ALSA: lola: Use DIV_ROUND_UP() instead of open-coding it
authorLars-Peter Clausen <lars@metafoo.de>
Wed, 23 Dec 2020 17:22:21 +0000 (18:22 +0100)
committerTakashi Iwai <tiwai@suse.de>
Fri, 25 Dec 2020 08:11:52 +0000 (09:11 +0100)
Use DIV_ROUND_UP() instead of open-coding it. This documents intent
and makes it more clear what is going on for the casual reviewer.

Generated using the following the Coccinelle semantic patch.

// <smpl>
@r1@
expression x;
constant C1;
constant C2;
@@
 (x + C1) / C2

@script:python@
C1 << r1.C1;
C2 << r1.C2;
@@
try:
if int(C1) != int(C2) - 1:
cocci.include_match(False)
except:
cocci.include_match(False)

@@
expression r1.x;
constant r1.C1;
constant r1.C2;
@@
-(((x) + C1) / C2)
+DIV_ROUND_UP(x, C2)
// </smpl>

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20201223172229.781-10-lars@metafoo.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lola/lola_clock.c

index fdb85f2..cafd30e 100644 (file)
@@ -135,7 +135,7 @@ int lola_init_clock_widget(struct lola *chip, int nid)
        }
 
        nitems = chip->clock.items;
-       nb_verbs = (nitems + 3) / 4;
+       nb_verbs = DIV_ROUND_UP(nitems, 4);
        idx = 0;
        idx_list = 0;
        for (i = 0; i < nb_verbs; i++) {