ALSA: usb-audio: Remove redundant assignment to len
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Tue, 27 Apr 2021 10:26:34 +0000 (18:26 +0800)
committerTakashi Iwai <tiwai@suse.de>
Wed, 28 Apr 2021 10:07:39 +0000 (12:07 +0200)
Variable len is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

sound/usb/mixer.c:2713:3: warning: Value stored to 'len' is never read
[clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Link: https://lore.kernel.org/r/1619519194-57806-1-git-send-email-jiapeng.chong@linux.alibaba.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/usb/mixer.c

index 2faf576..428d581 100644 (file)
@@ -2726,7 +2726,6 @@ static int parse_audio_selector_unit(struct mixer_build *state, int unitid,
 #define MAX_ITEM_NAME_LEN      64
        for (i = 0; i < desc->bNrInPins; i++) {
                struct usb_audio_term iterm;
-               len = 0;
                namelist[i] = kmalloc(MAX_ITEM_NAME_LEN, GFP_KERNEL);
                if (!namelist[i]) {
                        err = -ENOMEM;