pinctrl: renesas: rzg2l: Use spin_{lock,unlock}_irq{save,restore}
authorClaudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Wed, 22 May 2024 05:54:21 +0000 (08:54 +0300)
committerGeert Uytterhoeven <geert+renesas@glider.be>
Mon, 27 May 2024 15:13:31 +0000 (17:13 +0200)
On PREEMPT_RT kernels the spinlock_t maps to an rtmutex. Using
raw_spin_lock_irqsave()/raw_spin_unlock_irqrestore() on
&pctrl->lock.rlock breaks the PREEMPT_RT builds. To fix this use
spin_lock_irqsave()/spin_unlock_irqrestore() on &pctrl->lock.

Fixes: 02cd2d3be1c3 ("pinctrl: renesas: rzg2l: Configure the interrupt type on resume")
Reported-by: Diederik de Haas <didi.debian@cknow.org>
Closes: https://lore.kernel.org/all/131999629.KQPSlr0Zke@bagend
Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20240522055421.2842689-1-claudiu.beznea.uj@bp.renesas.com
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pinctrl/renesas/pinctrl-rzg2l.c

index c3256bf..60be78d 100644 (file)
@@ -2071,11 +2071,11 @@ static void rzg2l_gpio_irq_restore(struct rzg2l_pinctrl *pctrl)
                 * This has to be atomically executed to protect against a concurrent
                 * interrupt.
                 */
-               raw_spin_lock_irqsave(&pctrl->lock.rlock, flags);
+               spin_lock_irqsave(&pctrl->lock, flags);
                ret = rzg2l_gpio_irq_set_type(data, irqd_get_trigger_type(data));
                if (!ret && !irqd_irq_disabled(data))
                        rzg2l_gpio_irq_enable(data);
-               raw_spin_unlock_irqrestore(&pctrl->lock.rlock, flags);
+               spin_unlock_irqrestore(&pctrl->lock, flags);
 
                if (ret)
                        dev_crit(pctrl->dev, "Failed to set IRQ type for virq=%u\n", virq);