io_uring: fix invalid error check after malloc
authorPavel Begunkov <asml.silence@gmail.com>
Sun, 25 Apr 2021 23:16:31 +0000 (00:16 +0100)
committerJens Axboe <axboe@kernel.dk>
Mon, 26 Apr 2021 12:50:35 +0000 (06:50 -0600)
Now we allocate io_mapped_ubuf instead of bvec, so we clearly have to
check its address after allocation.

Fixes: 41edf1a5ec967 ("io_uring: keep table of pointers to ubufs")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/d28eb1bc4384284f69dbce35b9f70c115ff6176f.1619392565.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
fs/io_uring.c

index eef3733..b65a253 100644 (file)
@@ -8265,7 +8265,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, struct iovec *iov,
                goto done;
 
        imu = kvmalloc(struct_size(imu, bvec, nr_pages), GFP_KERNEL);
-       if (!imu->bvec)
+       if (!imu)
                goto done;
 
        ret = 0;