staging: fsl-dpaa2: Switch from strlcpy to strscpy
authorKumar Kartikeya Dwivedi <memxor@gmail.com>
Sun, 31 Jan 2021 17:28:24 +0000 (22:58 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Feb 2021 16:16:06 +0000 (17:16 +0100)
strlcpy is marked as deprecated in Documentation/process/deprecated.rst,
and there is no functional difference when the caller expects truncation
(when not checking the return value). strscpy is relatively better as it
also avoids scanning the whole source string.

This silences the related checkpatch warnings from:
5dbdb2d87c29 ("checkpatch: prefer strscpy to strlcpy")

Signed-off-by: Kumar Kartikeya Dwivedi <memxor@gmail.com>
Link: https://lore.kernel.org/r/20210131172838.146706-4-memxor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c

index d7f4ed1..0af2e99 100644 (file)
@@ -38,19 +38,19 @@ static void dpaa2_switch_get_drvinfo(struct net_device *netdev,
        u16 version_major, version_minor;
        int err;
 
-       strlcpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
+       strscpy(drvinfo->driver, KBUILD_MODNAME, sizeof(drvinfo->driver));
 
        err = dpsw_get_api_version(port_priv->ethsw_data->mc_io, 0,
                                   &version_major,
                                   &version_minor);
        if (err)
-               strlcpy(drvinfo->fw_version, "N/A",
+               strscpy(drvinfo->fw_version, "N/A",
                        sizeof(drvinfo->fw_version));
        else
                snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version),
                         "%u.%u", version_major, version_minor);
 
-       strlcpy(drvinfo->bus_info, dev_name(netdev->dev.parent->parent),
+       strscpy(drvinfo->bus_info, dev_name(netdev->dev.parent->parent),
                sizeof(drvinfo->bus_info));
 }