md: use current request time as base for ktime comparisons
authorPankaj Gupta <pankaj.gupta@cloud.ionos.com>
Wed, 11 Nov 2020 05:16:58 +0000 (06:16 +0100)
committerSong Liu <songliubraving@fb.com>
Mon, 30 Nov 2020 18:12:35 +0000 (10:12 -0800)
Request coalescing logic uses 'prev_flush_start' as base to
compare the current request start time. 'prev_flush_start' is
updated in other context.

This patch changes this by using ktime comparison base to
'req_start' for better readability of code.

Signed-off-by: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
drivers/md/md.c

index a0998ad..1a3a615 100644 (file)
@@ -667,10 +667,10 @@ bool md_flush_request(struct mddev *mddev, struct bio *bio)
         */
        wait_event_lock_irq(mddev->sb_wait,
                            !mddev->flush_bio ||
-                           ktime_after(mddev->prev_flush_start, req_start),
+                           ktime_before(req_start, mddev->prev_flush_start),
                            mddev->lock);
        /* new request after previous flush is completed */
-       if (!ktime_after(mddev->prev_flush_start, req_start)) {
+       if (ktime_after(req_start, mddev->prev_flush_start)) {
                WARN_ON(mddev->flush_bio);
                mddev->flush_bio = bio;
                bio = NULL;