nl80211: Uninitialized variable
authorBill Jordan <bjordan@rajant.com>
Fri, 10 Sep 2010 15:22:32 +0000 (11:22 -0400)
committerJohn W. Linville <linville@tuxdriver.com>
Tue, 14 Sep 2010 20:08:03 +0000 (16:08 -0400)
There is a path in nl80211_set_wiphy where result is tested but
uninitialized.

I am hitting this path when I attempt:

sh# iw dev wlan0 set channel 10
command failed: Unknown error 1069727332 (-1069727332)

Signed-off-by: William Jordan <bjordan@rajant.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/wireless/nl80211.c

index 85a23de..1d6ef24 100644 (file)
@@ -833,7 +833,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
        struct cfg80211_registered_device *rdev;
        struct net_device *netdev = NULL;
        struct wireless_dev *wdev;
-       int result, rem_txq_params = 0;
+       int result = 0, rem_txq_params = 0;
        struct nlattr *nl_txq_params;
        u32 changed;
        u8 retry_short = 0, retry_long = 0;