Input: synaptics - replace NOOP with suitable commentary
authorLee Jones <lee.jones@linaro.org>
Wed, 20 Jan 2021 02:43:11 +0000 (18:43 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 20 Jan 2021 03:03:11 +0000 (19:03 -0800)
Fixes the following W=1 kernel build warning(s):

 drivers/input/mouse/synaptics.c: In function ‘synaptics_process_packet’:
 drivers/input/mouse/synaptics.c:1110:6: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body]

Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20210114152323.2382283-2-lee.jones@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/mouse/synaptics.c

index 8fb7b43..ffad142 100644 (file)
@@ -1106,8 +1106,11 @@ static void synaptics_process_packet(struct psmouse *psmouse)
                                        num_fingers = hw.w + 2;
                                break;
                        case 2:
-                               if (SYN_MODEL_PEN(info->model_id))
-                                       ;   /* Nothing, treat a pen as a single finger */
+                               /*
+                                * SYN_MODEL_PEN(info->model_id): even if
+                                * the device supports pen, we treat it as
+                                * a single finger.
+                                */
                                break;
                        case 4 ... 15:
                                if (SYN_CAP_PALMDETECT(info->capabilities))