serial/imx: propagate error from of_alias_get_id instead of using -ENODEV
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Wed, 14 Dec 2011 20:26:51 +0000 (21:26 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 5 Jan 2012 00:30:34 +0000 (16:30 -0800)
A quick look at of_alias_get_id shows that in the error case it returns
-ENODEV, too, but still it's better style to propagate the value as is.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Grant Likely <grant.likely@secretlab.ca>
Cc: Jeremy Kerr <jeremy.kerr@canonical.com>
Cc: Jason Liu <jason.hui@linaro.org>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Acked-by: Jason Liu <jason.hui@linaro.org>
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/serial/imx.c

index ed6e144..2813f02 100644 (file)
@@ -1316,7 +1316,7 @@ static int serial_imx_probe_dt(struct imx_port *sport,
        ret = of_alias_get_id(np, "serial");
        if (ret < 0) {
                dev_err(&pdev->dev, "failed to get alias id, errno %d\n", ret);
-               return -ENODEV;
+               return ret;
        }
        sport->port.line = ret;