crypto: drivers - Drop sign/verify operations

The drivers aspeed-acry.c, hpre_crypto.c and jh7110-rsa.c purport to
implement sign/verify operations for raw (unpadded) "rsa".

But there is no such thing as message digests generally need to be
padded according to a predefined scheme (such as PSS or PKCS#1) to
match the size of the usually much larger RSA keys.

The bogus sign/verify operations defined by these drivers are never
called but block removal of sign/verify from akcipher_alg.  Drop them.

Signed-off-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c
index b4613bd..7a1e153 100644 (file)
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -601,8 +601,6 @@ static struct aspeed_acry_alg aspeed_acry_akcipher_algs[] = {
                .akcipher.base = {
                        .encrypt = aspeed_acry_rsa_enc,
                        .decrypt = aspeed_acry_rsa_dec,
-                       .sign = aspeed_acry_rsa_dec,
-                       .verify = aspeed_acry_rsa_enc,
                        .set_pub_key = aspeed_acry_rsa_set_pub_key,
                        .set_priv_key = aspeed_acry_rsa_set_priv_key,
                        .max_size = aspeed_acry_rsa_max_size,

diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
index c167dbd..2a29102 100644 (file)
--- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
@@ -2006,8 +2006,6 @@ static void hpre_curve25519_exit_tfm(struct crypto_kpp *tfm)
 }
 
 static struct akcipher_alg rsa = {
-       .sign = hpre_rsa_dec,
-       .verify = hpre_rsa_enc,
        .encrypt = hpre_rsa_enc,
        .decrypt = hpre_rsa_dec,
        .set_pub_key = hpre_rsa_setpubkey,

diff --git a/drivers/crypto/starfive/jh7110-rsa.c b/drivers/crypto/starfive/jh7110-rsa.c
index a778c48..d109c74 100644 (file)
--- a/drivers/crypto/starfive/jh7110-rsa.c
+++ b/drivers/crypto/starfive/jh7110-rsa.c
@@ -565,8 +565,6 @@ static void starfive_rsa_exit_tfm(struct crypto_akcipher *tfm)
 static struct akcipher_alg starfive_rsa = {
        .encrypt = starfive_rsa_enc,
        .decrypt = starfive_rsa_dec,
-       .sign = starfive_rsa_dec,
-       .verify = starfive_rsa_enc,
        .set_pub_key = starfive_rsa_set_pub_key,
        .set_priv_key = starfive_rsa_set_priv_key,
        .max_size = starfive_rsa_max_size,