soc: mediatek: mtk-svs: Call of_node_put(np) only once in svs_get_subsys_device()
authorMarkus Elfring <elfring@users.sourceforge.net>
Tue, 24 Sep 2024 18:00:09 +0000 (20:00 +0200)
committerAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Mon, 21 Oct 2024 14:00:52 +0000 (16:00 +0200)
An of_node_put(np) call was immediately used after a pointer check
for a of_find_device_by_node() call in this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/884f0a5d-e6d3-47dc-8a9e-201bb86b271f@web.de
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
drivers/soc/mediatek/mtk-svs.c

index 9a91298..7c349a9 100644 (file)
@@ -2133,14 +2133,12 @@ static struct device *svs_get_subsys_device(struct svs_platform *svsp,
        }
 
        pdev = of_find_device_by_node(np);
+       of_node_put(np);
        if (!pdev) {
-               of_node_put(np);
                dev_err(svsp->dev, "cannot find pdev by %s\n", node_name);
                return ERR_PTR(-ENXIO);
        }
 
-       of_node_put(np);
-
        return &pdev->dev;
 }