farsync: use DEFINE_SPINLOCK() for spinlock
authorLiu Jian <liujian56@huawei.com>
Fri, 26 Mar 2021 12:31:38 +0000 (20:31 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Mar 2021 22:25:44 +0000 (15:25 -0700)
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Liu Jian <liujian56@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/farsync.c

index 686a25d..5de71e4 100644 (file)
@@ -573,7 +573,7 @@ static DECLARE_TASKLET(fst_tx_task, fst_process_tx_work_q);
 static DECLARE_TASKLET(fst_int_task, fst_process_int_work_q);
 
 static struct fst_card_info *fst_card_array[FST_MAX_CARDS];
-static spinlock_t fst_work_q_lock;
+static DEFINE_SPINLOCK(fst_work_q_lock);
 static u64 fst_work_txq;
 static u64 fst_work_intq;
 
@@ -2648,7 +2648,6 @@ fst_init(void)
 
        for (i = 0; i < FST_MAX_CARDS; i++)
                fst_card_array[i] = NULL;
-       spin_lock_init(&fst_work_q_lock);
        return pci_register_driver(&fst_driver);
 }