xfs: simplify if-else condition in xfs_reflink_trim_around_shared
authorZeng Heng <zengheng4@huawei.com>
Sun, 18 Sep 2022 20:50:14 +0000 (06:50 +1000)
committerDave Chinner <david@fromorbit.com>
Sun, 18 Sep 2022 20:50:14 +0000 (06:50 +1000)
"else" is not generally useful after a return,
so remove it for clean code.

There is no logical changes.

Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_reflink.c

index 251f20d..93bdd25 100644 (file)
@@ -200,7 +200,9 @@ xfs_reflink_trim_around_shared(
        if (fbno == NULLAGBLOCK) {
                /* No shared blocks at all. */
                return 0;
-       } else if (fbno == agbno) {
+       }
+
+       if (fbno == agbno) {
                /*
                 * The start of this extent is shared.  Truncate the
                 * mapping at the end of the shared region so that a
@@ -210,16 +212,16 @@ xfs_reflink_trim_around_shared(
                irec->br_blockcount = flen;
                *shared = true;
                return 0;
-       } else {
-               /*
-                * There's a shared extent midway through this extent.
-                * Truncate the mapping at the start of the shared
-                * extent so that a subsequent iteration starts at the
-                * start of the shared region.
-                */
-               irec->br_blockcount = fbno - agbno;
-               return 0;
        }
+
+       /*
+        * There's a shared extent midway through this extent.
+        * Truncate the mapping at the start of the shared
+        * extent so that a subsequent iteration starts at the
+        * start of the shared region.
+        */
+       irec->br_blockcount = fbno - agbno;
+       return 0;
 }
 
 int