drm/i915/bios: set default backlight controller index
authorJani Nikula <jani.nikula@intel.com>
Tue, 7 Feb 2023 11:16:26 +0000 (13:16 +0200)
committerJani Nikula <jani.nikula@intel.com>
Wed, 8 Feb 2023 11:16:59 +0000 (13:16 +0200)
With backlight controller set to -1 in intel_panel_init_alloc() to
distinguish uninitialized values, and controller later being set only if
it's present in VBT, we can end up with -1 for the controller:

    [drm:intel_bios_init_panel [i915]] VBT backlight PWM modulation
    frequency 200 Hz, active high, min brightness 0, level 255,
    controller 4294967295

There's no harm if it happens on platforms that ignore controller due to
only one backlight controller being present, like on VLV above, but play
it safe.

Fixes: bf38bba3e7d6 ("drm/i915: Try to use the correct power sequencer intiially on bxt/glk")
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230207111626.1839645-1-jani.nikula@intel.com
drivers/gpu/drm/i915/display/intel_bios.c

index 1cd8af8..04b8464 100644 (file)
@@ -1033,6 +1033,7 @@ parse_lfp_backlight(struct drm_i915_private *i915,
        }
 
        panel->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI;
+       panel->vbt.backlight.controller = 0;
        if (i915->display.vbt.version >= 191) {
                size_t exp_size;