net: wwan: t7xx: Change PM_AUTOSUSPEND_MS to 5000
authorJack Wu <wojackbb@gmail.com>
Thu, 14 Nov 2024 10:20:02 +0000 (18:20 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 19 Nov 2024 02:38:20 +0000 (18:38 -0800)
Because optimizing the power consumption of t7XX,
change auto suspend time to 5000.

The Tests uses a script to loop through the power_state
of t7XX.
(for example: /sys/bus/pci/devices/0000\:72\:00.0/power_state)

* If Auto suspend is 20 seconds,
  test script show power_state have 0~5% of the time was in D3 state
  when host don't have data packet transmission.

* Changed auto suspend time to 5 seconds,
  test script show power_state have 50%~80% of the time was in D3 state
  when host don't have data packet transmission.

We tested Fibocom FM350 and our products using the t7xx and they all
benefited from this.

Signed-off-by: Jack Wu <wojackbb@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Reviewed-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
Link: https://patch.msgid.link/20241114102002.481081-1-wojackbb@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/wwan/t7xx/t7xx_pci.c

index 7b8c17b..8381b0d 100644 (file)
@@ -49,7 +49,7 @@
 #define T7XX_INIT_TIMEOUT              20
 #define PM_SLEEP_DIS_TIMEOUT_MS                20
 #define PM_ACK_TIMEOUT_MS              1500
-#define PM_AUTOSUSPEND_MS              20000
+#define PM_AUTOSUSPEND_MS              5000
 #define PM_RESOURCE_POLL_TIMEOUT_US    10000
 #define PM_RESOURCE_POLL_STEP_US       100