staging: r8188eu: remove ODM_RT_TRACE calls from hal/odm_RegConfig8188E.c

Remove ODM_RT_TRACE calls from hal/odm_RegConfig8188E.c, as by removing these
calls in this file and others, we can ultimately then remove the macro
definition itself, which does not follow best practice.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210731003937.68615-11-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
index 1a20552..ec8158e 100644 (file)
--- a/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
+++ b/drivers/staging/r8188eu/hal/odm_RegConfig8188E.c
@@ -32,7 +32,6 @@ void odm_ConfigRF_RadioA_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data
        u32 maskforPhySet = (u32)(content&0xE000);
 
        odm_ConfigRFReg_8188E(pDM_Odm, Addr, Data, RF_PATH_A, Addr|maskforPhySet);
-       ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_TRACE, ("===> ODM_ConfigRFWithHeaderFile: [RadioA] %08X %08X\n", Addr, Data));
 }
 
 void odm_ConfigRF_RadioB_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data)
@@ -41,14 +40,11 @@ void odm_ConfigRF_RadioB_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Data
        u32 maskforPhySet = (u32)(content&0xE000);
 
        odm_ConfigRFReg_8188E(pDM_Odm, Addr, Data, RF_PATH_B, Addr|maskforPhySet);
-
-       ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_TRACE, ("===> ODM_ConfigRFWithHeaderFile: [RadioB] %08X %08X\n", Addr, Data));
 }
 
 void odm_ConfigMAC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u8 Data)
 {
        ODM_Write1Byte(pDM_Odm, Addr, Data);
-       ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_TRACE, ("===> ODM_ConfigMACWithHeaderFile: [MAC_REG] %08X %08X\n", Addr, Data));
 }
 
 void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask, u32 Data)
@@ -56,33 +52,25 @@ void odm_ConfigBB_AGC_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask
        ODM_SetBBReg(pDM_Odm, Addr, Bitmask, Data);
        /*  Add 1us delay between BB/RF register setting. */
        ODM_delay_us(1);
-
-       ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_TRACE,
-                    ("===> ODM_ConfigBBWithHeaderFile: [AGC_TAB] %08X %08X\n",
-                    Addr, Data));
 }
 
 void odm_ConfigBB_PHY_REG_PG_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr,
                                   u32 Bitmask, u32 Data)
 {
-       if (Addr == 0xfe) {
+       if (Addr == 0xfe)
                ODM_sleep_ms(50);
-       } else if (Addr == 0xfd) {
+       else if (Addr == 0xfd)
                ODM_delay_ms(5);
-       } else if (Addr == 0xfc) {
+       else if (Addr == 0xfc)
                ODM_delay_ms(1);
-       } else if (Addr == 0xfb) {
+       else if (Addr == 0xfb)
                ODM_delay_us(50);
-       } else if (Addr == 0xfa) {
+       else if (Addr == 0xfa)
                ODM_delay_us(5);
-       } else if (Addr == 0xf9) {
+       else if (Addr == 0xf9)
                ODM_delay_us(1);
-       } else {
-               ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_LOUD,
-                            ("===> @@@@@@@ ODM_ConfigBBWithHeaderFile: [PHY_REG] %08X %08X %08X\n",
-                            Addr, Bitmask, Data));
+       else
                storePwrIndexDiffRateOffset(pDM_Odm->Adapter, Addr, Bitmask, Data);
-       }
 }
 
 void odm_ConfigBB_PHY_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask, u32 Data)
@@ -106,8 +94,5 @@ void odm_ConfigBB_PHY_8188E(struct odm_dm_struct *pDM_Odm, u32 Addr, u32 Bitmask
 
                /*  Add 1us delay between BB/RF register setting. */
                ODM_delay_us(1);
-               ODM_RT_TRACE(pDM_Odm, ODM_COMP_INIT, ODM_DBG_TRACE,
-                            ("===> ODM_ConfigBBWithHeaderFile: [PHY_REG] %08X %08X\n",
-                            Addr, Data));
        }
 }