Merge tag 'asoc-v5.16' of https://git.kernel.org/pub/scm/linux/kernel/git/broonie...
authorTakashi Iwai <tiwai@suse.de>
Mon, 1 Nov 2021 15:58:27 +0000 (16:58 +0100)
committerTakashi Iwai <tiwai@suse.de>
Mon, 1 Nov 2021 15:58:27 +0000 (16:58 +0100)
ASoC: Updates for v5.16

This is an unusually large set of updates, mostly a large crop of
unusually big drivers coupled with extensive overhauls of existing code.
There's a SH change here for the DAI format terminology, the change is
straightforward and the SH maintainers don't seem very active.

 - A new version of the audio graph card which supports a wider range of
   systems.
 - Move of the Cirrus DSP framework into drivers/firmware to allow for
   future use by non-audio DSPs.
 - Several conversions to YAML DT bindings.
 - Continuing cleanups to the SOF and Intel code.
 - A very big overhaul of the cs42l42 driver, correcting many problems.
 - Support for AMD Vangogh and Yelow Cap, Cirrus CS35L41, Maxim
   MAX98520 and MAX98360A, Mediatek MT8195, Nuvoton NAU8821, nVidia
   Tegra210, NXP i.MX8ULP, Qualcomm AudioReach, Realtek ALC5682I-VS,
   RT5682S, and RT9120 and Rockchip RV1126 and RK3568

1908 files changed:
CREDITS
Documentation/admin-guide/README.rst
Documentation/admin-guide/cgroup-v2.rst
Documentation/admin-guide/kernel-parameters.txt
Documentation/core-api/irq/irq-domain.rst
Documentation/devicetree/bindings/arm/tegra.yaml
Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml
Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml
Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt
Documentation/devicetree/bindings/display/panel/ilitek,ili9341.yaml
Documentation/devicetree/bindings/interconnect/qcom,sdm660.yaml
Documentation/devicetree/bindings/media/i2c/ovti,ov5647.yaml
Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx335.yaml
Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
Documentation/devicetree/bindings/mmc/snps,dwcmshc-sdhci.yaml
Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
Documentation/devicetree/bindings/net/dsa/marvell.txt
Documentation/devicetree/bindings/net/nxp,dwmac-imx.yaml
Documentation/devicetree/bindings/net/snps,dwmac.yaml
Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt [deleted file]
Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/amlogic,t9015.yaml
Documentation/devicetree/bindings/sound/audio-graph-card2.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/bt-sco.txt [deleted file]
Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/cs42l42.txt
Documentation/devicetree/bindings/sound/linux,bt-sco.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/max9892x.txt
Documentation/devicetree/bindings/sound/maxim,max98520.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/name-prefix.txt [deleted file]
Documentation/devicetree/bindings/sound/name-prefix.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nau8821.txt [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nvidia,tegra186-dspk.yaml
Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml
Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nvidia,tegra210-dmic.yaml
Documentation/devicetree/bindings/sound/nvidia,tegra210-i2s.yaml
Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/nxp,tfa989x.yaml
Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml
Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml
Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
Documentation/devicetree/bindings/sound/qcom,q6afe.txt
Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/qcom,q6asm.txt
Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-ports.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/richtek,rt9120.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/rockchip,pdm.txt [deleted file]
Documentation/devicetree/bindings/sound/rockchip,pdm.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/rt5659.txt
Documentation/devicetree/bindings/sound/simple-amplifier.txt [deleted file]
Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/simple-audio-mux.yaml
Documentation/devicetree/bindings/sound/socionext,uniphier-aio.yaml
Documentation/devicetree/bindings/sound/socionext,uniphier-evea.yaml
Documentation/devicetree/bindings/sound/spdif-transmitter.txt [deleted file]
Documentation/devicetree/bindings/sound/test-component.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/wlf,wm8962.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/wlf,wm8978.yaml [new file with mode: 0644]
Documentation/devicetree/bindings/sound/wm8962.txt [deleted file]
Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml
Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml [new file with mode: 0644]
Documentation/filesystems/ntfs3.rst
Documentation/gpu/amdgpu.rst
Documentation/gpu/drm-internals.rst
Documentation/hwmon/k10temp.rst
Documentation/networking/device_drivers/ethernet/intel/ice.rst
Documentation/networking/dsa/sja1105.rst
Documentation/process/changes.rst
Documentation/sound/alsa-configuration.rst
Documentation/sound/soc/codec.rst
Documentation/translations/zh_CN/admin-guide/README.rst
Documentation/translations/zh_TW/admin-guide/README.rst
Documentation/userspace-api/vduse.rst
MAINTAINERS
Makefile
arch/alpha/Kconfig
arch/alpha/include/asm/asm-prototypes.h
arch/alpha/include/asm/io.h
arch/alpha/include/asm/jensen.h
arch/alpha/include/asm/setup.h [new file with mode: 0644]
arch/alpha/include/uapi/asm/setup.h
arch/alpha/kernel/sys_jensen.c
arch/alpha/lib/Makefile
arch/alpha/lib/udiv-qrnnd.S [new file with mode: 0644]
arch/alpha/math-emu/Makefile
arch/alpha/math-emu/math.c
arch/alpha/math-emu/qrnnd.S [deleted file]
arch/arc/include/asm/pgtable.h
arch/arm/Kconfig
arch/arm/boot/dts/at91-sama5d27_som1_ek.dts
arch/arm/boot/dts/at91-sama7g5ek.dts
arch/arm/boot/dts/bcm2711-rpi-4-b.dts
arch/arm/boot/dts/bcm2711.dtsi
arch/arm/boot/dts/bcm2835-common.dtsi
arch/arm/boot/dts/bcm283x.dtsi
arch/arm/boot/dts/imx53-m53menlo.dts
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
arch/arm/boot/dts/imx6qdl-pico.dtsi
arch/arm/boot/dts/imx6sx-sdb.dts
arch/arm/boot/dts/imx6ul-14x14-evk.dtsi
arch/arm/boot/dts/omap3430-sdp.dts
arch/arm/boot/dts/qcom-apq8064.dtsi
arch/arm/boot/dts/sama7g5.dtsi
arch/arm/boot/dts/spear3xx.dtsi
arch/arm/boot/dts/vexpress-v2m-rs1.dtsi
arch/arm/boot/dts/vexpress-v2m.dtsi
arch/arm/boot/dts/vexpress-v2p-ca15-tc1.dts
arch/arm/boot/dts/vexpress-v2p-ca15_a7.dts
arch/arm/boot/dts/vexpress-v2p-ca5s.dts
arch/arm/boot/dts/vexpress-v2p-ca9.dts
arch/arm/common/sharpsl_param.c
arch/arm/configs/gemini_defconfig
arch/arm/configs/imx_v6_v7_defconfig
arch/arm/configs/multi_v7_defconfig
arch/arm/configs/oxnas_v6_defconfig
arch/arm/configs/shmobile_defconfig
arch/arm/kernel/signal.c
arch/arm/mach-at91/pm.c
arch/arm/mach-at91/pm_suspend.S
arch/arm/mach-dove/include/mach/uncompress.h
arch/arm/mach-imx/mach-imx6q.c
arch/arm/mach-imx/pm-imx6.c
arch/arm/mach-imx/src.c
arch/arm/mach-omap1/include/mach/memory.h
arch/arm/mach-omap1/usb.c
arch/arm/mach-omap2/Kconfig
arch/arm/mach-omap2/omap_hwmod.c
arch/arm/net/bpf_jit_32.c
arch/arm64/Kconfig
arch/arm64/boot/dts/arm/foundation-v8.dtsi
arch/arm64/boot/dts/arm/fvp-base-revc.dts
arch/arm64/boot/dts/arm/juno-base.dtsi
arch/arm64/boot/dts/arm/juno-motherboard.dtsi
arch/arm64/boot/dts/arm/rtsm_ve-aemv8a.dts
arch/arm64/boot/dts/arm/rtsm_ve-motherboard-rs2.dtsi
arch/arm64/boot/dts/arm/rtsm_ve-motherboard.dtsi
arch/arm64/boot/dts/arm/vexpress-v2f-1xv7-ca53x2.dts
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi
arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
arch/arm64/boot/dts/freescale/imx8mm-evk.dts
arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
arch/arm64/boot/dts/freescale/imx8mm-venice-gw7902.dts
arch/arm64/boot/dts/freescale/imx8mn-beacon-som.dtsi
arch/arm64/boot/dts/freescale/imx8mn-venice-gw7902.dts
arch/arm64/boot/dts/freescale/imx8mp-phycore-som.dtsi
arch/arm64/boot/dts/freescale/imx8mq-evk.dts
arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
arch/arm64/boot/dts/qcom/ipq8074.dtsi
arch/arm64/boot/dts/qcom/pm8150.dtsi
arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
arch/arm64/boot/dts/qcom/sc7280.dtsi
arch/arm64/boot/dts/qcom/sdm630.dtsi
arch/arm64/boot/dts/qcom/sdm845.dtsi
arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts
arch/arm64/configs/defconfig
arch/arm64/include/asm/acpi.h
arch/arm64/include/asm/assembler.h
arch/arm64/include/asm/mte.h
arch/arm64/include/asm/string.h
arch/arm64/kernel/acpi.c
arch/arm64/kernel/cpufeature.c
arch/arm64/kernel/fpsimd.c
arch/arm64/kernel/mte.c
arch/arm64/kernel/process.c
arch/arm64/kernel/signal.c
arch/arm64/kvm/hyp/nvhe/Makefile
arch/arm64/kvm/perf.c
arch/arm64/kvm/pmu-emul.c
arch/arm64/lib/strcmp.S
arch/arm64/lib/strncmp.S
arch/arm64/mm/hugetlbpage.c
arch/csky/Kconfig
arch/csky/include/asm/bitops.h
arch/csky/kernel/ptrace.c
arch/csky/kernel/signal.c
arch/ia64/Kconfig
arch/m68k/68000/entry.S
arch/m68k/Kconfig
arch/m68k/coldfire/entry.S
arch/m68k/include/asm/processor.h
arch/m68k/include/asm/raw_io.h
arch/m68k/include/asm/segment.h [deleted file]
arch/m68k/include/asm/thread_info.h
arch/m68k/include/asm/tlbflush.h
arch/m68k/include/asm/traps.h
arch/m68k/include/asm/uaccess.h
arch/m68k/kernel/asm-offsets.c
arch/m68k/kernel/entry.S
arch/m68k/kernel/process.c
arch/m68k/kernel/signal.c
arch/m68k/kernel/traps.c
arch/m68k/mac/misc.c
arch/m68k/mm/cache.c
arch/m68k/mm/init.c
arch/m68k/mm/kmap.c
arch/m68k/mm/memory.c
arch/m68k/mm/motorola.c
arch/m68k/mvme147/config.c
arch/m68k/mvme16x/config.c
arch/m68k/sun3/config.c
arch/m68k/sun3/mmu_emu.c
arch/m68k/sun3/sun3ints.c
arch/m68k/sun3x/prom.c
arch/mips/Kconfig
arch/mips/include/asm/mips-cps.h
arch/mips/kernel/signal.c
arch/mips/net/bpf_jit.c
arch/nios2/Kconfig.debug
arch/nios2/kernel/setup.c
arch/parisc/Kconfig
arch/parisc/include/asm/page.h
arch/parisc/lib/iomap.c
arch/powerpc/boot/Makefile
arch/powerpc/boot/dts/fsl/t1023rdb.dts
arch/powerpc/include/asm/asm-const.h
arch/powerpc/include/asm/book3s/32/kup.h
arch/powerpc/include/asm/code-patching.h
arch/powerpc/include/asm/interrupt.h
arch/powerpc/include/asm/security_features.h
arch/powerpc/kernel/dma-iommu.c
arch/powerpc/kernel/exceptions-64s.S
arch/powerpc/kernel/interrupt.c
arch/powerpc/kernel/interrupt_64.S
arch/powerpc/kernel/irq.c
arch/powerpc/kernel/mce.c
arch/powerpc/kernel/security.c
arch/powerpc/kernel/signal.c
arch/powerpc/kernel/traps.c
arch/powerpc/kvm/book3s_hv_rmhandlers.S
arch/powerpc/lib/code-patching.c
arch/powerpc/net/bpf_jit.h
arch/powerpc/net/bpf_jit64.h
arch/powerpc/net/bpf_jit_comp.c
arch/powerpc/net/bpf_jit_comp32.c
arch/powerpc/net/bpf_jit_comp64.c
arch/powerpc/platforms/pseries/eeh_pseries.c
arch/powerpc/platforms/pseries/msi.c
arch/powerpc/sysdev/xics/xics-common.c
arch/powerpc/sysdev/xive/common.c
arch/riscv/Kconfig
arch/riscv/include/asm/syscall.h
arch/riscv/include/asm/vdso.h
arch/riscv/include/uapi/asm/unistd.h
arch/riscv/kernel/syscall_table.c
arch/riscv/kernel/vdso.c
arch/riscv/kernel/vdso/vdso.lds.S
arch/riscv/mm/cacheflush.c
arch/s390/Kconfig
arch/s390/Makefile
arch/s390/configs/debug_defconfig
arch/s390/configs/defconfig
arch/s390/include/asm/ccwgroup.h
arch/s390/include/asm/pci.h
arch/s390/kvm/interrupt.c
arch/s390/kvm/kvm-s390.c
arch/s390/kvm/kvm-s390.h
arch/s390/lib/string.c
arch/s390/net/bpf_jit_comp.c
arch/s390/pci/pci.c
arch/s390/pci/pci_event.c
arch/s390/pci/pci_mmio.c
arch/sh/boards/mach-ecovec24/setup.c
arch/sh/boards/mach-se/7724/setup.c
arch/sh/boot/Makefile
arch/sh/include/asm/pgtable-3level.h
arch/sparc/kernel/ioport.c
arch/sparc/kernel/mdesc.c
arch/sparc/lib/iomap.c
arch/x86/Kconfig
arch/x86/Makefile_32.cpu
arch/x86/crypto/sm4-aesni-avx-asm_64.S
arch/x86/events/core.c
arch/x86/events/intel/core.c
arch/x86/events/msr.c
arch/x86/hyperv/hv_apic.c
arch/x86/include/asm/entry-common.h
arch/x86/include/asm/kvm_page_track.h
arch/x86/include/asm/kvmclock.h
arch/x86/include/asm/pkeys.h
arch/x86/include/asm/special_insns.h
arch/x86/include/asm/uaccess.h
arch/x86/include/asm/xen/pci.h
arch/x86/include/asm/xen/swiotlb-xen.h
arch/x86/kernel/cpu/common.c
arch/x86/kernel/cpu/mce/core.c
arch/x86/kernel/cpu/resctrl/core.c
arch/x86/kernel/early-quirks.c
arch/x86/kernel/fpu/signal.c
arch/x86/kernel/hpet.c
arch/x86/kernel/kvmclock.c
arch/x86/kernel/setup.c
arch/x86/kernel/setup_percpu.c
arch/x86/kernel/sev-shared.c
arch/x86/kvm/cpuid.c
arch/x86/kvm/emulate.c
arch/x86/kvm/hyperv.c
arch/x86/kvm/hyperv.h
arch/x86/kvm/ioapic.c
arch/x86/kvm/mmu/mmu.c
arch/x86/kvm/mmu/page_track.c
arch/x86/kvm/mmu/paging_tmpl.h
arch/x86/kvm/svm/nested.c
arch/x86/kvm/svm/sev.c
arch/x86/kvm/svm/svm.c
arch/x86/kvm/svm/svm.h
arch/x86/kvm/vmx/evmcs.c
arch/x86/kvm/vmx/nested.c
arch/x86/kvm/vmx/vmx.c
arch/x86/kvm/vmx/vmx.h
arch/x86/kvm/x86.c
arch/x86/lib/insn.c
arch/x86/mm/fault.c
arch/x86/mm/init_64.c
arch/x86/mm/kasan_init_64.c
arch/x86/mm/numa.c
arch/x86/mm/numa_emulation.c
arch/x86/mm/pat/memtype.c
arch/x86/net/bpf_jit_comp.c
arch/x86/pci/xen.c
arch/x86/platform/olpc/olpc.c
arch/x86/platform/pvh/enlighten.c
arch/x86/xen/Kconfig
arch/x86/xen/Makefile
arch/x86/xen/enlighten.c
arch/x86/xen/enlighten_pv.c
arch/x86/xen/enlighten_pvh.c
arch/x86/xen/mmu_pv.c
arch/x86/xen/pci-swiotlb-xen.c
arch/x86/xen/smp_pv.c
arch/x86/xen/xen-ops.h
arch/xtensa/include/asm/kmem_layout.h
arch/xtensa/kernel/irq.c
arch/xtensa/kernel/setup.c
arch/xtensa/mm/mmu.c
arch/xtensa/platforms/xtfpga/setup.c
block/bdev.c
block/bfq-cgroup.c
block/bfq-iosched.c
block/bio.c
block/blk-cgroup.c
block/blk-core.c
block/blk-integrity.c
block/blk-mq-debugfs.c
block/blk-mq-tag.c
block/blk-mq.c
block/blk.h
block/bsg.c
block/fops.c
block/genhd.c
block/kyber-iosched.c
drivers/Kconfig
drivers/acpi/arm64/gtdt.c
drivers/acpi/nfit/core.c
drivers/acpi/osl.c
drivers/acpi/x86/s2idle.c
drivers/android/binder.c
drivers/android/binder_internal.h
drivers/ata/libahci_platform.c
drivers/ata/pata_legacy.c
drivers/base/arch_numa.c
drivers/base/core.c
drivers/base/power/trace.c
drivers/base/swnode.c
drivers/base/test/Makefile
drivers/block/brd.c
drivers/block/nbd.c
drivers/block/rnbd/rnbd-clt-sysfs.c
drivers/block/virtio_blk.c
drivers/bus/Kconfig
drivers/bus/Makefile
drivers/bus/simple-pm-bus.c
drivers/bus/ti-sysc.c
drivers/clk/qcom/Kconfig
drivers/clk/qcom/gcc-sm6115.c
drivers/clk/renesas/r9a07g044-cpg.c
drivers/clk/renesas/rzg2l-cpg.c
drivers/clk/socfpga/clk-agilex.c
drivers/comedi/comedi_fops.c
drivers/cpufreq/cpufreq_governor_attr_set.c
drivers/cpufreq/intel_pstate.c
drivers/cpufreq/vexpress-spc-cpufreq.c
drivers/crypto/ccp/ccp-ops.c
drivers/edac/armada_xp_edac.c
drivers/edac/dmc520_edac.c
drivers/edac/synopsys_edac.c
drivers/firmware/Kconfig
drivers/firmware/Makefile
drivers/firmware/arm_ffa/bus.c
drivers/firmware/arm_scmi/Kconfig
drivers/firmware/arm_scmi/virtio.c
drivers/firmware/cirrus/Kconfig [new file with mode: 0644]
drivers/firmware/cirrus/Makefile [new file with mode: 0644]
drivers/firmware/cirrus/cs_dsp.c [new file with mode: 0644]
drivers/firmware/efi/cper.c
drivers/firmware/efi/libstub/fdt.c
drivers/firmware/efi/runtime-wrappers.c
drivers/fpga/dfl.c
drivers/fpga/ice40-spi.c
drivers/fpga/machxo2-spi.c
drivers/gpio/gpio-74x164.c
drivers/gpio/gpio-aspeed-sgpio.c
drivers/gpio/gpio-mockup.c
drivers/gpio/gpio-pca953x.c
drivers/gpio/gpio-rockchip.c
drivers/gpio/gpio-uniphier.c
drivers/gpio/gpiolib-acpi.c
drivers/gpu/drm/amd/amdgpu/amdgpu.h
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c
drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
drivers/gpu/drm/amd/amdgpu/amdgpu_gfx.c
drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ras_eeprom.h
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c
drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
drivers/gpu/drm/amd/amdgpu/gmc_v10_0.c
drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
drivers/gpu/drm/amd/amdgpu/sdma_v5_2.c
drivers/gpu/drm/amd/amdkfd/kfd_device.c
drivers/gpu/drm/amd/amdkfd/kfd_migrate.c
drivers/gpu/drm/amd/amdkfd/kfd_migrate.h
drivers/gpu/drm/amd/amdkfd/kfd_priv.h
drivers/gpu/drm/amd/amdkfd/kfd_svm.c
drivers/gpu/drm/amd/display/Kconfig
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.c
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_mst_types.h
drivers/gpu/drm/amd/display/amdgpu_dm/dc_fpu.c
drivers/gpu/drm/amd/display/dc/core/dc_link.c
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
drivers/gpu/drm/amd/display/dc/dce/dce_aux.c
drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c
drivers/gpu/drm/amd/display/dc/dcn10/dcn10_link_encoder.h
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dio_link_encoder.c
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_dio_link_encoder.h
drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
drivers/gpu/drm/amd/display/include/dal_asic_id.h
drivers/gpu/drm/amd/include/asic_reg/dpcs/dpcs_4_2_0_offset.h
drivers/gpu/drm/amd/pm/inc/smu11_driver_if_cyan_skillfish.h
drivers/gpu/drm/amd/pm/inc/smu_types.h
drivers/gpu/drm/amd/pm/inc/smu_v11_8_ppsmc.h
drivers/gpu/drm/amd/pm/powerplay/si_dpm.c
drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu11/cyan_skillfish_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu12/renoir_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu13/yellow_carp_ppt.c
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
drivers/gpu/drm/amd/pm/swsmu/smu_cmn.h
drivers/gpu/drm/drm_edid.c
drivers/gpu/drm/drm_fb_helper.c
drivers/gpu/drm/etnaviv/etnaviv_buffer.c
drivers/gpu/drm/etnaviv/etnaviv_gem.c
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
drivers/gpu/drm/etnaviv/etnaviv_gpu.c
drivers/gpu/drm/etnaviv/etnaviv_gpu.h
drivers/gpu/drm/etnaviv/etnaviv_iommu.c
drivers/gpu/drm/etnaviv/etnaviv_iommu_v2.c
drivers/gpu/drm/etnaviv/etnaviv_mmu.c
drivers/gpu/drm/etnaviv/etnaviv_mmu.h
drivers/gpu/drm/exynos/exynos5433_drm_decon.c
drivers/gpu/drm/exynos/exynos_drm_dsi.c
drivers/gpu/drm/exynos/exynos_drm_fimc.c
drivers/gpu/drm/exynos/exynos_drm_fimd.c
drivers/gpu/drm/exynos/exynos_drm_g2d.c
drivers/gpu/drm/exynos/exynos_drm_gsc.c
drivers/gpu/drm/exynos/exynos_drm_rotator.c
drivers/gpu/drm/exynos/exynos_drm_scaler.c
drivers/gpu/drm/exynos/exynos_hdmi.c
drivers/gpu/drm/hyperv/hyperv_drm.h
drivers/gpu/drm/hyperv/hyperv_drm_modeset.c
drivers/gpu/drm/hyperv/hyperv_drm_proto.c
drivers/gpu/drm/i915/Makefile
drivers/gpu/drm/i915/display/icl_dsi.c
drivers/gpu/drm/i915/display/intel_acpi.c
drivers/gpu/drm/i915/display/intel_audio.c
drivers/gpu/drm/i915/display/intel_bios.c
drivers/gpu/drm/i915/display/intel_bw.c
drivers/gpu/drm/i915/display/intel_ddi.c
drivers/gpu/drm/i915/display/intel_display.c
drivers/gpu/drm/i915/display/intel_dmc.c
drivers/gpu/drm/i915/display/intel_dp.c
drivers/gpu/drm/i915/display/intel_dp_link_training.c
drivers/gpu/drm/i915/display/intel_vbt_defs.h
drivers/gpu/drm/i915/gem/i915_gem_context.c
drivers/gpu/drm/i915/gem/i915_gem_shrinker.c
drivers/gpu/drm/i915/gem/i915_gem_ttm.c
drivers/gpu/drm/i915/gem/selftests/i915_gem_dmabuf.c
drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c
drivers/gpu/drm/i915/gt/intel_context.c
drivers/gpu/drm/i915/gt/intel_rps.c
drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h
drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h
drivers/gpu/drm/i915/gt/uc/intel_uc.c
drivers/gpu/drm/i915/gvt/scheduler.c
drivers/gpu/drm/i915/i915_reg.h
drivers/gpu/drm/i915/i915_request.c
drivers/gpu/drm/i915/intel_pm.c
drivers/gpu/drm/kmb/kmb_drv.c
drivers/gpu/drm/kmb/kmb_drv.h
drivers/gpu/drm/kmb/kmb_plane.c
drivers/gpu/drm/kmb/kmb_plane.h
drivers/gpu/drm/kmb/kmb_regs.h
drivers/gpu/drm/mediatek/mtk_drm_crtc.c
drivers/gpu/drm/msm/Kconfig
drivers/gpu/drm/msm/adreno/a3xx_gpu.c
drivers/gpu/drm/msm/adreno/a4xx_gpu.c
drivers/gpu/drm/msm/adreno/a6xx_gmu.c
drivers/gpu/drm/msm/adreno/a6xx_gmu.h
drivers/gpu/drm/msm/adreno/a6xx_gpu.c
drivers/gpu/drm/msm/adreno/a6xx_gpu.h
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c
drivers/gpu/drm/msm/dp/dp_display.c
drivers/gpu/drm/msm/dsi/dsi.c
drivers/gpu/drm/msm/dsi/dsi_host.c
drivers/gpu/drm/msm/dsi/phy/dsi_phy_14nm.c
drivers/gpu/drm/msm/dsi/phy/dsi_phy_28nm_8960.c
drivers/gpu/drm/msm/edp/edp_ctrl.c
drivers/gpu/drm/msm/msm_drv.c
drivers/gpu/drm/msm/msm_drv.h
drivers/gpu/drm/msm/msm_gem_submit.c
drivers/gpu/drm/msm/msm_gpu.h
drivers/gpu/drm/msm/msm_gpu_devfreq.c
drivers/gpu/drm/msm/msm_submitqueue.c
drivers/gpu/drm/nouveau/dispnv50/crc.c
drivers/gpu/drm/nouveau/dispnv50/head.c
drivers/gpu/drm/nouveau/include/nvif/class.h
drivers/gpu/drm/nouveau/include/nvkm/engine/fifo.h
drivers/gpu/drm/nouveau/nouveau_bo.c
drivers/gpu/drm/nouveau/nouveau_chan.c
drivers/gpu/drm/nouveau/nouveau_debugfs.c
drivers/gpu/drm/nouveau/nouveau_drm.c
drivers/gpu/drm/nouveau/nouveau_gem.c
drivers/gpu/drm/nouveau/nv84_fence.c
drivers/gpu/drm/nouveau/nvkm/engine/device/base.c
drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c
drivers/gpu/drm/nouveau/nvkm/engine/fifo/Kbuild
drivers/gpu/drm/nouveau/nvkm/engine/fifo/chang84.c
drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c [new file with mode: 0644]
drivers/gpu/drm/nouveau/nvkm/subdev/top/ga100.c
drivers/gpu/drm/panel/Kconfig
drivers/gpu/drm/panel/panel-abt-y030xx067a.c
drivers/gpu/drm/r128/ati_pcigart.c
drivers/gpu/drm/radeon/radeon_kms.c
drivers/gpu/drm/rcar-du/rcar_du_encoder.c
drivers/gpu/drm/rcar-du/rcar_lvds.c
drivers/gpu/drm/rcar-du/rcar_lvds.h
drivers/gpu/drm/rockchip/cdn-dp-core.c
drivers/gpu/drm/rockchip/rockchip_drm_vop.c
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.h
drivers/gpu/drm/sun4i/sun8i_hdmi_phy.c
drivers/gpu/drm/tegra/dc.c
drivers/gpu/drm/tegra/dc.h
drivers/gpu/drm/tegra/uapi.c
drivers/gpu/drm/ttm/ttm_pool.c
drivers/gpu/drm/vc4/vc4_hdmi.c
drivers/gpu/host1x/fence.c
drivers/hid/amd-sfh-hid/amd_sfh_pcie.c
drivers/hid/hid-apple.c
drivers/hid/hid-betopff.c
drivers/hid/hid-u2fzero.c
drivers/hid/wacom_wac.c
drivers/hv/ring_buffer.c
drivers/hwmon/k10temp.c
drivers/hwmon/ltc2947-core.c
drivers/hwmon/mlxreg-fan.c
drivers/hwmon/occ/common.c
drivers/hwmon/pmbus/ibm-cffps.c
drivers/hwmon/pmbus/mp2975.c
drivers/hwmon/tmp421.c
drivers/hwmon/w83791d.c
drivers/hwmon/w83792d.c
drivers/hwmon/w83793.c
drivers/hwtracing/coresight/coresight-syscfg.c
drivers/i2c/busses/i2c-mlxcpld.c
drivers/i2c/busses/i2c-mt65xx.c
drivers/i2c/i2c-core-acpi.c
drivers/iio/accel/fxls8962af-core.c
drivers/iio/adc/ad7192.c
drivers/iio/adc/ad7780.c
drivers/iio/adc/ad7793.c
drivers/iio/adc/aspeed_adc.c
drivers/iio/adc/max1027.c
drivers/iio/adc/mt6577_auxadc.c
drivers/iio/adc/rzg2l_adc.c
drivers/iio/adc/ti-adc128s052.c
drivers/iio/common/ssp_sensors/ssp_spi.c
drivers/iio/dac/ti-dac5571.c
drivers/iio/imu/adis16475.c
drivers/iio/imu/adis16480.c
drivers/iio/light/opt3001.c
drivers/iio/test/Makefile
drivers/infiniband/core/cma.c
drivers/infiniband/core/cma_priv.h
drivers/infiniband/hw/hfi1/ipoib_tx.c
drivers/infiniband/hw/hns/hns_roce_cq.c
drivers/infiniband/hw/hns/hns_roce_hw_v2.c
drivers/infiniband/hw/irdma/cm.c
drivers/infiniband/hw/irdma/hw.c
drivers/infiniband/hw/irdma/i40iw_if.c
drivers/infiniband/hw/irdma/main.h
drivers/infiniband/hw/irdma/user.h
drivers/infiniband/hw/irdma/utils.c
drivers/infiniband/hw/irdma/verbs.c
drivers/infiniband/hw/qib/qib_sysfs.c
drivers/infiniband/hw/usnic/usnic_ib.h
drivers/infiniband/hw/usnic/usnic_ib_main.c
drivers/infiniband/hw/usnic/usnic_ib_verbs.c
drivers/input/joystick/xpad.c
drivers/input/keyboard/snvs_pwrkey.c
drivers/input/touchscreen.c
drivers/input/touchscreen/resistive-adc-touch.c
drivers/interconnect/qcom/sdm660.c
drivers/iommu/Kconfig
drivers/iommu/apple-dart.c
drivers/iommu/arm/arm-smmu/Makefile
drivers/iommu/arm/arm-smmu/arm-smmu-impl.c
drivers/iommu/intel/dmar.c
drivers/ipack/devices/ipoctal.c
drivers/irqchip/Kconfig
drivers/irqchip/irq-armada-370-xp.c
drivers/irqchip/irq-gic-v3-its.c
drivers/irqchip/irq-gic.c
drivers/irqchip/irq-mbigen.c
drivers/irqchip/irq-renesas-rza1.c
drivers/isdn/capi/kcapi.c
drivers/isdn/hardware/mISDN/netjet.c
drivers/macintosh/smu.c
drivers/mcb/mcb-core.c
drivers/md/dm-clone-target.c
drivers/md/dm-rq.c
drivers/md/dm-verity-target.c
drivers/md/dm.c
drivers/md/md.c
drivers/media/platform/Kconfig
drivers/media/platform/s5p-jpeg/jpeg-core.c
drivers/media/platform/s5p-jpeg/jpeg-core.h
drivers/media/rc/ir_toy.c
drivers/misc/Kconfig
drivers/misc/bcm-vk/bcm_vk_tty.c
drivers/misc/cb710/sgbuf2.c
drivers/misc/eeprom/at25.c
drivers/misc/eeprom/eeprom_93xx46.c
drivers/misc/fastrpc.c
drivers/misc/gehc-achc.c
drivers/misc/genwqe/card_base.c
drivers/misc/habanalabs/common/command_submission.c
drivers/misc/habanalabs/common/hw_queue.c
drivers/misc/habanalabs/gaudi/gaudi.c
drivers/misc/habanalabs/gaudi/gaudi_security.c
drivers/misc/habanalabs/include/gaudi/asic_reg/gaudi_regs.h
drivers/misc/mei/hbm.c
drivers/misc/mei/hw-me-regs.h
drivers/misc/mei/pci-me.c
drivers/mmc/host/Kconfig
drivers/mmc/host/dw_mmc.c
drivers/mmc/host/meson-gx-mmc.c
drivers/mmc/host/renesas_sdhi_core.c
drivers/mmc/host/sdhci-of-at91.c
drivers/mtd/nand/raw/qcom_nandc.c
drivers/net/dsa/b53/b53_mdio.c
drivers/net/dsa/b53/b53_mmap.c
drivers/net/dsa/b53/b53_priv.h
drivers/net/dsa/b53/b53_spi.c
drivers/net/dsa/b53/b53_srab.c
drivers/net/dsa/bcm_sf2.c
drivers/net/dsa/dsa_loop.c
drivers/net/dsa/hirschmann/hellcreek.c
drivers/net/dsa/lan9303-core.c
drivers/net/dsa/lan9303.h
drivers/net/dsa/lan9303_i2c.c
drivers/net/dsa/lan9303_mdio.c
drivers/net/dsa/lantiq_gswip.c
drivers/net/dsa/microchip/ksz8795_spi.c
drivers/net/dsa/microchip/ksz8863_smi.c
drivers/net/dsa/microchip/ksz9477_i2c.c
drivers/net/dsa/microchip/ksz9477_spi.c
drivers/net/dsa/microchip/ksz_common.c
drivers/net/dsa/mt7530.c
drivers/net/dsa/mv88e6060.c
drivers/net/dsa/mv88e6xxx/chip.c
drivers/net/dsa/mv88e6xxx/chip.h
drivers/net/dsa/mv88e6xxx/devlink.c
drivers/net/dsa/mv88e6xxx/devlink.h
drivers/net/dsa/mv88e6xxx/global1.c
drivers/net/dsa/mv88e6xxx/port.c
drivers/net/dsa/mv88e6xxx/port.h
drivers/net/dsa/ocelot/felix.c
drivers/net/dsa/ocelot/felix.h
drivers/net/dsa/ocelot/felix_vsc9959.c
drivers/net/dsa/ocelot/seville_vsc9953.c
drivers/net/dsa/qca/ar9331.c
drivers/net/dsa/qca8k.c
drivers/net/dsa/realtek-smi-core.c
drivers/net/dsa/sja1105/sja1105_clocking.c
drivers/net/dsa/sja1105/sja1105_devlink.c
drivers/net/dsa/sja1105/sja1105_flower.c
drivers/net/dsa/sja1105/sja1105_main.c
drivers/net/dsa/sja1105/sja1105_mdio.c
drivers/net/dsa/sja1105/sja1105_ptp.c
drivers/net/dsa/sja1105/sja1105_ptp.h
drivers/net/dsa/sja1105/sja1105_spi.c
drivers/net/dsa/sja1105/sja1105_static_config.c
drivers/net/dsa/sja1105/sja1105_static_config.h
drivers/net/dsa/sja1105/sja1105_vl.c
drivers/net/dsa/sja1105/sja1105_vl.h
drivers/net/dsa/vitesse-vsc73xx-core.c
drivers/net/dsa/vitesse-vsc73xx-platform.c
drivers/net/dsa/vitesse-vsc73xx-spi.c
drivers/net/dsa/vitesse-vsc73xx.h
drivers/net/dsa/xrs700x/xrs700x.c
drivers/net/dsa/xrs700x/xrs700x.h
drivers/net/dsa/xrs700x/xrs700x_i2c.c
drivers/net/dsa/xrs700x/xrs700x_mdio.c
drivers/net/ethernet/3com/3c515.c
drivers/net/ethernet/8390/ne.c
drivers/net/ethernet/Kconfig
drivers/net/ethernet/amd/ni65.c
drivers/net/ethernet/aquantia/atlantic/aq_pci_func.c
drivers/net/ethernet/arc/Kconfig
drivers/net/ethernet/broadcom/bgmac-bcma.c
drivers/net/ethernet/broadcom/bgmac-platform.c
drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
drivers/net/ethernet/broadcom/bnxt/bnxt.c
drivers/net/ethernet/broadcom/bnxt/bnxt.h
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c
drivers/net/ethernet/broadcom/bnxt/bnxt_tc.c
drivers/net/ethernet/cadence/macb_pci.c
drivers/net/ethernet/freescale/enetc/enetc.c
drivers/net/ethernet/freescale/enetc/enetc_ierb.c
drivers/net/ethernet/freescale/enetc/enetc_ierb.h
drivers/net/ethernet/freescale/enetc/enetc_pf.c
drivers/net/ethernet/freescale/fec_main.c
drivers/net/ethernet/google/gve/gve.h
drivers/net/ethernet/google/gve/gve_main.c
drivers/net/ethernet/google/gve/gve_rx.c
drivers/net/ethernet/hisilicon/hns3/hnae3.h
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_dcb.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_tm.c
drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c
drivers/net/ethernet/hisilicon/hns_mdio.c
drivers/net/ethernet/i825xx/82596.c
drivers/net/ethernet/ibm/ibmvnic.c
drivers/net/ethernet/intel/Kconfig
drivers/net/ethernet/intel/e100.c
drivers/net/ethernet/intel/i40e/i40e_main.c
drivers/net/ethernet/intel/iavf/iavf_main.c
drivers/net/ethernet/intel/ice/ice.h
drivers/net/ethernet/intel/ice/ice_idc.c
drivers/net/ethernet/intel/ice/ice_ptp.c
drivers/net/ethernet/intel/igc/igc_main.c
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
drivers/net/ethernet/mediatek/mtk_ppe_offload.c
drivers/net/ethernet/mellanox/mlx4/en_netdev.c
drivers/net/ethernet/mellanox/mlx4/mlx4_en.h
drivers/net/ethernet/mellanox/mlx5/core/cq.c
drivers/net/ethernet/mellanox/mlx5/core/devlink.c
drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
drivers/net/ethernet/mellanox/mlx5/core/en.h
drivers/net/ethernet/mellanox/mlx5/core/en/hv_vhca_stats.c
drivers/net/ethernet/mellanox/mlx5/core/en/ptp.c
drivers/net/ethernet/mellanox/mlx5/core/en/ptp.h
drivers/net/ethernet/mellanox/mlx5/core/en/rep/bridge.c
drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
drivers/net/ethernet/mellanox/mlx5/core/en/rx_res.c
drivers/net/ethernet/mellanox/mlx5/core/en_ethtool.c
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
drivers/net/ethernet/mellanox/mlx5/core/en_rx.c
drivers/net/ethernet/mellanox/mlx5/core/en_stats.c
drivers/net/ethernet/mellanox/mlx5/core/esw/acl/egress_lgcy.c
drivers/net/ethernet/mellanox/mlx5/core/esw/acl/ingress_lgcy.c
drivers/net/ethernet/mellanox/mlx5/core/fs_core.c
drivers/net/ethernet/mellanox/mlx5/core/ipoib/ipoib.c
drivers/net/ethernet/mellanox/mlx5/core/lag.c
drivers/net/ethernet/mellanox/mlx5/core/lib/clock.c
drivers/net/ethernet/mellanox/mlx5/core/pci_irq.c
drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c
drivers/net/ethernet/mellanox/mlxsw/core_thermal.c
drivers/net/ethernet/micrel/Makefile
drivers/net/ethernet/micrel/ks8851_common.c
drivers/net/ethernet/microchip/encx24j600-regmap.c
drivers/net/ethernet/microchip/encx24j600.c
drivers/net/ethernet/microchip/encx24j600_hw.h
drivers/net/ethernet/microsoft/mana/hw_channel.c
drivers/net/ethernet/microsoft/mana/mana_en.c
drivers/net/ethernet/mscc/ocelot.c
drivers/net/ethernet/mscc/ocelot_devlink.c
drivers/net/ethernet/mscc/ocelot_mrp.c
drivers/net/ethernet/mscc/ocelot_net.c
drivers/net/ethernet/mscc/ocelot_vcap.c
drivers/net/ethernet/neterion/s2io.c
drivers/net/ethernet/netronome/nfp/flower/main.c
drivers/net/ethernet/netronome/nfp/flower/offload.c
drivers/net/ethernet/pensando/ionic/ionic_lif.c
drivers/net/ethernet/pensando/ionic/ionic_rx_filter.c
drivers/net/ethernet/pensando/ionic/ionic_stats.c
drivers/net/ethernet/qlogic/qed/qed_iwarp.c
drivers/net/ethernet/qlogic/qed/qed_main.c
drivers/net/ethernet/qlogic/qed/qed_mcp.c
drivers/net/ethernet/qlogic/qed/qed_roce.c
drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_init.c
drivers/net/ethernet/rdc/r6040.c
drivers/net/ethernet/sfc/efx_channels.c
drivers/net/ethernet/sfc/net_driver.h
drivers/net/ethernet/sfc/tx.c
drivers/net/ethernet/stmicro/stmmac/dwmac-generic.c
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
drivers/net/ethernet/stmicro/stmmac/dwmac1000_dma.c
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.c
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_dma.c
drivers/net/ethernet/stmicro/stmmac/hwif.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
drivers/net/ethernet/sun/Kconfig
drivers/net/hamradio/6pack.c
drivers/net/hamradio/Kconfig
drivers/net/hamradio/dmascc.c
drivers/net/ipa/Kconfig
drivers/net/ipa/ipa_table.c
drivers/net/mdio/mdio-ipq4019.c
drivers/net/mdio/mdio-mscc-miim.c
drivers/net/mhi_net.c
drivers/net/pcs/pcs-xpcs-nxp.c
drivers/net/pcs/pcs-xpcs.c
drivers/net/phy/bcm7xxx.c
drivers/net/phy/dp83640_reg.h
drivers/net/phy/mdio_bus.c
drivers/net/phy/mdio_device.c
drivers/net/phy/mxl-gpy.c
drivers/net/phy/phy_device.c
drivers/net/phy/phylink.c
drivers/net/phy/sfp.c
drivers/net/usb/Kconfig
drivers/net/usb/hso.c
drivers/net/usb/r8152.c
drivers/net/usb/smsc95xx.c
drivers/net/virtio_net.c
drivers/net/vxlan.c
drivers/net/wan/Makefile
drivers/net/wireless/ath/ath10k/Kconfig
drivers/net/wireless/ath/ath5k/Kconfig
drivers/net/wireless/ath/ath5k/led.c
drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
drivers/net/wireless/intel/iwlwifi/mvm/d3.c
drivers/net/wireless/intel/iwlwifi/mvm/time-event.c
drivers/net/wireless/intel/iwlwifi/pcie/drv.c
drivers/net/wireless/mac80211_hwsim.c
drivers/net/wireless/marvell/mwifiex/sta_tx.c
drivers/net/wireless/marvell/mwifiex/uap_txrx.c
drivers/net/xen-netback/netback.c
drivers/nfc/st-nci/spi.c
drivers/nvdimm/pmem.c
drivers/nvme/host/core.c
drivers/nvme/host/fc.c
drivers/nvme/host/multipath.c
drivers/nvme/host/nvme.h
drivers/nvme/host/pci.c
drivers/nvme/host/rdma.c
drivers/nvme/host/tcp.c
drivers/nvme/target/configfs.c
drivers/nvmem/Kconfig
drivers/nvmem/core.c
drivers/of/base.c
drivers/of/device.c
drivers/of/property.c
drivers/pci/Kconfig
drivers/pci/controller/pci-hyperv.c
drivers/pci/hotplug/s390_pci_hpc.c
drivers/pci/msi.c
drivers/pci/pci-acpi.c
drivers/pci/quirks.c
drivers/pci/vpd.c
drivers/perf/arm_pmu.c
drivers/pinctrl/core.c
drivers/pinctrl/pinctrl-amd.c
drivers/pinctrl/pinctrl-amd.h
drivers/pinctrl/pinctrl-rockchip.c
drivers/pinctrl/pinctrl-rockchip.h
drivers/pinctrl/qcom/Kconfig
drivers/pinctrl/qcom/pinctrl-sc7280.c
drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
drivers/platform/mellanox/mlxreg-io.c
drivers/platform/x86/amd-pmc.c
drivers/platform/x86/dell/Kconfig
drivers/platform/x86/gigabyte-wmi.c
drivers/platform/x86/intel/hid.c
drivers/platform/x86/intel/int1092/intel_sar.c
drivers/platform/x86/intel/int3472/intel_skl_int3472_discrete.c
drivers/platform/x86/intel/punit_ipc.c
drivers/platform/x86/intel_scu_ipc.c
drivers/platform/x86/lg-laptop.c
drivers/platform/x86/touchscreen_dmi.c
drivers/ptp/Kconfig
drivers/ptp/ptp_kvm_x86.c
drivers/ptp/ptp_pch.c
drivers/regulator/max14577-regulator.c
drivers/regulator/qcom-rpmh-regulator.c
drivers/rtc/rtc-cmos.c
drivers/s390/char/sclp_early.c
drivers/s390/cio/blacklist.c
drivers/s390/cio/ccwgroup.c
drivers/s390/cio/css.c
drivers/s390/cio/css.h
drivers/s390/crypto/ap_bus.c
drivers/s390/crypto/ap_queue.c
drivers/s390/crypto/vfio_ap_ops.c
drivers/s390/net/qeth_core.h
drivers/s390/net/qeth_core_main.c
drivers/s390/net/qeth_l2_main.c
drivers/s390/net/qeth_l3_main.c
drivers/scsi/arm/Kconfig
drivers/scsi/arm/acornscsi.c
drivers/scsi/arm/fas216.c
drivers/scsi/arm/queue.c
drivers/scsi/csiostor/csio_init.c
drivers/scsi/elx/efct/efct_lio.c
drivers/scsi/elx/efct/efct_scsi.c
drivers/scsi/elx/libefc/efc_device.c
drivers/scsi/elx/libefc/efc_fabric.c
drivers/scsi/libiscsi.c
drivers/scsi/lpfc/lpfc_attr.c
drivers/scsi/lpfc/lpfc_els.c
drivers/scsi/lpfc/lpfc_hw4.h
drivers/scsi/lpfc/lpfc_init.c
drivers/scsi/lpfc/lpfc_nvme.c
drivers/scsi/lpfc/lpfc_scsi.c
drivers/scsi/lpfc/lpfc_sli.c
drivers/scsi/megaraid/megaraid_sas_base.c
drivers/scsi/mpt3sas/mpt3sas_base.c
drivers/scsi/mpt3sas/mpt3sas_ctl.c
drivers/scsi/mpt3sas/mpt3sas_scsih.c
drivers/scsi/ncr53c8xx.c
drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_isr.c
drivers/scsi/scsi_transport_iscsi.c
drivers/scsi/sd.c
drivers/scsi/sd_zbc.c
drivers/scsi/ses.c
drivers/scsi/sr_ioctl.c
drivers/scsi/st.c
drivers/scsi/ufs/ufshcd-pci.c
drivers/scsi/ufs/ufshcd.c
drivers/scsi/ufs/ufshcd.h
drivers/scsi/ufs/ufshpb.c
drivers/scsi/virtio_scsi.c
drivers/soc/canaan/Kconfig
drivers/soc/qcom/Kconfig
drivers/soc/qcom/apr.c
drivers/soc/qcom/mdt_loader.c
drivers/soc/qcom/socinfo.c
drivers/soc/ti/omap_prm.c
drivers/spi/spi-atmel.c
drivers/spi/spi-bcm-qspi.c
drivers/spi/spi-mt65xx.c
drivers/spi/spi-mux.c
drivers/spi/spi-nxp-fspi.c
drivers/spi/spi-rockchip.c
drivers/spi/spi-tegra20-slink.c
drivers/spi/spi.c
drivers/spi/spidev.c
drivers/staging/greybus/uart.c
drivers/staging/media/atomisp/pci/hive_isp_css_common/host/input_system.c
drivers/staging/media/hantro/hantro_drv.c
drivers/staging/media/sunxi/cedrus/cedrus_video.c
drivers/staging/r8188eu/hal/hal_intf.c
drivers/staging/r8188eu/os_dep/ioctl_linux.c
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
drivers/target/target_core_configfs.c
drivers/target/target_core_pr.c
drivers/tee/optee/core.c
drivers/tee/optee/device.c
drivers/tee/optee/optee_private.h
drivers/tee/optee/shm_pool.c
drivers/thermal/intel/int340x_thermal/processor_thermal_device.c
drivers/thermal/qcom/tsens.c
drivers/thermal/thermal_core.c
drivers/thunderbolt/Makefile
drivers/tty/hvc/hvc_xen.c
drivers/tty/serial/8250/8250_omap.c
drivers/tty/serial/8250/Kconfig
drivers/tty/serial/mvebu-uart.c
drivers/tty/synclink_gt.c
drivers/tty/tty_ldisc.c
drivers/usb/cdns3/cdns3-gadget.c
drivers/usb/chipidea/ci_hdrc_imx.c
drivers/usb/class/cdc-acm.c
drivers/usb/class/cdc-acm.h
drivers/usb/class/cdc-wdm.c
drivers/usb/common/Kconfig
drivers/usb/core/hcd.c
drivers/usb/dwc2/gadget.c
drivers/usb/dwc2/hcd.c
drivers/usb/dwc3/core.c
drivers/usb/dwc3/gadget.c
drivers/usb/gadget/function/f_uac2.c
drivers/usb/gadget/function/u_audio.c
drivers/usb/gadget/udc/r8a66597-udc.c
drivers/usb/host/bcma-hcd.c
drivers/usb/host/ehci-hcd.c
drivers/usb/host/ohci-omap.c
drivers/usb/host/xhci-dbgtty.c
drivers/usb/host/xhci-pci.c
drivers/usb/host/xhci-ring.c
drivers/usb/host/xhci-tegra.c
drivers/usb/host/xhci.c
drivers/usb/host/xhci.h
drivers/usb/musb/musb_dsps.c
drivers/usb/musb/tusb6010.c
drivers/usb/serial/cp210x.c
drivers/usb/serial/mos7840.c
drivers/usb/serial/option.c
drivers/usb/serial/qcserial.c
drivers/usb/storage/unusual_devs.h
drivers/usb/storage/unusual_uas.h
drivers/usb/typec/tcpm/tcpci.c
drivers/usb/typec/tcpm/tcpm.c
drivers/usb/typec/tipd/core.c
drivers/vdpa/mlx5/net/mlx5_vnet.c
drivers/vdpa/vdpa_user/vduse_dev.c
drivers/vfio/pci/vfio_pci_core.c
drivers/vhost/net.c
drivers/vhost/vdpa.c
drivers/video/fbdev/Kconfig
drivers/video/fbdev/gbefb.c
drivers/virtio/virtio.c
drivers/watchdog/Kconfig
drivers/xen/Kconfig
drivers/xen/balloon.c
drivers/xen/gntdev.c
drivers/xen/privcmd.c
drivers/xen/swiotlb-xen.c
fs/9p/cache.c
fs/9p/fid.c
fs/9p/v9fs.c
fs/9p/vfs_addr.c
fs/9p/vfs_file.c
fs/9p/vfs_inode.c
fs/9p/vfs_inode_dotl.c
fs/afs/callback.c
fs/afs/cell.c
fs/afs/dir.c
fs/afs/dir_edit.c
fs/afs/dir_silly.c
fs/afs/file.c
fs/afs/fs_probe.c
fs/afs/fsclient.c
fs/afs/inode.c
fs/afs/internal.h
fs/afs/protocol_afs.h [new file with mode: 0644]
fs/afs/protocol_yfs.h
fs/afs/rotate.c
fs/afs/server.c
fs/afs/super.c
fs/afs/write.c
fs/binfmt_elf.c
fs/btrfs/ctree.h
fs/btrfs/dir-item.c
fs/btrfs/extent-tree.c
fs/btrfs/file-item.c
fs/btrfs/file.c
fs/btrfs/space-info.c
fs/btrfs/tree-log.c
fs/btrfs/verity.c
fs/btrfs/volumes.c
fs/buffer.c
fs/ceph/caps.c
fs/cifs/cache.c
fs/cifs/cifs_debug.c
fs/cifs/cifs_fs_sb.h
fs/cifs/cifs_ioctl.h
fs/cifs/cifs_spnego.c
fs/cifs/cifs_spnego.h
fs/cifs/cifs_unicode.c
fs/cifs/cifsacl.c
fs/cifs/cifsacl.h
fs/cifs/cifsencrypt.c
fs/cifs/cifsfs.c
fs/cifs/cifsfs.h
fs/cifs/cifsglob.h
fs/cifs/cifspdu.h
fs/cifs/cifsproto.h
fs/cifs/cifssmb.c
fs/cifs/connect.c
fs/cifs/dir.c
fs/cifs/dns_resolve.c
fs/cifs/dns_resolve.h
fs/cifs/export.c
fs/cifs/file.c
fs/cifs/fscache.c
fs/cifs/fscache.h
fs/cifs/inode.c
fs/cifs/ioctl.c
fs/cifs/link.c
fs/cifs/misc.c
fs/cifs/netmisc.c
fs/cifs/ntlmssp.h
fs/cifs/readdir.c
fs/cifs/rfc1002pdu.h
fs/cifs/sess.c
fs/cifs/smb2file.c
fs/cifs/smb2glob.h
fs/cifs/smb2inode.c
fs/cifs/smb2misc.c
fs/cifs/smb2pdu.c
fs/cifs/smb2pdu.h
fs/cifs/smb2proto.h
fs/cifs/smb2status.h
fs/cifs/smb2transport.c
fs/cifs/smberr.h
fs/cifs/transport.c
fs/cifs/winucase.c
fs/cifs/xattr.c
fs/debugfs/inode.c
fs/erofs/inode.c
fs/erofs/zmap.c
fs/ext2/balloc.c
fs/ext4/dir.c
fs/ext4/ext4.h
fs/ext4/extents.c
fs/ext4/fast_commit.c
fs/ext4/inline.c
fs/ext4/inode.c
fs/ext4/super.c
fs/fscache/object.c
fs/fscache/operation.c
fs/inode.c
fs/io-wq.c
fs/io_uring.c
fs/kernfs/dir.c
fs/ksmbd/auth.c
fs/ksmbd/connection.c
fs/ksmbd/crypto_ctx.c
fs/ksmbd/crypto_ctx.h
fs/ksmbd/glob.h
fs/ksmbd/misc.c
fs/ksmbd/misc.h
fs/ksmbd/oplock.c
fs/ksmbd/server.c
fs/ksmbd/smb2misc.c
fs/ksmbd/smb2ops.c
fs/ksmbd/smb2pdu.c
fs/ksmbd/smb2pdu.h
fs/ksmbd/smb_common.c
fs/ksmbd/smb_common.h
fs/ksmbd/smbacl.c
fs/ksmbd/transport_rdma.c
fs/ksmbd/transport_tcp.c
fs/ksmbd/vfs.c
fs/ksmbd/vfs.h
fs/lockd/svcxdr.h
fs/netfs/read_helper.c
fs/nfs_common/grace.c
fs/nfsd/filecache.c
fs/nfsd/nfs4state.c
fs/nfsd/nfs4xdr.c
fs/nfsd/nfsctl.c
fs/ntfs3/attrib.c
fs/ntfs3/attrlist.c
fs/ntfs3/bitfunc.c
fs/ntfs3/bitmap.c
fs/ntfs3/debug.h
fs/ntfs3/dir.c
fs/ntfs3/file.c
fs/ntfs3/frecord.c
fs/ntfs3/fslog.c
fs/ntfs3/fsntfs.c
fs/ntfs3/index.c
fs/ntfs3/inode.c
fs/ntfs3/lib/decompress_common.h
fs/ntfs3/lib/lib.h
fs/ntfs3/lznt.c
fs/ntfs3/namei.c
fs/ntfs3/ntfs.h
fs/ntfs3/ntfs_fs.h
fs/ntfs3/record.c
fs/ntfs3/run.c
fs/ntfs3/super.c
fs/ntfs3/upcase.c
fs/ntfs3/xattr.c
fs/ocfs2/dlmglue.c
fs/overlayfs/dir.c
fs/overlayfs/file.c
fs/qnx4/dir.c
fs/smbfs_common/smbfsctl.h
fs/vboxsf/super.c
fs/verity/enable.c
fs/verity/open.c
include/acpi/acpi_io.h
include/asm-generic/io.h
include/asm-generic/iomap.h
include/asm-generic/mshyperv.h
include/asm-generic/pci_iomap.h
include/asm-generic/vmlinux.lds.h
include/dt-bindings/soc/qcom,gpr.h [new file with mode: 0644]
include/dt-bindings/sound/qcom,lpass.h
include/dt-bindings/sound/qcom,q6afe.h
include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h [new file with mode: 0644]
include/kunit/test.h
include/kvm/arm_pmu.h
include/linux/arm-smccc.h
include/linux/bpf.h
include/linux/buffer_head.h
include/linux/cgroup-defs.h
include/linux/cgroup.h
include/linux/compiler-clang.h
include/linux/compiler-gcc.h
include/linux/compiler.h
include/linux/compiler_attributes.h
include/linux/cpumask.h
include/linux/dsa/mv88e6xxx.h [new file with mode: 0644]
include/linux/dsa/ocelot.h
include/linux/dsa/sja1105.h
include/linux/etherdevice.h
include/linux/firmware/cirrus/cs_dsp.h [new file with mode: 0644]
include/linux/firmware/cirrus/wmfw.h [new file with mode: 0644]
include/linux/fwnode.h
include/linux/genhd.h
include/linux/irqdomain.h
include/linux/kvm_host.h
include/linux/mdio.h
include/linux/memblock.h
include/linux/migrate.h
include/linux/mlx5/mlx5_ifc.h
include/linux/mmap_lock.h
include/linux/nvmem-consumer.h
include/linux/overflow.h
include/linux/packing.h
include/linux/perf/arm_pmu.h
include/linux/perf_event.h
include/linux/pkeys.h
include/linux/platform_data/usb-omap1.h
include/linux/qcom_scm.h
include/linux/sched.h
include/linux/skbuff.h
include/linux/soc/qcom/apr.h
include/linux/spi/spi.h
include/linux/tracehook.h
include/linux/uio.h
include/linux/usb/hcd.h
include/linux/workqueue.h
include/net/dsa.h
include/net/ip_fib.h
include/net/mac80211.h
include/net/netfilter/ipv6/nf_defrag_ipv6.h
include/net/netfilter/nf_tables.h
include/net/netns/netfilter.h
include/net/nexthop.h
include/net/pkt_sched.h
include/net/sock.h
include/scsi/scsi_device.h
include/soc/mscc/ocelot.h
include/soc/mscc/ocelot_ptp.h
include/soc/mscc/ocelot_vcap.h
include/sound/cs35l41.h [new file with mode: 0644]
include/sound/graph_card.h
include/sound/rt5682s.h [new file with mode: 0644]
include/sound/simple_card_utils.h
include/sound/soc-acpi.h
include/sound/soc-component.h
include/sound/soc-dpcm.h
include/sound/soc-topology.h
include/sound/sof.h
include/sound/sof/dai-intel.h
include/sound/sof/dai.h
include/trace/events/afs.h
include/trace/events/cachefiles.h
include/trace/events/erofs.h
include/trace/events/kyber.h
include/uapi/linux/android/binder.h
include/uapi/linux/cifs/cifs_mount.h
include/uapi/linux/hyperv.h
include/uapi/linux/io_uring.h
include/uapi/linux/xfrm.h
include/uapi/misc/habanalabs.h
include/uapi/sound/snd_ar_tokens.h [new file with mode: 0644]
include/uapi/sound/sof/tokens.h
include/xen/xen-ops.h
init/do_mounts.c
init/main.c
ipc/sem.c
kernel/bpf/bpf_struct_ops.c
kernel/bpf/core.c
kernel/bpf/disasm.c
kernel/bpf/disasm.h
kernel/bpf/stackmap.c
kernel/bpf/verifier.c
kernel/cgroup/cgroup.c
kernel/cgroup/cpuset.c
kernel/dma/debug.c
kernel/dma/mapping.c
kernel/entry/common.c
kernel/events/core.c
kernel/irq/irqdomain.c
kernel/locking/rwbase_rt.c
kernel/module.c
kernel/printk/printk.c
kernel/rseq.c
kernel/sched/debug.c
kernel/sched/fair.c
kernel/time/posix-cpu-timers.c
kernel/trace/blktrace.c
kernel/trace/trace.c
kernel/trace/trace_eprobe.c
kernel/trace/trace_events_hist.c
kernel/workqueue.c
lib/Kconfig.debug
lib/Kconfig.kasan
lib/Makefile
lib/bootconfig.c
lib/iov_iter.c
lib/kunit/executor_test.c
lib/packing.c
lib/pci_iomap.c
lib/zlib_inflate/inffast.c
mm/damon/dbgfs-test.h
mm/debug.c
mm/ksm.c
mm/memblock.c
mm/memcontrol.c
mm/memory-failure.c
mm/memory.c
mm/shmem.c
mm/swap.c
mm/util.c
mm/workingset.c
net/bpf/test_run.c
net/bridge/br_multicast.c
net/bridge/br_netlink.c
net/bridge/br_private.h
net/caif/chnl_net.c
net/core/dev.c
net/core/dev_addr_lists.c
net/core/net-procfs.c
net/core/netclassid_cgroup.c
net/core/netprio_cgroup.c
net/core/rtnetlink.c
net/core/sock.c
net/dccp/minisocks.c
net/dsa/Kconfig
net/dsa/dsa.c
net/dsa/dsa2.c
net/dsa/dsa_priv.h
net/dsa/slave.c
net/dsa/switch.c
net/dsa/tag_dsa.c
net/dsa/tag_ocelot.c
net/dsa/tag_ocelot_8021q.c
net/dsa/tag_sja1105.c
net/ipv4/fib_semantics.c
net/ipv4/icmp.c
net/ipv4/inet_hashtables.c
net/ipv4/netfilter/iptable_raw.c
net/ipv4/netfilter/nf_defrag_ipv4.c
net/ipv4/nexthop.c
net/ipv4/tcp_input.c
net/ipv4/udp.c
net/ipv4/udp_tunnel_nic.c
net/ipv6/inet6_hashtables.c
net/ipv6/ioam6.c
net/ipv6/ioam6_iptunnel.c
net/ipv6/ip6_fib.c
net/ipv6/netfilter/ip6_tables.c
net/ipv6/netfilter/nf_conntrack_reasm.c
net/ipv6/netfilter/nf_defrag_ipv6_hooks.c
net/ipv6/route.c
net/ipv6/udp.c
net/l2tp/l2tp_core.c
net/mac80211/mesh_pathtbl.c
net/mac80211/mesh_ps.c
net/mac80211/rate.c
net/mac80211/rx.c
net/mac80211/tx.c
net/mac80211/wpa.c
net/mctp/route.c
net/mptcp/mptcp_diag.c
net/mptcp/pm_netlink.c
net/mptcp/protocol.c
net/mptcp/protocol.h
net/mptcp/subflow.c
net/mptcp/syncookies.c
net/mptcp/token.c
net/mptcp/token_test.c
net/netfilter/ipset/ip_set_hash_gen.h
net/netfilter/ipvs/ip_vs_conn.c
net/netfilter/nf_conntrack_core.c
net/netfilter/nf_nat_core.c
net/netfilter/nf_nat_masquerade.c
net/netfilter/nf_tables_api.c
net/netfilter/nft_compat.c
net/netfilter/nft_quota.c
net/netfilter/xt_LOG.c
net/netfilter/xt_NFLOG.c
net/netlink/af_netlink.c
net/nfc/af_nfc.c
net/nfc/digital_core.c
net/nfc/digital_technology.c
net/nfc/nci/rsp.c
net/packet/af_packet.c
net/sched/cls_flower.c
net/sched/sch_api.c
net/sched/sch_fifo.c
net/sched/sch_mqprio.c
net/sched/sch_taprio.c
net/sctp/input.c
net/sctp/sm_make_chunk.c
net/smc/smc_cdc.c
net/smc/smc_clc.c
net/smc/smc_core.c
net/smc/smc_llc.c
net/smc/smc_tx.c
net/smc/smc_wr.h
net/sunrpc/auth_gss/svcauth_gss.c
net/tipc/socket.c
net/unix/af_unix.c
net/xfrm/xfrm_user.c
samples/bpf/Makefile
samples/bpf/bpf_insn.h
samples/bpf/xdp_redirect_map_multi.bpf.c
scripts/Makefile.clang
scripts/Makefile.gcc-plugins
scripts/Makefile.kasan
scripts/Makefile.modpost
scripts/checkkconfigsymbols.py
scripts/checksyscalls.sh
scripts/clang-tools/gen_compile_commands.py
scripts/min-tool-version.sh
scripts/recordmcount.pl
scripts/sorttable.c
security/selinux/hooks.c
security/selinux/nlmsgtab.c
security/smack/smack_lsm.c
sound/hda/intel-dsp-config.c
sound/soc/amd/Kconfig
sound/soc/amd/Makefile
sound/soc/amd/acp-da7219-max98357a.c
sound/soc/amd/acp-pcm-dma.c
sound/soc/amd/acp-rt5645.c
sound/soc/amd/acp.h
sound/soc/amd/acp/Kconfig [new file with mode: 0644]
sound/soc/amd/acp/Makefile [new file with mode: 0644]
sound/soc/amd/acp/acp-i2s.c [new file with mode: 0644]
sound/soc/amd/acp/acp-legacy-mach.c [new file with mode: 0644]
sound/soc/amd/acp/acp-mach-common.c [new file with mode: 0644]
sound/soc/amd/acp/acp-mach.h [new file with mode: 0644]
sound/soc/amd/acp/acp-platform.c [new file with mode: 0644]
sound/soc/amd/acp/acp-renoir.c [new file with mode: 0644]
sound/soc/amd/acp/acp-sof-mach.c [new file with mode: 0644]
sound/soc/amd/acp/amd.h [new file with mode: 0644]
sound/soc/amd/acp/chip_offset_byte.h [new file with mode: 0644]
sound/soc/amd/vangogh/Makefile
sound/soc/amd/vangogh/acp5x-i2s.c
sound/soc/amd/vangogh/acp5x-mach.c [new file with mode: 0644]
sound/soc/amd/vangogh/acp5x.h
sound/soc/amd/vangogh/pci-acp5x.c
sound/soc/amd/yc/Makefile [new file with mode: 0644]
sound/soc/amd/yc/acp6x-mach.c [new file with mode: 0644]
sound/soc/amd/yc/acp6x-pdm-dma.c [new file with mode: 0644]
sound/soc/amd/yc/acp6x.h [new file with mode: 0644]
sound/soc/amd/yc/acp6x_chip_offset_byte.h [new file with mode: 0644]
sound/soc/amd/yc/pci-acp6x.c [new file with mode: 0644]
sound/soc/atmel/atmel-i2s.c
sound/soc/atmel/atmel_ssc_dai.c
sound/soc/atmel/atmel_wm8904.c
sound/soc/atmel/mchp-i2s-mcc.c
sound/soc/atmel/mikroe-proto.c
sound/soc/atmel/sam9g20_wm8731.c
sound/soc/atmel/sam9x5_wm8731.c
sound/soc/atmel/tse850-pcm5142.c
sound/soc/au1x/db1200.c
sound/soc/au1x/i2sc.c
sound/soc/au1x/psc-i2s.c
sound/soc/bcm/bcm2835-i2s.c
sound/soc/bcm/cygnus-ssp.c
sound/soc/cirrus/edb93xx.c
sound/soc/cirrus/ep93xx-i2s.c
sound/soc/cirrus/snappercl15.c
sound/soc/codecs/88pm860x-codec.c
sound/soc/codecs/Kconfig
sound/soc/codecs/Makefile
sound/soc/codecs/ab8500-codec.c
sound/soc/codecs/ad1836.c
sound/soc/codecs/ad193x.c
sound/soc/codecs/adau1372.c
sound/soc/codecs/adau1373.c
sound/soc/codecs/adau1701.c
sound/soc/codecs/adau17x1.c
sound/soc/codecs/adau1977.c
sound/soc/codecs/adav80x.c
sound/soc/codecs/ak4104.c
sound/soc/codecs/ak4118.c
sound/soc/codecs/ak4458.c
sound/soc/codecs/ak4642.c
sound/soc/codecs/ak4671.c
sound/soc/codecs/ak5558.c
sound/soc/codecs/alc5623.c
sound/soc/codecs/alc5632.c
sound/soc/codecs/cpcap.c
sound/soc/codecs/cros_ec_codec.c
sound/soc/codecs/cs35l41-i2c.c [new file with mode: 0644]
sound/soc/codecs/cs35l41-spi.c [new file with mode: 0644]
sound/soc/codecs/cs35l41-tables.c [new file with mode: 0644]
sound/soc/codecs/cs35l41.c [new file with mode: 0644]
sound/soc/codecs/cs35l41.h [new file with mode: 0644]
sound/soc/codecs/cs42l42.c
sound/soc/codecs/cs42l42.h
sound/soc/codecs/cs47l15.c
sound/soc/codecs/cs47l24.c
sound/soc/codecs/cs47l35.c
sound/soc/codecs/cs47l85.c
sound/soc/codecs/cs47l90.c
sound/soc/codecs/cs47l92.c
sound/soc/codecs/es8316.c
sound/soc/codecs/lpass-rx-macro.c
sound/soc/codecs/lpass-tx-macro.c
sound/soc/codecs/lpass-va-macro.c
sound/soc/codecs/lpass-wsa-macro.c
sound/soc/codecs/madera.c
sound/soc/codecs/max98390.c
sound/soc/codecs/max98520.c [new file with mode: 0644]
sound/soc/codecs/max98520.h [new file with mode: 0644]
sound/soc/codecs/max98927.c
sound/soc/codecs/max98927.h
sound/soc/codecs/mt6359.c
sound/soc/codecs/nau8821.c [new file with mode: 0644]
sound/soc/codecs/nau8821.h [new file with mode: 0644]
sound/soc/codecs/nau8824.c
sound/soc/codecs/nau8824.h
sound/soc/codecs/nau8825.c
sound/soc/codecs/pcm5102a.c
sound/soc/codecs/rt1011.c
sound/soc/codecs/rt1015.c
sound/soc/codecs/rt1016.c
sound/soc/codecs/rt1019.c
sound/soc/codecs/rt1305.c
sound/soc/codecs/rt1308.c
sound/soc/codecs/rt5514.c
sound/soc/codecs/rt5616.c
sound/soc/codecs/rt5640.c
sound/soc/codecs/rt5645.c
sound/soc/codecs/rt5651.c
sound/soc/codecs/rt5659.c
sound/soc/codecs/rt5660.c
sound/soc/codecs/rt5663.c
sound/soc/codecs/rt5665.c
sound/soc/codecs/rt5668.c
sound/soc/codecs/rt5670.c
sound/soc/codecs/rt5677.c
sound/soc/codecs/rt5682-i2c.c
sound/soc/codecs/rt5682.c
sound/soc/codecs/rt5682.h
sound/soc/codecs/rt5682s.c [new file with mode: 0644]
sound/soc/codecs/rt5682s.h [new file with mode: 0644]
sound/soc/codecs/rt9120.c [new file with mode: 0644]
sound/soc/codecs/tfa989x.c
sound/soc/codecs/tlv320aic32x4-i2c.c
sound/soc/codecs/tlv320aic32x4-spi.c
sound/soc/codecs/tlv320aic32x4.c
sound/soc/codecs/tlv320aic32x4.h
sound/soc/codecs/tlv320aic3x-i2c.c
sound/soc/codecs/tlv320aic3x-spi.c
sound/soc/codecs/tlv320aic3x.c
sound/soc/codecs/tlv320aic3x.h
sound/soc/codecs/wcd9335.c
sound/soc/codecs/wm2200.c
sound/soc/codecs/wm5102.c
sound/soc/codecs/wm5110.c
sound/soc/codecs/wm8731.c
sound/soc/codecs/wm8900.c
sound/soc/codecs/wm8962.c
sound/soc/codecs/wm_adsp.c
sound/soc/codecs/wm_adsp.h
sound/soc/codecs/wmfw.h [deleted file]
sound/soc/codecs/zl38060.c
sound/soc/dwc/dwc-i2s.c
sound/soc/fsl/eukrea-tlv320.c
sound/soc/fsl/fsl-asoc-card.c
sound/soc/fsl/fsl_audmix.c
sound/soc/fsl/fsl_esai.c
sound/soc/fsl/fsl_mqs.c
sound/soc/fsl/fsl_rpmsg.c
sound/soc/fsl/fsl_rpmsg.h
sound/soc/fsl/fsl_sai.c
sound/soc/fsl/fsl_sai.h
sound/soc/fsl/fsl_spdif.c
sound/soc/fsl/fsl_ssi.c
sound/soc/fsl/imx-audmix.c
sound/soc/fsl/imx-card.c
sound/soc/fsl/imx-es8328.c
sound/soc/fsl/imx-hdmi.c
sound/soc/fsl/imx-rpmsg.c
sound/soc/fsl/imx-sgtl5000.c
sound/soc/fsl/mpc8610_hpcd.c
sound/soc/fsl/p1022_ds.c
sound/soc/fsl/p1022_rdk.c
sound/soc/generic/Kconfig
sound/soc/generic/Makefile
sound/soc/generic/audio-graph-card.c
sound/soc/generic/audio-graph-card2-custom-sample.c [new file with mode: 0644]
sound/soc/generic/audio-graph-card2-custom-sample.dtsi [new file with mode: 0644]
sound/soc/generic/audio-graph-card2.c [new file with mode: 0644]
sound/soc/generic/simple-card-utils.c
sound/soc/generic/test-component.c [new file with mode: 0644]
sound/soc/intel/boards/Kconfig
sound/soc/intel/boards/Makefile
sound/soc/intel/boards/bdw-rt5650.c
sound/soc/intel/boards/bdw-rt5677.c
sound/soc/intel/boards/broadwell.c
sound/soc/intel/boards/bxt_da7219_max98357a.c
sound/soc/intel/boards/bxt_rt298.c
sound/soc/intel/boards/bytcht_cx2072x.c
sound/soc/intel/boards/bytcht_da7213.c
sound/soc/intel/boards/bytcht_es8316.c
sound/soc/intel/boards/bytcht_nocodec.c
sound/soc/intel/boards/bytcr_rt5640.c
sound/soc/intel/boards/bytcr_rt5651.c
sound/soc/intel/boards/bytcr_wm5102.c
sound/soc/intel/boards/cht_bsw_max98090_ti.c
sound/soc/intel/boards/cht_bsw_nau8824.c
sound/soc/intel/boards/cht_bsw_rt5645.c
sound/soc/intel/boards/cht_bsw_rt5672.c
sound/soc/intel/boards/glk_rt5682_max98357a.c
sound/soc/intel/boards/haswell.c
sound/soc/intel/boards/kbl_da7219_max98357a.c
sound/soc/intel/boards/kbl_da7219_max98927.c
sound/soc/intel/boards/kbl_rt5660.c
sound/soc/intel/boards/kbl_rt5663_max98927.c
sound/soc/intel/boards/kbl_rt5663_rt5514_max98927.c
sound/soc/intel/boards/skl_nau88l25_max98357a.c
sound/soc/intel/boards/skl_nau88l25_ssm4567.c
sound/soc/intel/boards/skl_rt286.c
sound/soc/intel/boards/sof_es8336.c [new file with mode: 0644]
sound/soc/intel/boards/sof_rt5682.c
sound/soc/intel/boards/sof_sdw.c
sound/soc/intel/common/soc-acpi-intel-adl-match.c
sound/soc/intel/common/soc-acpi-intel-bxt-match.c
sound/soc/intel/common/soc-acpi-intel-byt-match.c
sound/soc/intel/common/soc-acpi-intel-cht-match.c
sound/soc/intel/common/soc-acpi-intel-cml-match.c
sound/soc/intel/common/soc-acpi-intel-glk-match.c
sound/soc/intel/common/soc-acpi-intel-jsl-match.c
sound/soc/intel/common/soc-acpi-intel-kbl-match.c
sound/soc/intel/common/soc-acpi-intel-skl-match.c
sound/soc/intel/common/soc-acpi-intel-tgl-match.c
sound/soc/intel/skylake/skl-topology.c
sound/soc/mediatek/Kconfig
sound/soc/mediatek/common/mtk-afe-fe-dai.c
sound/soc/mediatek/mt2701/mt2701-cs42448.c
sound/soc/mediatek/mt2701/mt2701-wm8960.c
sound/soc/mediatek/mt8183/mt8183-mt6358-ts3a227-max98357.c
sound/soc/mediatek/mt8195/Makefile
sound/soc/mediatek/mt8195/mt8195-afe-pcm.c
sound/soc/mediatek/mt8195/mt8195-audsys-clk.c
sound/soc/mediatek/mt8195/mt8195-dai-adda.c
sound/soc/mediatek/mt8195/mt8195-dai-etdm.c
sound/soc/mediatek/mt8195/mt8195-mt6359-rt1011-rt5682.c [new file with mode: 0644]
sound/soc/mediatek/mt8195/mt8195-mt6359-rt1019-rt5682.c
sound/soc/meson/aiu-encoder-spdif.c
sound/soc/meson/axg-card.c
sound/soc/meson/axg-tdm-interface.c
sound/soc/meson/meson-card-utils.c
sound/soc/meson/meson-codec-glue.c
sound/soc/qcom/Kconfig
sound/soc/qcom/apq8096.c
sound/soc/qcom/common.c
sound/soc/qcom/qdsp6/Makefile
sound/soc/qcom/qdsp6/audioreach.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/audioreach.h [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6afe-clocks.c
sound/soc/qcom/qdsp6/q6afe-dai.c
sound/soc/qcom/qdsp6/q6apm-dai.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6apm-lpass-dais.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6apm.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6apm.h [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.h [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6prm-clocks.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6prm.c [new file with mode: 0644]
sound/soc/qcom/qdsp6/q6prm.h [new file with mode: 0644]
sound/soc/qcom/qdsp6/topology.c [new file with mode: 0644]
sound/soc/qcom/sm8250.c
sound/soc/rockchip/Kconfig
sound/soc/rockchip/Makefile
sound/soc/rockchip/rockchip_i2s.c
sound/soc/rockchip/rockchip_i2s_tdm.c [new file with mode: 0644]
sound/soc/rockchip/rockchip_i2s_tdm.h [new file with mode: 0644]
sound/soc/rockchip/rockchip_pcm.c [deleted file]
sound/soc/rockchip/rockchip_pcm.h [deleted file]
sound/soc/rockchip/rockchip_pdm.c
sound/soc/rockchip/rockchip_pdm.h
sound/soc/samsung/s3c-i2s-v2.c
sound/soc/sh/rcar/core.c
sound/soc/soc-acpi.c
sound/soc/soc-component.c
sound/soc/soc-compress.c
sound/soc/soc-core.c
sound/soc/soc-dapm.c
sound/soc/soc-generic-dmaengine-pcm.c
sound/soc/soc-pcm.c
sound/soc/soc-topology.c
sound/soc/soc-utils.c
sound/soc/sof/Kconfig
sound/soc/sof/Makefile
sound/soc/sof/compress.c
sound/soc/sof/compress.h [deleted file]
sound/soc/sof/control.c
sound/soc/sof/core.c
sound/soc/sof/debug.c
sound/soc/sof/imx/Kconfig
sound/soc/sof/imx/imx-ops.h [new file with mode: 0644]
sound/soc/sof/imx/imx8.c
sound/soc/sof/imx/imx8m.c
sound/soc/sof/intel/Makefile
sound/soc/sof/intel/apl.c
sound/soc/sof/intel/atom.c
sound/soc/sof/intel/bdw.c
sound/soc/sof/intel/byt.c
sound/soc/sof/intel/cnl.c
sound/soc/sof/intel/hda-compress.c [deleted file]
sound/soc/sof/intel/hda-dai.c
sound/soc/sof/intel/hda-dsp.c
sound/soc/sof/intel/hda-ipc.c
sound/soc/sof/intel/hda-loader.c
sound/soc/sof/intel/hda-probes.c [new file with mode: 0644]
sound/soc/sof/intel/hda-stream.c
sound/soc/sof/intel/hda.c
sound/soc/sof/intel/hda.h
sound/soc/sof/intel/icl.c
sound/soc/sof/intel/intel-ipc.c [deleted file]
sound/soc/sof/intel/pci-apl.c
sound/soc/sof/intel/pci-cnl.c
sound/soc/sof/intel/pci-icl.c
sound/soc/sof/intel/pci-tgl.c
sound/soc/sof/intel/pci-tng.c
sound/soc/sof/intel/tgl.c
sound/soc/sof/ipc.c
sound/soc/sof/loader.c
sound/soc/sof/ops.c
sound/soc/sof/ops.h
sound/soc/sof/pcm.c
sound/soc/sof/pm.c
sound/soc/sof/probe.c [deleted file]
sound/soc/sof/probe.h [deleted file]
sound/soc/sof/sof-audio.c
sound/soc/sof/sof-audio.h
sound/soc/sof/sof-of-dev.c
sound/soc/sof/sof-priv.h
sound/soc/sof/sof-probes.c [new file with mode: 0644]
sound/soc/sof/sof-probes.h [new file with mode: 0644]
sound/soc/sof/stream-ipc.c [new file with mode: 0644]
sound/soc/sof/topology.c
sound/soc/sof/trace.c
sound/soc/sof/utils.c
sound/soc/sof/xtensa/core.c
sound/soc/tegra/Kconfig
sound/soc/tegra/Makefile
sound/soc/tegra/tegra210_adx.c [new file with mode: 0644]
sound/soc/tegra/tegra210_adx.h [new file with mode: 0644]
sound/soc/tegra/tegra210_ahub.c
sound/soc/tegra/tegra210_amx.c [new file with mode: 0644]
sound/soc/tegra/tegra210_amx.h [new file with mode: 0644]
sound/soc/tegra/tegra210_mixer.c [new file with mode: 0644]
sound/soc/tegra/tegra210_mixer.h [new file with mode: 0644]
sound/soc/tegra/tegra210_mvc.c [new file with mode: 0644]
sound/soc/tegra/tegra210_mvc.h [new file with mode: 0644]
sound/soc/tegra/tegra210_sfc.c [new file with mode: 0644]
sound/soc/tegra/tegra210_sfc.h [new file with mode: 0644]
sound/soc/tegra/tegra_asoc_machine.c
sound/soc/tegra/tegra_asoc_machine.h
sound/soc/ti/Kconfig
sound/soc/ti/davinci-evm.c
sound/soc/ti/omap-abe-twl6040.c
sound/soc/ux500/mop500_ab8500.c
sound/soc/ux500/mop500_ab8500.h
tools/arch/x86/include/asm/unistd_32.h [deleted file]
tools/arch/x86/include/asm/unistd_64.h [deleted file]
tools/arch/x86/include/uapi/asm/unistd_32.h [new file with mode: 0644]
tools/arch/x86/include/uapi/asm/unistd_64.h [new file with mode: 0644]
tools/arch/x86/lib/insn.c
tools/bootconfig/include/linux/memblock.h
tools/include/linux/compiler-gcc.h
tools/include/linux/overflow.h
tools/include/uapi/sound/asound.h
tools/lib/bpf/libbpf.c
tools/lib/bpf/linker.c
tools/lib/bpf/strset.c
tools/lib/perf/evsel.c
tools/lib/perf/tests/test-evlist.c
tools/lib/perf/tests/test-evsel.c
tools/objtool/arch/x86/decode.c
tools/objtool/check.c
tools/objtool/elf.c
tools/objtool/include/objtool/elf.h
tools/objtool/orc_gen.c
tools/objtool/special.c
tools/perf/Documentation/jitdump-specification.txt
tools/perf/Documentation/perf-c2c.txt
tools/perf/Documentation/perf-intel-pt.txt
tools/perf/Documentation/perf-lock.txt
tools/perf/Documentation/perf-script-perl.txt
tools/perf/Documentation/perf-script-python.txt
tools/perf/Documentation/perf-stat.txt
tools/perf/Documentation/topdown.txt
tools/perf/Makefile.config
tools/perf/Makefile.perf
tools/perf/arch/arm/util/auxtrace.c
tools/perf/arch/arm/util/cs-etm.c
tools/perf/arch/arm/util/perf_regs.c
tools/perf/arch/arm/util/pmu.c
tools/perf/arch/arm/util/unwind-libdw.c
tools/perf/arch/arm/util/unwind-libunwind.c
tools/perf/arch/x86/util/iostat.c
tools/perf/builtin-script.c
tools/perf/builtin-stat.c
tools/perf/pmu-events/arch/powerpc/power8/other.json
tools/perf/pmu-events/jevents.c
tools/perf/tests/attr/test-stat-default
tools/perf/tests/attr/test-stat-detailed-1
tools/perf/tests/attr/test-stat-detailed-2
tools/perf/tests/attr/test-stat-detailed-3
tools/perf/tests/code-reading.c
tools/perf/tests/dwarf-unwind.c
tools/perf/ui/browser.c
tools/perf/ui/browser.h
tools/perf/ui/browsers/annotate.c
tools/perf/util/bpf-event.c
tools/perf/util/config.c
tools/perf/util/machine.c
tools/perf/util/session.c
tools/testing/kunit/kunit.py
tools/testing/kunit/kunit_tool_test.py
tools/testing/selftests/arm64/signal/test_signals_utils.c
tools/testing/selftests/bpf/Makefile
tools/testing/selftests/bpf/cgroup_helpers.c
tools/testing/selftests/bpf/cgroup_helpers.h
tools/testing/selftests/bpf/network_helpers.c
tools/testing/selftests/bpf/network_helpers.h
tools/testing/selftests/bpf/prog_tests/cgroup_v1v2.c [new file with mode: 0644]
tools/testing/selftests/bpf/prog_tests/task_pt_regs.c
tools/testing/selftests/bpf/progs/connect4_dropper.c [new file with mode: 0644]
tools/testing/selftests/bpf/progs/test_task_pt_regs.c
tools/testing/selftests/bpf/test_lwt_ip_encap.sh
tools/testing/selftests/drivers/dma-buf/udmabuf.c
tools/testing/selftests/drivers/net/ocelot/tc_flower_chains.sh
tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc
tools/testing/selftests/kvm/.gitignore
tools/testing/selftests/kvm/Makefile
tools/testing/selftests/kvm/access_tracking_perf_test.c
tools/testing/selftests/kvm/demand_paging_test.c
tools/testing/selftests/kvm/dirty_log_perf_test.c
tools/testing/selftests/kvm/include/test_util.h
tools/testing/selftests/kvm/include/x86_64/processor.h
tools/testing/selftests/kvm/kvm_page_table_test.c
tools/testing/selftests/kvm/lib/test_util.c
tools/testing/selftests/kvm/rseq_test.c [new file with mode: 0644]
tools/testing/selftests/kvm/steal_time.c
tools/testing/selftests/kvm/x86_64/mmio_warning_test.c
tools/testing/selftests/kvm/x86_64/svm_int_ctl_test.c [new file with mode: 0644]
tools/testing/selftests/kvm/x86_64/xen_shinfo_test.c
tools/testing/selftests/lib.mk
tools/testing/selftests/nci/nci_dev.c
tools/testing/selftests/net/af_unix/Makefile
tools/testing/selftests/net/af_unix/test_unix_oob.c
tools/testing/selftests/net/altnames.sh
tools/testing/selftests/net/ioam6.sh
tools/testing/selftests/net/ioam6_parser.c
tools/testing/selftests/netfilter/nft_nat_zones.sh [new file with mode: 0755]
tools/testing/selftests/netfilter/nft_zones_many.sh [new file with mode: 0755]
tools/testing/selftests/powerpc/tm/tm-syscall-asm.S
tools/testing/selftests/powerpc/tm/tm-syscall.c
tools/usb/testusb.c
tools/vm/page-types.c
virt/kvm/kvm_main.c

diff --git a/CREDITS b/CREDITS
index 7ef7b13..d8f63e8 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -971,6 +971,7 @@ D: PowerPC
 N: Daniel Drake
 E: dsd@gentoo.org
 D: USBAT02 CompactFlash support in usb-storage
+D: ZD1211RW wireless driver
 S: UK
 
 N: Oleg Drokin
index 35314b6..caa3c09 100644 (file)
@@ -259,7 +259,7 @@ Configuring the kernel
 Compiling the kernel
 --------------------
 
- - Make sure you have at least gcc 4.9 available.
+ - Make sure you have at least gcc 5.1 available.
    For more information, refer to :ref:`Documentation/process/changes.rst <changes>`.
 
    Please note that you can still run a.out user programs with this kernel.
index babbe04..4d8c27e 100644 (file)
@@ -1226,7 +1226,7 @@ PAGE_SIZE multiple when read back.
 
        Note that all fields in this file are hierarchical and the
        file modified event can be generated due to an event down the
-       hierarchy. For for the local events at the cgroup level see
+       hierarchy. For the local events at the cgroup level see
        memory.events.local.
 
          low
@@ -2170,19 +2170,19 @@ existing device files.
 
 Cgroup v2 device controller has no interface files and is implemented
 on top of cgroup BPF. To control access to device files, a user may
-create bpf programs of the BPF_CGROUP_DEVICE type and attach them
-to cgroups. On an attempt to access a device file, corresponding
-BPF programs will be executed, and depending on the return value
-the attempt will succeed or fail with -EPERM.
-
-A BPF_CGROUP_DEVICE program takes a pointer to the bpf_cgroup_dev_ctx
-structure, which describes the device access attempt: access type
-(mknod/read/write) and device (type, major and minor numbers).
-If the program returns 0, the attempt fails with -EPERM, otherwise
-it succeeds.
-
-An example of BPF_CGROUP_DEVICE program may be found in the kernel
-source tree in the tools/testing/selftests/bpf/progs/dev_cgroup.c file.
+create bpf programs of type BPF_PROG_TYPE_CGROUP_DEVICE and attach
+them to cgroups with BPF_CGROUP_DEVICE flag. On an attempt to access a
+device file, corresponding BPF programs will be executed, and depending
+on the return value the attempt will succeed or fail with -EPERM.
+
+A BPF_PROG_TYPE_CGROUP_DEVICE program takes a pointer to the
+bpf_cgroup_dev_ctx structure, which describes the device access attempt:
+access type (mknod/read/write) and device (type, major and minor numbers).
+If the program returns 0, the attempt fails with -EPERM, otherwise it
+succeeds.
+
+An example of BPF_PROG_TYPE_CGROUP_DEVICE program may be found in
+tools/testing/selftests/bpf/progs/dev_cgroup.c in the kernel source tree.
 
 
 RDMA
index 91ba391..43dc35f 100644 (file)
                        The VGA and EFI output is eventually overwritten by
                        the real console.
 
-                       The xen output can only be used by Xen PV guests.
+                       The xen option can only be used in Xen domains.
 
                        The sclp output can only be used on s390.
 
index 6979b4a..9c0e875 100644 (file)
@@ -175,9 +175,10 @@ for IRQ numbers that are passed to struct device registrations.  In that
 case the Linux IRQ numbers cannot be dynamically assigned and the legacy
 mapping should be used.
 
-As the name implies, the *_legacy() functions are deprecated and only
+As the name implies, the \*_legacy() functions are deprecated and only
 exist to ease the support of ancient platforms. No new users should be
-added.
+added. Same goes for the \*_simple() functions when their use results
+in the legacy behaviour.
 
 The legacy map assumes a contiguous range of IRQ numbers has already
 been allocated for the controller and that the IRQ number can be
index b962fa6..d79d36a 100644 (file)
@@ -54,7 +54,7 @@ properties:
           - const: toradex,apalis_t30
           - const: nvidia,tegra30
       - items:
-          - const: toradex,apalis_t30-eval-v1.1
+          - const: toradex,apalis_t30-v1.1-eval
           - const: toradex,apalis_t30-eval
           - const: toradex,apalis_t30-v1.1
           - const: toradex,apalis_t30
index 07b2038..b446d0f 100644 (file)
@@ -50,7 +50,6 @@ properties:
               data-lanes:
                 description: array of physical DSI data lane indexes.
                 minItems: 1
-                maxItems: 4
                 items:
                   - const: 1
                   - const: 2
@@ -71,7 +70,6 @@ properties:
               data-lanes:
                 description: array of physical DSI data lane indexes.
                 minItems: 1
-                maxItems: 4
                 items:
                   - const: 1
                   - const: 2
index 1c2daf7..9115644 100644 (file)
@@ -18,7 +18,7 @@ properties:
     const: ti,sn65dsi86
 
   reg:
-    const: 0x2d
+    enum: [ 0x2c, 0x2d ]
 
   enable-gpios:
     maxItems: 1
index fbb59c9..78044c3 100644 (file)
@@ -9,7 +9,7 @@ function block.
 
 All DISP device tree nodes must be siblings to the central MMSYS_CONFIG node.
 For a description of the MMSYS_CONFIG binding, see
-Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.txt.
+Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.yaml.
 
 DISP function blocks
 ====================
index 2ed010f..20ce88a 100644 (file)
@@ -22,7 +22,7 @@ properties:
     items:
       - enum:
           # ili9341 240*320 Color on stm32f429-disco board
-        - st,sf-tc240t-9370-t
+          - st,sf-tc240t-9370-t
       - const: ilitek,ili9341
 
   reg: true
index 29de780..bcd41e4 100644 (file)
@@ -31,11 +31,11 @@ properties:
 
   clocks:
     minItems: 1
-    maxItems: 3
+    maxItems: 7
 
   clock-names:
     minItems: 1
-    maxItems: 3
+    maxItems: 7
 
 required:
   - compatible
@@ -72,6 +72,32 @@ allOf:
           contains:
             enum:
               - qcom,sdm660-a2noc
+    then:
+      properties:
+        clocks:
+          items:
+            - description: Bus Clock.
+            - description: Bus A Clock.
+            - description: IPA Clock.
+            - description: UFS AXI Clock.
+            - description: Aggregate2 UFS AXI Clock.
+            - description: Aggregate2 USB3 AXI Clock.
+            - description: Config NoC USB2 AXI Clock.
+        clock-names:
+          items:
+            - const: bus
+            - const: bus_a
+            - const: ipa
+            - const: ufs_axi
+            - const: aggre2_ufs_axi
+            - const: aggre2_usb3_axi
+            - const: cfg_noc_usb2_axi
+
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
               - qcom,sdm660-bimc
               - qcom,sdm660-cnoc
               - qcom,sdm660-gnoc
@@ -91,6 +117,7 @@ examples:
   - |
       #include <dt-bindings/clock/qcom,rpmcc.h>
       #include <dt-bindings/clock/qcom,mmcc-sdm660.h>
+      #include <dt-bindings/clock/qcom,gcc-sdm660.h>
 
       bimc: interconnect@1008000 {
               compatible = "qcom,sdm660-bimc";
@@ -123,9 +150,20 @@ examples:
               compatible = "qcom,sdm660-a2noc";
               reg = <0x01704000 0xc100>;
               #interconnect-cells = <1>;
-              clock-names = "bus", "bus_a";
+              clock-names = "bus",
+                            "bus_a",
+                            "ipa",
+                            "ufs_axi",
+                            "aggre2_ufs_axi",
+                            "aggre2_usb3_axi",
+                            "cfg_noc_usb2_axi";
               clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
-                       <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>;
+                       <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>,
+                       <&rpmcc RPM_SMD_IPA_CLK>,
+                       <&gcc GCC_UFS_AXI_CLK>,
+                       <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
+                       <&gcc GCC_AGGRE2_USB3_AXI_CLK>,
+                       <&gcc GCC_CFG_NOC_USB2_AXI_CLK>;
       };
 
       mnoc: interconnect@1745000 {
index 3e5d82d..a2abed0 100644 (file)
@@ -31,7 +31,7 @@ properties:
     maxItems: 1
 
   port:
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/$defs/port-base
     additionalProperties: false
 
     properties:
index ad42992..bf115ab 100644 (file)
@@ -38,7 +38,7 @@ properties:
 
   port:
     additionalProperties: false
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/$defs/port-base
 
     properties:
       endpoint:
index 881f795..cf2ca27 100644 (file)
@@ -38,7 +38,7 @@ properties:
 
   port:
     additionalProperties: false
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/$defs/port-base
 
     properties:
       endpoint:
index 1edeabf..afcf709 100644 (file)
@@ -38,7 +38,7 @@ properties:
 
   port:
     additionalProperties: false
-    $ref: /schemas/graph.yaml#/properties/port
+    $ref: /schemas/graph.yaml#/$defs/port-base
 
     properties:
       endpoint:
index e6c9a2f..f300ced 100644 (file)
@@ -20,9 +20,7 @@ properties:
       - snps,dwcmshc-sdhci
 
   reg:
-    minItems: 1
-    items:
-      - description: Offset and length of the register set for the device
+    maxItems: 1
 
   interrupts:
     maxItems: 1
index 7f2578d..9eb4bb5 100644 (file)
@@ -19,7 +19,9 @@ properties:
       - const: allwinner,sun8i-v3s-emac
       - const: allwinner,sun50i-a64-emac
       - items:
-          - const: allwinner,sun50i-h6-emac
+          - enum:
+              - allwinner,sun20i-d1-emac
+              - allwinner,sun50i-h6-emac
           - const: allwinner,sun50i-a64-emac
 
   reg:
index 30c11fe..2363b41 100644 (file)
@@ -83,7 +83,7 @@ Example:
                #interrupt-cells = <2>;
 
                switch0: switch@0 {
-                       compatible = "marvell,mv88e6390";
+                       compatible = "marvell,mv88e6190";
                        reg = <0>;
                        reset-gpios = <&gpio5 1 GPIO_ACTIVE_LOW>;
 
index 5629b2e..ee4afe3 100644 (file)
@@ -34,7 +34,6 @@ properties:
 
   clocks:
     minItems: 3
-    maxItems: 5
     items:
       - description: MAC host clock
       - description: MAC apb clock
index 42689b7..c115c95 100644 (file)
@@ -21,6 +21,7 @@ select:
       contains:
         enum:
           - snps,dwmac
+          - snps,dwmac-3.40a
           - snps,dwmac-3.50a
           - snps,dwmac-3.610
           - snps,dwmac-3.70a
@@ -76,6 +77,7 @@ properties:
         - rockchip,rk3399-gmac
         - rockchip,rv1108-gmac
         - snps,dwmac
+        - snps,dwmac-3.40a
         - snps,dwmac-3.50a
         - snps,dwmac-3.610
         - snps,dwmac-3.70a
index 2911e56..acea1cd 100644 (file)
@@ -41,7 +41,6 @@ properties:
       - description: builtin MSI controller.
 
   interrupt-names:
-    minItems: 1
     items:
       - const: msi
 
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.txt
deleted file mode 100644 (file)
index 2e2f6dc..0000000
+++ /dev/null
@@ -1,134 +0,0 @@
-Qualcomm APR (Asynchronous Packet Router) binding
-
-This binding describes the Qualcomm APR. APR is a IPC protocol for
-communication between Application processor and QDSP. APR is mainly
-used for audio/voice services on the QDSP.
-
-- compatible:
-       Usage: required
-       Value type: <stringlist>
-       Definition: must be "qcom,apr-v<VERSION-NUMBER>", example "qcom,apr-v2"
-
-- qcom,apr-domain
-       Usage: required
-       Value type: <u32>
-       Definition: Destination processor ID.
-       Possible values are :
-                       1 - APR simulator
-                       2 - PC
-                       3 - MODEM
-                       4 - ADSP
-                       5 - APPS
-                       6 - MODEM2
-                       7 - APPS2
-
-= APR SERVICES
-Each subnode of the APR node represents service tied to this apr. The name
-of the nodes are not important. The properties of these nodes are defined
-by the individual bindings for the specific service
-- All APR services MUST contain the following property:
-
-- reg
-       Usage: required
-       Value type: <u32>
-       Definition: APR Service ID
-       Possible values are :
-                       3 - DSP Core Service
-                       4 - Audio Front End Service.
-                       5 - Voice Stream Manager Service.
-                       6 - Voice processing manager.
-                       7 - Audio Stream Manager Service.
-                       8 - Audio Device Manager Service.
-                       9 - Multimode voice manager.
-                       10 - Core voice stream.
-                       11 - Core voice processor.
-                       12 - Ultrasound stream manager.
-                       13 - Listen stream manager.
-
-- qcom,protection-domain
-       Usage: optional
-       Value type: <stringlist>
-       Definition: Must list the protection domain service name and path
-                   that the particular apr service has a dependency on.
-       Possible values are :
-                       "avs/audio", "msm/adsp/audio_pd".
-                       "kernel/elf_loader", "msm/modem/wlan_pd".
-                       "tms/servreg", "msm/adsp/audio_pd".
-                       "tms/servreg", "msm/modem/wlan_pd".
-                       "tms/servreg", "msm/slpi/sensor_pd".
-
-= EXAMPLE
-The following example represents a QDSP based sound card on a MSM8996 device
-which uses apr as communication between Apps and QDSP.
-
-       apr {
-               compatible = "qcom,apr-v2";
-               qcom,apr-domain = <APR_DOMAIN_ADSP>;
-
-               apr-service@3 {
-                       compatible = "qcom,q6core";
-                       reg = <APR_SVC_ADSP_CORE>;
-               };
-
-               apr-service@4 {
-                       compatible = "qcom,q6afe";
-                       reg = <APR_SVC_AFE>;
-
-                       dais {
-                               #sound-dai-cells = <1>;
-                               dai@1 {
-                                       reg = <HDMI_RX>;
-                               };
-                       };
-               };
-
-               apr-service@7 {
-                       compatible = "qcom,q6asm";
-                       reg = <APR_SVC_ASM>;
-                       ...
-               };
-
-               apr-service@8 {
-                       compatible = "qcom,q6adm";
-                       reg = <APR_SVC_ADM>;
-                       ...
-               };
-       };
-
-= EXAMPLE 2
-The following example represents a QDSP based sound card with protection domain
-dependencies specified. Here some of the apr services are dependent on services
-running on protection domain hosted on ADSP/SLPI remote processors while others
-have no such dependency.
-
-       apr {
-               compatible = "qcom,apr-v2";
-               qcom,glink-channels = "apr_audio_svc";
-               qcom,apr-domain = <APR_DOMAIN_ADSP>;
-
-               apr-service@3 {
-                       compatible = "qcom,q6core";
-                       reg = <APR_SVC_ADSP_CORE>;
-               };
-
-               q6afe: apr-service@4 {
-                       compatible = "qcom,q6afe";
-                       reg = <APR_SVC_AFE>;
-                       qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
-                       ...
-               };
-
-               q6asm: apr-service@7 {
-                       compatible = "qcom,q6asm";
-                       reg = <APR_SVC_ASM>;
-                       qcom,protection-domain = "tms/servreg", "msm/slpi/sensor_pd";
-                       ...
-               };
-
-               q6adm: apr-service@8 {
-                       compatible = "qcom,q6adm";
-                       reg = <APR_SVC_ADM>;
-                       qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
-                       ...
-               };
-       };
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
new file mode 100644 (file)
index 0000000..028c5d1
--- /dev/null
@@ -0,0 +1,177 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/soc/qcom/qcom,apr.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm APR/GPR (Asynchronous/Generic Packet Router) binding
+
+maintainers:
+  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+description: |
+  This binding describes the Qualcomm APR/GPR, APR/GPR is a IPC protocol for
+  communication between Application processor and QDSP. APR/GPR is mainly
+  used for audio/voice services on the QDSP.
+
+properties:
+  compatible:
+    enum:
+      - qcom,apr-v2
+      - qcom,gpr
+
+  qcom,apr-domain:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum: [1, 2, 3, 4, 5, 6, 7]
+    description:
+      Selects the processor domain for apr
+        1 = APR simulator
+        2 = PC Domain
+        3 = Modem Domain
+        4 = ADSP Domain
+        5 = Application processor Domain
+        6 = Modem2 Domain
+        7 = Application Processor2 Domain
+    deprecated: true
+
+  qcom,domain:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    minimum: 1
+    maximum: 7
+    description:
+      Selects the processor domain for apr
+        1 = APR simulator
+        2 = PC Domain
+        3 = Modem Domain
+        4 = ADSP Domain
+        5 = Application processor Domain
+        6 = Modem2 Domain
+        7 = Application Processor2 Domain
+      Selects the processor domain for gpr
+        1 = Modem Domain
+        2 = Audio DSP Domain
+        3 = Application Processor Domain
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+#APR/GPR Services
+patternProperties:
+  "^service@[1-9a-d]$":
+    type: object
+    description:
+      APR/GPR node's client devices use subnodes for desired static port services.
+
+    properties:
+      compatible:
+        enum:
+          - qcom,q6core
+          - qcom,q6asm
+          - qcom,q6afe
+          - qcom,q6adm
+          - qcom,q6apm
+          - qcom,q6prm
+
+      reg:
+        minimum: 1
+        maximum: 13
+        description:
+          APR Service ID
+            3 = DSP Core Service
+            4 = Audio  Front End Service.
+            5 = Voice Stream Manager Service.
+            6 = Voice processing manager.
+            7 = Audio Stream Manager Service.
+            8 = Audio Device Manager Service.
+            9 = Multimode voice manager.
+            10 = Core voice stream.
+            11 = Core voice processor.
+            12 = Ultrasound stream manager.
+            13 = Listen stream manager.
+          GPR Service ID
+            1 = Audio Process Manager Service
+            2 = Proxy Resource Manager Service.
+            3 = AMDB Service.
+            4 = Voice processing manager.
+
+      qcom,protection-domain:
+        $ref: /schemas/types.yaml#/definitions/string-array
+        description: protection domain service name and path for apr service
+          possible values are
+          "avs/audio", "msm/adsp/audio_pd".
+          "kernel/elf_loader", "msm/modem/wlan_pd".
+          "tms/servreg", "msm/adsp/audio_pd".
+          "tms/servreg", "msm/modem/wlan_pd".
+          "tms/servreg", "msm/slpi/sensor_pd".
+
+      '#address-cells':
+        const: 1
+
+      '#size-cells':
+        const: 0
+
+    patternProperties:
+      "^.*@[0-9a-f]+$":
+        type: object
+        description:
+          Service based devices like clock controllers or digital audio interfaces.
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - qcom,domain
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/soc/qcom,apr.h>
+    apr {
+        compatible = "qcom,apr-v2";
+        qcom,domain = <APR_DOMAIN_ADSP>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        q6core: service@3 {
+          compatible = "qcom,q6core";
+          reg = <APR_SVC_ADSP_CORE>;
+          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+        };
+
+        q6afe: service@4 {
+          compatible = "qcom,q6afe";
+          reg = <APR_SVC_AFE>;
+          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+        };
+
+        q6asm: service@7 {
+          compatible = "qcom,q6asm";
+          reg = <APR_SVC_ASM>;
+          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+        };
+
+        q6adm: service@8 {
+          compatible = "qcom,q6adm";
+          reg = <APR_SVC_ADM>;
+          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+        };
+    };
+
+  - |
+    #include <dt-bindings/soc/qcom,gpr.h>
+    gpr {
+        compatible = "qcom,gpr";
+        qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        service@1 {
+          compatible = "qcom,q6apm";
+          reg = <GPR_APM_MODULE_IID>;
+          qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
+        };
+    };
index c7613ea..db7b04d 100644 (file)
@@ -34,6 +34,10 @@ properties:
   resets:
     maxItems: 1
 
+  AVDD-supply:
+    description:
+      Analogue power supply.
+
 required:
   - "#sound-dai-cells"
   - compatible
@@ -41,6 +45,7 @@ required:
   - clocks
   - clock-names
   - resets
+  - AVDD-supply
 
 additionalProperties: false
 
@@ -56,4 +61,5 @@ examples:
         clocks = <&clkc CLKID_AUDIO_CODEC>;
         clock-names = "pclk";
         resets = <&reset RESET_AUDIO_CODEC>;
+        AVDD-supply = <&vddao_1v8>;
     };
diff --git a/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml b/Documentation/devicetree/bindings/sound/audio-graph-card2.yaml
new file mode 100644 (file)
index 0000000..f7e94b1
--- /dev/null
@@ -0,0 +1,57 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/audio-graph-card2.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Audio Graph Card2 Device Tree Bindings
+
+maintainers:
+  - Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+
+properties:
+  compatible:
+    enum:
+      - audio-graph-card2
+  links:
+    $ref: /schemas/types.yaml#/definitions/phandle-array
+  label:
+    maxItems: 1
+  routing:
+    description: |
+      A list of the connections between audio components.
+      Each entry is a pair of strings, the first being the
+      connection's sink, the second being the connection's source.
+    $ref: /schemas/types.yaml#/definitions/non-unique-string-array
+  multi:
+    description: Multi-CPU/Codec node
+  dpcm:
+    description: DPCM node
+  codec2codec:
+    description: Codec to Codec node
+
+required:
+  - compatible
+  - links
+
+additionalProperties: false
+
+examples:
+  - |
+    sound {
+        compatible = "audio-graph-card2";
+
+        links = <&cpu_port>;
+    };
+
+    cpu {
+        compatible = "cpu-driver";
+
+        cpu_port: port { cpu_ep: endpoint { remote-endpoint = <&codec_ep>; }; };
+    };
+
+    codec {
+        compatible = "codec-driver";
+
+        port { codec_ep: endpoint { remote-endpoint = <&cpu_ep>; }; };
+    };
diff --git a/Documentation/devicetree/bindings/sound/bt-sco.txt b/Documentation/devicetree/bindings/sound/bt-sco.txt
deleted file mode 100644 (file)
index 641edf7..0000000
+++ /dev/null
@@ -1,13 +0,0 @@
-Bluetooth-SCO audio CODEC
-
-This device support generic Bluetooth SCO link.
-
-Required properties:
-
-  - compatible : "delta,dfbmcs320" or "linux,bt-sco"
-
-Example:
-
-codec: bt_sco {
-       compatible = "delta,dfbmcs320";
-};
diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
new file mode 100644 (file)
index 0000000..3235702
--- /dev/null
@@ -0,0 +1,157 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/cirrus,cs35l41.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Cirrus Logic CS35L41 Speaker Amplifier
+
+maintainers:
+  - david.rhodes@cirrus.com
+
+description: |
+  CS35L41 is a boosted mono Class D amplifier with DSP
+  speaker protection and equalization
+
+properties:
+  compatible:
+    enum:
+      - cirrus,cs35l40
+      - cirrus,cs35l41
+
+  reg:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    description:
+      The first cell indicating the audio interface.
+    const: 1
+
+  reset-gpios:
+    maxItems: 1
+
+  VA-supply:
+    description: voltage regulator phandle for the VA supply
+
+  VP-supply:
+    description: voltage regulator phandle for the VP supply
+
+  cirrus,boost-peak-milliamp:
+    description:
+      Boost-converter peak current limit in mA.
+      Configures the peak current by monitoring the current through the boost FET.
+      Range starts at 1600 mA and goes to a maximum of 4500 mA with increments
+      of 50 mA. See section 4.3.6 of the datasheet for details.
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+    minimum: 1600
+    maximum: 4500
+    default: 4500
+
+  cirrus,boost-ind-nanohenry:
+    description:
+      Boost inductor value, expressed in nH. Valid
+      values include 1000, 1200, 1500 and 2200.
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+    minimum: 1000
+    maximum: 2200
+
+  cirrus,boost-cap-microfarad:
+    description:
+      Total equivalent boost capacitance on the VBST
+      and VAMP pins, derated at 11 volts DC. The value must be rounded to the
+      nearest integer and expressed in uF.
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+
+  cirrus,asp-sdout-hiz:
+    description:
+      Audio serial port SDOUT Hi-Z control. Sets the Hi-Z
+      configuration for SDOUT pin of amplifier.
+      0 = Logic 0 during unused slots, and while all transmit channels disabled
+      1 = Hi-Z during unused slots but logic 0 while all transmit channels disabled
+      2 = (Default) Logic 0 during unused slots, but Hi-Z while all transmit channels disabled
+      3 = Hi-Z during unused slots and while all transmit channels disabled
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+    minimum: 0
+    maximum: 3
+    default: 2
+
+  cirrus,gpio1-polarity-invert:
+    description:
+      Boolean which specifies whether the GPIO1
+      level is inverted. If this property is not present the level is not inverted.
+    type: boolean
+
+  cirrus,gpio1-output-enable:
+    description:
+      Boolean which specifies whether the GPIO1 pin
+      is configured as an output. If this property is not present the
+      pin will be configured as an input.
+    type: boolean
+
+  cirrus,gpio1-src-select:
+    description:
+      Configures the function of the GPIO1 pin.
+      Note that the options are different from the GPIO2 pin
+      0 = High Impedance (Default)
+      1 = GPIO
+      2 = Sync
+      3 = MCLK input
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+    minimum: 0
+    maximum: 3
+
+  cirrus,gpio2-polarity-invert:
+    description:
+      Boolean which specifies whether the GPIO2
+      level is inverted. If this property is not present the level is not inverted.
+    type: boolean
+
+  cirrus,gpio2-output-enable:
+    description:
+      Boolean which specifies whether the GPIO2 pin
+      is configured as an output. If this property is not present the
+      pin will be configured as an input.
+    type: boolean
+
+  cirrus,gpio2-src-select:
+    description:
+      Configures the function of the GPIO2 pin.
+      Note that the options are different from the GPIO1 pin.
+      0 = High Impedance (Default)
+      1 = GPIO
+      2 = Open Drain INTB
+      3 = MCLK input
+      4 = Push-pull INTB (active low)
+      5 = Push-pull INT (active high)
+    $ref: "/schemas/types.yaml#/definitions/uint32"
+    minimum: 0
+    maximum: 5
+
+required:
+  - compatible
+  - reg
+  - "#sound-dai-cells"
+  - cirrus,boost-peak-milliamp
+  - cirrus,boost-ind-nanohenry
+  - cirrus,boost-cap-microfarad
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        cs35l41: cs35l41@2 {
+          #sound-dai-cells = <1>;
+          compatible = "cirrus,cs35l41";
+          reg = <2>;
+          VA-supply = <&dummy_vreg>;
+          VP-supply = <&dummy_vreg>;
+          reset-gpios = <&gpio 110 0>;
+          cirrus,boost-peak-milliamp = <4500>;
+          cirrus,boost-ind-nanohenry = <1000>;
+          cirrus,boost-cap-microfarad = <15>;
+        };
+    };
index 5d416fd..3b77056 100644 (file)
@@ -19,13 +19,14 @@ Optional properties:
   (See Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
   for further information relating to interrupt properties)
 
-  - cirrus,ts-inv : Boolean property. For jacks that invert the tip sense
-  polarity. Normal jacks will short tip sense pin to HS1 when headphones are
-  plugged in and leave tip sense floating when not plugged in. Inverting jacks
-  short tip sense when unplugged and float when plugged in.
+  - cirrus,ts-inv : Boolean property. Sets the behaviour of the jack plug
+  detect switch.
 
-  0 = (Default) Non-inverted
-  1 = Inverted
+  0 = (Default) Shorted to tip when unplugged, open when plugged.
+      This is "inverted tip sense (ITS)" in the datasheet.
+
+  1 = Open when unplugged, shorted to tip when plugged.
+      This is "normal tip sense (TS)" in the datasheet.
 
   - cirrus,ts-dbnc-rise : Debounce the rising edge of TIP_SENSE_PLUG. With no
   debounce, the tip sense pin might be noisy on a plug event.
diff --git a/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml b/Documentation/devicetree/bindings/sound/linux,bt-sco.yaml
new file mode 100644 (file)
index 0000000..e3a1f48
--- /dev/null
@@ -0,0 +1,38 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,bt-sco.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Bluetooth SCO Audio Codec Device Tree Bindings
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  '#sound-dai-cells':
+    enum:
+      - 0
+
+      # For Wideband PCM
+      - 1
+
+  compatible:
+    enum:
+      - delta,dfbmcs320
+      - linux,bt-sco
+
+required:
+  - '#sound-dai-cells'
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    codec {
+        #sound-dai-cells = <0>;
+        compatible = "linux,bt-sco";
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml b/Documentation/devicetree/bindings/sound/linux,spdif-dit.yaml
new file mode 100644 (file)
index 0000000..c6b070e
--- /dev/null
@@ -0,0 +1,32 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/linux,spdif-dit.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Dummy SPDIF Transmitter Device Tree Bindings
+
+maintainers:
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  compatible:
+    const: linux,spdif-dit
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - "#sound-dai-cells"
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    spdif-out {
+        #sound-dai-cells = <0>;
+        compatible = "linux,spdif-dit";
+    };
+
+...
index f617159..98cb9ba 100644 (file)
@@ -30,6 +30,9 @@ Required properties:
 
   - reg : the I2C address of the device for I2C
 
+Optional properties:
+  - reset-gpios : GPIO to reset the device
+
 Example:
 
 codec: max98927@3a {
diff --git a/Documentation/devicetree/bindings/sound/maxim,max98520.yaml b/Documentation/devicetree/bindings/sound/maxim,max98520.yaml
new file mode 100644 (file)
index 0000000..b6509cb
--- /dev/null
@@ -0,0 +1,36 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/maxim,max98520.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Maxim Integrated MAX98520 Speaker Amplifier Driver
+
+maintainers:
+  - George Song <george.song@maximintegrated.com>
+
+properties:
+  compatible:
+    const: maxim,max98520
+
+  reg:
+    maxItems: 1
+    description: I2C address of the device.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      max98520: amplifier@38 {
+        compatible = "maxim,max98520";
+        reg = <0x38>;
+      };
+    };
+
diff --git a/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml b/Documentation/devicetree/bindings/sound/mt8192-afe-pcm.yaml
new file mode 100644 (file)
index 0000000..7a25bc9
--- /dev/null
@@ -0,0 +1,100 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt8192-afe-pcm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek AFE PCM controller for mt8192
+
+maintainers:
+  - Jiaxin Yu <jiaxin.yu@mediatek.com>
+  - Shane Chien <shane.chien@mediatek.com>
+
+properties:
+  compatible:
+    const: mediatek,mt8192-audio
+
+  interrupts:
+    maxItems: 1
+
+  resets:
+    maxItems: 1
+
+  reset-names:
+    const: audiosys
+
+  mediatek,apmixedsys:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of the mediatek apmixedsys controller
+
+  mediatek,infracfg:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of the mediatek infracfg controller
+
+  mediatek,topckgen:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of the mediatek topckgen controller
+
+  power-domains:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: AFE clock
+      - description: ADDA DAC clock
+      - description: ADDA DAC pre-distortion clock
+      - description: audio infra sys clock
+      - description: audio infra 26M clock
+
+  clock-names:
+    items:
+      - const: aud_afe_clk
+      - const: aud_dac_clk
+      - const: aud_dac_predis_clk
+      - const: aud_infra_clk
+      - const: aud_infra_26m_clk
+
+required:
+  - compatible
+  - interrupts
+  - resets
+  - reset-names
+  - mediatek,apmixedsys
+  - mediatek,infracfg
+  - mediatek,topckgen
+  - power-domains
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/mt8192-clk.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/power/mt8192-power.h>
+    #include <dt-bindings/reset/mt8192-resets.h>
+
+    afe: mt8192-afe-pcm {
+        compatible = "mediatek,mt8192-audio";
+        interrupts = <GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>;
+        resets = <&watchdog MT8192_TOPRGU_AUDIO_SW_RST>;
+        reset-names = "audiosys";
+        mediatek,apmixedsys = <&apmixedsys>;
+        mediatek,infracfg = <&infracfg>;
+        mediatek,topckgen = <&topckgen>;
+        power-domains = <&scpsys MT8192_POWER_DOMAIN_AUDIO>;
+        clocks = <&audsys CLK_AUD_AFE>,
+                 <&audsys CLK_AUD_DAC>,
+                 <&audsys CLK_AUD_DAC_PREDIS>,
+                 <&infracfg CLK_INFRA_AUDIO>,
+                 <&infracfg CLK_INFRA_AUDIO_26M_B>;
+        clock-names = "aud_afe_clk",
+                      "aud_dac_clk",
+                      "aud_dac_predis_clk",
+                      "aud_infra_clk",
+                      "aud_infra_26m_clk";
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml b/Documentation/devicetree/bindings/sound/mt8195-mt6359-rt1011-rt5682.yaml
new file mode 100644 (file)
index 0000000..d354c30
--- /dev/null
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/mt8195-mt6359-rt1011-rt5682.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek MT8195 with MT6359, RT1011 and RT5682 ASoC sound card driver
+
+maintainers:
+  - Trevor Wu <trevor.wu@mediatek.com>
+
+description:
+  This binding describes the MT8195 sound card with RT1011 and RT5682.
+
+properties:
+  compatible:
+    const: mediatek,mt8195_mt6359_rt1011_rt5682
+
+  mediatek,platform:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of MT8195 ASoC platform.
+
+  mediatek,dptx-codec:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of MT8195 Display Port Tx codec node.
+
+  mediatek,hdmi-codec:
+    $ref: "/schemas/types.yaml#/definitions/phandle"
+    description: The phandle of MT8195 HDMI codec node.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - mediatek,platform
+
+examples:
+  - |
+
+    sound: mt8195-sound {
+        compatible = "mediatek,mt8195_mt6359_rt1011_rt5682";
+        mediatek,platform = <&afe>;
+        pinctrl-names = "default";
+        pinctrl-0 = <&aud_pins_default>;
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/name-prefix.txt b/Documentation/devicetree/bindings/sound/name-prefix.txt
deleted file mode 100644 (file)
index 6457759..0000000
+++ /dev/null
@@ -1,24 +0,0 @@
-Name prefix:
-
-Card implementing the routing property define the connection between
-audio components as list of string pair. Component using the same
-sink/source names may use the name prefix property to prepend the
-name of their sinks/sources with the provided string.
-
-Optional name prefix property:
-- sound-name-prefix : string using as prefix for the sink/source names of
-                     the component.
-
-Example: Two instances of the same component.
-
-amp0: analog-amplifier@0 {
-       compatible = "simple-audio-amplifier";
-       enable-gpios = <&gpio GPIOH_3 0>;
-       sound-name-prefix = "FRONT";
-};
-
-amp1: analog-amplifier@1 {
-       compatible = "simple-audio-amplifier";
-       enable-gpios = <&gpio GPIOH_4 0>;
-       sound-name-prefix = "BACK";
-};
diff --git a/Documentation/devicetree/bindings/sound/name-prefix.yaml b/Documentation/devicetree/bindings/sound/name-prefix.yaml
new file mode 100644 (file)
index 0000000..2fe57f8
--- /dev/null
@@ -0,0 +1,21 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/name-prefix.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Component sound name prefix
+
+maintainers:
+  - Jerome Brunet <jbrunet@baylibre.com>
+
+properties:
+  sound-name-prefix:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: |
+      Card implementing the routing property define the connection between
+      audio components as list of string pair. Component using the same
+      sink/source names may use this property to prepend the name of their
+      sinks/sources with the provided string.
+
+additionalProperties: true
diff --git a/Documentation/devicetree/bindings/sound/nau8821.txt b/Documentation/devicetree/bindings/sound/nau8821.txt
new file mode 100644 (file)
index 0000000..6c3baf7
--- /dev/null
@@ -0,0 +1,55 @@
+Nuvoton NAU88L21 audio codec
+
+This device supports I2C only.
+
+Required properties:
+  - compatible : Must be "nuvoton,nau8821"
+
+  - reg : the I2C address of the device. This is either 0x1B (CSB=0) or 0x54 (CSB=1).
+
+Optional properties:
+  - nuvoton,jkdet-enable: Enable jack detection via JKDET pin.
+  - nuvoton,jkdet-pull-enable: Enable JKDET pin pull. If set - pin pull enabled,
+      otherwise pin in high impedance state.
+  - nuvoton,jkdet-pull-up: Pull-up JKDET pin. If set then JKDET pin is pull up, otherwise pull down.
+  - nuvoton,jkdet-polarity: JKDET pin polarity. 0 - active high, 1 - active low.
+
+  - nuvoton,vref-impedance: VREF Impedance selection
+      0 - Open
+      1 - 25 kOhm
+      2 - 125 kOhm
+      3 - 2.5 kOhm
+
+  - nuvoton,micbias-voltage: Micbias voltage level.
+      0 - VDDA
+      1 - VDDA
+      2 - VDDA * 1.1
+      3 - VDDA * 1.2
+      4 - VDDA * 1.3
+      5 - VDDA * 1.4
+      6 - VDDA * 1.53
+      7 - VDDA * 1.53
+
+  - nuvoton,jack-insert-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
+  - nuvoton,jack-eject-debounce: number from 0 to 7 that sets debounce time to 2^(n+2) ms
+
+  - nuvoton,dmic-clk-threshold: the ADC threshold of DMIC clock.
+
+
+Example:
+
+  headset: nau8821@1b {
+      compatible = "nuvoton,nau8821";
+      reg = <0x1b>;
+      interrupt-parent = <&gpio>;
+      interrupts = <23 IRQ_TYPE_LEVEL_LOW>;
+      nuvoton,jkdet-enable;
+      nuvoton,jkdet-pull-enable;
+      nuvoton,jkdet-pull-up;
+      nuvoton,jkdet-polarity = <GPIO_ACTIVE_LOW>;
+      nuvoton,vref-impedance = <2>;
+      nuvoton,micbias-voltage = <6>;
+      nuvoton,jack-insert-debounce = <7>;
+      nuvoton,jack-eject-debounce = <7>;
+      nuvoton,dmic-clk-threshold = 3072000;
+  };
index 5f6b37c..0912d3e 100644 (file)
@@ -17,6 +17,9 @@ maintainers:
   - Jon Hunter <jonathanh@nvidia.com>
   - Sameer Pujar <spujar@nvidia.com>
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   $nodename:
     pattern: "^dspk@[0-9a-f]*$"
@@ -48,12 +51,6 @@ properties:
 
   sound-name-prefix:
     pattern: "^DSPK[1-9]$"
-    $ref: /schemas/types.yaml#/definitions/string
-    description:
-      Used as prefix for sink/source names of the component. Must be a
-      unique string among multiple instances of the same component.
-      The name can be "DSPK1" or "DSPKx", where x depends on the maximum
-      available instances on a Tegra SoC.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-adx.yaml
new file mode 100644 (file)
index 0000000..c4ba12e
--- /dev/null
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nvidia,tegra210-adx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tegra210 ADX Device Tree Bindings
+
+description: |
+  The Audio Demultiplexer (ADX) block takes an input stream with up to
+  16 channels and demultiplexes it into four output streams of up to 16
+  channels each. A byte RAM helps to form output frames by any combination
+  of bytes from the input frame. Its design is identical to that of byte
+  RAM in the AMX except that the data flow direction is reversed.
+
+maintainers:
+  - Jon Hunter <jonathanh@nvidia.com>
+  - Mohan Kumar <mkumard@nvidia.com>
+  - Sameer Pujar <spujar@nvidia.com>
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+properties:
+  $nodename:
+    pattern: "^adx@[0-9a-f]*$"
+
+  compatible:
+    oneOf:
+      - const: nvidia,tegra210-adx
+      - items:
+          - enum:
+              - nvidia,tegra194-adx
+              - nvidia,tegra186-adx
+          - const: nvidia,tegra210-adx
+
+  reg:
+    maxItems: 1
+
+  sound-name-prefix:
+    pattern: "^ADX[1-9]$"
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    description: |
+      ADX has one input and four outputs. Accordingly ACIF (Audio Client
+      Interface) port nodes are defined to represent ADX input (port 0)
+      and outputs (ports 1 to 4). These are connected to corresponding
+      ports on AHUB (Audio Hub).
+    properties:
+      port@0:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: ADX ACIF input port
+    patternProperties:
+      '^port@[1-4]':
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: ADX ACIF output ports
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+
+    adx@702d3800 {
+        compatible = "nvidia,tegra210-adx";
+        reg = <0x702d3800 0x100>;
+        sound-name-prefix = "ADX1";
+    };
+
+...
index 1118a94..df81d20 100644 (file)
@@ -85,6 +85,26 @@ patternProperties:
     type: object
     $ref: nvidia,tegra186-dspk.yaml#
 
+  '^mvc@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-mvc.yaml#
+
+  '^sfc@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-sfc.yaml#
+
+  '^amx@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-amx.yaml#
+
+  '^adx@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-adx.yaml#
+
+  '^amixer@[0-9a-f]+$':
+    type: object
+    $ref: nvidia,tegra210-mixer.yaml#
+
 required:
   - compatible
   - reg
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-amx.yaml
new file mode 100644 (file)
index 0000000..bb2111a
--- /dev/null
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nvidia,tegra210-amx.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tegra210 AMX Device Tree Bindings
+
+description: |
+  The Audio Multiplexer (AMX) block can multiplex up to four input streams
+  each of which can have maximum 16 channels and generate an output stream
+  with maximum 16 channels. A byte RAM helps to form an output frame by
+  any combination of bytes from the input frames.
+
+maintainers:
+  - Jon Hunter <jonathanh@nvidia.com>
+  - Mohan Kumar <mkumard@nvidia.com>
+  - Sameer Pujar <spujar@nvidia.com>
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+properties:
+  $nodename:
+    pattern: "^amx@[0-9a-f]*$"
+
+  compatible:
+    oneOf:
+      - const: nvidia,tegra210-amx
+      - items:
+          - const: nvidia,tegra186-amx
+          - const: nvidia,tegra210-amx
+      - const: nvidia,tegra194-amx
+
+  reg:
+    maxItems: 1
+
+  sound-name-prefix:
+    pattern: "^AMX[1-9]$"
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    description: |
+      AMX has four inputs and one output. Accordingly ACIF (Audio Client
+      Interfaces) port nodes are defined to represent AMX inputs (port 0
+      to 3) and output (port 4). These are connected to corresponding
+      ports on AHUB (Audio Hub).
+
+    patternProperties:
+      '^port@[0-3]':
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: AMX ACIF input ports
+
+    properties:
+      port@4:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: AMX ACIF output port
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+
+    amx@702d3000 {
+        compatible = "nvidia,tegra210-amx";
+        reg = <0x702d3000 0x100>;
+        sound-name-prefix = "AMX1";
+    };
+
+...
index fd275a5..62db982 100644 (file)
@@ -16,6 +16,9 @@ maintainers:
   - Jon Hunter <jonathanh@nvidia.com>
   - Sameer Pujar <spujar@nvidia.com>
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   $nodename:
     pattern: "^dmic@[0-9a-f]*$"
@@ -49,12 +52,6 @@ properties:
 
   sound-name-prefix:
     pattern: "^DMIC[1-9]$"
-    $ref: /schemas/types.yaml#/definitions/string
-    description:
-      used as prefix for sink/source names of the component. Must be a
-      unique string among multiple instances of the same component.
-      The name can be "DMIC1" or "DMIC2" ... "DMICx", where x depends
-      on the maximum available instances on a Tegra SoC.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
index 6337070..f954be6 100644 (file)
@@ -16,6 +16,9 @@ maintainers:
   - Jon Hunter <jonathanh@nvidia.com>
   - Sameer Pujar <spujar@nvidia.com>
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   $nodename:
     pattern: "^i2s@[0-9a-f]*$"
@@ -65,12 +68,6 @@ properties:
 
   sound-name-prefix:
     pattern: "^I2S[1-9]$"
-    $ref: /schemas/types.yaml#/definitions/string
-    description:
-      Used as prefix for sink/source names of the component. Must be a
-      unique string among multiple instances of the same component.
-      The name can be "I2S1" or "I2S2" ... "I2Sx", where x depends
-      on the maximum available instances on a Tegra SoC.
 
   ports:
     $ref: /schemas/graph.yaml#/properties/ports
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mixer.yaml
new file mode 100644 (file)
index 0000000..428f3c8
--- /dev/null
@@ -0,0 +1,74 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mixer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tegra210 Mixer Device Tree Bindings
+
+description: |
+  The Mixer supports mixing of up to ten 7.1 audio input streams and
+  generate five outputs (each of which can be any combination of the
+  ten input streams).
+
+maintainers:
+  - Jon Hunter <jonathanh@nvidia.com>
+  - Mohan Kumar <mkumard@nvidia.com>
+  - Sameer Pujar <spujar@nvidia.com>
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+properties:
+  $nodename:
+    pattern: "^amixer@[0-9a-f]*$"
+
+  compatible:
+    oneOf:
+      - const: nvidia,tegra210-amixer
+      - items:
+          - enum:
+              - nvidia,tegra194-amixer
+              - nvidia,tegra186-amixer
+          - const: nvidia,tegra210-amixer
+
+  reg:
+    maxItems: 1
+
+  sound-name-prefix:
+    pattern: "^MIXER[1-9]$"
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    description: |
+      Mixer has ten inputs and five outputs. Accordingly ACIF (Audio
+      Client Interfaces) port nodes are defined to represent Mixer
+      inputs (port 0 to 9) and outputs (port 10 to 14). These are
+      connected to corresponding ports on AHUB (Audio Hub).
+
+    patternProperties:
+      '^port@[0-9]':
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: Mixer ACIF input ports
+      '^port@[10-14]':
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: Mixer ACIF output ports
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+
+    amixer@702dbb00 {
+        compatible = "nvidia,tegra210-amixer";
+        reg = <0x702dbb00 0x800>;
+        sound-name-prefix = "MIXER1";
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-mvc.yaml
new file mode 100644 (file)
index 0000000..e2f5a85
--- /dev/null
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nvidia,tegra210-mvc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tegra210 MVC Device Tree Bindings
+
+description: |
+  The Master Volume Control (MVC) provides gain or attenuation to a digital
+  signal path. It can be used in input or output signal path for per-stream
+  volume control or it can be used as master volume control. The MVC block
+  has one input and one output. The input digital stream can be mono or
+  multi-channel (up to 7.1 channels) stream. An independent mute control is
+  also included in the MVC block.
+
+maintainers:
+  - Jon Hunter <jonathanh@nvidia.com>
+  - Mohan Kumar <mkumard@nvidia.com>
+  - Sameer Pujar <spujar@nvidia.com>
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+properties:
+  $nodename:
+    pattern: "^mvc@[0-9a-f]*$"
+
+  compatible:
+    oneOf:
+      - const: nvidia,tegra210-mvc
+      - items:
+          - enum:
+              - nvidia,tegra194-mvc
+              - nvidia,tegra186-mvc
+          - const: nvidia,tegra210-mvc
+
+  reg:
+    maxItems: 1
+
+  sound-name-prefix:
+    pattern: "^MVC[1-9]$"
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    properties:
+      port@0:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: |
+          MVC ACIF (Audio Client Interface) input port. This is connected
+          to corresponding ACIF output port on AHUB (Audio Hub).
+
+      port@1:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: |
+          MVC ACIF output port. This is connected to corresponding ACIF
+          input port on AHUB.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+
+    mvc@702da000 {
+        compatible = "nvidia,tegra210-mvc";
+        reg = <0x702da000 0x200>;
+        sound-name-prefix = "MVC1";
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-sfc.yaml
new file mode 100644 (file)
index 0000000..41ad651
--- /dev/null
@@ -0,0 +1,73 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/nvidia,tegra210-sfc.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Tegra210 SFC Device Tree Bindings
+
+description: |
+  The Sampling Frequency Converter (SFC) converts the sampling frequency
+  of the input signal from one frequency to another. It supports sampling
+  frequency conversions of streams of up to two channels (stereo).
+
+maintainers:
+  - Jon Hunter <jonathanh@nvidia.com>
+  - Mohan Kumar <mkumard@nvidia.com>
+  - Sameer Pujar <spujar@nvidia.com>
+
+allOf:
+  - $ref: name-prefix.yaml#
+
+properties:
+  $nodename:
+    pattern: "^sfc@[0-9a-f]*$"
+
+  compatible:
+    oneOf:
+      - const: nvidia,tegra210-sfc
+      - items:
+          - enum:
+              - nvidia,tegra194-sfc
+              - nvidia,tegra186-sfc
+          - const: nvidia,tegra210-sfc
+
+  reg:
+    maxItems: 1
+
+  sound-name-prefix:
+    pattern: "^SFC[1-9]$"
+
+  ports:
+    $ref: /schemas/graph.yaml#/properties/ports
+    properties:
+      port@0:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: |
+          SFC ACIF (Audio Client Interface) input port. This is connected
+          to corresponding ACIF output port on AHUB (Audio Hub).
+
+      port@1:
+        $ref: audio-graph-port.yaml#
+        unevaluatedProperties: false
+        description: |
+          SFC ACIF output port. This is connected to corresponding ACIF
+          input port on AHUB.
+
+required:
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+
+    sfc@702d2000 {
+        compatible = "nvidia,tegra210-sfc";
+        reg = <0x702d2000 0x200>;
+        sound-name-prefix = "SFC1";
+    };
+
+...
index ffb8fcf..7667471 100644 (file)
@@ -9,6 +9,9 @@ title: NXP/Goodix TFA989X (TFA1) Audio Amplifiers
 maintainers:
   - Stephan Gerhold <stephan@gerhold.net>
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   compatible:
     enum:
@@ -21,11 +24,7 @@ properties:
   '#sound-dai-cells':
     const: 0
 
-  sound-name-prefix:
-    $ref: /schemas/types.yaml#/definitions/string
-    description:
-      Used as prefix for sink/source names of the component. Must be a
-      unique string among multiple instances of the same component.
+  sound-name-prefix: true
 
   vddd-supply:
     description: regulator phandle for the VDDD power supply.
index 443d556..bc762b3 100644 (file)
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,sm8250-lpass-rx-macro
+    enum:
+      - qcom,sc7280-lpass-rx-macro
+      - qcom,sm8250-lpass-rx-macro
 
   reg:
     maxItems: 1
index 6b5ca02..74f5386 100644 (file)
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,sm8250-lpass-tx-macro
+    enum:
+      - qcom,sc7280-lpass-tx-macro
+      - qcom,sm8250-lpass-tx-macro
 
   reg:
     maxItems: 1
index 679b49c..99f2c36 100644 (file)
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,sm8250-lpass-va-macro
+    enum:
+      - qcom,sc7280-lpass-va-macro
+      - qcom,sm8250-lpass-va-macro
 
   reg:
     maxItems: 1
index 435b019..13cdb8a 100644 (file)
@@ -11,7 +11,9 @@ maintainers:
 
 properties:
   compatible:
-    const: qcom,sm8250-lpass-wsa-macro
+    enum:
+      - qcom,sc7280-lpass-wsa-macro
+      - qcom,sm8250-lpass-wsa-macro
 
   reg:
     maxItems: 1
index 2d6fb2e..bc6b5f1 100644 (file)
@@ -12,190 +12,9 @@ used by all apr services. Must contain the following properties.
                  from DSP.
                  example "qcom,q6afe"
 
-= AFE DAIs (Digial Audio Interface)
-"dais" subnode of the AFE node. It represents afe dais, each afe dai is a
-subnode of "dais" representing board specific dai setup.
-"dais" node should have following properties followed by dai children.
-
-- compatible:
-       Usage: required
-       Value type: <stringlist>
-       Definition: must be "qcom,q6afe-dais"
-
-- #sound-dai-cells
-       Usage: required
-       Value type: <u32>
-       Definition: Must be 1
-
-- #address-cells
-       Usage: required
-       Value type: <u32>
-       Definition: Must be 1
-
-- #size-cells
-       Usage: required
-       Value type: <u32>
-       Definition: Must be 0
-
-== AFE DAI is subnode of "dais" and represent a dai, it includes board specific
-configuration of each dai. Must contain the following properties.
-
-- reg
-       Usage: required
-       Value type: <u32>
-       Definition: Must be dai id
-
-- qcom,sd-lines
-       Usage: required for mi2s interface
-       Value type: <prop-encoded-array>
-       Definition: Must be list of serial data lines used by this dai.
-       should be one or more of the 0-3 sd lines.
-
- - qcom,tdm-sync-mode:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Synchronization mode.
-               0 - Short sync bit mode
-               1 - Long sync mode
-               2 - Short sync slot mode
-
- - qcom,tdm-sync-src:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Synchronization source.
-               0 - External source
-               1 - Internal source
-
- - qcom,tdm-data-out:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Data out signal to drive with other masters.
-               0 - Disable
-               1 - Enable
-
- - qcom,tdm-invert-sync:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Invert the sync.
-               0 - Normal
-               1 - Invert
-
- - qcom,tdm-data-delay:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Number of bit clock to delay data
-               with respect to sync edge.
-               0 - 0 bit clock cycle
-               1 - 1 bit clock cycle
-               2 - 2 bit clock cycle
-
- - qcom,tdm-data-align:
-       Usage: required for tdm interface
-       Value type: <prop-encoded-array>
-       Definition: Indicate how data is packed
-               within the slot. For example, 32 slot width in case of
-               sample bit width is 24.
-               0 - MSB
-               1 - LSB
-
-= AFE CLOCKSS
-"clocks" subnode of the AFE node. It represents q6afe clocks
-"clocks" node should have following properties.
-- compatible:
-       Usage: required
-       Value type: <stringlist>
-       Definition: must be "qcom,q6afe-clocks"
-
-- #clock-cells:
-       Usage: required
-       Value type: <u32>
-       Definition: Must be 2. Clock Id followed by
-               below valid clock coupling attributes.
-               1 - for no coupled clock
-               2 - for dividend of the coupled clock
-               3 - for divisor of the coupled clock
-               4 - for inverted and no couple clock
-
 = EXAMPLE
 
 apr-service@4 {
        compatible = "qcom,q6afe";
        reg = <APR_SVC_AFE>;
-
-       dais {
-               compatible = "qcom,q6afe-dais";
-               #sound-dai-cells = <1>;
-               #address-cells = <1>;
-               #size-cells = <0>;
-
-               dai@1 {
-                       reg = <HDMI_RX>;
-               };
-
-               dai@24 {
-                       reg = <PRIMARY_TDM_RX_0>;
-                       qcom,tdm-sync-mode = <1>:
-                       qcom,tdm-sync-src = <1>;
-                       qcom,tdm-data-out = <0>;
-                       qcom,tdm-invert-sync = <1>;
-                       qcom,tdm-data-delay = <1>;
-                       qcom,tdm-data-align = <0>;
-
-               };
-
-               dai@25 {
-                       reg = <PRIMARY_TDM_TX_0>;
-                       qcom,tdm-sync-mode = <1>:
-                       qcom,tdm-sync-src = <1>;
-                       qcom,tdm-data-out = <0>;
-                       qcom,tdm-invert-sync = <1>;
-                       qcom,tdm-data-delay <1>:
-                       qcom,tdm-data-align = <0>;
-               };
-
-               dai@16 {
-                       reg = <PRIMARY_MI2S_RX>;
-                       qcom,sd-lines = <0 2>;
-               };
-
-               dai@17 {
-                       reg = <PRIMARY_MI2S_TX>;
-                       qcom,sd-lines = <1>;
-               };
-
-               dai@18 {
-                       reg = <SECONDARY_MI2S_RX>;
-                       qcom,sd-lines = <0 3>;
-               };
-
-               dai@19 {
-                       reg = <SECONDARY_MI2S_TX>;
-                       qcom,sd-lines = <1>;
-               };
-
-               dai@20 {
-                       reg = <TERTIARY_MI2S_RX>;
-                       qcom,sd-lines = <1 3>;
-               };
-
-               dai@21 {
-                       reg = <TERTIARY_MI2S_TX>;
-                       qcom,sd-lines = <0>;
-               };
-
-               dai@22 {
-                       reg = <QUATERNARY_MI2S_RX>;
-                       qcom,sd-lines = <0>;
-               };
-
-               dai@23 {
-                       reg = <QUATERNARY_MI2S_TX>;
-                       qcom,sd-lines = <1>;
-               };
-       };
-
-       clocks {
-               compatible = "qcom,q6afe-clocks";
-               #clock-cells = <2>;
-       };
 };
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm-dai.yaml
new file mode 100644 (file)
index 0000000..5d97278
--- /dev/null
@@ -0,0 +1,53 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/sound/qcom,q6apm-dai.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm Audio Process Manager Digital Audio Interfaces binding
+
+maintainers:
+  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+description: |
+  This binding describes the Qualcomm APM DAIs in DSP
+
+properties:
+  compatible:
+    const: qcom,q6apm-dais
+
+  reg:
+    maxItems: 1
+
+  iommus:
+    maxItems: 1
+
+required:
+  - compatible
+  - iommus
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/soc/qcom,gpr.h>
+    gpr {
+        compatible = "qcom,gpr";
+        #address-cells = <1>;
+        #size-cells = <0>;
+        qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+        service@1 {
+          compatible = "qcom,q6apm";
+          reg = <1>;
+
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          apm-dai@1 {
+            compatible = "qcom,q6apm-dais";
+            iommus = <&apps_smmu 0x1801 0x0>;
+            reg = <1>;
+          };
+        };
+    };
index 8c4883b..0d00751 100644 (file)
@@ -14,7 +14,7 @@ used by the apr service device.
                    from DSP.
                    example "qcom,q6asm-v2.0"
 
-= ASM DAIs (Digial Audio Interface)
+= ASM DAIs (Digital Audio Interface)
 "dais" subnode of the ASM node represents dai specific configuration
 
 - compatible:
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-clocks.yaml
new file mode 100644 (file)
index 0000000..f83f007
--- /dev/null
@@ -0,0 +1,77 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/sound/qcom,q6dsp-lpass-clocks.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm DSP LPASS Clock Controller binding
+
+maintainers:
+  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+description: |
+  This binding describes the Qualcomm DSP Clock Controller
+
+properties:
+  compatible:
+    enum:
+      - qcom,q6afe-clocks
+      - qcom,q6prm-lpass-clocks
+
+  reg:
+    maxItems: 1
+
+  '#clock-cells':
+    const: 2
+    description:
+      Clock Id is followed by clock coupling attributes.
+        1 = for no coupled clock
+        2 = for dividend of the coupled clock
+        3 = for divisor of the coupled clock
+        4 = for inverted and no couple clock
+
+required:
+  - compatible
+  - reg
+  - "#clock-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/soc/qcom,apr.h>
+    #include <dt-bindings/sound/qcom,q6afe.h>
+    apr {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        apr-service@4 {
+            reg = <APR_SVC_AFE>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            clock-controller@2 {
+              compatible = "qcom,q6afe-clocks";
+              reg = <2>;
+              #clock-cells = <2>;
+            };
+        };
+      };
+
+  - |
+    #include <dt-bindings/soc/qcom,gpr.h>
+    gpr {
+        compatible = "qcom,gpr";
+        qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+        #address-cells = <1>;
+        #size-cells = <0>;
+        service@2 {
+            reg = <GPR_PRM_MODULE_IID>;
+            compatible = "qcom,q6prm";
+            #address-cells = <1>;
+            #size-cells = <0>;
+            clock-controller@2 {
+              compatible = "qcom,q6prm-lpass-clocks";
+              reg = <2>;
+              #clock-cells = <2>;
+            };
+        };
+      };
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-ports.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-lpass-ports.yaml
new file mode 100644 (file)
index 0000000..dc7fba7
--- /dev/null
@@ -0,0 +1,205 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/sound/qcom,q6dsp-lpass-ports.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Qualcomm DSP LPASS(Low Power Audio SubSystem) Audio Ports binding
+
+maintainers:
+  - Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
+
+description: |
+  This binding describes the Qualcomm DSP LPASS Audio ports
+
+properties:
+  compatible:
+    enum:
+      - qcom,q6afe-dais
+      - qcom,q6apm-lpass-dais
+
+  reg:
+    maxItems: 1
+
+  '#sound-dai-cells':
+    const: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
+#Digital Audio Interfaces
+patternProperties:
+  '^dai@[0-9]+$':
+    type: object
+    description:
+      Q6DSP Digital Audio Interfaces.
+
+    properties:
+      reg:
+        description:
+          Digital Audio Interface ID
+
+      qcom,sd-lines:
+        $ref: /schemas/types.yaml#/definitions/uint32-array
+        description:
+          List of serial data lines used by this dai.should be one or more of the 0-3 sd lines.
+        minItems: 1
+        maxItems: 4
+        uniqueItems: true
+        items:
+          minimum: 0
+          maximum: 3
+
+      qcom,tdm-sync-mode:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1, 2]
+        description:
+          TDM Synchronization mode
+            0 = Short sync bit mode
+            1 = Long sync mode
+            2 = Short sync slot mode
+
+      qcom,tdm-sync-src:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1]
+        description:
+          TDM Synchronization source
+            0 = External source
+            1 = Internal source
+
+      qcom,tdm-data-out:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1]
+        description:
+          TDM Data out signal to drive with other masters
+            0 = Disable
+            1 = Enable
+
+      qcom,tdm-invert-sync:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1]
+        description:
+          TDM Invert the sync
+            0 = Normal
+            1 = Invert
+
+      qcom,tdm-data-delay:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1, 2]
+        description:
+          TDM Number of bit clock to delay data
+            0 = 0 bit clock cycle
+            1 = 1 bit clock cycle
+            2 = 2 bit clock cycle
+
+      qcom,tdm-data-align:
+        $ref: /schemas/types.yaml#/definitions/uint32
+        enum: [0, 1]
+        description:
+          Indicate how data is packed within the slot. For example, 32 slot
+          width in case of sample bit width is 24TDM Invert the sync.
+            0 = MSB
+            1 = LSB
+
+    required:
+      - reg
+
+    allOf:
+      - if:
+          properties:
+            reg:
+              contains:
+                # TDM DAI ID range from PRIMARY_TDM_RX_0 - QUINARY_TDM_TX_7
+                items:
+                  minimum: 24
+                  maximum: 103
+        then:
+          required:
+            - qcom,tdm-sync-mode
+            - qcom,tdm-sync-src
+            - qcom,tdm-data-out
+            - qcom,tdm-invert-sync
+            - qcom,tdm-data-delay
+            - qcom,tdm-data-align
+
+      - if:
+          properties:
+            reg:
+              contains:
+                # MI2S DAI ID range PRIMARY_MI2S_RX - QUATERNARY_MI2S_TX and
+                # QUINARY_MI2S_RX - QUINARY_MI2S_TX
+                items:
+                  oneOf:
+                    - minimum: 16
+                      maximum: 23
+                    - minimum: 127
+                      maximum: 128
+        then:
+          required:
+            - qcom,sd-lines
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - "#sound-dai-cells"
+  - "#address-cells"
+  - "#size-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/soc/qcom,apr.h>
+    #include <dt-bindings/sound/qcom,q6afe.h>
+    apr {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        apr-service@4 {
+            reg = <APR_SVC_AFE>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            q6afedai@1 {
+              compatible = "qcom,q6afe-dais";
+              reg = <1>;
+              #address-cells = <1>;
+              #size-cells = <0>;
+              #sound-dai-cells = <1>;
+
+              dai@22 {
+                reg = <QUATERNARY_MI2S_RX>;
+                qcom,sd-lines = <0 1 2 3>;
+              };
+            };
+        };
+      };
+  - |
+    #include <dt-bindings/soc/qcom,gpr.h>
+    gpr {
+        compatible = "qcom,gpr";
+        #address-cells = <1>;
+        #size-cells = <0>;
+        qcom,domain = <GPR_DOMAIN_ID_ADSP>;
+        service@1 {
+            compatible = "qcom,q6apm";
+            reg = <GPR_APM_MODULE_IID>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+            q6apmdai@1 {
+              compatible = "qcom,q6apm-lpass-dais";
+              reg = <1>;
+              #address-cells = <1>;
+              #size-cells = <0>;
+              #sound-dai-cells = <1>;
+
+              dai@22 {
+                reg = <QUATERNARY_MI2S_RX>;
+                qcom,sd-lines = <0 1 2 3>;
+              };
+            };
+        };
+      };
diff --git a/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml b/Documentation/devicetree/bindings/sound/realtek,rt5682s.yaml
new file mode 100644 (file)
index 0000000..2b8b7b5
--- /dev/null
@@ -0,0 +1,117 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/realtek,rt5682s.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek rt5682s codec devicetree bindings
+
+maintainers:
+  - Derek Fang <derek.fang@realtek.com>
+
+description: |
+  Rt5682s(ALC5682I-VS) is a rt5682i variant which supports I2C only.
+
+properties:
+  compatible:
+    const: realtek,rt5682s
+
+  reg:
+    maxItems: 1
+    description: I2C address of the device.
+
+  interrupts:
+    description: The CODEC's interrupt output.
+
+  realtek,dmic1-data-pin:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum:
+      - 0 # dmic1 data is not used
+      - 1 # using GPIO2 pin as dmic1 data pin
+      - 2 # using GPIO5 pin as dmic1 data pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 data pin.
+
+  realtek,dmic1-clk-pin:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum:
+      - 0 # dmic1 clk is not used
+      - 1 # using GPIO1 pin as dmic1 clock pin
+      - 2 # using GPIO3 pin as dmic1 clock pin
+    description: |
+      Specify which GPIO pin be used as DMIC1 clk pin.
+
+  realtek,jd-src:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    enum:
+      - 0 # No JD is used
+      - 1 # using JD1 as JD source
+    description: |
+      Specify which JD source be used.
+
+  realtek,ldo1-en-gpios:
+    description: |
+      The GPIO that controls the CODEC's LDO1_EN pin.
+
+  realtek,dmic-clk-rate-hz:
+    description: |
+      Set the clock rate (hz) for the requirement of the particular DMIC.
+
+  realtek,dmic-delay-ms:
+    description: |
+      Set the delay time (ms) for the requirement of the particular DMIC.
+
+  realtek,dmic-clk-driving-high:
+    type: boolean
+    description: |
+      Set the high driving of the DMIC clock out.
+
+  clocks:
+    items:
+      - description: phandle and clock specifier for codec MCLK.
+
+  clock-names:
+    items:
+      - const: mclk
+
+  "#clock-cells":
+    const: 1
+
+  clock-output-names:
+    minItems: 2
+    maxItems: 2
+    description: Name given for DAI word clock and bit clock outputs.
+
+additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+examples:
+  - |
+    #include <dt-bindings/gpio/tegra-gpio.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            compatible = "realtek,rt5682s";
+            reg = <0x1a>;
+            interrupt-parent = <&gpio>;
+            interrupts = <TEGRA_GPIO(U, 6) IRQ_TYPE_LEVEL_HIGH>;
+            realtek,ldo1-en-gpios =
+                <&gpio TEGRA_GPIO(R, 2) GPIO_ACTIVE_HIGH>;
+            realtek,dmic1-data-pin = <1>;
+            realtek,dmic1-clk-pin = <1>;
+            realtek,jd-src = <1>;
+
+            #clock-cells = <1>;
+            clock-output-names = "rt5682-dai-wclk", "rt5682-dai-bclk";
+
+            clocks = <&osc>;
+            clock-names = "mclk";
+        };
+    };
diff --git a/Documentation/devicetree/bindings/sound/richtek,rt9120.yaml b/Documentation/devicetree/bindings/sound/richtek,rt9120.yaml
new file mode 100644 (file)
index 0000000..5655ca5
--- /dev/null
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/richtek,rt9120.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Richtek RT9120 Class-D audio amplifier
+
+maintainers:
+  - ChiYuan Huang <cy_huang@richtek.com>
+
+description: |
+  The RT9120 is a high efficiency, I2S-input, stereo audio power amplifier
+  delivering 2*20W into 8 Ohm BTL speaker loads. It supports the wide input
+  voltage  range from 4.5V to 26.4V to meet the need on most common
+  applications like as TV, monitors. home entertainment, electronic music
+  equipment.
+
+properties:
+  compatible:
+    enum:
+      - richtek,rt9120
+
+  reg:
+    description: I2C device address
+    maxItems: 1
+
+  pwdnn-gpios:
+    description: GPIO used for power down, low active
+    maxItems: 1
+
+  dvdd-supply:
+    description: |
+      Supply for the default on DVDD power, voltage domain must be 3P3V or 1P8V
+
+  '#sound-dai-cells':
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - dvdd-supply
+  - '#sound-dai-cells'
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c {
+      #address-cells = <1>;
+      #size-cells = <0>;
+      rt9120@1a {
+        compatible = "richtek,rt9120";
+        reg = <0x1a>;
+        pwdnn-gpios = <&gpio26 2 0>;
+        dvdd-supply = <&vdd_io_reg>;
+        #sound-dai-cells = <0>;
+      };
+    };
diff --git a/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
new file mode 100644 (file)
index 0000000..6a7c004
--- /dev/null
@@ -0,0 +1,182 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/rockchip,i2s-tdm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip I2S/TDM Controller
+
+description:
+  The Rockchip I2S/TDM Controller is a Time Division Multiplexed
+  audio interface found in various Rockchip SoCs, allowing up
+  to 8 channels of audio over a serial interface.
+
+maintainers:
+  - Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
+
+properties:
+  compatible:
+    enum:
+      - rockchip,px30-i2s-tdm
+      - rockchip,rk1808-i2s-tdm
+      - rockchip,rk3308-i2s-tdm
+      - rockchip,rk3568-i2s-tdm
+      - rockchip,rv1126-i2s-tdm
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  dmas:
+    minItems: 1
+    maxItems: 2
+
+  dma-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      enum:
+        - rx
+        - tx
+
+  clocks:
+    minItems: 3
+    items:
+      - description: clock for TX
+      - description: clock for RX
+      - description: AHB clock driving the interface
+      - description:
+          Parent clock for mclk_tx (only required when using mclk-calibrate)
+      - description:
+          Parent clock for mclk_rx (only required when using mclk-calibrate)
+      - description:
+          Clock for sample rates that are an integer multiple of 8000
+          (only required when using mclk-calibrate)
+      - description:
+          Clock for sample rates that are an integer multiple of 11025
+          (only required when using mclk-calibrate)
+
+  clock-names:
+    minItems: 3
+    items:
+      - const: mclk_tx
+      - const: mclk_rx
+      - const: hclk
+      - const: mclk_tx_src
+      - const: mclk_rx_src
+      - const: mclk_root0
+      - const: mclk_root1
+
+  resets:
+    minItems: 1
+    maxItems: 2
+    description: resets for the tx and rx directions
+
+  reset-names:
+    minItems: 1
+    maxItems: 2
+    items:
+      enum:
+        - tx-m
+        - rx-m
+
+  rockchip,grf:
+    $ref: /schemas/types.yaml#/definitions/phandle
+    description:
+      The phandle of the syscon node for the GRF register.
+
+  rockchip,trcm-sync-tx-only:
+    type: boolean
+    description: Use TX BCLK/LRCK for both TX and RX.
+
+  rockchip,trcm-sync-rx-only:
+    type: boolean
+    description: Use RX BCLK/LRCK for both TX and RX.
+
+  "#sound-dai-cells":
+    const: 0
+
+  rockchip,i2s-rx-route:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      Defines the mapping of I2S RX sdis to I2S data bus lines.
+      By default, they are mapped one-to-one.
+      rockchip,i2s-rx-route = <3> would mean sdi3 is receiving from data0.
+    maxItems: 4
+    items:
+      enum: [0, 1, 2, 3]
+
+  rockchip,i2s-tx-route:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      Defines the mapping of I2S TX sdos to I2S data bus lines.
+      By default, they are mapped one-to-one.
+      rockchip,i2s-tx-route = <3> would mean sdo3 is sending to data0.
+    maxItems: 4
+    items:
+      enum: [0, 1, 2, 3]
+
+  rockchip,io-multiplex:
+    description:
+      Specify that the GPIO lines on the I2S bus are multiplexed such that
+      the direction (input/output) needs to be dynamically adjusted.
+    type: boolean
+
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - dmas
+  - dma-names
+  - clocks
+  - clock-names
+  - resets
+  - reset-names
+  - rockchip,grf
+  - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/rk3568-cru.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/pinctrl/rockchip.h>
+
+    bus {
+        #address-cells = <2>;
+        #size-cells = <2>;
+        i2s@fe410000 {
+            compatible = "rockchip,rk3568-i2s-tdm";
+            reg = <0x0 0xfe410000 0x0 0x1000>;
+            interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
+            clocks = <&cru MCLK_I2S1_8CH_TX>, <&cru MCLK_I2S1_8CH_RX>,
+                     <&cru HCLK_I2S1_8CH>;
+            clock-names = "mclk_tx", "mclk_rx", "hclk";
+            dmas = <&dmac1 3>, <&dmac1 2>;
+            dma-names = "rx", "tx";
+            resets = <&cru SRST_M_I2S1_8CH_TX>, <&cru SRST_M_I2S1_8CH_RX>;
+            reset-names = "tx-m", "rx-m";
+            rockchip,trcm-sync-tx-only;
+            rockchip,grf = <&grf>;
+            #sound-dai-cells = <0>;
+            pinctrl-names = "default";
+            pinctrl-0 =
+                <&i2s1m0_sclktx
+                &i2s1m0_sclkrx
+                &i2s1m0_lrcktx
+                &i2s1m0_lrckrx
+                &i2s1m0_sdi0
+                &i2s1m0_sdi1
+                &i2s1m0_sdi2
+                &i2s1m0_sdi3
+                &i2s1m0_sdo0
+                &i2s1m0_sdo1
+                &i2s1m0_sdo2
+                &i2s1m0_sdo3>;
+        };
+    };
diff --git a/Documentation/devicetree/bindings/sound/rockchip,pdm.txt b/Documentation/devicetree/bindings/sound/rockchip,pdm.txt
deleted file mode 100644 (file)
index 98572a2..0000000
+++ /dev/null
@@ -1,46 +0,0 @@
-* Rockchip PDM controller
-
-Required properties:
-
-- compatible: "rockchip,pdm"
-  - "rockchip,px30-pdm"
-  - "rockchip,rk1808-pdm"
-  - "rockchip,rk3308-pdm"
-- reg: physical base address of the controller and length of memory mapped
-  region.
-- dmas: DMA specifiers for rx dma. See the DMA client binding,
-       Documentation/devicetree/bindings/dma/dma.txt
-- dma-names: should include "rx".
-- clocks: a list of phandle + clock-specifer pairs, one for each entry in clock-names.
-- clock-names: should contain following:
-   - "pdm_hclk": clock for PDM BUS
-   - "pdm_clk" : clock for PDM controller
-- resets: a list of phandle + reset-specifer paris, one for each entry in reset-names.
-- reset-names: reset names, should include "pdm-m".
-- pinctrl-names: Must contain a "default" entry.
-- pinctrl-N: One property must exist for each entry in
-            pinctrl-names. See ../pinctrl/pinctrl-bindings.txt
-            for details of the property values.
-
-Example for rk3328 PDM controller:
-
-pdm: pdm@ff040000 {
-       compatible = "rockchip,pdm";
-       reg = <0x0 0xff040000 0x0 0x1000>;
-       clocks = <&clk_pdm>, <&clk_gates28 0>;
-       clock-names = "pdm_clk", "pdm_hclk";
-       dmas = <&pdma 16>;
-       #dma-cells = <1>;
-       dma-names = "rx";
-       pinctrl-names = "default", "sleep";
-       pinctrl-0 = <&pdmm0_clk
-                    &pdmm0_sdi0
-                    &pdmm0_sdi1
-                    &pdmm0_sdi2
-                    &pdmm0_sdi3>;
-       pinctrl-1 = <&pdmm0_clk_sleep
-                    &pdmm0_sdi0_sleep
-                    &pdmm0_sdi1_sleep
-                    &pdmm0_sdi2_sleep
-                    &pdmm0_sdi3_sleep>;
-};
diff --git a/Documentation/devicetree/bindings/sound/rockchip,pdm.yaml b/Documentation/devicetree/bindings/sound/rockchip,pdm.yaml
new file mode 100644 (file)
index 0000000..22e1cf6
--- /dev/null
@@ -0,0 +1,120 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/rockchip,pdm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Rockchip PDM controller
+
+description:
+  The Pulse Density Modulation Interface Controller (PDMC) is
+  a PDM interface controller and decoder that support PDM format.
+  It integrates a clock generator driving the PDM microphone
+  and embeds filters which decimate the incoming bit stream to
+  obtain most common audio rates.
+
+maintainers:
+  - Heiko Stuebner <heiko@sntech.de>
+
+properties:
+  compatible:
+    enum:
+      - rockchip,pdm
+      - rockchip,px30-pdm
+      - rockchip,rk1808-pdm
+      - rockchip,rk3308-pdm
+      - rockchip,rk3568-pdm
+      - rockchip,rv1126-pdm
+
+  reg:
+    maxItems: 1
+
+  interrupts:
+    maxItems: 1
+
+  clocks:
+    items:
+      - description: clock for PDM controller
+      - description: clock for PDM BUS
+
+  clock-names:
+    items:
+      - const: pdm_clk
+      - const: pdm_hclk
+
+  dmas:
+    maxItems: 1
+
+  dma-names:
+    items:
+      - const: rx
+
+  power-domains:
+    maxItems: 1
+
+  resets:
+    items:
+      - description: reset for PDM controller
+
+  reset-names:
+    items:
+      - const: pdm-m
+
+  rockchip,path-map:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    description:
+      Defines the mapping of PDM SDIx to PDM PATHx.
+      By default, they are mapped one-to-one.
+    maxItems: 4
+    uniqueItems: true
+    items:
+      enum: [ 0, 1, 2, 3 ]
+
+  "#sound-dai-cells":
+    const: 0
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - clocks
+  - clock-names
+  - dmas
+  - dma-names
+  - "#sound-dai-cells"
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/rk3328-cru.h>
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/interrupt-controller/irq.h>
+    #include <dt-bindings/pinctrl/rockchip.h>
+
+    bus {
+        #address-cells = <2>;
+        #size-cells = <2>;
+
+        pdm@ff040000 {
+            compatible = "rockchip,pdm";
+            reg = <0x0 0xff040000 0x0 0x1000>;
+            interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
+            clocks = <&cru SCLK_PDM>, <&cru HCLK_PDM>;
+            clock-names = "pdm_clk", "pdm_hclk";
+            dmas = <&dmac 16>;
+            dma-names = "rx";
+            #sound-dai-cells = <0>;
+            pinctrl-names = "default", "sleep";
+            pinctrl-0 = <&pdmm0_clk
+                         &pdmm0_sdi0
+                         &pdmm0_sdi1
+                         &pdmm0_sdi2
+                         &pdmm0_sdi3>;
+            pinctrl-1 = <&pdmm0_clk_sleep
+                         &pdmm0_sdi0_sleep
+                         &pdmm0_sdi1_sleep
+                         &pdmm0_sdi2_sleep
+                         &pdmm0_sdi3_sleep>;
+        };
+    };
index c473df5..013f534 100644 (file)
@@ -42,7 +42,7 @@ Optional properties:
 - realtek,ldo1-en-gpios : The GPIO that controls the CODEC's LDO1_EN pin.
 - realtek,reset-gpios : The GPIO that controls the CODEC's RESET pin.
 
-- sound-name-prefix: Please refer to name-prefix.txt
+- sound-name-prefix: Please refer to name-prefix.yaml
 
 - ports: A Codec may have a single or multiple I2S interfaces. These
   interfaces on Codec side can be described under 'ports' or 'port'.
diff --git a/Documentation/devicetree/bindings/sound/simple-amplifier.txt b/Documentation/devicetree/bindings/sound/simple-amplifier.txt
deleted file mode 100644 (file)
index b1b097c..0000000
+++ /dev/null
@@ -1,17 +0,0 @@
-Simple Amplifier Audio Driver
-
-Required properties:
-- compatible : "dioo,dio2125" or "simple-audio-amplifier"
-
-Optional properties:
-- enable-gpios : the gpio connected to the enable pin of the simple amplifier
-- VCC-supply   : power supply for the device, as covered
-                 in Documentation/devicetree/bindings/regulator/regulator.txt
-
-Example:
-
-amp: analog-amplifier {
-       compatible = "simple-audio-amplifier";
-       VCC-supply = <&regulator>;
-       enable-gpios = <&gpio GPIOH_3 0>;
-};
diff --git a/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml b/Documentation/devicetree/bindings/sound/simple-audio-amplifier.yaml
new file mode 100644 (file)
index 0000000..2637937
--- /dev/null
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/simple-audio-amplifier.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Simple Audio Amplifier Device Tree Bindings
+
+maintainers:
+  - Jerome Brunet <jbrunet@baylibre.com>
+
+properties:
+  compatible:
+    enum:
+      - dioo,dio2125
+      - simple-audio-amplifier
+
+  enable-gpios:
+    maxItems: 1
+
+  VCC-supply:
+    description: >
+      power supply for the device
+
+  sound-name-prefix:
+    $ref: /schemas/types.yaml#/definitions/string
+    description: >
+      See ./name-prefix.txt
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/meson8-gpio.h>
+
+    analog-amplifier {
+        compatible = "simple-audio-amplifier";
+        VCC-supply = <&regulator>;
+        enable-gpios = <&gpio GPIOH_3 0>;
+    };
+
+...
index 5986d1f..b5fc35e 100644 (file)
@@ -13,6 +13,9 @@ description: |
   Simple audio multiplexers are driven using gpios, allowing to select which of
   their input line is connected to the output line.
 
+allOf:
+  - $ref: name-prefix.yaml#
+
 properties:
   compatible:
     const: simple-audio-mux
@@ -21,11 +24,7 @@ properties:
     description: |
       GPIOs used to select the input line.
 
-  sound-name-prefix:
-    $ref: /schemas/types.yaml#/definitions/string
-    description:
-      Used as prefix for sink/source names of the component. Must be a
-      unique string among multiple instances of the same component.
+  sound-name-prefix: true
 
 required:
   - compatible
index 55ae198..70f62ec 100644 (file)
@@ -46,7 +46,27 @@ properties:
 
 patternProperties:
   "^port@[0-9]$":
-    description: FIXME, Need to define what each port is.
+    description: |
+      Port number of DT node is specified by the following DAI channels that
+      depends on SoC.
+      ld11-aio,ld20-aio:
+        0: hdmi
+        1: pcmin2
+        2: line
+        3: hpcmout1
+        4: pcmout3
+        5: hiecout1
+        6: epcmout2
+        7: epcmout3
+        8: hieccompout1
+      pxs2-aio:
+        0: hdmi
+        1: line
+        2: aux
+        3: hiecout1
+        4: iecout1
+        5: hieccompout1
+        6: ieccompout1
     $ref: audio-graph-port.yaml#
     unevaluatedProperties: false
 
index 48ddfcb..be6acfd 100644 (file)
@@ -40,7 +40,11 @@ properties:
 
 patternProperties:
   "^port@[0-9]$":
-    description: FIXME, Need to define what each port is.
+    description: |
+      Port number of DT node is specified by the following DAI channels.
+        0: line1
+        1: hp
+        2: line2
     $ref: audio-graph-port.yaml#
     unevaluatedProperties: false
 
diff --git a/Documentation/devicetree/bindings/sound/spdif-transmitter.txt b/Documentation/devicetree/bindings/sound/spdif-transmitter.txt
deleted file mode 100644 (file)
index 55a8584..0000000
+++ /dev/null
@@ -1,10 +0,0 @@
-Device-Tree bindings for dummy spdif transmitter
-
-Required properties:
-       - compatible: should be "linux,spdif-dit".
-
-Example node:
-
-       codec: spdif-transmitter {
-               compatible = "linux,spdif-dit";
-       };
diff --git a/Documentation/devicetree/bindings/sound/test-component.yaml b/Documentation/devicetree/bindings/sound/test-component.yaml
new file mode 100644 (file)
index 0000000..17fdb43
--- /dev/null
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/test-component.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Test Component Device Tree Bindings
+
+maintainers:
+  - Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+
+properties:
+  compatible:
+    enum:
+      - test-cpu
+      - test-cpu-verbose
+      - test-cpu-verbose-dai
+      - test-cpu-verbose-component
+      - test-codec
+      - test-codec-verbose
+      - test-codec-verbose-dai
+      - test-codec-verbose-component
+
+required:
+  - compatible
+
+additionalProperties: true
+
+examples:
+  - |
+    test_cpu {
+        compatible = "test-cpu";
+    };
diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8962.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8962.yaml
new file mode 100644 (file)
index 0000000..0e6249d
--- /dev/null
@@ -0,0 +1,118 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8962.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wolfson WM8962 Ultra-Low Power Stereo CODEC
+
+maintainers:
+  - patches@opensource.cirrus.com
+
+properties:
+  compatible:
+    const: wlf,wm8962
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  "#sound-dai-cells":
+    const: 0
+
+  AVDD-supply:
+    description: Analogue supply.
+
+  CPVDD-supply:
+    description: Charge pump power supply.
+
+  DBVDD-supply:
+    description: Digital Buffer Supply.
+
+  DCVDD-supply:
+    description: Digital Core Supply.
+
+  MICVDD-supply:
+    description: Microphone bias amp supply.
+
+  PLLVDD-supply:
+    description: PLL Supply
+
+  SPKVDD1-supply:
+    description: Supply for left speaker drivers.
+
+  SPKVDD2-supply:
+    description: Supply for right speaker drivers.
+
+  spk-mono:
+    $ref: /schemas/types.yaml#/definitions/flag
+    description:
+      If present, the SPK_MONO bit of R51 (Class D Control 2) gets set,
+      indicating that the speaker is in mono mode.
+
+  mic-cfg:
+    $ref: /schemas/types.yaml#/definitions/uint32
+    description:
+      Default register value for R48 (Additional Control 4).
+      If absent, the default should be the register default.
+
+  gpio-cfg:
+    $ref: /schemas/types.yaml#/definitions/uint32-array
+    minItems: 6
+    maxItems: 6
+    description:
+      A list of GPIO configuration register values.  If absent, no
+      configuration of these registers is performed.  Note that only values
+      within [0x0, 0xffff] are valid.  Any other value is regarded as setting
+      the GPIO register to its reset value 0x0.
+
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
+required:
+  - compatible
+  - reg
+  - AVDD-supply
+  - CPVDD-supply
+  - DBVDD-supply
+  - DCVDD-supply
+  - MICVDD-supply
+  - PLLVDD-supply
+  - SPKVDD1-supply
+  - SPKVDD2-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/clock/imx6qdl-clock.h>
+
+    i2c {
+          #address-cells = <1>;
+          #size-cells = <0>;
+
+          wm8962: codec@1a {
+                  compatible = "wlf,wm8962";
+                  reg = <0x1a>;
+                  clocks = <&clks IMX6QDL_CLK_CKO>;
+                  DCVDD-supply = <&reg_audio>;
+                  DBVDD-supply = <&reg_audio>;
+                  AVDD-supply = <&reg_audio>;
+                  CPVDD-supply = <&reg_audio>;
+                  MICVDD-supply = <&reg_audio>;
+                  PLLVDD-supply = <&reg_audio>;
+                  SPKVDD1-supply = <&reg_audio>;
+                  SPKVDD2-supply = <&reg_audio>;
+                  gpio-cfg = <
+                          0x0000 /* 0:Default */
+                          0x0000 /* 1:Default */
+                          0x0013 /* 2:FN_DMICCLK */
+                          0x0000 /* 3:Default */
+                          0x8014 /* 4:FN_DMICCDAT */
+                          0x0000 /* 5:Default */
+                  >;
+          };
+    };
diff --git a/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml b/Documentation/devicetree/bindings/sound/wlf,wm8978.yaml
new file mode 100644 (file)
index 0000000..96cf9fc
--- /dev/null
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/wlf,wm8978.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Wolfson WM8978 Codec Device Tree Bindings
+
+maintainers:
+  - patches@opensource.cirrus.com
+
+properties:
+  '#sound-dai-cells':
+    const: 0
+
+  compatible:
+    const: wlf,wm8978
+
+  reg:
+    maxItems: 1
+
+  spi-max-frequency:
+    maximum: 526000
+
+required:
+  - '#sound-dai-cells'
+  - compatible
+  - reg
+
+additionalProperties: false
+
+examples:
+  - |
+    spi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@0 {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0>;
+            spi-max-frequency = <500000>;
+        };
+    };
+
+  - |
+    i2c {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        codec@1a {
+            #sound-dai-cells = <0>;
+            compatible = "wlf,wm8978";
+            reg = <0x1a>;
+        };
+    };
+
+...
diff --git a/Documentation/devicetree/bindings/sound/wm8962.txt b/Documentation/devicetree/bindings/sound/wm8962.txt
deleted file mode 100644 (file)
index c36c649..0000000
+++ /dev/null
@@ -1,43 +0,0 @@
-WM8962 audio CODEC
-
-This device supports I2C only.
-
-Required properties:
-
-  - compatible : "wlf,wm8962"
-
-  - reg : the I2C address of the device.
-
-Optional properties:
-
-  - clocks : The clock source of the mclk
-
-  - spk-mono: This is a boolean property. If present, the SPK_MONO bit
-    of R51 (Class D Control 2) gets set, indicating that the speaker is
-    in mono mode.
-
-  - mic-cfg : Default register value for R48 (Additional Control 4).
-    If absent, the default should be the register default.
-
-  - gpio-cfg : A list of GPIO configuration register values. The list must
-    be 6 entries long. If absent, no configuration of these registers is
-    performed. And note that only the value within [0x0, 0xffff] is valid.
-    Any other value is regarded as setting the GPIO register by its reset
-    value 0x0.
-
-Example:
-
-wm8962: codec@1a {
-       compatible = "wlf,wm8962";
-       reg = <0x1a>;
-       clocks = <&clks IMX6QDL_CLK_CKO>;
-
-       gpio-cfg = <
-               0x0000 /* 0:Default */
-               0x0000 /* 1:Default */
-               0x0013 /* 2:FN_DMICCLK */
-               0x0000 /* 3:Default */
-               0x8014 /* 4:FN_DMICCDAT */
-               0x0000 /* 5:Default */
-       >;
-};
index ca91201..d7e08b0 100644 (file)
@@ -171,7 +171,7 @@ examples:
       cs-gpios = <&gpio0 13 0>,
                  <&gpio0 14 0>;
       rx-sample-delay-ns = <3>;
-      spi-flash@1 {
+      flash@1 {
         compatible = "spi-nand";
         reg = <1>;
         rx-sample-delay-ns = <7>;
diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml
new file mode 100644 (file)
index 0000000..b9ca8ef
--- /dev/null
@@ -0,0 +1,89 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/ufs/samsung,exynos-ufs.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Samsung SoC series UFS host controller Device Tree Bindings
+
+maintainers:
+  - Alim Akhtar <alim.akhtar@samsung.com>
+
+description: |
+  Each Samsung UFS host controller instance should have its own node.
+  This binding define Samsung specific binding other then what is used
+  in the common ufshcd bindings
+  [1] Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+
+properties:
+
+  compatible:
+    enum:
+      - samsung,exynos7-ufs
+
+  reg:
+    items:
+      - description: HCI register
+      - description: vendor specific register
+      - description: unipro register
+      - description: UFS protector register
+
+  reg-names:
+    items:
+      - const: hci
+      - const: vs_hci
+      - const: unipro
+      - const: ufsp
+
+  clocks:
+    items:
+      - description: ufs link core clock
+      - description: unipro main clock
+
+  clock-names:
+    items:
+      - const: core_clk
+      - const: sclk_unipro_main
+
+  interrupts:
+    maxItems: 1
+
+  phys:
+    maxItems: 1
+
+  phy-names:
+    const: ufs-phy
+
+required:
+  - compatible
+  - reg
+  - interrupts
+  - phys
+  - phy-names
+  - clocks
+  - clock-names
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    #include <dt-bindings/clock/exynos7-clk.h>
+
+    ufs: ufs@15570000 {
+       compatible = "samsung,exynos7-ufs";
+       reg = <0x15570000 0x100>,
+             <0x15570100 0x100>,
+             <0x15571000 0x200>,
+             <0x15572000 0x300>;
+       reg-names = "hci", "vs_hci", "unipro", "ufsp";
+       interrupts = <GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>;
+       clocks = <&clock_fsys1 ACLK_UFS20_LINK>,
+                <&clock_fsys1 SCLK_UFSUNIPRO20_USER>;
+       clock-names = "core_clk", "sclk_unipro_main";
+       pinctrl-names = "default";
+       pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>;
+       phys = <&ufs_phy>;
+       phy-names = "ufs-phy";
+    };
+...
index ffe9ea0..d67ccd2 100644 (file)
 NTFS3
 =====
 
-
 Summary and Features
 ====================
 
-NTFS3 is fully functional NTFS Read-Write driver. The driver works with
-NTFS versions up to 3.1, normal/compressed/sparse files
-and journal replaying. File system type to use on mount is 'ntfs3'.
+NTFS3 is fully functional NTFS Read-Write driver. The driver works with NTFS
+versions up to 3.1. File system type to use on mount is *ntfs3*.
 
 - This driver implements NTFS read/write support for normal, sparse and
   compressed files.
-- Supports native journal replaying;
-- Supports extended attributes
-       Predefined extended attributes:
-       - 'system.ntfs_security' gets/sets security
-                       descriptor (SECURITY_DESCRIPTOR_RELATIVE)
-       - 'system.ntfs_attrib' gets/sets ntfs file/dir attributes.
-               Note: applied to empty files, this allows to switch type between
-               sparse(0x200), compressed(0x800) and normal;
+- Supports native journal replaying.
 - Supports NFS export of mounted NTFS volumes.
+- Supports extended attributes. Predefined extended attributes:
+
+       - *system.ntfs_security* gets/sets security
+
+               Descriptor: SECURITY_DESCRIPTOR_RELATIVE
+
+       - *system.ntfs_attrib* gets/sets ntfs file/dir attributes.
+
+         Note: Applied to empty files, this allows to switch type between
+         sparse(0x200), compressed(0x800) and normal.
 
 Mount Options
 =============
 
 The list below describes mount options supported by NTFS3 driver in addition to
-generic ones.
+generic ones. You can use every mount option with **no** option. If it is in
+this table marked with no it means default is without **no**.
 
-===============================================================================
+.. flat-table::
+   :widths: 1 5
+   :fill-cells:
 
-nls=name               This option informs the driver how to interpret path
-                       strings and translate them to Unicode and back. If
-                       this option is not set, the default codepage will be
-                       used (CONFIG_NLS_DEFAULT).
-                       Examples:
-                               'nls=utf8'
+   * - iocharset=name
+     - This option informs the driver how to interpret path strings and
+       translate them to Unicode and back. If this option is not set, the
+       default codepage will be used (CONFIG_NLS_DEFAULT).
 
-uid=
-gid=
-umask=                 Controls the default permissions for files/directories created
-                       after the NTFS volume is mounted.
+       Example: iocharset=utf8
 
-fmask=
-dmask=                 Instead of specifying umask which applies both to
-                       files and directories, fmask applies only to files and
-                       dmask only to directories.
+   * - uid=
+     - :rspan:`1`
+   * - gid=
 
-nohidden               Files with the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN)
-                       attribute will not be shown under Linux.
+   * - umask=
+     - Controls the default permissions for files/directories created after
+       the NTFS volume is mounted.
 
-sys_immutable          Files with the Windows-specific SYSTEM
-                       (FILE_ATTRIBUTE_SYSTEM) attribute will be marked as system
-                       immutable files.
+   * - dmask=
+     - :rspan:`1` Instead of specifying umask which applies both to files and
+       directories, fmask applies only to files and dmask only to directories.
+   * - fmask=
 
-discard                        Enable support of the TRIM command for improved performance
-                       on delete operations, which is recommended for use with the
-                       solid-state drives (SSD).
+   * - noacsrules
+     - "No access rules" mount option sets access rights for files/folders to
+       777 and owner/group to root. This mount option absorbs all other
+       permissions.
 
-force                  Forces the driver to mount partitions even if 'dirty' flag
-                       (volume dirty) is set. Not recommended for use.
+       - Permissions change for files/folders will be reported as successful,
+        but they will remain 777.
 
-sparse                 Create new files as "sparse".
+       - Owner/group change will be reported as successful, butthey will stay
+        as root.
 
-showmeta               Use this parameter to show all meta-files (System Files) on
-                       a mounted NTFS partition.
-                       By default, all meta-files are hidden.
+   * - nohidden
+     - Files with the Windows-specific HIDDEN (FILE_ATTRIBUTE_HIDDEN) attribute
+       will not be shown under Linux.
 
-prealloc               Preallocate space for files excessively when file size is
-                       increasing on writes. Decreases fragmentation in case of
-                       parallel write operations to different files.
+   * - sys_immutable
+     - Files with the Windows-specific SYSTEM (FILE_ATTRIBUTE_SYSTEM) attribute
+       will be marked as system immutable files.
 
-no_acs_rules           "No access rules" mount option sets access rights for
-                       files/folders to 777 and owner/group to root. This mount
-                       option absorbs all other permissions:
-                       - permissions change for files/folders will be reported
-                               as successful, but they will remain 777;
-                       - owner/group change will be reported as successful, but
-                               they will stay as root
+   * - discard
+     - Enable support of the TRIM command for improved performance on delete
+       operations, which is recommended for use with the solid-state drives
+       (SSD).
 
-acl                    Support POSIX ACLs (Access Control Lists). Effective if
-                       supported by Kernel. Not to be confused with NTFS ACLs.
-                       The option specified as acl enables support for POSIX ACLs.
+   * - force
+     - Forces the driver to mount partitions even if volume is marked dirty.
+       Not recommended for use.
 
-noatime                        All files and directories will not update their last access
-                       time attribute if a partition is mounted with this parameter.
-                       This option can speed up file system operation.
+   * - sparse
+     - Create new files as sparse.
 
-===============================================================================
+   * - showmeta
+     - Use this parameter to show all meta-files (System Files) on a mounted
+       NTFS partition. By default, all meta-files are hidden.
 
-ToDo list
-=========
+   * - prealloc
+     - Preallocate space for files excessively when file size is increasing on
+       writes. Decreases fragmentation in case of parallel write operations to
+       different files.
 
-- Full journaling support (currently journal replaying is supported) over JBD.
+   * - acl
+     - Support POSIX ACLs (Access Control Lists). Effective if supported by
+       Kernel. Not to be confused with NTFS ACLs. The option specified as acl
+       enables support for POSIX ACLs.
 
+Todo list
+=========
+- Full journaling support over JBD. Currently journal replaying is supported
+  which is not necessarily as effectice as JBD would be.
 
 References
 ==========
-https://www.paragon-software.com/home/ntfs-linux-professional/
-       - Commercial version of the NTFS driver for Linux.
+- Commercial version of the NTFS driver for Linux.
+       https://www.paragon-software.com/home/ntfs-linux-professional/
 
-almaz.alexandrovich@paragon-software.com
-       - Direct e-mail address for feedback and requests on the NTFS3 implementation.
+- Direct e-mail address for feedback and requests on the NTFS3 implementation.
+       almaz.alexandrovich@paragon-software.com
index 364680c..8ba72e8 100644 (file)
@@ -300,8 +300,8 @@ pcie_replay_count
 .. kernel-doc:: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
    :doc: pcie_replay_count
 
-+GPU SmartShift Information
-============================
+GPU SmartShift Information
+==========================
 
 GPU SmartShift information via sysfs
 
index 06af044..607f78f 100644 (file)
@@ -111,15 +111,6 @@ Component Helper Usage
 .. kernel-doc:: drivers/gpu/drm/drm_drv.c
    :doc: component helper usage recommendations
 
-IRQ Helper Library
-~~~~~~~~~~~~~~~~~~
-
-.. kernel-doc:: drivers/gpu/drm/drm_irq.c
-   :doc: irq helpers
-
-.. kernel-doc:: drivers/gpu/drm/drm_irq.c
-   :export:
-
 Memory Manager Initialization
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
index 8557e26..91b99ad 100644 (file)
@@ -132,20 +132,3 @@ On Family 17h and Family 18h CPUs, additional temperature sensors may report
 Core Complex Die (CCD) temperatures. Up to 8 such temperatures are reported
 as temp{3..10}_input, labeled Tccd{1..8}. Actual support depends on the CPU
 variant.
-
-Various Family 17h and 18h CPUs report voltage and current telemetry
-information. The following attributes may be reported.
-
-Attribute      Label   Description
-===============        ======= ================
-in0_input      Vcore   Core voltage
-in1_input      Vsoc    SoC voltage
-curr1_input    Icore   Core current
-curr2_input    Isoc    SoC current
-===============        ======= ================
-
-Current values are raw (unscaled) as reported by the CPU. Core current is
-reported as multiples of 1A / LSB. SoC is reported as multiples of 0.25A
-/ LSB. The real current is board specific. Reported currents should be seen
-as rough guidance, and should be scaled using sensors3.conf as appropriate
-for a given board.
index e7d9cbf..67b7a70 100644 (file)
@@ -851,7 +851,7 @@ NOTES:
 - 0x88A8 traffic will not be received unless VLAN stripping is disabled with
   the following command::
 
-    # ethool -K <ethX> rxvlan off
+    # ethtool -K <ethX> rxvlan off
 
 - 0x88A8/0x8100 double VLANs cannot be used with 0x8100 or 0x8100/0x8100 VLANS
   configured on the same port. 0x88a8/0x8100 traffic will not be received if
index 564caee..29b1bae 100644 (file)
@@ -296,7 +296,7 @@ not available.
 Device Tree bindings and board design
 =====================================
 
-This section references ``Documentation/devicetree/bindings/net/dsa/sja1105.txt``
+This section references ``Documentation/devicetree/bindings/net/dsa/nxp,sja1105.yaml``
 and aims to showcase some potential switch caveats.
 
 RMII PHY role and out-of-band signaling
index d3a8557..e35ab74 100644 (file)
@@ -29,7 +29,7 @@ you probably needn't concern yourself with pcmciautils.
 ====================== ===============  ========================================
         Program        Minimal version       Command to check the version
 ====================== ===============  ========================================
-GNU C                  4.9              gcc --version
+GNU C                  5.1              gcc --version
 Clang/LLVM (optional)  10.0.1           clang --version
 GNU make               3.81             make --version
 binutils               2.23             ld -v
index 65f6169..34888d4 100644 (file)
@@ -100,6 +100,15 @@ amidi_map
     MIDI device number maps assigned to the 2st OSS device;
     Default: 1
 
+Module snd-soc-core
+-------------------
+
+The soc core module. It is used by all ALSA card drivers.
+It takes the following options which have global effects.
+
+prealloc_buffer_size_kbytes
+    Specify prealloc buffer size in kbytes (default: 512).
+
 Common parameters for top sound card modules
 --------------------------------------------
 
index 8a9737e..57df149 100644 (file)
@@ -40,7 +40,7 @@ e.g.
        .prepare        = wm8731_pcm_prepare,
        .hw_params      = wm8731_hw_params,
        .shutdown       = wm8731_shutdown,
-       .digital_mute   = wm8731_mute,
+       .mute_stream    = wm8731_mute,
        .set_sysclk     = wm8731_set_dai_sysclk,
        .set_fmt        = wm8731_set_dai_fmt,
   };
@@ -60,7 +60,7 @@ e.g.
                .rates = WM8731_RATES,
                .formats = WM8731_FORMATS,},
        .ops = &wm8731_dai_ops,
-       .symmetric_rates = 1,
+       .symmetric_rate = 1,
   };
 
 
@@ -177,10 +177,10 @@ when the mute is applied or freed.
 i.e.
 ::
 
-  static int wm8974_mute(struct snd_soc_dai *dai, int mute)
+  static int wm8974_mute(struct snd_soc_dai *dai, int mute, int direction)
   {
        struct snd_soc_component *component = dai->component;
-       u16 mute_reg = snd_soc_component_read32(component, WM8974_DAC) & 0xffbf;
+       u16 mute_reg = snd_soc_component_read(component, WM8974_DAC) & 0xffbf;
 
        if (mute)
                snd_soc_component_write(component, WM8974_DAC, mute_reg | 0x40);
index 669a022..980eb20 100644 (file)
@@ -223,7 +223,7 @@ Linux内核5.x版本 <http://kernel.org/>
 编译内核
 ---------
 
- - 确保您至少有gcc 4.9可用。
+ - 确保您至少有gcc 5.1可用。
    有关更多信息,请参阅 :ref:`Documentation/process/changes.rst <changes>` 。
 
    请注意,您仍然可以使用此内核运行a.out用户程序。
index b752e50..6ce97ed 100644 (file)
@@ -226,7 +226,7 @@ Linux內核5.x版本 <http://kernel.org/>
 編譯內核
 ---------
 
- - 確保您至少有gcc 4.9可用。
+ - 確保您至少有gcc 5.1可用。
    有關更多信息,請參閱 :ref:`Documentation/process/changes.rst <changes>` 。
 
    請注意,您仍然可以使用此內核運行a.out用戶程序。
index 42ef59e..bdb880e 100644 (file)
@@ -18,7 +18,7 @@ types can be added after the security issue of corresponding device driver
 is clarified or fixed in the future.
 
 Create/Destroy VDUSE devices
-------------------------
+----------------------------
 
 VDUSE devices are created as follows:
 
index f555bfa..6fc811c 100644 (file)
@@ -414,7 +414,8 @@ T:  git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
 F:     drivers/acpi/pmic/
 
 ACPI THERMAL DRIVER
-M:     Zhang Rui <rui.zhang@intel.com>
+M:     Rafael J. Wysocki <rafael@kernel.org>
+R:     Zhang Rui <rui.zhang@intel.com>
 L:     linux-acpi@vger.kernel.org
 S:     Supported
 W:     https://01.org/linux-acpi
@@ -810,7 +811,7 @@ F:  Documentation/devicetree/bindings/dma/altr,msgdma.yaml
 F:     drivers/dma/altera-msgdma.c
 
 ALTERA PIO DRIVER
-M:     Joyce Ooi <joyce.ooi@intel.com>
+M:     Mun Yew Tham <mun.yew.tham@intel.com>
 L:     linux-gpio@vger.kernel.org
 S:     Maintained
 F:     drivers/gpio/gpio-altera.c
@@ -977,12 +978,12 @@ L:        platform-driver-x86@vger.kernel.org
 S:     Maintained
 F:     drivers/platform/x86/amd-pmc.*
 
-AMD POWERPLAY
+AMD POWERPLAY AND SWSMU
 M:     Evan Quan <evan.quan@amd.com>
 L:     amd-gfx@lists.freedesktop.org
 S:     Supported
 T:     git https://gitlab.freedesktop.org/agd5f/linux.git
-F:     drivers/gpu/drm/amd/pm/powerplay/
+F:     drivers/gpu/drm/amd/pm/
 
 AMD PTDMA DRIVER
 M:     Sanjay R Mehta <sanju.mehta@amd.com>
@@ -1275,6 +1276,7 @@ F:        drivers/input/mouse/bcm5974.c
 
 APPLE DART IOMMU DRIVER
 M:     Sven Peter <sven@svenpeter.dev>
+R:     Alyssa Rosenzweig <alyssa@rosenzweig.io>
 L:     iommu@lists.linux-foundation.org
 S:     Maintained
 F:     Documentation/devicetree/bindings/iommu/apple,dart.yaml
@@ -1711,6 +1713,8 @@ F:        drivers/*/*alpine*
 
 ARM/APPLE MACHINE SUPPORT
 M:     Hector Martin <marcan@marcan.st>
+M:     Sven Peter <sven@svenpeter.dev>
+R:     Alyssa Rosenzweig <alyssa@rosenzweig.io>
 L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:     Maintained
 W:     https://asahilinux.org
@@ -2236,6 +2240,7 @@ F:        arch/arm/mach-pxa/mioa701.c
 
 ARM/MStar/Sigmastar Armv7 SoC support
 M:     Daniel Palmer <daniel@thingy.jp>
+M:     Romain Perier <romain.perier@gmail.com>
 L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:     Maintained
 W:     http://linux-chenxing.org/
@@ -2712,6 +2717,7 @@ F:        drivers/power/reset/keystone-reset.c
 
 ARM/TEXAS INSTRUMENTS K3 ARCHITECTURE
 M:     Nishanth Menon <nm@ti.com>
+M:     Vignesh Raghavendra <vigneshr@ti.com>
 M:     Tero Kristo <kristo@kernel.org>
 L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:     Supported
@@ -2804,9 +2810,8 @@ F:        arch/arm/mach-pxa/include/mach/vpac270.h
 F:     arch/arm/mach-pxa/vpac270.c
 
 ARM/VT8500 ARM ARCHITECTURE
-M:     Tony Prisk <linux@prisktech.co.nz>
 L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
-S:     Maintained
+S:     Orphan
 F:     Documentation/devicetree/bindings/i2c/i2c-wmt.txt
 F:     arch/arm/mach-vt8500/
 F:     drivers/clocksource/timer-vt8500.c
@@ -2962,7 +2967,7 @@ F:        crypto/async_tx/
 F:     include/linux/async_tx.h
 
 AT24 EEPROM DRIVER
-M:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
+M:     Bartosz Golaszewski <brgl@bgdev.pl>
 L:     linux-i2c@vger.kernel.org
 S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git
@@ -3385,9 +3390,11 @@ F:       Documentation/networking/filter.rst
 F:     Documentation/userspace-api/ebpf/
 F:     arch/*/net/*
 F:     include/linux/bpf*
+F:     include/linux/btf*
 F:     include/linux/filter.h
 F:     include/trace/events/xdp.h
 F:     include/uapi/linux/bpf*
+F:     include/uapi/linux/btf*
 F:     include/uapi/linux/filter.h
 F:     kernel/bpf/
 F:     kernel/trace/bpf_trace.c
@@ -3821,7 +3828,6 @@ F:        drivers/scsi/mpi3mr/
 
 BROADCOM NETXTREME-E ROCE DRIVER
 M:     Selvin Xavier <selvin.xavier@broadcom.com>
-M:     Naresh Kumar PBS <nareshkumar.pbs@broadcom.com>
 L:     linux-rdma@vger.kernel.org
 S:     Supported
 W:     http://www.broadcom.com
@@ -4445,6 +4451,17 @@ L:       patches@opensource.cirrus.com
 S:     Maintained
 F:     sound/soc/codecs/cs*
 
+CIRRUS LOGIC DSP FIRMWARE DRIVER
+M:     Simon Trimmer <simont@opensource.cirrus.com>
+M:     Charles Keepax <ckeepax@opensource.cirrus.com>
+M:     Richard Fitzgerald <rf@opensource.cirrus.com>
+L:     patches@opensource.cirrus.com
+S:     Supported
+W:     https://github.com/CirrusLogic/linux-drivers/wiki
+T:     git https://github.com/CirrusLogic/linux-drivers.git
+F:     drivers/firmware/cirrus/*
+F:     include/linux/firmware/cirrus/*
+
 CIRRUS LOGIC EP93XX ETHERNET DRIVER
 M:     Hartley Sweeten <hsweeten@visionengravers.com>
 L:     netdev@vger.kernel.org
@@ -4656,7 +4673,7 @@ W:        http://linux-cifs.samba.org/
 T:     git git://git.samba.org/sfrench/cifs-2.6.git
 F:     Documentation/admin-guide/cifs/
 F:     fs/cifs/
-F:     fs/cifs_common/
+F:     fs/smbfs_common/
 
 COMPACTPCI HOTPLUG CORE
 M:     Scott Murray <scott@spiteful.org>
@@ -7337,10 +7354,11 @@ F:      include/uapi/linux/fpga-dfl.h
 
 FPGA MANAGER FRAMEWORK
 M:     Moritz Fischer <mdf@kernel.org>
+M:     Wu Hao <hao.wu@intel.com>
+M:     Xu Yilun <yilun.xu@intel.com>
 R:     Tom Rix <trix@redhat.com>
 L:     linux-fpga@vger.kernel.org
 S:     Maintained
-W:     http://www.rocketboards.org
 Q:     http://patchwork.kernel.org/project/linux-fpga/list/
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git
 F:     Documentation/devicetree/bindings/fpga/
@@ -7434,7 +7452,7 @@ FREESCALE IMX / MXC FEC DRIVER
 M:     Joakim Zhang <qiangqing.zhang@nxp.com>
 L:     netdev@vger.kernel.org
 S:     Maintained
-F:     Documentation/devicetree/bindings/net/fsl-fec.txt
+F:     Documentation/devicetree/bindings/net/fsl,fec.yaml
 F:     drivers/net/ethernet/freescale/fec.h
 F:     drivers/net/ethernet/freescale/fec_main.c
 F:     drivers/net/ethernet/freescale/fec_ptp.c
@@ -7986,7 +8004,7 @@ F:        include/linux/gpio/regmap.h
 
 GPIO SUBSYSTEM
 M:     Linus Walleij <linus.walleij@linaro.org>
-M:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
+M:     Bartosz Golaszewski <brgl@bgdev.pl>
 L:     linux-gpio@vger.kernel.org
 S:     Maintained
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git
@@ -8608,9 +8626,8 @@ F:        Documentation/devicetree/bindings/iio/humidity/st,hts221.yaml
 F:     drivers/iio/humidity/hts221*
 
 HUAWEI ETHERNET DRIVER
-M:     Bin Luo <luobin9@huawei.com>
 L:     netdev@vger.kernel.org
-S:     Supported
+S:     Orphan
 F:     Documentation/networking/device_drivers/ethernet/huawei/hinic.rst
 F:     drivers/net/ethernet/huawei/hinic/
 
@@ -9302,7 +9319,7 @@ S:        Maintained
 F:     drivers/platform/x86/intel/atomisp2/led.c
 
 INTEL BIOS SAR INT1092 DRIVER
-M:     Shravan S <s.shravan@intel.com>
+M:     Shravan Sudhakar <s.shravan@intel.com>
 M:     Intel Corporation <linuxwwan@intel.com>
 L:     platform-driver-x86@vger.kernel.org
 S:     Maintained
@@ -9624,7 +9641,7 @@ F:        include/uapi/linux/isst_if.h
 F:     tools/power/x86/intel-speed-select/
 
 INTEL STRATIX10 FIRMWARE DRIVERS
-M:     Richard Gong <richard.gong@linux.intel.com>
+M:     Dinh Nguyen <dinguyen@kernel.org>
 L:     linux-kernel@vger.kernel.org
 S:     Maintained
 F:     Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu
@@ -10194,8 +10211,8 @@ M:      Hyunchul Lee <hyc.lee@gmail.com>
 L:     linux-cifs@vger.kernel.org
 S:     Maintained
 T:     git git://git.samba.org/ksmbd.git
-F:     fs/cifs_common/
 F:     fs/ksmbd/
+F:     fs/smbfs_common/
 
 KERNEL UNIT TESTING FRAMEWORK (KUnit)
 M:     Brendan Higgins <brendanhiggins@google.com>
@@ -10274,7 +10291,6 @@ KERNEL VIRTUAL MACHINE for s390 (KVM/s390)
 M:     Christian Borntraeger <borntraeger@de.ibm.com>
 M:     Janosch Frank <frankja@linux.ibm.com>
 R:     David Hildenbrand <david@redhat.com>
-R:     Cornelia Huck <cohuck@redhat.com>
 R:     Claudio Imbrenda <imbrenda@linux.ibm.com>
 L:     kvm@vger.kernel.org
 S:     Supported
@@ -11148,6 +11164,7 @@ S:      Maintained
 F:     Documentation/devicetree/bindings/net/dsa/marvell.txt
 F:     Documentation/networking/devlink/mv88e6xxx.rst
 F:     drivers/net/dsa/mv88e6xxx/
+F:     include/linux/dsa/mv88e6xxx.h
 F:     include/linux/platform_data/mv88e6xxx.h
 
 MARVELL ARMADA 3700 PHY DRIVERS
@@ -11367,7 +11384,7 @@ F:      Documentation/devicetree/bindings/iio/proximity/maxbotix,mb1232.yaml
 F:     drivers/iio/proximity/mb1232.c
 
 MAXIM MAX77650 PMIC MFD DRIVER
-M:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
+M:     Bartosz Golaszewski <brgl@bgdev.pl>
 L:     linux-kernel@vger.kernel.org
 S:     Maintained
 F:     Documentation/devicetree/bindings/*/*max77650.yaml
@@ -13255,9 +13272,9 @@ F:      Documentation/scsi/NinjaSCSI.rst
 F:     drivers/scsi/nsp32*
 
 NIOS2 ARCHITECTURE
-M:     Ley Foon Tan <ley.foon.tan@intel.com>
+M:     Dinh Nguyen <dinguyen@kernel.org>
 S:     Maintained
-T:     git git://git.kernel.org/pub/scm/linux/kernel/git/lftan/nios2.git
+T:     git git://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git
 F:     arch/nios2/
 
 NITRO ENCLAVES (NE)
@@ -14342,7 +14359,8 @@ F:      Documentation/devicetree/bindings/pci/intel,ixp4xx-pci.yaml
 F:     drivers/pci/controller/pci-ixp4xx.c
 
 PCI DRIVER FOR INTEL VOLUME MANAGEMENT DEVICE (VMD)
-M:     Jonathan Derrick <jonathan.derrick@intel.com>
+M:     Nirmal Patel <nirmal.patel@linux.intel.com>
+R:     Jonathan Derrick <jonathan.derrick@linux.dev>
 L:     linux-pci@vger.kernel.org
 S:     Supported
 F:     drivers/pci/controller/vmd.c
@@ -16097,6 +16115,13 @@ F:     Documentation/ABI/*/sysfs-driver-hid-roccat*
 F:     drivers/hid/hid-roccat*
 F:     include/linux/hid-roccat*
 
+ROCKCHIP I2S TDM DRIVER
+M:     Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
+L:     linux-rockchip@lists.infradead.org
+S:     Maintained
+F:     Documentation/devicetree/bindings/sound/rockchip,i2s-tdm.yaml
+F:     sound/soc/rockchip/rockchip_i2s_tdm.*
+
 ROCKCHIP ISP V1 DRIVER
 M:     Helen Koike <helen.koike@collabora.com>
 M:     Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
@@ -16295,6 +16320,7 @@ S390
 M:     Heiko Carstens <hca@linux.ibm.com>
 M:     Vasily Gorbik <gor@linux.ibm.com>
 M:     Christian Borntraeger <borntraeger@de.ibm.com>
+R:     Alexander Gordeev <agordeev@linux.ibm.com>
 L:     linux-s390@vger.kernel.org
 S:     Supported
 W:     http://www.ibm.com/developerworks/linux/linux390/
@@ -16373,7 +16399,6 @@ F:      drivers/s390/crypto/vfio_ap_ops.c
 F:     drivers/s390/crypto/vfio_ap_private.h
 
 S390 VFIO-CCW DRIVER
-M:     Cornelia Huck <cohuck@redhat.com>
 M:     Eric Farman <farman@linux.ibm.com>
 M:     Matthew Rosato <mjrosato@linux.ibm.com>
 R:     Halil Pasic <pasic@linux.ibm.com>
@@ -16650,13 +16675,6 @@ M:     Lubomir Rintel <lkundrak@v3.sk>
 S:     Supported
 F:     drivers/char/pcmcia/scr24x_cs.c
 
-SCSI CDROM DRIVER
-M:     Jens Axboe <axboe@kernel.dk>
-L:     linux-scsi@vger.kernel.org
-S:     Maintained
-W:     http://www.kernel.dk
-F:     drivers/scsi/sr*
-
 SCSI RDMA PROTOCOL (SRP) INITIATOR
 M:     Bart Van Assche <bvanassche@acm.org>
 L:     linux-rdma@vger.kernel.org
@@ -16955,7 +16973,6 @@ F:      drivers/misc/sgi-xp/
 
 SHARED MEMORY COMMUNICATIONS (SMC) SOCKETS
 M:     Karsten Graul <kgraul@linux.ibm.com>
-M:     Guvenc Gulce <guvenc@linux.ibm.com>
 L:     linux-s390@vger.kernel.org
 S:     Supported
 W:     http://www.ibm.com/developerworks/linux/linux390/
@@ -17800,7 +17817,6 @@ F:      drivers/staging/nvec/
 
 STAGING - OLPC SECONDARY DISPLAY CONTROLLER (DCON)
 M:     Jens Frederich <jfrederich@gmail.com>
-M:     Daniel Drake <dsd@laptop.org>
 M:     Jon Nettleton <jon.nettleton@gmail.com>
 S:     Maintained
 W:     http://wiki.laptop.org/go/DCON
@@ -17969,10 +17985,11 @@ F:    Documentation/admin-guide/svga.rst
 F:     arch/x86/boot/video*
 
 SWIOTLB SUBSYSTEM
-M:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
+M:     Christoph Hellwig <hch@infradead.org>
 L:     iommu@lists.linux-foundation.org
 S:     Supported
-T:     git git://git.kernel.org/pub/scm/linux/kernel/git/konrad/swiotlb.git
+W:     http://git.infradead.org/users/hch/dma-mapping.git
+T:     git git://git.infradead.org/users/hch/dma-mapping.git
 F:     arch/*/kernel/pci-swiotlb.c
 F:     include/linux/swiotlb.h
 F:     kernel/dma/swiotlb.c
@@ -17988,7 +18005,7 @@ F:      net/switchdev/
 SY8106A REGULATOR DRIVER
 M:     Icenowy Zheng <icenowy@aosc.io>
 S:     Maintained
-F:     Documentation/devicetree/bindings/regulator/sy8106a-regulator.txt
+F:     Documentation/devicetree/bindings/regulator/silergy,sy8106a.yaml
 F:     drivers/regulator/sy8106a-regulator.c
 
 SYNC FILE FRAMEWORK
@@ -18555,13 +18572,14 @@ T:    git git://linuxtv.org/media_tree.git
 F:     drivers/media/radio/radio-raremono.c
 
 THERMAL
-M:     Zhang Rui <rui.zhang@intel.com>
+M:     Rafael J. Wysocki <rafael@kernel.org>
 M:     Daniel Lezcano <daniel.lezcano@linaro.org>
 R:     Amit Kucheria <amitk@kernel.org>
+R:     Zhang Rui <rui.zhang@intel.com>
 L:     linux-pm@vger.kernel.org
 S:     Supported
 Q:     https://patchwork.kernel.org/project/linux-pm/list/
-T:     git git://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git
+T:     git git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
 F:     Documentation/devicetree/bindings/thermal/
 F:     drivers/thermal/
 F:     include/linux/cpu_cooling.h
@@ -18690,7 +18708,7 @@ F:      include/linux/clk/ti.h
 
 TI DAVINCI MACHINE SUPPORT
 M:     Sekhar Nori <nsekhar@ti.com>
-R:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
+R:     Bartosz Golaszewski <brgl@bgdev.pl>
 L:     linux-arm-kernel@lists.infradead.org (moderated for non-subscribers)
 S:     Supported
 T:     git git://git.kernel.org/pub/scm/linux/kernel/git/nsekhar/linux-davinci.git
@@ -19289,13 +19307,12 @@ S:    Maintained
 F:     drivers/usb/misc/chaoskey.c
 
 USB CYPRESS C67X00 DRIVER
-M:     Peter Korsgaard <jacmet@sunsite.dk>
 L:     linux-usb@vger.kernel.org
-S:     Maintained
+S:     Orphan
 F:     drivers/usb/c67x00/
 
 USB DAVICOM DM9601 DRIVER
-M:     Peter Korsgaard <jacmet@sunsite.dk>
+M:     Peter Korsgaard <peter@korsgaard.com>
 L:     netdev@vger.kernel.org
 S:     Maintained
 W:     http://www.linux-usb.org/usbnet
@@ -20475,7 +20492,6 @@ F:      samples/bpf/xdpsock*
 F:     tools/lib/bpf/xsk*
 
 XEN BLOCK SUBSYSTEM
-M:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
 M:     Roger Pau Monné <roger.pau@citrix.com>
 L:     xen-devel@lists.xenproject.org (moderated for non-subscribers)
 S:     Supported
@@ -20523,7 +20539,7 @@ S:      Supported
 F:     drivers/net/xen-netback/*
 
 XEN PCI SUBSYSTEM
-M:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
+M:     Juergen Gross <jgross@suse.com>
 L:     xen-devel@lists.xenproject.org (moderated for non-subscribers)
 S:     Supported
 F:     arch/x86/pci/*xen*
@@ -20546,7 +20562,8 @@ S:      Supported
 F:     sound/xen/*
 
 XEN SWIOTLB SUBSYSTEM
-M:     Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
+M:     Juergen Gross <jgross@suse.com>
+M:     Stefano Stabellini <sstabellini@kernel.org>
 L:     xen-devel@lists.xenproject.org (moderated for non-subscribers)
 L:     iommu@lists.linux-foundation.org
 S:     Supported
@@ -20705,7 +20722,6 @@ S:      Maintained
 F:     mm/zbud.c
 
 ZD1211RW WIRELESS DRIVER
-M:     Daniel Drake <dsd@gentoo.org>
 M:     Ulrich Kunitz <kune@deine-taler.de>
 L:     linux-wireless@vger.kernel.org
 L:     zd1211-devs@lists.sourceforge.net (subscribers-only)
index 7cfe4ff..9129767 100644 (file)
--- a/Makefile
+++ b/Makefile
@@ -2,7 +2,7 @@
 VERSION = 5
 PATCHLEVEL = 15
 SUBLEVEL = 0
-EXTRAVERSION = -rc1
+EXTRAVERSION = -rc6
 NAME = Opossums on Parade
 
 # *DOCUMENTATION*
@@ -849,12 +849,6 @@ endif
 
 DEBUG_CFLAGS   :=
 
-# Workaround for GCC versions < 5.0
-# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61801
-ifdef CONFIG_CC_IS_GCC
-DEBUG_CFLAGS   += $(call cc-ifversion, -lt, 0500, $(call cc-option, -fno-var-tracking-assignments))
-endif
-
 ifdef CONFIG_DEBUG_INFO
 
 ifdef CONFIG_DEBUG_INFO_SPLIT
index 02e5b67..4e87783 100644 (file)
@@ -20,7 +20,7 @@ config ALPHA
        select NEED_SG_DMA_LENGTH
        select VIRT_TO_BUS
        select GENERIC_IRQ_PROBE
-       select GENERIC_PCI_IOMAP if PCI
+       select GENERIC_PCI_IOMAP
        select AUTO_IRQ_AFFINITY if SMP
        select GENERIC_IRQ_SHOW
        select ARCH_WANT_IPC_PARSE_VERSION
@@ -199,7 +199,6 @@ config ALPHA_EIGER
 
 config ALPHA_JENSEN
        bool "Jensen"
-       depends on BROKEN
        select HAVE_EISA
        help
          DEC PC 150 AXP (aka Jensen): This is a very old Digital system - one
index b34cc1f..c8ae46f 100644 (file)
@@ -16,3 +16,4 @@ extern void __divlu(void);
 extern void __remlu(void);
 extern void __divqu(void);
 extern void __remqu(void);
+extern unsigned long __udiv_qrnnd(unsigned long *, unsigned long, unsigned long , unsigned long);
index 0fab5ac..c9cb554 100644 (file)
@@ -60,7 +60,7 @@ extern inline void set_hae(unsigned long new_hae)
  * Change virtual addresses to physical addresses and vv.
  */
 #ifdef USE_48_BIT_KSEG
-static inline unsigned long virt_to_phys(void *address)
+static inline unsigned long virt_to_phys(volatile void *address)
 {
        return (unsigned long)address - IDENT_ADDR;
 }
@@ -70,7 +70,7 @@ static inline void * phys_to_virt(unsigned long address)
        return (void *) (address + IDENT_ADDR);
 }
 #else
-static inline unsigned long virt_to_phys(void *address)
+static inline unsigned long virt_to_phys(volatile void *address)
 {
         unsigned long phys = (unsigned long)address;
 
@@ -106,7 +106,7 @@ static inline void * phys_to_virt(unsigned long address)
 extern unsigned long __direct_map_base;
 extern unsigned long __direct_map_size;
 
-static inline unsigned long __deprecated virt_to_bus(void *address)
+static inline unsigned long __deprecated virt_to_bus(volatile void *address)
 {
        unsigned long phys = virt_to_phys(address);
        unsigned long bus = phys + __direct_map_base;
index 9168951..1c41314 100644 (file)
@@ -111,18 +111,18 @@ __EXTERN_INLINE void jensen_set_hae(unsigned long addr)
  * convinced that I need one of the newer machines.
  */
 
-static inline unsigned int jensen_local_inb(unsigned long addr)
+__EXTERN_INLINE unsigned int jensen_local_inb(unsigned long addr)
 {
        return 0xff & *(vuip)((addr << 9) + EISA_VL82C106);
 }
 
-static inline void jensen_local_outb(u8 b, unsigned long addr)
+__EXTERN_INLINE void jensen_local_outb(u8 b, unsigned long addr)
 {
        *(vuip)((addr << 9) + EISA_VL82C106) = b;
        mb();
 }
 
-static inline unsigned int jensen_bus_inb(unsigned long addr)
+__EXTERN_INLINE unsigned int jensen_bus_inb(unsigned long addr)
 {
        long result;
 
@@ -131,7 +131,7 @@ static inline unsigned int jensen_bus_inb(unsigned long addr)
        return __kernel_extbl(result, addr & 3);
 }
 
-static inline void jensen_bus_outb(u8 b, unsigned long addr)
+__EXTERN_INLINE void jensen_bus_outb(u8 b, unsigned long addr)
 {
        jensen_set_hae(0);
        *(vuip)((addr << 7) + EISA_IO + 0x00) = b * 0x01010101;
diff --git a/arch/alpha/include/asm/setup.h b/arch/alpha/include/asm/setup.h
new file mode 100644 (file)
index 0000000..262aab9
--- /dev/null
@@ -0,0 +1,43 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+#ifndef __ALPHA_SETUP_H
+#define __ALPHA_SETUP_H
+
+#include <uapi/asm/setup.h>
+
+/*
+ * We leave one page for the initial stack page, and one page for
+ * the initial process structure. Also, the console eats 3 MB for
+ * the initial bootloader (one of which we can reclaim later).
+ */
+#define BOOT_PCB       0x20000000
+#define BOOT_ADDR      0x20000000
+/* Remove when official MILO sources have ELF support: */
+#define BOOT_SIZE      (16*1024)
+
+#ifdef CONFIG_ALPHA_LEGACY_START_ADDRESS
+#define KERNEL_START_PHYS      0x300000 /* Old bootloaders hardcoded this.  */
+#else
+#define KERNEL_START_PHYS      0x1000000 /* required: Wildfire/Titan/Marvel */
+#endif
+
+#define KERNEL_START   (PAGE_OFFSET+KERNEL_START_PHYS)
+#define SWAPPER_PGD    KERNEL_START
+#define INIT_STACK     (PAGE_OFFSET+KERNEL_START_PHYS+0x02000)
+#define EMPTY_PGT      (PAGE_OFFSET+KERNEL_START_PHYS+0x04000)
+#define EMPTY_PGE      (PAGE_OFFSET+KERNEL_START_PHYS+0x08000)
+#define ZERO_PGE       (PAGE_OFFSET+KERNEL_START_PHYS+0x0A000)
+
+#define START_ADDR     (PAGE_OFFSET+KERNEL_START_PHYS+0x10000)
+
+/*
+ * This is setup by the secondary bootstrap loader.  Because
+ * the zero page is zeroed out as soon as the vm system is
+ * initialized, we need to copy things out into a more permanent
+ * place.
+ */
+#define PARAM                  ZERO_PGE
+#define COMMAND_LINE           ((char *)(absolute_pointer(PARAM + 0x0000)))
+#define INITRD_START           (*(unsigned long *) (PARAM+0x100))
+#define INITRD_SIZE            (*(unsigned long *) (PARAM+0x108))
+
+#endif
index 13b7ee4..f881ea5 100644 (file)
@@ -1,43 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
-#ifndef __ALPHA_SETUP_H
-#define __ALPHA_SETUP_H
+#ifndef _UAPI__ALPHA_SETUP_H
+#define _UAPI__ALPHA_SETUP_H
 
 #define COMMAND_LINE_SIZE      256
 
-/*
- * We leave one page for the initial stack page, and one page for
- * the initial process structure. Also, the console eats 3 MB for
- * the initial bootloader (one of which we can reclaim later).
- */
-#define BOOT_PCB       0x20000000
-#define BOOT_ADDR      0x20000000
-/* Remove when official MILO sources have ELF support: */
-#define BOOT_SIZE      (16*1024)
-
-#ifdef CONFIG_ALPHA_LEGACY_START_ADDRESS
-#define KERNEL_START_PHYS      0x300000 /* Old bootloaders hardcoded this.  */
-#else
-#define KERNEL_START_PHYS      0x1000000 /* required: Wildfire/Titan/Marvel */
-#endif
-
-#define KERNEL_START   (PAGE_OFFSET+KERNEL_START_PHYS)
-#define SWAPPER_PGD    KERNEL_START
-#define INIT_STACK     (PAGE_OFFSET+KERNEL_START_PHYS+0x02000)
-#define EMPTY_PGT      (PAGE_OFFSET+KERNEL_START_PHYS+0x04000)
-#define EMPTY_PGE      (PAGE_OFFSET+KERNEL_START_PHYS+0x08000)
-#define ZERO_PGE       (PAGE_OFFSET+KERNEL_START_PHYS+0x0A000)
-
-#define START_ADDR     (PAGE_OFFSET+KERNEL_START_PHYS+0x10000)
-
-/*
- * This is setup by the secondary bootstrap loader.  Because
- * the zero page is zeroed out as soon as the vm system is
- * initialized, we need to copy things out into a more permanent
- * place.
- */
-#define PARAM                  ZERO_PGE
-#define COMMAND_LINE           ((char*)(PARAM + 0x0000))
-#define INITRD_START           (*(unsigned long *) (PARAM+0x100))
-#define INITRD_SIZE            (*(unsigned long *) (PARAM+0x108))
-
-#endif
+#endif /* _UAPI__ALPHA_SETUP_H */
index e5d870f..5c9c884 100644 (file)
@@ -7,6 +7,11 @@
  *
  * Code supporting the Jensen.
  */
+#define __EXTERN_INLINE
+#include <asm/io.h>
+#include <asm/jensen.h>
+#undef  __EXTERN_INLINE
+
 #include <linux/interrupt.h>
 #include <linux/kernel.h>
 #include <linux/types.h>
 
 #include <asm/ptrace.h>
 
-#define __EXTERN_INLINE inline
-#include <asm/io.h>
-#include <asm/jensen.h>
-#undef  __EXTERN_INLINE
-
 #include <asm/dma.h>
 #include <asm/irq.h>
 #include <asm/mmu_context.h>
index 854d5e7..1cc74f7 100644 (file)
@@ -14,6 +14,7 @@ ev6-$(CONFIG_ALPHA_EV6) := ev6-
 ev67-$(CONFIG_ALPHA_EV67) := ev67-
 
 lib-y =        __divqu.o __remqu.o __divlu.o __remlu.o \
+       udiv-qrnnd.o \
        udelay.o \
        $(ev6-y)memset.o \
        $(ev6-y)memcpy.o \
diff --git a/arch/alpha/lib/udiv-qrnnd.S b/arch/alpha/lib/udiv-qrnnd.S
new file mode 100644 (file)
index 0000000..b887aa5
--- /dev/null
@@ -0,0 +1,165 @@
+ # Alpha 21064 __udiv_qrnnd
+ # Copyright (C) 1992, 1994, 1995, 2000 Free Software Foundation, Inc.
+
+ # This file is part of GCC.
+
+ # The GNU MP Library is free software; you can redistribute it and/or modify
+ # it under the terms of the GNU General Public License as published by
+ # the Free Software Foundation; either version 2 of the License, or (at your
+ # option) any later version.
+
+ # In addition to the permissions in the GNU General Public License, the
+ # Free Software Foundation gives you unlimited permission to link the
+ # compiled version of this file with other programs, and to distribute
+ # those programs without any restriction coming from the use of this
+ # file.  (The General Public License restrictions do apply in other
+ # respects; for example, they cover modification of the file, and
+ # distribution when not linked into another program.)
+
+ # This file is distributed in the hope that it will be useful, but
+ # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
+ # or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Library General Public
+ # License for more details.
+
+ # You should have received a copy of the GNU General Public License
+ # along with GCC; see the file COPYING.  If not, write to the 
+ # Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
+ # MA 02111-1307, USA.
+#include <asm/export.h>
+
+        .set noreorder
+        .set noat
+
+       .text
+
+       .globl __udiv_qrnnd
+       .ent __udiv_qrnnd
+__udiv_qrnnd:
+       .frame $30,0,$26,0
+       .prologue 0
+
+#define cnt    $2
+#define tmp    $3
+#define rem_ptr        $16
+#define n1     $17
+#define n0     $18
+#define d      $19
+#define qb     $20
+#define AT     $at
+
+       ldiq    cnt,16
+       blt     d,$largedivisor
+
+$loop1:        cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  d,n1,qb
+       subq    n1,d,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  d,n1,qb
+       subq    n1,d,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  d,n1,qb
+       subq    n1,d,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  d,n1,qb
+       subq    n1,d,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       subq    cnt,1,cnt
+       bgt     cnt,$loop1
+       stq     n1,0(rem_ptr)
+       bis     $31,n0,$0
+       ret     $31,($26),1
+
+$largedivisor:
+       and     n0,1,$4
+
+       srl     n0,1,n0
+       sll     n1,63,tmp
+       or      tmp,n0,n0
+       srl     n1,1,n1
+
+       and     d,1,$6
+       srl     d,1,$5
+       addq    $5,$6,$5
+
+$loop2:        cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  $5,n1,qb
+       subq    n1,$5,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  $5,n1,qb
+       subq    n1,$5,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  $5,n1,qb
+       subq    n1,$5,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       cmplt   n0,0,tmp
+       addq    n1,n1,n1
+       bis     n1,tmp,n1
+       addq    n0,n0,n0
+       cmpule  $5,n1,qb
+       subq    n1,$5,tmp
+       cmovne  qb,tmp,n1
+       bis     n0,qb,n0
+       subq    cnt,1,cnt
+       bgt     cnt,$loop2
+
+       addq    n1,n1,n1
+       addq    $4,n1,n1
+       bne     $6,$Odd
+       stq     n1,0(rem_ptr)
+       bis     $31,n0,$0
+       ret     $31,($26),1
+
+$Odd:
+       /* q' in n0. r' in n1 */
+       addq    n1,n0,n1
+
+       cmpult  n1,n0,tmp       # tmp := carry from addq
+       subq    n1,d,AT
+       addq    n0,tmp,n0
+       cmovne  tmp,AT,n1
+
+       cmpult  n1,d,tmp
+       addq    n0,1,AT
+       cmoveq  tmp,AT,n0
+       subq    n1,d,AT
+       cmoveq  tmp,AT,n1
+
+       stq     n1,0(rem_ptr)
+       bis     $31,n0,$0
+       ret     $31,($26),1
+
+       .end    __udiv_qrnnd
+EXPORT_SYMBOL(__udiv_qrnnd)
index 6eda097..3206402 100644 (file)
@@ -7,4 +7,4 @@ ccflags-y := -w
 
 obj-$(CONFIG_MATHEMU) += math-emu.o
 
-math-emu-objs := math.o qrnnd.o
+math-emu-objs := math.o
index f7cef66..4212258 100644 (file)
@@ -403,5 +403,3 @@ alpha_fp_emul_imprecise (struct pt_regs *regs, unsigned long write_mask)
 egress:
        return si_code;
 }
-
-EXPORT_SYMBOL(__udiv_qrnnd);
diff --git a/arch/alpha/math-emu/qrnnd.S b/arch/alpha/math-emu/qrnnd.S
deleted file mode 100644 (file)
index d6373ec..0000000
+++ /dev/null
@@ -1,163 +0,0 @@
- # Alpha 21064 __udiv_qrnnd
- # Copyright (C) 1992, 1994, 1995, 2000 Free Software Foundation, Inc.
-
- # This file is part of GCC.
-
- # The GNU MP Library is free software; you can redistribute it and/or modify
- # it under the terms of the GNU General Public License as published by
- # the Free Software Foundation; either version 2 of the License, or (at your
- # option) any later version.
-
- # In addition to the permissions in the GNU General Public License, the
- # Free Software Foundation gives you unlimited permission to link the
- # compiled version of this file with other programs, and to distribute
- # those programs without any restriction coming from the use of this
- # file.  (The General Public License restrictions do apply in other
- # respects; for example, they cover modification of the file, and
- # distribution when not linked into another program.)
-
- # This file is distributed in the hope that it will be useful, but
- # WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
- # or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Library General Public
- # License for more details.
-
- # You should have received a copy of the GNU General Public License
- # along with GCC; see the file COPYING.  If not, write to the 
- # Free Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
- # MA 02111-1307, USA.
-
-        .set noreorder
-        .set noat
-
-       .text
-
-       .globl __udiv_qrnnd
-       .ent __udiv_qrnnd
-__udiv_qrnnd:
-       .frame $30,0,$26,0
-       .prologue 0
-
-#define cnt    $2
-#define tmp    $3
-#define rem_ptr        $16
-#define n1     $17
-#define n0     $18
-#define d      $19
-#define qb     $20
-#define AT     $at
-
-       ldiq    cnt,16
-       blt     d,$largedivisor
-
-$loop1:        cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  d,n1,qb
-       subq    n1,d,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  d,n1,qb
-       subq    n1,d,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  d,n1,qb
-       subq    n1,d,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  d,n1,qb
-       subq    n1,d,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       subq    cnt,1,cnt
-       bgt     cnt,$loop1
-       stq     n1,0(rem_ptr)
-       bis     $31,n0,$0
-       ret     $31,($26),1
-
-$largedivisor:
-       and     n0,1,$4
-
-       srl     n0,1,n0
-       sll     n1,63,tmp
-       or      tmp,n0,n0
-       srl     n1,1,n1
-
-       and     d,1,$6
-       srl     d,1,$5
-       addq    $5,$6,$5
-
-$loop2:        cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  $5,n1,qb
-       subq    n1,$5,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  $5,n1,qb
-       subq    n1,$5,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  $5,n1,qb
-       subq    n1,$5,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       cmplt   n0,0,tmp
-       addq    n1,n1,n1
-       bis     n1,tmp,n1
-       addq    n0,n0,n0
-       cmpule  $5,n1,qb
-       subq    n1,$5,tmp
-       cmovne  qb,tmp,n1
-       bis     n0,qb,n0
-       subq    cnt,1,cnt
-       bgt     cnt,$loop2
-
-       addq    n1,n1,n1
-       addq    $4,n1,n1
-       bne     $6,$Odd
-       stq     n1,0(rem_ptr)
-       bis     $31,n0,$0
-       ret     $31,($26),1
-
-$Odd:
-       /* q' in n0. r' in n1 */
-       addq    n1,n0,n1
-
-       cmpult  n1,n0,tmp       # tmp := carry from addq
-       subq    n1,d,AT
-       addq    n0,tmp,n0
-       cmovne  tmp,AT,n1
-
-       cmpult  n1,d,tmp
-       addq    n0,1,AT
-       cmoveq  tmp,AT,n0
-       subq    n1,d,AT
-       cmoveq  tmp,AT,n1
-
-       stq     n1,0(rem_ptr)
-       bis     $31,n0,$0
-       ret     $31,($26),1
-
-       .end    __udiv_qrnnd
index 9320b04..4cf45a9 100644 (file)
@@ -26,11 +26,6 @@ extern char empty_zero_page[PAGE_SIZE];
 
 extern pgd_t swapper_pg_dir[] __aligned(PAGE_SIZE);
 
-/* Macro to mark a page protection as uncacheable */
-#define pgprot_noncached(prot) (__pgprot(pgprot_val(prot) & ~_PAGE_CACHEABLE))
-
-extern pgd_t swapper_pg_dir[] __aligned(PAGE_SIZE);
-
 /* to cope with aliasing VIPT cache */
 #define HAVE_ARCH_UNMAPPED_AREA
 
index fc19642..59baf6c 100644 (file)
@@ -1989,8 +1989,6 @@ config ARCH_HIBERNATION_POSSIBLE
 
 endmenu
 
-source "drivers/firmware/Kconfig"
-
 if CRYPTO
 source "arch/arm/crypto/Kconfig"
 endif
index 614999d..cd46725 100644 (file)
@@ -71,7 +71,6 @@
                        isc: isc@f0008000 {
                                pinctrl-names = "default";
                                pinctrl-0 = <&pinctrl_isc_base &pinctrl_isc_data_8bit &pinctrl_isc_data_9_10 &pinctrl_isc_data_11_12>;
-                               status = "okay";
                        };
 
                        qspi1: spi@f0024000 {
index 4cbed98..f3d6aaa 100644 (file)
 
                                        regulator-state-standby {
                                                regulator-on-in-suspend;
+                                               regulator-suspend-microvolt = <1350000>;
                                                regulator-mode = <4>;
                                        };
 
                                        regulator-state-mem {
                                                regulator-on-in-suspend;
+                                               regulator-suspend-microvolt = <1350000>;
                                                regulator-mode = <4>;
                                        };
                                };
        #address-cells = <1>;
        #size-cells = <0>;
        pinctrl-names = "default";
-       pinctrl-0 = <&pinctrl_gmac0_default &pinctrl_gmac0_txck_default &pinctrl_gmac0_phy_irq>;
+       pinctrl-0 = <&pinctrl_gmac0_default
+                    &pinctrl_gmac0_mdio_default
+                    &pinctrl_gmac0_txck_default
+                    &pinctrl_gmac0_phy_irq>;
        phy-mode = "rgmii-id";
        status = "okay";
 
        #address-cells = <1>;
        #size-cells = <0>;
        pinctrl-names = "default";
-       pinctrl-0 = <&pinctrl_gmac1_default &pinctrl_gmac1_phy_irq>;
+       pinctrl-0 = <&pinctrl_gmac1_default
+                    &pinctrl_gmac1_mdio_default
+                    &pinctrl_gmac1_phy_irq>;
        phy-mode = "rmii";
        status = "okay";
 
                         <PIN_PA15__G0_TXEN>,
                         <PIN_PA30__G0_RXCK>,
                         <PIN_PA18__G0_RXDV>,
-                        <PIN_PA22__G0_MDC>,
-                        <PIN_PA23__G0_MDIO>,
                         <PIN_PA25__G0_125CK>;
+               slew-rate = <0>;
+               bias-disable;
+       };
+
+       pinctrl_gmac0_mdio_default: gmac0_mdio_default {
+               pinmux = <PIN_PA22__G0_MDC>,
+                        <PIN_PA23__G0_MDIO>;
                bias-disable;
        };
 
        pinctrl_gmac0_txck_default: gmac0_txck_default {
                pinmux = <PIN_PA24__G0_TXCK>;
+               slew-rate = <0>;
                bias-pull-up;
        };
 
                         <PIN_PD25__G1_RX0>,
                         <PIN_PD26__G1_RX1>,
                         <PIN_PD27__G1_RXER>,
-                        <PIN_PD24__G1_RXDV>,
-                        <PIN_PD28__G1_MDC>,
+                        <PIN_PD24__G1_RXDV>;
+               slew-rate = <0>;
+               bias-disable;
+       };
+
+       pinctrl_gmac1_mdio_default: gmac1_mdio_default {
+               pinmux = <PIN_PD28__G1_MDC>,
                         <PIN_PD29__G1_MDIO>;
                bias-disable;
        };
                                 <PIN_PA8__SDMMC0_DAT5>,
                                 <PIN_PA9__SDMMC0_DAT6>,
                                 <PIN_PA10__SDMMC0_DAT7>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
 
                        pinmux = <PIN_PA0__SDMMC0_CK>,
                                 <PIN_PA2__SDMMC0_RSTN>,
                                 <PIN_PA11__SDMMC0_DS>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
        };
                                 <PIN_PC0__SDMMC1_DAT1>,
                                 <PIN_PC1__SDMMC1_DAT2>,
                                 <PIN_PC2__SDMMC1_DAT3>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
 
                                 <PIN_PB28__SDMMC1_RSTN>,
                                 <PIN_PC5__SDMMC1_1V8SEL>,
                                 <PIN_PC4__SDMMC1_CD>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
        };
                                 <PIN_PD6__SDMMC2_DAT1>,
                                 <PIN_PD7__SDMMC2_DAT2>,
                                 <PIN_PD8__SDMMC2_DAT3>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
 
                ck {
                        pinmux = <PIN_PD4__SDMMC2_CK>;
+                       slew-rate = <0>;
                        bias-pull-up;
                };
        };
        pinctrl-0 = <&pinctrl_sdmmc2_default>;
 };
 
+&shdwc {
+       atmel,shdwc-debouncer = <976>;
+       status = "okay";
+
+       input@0 {
+               reg = <0>;
+       };
+};
+
 &spdifrx {
        pinctrl-names = "default";
        pinctrl-0 = <&pinctrl_spdifrx_default>;
index f24bdd0..72ce80f 100644 (file)
@@ -40,8 +40,8 @@
                regulator-always-on;
                regulator-settling-time-us = <5000>;
                gpios = <&expgpio 4 GPIO_ACTIVE_HIGH>;
-               states = <1800000 0x1
-                         3300000 0x0>;
+               states = <1800000 0x1>,
+                        <3300000 0x0>;
                status = "okay";
        };
 
 };
 
 &pcie0 {
-       pci@1,0 {
+       pci@0,0 {
+               device_type = "pci";
                #address-cells = <3>;
                #size-cells = <2>;
                ranges;
 
                reg = <0 0 0 0 0>;
 
-               usb@1,0 {
-                       reg = <0x10000 0 0 0 0>;
+               usb@0,0 {
+                       reg = <0 0 0 0 0>;
                        resets = <&reset RASPBERRYPI_FIRMWARE_RESET_ID_USB>;
                };
        };
index b8a4096..3b60297 100644 (file)
                        status = "disabled";
                };
 
+               vec: vec@7ec13000 {
+                       compatible = "brcm,bcm2711-vec";
+                       reg = <0x7ec13000 0x1000>;
+                       clocks = <&clocks BCM2835_CLOCK_VEC>;
+                       interrupts = <GIC_SPI 123 IRQ_TYPE_LEVEL_HIGH>;
+                       status = "disabled";
+               };
+
                dvp: clock@7ef00000 {
                        compatible = "brcm,brcm2711-dvp";
                        reg = <0x7ef00000 0x10>;
                                compatible = "brcm,genet-mdio-v5";
                                reg = <0xe14 0x8>;
                                reg-names = "mdio";
-                               #address-cells = <0x0>;
-                               #size-cells = <0x1>;
+                               #address-cells = <0x1>;
+                               #size-cells = <0x0>;
                        };
                };
        };
index 4119271..c25e797 100644 (file)
                        status = "okay";
                };
 
+               vec: vec@7e806000 {
+                       compatible = "brcm,bcm2835-vec";
+                       reg = <0x7e806000 0x1000>;
+                       clocks = <&clocks BCM2835_CLOCK_VEC>;
+                       interrupts = <2 27>;
+                       status = "disabled";
+               };
+
                pixelvalve@7e807000 {
                        compatible = "brcm,bcm2835-pixelvalve2";
                        reg = <0x7e807000 0x100>;
index 0f3be55..a3e06b6 100644 (file)
                        status = "disabled";
                };
 
-               vec: vec@7e806000 {
-                       compatible = "brcm,bcm2835-vec";
-                       reg = <0x7e806000 0x1000>;
-                       clocks = <&clocks BCM2835_CLOCK_VEC>;
-                       interrupts = <2 27>;
-                       status = "disabled";
-               };
-
                usb: usb@7e980000 {
                        compatible = "brcm,bcm2835-usb";
                        reg = <0x7e980000 0x10000>;
index d3082b9..4f88e96 100644 (file)
@@ -56,6 +56,7 @@
        panel {
                compatible = "edt,etm0700g0dh6";
                pinctrl-0 = <&pinctrl_display_gpio>;
+               pinctrl-names = "default";
                enable-gpios = <&gpio6 0 GPIO_ACTIVE_HIGH>;
 
                port {
@@ -76,8 +77,7 @@
                regulator-name = "vbus";
                regulator-min-microvolt = <5000000>;
                regulator-max-microvolt = <5000000>;
-               gpio = <&gpio1 2 GPIO_ACTIVE_HIGH>;
-               enable-active-high;
+               gpio = <&gpio1 2 0>;
        };
 };
 
index cb8b539..e5c4dc6 100644 (file)
@@ -5,6 +5,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/interrupt-controller/irq.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/leds/common.h>
 #include <dt-bindings/pwm/pwm.h>
 
 / {
                        led-cur = /bits/ 8 <0x20>;
                        max-cur = /bits/ 8 <0x60>;
                        reg = <0>;
+                       color = <LED_COLOR_ID_RED>;
                };
 
                chan@1 {
                        led-cur = /bits/ 8 <0x20>;
                        max-cur = /bits/ 8 <0x60>;
                        reg = <1>;
+                       color = <LED_COLOR_ID_GREEN>;
                };
 
                chan@2 {
                        led-cur = /bits/ 8 <0x20>;
                        max-cur = /bits/ 8 <0x60>;
                        reg = <2>;
+                       color = <LED_COLOR_ID_BLUE>;
                };
 
                chan@3 {
                        led-cur = /bits/ 8 <0x0>;
                        max-cur = /bits/ 8 <0x0>;
                        reg = <3>;
+                       color = <LED_COLOR_ID_WHITE>;
                };
        };
 
index 5de4ccb..f7a56d6 100644 (file)
        pinctrl-0 = <&pinctrl_enet>;
        phy-mode = "rgmii-id";
        phy-reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>;
+       phy-handle = <&phy>;
        status = "okay";
+
+       mdio {
+               #address-cells = <1>;
+               #size-cells = <0>;
+
+               phy: ethernet-phy@1 {
+                       reg = <1>;
+                       qca,clk-out-frequency = <125000000>;
+               };
+       };
 };
 
 &hdmi {
index 5a63ca6..99f4cf7 100644 (file)
                compatible = "micron,n25q256a", "jedec,spi-nor";
                spi-max-frequency = <29000000>;
                spi-rx-bus-width = <4>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                reg = <0>;
        };
 
                compatible = "micron,n25q256a", "jedec,spi-nor";
                spi-max-frequency = <29000000>;
                spi-rx-bus-width = <4>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                reg = <2>;
        };
 };
index 779cc53..a3fde33 100644 (file)
                compatible = "micron,n25q256a", "jedec,spi-nor";
                spi-max-frequency = <29000000>;
                spi-rx-bus-width = <4>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                reg = <0>;
        };
 };
index c5b9037..7d530ae 100644 (file)
 
        nand@1,0 {
                compatible = "ti,omap2-nand";
-               reg = <0 0 4>; /* CS0, offset 0, IO size 4 */
+               reg = <1 0 4>; /* CS1, offset 0, IO size 4 */
                interrupt-parent = <&gpmc>;
                interrupts = <0 IRQ_TYPE_NONE>, /* fifoevent */
                             <1 IRQ_TYPE_NONE>; /* termcount */
index 0b2bed6..d1c1c6a 100644 (file)
                        clock-frequency = <19200000>;
                };
 
-               pxo_board {
+               pxo_board: pxo_board {
                        compatible = "fixed-clock";
                        #clock-cells = <0>;
                        clock-frequency = <27000000>;
                };
 
                gpu: adreno-3xx@4300000 {
-                       compatible = "qcom,adreno-3xx";
+                       compatible = "qcom,adreno-320.2", "qcom,adreno";
                        reg = <0x04300000 0x20000>;
                        reg-names = "kgsl_3d0_reg_memory";
                        interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
                        interrupt-names = "kgsl_3d0_irq";
                        clock-names =
-                           "core_clk",
-                           "iface_clk",
-                           "mem_clk",
-                           "mem_iface_clk";
+                           "core",
+                           "iface",
+                           "mem",
+                           "mem_iface";
                        clocks =
                            <&mmcc GFX3D_CLK>,
                            <&mmcc GFX3D_AHB_CLK>,
                            <&mmcc GFX3D_AXI_CLK>,
                            <&mmcc MMSS_IMEM_AHB_CLK>;
-                       qcom,chipid = <0x03020002>;
 
                        iommus = <&gfx3d 0
                                  &gfx3d 1
                        reg-names = "dsi_pll", "dsi_phy", "dsi_phy_regulator";
                        clock-names = "iface_clk", "ref";
                        clocks = <&mmcc DSI_M_AHB_CLK>,
-                                <&cxo_board>;
+                                <&pxo_board>;
                };
 
 
index cc6be6d..6c58c15 100644 (file)
                #size-cells = <1>;
                ranges;
 
+               securam: securam@e0000000 {
+                       compatible = "microchip,sama7g5-securam", "atmel,sama5d2-securam", "mmio-sram";
+                       reg = <0xe0000000 0x4000>;
+                       clocks = <&pmc PMC_TYPE_PERIPHERAL 18>;
+                       #address-cells = <1>;
+                       #size-cells = <1>;
+                       ranges = <0 0xe0000000 0x4000>;
+                       no-memory-wc;
+                       status = "okay";
+               };
+
                secumod: secumod@e0004000 {
                        compatible = "microchip,sama7g5-secumod", "atmel,sama5d2-secumod", "syscon";
                        reg = <0xe0004000 0x4000>;
                        clock-names = "td_slck", "md_slck", "main_xtal";
                };
 
+               shdwc: shdwc@e001d010 {
+                       compatible = "microchip,sama7g5-shdwc", "syscon";
+                       reg = <0xe001d010 0x10>;
+                       clocks = <&clk32k 0>;
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+                       atmel,wakeup-rtc-timer;
+                       atmel,wakeup-rtt-timer;
+                       status = "disabled";
+               };
+
                rtt: rtt@e001d020 {
                        compatible = "microchip,sama7g5-rtt", "microchip,sam9x60-rtt", "atmel,at91sam9260-rtt";
                        reg = <0xe001d020 0x30>;
                        clocks = <&clk32k 0>;
                };
 
+               chipid@e0020000 {
+                       compatible = "microchip,sama7g5-chipid";
+                       reg = <0xe0020000 0x8>;
+               };
+
                sdmmc0: mmc@e1204000 {
                        compatible = "microchip,sama7g5-sdhci", "microchip,sam9x60-sdhci";
                        reg = <0xe1204000 0x4000>;
                        };
                };
 
+               uddrc: uddrc@e3800000 {
+                       compatible = "microchip,sama7g5-uddrc";
+                       reg = <0xe3800000 0x4000>;
+                       status = "okay";
+               };
+
+               ddr3phy: ddr3phy@e3804000 {
+                       compatible = "microchip,sama7g5-ddr3phy";
+                       reg = <0xe3804000 0x1000>;
+                       status = "okay";
+               };
+
                gic: interrupt-controller@e8c11000 {
                        compatible = "arm,cortex-a7-gic";
                        #interrupt-cells = <3>;
index f266b7b..cc88ebe 100644 (file)
@@ -47,7 +47,7 @@
                };
 
                gmac: eth@e0800000 {
-                       compatible = "st,spear600-gmac";
+                       compatible = "snps,dwmac-3.40a";
                        reg = <0xe0800000 0x8000>;
                        interrupts = <23 22>;
                        interrupt-names = "macirq", "eth_wake_irq";
index 2ad9fd7..8af4b77 100644 (file)
@@ -17,6 +17,7 @@
  * TAKE CARE WHEN MAINTAINING THIS FILE TO PROPAGATE ANY RELEVANT
  * CHANGES TO vexpress-v2m.dtsi!
  */
+#include <dt-bindings/interrupt-controller/arm-gic.h>
 
 / {
        v2m_fixed_3v3: fixed-regulator-0 {
        };
 
        bus@8000000 {
-               motherboard-bus {
-                       model = "V2M-P1";
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <1>;
+
+               #interrupt-cells = <1>;
+               interrupt-map-mask = <0 63>;
+               interrupt-map = <0  0 &gic GIC_SPI  0 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  1 &gic GIC_SPI  1 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  2 &gic GIC_SPI  2 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  3 &gic GIC_SPI  3 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  4 &gic GIC_SPI  4 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  5 &gic GIC_SPI  5 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  6 &gic GIC_SPI  6 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  7 &gic GIC_SPI  7 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  8 &gic GIC_SPI  8 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  9 &gic GIC_SPI  9 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 10 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 11 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 12 &gic GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 13 &gic GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 14 &gic GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 15 &gic GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 16 &gic GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 17 &gic GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 18 &gic GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 19 &gic GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 20 &gic GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 21 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 22 &gic GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 23 &gic GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 24 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 25 &gic GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 26 &gic GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 27 &gic GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 28 &gic GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 29 &gic GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 30 &gic GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 31 &gic GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 32 &gic GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 33 &gic GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 34 &gic GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 35 &gic GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 36 &gic GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 37 &gic GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 38 &gic GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 39 &gic GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 40 &gic GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 41 &gic GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 42 &gic GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+
+               motherboard-bus@8000000 {
                        arm,hbi = <0x190>;
                        arm,vexpress,site = <0>;
-                       arm,v2m-memory-map = "rs1";
                        compatible = "arm,vexpress,v2m-p1", "simple-bus";
                        #address-cells = <2>; /* SMB chipselect number and offset */
                        #size-cells = <1>;
-                       #interrupt-cells = <1>;
-                       ranges;
+                       ranges = <0 0 0x08000000 0x04000000>,
+                                <1 0 0x14000000 0x04000000>,
+                                <2 0 0x18000000 0x04000000>,
+                                <3 0 0x1c000000 0x04000000>,
+                                <4 0 0x0c000000 0x04000000>,
+                                <5 0 0x10000000 0x04000000>;
 
                        nor_flash: flash@0 {
                                compatible = "arm,vexpress-flash", "cfi-flash";
                                        clock-names = "apb_pclk";
                                };
 
-                               mmci@50000 {
+                               mmc@50000 {
                                        compatible = "arm,pl180", "arm,primecell";
                                        reg = <0x050000 0x1000>;
                                        interrupts = <9>, <10>;
                                        clock-names = "uartclk", "apb_pclk";
                                };
 
-                               wdt@f0000 {
+                               watchdog@f0000 {
                                        compatible = "arm,sp805", "arm,primecell";
                                        reg = <0x0f0000 0x1000>;
                                        interrupts = <0>;
index ec13ceb..f434fe5 100644 (file)
  * TAKE CARE WHEN MAINTAINING THIS FILE TO PROPAGATE ANY RELEVANT
  * CHANGES TO vexpress-v2m-rs1.dtsi!
  */
+#include <dt-bindings/interrupt-controller/arm-gic.h>
 
 / {
-       bus@4000000 {
-               motherboard {
-                       model = "V2M-P1";
+       bus@40000000 {
+               compatible = "simple-bus";
+               #address-cells = <1>;
+               #size-cells = <1>;
+               ranges = <0x40000000 0x40000000 0x10000000>,
+                        <0x10000000 0x10000000 0x00020000>;
+
+               #interrupt-cells = <1>;
+               interrupt-map-mask = <0 63>;
+               interrupt-map = <0  0 &gic GIC_SPI  0 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  1 &gic GIC_SPI  1 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  2 &gic GIC_SPI  2 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  3 &gic GIC_SPI  3 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  4 &gic GIC_SPI  4 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  5 &gic GIC_SPI  5 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  6 &gic GIC_SPI  6 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  7 &gic GIC_SPI  7 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  8 &gic GIC_SPI  8 IRQ_TYPE_LEVEL_HIGH>,
+                               <0  9 &gic GIC_SPI  9 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 10 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 11 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 12 &gic GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 13 &gic GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 14 &gic GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 15 &gic GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 16 &gic GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 17 &gic GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 18 &gic GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 19 &gic GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 20 &gic GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 21 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 22 &gic GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 23 &gic GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 24 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 25 &gic GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 26 &gic GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 27 &gic GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 28 &gic GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 29 &gic GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 30 &gic GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 31 &gic GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 32 &gic GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 33 &gic GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 34 &gic GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 35 &gic GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 36 &gic GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 37 &gic GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 38 &gic GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 39 &gic GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 40 &gic GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 41 &gic GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
+                               <0 42 &gic GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+
+               motherboard-bus@40000000 {
                        arm,hbi = <0x190>;
                        arm,vexpress,site = <0>;
                        compatible = "arm,vexpress,v2m-p1", "simple-bus";
                        #address-cells = <2>; /* SMB chipselect number and offset */
                        #size-cells = <1>;
-                       #interrupt-cells = <1>;
-                       ranges;
+                       ranges = <0 0 0x40000000 0x04000000>,
+                                <1 0 0x44000000 0x04000000>,
+                                <2 0 0x48000000 0x04000000>,
+                                <3 0 0x4c000000 0x04000000>,
+                                <7 0 0x10000000 0x00020000>;
 
                        flash@0,00000000 {
                                compatible = "arm,vexpress-flash", "cfi-flash";
index e63c5c0..679537e 100644 (file)
        };
 
        bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
-               #interrupt-cells = <1>;
-               interrupt-map-mask = <0 0 63>;
-               interrupt-map = <0 0  0 &gic 0  0 4>,
-                               <0 0  1 &gic 0  1 4>,
-                               <0 0  2 &gic 0  2 4>,
-                               <0 0  3 &gic 0  3 4>,
-                               <0 0  4 &gic 0  4 4>,
-                               <0 0  5 &gic 0  5 4>,
-                               <0 0  6 &gic 0  6 4>,
-                               <0 0  7 &gic 0  7 4>,
-                               <0 0  8 &gic 0  8 4>,
-                               <0 0  9 &gic 0  9 4>,
-                               <0 0 10 &gic 0 10 4>,
-                               <0 0 11 &gic 0 11 4>,
-                               <0 0 12 &gic 0 12 4>,
-                               <0 0 13 &gic 0 13 4>,
-                               <0 0 14 &gic 0 14 4>,
-                               <0 0 15 &gic 0 15 4>,
-                               <0 0 16 &gic 0 16 4>,
-                               <0 0 17 &gic 0 17 4>,
-                               <0 0 18 &gic 0 18 4>,
-                               <0 0 19 &gic 0 19 4>,
-                               <0 0 20 &gic 0 20 4>,
-                               <0 0 21 &gic 0 21 4>,
-                               <0 0 22 &gic 0 22 4>,
-                               <0 0 23 &gic 0 23 4>,
-                               <0 0 24 &gic 0 24 4>,
-                               <0 0 25 &gic 0 25 4>,
-                               <0 0 26 &gic 0 26 4>,
-                               <0 0 27 &gic 0 27 4>,
-                               <0 0 28 &gic 0 28 4>,
-                               <0 0 29 &gic 0 29 4>,
-                               <0 0 30 &gic 0 30 4>,
-                               <0 0 31 &gic 0 31 4>,
-                               <0 0 32 &gic 0 32 4>,
-                               <0 0 33 &gic 0 33 4>,
-                               <0 0 34 &gic 0 34 4>,
-                               <0 0 35 &gic 0 35 4>,
-                               <0 0 36 &gic 0 36 4>,
-                               <0 0 37 &gic 0 37 4>,
-                               <0 0 38 &gic 0 38 4>,
-                               <0 0 39 &gic 0 39 4>,
-                               <0 0 40 &gic 0 40 4>,
-                               <0 0 41 &gic 0 41 4>,
-                               <0 0 42 &gic 0 42 4>;
+               ranges = <0x8000000 0 0x8000000 0x18000000>;
        };
 
        site2: hsb@40000000 {
index 012d40a..511e87c 100644 (file)
        };
 
        smb: bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
-               #interrupt-cells = <1>;
-               interrupt-map-mask = <0 0 63>;
-               interrupt-map = <0 0  0 &gic 0  0 4>,
-                               <0 0  1 &gic 0  1 4>,
-                               <0 0  2 &gic 0  2 4>,
-                               <0 0  3 &gic 0  3 4>,
-                               <0 0  4 &gic 0  4 4>,
-                               <0 0  5 &gic 0  5 4>,
-                               <0 0  6 &gic 0  6 4>,
-                               <0 0  7 &gic 0  7 4>,
-                               <0 0  8 &gic 0  8 4>,
-                               <0 0  9 &gic 0  9 4>,
-                               <0 0 10 &gic 0 10 4>,
-                               <0 0 11 &gic 0 11 4>,
-                               <0 0 12 &gic 0 12 4>,
-                               <0 0 13 &gic 0 13 4>,
-                               <0 0 14 &gic 0 14 4>,
-                               <0 0 15 &gic 0 15 4>,
-                               <0 0 16 &gic 0 16 4>,
-                               <0 0 17 &gic 0 17 4>,
-                               <0 0 18 &gic 0 18 4>,
-                               <0 0 19 &gic 0 19 4>,
-                               <0 0 20 &gic 0 20 4>,
-                               <0 0 21 &gic 0 21 4>,
-                               <0 0 22 &gic 0 22 4>,
-                               <0 0 23 &gic 0 23 4>,
-                               <0 0 24 &gic 0 24 4>,
-                               <0 0 25 &gic 0 25 4>,
-                               <0 0 26 &gic 0 26 4>,
-                               <0 0 27 &gic 0 27 4>,
-                               <0 0 28 &gic 0 28 4>,
-                               <0 0 29 &gic 0 29 4>,
-                               <0 0 30 &gic 0 30 4>,
-                               <0 0 31 &gic 0 31 4>,
-                               <0 0 32 &gic 0 32 4>,
-                               <0 0 33 &gic 0 33 4>,
-                               <0 0 34 &gic 0 34 4>,
-                               <0 0 35 &gic 0 35 4>,
-                               <0 0 36 &gic 0 36 4>,
-                               <0 0 37 &gic 0 37 4>,
-                               <0 0 38 &gic 0 38 4>,
-                               <0 0 39 &gic 0 39 4>,
-                               <0 0 40 &gic 0 40 4>,
-                               <0 0 41 &gic 0 41 4>,
-                               <0 0 42 &gic 0 42 4>;
+               ranges = <0x8000000 0 0x8000000 0x18000000>;
        };
 
        site2: hsb@40000000 {
index 7aa64ae..3b88209 100644 (file)
        };
 
        smb: bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0x08000000 0x04000000>,
-                        <1 0 0x14000000 0x04000000>,
-                        <2 0 0x18000000 0x04000000>,
-                        <3 0 0x1c000000 0x04000000>,
-                        <4 0 0x0c000000 0x04000000>,
-                        <5 0 0x10000000 0x04000000>;
-
-               #interrupt-cells = <1>;
-               interrupt-map-mask = <0 0 63>;
-               interrupt-map = <0 0  0 &gic 0  0 4>,
-                               <0 0  1 &gic 0  1 4>,
-                               <0 0  2 &gic 0  2 4>,
-                               <0 0  3 &gic 0  3 4>,
-                               <0 0  4 &gic 0  4 4>,
-                               <0 0  5 &gic 0  5 4>,
-                               <0 0  6 &gic 0  6 4>,
-                               <0 0  7 &gic 0  7 4>,
-                               <0 0  8 &gic 0  8 4>,
-                               <0 0  9 &gic 0  9 4>,
-                               <0 0 10 &gic 0 10 4>,
-                               <0 0 11 &gic 0 11 4>,
-                               <0 0 12 &gic 0 12 4>,
-                               <0 0 13 &gic 0 13 4>,
-                               <0 0 14 &gic 0 14 4>,
-                               <0 0 15 &gic 0 15 4>,
-                               <0 0 16 &gic 0 16 4>,
-                               <0 0 17 &gic 0 17 4>,
-                               <0 0 18 &gic 0 18 4>,
-                               <0 0 19 &gic 0 19 4>,
-                               <0 0 20 &gic 0 20 4>,
-                               <0 0 21 &gic 0 21 4>,
-                               <0 0 22 &gic 0 22 4>,
-                               <0 0 23 &gic 0 23 4>,
-                               <0 0 24 &gic 0 24 4>,
-                               <0 0 25 &gic 0 25 4>,
-                               <0 0 26 &gic 0 26 4>,
-                               <0 0 27 &gic 0 27 4>,
-                               <0 0 28 &gic 0 28 4>,
-                               <0 0 29 &gic 0 29 4>,
-                               <0 0 30 &gic 0 30 4>,
-                               <0 0 31 &gic 0 31 4>,
-                               <0 0 32 &gic 0 32 4>,
-                               <0 0 33 &gic 0 33 4>,
-                               <0 0 34 &gic 0 34 4>,
-                               <0 0 35 &gic 0 35 4>,
-                               <0 0 36 &gic 0 36 4>,
-                               <0 0 37 &gic 0 37 4>,
-                               <0 0 38 &gic 0 38 4>,
-                               <0 0 39 &gic 0 39 4>,
-                               <0 0 40 &gic 0 40 4>,
-                               <0 0 41 &gic 0 41 4>,
-                               <0 0 42 &gic 0 42 4>;
+               ranges = <0 0x8000000 0x18000000>;
        };
 
        site2: hsb@40000000 {
index 4c58479..5916e48 100644 (file)
                };
        };
 
-       smb: bus@4000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0x40000000 0x04000000>,
-                        <1 0 0x44000000 0x04000000>,
-                        <2 0 0x48000000 0x04000000>,
-                        <3 0 0x4c000000 0x04000000>,
-                        <7 0 0x10000000 0x00020000>;
-
-               #interrupt-cells = <1>;
-               interrupt-map-mask = <0 0 63>;
-               interrupt-map = <0 0  0 &gic 0  0 4>,
-                               <0 0  1 &gic 0  1 4>,
-                               <0 0  2 &gic 0  2 4>,
-                               <0 0  3 &gic 0  3 4>,
-                               <0 0  4 &gic 0  4 4>,
-                               <0 0  5 &gic 0  5 4>,
-                               <0 0  6 &gic 0  6 4>,
-                               <0 0  7 &gic 0  7 4>,
-                               <0 0  8 &gic 0  8 4>,
-                               <0 0  9 &gic 0  9 4>,
-                               <0 0 10 &gic 0 10 4>,
-                               <0 0 11 &gic 0 11 4>,
-                               <0 0 12 &gic 0 12 4>,
-                               <0 0 13 &gic 0 13 4>,
-                               <0 0 14 &gic 0 14 4>,
-                               <0 0 15 &gic 0 15 4>,
-                               <0 0 16 &gic 0 16 4>,
-                               <0 0 17 &gic 0 17 4>,
-                               <0 0 18 &gic 0 18 4>,
-                               <0 0 19 &gic 0 19 4>,
-                               <0 0 20 &gic 0 20 4>,
-                               <0 0 21 &gic 0 21 4>,
-                               <0 0 22 &gic 0 22 4>,
-                               <0 0 23 &gic 0 23 4>,
-                               <0 0 24 &gic 0 24 4>,
-                               <0 0 25 &gic 0 25 4>,
-                               <0 0 26 &gic 0 26 4>,
-                               <0 0 27 &gic 0 27 4>,
-                               <0 0 28 &gic 0 28 4>,
-                               <0 0 29 &gic 0 29 4>,
-                               <0 0 30 &gic 0 30 4>,
-                               <0 0 31 &gic 0 31 4>,
-                               <0 0 32 &gic 0 32 4>,
-                               <0 0 33 &gic 0 33 4>,
-                               <0 0 34 &gic 0 34 4>,
-                               <0 0 35 &gic 0 35 4>,
-                               <0 0 36 &gic 0 36 4>,
-                               <0 0 37 &gic 0 37 4>,
-                               <0 0 38 &gic 0 38 4>,
-                               <0 0 39 &gic 0 39 4>,
-                               <0 0 40 &gic 0 40 4>,
-                               <0 0 41 &gic 0 41 4>,
-                               <0 0 42 &gic 0 42 4>;
-       };
-
        site2: hsb@e0000000 {
                compatible = "simple-bus";
                #address-cells = <1>;
index efeb572..6237ede 100644 (file)
@@ -40,7 +40,9 @@ EXPORT_SYMBOL(sharpsl_param);
 
 void sharpsl_save_param(void)
 {
-       memcpy(&sharpsl_param, param_start(PARAM_BASE), sizeof(struct sharpsl_param_info));
+       struct sharpsl_param_info *params = param_start(PARAM_BASE);
+
+       memcpy(&sharpsl_param, params, sizeof(*params));
 
        if (sharpsl_param.comadj_keyword != COMADJ_MAGIC)
                sharpsl_param.comadj=-1;
index d2d5f1c..e6ff844 100644 (file)
@@ -76,6 +76,7 @@ CONFIG_REGULATOR_FIXED_VOLTAGE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_ILITEK_IL9322=y
 CONFIG_DRM_TVE200=y
+CONFIG_FB=y
 CONFIG_LOGO=y
 CONFIG_USB=y
 CONFIG_USB_MON=y
index ccee86d..5e4128d 100644 (file)
@@ -292,6 +292,7 @@ CONFIG_DRM_IMX_LDB=y
 CONFIG_DRM_IMX_HDMI=y
 CONFIG_DRM_ETNAVIV=y
 CONFIG_DRM_MXSFB=y
+CONFIG_FB=y
 CONFIG_FB_MODE_HELPERS=y
 CONFIG_LCD_CLASS_DEVICE=y
 CONFIG_LCD_L4F00242T03=y
index ba67c47..3357299 100644 (file)
@@ -197,7 +197,6 @@ CONFIG_PCI_EPF_TEST=m
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_OMAP_OCP2SCP=y
-CONFIG_SIMPLE_PM_BUS=y
 CONFIG_MTD=y
 CONFIG_MTD_CMDLINE_PARTS=y
 CONFIG_MTD_BLOCK=y
@@ -456,6 +455,7 @@ CONFIG_PINCTRL_STMFX=y
 CONFIG_PINCTRL_PALMAS=y
 CONFIG_PINCTRL_OWL=y
 CONFIG_PINCTRL_S500=y
+CONFIG_PINCTRL_MSM=y
 CONFIG_PINCTRL_APQ8064=y
 CONFIG_PINCTRL_APQ8084=y
 CONFIG_PINCTRL_IPQ8064=y
@@ -725,6 +725,7 @@ CONFIG_DRM_PL111=m
 CONFIG_DRM_LIMA=m
 CONFIG_DRM_PANFROST=m
 CONFIG_DRM_ASPEED_GFX=m
+CONFIG_FB=y
 CONFIG_FB_EFI=y
 CONFIG_FB_WM8505=y
 CONFIG_FB_SH_MOBILE_LCDC=y
@@ -1122,6 +1123,7 @@ CONFIG_PHY_DM816X_USB=m
 CONFIG_OMAP_USB2=y
 CONFIG_TI_PIPE3=y
 CONFIG_TWL4030_USB=m
+CONFIG_RAS=y
 CONFIG_NVMEM_IMX_OCOTP=y
 CONFIG_ROCKCHIP_EFUSE=m
 CONFIG_NVMEM_SUNXI_SID=y
index cae0db6..de37f7e 100644 (file)
@@ -46,7 +46,6 @@ CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=64
-CONFIG_SIMPLE_PM_BUS=y
 CONFIG_MTD=y
 CONFIG_MTD_CMDLINE_PARTS=y
 CONFIG_MTD_BLOCK=y
index d9a27e4..18d2a96 100644 (file)
@@ -40,7 +40,6 @@ CONFIG_PCI_RCAR_GEN2=y
 CONFIG_PCIE_RCAR_HOST=y
 CONFIG_DEVTMPFS=y
 CONFIG_DEVTMPFS_MOUNT=y
-CONFIG_SIMPLE_PM_BUS=y
 CONFIG_MTD=y
 CONFIG_MTD_BLOCK=y
 CONFIG_MTD_CFI=y
index d0a800b..a41e27a 100644 (file)
@@ -628,7 +628,6 @@ do_work_pending(struct pt_regs *regs, unsigned int thread_flags, int syscall)
                                uprobe_notify_resume(regs);
                        } else {
                                tracehook_notify_resume(regs);
-                               rseq_handle_notify_resume(NULL, regs);
                        }
                }
                local_irq_disable();
index d6cfe7c..8711d68 100644 (file)
@@ -47,12 +47,26 @@ struct at91_pm_bu {
        unsigned long ddr_phy_calibration[BACKUP_DDR_PHY_CALIBRATION];
 };
 
+/*
+ * struct at91_pm_sfrbu_offsets: registers mapping for SFRBU
+ * @pswbu: power switch BU control registers
+ */
+struct at91_pm_sfrbu_regs {
+       struct {
+               u32 key;
+               u32 ctrl;
+               u32 state;
+               u32 softsw;
+       } pswbu;
+};
+
 /**
  * struct at91_soc_pm - AT91 SoC power management data structure
  * @config_shdwc_ws: wakeup sources configuration function for SHDWC
  * @config_pmc_ws: wakeup srouces configuration function for PMC
  * @ws_ids: wakup sources of_device_id array
  * @data: PM data to be used on last phase of suspend
+ * @sfrbu_regs: SFRBU registers mapping
  * @bu: backup unit mapped data (for backup mode)
  * @memcs: memory chip select
  */
@@ -62,6 +76,7 @@ struct at91_soc_pm {
        const struct of_device_id *ws_ids;
        struct at91_pm_bu *bu;
        struct at91_pm_data data;
+       struct at91_pm_sfrbu_regs sfrbu_regs;
        void *memcs;
 };
 
@@ -356,9 +371,36 @@ static int at91_suspend_finish(unsigned long val)
        return 0;
 }
 
+static void at91_pm_switch_ba_to_vbat(void)
+{
+       unsigned int offset = offsetof(struct at91_pm_sfrbu_regs, pswbu);
+       unsigned int val;
+
+       /* Just for safety. */
+       if (!soc_pm.data.sfrbu)
+               return;
+
+       val = readl(soc_pm.data.sfrbu + offset);
+
+       /* Already on VBAT. */
+       if (!(val & soc_pm.sfrbu_regs.pswbu.state))
+               return;
+
+       val &= ~soc_pm.sfrbu_regs.pswbu.softsw;
+       val |= soc_pm.sfrbu_regs.pswbu.key | soc_pm.sfrbu_regs.pswbu.ctrl;
+       writel(val, soc_pm.data.sfrbu + offset);
+
+       /* Wait for update. */
+       val = readl(soc_pm.data.sfrbu + offset);
+       while (val & soc_pm.sfrbu_regs.pswbu.state)
+               val = readl(soc_pm.data.sfrbu + offset);
+}
+
 static void at91_pm_suspend(suspend_state_t state)
 {
        if (soc_pm.data.mode == AT91_PM_BACKUP) {
+               at91_pm_switch_ba_to_vbat();
+
                cpu_suspend(0, at91_suspend_finish);
 
                /* The SRAM is lost between suspend cycles */
@@ -589,18 +631,22 @@ static const struct of_device_id ramc_phy_ids[] __initconst = {
        { /* Sentinel. */ },
 };
 
-static __init void at91_dt_ramc(bool phy_mandatory)
+static __init int at91_dt_ramc(bool phy_mandatory)
 {
        struct device_node *np;
        const struct of_device_id *of_id;
        int idx = 0;
        void *standby = NULL;
        const struct ramc_info *ramc;
+       int ret;
 
        for_each_matching_node_and_match(np, ramc_ids, &of_id) {
                soc_pm.data.ramc[idx] = of_iomap(np, 0);
-               if (!soc_pm.data.ramc[idx])
-                       panic(pr_fmt("unable to map ramc[%d] cpu registers\n"), idx);
+               if (!soc_pm.data.ramc[idx]) {
+                       pr_err("unable to map ramc[%d] cpu registers\n", idx);
+                       ret = -ENOMEM;
+                       goto unmap_ramc;
+               }
 
                ramc = of_id->data;
                if (ramc) {
@@ -612,25 +658,42 @@ static __init void at91_dt_ramc(bool phy_mandatory)
                idx++;
        }
 
-       if (!idx)
-               panic(pr_fmt("unable to find compatible ram controller node in dtb\n"));
+       if (!idx) {
+               pr_err("unable to find compatible ram controller node in dtb\n");
+               ret = -ENODEV;
+               goto unmap_ramc;
+       }
 
        /* Lookup for DDR PHY node, if any. */
        for_each_matching_node_and_match(np, ramc_phy_ids, &of_id) {
                soc_pm.data.ramc_phy = of_iomap(np, 0);
-               if (!soc_pm.data.ramc_phy)
-                       panic(pr_fmt("unable to map ramc phy cpu registers\n"));
+               if (!soc_pm.data.ramc_phy) {
+                       pr_err("unable to map ramc phy cpu registers\n");
+                       ret = -ENOMEM;
+                       goto unmap_ramc;
+               }
        }
 
-       if (phy_mandatory && !soc_pm.data.ramc_phy)
-               panic(pr_fmt("DDR PHY is mandatory!\n"));
+       if (phy_mandatory && !soc_pm.data.ramc_phy) {
+               pr_err("DDR PHY is mandatory!\n");
+               ret = -ENODEV;
+               goto unmap_ramc;
+       }
 
        if (!standby) {
                pr_warn("ramc no standby function available\n");
-               return;
+               return 0;
        }
 
        at91_cpuidle_device.dev.platform_data = standby;
+
+       return 0;
+
+unmap_ramc:
+       while (idx)
+               iounmap(soc_pm.data.ramc[--idx]);
+
+       return ret;
 }
 
 static void at91rm9200_idle(void)
@@ -1017,6 +1080,8 @@ static void __init at91_pm_init(void (*pm_idle)(void))
 
 void __init at91rm9200_pm_init(void)
 {
+       int ret;
+
        if (!IS_ENABLED(CONFIG_SOC_AT91RM9200))
                return;
 
@@ -1028,7 +1093,9 @@ void __init at91rm9200_pm_init(void)
        soc_pm.data.standby_mode = AT91_PM_STANDBY;
        soc_pm.data.suspend_mode = AT91_PM_ULP0;
 
-       at91_dt_ramc(false);
+       ret = at91_dt_ramc(false);
+       if (ret)
+               return;
 
        /*
         * AT91RM9200 SDRAM low-power mode cannot be used with self-refresh.
@@ -1046,13 +1113,17 @@ void __init sam9x60_pm_init(void)
        static const int iomaps[] __initconst = {
                [AT91_PM_ULP1]          = AT91_PM_IOMAP(SHDWC),
        };
+       int ret;
 
        if (!IS_ENABLED(CONFIG_SOC_SAM9X60))
                return;
 
        at91_pm_modes_validate(modes, ARRAY_SIZE(modes));
        at91_pm_modes_init(iomaps, ARRAY_SIZE(iomaps));
-       at91_dt_ramc(false);
+       ret = at91_dt_ramc(false);
+       if (ret)
+               return;
+
        at91_pm_init(NULL);
 
        soc_pm.ws_ids = sam9x60_ws_ids;
@@ -1061,6 +1132,8 @@ void __init sam9x60_pm_init(void)
 
 void __init at91sam9_pm_init(void)
 {
+       int ret;
+
        if (!IS_ENABLED(CONFIG_SOC_AT91SAM9))
                return;
 
@@ -1072,7 +1145,10 @@ void __init at91sam9_pm_init(void)
        soc_pm.data.standby_mode = AT91_PM_STANDBY;
        soc_pm.data.suspend_mode = AT91_PM_ULP0;
 
-       at91_dt_ramc(false);
+       ret = at91_dt_ramc(false);
+       if (ret)
+               return;
+
        at91_pm_init(at91sam9_idle);
 }
 
@@ -1081,12 +1157,16 @@ void __init sama5_pm_init(void)
        static const int modes[] __initconst = {
                AT91_PM_STANDBY, AT91_PM_ULP0, AT91_PM_ULP0_FAST,
        };
+       int ret;
 
        if (!IS_ENABLED(CONFIG_SOC_SAMA5))
                return;
 
        at91_pm_modes_validate(modes, ARRAY_SIZE(modes));
-       at91_dt_ramc(false);
+       ret = at91_dt_ramc(false);
+       if (ret)
+               return;
+
        at91_pm_init(NULL);
 }
 
@@ -1101,18 +1181,27 @@ void __init sama5d2_pm_init(void)
                [AT91_PM_BACKUP]        = AT91_PM_IOMAP(SHDWC) |
                                          AT91_PM_IOMAP(SFRBU),
        };
+       int ret;
 
        if (!IS_ENABLED(CONFIG_SOC_SAMA5D2))
                return;
 
        at91_pm_modes_validate(modes, ARRAY_SIZE(modes));
        at91_pm_modes_init(iomaps, ARRAY_SIZE(iomaps));
-       at91_dt_ramc(false);
+       ret = at91_dt_ramc(false);
+       if (ret)
+               return;
+
        at91_pm_init(NULL);
 
        soc_pm.ws_ids = sama5d2_ws_ids;
        soc_pm.config_shdwc_ws = at91_sama5d2_config_shdwc_ws;
        soc_pm.config_pmc_ws = at91_sama5d2_config_pmc_ws;
+
+       soc_pm.sfrbu_regs.pswbu.key = (0x4BD20C << 8);
+       soc_pm.sfrbu_regs.pswbu.ctrl = BIT(0);
+       soc_pm.sfrbu_regs.pswbu.softsw = BIT(1);
+       soc_pm.sfrbu_regs.pswbu.state = BIT(3);
 }
 
 void __init sama7_pm_init(void)
@@ -1127,18 +1216,27 @@ void __init sama7_pm_init(void)
                [AT91_PM_BACKUP]        = AT91_PM_IOMAP(SFRBU) |
                                          AT91_PM_IOMAP(SHDWC),
        };
+       int ret;
 
        if (!IS_ENABLED(CONFIG_SOC_SAMA7))
                return;
 
        at91_pm_modes_validate(modes, ARRAY_SIZE(modes));
 
-       at91_dt_ramc(true);
+       ret = at91_dt_ramc(true);
+       if (ret)
+               return;
+
        at91_pm_modes_init(iomaps, ARRAY_SIZE(iomaps));
        at91_pm_init(NULL);
 
        soc_pm.ws_ids = sama7g5_ws_ids;
        soc_pm.config_pmc_ws = at91_sam9x60_config_pmc_ws;
+
+       soc_pm.sfrbu_regs.pswbu.key = (0x4BD20C << 8);
+       soc_pm.sfrbu_regs.pswbu.ctrl = BIT(0);
+       soc_pm.sfrbu_regs.pswbu.softsw = BIT(1);
+       soc_pm.sfrbu_regs.pswbu.state = BIT(2);
 }
 
 static int __init at91_pm_modes_select(char *str)
index cbd61a3..fdb4f63 100644 (file)
@@ -1014,31 +1014,55 @@ ENTRY(at91_pm_suspend_in_sram)
        mov     tmp1, #0
        mcr     p15, 0, tmp1, c7, c10, 4
 
+       /* Flush tlb. */
+       mov     r4, #0
+       mcr     p15, 0, r4, c8, c7, 0
+
+       ldr     tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET]
+       str     tmp1, .mckr_offset
+       ldr     tmp1, [r0, #PM_DATA_PMC_VERSION]
+       str     tmp1, .pmc_version
+       ldr     tmp1, [r0, #PM_DATA_MEMCTRL]
+       str     tmp1, .memtype
+       ldr     tmp1, [r0, #PM_DATA_MODE]
+       str     tmp1, .pm_mode
+
+       /*
+        * ldrne below are here to preload their address in the TLB as access
+        * to RAM may be limited while in self-refresh.
+        */
        ldr     tmp1, [r0, #PM_DATA_PMC]
        str     tmp1, .pmc_base
+       cmp     tmp1, #0
+       ldrne   tmp2, [tmp1, #0]
+
        ldr     tmp1, [r0, #PM_DATA_RAMC0]
        str     tmp1, .sramc_base
+       cmp     tmp1, #0
+       ldrne   tmp2, [tmp1, #0]
+
        ldr     tmp1, [r0, #PM_DATA_RAMC1]
        str     tmp1, .sramc1_base
+       cmp     tmp1, #0
+       ldrne   tmp2, [tmp1, #0]
+
+#ifndef CONFIG_SOC_SAM_V4_V5
+       /* ldrne below are here to preload their address in the TLB */
        ldr     tmp1, [r0, #PM_DATA_RAMC_PHY]
        str     tmp1, .sramc_phy_base
-       ldr     tmp1, [r0, #PM_DATA_MEMCTRL]
-       str     tmp1, .memtype
-       ldr     tmp1, [r0, #PM_DATA_MODE]
-       str     tmp1, .pm_mode
-       ldr     tmp1, [r0, #PM_DATA_PMC_MCKR_OFFSET]
-       str     tmp1, .mckr_offset
-       ldr     tmp1, [r0, #PM_DATA_PMC_VERSION]
-       str     tmp1, .pmc_version
-       /* Both ldrne below are here to preload their address in the TLB */
+       cmp     tmp1, #0
+       ldrne   tmp2, [tmp1, #0]
+
        ldr     tmp1, [r0, #PM_DATA_SHDWC]
        str     tmp1, .shdwc
        cmp     tmp1, #0
        ldrne   tmp2, [tmp1, #0]
+
        ldr     tmp1, [r0, #PM_DATA_SFRBU]
        str     tmp1, .sfrbu
        cmp     tmp1, #0
        ldrne   tmp2, [tmp1, #0x10]
+#endif
 
        /* Active the self-refresh mode */
        at91_sramc_self_refresh_ena
index 7a4bd88..ddf873f 100644 (file)
@@ -11,7 +11,7 @@
 
 #define LSR_THRE       0x20
 
-static void putc(const char c)
+static inline void putc(const char c)
 {
        int i;
 
@@ -24,7 +24,7 @@ static void putc(const char c)
        *UART_THR = c;
 }
 
-static void flush(void)
+static inline void flush(void)
 {
 }
 
index 11dcc36..c9d7c29 100644 (file)
@@ -172,6 +172,9 @@ static void __init imx6q_init_machine(void)
                                imx_get_soc_revision());
 
        imx6q_enet_phy_init();
+
+       of_platform_default_populate(NULL, NULL, NULL);
+
        imx_anatop_init();
        cpu_is_imx6q() ?  imx6q_pm_init() : imx6dl_pm_init();
        imx6q_1588_init();
index 9244437..f2ecca3 100644 (file)
@@ -10,6 +10,7 @@
 #include <linux/io.h>
 #include <linux/irq.h>
 #include <linux/genalloc.h>
+#include <linux/irqchip/arm-gic.h>
 #include <linux/mfd/syscon.h>
 #include <linux/mfd/syscon/imx6q-iomuxc-gpr.h>
 #include <linux/of.h>
@@ -619,6 +620,7 @@ static void __init imx6_pm_common_init(const struct imx6_pm_socdata
 
 static void imx6_pm_stby_poweroff(void)
 {
+       gic_cpu_if_down(0);
        imx6_set_lpm(STOP_POWER_OFF);
        imx6q_suspend_finish(0);
 
index 95fd1fb..59a8e8c 100644 (file)
@@ -9,6 +9,7 @@
 #include <linux/iopoll.h>
 #include <linux/of.h>
 #include <linux/of_address.h>
+#include <linux/platform_device.h>
 #include <linux/reset-controller.h>
 #include <linux/smp.h>
 #include <asm/smp_plat.h>
@@ -81,11 +82,6 @@ static const struct reset_control_ops imx_src_ops = {
        .reset = imx_src_reset_module,
 };
 
-static struct reset_controller_dev imx_reset_controller = {
-       .ops = &imx_src_ops,
-       .nr_resets = ARRAY_SIZE(sw_reset_bits),
-};
-
 static void imx_gpcv2_set_m_core_pgc(bool enable, u32 offset)
 {
        writel_relaxed(enable, gpc_base + offset);
@@ -177,10 +173,6 @@ void __init imx_src_init(void)
        src_base = of_iomap(np, 0);
        WARN_ON(!src_base);
 
-       imx_reset_controller.of_node = np;
-       if (IS_ENABLED(CONFIG_RESET_CONTROLLER))
-               reset_controller_register(&imx_reset_controller);
-
        /*
         * force warm reset sources to generate cold reset
         * for a more reliable restart
@@ -214,3 +206,33 @@ void __init imx7_src_init(void)
        if (!gpc_base)
                return;
 }
+
+static const struct of_device_id imx_src_dt_ids[] = {
+       { .compatible = "fsl,imx51-src" },
+       { /* sentinel */ }
+};
+
+static int imx_src_probe(struct platform_device *pdev)
+{
+       struct reset_controller_dev *rcdev;
+
+       rcdev = devm_kzalloc(&pdev->dev, sizeof(*rcdev), GFP_KERNEL);
+       if (!rcdev)
+               return -ENOMEM;
+
+       rcdev->ops = &imx_src_ops;
+       rcdev->dev = &pdev->dev;
+       rcdev->of_node = pdev->dev.of_node;
+       rcdev->nr_resets = ARRAY_SIZE(sw_reset_bits);
+
+       return devm_reset_controller_register(&pdev->dev, rcdev);
+}
+
+static struct platform_driver imx_src_driver = {
+       .driver = {
+               .name = "imx-src",
+               .of_match_table = imx_src_dt_ids,
+       },
+       .probe = imx_src_probe,
+};
+builtin_platform_driver(imx_src_driver);
index 36bc000..ba3a350 100644 (file)
@@ -9,16 +9,4 @@
 /* REVISIT: omap1 legacy drivers still rely on this */
 #include <mach/soc.h>
 
-/*
- * Bus address is physical address, except for OMAP-1510 Local Bus.
- * OMAP-1510 bus address is translated into a Local Bus address if the
- * OMAP bus type is lbus. We do the address translation based on the
- * device overriding the defaults used in the dma-mapping API.
- */
-
-/*
- * OMAP-1510 Local Bus address offset
- */
-#define OMAP1510_LB_OFFSET     UL(0x30000000)
-
 #endif
index 86d3b3c..e60831c 100644 (file)
@@ -11,6 +11,7 @@
 #include <linux/platform_device.h>
 #include <linux/dma-map-ops.h>
 #include <linux/io.h>
+#include <linux/delay.h>
 
 #include <asm/irq.h>
 
@@ -206,8 +207,6 @@ static inline void udc_device_init(struct omap_usb_config *pdata)
 
 #endif
 
-#if    IS_ENABLED(CONFIG_USB_OHCI_HCD)
-
 /* The dmamask must be set for OHCI to work */
 static u64 ohci_dmamask = ~(u32)0;
 
@@ -236,20 +235,15 @@ static struct platform_device ohci_device = {
 
 static inline void ohci_device_init(struct omap_usb_config *pdata)
 {
+       if (!IS_ENABLED(CONFIG_USB_OHCI_HCD))
+               return;
+
        if (cpu_is_omap7xx())
                ohci_resources[1].start = INT_7XX_USB_HHC_1;
        pdata->ohci_device = &ohci_device;
        pdata->ocpi_enable = &ocpi_enable;
 }
 
-#else
-
-static inline void ohci_device_init(struct omap_usb_config *pdata)
-{
-}
-
-#endif
-
 #if    defined(CONFIG_USB_OTG) && defined(CONFIG_ARCH_OMAP_OTG)
 
 static struct resource otg_resources[] = {
@@ -534,33 +528,87 @@ bad:
 }
 
 #ifdef CONFIG_ARCH_OMAP15XX
+/* OMAP-1510 OHCI has its own MMU for DMA */
+#define OMAP1510_LB_MEMSIZE    32      /* Should be same as SDRAM size */
+#define OMAP1510_LB_CLOCK_DIV  0xfffec10c
+#define OMAP1510_LB_MMU_CTL    0xfffec208
+#define OMAP1510_LB_MMU_LCK    0xfffec224
+#define OMAP1510_LB_MMU_LD_TLB 0xfffec228
+#define OMAP1510_LB_MMU_CAM_H  0xfffec22c
+#define OMAP1510_LB_MMU_CAM_L  0xfffec230
+#define OMAP1510_LB_MMU_RAM_H  0xfffec234
+#define OMAP1510_LB_MMU_RAM_L  0xfffec238
 
-/* ULPD_DPLL_CTRL */
-#define DPLL_IOB               (1 << 13)
-#define DPLL_PLL_ENABLE                (1 << 4)
-#define DPLL_LOCK              (1 << 0)
+/*
+ * Bus address is physical address, except for OMAP-1510 Local Bus.
+ * OMAP-1510 bus address is translated into a Local Bus address if the
+ * OMAP bus type is lbus.
+ */
+#define OMAP1510_LB_OFFSET        UL(0x30000000)
 
-/* ULPD_APLL_CTRL */
-#define APLL_NDPLL_SWITCH      (1 << 0)
+/*
+ * OMAP-1510 specific Local Bus clock on/off
+ */
+static int omap_1510_local_bus_power(int on)
+{
+       if (on) {
+               omap_writel((1 << 1) | (1 << 0), OMAP1510_LB_MMU_CTL);
+               udelay(200);
+       } else {
+               omap_writel(0, OMAP1510_LB_MMU_CTL);
+       }
 
-static int omap_1510_usb_ohci_notifier(struct notifier_block *nb,
-               unsigned long event, void *data)
+       return 0;
+}
+
+/*
+ * OMAP-1510 specific Local Bus initialization
+ * NOTE: This assumes 32MB memory size in OMAP1510LB_MEMSIZE.
+ *       See also arch/mach-omap/memory.h for __virt_to_dma() and
+ *       __dma_to_virt() which need to match with the physical
+ *       Local Bus address below.
+ */
+static int omap_1510_local_bus_init(void)
 {
-       struct device *dev = data;
+       unsigned int tlb;
+       unsigned long lbaddr, physaddr;
+
+       omap_writel((omap_readl(OMAP1510_LB_CLOCK_DIV) & 0xfffffff8) | 0x4,
+              OMAP1510_LB_CLOCK_DIV);
+
+       /* Configure the Local Bus MMU table */
+       for (tlb = 0; tlb < OMAP1510_LB_MEMSIZE; tlb++) {
+               lbaddr = tlb * 0x00100000 + OMAP1510_LB_OFFSET;
+               physaddr = tlb * 0x00100000 + PHYS_OFFSET;
+               omap_writel((lbaddr & 0x0fffffff) >> 22, OMAP1510_LB_MMU_CAM_H);
+               omap_writel(((lbaddr & 0x003ffc00) >> 6) | 0xc,
+                      OMAP1510_LB_MMU_CAM_L);
+               omap_writel(physaddr >> 16, OMAP1510_LB_MMU_RAM_H);
+               omap_writel((physaddr & 0x0000fc00) | 0x300, OMAP1510_LB_MMU_RAM_L);
+               omap_writel(tlb << 4, OMAP1510_LB_MMU_LCK);
+               omap_writel(0x1, OMAP1510_LB_MMU_LD_TLB);
+       }
 
-       if (event != BUS_NOTIFY_ADD_DEVICE)
-               return NOTIFY_DONE;
+       /* Enable the walking table */
+       omap_writel(omap_readl(OMAP1510_LB_MMU_CTL) | (1 << 3), OMAP1510_LB_MMU_CTL);
+       udelay(200);
 
-       if (strncmp(dev_name(dev), "ohci", 4) == 0 &&
-           dma_direct_set_offset(dev, PHYS_OFFSET, OMAP1510_LB_OFFSET,
-                       (u64)-1))
-               WARN_ONCE(1, "failed to set DMA offset\n");
-       return NOTIFY_OK;
+       return 0;
 }
 
-static struct notifier_block omap_1510_usb_ohci_nb = {
-       .notifier_call          = omap_1510_usb_ohci_notifier,
-};
+static void omap_1510_local_bus_reset(void)
+{
+       omap_1510_local_bus_power(1);
+       omap_1510_local_bus_init();
+}
+
+/* ULPD_DPLL_CTRL */
+#define DPLL_IOB               (1 << 13)
+#define DPLL_PLL_ENABLE                (1 << 4)
+#define DPLL_LOCK              (1 << 0)
+
+/* ULPD_APLL_CTRL */
+#define APLL_NDPLL_SWITCH      (1 << 0)
 
 static void __init omap_1510_usb_init(struct omap_usb_config *config)
 {
@@ -616,19 +664,19 @@ static void __init omap_1510_usb_init(struct omap_usb_config *config)
        }
 #endif
 
-#if    IS_ENABLED(CONFIG_USB_OHCI_HCD)
-       if (config->register_host) {
+       if (IS_ENABLED(CONFIG_USB_OHCI_HCD) && config->register_host) {
                int status;
 
-               bus_register_notifier(&platform_bus_type,
-                                     &omap_1510_usb_ohci_nb);
                ohci_device.dev.platform_data = config;
+               dma_direct_set_offset(&ohci_device.dev, PHYS_OFFSET,
+                                     OMAP1510_LB_OFFSET, (u64)-1);
                status = platform_device_register(&ohci_device);
                if (status)
                        pr_debug("can't register OHCI device, %d\n", status);
                /* hcd explicitly gates 48MHz */
+
+               config->lb_reset = omap_1510_local_bus_reset;
        }
-#endif
 }
 
 #else
index 7f13adf..02c253d 100644 (file)
@@ -112,7 +112,6 @@ config ARCH_OMAP2PLUS
        select PM_GENERIC_DOMAINS
        select PM_GENERIC_DOMAINS_OF
        select RESET_CONTROLLER
-       select SIMPLE_PM_BUS
        select SOC_BUS
        select TI_SYSC
        select OMAP_IRQCHIP
index 12b26e0..0c2936c 100644 (file)
@@ -3614,6 +3614,8 @@ int omap_hwmod_init_module(struct device *dev,
                oh->flags |= HWMOD_SWSUP_SIDLE_ACT;
        if (data->cfg->quirks & SYSC_QUIRK_SWSUP_MSTANDBY)
                oh->flags |= HWMOD_SWSUP_MSTANDBY;
+       if (data->cfg->quirks & SYSC_QUIRK_CLKDM_NOAUTO)
+               oh->flags |= HWMOD_CLKDM_NOAUTO;
 
        error = omap_hwmod_check_module(dev, oh, data, sysc_fields,
                                        rev_offs, sysc_offs, syss_offs,
index a951276..a903b26 100644 (file)
  *                        +-----+
  *                        |RSVD | JIT scratchpad
  * current ARM_SP =>      +-----+ <= (BPF_FP - STACK_SIZE + SCRATCH_SIZE)
+ *                        | ... | caller-saved registers
+ *                        +-----+
+ *                        | ... | arguments passed on stack
+ * ARM_SP during call =>  +-----|
  *                        |     |
  *                        | ... | Function call stack
  *                        |     |
  *
  * When popping registers off the stack at the end of a BPF function, we
  * reference them via the current ARM_FP register.
+ *
+ * Some eBPF operations are implemented via a call to a helper function.
+ * Such calls are "invisible" in the eBPF code, so it is up to the calling
+ * program to preserve any caller-saved ARM registers during the call. The
+ * JIT emits code to push and pop those registers onto the stack, immediately
+ * above the callee stack frame.
  */
 #define CALLEE_MASK    (1 << ARM_R4 | 1 << ARM_R5 | 1 << ARM_R6 | \
                         1 << ARM_R7 | 1 << ARM_R8 | 1 << ARM_R9 | \
@@ -70,6 +80,8 @@
 #define CALLEE_PUSH_MASK (CALLEE_MASK | 1 << ARM_LR)
 #define CALLEE_POP_MASK  (CALLEE_MASK | 1 << ARM_PC)
 
+#define CALLER_MASK    (1 << ARM_R0 | 1 << ARM_R1 | 1 << ARM_R2 | 1 << ARM_R3)
+
 enum {
        /* Stack layout - these are offsets from (top of stack - 4) */
        BPF_R2_HI,
@@ -464,6 +476,7 @@ static inline int epilogue_offset(const struct jit_ctx *ctx)
 
 static inline void emit_udivmod(u8 rd, u8 rm, u8 rn, struct jit_ctx *ctx, u8 op)
 {
+       const int exclude_mask = BIT(ARM_R0) | BIT(ARM_R1);
        const s8 *tmp = bpf2a32[TMP_REG_1];
 
 #if __LINUX_ARM_ARCH__ == 7
@@ -495,11 +508,17 @@ static inline void emit_udivmod(u8 rd, u8 rm, u8 rn, struct jit_ctx *ctx, u8 op)
                emit(ARM_MOV_R(ARM_R0, rm), ctx);
        }
 
+       /* Push caller-saved registers on stack */
+       emit(ARM_PUSH(CALLER_MASK & ~exclude_mask), ctx);
+
        /* Call appropriate function */
        emit_mov_i(ARM_IP, op == BPF_DIV ?
                   (u32)jit_udiv32 : (u32)jit_mod32, ctx);
        emit_blx_r(ARM_IP, ctx);
 
+       /* Restore caller-saved registers from stack */
+       emit(ARM_POP(CALLER_MASK & ~exclude_mask), ctx);
+
        /* Save return value */
        if (rd != ARM_R0)
                emit(ARM_MOV_R(rd, ARM_R0), ctx);
index 077f2ec..fee914c 100644 (file)
@@ -86,7 +86,7 @@ config ARM64
        select ARCH_SUPPORTS_LTO_CLANG_THIN
        select ARCH_SUPPORTS_CFI_CLANG
        select ARCH_SUPPORTS_ATOMIC_RMW
-       select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && (GCC_VERSION >= 50000 || CC_IS_CLANG)
+       select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
        select ARCH_SUPPORTS_NUMA_BALANCING
        select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT
        select ARCH_WANT_DEFAULT_BPF_JIT
@@ -1931,8 +1931,6 @@ source "drivers/cpufreq/Kconfig"
 
 endmenu
 
-source "drivers/firmware/Kconfig"
-
 source "drivers/acpi/Kconfig"
 
 source "arch/arm64/kvm/Kconfig"
index 05ae893..fbf13f7 100644 (file)
 
        bus@8000000 {
                compatible = "arm,vexpress,v2m-p1", "simple-bus";
-               arm,v2m-memory-map = "rs1";
                #address-cells = <2>; /* SMB chipselect number and offset */
                #size-cells = <1>;
 
index b8a2109..269b649 100644 (file)
                                remote-endpoint = <&clcd_pads>;
                        };
                };
-
-              panel-timing {
-                      clock-frequency = <63500127>;
-                      hactive = <1024>;
-                      hback-porch = <152>;
-                      hfront-porch = <48>;
-                      hsync-len = <104>;
-                      vactive = <768>;
-                      vback-porch = <23>;
-                      vfront-porch = <3>;
-                      vsync-len = <4>;
-              };
        };
 
        bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
                #interrupt-cells = <1>;
                interrupt-map-mask = <0 0 63>;
                interrupt-map = <0 0  0 &gic 0 0 GIC_SPI  0 IRQ_TYPE_LEVEL_HIGH>,
index 8e7a669..6288e10 100644 (file)
@@ -27,8 +27,6 @@
                reg = <0x0 0x2b1f0000 0x0 0x1000>;
                interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
                             <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
-               interrupt-names = "mhu_lpri_rx",
-                                 "mhu_hpri_rx";
                #mbox-cells = <1>;
                clocks = <&soc_refclk100mhz>;
                clock-names = "apb_pclk";
        };
 
        bus@8000000 {
-               compatible = "simple-bus";
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
                #interrupt-cells = <1>;
                interrupt-map-mask = <0 0 15>;
                interrupt-map = <0 0  0 &gic 0 GIC_SPI  68 IRQ_TYPE_LEVEL_HIGH>,
index 40d95c5..fefd2b5 100644 (file)
        };
 
        bus@8000000 {
-               motherboard-bus {
+               compatible = "simple-bus";
+               #address-cells = <2>;
+               #size-cells = <1>;
+               ranges = <0 0x8000000 0 0x8000000 0x18000000>;
+
+               motherboard-bus@8000000 {
                        compatible = "arm,vexpress,v2p-p1", "simple-bus";
                        #address-cells = <2>;  /* SMB chipselect number and offset */
                        #size-cells = <1>;
-                       #interrupt-cells = <1>;
-                       ranges;
-                       model = "V2M-Juno";
+                       ranges = <0 0 0 0x08000000 0x04000000>,
+                                <1 0 0 0x14000000 0x04000000>,
+                                <2 0 0 0x18000000 0x04000000>,
+                                <3 0 0 0x1c000000 0x04000000>,
+                                <4 0 0 0x0c000000 0x04000000>,
+                                <5 0 0 0x10000000 0x04000000>;
                        arm,hbi = <0x252>;
                        arm,vexpress,site = <0>;
-                       arm,v2m-memory-map = "rs1";
 
                        flash@0 {
                                /* 2 * 32MiB NOR Flash memory mounted on CS0 */
                                        };
                                };
 
-                               mmci@50000 {
+                               mmc@50000 {
                                        compatible = "arm,pl180", "arm,primecell";
                                        reg = <0x050000 0x1000>;
                                        interrupts = <5>;
                                        clock-names = "KMIREFCLK", "apb_pclk";
                                };
 
-                               wdt@f0000 {
+                               watchdog@f0000 {
                                        compatible = "arm,sp805", "arm,primecell";
                                        reg = <0x0f0000 0x10000>;
                                        interrupts = <7>;
index 3050f45..258991a 100644 (file)
        };
 
        bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
                #interrupt-cells = <1>;
                interrupt-map-mask = <0 0 63>;
                interrupt-map = <0 0  0 &gic GIC_SPI  0 IRQ_TYPE_LEVEL_HIGH>,
index b917d9d..33182d9 100644 (file)
@@ -6,7 +6,7 @@
  */
 / {
        bus@8000000 {
-               motherboard-bus {
+               motherboard-bus@8000000 {
                        arm,v2m-memory-map = "rs2";
 
                        iofpga-bus@300000000 {
index 4c4a381..5f6cab6 100644 (file)
        };
 
        bus@8000000 {
-               motherboard-bus {
-                       arm,v2m-memory-map = "rs1";
+               compatible = "simple-bus";
+               #address-cells = <2>;
+               #size-cells = <1>;
+               ranges = <0 0x8000000 0 0x8000000 0x18000000>;
+
+               motherboard-bus@8000000 {
                        compatible = "arm,vexpress,v2m-p1", "simple-bus";
                        #address-cells = <2>; /* SMB chipselect number and offset */
                        #size-cells = <1>;
-                       #interrupt-cells = <1>;
-                       ranges;
+                       ranges = <0 0 0 0x08000000 0x04000000>,
+                                <1 0 0 0x14000000 0x04000000>,
+                                <2 0 0 0x18000000 0x04000000>,
+                                <3 0 0 0x1c000000 0x04000000>,
+                                <4 0 0 0x0c000000 0x04000000>,
+                                <5 0 0 0x10000000 0x04000000>;
 
                        flash@0 {
                                compatible = "arm,vexpress-flash", "cfi-flash";
                                        clock-names = "apb_pclk";
                                };
 
-                               mmci@50000 {
+                               mmc@50000 {
                                        compatible = "arm,pl180", "arm,primecell";
                                        reg = <0x050000 0x1000>;
                                        interrupts = <9>, <10>;
                                        clock-names = "uartclk", "apb_pclk";
                                };
 
-                               wdt@f0000 {
+                               watchdog@f0000 {
                                        compatible = "arm,sp805", "arm,primecell";
                                        reg = <0x0f0000 0x1000>;
                                        interrupts = <0>;
index d859914..5b6d9d8 100644 (file)
        };
 
        smb: bus@8000000 {
-               compatible = "simple-bus";
-
-               #address-cells = <2>;
-               #size-cells = <1>;
-               ranges = <0 0 0 0x08000000 0x04000000>,
-                        <1 0 0 0x14000000 0x04000000>,
-                        <2 0 0 0x18000000 0x04000000>,
-                        <3 0 0 0x1c000000 0x04000000>,
-                        <4 0 0 0x0c000000 0x04000000>,
-                        <5 0 0 0x10000000 0x04000000>;
-
-               #interrupt-cells = <1>;
-               interrupt-map-mask = <0 0 63>;
-               interrupt-map = <0 0  0 &gic GIC_SPI  0 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  1 &gic GIC_SPI  1 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  2 &gic GIC_SPI  2 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  3 &gic GIC_SPI  3 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  4 &gic GIC_SPI  4 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  5 &gic GIC_SPI  5 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  6 &gic GIC_SPI  6 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  7 &gic GIC_SPI  7 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  8 &gic GIC_SPI  8 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0  9 &gic GIC_SPI  9 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 10 &gic GIC_SPI 10 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 11 &gic GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 12 &gic GIC_SPI 12 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 13 &gic GIC_SPI 13 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 14 &gic GIC_SPI 14 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 15 &gic GIC_SPI 15 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 16 &gic GIC_SPI 16 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 17 &gic GIC_SPI 17 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 18 &gic GIC_SPI 18 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 19 &gic GIC_SPI 19 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 20 &gic GIC_SPI 20 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 21 &gic GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 22 &gic GIC_SPI 22 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 23 &gic GIC_SPI 23 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 24 &gic GIC_SPI 24 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 25 &gic GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 26 &gic GIC_SPI 26 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 27 &gic GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 28 &gic GIC_SPI 28 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 29 &gic GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 30 &gic GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 31 &gic GIC_SPI 31 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 32 &gic GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 33 &gic GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 34 &gic GIC_SPI 34 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 35 &gic GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 36 &gic GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 37 &gic GIC_SPI 37 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 38 &gic GIC_SPI 38 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 39 &gic GIC_SPI 39 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 40 &gic GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 41 &gic GIC_SPI 41 IRQ_TYPE_LEVEL_HIGH>,
-                               <0 0 42 &gic GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+               ranges = <0x8000000 0 0x8000000 0x18000000>;
        };
 };
index 343ecf0..06b36cc 100644 (file)
                        interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
                        clock-frequency = <0>; /* fixed up by bootloader */
                        clocks = <&clockgen QORIQ_CLK_HWACCEL 1>;
-                       voltage-ranges = <1800 1800 3300 3300>;
+                       voltage-ranges = <1800 1800>;
                        sdhci,auto-cmd12;
-                       broken-cd;
+                       non-removable;
                        little-endian;
                        bus-width = <4>;
                        status = "disabled";
index 988f8ab..40f5e7a 100644 (file)
@@ -91,7 +91,7 @@
                #size-cells = <1>;
                compatible = "jedec,spi-nor";
                spi-max-frequency = <80000000>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                spi-rx-bus-width = <4>;
        };
 };
index 4e2820d..a2b24d4 100644 (file)
@@ -48,7 +48,7 @@
                #size-cells = <1>;
                compatible = "jedec,spi-nor";
                spi-max-frequency = <80000000>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                spi-rx-bus-width = <4>;
        };
 };
index d0456da..9db9b90 100644 (file)
                                regulator-min-microvolt = <850000>;
                                regulator-max-microvolt = <950000>;
                                regulator-boot-on;
+                               regulator-always-on;
                                regulator-ramp-delay = <3125>;
                                nxp,dvs-run-voltage = <950000>;
                                nxp,dvs-standby-voltage = <850000>;
index 05cb609..d52686f 100644 (file)
        pinctrl_hog: hoggrp {
                fsl,pins = <
                        MX8MM_IOMUXC_NAND_CE0_B_GPIO3_IO1       0x40000159 /* M2_GDIS# */
-                       MX8MM_IOMUXC_GPIO1_IO12_GPIO1_IO12      0x40000041 /* M2_RST# */
+                       MX8MM_IOMUXC_GPIO1_IO13_GPIO1_IO13      0x40000041 /* M2_RST# */
                        MX8MM_IOMUXC_NAND_DATA01_GPIO3_IO7      0x40000119 /* M2_OFF# */
                        MX8MM_IOMUXC_GPIO1_IO15_GPIO1_IO15      0x40000159 /* M2_WDIS# */
                        MX8MM_IOMUXC_SAI1_TXD2_GPIO4_IO14       0x40000041 /* AMP GPIO1 */
index 54eaf3d..3b2d627 100644 (file)
                #size-cells = <1>;
                compatible = "jedec,spi-nor";
                spi-max-frequency = <80000000>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                spi-rx-bus-width = <4>;
        };
 };
index e77db49..236f425 100644 (file)
        pinctrl_hog: hoggrp {
                fsl,pins = <
                        MX8MN_IOMUXC_NAND_CE0_B_GPIO3_IO1       0x40000159 /* M2_GDIS# */
-                       MX8MN_IOMUXC_GPIO1_IO12_GPIO1_IO12      0x40000041 /* M2_RST# */
+                       MX8MN_IOMUXC_GPIO1_IO13_GPIO1_IO13      0x40000041 /* M2_RST# */
                        MX8MN_IOMUXC_NAND_DATA01_GPIO3_IO7      0x40000119 /* M2_OFF# */
                        MX8MN_IOMUXC_GPIO1_IO15_GPIO1_IO15      0x40000159 /* M2_WDIS# */
                        MX8MN_IOMUXC_SAI2_RXFS_GPIO4_IO21       0x40000041 /* APP GPIO1 */
index aa78e0d..fc178ee 100644 (file)
@@ -74,7 +74,7 @@
                compatible = "jedec,spi-nor";
                reg = <0>;
                spi-max-frequency = <80000000>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                spi-rx-bus-width = <4>;
        };
 };
index 49f9db9..b83df77 100644 (file)
                #size-cells = <1>;
                compatible = "micron,n25q256a", "jedec,spi-nor";
                spi-max-frequency = <29000000>;
+               spi-tx-bus-width = <1>;
+               spi-rx-bus-width = <4>;
        };
 };
 
index f593e4f..564746d 100644 (file)
                #address-cells = <1>;
                #size-cells = <1>;
                reg = <0>;
-               spi-tx-bus-width = <4>;
+               spi-tx-bus-width = <1>;
                spi-rx-bus-width = <4>;
                m25p,fast-read;
                spi-max-frequency = <50000000>;
index a620ac0..db33300 100644 (file)
                                interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>;
                                phys = <&qusb_phy_0>, <&usb0_ssphy>;
                                phy-names = "usb2-phy", "usb3-phy";
-                               tx-fifo-resize;
                                snps,is-utmi-l1-suspend;
                                snps,hird-threshold = /bits/ 8 <0x0>;
                                snps,dis_u2_susphy_quirk;
                                interrupts = <GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
                                phys = <&qusb_phy_1>, <&usb1_ssphy>;
                                phy-names = "usb2-phy", "usb3-phy";
-                               tx-fifo-resize;
                                snps,is-utmi-l1-suspend;
                                snps,hird-threshold = /bits/ 8 <0x0>;
                                snps,dis_u2_susphy_quirk;
index c566a64..0df76f7 100644 (file)
                #size-cells = <0>;
 
                pon: power-on@800 {
-                       compatible = "qcom,pm8916-pon";
+                       compatible = "qcom,pm8998-pon";
                        reg = <0x0800>;
+                       mode-bootloader = <0x2>;
+                       mode-recovery = <0x1>;
 
                        pon_pwrkey: pwrkey {
                                compatible = "qcom,pm8941-pwrkey";
index 8ac96f8..28d5b55 100644 (file)
        };
 };
 
+&pon_pwrkey {
+       status = "okay";
+};
+
+&pon_resin {
+       status = "okay";
+
+       linux,code = <KEY_VOLUMEDOWN>;
+};
+
 &qupv3_id_0 {
        status = "okay";
 };
index 0f2b3c0..70c88c3 100644 (file)
                        "Headphone Jack", "HPOL",
                        "Headphone Jack", "HPOR";
 
-               #sound-dai-cells = <0>;
                #address-cells = <1>;
                #size-cells = <0>;
 
                        };
                };
 
-               dai-link@2 {
+               dai-link@5 {
                        link-name = "MultiMedia2";
-                       reg = <2>;
+                       reg = <LPASS_DP_RX>;
                        cpu {
-                               sound-dai = <&lpass_cpu 2>;
+                               sound-dai = <&lpass_cpu LPASS_DP_RX>;
                        };
 
                        codec {
@@ -782,7 +781,7 @@ hp_i2c: &i2c9 {
                qcom,playback-sd-lines = <0>;
        };
 
-       hdmi-primary@0 {
+       hdmi@5 {
                reg = <LPASS_DP_RX>;
        };
 };
index 53a21d0..fd78f16 100644 (file)
 
                cpufreq_hw: cpufreq@18591000 {
                        compatible = "qcom,cpufreq-epss";
-                       reg = <0 0x18591100 0 0x900>,
-                             <0 0x18592100 0 0x900>,
-                             <0 0x18593100 0 0x900>;
+                       reg = <0 0x18591000 0 0x1000>,
+                             <0 0x18592000 0 0x1000>,
+                             <0 0x18593000 0 0x1000>;
                        clocks = <&rpmhcc RPMH_CXO_CLK>, <&gcc GCC_GPLL0>;
                        clock-names = "xo", "alternate";
                        #freq-domain-cells = <1>;
index 9153e66..9c7f87e 100644 (file)
                        compatible = "qcom,sdm660-a2noc";
                        reg = <0x01704000 0xc100>;
                        #interconnect-cells = <1>;
-                       clock-names = "bus", "bus_a";
+                       clock-names = "bus",
+                                     "bus_a",
+                                     "ipa",
+                                     "ufs_axi",
+                                     "aggre2_ufs_axi",
+                                     "aggre2_usb3_axi",
+                                     "cfg_noc_usb2_axi";
                        clocks = <&rpmcc RPM_SMD_AGGR2_NOC_CLK>,
-                                <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>;
+                                <&rpmcc RPM_SMD_AGGR2_NOC_A_CLK>,
+                                <&rpmcc RPM_SMD_IPA_CLK>,
+                                <&gcc GCC_UFS_AXI_CLK>,
+                                <&gcc GCC_AGGRE2_UFS_AXI_CLK>,
+                                <&gcc GCC_AGGRE2_USB3_AXI_CLK>,
+                                <&gcc GCC_CFG_NOC_USB2_AXI_CLK>;
                };
 
                mnoc: interconnect@1745000 {
index 6d7172e..b3b9119 100644 (file)
                        no-map;
                };
 
-               wlan_msa_mem: memory@8c400000 {
-                       reg = <0 0x8c400000 0 0x100000>;
+               ipa_fw_mem: memory@8c400000 {
+                       reg = <0 0x8c400000 0 0x10000>;
                        no-map;
                };
 
-               gpu_mem: memory@8c515000 {
-                       reg = <0 0x8c515000 0 0x2000>;
+               ipa_gsi_mem: memory@8c410000 {
+                       reg = <0 0x8c410000 0 0x5000>;
                        no-map;
                };
 
-               ipa_fw_mem: memory@8c517000 {
-                       reg = <0 0x8c517000 0 0x5a000>;
+               gpu_mem: memory@8c415000 {
+                       reg = <0 0x8c415000 0 0x2000>;
                        no-map;
                };
 
-               adsp_mem: memory@8c600000 {
-                       reg = <0 0x8c600000 0 0x1a00000>;
+               adsp_mem: memory@8c500000 {
+                       reg = <0 0x8c500000 0 0x1a00000>;
+                       no-map;
+               };
+
+               wlan_msa_mem: memory@8df00000 {
+                       reg = <0 0x8df00000 0 0x100000>;
                        no-map;
                };
 
index 385e502..2ba23aa 100644 (file)
 #include "sdm850.dtsi"
 #include "pm8998.dtsi"
 
+/*
+ * Update following upstream (sdm845.dtsi) reserved
+ * memory mappings for firmware loading to succeed
+ * and enable the IPA device.
+ */
+/delete-node/ &ipa_fw_mem;
+/delete-node/ &ipa_gsi_mem;
+/delete-node/ &gpu_mem;
+/delete-node/ &adsp_mem;
+/delete-node/ &wlan_msa_mem;
+
 / {
        model = "Lenovo Yoga C630";
        compatible = "lenovo,yoga-c630", "qcom,sdm845";
                };
        };
 
+       /* Reserved memory changes for IPA */
+       reserved-memory {
+               wlan_msa_mem: memory@8c400000 {
+                       reg = <0 0x8c400000 0 0x100000>;
+                       no-map;
+               };
+
+               gpu_mem: memory@8c515000 {
+                       reg = <0 0x8c515000 0 0x2000>;
+                       no-map;
+               };
+
+               ipa_fw_mem: memory@8c517000 {
+                       reg = <0 0x8c517000 0 0x5a000>;
+                       no-map;
+               };
+
+               adsp_mem: memory@8c600000 {
+                       reg = <0 0x8c600000 0 0x1a00000>;
+                       no-map;
+               };
+       };
+
        sn65dsi86_refclk: sn65dsi86-refclk {
                compatible = "fixed-clock";
                #clock-cells = <0>;
index 156d96a..545197b 100644 (file)
@@ -245,7 +245,6 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_FW_LOADER_USER_HELPER=y
 CONFIG_FW_LOADER_USER_HELPER_FALLBACK=y
 CONFIG_HISILICON_LPC=y
-CONFIG_SIMPLE_PM_BUS=y
 CONFIG_FSL_MC_BUS=y
 CONFIG_TEGRA_ACONNECT=m
 CONFIG_GNSS=m
index 7535dc7..bd68e1b 100644 (file)
@@ -50,9 +50,6 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr);
 void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size);
 #define acpi_os_ioremap acpi_os_ioremap
 
-void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size);
-#define acpi_os_memmap acpi_os_memmap
-
 typedef u64 phys_cpuid_t;
 #define PHYS_CPUID_INVALID INVALID_HWID
 
index 89faca0..bfa5840 100644 (file)
@@ -525,6 +525,11 @@ alternative_endif
 #define EXPORT_SYMBOL_NOKASAN(name)    EXPORT_SYMBOL(name)
 #endif
 
+#ifdef CONFIG_KASAN_HW_TAGS
+#define EXPORT_SYMBOL_NOHWKASAN(name)
+#else
+#define EXPORT_SYMBOL_NOHWKASAN(name)  EXPORT_SYMBOL_NOKASAN(name)
+#endif
        /*
         * Emit a 64-bit absolute little endian symbol reference in a way that
         * ensures that it will be resolved at build time, even when building a
index 3f93b9e..0251165 100644 (file)
@@ -99,11 +99,17 @@ void mte_check_tfsr_el1(void);
 
 static inline void mte_check_tfsr_entry(void)
 {
+       if (!system_supports_mte())
+               return;
+
        mte_check_tfsr_el1();
 }
 
 static inline void mte_check_tfsr_exit(void)
 {
+       if (!system_supports_mte())
+               return;
+
        /*
         * The asynchronous faults are sync'ed automatically with
         * TFSR_EL1 on kernel entry but for exit an explicit dsb()
index 3a3264f..95f7686 100644 (file)
@@ -12,11 +12,13 @@ extern char *strrchr(const char *, int c);
 #define __HAVE_ARCH_STRCHR
 extern char *strchr(const char *, int c);
 
+#ifndef CONFIG_KASAN_HW_TAGS
 #define __HAVE_ARCH_STRCMP
 extern int strcmp(const char *, const char *);
 
 #define __HAVE_ARCH_STRNCMP
 extern int strncmp(const char *, const char *, __kernel_size_t);
+#endif
 
 #define __HAVE_ARCH_STRLEN
 extern __kernel_size_t strlen(const char *);
index 1c9c2f7..f385172 100644 (file)
@@ -273,8 +273,7 @@ pgprot_t __acpi_get_mem_attribute(phys_addr_t addr)
        return __pgprot(PROT_DEVICE_nGnRnE);
 }
 
-static void __iomem *__acpi_os_ioremap(acpi_physical_address phys,
-                                      acpi_size size, bool memory)
+void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size)
 {
        efi_memory_desc_t *md, *region = NULL;
        pgprot_t prot;
@@ -300,11 +299,9 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys,
         * It is fine for AML to remap regions that are not represented in the
         * EFI memory map at all, as it only describes normal memory, and MMIO
         * regions that require a virtual mapping to make them accessible to
-        * the EFI runtime services. Determine the region default
-        * attributes by checking the requested memory semantics.
+        * the EFI runtime services.
         */
-       prot = memory ? __pgprot(PROT_NORMAL_NC) :
-                       __pgprot(PROT_DEVICE_nGnRnE);
+       prot = __pgprot(PROT_DEVICE_nGnRnE);
        if (region) {
                switch (region->type) {
                case EFI_LOADER_CODE:
@@ -364,16 +361,6 @@ static void __iomem *__acpi_os_ioremap(acpi_physical_address phys,
        return __ioremap(phys, size, prot);
 }
 
-void __iomem *acpi_os_ioremap(acpi_physical_address phys, acpi_size size)
-{
-       return __acpi_os_ioremap(phys, size, false);
-}
-
-void __iomem *acpi_os_memmap(acpi_physical_address phys, acpi_size size)
-{
-       return __acpi_os_ioremap(phys, size, true);
-}
-
 /*
  * Claim Synchronous External Aborts as a firmware first notification.
  *
index f8a3067..6ec7036 100644 (file)
@@ -1526,9 +1526,13 @@ static bool unmap_kernel_at_el0(const struct arm64_cpu_capabilities *entry,
        /*
         * For reasons that aren't entirely clear, enabling KPTI on Cavium
         * ThunderX leads to apparent I-cache corruption of kernel text, which
-        * ends as well as you might imagine. Don't even try.
+        * ends as well as you might imagine. Don't even try. We cannot rely
+        * on the cpus_have_*cap() helpers here to detect the CPU erratum
+        * because cpucap detection order may change. However, since we know
+        * affected CPUs are always in a homogeneous configuration, it is
+        * safe to rely on this_cpu_has_cap() here.
         */
-       if (cpus_have_const_cap(ARM64_WORKAROUND_CAVIUM_27456)) {
+       if (this_cpu_has_cap(ARM64_WORKAROUND_CAVIUM_27456)) {
                str = "ARM64_WORKAROUND_CAVIUM_27456";
                __kpti_forced = -1;
        }
index 5a294f2..ff49627 100644 (file)
@@ -513,7 +513,7 @@ size_t sve_state_size(struct task_struct const *task)
 void sve_alloc(struct task_struct *task)
 {
        if (task->thread.sve_state) {
-               memset(task->thread.sve_state, 0, sve_state_size(current));
+               memset(task->thread.sve_state, 0, sve_state_size(task));
                return;
        }
 
index 9d314a3..e5e801b 100644 (file)
@@ -142,12 +142,7 @@ void mte_enable_kernel_async(void)
 #ifdef CONFIG_KASAN_HW_TAGS
 void mte_check_tfsr_el1(void)
 {
-       u64 tfsr_el1;
-
-       if (!system_supports_mte())
-               return;
-
-       tfsr_el1 = read_sysreg_s(SYS_TFSR_EL1);
+       u64 tfsr_el1 = read_sysreg_s(SYS_TFSR_EL1);
 
        if (unlikely(tfsr_el1 & SYS_TFSR_EL1_TF1)) {
                /*
@@ -199,6 +194,9 @@ void mte_thread_init_user(void)
 
 void mte_thread_switch(struct task_struct *next)
 {
+       if (!system_supports_mte())
+               return;
+
        mte_update_sctlr_user(next);
 
        /*
index 19100fe..40adb8c 100644 (file)
@@ -18,7 +18,6 @@
 #include <linux/mman.h>
 #include <linux/mm.h>
 #include <linux/nospec.h>
-#include <linux/sched.h>
 #include <linux/stddef.h>
 #include <linux/sysctl.h>
 #include <linux/unistd.h>
@@ -58,7 +57,7 @@
 
 #if defined(CONFIG_STACKPROTECTOR) && !defined(CONFIG_STACKPROTECTOR_PER_TASK)
 #include <linux/stackprotector.h>
-unsigned long __stack_chk_guard __read_mostly;
+unsigned long __stack_chk_guard __ro_after_init;
 EXPORT_SYMBOL(__stack_chk_guard);
 #endif
 
index 9fe70b1..c287b94 100644 (file)
@@ -940,10 +940,8 @@ void do_notify_resume(struct pt_regs *regs, unsigned long thread_flags)
                        if (thread_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
                                do_signal(regs);
 
-                       if (thread_flags & _TIF_NOTIFY_RESUME) {
+                       if (thread_flags & _TIF_NOTIFY_RESUME)
                                tracehook_notify_resume(regs);
-                               rseq_handle_notify_resume(NULL, regs);
-                       }
 
                        if (thread_flags & _TIF_FOREIGN_FPSTATE)
                                fpsimd_restore_current_state();
index 5df6193..8d741f7 100644 (file)
@@ -54,7 +54,7 @@ $(obj)/kvm_nvhe.tmp.o: $(obj)/hyp.lds $(addprefix $(obj)/,$(hyp-obj)) FORCE
 #    runtime. Because the hypervisor is part of the kernel binary, relocations
 #    produce a kernel VA. We enumerate relocations targeting hyp at build time
 #    and convert the kernel VAs at those positions to hyp VAs.
-$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel
+$(obj)/hyp-reloc.S: $(obj)/kvm_nvhe.tmp.o $(obj)/gen-hyprel FORCE
        $(call if_changed,hyprel)
 
 # 5) Compile hyp-reloc.S and link it into the existing partially linked object.
index f9bb3b1..c84fe24 100644 (file)
@@ -50,9 +50,6 @@ static struct perf_guest_info_callbacks kvm_guest_cbs = {
 
 int kvm_perf_init(void)
 {
-       if (kvm_pmu_probe_pmuver() != ID_AA64DFR0_PMUVER_IMP_DEF && !is_protected_kvm_enabled())
-               static_branch_enable(&kvm_arm_pmu_available);
-
        return perf_register_guest_info_callbacks(&kvm_guest_cbs);
 }
 
index f5065f2..2af3c37 100644 (file)
@@ -740,7 +740,14 @@ void kvm_pmu_set_counter_event_type(struct kvm_vcpu *vcpu, u64 data,
        kvm_pmu_create_perf_event(vcpu, select_idx);
 }
 
-int kvm_pmu_probe_pmuver(void)
+void kvm_host_pmu_init(struct arm_pmu *pmu)
+{
+       if (pmu->pmuver != 0 && pmu->pmuver != ID_AA64DFR0_PMUVER_IMP_DEF &&
+           !kvm_arm_support_pmu_v3() && !is_protected_kvm_enabled())
+               static_branch_enable(&kvm_arm_pmu_available);
+}
+
+static int kvm_pmu_probe_pmuver(void)
 {
        struct perf_event_attr attr = { };
        struct perf_event *event;
index d7bee21..83bcad7 100644 (file)
@@ -173,4 +173,4 @@ L(done):
        ret
 
 SYM_FUNC_END_PI(strcmp)
-EXPORT_SYMBOL_NOKASAN(strcmp)
+EXPORT_SYMBOL_NOHWKASAN(strcmp)
index 48d44f7..e42bcfc 100644 (file)
@@ -258,4 +258,4 @@ L(ret0):
        ret
 
 SYM_FUNC_END_PI(strncmp)
-EXPORT_SYMBOL_NOKASAN(strncmp)
+EXPORT_SYMBOL_NOHWKASAN(strncmp)
index 23505fc..a8158c9 100644 (file)
@@ -43,7 +43,7 @@ void __init arm64_hugetlb_cma_reserve(void)
 #ifdef CONFIG_ARM64_4K_PAGES
        order = PUD_SHIFT - PAGE_SHIFT;
 #else
-       order = CONT_PMD_SHIFT + PMD_SHIFT - PAGE_SHIFT;
+       order = CONT_PMD_SHIFT - PAGE_SHIFT;
 #endif
        /*
         * HugeTLB CMA reservation is required for gigantic
index 9d4d898..823d3d5 100644 (file)
@@ -8,7 +8,7 @@ config CSKY
        select ARCH_HAS_SYNC_DMA_FOR_DEVICE
        select ARCH_USE_BUILTIN_BSWAP
        select ARCH_USE_QUEUED_RWLOCKS
-       select ARCH_WANT_FRAME_POINTERS if !CPU_CK610
+       select ARCH_WANT_FRAME_POINTERS if !CPU_CK610 && $(cc-option,-mbacktrace)
        select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT
        select COMMON_CLK
        select CLKSRC_MMIO
@@ -241,6 +241,7 @@ endchoice
 
 menuconfig HAVE_TCM
        bool "Tightly-Coupled/Sram Memory"
+       depends on !COMPILE_TEST
        help
          The implementation are not only used by TCM (Tightly-Coupled Meory)
          but also used by sram on SOC bus. It follow existed linux tcm
index 9181878..02b72a0 100644 (file)
@@ -74,7 +74,6 @@ static __always_inline unsigned long __fls(unsigned long x)
  * bug fix, why only could use atomic!!!!
  */
 #include <asm-generic/bitops/non-atomic.h>
-#define __clear_bit(nr, vaddr) clear_bit(nr, vaddr)
 
 #include <asm-generic/bitops/le.h>
 #include <asm-generic/bitops/ext2-atomic.h>
index 0105ac8..1a5f54e 100644 (file)
@@ -99,7 +99,8 @@ static int gpr_set(struct task_struct *target,
        if (ret)
                return ret;
 
-       regs.sr = task_pt_regs(target)->sr;
+       /* BIT(0) of regs.sr is Condition Code/Carry bit */
+       regs.sr = (regs.sr & BIT(0)) | (task_pt_regs(target)->sr & ~BIT(0));
 #ifdef CONFIG_CPU_HAS_HILO
        regs.dcsr = task_pt_regs(target)->dcsr;
 #endif
index 312f046..c7b763d 100644 (file)
@@ -52,10 +52,14 @@ static long restore_sigcontext(struct pt_regs *regs,
        struct sigcontext __user *sc)
 {
        int err = 0;
+       unsigned long sr = regs->sr;
 
        /* sc_pt_regs is structured the same as the start of pt_regs */
        err |= __copy_from_user(regs, &sc->sc_pt_regs, sizeof(struct pt_regs));
 
+       /* BIT(0) of regs->sr is Condition Code/Carry bit */
+       regs->sr = (sr & ~1) | (regs->sr & 1);
+
        /* Restore the floating-point state. */
        err |= restore_fpu_state(sc);
 
@@ -260,8 +264,6 @@ asmlinkage void do_notify_resume(struct pt_regs *regs,
        if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
                do_signal(regs);
 
-       if (thread_info_flags & _TIF_NOTIFY_RESUME) {
+       if (thread_info_flags & _TIF_NOTIFY_RESUME)
                tracehook_notify_resume(regs);
-               rseq_handle_notify_resume(NULL, regs);
-       }
 }
index 045792c..1e33666 100644 (file)
@@ -388,8 +388,6 @@ config CRASH_DUMP
          help
            Generate crash dump after being started by kexec.
 
-source "drivers/firmware/Kconfig"
-
 endmenu
 
 menu "Power management and ACPI options"
index 259b366..997b549 100644 (file)
@@ -15,7 +15,6 @@
 #include <asm/unistd.h>
 #include <asm/errno.h>
 #include <asm/setup.h>
-#include <asm/segment.h>
 #include <asm/traps.h>
 #include <asm/asm-offsets.h>
 #include <asm/entry.h>
@@ -25,7 +24,6 @@
 .globl system_call
 .globl resume
 .globl ret_from_exception
-.globl ret_from_signal
 .globl sys_call_table
 .globl bad_interrupt
 .globl inthandler1
@@ -59,8 +57,6 @@ do_trace:
        subql   #4,%sp                  /* dummy return address */
        SAVE_SWITCH_STACK
        jbsr    syscall_trace_leave
-
-ret_from_signal:
        RESTORE_SWITCH_STACK
        addql   #4,%sp
        jra     ret_from_exception
index 774c35f..0b50da0 100644 (file)
@@ -29,7 +29,6 @@ config M68K
        select NO_DMA if !MMU && !COLDFIRE
        select OLD_SIGACTION
        select OLD_SIGSUSPEND3
-       select SET_FS
        select UACCESS_MEMCPY if !MMU
        select VIRT_TO_BUS
        select ZONE_DMA
index d43a027..9f337c7 100644 (file)
@@ -31,7 +31,6 @@
 #include <asm/thread_info.h>
 #include <asm/errno.h>
 #include <asm/setup.h>
-#include <asm/segment.h>
 #include <asm/asm-offsets.h>
 #include <asm/entry.h>
 
@@ -51,7 +50,6 @@ sw_usp:
 .globl system_call
 .globl resume
 .globl ret_from_exception
-.globl ret_from_signal
 .globl sys_call_table
 .globl inthandler
 
@@ -98,8 +96,6 @@ ENTRY(system_call)
        subql   #4,%sp                  /* dummy return address */
        SAVE_SWITCH_STACK
        jbsr    syscall_trace_leave
-
-ret_from_signal:
        RESTORE_SWITCH_STACK
        addql   #4,%sp
 
index 3750819..f4d82c6 100644 (file)
@@ -9,7 +9,6 @@
 #define __ASM_M68K_PROCESSOR_H
 
 #include <linux/thread_info.h>
-#include <asm/segment.h>
 #include <asm/fpu.h>
 #include <asm/ptrace.h>
 
@@ -75,11 +74,37 @@ static inline void wrusp(unsigned long usp)
 #define TASK_UNMAPPED_BASE     0
 #endif
 
+/* Address spaces (or Function Codes in Motorola lingo) */
+#define USER_DATA     1
+#define USER_PROGRAM  2
+#define SUPER_DATA    5
+#define SUPER_PROGRAM 6
+#define CPU_SPACE     7
+
+#ifdef CONFIG_CPU_HAS_ADDRESS_SPACES
+/*
+ * Set the SFC/DFC registers for special MM operations.  For most normal
+ * operation these remain set to USER_DATA for the uaccess routines.
+ */
+static inline void set_fc(unsigned long val)
+{
+       WARN_ON_ONCE(in_interrupt());
+
+       __asm__ __volatile__ ("movec %0,%/sfc\n\t"
+                             "movec %0,%/dfc\n\t"
+                             : /* no outputs */ : "r" (val) : "memory");
+}
+#else
+static inline void set_fc(unsigned long val)
+{
+}
+#endif /* CONFIG_CPU_HAS_ADDRESS_SPACES */
+
 struct thread_struct {
        unsigned long  ksp;             /* kernel stack pointer */
        unsigned long  usp;             /* user stack pointer */
        unsigned short sr;              /* saved status register */
-       unsigned short fs;              /* saved fs (sfc, dfc) */
+       unsigned short fc;              /* saved fc (sfc, dfc) */
        unsigned long  crp[2];          /* cpu root pointer */
        unsigned long  esp0;            /* points to SR of stack frame */
        unsigned long  faddr;           /* info about last fault */
@@ -92,7 +117,7 @@ struct thread_struct {
 #define INIT_THREAD  {                                                 \
        .ksp    = sizeof(init_stack) + (unsigned long) init_stack,      \
        .sr     = PS_S,                                                 \
-       .fs     = __KERNEL_DS,                                          \
+       .fc     = USER_DATA,                                            \
 }
 
 /*
index 911826e..80eb239 100644 (file)
  * two accesses to memory, which may be undesirable for some devices.
  */
 #define in_8(addr) \
-    ({ u8 __v = (*(__force volatile u8 *) (addr)); __v; })
+    ({ u8 __v = (*(__force volatile u8 *) (unsigned long)(addr)); __v; })
 #define in_be16(addr) \
-    ({ u16 __v = (*(__force volatile u16 *) (addr)); __v; })
+    ({ u16 __v = (*(__force volatile u16 *) (unsigned long)(addr)); __v; })
 #define in_be32(addr) \
-    ({ u32 __v = (*(__force volatile u32 *) (addr)); __v; })
+    ({ u32 __v = (*(__force volatile u32 *) (unsigned long)(addr)); __v; })
 #define in_le16(addr) \
-    ({ u16 __v = le16_to_cpu(*(__force volatile __le16 *) (addr)); __v; })
+    ({ u16 __v = le16_to_cpu(*(__force volatile __le16 *) (unsigned long)(addr)); __v; })
 #define in_le32(addr) \
-    ({ u32 __v = le32_to_cpu(*(__force volatile __le32 *) (addr)); __v; })
+    ({ u32 __v = le32_to_cpu(*(__force volatile __le32 *) (unsigned long)(addr)); __v; })
 
-#define out_8(addr,b) (void)((*(__force volatile u8 *) (addr)) = (b))
-#define out_be16(addr,w) (void)((*(__force volatile u16 *) (addr)) = (w))
-#define out_be32(addr,l) (void)((*(__force volatile u32 *) (addr)) = (l))
-#define out_le16(addr,w) (void)((*(__force volatile __le16 *) (addr)) = cpu_to_le16(w))
-#define out_le32(addr,l) (void)((*(__force volatile __le32 *) (addr)) = cpu_to_le32(l))
+#define out_8(addr,b) (void)((*(__force volatile u8 *) (unsigned long)(addr)) = (b))
+#define out_be16(addr,w) (void)((*(__force volatile u16 *) (unsigned long)(addr)) = (w))
+#define out_be32(addr,l) (void)((*(__force volatile u32 *) (unsigned long)(addr)) = (l))
+#define out_le16(addr,w) (void)((*(__force volatile __le16 *) (unsigned long)(addr)) = cpu_to_le16(w))
+#define out_le32(addr,l) (void)((*(__force volatile __le32 *) (unsigned long)(addr)) = cpu_to_le32(l))
 
 #define raw_inb in_8
 #define raw_inw in_be16
diff --git a/arch/m68k/include/asm/segment.h b/arch/m68k/include/asm/segment.h
deleted file mode 100644 (file)
index 2b5e68a..0000000
+++ /dev/null
@@ -1,59 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef _M68K_SEGMENT_H
-#define _M68K_SEGMENT_H
-
-/* define constants */
-/* Address spaces (FC0-FC2) */
-#define USER_DATA     (1)
-#ifndef __USER_DS
-#define __USER_DS     (USER_DATA)
-#endif
-#define USER_PROGRAM  (2)
-#define SUPER_DATA    (5)
-#ifndef __KERNEL_DS
-#define __KERNEL_DS   (SUPER_DATA)
-#endif
-#define SUPER_PROGRAM (6)
-#define CPU_SPACE     (7)
-
-#ifndef __ASSEMBLY__
-
-typedef struct {
-       unsigned long seg;
-} mm_segment_t;
-
-#define MAKE_MM_SEG(s) ((mm_segment_t) { (s) })
-
-#ifdef CONFIG_CPU_HAS_ADDRESS_SPACES
-/*
- * Get/set the SFC/DFC registers for MOVES instructions
- */
-#define USER_DS                MAKE_MM_SEG(__USER_DS)
-#define KERNEL_DS      MAKE_MM_SEG(__KERNEL_DS)
-
-static inline mm_segment_t get_fs(void)
-{
-       mm_segment_t _v;
-       __asm__ ("movec %/dfc,%0":"=r" (_v.seg):);
-       return _v;
-}
-
-static inline void set_fs(mm_segment_t val)
-{
-       __asm__ __volatile__ ("movec %0,%/sfc\n\t"
-                             "movec %0,%/dfc\n\t"
-                             : /* no outputs */ : "r" (val.seg) : "memory");
-}
-
-#else
-#define USER_DS                MAKE_MM_SEG(TASK_SIZE)
-#define KERNEL_DS      MAKE_MM_SEG(0xFFFFFFFF)
-#define get_fs()       (current_thread_info()->addr_limit)
-#define set_fs(x)      (current_thread_info()->addr_limit = (x))
-#endif
-
-#define uaccess_kernel()       (get_fs().seg == KERNEL_DS.seg)
-
-#endif /* __ASSEMBLY__ */
-
-#endif /* _M68K_SEGMENT_H */
index 15a7570..c952658 100644 (file)
@@ -4,7 +4,6 @@
 
 #include <asm/types.h>
 #include <asm/page.h>
-#include <asm/segment.h>
 
 /*
  * On machines with 4k pages we default to an 8k thread size, though we
@@ -27,7 +26,6 @@
 struct thread_info {
        struct task_struct      *task;          /* main task structure */
        unsigned long           flags;
-       mm_segment_t            addr_limit;     /* thread address space */
        int                     preempt_count;  /* 0 => preemptable, <0 => BUG */
        __u32                   cpu;            /* should always be 0 on m68k */
        unsigned long           tp_value;       /* thread pointer */
@@ -37,7 +35,6 @@ struct thread_info {
 #define INIT_THREAD_INFO(tsk)                  \
 {                                              \
        .task           = &tsk,                 \
-       .addr_limit     = KERNEL_DS,            \
        .preempt_count  = INIT_PREEMPT_COUNT,   \
 }
 
index a6318cc..b882e2f 100644 (file)
@@ -13,13 +13,12 @@ static inline void flush_tlb_kernel_page(void *addr)
        if (CPU_IS_COLDFIRE) {
                mmu_write(MMUOR, MMUOR_CNL);
        } else if (CPU_IS_040_OR_060) {
-               mm_segment_t old_fs = get_fs();
-               set_fs(KERNEL_DS);
+               set_fc(SUPER_DATA);
                __asm__ __volatile__(".chip 68040\n\t"
                                     "pflush (%0)\n\t"
                                     ".chip 68k"
                                     : : "a" (addr));
-               set_fs(old_fs);
+               set_fc(USER_DATA);
        } else if (CPU_IS_020_OR_030)
                __asm__ __volatile__("pflush #4,#4,(%0)" : : "a" (addr));
 }
@@ -84,12 +83,8 @@ static inline void flush_tlb_mm(struct mm_struct *mm)
 
 static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned long addr)
 {
-       if (vma->vm_mm == current->active_mm) {
-               mm_segment_t old_fs = force_uaccess_begin();
-
+       if (vma->vm_mm == current->active_mm)
                __flush_tlb_one(addr);
-               force_uaccess_end(old_fs);
-       }
 }
 
 static inline void flush_tlb_range(struct vm_area_struct *vma,
index 4aff335..a9d5c1c 100644 (file)
@@ -267,6 +267,10 @@ struct frame {
     } un;
 };
 
+#ifdef CONFIG_M68040
+asmlinkage void berr_040cleanup(struct frame *fp);
+#endif
+
 #endif /* __ASSEMBLY__ */
 
 #endif /* _M68K_TRAPS_H */
index f98208c..ba67052 100644 (file)
@@ -9,13 +9,16 @@
  */
 #include <linux/compiler.h>
 #include <linux/types.h>
-#include <asm/segment.h>
 #include <asm/extable.h>
 
 /* We let the MMU do all checking */
 static inline int access_ok(const void __user *addr,
                            unsigned long size)
 {
+       /*
+        * XXX: for !CONFIG_CPU_HAS_ADDRESS_SPACES this really needs to check
+        * for TASK_SIZE!
+        */
        return 1;
 }
 
@@ -35,12 +38,9 @@ static inline int access_ok(const void __user *addr,
 #define        MOVES   "move"
 #endif
 
-extern int __put_user_bad(void);
-extern int __get_user_bad(void);
-
-#define __put_user_asm(res, x, ptr, bwl, reg, err)     \
+#define __put_user_asm(inst, res, x, ptr, bwl, reg, err) \
 asm volatile ("\n"                                     \
-       "1:     "MOVES"."#bwl"  %2,%1\n"                \
+       "1:     "inst"."#bwl"   %2,%1\n"                \
        "2:\n"                                          \
        "       .section .fixup,\"ax\"\n"               \
        "       .even\n"                                \
@@ -56,6 +56,31 @@ asm volatile ("\n"                                   \
        : "+d" (res), "=m" (*(ptr))                     \
        : #reg (x), "i" (err))
 
+#define __put_user_asm8(inst, res, x, ptr)                     \
+do {                                                           \
+       const void *__pu_ptr = (const void __force *)(ptr);     \
+                                                               \
+       asm volatile ("\n"                                      \
+               "1:     "inst".l %2,(%1)+\n"                    \
+               "2:     "inst".l %R2,(%1)\n"                    \
+               "3:\n"                                          \
+               "       .section .fixup,\"ax\"\n"               \
+               "       .even\n"                                \
+               "10:    movel %3,%0\n"                          \
+               "       jra 3b\n"                               \
+               "       .previous\n"                            \
+               "\n"                                            \
+               "       .section __ex_table,\"a\"\n"            \
+               "       .align 4\n"                             \
+               "       .long 1b,10b\n"                         \
+               "       .long 2b,10b\n"                         \
+               "       .long 3b,10b\n"                         \
+               "       .previous"                              \
+               : "+d" (res), "+a" (__pu_ptr)                   \
+               : "r" (x), "i" (-EFAULT)                        \
+               : "memory");                                    \
+} while (0)
+
 /*
  * These are the main single-value transfer routines.  They automatically
  * use the right size if we just have the right pointer type.
@@ -68,51 +93,29 @@ asm volatile ("\n"                                  \
        __chk_user_ptr(ptr);                                            \
        switch (sizeof (*(ptr))) {                                      \
        case 1:                                                         \
-               __put_user_asm(__pu_err, __pu_val, ptr, b, d, -EFAULT); \
+               __put_user_asm(MOVES, __pu_err, __pu_val, ptr, b, d, -EFAULT); \
                break;                                                  \
        case 2:                                                         \
-               __put_user_asm(__pu_err, __pu_val, ptr, w, r, -EFAULT); \
+               __put_user_asm(MOVES, __pu_err, __pu_val, ptr, w, r, -EFAULT); \
                break;                                                  \
        case 4:                                                         \
-               __put_user_asm(__pu_err, __pu_val, ptr, l, r, -EFAULT); \
+               __put_user_asm(MOVES, __pu_err, __pu_val, ptr, l, r, -EFAULT); \
                break;                                                  \
        case 8:                                                         \
-           {                                                           \
-               const void __user *__pu_ptr = (ptr);                    \
-               asm volatile ("\n"                                      \
-                       "1:     "MOVES".l       %2,(%1)+\n"             \
-                       "2:     "MOVES".l       %R2,(%1)\n"             \
-                       "3:\n"                                          \
-                       "       .section .fixup,\"ax\"\n"               \
-                       "       .even\n"                                \
-                       "10:    movel %3,%0\n"                          \
-                       "       jra 3b\n"                               \
-                       "       .previous\n"                            \
-                       "\n"                                            \
-                       "       .section __ex_table,\"a\"\n"            \
-                       "       .align 4\n"                             \
-                       "       .long 1b,10b\n"                         \
-                       "       .long 2b,10b\n"                         \
-                       "       .long 3b,10b\n"                         \
-                       "       .previous"                              \
-                       : "+d" (__pu_err), "+a" (__pu_ptr)              \
-                       : "r" (__pu_val), "i" (-EFAULT)                 \
-                       : "memory");                                    \
+               __put_user_asm8(MOVES, __pu_err, __pu_val, ptr);        \
                break;                                                  \
-           }                                                           \
        default:                                                        \
-               __pu_err = __put_user_bad();                            \
-               break;                                                  \
+               BUILD_BUG();                                            \
        }                                                               \
        __pu_err;                                                       \
 })
 #define put_user(x, ptr)       __put_user(x, ptr)
 
 
-#define __get_user_asm(res, x, ptr, type, bwl, reg, err) ({            \
+#define __get_user_asm(inst, res, x, ptr, type, bwl, reg, err) ({      \
        type __gu_val;                                                  \
        asm volatile ("\n"                                              \
-               "1:     "MOVES"."#bwl"  %2,%1\n"                        \
+               "1:     "inst"."#bwl"   %2,%1\n"                        \
                "2:\n"                                                  \
                "       .section .fixup,\"ax\"\n"                       \
                "       .even\n"                                        \
@@ -130,53 +133,57 @@ asm volatile ("\n"                                        \
        (x) = (__force typeof(*(ptr)))(__force unsigned long)__gu_val;  \
 })
 
+#define __get_user_asm8(inst, res, x, ptr)                             \
+do {                                                                   \
+       const void *__gu_ptr = (const void __force *)(ptr);             \
+       union {                                                         \
+               u64 l;                                                  \
+               __typeof__(*(ptr)) t;                                   \
+       } __gu_val;                                                     \
+                                                                       \
+       asm volatile ("\n"                                              \
+               "1:     "inst".l (%2)+,%1\n"                            \
+               "2:     "inst".l (%2),%R1\n"                            \
+               "3:\n"                                                  \
+               "       .section .fixup,\"ax\"\n"                       \
+               "       .even\n"                                        \
+               "10:    move.l  %3,%0\n"                                \
+               "       sub.l   %1,%1\n"                                \
+               "       sub.l   %R1,%R1\n"                              \
+               "       jra     3b\n"                                   \
+               "       .previous\n"                                    \
+               "\n"                                                    \
+               "       .section __ex_table,\"a\"\n"                    \
+               "       .align  4\n"                                    \
+               "       .long   1b,10b\n"                               \
+               "       .long   2b,10b\n"                               \
+               "       .previous"                                      \
+               : "+d" (res), "=&r" (__gu_val.l),                       \
+                 "+a" (__gu_ptr)                                       \
+               : "i" (-EFAULT)                                         \
+               : "memory");                                            \
+       (x) = __gu_val.t;                                               \
+} while (0)
+
 #define __get_user(x, ptr)                                             \
 ({                                                                     \
        int __gu_err = 0;                                               \
        __chk_user_ptr(ptr);                                            \
        switch (sizeof(*(ptr))) {                                       \
        case 1:                                                         \
-               __get_user_asm(__gu_err, x, ptr, u8, b, d, -EFAULT);    \
+               __get_user_asm(MOVES, __gu_err, x, ptr, u8, b, d, -EFAULT); \
                break;                                                  \
        case 2:                                                         \
-               __get_user_asm(__gu_err, x, ptr, u16, w, r, -EFAULT);   \
+               __get_user_asm(MOVES, __gu_err, x, ptr, u16, w, r, -EFAULT); \
                break;                                                  \
        case 4:                                                         \
-               __get_user_asm(__gu_err, x, ptr, u32, l, r, -EFAULT);   \
+               __get_user_asm(MOVES, __gu_err, x, ptr, u32, l, r, -EFAULT); \
                break;                                                  \
-       case 8: {                                                       \
-               const void __user *__gu_ptr = (ptr);                    \
-               union {                                                 \
-                       u64 l;                                          \
-                       __typeof__(*(ptr)) t;                           \
-               } __gu_val;                                             \
-               asm volatile ("\n"                                      \
-                       "1:     "MOVES".l       (%2)+,%1\n"             \
-                       "2:     "MOVES".l       (%2),%R1\n"             \
-                       "3:\n"                                          \
-                       "       .section .fixup,\"ax\"\n"               \
-                       "       .even\n"                                \
-                       "10:    move.l  %3,%0\n"                        \
-                       "       sub.l   %1,%1\n"                        \
-                       "       sub.l   %R1,%R1\n"                      \
-                       "       jra     3b\n"                           \
-                       "       .previous\n"                            \
-                       "\n"                                            \
-                       "       .section __ex_table,\"a\"\n"            \
-                       "       .align  4\n"                            \
-                       "       .long   1b,10b\n"                       \
-                       "       .long   2b,10b\n"                       \
-                       "       .previous"                              \
-                       : "+d" (__gu_err), "=&r" (__gu_val.l),          \
-                         "+a" (__gu_ptr)                               \
-                       : "i" (-EFAULT)                                 \
-                       : "memory");                                    \
-               (x) = __gu_val.t;                                       \
+       case 8:                                                         \
+               __get_user_asm8(MOVES, __gu_err, x, ptr);               \
                break;                                                  \
-       }                                                               \
        default:                                                        \
-               __gu_err = __get_user_bad();                            \
-               break;                                                  \
+               BUILD_BUG();                                            \
        }                                                               \
        __gu_err;                                                       \
 })
@@ -322,16 +329,19 @@ __constant_copy_to_user(void __user *to, const void *from, unsigned long n)
 
        switch (n) {
        case 1:
-               __put_user_asm(res, *(u8 *)from, (u8 __user *)to, b, d, 1);
+               __put_user_asm(MOVES, res, *(u8 *)from, (u8 __user *)to,
+                               b, d, 1);
                break;
        case 2:
-               __put_user_asm(res, *(u16 *)from, (u16 __user *)to, w, r, 2);
+               __put_user_asm(MOVES, res, *(u16 *)from, (u16 __user *)to,
+                               w, r, 2);
                break;
        case 3:
                __constant_copy_to_user_asm(res, to, from, tmp, 3, w, b,);
                break;
        case 4:
-               __put_user_asm(res, *(u32 *)from, (u32 __user *)to, l, r, 4);
+               __put_user_asm(MOVES, res, *(u32 *)from, (u32 __user *)to,
+                               l, r, 4);
                break;
        case 5:
                __constant_copy_to_user_asm(res, to, from, tmp, 5, l, b,);
@@ -380,8 +390,65 @@ raw_copy_to_user(void __user *to, const void *from, unsigned long n)
 #define INLINE_COPY_FROM_USER
 #define INLINE_COPY_TO_USER
 
-#define user_addr_max() \
-       (uaccess_kernel() ? ~0UL : TASK_SIZE)
+#define HAVE_GET_KERNEL_NOFAULT
+
+#define __get_kernel_nofault(dst, src, type, err_label)                        \
+do {                                                                   \
+       type *__gk_dst = (type *)(dst);                                 \
+       type *__gk_src = (type *)(src);                                 \
+       int __gk_err = 0;                                               \
+                                                                       \
+       switch (sizeof(type)) {                                         \
+       case 1:                                                         \
+               __get_user_asm("move", __gk_err, *__gk_dst, __gk_src,   \
+                               u8, b, d, -EFAULT);                     \
+               break;                                                  \
+       case 2:                                                         \
+               __get_user_asm("move", __gk_err, *__gk_dst, __gk_src,   \
+                               u16, w, r, -EFAULT);                    \
+               break;                                                  \
+       case 4:                                                         \
+               __get_user_asm("move", __gk_err, *__gk_dst, __gk_src,   \
+                               u32, l, r, -EFAULT);                    \
+               break;                                                  \
+       case 8:                                                         \
+               __get_user_asm8("move", __gk_err, *__gk_dst, __gk_src); \
+               break;                                                  \
+       default:                                                        \
+               BUILD_BUG();                                            \
+       }                                                               \
+       if (unlikely(__gk_err))                                         \
+               goto err_label;                                         \
+} while (0)
+
+#define __put_kernel_nofault(dst, src, type, err_label)                        \
+do {                                                                   \
+       type __pk_src = *(type *)(src);                                 \
+       type *__pk_dst = (type *)(dst);                                 \
+       int __pk_err = 0;                                               \
+                                                                       \
+       switch (sizeof(type)) {                                         \
+       case 1:                                                         \
+               __put_user_asm("move", __pk_err, __pk_src, __pk_dst,    \
+                               b, d, -EFAULT);                         \
+               break;                                                  \
+       case 2:                                                         \
+               __put_user_asm("move", __pk_err, __pk_src, __pk_dst,    \
+                               w, r, -EFAULT);                         \
+               break;                                                  \
+       case 4:                                                         \
+               __put_user_asm("move", __pk_err, __pk_src, __pk_dst,    \
+                               l, r, -EFAULT);                         \
+               break;                                                  \
+       case 8:                                                         \
+               __put_user_asm8("move", __pk_err, __pk_src, __pk_dst);  \
+               break;                                                  \
+       default:                                                        \
+               BUILD_BUG();                                            \
+       }                                                               \
+       if (unlikely(__pk_err))                                         \
+               goto err_label;                                         \
+} while (0)
 
 extern long strncpy_from_user(char *dst, const char __user *src, long count);
 extern __must_check long strnlen_user(const char __user *str, long n);
index ccea355..906d732 100644 (file)
@@ -31,7 +31,7 @@ int main(void)
        DEFINE(THREAD_KSP, offsetof(struct thread_struct, ksp));
        DEFINE(THREAD_USP, offsetof(struct thread_struct, usp));
        DEFINE(THREAD_SR, offsetof(struct thread_struct, sr));
-       DEFINE(THREAD_FS, offsetof(struct thread_struct, fs));
+       DEFINE(THREAD_FC, offsetof(struct thread_struct, fc));
        DEFINE(THREAD_CRP, offsetof(struct thread_struct, crp));
        DEFINE(THREAD_ESP0, offsetof(struct thread_struct, esp0));
        DEFINE(THREAD_FPREG, offsetof(struct thread_struct, fp));
index 9dd76fb..9434fca 100644 (file)
@@ -36,7 +36,6 @@
 #include <linux/linkage.h>
 #include <asm/errno.h>
 #include <asm/setup.h>
-#include <asm/segment.h>
 #include <asm/traps.h>
 #include <asm/unistd.h>
 #include <asm/asm-offsets.h>
@@ -78,20 +77,38 @@ ENTRY(__sys_clone3)
 
 ENTRY(sys_sigreturn)
        SAVE_SWITCH_STACK
-       movel   %sp,%sp@-                 | switch_stack pointer
-       pea     %sp@(SWITCH_STACK_SIZE+4) | pt_regs pointer
+       movel   %sp,%a1                         | switch_stack pointer
+       lea     %sp@(SWITCH_STACK_SIZE),%a0     | pt_regs pointer
+       lea     %sp@(-84),%sp                   | leave a gap
+       movel   %a1,%sp@-
+       movel   %a0,%sp@-
        jbsr    do_sigreturn
-       addql   #8,%sp
-       RESTORE_SWITCH_STACK
-       rts
+       jra     1f                              | shared with rt_sigreturn()
 
 ENTRY(sys_rt_sigreturn)
        SAVE_SWITCH_STACK
-       movel   %sp,%sp@-                 | switch_stack pointer
-       pea     %sp@(SWITCH_STACK_SIZE+4) | pt_regs pointer
+       movel   %sp,%a1                         | switch_stack pointer
+       lea     %sp@(SWITCH_STACK_SIZE),%a0     | pt_regs pointer
+       lea     %sp@(-84),%sp                   | leave a gap
+       movel   %a1,%sp@-
+       movel   %a0,%sp@-
+       | stack contents:
+       |   [original pt_regs address] [original switch_stack address]
+       |   [gap] [switch_stack] [pt_regs] [exception frame]
        jbsr    do_rt_sigreturn
-       addql   #8,%sp
+
+1:
+       | stack contents now:
+       |   [original pt_regs address] [original switch_stack address]
+       |   [unused part of the gap] [moved switch_stack] [moved pt_regs]
+       |   [replacement exception frame]
+       | return value of do_{rt_,}sigreturn() points to moved switch_stack.
+
+       movel   %d0,%sp                         | discard the leftover junk
        RESTORE_SWITCH_STACK
+       | stack contents now is just [syscall return address] [pt_regs] [frame]
+       | return pt_regs.d0
+       movel   %sp@(PT_OFF_D0+4),%d0
        rts
 
 ENTRY(buserr)
@@ -182,25 +199,6 @@ do_trace_exit:
        addql   #4,%sp
        jra     .Lret_from_exception
 
-ENTRY(ret_from_signal)
-       movel   %curptr@(TASK_STACK),%a1
-       tstb    %a1@(TINFO_FLAGS+2)
-       jge     1f
-       jbsr    syscall_trace
-1:     RESTORE_SWITCH_STACK
-       addql   #4,%sp
-/* on 68040 complete pending writebacks if any */
-#ifdef CONFIG_M68040
-       bfextu  %sp@(PT_OFF_FORMATVEC){#0,#4},%d0
-       subql   #7,%d0                          | bus error frame ?
-       jbne    1f
-       movel   %sp,%sp@-
-       jbsr    berr_040cleanup
-       addql   #4,%sp
-1:
-#endif
-       jra     .Lret_from_exception
-
 ENTRY(system_call)
        SAVE_ALL_SYS
 
@@ -338,7 +336,7 @@ resume:
 
        /* save fs (sfc,%dfc) (may be pointing to kernel memory) */
        movec   %sfc,%d0
-       movew   %d0,%a0@(TASK_THREAD+THREAD_FS)
+       movew   %d0,%a0@(TASK_THREAD+THREAD_FC)
 
        /* save usp */
        /* it is better to use a movel here instead of a movew 8*) */
@@ -424,7 +422,7 @@ resume:
        movel   %a0,%usp
 
        /* restore fs (sfc,%dfc) */
-       movew   %a1@(TASK_THREAD+THREAD_FS),%a0
+       movew   %a1@(TASK_THREAD+THREAD_FC),%a0
        movec   %a0,%sfc
        movec   %a0,%dfc
 
index db49f90..1ab692b 100644 (file)
@@ -92,7 +92,7 @@ void show_regs(struct pt_regs * regs)
 
 void flush_thread(void)
 {
-       current->thread.fs = __USER_DS;
+       current->thread.fc = USER_DATA;
 #ifdef CONFIG_FPU
        if (!FPU_IS_EMU) {
                unsigned long zero = 0;
@@ -155,7 +155,7 @@ int copy_thread(unsigned long clone_flags, unsigned long usp, unsigned long arg,
         * Must save the current SFC/DFC value, NOT the value when
         * the parent was last descheduled - RGH  10-08-96
         */
-       p->thread.fs = get_fs().seg;
+       p->thread.fc = USER_DATA;
 
        if (unlikely(p->flags & (PF_KTHREAD | PF_IO_WORKER))) {
                /* kernel thread */
index 8f215e7..338817d 100644 (file)
@@ -447,7 +447,7 @@ static inline void save_fpu_state(struct sigcontext *sc, struct pt_regs *regs)
 
        if (CPU_IS_060 ? sc->sc_fpstate[2] : sc->sc_fpstate[0]) {
                fpu_version = sc->sc_fpstate[0];
-               if (CPU_IS_020_OR_030 &&
+               if (CPU_IS_020_OR_030 && !regs->stkadj &&
                    regs->vector >= (VEC_FPBRUC * 4) &&
                    regs->vector <= (VEC_FPNAN * 4)) {
                        /* Clear pending exception in 68882 idle frame */
@@ -510,7 +510,7 @@ static inline int rt_save_fpu_state(struct ucontext __user *uc, struct pt_regs *
                if (!(CPU_IS_060 || CPU_IS_COLDFIRE))
                        context_size = fpstate[1];
                fpu_version = fpstate[0];
-               if (CPU_IS_020_OR_030 &&
+               if (CPU_IS_020_OR_030 && !regs->stkadj &&
                    regs->vector >= (VEC_FPBRUC * 4) &&
                    regs->vector <= (VEC_FPNAN * 4)) {
                        /* Clear pending exception in 68882 idle frame */
@@ -641,56 +641,35 @@ static inline void siginfo_build_tests(void)
 static int mangle_kernel_stack(struct pt_regs *regs, int formatvec,
                               void __user *fp)
 {
-       int fsize = frame_extra_sizes(formatvec >> 12);
-       if (fsize < 0) {
+       int extra = frame_extra_sizes(formatvec >> 12);
+       char buf[sizeof_field(struct frame, un)];
+
+       if (extra < 0) {
                /*
                 * user process trying to return with weird frame format
                 */
                pr_debug("user process returning with weird frame format\n");
-               return 1;
+               return -1;
        }
-       if (!fsize) {
-               regs->format = formatvec >> 12;
-               regs->vector = formatvec & 0xfff;
-       } else {
-               struct switch_stack *sw = (struct switch_stack *)regs - 1;
-               /* yes, twice as much as max(sizeof(frame.un.fmt<x>)) */
-               unsigned long buf[sizeof_field(struct frame, un) / 2];
-
-               /* that'll make sure that expansion won't crap over data */
-               if (copy_from_user(buf + fsize / 4, fp, fsize))
-                       return 1;
-
-               /* point of no return */
-               regs->format = formatvec >> 12;
-               regs->vector = formatvec & 0xfff;
-#define frame_offset (sizeof(struct pt_regs)+sizeof(struct switch_stack))
-               __asm__ __volatile__ (
-#ifdef CONFIG_COLDFIRE
-                        "   movel %0,%/sp\n\t"
-                        "   bra ret_from_signal\n"
-#else
-                        "   movel %0,%/a0\n\t"
-                        "   subl %1,%/a0\n\t"     /* make room on stack */
-                        "   movel %/a0,%/sp\n\t"  /* set stack pointer */
-                        /* move switch_stack and pt_regs */
-                        "1: movel %0@+,%/a0@+\n\t"
-                        "   dbra %2,1b\n\t"
-                        "   lea %/sp@(%c3),%/a0\n\t" /* add offset of fmt */
-                        "   lsrl  #2,%1\n\t"
-                        "   subql #1,%1\n\t"
-                        /* copy to the gap we'd made */
-                        "2: movel %4@+,%/a0@+\n\t"
-                        "   dbra %1,2b\n\t"
-                        "   bral ret_from_signal\n"
+       if (extra && copy_from_user(buf, fp, extra))
+               return -1;
+       regs->format = formatvec >> 12;
+       regs->vector = formatvec & 0xfff;
+       if (extra) {
+               void *p = (struct switch_stack *)regs - 1;
+               struct frame *new = (void *)regs - extra;
+               int size = sizeof(struct pt_regs)+sizeof(struct switch_stack);
+
+               memmove(p - extra, p, size);
+               memcpy(p - extra + size, buf, extra);
+               current->thread.esp0 = (unsigned long)&new->ptregs;
+#ifdef CONFIG_M68040
+               /* on 68040 complete pending writebacks if any */
+               if (new->ptregs.format == 7) // bus error frame
+                       berr_040cleanup(new);
 #endif
-                        : /* no outputs, it doesn't ever return */
-                        : "a" (sw), "d" (fsize), "d" (frame_offset/4-1),
-                          "n" (frame_offset), "a" (buf + fsize/4)
-                        : "a0");
-#undef frame_offset
        }
-       return 0;
+       return extra;
 }
 
 static inline int
@@ -698,7 +677,6 @@ restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *usc, void __u
 {
        int formatvec;
        struct sigcontext context;
-       int err = 0;
 
        siginfo_build_tests();
 
@@ -707,7 +685,7 @@ restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *usc, void __u
 
        /* get previous context */
        if (copy_from_user(&context, usc, sizeof(context)))
-               goto badframe;
+               return -1;
 
        /* restore passed registers */
        regs->d0 = context.sc_d0;
@@ -720,15 +698,10 @@ restore_sigcontext(struct pt_regs *regs, struct sigcontext __user *usc, void __u
        wrusp(context.sc_usp);
        formatvec = context.sc_formatvec;
 
-       err = restore_fpu_state(&context);
+       if (restore_fpu_state(&context))
+               return -1;
 
-       if (err || mangle_kernel_stack(regs, formatvec, fp))
-               goto badframe;
-
-       return 0;
-
-badframe:
-       return 1;
+       return mangle_kernel_stack(regs, formatvec, fp);
 }
 
 static inline int
@@ -745,7 +718,7 @@ rt_restore_ucontext(struct pt_regs *regs, struct switch_stack *sw,
 
        err = __get_user(temp, &uc->uc_mcontext.version);
        if (temp != MCONTEXT_VERSION)
-               goto badframe;
+               return -1;
        /* restore passed registers */
        err |= __get_user(regs->d0, &gregs[0]);
        err |= __get_user(regs->d1, &gregs[1]);
@@ -774,22 +747,17 @@ rt_restore_ucontext(struct pt_regs *regs, struct switch_stack *sw,
        err |= restore_altstack(&uc->uc_stack);
 
        if (err)
-               goto badframe;
+               return -1;
 
-       if (mangle_kernel_stack(regs, temp, &uc->uc_extra))
-               goto badframe;
-
-       return 0;
-
-badframe:
-       return 1;
+       return mangle_kernel_stack(regs, temp, &uc->uc_extra);
 }
 
-asmlinkage int do_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
+asmlinkage void *do_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
 {
        unsigned long usp = rdusp();
        struct sigframe __user *frame = (struct sigframe __user *)(usp - 4);
        sigset_t set;
+       int size;
 
        if (!access_ok(frame, sizeof(*frame)))
                goto badframe;
@@ -801,20 +769,22 @@ asmlinkage int do_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
 
        set_current_blocked(&set);
 
-       if (restore_sigcontext(regs, &frame->sc, frame + 1))
+       size = restore_sigcontext(regs, &frame->sc, frame + 1);
+       if (size < 0)
                goto badframe;
-       return regs->d0;
+       return (void *)sw - size;
 
 badframe:
        force_sig(SIGSEGV);
-       return 0;
+       return sw;
 }
 
-asmlinkage int do_rt_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
+asmlinkage void *do_rt_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
 {
        unsigned long usp = rdusp();
        struct rt_sigframe __user *frame = (struct rt_sigframe __user *)(usp - 4);
        sigset_t set;
+       int size;
 
        if (!access_ok(frame, sizeof(*frame)))
                goto badframe;
@@ -823,27 +793,34 @@ asmlinkage int do_rt_sigreturn(struct pt_regs *regs, struct switch_stack *sw)
 
        set_current_blocked(&set);
 
-       if (rt_restore_ucontext(regs, sw, &frame->uc))
+       size = rt_restore_ucontext(regs, sw, &frame->uc);
+       if (size < 0)
                goto badframe;
-       return regs->d0;
+       return (void *)sw - size;
 
 badframe:
        force_sig(SIGSEGV);
-       return 0;
+       return sw;
+}
+
+static inline struct pt_regs *rte_regs(struct pt_regs *regs)
+{
+       return (void *)regs + regs->stkadj;
 }
 
 static void setup_sigcontext(struct sigcontext *sc, struct pt_regs *regs,
                             unsigned long mask)
 {
+       struct pt_regs *tregs = rte_regs(regs);
        sc->sc_mask = mask;
        sc->sc_usp = rdusp();
        sc->sc_d0 = regs->d0;
        sc->sc_d1 = regs->d1;
        sc->sc_a0 = regs->a0;
        sc->sc_a1 = regs->a1;
-       sc->sc_sr = regs->sr;
-       sc->sc_pc = regs->pc;
-       sc->sc_formatvec = regs->format << 12 | regs->vector;
+       sc->sc_sr = tregs->sr;
+       sc->sc_pc = tregs->pc;
+       sc->sc_formatvec = tregs->format << 12 | tregs->vector;
        save_a5_state(sc, regs);
        save_fpu_state(sc, regs);
 }
@@ -851,6 +828,7 @@ static void setup_sigcontext(struct sigcontext *sc, struct pt_regs *regs,
 static inline int rt_setup_ucontext(struct ucontext __user *uc, struct pt_regs *regs)
 {
        struct switch_stack *sw = (struct switch_stack *)regs - 1;
+       struct pt_regs *tregs = rte_regs(regs);
        greg_t __user *gregs = uc->uc_mcontext.gregs;
        int err = 0;
 
@@ -871,9 +849,9 @@ static inline int rt_setup_ucontext(struct ucontext __user *uc, struct pt_regs *
        err |= __put_user(sw->a5, &gregs[13]);
        err |= __put_user(sw->a6, &gregs[14]);
        err |= __put_user(rdusp(), &gregs[15]);
-       err |= __put_user(regs->pc, &gregs[16]);
-       err |= __put_user(regs->sr, &gregs[17]);
-       err |= __put_user((regs->format << 12) | regs->vector, &uc->uc_formatvec);
+       err |= __put_user(tregs->pc, &gregs[16]);
+       err |= __put_user(tregs->sr, &gregs[17]);
+       err |= __put_user((tregs->format << 12) | tregs->vector, &uc->uc_formatvec);
        err |= rt_save_fpu_state(uc, regs);
        return err;
 }
@@ -890,13 +868,14 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
                        struct pt_regs *regs)
 {
        struct sigframe __user *frame;
-       int fsize = frame_extra_sizes(regs->format);
+       struct pt_regs *tregs = rte_regs(regs);
+       int fsize = frame_extra_sizes(tregs->format);
        struct sigcontext context;
        int err = 0, sig = ksig->sig;
 
        if (fsize < 0) {
                pr_debug("setup_frame: Unknown frame format %#x\n",
-                        regs->format);
+                        tregs->format);
                return -EFAULT;
        }
 
@@ -907,7 +886,7 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
 
        err |= __put_user(sig, &frame->sig);
 
-       err |= __put_user(regs->vector, &frame->code);
+       err |= __put_user(tregs->vector, &frame->code);
        err |= __put_user(&frame->sc, &frame->psc);
 
        if (_NSIG_WORDS > 1)
@@ -933,34 +912,28 @@ static int setup_frame(struct ksignal *ksig, sigset_t *set,
 
        push_cache ((unsigned long) &frame->retcode);
 
-       /*
-        * Set up registers for signal handler.  All the state we are about
-        * to destroy is successfully copied to sigframe.
-        */
-       wrusp ((unsigned long) frame);
-       regs->pc = (unsigned long) ksig->ka.sa.sa_handler;
-       adjustformat(regs);
-
        /*
         * This is subtle; if we build more than one sigframe, all but the
         * first one will see frame format 0 and have fsize == 0, so we won't
         * screw stkadj.
         */
-       if (fsize)
+       if (fsize) {
                regs->stkadj = fsize;
-
-       /* Prepare to skip over the extra stuff in the exception frame.  */
-       if (regs->stkadj) {
-               struct pt_regs *tregs =
-                       (struct pt_regs *)((ulong)regs + regs->stkadj);
+               tregs = rte_regs(regs);
                pr_debug("Performing stackadjust=%04lx\n", regs->stkadj);
-               /* This must be copied with decreasing addresses to
-                   handle overlaps.  */
                tregs->vector = 0;
                tregs->format = 0;
-               tregs->pc = regs->pc;
                tregs->sr = regs->sr;
        }
+
+       /*
+        * Set up registers for signal handler.  All the state we are about
+        * to destroy is successfully copied to sigframe.
+        */
+       wrusp ((unsigned long) frame);
+       tregs->pc = (unsigned long) ksig->ka.sa.sa_handler;
+       adjustformat(regs);
+
        return 0;
 }
 
@@ -968,7 +941,8 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set,
                           struct pt_regs *regs)
 {
        struct rt_sigframe __user *frame;
-       int fsize = frame_extra_sizes(regs->format);
+       struct pt_regs *tregs = rte_regs(regs);
+       int fsize = frame_extra_sizes(tregs->format);
        int err = 0, sig = ksig->sig;
 
        if (fsize < 0) {
@@ -1018,34 +992,27 @@ static int setup_rt_frame(struct ksignal *ksig, sigset_t *set,
 
        push_cache ((unsigned long) &frame->retcode);
 
-       /*
-        * Set up registers for signal handler.  All the state we are about
-        * to destroy is successfully copied to sigframe.
-        */
-       wrusp ((unsigned long) frame);
-       regs->pc = (unsigned long) ksig->ka.sa.sa_handler;
-       adjustformat(regs);
-
        /*
         * This is subtle; if we build more than one sigframe, all but the
         * first one will see frame format 0 and have fsize == 0, so we won't
         * screw stkadj.
         */
-       if (fsize)
+       if (fsize) {
                regs->stkadj = fsize;
-
-       /* Prepare to skip over the extra stuff in the exception frame.  */
-       if (regs->stkadj) {
-               struct pt_regs *tregs =
-                       (struct pt_regs *)((ulong)regs + regs->stkadj);
+               tregs = rte_regs(regs);
                pr_debug("Performing stackadjust=%04lx\n", regs->stkadj);
-               /* This must be copied with decreasing addresses to
-                   handle overlaps.  */
                tregs->vector = 0;
                tregs->format = 0;
-               tregs->pc = regs->pc;
                tregs->sr = regs->sr;
        }
+
+       /*
+        * Set up registers for signal handler.  All the state we are about
+        * to destroy is successfully copied to sigframe.
+        */
+       wrusp ((unsigned long) frame);
+       tregs->pc = (unsigned long) ksig->ka.sa.sa_handler;
+       adjustformat(regs);
        return 0;
 }
 
index 5b19fcd..9718ce9 100644 (file)
@@ -181,9 +181,8 @@ static inline void access_error060 (struct frame *fp)
 static inline unsigned long probe040(int iswrite, unsigned long addr, int wbs)
 {
        unsigned long mmusr;
-       mm_segment_t old_fs = get_fs();
 
-       set_fs(MAKE_MM_SEG(wbs));
+       set_fc(wbs);
 
        if (iswrite)
                asm volatile (".chip 68040; ptestw (%0); .chip 68k" : : "a" (addr));
@@ -192,7 +191,7 @@ static inline unsigned long probe040(int iswrite, unsigned long addr, int wbs)
 
        asm volatile (".chip 68040; movec %%mmusr,%0; .chip 68k" : "=r" (mmusr));
 
-       set_fs(old_fs);
+       set_fc(USER_DATA);
 
        return mmusr;
 }
@@ -201,10 +200,8 @@ static inline int do_040writeback1(unsigned short wbs, unsigned long wba,
                                   unsigned long wbd)
 {
        int res = 0;
-       mm_segment_t old_fs = get_fs();
 
-       /* set_fs can not be moved, otherwise put_user() may oops */
-       set_fs(MAKE_MM_SEG(wbs));
+       set_fc(wbs);
 
        switch (wbs & WBSIZ_040) {
        case BA_SIZE_BYTE:
@@ -218,9 +215,7 @@ static inline int do_040writeback1(unsigned short wbs, unsigned long wba,
                break;
        }
 
-       /* set_fs can not be moved, otherwise put_user() may oops */
-       set_fs(old_fs);
-
+       set_fc(USER_DATA);
 
        pr_debug("do_040writeback1, res=%d\n", res);
 
index 90f4e9c..4fab347 100644 (file)
@@ -18,7 +18,6 @@
 
 #include <linux/uaccess.h>
 #include <asm/io.h>
-#include <asm/segment.h>
 #include <asm/setup.h>
 #include <asm/macintosh.h>
 #include <asm/mac_via.h>
index b486c08..dde978e 100644 (file)
@@ -49,24 +49,7 @@ static unsigned long virt_to_phys_slow(unsigned long vaddr)
                if (mmusr & MMU_R_040)
                        return (mmusr & PAGE_MASK) | (vaddr & ~PAGE_MASK);
        } else {
-               unsigned short mmusr;
-               unsigned long *descaddr;
-
-               asm volatile ("ptestr %3,%2@,#7,%0\n\t"
-                             "pmove %%psr,%1"
-                             : "=a&" (descaddr), "=m" (mmusr)
-                             : "a" (vaddr), "d" (get_fs().seg));
-               if (mmusr & (MMU_I|MMU_B|MMU_L))
-                       return 0;
-               descaddr = phys_to_virt((unsigned long)descaddr);
-               switch (mmusr & MMU_NUM) {
-               case 1:
-                       return (*descaddr & 0xfe000000) | (vaddr & 0x01ffffff);
-               case 2:
-                       return (*descaddr & 0xfffc0000) | (vaddr & 0x0003ffff);
-               case 3:
-                       return (*descaddr & PAGE_MASK) | (vaddr & ~PAGE_MASK);
-               }
+               WARN_ON_ONCE(!CPU_IS_040_OR_060);
        }
        return 0;
 }
@@ -107,11 +90,9 @@ void flush_icache_user_range(unsigned long address, unsigned long endaddr)
 
 void flush_icache_range(unsigned long address, unsigned long endaddr)
 {
-       mm_segment_t old_fs = get_fs();
-
-       set_fs(KERNEL_DS);
+       set_fc(SUPER_DATA);
        flush_icache_user_range(address, endaddr);
-       set_fs(old_fs);
+       set_fc(USER_DATA);
 }
 EXPORT_SYMBOL(flush_icache_range);
 
index 5d749e1..1b47bec 100644 (file)
@@ -72,12 +72,6 @@ void __init paging_init(void)
        if (!empty_zero_page)
                panic("%s: Failed to allocate %lu bytes align=0x%lx\n",
                      __func__, PAGE_SIZE, PAGE_SIZE);
-
-       /*
-        * Set up SFC/DFC registers (user data space).
-        */
-       set_fs (USER_DS);
-
        max_zone_pfn[ZONE_DMA] = end_mem >> PAGE_SHIFT;
        free_area_init(max_zone_pfn);
 }
index 1269d51..20ddf71 100644 (file)
@@ -17,7 +17,6 @@
 #include <linux/vmalloc.h>
 
 #include <asm/setup.h>
-#include <asm/segment.h>
 #include <asm/page.h>
 #include <asm/io.h>
 #include <asm/tlbflush.h>
index fe75aec..c2c03b0 100644 (file)
@@ -15,7 +15,6 @@
 #include <linux/gfp.h>
 
 #include <asm/setup.h>
-#include <asm/segment.h>
 #include <asm/page.h>
 #include <asm/traps.h>
 #include <asm/machdep.h>
index 3a653f0..9f3f777 100644 (file)
@@ -467,7 +467,7 @@ void __init paging_init(void)
        /*
         * Set up SFC/DFC registers
         */
-       set_fs(KERNEL_DS);
+       set_fc(USER_DATA);
 
 #ifdef DEBUG
        printk ("before free_area_init\n");
index e1e90c4..dfd6202 100644 (file)
@@ -171,7 +171,6 @@ static int bcd2int (unsigned char b)
 
 int mvme147_hwclk(int op, struct rtc_time *t)
 {
-#warning check me!
        if (!op) {
                m147_rtc->ctrl = RTC_READ;
                t->tm_year = bcd2int (m147_rtc->bcd_year);
@@ -183,6 +182,9 @@ int mvme147_hwclk(int op, struct rtc_time *t)
                m147_rtc->ctrl = 0;
                if (t->tm_year < 70)
                        t->tm_year += 100;
+       } else {
+               /* FIXME Setting the time is not yet supported */
+               return -EOPNOTSUPP;
        }
        return 0;
 }
index b59593c..b4422c2 100644 (file)
@@ -436,7 +436,6 @@ int bcd2int (unsigned char b)
 
 int mvme16x_hwclk(int op, struct rtc_time *t)
 {
-#warning check me!
        if (!op) {
                rtc->ctrl = RTC_READ;
                t->tm_year = bcd2int (rtc->bcd_year);
@@ -448,6 +447,9 @@ int mvme16x_hwclk(int op, struct rtc_time *t)
                rtc->ctrl = 0;
                if (t->tm_year < 70)
                        t->tm_year += 100;
+       } else {
+               /* FIXME Setting the time is not yet supported */
+               return -EOPNOTSUPP;
        }
        return 0;
 }
index f7dd472..203f428 100644 (file)
@@ -31,7 +31,6 @@
 #include <asm/intersil.h>
 #include <asm/irq.h>
 #include <asm/sections.h>
-#include <asm/segment.h>
 #include <asm/sun3ints.h>
 
 char sun3_reserved_pmeg[SUN3_PMEGS_NUM];
@@ -89,7 +88,7 @@ void __init sun3_init(void)
        sun3_reserved_pmeg[249] = 1;
        sun3_reserved_pmeg[252] = 1;
        sun3_reserved_pmeg[253] = 1;
-       set_fs(KERNEL_DS);
+       set_fc(USER_DATA);
 }
 
 /* Without this, Bad Things happen when something calls arch_reset. */
index 7aa879b..7ec2081 100644 (file)
@@ -23,7 +23,6 @@
 #include <linux/uaccess.h>
 #include <asm/page.h>
 #include <asm/sun3mmu.h>
-#include <asm/segment.h>
 #include <asm/oplib.h>
 #include <asm/mmu_context.h>
 #include <asm/dvma.h>
@@ -191,14 +190,13 @@ void __init mmu_emu_init(unsigned long bootmem_end)
        for(seg = 0; seg < PAGE_OFFSET; seg += SUN3_PMEG_SIZE)
                sun3_put_segmap(seg, SUN3_INVALID_PMEG);
 
-       set_fs(MAKE_MM_SEG(3));
+       set_fc(3);
        for(seg = 0; seg < 0x10000000; seg += SUN3_PMEG_SIZE) {
                i = sun3_get_segmap(seg);
                for(j = 1; j < CONTEXTS_NUM; j++)
                        (*(romvec->pv_setctxt))(j, (void *)seg, i);
        }
-       set_fs(KERNEL_DS);
-
+       set_fc(USER_DATA);
 }
 
 /* erase the mappings for a dead context.  Uses the pg_dir for hints
index 41ae422..36cc280 100644 (file)
@@ -11,7 +11,6 @@
 #include <linux/sched.h>
 #include <linux/kernel_stat.h>
 #include <linux/interrupt.h>
-#include <asm/segment.h>
 #include <asm/intersil.h>
 #include <asm/oplib.h>
 #include <asm/sun3ints.h>
index 74d2fe5..64c23bf 100644 (file)
@@ -14,7 +14,6 @@
 #include <asm/traps.h>
 #include <asm/sun3xprom.h>
 #include <asm/idprom.h>
-#include <asm/segment.h>
 #include <asm/sun3ints.h>
 #include <asm/openprom.h>
 #include <asm/machines.h>
index 771ca53..6b8f591 100644 (file)
@@ -3316,8 +3316,6 @@ source "drivers/cpuidle/Kconfig"
 
 endmenu
 
-source "drivers/firmware/Kconfig"
-
 source "arch/mips/kvm/Kconfig"
 
 source "arch/mips/vdso/Kconfig"
index 35fb8ee..fd43d87 100644 (file)
@@ -10,8 +10,6 @@
 #include <linux/io.h>
 #include <linux/types.h>
 
-#include <asm/mips-boards/launch.h>
-
 extern unsigned long __cps_access_bad_size(void)
        __compiletime_error("Bad size for CPS accessor");
 
@@ -167,30 +165,11 @@ static inline uint64_t mips_cps_cluster_config(unsigned int cluster)
  */
 static inline unsigned int mips_cps_numcores(unsigned int cluster)
 {
-       unsigned int ncores;
-
        if (!mips_cm_present())
                return 0;
 
        /* Add one before masking to handle 0xff indicating no cores */
-       ncores = (mips_cps_cluster_config(cluster) + 1) & CM_GCR_CONFIG_PCORES;
-
-       if (IS_ENABLED(CONFIG_SOC_MT7621)) {
-               struct cpulaunch *launch;
-
-               /*
-                * Ralink MT7621S SoC is single core, but the GCR_CONFIG method
-                * always reports 2 cores. Check the second core's LAUNCH_FREADY
-                * flag to detect if the second core is missing. This method
-                * only works before the core has been started.
-                */
-               launch = (struct cpulaunch *)CKSEG0ADDR(CPULAUNCH);
-               launch += 2; /* MT7621 has 2 VPEs per core */
-               if (!(launch->flags & LAUNCH_FREADY))
-                       ncores = 1;
-       }
-
-       return ncores;
+       return (mips_cps_cluster_config(cluster) + 1) & CM_GCR_CONFIG_PCORES;
 }
 
 /**
index f1e9851..c9b2a75 100644 (file)
@@ -906,10 +906,8 @@ asmlinkage void do_notify_resume(struct pt_regs *regs, void *unused,
        if (thread_info_flags & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
                do_signal(regs);
 
-       if (thread_info_flags & _TIF_NOTIFY_RESUME) {
+       if (thread_info_flags & _TIF_NOTIFY_RESUME)
                tracehook_notify_resume(regs);
-               rseq_handle_notify_resume(NULL, regs);
-       }
 
        user_enter();
 }
index 0af8862..cb6d224 100644 (file)
@@ -662,6 +662,11 @@ static void build_epilogue(struct jit_ctx *ctx)
        ((int)K < 0 ? ((int)K >= SKF_LL_OFF ? func##_negative : func) : \
         func##_positive)
 
+static bool is_bad_offset(int b_off)
+{
+       return b_off > 0x1ffff || b_off < -0x20000;
+}
+
 static int build_body(struct jit_ctx *ctx)
 {
        const struct bpf_prog *prog = ctx->skf;
@@ -728,7 +733,10 @@ load_common:
                        /* Load return register on DS for failures */
                        emit_reg_move(r_ret, r_zero, ctx);
                        /* Return with error */
-                       emit_b(b_imm(prog->len, ctx), ctx);
+                       b_off = b_imm(prog->len, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_b(b_off, ctx);
                        emit_nop(ctx);
                        break;
                case BPF_LD | BPF_W | BPF_IND:
@@ -775,8 +783,10 @@ load_ind:
                        emit_jalr(MIPS_R_RA, r_s0, ctx);
                        emit_reg_move(MIPS_R_A0, r_skb, ctx); /* delay slot */
                        /* Check the error value */
-                       emit_bcond(MIPS_COND_NE, r_ret, 0,
-                                  b_imm(prog->len, ctx), ctx);
+                       b_off = b_imm(prog->len, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_bcond(MIPS_COND_NE, r_ret, 0, b_off, ctx);
                        emit_reg_move(r_ret, r_zero, ctx);
                        /* We are good */
                        /* X <- P[1:K] & 0xf */
@@ -855,8 +865,10 @@ load_ind:
                        /* A /= X */
                        ctx->flags |= SEEN_X | SEEN_A;
                        /* Check if r_X is zero */
-                       emit_bcond(MIPS_COND_EQ, r_X, r_zero,
-                                  b_imm(prog->len, ctx), ctx);
+                       b_off = b_imm(prog->len, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_bcond(MIPS_COND_EQ, r_X, r_zero, b_off, ctx);
                        emit_load_imm(r_ret, 0, ctx); /* delay slot */
                        emit_div(r_A, r_X, ctx);
                        break;
@@ -864,8 +876,10 @@ load_ind:
                        /* A %= X */
                        ctx->flags |= SEEN_X | SEEN_A;
                        /* Check if r_X is zero */
-                       emit_bcond(MIPS_COND_EQ, r_X, r_zero,
-                                  b_imm(prog->len, ctx), ctx);
+                       b_off = b_imm(prog->len, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_bcond(MIPS_COND_EQ, r_X, r_zero, b_off, ctx);
                        emit_load_imm(r_ret, 0, ctx); /* delay slot */
                        emit_mod(r_A, r_X, ctx);
                        break;
@@ -926,7 +940,10 @@ load_ind:
                        break;
                case BPF_JMP | BPF_JA:
                        /* pc += K */
-                       emit_b(b_imm(i + k + 1, ctx), ctx);
+                       b_off = b_imm(i + k + 1, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_b(b_off, ctx);
                        emit_nop(ctx);
                        break;
                case BPF_JMP | BPF_JEQ | BPF_K:
@@ -1056,12 +1073,16 @@ jmp_cmp:
                        break;
                case BPF_RET | BPF_A:
                        ctx->flags |= SEEN_A;
-                       if (i != prog->len - 1)
+                       if (i != prog->len - 1) {
                                /*
                                 * If this is not the last instruction
                                 * then jump to the epilogue
                                 */
-                               emit_b(b_imm(prog->len, ctx), ctx);
+                               b_off = b_imm(prog->len, ctx);
+                               if (is_bad_offset(b_off))
+                                       return -E2BIG;
+                               emit_b(b_off, ctx);
+                       }
                        emit_reg_move(r_ret, r_A, ctx); /* delay slot */
                        break;
                case BPF_RET | BPF_K:
@@ -1075,7 +1096,10 @@ jmp_cmp:
                                 * If this is not the last instruction
                                 * then jump to the epilogue
                                 */
-                               emit_b(b_imm(prog->len, ctx), ctx);
+                               b_off = b_imm(prog->len, ctx);
+                               if (is_bad_offset(b_off))
+                                       return -E2BIG;
+                               emit_b(b_off, ctx);
                                emit_nop(ctx);
                        }
                        break;
@@ -1133,8 +1157,10 @@ jmp_cmp:
                        /* Load *dev pointer */
                        emit_load_ptr(r_s0, r_skb, off, ctx);
                        /* error (0) in the delay slot */
-                       emit_bcond(MIPS_COND_EQ, r_s0, r_zero,
-                                  b_imm(prog->len, ctx), ctx);
+                       b_off = b_imm(prog->len, ctx);
+                       if (is_bad_offset(b_off))
+                               return -E2BIG;
+                       emit_bcond(MIPS_COND_EQ, r_s0, r_zero, b_off, ctx);
                        emit_reg_move(r_ret, r_zero, ctx);
                        if (code == (BPF_ANC | SKF_AD_IFINDEX)) {
                                BUILD_BUG_ON(sizeof_field(struct net_device, ifindex) != 4);
@@ -1244,7 +1270,10 @@ void bpf_jit_compile(struct bpf_prog *fp)
 
        /* Generate the actual JIT code */
        build_prologue(&ctx);
-       build_body(&ctx);
+       if (build_body(&ctx)) {
+               module_memfree(ctx.target);
+               goto out;
+       }
        build_epilogue(&ctx);
 
        /* Update the icache */
index a8bc06e..ca1beb8 100644 (file)
@@ -3,9 +3,10 @@
 config EARLY_PRINTK
        bool "Activate early kernel debugging"
        default y
+       depends on TTY
        select SERIAL_CORE_CONSOLE
        help
-         Enable early printk on console
+         Enable early printk on console.
          This is useful for kernel debugging when your machine crashes very
          early before the console code is initialized.
          You should normally say N here, unless you want to debug such a crash.
index cf8d687..40bc8fb 100644 (file)
@@ -149,8 +149,6 @@ static void __init find_limits(unsigned long *min, unsigned long *max_low,
 
 void __init setup_arch(char **cmdline_p)
 {
-       int dram_start;
-
        console_verbose();
 
        memory_start = memblock_start_of_DRAM();
index 4742b6f..27a8b49 100644 (file)
@@ -384,6 +384,4 @@ config KEXEC_FILE
 
 endmenu
 
-source "drivers/firmware/Kconfig"
-
 source "drivers/parisc/Kconfig"
index d00313d..0561568 100644 (file)
@@ -184,7 +184,7 @@ extern int npmem_ranges;
 #include <asm-generic/getorder.h>
 #include <asm/pdc.h>
 
-#define PAGE0   ((struct zeropage *)__PAGE_OFFSET)
+#define PAGE0   ((struct zeropage *)absolute_pointer(__PAGE_OFFSET))
 
 /* DEFINITION OF THE ZERO-PAGE (PAG0) */
 /* based on work by Jason Eckhardt (jason@equator.com) */
index f03adb1..367f639 100644 (file)
@@ -513,12 +513,15 @@ void ioport_unmap(void __iomem *addr)
        }
 }
 
+#ifdef CONFIG_PCI
 void pci_iounmap(struct pci_dev *dev, void __iomem * addr)
 {
        if (!INDIRECT_ADDR(addr)) {
                iounmap(addr);
        }
 }
+EXPORT_SYMBOL(pci_iounmap);
+#endif
 
 EXPORT_SYMBOL(ioread8);
 EXPORT_SYMBOL(ioread16);
@@ -544,4 +547,3 @@ EXPORT_SYMBOL(iowrite16_rep);
 EXPORT_SYMBOL(iowrite32_rep);
 EXPORT_SYMBOL(ioport_map);
 EXPORT_SYMBOL(ioport_unmap);
-EXPORT_SYMBOL(pci_iounmap);
index 6900d0a..089ee3e 100644 (file)
@@ -35,7 +35,6 @@ endif
 BOOTCFLAGS    := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
                 -fno-strict-aliasing -O2 -msoft-float -mno-altivec -mno-vsx \
                 -pipe -fomit-frame-pointer -fno-builtin -fPIC -nostdinc \
-                -include $(srctree)/include/linux/compiler_attributes.h \
                 $(LINUXINCLUDE)
 
 ifdef CONFIG_PPC64_BOOT_WRAPPER
@@ -70,6 +69,7 @@ ifeq ($(call cc-option-yn, -fstack-protector),y)
 BOOTCFLAGS     += -fno-stack-protector
 endif
 
+BOOTCFLAGS     += -include $(srctree)/include/linux/compiler_attributes.h
 BOOTCFLAGS     += -I$(objtree)/$(obj) -I$(srctree)/$(obj)
 
 DTC_FLAGS      ?= -p 1024
index 5ba6fbf..f82f85c 100644 (file)
 
                        fm1mac3: ethernet@e4000 {
                                phy-handle = <&sgmii_aqr_phy3>;
-                               phy-connection-type = "sgmii-2500";
+                               phy-connection-type = "2500base-x";
                                sleep = <&rcpm 0x20000000>;
                        };
 
index 0ce2368..dbfa5e1 100644 (file)
 #  define ASM_CONST(x)         __ASM_CONST(x)
 #endif
 
-/*
- * Inline assembly memory constraint
- *
- * GCC 4.9 doesn't properly handle pre update memory constraint "m<>"
- *
- */
-#if defined(GCC_VERSION) && GCC_VERSION < 50000
-#define UPD_CONSTR ""
-#else
 #define UPD_CONSTR "<>"
-#endif
 
 #endif /* _ASM_POWERPC_ASM_CONST_H */
index d4b145b..9f38040 100644 (file)
@@ -136,6 +136,14 @@ static inline void kuap_kernel_restore(struct pt_regs *regs, unsigned long kuap)
        if (kuap_is_disabled())
                return;
 
+       if (unlikely(kuap != KUAP_NONE)) {
+               current->thread.kuap = KUAP_NONE;
+               kuap_lock(kuap, false);
+       }
+
+       if (likely(regs->kuap == KUAP_NONE))
+               return;
+
        current->thread.kuap = regs->kuap;
 
        kuap_unlock(regs->kuap, false);
index a95f637..4ba8345 100644 (file)
@@ -23,6 +23,7 @@
 #define BRANCH_ABSOLUTE        0x2
 
 bool is_offset_in_branch_range(long offset);
+bool is_offset_in_cond_branch_range(long offset);
 int create_branch(struct ppc_inst *instr, const u32 *addr,
                  unsigned long target, int flags);
 int create_cond_branch(struct ppc_inst *instr, const u32 *addr,
index 6b800d3..a1d2382 100644 (file)
@@ -265,13 +265,16 @@ static inline void interrupt_nmi_enter_prepare(struct pt_regs *regs, struct inte
        local_paca->irq_soft_mask = IRQS_ALL_DISABLED;
        local_paca->irq_happened |= PACA_IRQ_HARD_DIS;
 
-       if (is_implicit_soft_masked(regs)) {
-               // Adjust regs->softe soft implicit soft-mask, so
-               // arch_irq_disabled_regs(regs) behaves as expected.
+       if (!(regs->msr & MSR_EE) || is_implicit_soft_masked(regs)) {
+               /*
+                * Adjust regs->softe to be soft-masked if it had not been
+                * reconcied (e.g., interrupt entry with MSR[EE]=0 but softe
+                * not yet set disabled), or if it was in an implicit soft
+                * masked state. This makes arch_irq_disabled_regs(regs)
+                * behave as expected.
+                */
                regs->softe = IRQS_ALL_DISABLED;
        }
-       if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG))
-               BUG_ON(!arch_irq_disabled_regs(regs) && !(regs->msr & MSR_EE));
 
        /* Don't do any per-CPU operations until interrupt state is fixed */
 
@@ -525,10 +528,9 @@ static __always_inline long ____##func(struct pt_regs *regs)
 /* kernel/traps.c */
 DECLARE_INTERRUPT_HANDLER_NMI(system_reset_exception);
 #ifdef CONFIG_PPC_BOOK3S_64
-DECLARE_INTERRUPT_HANDLER_ASYNC(machine_check_exception);
-#else
-DECLARE_INTERRUPT_HANDLER_NMI(machine_check_exception);
+DECLARE_INTERRUPT_HANDLER_ASYNC(machine_check_exception_async);
 #endif
+DECLARE_INTERRUPT_HANDLER_NMI(machine_check_exception);
 DECLARE_INTERRUPT_HANDLER(SMIException);
 DECLARE_INTERRUPT_HANDLER(handle_hmi_exception);
 DECLARE_INTERRUPT_HANDLER(unknown_exception);
index 792eefa..27574f2 100644 (file)
@@ -39,6 +39,11 @@ static inline bool security_ftr_enabled(u64 feature)
        return !!(powerpc_security_features & feature);
 }
 
+#ifdef CONFIG_PPC_BOOK3S_64
+enum stf_barrier_type stf_barrier_type_get(void);
+#else
+static inline enum stf_barrier_type stf_barrier_type_get(void) { return STF_BARRIER_NONE; }
+#endif
 
 // Features indicating support for Spectre/Meltdown mitigations
 
index 111249f..038ce8d 100644 (file)
@@ -184,6 +184,15 @@ u64 dma_iommu_get_required_mask(struct device *dev)
        struct iommu_table *tbl = get_iommu_table_base(dev);
        u64 mask;
 
+       if (dev_is_pci(dev)) {
+               u64 bypass_mask = dma_direct_get_required_mask(dev);
+
+               if (dma_iommu_dma_supported(dev, bypass_mask)) {
+                       dev_info(dev, "%s: returning bypass mask 0x%llx\n", __func__, bypass_mask);
+                       return bypass_mask;
+               }
+       }
+
        if (!tbl)
                return 0;
 
index 37859e6..eaf1f72 100644 (file)
@@ -1243,7 +1243,7 @@ EXC_COMMON_BEGIN(machine_check_common)
        li      r10,MSR_RI
        mtmsrd  r10,1
        addi    r3,r1,STACK_FRAME_OVERHEAD
-       bl      machine_check_exception
+       bl      machine_check_exception_async
        b       interrupt_return_srr
 
 
@@ -1303,7 +1303,11 @@ END_FTR_SECTION_IFSET(CPU_FTR_HVMODE)
        subi    r12,r12,1
        sth     r12,PACA_IN_MCE(r13)
 
-       /* Invoke machine_check_exception to print MCE event and panic. */
+       /*
+        * Invoke machine_check_exception to print MCE event and panic.
+        * This is the NMI version of the handler because we are called from
+        * the early handler which is a true NMI.
+        */
        addi    r3,r1,STACK_FRAME_OVERHEAD
        bl      machine_check_exception
 
@@ -1665,27 +1669,30 @@ EXC_COMMON_BEGIN(program_check_common)
         */
 
        andi.   r10,r12,MSR_PR
-       bne     2f                      /* If userspace, go normal path */
+       bne     .Lnormal_stack          /* If userspace, go normal path */
 
        andis.  r10,r12,(SRR1_PROGTM)@h
-       bne     1f                      /* If TM, emergency             */
+       bne     .Lemergency_stack       /* If TM, emergency             */
 
        cmpdi   r1,-INT_FRAME_SIZE      /* check if r1 is in userspace  */
-       blt     2f                      /* normal path if not           */
+       blt     .Lnormal_stack          /* normal path if not           */
 
        /* Use the emergency stack                                      */
-1:     andi.   r10,r12,MSR_PR          /* Set CR0 correctly for label  */
+.Lemergency_stack:
+       andi.   r10,r12,MSR_PR          /* Set CR0 correctly for label  */
                                        /* 3 in EXCEPTION_PROLOG_COMMON */
        mr      r10,r1                  /* Save r1                      */
        ld      r1,PACAEMERGSP(r13)     /* Use emergency stack          */
        subi    r1,r1,INT_FRAME_SIZE    /* alloc stack frame            */
        __ISTACK(program_check)=0
        __GEN_COMMON_BODY program_check
-       b 3f
-2:
+       b .Ldo_program_check
+
+.Lnormal_stack:
        __ISTACK(program_check)=1
        __GEN_COMMON_BODY program_check
-3:
+
+.Ldo_program_check:
        addi    r3,r1,STACK_FRAME_OVERHEAD
        bl      program_check_exception
        REST_NVGPRS(r1) /* instruction emulation may change GPRs */
index a73f3f7..de10a26 100644 (file)
@@ -18,6 +18,7 @@
 #include <asm/switch_to.h>
 #include <asm/syscall.h>
 #include <asm/time.h>
+#include <asm/tm.h>
 #include <asm/unistd.h>
 
 #if defined(CONFIG_PPC_ADV_DEBUG_REGS) && defined(CONFIG_PPC32)
@@ -136,6 +137,48 @@ notrace long system_call_exception(long r3, long r4, long r5,
         */
        irq_soft_mask_regs_set_state(regs, IRQS_ENABLED);
 
+       /*
+        * If system call is called with TM active, set _TIF_RESTOREALL to
+        * prevent RFSCV being used to return to userspace, because POWER9
+        * TM implementation has problems with this instruction returning to
+        * transactional state. Final register values are not relevant because
+        * the transaction will be aborted upon return anyway. Or in the case
+        * of unsupported_scv SIGILL fault, the return state does not much
+        * matter because it's an edge case.
+        */
+       if (IS_ENABLED(CONFIG_PPC_TRANSACTIONAL_MEM) &&
+                       unlikely(MSR_TM_TRANSACTIONAL(regs->msr)))
+               current_thread_info()->flags |= _TIF_RESTOREALL;
+
+       /*
+        * If the system call was made with a transaction active, doom it and
+        * return without performing the system call. Unless it was an
+        * unsupported scv vector, in which case it's treated like an illegal
+        * instruction.
+        */
+#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
+       if (unlikely(MSR_TM_TRANSACTIONAL(regs->msr)) &&
+           !trap_is_unsupported_scv(regs)) {
+               /* Enable TM in the kernel, and disable EE (for scv) */
+               hard_irq_disable();
+               mtmsr(mfmsr() | MSR_TM);
+
+               /* tabort, this dooms the transaction, nothing else */
+               asm volatile(".long 0x7c00071d | ((%0) << 16)"
+                               :: "r"(TM_CAUSE_SYSCALL|TM_CAUSE_PERSISTENT));
+
+               /*
+                * Userspace will never see the return value. Execution will
+                * resume after the tbegin. of the aborted transaction with the
+                * checkpointed register state. A context switch could occur
+                * or signal delivered to the process before resuming the
+                * doomed transaction context, but that should all be handled
+                * as expected.
+                */
+               return -ENOSYS;
+       }
+#endif // CONFIG_PPC_TRANSACTIONAL_MEM
+
        local_irq_enable();
 
        if (unlikely(current_thread_info()->flags & _TIF_SYSCALL_DOTRACE)) {
index d4212d2..ec950b0 100644 (file)
@@ -12,7 +12,6 @@
 #include <asm/mmu.h>
 #include <asm/ppc_asm.h>
 #include <asm/ptrace.h>
-#include <asm/tm.h>
 
        .section        ".toc","aw"
 SYS_CALL_TABLE:
@@ -55,12 +54,6 @@ COMPAT_SYS_CALL_TABLE:
        .globl system_call_vectored_\name
 system_call_vectored_\name:
 _ASM_NOKPROBE_SYMBOL(system_call_vectored_\name)
-#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
-BEGIN_FTR_SECTION
-       extrdi. r10, r12, 1, (63-MSR_TS_T_LG) /* transaction active? */
-       bne     tabort_syscall
-END_FTR_SECTION_IFSET(CPU_FTR_TM)
-#endif
        SCV_INTERRUPT_TO_KERNEL
        mr      r10,r1
        ld      r1,PACAKSAVE(r13)
@@ -247,12 +240,6 @@ _ASM_NOKPROBE_SYMBOL(system_call_common_real)
        .globl system_call_common
 system_call_common:
 _ASM_NOKPROBE_SYMBOL(system_call_common)
-#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
-BEGIN_FTR_SECTION
-       extrdi. r10, r12, 1, (63-MSR_TS_T_LG) /* transaction active? */
-       bne     tabort_syscall
-END_FTR_SECTION_IFSET(CPU_FTR_TM)
-#endif
        mr      r10,r1
        ld      r1,PACAKSAVE(r13)
        std     r10,0(r1)
@@ -425,34 +412,6 @@ SOFT_MASK_TABLE(.Lsyscall_rst_start, 1b)
 RESTART_TABLE(.Lsyscall_rst_start, .Lsyscall_rst_end, syscall_restart)
 #endif
 
-#ifdef CONFIG_PPC_TRANSACTIONAL_MEM
-tabort_syscall:
-_ASM_NOKPROBE_SYMBOL(tabort_syscall)
-       /* Firstly we need to enable TM in the kernel */
-       mfmsr   r10
-       li      r9, 1
-       rldimi  r10, r9, MSR_TM_LG, 63-MSR_TM_LG
-       mtmsrd  r10, 0
-
-       /* tabort, this dooms the transaction, nothing else */
-       li      r9, (TM_CAUSE_SYSCALL|TM_CAUSE_PERSISTENT)
-       TABORT(R9)
-
-       /*
-        * Return directly to userspace. We have corrupted user register state,
-        * but userspace will never see that register state. Execution will
-        * resume after the tbegin of the aborted transaction with the
-        * checkpointed register state.
-        */
-       li      r9, MSR_RI
-       andc    r10, r10, r9
-       mtmsrd  r10, 1
-       mtspr   SPRN_SRR0, r11
-       mtspr   SPRN_SRR1, r12
-       RFI_TO_USER
-       b       .       /* prevent speculative execution */
-#endif
-
        /*
         * If MSR EE/RI was never enabled, IRQs not reconciled, NVGPRs not
         * touched, no exit work created, then this can be used.
index 551b653..c4f1d6b 100644 (file)
@@ -229,6 +229,9 @@ notrace void arch_local_irq_restore(unsigned long mask)
                return;
        }
 
+       if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG))
+               WARN_ON_ONCE(in_nmi() || in_hardirq());
+
        /*
         * After the stb, interrupts are unmasked and there are no interrupts
         * pending replay. The restart sequence makes this atomic with
@@ -321,6 +324,9 @@ notrace void arch_local_irq_restore(unsigned long mask)
        if (mask)
                return;
 
+       if (IS_ENABLED(CONFIG_PPC_IRQ_SOFT_MASK_DEBUG))
+               WARN_ON_ONCE(in_nmi() || in_hardirq());
+
        /*
         * From this point onward, we can take interrupts, preempt,
         * etc... unless we got hard-disabled. We check if an event
index 47a683c..fd829f7 100644 (file)
@@ -249,6 +249,7 @@ void machine_check_queue_event(void)
 {
        int index;
        struct machine_check_event evt;
+       unsigned long msr;
 
        if (!get_mce_event(&evt, MCE_EVENT_RELEASE))
                return;
@@ -262,8 +263,20 @@ void machine_check_queue_event(void)
        memcpy(&local_paca->mce_info->mce_event_queue[index],
               &evt, sizeof(evt));
 
-       /* Queue irq work to process this event later. */
-       irq_work_queue(&mce_event_process_work);
+       /*
+        * Queue irq work to process this event later. Before
+        * queuing the work enable translation for non radix LPAR,
+        * as irq_work_queue may try to access memory outside RMO
+        * region.
+        */
+       if (!radix_enabled() && firmware_has_feature(FW_FEATURE_LPAR)) {
+               msr = mfmsr();
+               mtmsr(msr | MSR_IR | MSR_DR);
+               irq_work_queue(&mce_event_process_work);
+               mtmsr(msr);
+       } else {
+               irq_work_queue(&mce_event_process_work);
+       }
 }
 
 void mce_common_process_ue(struct pt_regs *regs,
index 1a99849..15fb5ea 100644 (file)
@@ -263,6 +263,11 @@ static int __init handle_no_stf_barrier(char *p)
 
 early_param("no_stf_barrier", handle_no_stf_barrier);
 
+enum stf_barrier_type stf_barrier_type_get(void)
+{
+       return stf_enabled_flush_types;
+}
+
 /* This is the generic flag used by other architectures */
 static int __init handle_ssbd(char *p)
 {
index e600764..b93b87d 100644 (file)
@@ -293,10 +293,8 @@ void do_notify_resume(struct pt_regs *regs, unsigned long thread_info_flags)
                do_signal(current);
        }
 
-       if (thread_info_flags & _TIF_NOTIFY_RESUME) {
+       if (thread_info_flags & _TIF_NOTIFY_RESUME)
                tracehook_notify_resume(regs);
-               rseq_handle_notify_resume(NULL, regs);
-       }
 }
 
 static unsigned long get_tm_stackpointer(struct task_struct *tsk)
index aac8c04..1174170 100644 (file)
@@ -340,10 +340,16 @@ static bool exception_common(int signr, struct pt_regs *regs, int code,
                return false;
        }
 
-       show_signal_msg(signr, regs, code, addr);
+       /*
+        * Must not enable interrupts even for user-mode exception, because
+        * this can be called from machine check, which may be a NMI or IRQ
+        * which don't like interrupts being enabled. Could check for
+        * in_hardirq || in_nmi perhaps, but there doesn't seem to be a good
+        * reason why _exception() should enable irqs for an exception handler,
+        * the handlers themselves do that directly.
+        */
 
-       if (arch_irqs_disabled())
-               interrupt_cond_local_irq_enable(regs);
+       show_signal_msg(signr, regs, code, addr);
 
        current->thread.trap_nr = code;
 
@@ -790,24 +796,22 @@ void die_mce(const char *str, struct pt_regs *regs, long err)
         * do_exit() checks for in_interrupt() and panics in that case, so
         * exit the irq/nmi before calling die.
         */
-       if (IS_ENABLED(CONFIG_PPC_BOOK3S_64))
-               irq_exit();
-       else
+       if (in_nmi())
                nmi_exit();
+       else
+               irq_exit();
        die(str, regs, err);
 }
 
 /*
- * BOOK3S_64 does not call this handler as a non-maskable interrupt
+ * BOOK3S_64 does not usually call this handler as a non-maskable interrupt
  * (it uses its own early real-mode handler to handle the MCE proper
  * and then raises irq_work to call this handler when interrupts are
- * enabled).
+ * enabled). The only time when this is not true is if the early handler
+ * is unrecoverable, then it does call this directly to try to get a
+ * message out.
  */
-#ifdef CONFIG_PPC_BOOK3S_64
-DEFINE_INTERRUPT_HANDLER_ASYNC(machine_check_exception)
-#else
-DEFINE_INTERRUPT_HANDLER_NMI(machine_check_exception)
-#endif
+static void __machine_check_exception(struct pt_regs *regs)
 {
        int recover = 0;
 
@@ -841,12 +845,19 @@ bail:
        /* Must die if the interrupt is not recoverable */
        if (regs_is_unrecoverable(regs))
                die_mce("Unrecoverable Machine check", regs, SIGBUS);
+}
 
 #ifdef CONFIG_PPC_BOOK3S_64
-       return;
-#else
-       return 0;
+DEFINE_INTERRUPT_HANDLER_ASYNC(machine_check_exception_async)
+{
+       __machine_check_exception(regs);
+}
 #endif
+DEFINE_INTERRUPT_HANDLER_NMI(machine_check_exception)
+{
+       __machine_check_exception(regs);
+
+       return 0;
 }
 
 DEFINE_INTERRUPT_HANDLER(SMIException) /* async? */
index 7507939..eb776d0 100644 (file)
@@ -255,13 +255,16 @@ kvm_novcpu_exit:
  * r3 contains the SRR1 wakeup value, SRR1 is trashed.
  */
 _GLOBAL(idle_kvm_start_guest)
-       ld      r4,PACAEMERGSP(r13)
        mfcr    r5
        mflr    r0
-       std     r1,0(r4)
-       std     r5,8(r4)
-       std     r0,16(r4)
-       subi    r1,r4,STACK_FRAME_OVERHEAD
+       std     r5, 8(r1)       // Save CR in caller's frame
+       std     r0, 16(r1)      // Save LR in caller's frame
+       // Create frame on emergency stack
+       ld      r4, PACAEMERGSP(r13)
+       stdu    r1, -SWITCH_FRAME_SIZE(r4)
+       // Switch to new frame on emergency stack
+       mr      r1, r4
+       std     r3, 32(r1)      // Save SRR1 wakeup value
        SAVE_NVGPRS(r1)
 
        /*
@@ -313,6 +316,10 @@ kvm_unsplit_wakeup:
 
 kvm_secondary_got_guest:
 
+       // About to go to guest, clear saved SRR1
+       li      r0, 0
+       std     r0, 32(r1)
+
        /* Set HSTATE_DSCR(r13) to something sensible */
        ld      r6, PACA_DSCR_DEFAULT(r13)
        std     r6, HSTATE_DSCR(r13)
@@ -392,13 +399,12 @@ kvm_no_guest:
        mfspr   r4, SPRN_LPCR
        rlwimi  r4, r3, 0, LPCR_PECE0 | LPCR_PECE1
        mtspr   SPRN_LPCR, r4
-       /* set up r3 for return */
-       mfspr   r3,SPRN_SRR1
+       // Return SRR1 wakeup value, or 0 if we went into the guest
+       ld      r3, 32(r1)
        REST_NVGPRS(r1)
-       addi    r1, r1, STACK_FRAME_OVERHEAD
-       ld      r0, 16(r1)
-       ld      r5, 8(r1)
-       ld      r1, 0(r1)
+       ld      r1, 0(r1)       // Switch back to caller stack
+       ld      r0, 16(r1)      // Reload LR
+       ld      r5, 8(r1)       // Reload CR
        mtlr    r0
        mtcr    r5
        blr
@@ -2536,7 +2542,7 @@ END_FTR_SECTION_IFCLR(CPU_FTR_P9_TM_HV_ASSIST)
        /* The following code handles the fake_suspend = 1 case */
        mflr    r0
        std     r0, PPC_LR_STKOFF(r1)
-       stdu    r1, -PPC_MIN_STKFRM(r1)
+       stdu    r1, -TM_FRAME_SIZE(r1)
 
        /* Turn on TM. */
        mfmsr   r8
@@ -2551,10 +2557,42 @@ BEGIN_FTR_SECTION
 END_FTR_SECTION_IFSET(CPU_FTR_P9_TM_XER_SO_BUG)
        nop
 
+       /*
+        * It's possible that treclaim. may modify registers, if we have lost
+        * track of fake-suspend state in the guest due to it using rfscv.
+        * Save and restore registers in case this occurs.
+        */
+       mfspr   r3, SPRN_DSCR
+       mfspr   r4, SPRN_XER
+       mfspr   r5, SPRN_AMR
+       /* SPRN_TAR would need to be saved here if the kernel ever used it */
+       mfcr    r12
+       SAVE_NVGPRS(r1)
+       SAVE_GPR(2, r1)
+       SAVE_GPR(3, r1)
+       SAVE_GPR(4, r1)
+       SAVE_GPR(5, r1)
+       stw     r12, 8(r1)
+       std     r1, HSTATE_HOST_R1(r13)
+
        /* We have to treclaim here because that's the only way to do S->N */
        li      r3, TM_CAUSE_KVM_RESCHED
        TRECLAIM(R3)
 
+       GET_PACA(r13)
+       ld      r1, HSTATE_HOST_R1(r13)
+       REST_GPR(2, r1)
+       REST_GPR(3, r1)
+       REST_GPR(4, r1)
+       REST_GPR(5, r1)
+       lwz     r12, 8(r1)
+       REST_NVGPRS(r1)
+       mtspr   SPRN_DSCR, r3
+       mtspr   SPRN_XER, r4
+       mtspr   SPRN_AMR, r5
+       mtcr    r12
+       HMT_MEDIUM
+
        /*
         * We were in fake suspend, so we are not going to save the
         * register state as the guest checkpointed state (since
@@ -2582,7 +2620,7 @@ END_FTR_SECTION_IFSET(CPU_FTR_P9_TM_XER_SO_BUG)
        std     r5, VCPU_TFHAR(r9)
        std     r6, VCPU_TFIAR(r9)
 
-       addi    r1, r1, PPC_MIN_STKFRM
+       addi    r1, r1, TM_FRAME_SIZE
        ld      r0, PPC_LR_STKOFF(r1)
        mtlr    r0
        blr
index f9a3019..c5ed988 100644 (file)
@@ -228,6 +228,11 @@ bool is_offset_in_branch_range(long offset)
        return (offset >= -0x2000000 && offset <= 0x1fffffc && !(offset & 0x3));
 }
 
+bool is_offset_in_cond_branch_range(long offset)
+{
+       return offset >= -0x8000 && offset <= 0x7fff && !(offset & 0x3);
+}
+
 /*
  * Helper to check if a given instruction is a conditional branch
  * Derived from the conditional checks in analyse_instr()
@@ -280,7 +285,7 @@ int create_cond_branch(struct ppc_inst *instr, const u32 *addr,
                offset = offset - (unsigned long)addr;
 
        /* Check we can represent the target in the instruction format */
-       if (offset < -0x8000 || offset > 0x7FFF || offset & 0x3)
+       if (!is_offset_in_cond_branch_range(offset))
                return 1;
 
        /* Mask out the flags and target, so they don't step on each other. */
index 99fad09..7e9b978 100644 (file)
 #define EMIT(instr)            PLANT_INSTR(image, ctx->idx, instr)
 
 /* Long jump; (unconditional 'branch') */
-#define PPC_JMP(dest)          EMIT(PPC_INST_BRANCH |                        \
-                                    (((dest) - (ctx->idx * 4)) & 0x03fffffc))
+#define PPC_JMP(dest)                                                        \
+       do {                                                                  \
+               long offset = (long)(dest) - (ctx->idx * 4);                  \
+               if (!is_offset_in_branch_range(offset)) {                     \
+                       pr_err_ratelimited("Branch offset 0x%lx (@%u) out of range\n", offset, ctx->idx);                       \
+                       return -ERANGE;                                       \
+               }                                                             \
+               EMIT(PPC_INST_BRANCH | (offset & 0x03fffffc));                \
+       } while (0)
+
 /* blr; (unconditional 'branch' with link) to absolute address */
 #define PPC_BL_ABS(dest)       EMIT(PPC_INST_BL |                            \
                                     (((dest) - (unsigned long)(image + ctx->idx)) & 0x03fffffc))
 /* "cond" here covers BO:BI fields. */
-#define PPC_BCC_SHORT(cond, dest)      EMIT(PPC_INST_BRANCH_COND |           \
-                                            (((cond) & 0x3ff) << 16) |       \
-                                            (((dest) - (ctx->idx * 4)) &     \
-                                             0xfffc))
+#define PPC_BCC_SHORT(cond, dest)                                            \
+       do {                                                                  \
+               long offset = (long)(dest) - (ctx->idx * 4);                  \
+               if (!is_offset_in_cond_branch_range(offset)) {                \
+                       pr_err_ratelimited("Conditional branch offset 0x%lx (@%u) out of range\n", offset, ctx->idx);           \
+                       return -ERANGE;                                       \
+               }                                                             \
+               EMIT(PPC_INST_BRANCH_COND | (((cond) & 0x3ff) << 16) | (offset & 0xfffc));                                      \
+       } while (0)
+
 /* Sign-extended 32-bit immediate load */
 #define PPC_LI32(d, i)         do {                                          \
                if ((int)(uintptr_t)(i) >= -32768 &&                          \
 #define PPC_FUNC_ADDR(d,i) do { PPC_LI32(d, i); } while(0)
 #endif
 
-static inline bool is_nearbranch(int offset)
-{
-       return (offset < 32768) && (offset >= -32768);
-}
-
 /*
  * The fly in the ointment of code size changing from pass to pass is
  * avoided by padding the short branch case with a NOP.         If code size differs
@@ -91,7 +100,7 @@ static inline bool is_nearbranch(int offset)
  * state.
  */
 #define PPC_BCC(cond, dest)    do {                                          \
-               if (is_nearbranch((dest) - (ctx->idx * 4))) {                 \
+               if (is_offset_in_cond_branch_range((long)(dest) - (ctx->idx * 4))) {    \
                        PPC_BCC_SHORT(cond, dest);                            \
                        EMIT(PPC_RAW_NOP());                                  \
                } else {                                                      \
index 7b713ed..b63b35e 100644 (file)
  * with our redzone usage.
  *
  *             [       prev sp         ] <-------------
- *             [   nv gpr save area    ] 6*8           |
+ *             [   nv gpr save area    ] 5*8           |
  *             [    tail_call_cnt      ] 8             |
- *             [    local_tmp_var      ]             |
+ *             [    local_tmp_var      ] 16            |
  * fp (r31) -->        [   ebpf stack space    ] upto 512      |
  *             [     frame header      ] 32/112        |
  * sp (r1) --->        [    stack pointer      ] --------------
  */
 
 /* for gpr non volatile registers BPG_REG_6 to 10 */
-#define BPF_PPC_STACK_SAVE     (6*8)
+#define BPF_PPC_STACK_SAVE     (5*8)
 /* for bpf JIT code internal usage */
-#define BPF_PPC_STACK_LOCALS   16
+#define BPF_PPC_STACK_LOCALS   24
 /* stack frame excluding BPF stack, ensure this is quadword aligned */
 #define BPF_PPC_STACKFRAME     (STACK_FRAME_MIN_SIZE + \
                                 BPF_PPC_STACK_LOCALS + BPF_PPC_STACK_SAVE)
index 53aefee..fcbf7a9 100644 (file)
@@ -210,7 +210,11 @@ skip_init_ctx:
                /* Now build the prologue, body code & epilogue for real. */
                cgctx.idx = 0;
                bpf_jit_build_prologue(code_base, &cgctx);
-               bpf_jit_build_body(fp, code_base, &cgctx, addrs, extra_pass);
+               if (bpf_jit_build_body(fp, code_base, &cgctx, addrs, extra_pass)) {
+                       bpf_jit_binary_free(bpf_hdr);
+                       fp = org_fp;
+                       goto out_addrs;
+               }
                bpf_jit_build_epilogue(code_base, &cgctx);
 
                if (bpf_jit_enable > 1)
index beb12cb..0da31d4 100644 (file)
@@ -200,7 +200,7 @@ void bpf_jit_emit_func_call_rel(u32 *image, struct codegen_context *ctx, u64 fun
        }
 }
 
-static void bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32 out)
+static int bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32 out)
 {
        /*
         * By now, the eBPF program has already setup parameters in r3-r6
@@ -261,7 +261,9 @@ static void bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32
        bpf_jit_emit_common_epilogue(image, ctx);
 
        EMIT(PPC_RAW_BCTR());
+
        /* out: */
+       return 0;
 }
 
 /* Assemble the body code between the prologue & epilogue */
@@ -355,7 +357,7 @@ int bpf_jit_build_body(struct bpf_prog *fp, u32 *image, struct codegen_context *
                                PPC_LI32(_R0, imm);
                                EMIT(PPC_RAW_ADDC(dst_reg, dst_reg, _R0));
                        }
-                       if (imm >= 0)
+                       if (imm >= 0 || (BPF_OP(code) == BPF_SUB && imm == 0x80000000))
                                EMIT(PPC_RAW_ADDZE(dst_reg_h, dst_reg_h));
                        else
                                EMIT(PPC_RAW_ADDME(dst_reg_h, dst_reg_h));
@@ -623,7 +625,7 @@ int bpf_jit_build_body(struct bpf_prog *fp, u32 *image, struct codegen_context *
                        EMIT(PPC_RAW_LI(dst_reg_h, 0));
                        break;
                case BPF_ALU | BPF_ARSH | BPF_X: /* (s32) dst >>= src */
-                       EMIT(PPC_RAW_SRAW(dst_reg_h, dst_reg, src_reg));
+                       EMIT(PPC_RAW_SRAW(dst_reg, dst_reg, src_reg));
                        break;
                case BPF_ALU64 | BPF_ARSH | BPF_X: /* (s64) dst >>= src */
                        bpf_set_seen_register(ctx, tmp_reg);
@@ -1073,7 +1075,7 @@ cond_branch:
                                break;
                        case BPF_JMP32 | BPF_JSET | BPF_K:
                                /* andi does not sign-extend the immediate */
-                               if (imm >= -32768 && imm < 32768) {
+                               if (imm >= 0 && imm < 32768) {
                                        /* PPC_ANDI is _only/always_ dot-form */
                                        EMIT(PPC_RAW_ANDI(_R0, dst_reg, imm));
                                } else {
@@ -1090,7 +1092,9 @@ cond_branch:
                 */
                case BPF_JMP | BPF_TAIL_CALL:
                        ctx->seen |= SEEN_TAILCALL;
-                       bpf_jit_emit_tail_call(image, ctx, addrs[i + 1]);
+                       ret = bpf_jit_emit_tail_call(image, ctx, addrs[i + 1]);
+                       if (ret < 0)
+                               return ret;
                        break;
 
                default:
@@ -1103,7 +1107,7 @@ cond_branch:
                        return -EOPNOTSUPP;
                }
                if (BPF_CLASS(code) == BPF_ALU && !fp->aux->verifier_zext &&
-                   !insn_is_zext(&insn[i + 1]))
+                   !insn_is_zext(&insn[i + 1]) && !(BPF_OP(code) == BPF_END && imm == 64))
                        EMIT(PPC_RAW_LI(dst_reg_h, 0));
        }
 
index b87a63d..8b5157c 100644 (file)
@@ -15,6 +15,7 @@
 #include <linux/if_vlan.h>
 #include <asm/kprobes.h>
 #include <linux/bpf.h>
+#include <asm/security_features.h>
 
 #include "bpf_jit64.h"
 
@@ -35,9 +36,9 @@ static inline bool bpf_has_stack_frame(struct codegen_context *ctx)
  *             [       prev sp         ] <-------------
  *             [         ...           ]               |
  * sp (r1) --->        [    stack pointer      ] --------------
- *             [   nv gpr save area    ] 6*8
+ *             [   nv gpr save area    ] 5*8
  *             [    tail_call_cnt      ] 8
- *             [    local_tmp_var      ] 8
+ *             [    local_tmp_var      ] 16
  *             [   unused red zone     ] 208 bytes protected
  */
 static int bpf_jit_stack_local(struct codegen_context *ctx)
@@ -45,12 +46,12 @@ static int bpf_jit_stack_local(struct codegen_context *ctx)
        if (bpf_has_stack_frame(ctx))
                return STACK_FRAME_MIN_SIZE + ctx->stack_size;
        else
-               return -(BPF_PPC_STACK_SAVE + 16);
+               return -(BPF_PPC_STACK_SAVE + 24);
 }
 
 static int bpf_jit_stack_tailcallcnt(struct codegen_context *ctx)
 {
-       return bpf_jit_stack_local(ctx) + 8;
+       return bpf_jit_stack_local(ctx) + 16;
 }
 
 static int bpf_jit_stack_offsetof(struct codegen_context *ctx, int reg)
@@ -206,7 +207,7 @@ void bpf_jit_emit_func_call_rel(u32 *image, struct codegen_context *ctx, u64 fun
        EMIT(PPC_RAW_BCTRL());
 }
 
-static void bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32 out)
+static int bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32 out)
 {
        /*
         * By now, the eBPF program has already setup parameters in r3, r4 and r5
@@ -267,13 +268,38 @@ static void bpf_jit_emit_tail_call(u32 *image, struct codegen_context *ctx, u32
        bpf_jit_emit_common_epilogue(image, ctx);
 
        EMIT(PPC_RAW_BCTR());
+
        /* out: */
+       return 0;
 }
 
+/*
+ * We spill into the redzone always, even if the bpf program has its own stackframe.
+ * Offsets hardcoded based on BPF_PPC_STACK_SAVE -- see bpf_jit_stack_local()
+ */
+void bpf_stf_barrier(void);
+
+asm (
+"              .global bpf_stf_barrier         ;"
+"      bpf_stf_barrier:                        ;"
+"              std     21,-64(1)               ;"
+"              std     22,-56(1)               ;"
+"              sync                            ;"
+"              ld      21,-64(1)               ;"
+"              ld      22,-56(1)               ;"
+"              ori     31,31,0                 ;"
+"              .rept 14                        ;"
+"              b       1f                      ;"
+"      1:                                      ;"
+"              .endr                           ;"
+"              blr                             ;"
+);
+
 /* Assemble the body code between the prologue & epilogue */
 int bpf_jit_build_body(struct bpf_prog *fp, u32 *image, struct codegen_context *ctx,
                       u32 *addrs, bool extra_pass)
 {
+       enum stf_barrier_type stf_barrier = stf_barrier_type_get();
        const struct bpf_insn *insn = fp->insnsi;
        int flen = fp->len;
        int i, ret;
@@ -328,18 +354,25 @@ int bpf_jit_build_body(struct bpf_prog *fp, u32 *image, struct codegen_context *
                        EMIT(PPC_RAW_SUB(dst_reg, dst_reg, src_reg));
                        goto bpf_alu32_trunc;
                case BPF_ALU | BPF_ADD | BPF_K: /* (u32) dst += (u32) imm */
-               case BPF_ALU | BPF_SUB | BPF_K: /* (u32) dst -= (u32) imm */
                case BPF_ALU64 | BPF_ADD | BPF_K: /* dst += imm */
+                       if (!imm) {
+                               goto bpf_alu32_trunc;
+                       } else if (imm >= -32768 && imm < 32768) {
+                               EMIT(PPC_RAW_ADDI(dst_reg, dst_reg, IMM_L(imm)));
+                       } else {
+                               PPC_LI32(b2p[TMP_REG_1], imm);
+                               EMIT(PPC_RAW_ADD(dst_reg, dst_reg, b2p[TMP_REG_1]));
+                       }
+                       goto bpf_alu32_trunc;
+               case BPF_ALU | BPF_SUB | BPF_K: /* (u32) dst -= (u32) imm */
                case BPF_ALU64 | BPF_SUB | BPF_K: /* dst -= imm */
-                       if (BPF_OP(code) == BPF_SUB)
-                               imm = -imm;
-                       if (imm) {
-                               if (imm >= -32768 && imm < 32768)
-                                       EMIT(PPC_RAW_ADDI(dst_reg, dst_reg, IMM_L(imm)));
-                               else {
-                                       PPC_LI32(b2p[TMP_REG_1], imm);
-                                       EMIT(PPC_RAW_ADD(dst_reg, dst_reg, b2p[TMP_REG_1]));
-                               }
+                       if (!imm) {
+                               goto bpf_alu32_trunc;
+                       } else if (imm > -32768 && imm <= 32768) {
+                               EMIT(PPC_RAW_ADDI(dst_reg, dst_reg, IMM_L(-imm)));
+                       } else {
+                               PPC_LI32(b2p[TMP_REG_1], imm);
+                               EMIT(PPC_RAW_SUB(dst_reg, dst_reg, b2p[TMP_REG_1]));
                        }
                        goto bpf_alu32_trunc;
                case BPF_ALU | BPF_MUL | BPF_X: /* (u32) dst *= (u32) src */
@@ -389,8 +422,14 @@ int bpf_jit_build_body(struct bpf_prog *fp, u32 *image, struct codegen_context *
                case BPF_ALU64 | BPF_DIV | BPF_K: /* dst /= imm */
                        if (imm == 0)
                                return -EINVAL;
-                       else if (imm == 1)
-                               goto bpf_alu32_trunc;
+                       if (imm == 1) {
+                               if (BPF_OP(code) == BPF_DIV) {
+                                       goto bpf_alu32_trunc;
+                               } else {
+                                       EMIT(PPC_RAW_LI(dst_reg, 0));
+                                       break;
+                               }
+                       }
 
                        PPC_LI32(b2p[TMP_REG_1], imm);
                        switch (BPF_CLASS(code)) {
@@ -631,6 +670,29 @@ emit_clear:
                 * BPF_ST NOSPEC (speculation barrier)
                 */
                case BPF_ST | BPF_NOSPEC:
+                       if (!security_ftr_enabled(SEC_FTR_FAVOUR_SECURITY) ||
+                                       !security_ftr_enabled(SEC_FTR_STF_BARRIER))
+                               break;
+
+                       switch (stf_barrier) {
+                       case STF_BARRIER_EIEIO:
+                               EMIT(PPC_RAW_EIEIO() | 0x02000000);
+                               break;
+                       case STF_BARRIER_SYNC_ORI:
+                               EMIT(PPC_RAW_SYNC());
+                               EMIT(PPC_RAW_LD(b2p[TMP_REG_1], _R13, 0));
+                               EMIT(PPC_RAW_ORI(_R31, _R31, 0));
+                               break;
+                       case STF_BARRIER_FALLBACK:
+                               EMIT(PPC_RAW_MFLR(b2p[TMP_REG_1]));
+                               PPC_LI64(12, dereference_kernel_function_descriptor(bpf_stf_barrier));
+                               EMIT(PPC_RAW_MTCTR(12));
+                               EMIT(PPC_RAW_BCTRL());
+                               EMIT(PPC_RAW_MTLR(b2p[TMP_REG_1]));
+                               break;
+                       case STF_BARRIER_NONE:
+                               break;
+                       }
                        break;
 
                /*
@@ -993,7 +1055,9 @@ cond_branch:
                 */
                case BPF_JMP | BPF_TAIL_CALL:
                        ctx->seen |= SEEN_TAILCALL;
-                       bpf_jit_emit_tail_call(image, ctx, addrs[i + 1]);
+                       ret = bpf_jit_emit_tail_call(image, ctx, addrs[i + 1]);
+                       if (ret < 0)
+                               return ret;
                        break;
 
                default:
index bc15200..09fafcf 100644 (file)
@@ -867,6 +867,10 @@ static int __init eeh_pseries_init(void)
        if (is_kdump_kernel() || reset_devices) {
                pr_info("Issue PHB reset ...\n");
                list_for_each_entry(phb, &hose_list, list_node) {
+                       // Skip if the slot is empty
+                       if (list_empty(&PCI_DN(phb->dn)->child_list))
+                               continue;
+
                        pdn = list_first_entry(&PCI_DN(phb->dn)->child_list, struct pci_dn, list);
                        config_addr = pseries_eeh_get_pe_config_addr(pdn);
 
index 1b305e4..8627362 100644 (file)
@@ -507,12 +507,27 @@ static void pseries_msi_unmask(struct irq_data *d)
        irq_chip_unmask_parent(d);
 }
 
+static void pseries_msi_write_msg(struct irq_data *data, struct msi_msg *msg)
+{
+       struct msi_desc *entry = irq_data_get_msi_desc(data);
+
+       /*
+        * Do not update the MSIx vector table. It's not strictly necessary
+        * because the table is initialized by the underlying hypervisor, PowerVM
+        * or QEMU/KVM. However, if the MSIx vector entry is cleared, any further
+        * activation will fail. This can happen in some drivers (eg. IPR) which
+        * deactivate an IRQ used for testing MSI support.
+        */
+       entry->msg = *msg;
+}
+
 static struct irq_chip pseries_pci_msi_irq_chip = {
        .name           = "pSeries-PCI-MSI",
        .irq_shutdown   = pseries_msi_shutdown,
        .irq_mask       = pseries_msi_mask,
        .irq_unmask     = pseries_msi_unmask,
        .irq_eoi        = irq_chip_eoi_parent,
+       .irq_write_msi_msg      = pseries_msi_write_msg,
 };
 
 static struct msi_domain_info pseries_msi_domain_info = {
index 5c1a157..244a727 100644 (file)
@@ -348,9 +348,9 @@ static int xics_host_map(struct irq_domain *domain, unsigned int virq,
        if (xics_ics->check(xics_ics, hwirq))
                return -EINVAL;
 
-       /* No chip data for the XICS domain */
+       /* Let the ICS be the chip data for the XICS domain. For ICS native */
        irq_domain_set_info(domain, virq, hwirq, xics_ics->chip,
-                           NULL, handle_fasteoi_irq, NULL, NULL);
+                           xics_ics, handle_fasteoi_irq, NULL, NULL);
 
        return 0;
 }
index c732ce5..c5d75c0 100644 (file)
@@ -945,7 +945,8 @@ static int xive_get_irqchip_state(struct irq_data *data,
                 * interrupt to be inactive in that case.
                 */
                *state = (pq != XIVE_ESB_INVALID) && !xd->stale_p &&
-                       (xd->saved_p || !!(pq & XIVE_ESB_VAL_P));
+                       (xd->saved_p || (!!(pq & XIVE_ESB_VAL_P) &&
+                        !irqd_irq_disabled(data)));
                return 0;
        default:
                return -EINVAL;
index c3f3fd5..6a6fa9e 100644 (file)
@@ -236,7 +236,7 @@ config ARCH_RV32I
 config ARCH_RV64I
        bool "RV64I"
        select 64BIT
-       select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 && GCC_VERSION >= 50000
+       select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
        select HAVE_DYNAMIC_FTRACE if !XIP_KERNEL && MMU && $(cc-option,-fpatchable-function-entry=8)
        select HAVE_DYNAMIC_FTRACE_WITH_REGS if HAVE_DYNAMIC_FTRACE
        select HAVE_FTRACE_MCOUNT_RECORD if !XIP_KERNEL
@@ -561,5 +561,3 @@ menu "Power management options"
 source "kernel/power/Kconfig"
 
 endmenu
-
-source "drivers/firmware/Kconfig"
index b933b15..34fbb3e 100644 (file)
@@ -82,4 +82,5 @@ static inline int syscall_get_arch(struct task_struct *task)
 #endif
 }
 
+asmlinkage long sys_riscv_flush_icache(uintptr_t, uintptr_t, uintptr_t);
 #endif /* _ASM_RISCV_SYSCALL_H */
index 893e471..208e31b 100644 (file)
 #ifdef CONFIG_MMU
 
 #include <linux/types.h>
-#include <generated/vdso-offsets.h>
+/*
+ * All systems with an MMU have a VDSO, but systems without an MMU don't
+ * support shared libraries and therefor don't have one.
+ */
+#ifdef CONFIG_MMU
+
+#define __VVAR_PAGES    1
 
-#ifndef CONFIG_GENERIC_TIME_VSYSCALL
-struct vdso_data {
-};
-#endif
+#ifndef __ASSEMBLY__
+#include <generated/vdso-offsets.h>
 
 #define VDSO_SYMBOL(base, name)                                                        \
        (void __user *)((unsigned long)(base) + __vdso_##name##_offset)
 
 #endif /* CONFIG_MMU */
 
-asmlinkage long sys_riscv_flush_icache(uintptr_t, uintptr_t, uintptr_t);
+#endif /* !__ASSEMBLY__ */
+
+#endif /* CONFIG_MMU */
 
 #endif /* _ASM_RISCV_VDSO_H */
index 4b989ae..8062996 100644 (file)
 #ifdef __LP64__
 #define __ARCH_WANT_NEW_STAT
 #define __ARCH_WANT_SET_GET_RLIMIT
-#define __ARCH_WANT_SYS_CLONE3
 #endif /* __LP64__ */
 
+#define __ARCH_WANT_SYS_CLONE3
+
 #include <asm-generic/unistd.h>
 
 /*
index a63c667..44b1420 100644 (file)
@@ -7,7 +7,6 @@
 #include <linux/linkage.h>
 #include <linux/syscalls.h>
 #include <asm-generic/syscalls.h>
-#include <asm/vdso.h>
 #include <asm/syscall.h>
 
 #undef __SYSCALL
index 25a3b88..b70956d 100644 (file)
 #include <linux/binfmts.h>
 #include <linux/err.h>
 #include <asm/page.h>
+#include <asm/vdso.h>
+
 #ifdef CONFIG_GENERIC_TIME_VSYSCALL
 #include <vdso/datapage.h>
 #else
-#include <asm/vdso.h>
+struct vdso_data {
+};
 #endif
 
 extern char vdso_start[], vdso_end[];
 
+enum vvar_pages {
+       VVAR_DATA_PAGE_OFFSET,
+       VVAR_NR_PAGES,
+};
+
+#define VVAR_SIZE  (VVAR_NR_PAGES << PAGE_SHIFT)
+
 static unsigned int vdso_pages __ro_after_init;
 static struct page **vdso_pagelist __ro_after_init;
 
@@ -38,7 +48,7 @@ static int __init vdso_init(void)
 
        vdso_pages = (vdso_end - vdso_start) >> PAGE_SHIFT;
        vdso_pagelist =
-               kcalloc(vdso_pages + 1, sizeof(struct page *), GFP_KERNEL);
+               kcalloc(vdso_pages + VVAR_NR_PAGES, sizeof(struct page *), GFP_KERNEL);
        if (unlikely(vdso_pagelist == NULL)) {
                pr_err("vdso: pagelist allocation failed\n");
                return -ENOMEM;
@@ -63,38 +73,41 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
        unsigned long vdso_base, vdso_len;
        int ret;
 
-       vdso_len = (vdso_pages + 1) << PAGE_SHIFT;
+       BUILD_BUG_ON(VVAR_NR_PAGES != __VVAR_PAGES);
+
+       vdso_len = (vdso_pages + VVAR_NR_PAGES) << PAGE_SHIFT;
+
+       if (mmap_write_lock_killable(mm))
+               return -EINTR;
 
-       mmap_write_lock(mm);
        vdso_base = get_unmapped_area(NULL, 0, vdso_len, 0, 0);
        if (IS_ERR_VALUE(vdso_base)) {
                ret = vdso_base;
                goto end;
        }
 
-       /*
-        * Put vDSO base into mm struct. We need to do this before calling
-        * install_special_mapping or the perf counter mmap tracking code
-        * will fail to recognise it as a vDSO (since arch_vma_name fails).
-        */
-       mm->context.vdso = (void *)vdso_base;
+       mm->context.vdso = NULL;
+       ret = install_special_mapping(mm, vdso_base, VVAR_SIZE,
+               (VM_READ | VM_MAYREAD), &vdso_pagelist[vdso_pages]);
+       if (unlikely(ret))
+               goto end;
 
        ret =
-          install_special_mapping(mm, vdso_base, vdso_pages << PAGE_SHIFT,
+          install_special_mapping(mm, vdso_base + VVAR_SIZE,
+               vdso_pages << PAGE_SHIFT,
                (VM_READ | VM_EXEC | VM_MAYREAD | VM_MAYWRITE | VM_MAYEXEC),
                vdso_pagelist);
 
-       if (unlikely(ret)) {
-               mm->context.vdso = NULL;
+       if (unlikely(ret))
                goto end;
-       }
 
-       vdso_base += (vdso_pages << PAGE_SHIFT);
-       ret = install_special_mapping(mm, vdso_base, PAGE_SIZE,
-               (VM_READ | VM_MAYREAD), &vdso_pagelist[vdso_pages]);
+       /*
+        * Put vDSO base into mm struct. We need to do this before calling
+        * install_special_mapping or the perf counter mmap tracking code
+        * will fail to recognise it as a vDSO (since arch_vma_name fails).
+        */
+       mm->context.vdso = (void *)vdso_base + VVAR_SIZE;
 
-       if (unlikely(ret))
-               mm->context.vdso = NULL;
 end:
        mmap_write_unlock(mm);
        return ret;
@@ -105,7 +118,7 @@ const char *arch_vma_name(struct vm_area_struct *vma)
        if (vma->vm_mm && (vma->vm_start == (long)vma->vm_mm->context.vdso))
                return "[vdso]";
        if (vma->vm_mm && (vma->vm_start ==
-                          (long)vma->vm_mm->context.vdso + PAGE_SIZE))
+                          (long)vma->vm_mm->context.vdso - VVAR_SIZE))
                return "[vdso_data]";
        return NULL;
 }
index e6f558b..e9111f7 100644 (file)
@@ -3,12 +3,13 @@
  * Copyright (C) 2012 Regents of the University of California
  */
 #include <asm/page.h>
+#include <asm/vdso.h>
 
 OUTPUT_ARCH(riscv)
 
 SECTIONS
 {
-       PROVIDE(_vdso_data = . + PAGE_SIZE);
+       PROVIDE(_vdso_data = . - __VVAR_PAGES * PAGE_SIZE);
        . = SIZEOF_HEADERS;
 
        .hash           : { *(.hash) }                  :text
index 0941186..89f8106 100644 (file)
@@ -16,6 +16,8 @@ static void ipi_remote_fence_i(void *info)
 
 void flush_icache_all(void)
 {
+       local_flush_icache_all();
+
        if (IS_ENABLED(CONFIG_RISCV_SBI))
                sbi_remote_fence_i(NULL);
        else
index 2bd90c5..b86de61 100644 (file)
@@ -685,16 +685,6 @@ config STACK_GUARD
          The minimum size for the stack guard should be 256 for 31 bit and
          512 for 64 bit.
 
-config WARN_DYNAMIC_STACK
-       def_bool n
-       prompt "Emit compiler warnings for function with dynamic stack usage"
-       help
-         This option enables the compiler option -mwarn-dynamicstack. If the
-         compiler supports this options generates warnings for functions
-         that dynamically allocate stack space using alloca.
-
-         Say N if you are unsure.
-
 endmenu
 
 menu "I/O subsystem"
index a3cf33a..450b351 100644 (file)
@@ -85,13 +85,6 @@ cflags-$(CONFIG_CHECK_STACK) += -mstack-guard=$(CONFIG_STACK_GUARD)
 endif
 endif
 
-ifdef CONFIG_WARN_DYNAMIC_STACK
-  ifneq ($(call cc-option,-mwarn-dynamicstack),)
-    KBUILD_CFLAGS += -mwarn-dynamicstack
-    KBUILD_CFLAGS_DECOMPRESSOR += -mwarn-dynamicstack
-  endif
-endif
-
 ifdef CONFIG_EXPOLINE
   ifneq ($(call cc-option,$(CC_FLAGS_MARCH) -mindirect-branch=thunk),)
     CC_FLAGS_EXPOLINE := -mindirect-branch=thunk
index 37b6115..6aad18e 100644 (file)
@@ -10,6 +10,7 @@ CONFIG_BPF_JIT=y
 CONFIG_BPF_JIT_ALWAYS_ON=y
 CONFIG_BPF_LSM=y
 CONFIG_PREEMPT=y
+CONFIG_SCHED_CORE=y
 CONFIG_BSD_PROCESS_ACCT=y
 CONFIG_BSD_PROCESS_ACCT_V3=y
 CONFIG_TASKSTATS=y
@@ -503,6 +504,7 @@ CONFIG_NLMON=m
 # CONFIG_NET_VENDOR_HUAWEI is not set
 # CONFIG_NET_VENDOR_INTEL is not set
 # CONFIG_NET_VENDOR_MICROSOFT is not set
+# CONFIG_NET_VENDOR_LITEX is not set
 # CONFIG_NET_VENDOR_MARVELL is not set
 CONFIG_MLX4_EN=m
 CONFIG_MLX5_CORE=m
@@ -661,7 +663,6 @@ CONFIG_NFSD_V3_ACL=y
 CONFIG_NFSD_V4=y
 CONFIG_NFSD_V4_SECURITY_LABEL=y
 CONFIG_CIFS=m
-CONFIG_CIFS_WEAK_PW_HASH=y
 CONFIG_CIFS_UPCALL=y
 CONFIG_CIFS_XATTR=y
 CONFIG_CIFS_POSIX=y
@@ -720,6 +721,8 @@ CONFIG_CRYPTO_XCBC=m
 CONFIG_CRYPTO_VMAC=m
 CONFIG_CRYPTO_CRC32=m
 CONFIG_CRYPTO_BLAKE2S=m
+CONFIG_CRYPTO_MD4=m
+CONFIG_CRYPTO_MD5=y
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_RMD160=m
 CONFIG_CRYPTO_SHA3=m
@@ -774,7 +777,6 @@ CONFIG_RANDOM32_SELFTEST=y
 CONFIG_DMA_CMA=y
 CONFIG_CMA_SIZE_MBYTES=0
 CONFIG_DMA_API_DEBUG=y
-CONFIG_STRING_SELFTEST=y
 CONFIG_PRINTK_TIME=y
 CONFIG_DYNAMIC_DEBUG=y
 CONFIG_DEBUG_INFO=y
@@ -853,12 +855,12 @@ CONFIG_FAIL_FUNCTION=y
 CONFIG_FAULT_INJECTION_STACKTRACE_FILTER=y
 CONFIG_LKDTM=m
 CONFIG_TEST_MIN_HEAP=y
-CONFIG_TEST_SORT=y
 CONFIG_KPROBES_SANITY_TEST=y
 CONFIG_RBTREE_TEST=y
 CONFIG_INTERVAL_TREE_TEST=m
 CONFIG_PERCPU_TEST=m
 CONFIG_ATOMIC64_SELFTEST=y
+CONFIG_STRING_SELFTEST=y
 CONFIG_TEST_BITOPS=m
 CONFIG_TEST_BPF=m
 CONFIG_TEST_LIVEPATCH=m
index 56a1cc8..f08b161 100644 (file)
@@ -8,6 +8,7 @@ CONFIG_BPF_SYSCALL=y
 CONFIG_BPF_JIT=y
 CONFIG_BPF_JIT_ALWAYS_ON=y
 CONFIG_BPF_LSM=y
+CONFIG_SCHED_CORE=y
 CONFIG_BSD_PROCESS_ACCT=y
 CONFIG_BSD_PROCESS_ACCT_V3=y
 CONFIG_TASKSTATS=y
@@ -494,6 +495,7 @@ CONFIG_NLMON=m
 # CONFIG_NET_VENDOR_HUAWEI is not set
 # CONFIG_NET_VENDOR_INTEL is not set
 # CONFIG_NET_VENDOR_MICROSOFT is not set
+# CONFIG_NET_VENDOR_LITEX is not set
 # CONFIG_NET_VENDOR_MARVELL is not set
 CONFIG_MLX4_EN=m
 CONFIG_MLX5_CORE=m
@@ -648,7 +650,6 @@ CONFIG_NFSD_V3_ACL=y
 CONFIG_NFSD_V4=y
 CONFIG_NFSD_V4_SECURITY_LABEL=y
 CONFIG_CIFS=m
-CONFIG_CIFS_WEAK_PW_HASH=y
 CONFIG_CIFS_UPCALL=y
 CONFIG_CIFS_XATTR=y
 CONFIG_CIFS_POSIX=y
@@ -708,6 +709,8 @@ CONFIG_CRYPTO_XCBC=m
 CONFIG_CRYPTO_VMAC=m
 CONFIG_CRYPTO_CRC32=m
 CONFIG_CRYPTO_BLAKE2S=m
+CONFIG_CRYPTO_MD4=m
+CONFIG_CRYPTO_MD5=y
 CONFIG_CRYPTO_MICHAEL_MIC=m
 CONFIG_CRYPTO_RMD160=m
 CONFIG_CRYPTO_SHA3=m
index 36dbf50..aa995d9 100644 (file)
@@ -55,7 +55,7 @@ int ccwgroup_create_dev(struct device *root, struct ccwgroup_driver *gdrv,
                        int num_devices, const char *buf);
 
 extern int ccwgroup_set_online(struct ccwgroup_device *gdev);
-extern int ccwgroup_set_offline(struct ccwgroup_device *gdev);
+int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv);
 
 extern int ccwgroup_probe_ccwdev(struct ccw_device *cdev);
 extern void ccwgroup_remove_ccwdev(struct ccw_device *cdev);
index e4803ec..6b3c366 100644 (file)
@@ -207,6 +207,8 @@ int zpci_enable_device(struct zpci_dev *);
 int zpci_disable_device(struct zpci_dev *);
 int zpci_scan_configured_device(struct zpci_dev *zdev, u32 fh);
 int zpci_deconfigure_device(struct zpci_dev *zdev);
+void zpci_device_reserved(struct zpci_dev *zdev);
+bool zpci_is_device_configured(struct zpci_dev *zdev);
 
 int zpci_register_ioat(struct zpci_dev *, u8, u64, u64, u64);
 int zpci_unregister_ioat(struct zpci_dev *, u8);
index 16256e1..1072245 100644 (file)
@@ -419,13 +419,13 @@ static unsigned long deliverable_irqs(struct kvm_vcpu *vcpu)
 static void __set_cpu_idle(struct kvm_vcpu *vcpu)
 {
        kvm_s390_set_cpuflags(vcpu, CPUSTAT_WAIT);
-       set_bit(kvm_vcpu_get_idx(vcpu), vcpu->kvm->arch.idle_mask);
+       set_bit(vcpu->vcpu_idx, vcpu->kvm->arch.idle_mask);
 }
 
 static void __unset_cpu_idle(struct kvm_vcpu *vcpu)
 {
        kvm_s390_clear_cpuflags(vcpu, CPUSTAT_WAIT);
-       clear_bit(kvm_vcpu_get_idx(vcpu), vcpu->kvm->arch.idle_mask);
+       clear_bit(vcpu->vcpu_idx, vcpu->kvm->arch.idle_mask);
 }
 
 static void __reset_intercept_indicators(struct kvm_vcpu *vcpu)
index 752a0ff..6a6dd5e 100644 (file)
@@ -4066,7 +4066,7 @@ static int vcpu_pre_run(struct kvm_vcpu *vcpu)
                kvm_s390_patch_guest_per_regs(vcpu);
        }
 
-       clear_bit(kvm_vcpu_get_idx(vcpu), vcpu->kvm->arch.gisa_int.kicked_mask);
+       clear_bit(vcpu->vcpu_idx, vcpu->kvm->arch.gisa_int.kicked_mask);
 
        vcpu->arch.sie_block->icptcode = 0;
        cpuflags = atomic_read(&vcpu->arch.sie_block->cpuflags);
index ecd741e..52bc8fb 100644 (file)
@@ -79,7 +79,7 @@ static inline int is_vcpu_stopped(struct kvm_vcpu *vcpu)
 
 static inline int is_vcpu_idle(struct kvm_vcpu *vcpu)
 {
-       return test_bit(kvm_vcpu_get_idx(vcpu), vcpu->kvm->arch.idle_mask);
+       return test_bit(vcpu->vcpu_idx, vcpu->kvm->arch.idle_mask);
 }
 
 static inline int kvm_is_ucontrol(struct kvm *kvm)
index cfcdf76..a95ca6d 100644 (file)
@@ -259,14 +259,13 @@ EXPORT_SYMBOL(strcmp);
 #ifdef __HAVE_ARCH_STRRCHR
 char *strrchr(const char *s, int c)
 {
-       size_t len = __strend(s) - s;
-
-       if (len)
-              do {
-                      if (s[len] == (char) c)
-                              return (char *) s + len;
-              } while (--len > 0);
-       return NULL;
+       ssize_t len = __strend(s) - s;
+
+       do {
+               if (s[len] == (char)c)
+                       return (char *)s + len;
+       } while (--len >= 0);
+       return NULL;
 }
 EXPORT_SYMBOL(strrchr);
 #endif
index 8841926..1a374d0 100644 (file)
@@ -248,8 +248,7 @@ static inline void reg_set_seen(struct bpf_jit *jit, u32 b1)
 
 #define EMIT6_PCREL(op1, op2, b1, b2, i, off, mask)            \
 ({                                                             \
-       /* Branch instruction needs 6 bytes */                  \
-       int rel = (addrs[(i) + (off) + 1] - (addrs[(i) + 1] - 6)) / 2;\
+       int rel = (addrs[(i) + (off) + 1] - jit->prg) / 2;      \
        _EMIT6((op1) | reg(b1, b2) << 16 | (rel & 0xffff), (op2) | (mask));\
        REG_SET_SEEN(b1);                                       \
        REG_SET_SEEN(b2);                                       \
@@ -761,10 +760,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT4(0xb9080000, dst_reg, src_reg);
                break;
        case BPF_ALU | BPF_ADD | BPF_K: /* dst = (u32) dst + (u32) imm */
-               if (!imm)
-                       break;
-               /* alfi %dst,imm */
-               EMIT6_IMM(0xc20b0000, dst_reg, imm);
+               if (imm != 0) {
+                       /* alfi %dst,imm */
+                       EMIT6_IMM(0xc20b0000, dst_reg, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_ADD | BPF_K: /* dst = dst + imm */
@@ -786,17 +785,22 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT4(0xb9090000, dst_reg, src_reg);
                break;
        case BPF_ALU | BPF_SUB | BPF_K: /* dst = (u32) dst - (u32) imm */
-               if (!imm)
-                       break;
-               /* alfi %dst,-imm */
-               EMIT6_IMM(0xc20b0000, dst_reg, -imm);
+               if (imm != 0) {
+                       /* alfi %dst,-imm */
+                       EMIT6_IMM(0xc20b0000, dst_reg, -imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_SUB | BPF_K: /* dst = dst - imm */
                if (!imm)
                        break;
-               /* agfi %dst,-imm */
-               EMIT6_IMM(0xc2080000, dst_reg, -imm);
+               if (imm == -0x80000000) {
+                       /* algfi %dst,0x80000000 */
+                       EMIT6_IMM(0xc20a0000, dst_reg, 0x80000000);
+               } else {
+                       /* agfi %dst,-imm */
+                       EMIT6_IMM(0xc2080000, dst_reg, -imm);
+               }
                break;
        /*
         * BPF_MUL
@@ -811,10 +815,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT4(0xb90c0000, dst_reg, src_reg);
                break;
        case BPF_ALU | BPF_MUL | BPF_K: /* dst = (u32) dst * (u32) imm */
-               if (imm == 1)
-                       break;
-               /* msfi %r5,imm */
-               EMIT6_IMM(0xc2010000, dst_reg, imm);
+               if (imm != 1) {
+                       /* msfi %r5,imm */
+                       EMIT6_IMM(0xc2010000, dst_reg, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_MUL | BPF_K: /* dst = dst * imm */
@@ -867,6 +871,8 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                        if (BPF_OP(insn->code) == BPF_MOD)
                                /* lhgi %dst,0 */
                                EMIT4_IMM(0xa7090000, dst_reg, 0);
+                       else
+                               EMIT_ZERO(dst_reg);
                        break;
                }
                /* lhi %w0,0 */
@@ -999,10 +1005,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT4(0xb9820000, dst_reg, src_reg);
                break;
        case BPF_ALU | BPF_XOR | BPF_K: /* dst = (u32) dst ^ (u32) imm */
-               if (!imm)
-                       break;
-               /* xilf %dst,imm */
-               EMIT6_IMM(0xc0070000, dst_reg, imm);
+               if (imm != 0) {
+                       /* xilf %dst,imm */
+                       EMIT6_IMM(0xc0070000, dst_reg, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_XOR | BPF_K: /* dst = dst ^ imm */
@@ -1033,10 +1039,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT6_DISP_LH(0xeb000000, 0x000d, dst_reg, dst_reg, src_reg, 0);
                break;
        case BPF_ALU | BPF_LSH | BPF_K: /* dst = (u32) dst << (u32) imm */
-               if (imm == 0)
-                       break;
-               /* sll %dst,imm(%r0) */
-               EMIT4_DISP(0x89000000, dst_reg, REG_0, imm);
+               if (imm != 0) {
+                       /* sll %dst,imm(%r0) */
+                       EMIT4_DISP(0x89000000, dst_reg, REG_0, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_LSH | BPF_K: /* dst = dst << imm */
@@ -1058,10 +1064,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT6_DISP_LH(0xeb000000, 0x000c, dst_reg, dst_reg, src_reg, 0);
                break;
        case BPF_ALU | BPF_RSH | BPF_K: /* dst = (u32) dst >> (u32) imm */
-               if (imm == 0)
-                       break;
-               /* srl %dst,imm(%r0) */
-               EMIT4_DISP(0x88000000, dst_reg, REG_0, imm);
+               if (imm != 0) {
+                       /* srl %dst,imm(%r0) */
+                       EMIT4_DISP(0x88000000, dst_reg, REG_0, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_RSH | BPF_K: /* dst = dst >> imm */
@@ -1083,10 +1089,10 @@ static noinline int bpf_jit_insn(struct bpf_jit *jit, struct bpf_prog *fp,
                EMIT6_DISP_LH(0xeb000000, 0x000a, dst_reg, dst_reg, src_reg, 0);
                break;
        case BPF_ALU | BPF_ARSH | BPF_K: /* ((s32) dst >> imm */
-               if (imm == 0)
-                       break;
-               /* sra %dst,imm(%r0) */
-               EMIT4_DISP(0x8a000000, dst_reg, REG_0, imm);
+               if (imm != 0) {
+                       /* sra %dst,imm(%r0) */
+                       EMIT4_DISP(0x8a000000, dst_reg, REG_0, imm);
+               }
                EMIT_ZERO(dst_reg);
                break;
        case BPF_ALU64 | BPF_ARSH | BPF_K: /* ((s64) dst) >>= imm */
@@ -1820,7 +1826,7 @@ struct bpf_prog *bpf_int_jit_compile(struct bpf_prog *fp)
        jit.addrs = kvcalloc(fp->len + 1, sizeof(*jit.addrs), GFP_KERNEL);
        if (jit.addrs == NULL) {
                fp = orig_fp;
-               goto out;
+               goto free_addrs;
        }
        /*
         * Three initial passes:
index e7e6788..b833155 100644 (file)
@@ -92,7 +92,7 @@ void zpci_remove_reserved_devices(void)
        spin_unlock(&zpci_list_lock);
 
        list_for_each_entry_safe(zdev, tmp, &remove, entry)
-               zpci_zdev_put(zdev);
+               zpci_device_reserved(zdev);
 }
 
 int pci_domain_nr(struct pci_bus *bus)
@@ -751,6 +751,14 @@ error:
        return ERR_PTR(rc);
 }
 
+bool zpci_is_device_configured(struct zpci_dev *zdev)
+{
+       enum zpci_state state = zdev->state;
+
+       return state != ZPCI_FN_STATE_RESERVED &&
+               state != ZPCI_FN_STATE_STANDBY;
+}
+
 /**
  * zpci_scan_configured_device() - Scan a freshly configured zpci_dev
  * @zdev: The zpci_dev to be configured
@@ -822,6 +830,31 @@ int zpci_deconfigure_device(struct zpci_dev *zdev)
        return 0;
 }
 
+/**
+ * zpci_device_reserved() - Mark device as resverved
+ * @zdev: the zpci_dev that was reserved
+ *
+ * Handle the case that a given zPCI function was reserved by another system.
+ * After a call to this function the zpci_dev can not be found via
+ * get_zdev_by_fid() anymore but may still be accessible via existing
+ * references though it will not be functional anymore.
+ */
+void zpci_device_reserved(struct zpci_dev *zdev)
+{
+       if (zdev->has_hp_slot)
+               zpci_exit_slot(zdev);
+       /*
+        * Remove device from zpci_list as it is going away. This also
+        * makes sure we ignore subsequent zPCI events for this device.
+        */
+       spin_lock(&zpci_list_lock);
+       list_del(&zdev->entry);
+       spin_unlock(&zpci_list_lock);
+       zdev->state = ZPCI_FN_STATE_RESERVED;
+       zpci_dbg(3, "rsv fid:%x\n", zdev->fid);
+       zpci_zdev_put(zdev);
+}
+
 void zpci_release_device(struct kref *kref)
 {
        struct zpci_dev *zdev = container_of(kref, struct zpci_dev, kref);
@@ -843,6 +876,12 @@ void zpci_release_device(struct kref *kref)
        case ZPCI_FN_STATE_STANDBY:
                if (zdev->has_hp_slot)
                        zpci_exit_slot(zdev);
+               spin_lock(&zpci_list_lock);
+               list_del(&zdev->entry);
+               spin_unlock(&zpci_list_lock);
+               zpci_dbg(3, "rsv fid:%x\n", zdev->fid);
+               fallthrough;
+       case ZPCI_FN_STATE_RESERVED:
                if (zdev->has_resources)
                        zpci_cleanup_bus_resources(zdev);
                zpci_bus_device_unregister(zdev);
@@ -851,10 +890,6 @@ void zpci_release_device(struct kref *kref)
        default:
                break;
        }
-
-       spin_lock(&zpci_list_lock);
-       list_del(&zdev->entry);
-       spin_unlock(&zpci_list_lock);
        zpci_dbg(3, "rem fid:%x\n", zdev->fid);
        kfree(zdev);
 }
index c856f80..5b8d647 100644 (file)
@@ -140,7 +140,7 @@ static void __zpci_event_availability(struct zpci_ccdf_avail *ccdf)
                        /* The 0x0304 event may immediately reserve the device */
                        if (!clp_get_state(zdev->fid, &state) &&
                            state == ZPCI_FN_STATE_RESERVED) {
-                               zpci_zdev_put(zdev);
+                               zpci_device_reserved(zdev);
                        }
                }
                break;
@@ -151,7 +151,7 @@ static void __zpci_event_availability(struct zpci_ccdf_avail *ccdf)
        case 0x0308: /* Standby -> Reserved */
                if (!zdev)
                        break;
-               zpci_zdev_put(zdev);
+               zpci_device_reserved(zdev);
                break;
        default:
                break;
index ae683aa..c5b35ea 100644 (file)
@@ -159,7 +159,7 @@ SYSCALL_DEFINE3(s390_pci_mmio_write, unsigned long, mmio_addr,
 
        mmap_read_lock(current->mm);
        ret = -EINVAL;
-       vma = find_vma(current->mm, mmio_addr);
+       vma = vma_lookup(current->mm, mmio_addr);
        if (!vma)
                goto out_unlock_mmap;
        if (!(vma->vm_flags & (VM_IO | VM_PFNMAP)))
@@ -298,7 +298,7 @@ SYSCALL_DEFINE3(s390_pci_mmio_read, unsigned long, mmio_addr,
 
        mmap_read_lock(current->mm);
        ret = -EINVAL;
-       vma = find_vma(current->mm, mmio_addr);
+       vma = vma_lookup(current->mm, mmio_addr);
        if (!vma)
                goto out_unlock_mmap;
        if (!(vma->vm_flags & (VM_IO | VM_PFNMAP)))
index bab91a9..97c5703 100644 (file)
@@ -886,7 +886,7 @@ static struct asoc_simple_card_info fsi_da7210_info = {
        .card           = "FSIB-DA7210",
        .codec          = "da7210.0-001a",
        .platform       = "sh_fsi.0",
-       .daifmt         = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM,
+       .daifmt         = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBP_CFP,
        .cpu_dai = {
                .name   = "fsib-dai",
        },
index 8d6541b..d9b31d4 100644 (file)
@@ -305,7 +305,7 @@ static struct asoc_simple_card_info fsi_ak4642_info = {
        .card           = "FSIA-AK4642",
        .codec          = "ak4642-codec.0-0012",
        .platform       = "sh_fsi.0",
-       .daifmt         = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM,
+       .daifmt         = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBP_CFP,
        .cpu_dai = {
                .name   = "fsia-dai",
        },
index 58592df..c081e7e 100644 (file)
@@ -80,30 +80,30 @@ $(obj)/vmlinux.bin.xz: $(obj)/vmlinux.bin FORCE
 $(obj)/vmlinux.bin.lzo: $(obj)/vmlinux.bin FORCE
        $(call if_changed,lzo)
 
-$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2
+$(obj)/uImage.bz2: $(obj)/vmlinux.bin.bz2 FORCE
        $(call if_changed,uimage,bzip2)
 
-$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz
+$(obj)/uImage.gz: $(obj)/vmlinux.bin.gz FORCE
        $(call if_changed,uimage,gzip)
 
-$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma
+$(obj)/uImage.lzma: $(obj)/vmlinux.bin.lzma FORCE
        $(call if_changed,uimage,lzma)
 
-$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz
+$(obj)/uImage.xz: $(obj)/vmlinux.bin.xz FORCE
        $(call if_changed,uimage,xz)
 
-$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo
+$(obj)/uImage.lzo: $(obj)/vmlinux.bin.lzo FORCE
        $(call if_changed,uimage,lzo)
 
-$(obj)/uImage.bin: $(obj)/vmlinux.bin
+$(obj)/uImage.bin: $(obj)/vmlinux.bin FORCE
        $(call if_changed,uimage,none)
 
 OBJCOPYFLAGS_vmlinux.srec := -I binary -O srec
-$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux
+$(obj)/vmlinux.srec: $(obj)/compressed/vmlinux FORCE
        $(call if_changed,objcopy)
 
 OBJCOPYFLAGS_uImage.srec := -I binary -O srec
-$(obj)/uImage.srec: $(obj)/uImage
+$(obj)/uImage.srec: $(obj)/uImage FORCE
        $(call if_changed,objcopy)
 
 $(obj)/uImage: $(obj)/uImage.$(suffix-y)
index 56bf35c..cdced80 100644 (file)
@@ -34,7 +34,7 @@ typedef struct { unsigned long long pmd; } pmd_t;
 
 static inline pmd_t *pud_pgtable(pud_t pud)
 {
-       return (pmd_t *)pud_val(pud);
+       return (pmd_t *)(unsigned long)pud_val(pud);
 }
 
 /* only used by the stubbed out hugetlb gup code, should never be called */
index 8e1d72a..7ceae24 100644 (file)
@@ -356,7 +356,9 @@ err_nomem:
 void arch_dma_free(struct device *dev, size_t size, void *cpu_addr,
                dma_addr_t dma_addr, unsigned long attrs)
 {
-       if (!sparc_dma_free_resource(cpu_addr, PAGE_ALIGN(size)))
+       size = PAGE_ALIGN(size);
+
+       if (!sparc_dma_free_resource(cpu_addr, size))
                return;
 
        dma_make_coherent(dma_addr, size);
index 8e645dd..30f171b 100644 (file)
@@ -39,6 +39,7 @@ struct mdesc_hdr {
        u32     node_sz; /* node block size */
        u32     name_sz; /* name block size */
        u32     data_sz; /* data block size */
+       char    data[];
 } __attribute__((aligned(16)));
 
 struct mdesc_elem {
@@ -612,7 +613,7 @@ EXPORT_SYMBOL(mdesc_get_node_info);
 
 static struct mdesc_elem *node_block(struct mdesc_hdr *mdesc)
 {
-       return (struct mdesc_elem *) (mdesc + 1);
+       return (struct mdesc_elem *) mdesc->data;
 }
 
 static void *name_block(struct mdesc_hdr *mdesc)
index c9da9f1..f3a8cd4 100644 (file)
@@ -19,8 +19,10 @@ void ioport_unmap(void __iomem *addr)
 EXPORT_SYMBOL(ioport_map);
 EXPORT_SYMBOL(ioport_unmap);
 
+#ifdef CONFIG_PCI
 void pci_iounmap(struct pci_dev *dev, void __iomem * addr)
 {
        /* nothing to do */
 }
 EXPORT_SYMBOL(pci_iounmap);
+#endif
index 4e001bb..d9830e7 100644 (file)
@@ -339,6 +339,11 @@ config NEED_PER_CPU_PAGE_FIRST_CHUNK
 config ARCH_HIBERNATION_POSSIBLE
        def_bool y
 
+config ARCH_NR_GPIO
+       int
+       default 1024 if X86_64
+       default 512
+
 config ARCH_SUSPEND_POSSIBLE
        def_bool y
 
@@ -1400,7 +1405,7 @@ config HIGHMEM4G
 
 config HIGHMEM64G
        bool "64GB"
-       depends on !M486SX && !M486 && !M586 && !M586TSC && !M586MMX && !MGEODE_LX && !MGEODEGX1 && !MCYRIXIII && !MELAN && !MWINCHIPC6 && !WINCHIP3D && !MK6
+       depends on !M486SX && !M486 && !M586 && !M586TSC && !M586MMX && !MGEODE_LX && !MGEODEGX1 && !MCYRIXIII && !MELAN && !MWINCHIPC6 && !MWINCHIP3D && !MK6
        select X86_PAE
        help
          Select this if you have a 32-bit processor and more than 4
@@ -1520,7 +1525,6 @@ config AMD_MEM_ENCRYPT
 
 config AMD_MEM_ENCRYPT_ACTIVE_BY_DEFAULT
        bool "Activate AMD Secure Memory Encryption (SME) by default"
-       default y
        depends on AMD_MEM_ENCRYPT
        help
          Say yes to have system memory encrypted by default if running on
@@ -2605,7 +2609,6 @@ config PCI_OLPC
 config PCI_XEN
        def_bool y
        depends on PCI && XEN
-       select SWIOTLB_XEN
 
 config MMCONF_FAM10H
        def_bool y
@@ -2828,8 +2831,6 @@ config HAVE_ATOMIC_IOMAP
        def_bool y
        depends on X86_32
 
-source "drivers/firmware/Kconfig"
-
 source "arch/x86/kvm/Kconfig"
 
 source "arch/x86/Kconfig.assembler"
index e7355f8..94834c4 100644 (file)
@@ -4,6 +4,12 @@
 
 tune           = $(call cc-option,-mtune=$(1),$(2))
 
+ifdef CONFIG_CC_IS_CLANG
+align          := -falign-functions=0 $(call cc-option,-falign-jumps=0) $(call cc-option,-falign-loops=0)
+else
+align          := -falign-functions=0 -falign-jumps=0 -falign-loops=0
+endif
+
 cflags-$(CONFIG_M486SX)                += -march=i486
 cflags-$(CONFIG_M486)          += -march=i486
 cflags-$(CONFIG_M586)          += -march=i586
@@ -19,11 +25,11 @@ cflags-$(CONFIG_MK6)                += -march=k6
 # They make zero difference whatsosever to performance at this time.
 cflags-$(CONFIG_MK7)           += -march=athlon
 cflags-$(CONFIG_MK8)           += $(call cc-option,-march=k8,-march=athlon)
-cflags-$(CONFIG_MCRUSOE)       += -march=i686 -falign-functions=0 -falign-jumps=0 -falign-loops=0
-cflags-$(CONFIG_MEFFICEON)     += -march=i686 $(call tune,pentium3) -falign-functions=0 -falign-jumps=0 -falign-loops=0
+cflags-$(CONFIG_MCRUSOE)       += -march=i686 $(align)
+cflags-$(CONFIG_MEFFICEON)     += -march=i686 $(call tune,pentium3) $(align)
 cflags-$(CONFIG_MWINCHIPC6)    += $(call cc-option,-march=winchip-c6,-march=i586)
 cflags-$(CONFIG_MWINCHIP3D)    += $(call cc-option,-march=winchip2,-march=i586)
-cflags-$(CONFIG_MCYRIXIII)     += $(call cc-option,-march=c3,-march=i486) -falign-functions=0 -falign-jumps=0 -falign-loops=0
+cflags-$(CONFIG_MCYRIXIII)     += $(call cc-option,-march=c3,-march=i486) $(align)
 cflags-$(CONFIG_MVIAC3_2)      += $(call cc-option,-march=c3-2,-march=i686)
 cflags-$(CONFIG_MVIAC7)                += -march=i686
 cflags-$(CONFIG_MCORE2)                += -march=i686 $(call tune,core2)
index fa2c3f5..18d2f51 100644 (file)
@@ -367,10 +367,11 @@ SYM_FUNC_START(sm4_aesni_avx_crypt8)
         *      %rdx: src (1..8 blocks)
         *      %rcx: num blocks (1..8)
         */
-       FRAME_BEGIN
-
        cmpq $5, %rcx;
        jb sm4_aesni_avx_crypt4;
+
+       FRAME_BEGIN
+
        vmovdqu (0 * 16)(%rdx), RA0;
        vmovdqu (1 * 16)(%rdx), RA1;
        vmovdqu (2 * 16)(%rdx), RA2;
index 2a57dbe..6dfa8dd 100644 (file)
@@ -2465,6 +2465,7 @@ static int x86_pmu_event_init(struct perf_event *event)
        if (err) {
                if (event->destroy)
                        event->destroy(event);
+               event->destroy = NULL;
        }
 
        if (READ_ONCE(x86_pmu.attr_rdpmc) &&
index 7011e87..9a04443 100644 (file)
@@ -263,6 +263,7 @@ static struct event_constraint intel_icl_event_constraints[] = {
        INTEL_EVENT_CONSTRAINT_RANGE(0xa8, 0xb0, 0xf),
        INTEL_EVENT_CONSTRAINT_RANGE(0xb7, 0xbd, 0xf),
        INTEL_EVENT_CONSTRAINT_RANGE(0xd0, 0xe6, 0xf),
+       INTEL_EVENT_CONSTRAINT(0xef, 0xf),
        INTEL_EVENT_CONSTRAINT_RANGE(0xf0, 0xf4, 0xf),
        EVENT_CONSTRAINT_END
 };
index c853b28..96c775a 100644 (file)
@@ -68,6 +68,7 @@ static bool test_intel(int idx, void *data)
        case INTEL_FAM6_BROADWELL_D:
        case INTEL_FAM6_BROADWELL_G:
        case INTEL_FAM6_BROADWELL_X:
+       case INTEL_FAM6_SAPPHIRERAPIDS_X:
 
        case INTEL_FAM6_ATOM_SILVERMONT:
        case INTEL_FAM6_ATOM_SILVERMONT_D:
index 90e682a..db2d92f 100644 (file)
@@ -99,7 +99,8 @@ static void hv_apic_eoi_write(u32 reg, u32 val)
 /*
  * IPI implementation on Hyper-V.
  */
-static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector)
+static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector,
+               bool exclude_self)
 {
        struct hv_send_ipi_ex **arg;
        struct hv_send_ipi_ex *ipi_arg;
@@ -121,14 +122,27 @@ static bool __send_ipi_mask_ex(const struct cpumask *mask, int vector)
        ipi_arg->reserved = 0;
        ipi_arg->vp_set.valid_bank_mask = 0;
 
-       if (!cpumask_equal(mask, cpu_present_mask)) {
+       /*
+        * Use HV_GENERIC_SET_ALL and avoid converting cpumask to VP_SET
+        * when the IPI is sent to all currently present CPUs.
+        */
+       if (!cpumask_equal(mask, cpu_present_mask) || exclude_self) {
                ipi_arg->vp_set.format = HV_GENERIC_SET_SPARSE_4K;
-               nr_bank = cpumask_to_vpset(&(ipi_arg->vp_set), mask);
-       }
-       if (nr_bank < 0)
-               goto ipi_mask_ex_done;
-       if (!nr_bank)
+               if (exclude_self)
+                       nr_bank = cpumask_to_vpset_noself(&(ipi_arg->vp_set), mask);
+               else
+                       nr_bank = cpumask_to_vpset(&(ipi_arg->vp_set), mask);
+
+               /*
+                * 'nr_bank <= 0' means some CPUs in cpumask can't be
+                * represented in VP_SET. Return an error and fall back to
+                * native (architectural) method of sending IPIs.
+                */
+               if (nr_bank <= 0)
+                       goto ipi_mask_ex_done;
+       } else {
                ipi_arg->vp_set.format = HV_GENERIC_SET_ALL;
+       }
 
        status = hv_do_rep_hypercall(HVCALL_SEND_IPI_EX, 0, nr_bank,
                              ipi_arg, NULL);
@@ -138,15 +152,25 @@ ipi_mask_ex_done:
        return hv_result_success(status);
 }
 
-static bool __send_ipi_mask(const struct cpumask *mask, int vector)
+static bool __send_ipi_mask(const struct cpumask *mask, int vector,
+               bool exclude_self)
 {
-       int cur_cpu, vcpu;
+       int cur_cpu, vcpu, this_cpu = smp_processor_id();
        struct hv_send_ipi ipi_arg;
        u64 status;
+       unsigned int weight;
 
        trace_hyperv_send_ipi_mask(mask, vector);
 
-       if (cpumask_empty(mask))
+       weight = cpumask_weight(mask);
+
+       /*
+        * Do nothing if
+        *   1. the mask is empty
+        *   2. the mask only contains self when exclude_self is true
+        */
+       if (weight == 0 ||
+           (exclude_self && weight == 1 && cpumask_test_cpu(this_cpu, mask)))
                return true;
 
        if (!hv_hypercall_pg)
@@ -172,6 +196,8 @@ static bool __send_ipi_mask(const struct cpumask *mask, int vector)
        ipi_arg.cpu_mask = 0;
 
        for_each_cpu(cur_cpu, mask) {
+               if (exclude_self && cur_cpu == this_cpu)
+                       continue;
                vcpu = hv_cpu_number_to_vp_number(cur_cpu);
                if (vcpu == VP_INVAL)
                        return false;
@@ -191,7 +217,7 @@ static bool __send_ipi_mask(const struct cpumask *mask, int vector)
        return hv_result_success(status);
 
 do_ex_hypercall:
-       return __send_ipi_mask_ex(mask, vector);
+       return __send_ipi_mask_ex(mask, vector, exclude_self);
 }
 
 static bool __send_ipi_one(int cpu, int vector)
@@ -208,7 +234,7 @@ static bool __send_ipi_one(int cpu, int vector)
                return false;
 
        if (vp >= 64)
-               return __send_ipi_mask_ex(cpumask_of(cpu), vector);
+               return __send_ipi_mask_ex(cpumask_of(cpu), vector, false);
 
        status = hv_do_fast_hypercall16(HVCALL_SEND_IPI, vector, BIT_ULL(vp));
        return hv_result_success(status);
@@ -222,20 +248,13 @@ static void hv_send_ipi(int cpu, int vector)
 
 static void hv_send_ipi_mask(const struct cpumask *mask, int vector)
 {
-       if (!__send_ipi_mask(mask, vector))
+       if (!__send_ipi_mask(mask, vector, false))
                orig_apic.send_IPI_mask(mask, vector);
 }
 
 static void hv_send_ipi_mask_allbutself(const struct cpumask *mask, int vector)
 {
-       unsigned int this_cpu = smp_processor_id();
-       struct cpumask new_mask;
-       const struct cpumask *local_mask;
-
-       cpumask_copy(&new_mask, mask);
-       cpumask_clear_cpu(this_cpu, &new_mask);
-       local_mask = &new_mask;
-       if (!__send_ipi_mask(local_mask, vector))
+       if (!__send_ipi_mask(mask, vector, true))
                orig_apic.send_IPI_mask_allbutself(mask, vector);
 }
 
@@ -246,7 +265,7 @@ static void hv_send_ipi_allbutself(int vector)
 
 static void hv_send_ipi_all(int vector)
 {
-       if (!__send_ipi_mask(cpu_online_mask, vector))
+       if (!__send_ipi_mask(cpu_online_mask, vector, false))
                orig_apic.send_IPI_all(vector);
 }
 
index 14ebd21..4318464 100644 (file)
@@ -25,7 +25,7 @@ static __always_inline void arch_check_user_regs(struct pt_regs *regs)
                 * For !SMAP hardware we patch out CLAC on entry.
                 */
                if (boot_cpu_has(X86_FEATURE_SMAP) ||
-                   (IS_ENABLED(CONFIG_64_BIT) && boot_cpu_has(X86_FEATURE_XENPV)))
+                   (IS_ENABLED(CONFIG_64BIT) && boot_cpu_has(X86_FEATURE_XENPV)))
                        mask |= X86_EFLAGS_AC;
 
                WARN_ON_ONCE(flags & mask);
index 87bd602..6a5f3ac 100644 (file)
@@ -46,7 +46,7 @@ struct kvm_page_track_notifier_node {
                            struct kvm_page_track_notifier_node *node);
 };
 
-void kvm_page_track_init(struct kvm *kvm);
+int kvm_page_track_init(struct kvm *kvm);
 void kvm_page_track_cleanup(struct kvm *kvm);
 
 void kvm_page_track_free_memslot(struct kvm_memory_slot *slot);
index eceea92..6c57651 100644 (file)
@@ -2,6 +2,20 @@
 #ifndef _ASM_X86_KVM_CLOCK_H
 #define _ASM_X86_KVM_CLOCK_H
 
+#include <linux/percpu.h>
+
 extern struct clocksource kvm_clock;
 
+DECLARE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu);
+
+static inline struct pvclock_vcpu_time_info *this_cpu_pvti(void)
+{
+       return &this_cpu_read(hv_clock_per_cpu)->pvti;
+}
+
+static inline struct pvclock_vsyscall_time_info *this_cpu_hvclock(void)
+{
+       return this_cpu_read(hv_clock_per_cpu);
+}
+
 #endif /* _ASM_X86_KVM_CLOCK_H */
index 5c7bcaa..1d5f14a 100644 (file)
@@ -2,8 +2,6 @@
 #ifndef _ASM_X86_PKEYS_H
 #define _ASM_X86_PKEYS_H
 
-#define ARCH_DEFAULT_PKEY      0
-
 /*
  * If more than 16 keys are ever supported, a thorough audit
  * will be necessary to ensure that the types that store key
index f3fbb84..68c257a 100644 (file)
@@ -275,7 +275,7 @@ static inline int enqcmds(void __iomem *dst, const void *src)
 {
        const struct { char _[64]; } *__src = src;
        struct { char _[64]; } __iomem *__dst = dst;
-       int zf;
+       bool zf;
 
        /*
         * ENQCMDS %(rdx), rax
index c9fa7be..5c95d24 100644 (file)
@@ -301,8 +301,8 @@ do {                                                                        \
        unsigned int __gu_low, __gu_high;                               \
        const unsigned int __user *__gu_ptr;                            \
        __gu_ptr = (const void __user *)(ptr);                          \
-       __get_user_asm(__gu_low, ptr, "l", "=r", label);                \
-       __get_user_asm(__gu_high, ptr+1, "l", "=r", label);             \
+       __get_user_asm(__gu_low, __gu_ptr, "l", "=r", label);           \
+       __get_user_asm(__gu_high, __gu_ptr+1, "l", "=r", label);        \
        (x) = ((unsigned long long)__gu_high << 32) | __gu_low;         \
 } while (0)
 #else
index 3506d8c..4557f7c 100644 (file)
@@ -14,16 +14,19 @@ static inline int pci_xen_hvm_init(void)
        return -1;
 }
 #endif
-#if defined(CONFIG_XEN_DOM0)
+#ifdef CONFIG_XEN_PV_DOM0
 int __init pci_xen_initial_domain(void);
-int xen_find_device_domain_owner(struct pci_dev *dev);
-int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
-int xen_unregister_device_domain_owner(struct pci_dev *dev);
 #else
 static inline int __init pci_xen_initial_domain(void)
 {
        return -1;
 }
+#endif
+#ifdef CONFIG_XEN_DOM0
+int xen_find_device_domain_owner(struct pci_dev *dev);
+int xen_register_device_domain_owner(struct pci_dev *dev, uint16_t domain);
+int xen_unregister_device_domain_owner(struct pci_dev *dev);
+#else
 static inline int xen_find_device_domain_owner(struct pci_dev *dev)
 {
        return -1;
index 6b56d0d..66b4ddd 100644 (file)
@@ -3,14 +3,10 @@
 #define _ASM_X86_SWIOTLB_XEN_H
 
 #ifdef CONFIG_SWIOTLB_XEN
-extern int xen_swiotlb;
 extern int __init pci_xen_swiotlb_detect(void);
-extern void __init pci_xen_swiotlb_init(void);
 extern int pci_xen_swiotlb_init_late(void);
 #else
-#define xen_swiotlb (0)
-static inline int __init pci_xen_swiotlb_detect(void) { return 0; }
-static inline void __init pci_xen_swiotlb_init(void) { }
+#define pci_xen_swiotlb_detect NULL
 static inline int pci_xen_swiotlb_init_late(void) { return -ENXIO; }
 #endif
 
index 0f88859..b3410f1 100644 (file)
@@ -326,6 +326,7 @@ static __always_inline void setup_smap(struct cpuinfo_x86 *c)
 #ifdef CONFIG_X86_SMAP
                cr4_set_bits(X86_CR4_SMAP);
 #else
+               clear_cpu_cap(c, X86_FEATURE_SMAP);
                cr4_clear_bits(X86_CR4_SMAP);
 #endif
        }
index 8cb7816..193204a 100644 (file)
@@ -1253,6 +1253,9 @@ static void __mc_scan_banks(struct mce *m, struct pt_regs *regs, struct mce *fin
 
 static void kill_me_now(struct callback_head *ch)
 {
+       struct task_struct *p = container_of(ch, struct task_struct, mce_kill_me);
+
+       p->mce_count = 0;
        force_sig(SIGBUS);
 }
 
@@ -1262,6 +1265,7 @@ static void kill_me_maybe(struct callback_head *cb)
        int flags = MF_ACTION_REQUIRED;
        int ret;
 
+       p->mce_count = 0;
        pr_err("Uncorrected hardware memory error in user-access at %llx", p->mce_addr);
 
        if (!p->mce_ripv)
@@ -1290,17 +1294,34 @@ static void kill_me_maybe(struct callback_head *cb)
        }
 }
 
-static void queue_task_work(struct mce *m, int kill_current_task)
+static void queue_task_work(struct mce *m, char *msg, int kill_current_task)
 {
-       current->mce_addr = m->addr;
-       current->mce_kflags = m->kflags;
-       current->mce_ripv = !!(m->mcgstatus & MCG_STATUS_RIPV);
-       current->mce_whole_page = whole_page(m);
+       int count = ++current->mce_count;
 
-       if (kill_current_task)
-               current->mce_kill_me.func = kill_me_now;
-       else
-               current->mce_kill_me.func = kill_me_maybe;
+       /* First call, save all the details */
+       if (count == 1) {
+               current->mce_addr = m->addr;
+               current->mce_kflags = m->kflags;
+               current->mce_ripv = !!(m->mcgstatus & MCG_STATUS_RIPV);
+               current->mce_whole_page = whole_page(m);
+
+               if (kill_current_task)
+                       current->mce_kill_me.func = kill_me_now;
+               else
+                       current->mce_kill_me.func = kill_me_maybe;
+       }
+
+       /* Ten is likely overkill. Don't expect more than two faults before task_work() */
+       if (count > 10)
+               mce_panic("Too many consecutive machine checks while accessing user data", m, msg);
+
+       /* Second or later call, make sure page address matches the one from first call */
+       if (count > 1 && (current->mce_addr >> PAGE_SHIFT) != (m->addr >> PAGE_SHIFT))
+               mce_panic("Consecutive machine checks to different user pages", m, msg);
+
+       /* Do not call task_work_add() more than once */
+       if (count > 1)
+               return;
 
        task_work_add(current, &current->mce_kill_me, TWA_RESUME);
 }
@@ -1438,7 +1459,7 @@ noinstr void do_machine_check(struct pt_regs *regs)
                /* If this triggers there is no way to recover. Die hard. */
                BUG_ON(!on_thread_stack() || !user_mode(regs));
 
-               queue_task_work(&m, kill_current_task);
+               queue_task_work(&m, msg, kill_current_task);
 
        } else {
                /*
@@ -1456,7 +1477,7 @@ noinstr void do_machine_check(struct pt_regs *regs)
                }
 
                if (m.kflags & MCE_IN_KERNEL_COPYIN)
-                       queue_task_work(&m, kill_current_task);
+                       queue_task_work(&m, msg, kill_current_task);
        }
 out:
        mce_wrmsrl(MSR_IA32_MCG_STATUS, 0);
index 4b8813b..bb1c3f5 100644 (file)
@@ -527,12 +527,14 @@ static void domain_add_cpu(int cpu, struct rdt_resource *r)
        rdt_domain_reconfigure_cdp(r);
 
        if (r->alloc_capable && domain_setup_ctrlval(r, d)) {
-               kfree(d);
+               kfree(hw_dom);
                return;
        }
 
        if (r->mon_capable && domain_setup_mon_state(r, d)) {
-               kfree(d);
+               kfree(hw_dom->ctrl_val);
+               kfree(hw_dom->mbps_val);
+               kfree(hw_dom);
                return;
        }
 
index 38837da..391a4e2 100644 (file)
@@ -714,12 +714,6 @@ static struct chipset early_qrk[] __initdata = {
         */
        { PCI_VENDOR_ID_INTEL, 0x0f00,
                PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
-       { PCI_VENDOR_ID_INTEL, 0x3e20,
-               PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
-       { PCI_VENDOR_ID_INTEL, 0x3ec4,
-               PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
-       { PCI_VENDOR_ID_INTEL, 0x8a12,
-               PCI_CLASS_BRIDGE_HOST, PCI_ANY_ID, 0, force_disable_hpet},
        { PCI_VENDOR_ID_BROADCOM, 0x4331,
          PCI_CLASS_NETWORK_OTHER, PCI_ANY_ID, 0, apple_airport_reset},
        {}
index 445c57c..831b25c 100644 (file)
@@ -379,9 +379,14 @@ static int __fpu_restore_sig(void __user *buf, void __user *buf_fx,
                                     sizeof(fpu->state.fxsave)))
                        return -EFAULT;
 
-               /* Reject invalid MXCSR values. */
-               if (fpu->state.fxsave.mxcsr & ~mxcsr_feature_mask)
-                       return -EINVAL;
+               if (IS_ENABLED(CONFIG_X86_64)) {
+                       /* Reject invalid MXCSR values. */
+                       if (fpu->state.fxsave.mxcsr & ~mxcsr_feature_mask)
+                               return -EINVAL;
+               } else {
+                       /* Mask invalid bits out for historical reasons (broken hardware). */
+                       fpu->state.fxsave.mxcsr &= mxcsr_feature_mask;
+               }
 
                /* Enforce XFEATURE_MASK_FPSSE when XSAVE is enabled */
                if (use_xsave())
index 42fc41d..882213d 100644 (file)
@@ -10,6 +10,7 @@
 #include <asm/irq_remapping.h>
 #include <asm/hpet.h>
 #include <asm/time.h>
+#include <asm/mwait.h>
 
 #undef  pr_fmt
 #define pr_fmt(fmt) "hpet: " fmt
@@ -916,6 +917,83 @@ static bool __init hpet_counting(void)
        return false;
 }
 
+static bool __init mwait_pc10_supported(void)
+{
+       unsigned int eax, ebx, ecx, mwait_substates;
+
+       if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
+               return false;
+
+       if (!cpu_feature_enabled(X86_FEATURE_MWAIT))
+               return false;
+
+       if (boot_cpu_data.cpuid_level < CPUID_MWAIT_LEAF)
+               return false;
+
+       cpuid(CPUID_MWAIT_LEAF, &eax, &ebx, &ecx, &mwait_substates);
+
+       return (ecx & CPUID5_ECX_EXTENSIONS_SUPPORTED) &&
+              (ecx & CPUID5_ECX_INTERRUPT_BREAK) &&
+              (mwait_substates & (0xF << 28));
+}
+
+/*
+ * Check whether the system supports PC10. If so force disable HPET as that
+ * stops counting in PC10. This check is overbroad as it does not take any
+ * of the following into account:
+ *
+ *     - ACPI tables
+ *     - Enablement of intel_idle
+ *     - Command line arguments which limit intel_idle C-state support
+ *
+ * That's perfectly fine. HPET is a piece of hardware designed by committee
+ * and the only reasons why it is still in use on modern systems is the
+ * fact that it is impossible to reliably query TSC and CPU frequency via
+ * CPUID or firmware.
+ *
+ * If HPET is functional it is useful for calibrating TSC, but this can be
+ * done via PMTIMER as well which seems to be the last remaining timer on
+ * X86/INTEL platforms that has not been completely wreckaged by feature
+ * creep.
+ *
+ * In theory HPET support should be removed altogether, but there are older
+ * systems out there which depend on it because TSC and APIC timer are
+ * dysfunctional in deeper C-states.
+ *
+ * It's only 20 years now that hardware people have been asked to provide
+ * reliable and discoverable facilities which can be used for timekeeping
+ * and per CPU timer interrupts.
+ *
+ * The probability that this problem is going to be solved in the
+ * forseeable future is close to zero, so the kernel has to be cluttered
+ * with heuristics to keep up with the ever growing amount of hardware and
+ * firmware trainwrecks. Hopefully some day hardware people will understand
+ * that the approach of "This can be fixed in software" is not sustainable.
+ * Hope dies last...
+ */
+static bool __init hpet_is_pc10_damaged(void)
+{
+       unsigned long long pcfg;
+
+       /* Check whether PC10 substates are supported */
+       if (!mwait_pc10_supported())
+               return false;
+
+       /* Check whether PC10 is enabled in PKG C-state limit */
+       rdmsrl(MSR_PKG_CST_CONFIG_CONTROL, pcfg);
+       if ((pcfg & 0xF) < 8)
+               return false;
+
+       if (hpet_force_user) {
+               pr_warn("HPET force enabled via command line, but dysfunctional in PC10.\n");
+               return false;
+       }
+
+       pr_info("HPET dysfunctional in PC10. Force disabled.\n");
+       boot_hpet_disable = true;
+       return true;
+}
+
 /**
  * hpet_enable - Try to setup the HPET timer. Returns 1 on success.
  */
@@ -929,6 +1007,9 @@ int __init hpet_enable(void)
        if (!is_hpet_capable())
                return 0;
 
+       if (hpet_is_pc10_damaged())
+               return 0;
+
        hpet_set_mapping();
        if (!hpet_virt_address)
                return 0;
index ad273e5..73c74b9 100644 (file)
@@ -49,18 +49,9 @@ early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall);
 static struct pvclock_vsyscall_time_info
                        hv_clock_boot[HVC_BOOT_ARRAY_SIZE] __bss_decrypted __aligned(PAGE_SIZE);
 static struct pvclock_wall_clock wall_clock __bss_decrypted;
-static DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu);
 static struct pvclock_vsyscall_time_info *hvclock_mem;
-
-static inline struct pvclock_vcpu_time_info *this_cpu_pvti(void)
-{
-       return &this_cpu_read(hv_clock_per_cpu)->pvti;
-}
-
-static inline struct pvclock_vsyscall_time_info *this_cpu_hvclock(void)
-{
-       return this_cpu_read(hv_clock_per_cpu);
-}
+DEFINE_PER_CPU(struct pvclock_vsyscall_time_info *, hv_clock_per_cpu);
+EXPORT_PER_CPU_SYMBOL_GPL(hv_clock_per_cpu);
 
 /*
  * The wallclock is the time of day when we booted. Since then, some time may
index 79f1641..40ed44e 100644 (file)
@@ -830,6 +830,20 @@ void __init setup_arch(char **cmdline_p)
 
        x86_init.oem.arch_setup();
 
+       /*
+        * Do some memory reservations *before* memory is added to memblock, so
+        * memblock allocations won't overwrite it.
+        *
+        * After this point, everything still needed from the boot loader or
+        * firmware or kernel text should be early reserved or marked not RAM in
+        * e820. All other memory is free game.
+        *
+        * This call needs to happen before e820__memory_setup() which calls the
+        * xen_memory_setup() on Xen dom0 which relies on the fact that those
+        * early reservations have happened already.
+        */
+       early_reserve_memory();
+
        iomem_resource.end = (1ULL << boot_cpu_data.x86_phys_bits) - 1;
        e820__memory_setup();
        parse_setup_data();
@@ -876,18 +890,6 @@ void __init setup_arch(char **cmdline_p)
 
        parse_early_param();
 
-       /*
-        * Do some memory reservations *before* memory is added to
-        * memblock, so memblock allocations won't overwrite it.
-        * Do it after early param, so we could get (unlikely) panic from
-        * serial.
-        *
-        * After this point everything still needed from the boot loader or
-        * firmware or kernel text should be early reserved or marked not
-        * RAM in e820. All other memory is free game.
-        */
-       early_reserve_memory();
-
 #ifdef CONFIG_MEMORY_HOTPLUG
        /*
         * Memory used by the kernel cannot be hot-removed because Linux
index 78a32b9..5afd985 100644 (file)
@@ -135,7 +135,7 @@ static void * __init pcpu_fc_alloc(unsigned int cpu, size_t size, size_t align)
 
 static void __init pcpu_fc_free(void *ptr, size_t size)
 {
-       memblock_free(__pa(ptr), size);
+       memblock_free_ptr(ptr, size);
 }
 
 static int __init pcpu_cpu_distance(unsigned int from, unsigned int to)
index 9f90f46..bf1033a 100644 (file)
@@ -130,6 +130,8 @@ static enum es_result sev_es_ghcb_hv_call(struct ghcb *ghcb,
                } else {
                        ret = ES_VMM_ERROR;
                }
+       } else if (ghcb->save.sw_exit_info_1 & 0xffffffff) {
+               ret = ES_VMM_ERROR;
        } else {
                ret = ES_OK;
        }
index fe03bd9..751aa85 100644 (file)
@@ -65,8 +65,8 @@ static inline struct kvm_cpuid_entry2 *cpuid_entry2_find(
        for (i = 0; i < nent; i++) {
                e = &entries[i];
 
-               if (e->function == function && (e->index == index ||
-                   !(e->flags & KVM_CPUID_FLAG_SIGNIFCANT_INDEX)))
+               if (e->function == function &&
+                   (!(e->flags & KVM_CPUID_FLAG_SIGNIFCANT_INDEX) || e->index == index))
                        return e;
        }
 
index 2837110..9a144ca 100644 (file)
@@ -435,7 +435,6 @@ static int fastop(struct x86_emulate_ctxt *ctxt, fastop_t fop);
        __FOP_RET(#op)
 
 asm(".pushsection .fixup, \"ax\"\n"
-    ".global kvm_fastop_exception \n"
     "kvm_fastop_exception: xor %esi, %esi; ret\n"
     ".popsection");
 
@@ -4206,7 +4205,7 @@ static int check_rdtsc(struct x86_emulate_ctxt *ctxt)
        u64 cr4 = ctxt->ops->get_cr(ctxt, 4);
 
        if (cr4 & X86_CR4_TSD && ctxt->ops->cpl(ctxt))
-               return emulate_ud(ctxt);
+               return emulate_gp(ctxt, 0);
 
        return X86EMUL_CONTINUE;
 }
index 232a86a..d5124b5 100644 (file)
@@ -939,7 +939,7 @@ static int kvm_hv_vcpu_init(struct kvm_vcpu *vcpu)
        for (i = 0; i < ARRAY_SIZE(hv_vcpu->stimer); i++)
                stimer_init(&hv_vcpu->stimer[i], i);
 
-       hv_vcpu->vp_index = kvm_vcpu_get_idx(vcpu);
+       hv_vcpu->vp_index = vcpu->vcpu_idx;
 
        return 0;
 }
@@ -1444,7 +1444,6 @@ static int kvm_hv_set_msr(struct kvm_vcpu *vcpu, u32 msr, u64 data, bool host)
        switch (msr) {
        case HV_X64_MSR_VP_INDEX: {
                struct kvm_hv *hv = to_kvm_hv(vcpu->kvm);
-               int vcpu_idx = kvm_vcpu_get_idx(vcpu);
                u32 new_vp_index = (u32)data;
 
                if (!host || new_vp_index >= KVM_MAX_VCPUS)
@@ -1459,9 +1458,9 @@ static int kvm_hv_set_msr(struct kvm_vcpu *vcpu, u32 msr, u64 data, bool host)
                 * VP index is changing, adjust num_mismatched_vp_indexes if
                 * it now matches or no longer matches vcpu_idx.
                 */
-               if (hv_vcpu->vp_index == vcpu_idx)
+               if (hv_vcpu->vp_index == vcpu->vcpu_idx)
                        atomic_inc(&hv->num_mismatched_vp_indexes);
-               else if (new_vp_index == vcpu_idx)
+               else if (new_vp_index == vcpu->vcpu_idx)
                        atomic_dec(&hv->num_mismatched_vp_indexes);
 
                hv_vcpu->vp_index = new_vp_index;
index 730da85..ed1c4e5 100644 (file)
@@ -83,7 +83,7 @@ static inline u32 kvm_hv_get_vpindex(struct kvm_vcpu *vcpu)
 {
        struct kvm_vcpu_hv *hv_vcpu = to_hv_vcpu(vcpu);
 
-       return hv_vcpu ? hv_vcpu->vp_index : kvm_vcpu_get_idx(vcpu);
+       return hv_vcpu ? hv_vcpu->vp_index : vcpu->vcpu_idx;
 }
 
 int kvm_hv_set_msr_common(struct kvm_vcpu *vcpu, u32 msr, u64 data, bool host);
index ff005fe..8c065da 100644 (file)
@@ -319,8 +319,8 @@ static void ioapic_write_indirect(struct kvm_ioapic *ioapic, u32 val)
        unsigned index;
        bool mask_before, mask_after;
        union kvm_ioapic_redirect_entry *e;
-       unsigned long vcpu_bitmap;
        int old_remote_irr, old_delivery_status, old_dest_id, old_dest_mode;
+       DECLARE_BITMAP(vcpu_bitmap, KVM_MAX_VCPUS);
 
        switch (ioapic->ioregsel) {
        case IOAPIC_REG_VERSION:
@@ -384,9 +384,9 @@ static void ioapic_write_indirect(struct kvm_ioapic *ioapic, u32 val)
                        irq.shorthand = APIC_DEST_NOSHORT;
                        irq.dest_id = e->fields.dest_id;
                        irq.msi_redir_hint = false;
-                       bitmap_zero(&vcpu_bitmap, 16);
+                       bitmap_zero(vcpu_bitmap, KVM_MAX_VCPUS);
                        kvm_bitmap_or_dest_vcpus(ioapic->kvm, &irq,
-                                                &vcpu_bitmap);
+                                                vcpu_bitmap);
                        if (old_dest_mode != e->fields.dest_mode ||
                            old_dest_id != e->fields.dest_id) {
                                /*
@@ -399,10 +399,10 @@ static void ioapic_write_indirect(struct kvm_ioapic *ioapic, u32 val)
                                    kvm_lapic_irq_dest_mode(
                                        !!e->fields.dest_mode);
                                kvm_bitmap_or_dest_vcpus(ioapic->kvm, &irq,
-                                                        &vcpu_bitmap);
+                                                        vcpu_bitmap);
                        }
                        kvm_make_scan_ioapic_request_mask(ioapic->kvm,
-                                                         &vcpu_bitmap);
+                                                         vcpu_bitmap);
                } else {
                        kvm_make_scan_ioapic_request(ioapic->kvm);
                }
index 2d7e611..1a64ba5 100644 (file)
@@ -2027,8 +2027,8 @@ static void mmu_pages_clear_parents(struct mmu_page_path *parents)
        } while (!sp->unsync_children);
 }
 
-static void mmu_sync_children(struct kvm_vcpu *vcpu,
-                             struct kvm_mmu_page *parent)
+static int mmu_sync_children(struct kvm_vcpu *vcpu,
+                            struct kvm_mmu_page *parent, bool can_yield)
 {
        int i;
        struct kvm_mmu_page *sp;
@@ -2055,12 +2055,18 @@ static void mmu_sync_children(struct kvm_vcpu *vcpu,
                }
                if (need_resched() || rwlock_needbreak(&vcpu->kvm->mmu_lock)) {
                        kvm_mmu_flush_or_zap(vcpu, &invalid_list, false, flush);
+                       if (!can_yield) {
+                               kvm_make_request(KVM_REQ_MMU_SYNC, vcpu);
+                               return -EINTR;
+                       }
+
                        cond_resched_rwlock_write(&vcpu->kvm->mmu_lock);
                        flush = false;
                }
        }
 
        kvm_mmu_flush_or_zap(vcpu, &invalid_list, false, flush);
+       return 0;
 }
 
 static void __clear_sp_write_flooding_count(struct kvm_mmu_page *sp)
@@ -2146,9 +2152,6 @@ static struct kvm_mmu_page *kvm_mmu_get_page(struct kvm_vcpu *vcpu,
                        kvm_make_request(KVM_REQ_TLB_FLUSH_CURRENT, vcpu);
                }
 
-               if (sp->unsync_children)
-                       kvm_make_request(KVM_REQ_MMU_SYNC, vcpu);
-
                __clear_sp_write_flooding_count(sp);
 
 trace_get_page:
@@ -3684,7 +3687,7 @@ void kvm_mmu_sync_roots(struct kvm_vcpu *vcpu)
                write_lock(&vcpu->kvm->mmu_lock);
                kvm_mmu_audit(vcpu, AUDIT_PRE_SYNC);
 
-               mmu_sync_children(vcpu, sp);
+               mmu_sync_children(vcpu, sp, true);
 
                kvm_mmu_audit(vcpu, AUDIT_POST_SYNC);
                write_unlock(&vcpu->kvm->mmu_lock);
@@ -3700,7 +3703,7 @@ void kvm_mmu_sync_roots(struct kvm_vcpu *vcpu)
                if (IS_VALID_PAE_ROOT(root)) {
                        root &= PT64_BASE_ADDR_MASK;
                        sp = to_shadow_page(root);
-                       mmu_sync_children(vcpu, sp);
+                       mmu_sync_children(vcpu, sp, true);
                }
        }
 
index 269f11f..21427e8 100644 (file)
@@ -164,13 +164,13 @@ void kvm_page_track_cleanup(struct kvm *kvm)
        cleanup_srcu_struct(&head->track_srcu);
 }
 
-void kvm_page_track_init(struct kvm *kvm)
+int kvm_page_track_init(struct kvm *kvm)
 {
        struct kvm_page_track_notifier_head *head;
 
        head = &kvm->arch.track_notifier_head;
-       init_srcu_struct(&head->track_srcu);
        INIT_HLIST_HEAD(&head->track_notifier_list);
+       return init_srcu_struct(&head->track_srcu);
 }
 
 /*
index 7d03e9b..913d52a 100644 (file)
@@ -707,8 +707,27 @@ static int FNAME(fetch)(struct kvm_vcpu *vcpu, gpa_t addr,
                if (!is_shadow_present_pte(*it.sptep)) {
                        table_gfn = gw->table_gfn[it.level - 2];
                        access = gw->pt_access[it.level - 2];
-                       sp = kvm_mmu_get_page(vcpu, table_gfn, addr, it.level-1,
-                                             false, access);
+                       sp = kvm_mmu_get_page(vcpu, table_gfn, addr,
+                                             it.level-1, false, access);
+                       /*
+                        * We must synchronize the pagetable before linking it
+                        * because the guest doesn't need to flush tlb when
+                        * the gpte is changed from non-present to present.
+                        * Otherwise, the guest may use the wrong mapping.
+                        *
+                        * For PG_LEVEL_4K, kvm_mmu_get_page() has already
+                        * synchronized it transiently via kvm_sync_page().
+                        *
+                        * For higher level pagetable, we synchronize it via
+                        * the slower mmu_sync_children().  If it needs to
+                        * break, some progress has been made; return
+                        * RET_PF_RETRY and retry on the next #PF.
+                        * KVM_REQ_MMU_SYNC is not necessary but it
+                        * expedites the process.
+                        */
+                       if (sp->unsync_children &&
+                           mmu_sync_children(vcpu, sp, false))
+                               return RET_PF_RETRY;
                }
 
                /*
@@ -1047,14 +1066,6 @@ static gpa_t FNAME(gva_to_gpa_nested)(struct kvm_vcpu *vcpu, gpa_t vaddr,
  * Using the cached information from sp->gfns is safe because:
  * - The spte has a reference to the struct page, so the pfn for a given gfn
  *   can't change unless all sptes pointing to it are nuked first.
- *
- * Note:
- *   We should flush all tlbs if spte is dropped even though guest is
- *   responsible for it. Since if we don't, kvm_mmu_notifier_invalidate_page
- *   and kvm_mmu_notifier_invalidate_range_start detect the mapping page isn't
- *   used by guest then tlbs are not flushed, so guest is allowed to access the
- *   freed pages.
- *   And we increase kvm->tlbs_dirty to delay tlbs flush in this case.
  */
 static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
 {
@@ -1107,13 +1118,7 @@ static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
                        return 0;
 
                if (FNAME(prefetch_invalid_gpte)(vcpu, sp, &sp->spt[i], gpte)) {
-                       /*
-                        * Update spte before increasing tlbs_dirty to make
-                        * sure no tlb flush is lost after spte is zapped; see
-                        * the comments in kvm_flush_remote_tlbs().
-                        */
-                       smp_wmb();
-                       vcpu->kvm->tlbs_dirty++;
+                       set_spte_ret |= SET_SPTE_NEED_REMOTE_TLB_FLUSH;
                        continue;
                }
 
@@ -1128,12 +1133,7 @@ static int FNAME(sync_page)(struct kvm_vcpu *vcpu, struct kvm_mmu_page *sp)
 
                if (gfn != sp->gfns[i]) {
                        drop_spte(vcpu->kvm, &sp->spt[i]);
-                       /*
-                        * The same as above where we are doing
-                        * prefetch_invalid_gpte().
-                        */
-                       smp_wmb();
-                       vcpu->kvm->tlbs_dirty++;
+                       set_spte_ret |= SET_SPTE_NEED_REMOTE_TLB_FLUSH;
                        continue;
                }
 
index 2545d0c..510b833 100644 (file)
@@ -545,7 +545,6 @@ static void nested_vmcb02_prepare_control(struct vcpu_svm *svm)
                (svm->nested.ctl.int_ctl & int_ctl_vmcb12_bits) |
                (svm->vmcb01.ptr->control.int_ctl & int_ctl_vmcb01_bits);
 
-       svm->vmcb->control.virt_ext            = svm->nested.ctl.virt_ext;
        svm->vmcb->control.int_vector          = svm->nested.ctl.int_vector;
        svm->vmcb->control.int_state           = svm->nested.ctl.int_state;
        svm->vmcb->control.event_inj           = svm->nested.ctl.event_inj;
@@ -579,7 +578,7 @@ static void nested_svm_copy_common_state(struct vmcb *from_vmcb, struct vmcb *to
 }
 
 int enter_svm_guest_mode(struct kvm_vcpu *vcpu, u64 vmcb12_gpa,
-                        struct vmcb *vmcb12)
+                        struct vmcb *vmcb12, bool from_vmrun)
 {
        struct vcpu_svm *svm = to_svm(vcpu);
        int ret;
@@ -609,13 +608,16 @@ int enter_svm_guest_mode(struct kvm_vcpu *vcpu, u64 vmcb12_gpa,
        nested_vmcb02_prepare_save(svm, vmcb12);
 
        ret = nested_svm_load_cr3(&svm->vcpu, vmcb12->save.cr3,
-                                 nested_npt_enabled(svm), true);
+                                 nested_npt_enabled(svm), from_vmrun);
        if (ret)
                return ret;
 
        if (!npt_enabled)
                vcpu->arch.mmu->inject_page_fault = svm_inject_page_fault_nested;
 
+       if (!from_vmrun)
+               kvm_make_request(KVM_REQ_GET_NESTED_STATE_PAGES, vcpu);
+
        svm_set_gif(svm, true);
 
        return 0;
@@ -681,7 +683,7 @@ int nested_svm_vmrun(struct kvm_vcpu *vcpu)
 
        svm->nested.nested_run_pending = 1;
 
-       if (enter_svm_guest_mode(vcpu, vmcb12_gpa, vmcb12))
+       if (enter_svm_guest_mode(vcpu, vmcb12_gpa, vmcb12, true))
                goto out_exit_err;
 
        if (nested_svm_vmrun_msrpm(svm))
index 75e0b21..c36b5fe 100644 (file)
@@ -595,43 +595,50 @@ static int sev_es_sync_vmsa(struct vcpu_svm *svm)
        return 0;
 }
 
-static int sev_launch_update_vmsa(struct kvm *kvm, struct kvm_sev_cmd *argp)
+static int __sev_launch_update_vmsa(struct kvm *kvm, struct kvm_vcpu *vcpu,
+                                   int *error)
 {
-       struct kvm_sev_info *sev = &to_kvm_svm(kvm)->sev_info;
        struct sev_data_launch_update_vmsa vmsa;
+       struct vcpu_svm *svm = to_svm(vcpu);
+       int ret;
+
+       /* Perform some pre-encryption checks against the VMSA */
+       ret = sev_es_sync_vmsa(svm);
+       if (ret)
+               return ret;
+
+       /*
+        * The LAUNCH_UPDATE_VMSA command will perform in-place encryption of
+        * the VMSA memory content (i.e it will write the same memory region
+        * with the guest's key), so invalidate it first.
+        */
+       clflush_cache_range(svm->vmsa, PAGE_SIZE);
+
+       vmsa.reserved = 0;
+       vmsa.handle = to_kvm_svm(kvm)->sev_info.handle;
+       vmsa.address = __sme_pa(svm->vmsa);
+       vmsa.len = PAGE_SIZE;
+       return sev_issue_cmd(kvm, SEV_CMD_LAUNCH_UPDATE_VMSA, &vmsa, error);
+}
+
+static int sev_launch_update_vmsa(struct kvm *kvm, struct kvm_sev_cmd *argp)
+{
        struct kvm_vcpu *vcpu;
        int i, ret;
 
        if (!sev_es_guest(kvm))
                return -ENOTTY;
 
-       vmsa.reserved = 0;
-
        kvm_for_each_vcpu(i, vcpu, kvm) {
-               struct vcpu_svm *svm = to_svm(vcpu);
-
-               /* Perform some pre-encryption checks against the VMSA */
-               ret = sev_es_sync_vmsa(svm);
+               ret = mutex_lock_killable(&vcpu->mutex);
                if (ret)
                        return ret;
 
-               /*
-                * The LAUNCH_UPDATE_VMSA command will perform in-place
-                * encryption of the VMSA memory content (i.e it will write
-                * the same memory region with the guest's key), so invalidate
-                * it first.
-                */
-               clflush_cache_range(svm->vmsa, PAGE_SIZE);
+               ret = __sev_launch_update_vmsa(kvm, vcpu, &argp->error);
 
-               vmsa.handle = sev->handle;
-               vmsa.address = __sme_pa(svm->vmsa);
-               vmsa.len = PAGE_SIZE;
-               ret = sev_issue_cmd(kvm, SEV_CMD_LAUNCH_UPDATE_VMSA, &vmsa,
-                                   &argp->error);
+               mutex_unlock(&vcpu->mutex);
                if (ret)
                        return ret;
-
-               svm->vcpu.arch.guest_state_protected = true;
        }
 
        return 0;
@@ -1397,8 +1404,10 @@ static int sev_receive_start(struct kvm *kvm, struct kvm_sev_cmd *argp)
 
        /* Bind ASID to this guest */
        ret = sev_bind_asid(kvm, start.handle, error);
-       if (ret)
+       if (ret) {
+               sev_decommission(start.handle);
                goto e_free_session;
+       }
 
        params.handle = start.handle;
        if (copy_to_user((void __user *)(uintptr_t)argp->data,
@@ -1464,7 +1473,7 @@ static int sev_receive_update_data(struct kvm *kvm, struct kvm_sev_cmd *argp)
 
        /* Pin guest memory */
        guest_page = sev_pin_memory(kvm, params.guest_uaddr & PAGE_MASK,
-                                   PAGE_SIZE, &n, 0);
+                                   PAGE_SIZE, &n, 1);
        if (IS_ERR(guest_page)) {
                ret = PTR_ERR(guest_page);
                goto e_free_trans;
@@ -1501,6 +1510,20 @@ static int sev_receive_finish(struct kvm *kvm, struct kvm_sev_cmd *argp)
        return sev_issue_cmd(kvm, SEV_CMD_RECEIVE_FINISH, &data, &argp->error);
 }
 
+static bool cmd_allowed_from_miror(u32 cmd_id)
+{
+       /*
+        * Allow mirrors VM to call KVM_SEV_LAUNCH_UPDATE_VMSA to enable SEV-ES
+        * active mirror VMs. Also allow the debugging and status commands.
+        */
+       if (cmd_id == KVM_SEV_LAUNCH_UPDATE_VMSA ||
+           cmd_id == KVM_SEV_GUEST_STATUS || cmd_id == KVM_SEV_DBG_DECRYPT ||
+           cmd_id == KVM_SEV_DBG_ENCRYPT)
+               return true;
+
+       return false;
+}
+
 int svm_mem_enc_op(struct kvm *kvm, void __user *argp)
 {
        struct kvm_sev_cmd sev_cmd;
@@ -1517,8 +1540,9 @@ int svm_mem_enc_op(struct kvm *kvm, void __user *argp)
 
        mutex_lock(&kvm->lock);
 
-       /* enc_context_owner handles all memory enc operations */
-       if (is_mirroring_enc_context(kvm)) {
+       /* Only the enc_context_owner handles some memory enc operations. */
+       if (is_mirroring_enc_context(kvm) &&
+           !cmd_allowed_from_miror(sev_cmd.id)) {
                r = -EINVAL;
                goto out;
        }
@@ -1715,8 +1739,7 @@ int svm_vm_copy_asid_from(struct kvm *kvm, unsigned int source_fd)
 {
        struct file *source_kvm_file;
        struct kvm *source_kvm;
-       struct kvm_sev_info *mirror_sev;
-       unsigned int asid;
+       struct kvm_sev_info source_sev, *mirror_sev;
        int ret;
 
        source_kvm_file = fget(source_fd);
@@ -1739,7 +1762,8 @@ int svm_vm_copy_asid_from(struct kvm *kvm, unsigned int source_fd)
                goto e_source_unlock;
        }
 
-       asid = to_kvm_svm(source_kvm)->sev_info.asid;
+       memcpy(&source_sev, &to_kvm_svm(source_kvm)->sev_info,
+              sizeof(source_sev));
 
        /*
         * The mirror kvm holds an enc_context_owner ref so its asid can't
@@ -1759,8 +1783,16 @@ int svm_vm_copy_asid_from(struct kvm *kvm, unsigned int source_fd)
        /* Set enc_context_owner and copy its encryption context over */
        mirror_sev = &to_kvm_svm(kvm)->sev_info;
        mirror_sev->enc_context_owner = source_kvm;
-       mirror_sev->asid = asid;
        mirror_sev->active = true;
+       mirror_sev->asid = source_sev.asid;
+       mirror_sev->fd = source_sev.fd;
+       mirror_sev->es_active = source_sev.es_active;
+       mirror_sev->handle = source_sev.handle;
+       /*
+        * Do not copy ap_jump_table. Since the mirror does not share the same
+        * KVM contexts as the original, and they may have different
+        * memory-views.
+        */
 
        mutex_unlock(&kvm->lock);
        return 0;
index 05e8d4d..9896850 100644 (file)
@@ -1566,6 +1566,8 @@ static void svm_clear_vintr(struct vcpu_svm *svm)
 
                svm->vmcb->control.int_ctl |= svm->nested.ctl.int_ctl &
                        V_IRQ_INJECTION_BITS_MASK;
+
+               svm->vmcb->control.int_vector = svm->nested.ctl.int_vector;
        }
 
        vmcb_mark_dirty(svm->vmcb, VMCB_INTR);
@@ -2222,6 +2224,10 @@ static int gp_interception(struct kvm_vcpu *vcpu)
        if (error_code)
                goto reinject;
 
+       /* All SVM instructions expect page aligned RAX */
+       if (svm->vmcb->save.rax & ~PAGE_MASK)
+               goto reinject;
+
        /* Decode the instruction for usage later */
        if (x86_decode_emulated_instruction(vcpu, 0, NULL, 0) != EMULATION_OK)
                goto reinject;
@@ -4285,43 +4291,44 @@ static int svm_enter_smm(struct kvm_vcpu *vcpu, char *smstate)
        struct kvm_host_map map_save;
        int ret;
 
-       if (is_guest_mode(vcpu)) {
-               /* FED8h - SVM Guest */
-               put_smstate(u64, smstate, 0x7ed8, 1);
-               /* FEE0h - SVM Guest VMCB Physical Address */
-               put_smstate(u64, smstate, 0x7ee0, svm->nested.vmcb12_gpa);
+       if (!is_guest_mode(vcpu))
+               return 0;
 
-               svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
-               svm->vmcb->save.rsp = vcpu->arch.regs[VCPU_REGS_RSP];
-               svm->vmcb->save.rip = vcpu->arch.regs[VCPU_REGS_RIP];
+       /* FED8h - SVM Guest */
+       put_smstate(u64, smstate, 0x7ed8, 1);
+       /* FEE0h - SVM Guest VMCB Physical Address */
+       put_smstate(u64, smstate, 0x7ee0, svm->nested.vmcb12_gpa);
 
-               ret = nested_svm_vmexit(svm);
-               if (ret)
-                       return ret;
+       svm->vmcb->save.rax = vcpu->arch.regs[VCPU_REGS_RAX];
+       svm->vmcb->save.rsp = vcpu->arch.regs[VCPU_REGS_RSP];
+       svm->vmcb->save.rip = vcpu->arch.regs[VCPU_REGS_RIP];
 
-               /*
-                * KVM uses VMCB01 to store L1 host state while L2 runs but
-                * VMCB01 is going to be used during SMM and thus the state will
-                * be lost. Temporary save non-VMLOAD/VMSAVE state to the host save
-                * area pointed to by MSR_VM_HSAVE_PA. APM guarantees that the
-                * format of the area is identical to guest save area offsetted
-                * by 0x400 (matches the offset of 'struct vmcb_save_area'
-                * within 'struct vmcb'). Note: HSAVE area may also be used by
-                * L1 hypervisor to save additional host context (e.g. KVM does
-                * that, see svm_prepare_guest_switch()) which must be
-                * preserved.
-                */
-               if (kvm_vcpu_map(vcpu, gpa_to_gfn(svm->nested.hsave_msr),
-                                &map_save) == -EINVAL)
-                       return 1;
+       ret = nested_svm_vmexit(svm);
+       if (ret)
+               return ret;
 
-               BUILD_BUG_ON(offsetof(struct vmcb, save) != 0x400);
+       /*
+        * KVM uses VMCB01 to store L1 host state while L2 runs but
+        * VMCB01 is going to be used during SMM and thus the state will
+        * be lost. Temporary save non-VMLOAD/VMSAVE state to the host save
+        * area pointed to by MSR_VM_HSAVE_PA. APM guarantees that the
+        * format of the area is identical to guest save area offsetted
+        * by 0x400 (matches the offset of 'struct vmcb_save_area'
+        * within 'struct vmcb'). Note: HSAVE area may also be used by
+        * L1 hypervisor to save additional host context (e.g. KVM does
+        * that, see svm_prepare_guest_switch()) which must be
+        * preserved.
+        */
+       if (kvm_vcpu_map(vcpu, gpa_to_gfn(svm->nested.hsave_msr),
+                        &map_save) == -EINVAL)
+               return 1;
 
-               svm_copy_vmrun_state(map_save.hva + 0x400,
-                                    &svm->vmcb01.ptr->save);
+       BUILD_BUG_ON(offsetof(struct vmcb, save) != 0x400);
 
-               kvm_vcpu_unmap(vcpu, &map_save, true);
-       }
+       svm_copy_vmrun_state(map_save.hva + 0x400,
+                            &svm->vmcb01.ptr->save);
+
+       kvm_vcpu_unmap(vcpu, &map_save, true);
        return 0;
 }
 
@@ -4329,50 +4336,54 @@ static int svm_leave_smm(struct kvm_vcpu *vcpu, const char *smstate)
 {
        struct vcpu_svm *svm = to_svm(vcpu);
        struct kvm_host_map map, map_save;
-       int ret = 0;
+       u64 saved_efer, vmcb12_gpa;
+       struct vmcb *vmcb12;
+       int ret;
 
-       if (guest_cpuid_has(vcpu, X86_FEATURE_LM)) {
-               u64 saved_efer = GET_SMSTATE(u64, smstate, 0x7ed0);
-               u64 guest = GET_SMSTATE(u64, smstate, 0x7ed8);
-               u64 vmcb12_gpa = GET_SMSTATE(u64, smstate, 0x7ee0);
-               struct vmcb *vmcb12;
+       if (!guest_cpuid_has(vcpu, X86_FEATURE_LM))
+               return 0;
 
-               if (guest) {
-                       if (!guest_cpuid_has(vcpu, X86_FEATURE_SVM))
-                               return 1;
+       /* Non-zero if SMI arrived while vCPU was in guest mode. */
+       if (!GET_SMSTATE(u64, smstate, 0x7ed8))
+               return 0;
 
-                       if (!(saved_efer & EFER_SVME))
-                               return 1;
+       if (!guest_cpuid_has(vcpu, X86_FEATURE_SVM))
+               return 1;
 
-                       if (kvm_vcpu_map(vcpu,
-                                        gpa_to_gfn(vmcb12_gpa), &map) == -EINVAL)
-                               return 1;
+       saved_efer = GET_SMSTATE(u64, smstate, 0x7ed0);
+       if (!(saved_efer & EFER_SVME))
+               return 1;
 
-                       if (svm_allocate_nested(svm))
-                               return 1;
+       vmcb12_gpa = GET_SMSTATE(u64, smstate, 0x7ee0);
+       if (kvm_vcpu_map(vcpu, gpa_to_gfn(vmcb12_gpa), &map) == -EINVAL)
+               return 1;
 
-                       vmcb12 = map.hva;
+       ret = 1;
+       if (kvm_vcpu_map(vcpu, gpa_to_gfn(svm->nested.hsave_msr), &map_save) == -EINVAL)
+               goto unmap_map;
 
-                       nested_load_control_from_vmcb12(svm, &vmcb12->control);
+       if (svm_allocate_nested(svm))
+               goto unmap_save;
 
-                       ret = enter_svm_guest_mode(vcpu, vmcb12_gpa, vmcb12);
-                       kvm_vcpu_unmap(vcpu, &map, true);
+       /*
+        * Restore L1 host state from L1 HSAVE area as VMCB01 was
+        * used during SMM (see svm_enter_smm())
+        */
 
-                       /*
-                        * Restore L1 host state from L1 HSAVE area as VMCB01 was
-                        * used during SMM (see svm_enter_smm())
-                        */
-                       if (kvm_vcpu_map(vcpu, gpa_to_gfn(svm->nested.hsave_msr),
-                                        &map_save) == -EINVAL)
-                               return 1;
+       svm_copy_vmrun_state(&svm->vmcb01.ptr->save, map_save.hva + 0x400);
 
-                       svm_copy_vmrun_state(&svm->vmcb01.ptr->save,
-                                            map_save.hva + 0x400);
+       /*
+        * Enter the nested guest now
+        */
 
-                       kvm_vcpu_unmap(vcpu, &map_save, true);
-               }
-       }
+       vmcb12 = map.hva;
+       nested_load_control_from_vmcb12(svm, &vmcb12->control);
+       ret = enter_svm_guest_mode(vcpu, vmcb12_gpa, vmcb12, false);
 
+unmap_save:
+       kvm_vcpu_unmap(vcpu, &map_save, true);
+unmap_map:
+       kvm_vcpu_unmap(vcpu, &map, true);
        return ret;
 }
 
index 524d943..128a54b 100644 (file)
@@ -459,7 +459,8 @@ static inline bool nested_exit_on_nmi(struct vcpu_svm *svm)
        return vmcb_is_intercept(&svm->nested.ctl, INTERCEPT_NMI);
 }
 
-int enter_svm_guest_mode(struct kvm_vcpu *vcpu, u64 vmcb_gpa, struct vmcb *vmcb12);
+int enter_svm_guest_mode(struct kvm_vcpu *vcpu,
+                        u64 vmcb_gpa, struct vmcb *vmcb12, bool from_vmrun);
 void svm_leave_nested(struct vcpu_svm *svm);
 void svm_free_nested(struct vcpu_svm *svm);
 int svm_allocate_nested(struct vcpu_svm *svm);
index 0dab1b7..ba6f99f 100644 (file)
@@ -353,14 +353,20 @@ void nested_evmcs_filter_control_msr(u32 msr_index, u64 *pdata)
        switch (msr_index) {
        case MSR_IA32_VMX_EXIT_CTLS:
        case MSR_IA32_VMX_TRUE_EXIT_CTLS:
-               ctl_high &= ~VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL;
+               ctl_high &= ~EVMCS1_UNSUPPORTED_VMEXIT_CTRL;
                break;
        case MSR_IA32_VMX_ENTRY_CTLS:
        case MSR_IA32_VMX_TRUE_ENTRY_CTLS:
-               ctl_high &= ~VM_ENTRY_LOAD_IA32_PERF_GLOBAL_CTRL;
+               ctl_high &= ~EVMCS1_UNSUPPORTED_VMENTRY_CTRL;
                break;
        case MSR_IA32_VMX_PROCBASED_CTLS2:
-               ctl_high &= ~SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES;
+               ctl_high &= ~EVMCS1_UNSUPPORTED_2NDEXEC;
+               break;
+       case MSR_IA32_VMX_PINBASED_CTLS:
+               ctl_high &= ~EVMCS1_UNSUPPORTED_PINCTRL;
+               break;
+       case MSR_IA32_VMX_VMFUNC:
+               ctl_low &= ~EVMCS1_UNSUPPORTED_VMFUNC;
                break;
        }
 
index ccb03d6..eedcebf 100644 (file)
@@ -2583,8 +2583,13 @@ static int prepare_vmcs02(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
         * Guest state is invalid and unrestricted guest is disabled,
         * which means L1 attempted VMEntry to L2 with invalid state.
         * Fail the VMEntry.
+        *
+        * However when force loading the guest state (SMM exit or
+        * loading nested state after migration, it is possible to
+        * have invalid guest state now, which will be later fixed by
+        * restoring L2 register state
         */
-       if (CC(!vmx_guest_state_valid(vcpu))) {
+       if (CC(from_vmentry && !vmx_guest_state_valid(vcpu))) {
                *entry_failure_code = ENTRY_FAIL_DEFAULT;
                return -EINVAL;
        }
@@ -4351,6 +4356,8 @@ static void load_vmcs12_host_state(struct kvm_vcpu *vcpu,
        if (nested_vmx_load_msr(vcpu, vmcs12->vm_exit_msr_load_addr,
                                vmcs12->vm_exit_msr_load_count))
                nested_vmx_abort(vcpu, VMX_ABORT_LOAD_HOST_MSR_FAIL);
+
+       to_vmx(vcpu)->emulation_required = vmx_emulation_required(vcpu);
 }
 
 static inline u64 nested_vmx_get_vmcs01_guest_efer(struct vcpu_vmx *vmx)
@@ -4899,14 +4906,7 @@ out_vmcs02:
        return -ENOMEM;
 }
 
-/*
- * Emulate the VMXON instruction.
- * Currently, we just remember that VMX is active, and do not save or even
- * inspect the argument to VMXON (the so-called "VMXON pointer") because we
- * do not currently need to store anything in that guest-allocated memory
- * region. Consequently, VMCLEAR and VMPTRLD also do not verify that the their
- * argument is different from the VMXON pointer (which the spec says they do).
- */
+/* Emulate the VMXON instruction. */
 static int handle_vmon(struct kvm_vcpu *vcpu)
 {
        int ret;
@@ -5903,6 +5903,12 @@ static bool nested_vmx_l0_wants_exit(struct kvm_vcpu *vcpu,
        case EXIT_REASON_VMFUNC:
                /* VM functions are emulated through L2->L0 vmexits. */
                return true;
+       case EXIT_REASON_BUS_LOCK:
+               /*
+                * At present, bus lock VM exit is never exposed to L1.
+                * Handle L2's bus locks in L0 directly.
+                */
+               return true;
        default:
                break;
        }
index 0c2c0d5..116b089 100644 (file)
@@ -1323,7 +1323,7 @@ static void vmx_vcpu_put(struct kvm_vcpu *vcpu)
        vmx_prepare_switch_to_host(to_vmx(vcpu));
 }
 
-static bool emulation_required(struct kvm_vcpu *vcpu)
+bool vmx_emulation_required(struct kvm_vcpu *vcpu)
 {
        return emulate_invalid_guest_state && !vmx_guest_state_valid(vcpu);
 }
@@ -1367,7 +1367,7 @@ void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags)
        vmcs_writel(GUEST_RFLAGS, rflags);
 
        if ((old_rflags ^ vmx->rflags) & X86_EFLAGS_VM)
-               vmx->emulation_required = emulation_required(vcpu);
+               vmx->emulation_required = vmx_emulation_required(vcpu);
 }
 
 u32 vmx_get_interrupt_shadow(struct kvm_vcpu *vcpu)
@@ -1837,10 +1837,11 @@ static int vmx_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
                                    &msr_info->data))
                        return 1;
                /*
-                * Enlightened VMCS v1 doesn't have certain fields, but buggy
-                * Hyper-V versions are still trying to use corresponding
-                * features when they are exposed. Filter out the essential
-                * minimum.
+                * Enlightened VMCS v1 doesn't have certain VMCS fields but
+                * instead of just ignoring the features, different Hyper-V
+                * versions are either trying to use them and fail or do some
+                * sanity checking and refuse to boot. Filter all unsupported
+                * features out.
                 */
                if (!msr_info->host_initiated &&
                    vmx->nested.enlightened_vmcs_enabled)
@@ -3077,7 +3078,7 @@ void vmx_set_cr0(struct kvm_vcpu *vcpu, unsigned long cr0)
        }
 
        /* depends on vcpu->arch.cr0 to be set to a new value */
-       vmx->emulation_required = emulation_required(vcpu);
+       vmx->emulation_required = vmx_emulation_required(vcpu);
 }
 
 static int vmx_get_max_tdp_level(void)
@@ -3330,7 +3331,7 @@ static void vmx_set_segment(struct kvm_vcpu *vcpu, struct kvm_segment *var, int
 {
        __vmx_set_segment(vcpu, var, seg);
 
-       to_vmx(vcpu)->emulation_required = emulation_required(vcpu);
+       to_vmx(vcpu)->emulation_required = vmx_emulation_required(vcpu);
 }
 
 static void vmx_get_cs_db_l_bits(struct kvm_vcpu *vcpu, int *db, int *l)
@@ -6621,10 +6622,24 @@ static fastpath_t vmx_vcpu_run(struct kvm_vcpu *vcpu)
                     vmx->loaded_vmcs->soft_vnmi_blocked))
                vmx->loaded_vmcs->entry_time = ktime_get();
 
-       /* Don't enter VMX if guest state is invalid, let the exit handler
-          start emulation until we arrive back to a valid state */
-       if (vmx->emulation_required)
+       /*
+        * Don't enter VMX if guest state is invalid, let the exit handler
+        * start emulation until we arrive back to a valid state.  Synthesize a
+        * consistency check VM-Exit due to invalid guest state and bail.
+        */
+       if (unlikely(vmx->emulation_required)) {
+
+               /* We don't emulate invalid state of a nested guest */
+               vmx->fail = is_guest_mode(vcpu);
+
+               vmx->exit_reason.full = EXIT_REASON_INVALID_STATE;
+               vmx->exit_reason.failed_vmentry = 1;
+               kvm_register_mark_available(vcpu, VCPU_EXREG_EXIT_INFO_1);
+               vmx->exit_qualification = ENTRY_FAIL_DEFAULT;
+               kvm_register_mark_available(vcpu, VCPU_EXREG_EXIT_INFO_2);
+               vmx->exit_intr_info = 0;
                return EXIT_FASTPATH_NONE;
+       }
 
        trace_kvm_entry(vcpu);
 
@@ -6833,7 +6848,7 @@ static int vmx_create_vcpu(struct kvm_vcpu *vcpu)
                 */
                tsx_ctrl = vmx_find_uret_msr(vmx, MSR_IA32_TSX_CTRL);
                if (tsx_ctrl)
-                       vmx->guest_uret_msrs[i].mask = ~(u64)TSX_CTRL_CPUID_CLEAR;
+                       tsx_ctrl->mask = ~(u64)TSX_CTRL_CPUID_CLEAR;
        }
 
        err = alloc_loaded_vmcs(&vmx->vmcs01);
index 4858c5f..592217f 100644 (file)
@@ -248,12 +248,8 @@ struct vcpu_vmx {
         * only loaded into hardware when necessary, e.g. SYSCALL #UDs outside
         * of 64-bit mode or if EFER.SCE=1, thus the SYSCALL MSRs don't need to
         * be loaded into hardware if those conditions aren't met.
-        * nr_active_uret_msrs tracks the number of MSRs that need to be loaded
-        * into hardware when running the guest.  guest_uret_msrs[] is resorted
-        * whenever the number of "active" uret MSRs is modified.
         */
        struct vmx_uret_msr   guest_uret_msrs[MAX_NR_USER_RETURN_MSRS];
-       int                   nr_active_uret_msrs;
        bool                  guest_uret_msrs_loaded;
 #ifdef CONFIG_X86_64
        u64                   msr_host_kernel_gs_base;
@@ -359,6 +355,7 @@ void vmx_prepare_switch_to_guest(struct kvm_vcpu *vcpu);
 void vmx_set_host_fs_gs(struct vmcs_host_state *host, u16 fs_sel, u16 gs_sel,
                        unsigned long fs_base, unsigned long gs_base);
 int vmx_get_cpl(struct kvm_vcpu *vcpu);
+bool vmx_emulation_required(struct kvm_vcpu *vcpu);
 unsigned long vmx_get_rflags(struct kvm_vcpu *vcpu);
 void vmx_set_rflags(struct kvm_vcpu *vcpu, unsigned long rflags);
 u32 vmx_get_interrupt_shadow(struct kvm_vcpu *vcpu);
index 28ef141..aabd3a2 100644 (file)
@@ -1332,6 +1332,13 @@ static const u32 msrs_to_save_all[] = {
        MSR_ARCH_PERFMON_EVENTSEL0 + 12, MSR_ARCH_PERFMON_EVENTSEL0 + 13,
        MSR_ARCH_PERFMON_EVENTSEL0 + 14, MSR_ARCH_PERFMON_EVENTSEL0 + 15,
        MSR_ARCH_PERFMON_EVENTSEL0 + 16, MSR_ARCH_PERFMON_EVENTSEL0 + 17,
+
+       MSR_K7_EVNTSEL0, MSR_K7_EVNTSEL1, MSR_K7_EVNTSEL2, MSR_K7_EVNTSEL3,
+       MSR_K7_PERFCTR0, MSR_K7_PERFCTR1, MSR_K7_PERFCTR2, MSR_K7_PERFCTR3,
+       MSR_F15H_PERF_CTL0, MSR_F15H_PERF_CTL1, MSR_F15H_PERF_CTL2,
+       MSR_F15H_PERF_CTL3, MSR_F15H_PERF_CTL4, MSR_F15H_PERF_CTL5,
+       MSR_F15H_PERF_CTR0, MSR_F15H_PERF_CTR1, MSR_F15H_PERF_CTR2,
+       MSR_F15H_PERF_CTR3, MSR_F15H_PERF_CTR4, MSR_F15H_PERF_CTR5,
 };
 
 static u32 msrs_to_save[ARRAY_SIZE(msrs_to_save_all)];
@@ -2969,7 +2976,7 @@ static int kvm_guest_time_update(struct kvm_vcpu *v)
                                       offsetof(struct compat_vcpu_info, time));
        if (vcpu->xen.vcpu_time_info_set)
                kvm_setup_pvclock_page(v, &vcpu->xen.vcpu_time_info_cache, 0);
-       if (v == kvm_get_vcpu(v->kvm, 0))
+       if (!v->vcpu_idx)
                kvm_hv_setup_tsc_page(v->kvm, &vcpu->hv_clock);
        return 0;
 }
@@ -7658,6 +7665,13 @@ static void kvm_smm_changed(struct kvm_vcpu *vcpu, bool entering_smm)
 
                /* Process a latched INIT or SMI, if any.  */
                kvm_make_request(KVM_REQ_EVENT, vcpu);
+
+               /*
+                * Even if KVM_SET_SREGS2 loaded PDPTRs out of band,
+                * on SMM exit we still need to reload them from
+                * guest memory
+                */
+               vcpu->arch.pdptrs_from_userspace = false;
        }
 
        kvm_mmu_reset_context(vcpu);
@@ -10652,6 +10666,8 @@ int kvm_arch_vcpu_create(struct kvm_vcpu *vcpu)
        int r;
 
        vcpu->arch.last_vmentry_cpu = -1;
+       vcpu->arch.regs_avail = ~0;
+       vcpu->arch.regs_dirty = ~0;
 
        if (!irqchip_in_kernel(vcpu->kvm) || kvm_vcpu_is_reset_bsp(vcpu))
                vcpu->arch.mp_state = KVM_MP_STATE_RUNNABLE;
@@ -10893,6 +10909,9 @@ void kvm_vcpu_reset(struct kvm_vcpu *vcpu, bool init_event)
        kvm_set_rflags(vcpu, X86_EFLAGS_FIXED);
        kvm_rip_write(vcpu, 0xfff0);
 
+       vcpu->arch.cr3 = 0;
+       kvm_register_mark_dirty(vcpu, VCPU_EXREG_CR3);
+
        /*
         * CR0.CD/NW are set on RESET, preserved on INIT.  Note, some versions
         * of Intel's SDM list CD/NW as being set on INIT, but they contradict
@@ -11139,9 +11158,15 @@ void kvm_arch_free_vm(struct kvm *kvm)
 
 int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
 {
+       int ret;
+
        if (type)
                return -EINVAL;
 
+       ret = kvm_page_track_init(kvm);
+       if (ret)
+               return ret;
+
        INIT_HLIST_HEAD(&kvm->arch.mask_notifier_list);
        INIT_LIST_HEAD(&kvm->arch.active_mmu_pages);
        INIT_LIST_HEAD(&kvm->arch.zapped_obsolete_pages);
@@ -11174,7 +11199,6 @@ int kvm_arch_init_vm(struct kvm *kvm, unsigned long type)
 
        kvm_apicv_init(kvm);
        kvm_hv_init_vm(kvm);
-       kvm_page_track_init(kvm);
        kvm_mmu_init_vm(kvm);
        kvm_xen_init_vm(kvm);
 
index 058f19b..c565def 100644 (file)
        ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr)
 
 #define __get_next(t, insn)    \
-       ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); leXX_to_cpu(t, r); })
+       ({ t r; memcpy(&r, insn->next_byte, sizeof(t)); insn->next_byte += sizeof(t); leXX_to_cpu(t, r); })
 
 #define __peek_nbyte_next(t, insn, n)  \
-       ({ t r = *(t*)((insn)->next_byte + n); leXX_to_cpu(t, r); })
+       ({ t r; memcpy(&r, (insn)->next_byte + n, sizeof(t)); leXX_to_cpu(t, r); })
 
 #define get_next(t, insn)      \
        ({ if (unlikely(!validate_next(t, insn, 0))) goto err_out; __get_next(t, insn); })
index b2eefde..84a2c8c 100644 (file)
@@ -710,7 +710,8 @@ oops:
 
 static noinline void
 kernelmode_fixup_or_oops(struct pt_regs *regs, unsigned long error_code,
-                        unsigned long address, int signal, int si_code)
+                        unsigned long address, int signal, int si_code,
+                        u32 pkey)
 {
        WARN_ON_ONCE(user_mode(regs));
 
@@ -735,8 +736,12 @@ kernelmode_fixup_or_oops(struct pt_regs *regs, unsigned long error_code,
 
                        set_signal_archinfo(address, error_code);
 
-                       /* XXX: hwpoison faults will set the wrong code. */
-                       force_sig_fault(signal, si_code, (void __user *)address);
+                       if (si_code == SEGV_PKUERR) {
+                               force_sig_pkuerr((void __user *)address, pkey);
+                       } else {
+                               /* XXX: hwpoison faults will set the wrong code. */
+                               force_sig_fault(signal, si_code, (void __user *)address);
+                       }
                }
 
                /*
@@ -798,7 +803,8 @@ __bad_area_nosemaphore(struct pt_regs *regs, unsigned long error_code,
        struct task_struct *tsk = current;
 
        if (!user_mode(regs)) {
-               kernelmode_fixup_or_oops(regs, error_code, address, pkey, si_code);
+               kernelmode_fixup_or_oops(regs, error_code, address,
+                                        SIGSEGV, si_code, pkey);
                return;
        }
 
@@ -930,7 +936,8 @@ do_sigbus(struct pt_regs *regs, unsigned long error_code, unsigned long address,
 {
        /* Kernel mode? Handle exceptions or die: */
        if (!user_mode(regs)) {
-               kernelmode_fixup_or_oops(regs, error_code, address, SIGBUS, BUS_ADRERR);
+               kernelmode_fixup_or_oops(regs, error_code, address,
+                                        SIGBUS, BUS_ADRERR, ARCH_DEFAULT_PKEY);
                return;
        }
 
@@ -1396,7 +1403,8 @@ good_area:
                 */
                if (!user_mode(regs))
                        kernelmode_fixup_or_oops(regs, error_code, address,
-                                                SIGBUS, BUS_ADRERR);
+                                                SIGBUS, BUS_ADRERR,
+                                                ARCH_DEFAULT_PKEY);
                return;
        }
 
@@ -1416,7 +1424,8 @@ good_area:
                return;
 
        if (fatal_signal_pending(current) && !user_mode(regs)) {
-               kernelmode_fixup_or_oops(regs, error_code, address, 0, 0);
+               kernelmode_fixup_or_oops(regs, error_code, address,
+                                        0, 0, ARCH_DEFAULT_PKEY);
                return;
        }
 
@@ -1424,7 +1433,8 @@ good_area:
                /* Kernel mode? Handle exceptions or die: */
                if (!user_mode(regs)) {
                        kernelmode_fixup_or_oops(regs, error_code, address,
-                                                SIGSEGV, SEGV_MAPERR);
+                                                SIGSEGV, SEGV_MAPERR,
+                                                ARCH_DEFAULT_PKEY);
                        return;
                }
 
index a6e1176..3609822 100644 (file)
@@ -1432,18 +1432,18 @@ int kern_addr_valid(unsigned long addr)
                return 0;
 
        p4d = p4d_offset(pgd, addr);
-       if (p4d_none(*p4d))
+       if (!p4d_present(*p4d))
                return 0;
 
        pud = pud_offset(p4d, addr);
-       if (pud_none(*pud))
+       if (!pud_present(*pud))
                return 0;
 
        if (pud_large(*pud))
                return pfn_valid(pud_pfn(*pud));
 
        pmd = pmd_offset(pud, addr);
-       if (pmd_none(*pmd))
+       if (!pmd_present(*pmd))
                return 0;
 
        if (pmd_large(*pmd))
index 1a50434..ef88537 100644 (file)
@@ -49,8 +49,7 @@ static void __init kasan_populate_pmd(pmd_t *pmd, unsigned long addr,
                        p = early_alloc(PMD_SIZE, nid, false);
                        if (p && pmd_set_huge(pmd, __pa(p), PAGE_KERNEL))
                                return;
-                       else if (p)
-                               memblock_free(__pa(p), PMD_SIZE);
+                       memblock_free_ptr(p, PMD_SIZE);
                }
 
                p = early_alloc(PAGE_SIZE, nid, true);
@@ -86,8 +85,7 @@ static void __init kasan_populate_pud(pud_t *pud, unsigned long addr,
                        p = early_alloc(PUD_SIZE, nid, false);
                        if (p && pud_set_huge(pud, __pa(p), PAGE_KERNEL))
                                return;
-                       else if (p)
-                               memblock_free(__pa(p), PUD_SIZE);
+                       memblock_free_ptr(p, PUD_SIZE);
                }
 
                p = early_alloc(PAGE_SIZE, nid, true);
index a1b5c71..1e9b93b 100644 (file)
@@ -355,7 +355,7 @@ void __init numa_reset_distance(void)
 
        /* numa_distance could be 1LU marking allocation failure, test cnt */
        if (numa_distance_cnt)
-               memblock_free(__pa(numa_distance), size);
+               memblock_free_ptr(numa_distance, size);
        numa_distance_cnt = 0;
        numa_distance = NULL;   /* enable table creation */
 }
index 737491b..e801e30 100644 (file)
@@ -517,8 +517,7 @@ void __init numa_emulation(struct numa_meminfo *numa_meminfo, int numa_dist_cnt)
        }
 
        /* free the copied physical distance table */
-       if (phys_dist)
-               memblock_free(__pa(phys_dist), phys_size);
+       memblock_free_ptr(phys_dist, phys_size);
        return;
 
 no_emu:
index 3112ca7..4ba2a3e 100644 (file)
@@ -583,7 +583,12 @@ int memtype_reserve(u64 start, u64 end, enum page_cache_mode req_type,
        int err = 0;
 
        start = sanitize_phys(start);
-       end = sanitize_phys(end);
+
+       /*
+        * The end address passed into this function is exclusive, but
+        * sanitize_phys() expects an inclusive address.
+        */
+       end = sanitize_phys(end - 1) + 1;
        if (start >= end) {
                WARN(1, "%s failed: [mem %#010Lx-%#010Lx], req %s\n", __func__,
                                start, end - 1, cattr_name(req_type));
index 0fe6aac..9ea5738 100644 (file)
@@ -1341,9 +1341,10 @@ st:                      if (is_imm8(insn->off))
                        if (insn->imm == (BPF_AND | BPF_FETCH) ||
                            insn->imm == (BPF_OR | BPF_FETCH) ||
                            insn->imm == (BPF_XOR | BPF_FETCH)) {
-                               u8 *branch_target;
                                bool is64 = BPF_SIZE(insn->code) == BPF_DW;
                                u32 real_src_reg = src_reg;
+                               u32 real_dst_reg = dst_reg;
+                               u8 *branch_target;
 
                                /*
                                 * Can't be implemented with a single x86 insn.
@@ -1354,11 +1355,13 @@ st:                     if (is_imm8(insn->off))
                                emit_mov_reg(&prog, true, BPF_REG_AX, BPF_REG_0);
                                if (src_reg == BPF_REG_0)
                                        real_src_reg = BPF_REG_AX;
+                               if (dst_reg == BPF_REG_0)
+                                       real_dst_reg = BPF_REG_AX;
 
                                branch_target = prog;
                                /* Load old value */
                                emit_ldx(&prog, BPF_SIZE(insn->code),
-                                        BPF_REG_0, dst_reg, insn->off);
+                                        BPF_REG_0, real_dst_reg, insn->off);
                                /*
                                 * Perform the (commutative) operation locally,
                                 * put the result in the AUX_REG.
@@ -1369,7 +1372,8 @@ st:                       if (is_imm8(insn->off))
                                      add_2reg(0xC0, AUX_REG, real_src_reg));
                                /* Attempt to swap in new value */
                                err = emit_atomic(&prog, BPF_CMPXCHG,
-                                                 dst_reg, AUX_REG, insn->off,
+                                                 real_dst_reg, AUX_REG,
+                                                 insn->off,
                                                  BPF_SIZE(insn->code));
                                if (WARN_ON(err))
                                        return err;
@@ -1383,11 +1387,10 @@ st:                     if (is_imm8(insn->off))
                                /* Restore R0 after clobbering RAX */
                                emit_mov_reg(&prog, true, BPF_REG_0, BPF_REG_AX);
                                break;
-
                        }
 
                        err = emit_atomic(&prog, insn->imm, dst_reg, src_reg,
-                                                 insn->off, BPF_SIZE(insn->code));
+                                         insn->off, BPF_SIZE(insn->code));
                        if (err)
                                return err;
                        break;
@@ -1744,7 +1747,7 @@ static void restore_regs(const struct btf_func_model *m, u8 **prog, int nr_args,
 }
 
 static int invoke_bpf_prog(const struct btf_func_model *m, u8 **pprog,
-                          struct bpf_prog *p, int stack_size, bool mod_ret)
+                          struct bpf_prog *p, int stack_size, bool save_ret)
 {
        u8 *prog = *pprog;
        u8 *jmp_insn;
@@ -1777,11 +1780,15 @@ static int invoke_bpf_prog(const struct btf_func_model *m, u8 **pprog,
        if (emit_call(&prog, p->bpf_func, prog))
                return -EINVAL;
 
-       /* BPF_TRAMP_MODIFY_RETURN trampolines can modify the return
+       /*
+        * BPF_TRAMP_MODIFY_RETURN trampolines can modify the return
         * of the previous call which is then passed on the stack to
         * the next BPF program.
+        *
+        * BPF_TRAMP_FENTRY trampoline may need to return the return
+        * value of BPF_PROG_TYPE_STRUCT_OPS prog.
         */
-       if (mod_ret)
+       if (save_ret)
                emit_stx(&prog, BPF_DW, BPF_REG_FP, BPF_REG_0, -8);
 
        /* replace 2 nops with JE insn, since jmp target is known */
@@ -1828,13 +1835,15 @@ static int emit_cond_near_jump(u8 **pprog, void *func, void *ip, u8 jmp_cond)
 }
 
 static int invoke_bpf(const struct btf_func_model *m, u8 **pprog,
-                     struct bpf_tramp_progs *tp, int stack_size)
+                     struct bpf_tramp_progs *tp, int stack_size,
+                     bool save_ret)
 {
        int i;
        u8 *prog = *pprog;
 
        for (i = 0; i < tp->nr_progs; i++) {
-               if (invoke_bpf_prog(m, &prog, tp->progs[i], stack_size, false))
+               if (invoke_bpf_prog(m, &prog, tp->progs[i], stack_size,
+                                   save_ret))
                        return -EINVAL;
        }
        *pprog = prog;
@@ -1877,6 +1886,23 @@ static int invoke_bpf_mod_ret(const struct btf_func_model *m, u8 **pprog,
        return 0;
 }
 
+static bool is_valid_bpf_tramp_flags(unsigned int flags)
+{
+       if ((flags & BPF_TRAMP_F_RESTORE_REGS) &&
+           (flags & BPF_TRAMP_F_SKIP_FRAME))
+               return false;
+
+       /*
+        * BPF_TRAMP_F_RET_FENTRY_RET is only used by bpf_struct_ops,
+        * and it must be used alone.
+        */
+       if ((flags & BPF_TRAMP_F_RET_FENTRY_RET) &&
+           (flags & ~BPF_TRAMP_F_RET_FENTRY_RET))
+               return false;
+
+       return true;
+}
+
 /* Example:
  * __be16 eth_type_trans(struct sk_buff *skb, struct net_device *dev);
  * its 'struct btf_func_model' will be nr_args=2
@@ -1949,17 +1975,19 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i
        struct bpf_tramp_progs *fmod_ret = &tprogs[BPF_TRAMP_MODIFY_RETURN];
        u8 **branches = NULL;
        u8 *prog;
+       bool save_ret;
 
        /* x86-64 supports up to 6 arguments. 7+ can be added in the future */
        if (nr_args > 6)
                return -ENOTSUPP;
 
-       if ((flags & BPF_TRAMP_F_RESTORE_REGS) &&
-           (flags & BPF_TRAMP_F_SKIP_FRAME))
+       if (!is_valid_bpf_tramp_flags(flags))
                return -EINVAL;
 
-       if (flags & BPF_TRAMP_F_CALL_ORIG)
-               stack_size += 8; /* room for return value of orig_call */
+       /* room for return value of orig_call or fentry prog */
+       save_ret = flags & (BPF_TRAMP_F_CALL_ORIG | BPF_TRAMP_F_RET_FENTRY_RET);
+       if (save_ret)
+               stack_size += 8;
 
        if (flags & BPF_TRAMP_F_IP_ARG)
                stack_size += 8; /* room for IP address argument */
@@ -2005,7 +2033,8 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i
        }
 
        if (fentry->nr_progs)
-               if (invoke_bpf(m, &prog, fentry, stack_size))
+               if (invoke_bpf(m, &prog, fentry, stack_size,
+                              flags & BPF_TRAMP_F_RET_FENTRY_RET))
                        return -EINVAL;
 
        if (fmod_ret->nr_progs) {
@@ -2052,7 +2081,7 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i
        }
 
        if (fexit->nr_progs)
-               if (invoke_bpf(m, &prog, fexit, stack_size)) {
+               if (invoke_bpf(m, &prog, fexit, stack_size, false)) {
                        ret = -EINVAL;
                        goto cleanup;
                }
@@ -2072,9 +2101,10 @@ int arch_prepare_bpf_trampoline(struct bpf_tramp_image *im, void *image, void *i
                        ret = -EINVAL;
                        goto cleanup;
                }
-               /* restore original return value back into RAX */
-               emit_ldx(&prog, BPF_DW, BPF_REG_0, BPF_REG_FP, -8);
        }
+       /* restore return value of orig_call or fentry prog back into RAX */
+       if (save_ret)
+               emit_ldx(&prog, BPF_DW, BPF_REG_0, BPF_REG_FP, -8);
 
        EMIT1(0x5B); /* pop rbx */
        EMIT1(0xC9); /* leave */
index 3d41a09..5debe4a 100644 (file)
@@ -113,7 +113,7 @@ static int acpi_register_gsi_xen_hvm(struct device *dev, u32 gsi,
                                 false /* no mapping of GSI to PIRQ */);
 }
 
-#ifdef CONFIG_XEN_DOM0
+#ifdef CONFIG_XEN_PV_DOM0
 static int xen_register_gsi(u32 gsi, int triggering, int polarity)
 {
        int rc, irq;
@@ -261,7 +261,7 @@ error:
        return irq;
 }
 
-#ifdef CONFIG_XEN_DOM0
+#ifdef CONFIG_XEN_PV_DOM0
 static bool __read_mostly pci_seg_supported = true;
 
 static int xen_initdom_setup_msi_irqs(struct pci_dev *dev, int nvec, int type)
@@ -375,10 +375,10 @@ static void xen_initdom_restore_msi_irqs(struct pci_dev *dev)
                WARN(ret && ret != -ENOSYS, "restore_msi -> %d\n", ret);
        }
 }
-#else /* CONFIG_XEN_DOM0 */
+#else /* CONFIG_XEN_PV_DOM0 */
 #define xen_initdom_setup_msi_irqs     NULL
 #define xen_initdom_restore_msi_irqs   NULL
-#endif /* !CONFIG_XEN_DOM0 */
+#endif /* !CONFIG_XEN_PV_DOM0 */
 
 static void xen_teardown_msi_irqs(struct pci_dev *dev)
 {
@@ -555,7 +555,7 @@ int __init pci_xen_hvm_init(void)
        return 0;
 }
 
-#ifdef CONFIG_XEN_DOM0
+#ifdef CONFIG_XEN_PV_DOM0
 int __init pci_xen_initial_domain(void)
 {
        int irq;
@@ -583,6 +583,9 @@ int __init pci_xen_initial_domain(void)
        }
        return 0;
 }
+#endif
+
+#ifdef CONFIG_XEN_DOM0
 
 struct xen_device_domain_owner {
        domid_t domain;
@@ -656,4 +659,4 @@ int xen_unregister_device_domain_owner(struct pci_dev *dev)
        return 0;
 }
 EXPORT_SYMBOL_GPL(xen_unregister_device_domain_owner);
-#endif
+#endif /* CONFIG_XEN_DOM0 */
index ee2beda..1d4a00e 100644 (file)
@@ -274,7 +274,7 @@ static struct olpc_ec_driver ec_xo1_driver = {
 
 static struct olpc_ec_driver ec_xo1_5_driver = {
        .ec_cmd = olpc_xo1_ec_cmd,
-#ifdef CONFIG_OLPC_XO1_5_SCI
+#ifdef CONFIG_OLPC_XO15_SCI
        /*
         * XO-1.5 EC wakeups are available when olpc-xo15-sci driver is
         * compiled in
index 9ac7457..ed0442e 100644 (file)
 /*
  * PVH variables.
  *
- * pvh_bootparams and pvh_start_info need to live in the data segment since
+ * pvh_bootparams and pvh_start_info need to live in a data segment since
  * they are used after startup_{32|64}, which clear .bss, are invoked.
  */
-struct boot_params pvh_bootparams __section(".data");
-struct hvm_start_info pvh_start_info __section(".data");
+struct boot_params __initdata pvh_bootparams;
+struct hvm_start_info __initdata pvh_start_info;
 
-unsigned int pvh_start_info_sz = sizeof(pvh_start_info);
+const unsigned int __initconst pvh_start_info_sz = sizeof(pvh_start_info);
 
-static u64 pvh_get_root_pointer(void)
+static u64 __init pvh_get_root_pointer(void)
 {
        return pvh_start_info.rsdp_paddr;
 }
@@ -107,7 +107,7 @@ void __init __weak xen_pvh_init(struct boot_params *boot_params)
        BUG();
 }
 
-static void hypervisor_specific_init(bool xen_guest)
+static void __init hypervisor_specific_init(bool xen_guest)
 {
        if (xen_guest)
                xen_pvh_init(&pvh_bootparams);
index afc1da6..6bcd3d8 100644 (file)
@@ -43,13 +43,9 @@ config XEN_PV_SMP
        def_bool y
        depends on XEN_PV && SMP
 
-config XEN_DOM0
-       bool "Xen PV Dom0 support"
-       default y
-       depends on XEN_PV && PCI_XEN && SWIOTLB_XEN
-       depends on X86_IO_APIC && ACPI && PCI
-       help
-         Support running as a Xen PV Dom0 guest.
+config XEN_PV_DOM0
+       def_bool y
+       depends on XEN_PV && XEN_DOM0
 
 config XEN_PVHVM
        def_bool y
@@ -86,3 +82,12 @@ config XEN_PVH
        def_bool n
        help
          Support for running as a Xen PVH guest.
+
+config XEN_DOM0
+       bool "Xen Dom0 support"
+       default XEN_PV
+       depends on (XEN_PV && SWIOTLB_XEN) || (XEN_PVH && X86_64)
+       depends on X86_IO_APIC && ACPI && PCI
+       select X86_X2APIC if XEN_PVH && X86_64
+       help
+         Support running as a Xen Dom0 guest.
index 40b5779..4953260 100644 (file)
@@ -45,7 +45,7 @@ obj-$(CONFIG_PARAVIRT_SPINLOCKS)+= spinlock.o
 
 obj-$(CONFIG_XEN_DEBUG_FS)     += debugfs.o
 
-obj-$(CONFIG_XEN_DOM0)         += vga.o
+obj-$(CONFIG_XEN_PV_DOM0)      += vga.o
 
 obj-$(CONFIG_SWIOTLB_XEN)      += pci-swiotlb-xen.o
 
index c79bd0a..95d9703 100644 (file)
@@ -3,6 +3,7 @@
 #ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
 #include <linux/memblock.h>
 #endif
+#include <linux/console.h>
 #include <linux/cpu.h>
 #include <linux/kexec.h>
 #include <linux/slab.h>
 
 #include <xen/xen.h>
 #include <xen/features.h>
+#include <xen/interface/sched.h>
+#include <xen/interface/version.h>
 #include <xen/page.h>
 
 #include <asm/xen/hypercall.h>
 #include <asm/xen/hypervisor.h>
 #include <asm/cpu.h>
 #include <asm/e820/api.h> 
+#include <asm/setup.h>
 
 #include "xen-ops.h"
 #include "smp.h"
@@ -52,9 +56,6 @@ DEFINE_PER_CPU(struct vcpu_info, xen_vcpu_info);
 DEFINE_PER_CPU(uint32_t, xen_vcpu_id);
 EXPORT_PER_CPU_SYMBOL(xen_vcpu_id);
 
-enum xen_domain_type xen_domain_type = XEN_NATIVE;
-EXPORT_SYMBOL_GPL(xen_domain_type);
-
 unsigned long *machine_to_phys_mapping = (void *)MACH2PHYS_VIRT_START;
 EXPORT_SYMBOL(machine_to_phys_mapping);
 unsigned long  machine_to_phys_nr;
@@ -69,10 +70,12 @@ __read_mostly int xen_have_vector_callback;
 EXPORT_SYMBOL_GPL(xen_have_vector_callback);
 
 /*
- * NB: needs to live in .data because it's used by xen_prepare_pvh which runs
- * before clearing the bss.
+ * NB: These need to live in .data or alike because they're used by
+ * xen_prepare_pvh() which runs before clearing the bss.
  */
-uint32_t xen_start_flags __section(".data") = 0;
+enum xen_domain_type __ro_after_init xen_domain_type = XEN_NATIVE;
+EXPORT_SYMBOL_GPL(xen_domain_type);
+uint32_t __ro_after_init xen_start_flags;
 EXPORT_SYMBOL(xen_start_flags);
 
 /*
@@ -258,6 +261,45 @@ int xen_vcpu_setup(int cpu)
        return ((per_cpu(xen_vcpu, cpu) == NULL) ? -ENODEV : 0);
 }
 
+void __init xen_banner(void)
+{
+       unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL);
+       struct xen_extraversion extra;
+
+       HYPERVISOR_xen_version(XENVER_extraversion, &extra);
+
+       pr_info("Booting kernel on %s\n", pv_info.name);
+       pr_info("Xen version: %u.%u%s%s\n",
+               version >> 16, version & 0xffff, extra.extraversion,
+               xen_feature(XENFEAT_mmu_pt_update_preserve_ad)
+               ? " (preserve-AD)" : "");
+}
+
+/* Check if running on Xen version (major, minor) or later */
+bool xen_running_on_version_or_later(unsigned int major, unsigned int minor)
+{
+       unsigned int version;
+
+       if (!xen_domain())
+               return false;
+
+       version = HYPERVISOR_xen_version(XENVER_version, NULL);
+       if ((((version >> 16) == major) && ((version & 0xffff) >= minor)) ||
+               ((version >> 16) > major))
+               return true;
+       return false;
+}
+
+void __init xen_add_preferred_consoles(void)
+{
+       add_preferred_console("xenboot", 0, NULL);
+       if (!boot_params.screen_info.orig_video_isVGA)
+               add_preferred_console("tty", 0, NULL);
+       add_preferred_console("hvc", 0, NULL);
+       if (boot_params.screen_info.orig_video_isVGA)
+               add_preferred_console("tty", 0, NULL);
+}
+
 void xen_reboot(int reason)
 {
        struct sched_shutdown r = { .reason = reason };
index 753f637..a7b7d67 100644 (file)
@@ -28,7 +28,6 @@
 #include <linux/mm.h>
 #include <linux/page-flags.h>
 #include <linux/highmem.h>
-#include <linux/console.h>
 #include <linux/pci.h>
 #include <linux/gfp.h>
 #include <linux/edd.h>
@@ -109,17 +108,6 @@ struct tls_descs {
  */
 static DEFINE_PER_CPU(struct tls_descs, shadow_tls_desc);
 
-static void __init xen_banner(void)
-{
-       unsigned version = HYPERVISOR_xen_version(XENVER_version, NULL);
-       struct xen_extraversion extra;
-       HYPERVISOR_xen_version(XENVER_extraversion, &extra);
-
-       pr_info("Booting paravirtualized kernel on %s\n", pv_info.name);
-       pr_info("Xen version: %d.%d%s (preserve-AD)\n",
-               version >> 16, version & 0xffff, extra.extraversion);
-}
-
 static void __init xen_pv_init_platform(void)
 {
        populate_extra_pte(fix_to_virt(FIX_PARAVIRT_BOOTMAP));
@@ -142,22 +130,6 @@ static void __init xen_pv_guest_late_init(void)
 #endif
 }
 
-/* Check if running on Xen version (major, minor) or later */
-bool
-xen_running_on_version_or_later(unsigned int major, unsigned int minor)
-{
-       unsigned int version;
-
-       if (!xen_domain())
-               return false;
-
-       version = HYPERVISOR_xen_version(XENVER_version, NULL);
-       if ((((version >> 16) == major) && ((version & 0xffff) >= minor)) ||
-               ((version >> 16) > major))
-               return true;
-       return false;
-}
-
 static __read_mostly unsigned int cpuid_leaf5_ecx_val;
 static __read_mostly unsigned int cpuid_leaf5_edx_val;
 
@@ -755,8 +727,8 @@ static void xen_write_idt_entry(gate_desc *dt, int entrynum, const gate_desc *g)
        preempt_enable();
 }
 
-static void xen_convert_trap_info(const struct desc_ptr *desc,
-                                 struct trap_info *traps)
+static unsigned xen_convert_trap_info(const struct desc_ptr *desc,
+                                     struct trap_info *traps, bool full)
 {
        unsigned in, out, count;
 
@@ -766,17 +738,18 @@ static void xen_convert_trap_info(const struct desc_ptr *desc,
        for (in = out = 0; in < count; in++) {
                gate_desc *entry = (gate_desc *)(desc->address) + in;
 
-               if (cvt_gate_to_trap(in, entry, &traps[out]))
+               if (cvt_gate_to_trap(in, entry, &traps[out]) || full)
                        out++;
        }
-       traps[out].address = 0;
+
+       return out;
 }
 
 void xen_copy_trap_info(struct trap_info *traps)
 {
        const struct desc_ptr *desc = this_cpu_ptr(&idt_desc);
 
-       xen_convert_trap_info(desc, traps);
+       xen_convert_trap_info(desc, traps, true);
 }
 
 /* Load a new IDT into Xen.  In principle this can be per-CPU, so we
@@ -786,6 +759,7 @@ static void xen_load_idt(const struct desc_ptr *desc)
 {
        static DEFINE_SPINLOCK(lock);
        static struct trap_info traps[257];
+       unsigned out;
 
        trace_xen_cpu_load_idt(desc);
 
@@ -793,7 +767,8 @@ static void xen_load_idt(const struct desc_ptr *desc)
 
        memcpy(this_cpu_ptr(&idt_desc), desc, sizeof(idt_desc));
 
-       xen_convert_trap_info(desc, traps);
+       out = xen_convert_trap_info(desc, traps, false);
+       memset(&traps[out], 0, sizeof(traps[0]));
 
        xen_mc_flush();
        if (HYPERVISOR_set_trap_table(traps))
@@ -1214,6 +1189,11 @@ static void __init xen_dom0_set_legacy_features(void)
        x86_platform.legacy.rtc = 1;
 }
 
+static void __init xen_domu_set_legacy_features(void)
+{
+       x86_platform.legacy.rtc = 0;
+}
+
 /* First C function to be called on Xen boot */
 asmlinkage __visible void __init xen_start_kernel(void)
 {
@@ -1356,9 +1336,10 @@ asmlinkage __visible void __init xen_start_kernel(void)
        boot_params.hdr.hardware_subarch = X86_SUBARCH_XEN;
 
        if (!xen_initial_domain()) {
-               add_preferred_console("xenboot", 0, NULL);
                if (pci_xen)
                        x86_init.pci.arch_init = pci_xen_init;
+               x86_platform.set_legacy_features =
+                               xen_domu_set_legacy_features;
        } else {
                const struct dom0_vga_console_info *info =
                        (void *)((char *)xen_start_info +
@@ -1399,11 +1380,7 @@ asmlinkage __visible void __init xen_start_kernel(void)
 #endif
        }
 
-       if (!boot_params.screen_info.orig_video_isVGA)
-               add_preferred_console("tty", 0, NULL);
-       add_preferred_console("hvc", 0, NULL);
-       if (boot_params.screen_info.orig_video_isVGA)
-               add_preferred_console("tty", 0, NULL);
+       xen_add_preferred_consoles();
 
 #ifdef CONFIG_PCI
        /* PCI BIOS service won't work from a PV guest. */
index 0d5e34b..bcae606 100644 (file)
@@ -1,5 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <linux/acpi.h>
+#include <linux/export.h>
 
 #include <xen/hvc-console.h>
 
 /*
  * PVH variables.
  *
- * The variable xen_pvh needs to live in the data segment since it is used
+ * The variable xen_pvh needs to live in a data segment since it is used
  * after startup_{32|64} is invoked, which will clear the .bss segment.
  */
-bool xen_pvh __section(".data") = 0;
+bool __ro_after_init xen_pvh;
+EXPORT_SYMBOL_GPL(xen_pvh);
 
 void __init xen_pvh_init(struct boot_params *boot_params)
 {
@@ -36,6 +38,10 @@ void __init xen_pvh_init(struct boot_params *boot_params)
        pfn = __pa(hypercall_page);
        wrmsr_safe(msr, (u32)pfn, (u32)(pfn >> 32));
 
+       if (xen_initial_domain())
+               x86_init.oem.arch_setup = xen_add_preferred_consoles;
+       x86_init.oem.banner = xen_banner;
+
        xen_efi_init(boot_params);
 }
 
index 1df5f01..3359c23 100644 (file)
@@ -1518,14 +1518,17 @@ static inline void xen_alloc_ptpage(struct mm_struct *mm, unsigned long pfn,
        if (pinned) {
                struct page *page = pfn_to_page(pfn);
 
-               if (static_branch_likely(&xen_struct_pages_ready))
+               pinned = false;
+               if (static_branch_likely(&xen_struct_pages_ready)) {
+                       pinned = PagePinned(page);
                        SetPagePinned(page);
+               }
 
                xen_mc_batch();
 
                __set_pfn_prot(pfn, PAGE_KERNEL_RO);
 
-               if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS)
+               if (level == PT_PTE && USE_SPLIT_PTE_PTLOCKS && !pinned)
                        __pin_pagetable_pfn(MMUEXT_PIN_L1_TABLE, pfn);
 
                xen_mc_issue(PARAVIRT_LAZY_MMU);
@@ -2395,7 +2398,7 @@ static int remap_area_pfn_pte_fn(pte_t *ptep, unsigned long addr, void *data)
 
 int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
                  xen_pfn_t *pfn, int nr, int *err_ptr, pgprot_t prot,
-                 unsigned int domid, bool no_translate, struct page **pages)
+                 unsigned int domid, bool no_translate)
 {
        int err = 0;
        struct remap_data rmd;
index 54f9aa7..46df59a 100644 (file)
@@ -18,7 +18,7 @@
 #endif
 #include <linux/export.h>
 
-int xen_swiotlb __read_mostly;
+static int xen_swiotlb __read_mostly;
 
 /*
  * pci_xen_swiotlb_detect - set xen_swiotlb to 1 if necessary
@@ -56,7 +56,7 @@ int __init pci_xen_swiotlb_detect(void)
        return xen_swiotlb;
 }
 
-void __init pci_xen_swiotlb_init(void)
+static void __init pci_xen_swiotlb_init(void)
 {
        if (xen_swiotlb) {
                xen_swiotlb_init_early();
index 96afadf..7ed56c6 100644 (file)
@@ -290,8 +290,6 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle)
 
        gdt = get_cpu_gdt_rw(cpu);
 
-       memset(&ctxt->fpu_ctxt, 0, sizeof(ctxt->fpu_ctxt));
-
        /*
         * Bring up the CPU in cpu_bringup_and_idle() with the stack
         * pointing just below where pt_regs would be if it were a normal
@@ -308,8 +306,6 @@ cpu_initialize_context(unsigned int cpu, struct task_struct *idle)
 
        xen_copy_trap_info(ctxt->trap_ctxt);
 
-       ctxt->ldt_ents = 0;
-
        BUG_ON((unsigned long)gdt & ~PAGE_MASK);
 
        gdt_mfn = arbitrary_virt_to_mfn(gdt);
index 8d7ec49..8bc8b72 100644 (file)
@@ -51,6 +51,7 @@ void __init xen_remap_memory(void);
 phys_addr_t __init xen_find_free_area(phys_addr_t size);
 char * __init xen_memory_setup(void);
 void __init xen_arch_setup(void);
+void xen_banner(void);
 void xen_enable_sysenter(void);
 void xen_enable_syscall(void);
 void xen_vcpu_restore(void);
@@ -109,7 +110,7 @@ static inline void xen_uninit_lock_cpu(int cpu)
 
 struct dom0_vga_console_info;
 
-#ifdef CONFIG_XEN_DOM0
+#ifdef CONFIG_XEN_PV_DOM0
 void __init xen_init_vga(const struct dom0_vga_console_info *, size_t size);
 #else
 static inline void __init xen_init_vga(const struct dom0_vga_console_info *info,
@@ -118,6 +119,8 @@ static inline void __init xen_init_vga(const struct dom0_vga_console_info *info,
 }
 #endif
 
+void xen_add_preferred_consoles(void);
+
 void __init xen_init_apic(void);
 
 #ifdef CONFIG_XEN_EFI
index 7cbf68c..6fc05cb 100644 (file)
@@ -78,7 +78,7 @@
 #endif
 #define XCHAL_KIO_SIZE                 0x10000000
 
-#if (!XCHAL_HAVE_PTP_MMU || XCHAL_HAVE_SPANNING_WAY) && defined(CONFIG_OF)
+#if (!XCHAL_HAVE_PTP_MMU || XCHAL_HAVE_SPANNING_WAY) && defined(CONFIG_USE_OF)
 #define XCHAL_KIO_PADDR                        xtensa_get_kio_paddr()
 #ifndef __ASSEMBLY__
 extern unsigned long xtensa_kio_paddr;
index 764b54b..15051a8 100644 (file)
@@ -143,7 +143,7 @@ unsigned xtensa_get_ext_irq_no(unsigned irq)
 
 void __init init_IRQ(void)
 {
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
        irqchip_init();
 #else
 #ifdef CONFIG_HAVE_SMP
index ed18410..ee9082a 100644 (file)
@@ -63,7 +63,7 @@ extern unsigned long initrd_end;
 extern int initrd_below_start_ok;
 #endif
 
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
 void *dtb_start = __dtb_start;
 #endif
 
@@ -125,7 +125,7 @@ __tagtable(BP_TAG_INITRD, parse_tag_initrd);
 
 #endif /* CONFIG_BLK_DEV_INITRD */
 
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
 
 static int __init parse_tag_fdt(const bp_tag_t *tag)
 {
@@ -135,7 +135,7 @@ static int __init parse_tag_fdt(const bp_tag_t *tag)
 
 __tagtable(BP_TAG_FDT, parse_tag_fdt);
 
-#endif /* CONFIG_OF */
+#endif /* CONFIG_USE_OF */
 
 static int __init parse_tag_cmdline(const bp_tag_t* tag)
 {
@@ -183,7 +183,7 @@ static int __init parse_bootparam(const bp_tag_t *tag)
 }
 #endif
 
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
 
 #if !XCHAL_HAVE_PTP_MMU || XCHAL_HAVE_SPANNING_WAY
 unsigned long xtensa_kio_paddr = XCHAL_KIO_DEFAULT_PADDR;
@@ -232,7 +232,7 @@ void __init early_init_devtree(void *params)
                strlcpy(command_line, boot_command_line, COMMAND_LINE_SIZE);
 }
 
-#endif /* CONFIG_OF */
+#endif /* CONFIG_USE_OF */
 
 /*
  * Initialize architecture. (Early stage)
@@ -253,7 +253,7 @@ void __init init_arch(bp_tag_t *bp_start)
        if (bp_start)
                parse_bootparam(bp_start);
 
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
        early_init_devtree(dtb_start);
 #endif
 
index 7e4d97d..38acda4 100644 (file)
@@ -101,7 +101,7 @@ void init_mmu(void)
 
 void init_kio(void)
 {
-#if XCHAL_HAVE_PTP_MMU && XCHAL_HAVE_SPANNING_WAY && defined(CONFIG_OF)
+#if XCHAL_HAVE_PTP_MMU && XCHAL_HAVE_SPANNING_WAY && defined(CONFIG_USE_OF)
        /*
         * Update the IO area mapping in case xtensa_kio_paddr has changed
         */
index 4f7d614..538e674 100644 (file)
@@ -51,8 +51,12 @@ void platform_power_off(void)
 
 void platform_restart(void)
 {
-       /* Flush and reset the mmu, simulate a processor reset, and
-        * jump to the reset vector. */
+       /* Try software reset first. */
+       WRITE_ONCE(*(u32 *)XTFPGA_SWRST_VADDR, 0xdead);
+
+       /* If software reset did not work, flush and reset the mmu,
+        * simulate a processor reset, and jump to the reset vector.
+        */
        cpu_reset();
        /* control never gets here */
 }
@@ -66,7 +70,7 @@ void __init platform_calibrate_ccount(void)
 
 #endif
 
-#ifdef CONFIG_OF
+#ifdef CONFIG_USE_OF
 
 static void __init xtfpga_clk_setup(struct device_node *np)
 {
@@ -284,4 +288,4 @@ static int __init xtavnet_init(void)
  */
 arch_initcall(xtavnet_init);
 
-#endif /* CONFIG_OF */
+#endif /* CONFIG_USE_OF */
index cf2780c..485a258 100644 (file)
@@ -490,7 +490,6 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
        bdev = I_BDEV(inode);
        mutex_init(&bdev->bd_fsfreeze_mutex);
        spin_lock_init(&bdev->bd_size_lock);
-       bdev->bd_disk = disk;
        bdev->bd_partno = partno;
        bdev->bd_inode = inode;
        bdev->bd_stats = alloc_percpu(struct disk_stats);
@@ -498,6 +497,7 @@ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno)
                iput(inode);
                return NULL;
        }
+       bdev->bd_disk = disk;
        return bdev;
 }
 
index e2f1450..85b8e1c 100644 (file)
@@ -666,6 +666,12 @@ void bfq_bfqq_move(struct bfq_data *bfqd, struct bfq_queue *bfqq,
                bfq_put_idle_entity(bfq_entity_service_tree(entity), entity);
        bfqg_and_blkg_put(bfqq_group(bfqq));
 
+       if (entity->parent &&
+           entity->parent->last_bfqq_created == bfqq)
+               entity->parent->last_bfqq_created = NULL;
+       else if (bfqd->last_bfqq_created == bfqq)
+               bfqd->last_bfqq_created = NULL;
+
        entity->parent = bfqg->my_entity;
        entity->sched_data = &bfqg->sched_data;
        /* pin down bfqg and its associated blkg  */
index dd13c2b..480e1a1 100644 (file)
@@ -2662,15 +2662,6 @@ bfq_setup_merge(struct bfq_queue *bfqq, struct bfq_queue *new_bfqq)
         * are likely to increase the throughput.
         */
        bfqq->new_bfqq = new_bfqq;
-       /*
-        * The above assignment schedules the following redirections:
-        * each time some I/O for bfqq arrives, the process that
-        * generated that I/O is disassociated from bfqq and
-        * associated with new_bfqq. Here we increases new_bfqq->ref
-        * in advance, adding the number of processes that are
-        * expected to be associated with new_bfqq as they happen to
-        * issue I/O.
-        */
        new_bfqq->ref += process_refs;
        return new_bfqq;
 }
@@ -2733,10 +2724,6 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bfq_queue *bfqq,
 {
        struct bfq_queue *in_service_bfqq, *new_bfqq;
 
-       /* if a merge has already been setup, then proceed with that first */
-       if (bfqq->new_bfqq)
-               return bfqq->new_bfqq;
-
        /*
         * Check delayed stable merge for rotational or non-queueing
         * devs. For this branch to be executed, bfqq must not be
@@ -2838,6 +2825,9 @@ bfq_setup_cooperator(struct bfq_data *bfqd, struct bfq_queue *bfqq,
        if (bfq_too_late_for_merging(bfqq))
                return NULL;
 
+       if (bfqq->new_bfqq)
+               return bfqq->new_bfqq;
+
        if (!io_struct || unlikely(bfqq == &bfqd->oom_bfqq))
                return NULL;
 
index 5df3dd2..a6fb6a0 100644 (file)
@@ -1466,7 +1466,7 @@ again:
        if (!bio_integrity_endio(bio))
                return;
 
-       if (bio->bi_bdev)
+       if (bio->bi_bdev && bio_flagged(bio, BIO_TRACKED))
                rq_qos_done_bio(bio->bi_bdev->bd_disk->queue, bio);
 
        if (bio->bi_bdev && bio_flagged(bio, BIO_TRACE_COMPLETION)) {
index 3c88a79..38b9f76 100644 (file)
@@ -1182,10 +1182,6 @@ int blkcg_init_queue(struct request_queue *q)
        if (preloaded)
                radix_tree_preload_end();
 
-       ret = blk_iolatency_init(q);
-       if (ret)
-               goto err_destroy_all;
-
        ret = blk_ioprio_init(q);
        if (ret)
                goto err_destroy_all;
@@ -1194,6 +1190,12 @@ int blkcg_init_queue(struct request_queue *q)
        if (ret)
                goto err_destroy_all;
 
+       ret = blk_iolatency_init(q);
+       if (ret) {
+               blk_throtl_exit(q);
+               goto err_destroy_all;
+       }
+
        return 0;
 
 err_destroy_all:
@@ -1364,10 +1366,14 @@ enomem:
        /* alloc failed, nothing's initialized yet, free everything */
        spin_lock_irq(&q->queue_lock);
        list_for_each_entry(blkg, &q->blkg_list, q_node) {
+               struct blkcg *blkcg = blkg->blkcg;
+
+               spin_lock(&blkcg->lock);
                if (blkg->pd[pol->plid]) {
                        pol->pd_free_fn(blkg->pd[pol->plid]);
                        blkg->pd[pol->plid] = NULL;
                }
+               spin_unlock(&blkcg->lock);
        }
        spin_unlock_irq(&q->queue_lock);
        ret = -ENOMEM;
@@ -1399,12 +1405,16 @@ void blkcg_deactivate_policy(struct request_queue *q,
        __clear_bit(pol->plid, q->blkcg_pols);
 
        list_for_each_entry(blkg, &q->blkg_list, q_node) {
+               struct blkcg *blkcg = blkg->blkcg;
+
+               spin_lock(&blkcg->lock);
                if (blkg->pd[pol->plid]) {
                        if (pol->pd_offline_fn)
                                pol->pd_offline_fn(blkg->pd[pol->plid]);
                        pol->pd_free_fn(blkg->pd[pol->plid]);
                        blkg->pd[pol->plid] = NULL;
                }
+               spin_unlock(&blkcg->lock);
        }
 
        spin_unlock_irq(&q->queue_lock);
index 5454db2..4d8f5fe 100644 (file)
@@ -49,7 +49,6 @@
 #include "blk-mq.h"
 #include "blk-mq-sched.h"
 #include "blk-pm.h"
-#include "blk-rq-qos.h"
 
 struct dentry *blk_debugfs_root;
 
@@ -337,23 +336,25 @@ void blk_put_queue(struct request_queue *q)
 }
 EXPORT_SYMBOL(blk_put_queue);
 
-void blk_set_queue_dying(struct request_queue *q)
+void blk_queue_start_drain(struct request_queue *q)
 {
-       blk_queue_flag_set(QUEUE_FLAG_DYING, q);
-
        /*
         * When queue DYING flag is set, we need to block new req
         * entering queue, so we call blk_freeze_queue_start() to
         * prevent I/O from crossing blk_queue_enter().
         */
        blk_freeze_queue_start(q);
-
        if (queue_is_mq(q))
                blk_mq_wake_waiters(q);
-
        /* Make blk_queue_enter() reexamine the DYING flag. */
        wake_up_all(&q->mq_freeze_wq);
 }
+
+void blk_set_queue_dying(struct request_queue *q)
+{
+       blk_queue_flag_set(QUEUE_FLAG_DYING, q);
+       blk_queue_start_drain(q);
+}
 EXPORT_SYMBOL_GPL(blk_set_queue_dying);
 
 /**
@@ -385,13 +386,8 @@ void blk_cleanup_queue(struct request_queue *q)
         */
        blk_freeze_queue(q);
 
-       rq_qos_exit(q);
-
        blk_queue_flag_set(QUEUE_FLAG_DEAD, q);
 
-       /* for synchronous bio-based driver finish in-flight integrity i/o */
-       blk_flush_integrity();
-
        blk_sync_queue(q);
        if (queue_is_mq(q))
                blk_mq_exit_queue(q);
@@ -416,6 +412,30 @@ void blk_cleanup_queue(struct request_queue *q)
 }
 EXPORT_SYMBOL(blk_cleanup_queue);
 
+static bool blk_try_enter_queue(struct request_queue *q, bool pm)
+{
+       rcu_read_lock();
+       if (!percpu_ref_tryget_live(&q->q_usage_counter))
+               goto fail;
+
+       /*
+        * The code that increments the pm_only counter must ensure that the
+        * counter is globally visible before the queue is unfrozen.
+        */
+       if (blk_queue_pm_only(q) &&
+           (!pm || queue_rpm_status(q) == RPM_SUSPENDED))
+               goto fail_put;
+
+       rcu_read_unlock();
+       return true;
+
+fail_put:
+       percpu_ref_put(&q->q_usage_counter);
+fail:
+       rcu_read_unlock();
+       return false;
+}
+
 /**
  * blk_queue_enter() - try to increase q->q_usage_counter
  * @q: request queue pointer
@@ -425,40 +445,18 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags)
 {
        const bool pm = flags & BLK_MQ_REQ_PM;
 
-       while (true) {
-               bool success = false;
-
-               rcu_read_lock();
-               if (percpu_ref_tryget_live(&q->q_usage_counter)) {
-                       /*
-                        * The code that increments the pm_only counter is
-                        * responsible for ensuring that that counter is
-                        * globally visible before the queue is unfrozen.
-                        */
-                       if ((pm && queue_rpm_status(q) != RPM_SUSPENDED) ||
-                           !blk_queue_pm_only(q)) {
-                               success = true;
-                       } else {
-                               percpu_ref_put(&q->q_usage_counter);
-                       }
-               }
-               rcu_read_unlock();
-
-               if (success)
-                       return 0;
-
+       while (!blk_try_enter_queue(q, pm)) {
                if (flags & BLK_MQ_REQ_NOWAIT)
                        return -EBUSY;
 
                /*
-                * read pair of barrier in blk_freeze_queue_start(),
-                * we need to order reading __PERCPU_REF_DEAD flag of
-                * .q_usage_counter and reading .mq_freeze_depth or
-                * queue dying flag, otherwise the following wait may
-                * never return if the two reads are reordered.
+                * read pair of barrier in blk_freeze_queue_start(), we need to
+                * order reading __PERCPU_REF_DEAD flag of .q_usage_counter and
+                * reading .mq_freeze_depth or queue dying flag, otherwise the
+                * following wait may never return if the two reads are
+                * reordered.
                 */
                smp_rmb();
-
                wait_event(q->mq_freeze_wq,
                           (!q->mq_freeze_depth &&
                            blk_pm_resume_queue(pm, q)) ||
@@ -466,23 +464,43 @@ int blk_queue_enter(struct request_queue *q, blk_mq_req_flags_t flags)
                if (blk_queue_dying(q))
                        return -ENODEV;
        }
+
+       return 0;
 }
 
 static inline int bio_queue_enter(struct bio *bio)
 {
-       struct request_queue *q = bio->bi_bdev->bd_disk->queue;
-       bool nowait = bio->bi_opf & REQ_NOWAIT;
-       int ret;
+       struct gendisk *disk = bio->bi_bdev->bd_disk;
+       struct request_queue *q = disk->queue;
 
-       ret = blk_queue_enter(q, nowait ? BLK_MQ_REQ_NOWAIT : 0);
-       if (unlikely(ret)) {
-               if (nowait && !blk_queue_dying(q))
+       while (!blk_try_enter_queue(q, false)) {
+               if (bio->bi_opf & REQ_NOWAIT) {
+                       if (test_bit(GD_DEAD, &disk->state))
+                               goto dead;
                        bio_wouldblock_error(bio);
-               else
-                       bio_io_error(bio);
+                       return -EBUSY;
+               }
+
+               /*
+                * read pair of barrier in blk_freeze_queue_start(), we need to
+                * order reading __PERCPU_REF_DEAD flag of .q_usage_counter and
+                * reading .mq_freeze_depth or queue dying flag, otherwise the
+                * following wait may never return if the two reads are
+                * reordered.
+                */
+               smp_rmb();
+               wait_event(q->mq_freeze_wq,
+                          (!q->mq_freeze_depth &&
+                           blk_pm_resume_queue(false, q)) ||
+                          test_bit(GD_DEAD, &disk->state));
+               if (test_bit(GD_DEAD, &disk->state))
+                       goto dead;
        }
 
-       return ret;
+       return 0;
+dead:
+       bio_io_error(bio);
+       return -ENODEV;
 }
 
 void blk_queue_exit(struct request_queue *q)
@@ -899,11 +917,18 @@ static blk_qc_t __submit_bio(struct bio *bio)
        struct gendisk *disk = bio->bi_bdev->bd_disk;
        blk_qc_t ret = BLK_QC_T_NONE;
 
-       if (blk_crypto_bio_prep(&bio)) {
-               if (!disk->fops->submit_bio)
-                       return blk_mq_submit_bio(bio);
+       if (unlikely(bio_queue_enter(bio) != 0))
+               return BLK_QC_T_NONE;
+
+       if (!submit_bio_checks(bio) || !blk_crypto_bio_prep(&bio))
+               goto queue_exit;
+       if (disk->fops->submit_bio) {
                ret = disk->fops->submit_bio(bio);
+               goto queue_exit;
        }
+       return blk_mq_submit_bio(bio);
+
+queue_exit:
        blk_queue_exit(disk->queue);
        return ret;
 }
@@ -941,9 +966,6 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio)
                struct request_queue *q = bio->bi_bdev->bd_disk->queue;
                struct bio_list lower, same;
 
-               if (unlikely(bio_queue_enter(bio) != 0))
-                       continue;
-
                /*
                 * Create a fresh bio_list for all subordinate requests.
                 */
@@ -979,23 +1001,12 @@ static blk_qc_t __submit_bio_noacct(struct bio *bio)
 static blk_qc_t __submit_bio_noacct_mq(struct bio *bio)
 {
        struct bio_list bio_list[2] = { };
-       blk_qc_t ret = BLK_QC_T_NONE;
+       blk_qc_t ret;
 
        current->bio_list = bio_list;
 
        do {
-               struct gendisk *disk = bio->bi_bdev->bd_disk;
-
-               if (unlikely(bio_queue_enter(bio) != 0))
-                       continue;
-
-               if (!blk_crypto_bio_prep(&bio)) {
-                       blk_queue_exit(disk->queue);
-                       ret = BLK_QC_T_NONE;
-                       continue;
-               }
-
-               ret = blk_mq_submit_bio(bio);
+               ret = __submit_bio(bio);
        } while ((bio = bio_list_pop(&bio_list[0])));
 
        current->bio_list = NULL;
@@ -1013,9 +1024,6 @@ static blk_qc_t __submit_bio_noacct_mq(struct bio *bio)
  */
 blk_qc_t submit_bio_noacct(struct bio *bio)
 {
-       if (!submit_bio_checks(bio))
-               return BLK_QC_T_NONE;
-
        /*
         * We only want one ->submit_bio to be active at a time, else stack
         * usage with stacked devices could be a problem.  Use current->bio_list
index 69a1217..16d5d53 100644 (file)
@@ -426,8 +426,15 @@ EXPORT_SYMBOL(blk_integrity_register);
  */
 void blk_integrity_unregister(struct gendisk *disk)
 {
+       struct blk_integrity *bi = &disk->queue->integrity;
+
+       if (!bi->profile)
+               return;
+
+       /* ensure all bios are off the integrity workqueue */
+       blk_flush_integrity();
        blk_queue_flag_clear(QUEUE_FLAG_STABLE_WRITES, disk->queue);
-       memset(&disk->queue->integrity, 0, sizeof(struct blk_integrity));
+       memset(bi, 0, sizeof(*bi));
 }
 EXPORT_SYMBOL(blk_integrity_unregister);
 
index 4b66d27..3b38d15 100644 (file)
@@ -129,6 +129,7 @@ static const char *const blk_queue_flag_name[] = {
        QUEUE_FLAG_NAME(PCI_P2PDMA),
        QUEUE_FLAG_NAME(ZONE_RESETALL),
        QUEUE_FLAG_NAME(RQ_ALLOC_TIME),
+       QUEUE_FLAG_NAME(HCTX_ACTIVE),
        QUEUE_FLAG_NAME(NOWAIT),
 };
 #undef QUEUE_FLAG_NAME
index 86f8734..ff5caeb 100644 (file)
@@ -208,7 +208,7 @@ static struct request *blk_mq_find_and_get_req(struct blk_mq_tags *tags,
 
        spin_lock_irqsave(&tags->lock, flags);
        rq = tags->rqs[bitnr];
-       if (!rq || !refcount_inc_not_zero(&rq->ref))
+       if (!rq || rq->tag != bitnr || !refcount_inc_not_zero(&rq->ref))
                rq = NULL;
        spin_unlock_irqrestore(&tags->lock, flags);
        return rq;
index 108a352..bc02637 100644 (file)
@@ -188,9 +188,11 @@ void blk_mq_freeze_queue(struct request_queue *q)
 }
 EXPORT_SYMBOL_GPL(blk_mq_freeze_queue);
 
-void blk_mq_unfreeze_queue(struct request_queue *q)
+void __blk_mq_unfreeze_queue(struct request_queue *q, bool force_atomic)
 {
        mutex_lock(&q->mq_freeze_lock);
+       if (force_atomic)
+               q->q_usage_counter.data->force_atomic = true;
        q->mq_freeze_depth--;
        WARN_ON_ONCE(q->mq_freeze_depth < 0);
        if (!q->mq_freeze_depth) {
@@ -199,6 +201,11 @@ void blk_mq_unfreeze_queue(struct request_queue *q)
        }
        mutex_unlock(&q->mq_freeze_lock);
 }
+
+void blk_mq_unfreeze_queue(struct request_queue *q)
+{
+       __blk_mq_unfreeze_queue(q, false);
+}
 EXPORT_SYMBOL_GPL(blk_mq_unfreeze_queue);
 
 /*
index 7d2a0ba..6c3c00a 100644 (file)
@@ -51,6 +51,8 @@ struct blk_flush_queue *blk_alloc_flush_queue(int node, int cmd_size,
 void blk_free_flush_queue(struct blk_flush_queue *q);
 
 void blk_freeze_queue(struct request_queue *q);
+void __blk_mq_unfreeze_queue(struct request_queue *q, bool force_atomic);
+void blk_queue_start_drain(struct request_queue *q);
 
 #define BIO_INLINE_VECS 4
 struct bio_vec *bvec_alloc(mempool_t *pool, unsigned short *nr_vecs,
index 3510951..882f56b 100644 (file)
@@ -165,13 +165,20 @@ static const struct file_operations bsg_fops = {
        .llseek         =       default_llseek,
 };
 
+static void bsg_device_release(struct device *dev)
+{
+       struct bsg_device *bd = container_of(dev, struct bsg_device, device);
+
+       ida_simple_remove(&bsg_minor_ida, MINOR(bd->device.devt));
+       kfree(bd);
+}
+
 void bsg_unregister_queue(struct bsg_device *bd)
 {
        if (bd->queue->kobj.sd)
                sysfs_remove_link(&bd->queue->kobj, "bsg");
        cdev_device_del(&bd->cdev, &bd->device);
-       ida_simple_remove(&bsg_minor_ida, MINOR(bd->device.devt));
-       kfree(bd);
+       put_device(&bd->device);
 }
 EXPORT_SYMBOL_GPL(bsg_unregister_queue);
 
@@ -193,11 +200,13 @@ struct bsg_device *bsg_register_queue(struct request_queue *q,
        if (ret < 0) {
                if (ret == -ENOSPC)
                        dev_err(parent, "bsg: too many bsg devices\n");
-               goto out_kfree;
+               kfree(bd);
+               return ERR_PTR(ret);
        }
        bd->device.devt = MKDEV(bsg_major, ret);
        bd->device.class = bsg_class;
        bd->device.parent = parent;
+       bd->device.release = bsg_device_release;
        dev_set_name(&bd->device, "%s", name);
        device_initialize(&bd->device);
 
@@ -205,7 +214,7 @@ struct bsg_device *bsg_register_queue(struct request_queue *q,
        bd->cdev.owner = THIS_MODULE;
        ret = cdev_device_add(&bd->cdev, &bd->device);
        if (ret)
-               goto out_ida_remove;
+               goto out_put_device;
 
        if (q->kobj.sd) {
                ret = sysfs_create_link(&q->kobj, &bd->device.kobj, "bsg");
@@ -217,10 +226,8 @@ struct bsg_device *bsg_register_queue(struct request_queue *q,
 
 out_device_del:
        cdev_device_del(&bd->cdev, &bd->device);
-out_ida_remove:
-       ida_simple_remove(&bsg_minor_ida, MINOR(bd->device.devt));
-out_kfree:
-       kfree(bd);
+out_put_device:
+       put_device(&bd->device);
        return ERR_PTR(ret);
 }
 EXPORT_SYMBOL_GPL(bsg_register_queue);
index ffce6f6..1e970c2 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/task_io_accounting_ops.h>
 #include <linux/falloc.h>
 #include <linux/suspend.h>
+#include <linux/fs.h>
 #include "blk.h"
 
 static struct inode *bdev_file_inode(struct file *file)
@@ -553,7 +554,8 @@ static ssize_t blkdev_read_iter(struct kiocb *iocb, struct iov_iter *to)
 static long blkdev_fallocate(struct file *file, int mode, loff_t start,
                             loff_t len)
 {
-       struct block_device *bdev = I_BDEV(bdev_file_inode(file));
+       struct inode *inode = bdev_file_inode(file);
+       struct block_device *bdev = I_BDEV(inode);
        loff_t end = start + len - 1;
        loff_t isize;
        int error;
@@ -580,10 +582,12 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
        if ((start | len) & (bdev_logical_block_size(bdev) - 1))
                return -EINVAL;
 
+       filemap_invalidate_lock(inode->i_mapping);
+
        /* Invalidate the page cache, including dirty pages. */
        error = truncate_bdev_range(bdev, file->f_mode, start, end);
        if (error)
-               return error;
+               goto fail;
 
        switch (mode) {
        case FALLOC_FL_ZERO_RANGE:
@@ -600,17 +604,12 @@ static long blkdev_fallocate(struct file *file, int mode, loff_t start,
                                             GFP_KERNEL, 0);
                break;
        default:
-               return -EOPNOTSUPP;
+               error = -EOPNOTSUPP;
        }
-       if (error)
-               return error;
 
-       /*
-        * Invalidate the page cache again; if someone wandered in and dirtied
-        * a page, we just discard it - userspace has no way of knowing whether
-        * the write happened before or after discard completing...
-        */
-       return truncate_bdev_range(bdev, file->f_mode, start, end);
+ fail:
+       filemap_invalidate_unlock(inode->i_mapping);
+       return error;
 }
 
 const struct file_operations def_blk_fops = {
index 7b6e5e1..b498585 100644 (file)
@@ -26,6 +26,7 @@
 #include <linux/badblocks.h>
 
 #include "blk.h"
+#include "blk-rq-qos.h"
 
 static struct kobject *block_depr;
 
@@ -559,6 +560,8 @@ EXPORT_SYMBOL(device_add_disk);
  */
 void del_gendisk(struct gendisk *disk)
 {
+       struct request_queue *q = disk->queue;
+
        might_sleep();
 
        if (WARN_ON_ONCE(!disk_live(disk) && !(disk->flags & GENHD_FL_HIDDEN)))
@@ -575,8 +578,27 @@ void del_gendisk(struct gendisk *disk)
        fsync_bdev(disk->part0);
        __invalidate_device(disk->part0, true);
 
+       /*
+        * Fail any new I/O.
+        */
+       set_bit(GD_DEAD, &disk->state);
        set_capacity(disk, 0);
 
+       /*
+        * Prevent new I/O from crossing bio_queue_enter().
+        */
+       blk_queue_start_drain(q);
+       blk_mq_freeze_queue_wait(q);
+
+       rq_qos_exit(q);
+       blk_sync_queue(q);
+       blk_flush_integrity();
+       /*
+        * Allow using passthrough request again after the queue is torn down.
+        */
+       blk_queue_flag_clear(QUEUE_FLAG_INIT_DONE, q);
+       __blk_mq_unfreeze_queue(q, true);
+
        if (!(disk->flags & GENHD_FL_HIDDEN)) {
                sysfs_remove_link(&disk_to_dev(disk)->kobj, "bdi");
 
@@ -1056,6 +1078,7 @@ static void disk_release(struct device *dev)
        struct gendisk *disk = dev_to_disk(dev);
 
        might_sleep();
+       WARN_ON_ONCE(disk_live(disk));
 
        disk_release_events(disk);
        kfree(disk->random);
@@ -1268,6 +1291,7 @@ struct gendisk *__alloc_disk_node(struct request_queue *q, int node_id,
 
 out_destroy_part_tbl:
        xa_destroy(&disk->part_tbl);
+       disk->part0->bd_disk = NULL;
        iput(disk->part0->bd_inode);
 out_free_bdi:
        bdi_put(disk->bdi);
index 15a8be5..a0ffbab 100644 (file)
@@ -151,6 +151,7 @@ struct kyber_ctx_queue {
 
 struct kyber_queue_data {
        struct request_queue *q;
+       dev_t dev;
 
        /*
         * Each scheduling domain has a limited number of in-flight requests
@@ -257,7 +258,7 @@ static int calculate_percentile(struct kyber_queue_data *kqd,
        }
        memset(buckets, 0, sizeof(kqd->latency_buckets[sched_domain][type]));
 
-       trace_kyber_latency(kqd->q, kyber_domain_names[sched_domain],
+       trace_kyber_latency(kqd->dev, kyber_domain_names[sched_domain],
                            kyber_latency_type_names[type], percentile,
                            bucket + 1, 1 << KYBER_LATENCY_SHIFT, samples);
 
@@ -270,7 +271,7 @@ static void kyber_resize_domain(struct kyber_queue_data *kqd,
        depth = clamp(depth, 1U, kyber_depth[sched_domain]);
        if (depth != kqd->domain_tokens[sched_domain].sb.depth) {
                sbitmap_queue_resize(&kqd->domain_tokens[sched_domain], depth);
-               trace_kyber_adjust(kqd->q, kyber_domain_names[sched_domain],
+               trace_kyber_adjust(kqd->dev, kyber_domain_names[sched_domain],
                                   depth);
        }
 }
@@ -366,6 +367,7 @@ static struct kyber_queue_data *kyber_queue_data_alloc(struct request_queue *q)
                goto err;
 
        kqd->q = q;
+       kqd->dev = disk_devt(q->disk);
 
        kqd->cpu_latency = alloc_percpu_gfp(struct kyber_cpu_latency,
                                            GFP_KERNEL | __GFP_ZERO);
@@ -774,7 +776,7 @@ kyber_dispatch_cur_domain(struct kyber_queue_data *kqd,
                        list_del_init(&rq->queuelist);
                        return rq;
                } else {
-                       trace_kyber_throttled(kqd->q,
+                       trace_kyber_throttled(kqd->dev,
                                              kyber_domain_names[khd->cur_domain]);
                }
        } else if (sbitmap_any_bit_set(&khd->kcq_map[khd->cur_domain])) {
@@ -787,7 +789,7 @@ kyber_dispatch_cur_domain(struct kyber_queue_data *kqd,
                        list_del_init(&rq->queuelist);
                        return rq;
                } else {
-                       trace_kyber_throttled(kqd->q,
+                       trace_kyber_throttled(kqd->dev,
                                              kyber_domain_names[khd->cur_domain]);
                }
        }
index 30d2db3..0d399dd 100644 (file)
@@ -17,6 +17,8 @@ source "drivers/bus/Kconfig"
 
 source "drivers/connector/Kconfig"
 
+source "drivers/firmware/Kconfig"
+
 source "drivers/gnss/Kconfig"
 
 source "drivers/mtd/Kconfig"
index 0a0a982..c0e77c1 100644 (file)
@@ -36,7 +36,7 @@ struct acpi_gtdt_descriptor {
 
 static struct acpi_gtdt_descriptor acpi_gtdt_desc __initdata;
 
-static inline void *next_platform_timer(void *platform_timer)
+static inline __init void *next_platform_timer(void *platform_timer)
 {
        struct acpi_gtdt_header *gh = platform_timer;
 
index a3ef6cc..7dd80ac 100644 (file)
@@ -3007,6 +3007,18 @@ static int acpi_nfit_register_region(struct acpi_nfit_desc *acpi_desc,
                ndr_desc->target_node = NUMA_NO_NODE;
        }
 
+       /* Fallback to address based numa information if node lookup failed */
+       if (ndr_desc->numa_node == NUMA_NO_NODE) {
+               ndr_desc->numa_node = memory_add_physaddr_to_nid(spa->address);
+               dev_info(acpi_desc->dev, "changing numa node from %d to %d for nfit region [%pa-%pa]",
+                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
+       }
+       if (ndr_desc->target_node == NUMA_NO_NODE) {
+               ndr_desc->target_node = phys_to_target_node(spa->address);
+               dev_info(acpi_desc->dev, "changing target node from %d to %d for nfit region [%pa-%pa]",
+                       NUMA_NO_NODE, ndr_desc->numa_node, &res.start, &res.end);
+       }
+
        /*
         * Persistence domain bits are hierarchical, if
         * ACPI_NFIT_CAPABILITY_CACHE_FLUSH is set then
index a43f152..45c5c0e 100644 (file)
@@ -284,8 +284,7 @@ acpi_map_lookup_virt(void __iomem *virt, acpi_size size)
 #define should_use_kmap(pfn)   page_is_ram(pfn)
 #endif
 
-static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz,
-                             bool memory)
+static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz)
 {
        unsigned long pfn;
 
@@ -295,8 +294,7 @@ static void __iomem *acpi_map(acpi_physical_address pg_off, unsigned long pg_sz,
                        return NULL;
                return (void __iomem __force *)kmap(pfn_to_page(pfn));
        } else
-               return memory ? acpi_os_memmap(pg_off, pg_sz) :
-                               acpi_os_ioremap(pg_off, pg_sz);
+               return acpi_os_ioremap(pg_off, pg_sz);
 }
 
 static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr)
@@ -311,10 +309,9 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr)
 }
 
 /**
- * __acpi_os_map_iomem - Get a virtual address for a given physical address range.
+ * acpi_os_map_iomem - Get a virtual address for a given physical address range.
  * @phys: Start of the physical address range to map.
  * @size: Size of the physical address range to map.
- * @memory: true if remapping memory, false if IO
  *
  * Look up the given physical address range in the list of existing ACPI memory
  * mappings.  If found, get a reference to it and return a pointer to it (its
@@ -324,8 +321,8 @@ static void acpi_unmap(acpi_physical_address pg_off, void __iomem *vaddr)
  * During early init (when acpi_permanent_mmap has not been set yet) this
  * routine simply calls __acpi_map_table() to get the job done.
  */
-static void __iomem __ref
-*__acpi_os_map_iomem(acpi_physical_address phys, acpi_size size, bool memory)
+void __iomem __ref
+*acpi_os_map_iomem(acpi_physical_address phys, acpi_size size)
 {
        struct acpi_ioremap *map;
        void __iomem *virt;
@@ -356,7 +353,7 @@ static void __iomem __ref
 
        pg_off = round_down(phys, PAGE_SIZE);
        pg_sz = round_up(phys + size, PAGE_SIZE) - pg_off;
-       virt = acpi_map(phys, size, memory);
+       virt = acpi_map(phys, size);
        if (!virt) {
                mutex_unlock(&acpi_ioremap_lock);
                kfree(map);
@@ -375,17 +372,11 @@ out:
        mutex_unlock(&acpi_ioremap_lock);
        return map->virt + (phys - map->phys);
 }
-
-void __iomem *__ref
-acpi_os_map_iomem(acpi_physical_address phys, acpi_size size)
-{
-       return __acpi_os_map_iomem(phys, size, false);
-}
 EXPORT_SYMBOL_GPL(acpi_os_map_iomem);
 
 void *__ref acpi_os_map_memory(acpi_physical_address phys, acpi_size size)
 {
-       return (void *)__acpi_os_map_iomem(phys, size, true);
+       return (void *)acpi_os_map_iomem(phys, size);
 }
 EXPORT_SYMBOL_GPL(acpi_os_map_memory);
 
index bd92b54..1c48358 100644 (file)
@@ -371,7 +371,7 @@ static int lps0_device_attach(struct acpi_device *adev,
                return 0;
 
        if (acpi_s2idle_vendor_amd()) {
-               /* AMD0004, AMDI0005:
+               /* AMD0004, AMD0005, AMDI0005:
                 * - Should use rev_id 0x0
                 * - function mask > 0x3: Should use AMD method, but has off by one bug
                 * - function mask = 0x3: Should use Microsoft method
@@ -390,6 +390,7 @@ static int lps0_device_attach(struct acpi_device *adev,
                                        ACPI_LPS0_DSM_UUID_MICROSOFT, 0,
                                        &lps0_dsm_guid_microsoft);
                if (lps0_dsm_func_mask > 0x3 && (!strcmp(hid, "AMD0004") ||
+                                                !strcmp(hid, "AMD0005") ||
                                                 !strcmp(hid, "AMDI0005"))) {
                        lps0_dsm_func_mask = (lps0_dsm_func_mask << 1) | 0x1;
                        acpi_handle_debug(adev->handle, "_DSM UUID %s: Adjusted function mask: 0x%x\n",
index d9030cb..9edacc8 100644 (file)
@@ -1852,6 +1852,7 @@ static void binder_deferred_fd_close(int fd)
 }
 
 static void binder_transaction_buffer_release(struct binder_proc *proc,
+                                             struct binder_thread *thread,
                                              struct binder_buffer *buffer,
                                              binder_size_t failed_at,
                                              bool is_failure)
@@ -2011,8 +2012,16 @@ static void binder_transaction_buffer_release(struct binder_proc *proc,
                                                &proc->alloc, &fd, buffer,
                                                offset, sizeof(fd));
                                WARN_ON(err);
-                               if (!err)
+                               if (!err) {
                                        binder_deferred_fd_close(fd);
+                                       /*
+                                        * Need to make sure the thread goes
+                                        * back to userspace to complete the
+                                        * deferred close
+                                        */
+                                       if (thread)
+                                               thread->looper_need_return = true;
+                               }
                        }
                } break;
                default:
@@ -3038,9 +3047,8 @@ static void binder_transaction(struct binder_proc *proc,
        if (reply) {
                binder_enqueue_thread_work(thread, tcomplete);
                binder_inner_proc_lock(target_proc);
-               if (target_thread->is_dead || target_proc->is_frozen) {
-                       return_error = target_thread->is_dead ?
-                               BR_DEAD_REPLY : BR_FROZEN_REPLY;
+               if (target_thread->is_dead) {
+                       return_error = BR_DEAD_REPLY;
                        binder_inner_proc_unlock(target_proc);
                        goto err_dead_proc_or_thread;
                }
@@ -3105,7 +3113,7 @@ err_bad_parent:
 err_copy_data_failed:
        binder_free_txn_fixups(t);
        trace_binder_transaction_failed_buffer_release(t->buffer);
-       binder_transaction_buffer_release(target_proc, t->buffer,
+       binder_transaction_buffer_release(target_proc, NULL, t->buffer,
                                          buffer_offset, true);
        if (target_node)
                binder_dec_node_tmpref(target_node);
@@ -3184,7 +3192,9 @@ err_invalid_target_handle:
  * Cleanup buffer and free it.
  */
 static void
-binder_free_buf(struct binder_proc *proc, struct binder_buffer *buffer)
+binder_free_buf(struct binder_proc *proc,
+               struct binder_thread *thread,
+               struct binder_buffer *buffer)
 {
        binder_inner_proc_lock(proc);
        if (buffer->transaction) {
@@ -3212,7 +3222,7 @@ binder_free_buf(struct binder_proc *proc, struct binder_buffer *buffer)
                binder_node_inner_unlock(buf_node);
        }
        trace_binder_transaction_buffer_release(buffer);
-       binder_transaction_buffer_release(proc, buffer, 0, false);
+       binder_transaction_buffer_release(proc, thread, buffer, 0, false);
        binder_alloc_free_buf(&proc->alloc, buffer);
 }
 
@@ -3414,7 +3424,7 @@ static int binder_thread_write(struct binder_proc *proc,
                                     proc->pid, thread->pid, (u64)data_ptr,
                                     buffer->debug_id,
                                     buffer->transaction ? "active" : "finished");
-                       binder_free_buf(proc, buffer);
+                       binder_free_buf(proc, thread, buffer);
                        break;
                }
 
@@ -4107,7 +4117,7 @@ retry:
                        buffer->transaction = NULL;
                        binder_cleanup_transaction(t, "fd fixups failed",
                                                   BR_FAILED_REPLY);
-                       binder_free_buf(proc, buffer);
+                       binder_free_buf(proc, thread, buffer);
                        binder_debug(BINDER_DEBUG_FAILED_TRANSACTION,
                                     "%d:%d %stransaction %d fd fixups failed %d/%d, line %d\n",
                                     proc->pid, thread->pid,
@@ -4648,6 +4658,22 @@ static int binder_ioctl_get_node_debug_info(struct binder_proc *proc,
        return 0;
 }
 
+static bool binder_txns_pending_ilocked(struct binder_proc *proc)
+{
+       struct rb_node *n;
+       struct binder_thread *thread;
+
+       if (proc->outstanding_txns > 0)
+               return true;
+
+       for (n = rb_first(&proc->threads); n; n = rb_next(n)) {
+               thread = rb_entry(n, struct binder_thread, rb_node);
+               if (thread->transaction_stack)
+                       return true;
+       }
+       return false;
+}
+
 static int binder_ioctl_freeze(struct binder_freeze_info *info,
                               struct binder_proc *target_proc)
 {
@@ -4679,8 +4705,13 @@ static int binder_ioctl_freeze(struct binder_freeze_info *info,
                        (!target_proc->outstanding_txns),
                        msecs_to_jiffies(info->timeout_ms));
 
-       if (!ret && target_proc->outstanding_txns)
-               ret = -EAGAIN;
+       /* Check pending transactions that wait for reply */
+       if (ret >= 0) {
+               binder_inner_proc_lock(target_proc);
+               if (binder_txns_pending_ilocked(target_proc))
+                       ret = -EAGAIN;
+               binder_inner_proc_unlock(target_proc);
+       }
 
        if (ret < 0) {
                binder_inner_proc_lock(target_proc);
@@ -4696,6 +4727,7 @@ static int binder_ioctl_get_freezer_info(
 {
        struct binder_proc *target_proc;
        bool found = false;
+       __u32 txns_pending;
 
        info->sync_recv = 0;
        info->async_recv = 0;
@@ -4705,7 +4737,9 @@ static int binder_ioctl_get_freezer_info(
                if (target_proc->pid == info->pid) {
                        found = true;
                        binder_inner_proc_lock(target_proc);
-                       info->sync_recv |= target_proc->sync_recv;
+                       txns_pending = binder_txns_pending_ilocked(target_proc);
+                       info->sync_recv |= target_proc->sync_recv |
+                                       (txns_pending << 1);
                        info->async_recv |= target_proc->async_recv;
                        binder_inner_proc_unlock(target_proc);
                }
index 810c0b8..402c4d4 100644 (file)
@@ -378,6 +378,8 @@ struct binder_ref {
  *                        binder transactions
  *                        (protected by @inner_lock)
  * @sync_recv:            process received sync transactions since last frozen
+ *                        bit 0: received sync transaction after being frozen
+ *                        bit 1: new pending sync transaction during freezing
  *                        (protected by @inner_lock)
  * @async_recv:           process received async transactions since last frozen
  *                        (protected by @inner_lock)
index b2f5520..0910441 100644 (file)
@@ -440,10 +440,7 @@ struct ahci_host_priv *ahci_platform_get_resources(struct platform_device *pdev,
        hpriv->phy_regulator = devm_regulator_get(dev, "phy");
        if (IS_ERR(hpriv->phy_regulator)) {
                rc = PTR_ERR(hpriv->phy_regulator);
-               if (rc == -EPROBE_DEFER)
-                       goto err_out;
-               rc = 0;
-               hpriv->phy_regulator = NULL;
+               goto err_out;
        }
 
        if (flags & AHCI_PLATFORM_GET_RESETS) {
index c3e6592..0a8bf09 100644 (file)
@@ -352,7 +352,8 @@ static unsigned int pdc_data_xfer_vlb(struct ata_queued_cmd *qc,
                        iowrite32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
 
                if (unlikely(slop)) {
-                       __le32 pad;
+                       __le32 pad = 0;
+
                        if (rw == READ) {
                                pad = cpu_to_le32(ioread32(ap->ioaddr.data_addr));
                                memcpy(buf + buflen - slop, &pad, slop);
@@ -742,7 +743,8 @@ static unsigned int vlb32_data_xfer(struct ata_queued_cmd *qc,
                        ioread32_rep(ap->ioaddr.data_addr, buf, buflen >> 2);
 
                if (unlikely(slop)) {
-                       __le32 pad;
+                       __le32 pad = 0;
+
                        if (rw == WRITE) {
                                memcpy(&pad, buf + buflen - slop, slop);
                                iowrite32(le32_to_cpu(pad), ap->ioaddr.data_addr);
index 46c5034..00fb412 100644 (file)
@@ -264,7 +264,7 @@ void __init numa_free_distance(void)
        size = numa_distance_cnt * numa_distance_cnt *
                sizeof(numa_distance[0]);
 
-       memblock_free(__pa(numa_distance), size);
+       memblock_free_ptr(numa_distance, size);
        numa_distance_cnt = 0;
        numa_distance = NULL;
 }
index e65dd80..249da49 100644 (file)
@@ -95,12 +95,29 @@ int fwnode_link_add(struct fwnode_handle *con, struct fwnode_handle *sup)
 
        list_add(&link->s_hook, &sup->consumers);
        list_add(&link->c_hook, &con->suppliers);
+       pr_debug("%pfwP Linked as a fwnode consumer to %pfwP\n",
+                con, sup);
 out:
        mutex_unlock(&fwnode_link_lock);
 
        return ret;
 }
 
+/**
+ * __fwnode_link_del - Delete a link between two fwnode_handles.
+ * @link: the fwnode_link to be deleted
+ *
+ * The fwnode_link_lock needs to be held when this function is called.
+ */
+static void __fwnode_link_del(struct fwnode_link *link)
+{
+       pr_debug("%pfwP Dropping the fwnode link to %pfwP\n",
+                link->consumer, link->supplier);
+       list_del(&link->s_hook);
+       list_del(&link->c_hook);
+       kfree(link);
+}
+
 /**
  * fwnode_links_purge_suppliers - Delete all supplier links of fwnode_handle.
  * @fwnode: fwnode whose supplier links need to be deleted
@@ -112,11 +129,8 @@ static void fwnode_links_purge_suppliers(struct fwnode_handle *fwnode)
        struct fwnode_link *link, *tmp;
 
        mutex_lock(&fwnode_link_lock);
-       list_for_each_entry_safe(link, tmp, &fwnode->suppliers, c_hook) {
-               list_del(&link->s_hook);
-               list_del(&link->c_hook);
-               kfree(link);
-       }
+       list_for_each_entry_safe(link, tmp, &fwnode->suppliers, c_hook)
+               __fwnode_link_del(link);
        mutex_unlock(&fwnode_link_lock);
 }
 
@@ -131,11 +145,8 @@ static void fwnode_links_purge_consumers(struct fwnode_handle *fwnode)
        struct fwnode_link *link, *tmp;
 
        mutex_lock(&fwnode_link_lock);
-       list_for_each_entry_safe(link, tmp, &fwnode->consumers, s_hook) {
-               list_del(&link->s_hook);
-               list_del(&link->c_hook);
-               kfree(link);
-       }
+       list_for_each_entry_safe(link, tmp, &fwnode->consumers, s_hook)
+               __fwnode_link_del(link);
        mutex_unlock(&fwnode_link_lock);
 }
 
@@ -676,7 +687,8 @@ struct device_link *device_link_add(struct device *consumer,
 {
        struct device_link *link;
 
-       if (!consumer || !supplier || flags & ~DL_ADD_VALID_FLAGS ||
+       if (!consumer || !supplier || consumer == supplier ||
+           flags & ~DL_ADD_VALID_FLAGS ||
            (flags & DL_FLAG_STATELESS && flags & DL_MANAGED_LINK_FLAGS) ||
            (flags & DL_FLAG_SYNC_STATE_ONLY &&
             (flags & ~DL_FLAG_INFERRED) != DL_FLAG_SYNC_STATE_ONLY) ||
@@ -975,6 +987,7 @@ int device_links_check_suppliers(struct device *dev)
 {
        struct device_link *link;
        int ret = 0;
+       struct fwnode_handle *sup_fw;
 
        /*
         * Device waiting for supplier to become available is not allowed to
@@ -983,10 +996,11 @@ int device_links_check_suppliers(struct device *dev)
        mutex_lock(&fwnode_link_lock);
        if (dev->fwnode && !list_empty(&dev->fwnode->suppliers) &&
            !fw_devlink_is_permissive()) {
-               dev_dbg(dev, "probe deferral - wait for supplier %pfwP\n",
-                       list_first_entry(&dev->fwnode->suppliers,
-                       struct fwnode_link,
-                       c_hook)->supplier);
+               sup_fw = list_first_entry(&dev->fwnode->suppliers,
+                                         struct fwnode_link,
+                                         c_hook)->supplier;
+               dev_err_probe(dev, -EPROBE_DEFER, "wait for supplier %pfwP\n",
+                             sup_fw);
                mutex_unlock(&fwnode_link_lock);
                return -EPROBE_DEFER;
        }
@@ -1001,8 +1015,9 @@ int device_links_check_suppliers(struct device *dev)
                if (link->status != DL_STATE_AVAILABLE &&
                    !(link->flags & DL_FLAG_SYNC_STATE_ONLY)) {
                        device_links_missing_supplier(dev);
-                       dev_dbg(dev, "probe deferral - supplier %s not ready\n",
-                               dev_name(link->supplier));
+                       dev_err_probe(dev, -EPROBE_DEFER,
+                                     "supplier %s not ready\n",
+                                     dev_name(link->supplier));
                        ret = -EPROBE_DEFER;
                        break;
                }
@@ -1722,6 +1737,25 @@ static int fw_devlink_create_devlink(struct device *con,
        struct device *sup_dev;
        int ret = 0;
 
+       /*
+        * In some cases, a device P might also be a supplier to its child node
+        * C. However, this would defer the probe of C until the probe of P
+        * completes successfully. This is perfectly fine in the device driver
+        * model. device_add() doesn't guarantee probe completion of the device
+        * by the time it returns.
+        *
+        * However, there are a few drivers that assume C will finish probing
+        * as soon as it's added and before P finishes probing. So, we provide
+        * a flag to let fw_devlink know not to delay the probe of C until the
+        * probe of P completes successfully.
+        *
+        * When such a flag is set, we can't create device links where P is the
+        * supplier of C as that would delay the probe of C.
+        */
+       if (sup_handle->flags & FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD &&
+           fwnode_is_ancestor_of(sup_handle, con->fwnode))
+               return -EINVAL;
+
        sup_dev = get_dev_from_fwnode(sup_handle);
        if (sup_dev) {
                /*
@@ -1772,14 +1806,21 @@ static int fw_devlink_create_devlink(struct device *con,
         * be broken by applying logic. Check for these types of cycles and
         * break them so that devices in the cycle probe properly.
         *
-        * If the supplier's parent is dependent on the consumer, then
-        * the consumer-supplier dependency is a false dependency. So,
-        * treat it as an invalid link.
+        * If the supplier's parent is dependent on the consumer, then the
+        * consumer and supplier have a cyclic dependency. Since fw_devlink
+        * can't tell which of the inferred dependencies are incorrect, don't
+        * enforce probe ordering between any of the devices in this cyclic
+        * dependency. Do this by relaxing all the fw_devlink device links in
+        * this cycle and by treating the fwnode link between the consumer and
+        * the supplier as an invalid dependency.
         */
        sup_dev = fwnode_get_next_parent_dev(sup_handle);
        if (sup_dev && device_is_dependent(con, sup_dev)) {
-               dev_dbg(con, "Not linking to %pfwP - False link\n",
-                       sup_handle);
+               dev_info(con, "Fixing up cyclic dependency with %pfwP (%s)\n",
+                        sup_handle, dev_name(sup_dev));
+               device_links_write_lock();
+               fw_devlink_relax_cycle(con, sup_dev);
+               device_links_write_unlock();
                ret = -EINVAL;
        } else {
                /*
@@ -1858,9 +1899,7 @@ static void __fw_devlink_link_to_consumers(struct device *dev)
                if (!own_link || ret == -EAGAIN)
                        continue;
 
-               list_del(&link->s_hook);
-               list_del(&link->c_hook);
-               kfree(link);
+               __fwnode_link_del(link);
        }
 }
 
@@ -1912,9 +1951,7 @@ static void __fw_devlink_link_to_suppliers(struct device *dev,
                if (!own_link || ret == -EAGAIN)
                        continue;
 
-               list_del(&link->s_hook);
-               list_del(&link->c_hook);
-               kfree(link);
+               __fwnode_link_del(link);
 
                /* If no device link was created, nothing more to do. */
                if (ret)
index a97f33d..9466503 100644 (file)
@@ -13,6 +13,7 @@
 #include <linux/export.h>
 #include <linux/rtc.h>
 #include <linux/suspend.h>
+#include <linux/init.h>
 
 #include <linux/mc146818rtc.h>
 
@@ -165,6 +166,9 @@ void generate_pm_trace(const void *tracedata, unsigned int user)
        const char *file = *(const char **)(tracedata + 2);
        unsigned int user_hash_value, file_hash_value;
 
+       if (!x86_platform.legacy.rtc)
+               return;
+
        user_hash_value = user % USERHASH;
        file_hash_value = hash_string(lineno, file, FILEHASH);
        set_magic_time(user_hash_value, file_hash_value, dev_hash_value);
@@ -267,6 +271,9 @@ static struct notifier_block pm_trace_nb = {
 
 static int __init early_resume_init(void)
 {
+       if (!x86_platform.legacy.rtc)
+               return 0;
+
        hash_value_early_read = read_magic_time();
        register_pm_notifier(&pm_trace_nb);
        return 0;
@@ -277,6 +284,9 @@ static int __init late_resume_init(void)
        unsigned int val = hash_value_early_read;
        unsigned int user, file, dev;
 
+       if (!x86_platform.legacy.rtc)
+               return 0;
+
        user = val % USERHASH;
        val = val / USERHASH;
        file = val % FILEHASH;
index 7bd0f3c..c46f6a8 100644 (file)
@@ -1116,6 +1116,9 @@ int device_create_managed_software_node(struct device *dev,
        to_swnode(fwnode)->managed = true;
        set_secondary_fwnode(dev, fwnode);
 
+       if (device_is_registered(dev))
+               software_node_notify(dev);
+
        return 0;
 }
 EXPORT_SYMBOL_GPL(device_create_managed_software_node);
index 64b2f3d..7f76fee 100644 (file)
@@ -2,4 +2,4 @@
 obj-$(CONFIG_TEST_ASYNC_DRIVER_PROBE)  += test_async_driver_probe.o
 
 obj-$(CONFIG_DRIVER_PE_KUNIT_TEST) += property-entry-test.o
-CFLAGS_REMOVE_property-entry-test.o += -fplugin-arg-structleak_plugin-byref -fplugin-arg-structleak_plugin-byref-all
+CFLAGS_property-entry-test.o += $(DISABLE_STRUCTLEAK_PLUGIN)
index 58ec167..530b312 100644 (file)
@@ -373,10 +373,22 @@ static int brd_alloc(int i)
        struct gendisk *disk;
        char buf[DISK_NAME_LEN];
 
+       mutex_lock(&brd_devices_mutex);
+       list_for_each_entry(brd, &brd_devices, brd_list) {
+               if (brd->brd_number == i) {
+                       mutex_unlock(&brd_devices_mutex);
+                       return -EEXIST;
+               }
+       }
        brd = kzalloc(sizeof(*brd), GFP_KERNEL);
-       if (!brd)
+       if (!brd) {
+               mutex_unlock(&brd_devices_mutex);
                return -ENOMEM;
+       }
        brd->brd_number         = i;
+       list_add_tail(&brd->brd_list, &brd_devices);
+       mutex_unlock(&brd_devices_mutex);
+
        spin_lock_init(&brd->brd_lock);
        INIT_RADIX_TREE(&brd->brd_pages, GFP_ATOMIC);
 
@@ -411,37 +423,30 @@ static int brd_alloc(int i)
        blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue);
        blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue);
        add_disk(disk);
-       list_add_tail(&brd->brd_list, &brd_devices);
 
        return 0;
 
 out_free_dev:
+       mutex_lock(&brd_devices_mutex);
+       list_del(&brd->brd_list);
+       mutex_unlock(&brd_devices_mutex);
        kfree(brd);
        return -ENOMEM;
 }
 
 static void brd_probe(dev_t dev)
 {
-       int i = MINOR(dev) / max_part;
-       struct brd_device *brd;
-
-       mutex_lock(&brd_devices_mutex);
-       list_for_each_entry(brd, &brd_devices, brd_list) {
-               if (brd->brd_number == i)
-                       goto out_unlock;
-       }
-
-       brd_alloc(i);
-out_unlock:
-       mutex_unlock(&brd_devices_mutex);
+       brd_alloc(MINOR(dev) / max_part);
 }
 
 static void brd_del_one(struct brd_device *brd)
 {
-       list_del(&brd->brd_list);
        del_gendisk(brd->brd_disk);
        blk_cleanup_disk(brd->brd_disk);
        brd_free_pages(brd);
+       mutex_lock(&brd_devices_mutex);
+       list_del(&brd->brd_list);
+       mutex_unlock(&brd_devices_mutex);
        kfree(brd);
 }
 
@@ -491,25 +496,21 @@ static int __init brd_init(void)
 
        brd_debugfs_dir = debugfs_create_dir("ramdisk_pages", NULL);
 
-       mutex_lock(&brd_devices_mutex);
        for (i = 0; i < rd_nr; i++) {
                err = brd_alloc(i);
                if (err)
                        goto out_free;
        }
 
-       mutex_unlock(&brd_devices_mutex);
-
        pr_info("brd: module loaded\n");
        return 0;
 
 out_free:
+       unregister_blkdev(RAMDISK_MAJOR, "ramdisk");
        debugfs_remove_recursive(brd_debugfs_dir);
 
        list_for_each_entry_safe(brd, next, &brd_devices, brd_list)
                brd_del_one(brd);
-       mutex_unlock(&brd_devices_mutex);
-       unregister_blkdev(RAMDISK_MAJOR, "ramdisk");
 
        pr_info("brd: module NOT loaded !!!\n");
        return err;
@@ -519,13 +520,12 @@ static void __exit brd_exit(void)
 {
        struct brd_device *brd, *next;
 
+       unregister_blkdev(RAMDISK_MAJOR, "ramdisk");
        debugfs_remove_recursive(brd_debugfs_dir);
 
        list_for_each_entry_safe(brd, next, &brd_devices, brd_list)
                brd_del_one(brd);
 
-       unregister_blkdev(RAMDISK_MAJOR, "ramdisk");
-
        pr_info("brd: module unloaded\n");
 }
 
index 5170a63..1183f78 100644 (file)
@@ -97,13 +97,18 @@ struct nbd_config {
 
        atomic_t recv_threads;
        wait_queue_head_t recv_wq;
-       loff_t blksize;
+       unsigned int blksize_bits;
        loff_t bytesize;
 #if IS_ENABLED(CONFIG_DEBUG_FS)
        struct dentry *dbg_dir;
 #endif
 };
 
+static inline unsigned int nbd_blksize(struct nbd_config *config)
+{
+       return 1u << config->blksize_bits;
+}
+
 struct nbd_device {
        struct blk_mq_tag_set tag_set;
 
@@ -146,7 +151,7 @@ static struct dentry *nbd_dbg_dir;
 
 #define NBD_MAGIC 0x68797548
 
-#define NBD_DEF_BLKSIZE 1024
+#define NBD_DEF_BLKSIZE_BITS 10
 
 static unsigned int nbds_max = 16;
 static int max_part = 16;
@@ -317,12 +322,12 @@ static int nbd_set_size(struct nbd_device *nbd, loff_t bytesize,
                loff_t blksize)
 {
        if (!blksize)
-               blksize = NBD_DEF_BLKSIZE;
+               blksize = 1u << NBD_DEF_BLKSIZE_BITS;
        if (blksize < 512 || blksize > PAGE_SIZE || !is_power_of_2(blksize))
                return -EINVAL;
 
        nbd->config->bytesize = bytesize;
-       nbd->config->blksize = blksize;
+       nbd->config->blksize_bits = __ffs(blksize);
 
        if (!nbd->task_recv)
                return 0;
@@ -1337,7 +1342,7 @@ static int nbd_start_device(struct nbd_device *nbd)
                args->index = i;
                queue_work(nbd->recv_workq, &args->work);
        }
-       return nbd_set_size(nbd, config->bytesize, config->blksize);
+       return nbd_set_size(nbd, config->bytesize, nbd_blksize(config));
 }
 
 static int nbd_start_device_ioctl(struct nbd_device *nbd, struct block_device *bdev)
@@ -1406,11 +1411,11 @@ static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
        case NBD_SET_BLKSIZE:
                return nbd_set_size(nbd, config->bytesize, arg);
        case NBD_SET_SIZE:
-               return nbd_set_size(nbd, arg, config->blksize);
+               return nbd_set_size(nbd, arg, nbd_blksize(config));
        case NBD_SET_SIZE_BLOCKS:
-               if (check_mul_overflow((loff_t)arg, config->blksize, &bytesize))
+               if (check_shl_overflow(arg, config->blksize_bits, &bytesize))
                        return -EINVAL;
-               return nbd_set_size(nbd, bytesize, config->blksize);
+               return nbd_set_size(nbd, bytesize, nbd_blksize(config));
        case NBD_SET_TIMEOUT:
                nbd_set_cmd_timeout(nbd, arg);
                return 0;
@@ -1476,7 +1481,7 @@ static struct nbd_config *nbd_alloc_config(void)
        atomic_set(&config->recv_threads, 0);
        init_waitqueue_head(&config->recv_wq);
        init_waitqueue_head(&config->conn_wait);
-       config->blksize = NBD_DEF_BLKSIZE;
+       config->blksize_bits = NBD_DEF_BLKSIZE_BITS;
        atomic_set(&config->live_connections, 0);
        try_module_get(THIS_MODULE);
        return config;
@@ -1604,7 +1609,7 @@ static int nbd_dev_dbg_init(struct nbd_device *nbd)
        debugfs_create_file("tasks", 0444, dir, nbd, &nbd_dbg_tasks_fops);
        debugfs_create_u64("size_bytes", 0444, dir, &config->bytesize);
        debugfs_create_u32("timeout", 0444, dir, &nbd->tag_set.timeout);
-       debugfs_create_u64("blocksize", 0444, dir, &config->blksize);
+       debugfs_create_u32("blocksize_bits", 0444, dir, &config->blksize_bits);
        debugfs_create_file("flags", 0444, dir, nbd, &nbd_dbg_flags_fops);
 
        return 0;
@@ -1826,7 +1831,7 @@ nbd_device_policy[NBD_DEVICE_ATTR_MAX + 1] = {
 static int nbd_genl_size_set(struct genl_info *info, struct nbd_device *nbd)
 {
        struct nbd_config *config = nbd->config;
-       u64 bsize = config->blksize;
+       u64 bsize = nbd_blksize(config);
        u64 bytes = config->bytesize;
 
        if (info->attrs[NBD_ATTR_SIZE_BYTES])
@@ -1835,7 +1840,7 @@ static int nbd_genl_size_set(struct genl_info *info, struct nbd_device *nbd)
        if (info->attrs[NBD_ATTR_BLOCK_SIZE_BYTES])
                bsize = nla_get_u64(info->attrs[NBD_ATTR_BLOCK_SIZE_BYTES]);
 
-       if (bytes != config->bytesize || bsize != config->blksize)
+       if (bytes != config->bytesize || bsize != nbd_blksize(config))
                return nbd_set_size(nbd, bytes, bsize);
        return 0;
 }
index 4b93fd8..44e45af 100644 (file)
@@ -71,8 +71,10 @@ static int rnbd_clt_parse_map_options(const char *buf, size_t max_path_cnt,
        int opt_mask = 0;
        int token;
        int ret = -EINVAL;
-       int i, dest_port, nr_poll_queues;
+       int nr_poll_queues = 0;
+       int dest_port = 0;
        int p_cnt = 0;
+       int i;
 
        options = kstrdup(buf, GFP_KERNEL);
        if (!options)
index 9b3bd08..303caf2 100644 (file)
@@ -689,28 +689,6 @@ static const struct blk_mq_ops virtio_mq_ops = {
 static unsigned int virtblk_queue_depth;
 module_param_named(queue_depth, virtblk_queue_depth, uint, 0444);
 
-static int virtblk_validate(struct virtio_device *vdev)
-{
-       u32 blk_size;
-
-       if (!vdev->config->get) {
-               dev_err(&vdev->dev, "%s failure: config access disabled\n",
-                       __func__);
-               return -EINVAL;
-       }
-
-       if (!virtio_has_feature(vdev, VIRTIO_BLK_F_BLK_SIZE))
-               return 0;
-
-       blk_size = virtio_cread32(vdev,
-                       offsetof(struct virtio_blk_config, blk_size));
-
-       if (blk_size < SECTOR_SIZE || blk_size > PAGE_SIZE)
-               __virtio_clear_bit(vdev, VIRTIO_BLK_F_BLK_SIZE);
-
-       return 0;
-}
-
 static int virtblk_probe(struct virtio_device *vdev)
 {
        struct virtio_blk *vblk;
@@ -722,6 +700,12 @@ static int virtblk_probe(struct virtio_device *vdev)
        u8 physical_block_exp, alignment_offset;
        unsigned int queue_depth;
 
+       if (!vdev->config->get) {
+               dev_err(&vdev->dev, "%s failure: config access disabled\n",
+                       __func__);
+               return -EINVAL;
+       }
+
        err = ida_simple_get(&vd_index_ida, 0, minor_to_index(1 << MINORBITS),
                             GFP_KERNEL);
        if (err < 0)
@@ -836,14 +820,6 @@ static int virtblk_probe(struct virtio_device *vdev)
        else
                blk_size = queue_logical_block_size(q);
 
-       if (blk_size < SECTOR_SIZE || blk_size > PAGE_SIZE) {
-               dev_err(&vdev->dev,
-                       "block size is changed unexpectedly, now is %u\n",
-                       blk_size);
-               err = -EINVAL;
-               goto out_cleanup_disk;
-       }
-
        /* Use topology information if available */
        err = virtio_cread_feature(vdev, VIRTIO_BLK_F_TOPOLOGY,
                                   struct virtio_blk_config, physical_block_exp,
@@ -1009,7 +985,6 @@ static struct virtio_driver virtio_blk = {
        .driver.name                    = KBUILD_MODNAME,
        .driver.owner                   = THIS_MODULE,
        .id_table                       = id_table,
-       .validate                       = virtblk_validate,
        .probe                          = virtblk_probe,
        .remove                         = virtblk_remove,
        .config_changed                 = virtblk_config_changed,
index a5b96f3..a4cf3d6 100644 (file)
@@ -152,18 +152,6 @@ config QCOM_EBI2
          Interface 2, which can be used to connect things like NAND Flash,
          SRAM, ethernet adapters, FPGAs and LCD displays.
 
-config SIMPLE_PM_BUS
-       tristate "Simple Power-Managed Bus Driver"
-       depends on OF && PM
-       help
-         Driver for transparent busses that don't need a real driver, but
-         where the bus controller is part of a PM domain, or under the control
-         of a functional clock, and thus relies on runtime PM for managing
-         this PM domain and/or clock.
-         An example of such a bus controller is the Renesas Bus State
-         Controller (BSC, sometimes called "LBSC within Bus Bridge", or
-         "External Bus Interface") as found on several Renesas ARM SoCs.
-
 config SUN50I_DE2_BUS
        bool "Allwinner A64 DE2 Bus Driver"
          default ARM64
index 1c29c5e..52c2f35 100644 (file)
@@ -27,7 +27,7 @@ obj-$(CONFIG_OMAP_OCP2SCP)    += omap-ocp2scp.o
 obj-$(CONFIG_QCOM_EBI2)                += qcom-ebi2.o
 obj-$(CONFIG_SUN50I_DE2_BUS)   += sun50i-de2.o
 obj-$(CONFIG_SUNXI_RSB)                += sunxi-rsb.o
-obj-$(CONFIG_SIMPLE_PM_BUS)    += simple-pm-bus.o
+obj-$(CONFIG_OF)               += simple-pm-bus.o
 obj-$(CONFIG_TEGRA_ACONNECT)   += tegra-aconnect.o
 obj-$(CONFIG_TEGRA_GMI)                += tegra-gmi.o
 obj-$(CONFIG_TI_PWMSS)         += ti-pwmss.o
index 01a3d0c..6b8d625 100644 (file)
 #include <linux/platform_device.h>
 #include <linux/pm_runtime.h>
 
-
 static int simple_pm_bus_probe(struct platform_device *pdev)
 {
-       const struct of_dev_auxdata *lookup = dev_get_platdata(&pdev->dev);
-       struct device_node *np = pdev->dev.of_node;
+       const struct device *dev = &pdev->dev;
+       const struct of_dev_auxdata *lookup = dev_get_platdata(dev);
+       struct device_node *np = dev->of_node;
+       const struct of_device_id *match;
+
+       /*
+        * Allow user to use driver_override to bind this driver to a
+        * transparent bus device which has a different compatible string
+        * that's not listed in simple_pm_bus_of_match. We don't want to do any
+        * of the simple-pm-bus tasks for these devices, so return early.
+        */
+       if (pdev->driver_override)
+               return 0;
+
+       match = of_match_device(dev->driver->of_match_table, dev);
+       /*
+        * These are transparent bus devices (not simple-pm-bus matches) that
+        * have their child nodes populated automatically.  So, don't need to
+        * do anything more. We only match with the device if this driver is
+        * the most specific match because we don't want to incorrectly bind to
+        * a device that has a more specific driver.
+        */
+       if (match && match->data) {
+               if (of_property_match_string(np, "compatible", match->compatible) == 0)
+                       return 0;
+               else
+                       return -ENODEV;
+       }
 
        dev_dbg(&pdev->dev, "%s\n", __func__);
 
@@ -31,14 +56,25 @@ static int simple_pm_bus_probe(struct platform_device *pdev)
 
 static int simple_pm_bus_remove(struct platform_device *pdev)
 {
+       const void *data = of_device_get_match_data(&pdev->dev);
+
+       if (pdev->driver_override || data)
+               return 0;
+
        dev_dbg(&pdev->dev, "%s\n", __func__);
 
        pm_runtime_disable(&pdev->dev);
        return 0;
 }
 
+#define ONLY_BUS       ((void *) 1) /* Match if the device is only a bus. */
+
 static const struct of_device_id simple_pm_bus_of_match[] = {
        { .compatible = "simple-pm-bus", },
+       { .compatible = "simple-bus",   .data = ONLY_BUS },
+       { .compatible = "simple-mfd",   .data = ONLY_BUS },
+       { .compatible = "isa",          .data = ONLY_BUS },
+       { .compatible = "arm,amba-bus", .data = ONLY_BUS },
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, simple_pm_bus_of_match);
index a51c2a8..6a8b7fb 100644 (file)
@@ -1464,6 +1464,9 @@ static const struct sysc_revision_quirk sysc_revision_quirks[] = {
        /* Quirks that need to be set based on detected module */
        SYSC_QUIRK("aess", 0, 0, 0x10, -ENODEV, 0x40000000, 0xffffffff,
                   SYSC_MODULE_QUIRK_AESS),
+       /* Errata i893 handling for dra7 dcan1 and 2 */
+       SYSC_QUIRK("dcan", 0x4ae3c000, 0x20, -ENODEV, -ENODEV, 0xa3170504, 0xffffffff,
+                  SYSC_QUIRK_CLKDM_NOAUTO),
        SYSC_QUIRK("dcan", 0x48480000, 0x20, -ENODEV, -ENODEV, 0xa3170504, 0xffffffff,
                   SYSC_QUIRK_CLKDM_NOAUTO),
        SYSC_QUIRK("dss", 0x4832a000, 0, 0x10, 0x14, 0x00000020, 0xffffffff,
@@ -2954,6 +2957,7 @@ static int sysc_init_soc(struct sysc *ddata)
                        break;
                case SOC_AM3:
                        sysc_add_disabled(0x48310000);  /* rng */
+                       break;
                default:
                        break;
                }
index 0a55967..9ef007b 100644 (file)
@@ -564,6 +564,7 @@ config SM_GCC_6125
 
 config SM_GCC_6350
        tristate "SM6350 Global Clock Controller"
+       select QCOM_GDSC
        help
          Support for the global clock controller on SM6350 devices.
          Say Y if you want to use peripheral devices such as UART,
index bc09736..68fe9f6 100644 (file)
@@ -3242,7 +3242,7 @@ static struct gdsc hlos1_vote_turing_mmu_tbu1_gdsc = {
 };
 
 static struct gdsc hlos1_vote_turing_mmu_tbu0_gdsc = {
-       .gdscr = 0x7d060,
+       .gdscr = 0x7d07c,
        .pd = {
                .name = "hlos1_vote_turing_mmu_tbu0",
        },
index 4c94b94..1490446 100644 (file)
@@ -186,6 +186,8 @@ static struct rzg2l_reset r9a07g044_resets[] = {
 
 static const unsigned int r9a07g044_crit_mod_clks[] __initconst = {
        MOD_CLK_BASE + R9A07G044_GIC600_GICCLK,
+       MOD_CLK_BASE + R9A07G044_IA55_CLK,
+       MOD_CLK_BASE + R9A07G044_DMAC_ACLK,
 };
 
 const struct rzg2l_cpg_info r9a07g044_cpg_info = {
index 3b3b2c3..761922e 100644 (file)
@@ -391,7 +391,7 @@ static int rzg2l_mod_clock_is_enabled(struct clk_hw *hw)
 
        value = readl(priv->base + CLK_MON_R(clock->off));
 
-       return !(value & bitmask);
+       return value & bitmask;
 }
 
 static const struct clk_ops rzg2l_mod_clock_ops = {
index 242e94c..bf8cd92 100644 (file)
@@ -165,13 +165,6 @@ static const struct clk_parent_data mpu_mux[] = {
          .name = "boot_clk", },
 };
 
-static const struct clk_parent_data s2f_usr0_mux[] = {
-       { .fw_name = "f2s-free-clk",
-         .name = "f2s-free-clk", },
-       { .fw_name = "boot_clk",
-         .name = "boot_clk", },
-};
-
 static const struct clk_parent_data emac_mux[] = {
        { .fw_name = "emaca_free_clk",
          .name = "emaca_free_clk", },
@@ -312,8 +305,6 @@ static const struct stratix10_gate_clock agilex_gate_clks[] = {
          4, 0x44, 28, 1, 0, 0, 0},
        { AGILEX_CS_TIMER_CLK, "cs_timer_clk", NULL, noc_mux, ARRAY_SIZE(noc_mux), 0, 0x24,
          5, 0, 0, 0, 0x30, 1, 0},
-       { AGILEX_S2F_USER0_CLK, "s2f_user0_clk", NULL, s2f_usr0_mux, ARRAY_SIZE(s2f_usr0_mux), 0, 0x24,
-         6, 0, 0, 0, 0, 0, 0},
        { AGILEX_EMAC0_CLK, "emac0_clk", NULL, emac_mux, ARRAY_SIZE(emac_mux), 0, 0x7C,
          0, 0, 0, 0, 0x94, 26, 0},
        { AGILEX_EMAC1_CLK, "emac1_clk", NULL, emac_mux, ARRAY_SIZE(emac_mux), 0, 0x7C,
index df77b6b..763cea8 100644 (file)
@@ -3090,6 +3090,7 @@ static int compat_insnlist(struct file *file, unsigned long arg)
        mutex_lock(&dev->mutex);
        rc = do_insnlist_ioctl(dev, insns, insnlist32.n_insns, file);
        mutex_unlock(&dev->mutex);
+       kfree(insns);
        return rc;
 }
 
index 66b05a3..a6f365b 100644 (file)
@@ -74,8 +74,8 @@ unsigned int gov_attr_set_put(struct gov_attr_set *attr_set, struct list_head *l
        if (count)
                return count;
 
-       kobject_put(&attr_set->kobj);
        mutex_destroy(&attr_set->update_lock);
+       kobject_put(&attr_set->kobj);
        return 0;
 }
 EXPORT_SYMBOL_GPL(gov_attr_set_put);
index 1097f82..8c176b7 100644 (file)
@@ -3205,11 +3205,15 @@ static int __init intel_pstate_init(void)
        if (boot_cpu_data.x86_vendor != X86_VENDOR_INTEL)
                return -ENODEV;
 
-       if (no_load)
-               return -ENODEV;
-
        id = x86_match_cpu(hwp_support_ids);
        if (id) {
+               bool hwp_forced = intel_pstate_hwp_is_enabled();
+
+               if (hwp_forced)
+                       pr_info("HWP enabled by BIOS\n");
+               else if (no_load)
+                       return -ENODEV;
+
                copy_cpu_funcs(&core_funcs);
                /*
                 * Avoid enabling HWP for processors without EPP support,
@@ -3219,8 +3223,7 @@ static int __init intel_pstate_init(void)
                 * If HWP is enabled already, though, there is no choice but to
                 * deal with it.
                 */
-               if ((!no_hwp && boot_cpu_has(X86_FEATURE_HWP_EPP)) ||
-                   intel_pstate_hwp_is_enabled()) {
+               if ((!no_hwp && boot_cpu_has(X86_FEATURE_HWP_EPP)) || hwp_forced) {
                        hwp_active++;
                        hwp_mode_bdw = id->driver_data;
                        intel_pstate.attr = hwp_cpufreq_attrs;
@@ -3235,7 +3238,11 @@ static int __init intel_pstate_init(void)
 
                        goto hwp_cpu_matched;
                }
+               pr_info("HWP not enabled\n");
        } else {
+               if (no_load)
+                       return -ENODEV;
+
                id = x86_match_cpu(intel_pstate_cpu_ids);
                if (!id) {
                        pr_info("CPU model not supported\n");
@@ -3314,10 +3321,9 @@ static int __init intel_pstate_setup(char *str)
        else if (!strcmp(str, "passive"))
                default_driver = &intel_cpufreq;
 
-       if (!strcmp(str, "no_hwp")) {
-               pr_info("HWP disabled\n");
+       if (!strcmp(str, "no_hwp"))
                no_hwp = 1;
-       }
+
        if (!strcmp(str, "force"))
                force_load = 1;
        if (!strcmp(str, "hwp_only"))
index 284b6bd..d295f40 100644 (file)
@@ -451,7 +451,6 @@ static int ve_spc_cpufreq_init(struct cpufreq_policy *policy)
 static int ve_spc_cpufreq_exit(struct cpufreq_policy *policy)
 {
        struct device *cpu_dev;
-       int cur_cluster = cpu_to_cluster(policy->cpu);
 
        cpu_dev = get_cpu_device(policy->cpu);
        if (!cpu_dev) {
index bb88198..aa4e1a5 100644 (file)
@@ -778,7 +778,7 @@ ccp_run_aes_gcm_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
                                    in_place ? DMA_BIDIRECTIONAL
                                             : DMA_TO_DEVICE);
                if (ret)
-                       goto e_ctx;
+                       goto e_aad;
 
                if (in_place) {
                        dst = src;
@@ -863,7 +863,7 @@ ccp_run_aes_gcm_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
        op.u.aes.size = 0;
        ret = cmd_q->ccp->vdata->perform->aes(&op);
        if (ret)
-               goto e_dst;
+               goto e_final_wa;
 
        if (aes->action == CCP_AES_ACTION_ENCRYPT) {
                /* Put the ciphered tag after the ciphertext. */
@@ -873,17 +873,19 @@ ccp_run_aes_gcm_cmd(struct ccp_cmd_queue *cmd_q, struct ccp_cmd *cmd)
                ret = ccp_init_dm_workarea(&tag, cmd_q, authsize,
                                           DMA_BIDIRECTIONAL);
                if (ret)
-                       goto e_tag;
+                       goto e_final_wa;
                ret = ccp_set_dm_area(&tag, 0, p_tag, 0, authsize);
-               if (ret)
-                       goto e_tag;
+               if (ret) {
+                       ccp_dm_free(&tag);
+                       goto e_final_wa;
+               }
 
                ret = crypto_memneq(tag.address, final_wa.address,
                                    authsize) ? -EBADMSG : 0;
                ccp_dm_free(&tag);
        }
 
-e_tag:
+e_final_wa:
        ccp_dm_free(&final_wa);
 
 e_dst:
index e3e7575..b1f46a9 100644 (file)
@@ -178,7 +178,7 @@ static void axp_mc_check(struct mem_ctl_info *mci)
                                     "details unavailable (multiple errors)");
        if (cnt_dbe)
                edac_mc_handle_error(HW_EVENT_ERR_UNCORRECTED, mci,
-                                    cnt_sbe, /* error count */
+                                    cnt_dbe, /* error count */
                                     0, 0, 0, /* pfn, offset, syndrome */
                                     -1, -1, -1, /* top, mid, low layer */
                                     mci->ctl_name,
index fc1153a..b8a7d95 100644 (file)
@@ -464,7 +464,7 @@ static void dmc520_init_csrow(struct mem_ctl_info *mci)
                        dimm->grain     = pvt->mem_width_in_bytes;
                        dimm->dtype     = dt;
                        dimm->mtype     = mt;
-                       dimm->edac_mode = EDAC_FLAG_SECDED;
+                       dimm->edac_mode = EDAC_SECDED;
                        dimm->nr_pages  = pages_per_rank / csi->nr_channels;
                }
        }
index 7e7146b..7d08627 100644 (file)
@@ -782,7 +782,7 @@ static void init_csrows(struct mem_ctl_info *mci)
 
                for (j = 0; j < csi->nr_channels; j++) {
                        dimm            = csi->channels[j]->dimm;
-                       dimm->edac_mode = EDAC_FLAG_SECDED;
+                       dimm->edac_mode = EDAC_SECDED;
                        dimm->mtype     = p_data->get_mtype(priv->baseaddr);
                        dimm->nr_pages  = (size >> PAGE_SHIFT) / csi->nr_channels;
                        dimm->grain     = SYNPS_EDAC_ERR_GRAIN;
index 220a58c..75cb910 100644 (file)
@@ -203,10 +203,7 @@ config INTEL_STRATIX10_RSU
          Say Y here if you want Intel RSU support.
 
 config QCOM_SCM
-       tristate "Qcom SCM driver"
-       depends on ARM || ARM64
-       depends on HAVE_ARM_SMCCC
-       select RESET_CONTROLLER
+       tristate
 
 config QCOM_SCM_DOWNLOAD_MODE_DEFAULT
        bool "Qualcomm download mode enabled by default"
@@ -298,6 +295,7 @@ config TURRIS_MOX_RWTM
 
 source "drivers/firmware/arm_ffa/Kconfig"
 source "drivers/firmware/broadcom/Kconfig"
+source "drivers/firmware/cirrus/Kconfig"
 source "drivers/firmware/google/Kconfig"
 source "drivers/firmware/efi/Kconfig"
 source "drivers/firmware/imx/Kconfig"
index 5ced067..4e58cb4 100644 (file)
@@ -28,6 +28,7 @@ obj-$(CONFIG_TURRIS_MOX_RWTM) += turris-mox-rwtm.o
 obj-y                          += arm_ffa/
 obj-y                          += arm_scmi/
 obj-y                          += broadcom/
+obj-y                          += cirrus/
 obj-y                          += meson/
 obj-$(CONFIG_GOOGLE_FIRMWARE)  += google/
 obj-$(CONFIG_EFI)              += efi/
index 00fe595..641a918 100644 (file)
@@ -49,6 +49,13 @@ static int ffa_device_probe(struct device *dev)
        return ffa_drv->probe(ffa_dev);
 }
 
+static void ffa_device_remove(struct device *dev)
+{
+       struct ffa_driver *ffa_drv = to_ffa_driver(dev->driver);
+
+       ffa_drv->remove(to_ffa_dev(dev));
+}
+
 static int ffa_device_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
        struct ffa_device *ffa_dev = to_ffa_dev(dev);
@@ -86,6 +93,7 @@ struct bus_type ffa_bus_type = {
        .name           = "arm_ffa",
        .match          = ffa_device_match,
        .probe          = ffa_device_probe,
+       .remove         = ffa_device_remove,
        .uevent         = ffa_device_uevent,
        .dev_groups     = ffa_device_attributes_groups,
 };
@@ -127,7 +135,7 @@ static void ffa_release_device(struct device *dev)
 
 static int __ffa_devices_unregister(struct device *dev, void *data)
 {
-       ffa_release_device(dev);
+       device_unregister(dev);
 
        return 0;
 }
index 7f4d243..3d7081e 100644 (file)
@@ -68,7 +68,7 @@ config ARM_SCMI_TRANSPORT_SMC
 
 config ARM_SCMI_TRANSPORT_VIRTIO
        bool "SCMI transport based on VirtIO"
-       depends on VIRTIO
+       depends on VIRTIO=y || VIRTIO=ARM_SCMI_PROTOCOL
        select ARM_SCMI_HAVE_TRANSPORT
        select ARM_SCMI_HAVE_MSG
        help
index 224577f..11e8efb 100644 (file)
@@ -110,18 +110,16 @@ static void scmi_finalize_message(struct scmi_vio_channel *vioch,
        if (vioch->is_rx) {
                scmi_vio_feed_vq_rx(vioch, msg);
        } else {
-               unsigned long flags;
-
-               spin_lock_irqsave(&vioch->lock, flags);
+               /* Here IRQs are assumed to be already disabled by the caller */
+               spin_lock(&vioch->lock);
                list_add(&msg->list, &vioch->free_list);
-               spin_unlock_irqrestore(&vioch->lock, flags);
+               spin_unlock(&vioch->lock);
        }
 }
 
 static void scmi_vio_complete_cb(struct virtqueue *vqueue)
 {
        unsigned long ready_flags;
-       unsigned long flags;
        unsigned int length;
        struct scmi_vio_channel *vioch;
        struct scmi_vio_msg *msg;
@@ -140,7 +138,8 @@ static void scmi_vio_complete_cb(struct virtqueue *vqueue)
                        goto unlock_ready_out;
                }
 
-               spin_lock_irqsave(&vioch->lock, flags);
+               /* IRQs already disabled here no need to irqsave */
+               spin_lock(&vioch->lock);
                if (cb_enabled) {
                        virtqueue_disable_cb(vqueue);
                        cb_enabled = false;
@@ -151,7 +150,7 @@ static void scmi_vio_complete_cb(struct virtqueue *vqueue)
                                goto unlock_out;
                        cb_enabled = true;
                }
-               spin_unlock_irqrestore(&vioch->lock, flags);
+               spin_unlock(&vioch->lock);
 
                if (msg) {
                        msg->rx_len = length;
@@ -161,11 +160,18 @@ static void scmi_vio_complete_cb(struct virtqueue *vqueue)
                        scmi_finalize_message(vioch, msg);
                }
 
+               /*
+                * Release ready_lock and re-enable IRQs between loop iterations
+                * to allow virtio_chan_free() to possibly kick in and set the
+                * flag vioch->ready to false even in between processing of
+                * messages, so as to force outstanding messages to be ignored
+                * when system is shutting down.
+                */
                spin_unlock_irqrestore(&vioch->ready_lock, ready_flags);
        }
 
 unlock_out:
-       spin_unlock_irqrestore(&vioch->lock, flags);
+       spin_unlock(&vioch->lock);
 unlock_ready_out:
        spin_unlock_irqrestore(&vioch->ready_lock, ready_flags);
 }
@@ -384,8 +390,11 @@ static int scmi_vio_probe(struct virtio_device *vdev)
        struct virtqueue *vqs[VIRTIO_SCMI_VQ_MAX_CNT];
 
        /* Only one SCMI VirtiO device allowed */
-       if (scmi_vdev)
-               return -EINVAL;
+       if (scmi_vdev) {
+               dev_err(dev,
+                       "One SCMI Virtio device was already initialized: only one allowed.\n");
+               return -EBUSY;
+       }
 
        have_vq_rx = scmi_vio_have_vq_rx(vdev);
        vq_cnt = have_vq_rx ? VIRTIO_SCMI_VQ_MAX_CNT : 1;
@@ -428,16 +437,25 @@ static int scmi_vio_probe(struct virtio_device *vdev)
        }
 
        vdev->priv = channels;
-       scmi_vdev = vdev;
+       /* Ensure initialized scmi_vdev is visible */
+       smp_store_mb(scmi_vdev, vdev);
 
        return 0;
 }
 
 static void scmi_vio_remove(struct virtio_device *vdev)
 {
+       /*
+        * Once we get here, virtio_chan_free() will have already been called by
+        * the SCMI core for any existing channel and, as a consequence, all the
+        * virtio channels will have been already marked NOT ready, causing any
+        * outstanding message on any vqueue to be ignored by complete_cb: now
+        * we can just stop processing buffers and destroy the vqueues.
+        */
        vdev->config->reset(vdev);
        vdev->config->del_vqs(vdev);
-       scmi_vdev = NULL;
+       /* Ensure scmi_vdev is visible as NULL */
+       smp_store_mb(scmi_vdev, NULL);
 }
 
 static int scmi_vio_validate(struct virtio_device *vdev)
@@ -476,7 +494,7 @@ static int __init virtio_scmi_init(void)
        return register_virtio_driver(&virtio_scmi_driver);
 }
 
-static void __exit virtio_scmi_exit(void)
+static void virtio_scmi_exit(void)
 {
        unregister_virtio_driver(&virtio_scmi_driver);
 }
diff --git a/drivers/firmware/cirrus/Kconfig b/drivers/firmware/cirrus/Kconfig
new file mode 100644 (file)
index 0000000..f9503cb
--- /dev/null
@@ -0,0 +1,5 @@
+# SPDX-License-Identifier: GPL-2.0-only
+
+config CS_DSP
+       tristate
+       default n
diff --git a/drivers/firmware/cirrus/Makefile b/drivers/firmware/cirrus/Makefile
new file mode 100644 (file)
index 0000000..f074e26
--- /dev/null
@@ -0,0 +1,3 @@
+# SPDX-License-Identifier: GPL-2.0
+#
+obj-$(CONFIG_CS_DSP)           += cs_dsp.o
diff --git a/drivers/firmware/cirrus/cs_dsp.c b/drivers/firmware/cirrus/cs_dsp.c
new file mode 100644 (file)
index 0000000..948dd83
--- /dev/null
@@ -0,0 +1,3109 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * cs_dsp.c  --  Cirrus Logic DSP firmware support
+ *
+ * Based on sound/soc/codecs/wm_adsp.c
+ *
+ * Copyright 2012 Wolfson Microelectronics plc
+ * Copyright (C) 2015-2021 Cirrus Logic, Inc. and
+ *                         Cirrus Logic International Semiconductor Ltd.
+ */
+
+#include <linux/ctype.h>
+#include <linux/debugfs.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/firmware.h>
+#include <linux/interrupt.h>
+#include <linux/list.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+#include <linux/vmalloc.h>
+#include <linux/workqueue.h>
+
+#include <linux/firmware/cirrus/cs_dsp.h>
+#include <linux/firmware/cirrus/wmfw.h>
+
+#define cs_dsp_err(_dsp, fmt, ...) \
+       dev_err(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+#define cs_dsp_warn(_dsp, fmt, ...) \
+       dev_warn(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+#define cs_dsp_info(_dsp, fmt, ...) \
+       dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+#define cs_dsp_dbg(_dsp, fmt, ...) \
+       dev_dbg(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+
+#define ADSP1_CONTROL_1                   0x00
+#define ADSP1_CONTROL_2                   0x02
+#define ADSP1_CONTROL_3                   0x03
+#define ADSP1_CONTROL_4                   0x04
+#define ADSP1_CONTROL_5                   0x06
+#define ADSP1_CONTROL_6                   0x07
+#define ADSP1_CONTROL_7                   0x08
+#define ADSP1_CONTROL_8                   0x09
+#define ADSP1_CONTROL_9                   0x0A
+#define ADSP1_CONTROL_10                  0x0B
+#define ADSP1_CONTROL_11                  0x0C
+#define ADSP1_CONTROL_12                  0x0D
+#define ADSP1_CONTROL_13                  0x0F
+#define ADSP1_CONTROL_14                  0x10
+#define ADSP1_CONTROL_15                  0x11
+#define ADSP1_CONTROL_16                  0x12
+#define ADSP1_CONTROL_17                  0x13
+#define ADSP1_CONTROL_18                  0x14
+#define ADSP1_CONTROL_19                  0x16
+#define ADSP1_CONTROL_20                  0x17
+#define ADSP1_CONTROL_21                  0x18
+#define ADSP1_CONTROL_22                  0x1A
+#define ADSP1_CONTROL_23                  0x1B
+#define ADSP1_CONTROL_24                  0x1C
+#define ADSP1_CONTROL_25                  0x1E
+#define ADSP1_CONTROL_26                  0x20
+#define ADSP1_CONTROL_27                  0x21
+#define ADSP1_CONTROL_28                  0x22
+#define ADSP1_CONTROL_29                  0x23
+#define ADSP1_CONTROL_30                  0x24
+#define ADSP1_CONTROL_31                  0x26
+
+/*
+ * ADSP1 Control 19
+ */
+#define ADSP1_WDMA_BUFFER_LENGTH_MASK     0x00FF  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
+#define ADSP1_WDMA_BUFFER_LENGTH_SHIFT         0  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
+#define ADSP1_WDMA_BUFFER_LENGTH_WIDTH         8  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
+
+/*
+ * ADSP1 Control 30
+ */
+#define ADSP1_DBG_CLK_ENA                 0x0008  /* DSP1_DBG_CLK_ENA */
+#define ADSP1_DBG_CLK_ENA_MASK            0x0008  /* DSP1_DBG_CLK_ENA */
+#define ADSP1_DBG_CLK_ENA_SHIFT                3  /* DSP1_DBG_CLK_ENA */
+#define ADSP1_DBG_CLK_ENA_WIDTH                1  /* DSP1_DBG_CLK_ENA */
+#define ADSP1_SYS_ENA                     0x0004  /* DSP1_SYS_ENA */
+#define ADSP1_SYS_ENA_MASK                0x0004  /* DSP1_SYS_ENA */
+#define ADSP1_SYS_ENA_SHIFT                    2  /* DSP1_SYS_ENA */
+#define ADSP1_SYS_ENA_WIDTH                    1  /* DSP1_SYS_ENA */
+#define ADSP1_CORE_ENA                    0x0002  /* DSP1_CORE_ENA */
+#define ADSP1_CORE_ENA_MASK               0x0002  /* DSP1_CORE_ENA */
+#define ADSP1_CORE_ENA_SHIFT                   1  /* DSP1_CORE_ENA */
+#define ADSP1_CORE_ENA_WIDTH                   1  /* DSP1_CORE_ENA */
+#define ADSP1_START                       0x0001  /* DSP1_START */
+#define ADSP1_START_MASK                  0x0001  /* DSP1_START */
+#define ADSP1_START_SHIFT                      0  /* DSP1_START */
+#define ADSP1_START_WIDTH                      1  /* DSP1_START */
+
+/*
+ * ADSP1 Control 31
+ */
+#define ADSP1_CLK_SEL_MASK                0x0007  /* CLK_SEL_ENA */
+#define ADSP1_CLK_SEL_SHIFT                    0  /* CLK_SEL_ENA */
+#define ADSP1_CLK_SEL_WIDTH                    3  /* CLK_SEL_ENA */
+
+#define ADSP2_CONTROL                     0x0
+#define ADSP2_CLOCKING                    0x1
+#define ADSP2V2_CLOCKING                  0x2
+#define ADSP2_STATUS1                     0x4
+#define ADSP2_WDMA_CONFIG_1               0x30
+#define ADSP2_WDMA_CONFIG_2               0x31
+#define ADSP2V2_WDMA_CONFIG_2             0x32
+#define ADSP2_RDMA_CONFIG_1               0x34
+
+#define ADSP2_SCRATCH0                    0x40
+#define ADSP2_SCRATCH1                    0x41
+#define ADSP2_SCRATCH2                    0x42
+#define ADSP2_SCRATCH3                    0x43
+
+#define ADSP2V2_SCRATCH0_1                0x40
+#define ADSP2V2_SCRATCH2_3                0x42
+
+/*
+ * ADSP2 Control
+ */
+#define ADSP2_MEM_ENA                     0x0010  /* DSP1_MEM_ENA */
+#define ADSP2_MEM_ENA_MASK                0x0010  /* DSP1_MEM_ENA */
+#define ADSP2_MEM_ENA_SHIFT                    4  /* DSP1_MEM_ENA */
+#define ADSP2_MEM_ENA_WIDTH                    1  /* DSP1_MEM_ENA */
+#define ADSP2_SYS_ENA                     0x0004  /* DSP1_SYS_ENA */
+#define ADSP2_SYS_ENA_MASK                0x0004  /* DSP1_SYS_ENA */
+#define ADSP2_SYS_ENA_SHIFT                    2  /* DSP1_SYS_ENA */
+#define ADSP2_SYS_ENA_WIDTH                    1  /* DSP1_SYS_ENA */
+#define ADSP2_CORE_ENA                    0x0002  /* DSP1_CORE_ENA */
+#define ADSP2_CORE_ENA_MASK               0x0002  /* DSP1_CORE_ENA */
+#define ADSP2_CORE_ENA_SHIFT                   1  /* DSP1_CORE_ENA */
+#define ADSP2_CORE_ENA_WIDTH                   1  /* DSP1_CORE_ENA */
+#define ADSP2_START                       0x0001  /* DSP1_START */
+#define ADSP2_START_MASK                  0x0001  /* DSP1_START */
+#define ADSP2_START_SHIFT                      0  /* DSP1_START */
+#define ADSP2_START_WIDTH                      1  /* DSP1_START */
+
+/*
+ * ADSP2 clocking
+ */
+#define ADSP2_CLK_SEL_MASK                0x0007  /* CLK_SEL_ENA */
+#define ADSP2_CLK_SEL_SHIFT                    0  /* CLK_SEL_ENA */
+#define ADSP2_CLK_SEL_WIDTH                    3  /* CLK_SEL_ENA */
+
+/*
+ * ADSP2V2 clocking
+ */
+#define ADSP2V2_CLK_SEL_MASK             0x70000  /* CLK_SEL_ENA */
+#define ADSP2V2_CLK_SEL_SHIFT                 16  /* CLK_SEL_ENA */
+#define ADSP2V2_CLK_SEL_WIDTH                  3  /* CLK_SEL_ENA */
+
+#define ADSP2V2_RATE_MASK                 0x7800  /* DSP_RATE */
+#define ADSP2V2_RATE_SHIFT                    11  /* DSP_RATE */
+#define ADSP2V2_RATE_WIDTH                     4  /* DSP_RATE */
+
+/*
+ * ADSP2 Status 1
+ */
+#define ADSP2_RAM_RDY                     0x0001
+#define ADSP2_RAM_RDY_MASK                0x0001
+#define ADSP2_RAM_RDY_SHIFT                    0
+#define ADSP2_RAM_RDY_WIDTH                    1
+
+/*
+ * ADSP2 Lock support
+ */
+#define ADSP2_LOCK_CODE_0                    0x5555
+#define ADSP2_LOCK_CODE_1                    0xAAAA
+
+#define ADSP2_WATCHDOG                       0x0A
+#define ADSP2_BUS_ERR_ADDR                   0x52
+#define ADSP2_REGION_LOCK_STATUS             0x64
+#define ADSP2_LOCK_REGION_1_LOCK_REGION_0    0x66
+#define ADSP2_LOCK_REGION_3_LOCK_REGION_2    0x68
+#define ADSP2_LOCK_REGION_5_LOCK_REGION_4    0x6A
+#define ADSP2_LOCK_REGION_7_LOCK_REGION_6    0x6C
+#define ADSP2_LOCK_REGION_9_LOCK_REGION_8    0x6E
+#define ADSP2_LOCK_REGION_CTRL               0x7A
+#define ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR    0x7C
+
+#define ADSP2_REGION_LOCK_ERR_MASK           0x8000
+#define ADSP2_ADDR_ERR_MASK                  0x4000
+#define ADSP2_WDT_TIMEOUT_STS_MASK           0x2000
+#define ADSP2_CTRL_ERR_PAUSE_ENA             0x0002
+#define ADSP2_CTRL_ERR_EINT                  0x0001
+
+#define ADSP2_BUS_ERR_ADDR_MASK              0x00FFFFFF
+#define ADSP2_XMEM_ERR_ADDR_MASK             0x0000FFFF
+#define ADSP2_PMEM_ERR_ADDR_MASK             0x7FFF0000
+#define ADSP2_PMEM_ERR_ADDR_SHIFT            16
+#define ADSP2_WDT_ENA_MASK                   0xFFFFFFFD
+
+#define ADSP2_LOCK_REGION_SHIFT              16
+
+/*
+ * Event control messages
+ */
+#define CS_DSP_FW_EVENT_SHUTDOWN             0x000001
+
+/*
+ * HALO system info
+ */
+#define HALO_AHBM_WINDOW_DEBUG_0             0x02040
+#define HALO_AHBM_WINDOW_DEBUG_1             0x02044
+
+/*
+ * HALO core
+ */
+#define HALO_SCRATCH1                        0x005c0
+#define HALO_SCRATCH2                        0x005c8
+#define HALO_SCRATCH3                        0x005d0
+#define HALO_SCRATCH4                        0x005d8
+#define HALO_CCM_CORE_CONTROL                0x41000
+#define HALO_CORE_SOFT_RESET                 0x00010
+#define HALO_WDT_CONTROL                     0x47000
+
+/*
+ * HALO MPU banks
+ */
+#define HALO_MPU_XMEM_ACCESS_0               0x43000
+#define HALO_MPU_YMEM_ACCESS_0               0x43004
+#define HALO_MPU_WINDOW_ACCESS_0             0x43008
+#define HALO_MPU_XREG_ACCESS_0               0x4300C
+#define HALO_MPU_YREG_ACCESS_0               0x43014
+#define HALO_MPU_XMEM_ACCESS_1               0x43018
+#define HALO_MPU_YMEM_ACCESS_1               0x4301C
+#define HALO_MPU_WINDOW_ACCESS_1             0x43020
+#define HALO_MPU_XREG_ACCESS_1               0x43024
+#define HALO_MPU_YREG_ACCESS_1               0x4302C
+#define HALO_MPU_XMEM_ACCESS_2               0x43030
+#define HALO_MPU_YMEM_ACCESS_2               0x43034
+#define HALO_MPU_WINDOW_ACCESS_2             0x43038
+#define HALO_MPU_XREG_ACCESS_2               0x4303C
+#define HALO_MPU_YREG_ACCESS_2               0x43044
+#define HALO_MPU_XMEM_ACCESS_3               0x43048
+#define HALO_MPU_YMEM_ACCESS_3               0x4304C
+#define HALO_MPU_WINDOW_ACCESS_3             0x43050
+#define HALO_MPU_XREG_ACCESS_3               0x43054
+#define HALO_MPU_YREG_ACCESS_3               0x4305C
+#define HALO_MPU_XM_VIO_ADDR                 0x43100
+#define HALO_MPU_XM_VIO_STATUS               0x43104
+#define HALO_MPU_YM_VIO_ADDR                 0x43108
+#define HALO_MPU_YM_VIO_STATUS               0x4310C
+#define HALO_MPU_PM_VIO_ADDR                 0x43110
+#define HALO_MPU_PM_VIO_STATUS               0x43114
+#define HALO_MPU_LOCK_CONFIG                 0x43140
+
+/*
+ * HALO_AHBM_WINDOW_DEBUG_1
+ */
+#define HALO_AHBM_CORE_ERR_ADDR_MASK         0x0fffff00
+#define HALO_AHBM_CORE_ERR_ADDR_SHIFT                 8
+#define HALO_AHBM_FLAGS_ERR_MASK             0x000000ff
+
+/*
+ * HALO_CCM_CORE_CONTROL
+ */
+#define HALO_CORE_RESET                     0x00000200
+#define HALO_CORE_EN                        0x00000001
+
+/*
+ * HALO_CORE_SOFT_RESET
+ */
+#define HALO_CORE_SOFT_RESET_MASK           0x00000001
+
+/*
+ * HALO_WDT_CONTROL
+ */
+#define HALO_WDT_EN_MASK                    0x00000001
+
+/*
+ * HALO_MPU_?M_VIO_STATUS
+ */
+#define HALO_MPU_VIO_STS_MASK               0x007e0000
+#define HALO_MPU_VIO_STS_SHIFT                      17
+#define HALO_MPU_VIO_ERR_WR_MASK            0x00008000
+#define HALO_MPU_VIO_ERR_SRC_MASK           0x00007fff
+#define HALO_MPU_VIO_ERR_SRC_SHIFT                   0
+
+struct cs_dsp_ops {
+       bool (*validate_version)(struct cs_dsp *dsp, unsigned int version);
+       unsigned int (*parse_sizes)(struct cs_dsp *dsp,
+                                   const char * const file,
+                                   unsigned int pos,
+                                   const struct firmware *firmware);
+       int (*setup_algs)(struct cs_dsp *dsp);
+       unsigned int (*region_to_reg)(struct cs_dsp_region const *mem,
+                                     unsigned int offset);
+
+       void (*show_fw_status)(struct cs_dsp *dsp);
+       void (*stop_watchdog)(struct cs_dsp *dsp);
+
+       int (*enable_memory)(struct cs_dsp *dsp);
+       void (*disable_memory)(struct cs_dsp *dsp);
+       int (*lock_memory)(struct cs_dsp *dsp, unsigned int lock_regions);
+
+       int (*enable_core)(struct cs_dsp *dsp);
+       void (*disable_core)(struct cs_dsp *dsp);
+
+       int (*start_core)(struct cs_dsp *dsp);
+       void (*stop_core)(struct cs_dsp *dsp);
+};
+
+static const struct cs_dsp_ops cs_dsp_adsp1_ops;
+static const struct cs_dsp_ops cs_dsp_adsp2_ops[];
+static const struct cs_dsp_ops cs_dsp_halo_ops;
+
+struct cs_dsp_buf {
+       struct list_head list;
+       void *buf;
+};
+
+static struct cs_dsp_buf *cs_dsp_buf_alloc(const void *src, size_t len,
+                                          struct list_head *list)
+{
+       struct cs_dsp_buf *buf = kzalloc(sizeof(*buf), GFP_KERNEL);
+
+       if (buf == NULL)
+               return NULL;
+
+       buf->buf = vmalloc(len);
+       if (!buf->buf) {
+               kfree(buf);
+               return NULL;
+       }
+       memcpy(buf->buf, src, len);
+
+       if (list)
+               list_add_tail(&buf->list, list);
+
+       return buf;
+}
+
+static void cs_dsp_buf_free(struct list_head *list)
+{
+       while (!list_empty(list)) {
+               struct cs_dsp_buf *buf = list_first_entry(list,
+                                                         struct cs_dsp_buf,
+                                                         list);
+               list_del(&buf->list);
+               vfree(buf->buf);
+               kfree(buf);
+       }
+}
+
+/**
+ * cs_dsp_mem_region_name() - Return a name string for a memory type
+ * @type: the memory type to match
+ *
+ * Return: A const string identifying the memory region.
+ */
+const char *cs_dsp_mem_region_name(unsigned int type)
+{
+       switch (type) {
+       case WMFW_ADSP1_PM:
+               return "PM";
+       case WMFW_HALO_PM_PACKED:
+               return "PM_PACKED";
+       case WMFW_ADSP1_DM:
+               return "DM";
+       case WMFW_ADSP2_XM:
+               return "XM";
+       case WMFW_HALO_XM_PACKED:
+               return "XM_PACKED";
+       case WMFW_ADSP2_YM:
+               return "YM";
+       case WMFW_HALO_YM_PACKED:
+               return "YM_PACKED";
+       case WMFW_ADSP1_ZM:
+               return "ZM";
+       default:
+               return NULL;
+       }
+}
+EXPORT_SYMBOL_GPL(cs_dsp_mem_region_name);
+
+#ifdef CONFIG_DEBUG_FS
+static void cs_dsp_debugfs_save_wmfwname(struct cs_dsp *dsp, const char *s)
+{
+       char *tmp = kasprintf(GFP_KERNEL, "%s\n", s);
+
+       kfree(dsp->wmfw_file_name);
+       dsp->wmfw_file_name = tmp;
+}
+
+static void cs_dsp_debugfs_save_binname(struct cs_dsp *dsp, const char *s)
+{
+       char *tmp = kasprintf(GFP_KERNEL, "%s\n", s);
+
+       kfree(dsp->bin_file_name);
+       dsp->bin_file_name = tmp;
+}
+
+static void cs_dsp_debugfs_clear(struct cs_dsp *dsp)
+{
+       kfree(dsp->wmfw_file_name);
+       kfree(dsp->bin_file_name);
+       dsp->wmfw_file_name = NULL;
+       dsp->bin_file_name = NULL;
+}
+
+static ssize_t cs_dsp_debugfs_wmfw_read(struct file *file,
+                                       char __user *user_buf,
+                                       size_t count, loff_t *ppos)
+{
+       struct cs_dsp *dsp = file->private_data;
+       ssize_t ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       if (!dsp->wmfw_file_name || !dsp->booted)
+               ret = 0;
+       else
+               ret = simple_read_from_buffer(user_buf, count, ppos,
+                                             dsp->wmfw_file_name,
+                                             strlen(dsp->wmfw_file_name));
+
+       mutex_unlock(&dsp->pwr_lock);
+       return ret;
+}
+
+static ssize_t cs_dsp_debugfs_bin_read(struct file *file,
+                                      char __user *user_buf,
+                                      size_t count, loff_t *ppos)
+{
+       struct cs_dsp *dsp = file->private_data;
+       ssize_t ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       if (!dsp->bin_file_name || !dsp->booted)
+               ret = 0;
+       else
+               ret = simple_read_from_buffer(user_buf, count, ppos,
+                                             dsp->bin_file_name,
+                                             strlen(dsp->bin_file_name));
+
+       mutex_unlock(&dsp->pwr_lock);
+       return ret;
+}
+
+static const struct {
+       const char *name;
+       const struct file_operations fops;
+} cs_dsp_debugfs_fops[] = {
+       {
+               .name = "wmfw_file_name",
+               .fops = {
+                       .open = simple_open,
+                       .read = cs_dsp_debugfs_wmfw_read,
+               },
+       },
+       {
+               .name = "bin_file_name",
+               .fops = {
+                       .open = simple_open,
+                       .read = cs_dsp_debugfs_bin_read,
+               },
+       },
+};
+
+/**
+ * cs_dsp_init_debugfs() - Create and populate DSP representation in debugfs
+ * @dsp: pointer to DSP structure
+ * @debugfs_root: pointer to debugfs directory in which to create this DSP
+ *                representation
+ */
+void cs_dsp_init_debugfs(struct cs_dsp *dsp, struct dentry *debugfs_root)
+{
+       struct dentry *root = NULL;
+       int i;
+
+       root = debugfs_create_dir(dsp->name, debugfs_root);
+
+       debugfs_create_bool("booted", 0444, root, &dsp->booted);
+       debugfs_create_bool("running", 0444, root, &dsp->running);
+       debugfs_create_x32("fw_id", 0444, root, &dsp->fw_id);
+       debugfs_create_x32("fw_version", 0444, root, &dsp->fw_id_version);
+
+       for (i = 0; i < ARRAY_SIZE(cs_dsp_debugfs_fops); ++i)
+               debugfs_create_file(cs_dsp_debugfs_fops[i].name, 0444, root,
+                                   dsp, &cs_dsp_debugfs_fops[i].fops);
+
+       dsp->debugfs_root = root;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_init_debugfs);
+
+/**
+ * cs_dsp_cleanup_debugfs() - Removes DSP representation from debugfs
+ * @dsp: pointer to DSP structure
+ */
+void cs_dsp_cleanup_debugfs(struct cs_dsp *dsp)
+{
+       cs_dsp_debugfs_clear(dsp);
+       debugfs_remove_recursive(dsp->debugfs_root);
+       dsp->debugfs_root = NULL;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_cleanup_debugfs);
+#else
+void cs_dsp_init_debugfs(struct cs_dsp *dsp, struct dentry *debugfs_root)
+{
+}
+EXPORT_SYMBOL_GPL(cs_dsp_init_debugfs);
+
+void cs_dsp_cleanup_debugfs(struct cs_dsp *dsp)
+{
+}
+EXPORT_SYMBOL_GPL(cs_dsp_cleanup_debugfs);
+
+static inline void cs_dsp_debugfs_save_wmfwname(struct cs_dsp *dsp,
+                                               const char *s)
+{
+}
+
+static inline void cs_dsp_debugfs_save_binname(struct cs_dsp *dsp,
+                                              const char *s)
+{
+}
+
+static inline void cs_dsp_debugfs_clear(struct cs_dsp *dsp)
+{
+}
+#endif
+
+static const struct cs_dsp_region *cs_dsp_find_region(struct cs_dsp *dsp,
+                                                     int type)
+{
+       int i;
+
+       for (i = 0; i < dsp->num_mems; i++)
+               if (dsp->mem[i].type == type)
+                       return &dsp->mem[i];
+
+       return NULL;
+}
+
+static unsigned int cs_dsp_region_to_reg(struct cs_dsp_region const *mem,
+                                        unsigned int offset)
+{
+       switch (mem->type) {
+       case WMFW_ADSP1_PM:
+               return mem->base + (offset * 3);
+       case WMFW_ADSP1_DM:
+       case WMFW_ADSP2_XM:
+       case WMFW_ADSP2_YM:
+       case WMFW_ADSP1_ZM:
+               return mem->base + (offset * 2);
+       default:
+               WARN(1, "Unknown memory region type");
+               return offset;
+       }
+}
+
+static unsigned int cs_dsp_halo_region_to_reg(struct cs_dsp_region const *mem,
+                                             unsigned int offset)
+{
+       switch (mem->type) {
+       case WMFW_ADSP2_XM:
+       case WMFW_ADSP2_YM:
+               return mem->base + (offset * 4);
+       case WMFW_HALO_XM_PACKED:
+       case WMFW_HALO_YM_PACKED:
+               return (mem->base + (offset * 3)) & ~0x3;
+       case WMFW_HALO_PM_PACKED:
+               return mem->base + (offset * 5);
+       default:
+               WARN(1, "Unknown memory region type");
+               return offset;
+       }
+}
+
+static void cs_dsp_read_fw_status(struct cs_dsp *dsp,
+                                 int noffs, unsigned int *offs)
+{
+       unsigned int i;
+       int ret;
+
+       for (i = 0; i < noffs; ++i) {
+               ret = regmap_read(dsp->regmap, dsp->base + offs[i], &offs[i]);
+               if (ret) {
+                       cs_dsp_err(dsp, "Failed to read SCRATCH%u: %d\n", i, ret);
+                       return;
+               }
+       }
+}
+
+static void cs_dsp_adsp2_show_fw_status(struct cs_dsp *dsp)
+{
+       unsigned int offs[] = {
+               ADSP2_SCRATCH0, ADSP2_SCRATCH1, ADSP2_SCRATCH2, ADSP2_SCRATCH3,
+       };
+
+       cs_dsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
+
+       cs_dsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
+                  offs[0], offs[1], offs[2], offs[3]);
+}
+
+static void cs_dsp_adsp2v2_show_fw_status(struct cs_dsp *dsp)
+{
+       unsigned int offs[] = { ADSP2V2_SCRATCH0_1, ADSP2V2_SCRATCH2_3 };
+
+       cs_dsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
+
+       cs_dsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
+                  offs[0] & 0xFFFF, offs[0] >> 16,
+                  offs[1] & 0xFFFF, offs[1] >> 16);
+}
+
+static void cs_dsp_halo_show_fw_status(struct cs_dsp *dsp)
+{
+       unsigned int offs[] = {
+               HALO_SCRATCH1, HALO_SCRATCH2, HALO_SCRATCH3, HALO_SCRATCH4,
+       };
+
+       cs_dsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
+
+       cs_dsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
+                  offs[0], offs[1], offs[2], offs[3]);
+}
+
+static int cs_dsp_coeff_base_reg(struct cs_dsp_coeff_ctl *ctl, unsigned int *reg)
+{
+       const struct cs_dsp_alg_region *alg_region = &ctl->alg_region;
+       struct cs_dsp *dsp = ctl->dsp;
+       const struct cs_dsp_region *mem;
+
+       mem = cs_dsp_find_region(dsp, alg_region->type);
+       if (!mem) {
+               cs_dsp_err(dsp, "No base for region %x\n",
+                          alg_region->type);
+               return -EINVAL;
+       }
+
+       *reg = dsp->ops->region_to_reg(mem, ctl->alg_region.base + ctl->offset);
+
+       return 0;
+}
+
+/**
+ * cs_dsp_coeff_write_acked_control() - Sends event_id to the acked control
+ * @ctl: pointer to acked coefficient control
+ * @event_id: the value to write to the given acked control
+ *
+ * Once the value has been written to the control the function shall block
+ * until the running firmware acknowledges the write or timeout is exceeded.
+ *
+ * Must be called with pwr_lock held.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_coeff_write_acked_control(struct cs_dsp_coeff_ctl *ctl, unsigned int event_id)
+{
+       struct cs_dsp *dsp = ctl->dsp;
+       __be32 val = cpu_to_be32(event_id);
+       unsigned int reg;
+       int i, ret;
+
+       if (!dsp->running)
+               return -EPERM;
+
+       ret = cs_dsp_coeff_base_reg(ctl, &reg);
+       if (ret)
+               return ret;
+
+       cs_dsp_dbg(dsp, "Sending 0x%x to acked control alg 0x%x %s:0x%x\n",
+                  event_id, ctl->alg_region.alg,
+                  cs_dsp_mem_region_name(ctl->alg_region.type), ctl->offset);
+
+       ret = regmap_raw_write(dsp->regmap, reg, &val, sizeof(val));
+       if (ret) {
+               cs_dsp_err(dsp, "Failed to write %x: %d\n", reg, ret);
+               return ret;
+       }
+
+       /*
+        * Poll for ack, we initially poll at ~1ms intervals for firmwares
+        * that respond quickly, then go to ~10ms polls. A firmware is unlikely
+        * to ack instantly so we do the first 1ms delay before reading the
+        * control to avoid a pointless bus transaction
+        */
+       for (i = 0; i < CS_DSP_ACKED_CTL_TIMEOUT_MS;) {
+               switch (i) {
+               case 0 ... CS_DSP_ACKED_CTL_N_QUICKPOLLS - 1:
+                       usleep_range(1000, 2000);
+                       i++;
+                       break;
+               default:
+                       usleep_range(10000, 20000);
+                       i += 10;
+                       break;
+               }
+
+               ret = regmap_raw_read(dsp->regmap, reg, &val, sizeof(val));
+               if (ret) {
+                       cs_dsp_err(dsp, "Failed to read %x: %d\n", reg, ret);
+                       return ret;
+               }
+
+               if (val == 0) {
+                       cs_dsp_dbg(dsp, "Acked control ACKED at poll %u\n", i);
+                       return 0;
+               }
+       }
+
+       cs_dsp_warn(dsp, "Acked control @0x%x alg:0x%x %s:0x%x timed out\n",
+                   reg, ctl->alg_region.alg,
+                   cs_dsp_mem_region_name(ctl->alg_region.type),
+                   ctl->offset);
+
+       return -ETIMEDOUT;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_coeff_write_acked_control);
+
+static int cs_dsp_coeff_write_ctrl_raw(struct cs_dsp_coeff_ctl *ctl,
+                                      const void *buf, size_t len)
+{
+       struct cs_dsp *dsp = ctl->dsp;
+       void *scratch;
+       int ret;
+       unsigned int reg;
+
+       ret = cs_dsp_coeff_base_reg(ctl, &reg);
+       if (ret)
+               return ret;
+
+       scratch = kmemdup(buf, len, GFP_KERNEL | GFP_DMA);
+       if (!scratch)
+               return -ENOMEM;
+
+       ret = regmap_raw_write(dsp->regmap, reg, scratch,
+                              len);
+       if (ret) {
+               cs_dsp_err(dsp, "Failed to write %zu bytes to %x: %d\n",
+                          len, reg, ret);
+               kfree(scratch);
+               return ret;
+       }
+       cs_dsp_dbg(dsp, "Wrote %zu bytes to %x\n", len, reg);
+
+       kfree(scratch);
+
+       return 0;
+}
+
+/**
+ * cs_dsp_coeff_write_ctrl() - Writes the given buffer to the given coefficient control
+ * @ctl: pointer to coefficient control
+ * @buf: the buffer to write to the given control
+ * @len: the length of the buffer
+ *
+ * Must be called with pwr_lock held.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_coeff_write_ctrl(struct cs_dsp_coeff_ctl *ctl, const void *buf, size_t len)
+{
+       int ret = 0;
+
+       if (ctl->flags & WMFW_CTL_FLAG_VOLATILE)
+               ret = -EPERM;
+       else if (buf != ctl->cache)
+               memcpy(ctl->cache, buf, len);
+
+       ctl->set = 1;
+       if (ctl->enabled && ctl->dsp->running)
+               ret = cs_dsp_coeff_write_ctrl_raw(ctl, buf, len);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_coeff_write_ctrl);
+
+static int cs_dsp_coeff_read_ctrl_raw(struct cs_dsp_coeff_ctl *ctl, void *buf, size_t len)
+{
+       struct cs_dsp *dsp = ctl->dsp;
+       void *scratch;
+       int ret;
+       unsigned int reg;
+
+       ret = cs_dsp_coeff_base_reg(ctl, &reg);
+       if (ret)
+               return ret;
+
+       scratch = kmalloc(len, GFP_KERNEL | GFP_DMA);
+       if (!scratch)
+               return -ENOMEM;
+
+       ret = regmap_raw_read(dsp->regmap, reg, scratch, len);
+       if (ret) {
+               cs_dsp_err(dsp, "Failed to read %zu bytes from %x: %d\n",
+                          len, reg, ret);
+               kfree(scratch);
+               return ret;
+       }
+       cs_dsp_dbg(dsp, "Read %zu bytes from %x\n", len, reg);
+
+       memcpy(buf, scratch, len);
+       kfree(scratch);
+
+       return 0;
+}
+
+/**
+ * cs_dsp_coeff_read_ctrl() - Reads the given coefficient control into the given buffer
+ * @ctl: pointer to coefficient control
+ * @buf: the buffer to store to the given control
+ * @len: the length of the buffer
+ *
+ * Must be called with pwr_lock held.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_coeff_read_ctrl(struct cs_dsp_coeff_ctl *ctl, void *buf, size_t len)
+{
+       int ret = 0;
+
+       if (ctl->flags & WMFW_CTL_FLAG_VOLATILE) {
+               if (ctl->enabled && ctl->dsp->running)
+                       return cs_dsp_coeff_read_ctrl_raw(ctl, buf, len);
+               else
+                       return -EPERM;
+       } else {
+               if (!ctl->flags && ctl->enabled && ctl->dsp->running)
+                       ret = cs_dsp_coeff_read_ctrl_raw(ctl, ctl->cache, ctl->len);
+
+               if (buf != ctl->cache)
+                       memcpy(buf, ctl->cache, len);
+       }
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_coeff_read_ctrl);
+
+static int cs_dsp_coeff_init_control_caches(struct cs_dsp *dsp)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+       int ret;
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list) {
+               if (!ctl->enabled || ctl->set)
+                       continue;
+               if (ctl->flags & WMFW_CTL_FLAG_VOLATILE)
+                       continue;
+
+               /*
+                * For readable controls populate the cache from the DSP memory.
+                * For non-readable controls the cache was zero-filled when
+                * created so we don't need to do anything.
+                */
+               if (!ctl->flags || (ctl->flags & WMFW_CTL_FLAG_READABLE)) {
+                       ret = cs_dsp_coeff_read_ctrl_raw(ctl, ctl->cache, ctl->len);
+                       if (ret < 0)
+                               return ret;
+               }
+       }
+
+       return 0;
+}
+
+static int cs_dsp_coeff_sync_controls(struct cs_dsp *dsp)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+       int ret;
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list) {
+               if (!ctl->enabled)
+                       continue;
+               if (ctl->set && !(ctl->flags & WMFW_CTL_FLAG_VOLATILE)) {
+                       ret = cs_dsp_coeff_write_ctrl_raw(ctl, ctl->cache,
+                                                         ctl->len);
+                       if (ret < 0)
+                               return ret;
+               }
+       }
+
+       return 0;
+}
+
+static void cs_dsp_signal_event_controls(struct cs_dsp *dsp,
+                                        unsigned int event)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+       int ret;
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list) {
+               if (ctl->type != WMFW_CTL_TYPE_HOSTEVENT)
+                       continue;
+
+               if (!ctl->enabled)
+                       continue;
+
+               ret = cs_dsp_coeff_write_acked_control(ctl, event);
+               if (ret)
+                       cs_dsp_warn(dsp,
+                                   "Failed to send 0x%x event to alg 0x%x (%d)\n",
+                                   event, ctl->alg_region.alg, ret);
+       }
+}
+
+static void cs_dsp_free_ctl_blk(struct cs_dsp_coeff_ctl *ctl)
+{
+       kfree(ctl->cache);
+       kfree(ctl->subname);
+       kfree(ctl);
+}
+
+static int cs_dsp_create_control(struct cs_dsp *dsp,
+                                const struct cs_dsp_alg_region *alg_region,
+                                unsigned int offset, unsigned int len,
+                                const char *subname, unsigned int subname_len,
+                                unsigned int flags, unsigned int type)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+       int ret;
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list) {
+               if (ctl->fw_name == dsp->fw_name &&
+                   ctl->alg_region.alg == alg_region->alg &&
+                   ctl->alg_region.type == alg_region->type) {
+                       if ((!subname && !ctl->subname) ||
+                           (subname && !strncmp(ctl->subname, subname, ctl->subname_len))) {
+                               if (!ctl->enabled)
+                                       ctl->enabled = 1;
+                               return 0;
+                       }
+               }
+       }
+
+       ctl = kzalloc(sizeof(*ctl), GFP_KERNEL);
+       if (!ctl)
+               return -ENOMEM;
+
+       ctl->fw_name = dsp->fw_name;
+       ctl->alg_region = *alg_region;
+       if (subname && dsp->fw_ver >= 2) {
+               ctl->subname_len = subname_len;
+               ctl->subname = kmemdup(subname,
+                                      strlen(subname) + 1, GFP_KERNEL);
+               if (!ctl->subname) {
+                       ret = -ENOMEM;
+                       goto err_ctl;
+               }
+       }
+       ctl->enabled = 1;
+       ctl->set = 0;
+       ctl->dsp = dsp;
+
+       ctl->flags = flags;
+       ctl->type = type;
+       ctl->offset = offset;
+       ctl->len = len;
+       ctl->cache = kzalloc(ctl->len, GFP_KERNEL);
+       if (!ctl->cache) {
+               ret = -ENOMEM;
+               goto err_ctl_subname;
+       }
+
+       list_add(&ctl->list, &dsp->ctl_list);
+
+       if (dsp->client_ops->control_add) {
+               ret = dsp->client_ops->control_add(ctl);
+               if (ret)
+                       goto err_list_del;
+       }
+
+       return 0;
+
+err_list_del:
+       list_del(&ctl->list);
+       kfree(ctl->cache);
+err_ctl_subname:
+       kfree(ctl->subname);
+err_ctl:
+       kfree(ctl);
+
+       return ret;
+}
+
+struct cs_dsp_coeff_parsed_alg {
+       int id;
+       const u8 *name;
+       int name_len;
+       int ncoeff;
+};
+
+struct cs_dsp_coeff_parsed_coeff {
+       int offset;
+       int mem_type;
+       const u8 *name;
+       int name_len;
+       unsigned int ctl_type;
+       int flags;
+       int len;
+};
+
+static int cs_dsp_coeff_parse_string(int bytes, const u8 **pos, const u8 **str)
+{
+       int length;
+
+       switch (bytes) {
+       case 1:
+               length = **pos;
+               break;
+       case 2:
+               length = le16_to_cpu(*((__le16 *)*pos));
+               break;
+       default:
+               return 0;
+       }
+
+       if (str)
+               *str = *pos + bytes;
+
+       *pos += ((length + bytes) + 3) & ~0x03;
+
+       return length;
+}
+
+static int cs_dsp_coeff_parse_int(int bytes, const u8 **pos)
+{
+       int val = 0;
+
+       switch (bytes) {
+       case 2:
+               val = le16_to_cpu(*((__le16 *)*pos));
+               break;
+       case 4:
+               val = le32_to_cpu(*((__le32 *)*pos));
+               break;
+       default:
+               break;
+       }
+
+       *pos += bytes;
+
+       return val;
+}
+
+static inline void cs_dsp_coeff_parse_alg(struct cs_dsp *dsp, const u8 **data,
+                                         struct cs_dsp_coeff_parsed_alg *blk)
+{
+       const struct wmfw_adsp_alg_data *raw;
+
+       switch (dsp->fw_ver) {
+       case 0:
+       case 1:
+               raw = (const struct wmfw_adsp_alg_data *)*data;
+               *data = raw->data;
+
+               blk->id = le32_to_cpu(raw->id);
+               blk->name = raw->name;
+               blk->name_len = strlen(raw->name);
+               blk->ncoeff = le32_to_cpu(raw->ncoeff);
+               break;
+       default:
+               blk->id = cs_dsp_coeff_parse_int(sizeof(raw->id), data);
+               blk->name_len = cs_dsp_coeff_parse_string(sizeof(u8), data,
+                                                         &blk->name);
+               cs_dsp_coeff_parse_string(sizeof(u16), data, NULL);
+               blk->ncoeff = cs_dsp_coeff_parse_int(sizeof(raw->ncoeff), data);
+               break;
+       }
+
+       cs_dsp_dbg(dsp, "Algorithm ID: %#x\n", blk->id);
+       cs_dsp_dbg(dsp, "Algorithm name: %.*s\n", blk->name_len, blk->name);
+       cs_dsp_dbg(dsp, "# of coefficient descriptors: %#x\n", blk->ncoeff);
+}
+
+static inline void cs_dsp_coeff_parse_coeff(struct cs_dsp *dsp, const u8 **data,
+                                           struct cs_dsp_coeff_parsed_coeff *blk)
+{
+       const struct wmfw_adsp_coeff_data *raw;
+       const u8 *tmp;
+       int length;
+
+       switch (dsp->fw_ver) {
+       case 0:
+       case 1:
+               raw = (const struct wmfw_adsp_coeff_data *)*data;
+               *data = *data + sizeof(raw->hdr) + le32_to_cpu(raw->hdr.size);
+
+               blk->offset = le16_to_cpu(raw->hdr.offset);
+               blk->mem_type = le16_to_cpu(raw->hdr.type);
+               blk->name = raw->name;
+               blk->name_len = strlen(raw->name);
+               blk->ctl_type = le16_to_cpu(raw->ctl_type);
+               blk->flags = le16_to_cpu(raw->flags);
+               blk->len = le32_to_cpu(raw->len);
+               break;
+       default:
+               tmp = *data;
+               blk->offset = cs_dsp_coeff_parse_int(sizeof(raw->hdr.offset), &tmp);
+               blk->mem_type = cs_dsp_coeff_parse_int(sizeof(raw->hdr.type), &tmp);
+               length = cs_dsp_coeff_parse_int(sizeof(raw->hdr.size), &tmp);
+               blk->name_len = cs_dsp_coeff_parse_string(sizeof(u8), &tmp,
+                                                         &blk->name);
+               cs_dsp_coeff_parse_string(sizeof(u8), &tmp, NULL);
+               cs_dsp_coeff_parse_string(sizeof(u16), &tmp, NULL);
+               blk->ctl_type = cs_dsp_coeff_parse_int(sizeof(raw->ctl_type), &tmp);
+               blk->flags = cs_dsp_coeff_parse_int(sizeof(raw->flags), &tmp);
+               blk->len = cs_dsp_coeff_parse_int(sizeof(raw->len), &tmp);
+
+               *data = *data + sizeof(raw->hdr) + length;
+               break;
+       }
+
+       cs_dsp_dbg(dsp, "\tCoefficient type: %#x\n", blk->mem_type);
+       cs_dsp_dbg(dsp, "\tCoefficient offset: %#x\n", blk->offset);
+       cs_dsp_dbg(dsp, "\tCoefficient name: %.*s\n", blk->name_len, blk->name);
+       cs_dsp_dbg(dsp, "\tCoefficient flags: %#x\n", blk->flags);
+       cs_dsp_dbg(dsp, "\tALSA control type: %#x\n", blk->ctl_type);
+       cs_dsp_dbg(dsp, "\tALSA control len: %#x\n", blk->len);
+}
+
+static int cs_dsp_check_coeff_flags(struct cs_dsp *dsp,
+                                   const struct cs_dsp_coeff_parsed_coeff *coeff_blk,
+                                   unsigned int f_required,
+                                   unsigned int f_illegal)
+{
+       if ((coeff_blk->flags & f_illegal) ||
+           ((coeff_blk->flags & f_required) != f_required)) {
+               cs_dsp_err(dsp, "Illegal flags 0x%x for control type 0x%x\n",
+                          coeff_blk->flags, coeff_blk->ctl_type);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int cs_dsp_parse_coeff(struct cs_dsp *dsp,
+                             const struct wmfw_region *region)
+{
+       struct cs_dsp_alg_region alg_region = {};
+       struct cs_dsp_coeff_parsed_alg alg_blk;
+       struct cs_dsp_coeff_parsed_coeff coeff_blk;
+       const u8 *data = region->data;
+       int i, ret;
+
+       cs_dsp_coeff_parse_alg(dsp, &data, &alg_blk);
+       for (i = 0; i < alg_blk.ncoeff; i++) {
+               cs_dsp_coeff_parse_coeff(dsp, &data, &coeff_blk);
+
+               switch (coeff_blk.ctl_type) {
+               case WMFW_CTL_TYPE_BYTES:
+                       break;
+               case WMFW_CTL_TYPE_ACKED:
+                       if (coeff_blk.flags & WMFW_CTL_FLAG_SYS)
+                               continue;       /* ignore */
+
+                       ret = cs_dsp_check_coeff_flags(dsp, &coeff_blk,
+                                                      WMFW_CTL_FLAG_VOLATILE |
+                                                      WMFW_CTL_FLAG_WRITEABLE |
+                                                      WMFW_CTL_FLAG_READABLE,
+                                                      0);
+                       if (ret)
+                               return -EINVAL;
+                       break;
+               case WMFW_CTL_TYPE_HOSTEVENT:
+                       ret = cs_dsp_check_coeff_flags(dsp, &coeff_blk,
+                                                      WMFW_CTL_FLAG_SYS |
+                                                      WMFW_CTL_FLAG_VOLATILE |
+                                                      WMFW_CTL_FLAG_WRITEABLE |
+                                                      WMFW_CTL_FLAG_READABLE,
+                                                      0);
+                       if (ret)
+                               return -EINVAL;
+                       break;
+               case WMFW_CTL_TYPE_HOST_BUFFER:
+                       ret = cs_dsp_check_coeff_flags(dsp, &coeff_blk,
+                                                      WMFW_CTL_FLAG_SYS |
+                                                      WMFW_CTL_FLAG_VOLATILE |
+                                                      WMFW_CTL_FLAG_READABLE,
+                                                      0);
+                       if (ret)
+                               return -EINVAL;
+                       break;
+               default:
+                       cs_dsp_err(dsp, "Unknown control type: %d\n",
+                                  coeff_blk.ctl_type);
+                       return -EINVAL;
+               }
+
+               alg_region.type = coeff_blk.mem_type;
+               alg_region.alg = alg_blk.id;
+
+               ret = cs_dsp_create_control(dsp, &alg_region,
+                                           coeff_blk.offset,
+                                           coeff_blk.len,
+                                           coeff_blk.name,
+                                           coeff_blk.name_len,
+                                           coeff_blk.flags,
+                                           coeff_blk.ctl_type);
+               if (ret < 0)
+                       cs_dsp_err(dsp, "Failed to create control: %.*s, %d\n",
+                                  coeff_blk.name_len, coeff_blk.name, ret);
+       }
+
+       return 0;
+}
+
+static unsigned int cs_dsp_adsp1_parse_sizes(struct cs_dsp *dsp,
+                                            const char * const file,
+                                            unsigned int pos,
+                                            const struct firmware *firmware)
+{
+       const struct wmfw_adsp1_sizes *adsp1_sizes;
+
+       adsp1_sizes = (void *)&firmware->data[pos];
+
+       cs_dsp_dbg(dsp, "%s: %d DM, %d PM, %d ZM\n", file,
+                  le32_to_cpu(adsp1_sizes->dm), le32_to_cpu(adsp1_sizes->pm),
+                  le32_to_cpu(adsp1_sizes->zm));
+
+       return pos + sizeof(*adsp1_sizes);
+}
+
+static unsigned int cs_dsp_adsp2_parse_sizes(struct cs_dsp *dsp,
+                                            const char * const file,
+                                            unsigned int pos,
+                                            const struct firmware *firmware)
+{
+       const struct wmfw_adsp2_sizes *adsp2_sizes;
+
+       adsp2_sizes = (void *)&firmware->data[pos];
+
+       cs_dsp_dbg(dsp, "%s: %d XM, %d YM %d PM, %d ZM\n", file,
+                  le32_to_cpu(adsp2_sizes->xm), le32_to_cpu(adsp2_sizes->ym),
+                  le32_to_cpu(adsp2_sizes->pm), le32_to_cpu(adsp2_sizes->zm));
+
+       return pos + sizeof(*adsp2_sizes);
+}
+
+static bool cs_dsp_validate_version(struct cs_dsp *dsp, unsigned int version)
+{
+       switch (version) {
+       case 0:
+               cs_dsp_warn(dsp, "Deprecated file format %d\n", version);
+               return true;
+       case 1:
+       case 2:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool cs_dsp_halo_validate_version(struct cs_dsp *dsp, unsigned int version)
+{
+       switch (version) {
+       case 3:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static int cs_dsp_load(struct cs_dsp *dsp, const struct firmware *firmware,
+                      const char *file)
+{
+       LIST_HEAD(buf_list);
+       struct regmap *regmap = dsp->regmap;
+       unsigned int pos = 0;
+       const struct wmfw_header *header;
+       const struct wmfw_adsp1_sizes *adsp1_sizes;
+       const struct wmfw_footer *footer;
+       const struct wmfw_region *region;
+       const struct cs_dsp_region *mem;
+       const char *region_name;
+       char *text = NULL;
+       struct cs_dsp_buf *buf;
+       unsigned int reg;
+       int regions = 0;
+       int ret, offset, type;
+
+       ret = -EINVAL;
+
+       pos = sizeof(*header) + sizeof(*adsp1_sizes) + sizeof(*footer);
+       if (pos >= firmware->size) {
+               cs_dsp_err(dsp, "%s: file too short, %zu bytes\n",
+                          file, firmware->size);
+               goto out_fw;
+       }
+
+       header = (void *)&firmware->data[0];
+
+       if (memcmp(&header->magic[0], "WMFW", 4) != 0) {
+               cs_dsp_err(dsp, "%s: invalid magic\n", file);
+               goto out_fw;
+       }
+
+       if (!dsp->ops->validate_version(dsp, header->ver)) {
+               cs_dsp_err(dsp, "%s: unknown file format %d\n",
+                          file, header->ver);
+               goto out_fw;
+       }
+
+       cs_dsp_info(dsp, "Firmware version: %d\n", header->ver);
+       dsp->fw_ver = header->ver;
+
+       if (header->core != dsp->type) {
+               cs_dsp_err(dsp, "%s: invalid core %d != %d\n",
+                          file, header->core, dsp->type);
+               goto out_fw;
+       }
+
+       pos = sizeof(*header);
+       pos = dsp->ops->parse_sizes(dsp, file, pos, firmware);
+
+       footer = (void *)&firmware->data[pos];
+       pos += sizeof(*footer);
+
+       if (le32_to_cpu(header->len) != pos) {
+               cs_dsp_err(dsp, "%s: unexpected header length %d\n",
+                          file, le32_to_cpu(header->len));
+               goto out_fw;
+       }
+
+       cs_dsp_dbg(dsp, "%s: timestamp %llu\n", file,
+                  le64_to_cpu(footer->timestamp));
+
+       while (pos < firmware->size &&
+              sizeof(*region) < firmware->size - pos) {
+               region = (void *)&(firmware->data[pos]);
+               region_name = "Unknown";
+               reg = 0;
+               text = NULL;
+               offset = le32_to_cpu(region->offset) & 0xffffff;
+               type = be32_to_cpu(region->type) & 0xff;
+
+               switch (type) {
+               case WMFW_NAME_TEXT:
+                       region_name = "Firmware name";
+                       text = kzalloc(le32_to_cpu(region->len) + 1,
+                                      GFP_KERNEL);
+                       break;
+               case WMFW_ALGORITHM_DATA:
+                       region_name = "Algorithm";
+                       ret = cs_dsp_parse_coeff(dsp, region);
+                       if (ret != 0)
+                               goto out_fw;
+                       break;
+               case WMFW_INFO_TEXT:
+                       region_name = "Information";
+                       text = kzalloc(le32_to_cpu(region->len) + 1,
+                                      GFP_KERNEL);
+                       break;
+               case WMFW_ABSOLUTE:
+                       region_name = "Absolute";
+                       reg = offset;
+                       break;
+               case WMFW_ADSP1_PM:
+               case WMFW_ADSP1_DM:
+               case WMFW_ADSP2_XM:
+               case WMFW_ADSP2_YM:
+               case WMFW_ADSP1_ZM:
+               case WMFW_HALO_PM_PACKED:
+               case WMFW_HALO_XM_PACKED:
+               case WMFW_HALO_YM_PACKED:
+                       mem = cs_dsp_find_region(dsp, type);
+                       if (!mem) {
+                               cs_dsp_err(dsp, "No region of type: %x\n", type);
+                               ret = -EINVAL;
+                               goto out_fw;
+                       }
+
+                       region_name = cs_dsp_mem_region_name(type);
+                       reg = dsp->ops->region_to_reg(mem, offset);
+                       break;
+               default:
+                       cs_dsp_warn(dsp,
+                                   "%s.%d: Unknown region type %x at %d(%x)\n",
+                                   file, regions, type, pos, pos);
+                       break;
+               }
+
+               cs_dsp_dbg(dsp, "%s.%d: %d bytes at %d in %s\n", file,
+                          regions, le32_to_cpu(region->len), offset,
+                          region_name);
+
+               if (le32_to_cpu(region->len) >
+                   firmware->size - pos - sizeof(*region)) {
+                       cs_dsp_err(dsp,
+                                  "%s.%d: %s region len %d bytes exceeds file length %zu\n",
+                                  file, regions, region_name,
+                                  le32_to_cpu(region->len), firmware->size);
+                       ret = -EINVAL;
+                       goto out_fw;
+               }
+
+               if (text) {
+                       memcpy(text, region->data, le32_to_cpu(region->len));
+                       cs_dsp_info(dsp, "%s: %s\n", file, text);
+                       kfree(text);
+                       text = NULL;
+               }
+
+               if (reg) {
+                       buf = cs_dsp_buf_alloc(region->data,
+                                              le32_to_cpu(region->len),
+                                              &buf_list);
+                       if (!buf) {
+                               cs_dsp_err(dsp, "Out of memory\n");
+                               ret = -ENOMEM;
+                               goto out_fw;
+                       }
+
+                       ret = regmap_raw_write_async(regmap, reg, buf->buf,
+                                                    le32_to_cpu(region->len));
+                       if (ret != 0) {
+                               cs_dsp_err(dsp,
+                                          "%s.%d: Failed to write %d bytes at %d in %s: %d\n",
+                                          file, regions,
+                                          le32_to_cpu(region->len), offset,
+                                          region_name, ret);
+                               goto out_fw;
+                       }
+               }
+
+               pos += le32_to_cpu(region->len) + sizeof(*region);
+               regions++;
+       }
+
+       ret = regmap_async_complete(regmap);
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to complete async write: %d\n", ret);
+               goto out_fw;
+       }
+
+       if (pos > firmware->size)
+               cs_dsp_warn(dsp, "%s.%d: %zu bytes at end of file\n",
+                           file, regions, pos - firmware->size);
+
+       cs_dsp_debugfs_save_wmfwname(dsp, file);
+
+out_fw:
+       regmap_async_complete(regmap);
+       cs_dsp_buf_free(&buf_list);
+       kfree(text);
+
+       return ret;
+}
+
+/**
+ * cs_dsp_get_ctl() - Finds a matching coefficient control
+ * @dsp: pointer to DSP structure
+ * @name: pointer to string to match with a control's subname
+ * @type: the algorithm type to match
+ * @alg: the algorithm id to match
+ *
+ * Find cs_dsp_coeff_ctl with input name as its subname
+ *
+ * Return: pointer to the control on success, NULL if not found
+ */
+struct cs_dsp_coeff_ctl *cs_dsp_get_ctl(struct cs_dsp *dsp, const char *name, int type,
+                                       unsigned int alg)
+{
+       struct cs_dsp_coeff_ctl *pos, *rslt = NULL;
+
+       list_for_each_entry(pos, &dsp->ctl_list, list) {
+               if (!pos->subname)
+                       continue;
+               if (strncmp(pos->subname, name, pos->subname_len) == 0 &&
+                   pos->fw_name == dsp->fw_name &&
+                   pos->alg_region.alg == alg &&
+                   pos->alg_region.type == type) {
+                       rslt = pos;
+                       break;
+               }
+       }
+
+       return rslt;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_get_ctl);
+
+static void cs_dsp_ctl_fixup_base(struct cs_dsp *dsp,
+                                 const struct cs_dsp_alg_region *alg_region)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list) {
+               if (ctl->fw_name == dsp->fw_name &&
+                   alg_region->alg == ctl->alg_region.alg &&
+                   alg_region->type == ctl->alg_region.type) {
+                       ctl->alg_region.base = alg_region->base;
+               }
+       }
+}
+
+static void *cs_dsp_read_algs(struct cs_dsp *dsp, size_t n_algs,
+                             const struct cs_dsp_region *mem,
+                             unsigned int pos, unsigned int len)
+{
+       void *alg;
+       unsigned int reg;
+       int ret;
+       __be32 val;
+
+       if (n_algs == 0) {
+               cs_dsp_err(dsp, "No algorithms\n");
+               return ERR_PTR(-EINVAL);
+       }
+
+       if (n_algs > 1024) {
+               cs_dsp_err(dsp, "Algorithm count %zx excessive\n", n_algs);
+               return ERR_PTR(-EINVAL);
+       }
+
+       /* Read the terminator first to validate the length */
+       reg = dsp->ops->region_to_reg(mem, pos + len);
+
+       ret = regmap_raw_read(dsp->regmap, reg, &val, sizeof(val));
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to read algorithm list end: %d\n",
+                          ret);
+               return ERR_PTR(ret);
+       }
+
+       if (be32_to_cpu(val) != 0xbedead)
+               cs_dsp_warn(dsp, "Algorithm list end %x 0x%x != 0xbedead\n",
+                           reg, be32_to_cpu(val));
+
+       /* Convert length from DSP words to bytes */
+       len *= sizeof(u32);
+
+       alg = kzalloc(len, GFP_KERNEL | GFP_DMA);
+       if (!alg)
+               return ERR_PTR(-ENOMEM);
+
+       reg = dsp->ops->region_to_reg(mem, pos);
+
+       ret = regmap_raw_read(dsp->regmap, reg, alg, len);
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to read algorithm list: %d\n", ret);
+               kfree(alg);
+               return ERR_PTR(ret);
+       }
+
+       return alg;
+}
+
+/**
+ * cs_dsp_find_alg_region() - Finds a matching algorithm region
+ * @dsp: pointer to DSP structure
+ * @type: the algorithm type to match
+ * @id: the algorithm id to match
+ *
+ * Return: Pointer to matching algorithm region, or NULL if not found.
+ */
+struct cs_dsp_alg_region *cs_dsp_find_alg_region(struct cs_dsp *dsp,
+                                                int type, unsigned int id)
+{
+       struct cs_dsp_alg_region *alg_region;
+
+       list_for_each_entry(alg_region, &dsp->alg_regions, list) {
+               if (id == alg_region->alg && type == alg_region->type)
+                       return alg_region;
+       }
+
+       return NULL;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_find_alg_region);
+
+static struct cs_dsp_alg_region *cs_dsp_create_region(struct cs_dsp *dsp,
+                                                     int type, __be32 id,
+                                                     __be32 base)
+{
+       struct cs_dsp_alg_region *alg_region;
+
+       alg_region = kzalloc(sizeof(*alg_region), GFP_KERNEL);
+       if (!alg_region)
+               return ERR_PTR(-ENOMEM);
+
+       alg_region->type = type;
+       alg_region->alg = be32_to_cpu(id);
+       alg_region->base = be32_to_cpu(base);
+
+       list_add_tail(&alg_region->list, &dsp->alg_regions);
+
+       if (dsp->fw_ver > 0)
+               cs_dsp_ctl_fixup_base(dsp, alg_region);
+
+       return alg_region;
+}
+
+static void cs_dsp_free_alg_regions(struct cs_dsp *dsp)
+{
+       struct cs_dsp_alg_region *alg_region;
+
+       while (!list_empty(&dsp->alg_regions)) {
+               alg_region = list_first_entry(&dsp->alg_regions,
+                                             struct cs_dsp_alg_region,
+                                             list);
+               list_del(&alg_region->list);
+               kfree(alg_region);
+       }
+}
+
+static void cs_dsp_parse_wmfw_id_header(struct cs_dsp *dsp,
+                                       struct wmfw_id_hdr *fw, int nalgs)
+{
+       dsp->fw_id = be32_to_cpu(fw->id);
+       dsp->fw_id_version = be32_to_cpu(fw->ver);
+
+       cs_dsp_info(dsp, "Firmware: %x v%d.%d.%d, %d algorithms\n",
+                   dsp->fw_id, (dsp->fw_id_version & 0xff0000) >> 16,
+                   (dsp->fw_id_version & 0xff00) >> 8, dsp->fw_id_version & 0xff,
+                   nalgs);
+}
+
+static void cs_dsp_parse_wmfw_v3_id_header(struct cs_dsp *dsp,
+                                          struct wmfw_v3_id_hdr *fw, int nalgs)
+{
+       dsp->fw_id = be32_to_cpu(fw->id);
+       dsp->fw_id_version = be32_to_cpu(fw->ver);
+       dsp->fw_vendor_id = be32_to_cpu(fw->vendor_id);
+
+       cs_dsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %d algorithms\n",
+                   dsp->fw_id, dsp->fw_vendor_id,
+                   (dsp->fw_id_version & 0xff0000) >> 16,
+                   (dsp->fw_id_version & 0xff00) >> 8, dsp->fw_id_version & 0xff,
+                   nalgs);
+}
+
+static int cs_dsp_create_regions(struct cs_dsp *dsp, __be32 id, int nregions,
+                                const int *type, __be32 *base)
+{
+       struct cs_dsp_alg_region *alg_region;
+       int i;
+
+       for (i = 0; i < nregions; i++) {
+               alg_region = cs_dsp_create_region(dsp, type[i], id, base[i]);
+               if (IS_ERR(alg_region))
+                       return PTR_ERR(alg_region);
+       }
+
+       return 0;
+}
+
+static int cs_dsp_adsp1_setup_algs(struct cs_dsp *dsp)
+{
+       struct wmfw_adsp1_id_hdr adsp1_id;
+       struct wmfw_adsp1_alg_hdr *adsp1_alg;
+       struct cs_dsp_alg_region *alg_region;
+       const struct cs_dsp_region *mem;
+       unsigned int pos, len;
+       size_t n_algs;
+       int i, ret;
+
+       mem = cs_dsp_find_region(dsp, WMFW_ADSP1_DM);
+       if (WARN_ON(!mem))
+               return -EINVAL;
+
+       ret = regmap_raw_read(dsp->regmap, mem->base, &adsp1_id,
+                             sizeof(adsp1_id));
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to read algorithm info: %d\n",
+                          ret);
+               return ret;
+       }
+
+       n_algs = be32_to_cpu(adsp1_id.n_algs);
+
+       cs_dsp_parse_wmfw_id_header(dsp, &adsp1_id.fw, n_algs);
+
+       alg_region = cs_dsp_create_region(dsp, WMFW_ADSP1_ZM,
+                                         adsp1_id.fw.id, adsp1_id.zm);
+       if (IS_ERR(alg_region))
+               return PTR_ERR(alg_region);
+
+       alg_region = cs_dsp_create_region(dsp, WMFW_ADSP1_DM,
+                                         adsp1_id.fw.id, adsp1_id.dm);
+       if (IS_ERR(alg_region))
+               return PTR_ERR(alg_region);
+
+       /* Calculate offset and length in DSP words */
+       pos = sizeof(adsp1_id) / sizeof(u32);
+       len = (sizeof(*adsp1_alg) * n_algs) / sizeof(u32);
+
+       adsp1_alg = cs_dsp_read_algs(dsp, n_algs, mem, pos, len);
+       if (IS_ERR(adsp1_alg))
+               return PTR_ERR(adsp1_alg);
+
+       for (i = 0; i < n_algs; i++) {
+               cs_dsp_info(dsp, "%d: ID %x v%d.%d.%d DM@%x ZM@%x\n",
+                           i, be32_to_cpu(adsp1_alg[i].alg.id),
+                           (be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff0000) >> 16,
+                           (be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff00) >> 8,
+                           be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff,
+                           be32_to_cpu(adsp1_alg[i].dm),
+                           be32_to_cpu(adsp1_alg[i].zm));
+
+               alg_region = cs_dsp_create_region(dsp, WMFW_ADSP1_DM,
+                                                 adsp1_alg[i].alg.id,
+                                                 adsp1_alg[i].dm);
+               if (IS_ERR(alg_region)) {
+                       ret = PTR_ERR(alg_region);
+                       goto out;
+               }
+               if (dsp->fw_ver == 0) {
+                       if (i + 1 < n_algs) {
+                               len = be32_to_cpu(adsp1_alg[i + 1].dm);
+                               len -= be32_to_cpu(adsp1_alg[i].dm);
+                               len *= 4;
+                               cs_dsp_create_control(dsp, alg_region, 0,
+                                                     len, NULL, 0, 0,
+                                                     WMFW_CTL_TYPE_BYTES);
+                       } else {
+                               cs_dsp_warn(dsp, "Missing length info for region DM with ID %x\n",
+                                           be32_to_cpu(adsp1_alg[i].alg.id));
+                       }
+               }
+
+               alg_region = cs_dsp_create_region(dsp, WMFW_ADSP1_ZM,
+                                                 adsp1_alg[i].alg.id,
+                                                 adsp1_alg[i].zm);
+               if (IS_ERR(alg_region)) {
+                       ret = PTR_ERR(alg_region);
+                       goto out;
+               }
+               if (dsp->fw_ver == 0) {
+                       if (i + 1 < n_algs) {
+                               len = be32_to_cpu(adsp1_alg[i + 1].zm);
+                               len -= be32_to_cpu(adsp1_alg[i].zm);
+                               len *= 4;
+                               cs_dsp_create_control(dsp, alg_region, 0,
+                                                     len, NULL, 0, 0,
+                                                     WMFW_CTL_TYPE_BYTES);
+                       } else {
+                               cs_dsp_warn(dsp, "Missing length info for region ZM with ID %x\n",
+                                           be32_to_cpu(adsp1_alg[i].alg.id));
+                       }
+               }
+       }
+
+out:
+       kfree(adsp1_alg);
+       return ret;
+}
+
+static int cs_dsp_adsp2_setup_algs(struct cs_dsp *dsp)
+{
+       struct wmfw_adsp2_id_hdr adsp2_id;
+       struct wmfw_adsp2_alg_hdr *adsp2_alg;
+       struct cs_dsp_alg_region *alg_region;
+       const struct cs_dsp_region *mem;
+       unsigned int pos, len;
+       size_t n_algs;
+       int i, ret;
+
+       mem = cs_dsp_find_region(dsp, WMFW_ADSP2_XM);
+       if (WARN_ON(!mem))
+               return -EINVAL;
+
+       ret = regmap_raw_read(dsp->regmap, mem->base, &adsp2_id,
+                             sizeof(adsp2_id));
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to read algorithm info: %d\n",
+                          ret);
+               return ret;
+       }
+
+       n_algs = be32_to_cpu(adsp2_id.n_algs);
+
+       cs_dsp_parse_wmfw_id_header(dsp, &adsp2_id.fw, n_algs);
+
+       alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_XM,
+                                         adsp2_id.fw.id, adsp2_id.xm);
+       if (IS_ERR(alg_region))
+               return PTR_ERR(alg_region);
+
+       alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_YM,
+                                         adsp2_id.fw.id, adsp2_id.ym);
+       if (IS_ERR(alg_region))
+               return PTR_ERR(alg_region);
+
+       alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_ZM,
+                                         adsp2_id.fw.id, adsp2_id.zm);
+       if (IS_ERR(alg_region))
+               return PTR_ERR(alg_region);
+
+       /* Calculate offset and length in DSP words */
+       pos = sizeof(adsp2_id) / sizeof(u32);
+       len = (sizeof(*adsp2_alg) * n_algs) / sizeof(u32);
+
+       adsp2_alg = cs_dsp_read_algs(dsp, n_algs, mem, pos, len);
+       if (IS_ERR(adsp2_alg))
+               return PTR_ERR(adsp2_alg);
+
+       for (i = 0; i < n_algs; i++) {
+               cs_dsp_info(dsp,
+                           "%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n",
+                           i, be32_to_cpu(adsp2_alg[i].alg.id),
+                           (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16,
+                           (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8,
+                           be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff,
+                           be32_to_cpu(adsp2_alg[i].xm),
+                           be32_to_cpu(adsp2_alg[i].ym),
+                           be32_to_cpu(adsp2_alg[i].zm));
+
+               alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_XM,
+                                                 adsp2_alg[i].alg.id,
+                                                 adsp2_alg[i].xm);
+               if (IS_ERR(alg_region)) {
+                       ret = PTR_ERR(alg_region);
+                       goto out;
+               }
+               if (dsp->fw_ver == 0) {
+                       if (i + 1 < n_algs) {
+                               len = be32_to_cpu(adsp2_alg[i + 1].xm);
+                               len -= be32_to_cpu(adsp2_alg[i].xm);
+                               len *= 4;
+                               cs_dsp_create_control(dsp, alg_region, 0,
+                                                     len, NULL, 0, 0,
+                                                     WMFW_CTL_TYPE_BYTES);
+                       } else {
+                               cs_dsp_warn(dsp, "Missing length info for region XM with ID %x\n",
+                                           be32_to_cpu(adsp2_alg[i].alg.id));
+                       }
+               }
+
+               alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_YM,
+                                                 adsp2_alg[i].alg.id,
+                                                 adsp2_alg[i].ym);
+               if (IS_ERR(alg_region)) {
+                       ret = PTR_ERR(alg_region);
+                       goto out;
+               }
+               if (dsp->fw_ver == 0) {
+                       if (i + 1 < n_algs) {
+                               len = be32_to_cpu(adsp2_alg[i + 1].ym);
+                               len -= be32_to_cpu(adsp2_alg[i].ym);
+                               len *= 4;
+                               cs_dsp_create_control(dsp, alg_region, 0,
+                                                     len, NULL, 0, 0,
+                                                     WMFW_CTL_TYPE_BYTES);
+                       } else {
+                               cs_dsp_warn(dsp, "Missing length info for region YM with ID %x\n",
+                                           be32_to_cpu(adsp2_alg[i].alg.id));
+                       }
+               }
+
+               alg_region = cs_dsp_create_region(dsp, WMFW_ADSP2_ZM,
+                                                 adsp2_alg[i].alg.id,
+                                                 adsp2_alg[i].zm);
+               if (IS_ERR(alg_region)) {
+                       ret = PTR_ERR(alg_region);
+                       goto out;
+               }
+               if (dsp->fw_ver == 0) {
+                       if (i + 1 < n_algs) {
+                               len = be32_to_cpu(adsp2_alg[i + 1].zm);
+                               len -= be32_to_cpu(adsp2_alg[i].zm);
+                               len *= 4;
+                               cs_dsp_create_control(dsp, alg_region, 0,
+                                                     len, NULL, 0, 0,
+                                                     WMFW_CTL_TYPE_BYTES);
+                       } else {
+                               cs_dsp_warn(dsp, "Missing length info for region ZM with ID %x\n",
+                                           be32_to_cpu(adsp2_alg[i].alg.id));
+                       }
+               }
+       }
+
+out:
+       kfree(adsp2_alg);
+       return ret;
+}
+
+static int cs_dsp_halo_create_regions(struct cs_dsp *dsp, __be32 id,
+                                     __be32 xm_base, __be32 ym_base)
+{
+       static const int types[] = {
+               WMFW_ADSP2_XM, WMFW_HALO_XM_PACKED,
+               WMFW_ADSP2_YM, WMFW_HALO_YM_PACKED
+       };
+       __be32 bases[] = { xm_base, xm_base, ym_base, ym_base };
+
+       return cs_dsp_create_regions(dsp, id, ARRAY_SIZE(types), types, bases);
+}
+
+static int cs_dsp_halo_setup_algs(struct cs_dsp *dsp)
+{
+       struct wmfw_halo_id_hdr halo_id;
+       struct wmfw_halo_alg_hdr *halo_alg;
+       const struct cs_dsp_region *mem;
+       unsigned int pos, len;
+       size_t n_algs;
+       int i, ret;
+
+       mem = cs_dsp_find_region(dsp, WMFW_ADSP2_XM);
+       if (WARN_ON(!mem))
+               return -EINVAL;
+
+       ret = regmap_raw_read(dsp->regmap, mem->base, &halo_id,
+                             sizeof(halo_id));
+       if (ret != 0) {
+               cs_dsp_err(dsp, "Failed to read algorithm info: %d\n",
+                          ret);
+               return ret;
+       }
+
+       n_algs = be32_to_cpu(halo_id.n_algs);
+
+       cs_dsp_parse_wmfw_v3_id_header(dsp, &halo_id.fw, n_algs);
+
+       ret = cs_dsp_halo_create_regions(dsp, halo_id.fw.id,
+                                        halo_id.xm_base, halo_id.ym_base);
+       if (ret)
+               return ret;
+
+       /* Calculate offset and length in DSP words */
+       pos = sizeof(halo_id) / sizeof(u32);
+       len = (sizeof(*halo_alg) * n_algs) / sizeof(u32);
+
+       halo_alg = cs_dsp_read_algs(dsp, n_algs, mem, pos, len);
+       if (IS_ERR(halo_alg))
+               return PTR_ERR(halo_alg);
+
+       for (i = 0; i < n_algs; i++) {
+               cs_dsp_info(dsp,
+                           "%d: ID %x v%d.%d.%d XM@%x YM@%x\n",
+                           i, be32_to_cpu(halo_alg[i].alg.id),
+                           (be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16,
+                           (be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8,
+                           be32_to_cpu(halo_alg[i].alg.ver) & 0xff,
+                           be32_to_cpu(halo_alg[i].xm_base),
+                           be32_to_cpu(halo_alg[i].ym_base));
+
+               ret = cs_dsp_halo_create_regions(dsp, halo_alg[i].alg.id,
+                                                halo_alg[i].xm_base,
+                                                halo_alg[i].ym_base);
+               if (ret)
+                       goto out;
+       }
+
+out:
+       kfree(halo_alg);
+       return ret;
+}
+
+static int cs_dsp_load_coeff(struct cs_dsp *dsp, const struct firmware *firmware,
+                            const char *file)
+{
+       LIST_HEAD(buf_list);
+       struct regmap *regmap = dsp->regmap;
+       struct wmfw_coeff_hdr *hdr;
+       struct wmfw_coeff_item *blk;
+       const struct cs_dsp_region *mem;
+       struct cs_dsp_alg_region *alg_region;
+       const char *region_name;
+       int ret, pos, blocks, type, offset, reg;
+       struct cs_dsp_buf *buf;
+
+       if (!firmware)
+               return 0;
+
+       ret = -EINVAL;
+
+       if (sizeof(*hdr) >= firmware->size) {
+               cs_dsp_err(dsp, "%s: coefficient file too short, %zu bytes\n",
+                          file, firmware->size);
+               goto out_fw;
+       }
+
+       hdr = (void *)&firmware->data[0];
+       if (memcmp(hdr->magic, "WMDR", 4) != 0) {
+               cs_dsp_err(dsp, "%s: invalid coefficient magic\n", file);
+               goto out_fw;
+       }
+
+       switch (be32_to_cpu(hdr->rev) & 0xff) {
+       case 1:
+               break;
+       default:
+               cs_dsp_err(dsp, "%s: Unsupported coefficient file format %d\n",
+                          file, be32_to_cpu(hdr->rev) & 0xff);
+               ret = -EINVAL;
+               goto out_fw;
+       }
+
+       cs_dsp_dbg(dsp, "%s: v%d.%d.%d\n", file,
+                  (le32_to_cpu(hdr->ver) >> 16) & 0xff,
+                  (le32_to_cpu(hdr->ver) >>  8) & 0xff,
+                  le32_to_cpu(hdr->ver) & 0xff);
+
+       pos = le32_to_cpu(hdr->len);
+
+       blocks = 0;
+       while (pos < firmware->size &&
+              sizeof(*blk) < firmware->size - pos) {
+               blk = (void *)(&firmware->data[pos]);
+
+               type = le16_to_cpu(blk->type);
+               offset = le16_to_cpu(blk->offset);
+
+               cs_dsp_dbg(dsp, "%s.%d: %x v%d.%d.%d\n",
+                          file, blocks, le32_to_cpu(blk->id),
+                          (le32_to_cpu(blk->ver) >> 16) & 0xff,
+                          (le32_to_cpu(blk->ver) >>  8) & 0xff,
+                          le32_to_cpu(blk->ver) & 0xff);
+               cs_dsp_dbg(dsp, "%s.%d: %d bytes at 0x%x in %x\n",
+                          file, blocks, le32_to_cpu(blk->len), offset, type);
+
+               reg = 0;
+               region_name = "Unknown";
+               switch (type) {
+               case (WMFW_NAME_TEXT << 8):
+               case (WMFW_INFO_TEXT << 8):
+               case (WMFW_METADATA << 8):
+                       break;
+               case (WMFW_ABSOLUTE << 8):
+                       /*
+                        * Old files may use this for global
+                        * coefficients.
+                        */
+                       if (le32_to_cpu(blk->id) == dsp->fw_id &&
+                           offset == 0) {
+                               region_name = "global coefficients";
+                               mem = cs_dsp_find_region(dsp, type);
+                               if (!mem) {
+                                       cs_dsp_err(dsp, "No ZM\n");
+                                       break;
+                               }
+                               reg = dsp->ops->region_to_reg(mem, 0);
+
+                       } else {
+                               region_name = "register";
+                               reg = offset;
+                       }
+                       break;
+
+               case WMFW_ADSP1_DM:
+               case WMFW_ADSP1_ZM:
+               case WMFW_ADSP2_XM:
+               case WMFW_ADSP2_YM:
+               case WMFW_HALO_XM_PACKED:
+               case WMFW_HALO_YM_PACKED:
+               case WMFW_HALO_PM_PACKED:
+                       cs_dsp_dbg(dsp, "%s.%d: %d bytes in %x for %x\n",
+                                  file, blocks, le32_to_cpu(blk->len),
+                                  type, le32_to_cpu(blk->id));
+
+                       mem = cs_dsp_find_region(dsp, type);
+                       if (!mem) {
+                               cs_dsp_err(dsp, "No base for region %x\n", type);
+                               break;
+                       }
+
+                       alg_region = cs_dsp_find_alg_region(dsp, type,
+                                                           le32_to_cpu(blk->id));
+                       if (alg_region) {
+                               reg = alg_region->base;
+                               reg = dsp->ops->region_to_reg(mem, reg);
+                               reg += offset;
+                       } else {
+                               cs_dsp_err(dsp, "No %x for algorithm %x\n",
+                                          type, le32_to_cpu(blk->id));
+                       }
+                       break;
+
+               default:
+                       cs_dsp_err(dsp, "%s.%d: Unknown region type %x at %d\n",
+                                  file, blocks, type, pos);
+                       break;
+               }
+
+               if (reg) {
+                       if (le32_to_cpu(blk->len) >
+                           firmware->size - pos - sizeof(*blk)) {
+                               cs_dsp_err(dsp,
+                                          "%s.%d: %s region len %d bytes exceeds file length %zu\n",
+                                          file, blocks, region_name,
+                                          le32_to_cpu(blk->len),
+                                          firmware->size);
+                               ret = -EINVAL;
+                               goto out_fw;
+                       }
+
+                       buf = cs_dsp_buf_alloc(blk->data,
+                                              le32_to_cpu(blk->len),
+                                              &buf_list);
+                       if (!buf) {
+                               cs_dsp_err(dsp, "Out of memory\n");
+                               ret = -ENOMEM;
+                               goto out_fw;
+                       }
+
+                       cs_dsp_dbg(dsp, "%s.%d: Writing %d bytes at %x\n",
+                                  file, blocks, le32_to_cpu(blk->len),
+                                  reg);
+                       ret = regmap_raw_write_async(regmap, reg, buf->buf,
+                                                    le32_to_cpu(blk->len));
+                       if (ret != 0) {
+                               cs_dsp_err(dsp,
+                                          "%s.%d: Failed to write to %x in %s: %d\n",
+                                          file, blocks, reg, region_name, ret);
+                       }
+               }
+
+               pos += (le32_to_cpu(blk->len) + sizeof(*blk) + 3) & ~0x03;
+               blocks++;
+       }
+
+       ret = regmap_async_complete(regmap);
+       if (ret != 0)
+               cs_dsp_err(dsp, "Failed to complete async write: %d\n", ret);
+
+       if (pos > firmware->size)
+               cs_dsp_warn(dsp, "%s.%d: %zu bytes at end of file\n",
+                           file, blocks, pos - firmware->size);
+
+       cs_dsp_debugfs_save_binname(dsp, file);
+
+out_fw:
+       regmap_async_complete(regmap);
+       cs_dsp_buf_free(&buf_list);
+       return ret;
+}
+
+static int cs_dsp_create_name(struct cs_dsp *dsp)
+{
+       if (!dsp->name) {
+               dsp->name = devm_kasprintf(dsp->dev, GFP_KERNEL, "DSP%d",
+                                          dsp->num);
+               if (!dsp->name)
+                       return -ENOMEM;
+       }
+
+       return 0;
+}
+
+static int cs_dsp_common_init(struct cs_dsp *dsp)
+{
+       int ret;
+
+       ret = cs_dsp_create_name(dsp);
+       if (ret)
+               return ret;
+
+       INIT_LIST_HEAD(&dsp->alg_regions);
+       INIT_LIST_HEAD(&dsp->ctl_list);
+
+       mutex_init(&dsp->pwr_lock);
+
+       return 0;
+}
+
+/**
+ * cs_dsp_adsp1_init() - Initialise a cs_dsp structure representing a ADSP1 device
+ * @dsp: pointer to DSP structure
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_adsp1_init(struct cs_dsp *dsp)
+{
+       dsp->ops = &cs_dsp_adsp1_ops;
+
+       return cs_dsp_common_init(dsp);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_adsp1_init);
+
+/**
+ * cs_dsp_adsp1_power_up() - Load and start the named firmware
+ * @dsp: pointer to DSP structure
+ * @wmfw_firmware: the firmware to be sent
+ * @wmfw_filename: file name of firmware to be sent
+ * @coeff_firmware: the coefficient data to be sent
+ * @coeff_filename: file name of coefficient to data be sent
+ * @fw_name: the user-friendly firmware name
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_adsp1_power_up(struct cs_dsp *dsp,
+                         const struct firmware *wmfw_firmware, char *wmfw_filename,
+                         const struct firmware *coeff_firmware, char *coeff_filename,
+                         const char *fw_name)
+{
+       unsigned int val;
+       int ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       dsp->fw_name = fw_name;
+
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
+                          ADSP1_SYS_ENA, ADSP1_SYS_ENA);
+
+       /*
+        * For simplicity set the DSP clock rate to be the
+        * SYSCLK rate rather than making it configurable.
+        */
+       if (dsp->sysclk_reg) {
+               ret = regmap_read(dsp->regmap, dsp->sysclk_reg, &val);
+               if (ret != 0) {
+                       cs_dsp_err(dsp, "Failed to read SYSCLK state: %d\n", ret);
+                       goto err_mutex;
+               }
+
+               val = (val & dsp->sysclk_mask) >> dsp->sysclk_shift;
+
+               ret = regmap_update_bits(dsp->regmap,
+                                        dsp->base + ADSP1_CONTROL_31,
+                                        ADSP1_CLK_SEL_MASK, val);
+               if (ret != 0) {
+                       cs_dsp_err(dsp, "Failed to set clock rate: %d\n", ret);
+                       goto err_mutex;
+               }
+       }
+
+       ret = cs_dsp_load(dsp, wmfw_firmware, wmfw_filename);
+       if (ret != 0)
+               goto err_ena;
+
+       ret = cs_dsp_adsp1_setup_algs(dsp);
+       if (ret != 0)
+               goto err_ena;
+
+       ret = cs_dsp_load_coeff(dsp, coeff_firmware, coeff_filename);
+       if (ret != 0)
+               goto err_ena;
+
+       /* Initialize caches for enabled and unset controls */
+       ret = cs_dsp_coeff_init_control_caches(dsp);
+       if (ret != 0)
+               goto err_ena;
+
+       /* Sync set controls */
+       ret = cs_dsp_coeff_sync_controls(dsp);
+       if (ret != 0)
+               goto err_ena;
+
+       dsp->booted = true;
+
+       /* Start the core running */
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
+                          ADSP1_CORE_ENA | ADSP1_START,
+                          ADSP1_CORE_ENA | ADSP1_START);
+
+       dsp->running = true;
+
+       mutex_unlock(&dsp->pwr_lock);
+
+       return 0;
+
+err_ena:
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
+                          ADSP1_SYS_ENA, 0);
+err_mutex:
+       mutex_unlock(&dsp->pwr_lock);
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_adsp1_power_up);
+
+/**
+ * cs_dsp_adsp1_power_down() - Halts the DSP
+ * @dsp: pointer to DSP structure
+ */
+void cs_dsp_adsp1_power_down(struct cs_dsp *dsp)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       dsp->running = false;
+       dsp->booted = false;
+
+       /* Halt the core */
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
+                          ADSP1_CORE_ENA | ADSP1_START, 0);
+
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_19,
+                          ADSP1_WDMA_BUFFER_LENGTH_MASK, 0);
+
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
+                          ADSP1_SYS_ENA, 0);
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list)
+               ctl->enabled = 0;
+
+       cs_dsp_free_alg_regions(dsp);
+
+       mutex_unlock(&dsp->pwr_lock);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_adsp1_power_down);
+
+static int cs_dsp_adsp2v2_enable_core(struct cs_dsp *dsp)
+{
+       unsigned int val;
+       int ret, count;
+
+       /* Wait for the RAM to start, should be near instantaneous */
+       for (count = 0; count < 10; ++count) {
+               ret = regmap_read(dsp->regmap, dsp->base + ADSP2_STATUS1, &val);
+               if (ret != 0)
+                       return ret;
+
+               if (val & ADSP2_RAM_RDY)
+                       break;
+
+               usleep_range(250, 500);
+       }
+
+       if (!(val & ADSP2_RAM_RDY)) {
+               cs_dsp_err(dsp, "Failed to start DSP RAM\n");
+               return -EBUSY;
+       }
+
+       cs_dsp_dbg(dsp, "RAM ready after %d polls\n", count);
+
+       return 0;
+}
+
+static int cs_dsp_adsp2_enable_core(struct cs_dsp *dsp)
+{
+       int ret;
+
+       ret = regmap_update_bits_async(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                                      ADSP2_SYS_ENA, ADSP2_SYS_ENA);
+       if (ret != 0)
+               return ret;
+
+       return cs_dsp_adsp2v2_enable_core(dsp);
+}
+
+static int cs_dsp_adsp2_lock(struct cs_dsp *dsp, unsigned int lock_regions)
+{
+       struct regmap *regmap = dsp->regmap;
+       unsigned int code0, code1, lock_reg;
+
+       if (!(lock_regions & CS_ADSP2_REGION_ALL))
+               return 0;
+
+       lock_regions &= CS_ADSP2_REGION_ALL;
+       lock_reg = dsp->base + ADSP2_LOCK_REGION_1_LOCK_REGION_0;
+
+       while (lock_regions) {
+               code0 = code1 = 0;
+               if (lock_regions & BIT(0)) {
+                       code0 = ADSP2_LOCK_CODE_0;
+                       code1 = ADSP2_LOCK_CODE_1;
+               }
+               if (lock_regions & BIT(1)) {
+                       code0 |= ADSP2_LOCK_CODE_0 << ADSP2_LOCK_REGION_SHIFT;
+                       code1 |= ADSP2_LOCK_CODE_1 << ADSP2_LOCK_REGION_SHIFT;
+               }
+               regmap_write(regmap, lock_reg, code0);
+               regmap_write(regmap, lock_reg, code1);
+               lock_regions >>= 2;
+               lock_reg += 2;
+       }
+
+       return 0;
+}
+
+static int cs_dsp_adsp2_enable_memory(struct cs_dsp *dsp)
+{
+       return regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                                 ADSP2_MEM_ENA, ADSP2_MEM_ENA);
+}
+
+static void cs_dsp_adsp2_disable_memory(struct cs_dsp *dsp)
+{
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                          ADSP2_MEM_ENA, 0);
+}
+
+static void cs_dsp_adsp2_disable_core(struct cs_dsp *dsp)
+{
+       regmap_write(dsp->regmap, dsp->base + ADSP2_RDMA_CONFIG_1, 0);
+       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_1, 0);
+       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_2, 0);
+
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                          ADSP2_SYS_ENA, 0);
+}
+
+static void cs_dsp_adsp2v2_disable_core(struct cs_dsp *dsp)
+{
+       regmap_write(dsp->regmap, dsp->base + ADSP2_RDMA_CONFIG_1, 0);
+       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_1, 0);
+       regmap_write(dsp->regmap, dsp->base + ADSP2V2_WDMA_CONFIG_2, 0);
+}
+
+static int cs_dsp_halo_configure_mpu(struct cs_dsp *dsp, unsigned int lock_regions)
+{
+       struct reg_sequence config[] = {
+               { dsp->base + HALO_MPU_LOCK_CONFIG,     0x5555 },
+               { dsp->base + HALO_MPU_LOCK_CONFIG,     0xAAAA },
+               { dsp->base + HALO_MPU_XMEM_ACCESS_0,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_YMEM_ACCESS_0,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_WINDOW_ACCESS_0, lock_regions },
+               { dsp->base + HALO_MPU_XREG_ACCESS_0,   lock_regions },
+               { dsp->base + HALO_MPU_YREG_ACCESS_0,   lock_regions },
+               { dsp->base + HALO_MPU_XMEM_ACCESS_1,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_YMEM_ACCESS_1,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_WINDOW_ACCESS_1, lock_regions },
+               { dsp->base + HALO_MPU_XREG_ACCESS_1,   lock_regions },
+               { dsp->base + HALO_MPU_YREG_ACCESS_1,   lock_regions },
+               { dsp->base + HALO_MPU_XMEM_ACCESS_2,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_YMEM_ACCESS_2,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_WINDOW_ACCESS_2, lock_regions },
+               { dsp->base + HALO_MPU_XREG_ACCESS_2,   lock_regions },
+               { dsp->base + HALO_MPU_YREG_ACCESS_2,   lock_regions },
+               { dsp->base + HALO_MPU_XMEM_ACCESS_3,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_YMEM_ACCESS_3,   0xFFFFFFFF },
+               { dsp->base + HALO_MPU_WINDOW_ACCESS_3, lock_regions },
+               { dsp->base + HALO_MPU_XREG_ACCESS_3,   lock_regions },
+               { dsp->base + HALO_MPU_YREG_ACCESS_3,   lock_regions },
+               { dsp->base + HALO_MPU_LOCK_CONFIG,     0 },
+       };
+
+       return regmap_multi_reg_write(dsp->regmap, config, ARRAY_SIZE(config));
+}
+
+/**
+ * cs_dsp_set_dspclk() - Applies the given frequency to the given cs_dsp
+ * @dsp: pointer to DSP structure
+ * @freq: clock rate to set
+ *
+ * This is only for use on ADSP2 cores.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_set_dspclk(struct cs_dsp *dsp, unsigned int freq)
+{
+       int ret;
+
+       ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CLOCKING,
+                                ADSP2_CLK_SEL_MASK,
+                                freq << ADSP2_CLK_SEL_SHIFT);
+       if (ret)
+               cs_dsp_err(dsp, "Failed to set clock rate: %d\n", ret);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_set_dspclk);
+
+static void cs_dsp_stop_watchdog(struct cs_dsp *dsp)
+{
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_WATCHDOG,
+                          ADSP2_WDT_ENA_MASK, 0);
+}
+
+static void cs_dsp_halo_stop_watchdog(struct cs_dsp *dsp)
+{
+       regmap_update_bits(dsp->regmap, dsp->base + HALO_WDT_CONTROL,
+                          HALO_WDT_EN_MASK, 0);
+}
+
+/**
+ * cs_dsp_power_up() - Downloads firmware to the DSP
+ * @dsp: pointer to DSP structure
+ * @wmfw_firmware: the firmware to be sent
+ * @wmfw_filename: file name of firmware to be sent
+ * @coeff_firmware: the coefficient data to be sent
+ * @coeff_filename: file name of coefficient to data be sent
+ * @fw_name: the user-friendly firmware name
+ *
+ * This function is used on ADSP2 and Halo DSP cores, it powers-up the DSP core
+ * and downloads the firmware but does not start the firmware running. The
+ * cs_dsp booted flag will be set once completed and if the core has a low-power
+ * memory retention mode it will be put into this state after the firmware is
+ * downloaded.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_power_up(struct cs_dsp *dsp,
+                   const struct firmware *wmfw_firmware, char *wmfw_filename,
+                   const struct firmware *coeff_firmware, char *coeff_filename,
+                   const char *fw_name)
+{
+       int ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       dsp->fw_name = fw_name;
+
+       if (dsp->ops->enable_memory) {
+               ret = dsp->ops->enable_memory(dsp);
+               if (ret != 0)
+                       goto err_mutex;
+       }
+
+       if (dsp->ops->enable_core) {
+               ret = dsp->ops->enable_core(dsp);
+               if (ret != 0)
+                       goto err_mem;
+       }
+
+       ret = cs_dsp_load(dsp, wmfw_firmware, wmfw_filename);
+       if (ret != 0)
+               goto err_ena;
+
+       ret = dsp->ops->setup_algs(dsp);
+       if (ret != 0)
+               goto err_ena;
+
+       ret = cs_dsp_load_coeff(dsp, coeff_firmware, coeff_filename);
+       if (ret != 0)
+               goto err_ena;
+
+       /* Initialize caches for enabled and unset controls */
+       ret = cs_dsp_coeff_init_control_caches(dsp);
+       if (ret != 0)
+               goto err_ena;
+
+       if (dsp->ops->disable_core)
+               dsp->ops->disable_core(dsp);
+
+       dsp->booted = true;
+
+       mutex_unlock(&dsp->pwr_lock);
+
+       return 0;
+err_ena:
+       if (dsp->ops->disable_core)
+               dsp->ops->disable_core(dsp);
+err_mem:
+       if (dsp->ops->disable_memory)
+               dsp->ops->disable_memory(dsp);
+err_mutex:
+       mutex_unlock(&dsp->pwr_lock);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_power_up);
+
+/**
+ * cs_dsp_power_down() - Powers-down the DSP
+ * @dsp: pointer to DSP structure
+ *
+ * cs_dsp_stop() must have been called before this function. The core will be
+ * fully powered down and so the memory will not be retained.
+ */
+void cs_dsp_power_down(struct cs_dsp *dsp)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       cs_dsp_debugfs_clear(dsp);
+
+       dsp->fw_id = 0;
+       dsp->fw_id_version = 0;
+
+       dsp->booted = false;
+
+       if (dsp->ops->disable_memory)
+               dsp->ops->disable_memory(dsp);
+
+       list_for_each_entry(ctl, &dsp->ctl_list, list)
+               ctl->enabled = 0;
+
+       cs_dsp_free_alg_regions(dsp);
+
+       mutex_unlock(&dsp->pwr_lock);
+
+       cs_dsp_dbg(dsp, "Shutdown complete\n");
+}
+EXPORT_SYMBOL_GPL(cs_dsp_power_down);
+
+static int cs_dsp_adsp2_start_core(struct cs_dsp *dsp)
+{
+       return regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                                 ADSP2_CORE_ENA | ADSP2_START,
+                                 ADSP2_CORE_ENA | ADSP2_START);
+}
+
+static void cs_dsp_adsp2_stop_core(struct cs_dsp *dsp)
+{
+       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                          ADSP2_CORE_ENA | ADSP2_START, 0);
+}
+
+/**
+ * cs_dsp_run() - Starts the firmware running
+ * @dsp: pointer to DSP structure
+ *
+ * cs_dsp_power_up() must have previously been called successfully.
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_run(struct cs_dsp *dsp)
+{
+       int ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       if (!dsp->booted) {
+               ret = -EIO;
+               goto err;
+       }
+
+       if (dsp->ops->enable_core) {
+               ret = dsp->ops->enable_core(dsp);
+               if (ret != 0)
+                       goto err;
+       }
+
+       /* Sync set controls */
+       ret = cs_dsp_coeff_sync_controls(dsp);
+       if (ret != 0)
+               goto err;
+
+       if (dsp->ops->lock_memory) {
+               ret = dsp->ops->lock_memory(dsp, dsp->lock_regions);
+               if (ret != 0) {
+                       cs_dsp_err(dsp, "Error configuring MPU: %d\n", ret);
+                       goto err;
+               }
+       }
+
+       if (dsp->ops->start_core) {
+               ret = dsp->ops->start_core(dsp);
+               if (ret != 0)
+                       goto err;
+       }
+
+       dsp->running = true;
+
+       if (dsp->client_ops->post_run) {
+               ret = dsp->client_ops->post_run(dsp);
+               if (ret)
+                       goto err;
+       }
+
+       mutex_unlock(&dsp->pwr_lock);
+
+       return 0;
+
+err:
+       if (dsp->ops->stop_core)
+               dsp->ops->stop_core(dsp);
+       if (dsp->ops->disable_core)
+               dsp->ops->disable_core(dsp);
+       mutex_unlock(&dsp->pwr_lock);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_run);
+
+/**
+ * cs_dsp_stop() - Stops the firmware
+ * @dsp: pointer to DSP structure
+ *
+ * Memory will not be disabled so firmware will remain loaded.
+ */
+void cs_dsp_stop(struct cs_dsp *dsp)
+{
+       /* Tell the firmware to cleanup */
+       cs_dsp_signal_event_controls(dsp, CS_DSP_FW_EVENT_SHUTDOWN);
+
+       if (dsp->ops->stop_watchdog)
+               dsp->ops->stop_watchdog(dsp);
+
+       /* Log firmware state, it can be useful for analysis */
+       if (dsp->ops->show_fw_status)
+               dsp->ops->show_fw_status(dsp);
+
+       mutex_lock(&dsp->pwr_lock);
+
+       dsp->running = false;
+
+       if (dsp->ops->stop_core)
+               dsp->ops->stop_core(dsp);
+       if (dsp->ops->disable_core)
+               dsp->ops->disable_core(dsp);
+
+       if (dsp->client_ops->post_stop)
+               dsp->client_ops->post_stop(dsp);
+
+       mutex_unlock(&dsp->pwr_lock);
+
+       cs_dsp_dbg(dsp, "Execution stopped\n");
+}
+EXPORT_SYMBOL_GPL(cs_dsp_stop);
+
+static int cs_dsp_halo_start_core(struct cs_dsp *dsp)
+{
+       return regmap_update_bits(dsp->regmap,
+                                 dsp->base + HALO_CCM_CORE_CONTROL,
+                                 HALO_CORE_RESET | HALO_CORE_EN,
+                                 HALO_CORE_RESET | HALO_CORE_EN);
+}
+
+static void cs_dsp_halo_stop_core(struct cs_dsp *dsp)
+{
+       regmap_update_bits(dsp->regmap, dsp->base + HALO_CCM_CORE_CONTROL,
+                          HALO_CORE_EN, 0);
+
+       /* reset halo core with CORE_SOFT_RESET */
+       regmap_update_bits(dsp->regmap, dsp->base + HALO_CORE_SOFT_RESET,
+                          HALO_CORE_SOFT_RESET_MASK, 1);
+}
+
+/**
+ * cs_dsp_adsp2_init() - Initialise a cs_dsp structure representing a ADSP2 core
+ * @dsp: pointer to DSP structure
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_adsp2_init(struct cs_dsp *dsp)
+{
+       int ret;
+
+       switch (dsp->rev) {
+       case 0:
+               /*
+                * Disable the DSP memory by default when in reset for a small
+                * power saving.
+                */
+               ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
+                                        ADSP2_MEM_ENA, 0);
+               if (ret) {
+                       cs_dsp_err(dsp,
+                                  "Failed to clear memory retention: %d\n", ret);
+                       return ret;
+               }
+
+               dsp->ops = &cs_dsp_adsp2_ops[0];
+               break;
+       case 1:
+               dsp->ops = &cs_dsp_adsp2_ops[1];
+               break;
+       default:
+               dsp->ops = &cs_dsp_adsp2_ops[2];
+               break;
+       }
+
+       return cs_dsp_common_init(dsp);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_adsp2_init);
+
+/**
+ * cs_dsp_halo_init() - Initialise a cs_dsp structure representing a HALO Core DSP
+ * @dsp: pointer to DSP structure
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_halo_init(struct cs_dsp *dsp)
+{
+       dsp->ops = &cs_dsp_halo_ops;
+
+       return cs_dsp_common_init(dsp);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_halo_init);
+
+/**
+ * cs_dsp_remove() - Clean a cs_dsp before deletion
+ * @dsp: pointer to DSP structure
+ */
+void cs_dsp_remove(struct cs_dsp *dsp)
+{
+       struct cs_dsp_coeff_ctl *ctl;
+
+       while (!list_empty(&dsp->ctl_list)) {
+               ctl = list_first_entry(&dsp->ctl_list, struct cs_dsp_coeff_ctl, list);
+
+               if (dsp->client_ops->control_remove)
+                       dsp->client_ops->control_remove(ctl);
+
+               list_del(&ctl->list);
+               cs_dsp_free_ctl_blk(ctl);
+       }
+}
+EXPORT_SYMBOL_GPL(cs_dsp_remove);
+
+/**
+ * cs_dsp_read_raw_data_block() - Reads a block of data from DSP memory
+ * @dsp: pointer to DSP structure
+ * @mem_type: the type of DSP memory containing the data to be read
+ * @mem_addr: the address of the data within the memory region
+ * @num_words: the length of the data to read
+ * @data: a buffer to store the fetched data
+ *
+ * If this is used to read unpacked 24-bit memory, each 24-bit DSP word will
+ * occupy 32-bits in data (MSbyte will be 0). This padding can be removed using
+ * cs_dsp_remove_padding()
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_read_raw_data_block(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr,
+                              unsigned int num_words, __be32 *data)
+{
+       struct cs_dsp_region const *mem = cs_dsp_find_region(dsp, mem_type);
+       unsigned int reg;
+       int ret;
+
+       if (!mem)
+               return -EINVAL;
+
+       reg = dsp->ops->region_to_reg(mem, mem_addr);
+
+       ret = regmap_raw_read(dsp->regmap, reg, data,
+                             sizeof(*data) * num_words);
+       if (ret < 0)
+               return ret;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_read_raw_data_block);
+
+/**
+ * cs_dsp_read_data_word() - Reads a word from DSP memory
+ * @dsp: pointer to DSP structure
+ * @mem_type: the type of DSP memory containing the data to be read
+ * @mem_addr: the address of the data within the memory region
+ * @data: a buffer to store the fetched data
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_read_data_word(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr, u32 *data)
+{
+       __be32 raw;
+       int ret;
+
+       ret = cs_dsp_read_raw_data_block(dsp, mem_type, mem_addr, 1, &raw);
+       if (ret < 0)
+               return ret;
+
+       *data = be32_to_cpu(raw) & 0x00ffffffu;
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(cs_dsp_read_data_word);
+
+/**
+ * cs_dsp_write_data_word() - Writes a word to DSP memory
+ * @dsp: pointer to DSP structure
+ * @mem_type: the type of DSP memory containing the data to be written
+ * @mem_addr: the address of the data within the memory region
+ * @data: the data to be written
+ *
+ * Return: Zero for success, a negative number on error.
+ */
+int cs_dsp_write_data_word(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr, u32 data)
+{
+       struct cs_dsp_region const *mem = cs_dsp_find_region(dsp, mem_type);
+       __be32 val = cpu_to_be32(data & 0x00ffffffu);
+       unsigned int reg;
+
+       if (!mem)
+               return -EINVAL;
+
+       reg = dsp->ops->region_to_reg(mem, mem_addr);
+
+       return regmap_raw_write(dsp->regmap, reg, &val, sizeof(val));
+}
+EXPORT_SYMBOL_GPL(cs_dsp_write_data_word);
+
+/**
+ * cs_dsp_remove_padding() - Convert unpacked words to packed bytes
+ * @buf: buffer containing DSP words read from DSP memory
+ * @nwords: number of words to convert
+ *
+ * DSP words from the register map have pad bytes and the data bytes
+ * are in swapped order. This swaps to the native endian order and
+ * strips the pad bytes.
+ */
+void cs_dsp_remove_padding(u32 *buf, int nwords)
+{
+       const __be32 *pack_in = (__be32 *)buf;
+       u8 *pack_out = (u8 *)buf;
+       int i;
+
+       for (i = 0; i < nwords; i++) {
+               u32 word = be32_to_cpu(*pack_in++);
+               *pack_out++ = (u8)word;
+               *pack_out++ = (u8)(word >> 8);
+               *pack_out++ = (u8)(word >> 16);
+       }
+}
+EXPORT_SYMBOL_GPL(cs_dsp_remove_padding);
+
+/**
+ * cs_dsp_adsp2_bus_error() - Handle a DSP bus error interrupt
+ * @dsp: pointer to DSP structure
+ *
+ * The firmware and DSP state will be logged for future analysis.
+ */
+void cs_dsp_adsp2_bus_error(struct cs_dsp *dsp)
+{
+       unsigned int val;
+       struct regmap *regmap = dsp->regmap;
+       int ret = 0;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       ret = regmap_read(regmap, dsp->base + ADSP2_LOCK_REGION_CTRL, &val);
+       if (ret) {
+               cs_dsp_err(dsp,
+                          "Failed to read Region Lock Ctrl register: %d\n", ret);
+               goto error;
+       }
+
+       if (val & ADSP2_WDT_TIMEOUT_STS_MASK) {
+               cs_dsp_err(dsp, "watchdog timeout error\n");
+               dsp->ops->stop_watchdog(dsp);
+               if (dsp->client_ops->watchdog_expired)
+                       dsp->client_ops->watchdog_expired(dsp);
+       }
+
+       if (val & (ADSP2_ADDR_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {
+               if (val & ADSP2_ADDR_ERR_MASK)
+                       cs_dsp_err(dsp, "bus error: address error\n");
+               else
+                       cs_dsp_err(dsp, "bus error: region lock error\n");
+
+               ret = regmap_read(regmap, dsp->base + ADSP2_BUS_ERR_ADDR, &val);
+               if (ret) {
+                       cs_dsp_err(dsp,
+                                  "Failed to read Bus Err Addr register: %d\n",
+                                  ret);
+                       goto error;
+               }
+
+               cs_dsp_err(dsp, "bus error address = 0x%x\n",
+                          val & ADSP2_BUS_ERR_ADDR_MASK);
+
+               ret = regmap_read(regmap,
+                                 dsp->base + ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR,
+                                 &val);
+               if (ret) {
+                       cs_dsp_err(dsp,
+                                  "Failed to read Pmem Xmem Err Addr register: %d\n",
+                                  ret);
+                       goto error;
+               }
+
+               cs_dsp_err(dsp, "xmem error address = 0x%x\n",
+                          val & ADSP2_XMEM_ERR_ADDR_MASK);
+               cs_dsp_err(dsp, "pmem error address = 0x%x\n",
+                          (val & ADSP2_PMEM_ERR_ADDR_MASK) >>
+                          ADSP2_PMEM_ERR_ADDR_SHIFT);
+       }
+
+       regmap_update_bits(regmap, dsp->base + ADSP2_LOCK_REGION_CTRL,
+                          ADSP2_CTRL_ERR_EINT, ADSP2_CTRL_ERR_EINT);
+
+error:
+       mutex_unlock(&dsp->pwr_lock);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_adsp2_bus_error);
+
+/**
+ * cs_dsp_halo_bus_error() - Handle a DSP bus error interrupt
+ * @dsp: pointer to DSP structure
+ *
+ * The firmware and DSP state will be logged for future analysis.
+ */
+void cs_dsp_halo_bus_error(struct cs_dsp *dsp)
+{
+       struct regmap *regmap = dsp->regmap;
+       unsigned int fault[6];
+       struct reg_sequence clear[] = {
+               { dsp->base + HALO_MPU_XM_VIO_STATUS,     0x0 },
+               { dsp->base + HALO_MPU_YM_VIO_STATUS,     0x0 },
+               { dsp->base + HALO_MPU_PM_VIO_STATUS,     0x0 },
+       };
+       int ret;
+
+       mutex_lock(&dsp->pwr_lock);
+
+       ret = regmap_read(regmap, dsp->base_sysinfo + HALO_AHBM_WINDOW_DEBUG_1,
+                         fault);
+       if (ret) {
+               cs_dsp_warn(dsp, "Failed to read AHB DEBUG_1: %d\n", ret);
+               goto exit_unlock;
+       }
+
+       cs_dsp_warn(dsp, "AHB: STATUS: 0x%x ADDR: 0x%x\n",
+                   *fault & HALO_AHBM_FLAGS_ERR_MASK,
+                   (*fault & HALO_AHBM_CORE_ERR_ADDR_MASK) >>
+                   HALO_AHBM_CORE_ERR_ADDR_SHIFT);
+
+       ret = regmap_read(regmap, dsp->base_sysinfo + HALO_AHBM_WINDOW_DEBUG_0,
+                         fault);
+       if (ret) {
+               cs_dsp_warn(dsp, "Failed to read AHB DEBUG_0: %d\n", ret);
+               goto exit_unlock;
+       }
+
+       cs_dsp_warn(dsp, "AHB: SYS_ADDR: 0x%x\n", *fault);
+
+       ret = regmap_bulk_read(regmap, dsp->base + HALO_MPU_XM_VIO_ADDR,
+                              fault, ARRAY_SIZE(fault));
+       if (ret) {
+               cs_dsp_warn(dsp, "Failed to read MPU fault info: %d\n", ret);
+               goto exit_unlock;
+       }
+
+       cs_dsp_warn(dsp, "XM: STATUS:0x%x ADDR:0x%x\n", fault[1], fault[0]);
+       cs_dsp_warn(dsp, "YM: STATUS:0x%x ADDR:0x%x\n", fault[3], fault[2]);
+       cs_dsp_warn(dsp, "PM: STATUS:0x%x ADDR:0x%x\n", fault[5], fault[4]);
+
+       ret = regmap_multi_reg_write(dsp->regmap, clear, ARRAY_SIZE(clear));
+       if (ret)
+               cs_dsp_warn(dsp, "Failed to clear MPU status: %d\n", ret);
+
+exit_unlock:
+       mutex_unlock(&dsp->pwr_lock);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_halo_bus_error);
+
+/**
+ * cs_dsp_halo_wdt_expire() - Handle DSP watchdog expiry
+ * @dsp: pointer to DSP structure
+ *
+ * This is logged for future analysis.
+ */
+void cs_dsp_halo_wdt_expire(struct cs_dsp *dsp)
+{
+       mutex_lock(&dsp->pwr_lock);
+
+       cs_dsp_warn(dsp, "WDT Expiry Fault\n");
+
+       dsp->ops->stop_watchdog(dsp);
+       if (dsp->client_ops->watchdog_expired)
+               dsp->client_ops->watchdog_expired(dsp);
+
+       mutex_unlock(&dsp->pwr_lock);
+}
+EXPORT_SYMBOL_GPL(cs_dsp_halo_wdt_expire);
+
+static const struct cs_dsp_ops cs_dsp_adsp1_ops = {
+       .validate_version = cs_dsp_validate_version,
+       .parse_sizes = cs_dsp_adsp1_parse_sizes,
+       .region_to_reg = cs_dsp_region_to_reg,
+};
+
+static const struct cs_dsp_ops cs_dsp_adsp2_ops[] = {
+       {
+               .parse_sizes = cs_dsp_adsp2_parse_sizes,
+               .validate_version = cs_dsp_validate_version,
+               .setup_algs = cs_dsp_adsp2_setup_algs,
+               .region_to_reg = cs_dsp_region_to_reg,
+
+               .show_fw_status = cs_dsp_adsp2_show_fw_status,
+
+               .enable_memory = cs_dsp_adsp2_enable_memory,
+               .disable_memory = cs_dsp_adsp2_disable_memory,
+
+               .enable_core = cs_dsp_adsp2_enable_core,
+               .disable_core = cs_dsp_adsp2_disable_core,
+
+               .start_core = cs_dsp_adsp2_start_core,
+               .stop_core = cs_dsp_adsp2_stop_core,
+
+       },
+       {
+               .parse_sizes = cs_dsp_adsp2_parse_sizes,
+               .validate_version = cs_dsp_validate_version,
+               .setup_algs = cs_dsp_adsp2_setup_algs,
+               .region_to_reg = cs_dsp_region_to_reg,
+
+               .show_fw_status = cs_dsp_adsp2v2_show_fw_status,
+
+               .enable_memory = cs_dsp_adsp2_enable_memory,
+               .disable_memory = cs_dsp_adsp2_disable_memory,
+               .lock_memory = cs_dsp_adsp2_lock,
+
+               .enable_core = cs_dsp_adsp2v2_enable_core,
+               .disable_core = cs_dsp_adsp2v2_disable_core,
+
+               .start_core = cs_dsp_adsp2_start_core,
+               .stop_core = cs_dsp_adsp2_stop_core,
+       },
+       {
+               .parse_sizes = cs_dsp_adsp2_parse_sizes,
+               .validate_version = cs_dsp_validate_version,
+               .setup_algs = cs_dsp_adsp2_setup_algs,
+               .region_to_reg = cs_dsp_region_to_reg,
+
+               .show_fw_status = cs_dsp_adsp2v2_show_fw_status,
+               .stop_watchdog = cs_dsp_stop_watchdog,
+
+               .enable_memory = cs_dsp_adsp2_enable_memory,
+               .disable_memory = cs_dsp_adsp2_disable_memory,
+               .lock_memory = cs_dsp_adsp2_lock,
+
+               .enable_core = cs_dsp_adsp2v2_enable_core,
+               .disable_core = cs_dsp_adsp2v2_disable_core,
+
+               .start_core = cs_dsp_adsp2_start_core,
+               .stop_core = cs_dsp_adsp2_stop_core,
+       },
+};
+
+static const struct cs_dsp_ops cs_dsp_halo_ops = {
+       .parse_sizes = cs_dsp_adsp2_parse_sizes,
+       .validate_version = cs_dsp_halo_validate_version,
+       .setup_algs = cs_dsp_halo_setup_algs,
+       .region_to_reg = cs_dsp_halo_region_to_reg,
+
+       .show_fw_status = cs_dsp_halo_show_fw_status,
+       .stop_watchdog = cs_dsp_halo_stop_watchdog,
+
+       .lock_memory = cs_dsp_halo_configure_mpu,
+
+       .start_core = cs_dsp_halo_start_core,
+       .stop_core = cs_dsp_halo_stop_core,
+};
+
+MODULE_DESCRIPTION("Cirrus Logic DSP Support");
+MODULE_AUTHOR("Simon Trimmer <simont@opensource.cirrus.com>");
+MODULE_LICENSE("GPL v2");
index 73bdbd2..6ec8ede 100644 (file)
@@ -25,8 +25,6 @@
 #include <acpi/ghes.h>
 #include <ras/ras_event.h>
 
-static char rcd_decode_str[CPER_REC_LEN];
-
 /*
  * CPER record ID need to be unique even after reboot, because record
  * ID is used as index for ERST storage, while CPER records from
@@ -312,6 +310,7 @@ const char *cper_mem_err_unpack(struct trace_seq *p,
                                struct cper_mem_err_compact *cmem)
 {
        const char *ret = trace_seq_buffer_ptr(p);
+       char rcd_decode_str[CPER_REC_LEN];
 
        if (cper_mem_err_location(cmem, rcd_decode_str))
                trace_seq_printf(p, "%s", rcd_decode_str);
@@ -326,6 +325,7 @@ static void cper_print_mem(const char *pfx, const struct cper_sec_mem_err *mem,
        int len)
 {
        struct cper_mem_err_compact cmem;
+       char rcd_decode_str[CPER_REC_LEN];
 
        /* Don't trust UEFI 2.1/2.2 structure with bad validation bits */
        if (len == sizeof(struct cper_sec_mem_err_old) &&
index 365c3a4..fe567be 100644 (file)
@@ -271,7 +271,7 @@ efi_status_t allocate_new_fdt_and_exit_boot(void *handle,
                return status;
        }
 
-       efi_info("Exiting boot services and installing virtual address map...\n");
+       efi_info("Exiting boot services...\n");
 
        map.map = &memory_map;
        status = efi_allocate_pages(MAX_FDT_SIZE, new_fdt_addr, ULONG_MAX);
index 1410bea..f3e54f6 100644 (file)
@@ -414,7 +414,7 @@ static void virt_efi_reset_system(int reset_type,
                                  unsigned long data_size,
                                  efi_char16_t *data)
 {
-       if (down_interruptible(&efi_runtime_lock)) {
+       if (down_trylock(&efi_runtime_lock)) {
                pr_warn("failed to invoke the reset_system() runtime service:\n"
                        "could not get exclusive access to the firmware\n");
                return;
index c99b78e..f86666c 100644 (file)
@@ -1019,16 +1019,18 @@ create_feature_instance(struct build_feature_devs_info *binfo,
 {
        unsigned int irq_base, nr_irqs;
        struct dfl_feature_info *finfo;
+       u8 revision = 0;
        int ret;
-       u8 revision;
        u64 v;
 
-       v = readq(binfo->ioaddr + ofst);
-       revision = FIELD_GET(DFH_REVISION, v);
+       if (fid != FEATURE_ID_AFU) {
+               v = readq(binfo->ioaddr + ofst);
+               revision = FIELD_GET(DFH_REVISION, v);
 
-       /* read feature size and id if inputs are invalid */
-       size = size ? size : feature_size(v);
-       fid = fid ? fid : feature_id(v);
+               /* read feature size and id if inputs are invalid */
+               size = size ? size : feature_size(v);
+               fid = fid ? fid : feature_id(v);
+       }
 
        if (binfo->len - ofst < size)
                return -EINVAL;
index 69dec5a..029d3cd 100644 (file)
@@ -192,12 +192,19 @@ static const struct of_device_id ice40_fpga_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, ice40_fpga_of_match);
 
+static const struct spi_device_id ice40_fpga_spi_ids[] = {
+       { .name = "ice40-fpga-mgr", },
+       {},
+};
+MODULE_DEVICE_TABLE(spi, ice40_fpga_spi_ids);
+
 static struct spi_driver ice40_fpga_driver = {
        .probe = ice40_fpga_probe,
        .driver = {
                .name = "ice40spi",
                .of_match_table = of_match_ptr(ice40_fpga_of_match),
        },
+       .id_table = ice40_fpga_spi_ids,
 };
 
 module_spi_driver(ice40_fpga_driver);
index 1afb41a..ea2ec3c 100644 (file)
@@ -225,8 +225,10 @@ static int machxo2_write_init(struct fpga_manager *mgr,
                goto fail;
 
        get_status(spi, &status);
-       if (test_bit(FAIL, &status))
+       if (test_bit(FAIL, &status)) {
+               ret = -EINVAL;
                goto fail;
+       }
        dump_status_reg(&status);
 
        spi_message_init(&msg);
@@ -313,6 +315,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
        dump_status_reg(&status);
        if (!test_bit(DONE, &status)) {
                machxo2_cleanup(mgr);
+               ret = -EINVAL;
                goto fail;
        }
 
@@ -335,6 +338,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr,
                        break;
                if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) {
                        machxo2_cleanup(mgr);
+                       ret = -EINVAL;
                        goto fail;
                }
        } while (1);
index 05637d5..4a55cdf 100644 (file)
@@ -174,6 +174,13 @@ static int gen_74x164_remove(struct spi_device *spi)
        return 0;
 }
 
+static const struct spi_device_id gen_74x164_spi_ids[] = {
+       { .name = "74hc595" },
+       { .name = "74lvc594" },
+       {},
+};
+MODULE_DEVICE_TABLE(spi, gen_74x164_spi_ids);
+
 static const struct of_device_id gen_74x164_dt_ids[] = {
        { .compatible = "fairchild,74hc595" },
        { .compatible = "nxp,74lvc594" },
@@ -188,6 +195,7 @@ static struct spi_driver gen_74x164_driver = {
        },
        .probe          = gen_74x164_probe,
        .remove         = gen_74x164_remove,
+       .id_table       = gen_74x164_spi_ids,
 };
 module_spi_driver(gen_74x164_driver);
 
index 10f303d..3d6ef37 100644 (file)
@@ -395,7 +395,7 @@ static void aspeed_sgpio_irq_handler(struct irq_desc *desc)
                reg = ioread32(bank_reg(data, bank, reg_irq_status));
 
                for_each_set_bit(p, &reg, 32)
-                       generic_handle_domain_irq(gc->irq.domain, i * 32 + p);
+                       generic_handle_domain_irq(gc->irq.domain, i * 32 + p * 2);
        }
 
        chained_irq_exit(ic, desc);
index 0a9d746..d26bff2 100644 (file)
@@ -476,10 +476,19 @@ static struct platform_device *gpio_mockup_pdevs[GPIO_MOCKUP_MAX_GC];
 
 static void gpio_mockup_unregister_pdevs(void)
 {
+       struct platform_device *pdev;
+       struct fwnode_handle *fwnode;
        int i;
 
-       for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++)
-               platform_device_unregister(gpio_mockup_pdevs[i]);
+       for (i = 0; i < GPIO_MOCKUP_MAX_GC; i++) {
+               pdev = gpio_mockup_pdevs[i];
+               if (!pdev)
+                       continue;
+
+               fwnode = dev_fwnode(&pdev->dev);
+               platform_device_unregister(pdev);
+               fwnode_remove_software_node(fwnode);
+       }
 }
 
 static __init char **gpio_mockup_make_line_names(const char *label,
@@ -508,6 +517,7 @@ static int __init gpio_mockup_register_chip(int idx)
        struct property_entry properties[GPIO_MOCKUP_MAX_PROP];
        struct platform_device_info pdevinfo;
        struct platform_device *pdev;
+       struct fwnode_handle *fwnode;
        char **line_names = NULL;
        char chip_label[32];
        int prop = 0, base;
@@ -536,13 +546,18 @@ static int __init gpio_mockup_register_chip(int idx)
                                        "gpio-line-names", line_names, ngpio);
        }
 
+       fwnode = fwnode_create_software_node(properties, NULL);
+       if (IS_ERR(fwnode))
+               return PTR_ERR(fwnode);
+
        pdevinfo.name = "gpio-mockup";
        pdevinfo.id = idx;
-       pdevinfo.properties = properties;
+       pdevinfo.fwnode = fwnode;
 
        pdev = platform_device_register_full(&pdevinfo);
        kfree_strarray(line_names, ngpio);
        if (IS_ERR(pdev)) {
+               fwnode_remove_software_node(fwnode);
                pr_err("error registering device");
                return PTR_ERR(pdev);
        }
index f5cfc06..d2fe76f 100644 (file)
@@ -468,15 +468,8 @@ static int pca953x_gpio_get_value(struct gpio_chip *gc, unsigned off)
        mutex_lock(&chip->i2c_lock);
        ret = regmap_read(chip->regmap, inreg, &reg_val);
        mutex_unlock(&chip->i2c_lock);
-       if (ret < 0) {
-               /*
-                * NOTE:
-                * diagnostic already emitted; that's all we should
-                * do unless gpio_*_value_cansleep() calls become different
-                * from their nonsleeping siblings (and report faults).
-                */
-               return 0;
-       }
+       if (ret < 0)
+               return ret;
 
        return !!(reg_val & bit);
 }
@@ -566,21 +559,21 @@ static int pca953x_gpio_set_pull_up_down(struct pca953x_chip *chip,
 
        mutex_lock(&chip->i2c_lock);
 
-       /* Disable pull-up/pull-down */
-       ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, 0);
-       if (ret)
-               goto exit;
-
        /* Configure pull-up/pull-down */
        if (config == PIN_CONFIG_BIAS_PULL_UP)
                ret = regmap_write_bits(chip->regmap, pull_sel_reg, bit, bit);
        else if (config == PIN_CONFIG_BIAS_PULL_DOWN)
                ret = regmap_write_bits(chip->regmap, pull_sel_reg, bit, 0);
+       else
+               ret = 0;
        if (ret)
                goto exit;
 
-       /* Enable pull-up/pull-down */
-       ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, bit);
+       /* Disable/Enable pull-up/pull-down */
+       if (config == PIN_CONFIG_BIAS_DISABLE)
+               ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, 0);
+       else
+               ret = regmap_write_bits(chip->regmap, pull_en_reg, bit, bit);
 
 exit:
        mutex_unlock(&chip->i2c_lock);
@@ -594,7 +587,9 @@ static int pca953x_gpio_set_config(struct gpio_chip *gc, unsigned int offset,
 
        switch (pinconf_to_config_param(config)) {
        case PIN_CONFIG_BIAS_PULL_UP:
+       case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT:
        case PIN_CONFIG_BIAS_PULL_DOWN:
+       case PIN_CONFIG_BIAS_DISABLE:
                return pca953x_gpio_set_pull_up_down(chip, offset, config);
        default:
                return -ENOTSUPP;
index 036b2d9..ce63cbd 100644 (file)
@@ -141,7 +141,7 @@ static int rockchip_gpio_get_direction(struct gpio_chip *chip,
        u32 data;
 
        data = rockchip_gpio_readl_bit(bank, offset, bank->gpio_regs->port_ddr);
-       if (data & BIT(offset))
+       if (data)
                return GPIO_LINE_DIRECTION_OUT;
 
        return GPIO_LINE_DIRECTION_IN;
@@ -195,7 +195,7 @@ static int rockchip_gpio_set_debounce(struct gpio_chip *gc,
        unsigned int cur_div_reg;
        u64 div;
 
-       if (!IS_ERR(bank->db_clk)) {
+       if (bank->gpio_type == GPIO_TYPE_V2 && !IS_ERR(bank->db_clk)) {
                div_debounce_support = true;
                freq = clk_get_rate(bank->db_clk);
                max_debounce = (GENMASK(23, 0) + 1) * 2 * 1000000 / freq;
@@ -689,6 +689,7 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
        struct device_node *pctlnp = of_get_parent(np);
        struct pinctrl_dev *pctldev = NULL;
        struct rockchip_pin_bank *bank = NULL;
+       struct rockchip_pin_output_deferred *cfg;
        static int gpio;
        int id, ret;
 
@@ -716,12 +717,33 @@ static int rockchip_gpio_probe(struct platform_device *pdev)
        if (ret)
                return ret;
 
+       /*
+        * Prevent clashes with a deferred output setting
+        * being added right at this moment.
+        */
+       mutex_lock(&bank->deferred_lock);
+
        ret = rockchip_gpiolib_register(bank);
        if (ret) {
                clk_disable_unprepare(bank->clk);
+               mutex_unlock(&bank->deferred_lock);
                return ret;
        }
 
+       while (!list_empty(&bank->deferred_output)) {
+               cfg = list_first_entry(&bank->deferred_output,
+                                      struct rockchip_pin_output_deferred, head);
+               list_del(&cfg->head);
+
+               ret = rockchip_gpio_direction_output(&bank->gpio_chip, cfg->pin, cfg->arg);
+               if (ret)
+                       dev_warn(dev, "setting output pin %u to %u failed\n", cfg->pin, cfg->arg);
+
+               kfree(cfg);
+       }
+
+       mutex_unlock(&bank->deferred_lock);
+
        platform_set_drvdata(pdev, bank);
        dev_info(dev, "probed %pOF\n", np);
 
index f99f3c1..39dca14 100644 (file)
@@ -184,7 +184,7 @@ static void uniphier_gpio_irq_mask(struct irq_data *data)
 
        uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, 0);
 
-       return irq_chip_mask_parent(data);
+       irq_chip_mask_parent(data);
 }
 
 static void uniphier_gpio_irq_unmask(struct irq_data *data)
@@ -194,7 +194,7 @@ static void uniphier_gpio_irq_unmask(struct irq_data *data)
 
        uniphier_gpio_reg_update(priv, UNIPHIER_GPIO_IRQ_EN, mask, mask);
 
-       return irq_chip_unmask_parent(data);
+       irq_chip_unmask_parent(data);
 }
 
 static int uniphier_gpio_irq_set_type(struct irq_data *data, unsigned int type)
index 411525a..47712b6 100644 (file)
@@ -313,9 +313,11 @@ static struct gpio_desc *acpi_request_own_gpiod(struct gpio_chip *chip,
 
        ret = gpio_set_debounce_timeout(desc, agpio->debounce_timeout);
        if (ret)
-               gpiochip_free_own_desc(desc);
+               dev_warn(chip->parent,
+                        "Failed to set debounce-timeout for pin 0x%04X, err %d\n",
+                        pin, ret);
 
-       return ret ? ERR_PTR(ret) : desc;
+       return desc;
 }
 
 static bool acpi_gpio_in_ignore_list(const char *controller_in, int pin_in)
index dc3c6b3..269437b 100644 (file)
@@ -758,7 +758,7 @@ enum amd_hw_ip_block_type {
        MAX_HWIP
 };
 
-#define HWIP_MAX_INSTANCE      8
+#define HWIP_MAX_INSTANCE      10
 
 struct amd_powerplay {
        void *pp_handle;
@@ -1087,6 +1087,7 @@ struct amdgpu_device {
 
        bool                            no_hw_access;
        struct pci_saved_state          *pci_state;
+       pci_channel_state_t             pci_channel_state;
 
        struct amdgpu_reset_control     *reset_cntl;
 };
index 3003ee1..1d41c2c 100644 (file)
@@ -192,6 +192,16 @@ void amdgpu_amdkfd_suspend(struct amdgpu_device *adev, bool run_pm)
                kgd2kfd_suspend(adev->kfd.dev, run_pm);
 }
 
+int amdgpu_amdkfd_resume_iommu(struct amdgpu_device *adev)
+{
+       int r = 0;
+
+       if (adev->kfd.dev)
+               r = kgd2kfd_resume_iommu(adev->kfd.dev);
+
+       return r;
+}
+
 int amdgpu_amdkfd_resume(struct amdgpu_device *adev, bool run_pm)
 {
        int r = 0;
index ec028cf..3bc52b2 100644 (file)
@@ -137,6 +137,7 @@ int amdgpu_amdkfd_init(void);
 void amdgpu_amdkfd_fini(void);
 
 void amdgpu_amdkfd_suspend(struct amdgpu_device *adev, bool run_pm);
+int amdgpu_amdkfd_resume_iommu(struct amdgpu_device *adev);
 int amdgpu_amdkfd_resume(struct amdgpu_device *adev, bool run_pm);
 void amdgpu_amdkfd_interrupt(struct amdgpu_device *adev,
                        const void *ih_ring_entry);
@@ -327,6 +328,7 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd,
                         const struct kgd2kfd_shared_resources *gpu_resources);
 void kgd2kfd_device_exit(struct kfd_dev *kfd);
 void kgd2kfd_suspend(struct kfd_dev *kfd, bool run_pm);
+int kgd2kfd_resume_iommu(struct kfd_dev *kfd);
 int kgd2kfd_resume(struct kfd_dev *kfd, bool run_pm);
 int kgd2kfd_pre_reset(struct kfd_dev *kfd);
 int kgd2kfd_post_reset(struct kfd_dev *kfd);
@@ -365,6 +367,11 @@ static inline void kgd2kfd_suspend(struct kfd_dev *kfd, bool run_pm)
 {
 }
 
+static int __maybe_unused kgd2kfd_resume_iommu(struct kfd_dev *kfd)
+{
+       return 0;
+}
+
 static inline int kgd2kfd_resume(struct kfd_dev *kfd, bool run_pm)
 {
        return 0;
index 2d6b2d7..054c1a2 100644 (file)
@@ -563,6 +563,7 @@ kfd_mem_dmaunmap_userptr(struct kgd_mem *mem,
 
        dma_unmap_sgtable(adev->dev, ttm->sg, direction, 0);
        sg_free_table(ttm->sg);
+       kfree(ttm->sg);
        ttm->sg = NULL;
 }
 
index 2771288..463b9c0 100644 (file)
@@ -1544,20 +1544,18 @@ int amdgpu_debugfs_init(struct amdgpu_device *adev)
        struct dentry *ent;
        int r, i;
 
-
-
        ent = debugfs_create_file("amdgpu_preempt_ib", 0600, root, adev,
                                  &fops_ib_preempt);
-       if (!ent) {
+       if (IS_ERR(ent)) {
                DRM_ERROR("unable to create amdgpu_preempt_ib debugsfs file\n");
-               return -EIO;
+               return PTR_ERR(ent);
        }
 
        ent = debugfs_create_file("amdgpu_force_sclk", 0200, root, adev,
                                  &fops_sclk_set);
-       if (!ent) {
+       if (IS_ERR(ent)) {
                DRM_ERROR("unable to create amdgpu_set_sclk debugsfs file\n");
-               return -EIO;
+               return PTR_ERR(ent);
        }
 
        /* Register debugfs entries for amdgpu_ttm */
index 41c6b3a..af9bdf1 100644 (file)
@@ -2432,6 +2432,10 @@ static int amdgpu_device_ip_init(struct amdgpu_device *adev)
        if (!adev->gmc.xgmi.pending_reset)
                amdgpu_amdkfd_device_init(adev);
 
+       r = amdgpu_amdkfd_resume_iommu(adev);
+       if (r)
+               goto init_failed;
+
        amdgpu_fru_get_product_info(adev);
 
 init_failed:
@@ -3148,6 +3152,10 @@ static int amdgpu_device_ip_resume(struct amdgpu_device *adev)
 {
        int r;
 
+       r = amdgpu_amdkfd_resume_iommu(adev);
+       if (r)
+               return r;
+
        r = amdgpu_device_ip_resume_phase1(adev);
        if (r)
                return r;
@@ -4601,6 +4609,10 @@ int amdgpu_do_asic_reset(struct list_head *device_list_handle,
                                dev_warn(tmp_adev->dev, "asic atom init failed!");
                        } else {
                                dev_info(tmp_adev->dev, "GPU reset succeeded, trying to resume\n");
+                               r = amdgpu_amdkfd_resume_iommu(tmp_adev);
+                               if (r)
+                                       goto out;
+
                                r = amdgpu_device_ip_resume_phase1(tmp_adev);
                                if (r)
                                        goto out;
@@ -5387,6 +5399,8 @@ pci_ers_result_t amdgpu_pci_error_detected(struct pci_dev *pdev, pci_channel_sta
                return PCI_ERS_RESULT_DISCONNECT;
        }
 
+       adev->pci_channel_state = state;
+
        switch (state) {
        case pci_channel_io_normal:
                return PCI_ERS_RESULT_CAN_RECOVER;
@@ -5529,6 +5543,10 @@ void amdgpu_pci_resume(struct pci_dev *pdev)
 
        DRM_INFO("PCI error: resume callback!!\n");
 
+       /* Only continue execution for the case of pci_channel_io_frozen */
+       if (adev->pci_channel_state != pci_channel_io_frozen)
+               return;
+
        for (i = 0; i < AMDGPU_MAX_RINGS; ++i) {
                struct amdgpu_ring *ring = adev->rings[i];
 
index 7a73167..dc50c05 100644 (file)
@@ -837,6 +837,28 @@ static int convert_tiling_flags_to_modifier(struct amdgpu_framebuffer *afb)
        return 0;
 }
 
+/* Mirrors the is_displayable check in radeonsi's gfx6_compute_surface */
+static int check_tiling_flags_gfx6(struct amdgpu_framebuffer *afb)
+{
+       u64 micro_tile_mode;
+
+       /* Zero swizzle mode means linear */
+       if (AMDGPU_TILING_GET(afb->tiling_flags, SWIZZLE_MODE) == 0)
+               return 0;
+
+       micro_tile_mode = AMDGPU_TILING_GET(afb->tiling_flags, MICRO_TILE_MODE);
+       switch (micro_tile_mode) {
+       case 0: /* DISPLAY */
+       case 3: /* RENDER */
+               return 0;
+       default:
+               drm_dbg_kms(afb->base.dev,
+                           "Micro tile mode %llu not supported for scanout\n",
+                           micro_tile_mode);
+               return -EINVAL;
+       }
+}
+
 static void get_block_dimensions(unsigned int block_log2, unsigned int cpp,
                                 unsigned int *width, unsigned int *height)
 {
@@ -1103,6 +1125,7 @@ int amdgpu_display_framebuffer_init(struct drm_device *dev,
                                    const struct drm_mode_fb_cmd2 *mode_cmd,
                                    struct drm_gem_object *obj)
 {
+       struct amdgpu_device *adev = drm_to_adev(dev);
        int ret, i;
 
        /*
@@ -1122,6 +1145,14 @@ int amdgpu_display_framebuffer_init(struct drm_device *dev,
        if (ret)
                return ret;
 
+       if (!dev->mode_config.allow_fb_modifiers) {
+               drm_WARN_ONCE(dev, adev->family >= AMDGPU_FAMILY_AI,
+                             "GFX9+ requires FB check based on format modifier\n");
+               ret = check_tiling_flags_gfx6(rfb);
+               if (ret)
+                       return ret;
+       }
+
        if (dev->mode_config.allow_fb_modifiers &&
            !(rfb->base.flags & DRM_MODE_FB_MODIFIERS)) {
                ret = convert_tiling_flags_to_modifier(rfb);
index e7f06bd..1916ec8 100644 (file)
@@ -31,6 +31,8 @@
 /* delay 0.1 second to enable gfx off feature */
 #define GFX_OFF_DELAY_ENABLE         msecs_to_jiffies(100)
 
+#define GFX_OFF_NO_DELAY 0
+
 /*
  * GPU GFX IP block helpers function.
  */
@@ -558,6 +560,8 @@ int amdgpu_gfx_enable_kcq(struct amdgpu_device *adev)
 
 void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool enable)
 {
+       unsigned long delay = GFX_OFF_DELAY_ENABLE;
+
        if (!(adev->pm.pp_feature & PP_GFXOFF_MASK))
                return;
 
@@ -573,8 +577,14 @@ void amdgpu_gfx_off_ctrl(struct amdgpu_device *adev, bool enable)
 
                adev->gfx.gfx_off_req_count--;
 
-               if (adev->gfx.gfx_off_req_count == 0 && !adev->gfx.gfx_off_state)
-                       schedule_delayed_work(&adev->gfx.gfx_off_delay_work, GFX_OFF_DELAY_ENABLE);
+               if (adev->gfx.gfx_off_req_count == 0 &&
+                   !adev->gfx.gfx_off_state) {
+                       /* If going to s2idle, no need to wait */
+                       if (adev->in_s0ix)
+                               delay = GFX_OFF_NO_DELAY;
+                       schedule_delayed_work(&adev->gfx.gfx_off_delay_work,
+                                             delay);
+               }
        } else {
                if (adev->gfx.gfx_off_req_count == 0) {
                        cancel_delayed_work_sync(&adev->gfx.gfx_off_delay_work);
index c7797ea..9ff600a 100644 (file)
@@ -598,7 +598,7 @@ void amdgpu_gmc_tmz_set(struct amdgpu_device *adev)
                break;
        default:
                adev->gmc.tmz_enabled = false;
-               dev_warn(adev->dev,
+               dev_info(adev->dev,
                         "Trusted Memory Zone (TMZ) feature not supported\n");
                break;
        }
index dc44c94..9873251 100644 (file)
@@ -757,7 +757,7 @@ Out:
        return res;
 }
 
-inline uint32_t amdgpu_ras_eeprom_max_record_count(void)
+uint32_t amdgpu_ras_eeprom_max_record_count(void)
 {
        return RAS_MAX_RECORD_COUNT;
 }
index f95fc61..6bb0057 100644 (file)
@@ -120,7 +120,7 @@ int amdgpu_ras_eeprom_read(struct amdgpu_ras_eeprom_control *control,
 int amdgpu_ras_eeprom_append(struct amdgpu_ras_eeprom_control *control,
                             struct eeprom_table_record *records, const u32 num);
 
-inline uint32_t amdgpu_ras_eeprom_max_record_count(void);
+uint32_t amdgpu_ras_eeprom_max_record_count(void);
 
 void amdgpu_ras_debugfs_set_ret_size(struct amdgpu_ras_eeprom_control *control);
 
index 7b634a1..0554576 100644 (file)
@@ -428,8 +428,8 @@ int amdgpu_debugfs_ring_init(struct amdgpu_device *adev,
        ent = debugfs_create_file(name,
                                  S_IFREG | S_IRUGO, root,
                                  ring, &amdgpu_debugfs_ring_fops);
-       if (!ent)
-               return -ENOMEM;
+       if (IS_ERR(ent))
+               return PTR_ERR(ent);
 
        i_size_write(ent->d_inode, ring->ring_size + 12);
        ring->ent = ent;
index 38dade4..94126dc 100644 (file)
@@ -515,6 +515,15 @@ static int amdgpu_bo_move(struct ttm_buffer_object *bo, bool evict,
                goto out;
        }
 
+       if (bo->type == ttm_bo_type_device &&
+           new_mem->mem_type == TTM_PL_VRAM &&
+           old_mem->mem_type != TTM_PL_VRAM) {
+               /* amdgpu_bo_fault_reserve_notify will re-set this if the CPU
+                * accesses the BO after it's moved.
+                */
+               abo->flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
+       }
+
        if (adev->mman.buffer_funcs_enabled) {
                if (((old_mem->mem_type == TTM_PL_SYSTEM &&
                      new_mem->mem_type == TTM_PL_VRAM) ||
@@ -545,15 +554,6 @@ static int amdgpu_bo_move(struct ttm_buffer_object *bo, bool evict,
                        return r;
        }
 
-       if (bo->type == ttm_bo_type_device &&
-           new_mem->mem_type == TTM_PL_VRAM &&
-           old_mem->mem_type != TTM_PL_VRAM) {
-               /* amdgpu_bo_fault_reserve_notify will re-set this if the CPU
-                * accesses the BO after it's moved.
-                */
-               abo->flags &= ~AMDGPU_GEM_CREATE_CPU_ACCESS_REQUIRED;
-       }
-
 out:
        /* update statistics */
        atomic64_add(bo->base.size, &adev->num_bytes_moved);
index 603c259..025184a 100644 (file)
@@ -3599,7 +3599,7 @@ static int gfx_v9_0_mqd_init(struct amdgpu_ring *ring)
 
        /* set static priority for a queue/ring */
        gfx_v9_0_mqd_set_priority(ring, mqd);
-       mqd->cp_hqd_quantum = RREG32(mmCP_HQD_QUANTUM);
+       mqd->cp_hqd_quantum = RREG32_SOC15(GC, 0, mmCP_HQD_QUANTUM);
 
        /* map_queues packet doesn't need activate the queue,
         * so only kiq need set this field.
index 41c3a0d..e47104a 100644 (file)
@@ -1098,6 +1098,8 @@ static int gmc_v10_0_hw_fini(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+       gmc_v10_0_gart_disable(adev);
+
        if (amdgpu_sriov_vf(adev)) {
                /* full access mode, so don't touch any GMC register */
                DRM_DEBUG("For SRIOV client, shouldn't do anything.\n");
@@ -1106,7 +1108,6 @@ static int gmc_v10_0_hw_fini(void *handle)
 
        amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
        amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
-       gmc_v10_0_gart_disable(adev);
 
        return 0;
 }
index d90c16a..5551359 100644 (file)
@@ -1794,6 +1794,8 @@ static int gmc_v9_0_hw_fini(void *handle)
 {
        struct amdgpu_device *adev = (struct amdgpu_device *)handle;
 
+       gmc_v9_0_gart_disable(adev);
+
        if (amdgpu_sriov_vf(adev)) {
                /* full access mode, so don't touch any GMC register */
                DRM_DEBUG("For SRIOV client, shouldn't do anything.\n");
@@ -1802,7 +1804,6 @@ static int gmc_v9_0_hw_fini(void *handle)
 
        amdgpu_irq_put(adev, &adev->gmc.ecc_irq, 0);
        amdgpu_irq_put(adev, &adev->gmc.vm_fault, 0);
-       gmc_v9_0_gart_disable(adev);
 
        return 0;
 }
index 779f5c9..e32efcf 100644 (file)
@@ -868,6 +868,12 @@ static int sdma_v5_2_start(struct amdgpu_device *adev)
                        msleep(1000);
        }
 
+       /* TODO: check whether can submit a doorbell request to raise
+        * a doorbell fence to exit gfxoff.
+        */
+       if (adev->in_s0ix)
+               amdgpu_gfx_off_ctrl(adev, false);
+
        sdma_v5_2_soft_reset(adev);
        /* unhalt the MEs */
        sdma_v5_2_enable(adev, true);
@@ -876,6 +882,8 @@ static int sdma_v5_2_start(struct amdgpu_device *adev)
 
        /* start the gfx rings and rlc compute queues */
        r = sdma_v5_2_gfx_resume(adev);
+       if (adev->in_s0ix)
+               amdgpu_gfx_off_ctrl(adev, true);
        if (r)
                return r;
        r = sdma_v5_2_rlc_resume(adev);
index 16a57b7..4a41623 100644 (file)
@@ -468,6 +468,7 @@ static const struct kfd_device_info navi10_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 145,
        .num_sdma_engines = 2,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -487,6 +488,7 @@ static const struct kfd_device_info navi12_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 145,
        .num_sdma_engines = 2,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -506,6 +508,7 @@ static const struct kfd_device_info navi14_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 145,
        .num_sdma_engines = 2,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -525,6 +528,7 @@ static const struct kfd_device_info sienna_cichlid_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 4,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -544,6 +548,7 @@ static const struct kfd_device_info navy_flounder_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 2,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -562,7 +567,8 @@ static const struct kfd_device_info vangogh_device_info = {
        .mqd_size_aligned = MQD_SIZE_ALIGNED,
        .needs_iommu_device = false,
        .supports_cwsr = true,
-       .needs_pci_atomics = false,
+       .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 1,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 2,
@@ -582,6 +588,7 @@ static const struct kfd_device_info dimgrey_cavefish_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 2,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -601,6 +608,7 @@ static const struct kfd_device_info beige_goby_device_info = {
        .needs_iommu_device = false,
        .supports_cwsr = true,
        .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 1,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 8,
@@ -619,7 +627,8 @@ static const struct kfd_device_info yellow_carp_device_info = {
        .mqd_size_aligned = MQD_SIZE_ALIGNED,
        .needs_iommu_device = false,
        .supports_cwsr = true,
-       .needs_pci_atomics = false,
+       .needs_pci_atomics = true,
+       .no_atomic_fw_version = 92,
        .num_sdma_engines = 1,
        .num_xgmi_sdma_engines = 0,
        .num_sdma_queues_per_engine = 2,
@@ -708,20 +717,6 @@ struct kfd_dev *kgd2kfd_probe(struct kgd_dev *kgd,
        if (!kfd)
                return NULL;
 
-       /* Allow BIF to recode atomics to PCIe 3.0 AtomicOps.
-        * 32 and 64-bit requests are possible and must be
-        * supported.
-        */
-       kfd->pci_atomic_requested = amdgpu_amdkfd_have_atomics_support(kgd);
-       if (device_info->needs_pci_atomics &&
-           !kfd->pci_atomic_requested) {
-               dev_info(kfd_device,
-                        "skipped device %x:%x, PCI rejects atomics\n",
-                        pdev->vendor, pdev->device);
-               kfree(kfd);
-               return NULL;
-       }
-
        kfd->kgd = kgd;
        kfd->device_info = device_info;
        kfd->pdev = pdev;
@@ -821,6 +816,23 @@ bool kgd2kfd_device_init(struct kfd_dev *kfd,
        kfd->vm_info.vmid_num_kfd = kfd->vm_info.last_vmid_kfd
                        - kfd->vm_info.first_vmid_kfd + 1;
 
+       /* Allow BIF to recode atomics to PCIe 3.0 AtomicOps.
+        * 32 and 64-bit requests are possible and must be
+        * supported.
+        */
+       kfd->pci_atomic_requested = amdgpu_amdkfd_have_atomics_support(kfd->kgd);
+       if (!kfd->pci_atomic_requested &&
+           kfd->device_info->needs_pci_atomics &&
+           (!kfd->device_info->no_atomic_fw_version ||
+            kfd->mec_fw_version < kfd->device_info->no_atomic_fw_version)) {
+               dev_info(kfd_device,
+                        "skipped device %x:%x, PCI rejects atomics %d<%d\n",
+                        kfd->pdev->vendor, kfd->pdev->device,
+                        kfd->mec_fw_version,
+                        kfd->device_info->no_atomic_fw_version);
+               return false;
+       }
+
        /* Verify module parameters regarding mapped process number*/
        if ((hws_max_conc_proc < 0)
                        || (hws_max_conc_proc > kfd->vm_info.vmid_num_kfd)) {
@@ -959,7 +971,6 @@ out:
 void kgd2kfd_device_exit(struct kfd_dev *kfd)
 {
        if (kfd->init_complete) {
-               svm_migrate_fini((struct amdgpu_device *)kfd->kgd);
                device_queue_manager_uninit(kfd->dqm);
                kfd_interrupt_exit(kfd);
                kfd_topology_remove_device(kfd);
@@ -1057,31 +1068,29 @@ int kgd2kfd_resume(struct kfd_dev *kfd, bool run_pm)
        return ret;
 }
 
-static int kfd_resume(struct kfd_dev *kfd)
+int kgd2kfd_resume_iommu(struct kfd_dev *kfd)
 {
        int err = 0;
 
        err = kfd_iommu_resume(kfd);
-       if (err) {
+       if (err)
                dev_err(kfd_device,
                        "Failed to resume IOMMU for device %x:%x\n",
                        kfd->pdev->vendor, kfd->pdev->device);
-               return err;
-       }
+       return err;
+}
+
+static int kfd_resume(struct kfd_dev *kfd)
+{
+       int err = 0;
 
        err = kfd->dqm->ops.start(kfd->dqm);
-       if (err) {
+       if (err)
                dev_err(kfd_device,
                        "Error starting queue manager for device %x:%x\n",
                        kfd->pdev->vendor, kfd->pdev->device);
-               goto dqm_start_error;
-       }
 
        return err;
-
-dqm_start_error:
-       kfd_iommu_suspend(kfd);
-       return err;
 }
 
 static inline void kfd_queue_work(struct workqueue_struct *wq,
index dab290a..4a16e3c 100644 (file)
@@ -891,9 +891,16 @@ int svm_migrate_init(struct amdgpu_device *adev)
        pgmap->ops = &svm_migrate_pgmap_ops;
        pgmap->owner = SVM_ADEV_PGMAP_OWNER(adev);
        pgmap->flags = MIGRATE_VMA_SELECT_DEVICE_PRIVATE;
+
+       /* Device manager releases device-specific resources, memory region and
+        * pgmap when driver disconnects from device.
+        */
        r = devm_memremap_pages(adev->dev, pgmap);
        if (IS_ERR(r)) {
                pr_err("failed to register HMM device memory\n");
+
+               /* Disable SVM support capability */
+               pgmap->type = 0;
                devm_release_mem_region(adev->dev, res->start,
                                        res->end - res->start + 1);
                return PTR_ERR(r);
@@ -908,12 +915,3 @@ int svm_migrate_init(struct amdgpu_device *adev)
 
        return 0;
 }
-
-void svm_migrate_fini(struct amdgpu_device *adev)
-{
-       struct dev_pagemap *pgmap = &adev->kfd.dev->pgmap;
-
-       devm_memunmap_pages(adev->dev, pgmap);
-       devm_release_mem_region(adev->dev, pgmap->range.start,
-                               pgmap->range.end - pgmap->range.start + 1);
-}
index 0de76b5..2f5b339 100644 (file)
@@ -47,7 +47,6 @@ unsigned long
 svm_migrate_addr_to_pfn(struct amdgpu_device *adev, unsigned long addr);
 
 int svm_migrate_init(struct amdgpu_device *adev);
-void svm_migrate_fini(struct amdgpu_device *adev);
 
 #else
 
@@ -55,10 +54,6 @@ static inline int svm_migrate_init(struct amdgpu_device *adev)
 {
        return 0;
 }
-static inline void svm_migrate_fini(struct amdgpu_device *adev)
-{
-       /* empty */
-}
 
 #endif /* IS_ENABLED(CONFIG_HSA_AMD_SVM) */
 
index ab83b0d..6d8f9bb 100644 (file)
@@ -207,6 +207,7 @@ struct kfd_device_info {
        bool supports_cwsr;
        bool needs_iommu_device;
        bool needs_pci_atomics;
+       uint32_t no_atomic_fw_version;
        unsigned int num_sdma_engines;
        unsigned int num_xgmi_sdma_engines;
        unsigned int num_sdma_queues_per_engine;
index 9fc8021..9d0f65a 100644 (file)
@@ -118,6 +118,13 @@ static void svm_range_remove_notifier(struct svm_range *prange)
                mmu_interval_notifier_remove(&prange->notifier);
 }
 
+static bool
+svm_is_valid_dma_mapping_addr(struct device *dev, dma_addr_t dma_addr)
+{
+       return dma_addr && !dma_mapping_error(dev, dma_addr) &&
+              !(dma_addr & SVM_RANGE_VRAM_DOMAIN);
+}
+
 static int
 svm_range_dma_map_dev(struct amdgpu_device *adev, struct svm_range *prange,
                      unsigned long offset, unsigned long npages,
@@ -139,8 +146,7 @@ svm_range_dma_map_dev(struct amdgpu_device *adev, struct svm_range *prange,
 
        addr += offset;
        for (i = 0; i < npages; i++) {
-               if (WARN_ONCE(addr[i] && !dma_mapping_error(dev, addr[i]),
-                             "leaking dma mapping\n"))
+               if (svm_is_valid_dma_mapping_addr(dev, addr[i]))
                        dma_unmap_page(dev, addr[i], PAGE_SIZE, dir);
 
                page = hmm_pfn_to_page(hmm_pfns[i]);
@@ -209,7 +215,7 @@ void svm_range_dma_unmap(struct device *dev, dma_addr_t *dma_addr,
                return;
 
        for (i = offset; i < offset + npages; i++) {
-               if (!dma_addr[i] || dma_mapping_error(dev, dma_addr[i]))
+               if (!svm_is_valid_dma_mapping_addr(dev, dma_addr[i]))
                        continue;
                pr_debug("dma unmapping 0x%llx\n", dma_addr[i] >> PAGE_SHIFT);
                dma_unmap_page(dev, dma_addr[i], PAGE_SIZE, dir);
@@ -1165,7 +1171,7 @@ svm_range_map_to_gpu(struct amdgpu_device *adev, struct amdgpu_vm *vm,
        unsigned long last_start;
        int last_domain;
        int r = 0;
-       int64_t i;
+       int64_t i, j;
 
        last_start = prange->start + offset;
 
@@ -1178,7 +1184,11 @@ svm_range_map_to_gpu(struct amdgpu_device *adev, struct amdgpu_vm *vm,
        for (i = offset; i < offset + npages; i++) {
                last_domain = dma_addr[i] & SVM_RANGE_VRAM_DOMAIN;
                dma_addr[i] &= ~SVM_RANGE_VRAM_DOMAIN;
-               if ((prange->start + i) < prange->last &&
+
+               /* Collect all pages in the same address range and memory domain
+                * that can be mapped with a single call to update mapping.
+                */
+               if (i < offset + npages - 1 &&
                    last_domain == (dma_addr[i + 1] & SVM_RANGE_VRAM_DOMAIN))
                        continue;
 
@@ -1201,6 +1211,10 @@ svm_range_map_to_gpu(struct amdgpu_device *adev, struct amdgpu_vm *vm,
                                                NULL, dma_addr,
                                                &vm->last_update,
                                                &table_freed);
+
+               for (j = last_start - prange->start; j <= i; j++)
+                       dma_addr[j] |= last_domain;
+
                if (r) {
                        pr_debug("failed %d to map to gpu 0x%lx\n", r, prange->start);
                        goto out;
index 7dffc04..127667e 100644 (file)
@@ -25,6 +25,8 @@ config DRM_AMD_DC_HDCP
 
 config DRM_AMD_DC_SI
        bool "AMD DC support for Southern Islands ASICs"
+       depends on DRM_AMDGPU_SI
+       depends on DRM_AMD_DC
        default n
        help
          Choose this option to enable new AMD DC support for SI asics
index 9b1fc54..1ea31dc 100644 (file)
@@ -998,6 +998,8 @@ static void mmhub_read_system_context(struct amdgpu_device *adev, struct dc_phy_
        uint32_t agp_base, agp_bot, agp_top;
        PHYSICAL_ADDRESS_LOC page_table_start, page_table_end, page_table_base;
 
+       memset(pa_config, 0, sizeof(*pa_config));
+
        logical_addr_low  = min(adev->gmc.fb_start, adev->gmc.agp_start) >> 18;
        pt_base = amdgpu_gmc_pd_addr(adev->gart.bo);
 
@@ -1113,6 +1115,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
 
        init_data.asic_id.pci_revision_id = adev->pdev->revision;
        init_data.asic_id.hw_internal_rev = adev->external_rev_id;
+       init_data.asic_id.chip_id = adev->pdev->device;
 
        init_data.asic_id.vram_width = adev->gmc.vram_width;
        /* TODO: initialize init_data.asic_id.vram_type here!!!! */
@@ -1717,6 +1720,7 @@ static int dm_late_init(void *handle)
                linear_lut[i] = 0xFFFF * i / 15;
 
        params.set = 0;
+       params.backlight_ramping_override = false;
        params.backlight_ramping_start = 0xCCCC;
        params.backlight_ramping_reduction = 0xCCCCCCCC;
        params.backlight_lut_array_size = 16;
@@ -6024,21 +6028,23 @@ static inline int dm_set_vblank(struct drm_crtc *crtc, bool enable)
                return 0;
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
-       work = kzalloc(sizeof(*work), GFP_ATOMIC);
-       if (!work)
-               return -ENOMEM;
+       if (dm->vblank_control_workqueue) {
+               work = kzalloc(sizeof(*work), GFP_ATOMIC);
+               if (!work)
+                       return -ENOMEM;
 
-       INIT_WORK(&work->work, vblank_control_worker);
-       work->dm = dm;
-       work->acrtc = acrtc;
-       work->enable = enable;
+               INIT_WORK(&work->work, vblank_control_worker);
+               work->dm = dm;
+               work->acrtc = acrtc;
+               work->enable = enable;
 
-       if (acrtc_state->stream) {
-               dc_stream_retain(acrtc_state->stream);
-               work->stream = acrtc_state->stream;
-       }
+               if (acrtc_state->stream) {
+                       dc_stream_retain(acrtc_state->stream);
+                       work->stream = acrtc_state->stream;
+               }
 
-       queue_work(dm->vblank_control_workqueue, &work->work);
+               queue_work(dm->vblank_control_workqueue, &work->work);
+       }
 #endif
 
        return 0;
@@ -6792,14 +6798,15 @@ const struct drm_encoder_helper_funcs amdgpu_dm_encoder_helper_funcs = {
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
 static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state,
-                                           struct dc_state *dc_state)
+                                           struct dc_state *dc_state,
+                                           struct dsc_mst_fairness_vars *vars)
 {
        struct dc_stream_state *stream = NULL;
        struct drm_connector *connector;
        struct drm_connector_state *new_con_state;
        struct amdgpu_dm_connector *aconnector;
        struct dm_connector_state *dm_conn_state;
-       int i, j, clock, bpp;
+       int i, j, clock;
        int vcpi, pbn_div, pbn = 0;
 
        for_each_new_connector_in_state(state, connector, new_con_state, i) {
@@ -6838,9 +6845,15 @@ static int dm_update_mst_vcpi_slots_for_dsc(struct drm_atomic_state *state,
                }
 
                pbn_div = dm_mst_get_pbn_divider(stream->link);
-               bpp = stream->timing.dsc_cfg.bits_per_pixel;
                clock = stream->timing.pix_clk_100hz / 10;
-               pbn = drm_dp_calc_pbn_mode(clock, bpp, true);
+               /* pbn is calculated by compute_mst_dsc_configs_for_state*/
+               for (j = 0; j < dc_state->stream_count; j++) {
+                       if (vars[j].aconnector == aconnector) {
+                               pbn = vars[j].pbn;
+                               break;
+                       }
+               }
+
                vcpi = drm_dp_mst_atomic_enable_dsc(state,
                                                    aconnector->port,
                                                    pbn, pbn_div,
@@ -7519,6 +7532,32 @@ static void amdgpu_dm_connector_add_common_modes(struct drm_encoder *encoder,
        }
 }
 
+static void amdgpu_set_panel_orientation(struct drm_connector *connector)
+{
+       struct drm_encoder *encoder;
+       struct amdgpu_encoder *amdgpu_encoder;
+       const struct drm_display_mode *native_mode;
+
+       if (connector->connector_type != DRM_MODE_CONNECTOR_eDP &&
+           connector->connector_type != DRM_MODE_CONNECTOR_LVDS)
+               return;
+
+       encoder = amdgpu_dm_connector_to_encoder(connector);
+       if (!encoder)
+               return;
+
+       amdgpu_encoder = to_amdgpu_encoder(encoder);
+
+       native_mode = &amdgpu_encoder->native_mode;
+       if (native_mode->hdisplay == 0 || native_mode->vdisplay == 0)
+               return;
+
+       drm_connector_set_panel_orientation_with_quirk(connector,
+                                                      DRM_MODE_PANEL_ORIENTATION_UNKNOWN,
+                                                      native_mode->hdisplay,
+                                                      native_mode->vdisplay);
+}
+
 static void amdgpu_dm_connector_ddc_get_modes(struct drm_connector *connector,
                                              struct edid *edid)
 {
@@ -7547,6 +7586,8 @@ static void amdgpu_dm_connector_ddc_get_modes(struct drm_connector *connector,
                 * restored here.
                 */
                amdgpu_dm_update_freesync_caps(connector, edid);
+
+               amdgpu_set_panel_orientation(connector);
        } else {
                amdgpu_dm_connector->num_modes = 0;
        }
@@ -8058,8 +8099,26 @@ static bool is_content_protection_different(struct drm_connector_state *state,
            state->content_protection == DRM_MODE_CONTENT_PROTECTION_ENABLED)
                state->content_protection = DRM_MODE_CONTENT_PROTECTION_DESIRED;
 
-       /* Check if something is connected/enabled, otherwise we start hdcp but nothing is connected/enabled
-        * hot-plug, headless s3, dpms
+       /* Stream removed and re-enabled
+        *
+        * Can sometimes overlap with the HPD case,
+        * thus set update_hdcp to false to avoid
+        * setting HDCP multiple times.
+        *
+        * Handles:     DESIRED -> DESIRED (Special case)
+        */
+       if (!(old_state->crtc && old_state->crtc->enabled) &&
+               state->crtc && state->crtc->enabled &&
+               connector->state->content_protection == DRM_MODE_CONTENT_PROTECTION_DESIRED) {
+               dm_con_state->update_hdcp = false;
+               return true;
+       }
+
+       /* Hot-plug, headless s3, dpms
+        *
+        * Only start HDCP if the display is connected/enabled.
+        * update_hdcp flag will be set to false until the next
+        * HPD comes in.
         *
         * Handles:     DESIRED -> DESIRED (Special case)
         */
@@ -8648,7 +8707,8 @@ static void amdgpu_dm_commit_planes(struct drm_atomic_state *state,
                 * If PSR or idle optimizations are enabled then flush out
                 * any pending work before hardware programming.
                 */
-               flush_workqueue(dm->vblank_control_workqueue);
+               if (dm->vblank_control_workqueue)
+                       flush_workqueue(dm->vblank_control_workqueue);
 #endif
 
                bundle->stream_update.stream = acrtc_state->stream;
@@ -8983,7 +9043,8 @@ static void amdgpu_dm_atomic_commit_tail(struct drm_atomic_state *state)
                /* if there mode set or reset, disable eDP PSR */
                if (mode_set_reset_required) {
 #if defined(CONFIG_DRM_AMD_DC_DCN)
-                       flush_workqueue(dm->vblank_control_workqueue);
+                       if (dm->vblank_control_workqueue)
+                               flush_workqueue(dm->vblank_control_workqueue);
 #endif
                        amdgpu_dm_psr_disable_all(dm);
                }
@@ -10243,6 +10304,9 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
        int ret, i;
        bool lock_and_validation_needed = false;
        struct dm_crtc_state *dm_old_crtc_state;
+#if defined(CONFIG_DRM_AMD_DC_DCN)
+       struct dsc_mst_fairness_vars vars[MAX_PIPES];
+#endif
 
        trace_amdgpu_dm_atomic_check_begin(state);
 
@@ -10473,10 +10537,10 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
                        goto fail;
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
-               if (!compute_mst_dsc_configs_for_state(state, dm_state->context))
+               if (!compute_mst_dsc_configs_for_state(state, dm_state->context, vars))
                        goto fail;
 
-               ret = dm_update_mst_vcpi_slots_for_dsc(state, dm_state->context);
+               ret = dm_update_mst_vcpi_slots_for_dsc(state, dm_state->context, vars);
                if (ret)
                        goto fail;
 #endif
@@ -10492,7 +10556,8 @@ static int amdgpu_dm_atomic_check(struct drm_device *dev,
                        goto fail;
                status = dc_validate_global_state(dc, dm_state->context, false);
                if (status != DC_OK) {
-                       DC_LOG_WARNING("DC global validation failure: %s (%d)",
+                       drm_dbg_atomic(dev,
+                                      "DC global validation failure: %s (%d)",
                                       dc_status_to_str(status), status);
                        ret = -EINVAL;
                        goto fail;
index 1bcba69..7af0d58 100644 (file)
@@ -518,12 +518,7 @@ struct dsc_mst_fairness_params {
        uint32_t num_slices_h;
        uint32_t num_slices_v;
        uint32_t bpp_overwrite;
-};
-
-struct dsc_mst_fairness_vars {
-       int pbn;
-       bool dsc_enabled;
-       int bpp_x16;
+       struct amdgpu_dm_connector *aconnector;
 };
 
 static int kbps_to_peak_pbn(int kbps)
@@ -750,12 +745,12 @@ static void try_disable_dsc(struct drm_atomic_state *state,
 
 static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state,
                                             struct dc_state *dc_state,
-                                            struct dc_link *dc_link)
+                                            struct dc_link *dc_link,
+                                            struct dsc_mst_fairness_vars *vars)
 {
        int i;
        struct dc_stream_state *stream;
        struct dsc_mst_fairness_params params[MAX_PIPES];
-       struct dsc_mst_fairness_vars vars[MAX_PIPES];
        struct amdgpu_dm_connector *aconnector;
        int count = 0;
        bool debugfs_overwrite = false;
@@ -776,6 +771,7 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state,
                params[count].timing = &stream->timing;
                params[count].sink = stream->sink;
                aconnector = (struct amdgpu_dm_connector *)stream->dm_stream_context;
+               params[count].aconnector = aconnector;
                params[count].port = aconnector->port;
                params[count].clock_force_enable = aconnector->dsc_settings.dsc_force_enable;
                if (params[count].clock_force_enable == DSC_CLK_FORCE_ENABLE)
@@ -798,6 +794,7 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state,
        }
        /* Try no compression */
        for (i = 0; i < count; i++) {
+               vars[i].aconnector = params[i].aconnector;
                vars[i].pbn = kbps_to_peak_pbn(params[i].bw_range.stream_kbps);
                vars[i].dsc_enabled = false;
                vars[i].bpp_x16 = 0;
@@ -851,7 +848,8 @@ static bool compute_mst_dsc_configs_for_link(struct drm_atomic_state *state,
 }
 
 bool compute_mst_dsc_configs_for_state(struct drm_atomic_state *state,
-                                      struct dc_state *dc_state)
+                                      struct dc_state *dc_state,
+                                      struct dsc_mst_fairness_vars *vars)
 {
        int i, j;
        struct dc_stream_state *stream;
@@ -882,7 +880,7 @@ bool compute_mst_dsc_configs_for_state(struct drm_atomic_state *state,
                        return false;
 
                mutex_lock(&aconnector->mst_mgr.lock);
-               if (!compute_mst_dsc_configs_for_link(state, dc_state, stream->link)) {
+               if (!compute_mst_dsc_configs_for_link(state, dc_state, stream->link, vars)) {
                        mutex_unlock(&aconnector->mst_mgr.lock);
                        return false;
                }
index b38bd68..900d3f7 100644 (file)
@@ -39,8 +39,17 @@ void
 dm_dp_create_fake_mst_encoders(struct amdgpu_device *adev);
 
 #if defined(CONFIG_DRM_AMD_DC_DCN)
+
+struct dsc_mst_fairness_vars {
+       int pbn;
+       bool dsc_enabled;
+       int bpp_x16;
+       struct amdgpu_dm_connector *aconnector;
+};
+
 bool compute_mst_dsc_configs_for_state(struct drm_atomic_state *state,
-                                      struct dc_state *dc_state);
+                                      struct dc_state *dc_state,
+                                      struct dsc_mst_fairness_vars *vars);
 #endif
 
 #endif
index c9f47d1..b1bf80d 100644 (file)
@@ -62,7 +62,7 @@ inline void dc_assert_fp_enabled(void)
        depth = *pcpu;
        put_cpu_ptr(&fpu_recursion_depth);
 
-       ASSERT(depth > 1);
+       ASSERT(depth >= 1);
 }
 
 /**
index 8bd7f42..1e44b13 100644 (file)
@@ -2586,13 +2586,21 @@ static struct abm *get_abm_from_stream_res(const struct dc_link *link)
 
 int dc_link_get_backlight_level(const struct dc_link *link)
 {
-
        struct abm *abm = get_abm_from_stream_res(link);
+       struct panel_cntl *panel_cntl = link->panel_cntl;
+       struct dc  *dc = link->ctx->dc;
+       struct dmcu *dmcu = dc->res_pool->dmcu;
+       bool fw_set_brightness = true;
 
-       if (abm == NULL || abm->funcs->get_current_backlight == NULL)
-               return DC_ERROR_UNEXPECTED;
+       if (dmcu)
+               fw_set_brightness = dmcu->funcs->is_dmcu_initialized(dmcu);
 
-       return (int) abm->funcs->get_current_backlight(abm);
+       if (!fw_set_brightness && panel_cntl->funcs->get_current_backlight)
+               return panel_cntl->funcs->get_current_backlight(panel_cntl);
+       else if (abm != NULL && abm->funcs->get_current_backlight != NULL)
+               return (int) abm->funcs->get_current_backlight(abm);
+       else
+               return DC_ERROR_UNEXPECTED;
 }
 
 int dc_link_get_target_backlight_pwm(const struct dc_link *link)
index 330edd6..6d655e1 100644 (file)
@@ -1,4 +1,26 @@
-/* Copyright 2015 Advanced Micro Devices, Inc. */
+/*
+ * Copyright 2015 Advanced Micro Devices, Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ *
+ * Authors: AMD
+ */
 #include "dm_services.h"
 #include "dc.h"
 #include "dc_link_dp.h"
@@ -1284,12 +1306,6 @@ static void override_training_settings(
 {
        uint32_t lane;
 
-       /* Override link settings */
-       if (link->preferred_link_setting.link_rate != LINK_RATE_UNKNOWN)
-               lt_settings->link_settings.link_rate = link->preferred_link_setting.link_rate;
-       if (link->preferred_link_setting.lane_count != LANE_COUNT_UNKNOWN)
-               lt_settings->link_settings.lane_count = link->preferred_link_setting.lane_count;
-
        /* Override link spread */
        if (!link->dp_ss_off && overrides->downspread != NULL)
                lt_settings->link_settings.link_spread = *overrides->downspread ?
@@ -1804,14 +1820,13 @@ bool perform_link_training_with_retries(
                if (panel_mode == DP_PANEL_MODE_EDP) {
                        struct cp_psp *cp_psp = &stream->ctx->cp_psp;
 
-                       if (cp_psp && cp_psp->funcs.enable_assr) {
-                               if (!cp_psp->funcs.enable_assr(cp_psp->handle, link)) {
-                                       /* since eDP implies ASSR on, change panel
-                                        * mode to disable ASSR
-                                        */
-                                       panel_mode = DP_PANEL_MODE_DEFAULT;
-                               }
-                       }
+                       if (cp_psp && cp_psp->funcs.enable_assr)
+                               /* ASSR is bound to fail with unsigned PSP
+                                * verstage used during devlopment phase.
+                                * Report and continue with eDP panel mode to
+                                * perform eDP link training with right settings
+                                */
+                               cp_psp->funcs.enable_assr(cp_psp->handle, link);
                }
 #endif
 
@@ -1840,9 +1855,13 @@ bool perform_link_training_with_retries(
                dp_disable_link_phy(link, signal);
 
                /* Abort link training if failure due to sink being unplugged. */
-               if (status == LINK_TRAINING_ABORT)
-                       break;
-               else if (do_fallback) {
+               if (status == LINK_TRAINING_ABORT) {
+                       enum dc_connection_type type = dc_connection_none;
+
+                       dc_link_detect_sink(link, &type);
+                       if (type == dc_connection_none)
+                               break;
+               } else if (do_fallback) {
                        decide_fallback_link_setting(*link_setting, &current_setting, status);
                        /* Fail link training if reduced link bandwidth no longer meets
                         * stream requirements.
index e14f99b..3c33473 100644 (file)
@@ -42,7 +42,7 @@
 #define DC_LOGGER \
        engine->ctx->logger
 
-#define DC_TRACE_LEVEL_MESSAGE(...) /* do nothing */
+#define DC_TRACE_LEVEL_MESSAGE(...) do { } while (0)
 #define IS_DC_I2CAUX_LOGGING_ENABLED() (false)
 #define LOG_FLAG_Error_I2cAux LOG_ERROR
 #define LOG_FLAG_I2cAux_DceAux LOG_I2C_AUX
@@ -76,7 +76,7 @@ enum {
 #define DEFAULT_AUX_ENGINE_MULT   0
 #define DEFAULT_AUX_ENGINE_LENGTH 69
 
-#define DC_TRACE_LEVEL_MESSAGE(...) /* do nothing */
+#define DC_TRACE_LEVEL_MESSAGE(...) do { } while (0)
 
 static void release_engine(
        struct dce_aux *engine)
index e923392..e857006 100644 (file)
@@ -49,7 +49,6 @@
 static unsigned int dce_get_16_bit_backlight_from_pwm(struct panel_cntl *panel_cntl)
 {
        uint64_t current_backlight;
-       uint32_t round_result;
        uint32_t bl_period, bl_int_count;
        uint32_t bl_pwm, fractional_duty_cycle_en;
        uint32_t bl_period_mask, bl_pwm_mask;
@@ -84,15 +83,6 @@ static unsigned int dce_get_16_bit_backlight_from_pwm(struct panel_cntl *panel_c
        current_backlight = div_u64(current_backlight, bl_period);
        current_backlight = (current_backlight + 1) >> 1;
 
-       current_backlight = (uint64_t)(current_backlight) * bl_period;
-
-       round_result = (uint32_t)(current_backlight & 0xFFFFFFFF);
-
-       round_result = (round_result >> (bl_int_count-1)) & 1;
-
-       current_backlight >>= bl_int_count;
-       current_backlight += round_result;
-
        return (uint32_t)(current_backlight);
 }
 
index d8b2261..c337588 100644 (file)
@@ -118,6 +118,7 @@ struct dcn10_link_enc_registers {
        uint32_t RDPCSTX_PHY_CNTL4;
        uint32_t RDPCSTX_PHY_CNTL5;
        uint32_t RDPCSTX_PHY_CNTL6;
+       uint32_t RDPCSPIPE_PHY_CNTL6;
        uint32_t RDPCSTX_PHY_CNTL7;
        uint32_t RDPCSTX_PHY_CNTL8;
        uint32_t RDPCSTX_PHY_CNTL9;
index 90127c1..b089244 100644 (file)
@@ -37,6 +37,7 @@
 
 #include "link_enc_cfg.h"
 #include "dc_dmub_srv.h"
+#include "dal_asic_id.h"
 
 #define CTX \
        enc10->base.ctx
 #define AUX_REG_WRITE(reg_name, val) \
                        dm_write_reg(CTX, AUX_REG(reg_name), val)
 
+#ifndef MIN
+#define MIN(X, Y) ((X) < (Y) ? (X) : (Y))
+#endif
+
 void dcn31_link_encoder_set_dio_phy_mux(
        struct link_encoder *enc,
        enum encoder_type_select sel,
@@ -215,8 +220,8 @@ static const struct link_encoder_funcs dcn31_link_enc_funcs = {
        .fec_is_active = enc2_fec_is_active,
        .get_dig_frontend = dcn10_get_dig_frontend,
        .get_dig_mode = dcn10_get_dig_mode,
-       .is_in_alt_mode = dcn20_link_encoder_is_in_alt_mode,
-       .get_max_link_cap = dcn20_link_encoder_get_max_link_cap,
+       .is_in_alt_mode = dcn31_link_encoder_is_in_alt_mode,
+       .get_max_link_cap = dcn31_link_encoder_get_max_link_cap,
        .set_dio_phy_mux = dcn31_link_encoder_set_dio_phy_mux,
 };
 
@@ -404,3 +409,60 @@ void dcn31_link_encoder_disable_output(
        }
 }
 
+bool dcn31_link_encoder_is_in_alt_mode(struct link_encoder *enc)
+{
+       struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc);
+       uint32_t dp_alt_mode_disable;
+       bool is_usb_c_alt_mode = false;
+
+       if (enc->features.flags.bits.DP_IS_USB_C) {
+               if (enc->ctx->asic_id.hw_internal_rev != YELLOW_CARP_B0) {
+                       // [Note] no need to check hw_internal_rev once phy mux selection is ready
+                       REG_GET(RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE, &dp_alt_mode_disable);
+               } else {
+               /*
+                * B0 phys use a new set of registers to check whether alt mode is disabled.
+                * if value == 1 alt mode is disabled, otherwise it is enabled.
+                */
+                       if ((enc10->base.transmitter == TRANSMITTER_UNIPHY_A)
+                                       || (enc10->base.transmitter == TRANSMITTER_UNIPHY_B)
+                                       || (enc10->base.transmitter == TRANSMITTER_UNIPHY_E)) {
+                               REG_GET(RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE, &dp_alt_mode_disable);
+                       } else {
+                       // [Note] need to change TRANSMITTER_UNIPHY_C/D to F/G once phy mux selection is ready
+                               REG_GET(RDPCSPIPE_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE, &dp_alt_mode_disable);
+                       }
+               }
+
+               is_usb_c_alt_mode = (dp_alt_mode_disable == 0);
+       }
+
+       return is_usb_c_alt_mode;
+}
+
+void dcn31_link_encoder_get_max_link_cap(struct link_encoder *enc,
+                                                                                struct dc_link_settings *link_settings)
+{
+       struct dcn10_link_encoder *enc10 = TO_DCN10_LINK_ENC(enc);
+       uint32_t is_in_usb_c_dp4_mode = 0;
+
+       dcn10_link_encoder_get_max_link_cap(enc, link_settings);
+
+       /* in usb c dp2 mode, max lane count is 2 */
+       if (enc->funcs->is_in_alt_mode && enc->funcs->is_in_alt_mode(enc)) {
+               if (enc->ctx->asic_id.hw_internal_rev != YELLOW_CARP_B0) {
+                       // [Note] no need to check hw_internal_rev once phy mux selection is ready
+                       REG_GET(RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DP4, &is_in_usb_c_dp4_mode);
+               } else {
+                       if ((enc10->base.transmitter == TRANSMITTER_UNIPHY_A)
+                                       || (enc10->base.transmitter == TRANSMITTER_UNIPHY_B)
+                                       || (enc10->base.transmitter == TRANSMITTER_UNIPHY_E)) {
+                               REG_GET(RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DP4, &is_in_usb_c_dp4_mode);
+                       } else {
+                               REG_GET(RDPCSPIPE_PHY_CNTL6, RDPCS_PHY_DPALT_DP4, &is_in_usb_c_dp4_mode);
+                       }
+               }
+               if (!is_in_usb_c_dp4_mode)
+                       link_settings->lane_count = MIN(LANE_COUNT_TWO, link_settings->lane_count);
+       }
+}
index 32d1463..3454f1e 100644 (file)
@@ -69,6 +69,7 @@
        SRI(RDPCSTX_PHY_CNTL4, RDPCSTX, id), \
        SRI(RDPCSTX_PHY_CNTL5, RDPCSTX, id), \
        SRI(RDPCSTX_PHY_CNTL6, RDPCSTX, id), \
+       SRI(RDPCSPIPE_PHY_CNTL6, RDPCSPIPE, id), \
        SRI(RDPCSTX_PHY_CNTL7, RDPCSTX, id), \
        SRI(RDPCSTX_PHY_CNTL8, RDPCSTX, id), \
        SRI(RDPCSTX_PHY_CNTL9, RDPCSTX, id), \
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL6, RDPCS_PHY_DP_TX2_MPLL_EN, mask_sh),\
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL6, RDPCS_PHY_DP_TX3_MPLL_EN, mask_sh),\
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DP4, mask_sh),\
-       LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE, mask_sh),\
+       LE_SF(RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6, RDPCS_PHY_DPALT_DP4, mask_sh),\
+       LE_SF(RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE, mask_sh),\
+       LE_SF(RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6, RDPCS_PHY_DPALT_DISABLE_ACK, mask_sh),\
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL7, RDPCS_PHY_DP_MPLLB_FRACN_QUOT, mask_sh),\
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL7, RDPCS_PHY_DP_MPLLB_FRACN_DEN, mask_sh),\
        LE_SF(RDPCSTX0_RDPCSTX_PHY_CNTL8, RDPCS_PHY_DP_MPLLB_SSC_PEAK, mask_sh),\
@@ -243,4 +246,13 @@ void dcn31_link_encoder_disable_output(
        struct link_encoder *enc,
        enum signal_type signal);
 
+/*
+ * Check whether USB-C DP Alt mode is disabled
+ */
+bool dcn31_link_encoder_is_in_alt_mode(
+       struct link_encoder *enc);
+
+void dcn31_link_encoder_get_max_link_cap(struct link_encoder *enc,
+       struct dc_link_settings *link_settings);
+
 #endif /* __DC_LINK_ENCODER__DCN31_H__ */
index a7702d3..0006bba 100644 (file)
@@ -928,7 +928,7 @@ static const struct dc_debug_options debug_defaults_drv = {
        .disable_dcc = DCC_ENABLE,
        .vsr_support = true,
        .performance_trace = false,
-       .max_downscale_src_width = 7680,/*upto 8K*/
+       .max_downscale_src_width = 3840,/*upto 4K*/
        .disable_pplib_wm_range = false,
        .scl_reset_length10 = true,
        .sanity_checks = false,
@@ -1284,6 +1284,12 @@ static struct stream_encoder *dcn31_stream_encoder_create(
        if (!enc1 || !vpg || !afmt)
                return NULL;
 
+       if (ctx->asic_id.chip_family == FAMILY_YELLOW_CARP &&
+                       ctx->asic_id.hw_internal_rev == YELLOW_CARP_B0) {
+               if ((eng_id == ENGINE_ID_DIGC) || (eng_id == ENGINE_ID_DIGD))
+                       eng_id = eng_id + 3; // For B0 only. C->F, D->G.
+       }
+
        dcn30_dio_stream_encoder_construct(enc1, ctx, ctx->dc_bios,
                                        eng_id, vpg, afmt,
                                        &stream_enc_regs[eng_id],
index 381c17c..5adc471 100644 (file)
@@ -227,7 +227,7 @@ enum {
 #define FAMILY_YELLOW_CARP                     146
 
 #define YELLOW_CARP_A0 0x01
-#define YELLOW_CARP_B0 0x02            // TODO: DCN31 - update with correct B0 ID
+#define YELLOW_CARP_B0 0x1A
 #define YELLOW_CARP_UNKNOWN 0xFF
 
 #ifndef ASICREV_IS_YELLOW_CARP
index 92caf84..01a5655 100644 (file)
 #define ixDPCSSYS_CR4_RAWLANEX_DIG_PCS_XF_RX_OVRD_OUT_2                                                0xe0c7
 #define ixDPCSSYS_CR4_RAWLANEX_DIG_PCS_XF_TX_OVRD_IN_2                                                 0xe0c8
 
+//RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DP4__SHIFT                                            0x10
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE__SHIFT                                        0x11
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_ACK__SHIFT                                    0x12
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DP4_MASK                                              0x00010000L
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_MASK                                          0x00020000L
+#define RDPCSPIPE0_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_ACK_MASK                                      0x00040000L
+
+//RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DP4__SHIFT                                            0x10
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE__SHIFT                                        0x11
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_ACK__SHIFT                                    0x12
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DP4_MASK                                              0x00010000L
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_MASK                                          0x00020000L
+#define RDPCSPIPE1_RDPCSPIPE_PHY_CNTL6__RDPCS_PHY_DPALT_DISABLE_ACK_MASK                                      0x00040000L
+
+//[Note] Hack. RDPCSPIPE only has 2 instances.
+#define regRDPCSPIPE0_RDPCSPIPE_PHY_CNTL6                                                              0x2d73
+#define regRDPCSPIPE0_RDPCSPIPE_PHY_CNTL6_BASE_IDX                                                     2
+#define regRDPCSPIPE1_RDPCSPIPE_PHY_CNTL6                                                              0x2e4b
+#define regRDPCSPIPE1_RDPCSPIPE_PHY_CNTL6_BASE_IDX                                                     2
+#define regRDPCSPIPE2_RDPCSPIPE_PHY_CNTL6                                                              0x2d73
+#define regRDPCSPIPE2_RDPCSPIPE_PHY_CNTL6_BASE_IDX                                                     2
+#define regRDPCSPIPE3_RDPCSPIPE_PHY_CNTL6                                                              0x2e4b
+#define regRDPCSPIPE3_RDPCSPIPE_PHY_CNTL6_BASE_IDX                                                     2
+#define regRDPCSPIPE4_RDPCSPIPE_PHY_CNTL6                                                              0x2d73
+#define regRDPCSPIPE4_RDPCSPIPE_PHY_CNTL6_BASE_IDX                                                     2
 
 #endif
index 8a08ecc..4884a4e 100644 (file)
 #define TABLE_PMSTATUSLOG        3 // Called by Tools for Agm logging
 #define TABLE_DPMCLOCKS          4 // Called by Driver; defined here, but not used, for backward compatible
 #define TABLE_MOMENTARY_PM       5 // Called by Tools; defined here, but not used, for backward compatible
-#define TABLE_COUNT              6
+#define TABLE_SMU_METRICS        6 // Called by Driver
+#define TABLE_COUNT              7
 
-#define NUM_DSPCLK_LEVELS              8
-#define NUM_SOCCLK_DPM_LEVELS  8
-#define NUM_DCEFCLK_DPM_LEVELS 4
-#define NUM_FCLK_DPM_LEVELS            4
-#define NUM_MEMCLK_DPM_LEVELS  4
+typedef struct SmuMetricsTable_t {
+       //CPU status
+       uint16_t CoreFrequency[6];              //[MHz]
+       uint32_t CorePower[6];                  //[mW]
+       uint16_t CoreTemperature[6];            //[centi-Celsius]
+       uint16_t L3Frequency[2];                //[MHz]
+       uint16_t L3Temperature[2];              //[centi-Celsius]
+       uint16_t C0Residency[6];                //Percentage
 
-#define NUMBER_OF_PSTATES              8
-#define NUMBER_OF_CORES                        8
+       // GFX status
+       uint16_t GfxclkFrequency;               //[MHz]
+       uint16_t GfxTemperature;                //[centi-Celsius]
 
-typedef enum {
-       S3_TYPE_ENTRY,
-       S5_TYPE_ENTRY,
-} Sleep_Type_e;
+       // SOC IP info
+       uint16_t SocclkFrequency;               //[MHz]
+       uint16_t VclkFrequency;                 //[MHz]
+       uint16_t DclkFrequency;                 //[MHz]
+       uint16_t MemclkFrequency;               //[MHz]
 
-typedef enum {
-       GFX_OFF = 0,
-       GFX_ON  = 1,
-} GFX_Mode_e;
+       // power, VF info for CPU/GFX telemetry rails, and then socket power total
+       uint32_t Voltage[2];                    //[mV] indices: VDDCR_VDD, VDDCR_GFX
+       uint32_t Current[2];                    //[mA] indices: VDDCR_VDD, VDDCR_GFX
+       uint32_t Power[2];                      //[mW] indices: VDDCR_VDD, VDDCR_GFX
+       uint32_t CurrentSocketPower;            //[mW]
 
-typedef enum {
-       CPU_P0 = 0,
-       CPU_P1,
-       CPU_P2,
-       CPU_P3,
-       CPU_P4,
-       CPU_P5,
-       CPU_P6,
-       CPU_P7
-} CPU_PState_e;
+       uint16_t SocTemperature;                //[centi-Celsius]
+       uint16_t EdgeTemperature;
+       uint16_t ThrottlerStatus;
+       uint16_t Spare;
 
-typedef enum {
-       CPU_CORE0 = 0,
-       CPU_CORE1,
-       CPU_CORE2,
-       CPU_CORE3,
-       CPU_CORE4,
-       CPU_CORE5,
-       CPU_CORE6,
-       CPU_CORE7
-} CORE_ID_e;
+} SmuMetricsTable_t;
 
-typedef enum {
-       DF_DPM0 = 0,
-       DF_DPM1,
-       DF_DPM2,
-       DF_DPM3,
-       DF_PState_Count
-} DF_PState_e;
-
-typedef enum {
-       GFX_DPM0 = 0,
-       GFX_DPM1,
-       GFX_DPM2,
-       GFX_DPM3,
-       GFX_PState_Count
-} GFX_PState_e;
+typedef struct SmuMetrics_t {
+       SmuMetricsTable_t Current;
+       SmuMetricsTable_t Average;
+       uint32_t SampleStartTime;
+       uint32_t SampleStopTime;
+       uint32_t Accnt;
+} SmuMetrics_t;
 
 #endif
index 6f1b1b5..18b862a 100644 (file)
        __SMU_DUMMY_MAP(SetUclkDpmMode),                \
        __SMU_DUMMY_MAP(LightSBR),                      \
        __SMU_DUMMY_MAP(GfxDriverResetRecovery),        \
-       __SMU_DUMMY_MAP(BoardPowerCalibration),
+       __SMU_DUMMY_MAP(BoardPowerCalibration),   \
+       __SMU_DUMMY_MAP(RequestGfxclk),           \
+       __SMU_DUMMY_MAP(ForceGfxVid),             \
+       __SMU_DUMMY_MAP(UnforceGfxVid),
 
 #undef __SMU_DUMMY_MAP
 #define __SMU_DUMMY_MAP(type)  SMU_MSG_##type
index 6e60887..909a86a 100644 (file)
 #define PPSMC_MSG_SetDriverTableVMID                    0x34
 #define PPSMC_MSG_SetSoftMinCclk                        0x35
 #define PPSMC_MSG_SetSoftMaxCclk                        0x36
-#define PPSMC_Message_Count                             0x37
+#define PPSMC_MSG_GetGfxFrequency                       0x37
+#define PPSMC_MSG_GetGfxVid                             0x38
+#define PPSMC_MSG_ForceGfxFreq                          0x39
+#define PPSMC_MSG_UnForceGfxFreq                        0x3A
+#define PPSMC_MSG_ForceGfxVid                           0x3B
+#define PPSMC_MSG_UnforceGfxVid                         0x3C
+#define PPSMC_MSG_GetEnabledSmuFeatures                 0x3D
+#define PPSMC_Message_Count                             0x3E
 
 #endif
index bdbbeb9..81f82aa 100644 (file)
@@ -6867,6 +6867,8 @@ static int si_dpm_enable(struct amdgpu_device *adev)
        si_enable_auto_throttle_source(adev, AMDGPU_DPM_AUTO_THROTTLE_SRC_THERMAL, true);
        si_thermal_start_thermal_controller(adev);
 
+       ni_update_current_ps(adev, boot_ps);
+
        return 0;
 }
 
index 3ab1ce4..04863a7 100644 (file)
@@ -1404,7 +1404,7 @@ static int smu_disable_dpms(struct smu_context *smu)
         */
        if (smu->uploading_custom_pp_table &&
            (adev->asic_type >= CHIP_NAVI10) &&
-           (adev->asic_type <= CHIP_DIMGREY_CAVEFISH))
+           (adev->asic_type <= CHIP_BEIGE_GOBY))
                return smu_disable_all_features_with_exception(smu,
                                                               true,
                                                               SMU_FEATURE_COUNT);
index e343cc2..082f018 100644 (file)
@@ -771,8 +771,12 @@ static int arcturus_print_clk_levels(struct smu_context *smu,
        struct smu_11_0_dpm_context *dpm_context = NULL;
        uint32_t gen_speed, lane_width;
 
-       if (amdgpu_ras_intr_triggered())
-               return sysfs_emit(buf, "unavailable\n");
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
+       if (amdgpu_ras_intr_triggered()) {
+               size += sysfs_emit_at(buf, size, "unavailable\n");
+               return size;
+       }
 
        dpm_context = smu_dpm->dpm_context;
 
index b05f954..3d4c65b 100644 (file)
 #undef pr_info
 #undef pr_debug
 
+/* unit: MHz */
+#define CYAN_SKILLFISH_SCLK_MIN                        1000
+#define CYAN_SKILLFISH_SCLK_MAX                        2000
+#define CYAN_SKILLFISH_SCLK_DEFAULT                    1800
+
+/* unit: mV */
+#define CYAN_SKILLFISH_VDDC_MIN                        700
+#define CYAN_SKILLFISH_VDDC_MAX                        1129
+#define CYAN_SKILLFISH_VDDC_MAGIC                      5118 // 0x13fe
+
+static struct gfx_user_settings {
+       uint32_t sclk;
+       uint32_t vddc;
+} cyan_skillfish_user_settings;
+
+#define FEATURE_MASK(feature) (1ULL << feature)
+#define SMC_DPM_FEATURE ( \
+       FEATURE_MASK(FEATURE_FCLK_DPM_BIT)      |       \
+       FEATURE_MASK(FEATURE_SOC_DPM_BIT)       |       \
+       FEATURE_MASK(FEATURE_GFX_DPM_BIT))
+
 static struct cmn2asic_msg_mapping cyan_skillfish_message_map[SMU_MSG_MAX_COUNT] = {
        MSG_MAP(TestMessage,                    PPSMC_MSG_TestMessage,                  0),
        MSG_MAP(GetSmuVersion,                  PPSMC_MSG_GetSmuVersion,                0),
@@ -52,14 +73,473 @@ static struct cmn2asic_msg_mapping cyan_skillfish_message_map[SMU_MSG_MAX_COUNT]
        MSG_MAP(SetDriverDramAddrLow,           PPSMC_MSG_SetDriverTableDramAddrLow,    0),
        MSG_MAP(TransferTableSmu2Dram,          PPSMC_MSG_TransferTableSmu2Dram,        0),
        MSG_MAP(TransferTableDram2Smu,          PPSMC_MSG_TransferTableDram2Smu,        0),
+       MSG_MAP(GetEnabledSmuFeatures,          PPSMC_MSG_GetEnabledSmuFeatures,        0),
+       MSG_MAP(RequestGfxclk,                  PPSMC_MSG_RequestGfxclk,                0),
+       MSG_MAP(ForceGfxVid,                    PPSMC_MSG_ForceGfxVid,                  0),
+       MSG_MAP(UnforceGfxVid,                  PPSMC_MSG_UnforceGfxVid,                0),
+};
+
+static struct cmn2asic_mapping cyan_skillfish_table_map[SMU_TABLE_COUNT] = {
+       TAB_MAP_VALID(SMU_METRICS),
 };
 
+static int cyan_skillfish_tables_init(struct smu_context *smu)
+{
+       struct smu_table_context *smu_table = &smu->smu_table;
+       struct smu_table *tables = smu_table->tables;
+
+       SMU_TABLE_INIT(tables, SMU_TABLE_SMU_METRICS,
+                               sizeof(SmuMetrics_t),
+                               PAGE_SIZE,
+                               AMDGPU_GEM_DOMAIN_VRAM);
+
+       smu_table->metrics_table = kzalloc(sizeof(SmuMetrics_t), GFP_KERNEL);
+       if (!smu_table->metrics_table)
+               goto err0_out;
+
+       smu_table->gpu_metrics_table_size = sizeof(struct gpu_metrics_v2_2);
+       smu_table->gpu_metrics_table = kzalloc(smu_table->gpu_metrics_table_size, GFP_KERNEL);
+       if (!smu_table->gpu_metrics_table)
+               goto err1_out;
+
+       smu_table->metrics_time = 0;
+
+       return 0;
+
+err1_out:
+       smu_table->gpu_metrics_table_size = 0;
+       kfree(smu_table->metrics_table);
+err0_out:
+       return -ENOMEM;
+}
+
+static int cyan_skillfish_init_smc_tables(struct smu_context *smu)
+{
+       int ret = 0;
+
+       ret = cyan_skillfish_tables_init(smu);
+       if (ret)
+               return ret;
+
+       return smu_v11_0_init_smc_tables(smu);
+}
+
+static int cyan_skillfish_finit_smc_tables(struct smu_context *smu)
+{
+       struct smu_table_context *smu_table = &smu->smu_table;
+
+       kfree(smu_table->metrics_table);
+       smu_table->metrics_table = NULL;
+
+       kfree(smu_table->gpu_metrics_table);
+       smu_table->gpu_metrics_table = NULL;
+       smu_table->gpu_metrics_table_size = 0;
+
+       smu_table->metrics_time = 0;
+
+       return 0;
+}
+
+static int
+cyan_skillfish_get_smu_metrics_data(struct smu_context *smu,
+                                       MetricsMember_t member,
+                                       uint32_t *value)
+{
+       struct smu_table_context *smu_table = &smu->smu_table;
+       SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
+       int ret = 0;
+
+       mutex_lock(&smu->metrics_lock);
+
+       ret = smu_cmn_get_metrics_table_locked(smu, NULL, false);
+       if (ret) {
+               mutex_unlock(&smu->metrics_lock);
+               return ret;
+       }
+
+       switch (member) {
+       case METRICS_CURR_GFXCLK:
+               *value = metrics->Current.GfxclkFrequency;
+               break;
+       case METRICS_CURR_SOCCLK:
+               *value = metrics->Current.SocclkFrequency;
+               break;
+       case METRICS_CURR_VCLK:
+               *value = metrics->Current.VclkFrequency;
+               break;
+       case METRICS_CURR_DCLK:
+               *value = metrics->Current.DclkFrequency;
+               break;
+       case METRICS_CURR_UCLK:
+               *value = metrics->Current.MemclkFrequency;
+               break;
+       case METRICS_AVERAGE_SOCKETPOWER:
+               *value = (metrics->Current.CurrentSocketPower << 8) /
+                               1000;
+               break;
+       case METRICS_TEMPERATURE_EDGE:
+               *value = metrics->Current.GfxTemperature / 100 *
+                               SMU_TEMPERATURE_UNITS_PER_CENTIGRADES;
+               break;
+       case METRICS_TEMPERATURE_HOTSPOT:
+               *value = metrics->Current.SocTemperature / 100 *
+                               SMU_TEMPERATURE_UNITS_PER_CENTIGRADES;
+               break;
+       case METRICS_VOLTAGE_VDDSOC:
+               *value = metrics->Current.Voltage[0];
+               break;
+       case METRICS_VOLTAGE_VDDGFX:
+               *value = metrics->Current.Voltage[1];
+               break;
+       case METRICS_THROTTLER_STATUS:
+               *value = metrics->Current.ThrottlerStatus;
+               break;
+       default:
+               *value = UINT_MAX;
+               break;
+       }
+
+       mutex_unlock(&smu->metrics_lock);
+
+       return ret;
+}
+
+static int cyan_skillfish_read_sensor(struct smu_context *smu,
+                                       enum amd_pp_sensors sensor,
+                                       void *data,
+                                       uint32_t *size)
+{
+       int ret = 0;
+
+       if (!data || !size)
+               return -EINVAL;
+
+       mutex_lock(&smu->sensor_lock);
+
+       switch (sensor) {
+       case AMDGPU_PP_SENSOR_GFX_SCLK:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_CURR_GFXCLK,
+                                                  (uint32_t *)data);
+               *(uint32_t *)data *= 100;
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_GFX_MCLK:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_CURR_UCLK,
+                                                  (uint32_t *)data);
+               *(uint32_t *)data *= 100;
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_GPU_POWER:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_AVERAGE_SOCKETPOWER,
+                                                  (uint32_t *)data);
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_HOTSPOT_TEMP:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_TEMPERATURE_HOTSPOT,
+                                                  (uint32_t *)data);
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_EDGE_TEMP:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_TEMPERATURE_EDGE,
+                                                  (uint32_t *)data);
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_VDDNB:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_VOLTAGE_VDDSOC,
+                                                  (uint32_t *)data);
+               *size = 4;
+               break;
+       case AMDGPU_PP_SENSOR_VDDGFX:
+               ret = cyan_skillfish_get_smu_metrics_data(smu,
+                                                  METRICS_VOLTAGE_VDDGFX,
+                                                  (uint32_t *)data);
+               *size = 4;
+               break;
+       default:
+               ret = -EOPNOTSUPP;
+               break;
+       }
+
+       mutex_unlock(&smu->sensor_lock);
+
+       return ret;
+}
+
+static int cyan_skillfish_get_current_clk_freq(struct smu_context *smu,
+                                               enum smu_clk_type clk_type,
+                                               uint32_t *value)
+{
+       MetricsMember_t member_type;
+
+       switch (clk_type) {
+       case SMU_GFXCLK:
+       case SMU_SCLK:
+               member_type = METRICS_CURR_GFXCLK;
+               break;
+       case SMU_FCLK:
+       case SMU_MCLK:
+               member_type = METRICS_CURR_UCLK;
+               break;
+       case SMU_SOCCLK:
+               member_type = METRICS_CURR_SOCCLK;
+               break;
+       case SMU_VCLK:
+               member_type = METRICS_CURR_VCLK;
+               break;
+       case SMU_DCLK:
+               member_type = METRICS_CURR_DCLK;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return cyan_skillfish_get_smu_metrics_data(smu, member_type, value);
+}
+
+static int cyan_skillfish_print_clk_levels(struct smu_context *smu,
+                                       enum smu_clk_type clk_type,
+                                       char *buf)
+{
+       int ret = 0, size = 0;
+       uint32_t cur_value = 0;
+
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
+       switch (clk_type) {
+       case SMU_OD_SCLK:
+               ret  = cyan_skillfish_get_smu_metrics_data(smu, METRICS_CURR_GFXCLK, &cur_value);
+               if (ret)
+                       return ret;
+               size += sysfs_emit_at(buf, size,"%s:\n", "OD_SCLK");
+               size += sysfs_emit_at(buf, size, "0: %uMhz *\n", cur_value);
+               break;
+       case SMU_OD_VDDC_CURVE:
+               ret  = cyan_skillfish_get_smu_metrics_data(smu, METRICS_VOLTAGE_VDDGFX, &cur_value);
+               if (ret)
+                       return ret;
+               size += sysfs_emit_at(buf, size,"%s:\n", "OD_VDDC");
+               size += sysfs_emit_at(buf, size, "0: %umV *\n", cur_value);
+               break;
+       case SMU_OD_RANGE:
+               size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
+               size += sysfs_emit_at(buf, size, "SCLK: %7uMhz %10uMhz\n",
+                                               CYAN_SKILLFISH_SCLK_MIN, CYAN_SKILLFISH_SCLK_MAX);
+               size += sysfs_emit_at(buf, size, "VDDC: %7umV  %10umV\n",
+                                               CYAN_SKILLFISH_VDDC_MIN, CYAN_SKILLFISH_VDDC_MAX);
+               break;
+       case SMU_GFXCLK:
+       case SMU_SCLK:
+       case SMU_FCLK:
+       case SMU_MCLK:
+       case SMU_SOCCLK:
+       case SMU_VCLK:
+       case SMU_DCLK:
+               ret = cyan_skillfish_get_current_clk_freq(smu, clk_type, &cur_value);
+               if (ret)
+                       return ret;
+               size += sysfs_emit_at(buf, size, "0: %uMhz *\n", cur_value);
+               break;
+       default:
+               dev_warn(smu->adev->dev, "Unsupported clock type\n");
+               return ret;
+       }
+
+       return size;
+}
+
+static bool cyan_skillfish_is_dpm_running(struct smu_context *smu)
+{
+       struct amdgpu_device *adev = smu->adev;
+       int ret = 0;
+       uint32_t feature_mask[2];
+       uint64_t feature_enabled;
+
+       /* we need to re-init after suspend so return false */
+       if (adev->in_suspend)
+               return false;
+
+       ret = smu_cmn_get_enabled_32_bits_mask(smu, feature_mask, 2);
+
+       if (ret)
+               return false;
+
+       feature_enabled = (uint64_t)feature_mask[0] |
+                               ((uint64_t)feature_mask[1] << 32);
+
+       return !!(feature_enabled & SMC_DPM_FEATURE);
+}
+
+static ssize_t cyan_skillfish_get_gpu_metrics(struct smu_context *smu,
+                                               void **table)
+{
+       struct smu_table_context *smu_table = &smu->smu_table;
+       struct gpu_metrics_v2_2 *gpu_metrics =
+               (struct gpu_metrics_v2_2 *)smu_table->gpu_metrics_table;
+       SmuMetrics_t metrics;
+       int i, ret = 0;
+
+       ret = smu_cmn_get_metrics_table(smu, &metrics, true);
+       if (ret)
+               return ret;
+
+       smu_cmn_init_soft_gpu_metrics(gpu_metrics, 2, 2);
+
+       gpu_metrics->temperature_gfx = metrics.Current.GfxTemperature;
+       gpu_metrics->temperature_soc = metrics.Current.SocTemperature;
+
+       gpu_metrics->average_socket_power = metrics.Current.CurrentSocketPower;
+       gpu_metrics->average_soc_power = metrics.Current.Power[0];
+       gpu_metrics->average_gfx_power = metrics.Current.Power[1];
+
+       gpu_metrics->average_gfxclk_frequency = metrics.Average.GfxclkFrequency;
+       gpu_metrics->average_socclk_frequency = metrics.Average.SocclkFrequency;
+       gpu_metrics->average_uclk_frequency = metrics.Average.MemclkFrequency;
+       gpu_metrics->average_fclk_frequency = metrics.Average.MemclkFrequency;
+       gpu_metrics->average_vclk_frequency = metrics.Average.VclkFrequency;
+       gpu_metrics->average_dclk_frequency = metrics.Average.DclkFrequency;
+
+       gpu_metrics->current_gfxclk = metrics.Current.GfxclkFrequency;
+       gpu_metrics->current_socclk = metrics.Current.SocclkFrequency;
+       gpu_metrics->current_uclk = metrics.Current.MemclkFrequency;
+       gpu_metrics->current_fclk = metrics.Current.MemclkFrequency;
+       gpu_metrics->current_vclk = metrics.Current.VclkFrequency;
+       gpu_metrics->current_dclk = metrics.Current.DclkFrequency;
+
+       for (i = 0; i < 6; i++) {
+               gpu_metrics->temperature_core[i] = metrics.Current.CoreTemperature[i];
+               gpu_metrics->average_core_power[i] = metrics.Average.CorePower[i];
+               gpu_metrics->current_coreclk[i] = metrics.Current.CoreFrequency[i];
+       }
+
+       for (i = 0; i < 2; i++) {
+               gpu_metrics->temperature_l3[i] = metrics.Current.L3Temperature[i];
+               gpu_metrics->current_l3clk[i] = metrics.Current.L3Frequency[i];
+       }
+
+       gpu_metrics->throttle_status = metrics.Current.ThrottlerStatus;
+       gpu_metrics->system_clock_counter = ktime_get_boottime_ns();
+
+       *table = (void *)gpu_metrics;
+
+       return sizeof(struct gpu_metrics_v2_2);
+}
+
+static int cyan_skillfish_od_edit_dpm_table(struct smu_context *smu,
+                                       enum PP_OD_DPM_TABLE_COMMAND type,
+                                       long input[], uint32_t size)
+{
+       int ret = 0;
+       uint32_t vid;
+
+       switch (type) {
+       case PP_OD_EDIT_VDDC_CURVE:
+               if (size != 3 || input[0] != 0) {
+                       dev_err(smu->adev->dev, "Invalid parameter!\n");
+                       return -EINVAL;
+               }
+
+               if (input[1] <= CYAN_SKILLFISH_SCLK_MIN ||
+                       input[1] > CYAN_SKILLFISH_SCLK_MAX) {
+                       dev_err(smu->adev->dev, "Invalid sclk! Valid sclk range: %uMHz - %uMhz\n",
+                                       CYAN_SKILLFISH_SCLK_MIN, CYAN_SKILLFISH_SCLK_MAX);
+                       return -EINVAL;
+               }
+
+               if (input[2] <= CYAN_SKILLFISH_VDDC_MIN ||
+                       input[2] > CYAN_SKILLFISH_VDDC_MAX) {
+                       dev_err(smu->adev->dev, "Invalid vddc! Valid vddc range: %umV - %umV\n",
+                                       CYAN_SKILLFISH_VDDC_MIN, CYAN_SKILLFISH_VDDC_MAX);
+                       return -EINVAL;
+               }
+
+               cyan_skillfish_user_settings.sclk = input[1];
+               cyan_skillfish_user_settings.vddc = input[2];
+
+               break;
+       case PP_OD_RESTORE_DEFAULT_TABLE:
+               if (size != 0) {
+                       dev_err(smu->adev->dev, "Invalid parameter!\n");
+                       return -EINVAL;
+               }
+
+               cyan_skillfish_user_settings.sclk = CYAN_SKILLFISH_SCLK_DEFAULT;
+               cyan_skillfish_user_settings.vddc = CYAN_SKILLFISH_VDDC_MAGIC;
+
+               break;
+       case PP_OD_COMMIT_DPM_TABLE:
+               if (size != 0) {
+                       dev_err(smu->adev->dev, "Invalid parameter!\n");
+                       return -EINVAL;
+               }
+
+               if (cyan_skillfish_user_settings.sclk < CYAN_SKILLFISH_SCLK_MIN ||
+                   cyan_skillfish_user_settings.sclk > CYAN_SKILLFISH_SCLK_MAX) {
+                       dev_err(smu->adev->dev, "Invalid sclk! Valid sclk range: %uMHz - %uMhz\n",
+                                       CYAN_SKILLFISH_SCLK_MIN, CYAN_SKILLFISH_SCLK_MAX);
+                       return -EINVAL;
+               }
+
+               if ((cyan_skillfish_user_settings.vddc != CYAN_SKILLFISH_VDDC_MAGIC) &&
+                       (cyan_skillfish_user_settings.vddc < CYAN_SKILLFISH_VDDC_MIN ||
+                       cyan_skillfish_user_settings.vddc > CYAN_SKILLFISH_VDDC_MAX)) {
+                       dev_err(smu->adev->dev, "Invalid vddc! Valid vddc range: %umV - %umV\n",
+                                       CYAN_SKILLFISH_VDDC_MIN, CYAN_SKILLFISH_VDDC_MAX);
+                       return -EINVAL;
+               }
+
+               ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_RequestGfxclk,
+                                       cyan_skillfish_user_settings.sclk, NULL);
+               if (ret) {
+                       dev_err(smu->adev->dev, "Set sclk failed!\n");
+                       return ret;
+               }
+
+               if (cyan_skillfish_user_settings.vddc == CYAN_SKILLFISH_VDDC_MAGIC) {
+                       ret = smu_cmn_send_smc_msg(smu, SMU_MSG_UnforceGfxVid, NULL);
+                       if (ret) {
+                               dev_err(smu->adev->dev, "Unforce vddc failed!\n");
+                               return ret;
+                       }
+               } else {
+                       /*
+                        * PMFW accepts SVI2 VID code, convert voltage to VID:
+                        * vid = (uint32_t)((1.55 - voltage) * 160.0 + 0.00001)
+                        */
+                       vid = (1550 - cyan_skillfish_user_settings.vddc) * 160 / 1000;
+                       ret = smu_cmn_send_smc_msg_with_param(smu, SMU_MSG_ForceGfxVid, vid, NULL);
+                       if (ret) {
+                               dev_err(smu->adev->dev, "Force vddc failed!\n");
+                               return ret;
+                       }
+               }
+
+               break;
+       default:
+               return -EOPNOTSUPP;
+       }
+
+       return ret;
+}
+
 static const struct pptable_funcs cyan_skillfish_ppt_funcs = {
 
        .check_fw_status = smu_v11_0_check_fw_status,
        .check_fw_version = smu_v11_0_check_fw_version,
        .init_power = smu_v11_0_init_power,
        .fini_power = smu_v11_0_fini_power,
+       .init_smc_tables = cyan_skillfish_init_smc_tables,
+       .fini_smc_tables = cyan_skillfish_finit_smc_tables,
+       .read_sensor = cyan_skillfish_read_sensor,
+       .print_clk_levels = cyan_skillfish_print_clk_levels,
+       .is_dpm_running = cyan_skillfish_is_dpm_running,
+       .get_gpu_metrics = cyan_skillfish_get_gpu_metrics,
+       .od_edit_dpm_table = cyan_skillfish_od_edit_dpm_table,
        .register_irq_handler = smu_v11_0_register_irq_handler,
        .notify_memory_pool_location = smu_v11_0_notify_memory_pool_location,
        .send_smc_msg_with_param = smu_cmn_send_smc_msg_with_param,
@@ -72,5 +552,6 @@ void cyan_skillfish_set_ppt_funcs(struct smu_context *smu)
 {
        smu->ppt_funcs = &cyan_skillfish_ppt_funcs;
        smu->message_map = cyan_skillfish_message_map;
+       smu->table_map = cyan_skillfish_table_map;
        smu->is_apu = true;
 }
index a5fc5d7..b1ad451 100644 (file)
@@ -1279,6 +1279,8 @@ static int navi10_print_clk_levels(struct smu_context *smu,
        struct smu_11_0_overdrive_table *od_settings = smu->od_settings;
        uint32_t min_value, max_value;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_GFXCLK:
        case SMU_SCLK:
@@ -1392,7 +1394,7 @@ static int navi10_print_clk_levels(struct smu_context *smu,
        case SMU_OD_RANGE:
                if (!smu->od_enabled || !od_table || !od_settings)
                        break;
-               size = sysfs_emit(buf, "%s:\n", "OD_RANGE");
+               size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
 
                if (navi10_od_feature_is_supported(od_settings, SMU_11_0_ODCAP_GFXCLK_LIMITS)) {
                        navi10_od_setting_get_range(od_settings, SMU_11_0_ODSETTING_GFXCLKFMIN,
@@ -2272,7 +2274,27 @@ static int navi10_baco_enter(struct smu_context *smu)
 {
        struct amdgpu_device *adev = smu->adev;
 
-       if (adev->in_runpm)
+       /*
+        * This aims the case below:
+        *   amdgpu driver loaded -> runpm suspend kicked -> sound driver loaded
+        *
+        * For NAVI10 and later ASICs, we rely on PMFW to handle the runpm. To
+        * make that possible, PMFW needs to acknowledge the dstate transition
+        * process for both gfx(function 0) and audio(function 1) function of
+        * the ASIC.
+        *
+        * The PCI device's initial runpm status is RUNPM_SUSPENDED. So as the
+        * device representing the audio function of the ASIC. And that means
+        * even if the sound driver(snd_hda_intel) was not loaded yet, it's still
+        * possible runpm suspend kicked on the ASIC. However without the dstate
+        * transition notification from audio function, pmfw cannot handle the
+        * BACO in/exit correctly. And that will cause driver hang on runpm
+        * resuming.
+        *
+        * To address this, we revert to legacy message way(driver masters the
+        * timing for BACO in/exit) on sound driver missing.
+        */
+       if (adev->in_runpm && smu_cmn_is_audio_func_enabled(adev))
                return smu_v11_0_baco_set_armd3_sequence(smu, BACO_SEQ_BACO);
        else
                return smu_v11_0_baco_enter(smu);
@@ -2282,7 +2304,7 @@ static int navi10_baco_exit(struct smu_context *smu)
 {
        struct amdgpu_device *adev = smu->adev;
 
-       if (adev->in_runpm) {
+       if (adev->in_runpm && smu_cmn_is_audio_func_enabled(adev)) {
                /* Wait for PMFW handling for the Dstate change */
                msleep(10);
                return smu_v11_0_baco_set_armd3_sequence(smu, BACO_SEQ_ULPS);
index 5e292c3..ca57221 100644 (file)
@@ -1058,6 +1058,8 @@ static int sienna_cichlid_print_clk_levels(struct smu_context *smu,
        uint32_t min_value, max_value;
        uint32_t smu_version;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_GFXCLK:
        case SMU_SCLK:
@@ -1180,7 +1182,7 @@ static int sienna_cichlid_print_clk_levels(struct smu_context *smu,
                if (!smu->od_enabled || !od_table || !od_settings)
                        break;
 
-               size = sysfs_emit(buf, "%s:\n", "OD_RANGE");
+               size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
 
                if (sienna_cichlid_is_od_feature_supported(od_settings, SMU_11_0_7_ODCAP_GFXCLK_LIMITS)) {
                        sienna_cichlid_get_od_setting_range(od_settings, SMU_11_0_7_ODSETTING_GFXCLKFMIN,
@@ -2187,7 +2189,7 @@ static int sienna_cichlid_baco_enter(struct smu_context *smu)
 {
        struct amdgpu_device *adev = smu->adev;
 
-       if (adev->in_runpm)
+       if (adev->in_runpm && smu_cmn_is_audio_func_enabled(adev))
                return smu_v11_0_baco_set_armd3_sequence(smu, BACO_SEQ_BACO);
        else
                return smu_v11_0_baco_enter(smu);
@@ -2197,7 +2199,7 @@ static int sienna_cichlid_baco_exit(struct smu_context *smu)
 {
        struct amdgpu_device *adev = smu->adev;
 
-       if (adev->in_runpm) {
+       if (adev->in_runpm && smu_cmn_is_audio_func_enabled(adev)) {
                /* Wait for PMFW handling for the Dstate change */
                msleep(10);
                return smu_v11_0_baco_set_armd3_sequence(smu, BACO_SEQ_ULPS);
index 3a34214..f6ef0ce 100644 (file)
@@ -589,10 +589,12 @@ static int vangogh_print_legacy_clk_levels(struct smu_context *smu,
        if (ret)
                return ret;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_OD_SCLK:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "%s:\n", "OD_SCLK");
+                       size += sysfs_emit_at(buf, size, "%s:\n", "OD_SCLK");
                        size += sysfs_emit_at(buf, size, "0: %10uMhz\n",
                        (smu->gfx_actual_hard_min_freq > 0) ? smu->gfx_actual_hard_min_freq : smu->gfx_default_hard_min_freq);
                        size += sysfs_emit_at(buf, size, "1: %10uMhz\n",
@@ -601,7 +603,7 @@ static int vangogh_print_legacy_clk_levels(struct smu_context *smu,
                break;
        case SMU_OD_CCLK:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "CCLK_RANGE in Core%d:\n",  smu->cpu_core_id_select);
+                       size += sysfs_emit_at(buf, size, "CCLK_RANGE in Core%d:\n",  smu->cpu_core_id_select);
                        size += sysfs_emit_at(buf, size, "0: %10uMhz\n",
                        (smu->cpu_actual_soft_min_freq > 0) ? smu->cpu_actual_soft_min_freq : smu->cpu_default_soft_min_freq);
                        size += sysfs_emit_at(buf, size, "1: %10uMhz\n",
@@ -610,7 +612,7 @@ static int vangogh_print_legacy_clk_levels(struct smu_context *smu,
                break;
        case SMU_OD_RANGE:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "%s:\n", "OD_RANGE");
+                       size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
                        size += sysfs_emit_at(buf, size, "SCLK: %7uMhz %10uMhz\n",
                                smu->gfx_default_hard_min_freq, smu->gfx_default_soft_max_freq);
                        size += sysfs_emit_at(buf, size, "CCLK: %7uMhz %10uMhz\n",
@@ -688,10 +690,12 @@ static int vangogh_print_clk_levels(struct smu_context *smu,
        if (ret)
                return ret;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_OD_SCLK:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "%s:\n", "OD_SCLK");
+                       size += sysfs_emit_at(buf, size, "%s:\n", "OD_SCLK");
                        size += sysfs_emit_at(buf, size, "0: %10uMhz\n",
                        (smu->gfx_actual_hard_min_freq > 0) ? smu->gfx_actual_hard_min_freq : smu->gfx_default_hard_min_freq);
                        size += sysfs_emit_at(buf, size, "1: %10uMhz\n",
@@ -700,7 +704,7 @@ static int vangogh_print_clk_levels(struct smu_context *smu,
                break;
        case SMU_OD_CCLK:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "CCLK_RANGE in Core%d:\n",  smu->cpu_core_id_select);
+                       size += sysfs_emit_at(buf, size, "CCLK_RANGE in Core%d:\n",  smu->cpu_core_id_select);
                        size += sysfs_emit_at(buf, size, "0: %10uMhz\n",
                        (smu->cpu_actual_soft_min_freq > 0) ? smu->cpu_actual_soft_min_freq : smu->cpu_default_soft_min_freq);
                        size += sysfs_emit_at(buf, size, "1: %10uMhz\n",
@@ -709,7 +713,7 @@ static int vangogh_print_clk_levels(struct smu_context *smu,
                break;
        case SMU_OD_RANGE:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
-                       size = sysfs_emit(buf, "%s:\n", "OD_RANGE");
+                       size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
                        size += sysfs_emit_at(buf, size, "SCLK: %7uMhz %10uMhz\n",
                                smu->gfx_default_hard_min_freq, smu->gfx_default_soft_max_freq);
                        size += sysfs_emit_at(buf, size, "CCLK: %7uMhz %10uMhz\n",
index 5aa175e..145f13b 100644 (file)
@@ -497,6 +497,8 @@ static int renoir_print_clk_levels(struct smu_context *smu,
        if (ret)
                return ret;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_OD_RANGE:
                if (smu_dpm_ctx->dpm_level == AMD_DPM_FORCED_LEVEL_MANUAL) {
index ab65202..5019903 100644 (file)
@@ -733,15 +733,19 @@ static int aldebaran_print_clk_levels(struct smu_context *smu,
        uint32_t freq_values[3] = {0};
        uint32_t min_clk, max_clk;
 
-       if (amdgpu_ras_intr_triggered())
-               return sysfs_emit(buf, "unavailable\n");
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
+       if (amdgpu_ras_intr_triggered()) {
+               size += sysfs_emit_at(buf, size, "unavailable\n");
+               return size;
+       }
 
        dpm_context = smu_dpm->dpm_context;
 
        switch (type) {
 
        case SMU_OD_SCLK:
-               size = sysfs_emit(buf, "%s:\n", "GFXCLK");
+               size += sysfs_emit_at(buf, size, "%s:\n", "GFXCLK");
                fallthrough;
        case SMU_SCLK:
                ret = aldebaran_get_current_clk_freq_by_table(smu, SMU_GFXCLK, &now);
@@ -795,7 +799,7 @@ static int aldebaran_print_clk_levels(struct smu_context *smu,
                break;
 
        case SMU_OD_MCLK:
-               size = sysfs_emit(buf, "%s:\n", "MCLK");
+               size += sysfs_emit_at(buf, size, "%s:\n", "MCLK");
                fallthrough;
        case SMU_MCLK:
                ret = aldebaran_get_current_clk_freq_by_table(smu, SMU_UCLK, &now);
index 627ba2e..a403657 100644 (file)
@@ -1052,16 +1052,18 @@ static int yellow_carp_print_clk_levels(struct smu_context *smu,
        int i, size = 0, ret = 0;
        uint32_t cur_value = 0, value = 0, count = 0;
 
+       smu_cmn_get_sysfs_buf(&buf, &size);
+
        switch (clk_type) {
        case SMU_OD_SCLK:
-               size = sysfs_emit(buf, "%s:\n", "OD_SCLK");
+               size += sysfs_emit_at(buf, size, "%s:\n", "OD_SCLK");
                size += sysfs_emit_at(buf, size, "0: %10uMhz\n",
                (smu->gfx_actual_hard_min_freq > 0) ? smu->gfx_actual_hard_min_freq : smu->gfx_default_hard_min_freq);
                size += sysfs_emit_at(buf, size, "1: %10uMhz\n",
                (smu->gfx_actual_soft_max_freq > 0) ? smu->gfx_actual_soft_max_freq : smu->gfx_default_soft_max_freq);
                break;
        case SMU_OD_RANGE:
-               size = sysfs_emit(buf, "%s:\n", "OD_RANGE");
+               size += sysfs_emit_at(buf, size, "%s:\n", "OD_RANGE");
                size += sysfs_emit_at(buf, size, "SCLK: %7uMhz %10uMhz\n",
                                                smu->gfx_default_hard_min_freq, smu->gfx_default_soft_max_freq);
                break;
index 66711ab..843d2cb 100644 (file)
@@ -1053,3 +1053,24 @@ int smu_cmn_set_mp1_state(struct smu_context *smu,
 
        return ret;
 }
+
+bool smu_cmn_is_audio_func_enabled(struct amdgpu_device *adev)
+{
+       struct pci_dev *p = NULL;
+       bool snd_driver_loaded;
+
+       /*
+        * If the ASIC comes with no audio function, we always assume
+        * it is "enabled".
+        */
+       p = pci_get_domain_bus_and_slot(pci_domain_nr(adev->pdev->bus),
+                       adev->pdev->bus->number, 1);
+       if (!p)
+               return true;
+
+       snd_driver_loaded = pci_is_enabled(p) ? true : false;
+
+       pci_dev_put(p);
+
+       return snd_driver_loaded;
+}
index 16993da..beea038 100644 (file)
@@ -110,5 +110,20 @@ void smu_cmn_init_soft_gpu_metrics(void *table, uint8_t frev, uint8_t crev);
 int smu_cmn_set_mp1_state(struct smu_context *smu,
                          enum pp_mp1_state mp1_state);
 
+/*
+ * Helper function to make sysfs_emit_at() happy. Align buf to
+ * the current page boundary and record the offset.
+ */
+static inline void smu_cmn_get_sysfs_buf(char **buf, int *offset)
+{
+       if (!*buf || !offset)
+               return;
+
+       *offset = offset_in_page(*buf);
+       *buf -= *offset;
+}
+
+bool smu_cmn_is_audio_func_enabled(struct amdgpu_device *adev);
+
 #endif
 #endif
index 6325877..ea9a79b 100644 (file)
@@ -1834,11 +1834,20 @@ static void connector_bad_edid(struct drm_connector *connector,
                               u8 *edid, int num_blocks)
 {
        int i;
-       u8 num_of_ext = edid[0x7e];
+       u8 last_block;
+
+       /*
+        * 0x7e in the EDID is the number of extension blocks. The EDID
+        * is 1 (base block) + num_ext_blocks big. That means we can think
+        * of 0x7e in the EDID of the _index_ of the last block in the
+        * combined chunk of memory.
+        */
+       last_block = edid[0x7e];
 
        /* Calculate real checksum for the last edid extension block data */
-       connector->real_edid_checksum =
-               drm_edid_block_checksum(edid + num_of_ext * EDID_LENGTH);
+       if (last_block < num_blocks)
+               connector->real_edid_checksum =
+                       drm_edid_block_checksum(edid + last_block * EDID_LENGTH);
 
        if (connector->bad_edid_counter++ && !drm_debug_enabled(DRM_UT_KMS))
                return;
index 3ab0783..8e7a124 100644 (file)
@@ -1506,6 +1506,7 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
 {
        struct drm_client_dev *client = &fb_helper->client;
        struct drm_device *dev = fb_helper->dev;
+       struct drm_mode_config *config = &dev->mode_config;
        int ret = 0;
        int crtc_count = 0;
        struct drm_connector_list_iter conn_iter;
@@ -1663,6 +1664,11 @@ static int drm_fb_helper_single_fb_probe(struct drm_fb_helper *fb_helper,
        /* Handle our overallocation */
        sizes.surface_height *= drm_fbdev_overalloc;
        sizes.surface_height /= 100;
+       if (sizes.surface_height > config->max_height) {
+               drm_dbg_kms(dev, "Fbdev over-allocation too large; clamping height to %d\n",
+                           config->max_height);
+               sizes.surface_height = config->max_height;
+       }
 
        /* push down into drivers */
        ret = (*fb_helper->funcs->fb_probe)(fb_helper, &sizes);
index 76d3856..cf741c5 100644 (file)
@@ -397,8 +397,7 @@ void etnaviv_buffer_queue(struct etnaviv_gpu *gpu, u32 exec_state,
                if (switch_mmu_context) {
                        struct etnaviv_iommu_context *old_context = gpu->mmu_context;
 
-                       etnaviv_iommu_context_get(mmu_context);
-                       gpu->mmu_context = mmu_context;
+                       gpu->mmu_context = etnaviv_iommu_context_get(mmu_context);
                        etnaviv_iommu_context_put(old_context);
                }
 
index 8f1b5af..f0b2540 100644 (file)
@@ -294,8 +294,7 @@ struct etnaviv_vram_mapping *etnaviv_gem_mapping_get(
                list_del(&mapping->obj_node);
        }
 
-       etnaviv_iommu_context_get(mmu_context);
-       mapping->context = mmu_context;
+       mapping->context = etnaviv_iommu_context_get(mmu_context);
        mapping->use = 1;
 
        ret = etnaviv_iommu_map_gem(mmu_context, etnaviv_obj,
index 4dd7d9d..486259e 100644 (file)
@@ -532,8 +532,7 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
                goto err_submit_objects;
 
        submit->ctx = file->driver_priv;
-       etnaviv_iommu_context_get(submit->ctx->mmu);
-       submit->mmu_context = submit->ctx->mmu;
+       submit->mmu_context = etnaviv_iommu_context_get(submit->ctx->mmu);
        submit->exec_state = args->exec_state;
        submit->flags = args->flags;
 
index c297fff..cc5b07f 100644 (file)
@@ -569,6 +569,12 @@ static int etnaviv_hw_reset(struct etnaviv_gpu *gpu)
        /* We rely on the GPU running, so program the clock */
        etnaviv_gpu_update_clock(gpu);
 
+       gpu->fe_running = false;
+       gpu->exec_state = -1;
+       if (gpu->mmu_context)
+               etnaviv_iommu_context_put(gpu->mmu_context);
+       gpu->mmu_context = NULL;
+
        return 0;
 }
 
@@ -637,19 +643,23 @@ void etnaviv_gpu_start_fe(struct etnaviv_gpu *gpu, u32 address, u16 prefetch)
                          VIVS_MMUv2_SEC_COMMAND_CONTROL_ENABLE |
                          VIVS_MMUv2_SEC_COMMAND_CONTROL_PREFETCH(prefetch));
        }
+
+       gpu->fe_running = true;
 }
 
-static void etnaviv_gpu_start_fe_idleloop(struct etnaviv_gpu *gpu)
+static void etnaviv_gpu_start_fe_idleloop(struct etnaviv_gpu *gpu,
+                                         struct etnaviv_iommu_context *context)
 {
-       u32 address = etnaviv_cmdbuf_get_va(&gpu->buffer,
-                               &gpu->mmu_context->cmdbuf_mapping);
        u16 prefetch;
+       u32 address;
 
        /* setup the MMU */
-       etnaviv_iommu_restore(gpu, gpu->mmu_context);
+       etnaviv_iommu_restore(gpu, context);
 
        /* Start command processor */
        prefetch = etnaviv_buffer_init(gpu);
+       address = etnaviv_cmdbuf_get_va(&gpu->buffer,
+                                       &gpu->mmu_context->cmdbuf_mapping);
 
        etnaviv_gpu_start_fe(gpu, address, prefetch);
 }
@@ -832,7 +842,6 @@ int etnaviv_gpu_init(struct etnaviv_gpu *gpu)
        /* Now program the hardware */
        mutex_lock(&gpu->lock);
        etnaviv_gpu_hw_init(gpu);
-       gpu->exec_state = -1;
        mutex_unlock(&gpu->lock);
 
        pm_runtime_mark_last_busy(gpu->dev);
@@ -1057,8 +1066,6 @@ void etnaviv_gpu_recover_hang(struct etnaviv_gpu *gpu)
        spin_unlock(&gpu->event_spinlock);
 
        etnaviv_gpu_hw_init(gpu);
-       gpu->exec_state = -1;
-       gpu->mmu_context = NULL;
 
        mutex_unlock(&gpu->lock);
        pm_runtime_mark_last_busy(gpu->dev);
@@ -1370,14 +1377,12 @@ struct dma_fence *etnaviv_gpu_submit(struct etnaviv_gem_submit *submit)
                goto out_unlock;
        }
 
-       if (!gpu->mmu_context) {
-               etnaviv_iommu_context_get(submit->mmu_context);
-               gpu->mmu_context = submit->mmu_context;
-               etnaviv_gpu_start_fe_idleloop(gpu);
-       } else {
-               etnaviv_iommu_context_get(gpu->mmu_context);
-               submit->prev_mmu_context = gpu->mmu_context;
-       }
+       if (!gpu->fe_running)
+               etnaviv_gpu_start_fe_idleloop(gpu, submit->mmu_context);
+
+       if (submit->prev_mmu_context)
+               etnaviv_iommu_context_put(submit->prev_mmu_context);
+       submit->prev_mmu_context = etnaviv_iommu_context_get(gpu->mmu_context);
 
        if (submit->nr_pmrs) {
                gpu->event[event[1]].sync_point = &sync_point_perfmon_sample_pre;
@@ -1579,7 +1584,7 @@ int etnaviv_gpu_wait_idle(struct etnaviv_gpu *gpu, unsigned int timeout_ms)
 
 static int etnaviv_gpu_hw_suspend(struct etnaviv_gpu *gpu)
 {
-       if (gpu->initialized && gpu->mmu_context) {
+       if (gpu->initialized && gpu->fe_running) {
                /* Replace the last WAIT with END */
                mutex_lock(&gpu->lock);
                etnaviv_buffer_end(gpu);
@@ -1592,8 +1597,7 @@ static int etnaviv_gpu_hw_suspend(struct etnaviv_gpu *gpu)
                 */
                etnaviv_gpu_wait_idle(gpu, 100);
 
-               etnaviv_iommu_context_put(gpu->mmu_context);
-               gpu->mmu_context = NULL;
+               gpu->fe_running = false;
        }
 
        gpu->exec_state = -1;
@@ -1741,6 +1745,9 @@ static void etnaviv_gpu_unbind(struct device *dev, struct device *master,
        etnaviv_gpu_hw_suspend(gpu);
 #endif
 
+       if (gpu->mmu_context)
+               etnaviv_iommu_context_put(gpu->mmu_context);
+
        if (gpu->initialized) {
                etnaviv_cmdbuf_free(&gpu->buffer);
                etnaviv_iommu_global_fini(gpu);
index 8ea4869..1c75c8e 100644 (file)
@@ -101,6 +101,7 @@ struct etnaviv_gpu {
        struct workqueue_struct *wq;
        struct drm_gpu_scheduler sched;
        bool initialized;
+       bool fe_running;
 
        /* 'ring'-buffer: */
        struct etnaviv_cmdbuf buffer;
index 1a7c89a..afe5dd6 100644 (file)
@@ -92,6 +92,10 @@ static void etnaviv_iommuv1_restore(struct etnaviv_gpu *gpu,
        struct etnaviv_iommuv1_context *v1_context = to_v1_context(context);
        u32 pgtable;
 
+       if (gpu->mmu_context)
+               etnaviv_iommu_context_put(gpu->mmu_context);
+       gpu->mmu_context = etnaviv_iommu_context_get(context);
+
        /* set base addresses */
        gpu_write(gpu, VIVS_MC_MEMORY_BASE_ADDR_RA, context->global->memory_base);
        gpu_write(gpu, VIVS_MC_MEMORY_BASE_ADDR_FE, context->global->memory_base);
index f8bf488..d664ae2 100644 (file)
@@ -172,6 +172,10 @@ static void etnaviv_iommuv2_restore_nonsec(struct etnaviv_gpu *gpu,
        if (gpu_read(gpu, VIVS_MMUv2_CONTROL) & VIVS_MMUv2_CONTROL_ENABLE)
                return;
 
+       if (gpu->mmu_context)
+               etnaviv_iommu_context_put(gpu->mmu_context);
+       gpu->mmu_context = etnaviv_iommu_context_get(context);
+
        prefetch = etnaviv_buffer_config_mmuv2(gpu,
                                (u32)v2_context->mtlb_dma,
                                (u32)context->global->bad_page_dma);
@@ -192,6 +196,10 @@ static void etnaviv_iommuv2_restore_sec(struct etnaviv_gpu *gpu,
        if (gpu_read(gpu, VIVS_MMUv2_SEC_CONTROL) & VIVS_MMUv2_SEC_CONTROL_ENABLE)
                return;
 
+       if (gpu->mmu_context)
+               etnaviv_iommu_context_put(gpu->mmu_context);
+       gpu->mmu_context = etnaviv_iommu_context_get(context);
+
        gpu_write(gpu, VIVS_MMUv2_PTA_ADDRESS_LOW,
                  lower_32_bits(context->global->v2.pta_dma));
        gpu_write(gpu, VIVS_MMUv2_PTA_ADDRESS_HIGH,
index dab1b58..9fb1a2a 100644 (file)
@@ -199,6 +199,7 @@ static int etnaviv_iommu_find_iova(struct etnaviv_iommu_context *context,
                 */
                list_for_each_entry_safe(m, n, &list, scan_node) {
                        etnaviv_iommu_remove_mapping(context, m);
+                       etnaviv_iommu_context_put(m->context);
                        m->context = NULL;
                        list_del_init(&m->mmu_node);
                        list_del_init(&m->scan_node);
index d1d6902..e4a0b7d 100644 (file)
@@ -105,9 +105,11 @@ void etnaviv_iommu_dump(struct etnaviv_iommu_context *ctx, void *buf);
 struct etnaviv_iommu_context *
 etnaviv_iommu_context_init(struct etnaviv_iommu_global *global,
                           struct etnaviv_cmdbuf_suballoc *suballoc);
-static inline void etnaviv_iommu_context_get(struct etnaviv_iommu_context *ctx)
+static inline struct etnaviv_iommu_context *
+etnaviv_iommu_context_get(struct etnaviv_iommu_context *ctx)
 {
        kref_get(&ctx->refcount);
+       return ctx;
 }
 void etnaviv_iommu_context_put(struct etnaviv_iommu_context *ctx);
 void etnaviv_iommu_restore(struct etnaviv_gpu *gpu,
index 9870c4e..b5001db 100644 (file)
@@ -793,7 +793,6 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        struct decon_context *ctx;
-       struct resource *res;
        int ret;
        int i;
 
@@ -818,8 +817,7 @@ static int exynos5433_decon_probe(struct platform_device *pdev)
                ctx->clks[i] = clk;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ctx->addr = devm_ioremap_resource(dev, res);
+       ctx->addr = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ctx->addr))
                return PTR_ERR(ctx->addr);
 
index e39fac8..8d13785 100644 (file)
@@ -1738,7 +1738,6 @@ static const struct component_ops exynos_dsi_component_ops = {
 static int exynos_dsi_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct resource *res;
        struct exynos_dsi *dsi;
        int ret, i;
 
@@ -1789,8 +1788,7 @@ static int exynos_dsi_probe(struct platform_device *pdev)
                }
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       dsi->reg_base = devm_ioremap_resource(dev, res);
+       dsi->reg_base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(dsi->reg_base))
                return PTR_ERR(dsi->reg_base);
 
index a3c7181..ecfd82d 100644 (file)
@@ -85,7 +85,6 @@ struct fimc_scaler {
 /*
  * A structure of fimc context.
  *
- * @regs_res: register resources.
  * @regs: memory mapped io registers.
  * @lock: locking of operations.
  * @clocks: fimc clocks.
@@ -103,7 +102,6 @@ struct fimc_context {
        struct exynos_drm_ipp_formats   *formats;
        unsigned int                    num_formats;
 
-       struct resource *regs_res;
        void __iomem    *regs;
        spinlock_t      lock;
        struct clk      *clocks[FIMC_CLKS_MAX];
@@ -1327,8 +1325,7 @@ static int fimc_probe(struct platform_device *pdev)
        ctx->num_formats = num_formats;
 
        /* resource memory */
-       ctx->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ctx->regs = devm_ioremap_resource(dev, ctx->regs_res);
+       ctx->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ctx->regs))
                return PTR_ERR(ctx->regs);
 
index 700ca4f..c735e53 100644 (file)
@@ -1202,9 +1202,7 @@ static int fimd_probe(struct platform_device *pdev)
                return PTR_ERR(ctx->lcd_clk);
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-       ctx->regs = devm_ioremap_resource(dev, res);
+       ctx->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ctx->regs))
                return PTR_ERR(ctx->regs);
 
index b002306..471fd6c 100644 (file)
@@ -1449,7 +1449,6 @@ static const struct component_ops g2d_component_ops = {
 static int g2d_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct resource *res;
        struct g2d_data *g2d;
        int ret;
 
@@ -1491,9 +1490,7 @@ static int g2d_probe(struct platform_device *pdev)
        clear_bit(G2D_BIT_SUSPEND_RUNQUEUE, &g2d->flags);
        clear_bit(G2D_BIT_ENGINE_BUSY, &g2d->flags);
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-
-       g2d->regs = devm_ioremap_resource(dev, res);
+       g2d->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(g2d->regs)) {
                ret = PTR_ERR(g2d->regs);
                goto err_put_clk;
index 90d7bf9..166a802 100644 (file)
@@ -86,7 +86,6 @@ struct gsc_scaler {
 /*
  * A structure of gsc context.
  *
- * @regs_res: register resources.
  * @regs: memory mapped io registers.
  * @gsc_clk: gsc gate clock.
  * @sc: scaler infomations.
@@ -103,7 +102,6 @@ struct gsc_context {
        struct exynos_drm_ipp_formats   *formats;
        unsigned int                    num_formats;
 
-       struct resource *regs_res;
        void __iomem    *regs;
        const char      **clk_names;
        struct clk      *clocks[GSC_MAX_CLOCKS];
@@ -1272,9 +1270,7 @@ static int gsc_probe(struct platform_device *pdev)
                }
        }
 
-       /* resource memory */
-       ctx->regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       ctx->regs = devm_ioremap_resource(dev, ctx->regs_res);
+       ctx->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(ctx->regs))
                return PTR_ERR(ctx->regs);
 
index ee61be4..dec7df3 100644 (file)
@@ -278,7 +278,6 @@ static const struct component_ops rotator_component_ops = {
 static int rotator_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct resource *regs_res;
        struct rot_context *rot;
        const struct rot_variant *variant;
        int irq;
@@ -292,8 +291,7 @@ static int rotator_probe(struct platform_device *pdev)
        rot->formats = variant->formats;
        rot->num_formats = variant->num_formats;
        rot->dev = dev;
-       regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       rot->regs = devm_ioremap_resource(dev, regs_res);
+       rot->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(rot->regs))
                return PTR_ERR(rot->regs);
 
index f9ae5b0..3a7851b 100644 (file)
@@ -485,7 +485,6 @@ static const struct component_ops scaler_component_ops = {
 static int scaler_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct resource *regs_res;
        struct scaler_context *scaler;
        int irq;
        int ret, i;
@@ -498,8 +497,7 @@ static int scaler_probe(struct platform_device *pdev)
                (struct scaler_data *)of_device_get_match_data(dev);
 
        scaler->dev = dev;
-       regs_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       scaler->regs = devm_ioremap_resource(dev, regs_res);
+       scaler->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(scaler->regs))
                return PTR_ERR(scaler->regs);
 
index c769dec..7655142 100644 (file)
@@ -1957,7 +1957,6 @@ static int hdmi_probe(struct platform_device *pdev)
        struct hdmi_audio_infoframe *audio_infoframe;
        struct device *dev = &pdev->dev;
        struct hdmi_context *hdata;
-       struct resource *res;
        int ret;
 
        hdata = devm_kzalloc(dev, sizeof(struct hdmi_context), GFP_KERNEL);
@@ -1979,8 +1978,7 @@ static int hdmi_probe(struct platform_device *pdev)
                return ret;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       hdata->regs = devm_ioremap_resource(dev, res);
+       hdata->regs = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(hdata->regs)) {
                ret = PTR_ERR(hdata->regs);
                return ret;
index 886add4..d2d8582 100644 (file)
@@ -46,6 +46,7 @@ int hyperv_mode_config_init(struct hyperv_drm_device *hv);
 int hyperv_update_vram_location(struct hv_device *hdev, phys_addr_t vram_pp);
 int hyperv_update_situation(struct hv_device *hdev, u8 active, u32 bpp,
                            u32 w, u32 h, u32 pitch);
+int hyperv_hide_hw_ptr(struct hv_device *hdev);
 int hyperv_update_dirt(struct hv_device *hdev, struct drm_rect *rect);
 int hyperv_connect_vsp(struct hv_device *hdev);
 
index 6dd4717..8c97a20 100644 (file)
@@ -101,6 +101,7 @@ static void hyperv_pipe_enable(struct drm_simple_display_pipe *pipe,
        struct hyperv_drm_device *hv = to_hv(pipe->crtc.dev);
        struct drm_shadow_plane_state *shadow_plane_state = to_drm_shadow_plane_state(plane_state);
 
+       hyperv_hide_hw_ptr(hv->hdev);
        hyperv_update_situation(hv->hdev, 1,  hv->screen_depth,
                                crtc_state->mode.hdisplay,
                                crtc_state->mode.vdisplay,
index 6d4bdcc..c0155c6 100644 (file)
@@ -299,6 +299,55 @@ int hyperv_update_situation(struct hv_device *hdev, u8 active, u32 bpp,
        return 0;
 }
 
+/*
+ * Hyper-V supports a hardware cursor feature. It's not used by Linux VM,
+ * but the Hyper-V host still draws a point as an extra mouse pointer,
+ * which is unwanted, especially when Xorg is running.
+ *
+ * The hyperv_fb driver uses synthvid_send_ptr() to hide the unwanted
+ * pointer, by setting msg.ptr_pos.is_visible = 1 and setting the
+ * msg.ptr_shape.data. Note: setting msg.ptr_pos.is_visible to 0 doesn't
+ * work in tests.
+ *
+ * Copy synthvid_send_ptr() to hyperv_drm and rename it to
+ * hyperv_hide_hw_ptr(). Note: hyperv_hide_hw_ptr() is also called in the
+ * handler of the SYNTHVID_FEATURE_CHANGE event, otherwise the host still
+ * draws an extra unwanted mouse pointer after the VM Connection window is
+ * closed and reopened.
+ */
+int hyperv_hide_hw_ptr(struct hv_device *hdev)
+{
+       struct synthvid_msg msg;
+
+       memset(&msg, 0, sizeof(struct synthvid_msg));
+       msg.vid_hdr.type = SYNTHVID_POINTER_POSITION;
+       msg.vid_hdr.size = sizeof(struct synthvid_msg_hdr) +
+               sizeof(struct synthvid_pointer_position);
+       msg.ptr_pos.is_visible = 1;
+       msg.ptr_pos.video_output = 0;
+       msg.ptr_pos.image_x = 0;
+       msg.ptr_pos.image_y = 0;
+       hyperv_sendpacket(hdev, &msg);
+
+       memset(&msg, 0, sizeof(struct synthvid_msg));
+       msg.vid_hdr.type = SYNTHVID_POINTER_SHAPE;
+       msg.vid_hdr.size = sizeof(struct synthvid_msg_hdr) +
+               sizeof(struct synthvid_pointer_shape);
+       msg.ptr_shape.part_idx = SYNTHVID_CURSOR_COMPLETE;
+       msg.ptr_shape.is_argb = 1;
+       msg.ptr_shape.width = 1;
+       msg.ptr_shape.height = 1;
+       msg.ptr_shape.hot_x = 0;
+       msg.ptr_shape.hot_y = 0;
+       msg.ptr_shape.data[0] = 0;
+       msg.ptr_shape.data[1] = 1;
+       msg.ptr_shape.data[2] = 1;
+       msg.ptr_shape.data[3] = 1;
+       hyperv_sendpacket(hdev, &msg);
+
+       return 0;
+}
+
 int hyperv_update_dirt(struct hv_device *hdev, struct drm_rect *rect)
 {
        struct hyperv_drm_device *hv = hv_get_drvdata(hdev);
@@ -392,8 +441,11 @@ static void hyperv_receive_sub(struct hv_device *hdev)
                return;
        }
 
-       if (msg->vid_hdr.type == SYNTHVID_FEATURE_CHANGE)
+       if (msg->vid_hdr.type == SYNTHVID_FEATURE_CHANGE) {
                hv->dirt_needed = msg->feature_chg.is_dirt_needed;
+               if (hv->dirt_needed)
+                       hyperv_hide_hw_ptr(hv->hdev);
+       }
 }
 
 static void hyperv_receive(void *ctx)
index 642a5b5..335ba9f 100644 (file)
@@ -19,7 +19,6 @@ subdir-ccflags-y += $(call cc-disable-warning, missing-field-initializers)
 subdir-ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
 # clang warnings
 subdir-ccflags-y += $(call cc-disable-warning, sign-compare)
-subdir-ccflags-y += $(call cc-disable-warning, sometimes-uninitialized)
 subdir-ccflags-y += $(call cc-disable-warning, initializer-overrides)
 subdir-ccflags-y += $(call cc-disable-warning, frame-address)
 subdir-ccflags-$(CONFIG_DRM_I915_WERROR) += -Werror
index 43ec7fc..a3eae3f 100644 (file)
@@ -1577,8 +1577,14 @@ static void gen11_dsi_sync_state(struct intel_encoder *encoder,
                                 const struct intel_crtc_state *crtc_state)
 {
        struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
-       struct intel_crtc *intel_crtc = to_intel_crtc(crtc_state->uapi.crtc);
-       enum pipe pipe = intel_crtc->pipe;
+       struct intel_crtc *intel_crtc;
+       enum pipe pipe;
+
+       if (!crtc_state)
+               return;
+
+       intel_crtc = to_intel_crtc(crtc_state->uapi.crtc);
+       pipe = intel_crtc->pipe;
 
        /* wa verify 1409054076:icl,jsl,ehl */
        if (DISPLAY_VER(dev_priv) == 11 && pipe == PIPE_B &&
index 7cfe91f..68abeaf 100644 (file)
@@ -186,13 +186,16 @@ void intel_dsm_get_bios_data_funcs_supported(struct drm_i915_private *i915)
 {
        struct pci_dev *pdev = to_pci_dev(i915->drm.dev);
        acpi_handle dhandle;
+       union acpi_object *obj;
 
        dhandle = ACPI_HANDLE(&pdev->dev);
        if (!dhandle)
                return;
 
-       acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
-                         INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
+       obj = acpi_evaluate_dsm(dhandle, &intel_dsm_guid2, INTEL_DSM_REVISION_ID,
+                               INTEL_DSM_FN_GET_BIOS_DATA_FUNCS_SUPPORTED, NULL);
+       if (obj)
+               ACPI_FREE(obj);
 }
 
 /*
index 5322375..4e0f96b 100644 (file)
@@ -1308,8 +1308,9 @@ static void i915_audio_component_init(struct drm_i915_private *dev_priv)
                else
                        aud_freq = aud_freq_init;
 
-               /* use BIOS provided value for TGL unless it is a known bad value */
-               if (IS_TIGERLAKE(dev_priv) && aud_freq_init != AUD_FREQ_TGL_BROKEN)
+               /* use BIOS provided value for TGL and RKL unless it is a known bad value */
+               if ((IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv)) &&
+                   aud_freq_init != AUD_FREQ_TGL_BROKEN)
                        aud_freq = aud_freq_init;
 
                drm_dbg_kms(&dev_priv->drm, "use AUD_FREQ_CNTRL of 0x%x (init value 0x%x)\n",
index e86e6ed..fd71346 100644 (file)
@@ -451,13 +451,23 @@ parse_lfp_backlight(struct drm_i915_private *i915,
        }
 
        i915->vbt.backlight.type = INTEL_BACKLIGHT_DISPLAY_DDI;
-       if (bdb->version >= 191 &&
-           get_blocksize(backlight_data) >= sizeof(*backlight_data)) {
-               const struct lfp_backlight_control_method *method;
+       if (bdb->version >= 191) {
+               size_t exp_size;
 
-               method = &backlight_data->backlight_control[panel_type];
-               i915->vbt.backlight.type = method->type;
-               i915->vbt.backlight.controller = method->controller;
+               if (bdb->version >= 236)
+                       exp_size = sizeof(struct bdb_lfp_backlight_data);
+               else if (bdb->version >= 234)
+                       exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_234;
+               else
+                       exp_size = EXP_BDB_LFP_BL_DATA_SIZE_REV_191;
+
+               if (get_blocksize(backlight_data) >= exp_size) {
+                       const struct lfp_backlight_control_method *method;
+
+                       method = &backlight_data->backlight_control[panel_type];
+                       i915->vbt.backlight.type = method->type;
+                       i915->vbt.backlight.controller = method->controller;
+               }
        }
 
        i915->vbt.backlight.pwm_freq_hz = entry->pwm_freq_hz;
index e91e0e0..4b94256 100644 (file)
@@ -222,31 +222,42 @@ static int icl_sagv_max_dclk(const struct intel_qgv_info *qi)
 
 struct intel_sa_info {
        u16 displayrtids;
-       u8 deburst, deprogbwlimit;
+       u8 deburst, deprogbwlimit, derating;
 };
 
 static const struct intel_sa_info icl_sa_info = {
        .deburst = 8,
        .deprogbwlimit = 25, /* GB/s */
        .displayrtids = 128,
+       .derating = 10,
 };
 
 static const struct intel_sa_info tgl_sa_info = {
        .deburst = 16,
        .deprogbwlimit = 34, /* GB/s */
        .displayrtids = 256,
+       .derating = 10,
 };
 
 static const struct intel_sa_info rkl_sa_info = {
        .deburst = 16,
        .deprogbwlimit = 20, /* GB/s */
        .displayrtids = 128,
+       .derating = 10,
 };
 
 static const struct intel_sa_info adls_sa_info = {
        .deburst = 16,
        .deprogbwlimit = 38, /* GB/s */
        .displayrtids = 256,
+       .derating = 10,
+};
+
+static const struct intel_sa_info adlp_sa_info = {
+       .deburst = 16,
+       .deprogbwlimit = 38, /* GB/s */
+       .displayrtids = 256,
+       .derating = 20,
 };
 
 static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel_sa_info *sa)
@@ -302,7 +313,7 @@ static int icl_get_bw_info(struct drm_i915_private *dev_priv, const struct intel
                        bw = icl_calc_bw(sp->dclk, clpchgroup * 32 * num_channels, ct);
 
                        bi->deratedbw[j] = min(maxdebw,
-                                              bw * 9 / 10); /* 90% */
+                                              bw * (100 - sa->derating) / 100);
 
                        drm_dbg_kms(&dev_priv->drm,
                                    "BW%d / QGV %d: num_planes=%d deratedbw=%u\n",
@@ -400,7 +411,9 @@ void intel_bw_init_hw(struct drm_i915_private *dev_priv)
 
        if (IS_DG2(dev_priv))
                dg2_get_bw_info(dev_priv);
-       else if (IS_ALDERLAKE_S(dev_priv) || IS_ALDERLAKE_P(dev_priv))
+       else if (IS_ALDERLAKE_P(dev_priv))
+               icl_get_bw_info(dev_priv, &adlp_sa_info);
+       else if (IS_ALDERLAKE_S(dev_priv))
                icl_get_bw_info(dev_priv, &adls_sa_info);
        else if (IS_ROCKETLAKE(dev_priv))
                icl_get_bw_info(dev_priv, &rkl_sa_info);
index 9903a78..bd18432 100644 (file)
@@ -3807,7 +3807,13 @@ void hsw_ddi_get_config(struct intel_encoder *encoder,
 static void intel_ddi_sync_state(struct intel_encoder *encoder,
                                 const struct intel_crtc_state *crtc_state)
 {
-       if (intel_crtc_has_dp_encoder(crtc_state))
+       struct drm_i915_private *i915 = to_i915(encoder->base.dev);
+       enum phy phy = intel_port_to_phy(i915, encoder->port);
+
+       if (intel_phy_is_tc(i915, phy))
+               intel_tc_port_sanitize(enc_to_dig_port(encoder));
+
+       if (crtc_state && intel_crtc_has_dp_encoder(crtc_state))
                intel_dp_sync_state(encoder, crtc_state);
 }
 
index 134a6ac..17f44ff 100644 (file)
@@ -13082,18 +13082,16 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
        readout_plane_state(dev_priv);
 
        for_each_intel_encoder(dev, encoder) {
+               struct intel_crtc_state *crtc_state = NULL;
+
                pipe = 0;
 
                if (encoder->get_hw_state(encoder, &pipe)) {
-                       struct intel_crtc_state *crtc_state;
-
                        crtc = intel_get_crtc_for_pipe(dev_priv, pipe);
                        crtc_state = to_intel_crtc_state(crtc->base.state);
 
                        encoder->base.crtc = &crtc->base;
                        intel_encoder_get_config(encoder, crtc_state);
-                       if (encoder->sync_state)
-                               encoder->sync_state(encoder, crtc_state);
 
                        /* read out to slave crtc as well for bigjoiner */
                        if (crtc_state->bigjoiner) {
@@ -13108,6 +13106,9 @@ static void intel_modeset_readout_hw_state(struct drm_device *dev)
                        encoder->base.crtc = NULL;
                }
 
+               if (encoder->sync_state)
+                       encoder->sync_state(encoder, crtc_state);
+
                drm_dbg_kms(&dev_priv->drm,
                            "[ENCODER:%d:%s] hw state readout: %s, pipe %c\n",
                            encoder->base.base.id, encoder->base.name,
@@ -13390,17 +13391,6 @@ intel_modeset_setup_hw_state(struct drm_device *dev,
        intel_modeset_readout_hw_state(dev);
 
        /* HW state is read out, now we need to sanitize this mess. */
-
-       /* Sanitize the TypeC port mode upfront, encoders depend on this */
-       for_each_intel_encoder(dev, encoder) {
-               enum phy phy = intel_port_to_phy(dev_priv, encoder->port);
-
-               /* We need to sanitize only the MST primary port. */
-               if (encoder->type != INTEL_OUTPUT_DP_MST &&
-                   intel_phy_is_tc(dev_priv, phy))
-                       intel_tc_port_sanitize(enc_to_dig_port(encoder));
-       }
-
        get_encoder_power_domains(dev_priv);
 
        if (HAS_PCH_IBX(dev_priv))
index 3c3c6cb..b3c8e1c 100644 (file)
@@ -805,11 +805,14 @@ void intel_dmc_ucode_resume(struct drm_i915_private *dev_priv)
  */
 void intel_dmc_ucode_fini(struct drm_i915_private *dev_priv)
 {
+       int id;
+
        if (!HAS_DMC(dev_priv))
                return;
 
        intel_dmc_ucode_suspend(dev_priv);
        drm_WARN_ON(&dev_priv->drm, dev_priv->dmc.wakeref);
 
-       kfree(dev_priv->dmc.dmc_info[DMC_FW_MAIN].payload);
+       for (id = 0; id < DMC_FW_MAX; id++)
+               kfree(dev_priv->dmc.dmc_info[id].payload);
 }
index 04175f3..abe3d61 100644 (file)
@@ -2445,11 +2445,14 @@ intel_edp_init_dpcd(struct intel_dp *intel_dp)
         */
        if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_DPCD_REV,
                             intel_dp->edp_dpcd, sizeof(intel_dp->edp_dpcd)) ==
-                            sizeof(intel_dp->edp_dpcd))
+                            sizeof(intel_dp->edp_dpcd)) {
                drm_dbg_kms(&dev_priv->drm, "eDP DPCD: %*ph\n",
                            (int)sizeof(intel_dp->edp_dpcd),
                            intel_dp->edp_dpcd);
 
+               intel_dp->use_max_params = intel_dp->edp_dpcd[0] < DP_EDP_14;
+       }
+
        /*
         * This has to be called after intel_dp->edp_dpcd is filled, PSR checks
         * for SET_POWER_CAPABLE bit in intel_dp->edp_dpcd[1]
index 053a3c2..508a514 100644 (file)
@@ -848,7 +848,7 @@ intel_dp_link_train_all_phys(struct intel_dp *intel_dp,
        }
 
        if (ret)
-               intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
+               ret = intel_dp_link_train_phy(intel_dp, crtc_state, DP_PHY_DPRX);
 
        if (intel_dp->set_idle_link_train)
                intel_dp->set_idle_link_train(intel_dp, crtc_state);
index 330077c..a2108a8 100644 (file)
@@ -814,6 +814,11 @@ struct lfp_brightness_level {
        u16 reserved;
 } __packed;
 
+#define EXP_BDB_LFP_BL_DATA_SIZE_REV_191 \
+       offsetof(struct bdb_lfp_backlight_data, brightness_level)
+#define EXP_BDB_LFP_BL_DATA_SIZE_REV_234 \
+       offsetof(struct bdb_lfp_backlight_data, brightness_precision_bits)
+
 struct bdb_lfp_backlight_data {
        u8 entry_size;
        struct lfp_backlight_data_entry data[16];
index cff7267..166bb46 100644 (file)
@@ -937,6 +937,10 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx,
        unsigned int n;
 
        e = alloc_engines(num_engines);
+       if (!e)
+               return ERR_PTR(-ENOMEM);
+       e->num_engines = num_engines;
+
        for (n = 0; n < num_engines; n++) {
                struct intel_context *ce;
                int ret;
@@ -970,7 +974,6 @@ static struct i915_gem_engines *user_engines(struct i915_gem_context *ctx,
                        goto free_engines;
                }
        }
-       e->num_engines = num_engines;
 
        return e;
 
@@ -986,6 +989,9 @@ void i915_gem_context_release(struct kref *ref)
        trace_i915_context_free(ctx);
        GEM_BUG_ON(!i915_gem_context_is_closed(ctx));
 
+       if (ctx->syncobj)
+               drm_syncobj_put(ctx->syncobj);
+
        mutex_destroy(&ctx->engines_mutex);
        mutex_destroy(&ctx->lut_mutex);
 
@@ -1205,9 +1211,6 @@ static void context_close(struct i915_gem_context *ctx)
        if (vm)
                i915_vm_close(vm);
 
-       if (ctx->syncobj)
-               drm_syncobj_put(ctx->syncobj);
-
        ctx->file_priv = ERR_PTR(-EBADF);
 
        /*
index e382b7f..5ab136f 100644 (file)
@@ -118,7 +118,7 @@ i915_gem_shrink(struct i915_gem_ww_ctx *ww,
        intel_wakeref_t wakeref = 0;
        unsigned long count = 0;
        unsigned long scanned = 0;
-       int err;
+       int err = 0;
 
        /* CHV + VTD workaround use stop_machine(); need to trylock vm->mutex */
        bool trylock_vm = !ww && intel_vm_no_concurrent_access_wa(i915);
@@ -242,12 +242,15 @@ skip:
                list_splice_tail(&still_in_list, phase->list);
                spin_unlock_irqrestore(&i915->mm.obj_lock, flags);
                if (err)
-                       return err;
+                       break;
        }
 
        if (shrink & I915_SHRINK_BOUND)
                intel_runtime_pm_put(&i915->runtime_pm, wakeref);
 
+       if (err)
+               return err;
+
        if (nr_scanned)
                *nr_scanned += scanned;
        return count;
index 35eedc1..6ea1315 100644 (file)
@@ -356,11 +356,8 @@ static void i915_ttm_delete_mem_notify(struct ttm_buffer_object *bo)
 {
        struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
 
-       if (likely(obj)) {
-               /* This releases all gem object bindings to the backend. */
+       if (likely(obj))
                i915_ttm_free_cached_io_st(obj);
-               __i915_gem_free_object(obj);
-       }
 }
 
 static struct intel_memory_region *
@@ -875,8 +872,12 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo)
 {
        struct drm_i915_gem_object *obj = i915_ttm_to_gem(bo);
 
+       /* This releases all gem object bindings to the backend. */
+       __i915_gem_free_object(obj);
+
        i915_gem_object_release_memory_region(obj);
        mutex_destroy(&obj->ttm.get_io_page.lock);
+
        if (obj->ttm.created)
                call_rcu(&obj->rcu, __i915_gem_free_object_rcu);
 }
index ffae7df..4a6bb64 100644 (file)
@@ -59,13 +59,13 @@ static int igt_dmabuf_import_self(void *arg)
                err = PTR_ERR(import);
                goto out_dmabuf;
        }
+       import_obj = to_intel_bo(import);
 
        if (import != &obj->base) {
                pr_err("i915_gem_prime_import created a new object!\n");
                err = -EINVAL;
                goto out_import;
        }
-       import_obj = to_intel_bo(import);
 
        i915_gem_object_lock(import_obj, NULL);
        err = __i915_gem_object_get_pages(import_obj);
@@ -128,6 +128,8 @@ static int igt_dmabuf_import_same_driver_lmem(void *arg)
                pr_err("i915_gem_prime_import failed with the wrong err=%ld\n",
                       PTR_ERR(import));
                err = PTR_ERR(import);
+       } else {
+               err = 0;
        }
 
        dma_buf_put(dmabuf);
@@ -176,6 +178,7 @@ static int igt_dmabuf_import_same_driver(struct drm_i915_private *i915,
                err = PTR_ERR(import);
                goto out_dmabuf;
        }
+       import_obj = to_intel_bo(import);
 
        if (import == &obj->base) {
                pr_err("i915_gem_prime_import reused gem object!\n");
@@ -183,8 +186,6 @@ static int igt_dmabuf_import_same_driver(struct drm_i915_private *i915,
                goto out_import;
        }
 
-       import_obj = to_intel_bo(import);
-
        i915_gem_object_lock(import_obj, NULL);
        err = __i915_gem_object_get_pages(import_obj);
        if (err) {
index b20f562..a2c34e5 100644 (file)
@@ -581,6 +581,20 @@ static enum i915_mmap_type default_mapping(struct drm_i915_private *i915)
        return I915_MMAP_TYPE_GTT;
 }
 
+static struct drm_i915_gem_object *
+create_sys_or_internal(struct drm_i915_private *i915,
+                      unsigned long size)
+{
+       if (HAS_LMEM(i915)) {
+               struct intel_memory_region *sys_region =
+                       i915->mm.regions[INTEL_REGION_SMEM];
+
+               return __i915_gem_object_create_user(i915, size, &sys_region, 1);
+       }
+
+       return i915_gem_object_create_internal(i915, size);
+}
+
 static bool assert_mmap_offset(struct drm_i915_private *i915,
                               unsigned long size,
                               int expected)
@@ -589,7 +603,7 @@ static bool assert_mmap_offset(struct drm_i915_private *i915,
        u64 offset;
        int ret;
 
-       obj = i915_gem_object_create_internal(i915, size);
+       obj = create_sys_or_internal(i915, size);
        if (IS_ERR(obj))
                return expected && expected == PTR_ERR(obj);
 
@@ -633,6 +647,7 @@ static int igt_mmap_offset_exhaustion(void *arg)
        struct drm_mm_node *hole, *next;
        int loop, err = 0;
        u64 offset;
+       int enospc = HAS_LMEM(i915) ? -ENXIO : -ENOSPC;
 
        /* Disable background reaper */
        disable_retire_worker(i915);
@@ -683,14 +698,14 @@ static int igt_mmap_offset_exhaustion(void *arg)
        }
 
        /* Too large */
-       if (!assert_mmap_offset(i915, 2 * PAGE_SIZE, -ENOSPC)) {
+       if (!assert_mmap_offset(i915, 2 * PAGE_SIZE, enospc)) {
                pr_err("Unexpectedly succeeded in inserting too large object into single page hole\n");
                err = -EINVAL;
                goto out;
        }
 
        /* Fill the hole, further allocation attempts should then fail */
-       obj = i915_gem_object_create_internal(i915, PAGE_SIZE);
+       obj = create_sys_or_internal(i915, PAGE_SIZE);
        if (IS_ERR(obj)) {
                err = PTR_ERR(obj);
                pr_err("Unable to create object for reclaimed hole\n");
@@ -703,7 +718,7 @@ static int igt_mmap_offset_exhaustion(void *arg)
                goto err_obj;
        }
 
-       if (!assert_mmap_offset(i915, PAGE_SIZE, -ENOSPC)) {
+       if (!assert_mmap_offset(i915, PAGE_SIZE, enospc)) {
                pr_err("Unexpectedly succeeded in inserting object into no holes!\n");
                err = -EINVAL;
                goto err_obj;
@@ -839,10 +854,9 @@ static int wc_check(struct drm_i915_gem_object *obj)
 
 static bool can_mmap(struct drm_i915_gem_object *obj, enum i915_mmap_type type)
 {
-       struct drm_i915_private *i915 = to_i915(obj->base.dev);
        bool no_map;
 
-       if (HAS_LMEM(i915))
+       if (obj->ops->mmap_offset)
                return type == I915_MMAP_TYPE_FIXED;
        else if (type == I915_MMAP_TYPE_FIXED)
                return false;
index 745e84c..17ca4dc 100644 (file)
@@ -362,8 +362,9 @@ static int __intel_context_active(struct i915_active *active)
        return 0;
 }
 
-static int sw_fence_dummy_notify(struct i915_sw_fence *sf,
-                                enum i915_sw_fence_notify state)
+static int __i915_sw_fence_call
+sw_fence_dummy_notify(struct i915_sw_fence *sf,
+                     enum i915_sw_fence_notify state)
 {
        return NOTIFY_DONE;
 }
@@ -420,6 +421,7 @@ void intel_context_fini(struct intel_context *ce)
 
        mutex_destroy(&ce->pin_mutex);
        i915_active_fini(&ce->active);
+       i915_sw_fence_fini(&ce->guc_blocked);
 }
 
 void i915_context_module_exit(void)
index d812b27..0a03fbe 100644 (file)
@@ -882,8 +882,6 @@ void intel_rps_park(struct intel_rps *rps)
        if (!intel_rps_is_enabled(rps))
                return;
 
-       GEM_BUG_ON(atomic_read(&rps->num_waiters));
-
        if (!intel_rps_clear_active(rps))
                return;
 
@@ -1973,8 +1971,14 @@ u32 intel_rps_read_actual_frequency(struct intel_rps *rps)
 u32 intel_rps_read_punit_req(struct intel_rps *rps)
 {
        struct intel_uncore *uncore = rps_to_uncore(rps);
+       struct intel_runtime_pm *rpm = rps_to_uncore(rps)->rpm;
+       intel_wakeref_t wakeref;
+       u32 freq = 0;
 
-       return intel_uncore_read(uncore, GEN6_RPNSWREQ);
+       with_intel_runtime_pm_if_in_use(rpm, wakeref)
+               freq = intel_uncore_read(uncore, GEN6_RPNSWREQ);
+
+       return freq;
 }
 
 static u32 intel_rps_get_req(u32 pureq)
index 99e1fad..c9086a6 100644 (file)
@@ -102,11 +102,11 @@ static_assert(sizeof(struct guc_ct_buffer_desc) == 64);
  *  |   +-------+--------------------------------------------------------------+
  *  |   |   7:0 | NUM_DWORDS = length (in dwords) of the embedded HXG message  |
  *  +---+-------+--------------------------------------------------------------+
- *  | 1 |  31:0 |  +--------------------------------------------------------+  |
- *  +---+-------+  |                                                        |  |
- *  |...|       |  |  Embedded `HXG Message`_                               |  |
- *  +---+-------+  |                                                        |  |
- *  | n |  31:0 |  +--------------------------------------------------------+  |
+ *  | 1 |  31:0 |                                                              |
+ *  +---+-------+                                                              |
+ *  |...|       | [Embedded `HXG Message`_]                                    |
+ *  +---+-------+                                                              |
+ *  | n |  31:0 |                                                              |
  *  +---+-------+--------------------------------------------------------------+
  */
 
index bbf1ddb..9baa3cb 100644 (file)
  *  +---+-------+--------------------------------------------------------------+
  *  |   | Bits  | Description                                                  |
  *  +===+=======+==============================================================+
- *  | 0 |  31:0 |  +--------------------------------------------------------+  |
- *  +---+-------+  |                                                        |  |
- *  |...|       |  |  Embedded `HXG Message`_                               |  |
- *  +---+-------+  |                                                        |  |
- *  | n |  31:0 |  +--------------------------------------------------------+  |
+ *  | 0 |  31:0 |                                                              |
+ *  +---+-------+                                                              |
+ *  |...|       | [Embedded `HXG Message`_]                                    |
+ *  +---+-------+                                                              |
+ *  | n |  31:0 |                                                              |
  *  +---+-------+--------------------------------------------------------------+
  */
 
index b104fb7..86c3185 100644 (file)
@@ -172,11 +172,6 @@ void intel_uc_driver_remove(struct intel_uc *uc)
        __uc_free_load_err_log(uc);
 }
 
-static inline bool guc_communication_enabled(struct intel_guc *guc)
-{
-       return intel_guc_ct_enabled(&guc->ct);
-}
-
 /*
  * Events triggered while CT buffers are disabled are logged in the SCRATCH_15
  * register using the same bits used in the CT message payload. Since our
@@ -210,7 +205,7 @@ static void guc_get_mmio_msg(struct intel_guc *guc)
 static void guc_handle_mmio_msg(struct intel_guc *guc)
 {
        /* we need communication to be enabled to reply to GuC */
-       GEM_BUG_ON(!guc_communication_enabled(guc));
+       GEM_BUG_ON(!intel_guc_ct_enabled(&guc->ct));
 
        spin_lock_irq(&guc->irq_lock);
        if (guc->mmio_msg) {
@@ -226,7 +221,7 @@ static int guc_enable_communication(struct intel_guc *guc)
        struct drm_i915_private *i915 = gt->i915;
        int ret;
 
-       GEM_BUG_ON(guc_communication_enabled(guc));
+       GEM_BUG_ON(intel_guc_ct_enabled(&guc->ct));
 
        ret = i915_inject_probe_error(i915, -ENXIO);
        if (ret)
@@ -662,7 +657,7 @@ static int __uc_resume(struct intel_uc *uc, bool enable_communication)
                return 0;
 
        /* Make sure we enable communication if and only if it's disabled */
-       GEM_BUG_ON(enable_communication == guc_communication_enabled(guc));
+       GEM_BUG_ON(enable_communication == intel_guc_ct_enabled(&guc->ct));
 
        if (enable_communication)
                guc_enable_communication(guc);
index b56a8e3..1bb1be5 100644 (file)
@@ -576,7 +576,7 @@ retry:
 
                        /* No one is going to touch shadow bb from now on. */
                        i915_gem_object_flush_map(bb->obj);
-                       i915_gem_object_unlock(bb->obj);
+                       i915_gem_ww_ctx_fini(&ww);
                }
        }
        return 0;
@@ -630,7 +630,7 @@ retry:
                return ret;
        }
 
-       i915_gem_object_unlock(wa_ctx->indirect_ctx.obj);
+       i915_gem_ww_ctx_fini(&ww);
 
        /* FIXME: we are not tracking our pinned VMA leaving it
         * up to the core to fix up the stray pin_count upon
index 664970f..4037030 100644 (file)
@@ -8193,6 +8193,11 @@ enum {
 #define  HSW_SPR_STRETCH_MAX_X1                REG_FIELD_PREP(HSW_SPR_STRETCH_MAX_MASK, 3)
 #define  HSW_FBCQ_DIS                  (1 << 22)
 #define  BDW_DPRS_MASK_VBLANK_SRD      (1 << 0)
+#define  SKL_PLANE1_STRETCH_MAX_MASK   REG_GENMASK(1, 0)
+#define  SKL_PLANE1_STRETCH_MAX_X8     REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 0)
+#define  SKL_PLANE1_STRETCH_MAX_X4     REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 1)
+#define  SKL_PLANE1_STRETCH_MAX_X2     REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 2)
+#define  SKL_PLANE1_STRETCH_MAX_X1     REG_FIELD_PREP(SKL_PLANE1_STRETCH_MAX_MASK, 3)
 #define CHICKEN_PIPESL_1(pipe) _MMIO_PIPE(pipe, _CHICKEN_PIPESL_1_A, _CHICKEN_PIPESL_1_B)
 
 #define _CHICKEN_TRANS_A       0x420c0
index ce44671..79da5ec 100644 (file)
@@ -829,8 +829,6 @@ static void __i915_request_ctor(void *arg)
        i915_sw_fence_init(&rq->submit, submit_notify);
        i915_sw_fence_init(&rq->semaphore, semaphore_notify);
 
-       dma_fence_init(&rq->fence, &i915_fence_ops, &rq->lock, 0, 0);
-
        rq->capture_list = NULL;
 
        init_llist_head(&rq->execute_cb);
@@ -905,17 +903,12 @@ __i915_request_create(struct intel_context *ce, gfp_t gfp)
        rq->ring = ce->ring;
        rq->execution_mask = ce->engine->mask;
 
-       kref_init(&rq->fence.refcount);
-       rq->fence.flags = 0;
-       rq->fence.error = 0;
-       INIT_LIST_HEAD(&rq->fence.cb_list);
-
        ret = intel_timeline_get_seqno(tl, rq, &seqno);
        if (ret)
                goto err_free;
 
-       rq->fence.context = tl->fence_context;
-       rq->fence.seqno = seqno;
+       dma_fence_init(&rq->fence, &i915_fence_ops, &rq->lock,
+                      tl->fence_context, seqno);
 
        RCU_INIT_POINTER(rq->timeline, tl);
        rq->hwsp_seqno = tl->hwsp_seqno;
index 65bc370..a725792 100644 (file)
@@ -76,6 +76,8 @@ struct intel_wm_config {
 
 static void gen9_init_clock_gating(struct drm_i915_private *dev_priv)
 {
+       enum pipe pipe;
+
        if (HAS_LLC(dev_priv)) {
                /*
                 * WaCompressedResourceDisplayNewHashMode:skl,kbl
@@ -89,6 +91,16 @@ static void gen9_init_clock_gating(struct drm_i915_private *dev_priv)
                           SKL_DE_COMPRESSED_HASH_MODE);
        }
 
+       for_each_pipe(dev_priv, pipe) {
+               /*
+                * "Plane N strech max must be programmed to 11b (x1)
+                *  when Async flips are enabled on that plane."
+                */
+               if (!IS_GEMINILAKE(dev_priv) && intel_vtd_active())
+                       intel_uncore_rmw(&dev_priv->uncore, CHICKEN_PIPESL_1(pipe),
+                                        SKL_PLANE1_STRETCH_MAX_MASK, SKL_PLANE1_STRETCH_MAX_X1);
+       }
+
        /* See Bspec note for PSR2_CTL bit 31, Wa#828:skl,bxt,kbl,cfl */
        intel_uncore_write(&dev_priv->uncore, CHICKEN_PAR1_1,
                   intel_uncore_read(&dev_priv->uncore, CHICKEN_PAR1_1) | SKL_EDP_PSR_FIX_RDWRAP);
index 1c2f479..12ce669 100644 (file)
@@ -172,10 +172,10 @@ static int kmb_setup_mode_config(struct drm_device *drm)
        ret = drmm_mode_config_init(drm);
        if (ret)
                return ret;
-       drm->mode_config.min_width = KMB_MIN_WIDTH;
-       drm->mode_config.min_height = KMB_MIN_HEIGHT;
-       drm->mode_config.max_width = KMB_MAX_WIDTH;
-       drm->mode_config.max_height = KMB_MAX_HEIGHT;
+       drm->mode_config.min_width = KMB_FB_MIN_WIDTH;
+       drm->mode_config.min_height = KMB_FB_MIN_HEIGHT;
+       drm->mode_config.max_width = KMB_FB_MAX_WIDTH;
+       drm->mode_config.max_height = KMB_FB_MAX_HEIGHT;
        drm->mode_config.funcs = &kmb_mode_config_funcs;
 
        ret = kmb_setup_crtc(drm);
index ebbaa5f..69a62e2 100644 (file)
 #define DRIVER_MAJOR                   1
 #define DRIVER_MINOR                   1
 
+#define KMB_FB_MAX_WIDTH               1920
+#define KMB_FB_MAX_HEIGHT              1080
+#define KMB_FB_MIN_WIDTH               1
+#define KMB_FB_MIN_HEIGHT              1
+
 #define KMB_LCD_DEFAULT_CLK            200000000
 #define KMB_SYS_CLK_MHZ                        500
 
index ecee678..06b0c42 100644 (file)
@@ -94,9 +94,10 @@ static int kmb_plane_atomic_check(struct drm_plane *plane,
        if (ret)
                return ret;
 
-       if (new_plane_state->crtc_w > KMB_MAX_WIDTH || new_plane_state->crtc_h > KMB_MAX_HEIGHT)
-               return -EINVAL;
-       if (new_plane_state->crtc_w < KMB_MIN_WIDTH || new_plane_state->crtc_h < KMB_MIN_HEIGHT)
+       if (new_plane_state->crtc_w > KMB_FB_MAX_WIDTH ||
+           new_plane_state->crtc_h > KMB_FB_MAX_HEIGHT ||
+           new_plane_state->crtc_w < KMB_FB_MIN_WIDTH ||
+           new_plane_state->crtc_h < KMB_FB_MIN_HEIGHT)
                return -EINVAL;
        can_position = (plane->type == DRM_PLANE_TYPE_OVERLAY);
        crtc_state =
@@ -277,6 +278,44 @@ static void config_csc(struct kmb_drm_private *kmb, int plane_id)
        kmb_write_lcd(kmb, LCD_LAYERn_CSC_OFF3(plane_id), csc_coef_lcd[11]);
 }
 
+static void kmb_plane_set_alpha(struct kmb_drm_private *kmb,
+                               const struct drm_plane_state *state,
+                               unsigned char plane_id,
+                               unsigned int *val)
+{
+       u16 plane_alpha = state->alpha;
+       u16 pixel_blend_mode = state->pixel_blend_mode;
+       int has_alpha = state->fb->format->has_alpha;
+
+       if (plane_alpha != DRM_BLEND_ALPHA_OPAQUE)
+               *val |= LCD_LAYER_ALPHA_STATIC;
+
+       if (has_alpha) {
+               switch (pixel_blend_mode) {
+               case DRM_MODE_BLEND_PIXEL_NONE:
+                       break;
+               case DRM_MODE_BLEND_PREMULTI:
+                       *val |= LCD_LAYER_ALPHA_EMBED | LCD_LAYER_ALPHA_PREMULT;
+                       break;
+               case DRM_MODE_BLEND_COVERAGE:
+                       *val |= LCD_LAYER_ALPHA_EMBED;
+                       break;
+               default:
+                       DRM_DEBUG("Missing pixel blend mode case (%s == %ld)\n",
+                                 __stringify(pixel_blend_mode),
+                                 (long)pixel_blend_mode);
+                       break;
+               }
+       }
+
+       if (plane_alpha == DRM_BLEND_ALPHA_OPAQUE && !has_alpha) {
+               *val &= LCD_LAYER_ALPHA_DISABLED;
+               return;
+       }
+
+       kmb_write_lcd(kmb, LCD_LAYERn_ALPHA(plane_id), plane_alpha);
+}
+
 static void kmb_plane_atomic_update(struct drm_plane *plane,
                                    struct drm_atomic_state *state)
 {
@@ -303,11 +342,12 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
        fb = new_plane_state->fb;
        if (!fb)
                return;
+
        num_planes = fb->format->num_planes;
        kmb_plane = to_kmb_plane(plane);
-       plane_id = kmb_plane->id;
 
        kmb = to_kmb(plane->dev);
+       plane_id = kmb_plane->id;
 
        spin_lock_irq(&kmb->irq_lock);
        if (kmb->kmb_under_flow || kmb->kmb_flush_done) {
@@ -400,20 +440,32 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
                config_csc(kmb, plane_id);
        }
 
+       kmb_plane_set_alpha(kmb, plane->state, plane_id, &val);
+
        kmb_write_lcd(kmb, LCD_LAYERn_CFG(plane_id), val);
 
+       /* Configure LCD_CONTROL */
+       ctrl = kmb_read_lcd(kmb, LCD_CONTROL);
+
+       /* Set layer blending config */
+       ctrl &= ~LCD_CTRL_ALPHA_ALL;
+       ctrl |= LCD_CTRL_ALPHA_BOTTOM_VL1 |
+               LCD_CTRL_ALPHA_BLEND_VL2;
+
+       ctrl &= ~LCD_CTRL_ALPHA_BLEND_BKGND_DISABLE;
+
        switch (plane_id) {
        case LAYER_0:
-               ctrl = LCD_CTRL_VL1_ENABLE;
+               ctrl |= LCD_CTRL_VL1_ENABLE;
                break;
        case LAYER_1:
-               ctrl = LCD_CTRL_VL2_ENABLE;
+               ctrl |= LCD_CTRL_VL2_ENABLE;
                break;
        case LAYER_2:
-               ctrl = LCD_CTRL_GL1_ENABLE;
+               ctrl |= LCD_CTRL_GL1_ENABLE;
                break;
        case LAYER_3:
-               ctrl = LCD_CTRL_GL2_ENABLE;
+               ctrl |= LCD_CTRL_GL2_ENABLE;
                break;
        }
 
@@ -425,7 +477,7 @@ static void kmb_plane_atomic_update(struct drm_plane *plane,
         */
        ctrl |= LCD_CTRL_VHSYNC_IDLE_LVL;
 
-       kmb_set_bitmask_lcd(kmb, LCD_CONTROL, ctrl);
+       kmb_write_lcd(kmb, LCD_CONTROL, ctrl);
 
        /* Enable pipeline AXI read transactions for the DMA
         * after setting graphics layers. This must be done
@@ -490,6 +542,9 @@ struct kmb_plane *kmb_plane_init(struct drm_device *drm)
        enum drm_plane_type plane_type;
        const u32 *plane_formats;
        int num_plane_formats;
+       unsigned int blend_caps = BIT(DRM_MODE_BLEND_PIXEL_NONE) |
+                                 BIT(DRM_MODE_BLEND_PREMULTI)   |
+                                 BIT(DRM_MODE_BLEND_COVERAGE);
 
        for (i = 0; i < KMB_MAX_PLANES; i++) {
                plane = drmm_kzalloc(drm, sizeof(*plane), GFP_KERNEL);
@@ -521,8 +576,16 @@ struct kmb_plane *kmb_plane_init(struct drm_device *drm)
                drm_dbg(drm, "%s : %d i=%d type=%d",
                        __func__, __LINE__,
                          i, plane_type);
+               drm_plane_create_alpha_property(&plane->base_plane);
+
+               drm_plane_create_blend_mode_property(&plane->base_plane,
+                                                    blend_caps);
+
+               drm_plane_create_zpos_immutable_property(&plane->base_plane, i);
+
                drm_plane_helper_add(&plane->base_plane,
                                     &kmb_plane_helper_funcs);
+
                if (plane_type == DRM_PLANE_TYPE_PRIMARY) {
                        primary = plane;
                        kmb->plane = plane;
index 486490f..6e8d22c 100644 (file)
@@ -35,6 +35,9 @@
 #define POSSIBLE_CRTCS 1
 #define to_kmb_plane(x) container_of(x, struct kmb_plane, base_plane)
 
+#define POSSIBLE_CRTCS         1
+#define KMB_MAX_PLANES         2
+
 enum layer_id {
        LAYER_0,
        LAYER_1,
@@ -43,8 +46,6 @@ enum layer_id {
        /* KMB_MAX_PLANES */
 };
 
-#define KMB_MAX_PLANES 1
-
 enum sub_plane_id {
        Y_PLANE,
        U_PLANE,
index 4815056..9756101 100644 (file)
 #define LCD_CTRL_OUTPUT_ENABLED                          BIT(19)
 #define LCD_CTRL_BPORCH_ENABLE                   BIT(21)
 #define LCD_CTRL_FPORCH_ENABLE                   BIT(22)
+#define LCD_CTRL_ALPHA_BLEND_BKGND_DISABLE       BIT(23)
 #define LCD_CTRL_PIPELINE_DMA                    BIT(28)
 #define LCD_CTRL_VHSYNC_IDLE_LVL                 BIT(31)
+#define LCD_CTRL_ALPHA_ALL                       (0xff << 6)
 
 /* interrupts */
 #define LCD_INT_STATUS                         (0x4 * 0x001)
 #define LCD_LAYER_ALPHA_EMBED                  BIT(5)
 #define LCD_LAYER_ALPHA_COMBI                  (LCD_LAYER_ALPHA_STATIC | \
                                                      LCD_LAYER_ALPHA_EMBED)
+#define LCD_LAYER_ALPHA_DISABLED               ~(LCD_LAYER_ALPHA_COMBI)
 /* RGB multiplied with alpha */
 #define LCD_LAYER_ALPHA_PREMULT                        BIT(6)
 #define LCD_LAYER_INVERT_COL                   BIT(7)
index 5f81489..a4e80e4 100644 (file)
@@ -4,8 +4,6 @@
  */
 
 #include <linux/clk.h>
-#include <linux/dma-mapping.h>
-#include <linux/mailbox_controller.h>
 #include <linux/pm_runtime.h>
 #include <linux/soc/mediatek/mtk-cmdq.h>
 #include <linux/soc/mediatek/mtk-mmsys.h>
@@ -52,11 +50,8 @@ struct mtk_drm_crtc {
        bool                            pending_async_planes;
 
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       struct mbox_client              cmdq_cl;
-       struct mbox_chan                *cmdq_chan;
-       struct cmdq_pkt                 cmdq_handle;
+       struct cmdq_client              *cmdq_client;
        u32                             cmdq_event;
-       u32                             cmdq_vblank_cnt;
 #endif
 
        struct device                   *mmsys_dev;
@@ -227,79 +222,9 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc,
 }
 
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-static int mtk_drm_cmdq_pkt_create(struct mbox_chan *chan, struct cmdq_pkt *pkt,
-                                   size_t size)
+static void ddp_cmdq_cb(struct cmdq_cb_data data)
 {
-       struct device *dev;
-       dma_addr_t dma_addr;
-
-       pkt->va_base = kzalloc(size, GFP_KERNEL);
-       if (!pkt->va_base) {
-               kfree(pkt);
-               return -ENOMEM;
-       }
-       pkt->buf_size = size;
-
-       dev = chan->mbox->dev;
-       dma_addr = dma_map_single(dev, pkt->va_base, pkt->buf_size,
-                                 DMA_TO_DEVICE);
-       if (dma_mapping_error(dev, dma_addr)) {
-               dev_err(dev, "dma map failed, size=%u\n", (u32)(u64)size);
-               kfree(pkt->va_base);
-               kfree(pkt);
-               return -ENOMEM;
-       }
-
-       pkt->pa_base = dma_addr;
-
-       return 0;
-}
-
-static void mtk_drm_cmdq_pkt_destroy(struct mbox_chan *chan, struct cmdq_pkt *pkt)
-{
-       dma_unmap_single(chan->mbox->dev, pkt->pa_base, pkt->buf_size,
-                        DMA_TO_DEVICE);
-       kfree(pkt->va_base);
-       kfree(pkt);
-}
-
-static void ddp_cmdq_cb(struct mbox_client *cl, void *mssg)
-{
-       struct mtk_drm_crtc *mtk_crtc = container_of(cl, struct mtk_drm_crtc, cmdq_cl);
-       struct cmdq_cb_data *data = mssg;
-       struct mtk_crtc_state *state;
-       unsigned int i;
-
-       state = to_mtk_crtc_state(mtk_crtc->base.state);
-
-       state->pending_config = false;
-
-       if (mtk_crtc->pending_planes) {
-               for (i = 0; i < mtk_crtc->layer_nr; i++) {
-                       struct drm_plane *plane = &mtk_crtc->planes[i];
-                       struct mtk_plane_state *plane_state;
-
-                       plane_state = to_mtk_plane_state(plane->state);
-
-                       plane_state->pending.config = false;
-               }
-               mtk_crtc->pending_planes = false;
-       }
-
-       if (mtk_crtc->pending_async_planes) {
-               for (i = 0; i < mtk_crtc->layer_nr; i++) {
-                       struct drm_plane *plane = &mtk_crtc->planes[i];
-                       struct mtk_plane_state *plane_state;
-
-                       plane_state = to_mtk_plane_state(plane->state);
-
-                       plane_state->pending.async_config = false;
-               }
-               mtk_crtc->pending_async_planes = false;
-       }
-
-       mtk_crtc->cmdq_vblank_cnt = 0;
-       mtk_drm_cmdq_pkt_destroy(mtk_crtc->cmdq_chan, data->pkt);
+       cmdq_pkt_destroy(data.data);
 }
 #endif
 
@@ -453,8 +378,7 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc,
                                    state->pending_vrefresh, 0,
                                    cmdq_handle);
 
-               if (!cmdq_handle)
-                       state->pending_config = false;
+               state->pending_config = false;
        }
 
        if (mtk_crtc->pending_planes) {
@@ -474,12 +398,9 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc,
                                mtk_ddp_comp_layer_config(comp, local_layer,
                                                          plane_state,
                                                          cmdq_handle);
-                       if (!cmdq_handle)
-                               plane_state->pending.config = false;
+                       plane_state->pending.config = false;
                }
-
-               if (!cmdq_handle)
-                       mtk_crtc->pending_planes = false;
+               mtk_crtc->pending_planes = false;
        }
 
        if (mtk_crtc->pending_async_planes) {
@@ -499,12 +420,9 @@ static void mtk_crtc_ddp_config(struct drm_crtc *crtc,
                                mtk_ddp_comp_layer_config(comp, local_layer,
                                                          plane_state,
                                                          cmdq_handle);
-                       if (!cmdq_handle)
-                               plane_state->pending.async_config = false;
+                       plane_state->pending.async_config = false;
                }
-
-               if (!cmdq_handle)
-                       mtk_crtc->pending_async_planes = false;
+               mtk_crtc->pending_async_planes = false;
        }
 }
 
@@ -512,7 +430,7 @@ static void mtk_drm_crtc_update_config(struct mtk_drm_crtc *mtk_crtc,
                                       bool needs_vblank)
 {
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       struct cmdq_pkt *cmdq_handle = &mtk_crtc->cmdq_handle;
+       struct cmdq_pkt *cmdq_handle;
 #endif
        struct drm_crtc *crtc = &mtk_crtc->base;
        struct mtk_drm_private *priv = crtc->dev->dev_private;
@@ -550,24 +468,14 @@ static void mtk_drm_crtc_update_config(struct mtk_drm_crtc *mtk_crtc,
                mtk_mutex_release(mtk_crtc->mutex);
        }
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       if (mtk_crtc->cmdq_chan) {
-               mbox_flush(mtk_crtc->cmdq_chan, 2000);
-               cmdq_handle->cmd_buf_size = 0;
+       if (mtk_crtc->cmdq_client) {
+               mbox_flush(mtk_crtc->cmdq_client->chan, 2000);
+               cmdq_handle = cmdq_pkt_create(mtk_crtc->cmdq_client, PAGE_SIZE);
                cmdq_pkt_clear_event(cmdq_handle, mtk_crtc->cmdq_event);
                cmdq_pkt_wfe(cmdq_handle, mtk_crtc->cmdq_event, false);
                mtk_crtc_ddp_config(crtc, cmdq_handle);
                cmdq_pkt_finalize(cmdq_handle);
-               dma_sync_single_for_device(mtk_crtc->cmdq_chan->mbox->dev,
-                                           cmdq_handle->pa_base,
-                                           cmdq_handle->cmd_buf_size,
-                                           DMA_TO_DEVICE);
-               /*
-                * CMDQ command should execute in next vblank,
-                * If it fail to execute in next 2 vblank, timeout happen.
-                */
-               mtk_crtc->cmdq_vblank_cnt = 2;
-               mbox_send_message(mtk_crtc->cmdq_chan, cmdq_handle);
-               mbox_client_txdone(mtk_crtc->cmdq_chan, 0);
+               cmdq_pkt_flush_async(cmdq_handle, ddp_cmdq_cb, cmdq_handle);
        }
 #endif
        mtk_crtc->config_updating = false;
@@ -581,15 +489,12 @@ static void mtk_crtc_ddp_irq(void *data)
        struct mtk_drm_private *priv = crtc->dev->dev_private;
 
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       if (!priv->data->shadow_register && !mtk_crtc->cmdq_chan)
-               mtk_crtc_ddp_config(crtc, NULL);
-       else if (mtk_crtc->cmdq_vblank_cnt > 0 && --mtk_crtc->cmdq_vblank_cnt == 0)
-               DRM_ERROR("mtk_crtc %d CMDQ execute command timeout!\n",
-                         drm_crtc_index(&mtk_crtc->base));
+       if (!priv->data->shadow_register && !mtk_crtc->cmdq_client)
 #else
        if (!priv->data->shadow_register)
-               mtk_crtc_ddp_config(crtc, NULL);
 #endif
+               mtk_crtc_ddp_config(crtc, NULL);
+
        mtk_drm_finish_page_flip(mtk_crtc);
 }
 
@@ -924,20 +829,16 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
        mutex_init(&mtk_crtc->hw_lock);
 
 #if IS_REACHABLE(CONFIG_MTK_CMDQ)
-       mtk_crtc->cmdq_cl.dev = mtk_crtc->mmsys_dev;
-       mtk_crtc->cmdq_cl.tx_block = false;
-       mtk_crtc->cmdq_cl.knows_txdone = true;
-       mtk_crtc->cmdq_cl.rx_callback = ddp_cmdq_cb;
-       mtk_crtc->cmdq_chan =
-                       mbox_request_channel(&mtk_crtc->cmdq_cl,
-                                             drm_crtc_index(&mtk_crtc->base));
-       if (IS_ERR(mtk_crtc->cmdq_chan)) {
+       mtk_crtc->cmdq_client =
+                       cmdq_mbox_create(mtk_crtc->mmsys_dev,
+                                        drm_crtc_index(&mtk_crtc->base));
+       if (IS_ERR(mtk_crtc->cmdq_client)) {
                dev_dbg(dev, "mtk_crtc %d failed to create mailbox client, writing register by CPU now\n",
                        drm_crtc_index(&mtk_crtc->base));
-               mtk_crtc->cmdq_chan = NULL;
+               mtk_crtc->cmdq_client = NULL;
        }
 
-       if (mtk_crtc->cmdq_chan) {
+       if (mtk_crtc->cmdq_client) {
                ret = of_property_read_u32_index(priv->mutex_node,
                                                 "mediatek,gce-events",
                                                 drm_crtc_index(&mtk_crtc->base),
@@ -945,18 +846,8 @@ int mtk_drm_crtc_create(struct drm_device *drm_dev,
                if (ret) {
                        dev_dbg(dev, "mtk_crtc %d failed to get mediatek,gce-events property\n",
                                drm_crtc_index(&mtk_crtc->base));
-                       mbox_free_channel(mtk_crtc->cmdq_chan);
-                       mtk_crtc->cmdq_chan = NULL;
-               } else {
-                       ret = mtk_drm_cmdq_pkt_create(mtk_crtc->cmdq_chan,
-                                                      &mtk_crtc->cmdq_handle,
-                                                      PAGE_SIZE);
-                       if (ret) {
-                               dev_dbg(dev, "mtk_crtc %d failed to create cmdq packet\n",
-                                       drm_crtc_index(&mtk_crtc->base));
-                               mbox_free_channel(mtk_crtc->cmdq_chan);
-                               mtk_crtc->cmdq_chan = NULL;
-                       }
+                       cmdq_mbox_destroy(mtk_crtc->cmdq_client);
+                       mtk_crtc->cmdq_client = NULL;
                }
        }
 #endif
index e9c6af7..3ddf739 100644 (file)
@@ -17,7 +17,7 @@ config DRM_MSM
        select DRM_SCHED
        select SHMEM
        select TMPFS
-       select QCOM_SCM if ARCH_QCOM
+       select QCOM_SCM
        select WANT_DEV_COREDUMP
        select SND_SOC_HDMI_CODEC if SND_SOC
        select SYNC_FILE
@@ -55,7 +55,7 @@ config DRM_MSM_GPU_SUDO
 
 config DRM_MSM_HDMI_HDCP
        bool "Enable HDMI HDCP support in MSM DRM driver"
-       depends on DRM_MSM && QCOM_SCM
+       depends on DRM_MSM
        default y
        help
          Choose this option to enable HDCP state machine
index 4534633..8fb847c 100644 (file)
@@ -571,13 +571,14 @@ struct msm_gpu *a3xx_gpu_init(struct drm_device *dev)
        }
 
        icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
-       ret = IS_ERR(icc_path);
-       if (ret)
+       if (IS_ERR(icc_path)) {
+               ret = PTR_ERR(icc_path);
                goto fail;
+       }
 
        ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem");
-       ret = IS_ERR(ocmem_icc_path);
-       if (ret) {
+       if (IS_ERR(ocmem_icc_path)) {
+               ret = PTR_ERR(ocmem_icc_path);
                /* allow -ENODATA, ocmem icc is optional */
                if (ret != -ENODATA)
                        goto fail;
index 82bebb4..a96ee79 100644 (file)
@@ -699,13 +699,14 @@ struct msm_gpu *a4xx_gpu_init(struct drm_device *dev)
        }
 
        icc_path = devm_of_icc_get(&pdev->dev, "gfx-mem");
-       ret = IS_ERR(icc_path);
-       if (ret)
+       if (IS_ERR(icc_path)) {
+               ret = PTR_ERR(icc_path);
                goto fail;
+       }
 
        ocmem_icc_path = devm_of_icc_get(&pdev->dev, "ocmem");
-       ret = IS_ERR(ocmem_icc_path);
-       if (ret) {
+       if (IS_ERR(ocmem_icc_path)) {
+               ret = PTR_ERR(ocmem_icc_path);
                /* allow -ENODATA, ocmem icc is optional */
                if (ret != -ENODATA)
                        goto fail;
index a7c5801..8b73f70 100644 (file)
@@ -296,6 +296,8 @@ int a6xx_gmu_set_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
        u32 val;
        int request, ack;
 
+       WARN_ON_ONCE(!mutex_is_locked(&gmu->lock));
+
        if (state >= ARRAY_SIZE(a6xx_gmu_oob_bits))
                return -EINVAL;
 
@@ -337,6 +339,8 @@ void a6xx_gmu_clear_oob(struct a6xx_gmu *gmu, enum a6xx_gmu_oob_state state)
 {
        int bit;
 
+       WARN_ON_ONCE(!mutex_is_locked(&gmu->lock));
+
        if (state >= ARRAY_SIZE(a6xx_gmu_oob_bits))
                return;
 
@@ -1482,6 +1486,8 @@ int a6xx_gmu_init(struct a6xx_gpu *a6xx_gpu, struct device_node *node)
        if (!pdev)
                return -ENODEV;
 
+       mutex_init(&gmu->lock);
+
        gmu->dev = &pdev->dev;
 
        of_dma_configure(gmu->dev, node, true);
index 3c74f64..84bd516 100644 (file)
@@ -44,6 +44,9 @@ struct a6xx_gmu_bo {
 struct a6xx_gmu {
        struct device *dev;
 
+       /* For serializing communication with the GMU: */
+       struct mutex lock;
+
        struct msm_gem_address_space *aspace;
 
        void * __iomem mmio;
index 40c9fef..33da25b 100644 (file)
@@ -106,7 +106,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu,
        u32 asid;
        u64 memptr = rbmemptr(ring, ttbr0);
 
-       if (ctx == a6xx_gpu->cur_ctx)
+       if (ctx->seqno == a6xx_gpu->cur_ctx_seqno)
                return;
 
        if (msm_iommu_pagetable_params(ctx->aspace->mmu, &ttbr, &asid))
@@ -139,7 +139,7 @@ static void a6xx_set_pagetable(struct a6xx_gpu *a6xx_gpu,
        OUT_PKT7(ring, CP_EVENT_WRITE, 1);
        OUT_RING(ring, 0x31);
 
-       a6xx_gpu->cur_ctx = ctx;
+       a6xx_gpu->cur_ctx_seqno = ctx->seqno;
 }
 
 static void a6xx_submit(struct msm_gpu *gpu, struct msm_gem_submit *submit)
@@ -881,7 +881,7 @@ static int a6xx_zap_shader_init(struct msm_gpu *gpu)
          A6XX_RBBM_INT_0_MASK_UCHE_OOB_ACCESS | \
          A6XX_RBBM_INT_0_MASK_UCHE_TRAP_INTR)
 
-static int a6xx_hw_init(struct msm_gpu *gpu)
+static int hw_init(struct msm_gpu *gpu)
 {
        struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
        struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
@@ -1081,7 +1081,7 @@ static int a6xx_hw_init(struct msm_gpu *gpu)
        /* Always come up on rb 0 */
        a6xx_gpu->cur_ring = gpu->rb[0];
 
-       a6xx_gpu->cur_ctx = NULL;
+       a6xx_gpu->cur_ctx_seqno = 0;
 
        /* Enable the SQE_to start the CP engine */
        gpu_write(gpu, REG_A6XX_CP_SQE_CNTL, 1);
@@ -1135,6 +1135,19 @@ out:
        return ret;
 }
 
+static int a6xx_hw_init(struct msm_gpu *gpu)
+{
+       struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+       struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+       int ret;
+
+       mutex_lock(&a6xx_gpu->gmu.lock);
+       ret = hw_init(gpu);
+       mutex_unlock(&a6xx_gpu->gmu.lock);
+
+       return ret;
+}
+
 static void a6xx_dump(struct msm_gpu *gpu)
 {
        DRM_DEV_INFO(&gpu->pdev->dev, "status:   %08x\n",
@@ -1509,7 +1522,9 @@ static int a6xx_pm_resume(struct msm_gpu *gpu)
 
        trace_msm_gpu_resume(0);
 
+       mutex_lock(&a6xx_gpu->gmu.lock);
        ret = a6xx_gmu_resume(a6xx_gpu);
+       mutex_unlock(&a6xx_gpu->gmu.lock);
        if (ret)
                return ret;
 
@@ -1532,7 +1547,9 @@ static int a6xx_pm_suspend(struct msm_gpu *gpu)
 
        msm_devfreq_suspend(gpu);
 
+       mutex_lock(&a6xx_gpu->gmu.lock);
        ret = a6xx_gmu_stop(a6xx_gpu);
+       mutex_unlock(&a6xx_gpu->gmu.lock);
        if (ret)
                return ret;
 
@@ -1547,18 +1564,19 @@ static int a6xx_get_timestamp(struct msm_gpu *gpu, uint64_t *value)
 {
        struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
        struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
-       static DEFINE_MUTEX(perfcounter_oob);
 
-       mutex_lock(&perfcounter_oob);
+       mutex_lock(&a6xx_gpu->gmu.lock);
 
        /* Force the GPU power on so we can read this register */
        a6xx_gmu_set_oob(&a6xx_gpu->gmu, GMU_OOB_PERFCOUNTER_SET);
 
        *value = gpu_read64(gpu, REG_A6XX_CP_ALWAYS_ON_COUNTER_LO,
-               REG_A6XX_CP_ALWAYS_ON_COUNTER_HI);
+                           REG_A6XX_CP_ALWAYS_ON_COUNTER_HI);
 
        a6xx_gmu_clear_oob(&a6xx_gpu->gmu, GMU_OOB_PERFCOUNTER_SET);
-       mutex_unlock(&perfcounter_oob);
+
+       mutex_unlock(&a6xx_gpu->gmu.lock);
+
        return 0;
 }
 
@@ -1622,6 +1640,16 @@ static unsigned long a6xx_gpu_busy(struct msm_gpu *gpu)
        return (unsigned long)busy_time;
 }
 
+void a6xx_gpu_set_freq(struct msm_gpu *gpu, struct dev_pm_opp *opp)
+{
+       struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
+       struct a6xx_gpu *a6xx_gpu = to_a6xx_gpu(adreno_gpu);
+
+       mutex_lock(&a6xx_gpu->gmu.lock);
+       a6xx_gmu_set_freq(gpu, opp);
+       mutex_unlock(&a6xx_gpu->gmu.lock);
+}
+
 static struct msm_gem_address_space *
 a6xx_create_address_space(struct msm_gpu *gpu, struct platform_device *pdev)
 {
@@ -1766,7 +1794,7 @@ static const struct adreno_gpu_funcs funcs = {
 #endif
                .gpu_busy = a6xx_gpu_busy,
                .gpu_get_freq = a6xx_gmu_get_freq,
-               .gpu_set_freq = a6xx_gmu_set_freq,
+               .gpu_set_freq = a6xx_gpu_set_freq,
 #if defined(CONFIG_DRM_MSM_GPU_STATE)
                .gpu_state_get = a6xx_gpu_state_get,
                .gpu_state_put = a6xx_gpu_state_put,
index 0bc2d06..8e5527c 100644 (file)
@@ -19,7 +19,16 @@ struct a6xx_gpu {
        uint64_t sqe_iova;
 
        struct msm_ringbuffer *cur_ring;
-       struct msm_file_private *cur_ctx;
+
+       /**
+        * cur_ctx_seqno:
+        *
+        * The ctx->seqno value of the context with current pgtables
+        * installed.  Tracked by seqno rather than pointer value to
+        * avoid dangling pointers, and cases where a ctx can be freed
+        * and a new one created with the same address.
+        */
+       int cur_ctx_seqno;
 
        struct a6xx_gmu gmu;
 
index b131fd3..700d65e 100644 (file)
@@ -794,7 +794,7 @@ static const struct dpu_pingpong_cfg sm8150_pp[] = {
                        DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30),
                        -1),
        PP_BLK("pingpong_5", PINGPONG_5, 0x72800, MERGE_3D_2, sdm845_pp_sblk,
-                       DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30),
+                       DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 31),
                        -1),
 };
 
index f482e09..bb7d066 100644 (file)
@@ -1125,6 +1125,20 @@ static void mdp5_crtc_reset(struct drm_crtc *crtc)
        __drm_atomic_helper_crtc_reset(crtc, &mdp5_cstate->base);
 }
 
+static const struct drm_crtc_funcs mdp5_crtc_no_lm_cursor_funcs = {
+       .set_config = drm_atomic_helper_set_config,
+       .destroy = mdp5_crtc_destroy,
+       .page_flip = drm_atomic_helper_page_flip,
+       .reset = mdp5_crtc_reset,
+       .atomic_duplicate_state = mdp5_crtc_duplicate_state,
+       .atomic_destroy_state = mdp5_crtc_destroy_state,
+       .atomic_print_state = mdp5_crtc_atomic_print_state,
+       .get_vblank_counter = mdp5_crtc_get_vblank_counter,
+       .enable_vblank  = msm_crtc_enable_vblank,
+       .disable_vblank = msm_crtc_disable_vblank,
+       .get_vblank_timestamp = drm_crtc_vblank_helper_get_vblank_timestamp,
+};
+
 static const struct drm_crtc_funcs mdp5_crtc_funcs = {
        .set_config = drm_atomic_helper_set_config,
        .destroy = mdp5_crtc_destroy,
@@ -1313,6 +1327,8 @@ struct drm_crtc *mdp5_crtc_init(struct drm_device *dev,
        mdp5_crtc->lm_cursor_enabled = cursor_plane ? false : true;
 
        drm_crtc_init_with_planes(dev, crtc, plane, cursor_plane,
+                                 cursor_plane ?
+                                 &mdp5_crtc_no_lm_cursor_funcs :
                                  &mdp5_crtc_funcs, NULL);
 
        drm_flip_work_init(&mdp5_crtc->unref_cursor_work,
index fbe4c2c..a0392e4 100644 (file)
@@ -1309,14 +1309,14 @@ static int dp_pm_resume(struct device *dev)
         * can not declared display is connected unless
         * HDMI cable is plugged in and sink_count of
         * dongle become 1
+        * also only signal audio when disconnected
         */
-       if (dp->link->sink_count)
+       if (dp->link->sink_count) {
                dp->dp_display.is_connected = true;
-       else
+       } else {
                dp->dp_display.is_connected = false;
-
-       dp_display_handle_plugged_change(g_dp_display,
-                               dp->dp_display.is_connected);
+               dp_display_handle_plugged_change(g_dp_display, false);
+       }
 
        DRM_DEBUG_DP("After, sink_count=%d is_connected=%d core_inited=%d power_on=%d\n",
                        dp->link->sink_count, dp->dp_display.is_connected,
index 614dc7f..75ae300 100644 (file)
@@ -215,8 +215,10 @@ int msm_dsi_modeset_init(struct msm_dsi *msm_dsi, struct drm_device *dev,
                goto fail;
        }
 
-       if (!msm_dsi_manager_validate_current_config(msm_dsi->id))
+       if (!msm_dsi_manager_validate_current_config(msm_dsi->id)) {
+               ret = -EINVAL;
                goto fail;
+       }
 
        msm_dsi->encoder = encoder;
 
index e269df2..c86b509 100644 (file)
@@ -451,7 +451,7 @@ static int dsi_bus_clk_enable(struct msm_dsi_host *msm_host)
 
        return 0;
 err:
-       for (; i > 0; i--)
+       while (--i >= 0)
                clk_disable_unprepare(msm_host->bus_clks[i]);
 
        return ret;
index d13552b..5b4e991 100644 (file)
@@ -110,14 +110,13 @@ static struct dsi_pll_14nm *pll_14nm_list[DSI_MAX];
 static bool pll_14nm_poll_for_ready(struct dsi_pll_14nm *pll_14nm,
                                    u32 nb_tries, u32 timeout_us)
 {
-       bool pll_locked = false;
+       bool pll_locked = false, pll_ready = false;
        void __iomem *base = pll_14nm->phy->pll_base;
        u32 tries, val;
 
        tries = nb_tries;
        while (tries--) {
-               val = dsi_phy_read(base +
-                              REG_DSI_14nm_PHY_PLL_RESET_SM_READY_STATUS);
+               val = dsi_phy_read(base + REG_DSI_14nm_PHY_PLL_RESET_SM_READY_STATUS);
                pll_locked = !!(val & BIT(5));
 
                if (pll_locked)
@@ -126,23 +125,24 @@ static bool pll_14nm_poll_for_ready(struct dsi_pll_14nm *pll_14nm,
                udelay(timeout_us);
        }
 
-       if (!pll_locked) {
-               tries = nb_tries;
-               while (tries--) {
-                       val = dsi_phy_read(base +
-                               REG_DSI_14nm_PHY_PLL_RESET_SM_READY_STATUS);
-                       pll_locked = !!(val & BIT(0));
+       if (!pll_locked)
+               goto out;
 
-                       if (pll_locked)
-                               break;
+       tries = nb_tries;
+       while (tries--) {
+               val = dsi_phy_read(base + REG_DSI_14nm_PHY_PLL_RESET_SM_READY_STATUS);
+               pll_ready = !!(val & BIT(0));
 
-                       udelay(timeout_us);
-               }
+               if (pll_ready)
+                       break;
+
+               udelay(timeout_us);
        }
 
-       DBG("DSI PLL is %slocked", pll_locked ? "" : "*not* ");
+out:
+       DBG("DSI PLL is %slocked, %sready", pll_locked ? "" : "*not* ", pll_ready ? "" : "*not* ");
 
-       return pll_locked;
+       return pll_locked && pll_ready;
 }
 
 static void dsi_pll_14nm_config_init(struct dsi_pll_config *pconf)
index aaa3745..71ed4aa 100644 (file)
@@ -428,7 +428,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
        bytediv->reg = pll_28nm->phy->pll_base + REG_DSI_28nm_8960_PHY_PLL_CTRL_9;
 
        snprintf(parent_name, 32, "dsi%dvco_clk", pll_28nm->phy->id);
-       snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->phy->id);
+       snprintf(clk_name, 32, "dsi%dpllbyte", pll_28nm->phy->id + 1);
 
        bytediv_init.name = clk_name;
        bytediv_init.ops = &clk_bytediv_ops;
@@ -442,7 +442,7 @@ static int pll_28nm_register(struct dsi_pll_28nm *pll_28nm, struct clk_hw **prov
                return ret;
        provided_clocks[DSI_BYTE_PLL_CLK] = &bytediv->hw;
 
-       snprintf(clk_name, 32, "dsi%dpll", pll_28nm->phy->id);
+       snprintf(clk_name, 32, "dsi%dpll", pll_28nm->phy->id + 1);
        /* DIV3 */
        hw = devm_clk_hw_register_divider(dev, clk_name,
                                parent_name, 0, pll_28nm->phy->pll_base +
index 4fb397e..fe1366b 100644 (file)
@@ -1116,7 +1116,7 @@ void msm_edp_ctrl_power(struct edp_ctrl *ctrl, bool on)
 int msm_edp_ctrl_init(struct msm_edp *edp)
 {
        struct edp_ctrl *ctrl = NULL;
-       struct device *dev = &edp->pdev->dev;
+       struct device *dev;
        int ret;
 
        if (!edp) {
@@ -1124,6 +1124,7 @@ int msm_edp_ctrl_init(struct msm_edp *edp)
                return -EINVAL;
        }
 
+       dev = &edp->pdev->dev;
        ctrl = devm_kzalloc(dev, sizeof(*ctrl), GFP_KERNEL);
        if (!ctrl)
                return -ENOMEM;
index 2e6fc18..d4e0970 100644 (file)
@@ -630,10 +630,11 @@ static int msm_drm_init(struct device *dev, const struct drm_driver *drv)
        if (ret)
                goto err_msm_uninit;
 
-       ret = msm_disp_snapshot_init(ddev);
-       if (ret)
-               DRM_DEV_ERROR(dev, "msm_disp_snapshot_init failed ret = %d\n", ret);
-
+       if (kms) {
+               ret = msm_disp_snapshot_init(ddev);
+               if (ret)
+                       DRM_DEV_ERROR(dev, "msm_disp_snapshot_init failed ret = %d\n", ret);
+       }
        drm_mode_config_reset(ddev);
 
 #ifdef CONFIG_DRM_FBDEV_EMULATION
@@ -682,6 +683,7 @@ static void load_gpu(struct drm_device *dev)
 
 static int context_init(struct drm_device *dev, struct drm_file *file)
 {
+       static atomic_t ident = ATOMIC_INIT(0);
        struct msm_drm_private *priv = dev->dev_private;
        struct msm_file_private *ctx;
 
@@ -689,12 +691,17 @@ static int context_init(struct drm_device *dev, struct drm_file *file)
        if (!ctx)
                return -ENOMEM;
 
+       INIT_LIST_HEAD(&ctx->submitqueues);
+       rwlock_init(&ctx->queuelock);
+
        kref_init(&ctx->ref);
        msm_submitqueue_init(dev, ctx);
 
        ctx->aspace = msm_gpu_create_private_address_space(priv->gpu, current);
        file->driver_priv = ctx;
 
+       ctx->seqno = atomic_inc_return(&ident);
+
        return 0;
 }
 
index 8b005d1..c552f0c 100644 (file)
@@ -53,14 +53,6 @@ struct msm_disp_state;
 
 #define FRAC_16_16(mult, div)    (((mult) << 16) / (div))
 
-struct msm_file_private {
-       rwlock_t queuelock;
-       struct list_head submitqueues;
-       int queueid;
-       struct msm_gem_address_space *aspace;
-       struct kref ref;
-};
-
 enum msm_mdp_plane_property {
        PLANE_PROP_ZPOS,
        PLANE_PROP_ALPHA,
@@ -488,41 +480,6 @@ void msm_writel(u32 data, void __iomem *addr);
 u32 msm_readl(const void __iomem *addr);
 void msm_rmw(void __iomem *addr, u32 mask, u32 or);
 
-struct msm_gpu_submitqueue;
-int msm_submitqueue_init(struct drm_device *drm, struct msm_file_private *ctx);
-struct msm_gpu_submitqueue *msm_submitqueue_get(struct msm_file_private *ctx,
-               u32 id);
-int msm_submitqueue_create(struct drm_device *drm,
-               struct msm_file_private *ctx,
-               u32 prio, u32 flags, u32 *id);
-int msm_submitqueue_query(struct drm_device *drm, struct msm_file_private *ctx,
-               struct drm_msm_submitqueue_query *args);
-int msm_submitqueue_remove(struct msm_file_private *ctx, u32 id);
-void msm_submitqueue_close(struct msm_file_private *ctx);
-
-void msm_submitqueue_destroy(struct kref *kref);
-
-static inline void __msm_file_private_destroy(struct kref *kref)
-{
-       struct msm_file_private *ctx = container_of(kref,
-               struct msm_file_private, ref);
-
-       msm_gem_address_space_put(ctx->aspace);
-       kfree(ctx);
-}
-
-static inline void msm_file_private_put(struct msm_file_private *ctx)
-{
-       kref_put(&ctx->ref, __msm_file_private_destroy);
-}
-
-static inline struct msm_file_private *msm_file_private_get(
-       struct msm_file_private *ctx)
-{
-       kref_get(&ctx->ref);
-       return ctx;
-}
-
 #define DBG(fmt, ...) DRM_DEBUG_DRIVER(fmt"\n", ##__VA_ARGS__)
 #define VERB(fmt, ...) if (0) DRM_DEBUG_DRIVER(fmt"\n", ##__VA_ARGS__)
 
@@ -547,7 +504,7 @@ static inline int align_pitch(int width, int bpp)
 static inline unsigned long timeout_to_jiffies(const ktime_t *timeout)
 {
        ktime_t now = ktime_get();
-       unsigned long remaining_jiffies;
+       s64 remaining_jiffies;
 
        if (ktime_compare(*timeout, now) < 0) {
                remaining_jiffies = 0;
@@ -556,7 +513,7 @@ static inline unsigned long timeout_to_jiffies(const ktime_t *timeout)
                remaining_jiffies = ktime_divns(rem, NSEC_PER_SEC / HZ);
        }
 
-       return remaining_jiffies;
+       return clamp(remaining_jiffies, 0LL, (s64)INT_MAX);
 }
 
 #endif /* __MSM_DRV_H__ */
index fdc5367..151d19e 100644 (file)
@@ -46,7 +46,7 @@ static struct msm_gem_submit *submit_create(struct drm_device *dev,
        if (!submit)
                return ERR_PTR(-ENOMEM);
 
-       ret = drm_sched_job_init(&submit->base, &queue->entity, queue);
+       ret = drm_sched_job_init(&submit->base, queue->entity, queue);
        if (ret) {
                kfree(submit);
                return ERR_PTR(ret);
@@ -171,7 +171,8 @@ out:
 static int submit_lookup_cmds(struct msm_gem_submit *submit,
                struct drm_msm_gem_submit *args, struct drm_file *file)
 {
-       unsigned i, sz;
+       unsigned i;
+       size_t sz;
        int ret = 0;
 
        for (i = 0; i < args->nr_cmds; i++) {
@@ -907,7 +908,7 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data,
        /* The scheduler owns a ref now: */
        msm_gem_submit_get(submit);
 
-       drm_sched_entity_push_job(&submit->base, &queue->entity);
+       drm_sched_entity_push_job(&submit->base, queue->entity);
 
        args->fence = submit->fence_id;
 
index 0e4b45b..030f82f 100644 (file)
@@ -257,6 +257,39 @@ struct msm_gpu_perfcntr {
  */
 #define NR_SCHED_PRIORITIES (1 + DRM_SCHED_PRIORITY_HIGH - DRM_SCHED_PRIORITY_MIN)
 
+/**
+ * struct msm_file_private - per-drm_file context
+ *
+ * @queuelock:    synchronizes access to submitqueues list
+ * @submitqueues: list of &msm_gpu_submitqueue created by userspace
+ * @queueid:      counter incremented each time a submitqueue is created,
+ *                used to assign &msm_gpu_submitqueue.id
+ * @aspace:       the per-process GPU address-space
+ * @ref:          reference count
+ * @seqno:        unique per process seqno
+ */
+struct msm_file_private {
+       rwlock_t queuelock;
+       struct list_head submitqueues;
+       int queueid;
+       struct msm_gem_address_space *aspace;
+       struct kref ref;
+       int seqno;
+
+       /**
+        * entities:
+        *
+        * Table of per-priority-level sched entities used by submitqueues
+        * associated with this &drm_file.  Because some userspace apps
+        * make assumptions about rendering from multiple gl contexts
+        * (of the same priority) within the process happening in FIFO
+        * order without requiring any fencing beyond MakeCurrent(), we
+        * create at most one &drm_sched_entity per-process per-priority-
+        * level.
+        */
+       struct drm_sched_entity *entities[NR_SCHED_PRIORITIES * MSM_GPU_MAX_RINGS];
+};
+
 /**
  * msm_gpu_convert_priority - Map userspace priority to ring # and sched priority
  *
@@ -304,6 +337,8 @@ static inline int msm_gpu_convert_priority(struct msm_gpu *gpu, int prio,
 }
 
 /**
+ * struct msm_gpu_submitqueues - Userspace created context.
+ *
  * A submitqueue is associated with a gl context or vk queue (or equiv)
  * in userspace.
  *
@@ -321,7 +356,7 @@ static inline int msm_gpu_convert_priority(struct msm_gpu *gpu, int prio,
  *             seqno, protected by submitqueue lock
  * @lock:      submitqueue lock
  * @ref:       reference count
- * @entity: the submit job-queue
+ * @entity:    the submit job-queue
  */
 struct msm_gpu_submitqueue {
        int id;
@@ -333,7 +368,7 @@ struct msm_gpu_submitqueue {
        struct idr fence_idr;
        struct mutex lock;
        struct kref ref;
-       struct drm_sched_entity entity;
+       struct drm_sched_entity *entity;
 };
 
 struct msm_gpu_state_bo {
@@ -421,6 +456,33 @@ static inline void gpu_write64(struct msm_gpu *gpu, u32 lo, u32 hi, u64 val)
 int msm_gpu_pm_suspend(struct msm_gpu *gpu);
 int msm_gpu_pm_resume(struct msm_gpu *gpu);
 
+int msm_submitqueue_init(struct drm_device *drm, struct msm_file_private *ctx);
+struct msm_gpu_submitqueue *msm_submitqueue_get(struct msm_file_private *ctx,
+               u32 id);
+int msm_submitqueue_create(struct drm_device *drm,
+               struct msm_file_private *ctx,
+               u32 prio, u32 flags, u32 *id);
+int msm_submitqueue_query(struct drm_device *drm, struct msm_file_private *ctx,
+               struct drm_msm_submitqueue_query *args);
+int msm_submitqueue_remove(struct msm_file_private *ctx, u32 id);
+void msm_submitqueue_close(struct msm_file_private *ctx);
+
+void msm_submitqueue_destroy(struct kref *kref);
+
+void __msm_file_private_destroy(struct kref *kref);
+
+static inline void msm_file_private_put(struct msm_file_private *ctx)
+{
+       kref_put(&ctx->ref, __msm_file_private_destroy);
+}
+
+static inline struct msm_file_private *msm_file_private_get(
+       struct msm_file_private *ctx)
+{
+       kref_get(&ctx->ref);
+       return ctx;
+}
+
 void msm_devfreq_init(struct msm_gpu *gpu);
 void msm_devfreq_cleanup(struct msm_gpu *gpu);
 void msm_devfreq_resume(struct msm_gpu *gpu);
index 0a1ee20..84e98c0 100644 (file)
@@ -151,6 +151,9 @@ void msm_devfreq_active(struct msm_gpu *gpu)
        unsigned int idle_time;
        unsigned long target_freq = df->idle_freq;
 
+       if (!df->devfreq)
+               return;
+
        /*
         * Hold devfreq lock to synchronize with get_dev_status()/
         * target() callbacks
@@ -186,6 +189,9 @@ void msm_devfreq_idle(struct msm_gpu *gpu)
        struct msm_gpu_devfreq *df = &gpu->devfreq;
        unsigned long idle_freq, target_freq = 0;
 
+       if (!df->devfreq)
+               return;
+
        /*
         * Hold devfreq lock to synchronize with get_dev_status()/
         * target() callbacks
index 32a55d8..b8621c6 100644 (file)
@@ -7,6 +7,24 @@
 
 #include "msm_gpu.h"
 
+void __msm_file_private_destroy(struct kref *kref)
+{
+       struct msm_file_private *ctx = container_of(kref,
+               struct msm_file_private, ref);
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(ctx->entities); i++) {
+               if (!ctx->entities[i])
+                       continue;
+
+               drm_sched_entity_destroy(ctx->entities[i]);
+               kfree(ctx->entities[i]);
+       }
+
+       msm_gem_address_space_put(ctx->aspace);
+       kfree(ctx);
+}
+
 void msm_submitqueue_destroy(struct kref *kref)
 {
        struct msm_gpu_submitqueue *queue = container_of(kref,
@@ -14,8 +32,6 @@ void msm_submitqueue_destroy(struct kref *kref)
 
        idr_destroy(&queue->fence_idr);
 
-       drm_sched_entity_destroy(&queue->entity);
-
        msm_file_private_put(queue->ctx);
 
        kfree(queue);
@@ -61,13 +77,47 @@ void msm_submitqueue_close(struct msm_file_private *ctx)
        }
 }
 
+static struct drm_sched_entity *
+get_sched_entity(struct msm_file_private *ctx, struct msm_ringbuffer *ring,
+                unsigned ring_nr, enum drm_sched_priority sched_prio)
+{
+       static DEFINE_MUTEX(entity_lock);
+       unsigned idx = (ring_nr * NR_SCHED_PRIORITIES) + sched_prio;
+
+       /* We should have already validated that the requested priority is
+        * valid by the time we get here.
+        */
+       if (WARN_ON(idx >= ARRAY_SIZE(ctx->entities)))
+               return ERR_PTR(-EINVAL);
+
+       mutex_lock(&entity_lock);
+
+       if (!ctx->entities[idx]) {
+               struct drm_sched_entity *entity;
+               struct drm_gpu_scheduler *sched = &ring->sched;
+               int ret;
+
+               entity = kzalloc(sizeof(*ctx->entities[idx]), GFP_KERNEL);
+
+               ret = drm_sched_entity_init(entity, sched_prio, &sched, 1, NULL);
+               if (ret) {
+                       kfree(entity);
+                       return ERR_PTR(ret);
+               }
+
+               ctx->entities[idx] = entity;
+       }
+
+       mutex_unlock(&entity_lock);
+
+       return ctx->entities[idx];
+}
+
 int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,
                u32 prio, u32 flags, u32 *id)
 {
        struct msm_drm_private *priv = drm->dev_private;
        struct msm_gpu_submitqueue *queue;
-       struct msm_ringbuffer *ring;
-       struct drm_gpu_scheduler *sched;
        enum drm_sched_priority sched_prio;
        unsigned ring_nr;
        int ret;
@@ -91,12 +141,10 @@ int msm_submitqueue_create(struct drm_device *drm, struct msm_file_private *ctx,
        queue->flags = flags;
        queue->ring_nr = ring_nr;
 
-       ring = priv->gpu->rb[ring_nr];
-       sched = &ring->sched;
-
-       ret = drm_sched_entity_init(&queue->entity,
-                       sched_prio, &sched, 1, NULL);
-       if (ret) {
+       queue->entity = get_sched_entity(ctx, priv->gpu->rb[ring_nr],
+                                        ring_nr, sched_prio);
+       if (IS_ERR(queue->entity)) {
+               ret = PTR_ERR(queue->entity);
                kfree(queue);
                return ret;
        }
@@ -140,10 +188,6 @@ int msm_submitqueue_init(struct drm_device *drm, struct msm_file_private *ctx)
         */
        default_prio = DIV_ROUND_UP(max_priority, 2);
 
-       INIT_LIST_HEAD(&ctx->submitqueues);
-
-       rwlock_init(&ctx->queuelock);
-
        return msm_submitqueue_create(drm, ctx, default_prio, 0, NULL);
 }
 
index b8c31b6..66f32d9 100644 (file)
@@ -704,6 +704,7 @@ static const struct file_operations nv50_crc_flip_threshold_fops = {
        .open = nv50_crc_debugfs_flip_threshold_open,
        .read = seq_read,
        .write = nv50_crc_debugfs_flip_threshold_set,
+       .release = single_release,
 };
 
 int nv50_head_crc_late_register(struct nv50_head *head)
index d66f972..72099d1 100644 (file)
@@ -52,6 +52,7 @@ nv50_head_flush_clr(struct nv50_head *head,
 void
 nv50_head_flush_set_wndw(struct nv50_head *head, struct nv50_head_atom *asyh)
 {
+       if (asyh->set.curs   ) head->func->curs_set(head, asyh);
        if (asyh->set.olut   ) {
                asyh->olut.offset = nv50_lut_load(&head->olut,
                                                  asyh->olut.buffer,
@@ -67,7 +68,6 @@ nv50_head_flush_set(struct nv50_head *head, struct nv50_head_atom *asyh)
        if (asyh->set.view   ) head->func->view    (head, asyh);
        if (asyh->set.mode   ) head->func->mode    (head, asyh);
        if (asyh->set.core   ) head->func->core_set(head, asyh);
-       if (asyh->set.curs   ) head->func->curs_set(head, asyh);
        if (asyh->set.base   ) head->func->base    (head, asyh);
        if (asyh->set.ovly   ) head->func->ovly    (head, asyh);
        if (asyh->set.dither ) head->func->dither  (head, asyh);
index c68cc95..a582c0c 100644 (file)
@@ -71,6 +71,7 @@
 #define PASCAL_CHANNEL_GPFIFO_A                       /* cla06f.h */ 0x0000c06f
 #define VOLTA_CHANNEL_GPFIFO_A                        /* clc36f.h */ 0x0000c36f
 #define TURING_CHANNEL_GPFIFO_A                       /* clc36f.h */ 0x0000c46f
+#define AMPERE_CHANNEL_GPFIFO_B                       /* clc36f.h */ 0x0000c76f
 
 #define NV50_DISP                                     /* cl5070.h */ 0x00005070
 #define G82_DISP                                      /* cl5070.h */ 0x00008270
 #define PASCAL_DMA_COPY_B                                            0x0000c1b5
 #define VOLTA_DMA_COPY_A                                             0x0000c3b5
 #define TURING_DMA_COPY_A                                            0x0000c5b5
+#define AMPERE_DMA_COPY_B                                            0x0000c7b5
 
 #define FERMI_DECOMPRESS                                             0x000090b8
 
index 54fab7c..64ee82c 100644 (file)
@@ -77,4 +77,5 @@ int gp100_fifo_new(struct nvkm_device *, enum nvkm_subdev_type, int inst, struct
 int gp10b_fifo_new(struct nvkm_device *, enum nvkm_subdev_type, int inst, struct nvkm_fifo **);
 int gv100_fifo_new(struct nvkm_device *, enum nvkm_subdev_type, int inst, struct nvkm_fifo **);
 int tu102_fifo_new(struct nvkm_device *, enum nvkm_subdev_type, int inst, struct nvkm_fifo **);
+int ga102_fifo_new(struct nvkm_device *, enum nvkm_subdev_type, int inst, struct nvkm_fifo **);
 #endif
index 6d07e65..c58bcdb 100644 (file)
@@ -844,6 +844,7 @@ nouveau_bo_move_init(struct nouveau_drm *drm)
                            struct ttm_resource *, struct ttm_resource *);
                int (*init)(struct nouveau_channel *, u32 handle);
        } _methods[] = {
+               {  "COPY", 4, 0xc7b5, nve0_bo_move_copy, nve0_bo_move_init },
                {  "COPY", 4, 0xc5b5, nve0_bo_move_copy, nve0_bo_move_init },
                {  "GRCE", 0, 0xc5b5, nve0_bo_move_copy, nvc0_bo_move_init },
                {  "COPY", 4, 0xc3b5, nve0_bo_move_copy, nve0_bo_move_init },
index 80099ef..ea77691 100644 (file)
@@ -250,7 +250,8 @@ static int
 nouveau_channel_ind(struct nouveau_drm *drm, struct nvif_device *device,
                    u64 runlist, bool priv, struct nouveau_channel **pchan)
 {
-       static const u16 oclasses[] = { TURING_CHANNEL_GPFIFO_A,
+       static const u16 oclasses[] = { AMPERE_CHANNEL_GPFIFO_B,
+                                       TURING_CHANNEL_GPFIFO_A,
                                        VOLTA_CHANNEL_GPFIFO_A,
                                        PASCAL_CHANNEL_GPFIFO_A,
                                        MAXWELL_CHANNEL_GPFIFO_A,
@@ -386,7 +387,8 @@ nouveau_channel_init(struct nouveau_channel *chan, u32 vram, u32 gart)
 
        nvif_object_map(&chan->user, NULL, 0);
 
-       if (chan->user.oclass >= FERMI_CHANNEL_GPFIFO) {
+       if (chan->user.oclass >= FERMI_CHANNEL_GPFIFO &&
+           chan->user.oclass < AMPERE_CHANNEL_GPFIFO_B) {
                ret = nvif_notify_ctor(&chan->user, "abi16ChanKilled",
                                       nouveau_channel_killed,
                                       true, NV906F_V0_NTFY_KILLED,
index c2bc05e..1cbe010 100644 (file)
@@ -207,6 +207,7 @@ static const struct file_operations nouveau_pstate_fops = {
        .open = nouveau_debugfs_pstate_open,
        .read = seq_read,
        .write = nouveau_debugfs_pstate_set,
+       .release = single_release,
 };
 
 static struct drm_info_list nouveau_debugfs_list[] = {
index 1f828c9..6109cd9 100644 (file)
@@ -345,6 +345,9 @@ nouveau_accel_gr_init(struct nouveau_drm *drm)
        u32 arg0, arg1;
        int ret;
 
+       if (device->info.family >= NV_DEVICE_INFO_V0_AMPERE)
+               return;
+
        /* Allocate channel that has access to the graphics engine. */
        if (device->info.family >= NV_DEVICE_INFO_V0_KEPLER) {
                arg0 = nvif_fifo_runlist(device, NV_DEVICE_HOST_RUNLIST_ENGINES_GR);
@@ -469,6 +472,7 @@ nouveau_accel_init(struct nouveau_drm *drm)
                case PASCAL_CHANNEL_GPFIFO_A:
                case VOLTA_CHANNEL_GPFIFO_A:
                case TURING_CHANNEL_GPFIFO_A:
+               case AMPERE_CHANNEL_GPFIFO_B:
                        ret = nvc0_fence_create(drm);
                        break;
                default:
index 5b27845..8c2ecc2 100644 (file)
@@ -247,10 +247,8 @@ nouveau_gem_new(struct nouveau_cli *cli, u64 size, int align, uint32_t domain,
        }
 
        ret = nouveau_bo_init(nvbo, size, align, domain, NULL, NULL);
-       if (ret) {
-               nouveau_bo_ref(NULL, &nvbo);
+       if (ret)
                return ret;
-       }
 
        /* we restrict allowed domains on nv50+ to only the types
         * that were requested at creation time.  not possibly on
index 7c9c928..c3526a8 100644 (file)
@@ -204,7 +204,7 @@ nv84_fence_create(struct nouveau_drm *drm)
        priv->base.context_new = nv84_fence_context_new;
        priv->base.context_del = nv84_fence_context_del;
 
-       priv->base.uevent = true;
+       priv->base.uevent = drm->client.device.info.family < NV_DEVICE_INFO_V0_AMPERE;
 
        mutex_init(&priv->mutex);
 
index 93ddf63..ca75c5f 100644 (file)
@@ -2602,6 +2602,7 @@ nv172_chipset = {
        .top      = { 0x00000001, ga100_top_new },
        .disp     = { 0x00000001, ga102_disp_new },
        .dma      = { 0x00000001, gv100_dma_new },
+       .fifo     = { 0x00000001, ga102_fifo_new },
 };
 
 static const struct nvkm_device_chip
@@ -2622,6 +2623,7 @@ nv174_chipset = {
        .top      = { 0x00000001, ga100_top_new },
        .disp     = { 0x00000001, ga102_disp_new },
        .dma      = { 0x00000001, gv100_dma_new },
+       .fifo     = { 0x00000001, ga102_fifo_new },
 };
 
 static const struct nvkm_device_chip
@@ -2642,6 +2644,7 @@ nv177_chipset = {
        .top      = { 0x00000001, ga100_top_new },
        .disp     = { 0x00000001, ga102_disp_new },
        .dma      = { 0x00000001, gv100_dma_new },
+       .fifo     = { 0x00000001, ga102_fifo_new },
 };
 
 static int
index b0ece71..ce77457 100644 (file)
@@ -57,7 +57,7 @@ nvkm_control_mthd_pstate_info(struct nvkm_control *ctrl, void *data, u32 size)
                args->v0.count = 0;
                args->v0.ustate_ac = NVIF_CONTROL_PSTATE_INFO_V0_USTATE_DISABLE;
                args->v0.ustate_dc = NVIF_CONTROL_PSTATE_INFO_V0_USTATE_DISABLE;
-               args->v0.pwrsrc = -ENOSYS;
+               args->v0.pwrsrc = -ENODEV;
                args->v0.pstate = NVIF_CONTROL_PSTATE_INFO_V0_PSTATE_UNKNOWN;
        }
 
index 3209eb7..5e831d3 100644 (file)
@@ -18,6 +18,7 @@ nvkm-y += nvkm/engine/fifo/gp100.o
 nvkm-y += nvkm/engine/fifo/gp10b.o
 nvkm-y += nvkm/engine/fifo/gv100.o
 nvkm-y += nvkm/engine/fifo/tu102.o
+nvkm-y += nvkm/engine/fifo/ga102.o
 
 nvkm-y += nvkm/engine/fifo/chan.o
 nvkm-y += nvkm/engine/fifo/channv50.o
index 353b77d..3492c56 100644 (file)
@@ -82,7 +82,7 @@ g84_fifo_chan_engine_fini(struct nvkm_fifo_chan *base,
        if (offset < 0)
                return 0;
 
-       engn = fifo->base.func->engine_id(&fifo->base, engine);
+       engn = fifo->base.func->engine_id(&fifo->base, engine) - 1;
        save = nvkm_mask(device, 0x002520, 0x0000003f, 1 << engn);
        nvkm_wr32(device, 0x0032fc, chan->base.inst->addr >> 12);
        done = nvkm_msec(device, 2000,
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c b/drivers/gpu/drm/nouveau/nvkm/engine/fifo/ga102.c
new file mode 100644 (file)
index 0000000..c630dbd
--- /dev/null
@@ -0,0 +1,311 @@
+/*
+ * Copyright 2021 Red Hat Inc.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in
+ * all copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
+ * OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
+ * ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
+ * OTHER DEALINGS IN THE SOFTWARE.
+ */
+#define ga102_fifo(p) container_of((p), struct ga102_fifo, base.engine)
+#define ga102_chan(p) container_of((p), struct ga102_chan, object)
+#include <engine/fifo.h>
+#include "user.h"
+
+#include <core/memory.h>
+#include <subdev/mmu.h>
+#include <subdev/timer.h>
+#include <subdev/top.h>
+
+#include <nvif/cl0080.h>
+#include <nvif/clc36f.h>
+#include <nvif/class.h>
+
+struct ga102_fifo {
+       struct nvkm_fifo base;
+};
+
+struct ga102_chan {
+       struct nvkm_object object;
+
+       struct {
+               u32 runl;
+               u32 chan;
+       } ctrl;
+
+       struct nvkm_memory *mthd;
+       struct nvkm_memory *inst;
+       struct nvkm_memory *user;
+       struct nvkm_memory *runl;
+
+       struct nvkm_vmm *vmm;
+};
+
+static int
+ga102_chan_sclass(struct nvkm_object *object, int index, struct nvkm_oclass *oclass)
+{
+       if (index == 0) {
+               oclass->ctor = nvkm_object_new;
+               oclass->base = (struct nvkm_sclass) { -1, -1, AMPERE_DMA_COPY_B };
+               return 0;
+       }
+
+       return -EINVAL;
+}
+
+static int
+ga102_chan_map(struct nvkm_object *object, void *argv, u32 argc,
+              enum nvkm_object_map *type, u64 *addr, u64 *size)
+{
+       struct ga102_chan *chan = ga102_chan(object);
+       struct nvkm_device *device = chan->object.engine->subdev.device;
+       u64 bar2 = nvkm_memory_bar2(chan->user);
+
+       if (bar2 == ~0ULL)
+               return -EFAULT;
+
+       *type = NVKM_OBJECT_MAP_IO;
+       *addr = device->func->resource_addr(device, 3) + bar2;
+       *size = 0x1000;
+       return 0;
+}
+
+static int
+ga102_chan_fini(struct nvkm_object *object, bool suspend)
+{
+       struct ga102_chan *chan = ga102_chan(object);
+       struct nvkm_device *device = chan->object.engine->subdev.device;
+
+       nvkm_wr32(device, chan->ctrl.chan, 0x00000003);
+
+       nvkm_wr32(device, chan->ctrl.runl + 0x098, 0x01000000);
+       nvkm_msec(device, 2000,
+               if (!(nvkm_rd32(device, chan->ctrl.runl + 0x098) & 0x00100000))
+                       break;
+       );
+
+       nvkm_wr32(device, chan->ctrl.runl + 0x088, 0);
+
+       nvkm_wr32(device, chan->ctrl.chan, 0xffffffff);
+       return 0;
+}
+
+static int
+ga102_chan_init(struct nvkm_object *object)
+{
+       struct ga102_chan *chan = ga102_chan(object);
+       struct nvkm_device *device = chan->object.engine->subdev.device;
+
+       nvkm_mask(device, chan->ctrl.runl + 0x300, 0x80000000, 0x80000000);
+
+       nvkm_wr32(device, chan->ctrl.runl + 0x080, lower_32_bits(nvkm_memory_addr(chan->runl)));
+       nvkm_wr32(device, chan->ctrl.runl + 0x084, upper_32_bits(nvkm_memory_addr(chan->runl)));
+       nvkm_wr32(device, chan->ctrl.runl + 0x088, 2);
+
+       nvkm_wr32(device, chan->ctrl.chan, 0x00000002);
+       nvkm_wr32(device, chan->ctrl.runl + 0x0090, 0);
+       return 0;
+}
+
+static void *
+ga102_chan_dtor(struct nvkm_object *object)
+{
+       struct ga102_chan *chan = ga102_chan(object);
+
+       if (chan->vmm) {
+               nvkm_vmm_part(chan->vmm, chan->inst);
+               nvkm_vmm_unref(&chan->vmm);
+       }
+
+       nvkm_memory_unref(&chan->runl);
+       nvkm_memory_unref(&chan->user);
+       nvkm_memory_unref(&chan->inst);
+       nvkm_memory_unref(&chan->mthd);
+       return chan;
+}
+
+static const struct nvkm_object_func
+ga102_chan = {
+       .dtor = ga102_chan_dtor,
+       .init = ga102_chan_init,
+       .fini = ga102_chan_fini,
+       .map = ga102_chan_map,
+       .sclass = ga102_chan_sclass,
+};
+
+static int
+ga102_chan_new(struct nvkm_device *device,
+              const struct nvkm_oclass *oclass, void *argv, u32 argc, struct nvkm_object **pobject)
+{
+       struct volta_channel_gpfifo_a_v0 *args = argv;
+       struct nvkm_top_device *tdev;
+       struct nvkm_vmm *vmm;
+       struct ga102_chan *chan;
+       int ret;
+
+       if (argc != sizeof(*args))
+               return -ENOSYS;
+
+       vmm = nvkm_uvmm_search(oclass->client, args->vmm);
+       if (IS_ERR(vmm))
+               return PTR_ERR(vmm);
+
+       if (!(chan = kzalloc(sizeof(*chan), GFP_KERNEL)))
+               return -ENOMEM;
+
+       nvkm_object_ctor(&ga102_chan, oclass, &chan->object);
+       *pobject = &chan->object;
+
+       list_for_each_entry(tdev, &device->top->device, head) {
+               if (tdev->type == NVKM_ENGINE_CE) {
+                       chan->ctrl.runl = tdev->runlist;
+                       break;
+               }
+       }
+
+       if (!chan->ctrl.runl)
+               return -ENODEV;
+
+       chan->ctrl.chan = nvkm_rd32(device, chan->ctrl.runl + 0x004) & 0xfffffff0;
+
+       args->chid = 0;
+       args->inst = 0;
+       args->token = nvkm_rd32(device, chan->ctrl.runl + 0x008) & 0xffff0000;
+
+       ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 0x1000, true, &chan->mthd);
+       if (ret)
+               return ret;
+
+       ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 0x1000, true, &chan->inst);
+       if (ret)
+               return ret;
+
+       nvkm_kmap(chan->inst);
+       nvkm_wo32(chan->inst, 0x010, 0x0000face);
+       nvkm_wo32(chan->inst, 0x030, 0x7ffff902);
+       nvkm_wo32(chan->inst, 0x048, lower_32_bits(args->ioffset));
+       nvkm_wo32(chan->inst, 0x04c, upper_32_bits(args->ioffset) |
+                                    (order_base_2(args->ilength / 8) << 16));
+       nvkm_wo32(chan->inst, 0x084, 0x20400000);
+       nvkm_wo32(chan->inst, 0x094, 0x30000001);
+       nvkm_wo32(chan->inst, 0x0ac, 0x00020000);
+       nvkm_wo32(chan->inst, 0x0e4, 0x00000000);
+       nvkm_wo32(chan->inst, 0x0e8, 0);
+       nvkm_wo32(chan->inst, 0x0f4, 0x00001000);
+       nvkm_wo32(chan->inst, 0x0f8, 0x10003080);
+       nvkm_mo32(chan->inst, 0x218, 0x00000000, 0x00000000);
+       nvkm_wo32(chan->inst, 0x220, lower_32_bits(nvkm_memory_bar2(chan->mthd)));
+       nvkm_wo32(chan->inst, 0x224, upper_32_bits(nvkm_memory_bar2(chan->mthd)));
+       nvkm_done(chan->inst);
+
+       ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 0x1000, true, &chan->user);
+       if (ret)
+               return ret;
+
+       ret = nvkm_memory_new(device, NVKM_MEM_TARGET_INST, 0x1000, 0x1000, true, &chan->runl);
+       if (ret)
+               return ret;
+
+       nvkm_kmap(chan->runl);
+       nvkm_wo32(chan->runl, 0x00, 0x80030001);
+       nvkm_wo32(chan->runl, 0x04, 1);
+       nvkm_wo32(chan->runl, 0x08, 0);
+       nvkm_wo32(chan->runl, 0x0c, 0x00000000);
+       nvkm_wo32(chan->runl, 0x10, lower_32_bits(nvkm_memory_addr(chan->user)));
+       nvkm_wo32(chan->runl, 0x14, upper_32_bits(nvkm_memory_addr(chan->user)));
+       nvkm_wo32(chan->runl, 0x18, lower_32_bits(nvkm_memory_addr(chan->inst)));
+       nvkm_wo32(chan->runl, 0x1c, upper_32_bits(nvkm_memory_addr(chan->inst)));
+       nvkm_done(chan->runl);
+
+       ret = nvkm_vmm_join(vmm, chan->inst);
+       if (ret)
+               return ret;
+
+       chan->vmm = nvkm_vmm_ref(vmm);
+       return 0;
+}
+
+static const struct nvkm_device_oclass
+ga102_chan_oclass = {
+       .ctor = ga102_chan_new,
+};
+
+static int
+ga102_user_new(struct nvkm_device *device,
+              const struct nvkm_oclass *oclass, void *argv, u32 argc, struct nvkm_object **pobject)
+{
+       return tu102_fifo_user_new(oclass, argv, argc, pobject);
+}
+
+static const struct nvkm_device_oclass
+ga102_user_oclass = {
+       .ctor = ga102_user_new,
+};
+
+static int
+ga102_fifo_sclass(struct nvkm_oclass *oclass, int index, const struct nvkm_device_oclass **class)
+{
+       if (index == 0) {
+               oclass->base = (struct nvkm_sclass) { -1, -1, VOLTA_USERMODE_A };
+               *class = &ga102_user_oclass;
+               return 0;
+       } else
+       if (index == 1) {
+               oclass->base = (struct nvkm_sclass) { 0, 0, AMPERE_CHANNEL_GPFIFO_B };
+               *class = &ga102_chan_oclass;
+               return 0;
+       }
+
+       return 2;
+}
+
+static int
+ga102_fifo_info(struct nvkm_engine *engine, u64 mthd, u64 *data)
+{
+       switch (mthd) {
+       case NV_DEVICE_HOST_CHANNELS: *data = 1; return 0;
+       default:
+               break;
+       }
+
+       return -ENOSYS;
+}
+
+static void *
+ga102_fifo_dtor(struct nvkm_engine *engine)
+{
+       return ga102_fifo(engine);
+}
+
+static const struct nvkm_engine_func
+ga102_fifo = {
+       .dtor = ga102_fifo_dtor,
+       .info = ga102_fifo_info,
+       .base.sclass = ga102_fifo_sclass,
+};
+
+int
+ga102_fifo_new(struct nvkm_device *device, enum nvkm_subdev_type type, int inst,
+              struct nvkm_fifo **pfifo)
+{
+       struct ga102_fifo *fifo;
+
+       if (!(fifo = kzalloc(sizeof(*fifo), GFP_KERNEL)))
+               return -ENOMEM;
+
+       nvkm_engine_ctor(&ga102_fifo, device, type, inst, true, &fifo->base.engine);
+       *pfifo = &fifo->base;
+       return 0;
+}
index 31933f3..c982d83 100644 (file)
@@ -54,7 +54,7 @@ ga100_top_oneinit(struct nvkm_top *top)
                        info->reset   = (data & 0x0000001f);
                        break;
                case 2:
-                       info->runlist = (data & 0x0000fc00) >> 10;
+                       info->runlist = (data & 0x00fffc00);
                        info->engine  = (data & 0x00000003);
                        break;
                default:
@@ -85,9 +85,10 @@ ga100_top_oneinit(struct nvkm_top *top)
                }
 
                nvkm_debug(subdev, "%02x.%d (%8s): addr %06x fault %2d "
-                                  "runlist %2d engine %2d reset %2d\n", type, inst,
+                                  "runlist %6x engine %2d reset %2d\n", type, inst,
                           info->type == NVKM_SUBDEV_NR ? "????????" : nvkm_subdev_type[info->type],
-                          info->addr, info->fault, info->runlist, info->engine, info->reset);
+                          info->addr, info->fault, info->runlist < 0 ? 0 : info->runlist,
+                          info->engine, info->reset);
                info = NULL;
        }
 
index beb581b..418638e 100644 (file)
@@ -295,6 +295,7 @@ config DRM_PANEL_OLIMEX_LCD_OLINUXINO
        depends on OF
        depends on I2C
        depends on BACKLIGHT_CLASS_DEVICE
+       select CRC32
        help
          The panel is used with different sizes LCDs, from 480x272 to
          1280x800, and 24 bit per pixel.
index 2d8794d..3d8a9ab 100644 (file)
@@ -146,8 +146,8 @@ static const struct reg_sequence y030xx067a_init_sequence[] = {
        { 0x09, REG09_SUB_BRIGHT_R(0x20) },
        { 0x0a, REG0A_SUB_BRIGHT_B(0x20) },
        { 0x0b, REG0B_HD_FREERUN | REG0B_VD_FREERUN },
-       { 0x0c, REG0C_CONTRAST_R(0x10) },
-       { 0x0d, REG0D_CONTRAST_G(0x10) },
+       { 0x0c, REG0C_CONTRAST_R(0x00) },
+       { 0x0d, REG0D_CONTRAST_G(0x00) },
        { 0x0e, REG0E_CONTRAST_B(0x10) },
        { 0x0f, 0 },
        { 0x10, REG10_BRIGHT(0x7f) },
index 0ecccf2..d2a0f53 100644 (file)
@@ -214,7 +214,7 @@ int drm_ati_pcigart_init(struct drm_device *dev, struct drm_ati_pcigart_info *ga
        }
        ret = 0;
 
-#if defined(__i386__) || defined(__x86_64__)
+#ifdef CONFIG_X86
        wbinvd();
 #else
        mb();
index 0473583..482fb0a 100644 (file)
@@ -119,7 +119,7 @@ int radeon_driver_load_kms(struct drm_device *dev, unsigned long flags)
 #endif
 
        if (pci_find_capability(pdev, PCI_CAP_ID_AGP))
-               rdev->agp = radeon_agp_head_init(rdev->ddev);
+               rdev->agp = radeon_agp_head_init(dev);
        if (rdev->agp) {
                rdev->agp->agp_mtrr = arch_phys_wc_add(
                        rdev->agp->agp_info.aper_base,
index 0daa8bb..4bf4e25 100644 (file)
@@ -86,12 +86,20 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu,
        }
 
        /*
-        * Create and initialize the encoder. On Gen3 skip the LVDS1 output if
+        * Create and initialize the encoder. On Gen3, skip the LVDS1 output if
         * the LVDS1 encoder is used as a companion for LVDS0 in dual-link
-        * mode.
+        * mode, or any LVDS output if it isn't connected. The latter may happen
+        * on D3 or E3 as the LVDS encoders are needed to provide the pixel
+        * clock to the DU, even when the LVDS outputs are not used.
         */
-       if (rcdu->info->gen >= 3 && output == RCAR_DU_OUTPUT_LVDS1) {
-               if (rcar_lvds_dual_link(bridge))
+       if (rcdu->info->gen >= 3) {
+               if (output == RCAR_DU_OUTPUT_LVDS1 &&
+                   rcar_lvds_dual_link(bridge))
+                       return -ENOLINK;
+
+               if ((output == RCAR_DU_OUTPUT_LVDS0 ||
+                    output == RCAR_DU_OUTPUT_LVDS1) &&
+                   !rcar_lvds_is_connected(bridge))
                        return -ENOLINK;
        }
 
index d061b8d..b672c5b 100644 (file)
@@ -576,6 +576,9 @@ static int rcar_lvds_attach(struct drm_bridge *bridge,
 {
        struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge);
 
+       if (!lvds->next_bridge)
+               return 0;
+
        return drm_bridge_attach(bridge->encoder, lvds->next_bridge, bridge,
                                 flags);
 }
@@ -598,6 +601,14 @@ bool rcar_lvds_dual_link(struct drm_bridge *bridge)
 }
 EXPORT_SYMBOL_GPL(rcar_lvds_dual_link);
 
+bool rcar_lvds_is_connected(struct drm_bridge *bridge)
+{
+       struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge);
+
+       return lvds->next_bridge != NULL;
+}
+EXPORT_SYMBOL_GPL(rcar_lvds_is_connected);
+
 /* -----------------------------------------------------------------------------
  * Probe & Remove
  */
index 222ec0e..eb7c6ef 100644 (file)
@@ -16,6 +16,7 @@ struct drm_bridge;
 int rcar_lvds_clk_enable(struct drm_bridge *bridge, unsigned long freq);
 void rcar_lvds_clk_disable(struct drm_bridge *bridge);
 bool rcar_lvds_dual_link(struct drm_bridge *bridge);
+bool rcar_lvds_is_connected(struct drm_bridge *bridge);
 #else
 static inline int rcar_lvds_clk_enable(struct drm_bridge *bridge,
                                       unsigned long freq)
@@ -27,6 +28,10 @@ static inline bool rcar_lvds_dual_link(struct drm_bridge *bridge)
 {
        return false;
 }
+static inline bool rcar_lvds_is_connected(struct drm_bridge *bridge)
+{
+       return false;
+}
 #endif /* CONFIG_DRM_RCAR_LVDS */
 
 #endif /* __RCAR_LVDS_H__ */
index 8ab3247..13c6b85 100644 (file)
@@ -1123,7 +1123,7 @@ static int cdn_dp_suspend(struct device *dev)
        return ret;
 }
 
-static int cdn_dp_resume(struct device *dev)
+static __maybe_unused int cdn_dp_resume(struct device *dev)
 {
        struct cdn_dp_device *dp = dev_get_drvdata(dev);
 
index ba9e14d..a25b98b 100644 (file)
@@ -1174,26 +1174,24 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
         *
         * Action plan:
         *
-        * 1. When DRM gives us a mode, we should add 999 Hz to it.  That way
-        *    if the clock we need is 60000001 Hz (~60 MHz) and DRM tells us to
-        *    make 60000 kHz then the clock framework will actually give us
-        *    the right clock.
+        * 1. Try to set the exact rate first, and confirm the clock framework
+        *    can provide it.
         *
-        *    NOTE: if the PLL (maybe through a divider) could actually make
-        *    a clock rate 999 Hz higher instead of the one we want then this
-        *    could be a problem.  Unfortunately there's not much we can do
-        *    since it's baked into DRM to use kHz.  It shouldn't matter in
-        *    practice since Rockchip PLLs are controlled by tables and
-        *    even if there is a divider in the middle I wouldn't expect PLL
-        *    rates in the table that are just a few kHz different.
+        * 2. If the clock framework cannot provide the exact rate, we should
+        *    add 999 Hz to the requested rate.  That way if the clock we need
+        *    is 60000001 Hz (~60 MHz) and DRM tells us to make 60000 kHz then
+        *    the clock framework will actually give us the right clock.
         *
-        * 2. Get the clock framework to round the rate for us to tell us
+        * 3. Get the clock framework to round the rate for us to tell us
         *    what it will actually make.
         *
-        * 3. Store the rounded up rate so that we don't need to worry about
+        * 4. Store the rounded up rate so that we don't need to worry about
         *    this in the actual clk_set_rate().
         */
-       rate = clk_round_rate(vop->dclk, adjusted_mode->clock * 1000 + 999);
+       rate = clk_round_rate(vop->dclk, adjusted_mode->clock * 1000);
+       if (rate / 1000 != adjusted_mode->clock)
+               rate = clk_round_rate(vop->dclk,
+                                     adjusted_mode->clock * 1000 + 999);
        adjusted_mode->clock = DIV_ROUND_UP(rate, 1000);
 
        return true;
index f75fb15..016b877 100644 (file)
@@ -216,11 +216,13 @@ static int sun8i_dw_hdmi_bind(struct device *dev, struct device *master,
                goto err_disable_clk_tmds;
        }
 
+       ret = sun8i_hdmi_phy_init(hdmi->phy);
+       if (ret)
+               goto err_disable_clk_tmds;
+
        drm_encoder_helper_add(encoder, &sun8i_dw_hdmi_encoder_helper_funcs);
        drm_simple_encoder_init(drm, encoder, DRM_MODE_ENCODER_TMDS);
 
-       sun8i_hdmi_phy_init(hdmi->phy);
-
        plat_data->mode_valid = hdmi->quirks->mode_valid;
        plat_data->use_drm_infoframe = hdmi->quirks->use_drm_infoframe;
        sun8i_hdmi_phy_set_ops(hdmi->phy, plat_data);
@@ -262,6 +264,7 @@ static void sun8i_dw_hdmi_unbind(struct device *dev, struct device *master,
        struct sun8i_dw_hdmi *hdmi = dev_get_drvdata(dev);
 
        dw_hdmi_unbind(hdmi->hdmi);
+       sun8i_hdmi_phy_deinit(hdmi->phy);
        clk_disable_unprepare(hdmi->clk_tmds);
        reset_control_assert(hdmi->rst_ctrl);
        gpiod_set_value(hdmi->ddc_en, 0);
index 74f6ed0..bffe1b9 100644 (file)
@@ -169,6 +169,7 @@ struct sun8i_hdmi_phy {
        struct clk                      *clk_phy;
        struct clk                      *clk_pll0;
        struct clk                      *clk_pll1;
+       struct device                   *dev;
        unsigned int                    rcal;
        struct regmap                   *regs;
        struct reset_control            *rst_phy;
@@ -205,7 +206,8 @@ encoder_to_sun8i_dw_hdmi(struct drm_encoder *encoder)
 
 int sun8i_hdmi_phy_get(struct sun8i_dw_hdmi *hdmi, struct device_node *node);
 
-void sun8i_hdmi_phy_init(struct sun8i_hdmi_phy *phy);
+int sun8i_hdmi_phy_init(struct sun8i_hdmi_phy *phy);
+void sun8i_hdmi_phy_deinit(struct sun8i_hdmi_phy *phy);
 void sun8i_hdmi_phy_set_ops(struct sun8i_hdmi_phy *phy,
                            struct dw_hdmi_plat_data *plat_data);
 
index c923970..b64d93d 100644 (file)
@@ -506,9 +506,60 @@ static void sun8i_hdmi_phy_init_h3(struct sun8i_hdmi_phy *phy)
        phy->rcal = (val & SUN8I_HDMI_PHY_ANA_STS_RCAL_MASK) >> 2;
 }
 
-void sun8i_hdmi_phy_init(struct sun8i_hdmi_phy *phy)
+int sun8i_hdmi_phy_init(struct sun8i_hdmi_phy *phy)
 {
+       int ret;
+
+       ret = reset_control_deassert(phy->rst_phy);
+       if (ret) {
+               dev_err(phy->dev, "Cannot deassert phy reset control: %d\n", ret);
+               return ret;
+       }
+
+       ret = clk_prepare_enable(phy->clk_bus);
+       if (ret) {
+               dev_err(phy->dev, "Cannot enable bus clock: %d\n", ret);
+               goto err_assert_rst_phy;
+       }
+
+       ret = clk_prepare_enable(phy->clk_mod);
+       if (ret) {
+               dev_err(phy->dev, "Cannot enable mod clock: %d\n", ret);
+               goto err_disable_clk_bus;
+       }
+
+       if (phy->variant->has_phy_clk) {
+               ret = sun8i_phy_clk_create(phy, phy->dev,
+                                          phy->variant->has_second_pll);
+               if (ret) {
+                       dev_err(phy->dev, "Couldn't create the PHY clock\n");
+                       goto err_disable_clk_mod;
+               }
+
+               clk_prepare_enable(phy->clk_phy);
+       }
+
        phy->variant->phy_init(phy);
+
+       return 0;
+
+err_disable_clk_mod:
+       clk_disable_unprepare(phy->clk_mod);
+err_disable_clk_bus:
+       clk_disable_unprepare(phy->clk_bus);
+err_assert_rst_phy:
+       reset_control_assert(phy->rst_phy);
+
+       return ret;
+}
+
+void sun8i_hdmi_phy_deinit(struct sun8i_hdmi_phy *phy)
+{
+       clk_disable_unprepare(phy->clk_mod);
+       clk_disable_unprepare(phy->clk_bus);
+       clk_disable_unprepare(phy->clk_phy);
+
+       reset_control_assert(phy->rst_phy);
 }
 
 void sun8i_hdmi_phy_set_ops(struct sun8i_hdmi_phy *phy,
@@ -638,6 +689,7 @@ static int sun8i_hdmi_phy_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        phy->variant = (struct sun8i_hdmi_phy_variant *)match->data;
+       phy->dev = dev;
 
        ret = of_address_to_resource(node, 0, &res);
        if (ret) {
@@ -696,47 +748,10 @@ static int sun8i_hdmi_phy_probe(struct platform_device *pdev)
                goto err_put_clk_pll1;
        }
 
-       ret = reset_control_deassert(phy->rst_phy);
-       if (ret) {
-               dev_err(dev, "Cannot deassert phy reset control: %d\n", ret);
-               goto err_put_rst_phy;
-       }
-
-       ret = clk_prepare_enable(phy->clk_bus);
-       if (ret) {
-               dev_err(dev, "Cannot enable bus clock: %d\n", ret);
-               goto err_deassert_rst_phy;
-       }
-
-       ret = clk_prepare_enable(phy->clk_mod);
-       if (ret) {
-               dev_err(dev, "Cannot enable mod clock: %d\n", ret);
-               goto err_disable_clk_bus;
-       }
-
-       if (phy->variant->has_phy_clk) {
-               ret = sun8i_phy_clk_create(phy, dev,
-                                          phy->variant->has_second_pll);
-               if (ret) {
-                       dev_err(dev, "Couldn't create the PHY clock\n");
-                       goto err_disable_clk_mod;
-               }
-
-               clk_prepare_enable(phy->clk_phy);
-       }
-
        platform_set_drvdata(pdev, phy);
 
        return 0;
 
-err_disable_clk_mod:
-       clk_disable_unprepare(phy->clk_mod);
-err_disable_clk_bus:
-       clk_disable_unprepare(phy->clk_bus);
-err_deassert_rst_phy:
-       reset_control_assert(phy->rst_phy);
-err_put_rst_phy:
-       reset_control_put(phy->rst_phy);
 err_put_clk_pll1:
        clk_put(phy->clk_pll1);
 err_put_clk_pll0:
@@ -753,12 +768,6 @@ static int sun8i_hdmi_phy_remove(struct platform_device *pdev)
 {
        struct sun8i_hdmi_phy *phy = platform_get_drvdata(pdev);
 
-       clk_disable_unprepare(phy->clk_mod);
-       clk_disable_unprepare(phy->clk_bus);
-       clk_disable_unprepare(phy->clk_phy);
-
-       reset_control_assert(phy->rst_phy);
-
        reset_control_put(phy->rst_phy);
 
        clk_put(phy->clk_pll0);
index 16c7aab..a29d64f 100644 (file)
@@ -1845,7 +1845,6 @@ tegra_crtc_update_memory_bandwidth(struct drm_crtc *crtc,
                                   bool prepare_bandwidth_transition)
 {
        const struct tegra_plane_state *old_tegra_state, *new_tegra_state;
-       const struct tegra_dc_state *old_dc_state, *new_dc_state;
        u32 i, new_avg_bw, old_avg_bw, new_peak_bw, old_peak_bw;
        const struct drm_plane_state *old_plane_state;
        const struct drm_crtc_state *old_crtc_state;
@@ -1858,8 +1857,6 @@ tegra_crtc_update_memory_bandwidth(struct drm_crtc *crtc,
                return;
 
        old_crtc_state = drm_atomic_get_old_crtc_state(state, crtc);
-       old_dc_state = to_const_dc_state(old_crtc_state);
-       new_dc_state = to_const_dc_state(crtc->state);
 
        if (!crtc->state->active) {
                if (!old_crtc_state->active)
index f0cb691..4037830 100644 (file)
@@ -35,12 +35,6 @@ static inline struct tegra_dc_state *to_dc_state(struct drm_crtc_state *state)
        return NULL;
 }
 
-static inline const struct tegra_dc_state *
-to_const_dc_state(const struct drm_crtc_state *state)
-{
-       return to_dc_state((struct drm_crtc_state *)state);
-}
-
 struct tegra_dc_stats {
        unsigned long frames;
        unsigned long vblank;
index dc16a24..690a339 100644 (file)
@@ -222,7 +222,7 @@ int tegra_drm_ioctl_channel_map(struct drm_device *drm, void *data, struct drm_f
                mapping->iova = sg_dma_address(mapping->sgt->sgl);
        }
 
-       mapping->iova_end = mapping->iova + host1x_to_tegra_bo(mapping->bo)->size;
+       mapping->iova_end = mapping->iova + host1x_to_tegra_bo(mapping->bo)->gem.size;
 
        err = xa_alloc(&context->mappings, &args->mapping, mapping, XA_LIMIT(1, U32_MAX),
                       GFP_KERNEL);
index cb38b1a..82cbb29 100644 (file)
@@ -383,7 +383,8 @@ int ttm_pool_alloc(struct ttm_pool *pool, struct ttm_tt *tt,
        else
                gfp_flags |= GFP_HIGHUSER;
 
-       for (order = min(MAX_ORDER - 1UL, __fls(num_pages)); num_pages;
+       for (order = min_t(unsigned int, MAX_ORDER - 1, __fls(num_pages));
+            num_pages;
             order = min_t(unsigned int, order, __fls(num_pages))) {
                bool apply_caching = false;
                struct ttm_pool_type *pt;
index 4a11150..ed8a4b7 100644 (file)
@@ -167,8 +167,6 @@ vc4_hdmi_connector_detect(struct drm_connector *connector, bool force)
        struct vc4_hdmi *vc4_hdmi = connector_to_vc4_hdmi(connector);
        bool connected = false;
 
-       WARN_ON(pm_runtime_resume_and_get(&vc4_hdmi->pdev->dev));
-
        if (vc4_hdmi->hpd_gpio &&
            gpiod_get_value_cansleep(vc4_hdmi->hpd_gpio)) {
                connected = true;
@@ -189,12 +187,10 @@ vc4_hdmi_connector_detect(struct drm_connector *connector, bool force)
                        }
                }
 
-               pm_runtime_put(&vc4_hdmi->pdev->dev);
                return connector_status_connected;
        }
 
        cec_phys_addr_invalidate(vc4_hdmi->cec_adap);
-       pm_runtime_put(&vc4_hdmi->pdev->dev);
        return connector_status_disconnected;
 }
 
@@ -436,7 +432,7 @@ static void vc4_hdmi_set_avi_infoframe(struct drm_encoder *encoder)
        struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
        struct drm_connector *connector = &vc4_hdmi->connector;
        struct drm_connector_state *cstate = connector->state;
-       struct drm_crtc *crtc = cstate->crtc;
+       struct drm_crtc *crtc = encoder->crtc;
        const struct drm_display_mode *mode = &crtc->state->adjusted_mode;
        union hdmi_infoframe frame;
        int ret;
@@ -541,11 +537,8 @@ static bool vc4_hdmi_supports_scrambling(struct drm_encoder *encoder,
 
 static void vc4_hdmi_enable_scrambling(struct drm_encoder *encoder)
 {
+       struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
-       struct drm_connector *connector = &vc4_hdmi->connector;
-       struct drm_connector_state *cstate = connector->state;
-       struct drm_crtc *crtc = cstate->crtc;
-       struct drm_display_mode *mode = &crtc->state->adjusted_mode;
 
        if (!vc4_hdmi_supports_scrambling(encoder, mode))
                return;
@@ -566,18 +559,17 @@ static void vc4_hdmi_enable_scrambling(struct drm_encoder *encoder)
 static void vc4_hdmi_disable_scrambling(struct drm_encoder *encoder)
 {
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
-       struct drm_connector *connector = &vc4_hdmi->connector;
-       struct drm_connector_state *cstate = connector->state;
+       struct drm_crtc *crtc = encoder->crtc;
 
        /*
-        * At boot, connector->state will be NULL. Since we don't know the
+        * At boot, encoder->crtc will be NULL. Since we don't know the
         * state of the scrambler and in order to avoid any
         * inconsistency, let's disable it all the time.
         */
-       if (cstate && !vc4_hdmi_supports_scrambling(encoder, &cstate->crtc->mode))
+       if (crtc && !vc4_hdmi_supports_scrambling(encoder, &crtc->mode))
                return;
 
-       if (cstate && !vc4_hdmi_mode_needs_scrambling(&cstate->crtc->mode))
+       if (crtc && !vc4_hdmi_mode_needs_scrambling(&crtc->mode))
                return;
 
        if (delayed_work_pending(&vc4_hdmi->scrambling_work))
@@ -635,6 +627,7 @@ static void vc4_hdmi_encoder_post_crtc_powerdown(struct drm_encoder *encoder,
                vc4_hdmi->variant->phy_disable(vc4_hdmi);
 
        clk_disable_unprepare(vc4_hdmi->pixel_bvb_clock);
+       clk_disable_unprepare(vc4_hdmi->hsm_clock);
        clk_disable_unprepare(vc4_hdmi->pixel_clock);
 
        ret = pm_runtime_put(&vc4_hdmi->pdev->dev);
@@ -898,9 +891,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
                vc4_hdmi_encoder_get_connector_state(encoder, state);
        struct vc4_hdmi_connector_state *vc4_conn_state =
                conn_state_to_vc4_hdmi_conn_state(conn_state);
-       struct drm_crtc_state *crtc_state =
-               drm_atomic_get_new_crtc_state(state, conn_state->crtc);
-       struct drm_display_mode *mode = &crtc_state->adjusted_mode;
+       struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
        unsigned long bvb_rate, pixel_rate, hsm_rate;
        int ret;
@@ -947,6 +938,13 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
                return;
        }
 
+       ret = clk_prepare_enable(vc4_hdmi->hsm_clock);
+       if (ret) {
+               DRM_ERROR("Failed to turn on HSM clock: %d\n", ret);
+               clk_disable_unprepare(vc4_hdmi->pixel_clock);
+               return;
+       }
+
        vc4_hdmi_cec_update_clk_div(vc4_hdmi);
 
        if (pixel_rate > 297000000)
@@ -959,6 +957,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
        ret = clk_set_min_rate(vc4_hdmi->pixel_bvb_clock, bvb_rate);
        if (ret) {
                DRM_ERROR("Failed to set pixel bvb clock rate: %d\n", ret);
+               clk_disable_unprepare(vc4_hdmi->hsm_clock);
                clk_disable_unprepare(vc4_hdmi->pixel_clock);
                return;
        }
@@ -966,6 +965,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
        ret = clk_prepare_enable(vc4_hdmi->pixel_bvb_clock);
        if (ret) {
                DRM_ERROR("Failed to turn on pixel bvb clock: %d\n", ret);
+               clk_disable_unprepare(vc4_hdmi->hsm_clock);
                clk_disable_unprepare(vc4_hdmi->pixel_clock);
                return;
        }
@@ -985,11 +985,7 @@ static void vc4_hdmi_encoder_pre_crtc_configure(struct drm_encoder *encoder,
 static void vc4_hdmi_encoder_pre_crtc_enable(struct drm_encoder *encoder,
                                             struct drm_atomic_state *state)
 {
-       struct drm_connector_state *conn_state =
-               vc4_hdmi_encoder_get_connector_state(encoder, state);
-       struct drm_crtc_state *crtc_state =
-               drm_atomic_get_new_crtc_state(state, conn_state->crtc);
-       struct drm_display_mode *mode = &crtc_state->adjusted_mode;
+       struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
        struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
 
@@ -1012,11 +1008,7 @@ static void vc4_hdmi_encoder_pre_crtc_enable(struct drm_encoder *encoder,
 static void vc4_hdmi_encoder_post_crtc_enable(struct drm_encoder *encoder,
                                              struct drm_atomic_state *state)
 {
-       struct drm_connector_state *conn_state =
-               vc4_hdmi_encoder_get_connector_state(encoder, state);
-       struct drm_crtc_state *crtc_state =
-               drm_atomic_get_new_crtc_state(state, conn_state->crtc);
-       struct drm_display_mode *mode = &crtc_state->adjusted_mode;
+       struct drm_display_mode *mode = &encoder->crtc->state->adjusted_mode;
        struct vc4_hdmi *vc4_hdmi = encoder_to_vc4_hdmi(encoder);
        struct vc4_hdmi_encoder *vc4_encoder = to_vc4_hdmi_encoder(encoder);
        bool hsync_pos = mode->flags & DRM_MODE_FLAG_PHSYNC;
@@ -1204,8 +1196,8 @@ static void vc4_hdmi_audio_set_mai_clock(struct vc4_hdmi *vc4_hdmi,
 
 static void vc4_hdmi_set_n_cts(struct vc4_hdmi *vc4_hdmi, unsigned int samplerate)
 {
-       struct drm_connector *connector = &vc4_hdmi->connector;
-       struct drm_crtc *crtc = connector->state->crtc;
+       struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
+       struct drm_crtc *crtc = encoder->crtc;
        const struct drm_display_mode *mode = &crtc->state->adjusted_mode;
        u32 n, cts;
        u64 tmp;
@@ -1238,13 +1230,13 @@ static inline struct vc4_hdmi *dai_to_hdmi(struct snd_soc_dai *dai)
 static int vc4_hdmi_audio_startup(struct device *dev, void *data)
 {
        struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
-       struct drm_connector *connector = &vc4_hdmi->connector;
+       struct drm_encoder *encoder = &vc4_hdmi->encoder.base.base;
 
        /*
         * If the HDMI encoder hasn't probed, or the encoder is
         * currently in DVI mode, treat the codec dai as missing.
         */
-       if (!connector->state || !(HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
+       if (!encoder->crtc || !(HDMI_READ(HDMI_RAM_PACKET_CONFIG) &
                                VC4_HDMI_RAM_PACKET_ENABLE))
                return -ENODEV;
 
@@ -1403,14 +1395,6 @@ static int vc4_hdmi_audio_prepare(struct device *dev, void *data,
        return 0;
 }
 
-static const struct snd_soc_dapm_widget vc4_hdmi_audio_widgets[] = {
-       SND_SOC_DAPM_OUTPUT("TX"),
-};
-
-static const struct snd_soc_dapm_route vc4_hdmi_audio_routes[] = {
-       { "TX", NULL, "Playback" },
-};
-
 static const struct snd_soc_component_driver vc4_hdmi_audio_cpu_dai_comp = {
        .name = "vc4-hdmi-cpu-dai-component",
 };
@@ -2114,29 +2098,6 @@ static int vc5_hdmi_init_resources(struct vc4_hdmi *vc4_hdmi)
        return 0;
 }
 
-#ifdef CONFIG_PM
-static int vc4_hdmi_runtime_suspend(struct device *dev)
-{
-       struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
-
-       clk_disable_unprepare(vc4_hdmi->hsm_clock);
-
-       return 0;
-}
-
-static int vc4_hdmi_runtime_resume(struct device *dev)
-{
-       struct vc4_hdmi *vc4_hdmi = dev_get_drvdata(dev);
-       int ret;
-
-       ret = clk_prepare_enable(vc4_hdmi->hsm_clock);
-       if (ret)
-               return ret;
-
-       return 0;
-}
-#endif
-
 static int vc4_hdmi_bind(struct device *dev, struct device *master, void *data)
 {
        const struct vc4_hdmi_variant *variant = of_device_get_match_data(dev);
@@ -2391,18 +2352,11 @@ static const struct of_device_id vc4_hdmi_dt_match[] = {
        {}
 };
 
-static const struct dev_pm_ops vc4_hdmi_pm_ops = {
-       SET_RUNTIME_PM_OPS(vc4_hdmi_runtime_suspend,
-                          vc4_hdmi_runtime_resume,
-                          NULL)
-};
-
 struct platform_driver vc4_hdmi_driver = {
        .probe = vc4_hdmi_dev_probe,
        .remove = vc4_hdmi_dev_remove,
        .driver = {
                .name = "vc4_hdmi",
                .of_match_table = vc4_hdmi_dt_match,
-               .pm = &vc4_hdmi_pm_ops,
        },
 };
index 6941add..ecab728 100644 (file)
@@ -15,7 +15,7 @@
 #include "intr.h"
 #include "syncpt.h"
 
-DEFINE_SPINLOCK(lock);
+static DEFINE_SPINLOCK(lock);
 
 struct host1x_syncpt_fence {
        struct dma_fence base;
@@ -152,8 +152,10 @@ struct dma_fence *host1x_fence_create(struct host1x_syncpt *sp, u32 threshold)
                return ERR_PTR(-ENOMEM);
 
        fence->waiter = kzalloc(sizeof(*fence->waiter), GFP_KERNEL);
-       if (!fence->waiter)
+       if (!fence->waiter) {
+               kfree(fence);
                return ERR_PTR(-ENOMEM);
+       }
 
        fence->sp = sp;
        fence->threshold = threshold;
index 79b138f..05c007b 100644 (file)
@@ -255,13 +255,13 @@ static int amd_mp2_pci_probe(struct pci_dev *pdev, const struct pci_device_id *i
        if (!privdata->cl_data)
                return -ENOMEM;
 
-       rc = devm_add_action_or_reset(&pdev->dev, amd_mp2_pci_remove, privdata);
+       mp2_select_ops(privdata);
+
+       rc = amd_sfh_hid_client_init(privdata);
        if (rc)
                return rc;
 
-       mp2_select_ops(privdata);
-
-       return amd_sfh_hid_client_init(privdata);
+       return devm_add_action_or_reset(&pdev->dev, amd_mp2_pci_remove, privdata);
 }
 
 static int __maybe_unused amd_mp2_pci_resume(struct device *dev)
index 833fcf0..6ccfa0c 100644 (file)
@@ -336,12 +336,19 @@ static int apple_event(struct hid_device *hdev, struct hid_field *field,
 
 /*
  * MacBook JIS keyboard has wrong logical maximum
+ * Magic Keyboard JIS has wrong logical maximum
  */
 static __u8 *apple_report_fixup(struct hid_device *hdev, __u8 *rdesc,
                unsigned int *rsize)
 {
        struct apple_sc *asc = hid_get_drvdata(hdev);
 
+       if(*rsize >=71 && rdesc[70] == 0x65 && rdesc[64] == 0x65) {
+               hid_info(hdev,
+                        "fixing up Magic Keyboard JIS report descriptor\n");
+               rdesc[64] = rdesc[70] = 0xe7;
+       }
+
        if ((asc->quirks & APPLE_RDESC_JIS) && *rsize >= 60 &&
                        rdesc[53] == 0x65 && rdesc[59] == 0x65) {
                hid_info(hdev,
index 0790fbd..467d789 100644 (file)
@@ -56,15 +56,22 @@ static int betopff_init(struct hid_device *hid)
 {
        struct betopff_device *betopff;
        struct hid_report *report;
-       struct hid_input *hidinput =
-                       list_first_entry(&hid->inputs, struct hid_input, list);
+       struct hid_input *hidinput;
        struct list_head *report_list =
                        &hid->report_enum[HID_OUTPUT_REPORT].report_list;
-       struct input_dev *dev = hidinput->input;
+       struct input_dev *dev;
        int field_count = 0;
        int error;
        int i, j;
 
+       if (list_empty(&hid->inputs)) {
+               hid_err(hid, "no inputs found\n");
+               return -ENODEV;
+       }
+
+       hidinput = list_first_entry(&hid->inputs, struct hid_input, list);
+       dev = hidinput->input;
+
        if (list_empty(report_list)) {
                hid_err(hid, "no output reports found\n");
                return -ENODEV;
index 95e0807..d70cd3d 100644 (file)
@@ -198,7 +198,9 @@ static int u2fzero_rng_read(struct hwrng *rng, void *data,
        }
 
        ret = u2fzero_recv(dev, &req, &resp);
-       if (ret < 0)
+
+       /* ignore errors or packets without data */
+       if (ret < offsetof(struct u2f_hid_msg, init.data))
                return 0;
 
        /* only take the minimum amount of data it is safe to take */
index fd51769..33a6908 100644 (file)
@@ -4746,6 +4746,12 @@ static const struct wacom_features wacom_features_0x393 =
        { "Wacom Intuos Pro S", 31920, 19950, 8191, 63,
          INTUOSP2S_BT, WACOM_INTUOS3_RES, WACOM_INTUOS3_RES, 7,
          .touch_max = 10 };
+static const struct wacom_features wacom_features_0x3c6 =
+       { "Wacom Intuos BT S", 15200, 9500, 4095, 63,
+         INTUOSHT3_BT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, 4 };
+static const struct wacom_features wacom_features_0x3c8 =
+       { "Wacom Intuos BT M", 21600, 13500, 4095, 63,
+         INTUOSHT3_BT, WACOM_INTUOS_RES, WACOM_INTUOS_RES, 4 };
 
 static const struct wacom_features wacom_features_HID_ANY_ID =
        { "Wacom HID", .type = HID_GENERIC, .oVid = HID_ANY_ID, .oPid = HID_ANY_ID };
@@ -4919,6 +4925,8 @@ const struct hid_device_id wacom_ids[] = {
        { USB_DEVICE_WACOM(0x37A) },
        { USB_DEVICE_WACOM(0x37B) },
        { BT_DEVICE_WACOM(0x393) },
+       { BT_DEVICE_WACOM(0x3c6) },
+       { BT_DEVICE_WACOM(0x3c8) },
        { USB_DEVICE_WACOM(0x4001) },
        { USB_DEVICE_WACOM(0x4004) },
        { USB_DEVICE_WACOM(0x5000) },
index 2aee356..314015d 100644 (file)
@@ -245,6 +245,7 @@ void hv_ringbuffer_cleanup(struct hv_ring_buffer_info *ring_info)
        mutex_unlock(&ring_info->ring_buffer_mutex);
 
        kfree(ring_info->pkt_buffer);
+       ring_info->pkt_buffer = NULL;
        ring_info->pkt_buffer_size = 0;
 }
 
index 38bc35a..3618a92 100644 (file)
@@ -362,12 +362,6 @@ static const struct hwmon_channel_info *k10temp_info[] = {
                           HWMON_T_INPUT | HWMON_T_LABEL,
                           HWMON_T_INPUT | HWMON_T_LABEL,
                           HWMON_T_INPUT | HWMON_T_LABEL),
-       HWMON_CHANNEL_INFO(in,
-                          HWMON_I_INPUT | HWMON_I_LABEL,
-                          HWMON_I_INPUT | HWMON_I_LABEL),
-       HWMON_CHANNEL_INFO(curr,
-                          HWMON_C_INPUT | HWMON_C_LABEL,
-                          HWMON_C_INPUT | HWMON_C_LABEL),
        NULL
 };
 
index bb3f774..5423466 100644 (file)
@@ -989,8 +989,12 @@ static int ltc2947_setup(struct ltc2947_data *st)
                return ret;
 
        /* check external clock presence */
-       extclk = devm_clk_get(st->dev, NULL);
-       if (!IS_ERR(extclk)) {
+       extclk = devm_clk_get_optional(st->dev, NULL);
+       if (IS_ERR(extclk))
+               return dev_err_probe(st->dev, PTR_ERR(extclk),
+                                    "Failed to get external clock\n");
+
+       if (extclk) {
                unsigned long rate_hz;
                u8 pre = 0, div, tbctl;
                u64 aux;
index 116681f..89fe7b9 100644 (file)
@@ -315,8 +315,8 @@ static int mlxreg_fan_set_cur_state(struct thermal_cooling_device *cdev,
 {
        struct mlxreg_fan *fan = cdev->devdata;
        unsigned long cur_state;
+       int i, config = 0;
        u32 regval;
-       int i;
        int err;
 
        /*
@@ -329,6 +329,12 @@ static int mlxreg_fan_set_cur_state(struct thermal_cooling_device *cdev,
         * overwritten.
         */
        if (state >= MLXREG_FAN_SPEED_MIN && state <= MLXREG_FAN_SPEED_MAX) {
+               /*
+                * This is configuration change, which is only supported through sysfs.
+                * For configuration non-zero value is to be returned to avoid thermal
+                * statistics update.
+                */
+               config = 1;
                state -= MLXREG_FAN_MAX_STATE;
                for (i = 0; i < state; i++)
                        fan->cooling_levels[i] = state;
@@ -343,7 +349,7 @@ static int mlxreg_fan_set_cur_state(struct thermal_cooling_device *cdev,
 
                cur_state = MLXREG_FAN_PWM_DUTY2STATE(regval);
                if (state < cur_state)
-                       return 0;
+                       return config;
 
                state = cur_state;
        }
@@ -359,7 +365,7 @@ static int mlxreg_fan_set_cur_state(struct thermal_cooling_device *cdev,
                dev_err(fan->dev, "Failed to write PWM duty\n");
                return err;
        }
-       return 0;
+       return config;
 }
 
 static const struct thermal_cooling_device_ops mlxreg_fan_cooling_ops = {
index 0d68a78..ae66461 100644 (file)
@@ -340,18 +340,11 @@ static ssize_t occ_show_temp_10(struct device *dev,
                if (val == OCC_TEMP_SENSOR_FAULT)
                        return -EREMOTEIO;
 
-               /*
-                * VRM doesn't return temperature, only alarm bit. This
-                * attribute maps to tempX_alarm instead of tempX_input for
-                * VRM
-                */
-               if (temp->fru_type != OCC_FRU_TYPE_VRM) {
-                       /* sensor not ready */
-                       if (val == 0)
-                               return -EAGAIN;
+               /* sensor not ready */
+               if (val == 0)
+                       return -EAGAIN;
 
-                       val *= 1000;
-               }
+               val *= 1000;
                break;
        case 2:
                val = temp->fru_type;
@@ -886,7 +879,7 @@ static int occ_setup_sensor_attrs(struct occ *occ)
                                             0, i);
                attr++;
 
-               if (sensors->temp.version > 1 &&
+               if (sensors->temp.version == 2 &&
                    temp->fru_type == OCC_FRU_TYPE_VRM) {
                        snprintf(attr->name, sizeof(attr->name),
                                 "temp%d_alarm", s);
index df712ce..53f7d14 100644 (file)
@@ -171,8 +171,14 @@ static ssize_t ibm_cffps_debugfs_read(struct file *file, char __user *buf,
                cmd = CFFPS_SN_CMD;
                break;
        case CFFPS_DEBUGFS_MAX_POWER_OUT:
-               rc = i2c_smbus_read_word_swapped(psu->client,
-                                                CFFPS_MAX_POWER_OUT_CMD);
+               if (psu->version == cffps1) {
+                       rc = i2c_smbus_read_word_swapped(psu->client,
+                                       CFFPS_MAX_POWER_OUT_CMD);
+               } else {
+                       rc = i2c_smbus_read_word_data(psu->client,
+                                       CFFPS_MAX_POWER_OUT_CMD);
+               }
+
                if (rc < 0)
                        return rc;
 
index eb94bd5..51986ad 100644 (file)
@@ -54,7 +54,7 @@
 
 #define MP2975_RAIL2_FUNC      (PMBUS_HAVE_VOUT | PMBUS_HAVE_STATUS_VOUT | \
                                 PMBUS_HAVE_IOUT | PMBUS_HAVE_STATUS_IOUT | \
-                                PMBUS_PHASE_VIRTUAL)
+                                PMBUS_HAVE_POUT | PMBUS_PHASE_VIRTUAL)
 
 struct mp2975_data {
        struct pmbus_driver_info info;
index ede66ea..b963a36 100644 (file)
@@ -100,71 +100,81 @@ struct tmp421_data {
        s16 temp[4];
 };
 
-static int temp_from_s16(s16 reg)
+static int temp_from_raw(u16 reg, bool extended)
 {
        /* Mask out status bits */
        int temp = reg & ~0xf;
 
-       return (temp * 1000 + 128) / 256;
-}
-
-static int temp_from_u16(u16 reg)
-{
-       /* Mask out status bits */
-       int temp = reg & ~0xf;
-
-       /* Add offset for extended temperature range. */
-       temp -= 64 * 256;
+       if (extended)
+               temp = temp - 64 * 256;
+       else
+               temp = (s16)temp;
 
-       return (temp * 1000 + 128) / 256;
+       return DIV_ROUND_CLOSEST(temp * 1000, 256);
 }
 
-static struct tmp421_data *tmp421_update_device(struct device *dev)
+static int tmp421_update_device(struct tmp421_data *data)
 {
-       struct tmp421_data *data = dev_get_drvdata(dev);
        struct i2c_client *client = data->client;
+       int ret = 0;
        int i;
 
        mutex_lock(&data->update_lock);
 
        if (time_after(jiffies, data->last_updated + (HZ / 2)) ||
            !data->valid) {
-               data->config = i2c_smbus_read_byte_data(client,
-                       TMP421_CONFIG_REG_1);
+               ret = i2c_smbus_read_byte_data(client, TMP421_CONFIG_REG_1);
+               if (ret < 0)
+                       goto exit;
+               data->config = ret;
 
                for (i = 0; i < data->channels; i++) {
-                       data->temp[i] = i2c_smbus_read_byte_data(client,
-                               TMP421_TEMP_MSB[i]) << 8;
-                       data->temp[i] |= i2c_smbus_read_byte_data(client,
-                               TMP421_TEMP_LSB[i]);
+                       ret = i2c_smbus_read_byte_data(client, TMP421_TEMP_MSB[i]);
+                       if (ret < 0)
+                               goto exit;
+                       data->temp[i] = ret << 8;
+
+                       ret = i2c_smbus_read_byte_data(client, TMP421_TEMP_LSB[i]);
+                       if (ret < 0)
+                               goto exit;
+                       data->temp[i] |= ret;
                }
                data->last_updated = jiffies;
                data->valid = 1;
        }
 
+exit:
        mutex_unlock(&data->update_lock);
 
-       return data;
+       if (ret < 0) {
+               data->valid = 0;
+               return ret;
+       }
+
+       return 0;
 }
 
 static int tmp421_read(struct device *dev, enum hwmon_sensor_types type,
                       u32 attr, int channel, long *val)
 {
-       struct tmp421_data *tmp421 = tmp421_update_device(dev);
+       struct tmp421_data *tmp421 = dev_get_drvdata(dev);
+       int ret = 0;
+
+       ret = tmp421_update_device(tmp421);
+       if (ret)
+               return ret;
 
        switch (attr) {
        case hwmon_temp_input:
-               if (tmp421->config & TMP421_CONFIG_RANGE)
-                       *val = temp_from_u16(tmp421->temp[channel]);
-               else
-                       *val = temp_from_s16(tmp421->temp[channel]);
+               *val = temp_from_raw(tmp421->temp[channel],
+                                    tmp421->config & TMP421_CONFIG_RANGE);
                return 0;
        case hwmon_temp_fault:
                /*
-                * The OPEN bit signals a fault. This is bit 0 of the temperature
-                * register (low byte).
+                * Any of OPEN or /PVLD bits indicate a hardware mulfunction
+                * and the conversion result may be incorrect
                 */
-               *val = tmp421->temp[channel] & 0x01;
+               *val = !!(tmp421->temp[channel] & 0x03);
                return 0;
        default:
                return -EOPNOTSUPP;
@@ -177,9 +187,6 @@ static umode_t tmp421_is_visible(const void *data, enum hwmon_sensor_types type,
 {
        switch (attr) {
        case hwmon_temp_fault:
-               if (channel == 0)
-                       return 0;
-               return 0444;
        case hwmon_temp_input:
                return 0444;
        default:
index 37b25a1..3c1be2c 100644 (file)
@@ -273,9 +273,6 @@ struct w83791d_data {
        char valid;                     /* !=0 if following fields are valid */
        unsigned long last_updated;     /* In jiffies */
 
-       /* array of 2 pointers to subclients */
-       struct i2c_client *lm75[2];
-
        /* volts */
        u8 in[NUMBER_OF_VIN];           /* Register value */
        u8 in_max[NUMBER_OF_VIN];       /* Register value */
@@ -1257,7 +1254,6 @@ static const struct attribute_group w83791d_group_fanpwm45 = {
 static int w83791d_detect_subclients(struct i2c_client *client)
 {
        struct i2c_adapter *adapter = client->adapter;
-       struct w83791d_data *data = i2c_get_clientdata(client);
        int address = client->addr;
        int i, id;
        u8 val;
@@ -1280,22 +1276,19 @@ static int w83791d_detect_subclients(struct i2c_client *client)
        }
 
        val = w83791d_read(client, W83791D_REG_I2C_SUBADDR);
-       if (!(val & 0x08))
-               data->lm75[0] = devm_i2c_new_dummy_device(&client->dev, adapter,
-                                                         0x48 + (val & 0x7));
-       if (!(val & 0x80)) {
-               if (!IS_ERR(data->lm75[0]) &&
-                               ((val & 0x7) == ((val >> 4) & 0x7))) {
-                       dev_err(&client->dev,
-                               "duplicate addresses 0x%x, "
-                               "use force_subclient\n",
-                               data->lm75[0]->addr);
-                       return -ENODEV;
-               }
-               data->lm75[1] = devm_i2c_new_dummy_device(&client->dev, adapter,
-                                                         0x48 + ((val >> 4) & 0x7));
+
+       if (!(val & 0x88) && (val & 0x7) == ((val >> 4) & 0x7)) {
+               dev_err(&client->dev,
+                       "duplicate addresses 0x%x, use force_subclient\n", 0x48 + (val & 0x7));
+               return -ENODEV;
        }
 
+       if (!(val & 0x08))
+               devm_i2c_new_dummy_device(&client->dev, adapter, 0x48 + (val & 0x7));
+
+       if (!(val & 0x80))
+               devm_i2c_new_dummy_device(&client->dev, adapter, 0x48 + ((val >> 4) & 0x7));
+
        return 0;
 }
 
index abd5c3a..1f175f3 100644 (file)
@@ -264,9 +264,6 @@ struct w83792d_data {
        char valid;             /* !=0 if following fields are valid */
        unsigned long last_updated;     /* In jiffies */
 
-       /* array of 2 pointers to subclients */
-       struct i2c_client *lm75[2];
-
        u8 in[9];               /* Register value */
        u8 in_max[9];           /* Register value */
        u8 in_min[9];           /* Register value */
@@ -927,7 +924,6 @@ w83792d_detect_subclients(struct i2c_client *new_client)
        int address = new_client->addr;
        u8 val;
        struct i2c_adapter *adapter = new_client->adapter;
-       struct w83792d_data *data = i2c_get_clientdata(new_client);
 
        id = i2c_adapter_id(adapter);
        if (force_subclients[0] == id && force_subclients[1] == address) {
@@ -946,21 +942,19 @@ w83792d_detect_subclients(struct i2c_client *new_client)
        }
 
        val = w83792d_read_value(new_client, W83792D_REG_I2C_SUBADDR);
-       if (!(val & 0x08))
-               data->lm75[0] = devm_i2c_new_dummy_device(&new_client->dev, adapter,
-                                                         0x48 + (val & 0x7));
-       if (!(val & 0x80)) {
-               if (!IS_ERR(data->lm75[0]) &&
-                       ((val & 0x7) == ((val >> 4) & 0x7))) {
-                       dev_err(&new_client->dev,
-                               "duplicate addresses 0x%x, use force_subclient\n",
-                               data->lm75[0]->addr);
-                       return -ENODEV;
-               }
-               data->lm75[1] = devm_i2c_new_dummy_device(&new_client->dev, adapter,
-                                                         0x48 + ((val >> 4) & 0x7));
+
+       if (!(val & 0x88) && (val & 0x7) == ((val >> 4) & 0x7)) {
+               dev_err(&new_client->dev,
+                       "duplicate addresses 0x%x, use force_subclient\n", 0x48 + (val & 0x7));
+               return -ENODEV;
        }
 
+       if (!(val & 0x08))
+               devm_i2c_new_dummy_device(&new_client->dev, adapter, 0x48 + (val & 0x7));
+
+       if (!(val & 0x80))
+               devm_i2c_new_dummy_device(&new_client->dev, adapter, 0x48 + ((val >> 4) & 0x7));
+
        return 0;
 }
 
index e7d0484..1d2854d 100644 (file)
@@ -202,7 +202,6 @@ static inline s8 TEMP_TO_REG(long val, s8 min, s8 max)
 }
 
 struct w83793_data {
-       struct i2c_client *lm75[2];
        struct device *hwmon_dev;
        struct mutex update_lock;
        char valid;                     /* !=0 if following fields are valid */
@@ -1566,7 +1565,6 @@ w83793_detect_subclients(struct i2c_client *client)
        int address = client->addr;
        u8 tmp;
        struct i2c_adapter *adapter = client->adapter;
-       struct w83793_data *data = i2c_get_clientdata(client);
 
        id = i2c_adapter_id(adapter);
        if (force_subclients[0] == id && force_subclients[1] == address) {
@@ -1586,21 +1584,19 @@ w83793_detect_subclients(struct i2c_client *client)
        }
 
        tmp = w83793_read_value(client, W83793_REG_I2C_SUBADDR);
-       if (!(tmp & 0x08))
-               data->lm75[0] = devm_i2c_new_dummy_device(&client->dev, adapter,
-                                                         0x48 + (tmp & 0x7));
-       if (!(tmp & 0x80)) {
-               if (!IS_ERR(data->lm75[0])
-                   && ((tmp & 0x7) == ((tmp >> 4) & 0x7))) {
-                       dev_err(&client->dev,
-                               "duplicate addresses 0x%x, "
-                               "use force_subclients\n", data->lm75[0]->addr);
-                       return -ENODEV;
-               }
-               data->lm75[1] = devm_i2c_new_dummy_device(&client->dev, adapter,
-                                                         0x48 + ((tmp >> 4) & 0x7));
+
+       if (!(tmp & 0x88) && (tmp & 0x7) == ((tmp >> 4) & 0x7)) {
+               dev_err(&client->dev,
+                       "duplicate addresses 0x%x, use force_subclient\n", 0x48 + (tmp & 0x7));
+               return -ENODEV;
        }
 
+       if (!(tmp & 0x08))
+               devm_i2c_new_dummy_device(&client->dev, adapter, 0x48 + (tmp & 0x7));
+
+       if (!(tmp & 0x80))
+               devm_i2c_new_dummy_device(&client->dev, adapter, 0x48 + ((tmp >> 4) & 0x7));
+
        return 0;
 }
 
index fc0760f..4305456 100644 (file)
@@ -5,6 +5,7 @@
  */
 
 #include <linux/platform_device.h>
+#include <linux/slab.h>
 
 #include "coresight-config.h"
 #include "coresight-etm-perf.h"
index 4e0b7c2..015e11c 100644 (file)
@@ -49,7 +49,7 @@
 #define MLXCPLD_LPCI2C_NACK_IND                2
 
 #define MLXCPLD_I2C_FREQ_1000KHZ_SET   0x04
-#define MLXCPLD_I2C_FREQ_400KHZ_SET    0x0f
+#define MLXCPLD_I2C_FREQ_400KHZ_SET    0x0c
 #define MLXCPLD_I2C_FREQ_100KHZ_SET    0x42
 
 enum mlxcpld_i2c_frequency {
@@ -495,7 +495,7 @@ mlxcpld_i2c_set_frequency(struct mlxcpld_i2c_priv *priv,
                return err;
 
        /* Set frequency only if it is not 100KHz, which is default. */
-       switch ((data->reg & data->mask) >> data->bit) {
+       switch ((regval & data->mask) >> data->bit) {
        case MLXCPLD_I2C_FREQ_1000KHZ:
                freq = MLXCPLD_I2C_FREQ_1000KHZ_SET;
                break;
index 477480d..7d4b3eb 100644 (file)
@@ -41,6 +41,8 @@
 #define I2C_HANDSHAKE_RST              0x0020
 #define I2C_FIFO_ADDR_CLR              0x0001
 #define I2C_DELAY_LEN                  0x0002
+#define I2C_ST_START_CON               0x8001
+#define I2C_FS_START_CON               0x1800
 #define I2C_TIME_CLR_VALUE             0x0000
 #define I2C_TIME_DEFAULT_VALUE         0x0003
 #define I2C_WRRD_TRANAC_VALUE          0x0002
@@ -480,6 +482,7 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
 {
        u16 control_reg;
        u16 intr_stat_reg;
+       u16 ext_conf_val;
 
        mtk_i2c_writew(i2c, I2C_CHN_CLR_FLAG, OFFSET_START);
        intr_stat_reg = mtk_i2c_readw(i2c, OFFSET_INTR_STAT);
@@ -518,8 +521,13 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
        if (i2c->dev_comp->ltiming_adjust)
                mtk_i2c_writew(i2c, i2c->ltiming_reg, OFFSET_LTIMING);
 
+       if (i2c->speed_hz <= I2C_MAX_STANDARD_MODE_FREQ)
+               ext_conf_val = I2C_ST_START_CON;
+       else
+               ext_conf_val = I2C_FS_START_CON;
+
        if (i2c->dev_comp->timing_adjust) {
-               mtk_i2c_writew(i2c, i2c->ac_timing.ext, OFFSET_EXT_CONF);
+               ext_conf_val = i2c->ac_timing.ext;
                mtk_i2c_writew(i2c, i2c->ac_timing.inter_clk_div,
                               OFFSET_CLOCK_DIV);
                mtk_i2c_writew(i2c, I2C_SCL_MIS_COMP_VALUE,
@@ -544,6 +552,7 @@ static void mtk_i2c_init_hw(struct mtk_i2c *i2c)
                                       OFFSET_HS_STA_STO_AC_TIMING);
                }
        }
+       mtk_i2c_writew(i2c, ext_conf_val, OFFSET_EXT_CONF);
 
        /* If use i2c pin from PMIC mt6397 side, need set PATH_DIR first */
        if (i2c->have_pmic)
index aaeeacc..546cc93 100644 (file)
@@ -454,6 +454,7 @@ static int i2c_acpi_notify(struct notifier_block *nb, unsigned long value,
                        break;
 
                i2c_acpi_register_device(adapter, adev, &info);
+               put_device(&adapter->dev);
                break;
        case ACPI_RECONFIG_DEVICE_REMOVE:
                if (!acpi_device_enumerated(adev))
index 0019f1e..f41db9e 100644 (file)
@@ -738,7 +738,7 @@ static irqreturn_t fxls8962af_interrupt(int irq, void *p)
 
        if (reg & FXLS8962AF_INT_STATUS_SRC_BUF) {
                ret = fxls8962af_fifo_flush(indio_dev);
-               if (ret)
+               if (ret < 0)
                        return IRQ_NONE;
 
                return IRQ_HANDLED;
index ee8ed94..2121a81 100644 (file)
@@ -293,6 +293,7 @@ static const struct ad_sigma_delta_info ad7192_sigma_delta_info = {
        .has_registers = true,
        .addr_shift = 3,
        .read_mask = BIT(6),
+       .irq_flags = IRQF_TRIGGER_FALLING,
 };
 
 static const struct ad_sd_calib_data ad7192_calib_arr[8] = {
index 42bb952..b6e8c8a 100644 (file)
@@ -203,7 +203,7 @@ static const struct ad_sigma_delta_info ad7780_sigma_delta_info = {
        .set_mode = ad7780_set_mode,
        .postprocess_sample = ad7780_postprocess_sample,
        .has_registers = false,
-       .irq_flags = IRQF_TRIGGER_LOW,
+       .irq_flags = IRQF_TRIGGER_FALLING,
 };
 
 #define _AD7780_CHANNEL(_bits, _wordsize, _mask_all)           \
index ef3e2d3..0e7ab3f 100644 (file)
@@ -206,7 +206,7 @@ static const struct ad_sigma_delta_info ad7793_sigma_delta_info = {
        .has_registers = true,
        .addr_shift = 3,
        .read_mask = BIT(6),
-       .irq_flags = IRQF_TRIGGER_LOW,
+       .irq_flags = IRQF_TRIGGER_FALLING,
 };
 
 static const struct ad_sd_calib_data ad7793_calib_arr[6] = {
index 19efaa4..34ec0c2 100644 (file)
@@ -183,6 +183,7 @@ static int aspeed_adc_probe(struct platform_device *pdev)
 
        data = iio_priv(indio_dev);
        data->dev = &pdev->dev;
+       platform_set_drvdata(pdev, indio_dev);
 
        data->base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(data->base))
index 655ab02..b753658 100644 (file)
@@ -103,7 +103,7 @@ MODULE_DEVICE_TABLE(of, max1027_adc_dt_ids);
                        .sign = 'u',                                    \
                        .realbits = depth,                              \
                        .storagebits = 16,                              \
-                       .shift = 2,                                     \
+                       .shift = (depth == 10) ? 2 : 0,                 \
                        .endianness = IIO_BE,                           \
                },                                                      \
        }
@@ -142,7 +142,6 @@ MODULE_DEVICE_TABLE(of, max1027_adc_dt_ids);
        MAX1027_V_CHAN(11, depth)
 
 #define MAX1X31_CHANNELS(depth)                        \
-       MAX1X27_CHANNELS(depth),                \
        MAX1X29_CHANNELS(depth),                \
        MAX1027_V_CHAN(12, depth),              \
        MAX1027_V_CHAN(13, depth),              \
index 79c1dd6..d4fccd5 100644 (file)
@@ -82,6 +82,10 @@ static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = {
        MT6577_AUXADC_CHANNEL(15),
 };
 
+/* For Voltage calculation */
+#define VOLTAGE_FULL_RANGE  1500       /* VA voltage */
+#define AUXADC_PRECISE      4096       /* 12 bits */
+
 static int mt_auxadc_get_cali_data(int rawdata, bool enable_cali)
 {
        return rawdata;
@@ -191,6 +195,10 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev,
                }
                if (adc_dev->dev_comp->sample_data_cali)
                        *val = mt_auxadc_get_cali_data(*val, true);
+
+               /* Convert adc raw data to voltage: 0 - 1500 mV */
+               *val = *val * VOLTAGE_FULL_RANGE / AUXADC_PRECISE;
+
                return IIO_VAL_INT;
 
        default:
index 9996d5e..32fbf57 100644 (file)
@@ -401,7 +401,7 @@ static int rzg2l_adc_hw_init(struct rzg2l_adc *adc)
 exit_hw_init:
        clk_disable_unprepare(adc->pclk);
 
-       return 0;
+       return ret;
 }
 
 static void rzg2l_adc_pm_runtime_disable(void *data)
@@ -570,8 +570,10 @@ static int __maybe_unused rzg2l_adc_pm_runtime_resume(struct device *dev)
                return ret;
 
        ret = clk_prepare_enable(adc->adclk);
-       if (ret)
+       if (ret) {
+               clk_disable_unprepare(adc->pclk);
                return ret;
+       }
 
        rzg2l_adc_pwr(adc, true);
 
index 3143f35..83c1ae0 100644 (file)
@@ -171,7 +171,13 @@ static int adc128_probe(struct spi_device *spi)
        mutex_init(&adc->lock);
 
        ret = iio_device_register(indio_dev);
+       if (ret)
+               goto err_disable_regulator;
 
+       return 0;
+
+err_disable_regulator:
+       regulator_disable(adc->reg);
        return ret;
 }
 
index 4864c38..769bd92 100644 (file)
@@ -137,7 +137,7 @@ static int ssp_print_mcu_debug(char *data_frame, int *data_index,
        if (length > received_len - *data_index || length <= 0) {
                ssp_dbg("[SSP]: MSG From MCU-invalid debug length(%d/%d)\n",
                        length, received_len);
-               return length ? length : -EPROTO;
+               return -EPROTO;
        }
 
        ssp_dbg("[SSP]: MSG From MCU - %s\n", &data_frame[*data_index]);
@@ -273,6 +273,8 @@ static int ssp_parse_dataframe(struct ssp_data *data, char *dataframe, int len)
        for (idx = 0; idx < len;) {
                switch (dataframe[idx++]) {
                case SSP_MSG2AP_INST_BYPASS_DATA:
+                       if (idx >= len)
+                               return -EPROTO;
                        sd = dataframe[idx++];
                        if (sd < 0 || sd >= SSP_SENSOR_MAX) {
                                dev_err(SSP_DEV,
@@ -282,10 +284,13 @@ static int ssp_parse_dataframe(struct ssp_data *data, char *dataframe, int len)
 
                        if (indio_devs[sd]) {
                                spd = iio_priv(indio_devs[sd]);
-                               if (spd->process_data)
+                               if (spd->process_data) {
+                                       if (idx >= len)
+                                               return -EPROTO;
                                        spd->process_data(indio_devs[sd],
                                                          &dataframe[idx],
                                                          data->timestamp);
+                               }
                        } else {
                                dev_err(SSP_DEV, "no client for frame\n");
                        }
@@ -293,6 +298,8 @@ static int ssp_parse_dataframe(struct ssp_data *data, char *dataframe, int len)
                        idx += ssp_offset_map[sd];
                        break;
                case SSP_MSG2AP_INST_DEBUG_DATA:
+                       if (idx >= len)
+                               return -EPROTO;
                        sd = ssp_print_mcu_debug(dataframe, &idx, len);
                        if (sd) {
                                dev_err(SSP_DEV,
index 2a5ba1b..546a4cf 100644 (file)
@@ -350,6 +350,7 @@ static int dac5571_probe(struct i2c_client *client,
                data->dac5571_pwrdwn = dac5571_pwrdwn_quad;
                break;
        default:
+               ret = -EINVAL;
                goto err;
        }
 
index eb48102..287fff3 100644 (file)
@@ -353,10 +353,11 @@ static int adis16475_set_freq(struct adis16475 *st, const u32 freq)
        if (dec > st->info->max_dec)
                dec = st->info->max_dec;
 
-       ret = adis_write_reg_16(&st->adis, ADIS16475_REG_DEC_RATE, dec);
+       ret = __adis_write_reg_16(&st->adis, ADIS16475_REG_DEC_RATE, dec);
        if (ret)
                goto error;
 
+       adis_dev_unlock(&st->adis);
        /*
         * If decimation is used, then gyro and accel data will have meaningful
         * bits on the LSB registers. This info is used on the trigger handler.
index a869a6e..ed12932 100644 (file)
@@ -144,6 +144,7 @@ struct adis16480_chip_info {
        unsigned int max_dec_rate;
        const unsigned int *filter_freqs;
        bool has_pps_clk_mode;
+       bool has_sleep_cnt;
        const struct adis_data adis_data;
 };
 
@@ -939,6 +940,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
                .temp_scale = 5650, /* 5.65 milli degree Celsius */
                .int_clk = 2460000,
                .max_dec_rate = 2048,
+               .has_sleep_cnt = true,
                .filter_freqs = adis16480_def_filter_freqs,
                .adis_data = ADIS16480_DATA(16375, &adis16485_timeouts, 0),
        },
@@ -952,6 +954,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
                .temp_scale = 5650, /* 5.65 milli degree Celsius */
                .int_clk = 2460000,
                .max_dec_rate = 2048,
+               .has_sleep_cnt = true,
                .filter_freqs = adis16480_def_filter_freqs,
                .adis_data = ADIS16480_DATA(16480, &adis16480_timeouts, 0),
        },
@@ -965,6 +968,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
                .temp_scale = 5650, /* 5.65 milli degree Celsius */
                .int_clk = 2460000,
                .max_dec_rate = 2048,
+               .has_sleep_cnt = true,
                .filter_freqs = adis16480_def_filter_freqs,
                .adis_data = ADIS16480_DATA(16485, &adis16485_timeouts, 0),
        },
@@ -978,6 +982,7 @@ static const struct adis16480_chip_info adis16480_chip_info[] = {
                .temp_scale = 5650, /* 5.65 milli degree Celsius */
                .int_clk = 2460000,
                .max_dec_rate = 2048,
+               .has_sleep_cnt = true,
                .filter_freqs = adis16480_def_filter_freqs,
                .adis_data = ADIS16480_DATA(16488, &adis16485_timeouts, 0),
        },
@@ -1425,9 +1430,12 @@ static int adis16480_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = devm_add_action_or_reset(&spi->dev, adis16480_stop, indio_dev);
-       if (ret)
-               return ret;
+       if (st->chip_info->has_sleep_cnt) {
+               ret = devm_add_action_or_reset(&spi->dev, adis16480_stop,
+                                              indio_dev);
+               if (ret)
+                       return ret;
+       }
 
        ret = adis16480_config_irq_pin(spi->dev.of_node, st);
        if (ret)
index 52963da..1880bd5 100644 (file)
@@ -276,6 +276,8 @@ static int opt3001_get_lux(struct opt3001 *opt, int *val, int *val2)
                ret = wait_event_timeout(opt->result_ready_queue,
                                opt->result_ready,
                                msecs_to_jiffies(OPT3001_RESULT_READY_LONG));
+               if (ret == 0)
+                       return -ETIMEDOUT;
        } else {
                /* Sleep for result ready time */
                timeout = (opt->int_time == OPT3001_INT_TIME_SHORT) ?
@@ -312,9 +314,7 @@ err:
                /* Disallow IRQ to access the device while lock is active */
                opt->ok_to_ignore_lock = false;
 
-       if (ret == 0)
-               return -ETIMEDOUT;
-       else if (ret < 0)
+       if (ret < 0)
                return ret;
 
        if (opt->use_irq) {
index f1099b4..467519a 100644 (file)
@@ -5,3 +5,4 @@
 
 # Keep in alphabetical order
 obj-$(CONFIG_IIO_TEST_FORMAT) += iio-test-format.o
+CFLAGS_iio-test-format.o += $(DISABLE_STRUCTLEAK_PLUGIN)
index c40791b..704ce59 100644 (file)
@@ -1746,15 +1746,16 @@ static void cma_cancel_route(struct rdma_id_private *id_priv)
        }
 }
 
-static void cma_cancel_listens(struct rdma_id_private *id_priv)
+static void _cma_cancel_listens(struct rdma_id_private *id_priv)
 {
        struct rdma_id_private *dev_id_priv;
 
+       lockdep_assert_held(&lock);
+
        /*
         * Remove from listen_any_list to prevent added devices from spawning
         * additional listen requests.
         */
-       mutex_lock(&lock);
        list_del(&id_priv->list);
 
        while (!list_empty(&id_priv->listen_list)) {
@@ -1768,6 +1769,12 @@ static void cma_cancel_listens(struct rdma_id_private *id_priv)
                rdma_destroy_id(&dev_id_priv->id);
                mutex_lock(&lock);
        }
+}
+
+static void cma_cancel_listens(struct rdma_id_private *id_priv)
+{
+       mutex_lock(&lock);
+       _cma_cancel_listens(id_priv);
        mutex_unlock(&lock);
 }
 
@@ -1776,6 +1783,14 @@ static void cma_cancel_operation(struct rdma_id_private *id_priv,
 {
        switch (state) {
        case RDMA_CM_ADDR_QUERY:
+               /*
+                * We can avoid doing the rdma_addr_cancel() based on state,
+                * only RDMA_CM_ADDR_QUERY has a work that could still execute.
+                * Notice that the addr_handler work could still be exiting
+                * outside this state, however due to the interaction with the
+                * handler_mutex the work is guaranteed not to touch id_priv
+                * during exit.
+                */
                rdma_addr_cancel(&id_priv->id.route.addr.dev_addr);
                break;
        case RDMA_CM_ROUTE_QUERY:
@@ -1810,6 +1825,8 @@ static void cma_release_port(struct rdma_id_private *id_priv)
 static void destroy_mc(struct rdma_id_private *id_priv,
                       struct cma_multicast *mc)
 {
+       bool send_only = mc->join_state == BIT(SENDONLY_FULLMEMBER_JOIN);
+
        if (rdma_cap_ib_mcast(id_priv->id.device, id_priv->id.port_num))
                ib_sa_free_multicast(mc->sa_mc);
 
@@ -1826,7 +1843,10 @@ static void destroy_mc(struct rdma_id_private *id_priv,
 
                        cma_set_mgid(id_priv, (struct sockaddr *)&mc->addr,
                                     &mgid);
-                       cma_igmp_send(ndev, &mgid, false);
+
+                       if (!send_only)
+                               cma_igmp_send(ndev, &mgid, false);
+
                        dev_put(ndev);
                }
 
@@ -2574,7 +2594,7 @@ static int cma_listen_on_all(struct rdma_id_private *id_priv)
        return 0;
 
 err_listen:
-       list_del(&id_priv->list);
+       _cma_cancel_listens(id_priv);
        mutex_unlock(&lock);
        if (to_destroy)
                rdma_destroy_id(&to_destroy->id);
@@ -3413,6 +3433,21 @@ int rdma_resolve_addr(struct rdma_cm_id *id, struct sockaddr *src_addr,
                if (dst_addr->sa_family == AF_IB) {
                        ret = cma_resolve_ib_addr(id_priv);
                } else {
+                       /*
+                        * The FSM can return back to RDMA_CM_ADDR_BOUND after
+                        * rdma_resolve_ip() is called, eg through the error
+                        * path in addr_handler(). If this happens the existing
+                        * request must be canceled before issuing a new one.
+                        * Since canceling a request is a bit slow and this
+                        * oddball path is rare, keep track once a request has
+                        * been issued. The track turns out to be a permanent
+                        * state since this is the only cancel as it is
+                        * immediately before rdma_resolve_ip().
+                        */
+                       if (id_priv->used_resolve_ip)
+                               rdma_addr_cancel(&id->route.addr.dev_addr);
+                       else
+                               id_priv->used_resolve_ip = 1;
                        ret = rdma_resolve_ip(cma_src_addr(id_priv), dst_addr,
                                              &id->route.addr.dev_addr,
                                              timeout_ms, addr_handler,
@@ -3771,9 +3806,13 @@ int rdma_listen(struct rdma_cm_id *id, int backlog)
        int ret;
 
        if (!cma_comp_exch(id_priv, RDMA_CM_ADDR_BOUND, RDMA_CM_LISTEN)) {
+               struct sockaddr_in any_in = {
+                       .sin_family = AF_INET,
+                       .sin_addr.s_addr = htonl(INADDR_ANY),
+               };
+
                /* For a well behaved ULP state will be RDMA_CM_IDLE */
-               id->route.addr.src_addr.ss_family = AF_INET;
-               ret = rdma_bind_addr(id, cma_src_addr(id_priv));
+               ret = rdma_bind_addr(id, (struct sockaddr *)&any_in);
                if (ret)
                        return ret;
                if (WARN_ON(!cma_comp_exch(id_priv, RDMA_CM_ADDR_BOUND,
index 5c463da..f92f101 100644 (file)
@@ -91,6 +91,7 @@ struct rdma_id_private {
        u8                      afonly;
        u8                      timeout;
        u8                      min_rnr_timer;
+       u8 used_resolve_ip;
        enum ib_gid_type        gid_type;
 
        /*
index e74ddbe..15b0cb0 100644 (file)
@@ -876,14 +876,14 @@ void hfi1_ipoib_tx_timeout(struct net_device *dev, unsigned int q)
        struct hfi1_ipoib_txq *txq = &priv->txqs[q];
        u64 completed = atomic64_read(&txq->complete_txreqs);
 
-       dd_dev_info(priv->dd, "timeout txq %llx q %u stopped %u stops %d no_desc %d ring_full %d\n",
-                   (unsigned long long)txq, q,
+       dd_dev_info(priv->dd, "timeout txq %p q %u stopped %u stops %d no_desc %d ring_full %d\n",
+                   txq, q,
                    __netif_subqueue_stopped(dev, txq->q_idx),
                    atomic_read(&txq->stops),
                    atomic_read(&txq->no_desc),
                    atomic_read(&txq->ring_full));
-       dd_dev_info(priv->dd, "sde %llx engine %u\n",
-                   (unsigned long long)txq->sde,
+       dd_dev_info(priv->dd, "sde %p engine %u\n",
+                   txq->sde,
                    txq->sde ? txq->sde->this_idx : 0);
        dd_dev_info(priv->dd, "flow %x\n", txq->flow.as_int);
        dd_dev_info(priv->dd, "sent %llu completed %llu used %llu\n",
index 1e9c3c5..d763f09 100644 (file)
@@ -326,19 +326,30 @@ static void set_cq_param(struct hns_roce_cq *hr_cq, u32 cq_entries, int vector,
        INIT_LIST_HEAD(&hr_cq->rq_list);
 }
 
-static void set_cqe_size(struct hns_roce_cq *hr_cq, struct ib_udata *udata,
-                        struct hns_roce_ib_create_cq *ucmd)
+static int set_cqe_size(struct hns_roce_cq *hr_cq, struct ib_udata *udata,
+                       struct hns_roce_ib_create_cq *ucmd)
 {
        struct hns_roce_dev *hr_dev = to_hr_dev(hr_cq->ib_cq.device);
 
-       if (udata) {
-               if (udata->inlen >= offsetofend(typeof(*ucmd), cqe_size))
-                       hr_cq->cqe_size = ucmd->cqe_size;
-               else
-                       hr_cq->cqe_size = HNS_ROCE_V2_CQE_SIZE;
-       } else {
+       if (!udata) {
                hr_cq->cqe_size = hr_dev->caps.cqe_sz;
+               return 0;
+       }
+
+       if (udata->inlen >= offsetofend(typeof(*ucmd), cqe_size)) {
+               if (ucmd->cqe_size != HNS_ROCE_V2_CQE_SIZE &&
+                   ucmd->cqe_size != HNS_ROCE_V3_CQE_SIZE) {
+                       ibdev_err(&hr_dev->ib_dev,
+                                 "invalid cqe size %u.\n", ucmd->cqe_size);
+                       return -EINVAL;
+               }
+
+               hr_cq->cqe_size = ucmd->cqe_size;
+       } else {
+               hr_cq->cqe_size = HNS_ROCE_V2_CQE_SIZE;
        }
+
+       return 0;
 }
 
 int hns_roce_create_cq(struct ib_cq *ib_cq, const struct ib_cq_init_attr *attr,
@@ -366,7 +377,9 @@ int hns_roce_create_cq(struct ib_cq *ib_cq, const struct ib_cq_init_attr *attr,
 
        set_cq_param(hr_cq, attr->cqe, attr->comp_vector, &ucmd);
 
-       set_cqe_size(hr_cq, udata, &ucmd);
+       ret = set_cqe_size(hr_cq, udata, &ucmd);
+       if (ret)
+               return ret;
 
        ret = alloc_cq_buf(hr_dev, hr_cq, udata, ucmd.buf_addr);
        if (ret) {
index 5b99531..d5f3faa 100644 (file)
@@ -3299,7 +3299,7 @@ static void __hns_roce_v2_cq_clean(struct hns_roce_cq *hr_cq, u32 qpn,
                        dest = get_cqe_v2(hr_cq, (prod_index + nfreed) &
                                          hr_cq->ib_cq.cqe);
                        owner_bit = hr_reg_read(dest, CQE_OWNER);
-                       memcpy(dest, cqe, sizeof(*cqe));
+                       memcpy(dest, cqe, hr_cq->cqe_size);
                        hr_reg_write(dest, CQE_OWNER, owner_bit);
                }
        }
@@ -4397,7 +4397,12 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp,
        hr_qp->path_mtu = ib_mtu;
 
        mtu = ib_mtu_enum_to_int(ib_mtu);
-       if (WARN_ON(mtu < 0))
+       if (WARN_ON(mtu <= 0))
+               return -EINVAL;
+#define MAX_LP_MSG_LEN 65536
+       /* MTU * (2 ^ LP_PKTN_INI) shouldn't be bigger than 64KB */
+       lp_pktn_ini = ilog2(MAX_LP_MSG_LEN / mtu);
+       if (WARN_ON(lp_pktn_ini >= 0xF))
                return -EINVAL;
 
        if (attr_mask & IB_QP_PATH_MTU) {
@@ -4405,10 +4410,6 @@ static int modify_qp_init_to_rtr(struct ib_qp *ibqp,
                hr_reg_clear(qpc_mask, QPC_MTU);
        }
 
-#define MAX_LP_MSG_LEN 65536
-       /* MTU * (2 ^ LP_PKTN_INI) shouldn't be bigger than 64KB */
-       lp_pktn_ini = ilog2(MAX_LP_MSG_LEN / mtu);
-
        hr_reg_write(context, QPC_LP_PKTN_INI, lp_pktn_ini);
        hr_reg_clear(qpc_mask, QPC_LP_PKTN_INI);
 
index 6b62299..6dea0a4 100644 (file)
@@ -3496,7 +3496,7 @@ static void irdma_cm_disconn_true(struct irdma_qp *iwqp)
             original_hw_tcp_state == IRDMA_TCP_STATE_TIME_WAIT ||
             last_ae == IRDMA_AE_RDMAP_ROE_BAD_LLP_CLOSE ||
             last_ae == IRDMA_AE_BAD_CLOSE ||
-            last_ae == IRDMA_AE_LLP_CONNECTION_RESET || iwdev->reset)) {
+            last_ae == IRDMA_AE_LLP_CONNECTION_RESET || iwdev->rf->reset)) {
                issue_close = 1;
                iwqp->cm_id = NULL;
                qp->term_flags = 0;
@@ -4250,7 +4250,7 @@ void irdma_cm_teardown_connections(struct irdma_device *iwdev, u32 *ipaddr,
                                       teardown_entry);
                attr.qp_state = IB_QPS_ERR;
                irdma_modify_qp(&cm_node->iwqp->ibqp, &attr, IB_QP_STATE, NULL);
-               if (iwdev->reset)
+               if (iwdev->rf->reset)
                        irdma_cm_disconn(cm_node->iwqp);
                irdma_rem_ref_cm_node(cm_node);
        }
index 00de5ee..7de525a 100644 (file)
@@ -176,6 +176,14 @@ static void irdma_set_flush_fields(struct irdma_sc_qp *qp,
        case IRDMA_AE_LLP_RECEIVED_MPA_CRC_ERROR:
                qp->flush_code = FLUSH_GENERAL_ERR;
                break;
+       case IRDMA_AE_LLP_TOO_MANY_RETRIES:
+               qp->flush_code = FLUSH_RETRY_EXC_ERR;
+               break;
+       case IRDMA_AE_AMP_MWBIND_INVALID_RIGHTS:
+       case IRDMA_AE_AMP_MWBIND_BIND_DISABLED:
+       case IRDMA_AE_AMP_MWBIND_INVALID_BOUNDS:
+               qp->flush_code = FLUSH_MW_BIND_ERR;
+               break;
        default:
                qp->flush_code = FLUSH_FATAL_ERR;
                break;
@@ -1489,7 +1497,7 @@ void irdma_reinitialize_ieq(struct irdma_sc_vsi *vsi)
 
        irdma_puda_dele_rsrc(vsi, IRDMA_PUDA_RSRC_TYPE_IEQ, false);
        if (irdma_initialize_ieq(iwdev)) {
-               iwdev->reset = true;
+               iwdev->rf->reset = true;
                rf->gen_ops.request_reset(rf);
        }
 }
@@ -1632,13 +1640,13 @@ void irdma_rt_deinit_hw(struct irdma_device *iwdev)
        case IEQ_CREATED:
                if (!iwdev->roce_mode)
                        irdma_puda_dele_rsrc(&iwdev->vsi, IRDMA_PUDA_RSRC_TYPE_IEQ,
-                                            iwdev->reset);
+                                            iwdev->rf->reset);
                fallthrough;
        case ILQ_CREATED:
                if (!iwdev->roce_mode)
                        irdma_puda_dele_rsrc(&iwdev->vsi,
                                             IRDMA_PUDA_RSRC_TYPE_ILQ,
-                                            iwdev->reset);
+                                            iwdev->rf->reset);
                break;
        default:
                ibdev_warn(&iwdev->ibdev, "bad init_state = %d\n", iwdev->init_state);
index bddf881..d219f64 100644 (file)
@@ -55,7 +55,7 @@ static void i40iw_close(struct i40e_info *cdev_info, struct i40e_client *client,
 
        iwdev = to_iwdev(ibdev);
        if (reset)
-               iwdev->reset = true;
+               iwdev->rf->reset = true;
 
        iwdev->iw_status = 0;
        irdma_port_ibevent(iwdev);
index 743d9e1..b678fe7 100644 (file)
@@ -346,7 +346,6 @@ struct irdma_device {
        bool roce_mode:1;
        bool roce_dcqcn_en:1;
        bool dcb:1;
-       bool reset:1;
        bool iw_ooo:1;
        enum init_completion_state init_state;
 
index ff705f3..3dcbb1f 100644 (file)
@@ -102,6 +102,8 @@ enum irdma_flush_opcode {
        FLUSH_REM_OP_ERR,
        FLUSH_LOC_LEN_ERR,
        FLUSH_FATAL_ERR,
+       FLUSH_RETRY_EXC_ERR,
+       FLUSH_MW_BIND_ERR,
 };
 
 enum irdma_cmpl_status {
index e944709..ac91ea5 100644 (file)
@@ -2507,7 +2507,7 @@ void irdma_modify_qp_to_err(struct irdma_sc_qp *sc_qp)
        struct irdma_qp *qp = sc_qp->qp_uk.back_qp;
        struct ib_qp_attr attr;
 
-       if (qp->iwdev->reset)
+       if (qp->iwdev->rf->reset)
                return;
        attr.qp_state = IB_QPS_ERR;
 
index 4fc3234..7110ebf 100644 (file)
@@ -535,8 +535,7 @@ static int irdma_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata)
        irdma_qp_rem_ref(&iwqp->ibqp);
        wait_for_completion(&iwqp->free_qp);
        irdma_free_lsmm_rsrc(iwqp);
-       if (!iwdev->reset)
-               irdma_cqp_qp_destroy_cmd(&iwdev->rf->sc_dev, &iwqp->sc_qp);
+       irdma_cqp_qp_destroy_cmd(&iwdev->rf->sc_dev, &iwqp->sc_qp);
 
        if (!iwqp->user_mode) {
                if (iwqp->iwscq) {
@@ -2035,7 +2034,7 @@ static int irdma_create_cq(struct ib_cq *ibcq,
                /* Kmode allocations */
                int rsize;
 
-               if (entries > rf->max_cqe) {
+               if (entries < 1 || entries > rf->max_cqe) {
                        err_code = -EINVAL;
                        goto cq_free_rsrc;
                }
@@ -3353,6 +3352,10 @@ static enum ib_wc_status irdma_flush_err_to_ib_wc_status(enum irdma_flush_opcode
                return IB_WC_LOC_LEN_ERR;
        case FLUSH_GENERAL_ERR:
                return IB_WC_WR_FLUSH_ERR;
+       case FLUSH_RETRY_EXC_ERR:
+               return IB_WC_RETRY_EXC_ERR;
+       case FLUSH_MW_BIND_ERR:
+               return IB_WC_MW_BIND_ERR;
        case FLUSH_FATAL_ERR:
        default:
                return IB_WC_FATAL_ERR;
index 452e235..0a3b281 100644 (file)
@@ -403,7 +403,7 @@ static ssize_t diagc_attr_store(struct ib_device *ibdev, u32 port_num,
 }
 
 #define QIB_DIAGC_ATTR(N)                                                      \
-       static_assert(&((struct qib_ibport *)0)->rvp.n_##N != (u64 *)NULL);    \
+       static_assert(__same_type(((struct qib_ibport *)0)->rvp.n_##N, u64));  \
        static struct qib_diagc_attr qib_diagc_attr_##N = {                    \
                .attr = __ATTR(N, 0664, diagc_attr_show, diagc_attr_store),    \
                .counter =                                                     \
index 84dd682..b350081 100644 (file)
@@ -90,7 +90,7 @@ struct usnic_ib_dev {
 
 struct usnic_ib_vf {
        struct usnic_ib_dev             *pf;
-       spinlock_t                      lock;
+       struct mutex                    lock;
        struct usnic_vnic               *vnic;
        unsigned int                    qp_grp_ref_cnt;
        struct usnic_ib_pd              *pd;
index 228e9a3..d346dd4 100644 (file)
@@ -572,7 +572,7 @@ static int usnic_ib_pci_probe(struct pci_dev *pdev,
        }
 
        vf->pf = pf;
-       spin_lock_init(&vf->lock);
+       mutex_init(&vf->lock);
        mutex_lock(&pf->usdev_lock);
        list_add_tail(&vf->link, &pf->vf_dev_list);
        /*
index 06a4e9d..756a83b 100644 (file)
@@ -196,7 +196,7 @@ find_free_vf_and_create_qp_grp(struct ib_qp *qp,
                for (i = 0; dev_list[i]; i++) {
                        dev = dev_list[i];
                        vf = dev_get_drvdata(dev);
-                       spin_lock(&vf->lock);
+                       mutex_lock(&vf->lock);
                        vnic = vf->vnic;
                        if (!usnic_vnic_check_room(vnic, res_spec)) {
                                usnic_dbg("Found used vnic %s from %s\n",
@@ -208,10 +208,10 @@ find_free_vf_and_create_qp_grp(struct ib_qp *qp,
                                                             vf, pd, res_spec,
                                                             trans_spec);
 
-                               spin_unlock(&vf->lock);
+                               mutex_unlock(&vf->lock);
                                goto qp_grp_check;
                        }
-                       spin_unlock(&vf->lock);
+                       mutex_unlock(&vf->lock);
 
                }
                usnic_uiom_free_dev_list(dev_list);
@@ -220,7 +220,7 @@ find_free_vf_and_create_qp_grp(struct ib_qp *qp,
 
        /* Try to find resources on an unused vf */
        list_for_each_entry(vf, &us_ibdev->vf_dev_list, link) {
-               spin_lock(&vf->lock);
+               mutex_lock(&vf->lock);
                vnic = vf->vnic;
                if (vf->qp_grp_ref_cnt == 0 &&
                    usnic_vnic_check_room(vnic, res_spec) == 0) {
@@ -228,10 +228,10 @@ find_free_vf_and_create_qp_grp(struct ib_qp *qp,
                                                     vf, pd, res_spec,
                                                     trans_spec);
 
-                       spin_unlock(&vf->lock);
+                       mutex_unlock(&vf->lock);
                        goto qp_grp_check;
                }
-               spin_unlock(&vf->lock);
+               mutex_unlock(&vf->lock);
        }
 
        usnic_info("No free qp grp found on %s\n",
@@ -253,9 +253,9 @@ static void qp_grp_destroy(struct usnic_ib_qp_grp *qp_grp)
 
        WARN_ON(qp_grp->state != IB_QPS_RESET);
 
-       spin_lock(&vf->lock);
+       mutex_lock(&vf->lock);
        usnic_ib_qp_grp_destroy(qp_grp);
-       spin_unlock(&vf->lock);
+       mutex_unlock(&vf->lock);
 }
 
 static int create_qp_validate_user_data(struct usnic_ib_create_qp_cmd cmd)
index 29de841..4c914f7 100644 (file)
@@ -334,6 +334,7 @@ static const struct xpad_device {
        { 0x24c6, 0x5b03, "Thrustmaster Ferrari 458 Racing Wheel", 0, XTYPE_XBOX360 },
        { 0x24c6, 0x5d04, "Razer Sabertooth", 0, XTYPE_XBOX360 },
        { 0x24c6, 0xfafe, "Rock Candy Gamepad for Xbox 360", 0, XTYPE_XBOX360 },
+       { 0x3285, 0x0607, "Nacon GC-100", 0, XTYPE_XBOX360 },
        { 0x3767, 0x0101, "Fanatec Speedster 3 Forceshock Wheel", 0, XTYPE_XBOX },
        { 0xffff, 0xffff, "Chinese-made Xbox Controller", 0, XTYPE_XBOX },
        { 0x0000, 0x0000, "Generic X-Box pad", 0, XTYPE_UNKNOWN }
@@ -451,6 +452,7 @@ static const struct usb_device_id xpad_table[] = {
        XPAD_XBOXONE_VENDOR(0x24c6),            /* PowerA Controllers */
        XPAD_XBOXONE_VENDOR(0x2e24),            /* Hyperkin Duke X-Box One pad */
        XPAD_XBOX360_VENDOR(0x2f24),            /* GameSir Controllers */
+       XPAD_XBOX360_VENDOR(0x3285),            /* Nacon GC-100 */
        { }
 };
 
index 2f5e3ab..6528676 100644 (file)
@@ -3,6 +3,7 @@
 // Driver for the IMX SNVS ON/OFF Power Key
 // Copyright (C) 2015 Freescale Semiconductor, Inc. All Rights Reserved.
 
+#include <linux/clk.h>
 #include <linux/device.h>
 #include <linux/err.h>
 #include <linux/init.h>
@@ -99,6 +100,11 @@ static irqreturn_t imx_snvs_pwrkey_interrupt(int irq, void *dev_id)
        return IRQ_HANDLED;
 }
 
+static void imx_snvs_pwrkey_disable_clk(void *data)
+{
+       clk_disable_unprepare(data);
+}
+
 static void imx_snvs_pwrkey_act(void *pdata)
 {
        struct pwrkey_drv_data *pd = pdata;
@@ -111,6 +117,7 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
        struct pwrkey_drv_data *pdata;
        struct input_dev *input;
        struct device_node *np;
+       struct clk *clk;
        int error;
        u32 vid;
 
@@ -134,6 +141,28 @@ static int imx_snvs_pwrkey_probe(struct platform_device *pdev)
                dev_warn(&pdev->dev, "KEY_POWER without setting in dts\n");
        }
 
+       clk = devm_clk_get_optional(&pdev->dev, NULL);
+       if (IS_ERR(clk)) {
+               dev_err(&pdev->dev, "Failed to get snvs clock (%pe)\n", clk);
+               return PTR_ERR(clk);
+       }
+
+       error = clk_prepare_enable(clk);
+       if (error) {
+               dev_err(&pdev->dev, "Failed to enable snvs clock (%pe)\n",
+                       ERR_PTR(error));
+               return error;
+       }
+
+       error = devm_add_action_or_reset(&pdev->dev,
+                                        imx_snvs_pwrkey_disable_clk, clk);
+       if (error) {
+               dev_err(&pdev->dev,
+                       "Failed to register clock cleanup handler (%pe)\n",
+                       ERR_PTR(error));
+               return error;
+       }
+
        pdata->wakeup = of_property_read_bool(np, "wakeup-source");
 
        pdata->irq = platform_get_irq(pdev, 0);
index dd18cb9..4620e20 100644 (file)
@@ -80,27 +80,27 @@ void touchscreen_parse_properties(struct input_dev *input, bool multitouch,
 
        data_present = touchscreen_get_prop_u32(dev, "touchscreen-min-x",
                                                input_abs_get_min(input, axis_x),
-                                               &minimum) |
-                      touchscreen_get_prop_u32(dev, "touchscreen-size-x",
-                                               input_abs_get_max(input,
-                                                                 axis_x) + 1,
-                                               &maximum) |
-                      touchscreen_get_prop_u32(dev, "touchscreen-fuzz-x",
-                                               input_abs_get_fuzz(input, axis_x),
-                                               &fuzz);
+                                               &minimum);
+       data_present |= touchscreen_get_prop_u32(dev, "touchscreen-size-x",
+                                                input_abs_get_max(input,
+                                                                  axis_x) + 1,
+                                                &maximum);
+       data_present |= touchscreen_get_prop_u32(dev, "touchscreen-fuzz-x",
+                                                input_abs_get_fuzz(input, axis_x),
+                                                &fuzz);
        if (data_present)
                touchscreen_set_params(input, axis_x, minimum, maximum - 1, fuzz);
 
        data_present = touchscreen_get_prop_u32(dev, "touchscreen-min-y",
                                                input_abs_get_min(input, axis_y),
-                                               &minimum) |
-                      touchscreen_get_prop_u32(dev, "touchscreen-size-y",
-                                               input_abs_get_max(input,
-                                                                 axis_y) + 1,
-                                               &maximum) |
-                      touchscreen_get_prop_u32(dev, "touchscreen-fuzz-y",
-                                               input_abs_get_fuzz(input, axis_y),
-                                               &fuzz);
+                                               &minimum);
+       data_present |= touchscreen_get_prop_u32(dev, "touchscreen-size-y",
+                                                input_abs_get_max(input,
+                                                                  axis_y) + 1,
+                                                &maximum);
+       data_present |= touchscreen_get_prop_u32(dev, "touchscreen-fuzz-y",
+                                                input_abs_get_fuzz(input, axis_y),
+                                                &fuzz);
        if (data_present)
                touchscreen_set_params(input, axis_y, minimum, maximum - 1, fuzz);
 
@@ -108,11 +108,11 @@ void touchscreen_parse_properties(struct input_dev *input, bool multitouch,
        data_present = touchscreen_get_prop_u32(dev,
                                                "touchscreen-max-pressure",
                                                input_abs_get_max(input, axis),
-                                               &maximum) |
-                      touchscreen_get_prop_u32(dev,
-                                               "touchscreen-fuzz-pressure",
-                                               input_abs_get_fuzz(input, axis),
-                                               &fuzz);
+                                               &maximum);
+       data_present |= touchscreen_get_prop_u32(dev,
+                                                "touchscreen-fuzz-pressure",
+                                                input_abs_get_fuzz(input, axis),
+                                                &fuzz);
        if (data_present)
                touchscreen_set_params(input, axis, 0, maximum, fuzz);
 
index 744544a..6f754a8 100644 (file)
@@ -71,19 +71,22 @@ static int grts_cb(const void *data, void *private)
                unsigned int z2 = touch_info[st->ch_map[GRTS_CH_Z2]];
                unsigned int Rt;
 
-               Rt = z2;
-               Rt -= z1;
-               Rt *= st->x_plate_ohms;
-               Rt = DIV_ROUND_CLOSEST(Rt, 16);
-               Rt *= x;
-               Rt /= z1;
-               Rt = DIV_ROUND_CLOSEST(Rt, 256);
-               /*
-                * On increased pressure the resistance (Rt) is decreasing
-                * so, convert values to make it looks as real pressure.
-                */
-               if (Rt < GRTS_DEFAULT_PRESSURE_MAX)
-                       press = GRTS_DEFAULT_PRESSURE_MAX - Rt;
+               if (likely(x && z1)) {
+                       Rt = z2;
+                       Rt -= z1;
+                       Rt *= st->x_plate_ohms;
+                       Rt = DIV_ROUND_CLOSEST(Rt, 16);
+                       Rt *= x;
+                       Rt /= z1;
+                       Rt = DIV_ROUND_CLOSEST(Rt, 256);
+                       /*
+                        * On increased pressure the resistance (Rt) is
+                        * decreasing so, convert values to make it looks as
+                        * real pressure.
+                        */
+                       if (Rt < GRTS_DEFAULT_PRESSURE_MAX)
+                               press = GRTS_DEFAULT_PRESSURE_MAX - Rt;
+               }
        }
 
        if ((!x && !y) || (st->pressure && (press < st->pressure_min))) {
index 632dbdd..fb23a5b 100644 (file)
@@ -44,9 +44,9 @@
 #define NOC_PERM_MODE_BYPASS           (1 << NOC_QOS_MODE_BYPASS)
 
 #define NOC_QOS_PRIORITYn_ADDR(n)      (0x8 + (n * 0x1000))
-#define NOC_QOS_PRIORITY_MASK          0xf
+#define NOC_QOS_PRIORITY_P1_MASK       0xc
+#define NOC_QOS_PRIORITY_P0_MASK       0x3
 #define NOC_QOS_PRIORITY_P1_SHIFT      0x2
-#define NOC_QOS_PRIORITY_P0_SHIFT      0x3
 
 #define NOC_QOS_MODEn_ADDR(n)          (0xc + (n * 0x1000))
 #define NOC_QOS_MODEn_MASK             0x3
@@ -173,6 +173,16 @@ static const struct clk_bulk_data bus_mm_clocks[] = {
        { .id = "iface" },
 };
 
+static const struct clk_bulk_data bus_a2noc_clocks[] = {
+       { .id = "bus" },
+       { .id = "bus_a" },
+       { .id = "ipa" },
+       { .id = "ufs_axi" },
+       { .id = "aggre2_ufs_axi" },
+       { .id = "aggre2_usb3_axi" },
+       { .id = "cfg_noc_usb2_axi" },
+};
+
 /**
  * struct qcom_icc_provider - Qualcomm specific interconnect provider
  * @provider: generic interconnect provider
@@ -307,7 +317,7 @@ DEFINE_QNODE(slv_bimc_cfg, SDM660_SLAVE_BIMC_CFG, 4, -1, 56, true, -1, 0, -1, 0)
 DEFINE_QNODE(slv_prng, SDM660_SLAVE_PRNG, 4, -1, 44, true, -1, 0, -1, 0);
 DEFINE_QNODE(slv_spdm, SDM660_SLAVE_SPDM, 4, -1, 60, true, -1, 0, -1, 0);
 DEFINE_QNODE(slv_qdss_cfg, SDM660_SLAVE_QDSS_CFG, 4, -1, 63, true, -1, 0, -1, 0);
-DEFINE_QNODE(slv_cnoc_mnoc_cfg, SDM660_SLAVE_BLSP_1, 4, -1, 66, true, -1, 0, -1, SDM660_MASTER_CNOC_MNOC_CFG);
+DEFINE_QNODE(slv_cnoc_mnoc_cfg, SDM660_SLAVE_CNOC_MNOC_CFG, 4, -1, 66, true, -1, 0, -1, SDM660_MASTER_CNOC_MNOC_CFG);
 DEFINE_QNODE(slv_snoc_cfg, SDM660_SLAVE_SNOC_CFG, 4, -1, 70, true, -1, 0, -1, 0);
 DEFINE_QNODE(slv_qm_cfg, SDM660_SLAVE_QM_CFG, 4, -1, 212, true, -1, 0, -1, 0);
 DEFINE_QNODE(slv_clk_ctl, SDM660_SLAVE_CLK_CTL, 4, -1, 47, true, -1, 0, -1, 0);
@@ -624,13 +634,12 @@ static int qcom_icc_noc_set_qos_priority(struct regmap *rmap,
        /* Must be updated one at a time, P1 first, P0 last */
        val = qos->areq_prio << NOC_QOS_PRIORITY_P1_SHIFT;
        rc = regmap_update_bits(rmap, NOC_QOS_PRIORITYn_ADDR(qos->qos_port),
-                               NOC_QOS_PRIORITY_MASK, val);
+                               NOC_QOS_PRIORITY_P1_MASK, val);
        if (rc)
                return rc;
 
-       val = qos->prio_level << NOC_QOS_PRIORITY_P0_SHIFT;
        return regmap_update_bits(rmap, NOC_QOS_PRIORITYn_ADDR(qos->qos_port),
-                                 NOC_QOS_PRIORITY_MASK, val);
+                                 NOC_QOS_PRIORITY_P0_MASK, qos->prio_level);
 }
 
 static int qcom_icc_set_noc_qos(struct icc_node *src, u64 max_bw)
@@ -810,6 +819,10 @@ static int qnoc_probe(struct platform_device *pdev)
                qp->bus_clks = devm_kmemdup(dev, bus_mm_clocks,
                                            sizeof(bus_mm_clocks), GFP_KERNEL);
                qp->num_clks = ARRAY_SIZE(bus_mm_clocks);
+       } else if (of_device_is_compatible(dev->of_node, "qcom,sdm660-a2noc")) {
+               qp->bus_clks = devm_kmemdup(dev, bus_a2noc_clocks,
+                                           sizeof(bus_a2noc_clocks), GFP_KERNEL);
+               qp->num_clks = ARRAY_SIZE(bus_a2noc_clocks);
        } else {
                if (of_device_is_compatible(dev->of_node, "qcom,sdm660-bimc"))
                        qp->is_bimc_node = true;
index 124c41a..3eb68fa 100644 (file)
@@ -308,7 +308,6 @@ config APPLE_DART
 config ARM_SMMU
        tristate "ARM Ltd. System MMU (SMMU) Support"
        depends on ARM64 || ARM || (COMPILE_TEST && !GENERIC_ATOMIC64)
-       depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y
        select IOMMU_API
        select IOMMU_IO_PGTABLE_LPAE
        select ARM_DMA_USE_IOMMU if ARM
@@ -356,6 +355,14 @@ config ARM_SMMU_DISABLE_BYPASS_BY_DEFAULT
          'arm-smmu.disable_bypass' will continue to override this
          config.
 
+config ARM_SMMU_QCOM
+       def_tristate y
+       depends on ARM_SMMU && ARCH_QCOM
+       select QCOM_SCM
+       help
+         When running on a Qualcomm platform that has the custom variant
+         of the ARM SMMU, this needs to be built into the SMMU driver.
+
 config ARM_SMMU_V3
        tristate "ARM Ltd. System MMU Version 3 (SMMUv3) Support"
        depends on ARM64
@@ -438,7 +445,7 @@ config QCOM_IOMMU
        # Note: iommu drivers cannot (yet?) be built as modules
        bool "Qualcomm IOMMU Support"
        depends on ARCH_QCOM || (COMPILE_TEST && !GENERIC_ATOMIC64)
-       depends on QCOM_SCM=y
+       select QCOM_SCM
        select IOMMU_API
        select IOMMU_IO_PGTABLE_LPAE
        select ARM_DMA_USE_IOMMU
index 559db92..fdfa39e 100644 (file)
@@ -183,7 +183,6 @@ struct apple_dart_master_cfg {
 
 static struct platform_driver apple_dart_driver;
 static const struct iommu_ops apple_dart_iommu_ops;
-static const struct iommu_flush_ops apple_dart_tlb_ops;
 
 static struct apple_dart_domain *to_dart_domain(struct iommu_domain *dom)
 {
@@ -338,22 +337,6 @@ static void apple_dart_iotlb_sync_map(struct iommu_domain *domain,
        apple_dart_domain_flush_tlb(to_dart_domain(domain));
 }
 
-static void apple_dart_tlb_flush_all(void *cookie)
-{
-       apple_dart_domain_flush_tlb(cookie);
-}
-
-static void apple_dart_tlb_flush_walk(unsigned long iova, size_t size,
-                                     size_t granule, void *cookie)
-{
-       apple_dart_domain_flush_tlb(cookie);
-}
-
-static const struct iommu_flush_ops apple_dart_tlb_ops = {
-       .tlb_flush_all = apple_dart_tlb_flush_all,
-       .tlb_flush_walk = apple_dart_tlb_flush_walk,
-};
-
 static phys_addr_t apple_dart_iova_to_phys(struct iommu_domain *domain,
                                           dma_addr_t iova)
 {
@@ -435,7 +418,6 @@ static int apple_dart_finalize_domain(struct iommu_domain *domain,
                .ias = 32,
                .oas = 36,
                .coherent_walk = 1,
-               .tlb = &apple_dart_tlb_ops,
                .iommu_dev = dart->dev,
        };
 
@@ -661,16 +643,34 @@ static int apple_dart_of_xlate(struct device *dev, struct of_phandle_args *args)
        return -EINVAL;
 }
 
+static DEFINE_MUTEX(apple_dart_groups_lock);
+
+static void apple_dart_release_group(void *iommu_data)
+{
+       int i, sid;
+       struct apple_dart_stream_map *stream_map;
+       struct apple_dart_master_cfg *group_master_cfg = iommu_data;
+
+       mutex_lock(&apple_dart_groups_lock);
+
+       for_each_stream_map(i, group_master_cfg, stream_map)
+               for_each_set_bit(sid, &stream_map->sidmap, DART_MAX_STREAMS)
+                       stream_map->dart->sid2group[sid] = NULL;
+
+       kfree(iommu_data);
+       mutex_unlock(&apple_dart_groups_lock);
+}
+
 static struct iommu_group *apple_dart_device_group(struct device *dev)
 {
-       static DEFINE_MUTEX(lock);
        int i, sid;
        struct apple_dart_master_cfg *cfg = dev_iommu_priv_get(dev);
        struct apple_dart_stream_map *stream_map;
+       struct apple_dart_master_cfg *group_master_cfg;
        struct iommu_group *group = NULL;
        struct iommu_group *res = ERR_PTR(-EINVAL);
 
-       mutex_lock(&lock);
+       mutex_lock(&apple_dart_groups_lock);
 
        for_each_stream_map(i, cfg, stream_map) {
                for_each_set_bit(sid, &stream_map->sidmap, DART_MAX_STREAMS) {
@@ -698,6 +698,20 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
 #endif
                group = generic_device_group(dev);
 
+       res = ERR_PTR(-ENOMEM);
+       if (!group)
+               goto out;
+
+       group_master_cfg = kzalloc(sizeof(*group_master_cfg), GFP_KERNEL);
+       if (!group_master_cfg) {
+               iommu_group_put(group);
+               goto out;
+       }
+
+       memcpy(group_master_cfg, cfg, sizeof(*group_master_cfg));
+       iommu_group_set_iommudata(group, group_master_cfg,
+               apple_dart_release_group);
+
        for_each_stream_map(i, cfg, stream_map)
                for_each_set_bit(sid, &stream_map->sidmap, DART_MAX_STREAMS)
                        stream_map->dart->sid2group[sid] = group;
@@ -705,7 +719,7 @@ static struct iommu_group *apple_dart_device_group(struct device *dev)
        res = group;
 
 out:
-       mutex_unlock(&lock);
+       mutex_unlock(&apple_dart_groups_lock);
        return res;
 }
 
index e240a7b..b0cc01a 100644 (file)
@@ -1,4 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0
 obj-$(CONFIG_QCOM_IOMMU) += qcom_iommu.o
 obj-$(CONFIG_ARM_SMMU) += arm_smmu.o
-arm_smmu-objs += arm-smmu.o arm-smmu-impl.o arm-smmu-nvidia.o arm-smmu-qcom.o
+arm_smmu-objs += arm-smmu.o arm-smmu-impl.o arm-smmu-nvidia.o
+arm_smmu-$(CONFIG_ARM_SMMU_QCOM) += arm-smmu-qcom.o
index 9f465e1..2c25cce 100644 (file)
@@ -215,7 +215,8 @@ struct arm_smmu_device *arm_smmu_impl_init(struct arm_smmu_device *smmu)
            of_device_is_compatible(np, "nvidia,tegra186-smmu"))
                return nvidia_smmu_impl_init(smmu);
 
-       smmu = qcom_smmu_impl_init(smmu);
+       if (IS_ENABLED(CONFIG_ARM_SMMU_QCOM))
+               smmu = qcom_smmu_impl_init(smmu);
 
        if (of_device_is_compatible(np, "marvell,ap806-smmu-500"))
                smmu->impl = &mrvl_mmu500_impl;
index 0ec5514..b7708b9 100644 (file)
@@ -1942,18 +1942,18 @@ static int dmar_fault_do_one(struct intel_iommu *iommu, int type,
        reason = dmar_get_fault_reason(fault_reason, &fault_type);
 
        if (fault_type == INTR_REMAP)
-               pr_err("[INTR-REMAP] Request device [0x%02x:0x%02x.%d] fault index 0x%llx [fault reason 0x%02x] %s\n",
+               pr_err("[INTR-REMAP] Request device [%02x:%02x.%d] fault index 0x%llx [fault reason 0x%02x] %s\n",
                       source_id >> 8, PCI_SLOT(source_id & 0xFF),
                       PCI_FUNC(source_id & 0xFF), addr >> 48,
                       fault_reason, reason);
        else if (pasid == INVALID_IOASID)
-               pr_err("[%s NO_PASID] Request device [0x%02x:0x%02x.%d] fault addr 0x%llx [fault reason 0x%02x] %s\n",
+               pr_err("[%s NO_PASID] Request device [%02x:%02x.%d] fault addr 0x%llx [fault reason 0x%02x] %s\n",
                       type ? "DMA Read" : "DMA Write",
                       source_id >> 8, PCI_SLOT(source_id & 0xFF),
                       PCI_FUNC(source_id & 0xFF), addr,
                       fault_reason, reason);
        else
-               pr_err("[%s PASID 0x%x] Request device [0x%02x:0x%02x.%d] fault addr 0x%llx [fault reason 0x%02x] %s\n",
+               pr_err("[%s PASID 0x%x] Request device [%02x:%02x.%d] fault addr 0x%llx [fault reason 0x%02x] %s\n",
                       type ? "DMA Read" : "DMA Write", pasid,
                       source_id >> 8, PCI_SLOT(source_id & 0xFF),
                       PCI_FUNC(source_id & 0xFF), addr,
index c14e65a..c709861 100644 (file)
@@ -33,6 +33,7 @@ struct ipoctal_channel {
        unsigned int                    pointer_read;
        unsigned int                    pointer_write;
        struct tty_port                 tty_port;
+       bool                            tty_registered;
        union scc2698_channel __iomem   *regs;
        union scc2698_block __iomem     *block_regs;
        unsigned int                    board_id;
@@ -81,22 +82,34 @@ static int ipoctal_port_activate(struct tty_port *port, struct tty_struct *tty)
        return 0;
 }
 
-static int ipoctal_open(struct tty_struct *tty, struct file *file)
+static int ipoctal_install(struct tty_driver *driver, struct tty_struct *tty)
 {
        struct ipoctal_channel *channel = dev_get_drvdata(tty->dev);
        struct ipoctal *ipoctal = chan_to_ipoctal(channel, tty->index);
-       int err;
-
-       tty->driver_data = channel;
+       int res;
 
        if (!ipack_get_carrier(ipoctal->dev))
                return -EBUSY;
 
-       err = tty_port_open(&channel->tty_port, tty, file);
-       if (err)
-               ipack_put_carrier(ipoctal->dev);
+       res = tty_standard_install(driver, tty);
+       if (res)
+               goto err_put_carrier;
+
+       tty->driver_data = channel;
+
+       return 0;
+
+err_put_carrier:
+       ipack_put_carrier(ipoctal->dev);
+
+       return res;
+}
+
+static int ipoctal_open(struct tty_struct *tty, struct file *file)
+{
+       struct ipoctal_channel *channel = tty->driver_data;
 
-       return err;
+       return tty_port_open(&channel->tty_port, tty, file);
 }
 
 static void ipoctal_reset_stats(struct ipoctal_stats *stats)
@@ -264,7 +277,6 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
        int res;
        int i;
        struct tty_driver *tty;
-       char name[20];
        struct ipoctal_channel *channel;
        struct ipack_region *region;
        void __iomem *addr;
@@ -355,8 +367,11 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
        /* Fill struct tty_driver with ipoctal data */
        tty->owner = THIS_MODULE;
        tty->driver_name = KBUILD_MODNAME;
-       sprintf(name, KBUILD_MODNAME ".%d.%d.", bus_nr, slot);
-       tty->name = name;
+       tty->name = kasprintf(GFP_KERNEL, KBUILD_MODNAME ".%d.%d.", bus_nr, slot);
+       if (!tty->name) {
+               res = -ENOMEM;
+               goto err_put_driver;
+       }
        tty->major = 0;
 
        tty->minor_start = 0;
@@ -371,8 +386,7 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
        res = tty_register_driver(tty);
        if (res) {
                dev_err(&ipoctal->dev->dev, "Can't register tty driver.\n");
-               tty_driver_kref_put(tty);
-               return res;
+               goto err_free_name;
        }
 
        /* Save struct tty_driver for use it when uninstalling the device */
@@ -383,7 +397,9 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
 
                channel = &ipoctal->channel[i];
                tty_port_init(&channel->tty_port);
-               tty_port_alloc_xmit_buf(&channel->tty_port);
+               res = tty_port_alloc_xmit_buf(&channel->tty_port);
+               if (res)
+                       continue;
                channel->tty_port.ops = &ipoctal_tty_port_ops;
 
                ipoctal_reset_stats(&channel->stats);
@@ -391,13 +407,15 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
                spin_lock_init(&channel->lock);
                channel->pointer_read = 0;
                channel->pointer_write = 0;
-               tty_dev = tty_port_register_device(&channel->tty_port, tty, i, NULL);
+               tty_dev = tty_port_register_device_attr(&channel->tty_port, tty,
+                                                       i, NULL, channel, NULL);
                if (IS_ERR(tty_dev)) {
                        dev_err(&ipoctal->dev->dev, "Failed to register tty device.\n");
+                       tty_port_free_xmit_buf(&channel->tty_port);
                        tty_port_destroy(&channel->tty_port);
                        continue;
                }
-               dev_set_drvdata(tty_dev, channel);
+               channel->tty_registered = true;
        }
 
        /*
@@ -409,6 +427,13 @@ static int ipoctal_inst_slot(struct ipoctal *ipoctal, unsigned int bus_nr,
                                       ipoctal_irq_handler, ipoctal);
 
        return 0;
+
+err_free_name:
+       kfree(tty->name);
+err_put_driver:
+       tty_driver_kref_put(tty);
+
+       return res;
 }
 
 static inline int ipoctal_copy_write_buffer(struct ipoctal_channel *channel,
@@ -648,6 +673,7 @@ static void ipoctal_cleanup(struct tty_struct *tty)
 
 static const struct tty_operations ipoctal_fops = {
        .ioctl =                NULL,
+       .install =              ipoctal_install,
        .open =                 ipoctal_open,
        .close =                ipoctal_close,
        .write =                ipoctal_write_tty,
@@ -690,12 +716,17 @@ static void __ipoctal_remove(struct ipoctal *ipoctal)
 
        for (i = 0; i < NR_CHANNELS; i++) {
                struct ipoctal_channel *channel = &ipoctal->channel[i];
+
+               if (!channel->tty_registered)
+                       continue;
+
                tty_unregister_device(ipoctal->tty_drv, i);
                tty_port_free_xmit_buf(&channel->tty_port);
                tty_port_destroy(&channel->tty_port);
        }
 
        tty_unregister_driver(ipoctal->tty_drv);
+       kfree(ipoctal->tty_drv->name);
        tty_driver_kref_put(ipoctal->tty_drv);
        kfree(ipoctal);
 }
index 4d5924e..aca7b59 100644 (file)
@@ -409,6 +409,7 @@ config MESON_IRQ_GPIO
 config GOLDFISH_PIC
        bool "Goldfish programmable interrupt controller"
        depends on MIPS && (GOLDFISH || COMPILE_TEST)
+       select GENERIC_IRQ_CHIP
        select IRQ_DOMAIN
        help
          Say yes here to enable Goldfish interrupt controller driver used
index 7557ab5..53e0fb0 100644 (file)
@@ -359,16 +359,16 @@ static void armada_370_xp_ipi_send_mask(struct irq_data *d,
                ARMADA_370_XP_SW_TRIG_INT_OFFS);
 }
 
-static void armada_370_xp_ipi_eoi(struct irq_data *d)
+static void armada_370_xp_ipi_ack(struct irq_data *d)
 {
        writel(~BIT(d->hwirq), per_cpu_int_base + ARMADA_370_XP_IN_DRBEL_CAUSE_OFFS);
 }
 
 static struct irq_chip ipi_irqchip = {
        .name           = "IPI",
+       .irq_ack        = armada_370_xp_ipi_ack,
        .irq_mask       = armada_370_xp_ipi_mask,
        .irq_unmask     = armada_370_xp_ipi_unmask,
-       .irq_eoi        = armada_370_xp_ipi_eoi,
        .ipi_send_mask  = armada_370_xp_ipi_send_mask,
 };
 
index 7f40dca..eb0882d 100644 (file)
@@ -4501,7 +4501,7 @@ static int its_vpe_irq_domain_alloc(struct irq_domain *domain, unsigned int virq
 
        if (err) {
                if (i > 0)
-                       its_vpe_irq_domain_free(domain, virq, i - 1);
+                       its_vpe_irq_domain_free(domain, virq, i);
 
                its_lpi_free(bitmap, base, nr_ids);
                its_free_prop_table(vprop_page);
index d329ec3..5f22c9d 100644 (file)
@@ -107,6 +107,8 @@ static DEFINE_RAW_SPINLOCK(cpu_map_lock);
 
 #endif
 
+static DEFINE_STATIC_KEY_FALSE(needs_rmw_access);
+
 /*
  * The GIC mapping of CPU interfaces does not necessarily match
  * the logical CPU numbering.  Let's use a mapping as returned
@@ -774,6 +776,25 @@ static int gic_pm_init(struct gic_chip_data *gic)
 #endif
 
 #ifdef CONFIG_SMP
+static void rmw_writeb(u8 bval, void __iomem *addr)
+{
+       static DEFINE_RAW_SPINLOCK(rmw_lock);
+       unsigned long offset = (unsigned long)addr & 3UL;
+       unsigned long shift = offset * 8;
+       unsigned long flags;
+       u32 val;
+
+       raw_spin_lock_irqsave(&rmw_lock, flags);
+
+       addr -= offset;
+       val = readl_relaxed(addr);
+       val &= ~GENMASK(shift + 7, shift);
+       val |= bval << shift;
+       writel_relaxed(val, addr);
+
+       raw_spin_unlock_irqrestore(&rmw_lock, flags);
+}
+
 static int gic_set_affinity(struct irq_data *d, const struct cpumask *mask_val,
                            bool force)
 {
@@ -788,7 +809,10 @@ static int gic_set_affinity(struct irq_data *d, const struct cpumask *mask_val,
        if (cpu >= NR_GIC_CPU_IF || cpu >= nr_cpu_ids)
                return -EINVAL;
 
-       writeb_relaxed(gic_cpu_map[cpu], reg);
+       if (static_branch_unlikely(&needs_rmw_access))
+               rmw_writeb(gic_cpu_map[cpu], reg);
+       else
+               writeb_relaxed(gic_cpu_map[cpu], reg);
        irq_data_update_effective_affinity(d, cpumask_of(cpu));
 
        return IRQ_SET_MASK_OK_DONE;
@@ -1375,6 +1399,30 @@ static bool gic_check_eoimode(struct device_node *node, void __iomem **base)
        return true;
 }
 
+static bool gic_enable_rmw_access(void *data)
+{
+       /*
+        * The EMEV2 class of machines has a broken interconnect, and
+        * locks up on accesses that are less than 32bit. So far, only
+        * the affinity setting requires it.
+        */
+       if (of_machine_is_compatible("renesas,emev2")) {
+               static_branch_enable(&needs_rmw_access);
+               return true;
+       }
+
+       return false;
+}
+
+static const struct gic_quirk gic_quirks[] = {
+       {
+               .desc           = "broken byte access",
+               .compatible     = "arm,pl390",
+               .init           = gic_enable_rmw_access,
+       },
+       { },
+};
+
 static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
 {
        if (!gic || !node)
@@ -1391,6 +1439,8 @@ static int gic_of_setup(struct gic_chip_data *gic, struct device_node *node)
        if (of_property_read_u32(node, "cpu-offset", &gic->percpu_offset))
                gic->percpu_offset = 0;
 
+       gic_enable_of_quirks(node, gic_quirks, gic);
+
        return 0;
 
 error:
index f565317..12df216 100644 (file)
@@ -25,7 +25,7 @@
 /* The maximum IRQ pin number of mbigen chip(start from 0) */
 #define MAXIMUM_IRQ_PIN_NUM            1407
 
-/**
+/*
  * In mbigen vector register
  * bit[21:12]: event id value
  * bit[11:0]:  device id
 /* offset of vector register in mbigen node */
 #define REG_MBIGEN_VEC_OFFSET          0x200
 
-/**
+/*
  * offset of clear register in mbigen node
  * This register is used to clear the status
  * of interrupt
  */
 #define REG_MBIGEN_CLEAR_OFFSET                0xa000
 
-/**
+/*
  * offset of interrupt type register
  * This register is used to configure interrupt
  * trigger type
index b0d46ac..72c06e8 100644 (file)
@@ -223,12 +223,12 @@ static int rza1_irqc_probe(struct platform_device *pdev)
                goto out_put_node;
        }
 
-       priv->chip.name = "rza1-irqc",
-       priv->chip.irq_mask = irq_chip_mask_parent,
-       priv->chip.irq_unmask = irq_chip_unmask_parent,
-       priv->chip.irq_eoi = rza1_irqc_eoi,
-       priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy,
-       priv->chip.irq_set_type = rza1_irqc_set_type,
+       priv->chip.name = "rza1-irqc";
+       priv->chip.irq_mask = irq_chip_mask_parent;
+       priv->chip.irq_unmask = irq_chip_unmask_parent;
+       priv->chip.irq_eoi = rza1_irqc_eoi;
+       priv->chip.irq_retrigger = irq_chip_retrigger_hierarchy;
+       priv->chip.irq_set_type = rza1_irqc_set_type;
        priv->chip.flags = IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_SKIP_SET_WAKE;
 
        priv->irq_domain = irq_domain_add_hierarchy(parent, 0, IRQC_NUM_IRQ,
index cb0afe8..7313454 100644 (file)
@@ -480,6 +480,11 @@ int detach_capi_ctr(struct capi_ctr *ctr)
 
        ctr_down(ctr, CAPI_CTR_DETACHED);
 
+       if (ctr->cnr < 1 || ctr->cnr - 1 >= CAPI_MAXCONTR) {
+               err = -EINVAL;
+               goto unlock_out;
+       }
+
        if (capi_controller[ctr->cnr - 1] != ctr) {
                err = -EINVAL;
                goto unlock_out;
index 2a1ddd4..a52f275 100644 (file)
@@ -949,8 +949,8 @@ nj_release(struct tiger_hw *card)
                nj_disable_hwirq(card);
                mode_tiger(&card->bc[0], ISDN_P_NONE);
                mode_tiger(&card->bc[1], ISDN_P_NONE);
-               card->isac.release(&card->isac);
                spin_unlock_irqrestore(&card->lock, flags);
+               card->isac.release(&card->isac);
                release_region(card->base, card->base_s);
                card->base_s = 0;
        }
index 94fb63a..fe63d5e 100644 (file)
@@ -570,7 +570,7 @@ fail_msg_node:
 fail_db_node:
        of_node_put(smu->db_node);
 fail_bootmem:
-       memblock_free(__pa(smu), sizeof(struct smu_device));
+       memblock_free_ptr(smu, sizeof(struct smu_device));
        smu = NULL;
 fail_np:
        of_node_put(np);
index edf4ee6..cf128b3 100644 (file)
@@ -275,8 +275,8 @@ struct mcb_bus *mcb_alloc_bus(struct device *carrier)
 
        bus_nr = ida_simple_get(&mcb_ida, 0, 0, GFP_KERNEL);
        if (bus_nr < 0) {
-               rc = bus_nr;
-               goto err_free;
+               kfree(bus);
+               return ERR_PTR(bus_nr);
        }
 
        bus->bus_nr = bus_nr;
@@ -291,12 +291,12 @@ struct mcb_bus *mcb_alloc_bus(struct device *carrier)
        dev_set_name(&bus->dev, "mcb:%d", bus_nr);
        rc = device_add(&bus->dev);
        if (rc)
-               goto err_free;
+               goto err_put;
 
        return bus;
-err_free:
-       put_device(carrier);
-       kfree(bus);
+
+err_put:
+       put_device(&bus->dev);
        return ERR_PTR(rc);
 }
 EXPORT_SYMBOL_NS_GPL(mcb_alloc_bus, MCB);
index 84dbe08..edd22e4 100644 (file)
@@ -161,7 +161,7 @@ static const char *clone_device_name(struct clone *clone)
 
 static void __set_clone_mode(struct clone *clone, enum clone_metadata_mode new_mode)
 {
-       const char *descs[] = {
+       static const char * const descs[] = {
                "read-write",
                "read-only",
                "fail"
index 5b95eea..a896dea 100644 (file)
@@ -490,6 +490,14 @@ static blk_status_t dm_mq_queue_rq(struct blk_mq_hw_ctx *hctx,
        struct mapped_device *md = tio->md;
        struct dm_target *ti = md->immutable_target;
 
+       /*
+        * blk-mq's unquiesce may come from outside events, such as
+        * elevator switch, updating nr_requests or others, and request may
+        * come during suspend, so simply ask for blk-mq to requeue it.
+        */
+       if (unlikely(test_bit(DMF_BLOCK_IO_FOR_SUSPEND, &md->flags)))
+               return BLK_STS_RESOURCE;
+
        if (unlikely(!ti)) {
                int srcu_idx;
                struct dm_table *map = dm_get_live_table(md, &srcu_idx);
index 22a5ac8..88288c8 100644 (file)
@@ -475,6 +475,7 @@ static int verity_verify_io(struct dm_verity_io *io)
        struct bvec_iter start;
        unsigned b;
        struct crypto_wait wait;
+       struct bio *bio = dm_bio_from_per_bio_data(io, v->ti->per_io_data_size);
 
        for (b = 0; b < io->n_blocks; b++) {
                int r;
@@ -529,9 +530,17 @@ static int verity_verify_io(struct dm_verity_io *io)
                else if (verity_fec_decode(v, io, DM_VERITY_BLOCK_TYPE_DATA,
                                           cur_block, NULL, &start) == 0)
                        continue;
-               else if (verity_handle_err(v, DM_VERITY_BLOCK_TYPE_DATA,
-                                          cur_block))
-                       return -EIO;
+               else {
+                       if (bio->bi_status) {
+                               /*
+                                * Error correction failed; Just return error
+                                */
+                               return -EIO;
+                       }
+                       if (verity_handle_err(v, DM_VERITY_BLOCK_TYPE_DATA,
+                                             cur_block))
+                               return -EIO;
+               }
        }
 
        return 0;
index a011d09..76d9da4 100644 (file)
@@ -496,18 +496,17 @@ static void start_io_acct(struct dm_io *io)
                                    false, 0, &io->stats_aux);
 }
 
-static void end_io_acct(struct dm_io *io)
+static void end_io_acct(struct mapped_device *md, struct bio *bio,
+                       unsigned long start_time, struct dm_stats_aux *stats_aux)
 {
-       struct mapped_device *md = io->md;
-       struct bio *bio = io->orig_bio;
-       unsigned long duration = jiffies - io->start_time;
+       unsigned long duration = jiffies - start_time;
 
-       bio_end_io_acct(bio, io->start_time);
+       bio_end_io_acct(bio, start_time);
 
        if (unlikely(dm_stats_used(&md->stats)))
                dm_stats_account_io(&md->stats, bio_data_dir(bio),
                                    bio->bi_iter.bi_sector, bio_sectors(bio),
-                                   true, duration, &io->stats_aux);
+                                   true, duration, stats_aux);
 
        /* nudge anyone waiting on suspend queue */
        if (unlikely(wq_has_sleeper(&md->wait)))
@@ -790,6 +789,8 @@ void dm_io_dec_pending(struct dm_io *io, blk_status_t error)
        blk_status_t io_error;
        struct bio *bio;
        struct mapped_device *md = io->md;
+       unsigned long start_time = 0;
+       struct dm_stats_aux stats_aux;
 
        /* Push-back supersedes any I/O errors */
        if (unlikely(error)) {
@@ -821,8 +822,10 @@ void dm_io_dec_pending(struct dm_io *io, blk_status_t error)
                }
 
                io_error = io->status;
-               end_io_acct(io);
+               start_time = io->start_time;
+               stats_aux = io->stats_aux;
                free_io(md, io);
+               end_io_acct(md, bio, start_time, &stats_aux);
 
                if (io_error == BLK_STS_DM_REQUEUE)
                        return;
index ae8fe54..6c0c3d0 100644 (file)
@@ -5700,10 +5700,6 @@ static int md_alloc(dev_t dev, char *name)
        disk->flags |= GENHD_FL_EXT_DEVT;
        disk->events |= DISK_EVENT_MEDIA_CHANGE;
        mddev->gendisk = disk;
-       /* As soon as we call add_disk(), another thread could get
-        * through to md_open, so make sure it doesn't get too far
-        */
-       mutex_lock(&mddev->open_mutex);
        add_disk(disk);
 
        error = kobject_add(&mddev->kobj, &disk_to_dev(disk)->kobj, "%s", "md");
@@ -5718,7 +5714,6 @@ static int md_alloc(dev_t dev, char *name)
        if (mddev->kobj.sd &&
            sysfs_create_group(&mddev->kobj, &md_bitmap_group))
                pr_debug("pointless warning\n");
-       mutex_unlock(&mddev->open_mutex);
  abort:
        mutex_unlock(&disks_mutex);
        if (!error && mddev->kobj.sd) {
index 157c924..80321e0 100644 (file)
@@ -565,7 +565,7 @@ config VIDEO_QCOM_VENUS
        depends on VIDEO_DEV && VIDEO_V4L2 && QCOM_SMEM
        depends on (ARCH_QCOM && IOMMU_DMA) || COMPILE_TEST
        select QCOM_MDT_LOADER if ARCH_QCOM
-       select QCOM_SCM if ARCH_QCOM
+       select QCOM_SCM
        select VIDEOBUF2_DMA_CONTIG
        select V4L2_MEM2MEM_DEV
        help
index d402e45..7d0ab19 100644 (file)
@@ -1140,8 +1140,8 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
                        continue;
                length = 0;
                switch (c) {
-               /* SOF0: baseline JPEG */
-               case SOF0:
+               /* JPEG_MARKER_SOF0: baseline JPEG */
+               case JPEG_MARKER_SOF0:
                        if (get_word_be(&jpeg_buffer, &word))
                                break;
                        length = (long)word - 2;
@@ -1172,7 +1172,7 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
                        notfound = 0;
                        break;
 
-               case DQT:
+               case JPEG_MARKER_DQT:
                        if (get_word_be(&jpeg_buffer, &word))
                                break;
                        length = (long)word - 2;
@@ -1185,7 +1185,7 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
                        skip(&jpeg_buffer, length);
                        break;
 
-               case DHT:
+               case JPEG_MARKER_DHT:
                        if (get_word_be(&jpeg_buffer, &word))
                                break;
                        length = (long)word - 2;
@@ -1198,15 +1198,15 @@ static bool s5p_jpeg_parse_hdr(struct s5p_jpeg_q_data *result,
                        skip(&jpeg_buffer, length);
                        break;
 
-               case SOS:
+               case JPEG_MARKER_SOS:
                        sos = jpeg_buffer.curr - 2; /* 0xffda */
                        break;
 
                /* skip payload-less markers */
-               case RST ... RST + 7:
-               case SOI:
-               case EOI:
-               case TEM:
+               case JPEG_MARKER_RST ... JPEG_MARKER_RST + 7:
+               case JPEG_MARKER_SOI:
+               case JPEG_MARKER_EOI:
+               case JPEG_MARKER_TEM:
                        break;
 
                /* skip uninteresting payload markers */
index a77d93c..8473a01 100644 (file)
 #define EXYNOS3250_IRQ_TIMEOUT         0x10000000
 
 /* a selection of JPEG markers */
-#define TEM                            0x01
-#define SOF0                           0xc0
-#define DHT                            0xc4
-#define RST                            0xd0
-#define SOI                            0xd8
-#define EOI                            0xd9
-#define        SOS                             0xda
-#define DQT                            0xdb
-#define DHP                            0xde
+#define JPEG_MARKER_TEM                                0x01
+#define JPEG_MARKER_SOF0                               0xc0
+#define JPEG_MARKER_DHT                                0xc4
+#define JPEG_MARKER_RST                                0xd0
+#define JPEG_MARKER_SOI                                0xd8
+#define JPEG_MARKER_EOI                                0xd9
+#define        JPEG_MARKER_SOS                         0xda
+#define JPEG_MARKER_DQT                                0xdb
+#define JPEG_MARKER_DHP                                0xde
 
 /* Flags that indicate a format can be used for capture/output */
 #define SJPEG_FMT_FLAG_ENC_CAPTURE     (1 << 0)
@@ -187,11 +187,11 @@ struct s5p_jpeg_marker {
  * @fmt:       driver-specific format of this queue
  * @w:         image width
  * @h:         image height
- * @sos:       SOS marker's position relative to the buffer beginning
- * @dht:       DHT markers' positions relative to the buffer beginning
- * @dqt:       DQT markers' positions relative to the buffer beginning
- * @sof:       SOF0 marker's position relative to the buffer beginning
- * @sof_len:   SOF0 marker's payload length (without length field itself)
+ * @sos:       JPEG_MARKER_SOS's position relative to the buffer beginning
+ * @dht:       JPEG_MARKER_DHT' positions relative to the buffer beginning
+ * @dqt:       JPEG_MARKER_DQT' positions relative to the buffer beginning
+ * @sof:       JPEG_MARKER_SOF0's position relative to the buffer beginning
+ * @sof_len:   JPEG_MARKER_SOF0's payload length (without length field itself)
  * @size:      image buffer size in bytes
  */
 struct s5p_jpeg_q_data {
index 3e729a1..48d52ba 100644 (file)
@@ -24,6 +24,7 @@ static const u8 COMMAND_VERSION[] = { 'v' };
 // End transmit and repeat reset command so we exit sump mode
 static const u8 COMMAND_RESET[] = { 0xff, 0xff, 0, 0, 0, 0, 0 };
 static const u8 COMMAND_SMODE_ENTER[] = { 's' };
+static const u8 COMMAND_SMODE_EXIT[] = { 0 };
 static const u8 COMMAND_TXSTART[] = { 0x26, 0x24, 0x25, 0x03 };
 
 #define REPLY_XMITCOUNT 't'
@@ -309,12 +310,30 @@ static int irtoy_tx(struct rc_dev *rc, uint *txbuf, uint count)
                buf[i] = cpu_to_be16(v);
        }
 
-       buf[count] = cpu_to_be16(0xffff);
+       buf[count] = 0xffff;
 
        irtoy->tx_buf = buf;
        irtoy->tx_len = size;
        irtoy->emitted = 0;
 
+       // There is an issue where if the unit is receiving IR while the
+       // first TXSTART command is sent, the device might end up hanging
+       // with its led on. It does not respond to any command when this
+       // happens. To work around this, re-enter sample mode.
+       err = irtoy_command(irtoy, COMMAND_SMODE_EXIT,
+                           sizeof(COMMAND_SMODE_EXIT), STATE_RESET);
+       if (err) {
+               dev_err(irtoy->dev, "exit sample mode: %d\n", err);
+               return err;
+       }
+
+       err = irtoy_command(irtoy, COMMAND_SMODE_ENTER,
+                           sizeof(COMMAND_SMODE_ENTER), STATE_COMMAND);
+       if (err) {
+               dev_err(irtoy->dev, "enter sample mode: %d\n", err);
+               return err;
+       }
+
        err = irtoy_command(irtoy, COMMAND_TXSTART, sizeof(COMMAND_TXSTART),
                            STATE_TX);
        kfree(buf);
index 85ba901..0f5a49f 100644 (file)
@@ -224,6 +224,7 @@ config HI6421V600_IRQ
        tristate "HiSilicon Hi6421v600 IRQ and powerkey"
        depends on OF
        depends on SPMI
+       depends on HAS_IOMEM
        select MFD_CORE
        select REGMAP_SPMI
        help
index 1b6076a..6669625 100644 (file)
@@ -267,13 +267,13 @@ int bcm_vk_tty_init(struct bcm_vk *vk, char *name)
                struct device *tty_dev;
 
                tty_port_init(&vk->tty[i].port);
-               tty_dev = tty_port_register_device(&vk->tty[i].port, tty_drv,
-                                                  i, dev);
+               tty_dev = tty_port_register_device_attr(&vk->tty[i].port,
+                                                       tty_drv, i, dev, vk,
+                                                       NULL);
                if (IS_ERR(tty_dev)) {
                        err = PTR_ERR(tty_dev);
                        goto unwind;
                }
-               dev_set_drvdata(tty_dev, vk);
                vk->tty[i].is_opened = false;
        }
 
index e5a4ed3..a798fad 100644 (file)
@@ -47,7 +47,7 @@ static inline bool needs_unaligned_copy(const void *ptr)
 #ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
        return false;
 #else
-       return ((ptr - NULL) & 3) != 0;
+       return ((uintptr_t)ptr & 3) != 0;
 #endif
 }
 
index 4d09b67..6323254 100644 (file)
@@ -366,6 +366,13 @@ static const struct of_device_id at25_of_match[] = {
 };
 MODULE_DEVICE_TABLE(of, at25_of_match);
 
+static const struct spi_device_id at25_spi_ids[] = {
+       { .name = "at25",},
+       { .name = "fm25",},
+       { }
+};
+MODULE_DEVICE_TABLE(spi, at25_spi_ids);
+
 static int at25_probe(struct spi_device *spi)
 {
        struct at25_data        *at25 = NULL;
@@ -491,6 +498,7 @@ static struct spi_driver at25_driver = {
                .dev_groups     = sernum_groups,
        },
        .probe          = at25_probe,
+       .id_table       = at25_spi_ids,
 };
 
 module_spi_driver(at25_driver);
index 29d8971..1f15399 100644 (file)
@@ -406,6 +406,23 @@ static const struct of_device_id eeprom_93xx46_of_table[] = {
 };
 MODULE_DEVICE_TABLE(of, eeprom_93xx46_of_table);
 
+static const struct spi_device_id eeprom_93xx46_spi_ids[] = {
+       { .name = "eeprom-93xx46",
+         .driver_data = (kernel_ulong_t)&at93c46_data, },
+       { .name = "at93c46",
+         .driver_data = (kernel_ulong_t)&at93c46_data, },
+       { .name = "at93c46d",
+         .driver_data = (kernel_ulong_t)&atmel_at93c46d_data, },
+       { .name = "at93c56",
+         .driver_data = (kernel_ulong_t)&at93c56_data, },
+       { .name = "at93c66",
+         .driver_data = (kernel_ulong_t)&at93c66_data, },
+       { .name = "93lc46b",
+         .driver_data = (kernel_ulong_t)&microchip_93lc46b_data, },
+       {}
+};
+MODULE_DEVICE_TABLE(spi, eeprom_93xx46_spi_ids);
+
 static int eeprom_93xx46_probe_dt(struct spi_device *spi)
 {
        const struct of_device_id *of_id =
@@ -555,6 +572,7 @@ static struct spi_driver eeprom_93xx46_driver = {
        },
        .probe          = eeprom_93xx46_probe,
        .remove         = eeprom_93xx46_remove,
+       .id_table       = eeprom_93xx46_spi_ids,
 };
 
 module_spi_driver(eeprom_93xx46_driver);
index beda610..ad6ced4 100644 (file)
@@ -814,10 +814,12 @@ static int fastrpc_get_args(u32 kernel, struct fastrpc_invoke_ctx *ctx)
                        rpra[i].pv = (u64) ctx->args[i].ptr;
                        pages[i].addr = ctx->maps[i]->phys;
 
+                       mmap_read_lock(current->mm);
                        vma = find_vma(current->mm, ctx->args[i].ptr);
                        if (vma)
                                pages[i].addr += ctx->args[i].ptr -
                                                 vma->vm_start;
+                       mmap_read_unlock(current->mm);
 
                        pg_start = (ctx->args[i].ptr & PAGE_MASK) >> PAGE_SHIFT;
                        pg_end = ((ctx->args[i].ptr + len - 1) & PAGE_MASK) >>
index 02f33bc..4c9c539 100644 (file)
@@ -539,6 +539,7 @@ static int gehc_achc_probe(struct spi_device *spi)
 
 static const struct spi_device_id gehc_achc_id[] = {
        { "ge,achc", 0 },
+       { "achc", 0 },
        { }
 };
 MODULE_DEVICE_TABLE(spi, gehc_achc_id);
index 2e1befb..6939818 100644 (file)
@@ -1090,7 +1090,7 @@ static int genwqe_pci_setup(struct genwqe_dev *cd)
 
        /* check for 64-bit DMA address supported (DAC) */
        /* check for 32-bit DMA address supported (SAC) */
-       if (dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(64)) ||
+       if (dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(64)) &&
            dma_set_mask_and_coherent(&pci_dev->dev, DMA_BIT_MASK(32))) {
                dev_err(&pci_dev->dev,
                        "err: neither DMA32 nor DMA64 supported\n");
index 7b0516c..6dafff3 100644 (file)
@@ -405,7 +405,7 @@ static void staged_cs_put(struct hl_device *hdev, struct hl_cs *cs)
 static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs)
 {
        bool next_entry_found = false;
-       struct hl_cs *next;
+       struct hl_cs *next, *first_cs;
 
        if (!cs_needs_timeout(cs))
                return;
@@ -415,9 +415,16 @@ static void cs_handle_tdr(struct hl_device *hdev, struct hl_cs *cs)
        /* We need to handle tdr only once for the complete staged submission.
         * Hence, we choose the CS that reaches this function first which is
         * the CS marked as 'staged_last'.
+        * In case single staged cs was submitted which has both first and last
+        * indications, then "cs_find_first" below will return NULL, since we
+        * removed the cs node from the list before getting here,
+        * in such cases just continue with the cs to cancel it's TDR work.
         */
-       if (cs->staged_cs && cs->staged_last)
-               cs = hl_staged_cs_find_first(hdev, cs->staged_sequence);
+       if (cs->staged_cs && cs->staged_last) {
+               first_cs = hl_staged_cs_find_first(hdev, cs->staged_sequence);
+               if (first_cs)
+                       cs = first_cs;
+       }
 
        spin_unlock(&hdev->cs_mirror_lock);
 
@@ -1288,6 +1295,12 @@ static int cs_ioctl_default(struct hl_fpriv *hpriv, void __user *chunks,
        if (rc)
                goto free_cs_object;
 
+       /* If this is a staged submission we must return the staged sequence
+        * rather than the internal CS sequence
+        */
+       if (cs->staged_cs)
+               *cs_seq = cs->staged_sequence;
+
        /* Validate ALL the CS chunks before submitting the CS */
        for (i = 0 ; i < num_chunks ; i++) {
                struct hl_cs_chunk *chunk = &cs_chunk_array[i];
@@ -1988,6 +2001,15 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type,
                        goto free_cs_chunk_array;
                }
 
+               if (!hdev->nic_ports_mask) {
+                       atomic64_inc(&ctx->cs_counters.validation_drop_cnt);
+                       atomic64_inc(&cntr->validation_drop_cnt);
+                       dev_err(hdev->dev,
+                               "Collective operations not supported when NIC ports are disabled");
+                       rc = -EINVAL;
+                       goto free_cs_chunk_array;
+               }
+
                collective_engine_id = chunk->collective_engine_id;
        }
 
@@ -2026,9 +2048,10 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type,
                        spin_unlock(&ctx->sig_mgr.lock);
 
                        if (!handle_found) {
-                               dev_err(hdev->dev, "Cannot find encapsulated signals handle for seq 0x%llx\n",
+                               /* treat as signal CS already finished */
+                               dev_dbg(hdev->dev, "Cannot find encapsulated signals handle for seq 0x%llx\n",
                                                signal_seq);
-                               rc = -EINVAL;
+                               rc = 0;
                                goto free_cs_chunk_array;
                        }
 
@@ -2613,7 +2636,8 @@ static int hl_multi_cs_wait_ioctl(struct hl_fpriv *hpriv, void *data)
                 * completed after the poll function.
                 */
                if (!mcs_data.completion_bitmap) {
-                       dev_err(hdev->dev, "Multi-CS got completion on wait but no CS completed\n");
+                       dev_warn_ratelimited(hdev->dev,
+                               "Multi-CS got completion on wait but no CS completed\n");
                        rc = -EFAULT;
                }
        }
@@ -2625,11 +2649,18 @@ put_ctx:
 free_seq_arr:
        kfree(cs_seq_arr);
 
-       /* update output args */
-       memset(args, 0, sizeof(*args));
        if (rc)
                return rc;
 
+       if (mcs_data.wait_status == -ERESTARTSYS) {
+               dev_err_ratelimited(hdev->dev,
+                               "user process got signal while waiting for Multi-CS\n");
+               return -EINTR;
+       }
+
+       /* update output args */
+       memset(args, 0, sizeof(*args));
+
        if (mcs_data.completion_bitmap) {
                args->out.status = HL_WAIT_CS_STATUS_COMPLETED;
                args->out.cs_completion_map = mcs_data.completion_bitmap;
@@ -2643,8 +2674,6 @@ free_seq_arr:
                /* update if some CS was gone */
                if (mcs_data.timestamp)
                        args->out.flags |= HL_WAIT_CS_STATUS_FLAG_GONE;
-       } else if (mcs_data.wait_status == -ERESTARTSYS) {
-               args->out.status = HL_WAIT_CS_STATUS_INTERRUPTED;
        } else {
                args->out.status = HL_WAIT_CS_STATUS_BUSY;
        }
@@ -2664,16 +2693,17 @@ static int hl_cs_wait_ioctl(struct hl_fpriv *hpriv, void *data)
        rc = _hl_cs_wait_ioctl(hdev, hpriv->ctx, args->in.timeout_us, seq,
                                &status, &timestamp);
 
+       if (rc == -ERESTARTSYS) {
+               dev_err_ratelimited(hdev->dev,
+                       "user process got signal while waiting for CS handle %llu\n",
+                       seq);
+               return -EINTR;
+       }
+
        memset(args, 0, sizeof(*args));
 
        if (rc) {
-               if (rc == -ERESTARTSYS) {
-                       dev_err_ratelimited(hdev->dev,
-                               "user process got signal while waiting for CS handle %llu\n",
-                               seq);
-                       args->out.status = HL_WAIT_CS_STATUS_INTERRUPTED;
-                       rc = -EINTR;
-               } else if (rc == -ETIMEDOUT) {
+               if (rc == -ETIMEDOUT) {
                        dev_err_ratelimited(hdev->dev,
                                "CS %llu has timed-out while user process is waiting for it\n",
                                seq);
@@ -2740,10 +2770,20 @@ static int _hl_interrupt_wait_ioctl(struct hl_device *hdev, struct hl_ctx *ctx,
        else
                interrupt = &hdev->user_interrupt[interrupt_offset];
 
+       /* Add pending user interrupt to relevant list for the interrupt
+        * handler to monitor
+        */
+       spin_lock_irqsave(&interrupt->wait_list_lock, flags);
+       list_add_tail(&pend->wait_list_node, &interrupt->wait_list_head);
+       spin_unlock_irqrestore(&interrupt->wait_list_lock, flags);
+
+       /* We check for completion value as interrupt could have been received
+        * before we added the node to the wait list
+        */
        if (copy_from_user(&completion_value, u64_to_user_ptr(user_address), 4)) {
                dev_err(hdev->dev, "Failed to copy completion value from user\n");
                rc = -EFAULT;
-               goto free_fence;
+               goto remove_pending_user_interrupt;
        }
 
        if (completion_value >= target_value)
@@ -2752,14 +2792,7 @@ static int _hl_interrupt_wait_ioctl(struct hl_device *hdev, struct hl_ctx *ctx,
                *status = CS_WAIT_STATUS_BUSY;
 
        if (!timeout_us || (*status == CS_WAIT_STATUS_COMPLETED))
-               goto free_fence;
-
-       /* Add pending user interrupt to relevant list for the interrupt
-        * handler to monitor
-        */
-       spin_lock_irqsave(&interrupt->wait_list_lock, flags);
-       list_add_tail(&pend->wait_list_node, &interrupt->wait_list_head);
-       spin_unlock_irqrestore(&interrupt->wait_list_lock, flags);
+               goto remove_pending_user_interrupt;
 
 wait_again:
        /* Wait for interrupt handler to signal completion */
@@ -2770,6 +2803,15 @@ wait_again:
         * If comparison fails, keep waiting until timeout expires
         */
        if (completion_rc > 0) {
+               spin_lock_irqsave(&interrupt->wait_list_lock, flags);
+               /* reinit_completion must be called before we check for user
+                * completion value, otherwise, if interrupt is received after
+                * the comparison and before the next wait_for_completion,
+                * we will reach timeout and fail
+                */
+               reinit_completion(&pend->fence.completion);
+               spin_unlock_irqrestore(&interrupt->wait_list_lock, flags);
+
                if (copy_from_user(&completion_value, u64_to_user_ptr(user_address), 4)) {
                        dev_err(hdev->dev, "Failed to copy completion value from user\n");
                        rc = -EFAULT;
@@ -2780,18 +2822,13 @@ wait_again:
                if (completion_value >= target_value) {
                        *status = CS_WAIT_STATUS_COMPLETED;
                } else {
-                       spin_lock_irqsave(&interrupt->wait_list_lock, flags);
-                       reinit_completion(&pend->fence.completion);
                        timeout = completion_rc;
-
-                       spin_unlock_irqrestore(&interrupt->wait_list_lock, flags);
                        goto wait_again;
                }
        } else if (completion_rc == -ERESTARTSYS) {
                dev_err_ratelimited(hdev->dev,
                        "user process got signal while waiting for interrupt ID %d\n",
                        interrupt->interrupt_id);
-               *status = HL_WAIT_CS_STATUS_INTERRUPTED;
                rc = -EINTR;
        } else {
                *status = CS_WAIT_STATUS_BUSY;
@@ -2802,7 +2839,6 @@ remove_pending_user_interrupt:
        list_del(&pend->wait_list_node);
        spin_unlock_irqrestore(&interrupt->wait_list_lock, flags);
 
-free_fence:
        kfree(pend);
        hl_ctx_put(ctx);
 
@@ -2847,8 +2883,6 @@ static int hl_interrupt_wait_ioctl(struct hl_fpriv *hpriv, void *data)
                                args->in.interrupt_timeout_us, args->in.addr,
                                args->in.target, interrupt_offset, &status);
 
-       memset(args, 0, sizeof(*args));
-
        if (rc) {
                if (rc != -EINTR)
                        dev_err_ratelimited(hdev->dev,
@@ -2857,6 +2891,8 @@ static int hl_interrupt_wait_ioctl(struct hl_fpriv *hpriv, void *data)
                return rc;
        }
 
+       memset(args, 0, sizeof(*args));
+
        switch (status) {
        case CS_WAIT_STATUS_COMPLETED:
                args->out.status = HL_WAIT_CS_STATUS_COMPLETED;
index 76b7de8..0743319 100644 (file)
@@ -437,6 +437,7 @@ void hl_hw_queue_encaps_sig_set_sob_info(struct hl_device *hdev,
                        struct hl_cs_compl *cs_cmpl)
 {
        struct hl_cs_encaps_sig_handle *handle = cs->encaps_sig_hdl;
+       u32 offset = 0;
 
        cs_cmpl->hw_sob = handle->hw_sob;
 
@@ -446,9 +447,13 @@ void hl_hw_queue_encaps_sig_set_sob_info(struct hl_device *hdev,
         * set offset 1 for example he mean to wait only for the first
         * signal only, which will be pre_sob_val, and if he set offset 2
         * then the value required is (pre_sob_val + 1) and so on...
+        * if user set wait offset to 0, then treat it as legacy wait cs,
+        * wait for the next signal.
         */
-       cs_cmpl->sob_val = handle->pre_sob_val +
-                       (job->encaps_sig_wait_offset - 1);
+       if (job->encaps_sig_wait_offset)
+               offset = job->encaps_sig_wait_offset - 1;
+
+       cs_cmpl->sob_val = handle->pre_sob_val + offset;
 }
 
 static int init_wait_cs(struct hl_device *hdev, struct hl_cs *cs,
index 383865b..14da87b 100644 (file)
@@ -395,7 +395,7 @@ static struct hl_hw_obj_name_entry gaudi_so_id_to_str[] = {
 
 static struct hl_hw_obj_name_entry gaudi_monitor_id_to_str[] = {
        { .id = 200, .name = "MON_OBJ_DMA_DOWN_FEEDBACK_RESET" },
-       { .id = 201, .name = "MON_OBJ_DMA_UP_FEADBACK_RESET" },
+       { .id = 201, .name = "MON_OBJ_DMA_UP_FEEDBACK_RESET" },
        { .id = 203, .name = "MON_OBJ_DRAM_TO_SRAM_QUEUE_FENCE" },
        { .id = 204, .name = "MON_OBJ_TPC_0_CLK_GATE" },
        { .id = 205, .name = "MON_OBJ_TPC_1_CLK_GATE" },
@@ -5802,6 +5802,7 @@ static void gaudi_add_end_of_cb_packets(struct hl_device *hdev,
 {
        struct gaudi_device *gaudi = hdev->asic_specific;
        struct packet_msg_prot *cq_pkt;
+       u64 msi_addr;
        u32 tmp;
 
        cq_pkt = kernel_address + len - (sizeof(struct packet_msg_prot) * 2);
@@ -5823,10 +5824,12 @@ static void gaudi_add_end_of_cb_packets(struct hl_device *hdev,
        cq_pkt->ctl = cpu_to_le32(tmp);
        cq_pkt->value = cpu_to_le32(1);
 
-       if (!gaudi->multi_msi_mode)
-               msi_vec = 0;
+       if (gaudi->multi_msi_mode)
+               msi_addr = mmPCIE_MSI_INTR_0 + msi_vec * 4;
+       else
+               msi_addr = mmPCIE_CORE_MSI_REQ;
 
-       cq_pkt->addr = cpu_to_le64(CFG_BASE + mmPCIE_MSI_INTR_0 + msi_vec * 4);
+       cq_pkt->addr = cpu_to_le64(CFG_BASE + msi_addr);
 }
 
 static void gaudi_update_eq_ci(struct hl_device *hdev, u32 val)
index cb265c0..25ac87c 100644 (file)
@@ -8,16 +8,21 @@
 #include "gaudiP.h"
 #include "../include/gaudi/asic_reg/gaudi_regs.h"
 
-#define GAUDI_NUMBER_OF_RR_REGS                24
-#define GAUDI_NUMBER_OF_LBW_RANGES     12
+#define GAUDI_NUMBER_OF_LBW_RR_REGS    28
+#define GAUDI_NUMBER_OF_HBW_RR_REGS    24
+#define GAUDI_NUMBER_OF_LBW_RANGES     10
 
-static u64 gaudi_rr_lbw_hit_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_hit_aw_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_HIT_WPROT,
        mmDMA_IF_W_S_DMA0_HIT_WPROT,
        mmDMA_IF_W_S_DMA1_HIT_WPROT,
+       mmDMA_IF_E_S_SOB_HIT_WPROT,
        mmDMA_IF_E_S_DMA0_HIT_WPROT,
        mmDMA_IF_E_S_DMA1_HIT_WPROT,
+       mmDMA_IF_W_N_SOB_HIT_WPROT,
        mmDMA_IF_W_N_DMA0_HIT_WPROT,
        mmDMA_IF_W_N_DMA1_HIT_WPROT,
+       mmDMA_IF_E_N_SOB_HIT_WPROT,
        mmDMA_IF_E_N_DMA0_HIT_WPROT,
        mmDMA_IF_E_N_DMA1_HIT_WPROT,
        mmSIF_RTR_0_LBW_RANGE_PROT_HIT_AW,
@@ -38,13 +43,17 @@ static u64 gaudi_rr_lbw_hit_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_HIT_AW,
 };
 
-static u64 gaudi_rr_lbw_hit_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_hit_ar_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_HIT_RPROT,
        mmDMA_IF_W_S_DMA0_HIT_RPROT,
        mmDMA_IF_W_S_DMA1_HIT_RPROT,
+       mmDMA_IF_E_S_SOB_HIT_RPROT,
        mmDMA_IF_E_S_DMA0_HIT_RPROT,
        mmDMA_IF_E_S_DMA1_HIT_RPROT,
+       mmDMA_IF_W_N_SOB_HIT_RPROT,
        mmDMA_IF_W_N_DMA0_HIT_RPROT,
        mmDMA_IF_W_N_DMA1_HIT_RPROT,
+       mmDMA_IF_E_N_SOB_HIT_RPROT,
        mmDMA_IF_E_N_DMA0_HIT_RPROT,
        mmDMA_IF_E_N_DMA1_HIT_RPROT,
        mmSIF_RTR_0_LBW_RANGE_PROT_HIT_AR,
@@ -65,13 +74,17 @@ static u64 gaudi_rr_lbw_hit_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_HIT_AR,
 };
 
-static u64 gaudi_rr_lbw_min_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_min_aw_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_MIN_WPROT_0,
        mmDMA_IF_W_S_DMA0_MIN_WPROT_0,
        mmDMA_IF_W_S_DMA1_MIN_WPROT_0,
+       mmDMA_IF_E_S_SOB_MIN_WPROT_0,
        mmDMA_IF_E_S_DMA0_MIN_WPROT_0,
        mmDMA_IF_E_S_DMA1_MIN_WPROT_0,
+       mmDMA_IF_W_N_SOB_MIN_WPROT_0,
        mmDMA_IF_W_N_DMA0_MIN_WPROT_0,
        mmDMA_IF_W_N_DMA1_MIN_WPROT_0,
+       mmDMA_IF_E_N_SOB_MIN_WPROT_0,
        mmDMA_IF_E_N_DMA0_MIN_WPROT_0,
        mmDMA_IF_E_N_DMA1_MIN_WPROT_0,
        mmSIF_RTR_0_LBW_RANGE_PROT_MIN_AW_0,
@@ -92,13 +105,17 @@ static u64 gaudi_rr_lbw_min_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_MIN_AW_0,
 };
 
-static u64 gaudi_rr_lbw_max_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_max_aw_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_MAX_WPROT_0,
        mmDMA_IF_W_S_DMA0_MAX_WPROT_0,
        mmDMA_IF_W_S_DMA1_MAX_WPROT_0,
+       mmDMA_IF_E_S_SOB_MAX_WPROT_0,
        mmDMA_IF_E_S_DMA0_MAX_WPROT_0,
        mmDMA_IF_E_S_DMA1_MAX_WPROT_0,
+       mmDMA_IF_W_N_SOB_MAX_WPROT_0,
        mmDMA_IF_W_N_DMA0_MAX_WPROT_0,
        mmDMA_IF_W_N_DMA1_MAX_WPROT_0,
+       mmDMA_IF_E_N_SOB_MAX_WPROT_0,
        mmDMA_IF_E_N_DMA0_MAX_WPROT_0,
        mmDMA_IF_E_N_DMA1_MAX_WPROT_0,
        mmSIF_RTR_0_LBW_RANGE_PROT_MAX_AW_0,
@@ -119,13 +136,17 @@ static u64 gaudi_rr_lbw_max_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_MAX_AW_0,
 };
 
-static u64 gaudi_rr_lbw_min_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_min_ar_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_MIN_RPROT_0,
        mmDMA_IF_W_S_DMA0_MIN_RPROT_0,
        mmDMA_IF_W_S_DMA1_MIN_RPROT_0,
+       mmDMA_IF_E_S_SOB_MIN_RPROT_0,
        mmDMA_IF_E_S_DMA0_MIN_RPROT_0,
        mmDMA_IF_E_S_DMA1_MIN_RPROT_0,
+       mmDMA_IF_W_N_SOB_MIN_RPROT_0,
        mmDMA_IF_W_N_DMA0_MIN_RPROT_0,
        mmDMA_IF_W_N_DMA1_MIN_RPROT_0,
+       mmDMA_IF_E_N_SOB_MIN_RPROT_0,
        mmDMA_IF_E_N_DMA0_MIN_RPROT_0,
        mmDMA_IF_E_N_DMA1_MIN_RPROT_0,
        mmSIF_RTR_0_LBW_RANGE_PROT_MIN_AR_0,
@@ -146,13 +167,17 @@ static u64 gaudi_rr_lbw_min_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_MIN_AR_0,
 };
 
-static u64 gaudi_rr_lbw_max_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_lbw_max_ar_regs[GAUDI_NUMBER_OF_LBW_RR_REGS] = {
+       mmDMA_IF_W_S_SOB_MAX_RPROT_0,
        mmDMA_IF_W_S_DMA0_MAX_RPROT_0,
        mmDMA_IF_W_S_DMA1_MAX_RPROT_0,
+       mmDMA_IF_E_S_SOB_MAX_RPROT_0,
        mmDMA_IF_E_S_DMA0_MAX_RPROT_0,
        mmDMA_IF_E_S_DMA1_MAX_RPROT_0,
+       mmDMA_IF_W_N_SOB_MAX_RPROT_0,
        mmDMA_IF_W_N_DMA0_MAX_RPROT_0,
        mmDMA_IF_W_N_DMA1_MAX_RPROT_0,
+       mmDMA_IF_E_N_SOB_MAX_RPROT_0,
        mmDMA_IF_E_N_DMA0_MAX_RPROT_0,
        mmDMA_IF_E_N_DMA1_MAX_RPROT_0,
        mmSIF_RTR_0_LBW_RANGE_PROT_MAX_AR_0,
@@ -173,7 +198,7 @@ static u64 gaudi_rr_lbw_max_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_7_LBW_RANGE_PROT_MAX_AR_0,
 };
 
-static u64 gaudi_rr_hbw_hit_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_hit_aw_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_HIT_AW,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_HIT_AW,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_HIT_AW,
@@ -200,7 +225,7 @@ static u64 gaudi_rr_hbw_hit_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_HIT_AW
 };
 
-static u64 gaudi_rr_hbw_hit_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_hit_ar_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_HIT_AR,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_HIT_AR,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_HIT_AR,
@@ -227,7 +252,7 @@ static u64 gaudi_rr_hbw_hit_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_HIT_AR
 };
 
-static u64 gaudi_rr_hbw_base_low_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_base_low_aw_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_BASE_LOW_AW_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_BASE_LOW_AW_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_BASE_LOW_AW_0,
@@ -254,7 +279,7 @@ static u64 gaudi_rr_hbw_base_low_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_BASE_LOW_AW_0
 };
 
-static u64 gaudi_rr_hbw_base_high_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_base_high_aw_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_BASE_HIGH_AW_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_BASE_HIGH_AW_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_BASE_HIGH_AW_0,
@@ -281,7 +306,7 @@ static u64 gaudi_rr_hbw_base_high_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_BASE_HIGH_AW_0
 };
 
-static u64 gaudi_rr_hbw_mask_low_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_mask_low_aw_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_MASK_LOW_AW_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_MASK_LOW_AW_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_MASK_LOW_AW_0,
@@ -308,7 +333,7 @@ static u64 gaudi_rr_hbw_mask_low_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_MASK_LOW_AW_0
 };
 
-static u64 gaudi_rr_hbw_mask_high_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_mask_high_aw_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_MASK_HIGH_AW_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_MASK_HIGH_AW_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_MASK_HIGH_AW_0,
@@ -335,7 +360,7 @@ static u64 gaudi_rr_hbw_mask_high_aw_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_MASK_HIGH_AW_0
 };
 
-static u64 gaudi_rr_hbw_base_low_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_base_low_ar_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_BASE_LOW_AR_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_BASE_LOW_AR_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_BASE_LOW_AR_0,
@@ -362,7 +387,7 @@ static u64 gaudi_rr_hbw_base_low_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_BASE_LOW_AR_0
 };
 
-static u64 gaudi_rr_hbw_base_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_base_high_ar_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_BASE_HIGH_AR_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_BASE_HIGH_AR_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_BASE_HIGH_AR_0,
@@ -389,7 +414,7 @@ static u64 gaudi_rr_hbw_base_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_BASE_HIGH_AR_0
 };
 
-static u64 gaudi_rr_hbw_mask_low_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_mask_low_ar_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_MASK_LOW_AR_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_MASK_LOW_AR_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_MASK_LOW_AR_0,
@@ -416,7 +441,7 @@ static u64 gaudi_rr_hbw_mask_low_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
        mmNIF_RTR_CTRL_7_RANGE_SEC_MASK_LOW_AR_0
 };
 
-static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_RR_REGS] = {
+static u64 gaudi_rr_hbw_mask_high_ar_regs[GAUDI_NUMBER_OF_HBW_RR_REGS] = {
        mmDMA_IF_W_S_DOWN_CH0_RANGE_SEC_MASK_HIGH_AR_0,
        mmDMA_IF_W_S_DOWN_CH1_RANGE_SEC_MASK_HIGH_AR_0,
        mmDMA_IF_E_S_DOWN_CH0_RANGE_SEC_MASK_HIGH_AR_0,
@@ -12849,50 +12874,44 @@ static void gaudi_init_range_registers_lbw(struct hl_device *hdev)
        u32 lbw_rng_end[GAUDI_NUMBER_OF_LBW_RANGES];
        int i, j;
 
-       lbw_rng_start[0]  = (0xFBFE0000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[0]    = (0xFBFFF000 & 0x3FFFFFF) + 1;
+       lbw_rng_start[0]  = (0xFC0E8000 & 0x3FFFFFF) - 1; /* 0x000E7FFF */
+       lbw_rng_end[0]    = (0xFC11FFFF & 0x3FFFFFF) + 1; /* 0x00120000 */
 
-       lbw_rng_start[1]  = (0xFC0E8000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[1]    = (0xFC120000 & 0x3FFFFFF) + 1;
+       lbw_rng_start[1]  = (0xFC1E8000 & 0x3FFFFFF) - 1; /* 0x001E7FFF */
+       lbw_rng_end[1]    = (0xFC48FFFF & 0x3FFFFFF) + 1; /* 0x00490000 */
 
-       lbw_rng_start[2]  = (0xFC1E8000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[2]    = (0xFC48FFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[2]  = (0xFC600000 & 0x3FFFFFF) - 1; /* 0x005FFFFF */
+       lbw_rng_end[2]    = (0xFCC48FFF & 0x3FFFFFF) + 1; /* 0x00C49000 */
 
-       lbw_rng_start[3]  = (0xFC600000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[3]    = (0xFCC48FFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[3]  = (0xFCC4A000 & 0x3FFFFFF) - 1; /* 0x00C49FFF */
+       lbw_rng_end[3]    = (0xFCCDFFFF & 0x3FFFFFF) + 1; /* 0x00CE0000 */
 
-       lbw_rng_start[4]  = (0xFCC4A000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[4]    = (0xFCCDFFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[4]  = (0xFCCE4000 & 0x3FFFFFF) - 1; /* 0x00CE3FFF */
+       lbw_rng_end[4]    = (0xFCD1FFFF & 0x3FFFFFF) + 1; /* 0x00D20000 */
 
-       lbw_rng_start[5]  = (0xFCCE4000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[5]    = (0xFCD1FFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[5]  = (0xFCD24000 & 0x3FFFFFF) - 1; /* 0x00D23FFF */
+       lbw_rng_end[5]    = (0xFCD5FFFF & 0x3FFFFFF) + 1; /* 0x00D60000 */
 
-       lbw_rng_start[6]  = (0xFCD24000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[6]    = (0xFCD5FFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[6]  = (0xFCD64000 & 0x3FFFFFF) - 1; /* 0x00D63FFF */
+       lbw_rng_end[6]    = (0xFCD9FFFF & 0x3FFFFFF) + 1; /* 0x00DA0000 */
 
-       lbw_rng_start[7]  = (0xFCD64000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[7]    = (0xFCD9FFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[7]  = (0xFCDA4000 & 0x3FFFFFF) - 1; /* 0x00DA3FFF */
+       lbw_rng_end[7]    = (0xFCDDFFFF & 0x3FFFFFF) + 1; /* 0x00DE0000 */
 
-       lbw_rng_start[8]  = (0xFCDA4000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[8]    = (0xFCDDFFFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[8]  = (0xFCDE4000 & 0x3FFFFFF) - 1; /* 0x00DE3FFF */
+       lbw_rng_end[8]    = (0xFCE05FFF & 0x3FFFFFF) + 1; /* 0x00E06000 */
 
-       lbw_rng_start[9]  = (0xFCDE4000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[9]    = (0xFCE05FFF & 0x3FFFFFF) + 1;
+       lbw_rng_start[9]  = (0xFCFC9000 & 0x3FFFFFF) - 1; /* 0x00FC8FFF */
+       lbw_rng_end[9]    = (0xFFFFFFFE & 0x3FFFFFF) + 1; /* 0x03FFFFFF */
 
-       lbw_rng_start[10]  = (0xFEC43000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[10]    = (0xFEC43FFF & 0x3FFFFFF) + 1;
-
-       lbw_rng_start[11] = (0xFE484000 & 0x3FFFFFF) - 1;
-       lbw_rng_end[11]   = (0xFE484FFF & 0x3FFFFFF) + 1;
-
-       for (i = 0 ; i < GAUDI_NUMBER_OF_RR_REGS ; i++) {
+       for (i = 0 ; i < GAUDI_NUMBER_OF_LBW_RR_REGS ; i++) {
                WREG32(gaudi_rr_lbw_hit_aw_regs[i],
                                (1 << GAUDI_NUMBER_OF_LBW_RANGES) - 1);
                WREG32(gaudi_rr_lbw_hit_ar_regs[i],
                                (1 << GAUDI_NUMBER_OF_LBW_RANGES) - 1);
        }
 
-       for (i = 0 ; i < GAUDI_NUMBER_OF_RR_REGS ; i++)
+       for (i = 0 ; i < GAUDI_NUMBER_OF_LBW_RR_REGS ; i++)
                for (j = 0 ; j < GAUDI_NUMBER_OF_LBW_RANGES ; j++) {
                        WREG32(gaudi_rr_lbw_min_aw_regs[i] + (j << 2),
                                                        lbw_rng_start[j]);
@@ -12939,12 +12958,12 @@ static void gaudi_init_range_registers_hbw(struct hl_device *hdev)
         * 6th range is the host
         */
 
-       for (i = 0 ; i < GAUDI_NUMBER_OF_RR_REGS ; i++) {
+       for (i = 0 ; i < GAUDI_NUMBER_OF_HBW_RR_REGS ; i++) {
                WREG32(gaudi_rr_hbw_hit_aw_regs[i], 0x1F);
                WREG32(gaudi_rr_hbw_hit_ar_regs[i], 0x1D);
        }
 
-       for (i = 0 ; i < GAUDI_NUMBER_OF_RR_REGS ; i++) {
+       for (i = 0 ; i < GAUDI_NUMBER_OF_HBW_RR_REGS ; i++) {
                WREG32(gaudi_rr_hbw_base_low_aw_regs[i], dram_addr_lo);
                WREG32(gaudi_rr_hbw_base_low_ar_regs[i], dram_addr_lo);
 
index ffdfbd9..1a65766 100644 (file)
 #define mmPCIE_AUX_FLR_CTRL                                          0xC07394
 #define mmPCIE_AUX_DBI                                               0xC07490
 
+#define mmPCIE_CORE_MSI_REQ                                          0xC04100
+
 #define mmPSOC_PCI_PLL_NR                                            0xC72100
 #define mmSRAM_W_PLL_NR                                              0x4C8100
 #define mmPSOC_HBM_PLL_NR                                            0xC74100
index 99b5c1e..be41843 100644 (file)
@@ -1298,7 +1298,8 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 
                if (dev->dev_state != MEI_DEV_INIT_CLIENTS ||
                    dev->hbm_state != MEI_HBM_STARTING) {
-                       if (dev->dev_state == MEI_DEV_POWER_DOWN) {
+                       if (dev->dev_state == MEI_DEV_POWER_DOWN ||
+                           dev->dev_state == MEI_DEV_POWERING_DOWN) {
                                dev_dbg(dev->dev, "hbm: start: on shutdown, ignoring\n");
                                return 0;
                        }
@@ -1381,7 +1382,8 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 
                if (dev->dev_state != MEI_DEV_INIT_CLIENTS ||
                    dev->hbm_state != MEI_HBM_DR_SETUP) {
-                       if (dev->dev_state == MEI_DEV_POWER_DOWN) {
+                       if (dev->dev_state == MEI_DEV_POWER_DOWN ||
+                           dev->dev_state == MEI_DEV_POWERING_DOWN) {
                                dev_dbg(dev->dev, "hbm: dma setup response: on shutdown, ignoring\n");
                                return 0;
                        }
@@ -1448,7 +1450,8 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 
                if (dev->dev_state != MEI_DEV_INIT_CLIENTS ||
                    dev->hbm_state != MEI_HBM_CLIENT_PROPERTIES) {
-                       if (dev->dev_state == MEI_DEV_POWER_DOWN) {
+                       if (dev->dev_state == MEI_DEV_POWER_DOWN ||
+                           dev->dev_state == MEI_DEV_POWERING_DOWN) {
                                dev_dbg(dev->dev, "hbm: properties response: on shutdown, ignoring\n");
                                return 0;
                        }
@@ -1490,7 +1493,8 @@ int mei_hbm_dispatch(struct mei_device *dev, struct mei_msg_hdr *hdr)
 
                if (dev->dev_state != MEI_DEV_INIT_CLIENTS ||
                    dev->hbm_state != MEI_HBM_ENUM_CLIENTS) {
-                       if (dev->dev_state == MEI_DEV_POWER_DOWN) {
+                       if (dev->dev_state == MEI_DEV_POWER_DOWN ||
+                           dev->dev_state == MEI_DEV_POWERING_DOWN) {
                                dev_dbg(dev->dev, "hbm: enumeration response: on shutdown, ignoring\n");
                                return 0;
                        }
index cb34925..67bb6a2 100644 (file)
@@ -92,6 +92,7 @@
 #define MEI_DEV_ID_CDF        0x18D3  /* Cedar Fork */
 
 #define MEI_DEV_ID_ICP_LP     0x34E0  /* Ice Lake Point LP */
+#define MEI_DEV_ID_ICP_N      0x38E0  /* Ice Lake Point N */
 
 #define MEI_DEV_ID_JSP_N      0x4DE0  /* Jasper Lake Point N */
 
index c3393b3..3a45aaf 100644 (file)
@@ -96,6 +96,7 @@ static const struct pci_device_id mei_me_pci_tbl[] = {
        {MEI_PCI_DEVICE(MEI_DEV_ID_CMP_H_3, MEI_ME_PCH8_ITOUCH_CFG)},
 
        {MEI_PCI_DEVICE(MEI_DEV_ID_ICP_LP, MEI_ME_PCH12_CFG)},
+       {MEI_PCI_DEVICE(MEI_DEV_ID_ICP_N, MEI_ME_PCH12_CFG)},
 
        {MEI_PCI_DEVICE(MEI_DEV_ID_TGP_LP, MEI_ME_PCH15_CFG)},
        {MEI_PCI_DEVICE(MEI_DEV_ID_TGP_H, MEI_ME_PCH15_SPS_CFG)},
index 7131396..95b3511 100644 (file)
@@ -547,7 +547,7 @@ config MMC_SDHCI_MSM
        depends on MMC_SDHCI_PLTFM
        select MMC_SDHCI_IO_ACCESSORS
        select MMC_CQHCI
-       select QCOM_SCM if MMC_CRYPTO && ARCH_QCOM
+       select QCOM_SCM if MMC_CRYPTO
        help
          This selects the Secure Digital Host Controller Interface (SDHCI)
          support present in Qualcomm SOCs. The controller supports
index 6578cc6..380f9aa 100644 (file)
@@ -1802,10 +1802,15 @@ static enum hrtimer_restart dw_mci_fault_timer(struct hrtimer *t)
 
        spin_lock_irqsave(&host->irq_lock, flags);
 
-       if (!host->data_status)
+       /*
+        * Only inject an error if we haven't already got an error or data over
+        * interrupt.
+        */
+       if (!host->data_status) {
                host->data_status = SDMMC_INT_DCRC;
-       set_bit(EVENT_DATA_ERROR, &host->pending_events);
-       tasklet_schedule(&host->tasklet);
+               set_bit(EVENT_DATA_ERROR, &host->pending_events);
+               tasklet_schedule(&host->tasklet);
+       }
 
        spin_unlock_irqrestore(&host->irq_lock, flags);
 
@@ -2721,12 +2726,16 @@ static irqreturn_t dw_mci_interrupt(int irq, void *dev_id)
                }
 
                if (pending & DW_MCI_DATA_ERROR_FLAGS) {
+                       spin_lock(&host->irq_lock);
+
                        /* if there is an error report DATA_ERROR */
                        mci_writel(host, RINTSTS, DW_MCI_DATA_ERROR_FLAGS);
                        host->data_status = pending;
                        smp_wmb(); /* drain writebuffer */
                        set_bit(EVENT_DATA_ERROR, &host->pending_events);
                        tasklet_schedule(&host->tasklet);
+
+                       spin_unlock(&host->irq_lock);
                }
 
                if (pending & SDMMC_INT_DATA_OVER) {
index 3f28eb4..8f36536 100644 (file)
@@ -746,7 +746,7 @@ static void meson_mmc_desc_chain_transfer(struct mmc_host *mmc, u32 cmd_cfg)
        writel(start, host->regs + SD_EMMC_START);
 }
 
-/* local sg copy to buffer version with _to/fromio usage for dram_access_quirk */
+/* local sg copy for dram_access_quirk */
 static void meson_mmc_copy_buffer(struct meson_host *host, struct mmc_data *data,
                                  size_t buflen, bool to_buffer)
 {
@@ -764,21 +764,27 @@ static void meson_mmc_copy_buffer(struct meson_host *host, struct mmc_data *data
        sg_miter_start(&miter, sgl, nents, sg_flags);
 
        while ((offset < buflen) && sg_miter_next(&miter)) {
-               unsigned int len;
+               unsigned int buf_offset = 0;
+               unsigned int len, left;
+               u32 *buf = miter.addr;
 
                len = min(miter.length, buflen - offset);
+               left = len;
 
-               /* When dram_access_quirk, the bounce buffer is a iomem mapping */
-               if (host->dram_access_quirk) {
-                       if (to_buffer)
-                               memcpy_toio(host->bounce_iomem_buf + offset, miter.addr, len);
-                       else
-                               memcpy_fromio(miter.addr, host->bounce_iomem_buf + offset, len);
+               if (to_buffer) {
+                       do {
+                               writel(*buf++, host->bounce_iomem_buf + offset + buf_offset);
+
+                               buf_offset += 4;
+                               left -= 4;
+                       } while (left);
                } else {
-                       if (to_buffer)
-                               memcpy(host->bounce_buf + offset, miter.addr, len);
-                       else
-                               memcpy(miter.addr, host->bounce_buf + offset, len);
+                       do {
+                               *buf++ = readl(host->bounce_iomem_buf + offset + buf_offset);
+
+                               buf_offset += 4;
+                               left -= 4;
+                       } while (left);
                }
 
                offset += len;
@@ -830,7 +836,11 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
                if (data->flags & MMC_DATA_WRITE) {
                        cmd_cfg |= CMD_CFG_DATA_WR;
                        WARN_ON(xfer_bytes > host->bounce_buf_size);
-                       meson_mmc_copy_buffer(host, data, xfer_bytes, true);
+                       if (host->dram_access_quirk)
+                               meson_mmc_copy_buffer(host, data, xfer_bytes, true);
+                       else
+                               sg_copy_to_buffer(data->sg, data->sg_len,
+                                                 host->bounce_buf, xfer_bytes);
                        dma_wmb();
                }
 
@@ -849,12 +859,43 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
        writel(cmd->arg, host->regs + SD_EMMC_CMD_ARG);
 }
 
+static int meson_mmc_validate_dram_access(struct mmc_host *mmc, struct mmc_data *data)
+{
+       struct scatterlist *sg;
+       int i;
+
+       /* Reject request if any element offset or size is not 32bit aligned */
+       for_each_sg(data->sg, sg, data->sg_len, i) {
+               if (!IS_ALIGNED(sg->offset, sizeof(u32)) ||
+                   !IS_ALIGNED(sg->length, sizeof(u32))) {
+                       dev_err(mmc_dev(mmc), "unaligned sg offset %u len %u\n",
+                               data->sg->offset, data->sg->length);
+                       return -EINVAL;
+               }
+       }
+
+       return 0;
+}
+
 static void meson_mmc_request(struct mmc_host *mmc, struct mmc_request *mrq)
 {
        struct meson_host *host = mmc_priv(mmc);
        bool needs_pre_post_req = mrq->data &&
                        !(mrq->data->host_cookie & SD_EMMC_PRE_REQ_DONE);
 
+       /*
+        * The memory at the end of the controller used as bounce buffer for
+        * the dram_access_quirk only accepts 32bit read/write access,
+        * check the aligment and length of the data before starting the request.
+        */
+       if (host->dram_access_quirk && mrq->data) {
+               mrq->cmd->error = meson_mmc_validate_dram_access(mmc, mrq->data);
+               if (mrq->cmd->error) {
+                       mmc_request_done(mmc, mrq);
+                       return;
+               }
+       }
+
        if (needs_pre_post_req) {
                meson_mmc_get_transfer_mode(mmc, mrq);
                if (!meson_mmc_desc_chain_mode(mrq->data))
@@ -999,7 +1040,11 @@ static irqreturn_t meson_mmc_irq_thread(int irq, void *dev_id)
        if (meson_mmc_bounce_buf_read(data)) {
                xfer_bytes = data->blksz * data->blocks;
                WARN_ON(xfer_bytes > host->bounce_buf_size);
-               meson_mmc_copy_buffer(host, data, xfer_bytes, false);
+               if (host->dram_access_quirk)
+                       meson_mmc_copy_buffer(host, data, xfer_bytes, false);
+               else
+                       sg_copy_from_buffer(data->sg, data->sg_len,
+                                           host->bounce_buf, xfer_bytes);
        }
 
        next_cmd = meson_mmc_get_next_command(cmd);
index 6fc4cf3..a4407f3 100644 (file)
@@ -561,6 +561,8 @@ static void renesas_sdhi_reset(struct tmio_mmc_host *host)
                /* Unknown why but without polling reset status, it will hang */
                read_poll_timeout(reset_control_status, ret, ret == 0, 1, 100,
                                  false, priv->rstc);
+               /* At least SDHI_VER_GEN2_SDR50 needs manual release of reset */
+               sd_ctrl_write16(host, CTL_RESET_SD, 0x0001);
                priv->needs_adjust_hs400 = false;
                renesas_sdhi_set_clock(host, host->clk_cache);
        } else if (priv->scc_ctl) {
index 5564d7b..d1a1c54 100644 (file)
@@ -11,6 +11,7 @@
 #include <linux/delay.h>
 #include <linux/err.h>
 #include <linux/io.h>
+#include <linux/iopoll.h>
 #include <linux/kernel.h>
 #include <linux/mmc/host.h>
 #include <linux/mmc/slot-gpio.h>
@@ -61,7 +62,6 @@ static void sdhci_at91_set_force_card_detect(struct sdhci_host *host)
 static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned int clock)
 {
        u16 clk;
-       unsigned long timeout;
 
        host->mmc->actual_clock = 0;
 
@@ -86,16 +86,11 @@ static void sdhci_at91_set_clock(struct sdhci_host *host, unsigned int clock)
        sdhci_writew(host, clk, SDHCI_CLOCK_CONTROL);
 
        /* Wait max 20 ms */
-       timeout = 20;
-       while (!((clk = sdhci_readw(host, SDHCI_CLOCK_CONTROL))
-               & SDHCI_CLOCK_INT_STABLE)) {
-               if (timeout == 0) {
-                       pr_err("%s: Internal clock never stabilised.\n",
-                              mmc_hostname(host->mmc));
-                       return;
-               }
-               timeout--;
-               mdelay(1);
+       if (read_poll_timeout(sdhci_readw, clk, (clk & SDHCI_CLOCK_INT_STABLE),
+                             1000, 20000, false, host, SDHCI_CLOCK_CONTROL)) {
+               pr_err("%s: Internal clock never stabilised.\n",
+                      mmc_hostname(host->mmc));
+               return;
        }
 
        clk |= SDHCI_CLOCK_CARD_EN;
@@ -114,6 +109,7 @@ static void sdhci_at91_reset(struct sdhci_host *host, u8 mask)
 {
        struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
        struct sdhci_at91_priv *priv = sdhci_pltfm_priv(pltfm_host);
+       unsigned int tmp;
 
        sdhci_reset(host, mask);
 
@@ -126,6 +122,10 @@ static void sdhci_at91_reset(struct sdhci_host *host, u8 mask)
 
                sdhci_writel(host, calcr | SDMMC_CALCR_ALWYSON | SDMMC_CALCR_EN,
                             SDMMC_CALCR);
+
+               if (read_poll_timeout(sdhci_readl, tmp, !(tmp & SDMMC_CALCR_EN),
+                                     10, 20000, false, host, SDMMC_CALCR))
+                       dev_err(mmc_dev(host->mmc), "Failed to calibrate\n");
        }
 }
 
index ef0bade..04e6f7b 100644 (file)
@@ -1676,13 +1676,17 @@ qcom_nandc_read_cw_raw(struct mtd_info *mtd, struct nand_chip *chip,
        struct nand_ecc_ctrl *ecc = &chip->ecc;
        int data_size1, data_size2, oob_size1, oob_size2;
        int ret, reg_off = FLASH_BUF_ACC, read_loc = 0;
+       int raw_cw = cw;
 
        nand_read_page_op(chip, page, 0, NULL, 0);
        host->use_ecc = false;
 
+       if (nandc->props->qpic_v2)
+               raw_cw = ecc->steps - 1;
+
        clear_bam_transaction(nandc);
        set_address(host, host->cw_size * cw, page);
-       update_rw_regs(host, 1, true, cw);
+       update_rw_regs(host, 1, true, raw_cw);
        config_nand_page_read(chip);
 
        data_size1 = mtd->writesize - host->cw_size * (ecc->steps - 1);
@@ -1711,7 +1715,7 @@ qcom_nandc_read_cw_raw(struct mtd_info *mtd, struct nand_chip *chip,
                nandc_set_read_loc(chip, cw, 3, read_loc, oob_size2, 1);
        }
 
-       config_nand_cw_read(chip, false, cw);
+       config_nand_cw_read(chip, false, raw_cw);
 
        read_data_dma(nandc, reg_off, data_buf, data_size1, 0);
        reg_off += data_size1;
index a533a90..a7aeb3c 100644 (file)
@@ -351,9 +351,25 @@ static int b53_mdio_probe(struct mdio_device *mdiodev)
 static void b53_mdio_remove(struct mdio_device *mdiodev)
 {
        struct b53_device *dev = dev_get_drvdata(&mdiodev->dev);
-       struct dsa_switch *ds = dev->ds;
 
-       dsa_unregister_switch(ds);
+       if (!dev)
+               return;
+
+       b53_switch_remove(dev);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void b53_mdio_shutdown(struct mdio_device *mdiodev)
+{
+       struct b53_device *dev = dev_get_drvdata(&mdiodev->dev);
+
+       if (!dev)
+               return;
+
+       b53_switch_shutdown(dev);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id b53_of_match[] = {
@@ -373,6 +389,7 @@ MODULE_DEVICE_TABLE(of, b53_of_match);
 static struct mdio_driver b53_mdio_driver = {
        .probe  = b53_mdio_probe,
        .remove = b53_mdio_remove,
+       .shutdown = b53_mdio_shutdown,
        .mdiodrv.driver = {
                .name = "bcm53xx",
                .of_match_table = b53_of_match,
index 82680e0..ae4c79d 100644 (file)
@@ -316,9 +316,21 @@ static int b53_mmap_remove(struct platform_device *pdev)
        if (dev)
                b53_switch_remove(dev);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
+static void b53_mmap_shutdown(struct platform_device *pdev)
+{
+       struct b53_device *dev = platform_get_drvdata(pdev);
+
+       if (dev)
+               b53_switch_shutdown(dev);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static const struct of_device_id b53_mmap_of_table[] = {
        { .compatible = "brcm,bcm3384-switch" },
        { .compatible = "brcm,bcm6328-switch" },
@@ -331,6 +343,7 @@ MODULE_DEVICE_TABLE(of, b53_mmap_of_table);
 static struct platform_driver b53_mmap_driver = {
        .probe = b53_mmap_probe,
        .remove = b53_mmap_remove,
+       .shutdown = b53_mmap_shutdown,
        .driver = {
                .name = "b53-switch",
                .of_match_table = b53_mmap_of_table,
index 5d068ac..959a52d 100644 (file)
@@ -228,6 +228,11 @@ static inline void b53_switch_remove(struct b53_device *dev)
        dsa_unregister_switch(dev->ds);
 }
 
+static inline void b53_switch_shutdown(struct b53_device *dev)
+{
+       dsa_switch_shutdown(dev->ds);
+}
+
 #define b53_build_op(type_op_size, val_type)                           \
 static inline int b53_##type_op_size(struct b53_device *dev, u8 page,  \
                                     u8 reg, val_type val)              \
index ecb9f7f..01e37b7 100644 (file)
@@ -321,9 +321,21 @@ static int b53_spi_remove(struct spi_device *spi)
        if (dev)
                b53_switch_remove(dev);
 
+       spi_set_drvdata(spi, NULL);
+
        return 0;
 }
 
+static void b53_spi_shutdown(struct spi_device *spi)
+{
+       struct b53_device *dev = spi_get_drvdata(spi);
+
+       if (dev)
+               b53_switch_shutdown(dev);
+
+       spi_set_drvdata(spi, NULL);
+}
+
 static const struct of_device_id b53_spi_of_match[] = {
        { .compatible = "brcm,bcm5325" },
        { .compatible = "brcm,bcm5365" },
@@ -344,6 +356,7 @@ static struct spi_driver b53_spi_driver = {
        },
        .probe  = b53_spi_probe,
        .remove = b53_spi_remove,
+       .shutdown = b53_spi_shutdown,
 };
 
 module_spi_driver(b53_spi_driver);
index 3f4249d..4591bb1 100644 (file)
@@ -629,17 +629,34 @@ static int b53_srab_probe(struct platform_device *pdev)
 static int b53_srab_remove(struct platform_device *pdev)
 {
        struct b53_device *dev = platform_get_drvdata(pdev);
-       struct b53_srab_priv *priv = dev->priv;
 
-       b53_srab_intr_set(priv, false);
+       if (!dev)
+               return 0;
+
+       b53_srab_intr_set(dev->priv, false);
        b53_switch_remove(dev);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
+static void b53_srab_shutdown(struct platform_device *pdev)
+{
+       struct b53_device *dev = platform_get_drvdata(pdev);
+
+       if (!dev)
+               return;
+
+       b53_switch_shutdown(dev);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static struct platform_driver b53_srab_driver = {
        .probe = b53_srab_probe,
        .remove = b53_srab_remove,
+       .shutdown = b53_srab_shutdown,
        .driver = {
                .name = "b53-srab-switch",
                .of_match_table = b53_srab_of_match,
index 6ce9ec1..7578a5c 100644 (file)
@@ -68,7 +68,7 @@ static unsigned int bcm_sf2_num_active_ports(struct dsa_switch *ds)
        struct bcm_sf2_priv *priv = bcm_sf2_to_priv(ds);
        unsigned int port, count = 0;
 
-       for (port = 0; port < ARRAY_SIZE(priv->port_sts); port++) {
+       for (port = 0; port < ds->num_ports; port++) {
                if (dsa_is_cpu_port(ds, port))
                        continue;
                if (priv->port_sts[port].enabled)
@@ -1512,6 +1512,9 @@ static int bcm_sf2_sw_remove(struct platform_device *pdev)
 {
        struct bcm_sf2_priv *priv = platform_get_drvdata(pdev);
 
+       if (!priv)
+               return 0;
+
        priv->wol_ports_mask = 0;
        /* Disable interrupts */
        bcm_sf2_intr_disable(priv);
@@ -1523,6 +1526,8 @@ static int bcm_sf2_sw_remove(struct platform_device *pdev)
        if (priv->type == BCM7278_DEVICE_ID)
                reset_control_assert(priv->rcdev);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
@@ -1530,6 +1535,9 @@ static void bcm_sf2_sw_shutdown(struct platform_device *pdev)
 {
        struct bcm_sf2_priv *priv = platform_get_drvdata(pdev);
 
+       if (!priv)
+               return;
+
        /* For a kernel about to be kexec'd we want to keep the GPHY on for a
         * successful MDIO bus scan to occur. If we did turn off the GPHY
         * before (e.g: port_disable), this will also power it back on.
@@ -1538,6 +1546,10 @@ static void bcm_sf2_sw_shutdown(struct platform_device *pdev)
         */
        if (priv->hw_params.num_gphy == 1)
                bcm_sf2_gphy_enable_set(priv->dev->ds, true);
+
+       dsa_switch_shutdown(priv->dev->ds);
+
+       platform_set_drvdata(pdev, NULL);
 }
 
 #ifdef CONFIG_PM_SLEEP
index bfdf332..e638e3e 100644 (file)
@@ -340,10 +340,29 @@ static int dsa_loop_drv_probe(struct mdio_device *mdiodev)
 static void dsa_loop_drv_remove(struct mdio_device *mdiodev)
 {
        struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
-       struct dsa_loop_priv *ps = ds->priv;
+       struct dsa_loop_priv *ps;
+
+       if (!ds)
+               return;
+
+       ps = ds->priv;
 
        dsa_unregister_switch(ds);
        dev_put(ps->netdev);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void dsa_loop_drv_shutdown(struct mdio_device *mdiodev)
+{
+       struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
+
+       if (!ds)
+               return;
+
+       dsa_switch_shutdown(ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static struct mdio_driver dsa_loop_drv = {
@@ -352,6 +371,7 @@ static struct mdio_driver dsa_loop_drv = {
        },
        .probe  = dsa_loop_drv_probe,
        .remove = dsa_loop_drv_remove,
+       .shutdown = dsa_loop_drv_shutdown,
 };
 
 #define NUM_FIXED_PHYS (DSA_LOOP_NUM_PORTS - 2)
index 542cfc4..354655f 100644 (file)
@@ -1916,6 +1916,9 @@ static int hellcreek_remove(struct platform_device *pdev)
 {
        struct hellcreek *hellcreek = platform_get_drvdata(pdev);
 
+       if (!hellcreek)
+               return 0;
+
        hellcreek_hwtstamp_free(hellcreek);
        hellcreek_ptp_free(hellcreek);
        dsa_unregister_switch(hellcreek->ds);
@@ -1924,6 +1927,18 @@ static int hellcreek_remove(struct platform_device *pdev)
        return 0;
 }
 
+static void hellcreek_shutdown(struct platform_device *pdev)
+{
+       struct hellcreek *hellcreek = platform_get_drvdata(pdev);
+
+       if (!hellcreek)
+               return;
+
+       dsa_switch_shutdown(hellcreek->ds);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static const struct hellcreek_platform_data de1soc_r1_pdata = {
        .name            = "r4c30",
        .num_ports       = 4,
@@ -1946,6 +1961,7 @@ MODULE_DEVICE_TABLE(of, hellcreek_of_match);
 static struct platform_driver hellcreek_driver = {
        .probe  = hellcreek_probe,
        .remove = hellcreek_remove,
+       .shutdown = hellcreek_shutdown,
        .driver = {
                .name = "hellcreek",
                .of_match_table = hellcreek_of_match,
index d7ce281..89f9202 100644 (file)
@@ -1379,6 +1379,12 @@ int lan9303_remove(struct lan9303 *chip)
 }
 EXPORT_SYMBOL(lan9303_remove);
 
+void lan9303_shutdown(struct lan9303 *chip)
+{
+       dsa_switch_shutdown(chip->ds);
+}
+EXPORT_SYMBOL(lan9303_shutdown);
+
 MODULE_AUTHOR("Juergen Borleis <kernel@pengutronix.de>");
 MODULE_DESCRIPTION("Core driver for SMSC/Microchip LAN9303 three port ethernet switch");
 MODULE_LICENSE("GPL v2");
index 11f590b..c7f73ef 100644 (file)
@@ -10,3 +10,4 @@ extern const struct lan9303_phy_ops lan9303_indirect_phy_ops;
 
 int lan9303_probe(struct lan9303 *chip, struct device_node *np);
 int lan9303_remove(struct lan9303 *chip);
+void lan9303_shutdown(struct lan9303 *chip);
index 9bffaef..8ca4713 100644 (file)
@@ -67,13 +67,28 @@ static int lan9303_i2c_probe(struct i2c_client *client,
 
 static int lan9303_i2c_remove(struct i2c_client *client)
 {
-       struct lan9303_i2c *sw_dev;
+       struct lan9303_i2c *sw_dev = i2c_get_clientdata(client);
 
-       sw_dev = i2c_get_clientdata(client);
        if (!sw_dev)
-               return -ENODEV;
+               return 0;
+
+       lan9303_remove(&sw_dev->chip);
+
+       i2c_set_clientdata(client, NULL);
+
+       return 0;
+}
+
+static void lan9303_i2c_shutdown(struct i2c_client *client)
+{
+       struct lan9303_i2c *sw_dev = i2c_get_clientdata(client);
+
+       if (!sw_dev)
+               return;
+
+       lan9303_shutdown(&sw_dev->chip);
 
-       return lan9303_remove(&sw_dev->chip);
+       i2c_set_clientdata(client, NULL);
 }
 
 /*-------------------------------------------------------------------------*/
@@ -97,6 +112,7 @@ static struct i2c_driver lan9303_i2c_driver = {
        },
        .probe = lan9303_i2c_probe,
        .remove = lan9303_i2c_remove,
+       .shutdown = lan9303_i2c_shutdown,
        .id_table = lan9303_i2c_id,
 };
 module_i2c_driver(lan9303_i2c_driver);
index 9cbe804..bbb7032 100644 (file)
@@ -138,6 +138,20 @@ static void lan9303_mdio_remove(struct mdio_device *mdiodev)
                return;
 
        lan9303_remove(&sw_dev->chip);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void lan9303_mdio_shutdown(struct mdio_device *mdiodev)
+{
+       struct lan9303_mdio *sw_dev = dev_get_drvdata(&mdiodev->dev);
+
+       if (!sw_dev)
+               return;
+
+       lan9303_shutdown(&sw_dev->chip);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 /*-------------------------------------------------------------------------*/
@@ -155,6 +169,7 @@ static struct mdio_driver lan9303_mdio_driver = {
        },
        .probe  = lan9303_mdio_probe,
        .remove = lan9303_mdio_remove,
+       .shutdown = lan9303_mdio_shutdown,
 };
 mdio_module_driver(lan9303_mdio_driver);
 
index 64d6dfa..3ff4b7e 100644 (file)
@@ -1885,6 +1885,12 @@ static int gswip_gphy_fw_load(struct gswip_priv *priv, struct gswip_gphy_fw *gph
 
        reset_control_assert(gphy_fw->reset);
 
+       /* The vendor BSP uses a 200ms delay after asserting the reset line.
+        * Without this some users are observing that the PHY is not coming up
+        * on the MDIO bus.
+        */
+       msleep(200);
+
        ret = request_firmware(&fw, gphy_fw->fw_name, dev);
        if (ret) {
                dev_err(dev, "failed to load firmware: %s, error: %i\n",
@@ -2178,6 +2184,9 @@ static int gswip_remove(struct platform_device *pdev)
        struct gswip_priv *priv = platform_get_drvdata(pdev);
        int i;
 
+       if (!priv)
+               return 0;
+
        /* disable the switch */
        gswip_mdio_mask(priv, GSWIP_MDIO_GLOB_ENABLE, 0, GSWIP_MDIO_GLOB);
 
@@ -2191,9 +2200,23 @@ static int gswip_remove(struct platform_device *pdev)
        for (i = 0; i < priv->num_gphy_fw; i++)
                gswip_gphy_fw_remove(priv, &priv->gphy_fw[i]);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
+static void gswip_shutdown(struct platform_device *pdev)
+{
+       struct gswip_priv *priv = platform_get_drvdata(pdev);
+
+       if (!priv)
+               return;
+
+       dsa_switch_shutdown(priv->ds);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static const struct gswip_hw_info gswip_xrx200 = {
        .max_ports = 7,
        .cpu_port = 6,
@@ -2217,6 +2240,7 @@ MODULE_DEVICE_TABLE(of, gswip_of_match);
 static struct platform_driver gswip_driver = {
        .probe = gswip_probe,
        .remove = gswip_remove,
+       .shutdown = gswip_shutdown,
        .driver = {
                .name = "gswip",
                .of_match_table = gswip_of_match,
index ea7550d..866767b 100644 (file)
@@ -94,6 +94,8 @@ static int ksz8795_spi_remove(struct spi_device *spi)
        if (dev)
                ksz_switch_remove(dev);
 
+       spi_set_drvdata(spi, NULL);
+
        return 0;
 }
 
@@ -101,8 +103,15 @@ static void ksz8795_spi_shutdown(struct spi_device *spi)
 {
        struct ksz_device *dev = spi_get_drvdata(spi);
 
-       if (dev && dev->dev_ops->shutdown)
+       if (!dev)
+               return;
+
+       if (dev->dev_ops->shutdown)
                dev->dev_ops->shutdown(dev);
+
+       dsa_switch_shutdown(dev->ds);
+
+       spi_set_drvdata(spi, NULL);
 }
 
 static const struct of_device_id ksz8795_dt_ids[] = {
index 1129348..5883fa7 100644 (file)
@@ -191,6 +191,18 @@ static void ksz8863_smi_remove(struct mdio_device *mdiodev)
 
        if (dev)
                ksz_switch_remove(dev);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void ksz8863_smi_shutdown(struct mdio_device *mdiodev)
+{
+       struct ksz_device *dev = dev_get_drvdata(&mdiodev->dev);
+
+       if (dev)
+               dsa_switch_shutdown(dev->ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id ksz8863_dt_ids[] = {
@@ -203,6 +215,7 @@ MODULE_DEVICE_TABLE(of, ksz8863_dt_ids);
 static struct mdio_driver ksz8863_driver = {
        .probe  = ksz8863_smi_probe,
        .remove = ksz8863_smi_remove,
+       .shutdown = ksz8863_smi_shutdown,
        .mdiodrv.driver = {
                .name   = "ksz8863-switch",
                .of_match_table = ksz8863_dt_ids,
index 4e053a2..f3afb8b 100644 (file)
@@ -56,7 +56,10 @@ static int ksz9477_i2c_remove(struct i2c_client *i2c)
 {
        struct ksz_device *dev = i2c_get_clientdata(i2c);
 
-       ksz_switch_remove(dev);
+       if (dev)
+               ksz_switch_remove(dev);
+
+       i2c_set_clientdata(i2c, NULL);
 
        return 0;
 }
@@ -65,8 +68,15 @@ static void ksz9477_i2c_shutdown(struct i2c_client *i2c)
 {
        struct ksz_device *dev = i2c_get_clientdata(i2c);
 
-       if (dev && dev->dev_ops->shutdown)
+       if (!dev)
+               return;
+
+       if (dev->dev_ops->shutdown)
                dev->dev_ops->shutdown(dev);
+
+       dsa_switch_shutdown(dev->ds);
+
+       i2c_set_clientdata(i2c, NULL);
 }
 
 static const struct i2c_device_id ksz9477_i2c_id[] = {
index 15bc11b..e3cb0e6 100644 (file)
@@ -72,6 +72,8 @@ static int ksz9477_spi_remove(struct spi_device *spi)
        if (dev)
                ksz_switch_remove(dev);
 
+       spi_set_drvdata(spi, NULL);
+
        return 0;
 }
 
@@ -79,8 +81,10 @@ static void ksz9477_spi_shutdown(struct spi_device *spi)
 {
        struct ksz_device *dev = spi_get_drvdata(spi);
 
-       if (dev && dev->dev_ops->shutdown)
-               dev->dev_ops->shutdown(dev);
+       if (dev)
+               dsa_switch_shutdown(dev->ds);
+
+       spi_set_drvdata(spi, NULL);
 }
 
 static const struct of_device_id ksz9477_dt_ids[] = {
index 1542bfb..7c2968a 100644 (file)
@@ -449,8 +449,10 @@ EXPORT_SYMBOL(ksz_switch_register);
 void ksz_switch_remove(struct ksz_device *dev)
 {
        /* timer started */
-       if (dev->mib_read_interval)
+       if (dev->mib_read_interval) {
+               dev->mib_read_interval = 0;
                cancel_delayed_work_sync(&dev->mib_read);
+       }
 
        dev->dev_ops->exit(dev);
        dsa_unregister_switch(dev->ds);
index d0cba2d..094737e 100644 (file)
@@ -3286,6 +3286,9 @@ mt7530_remove(struct mdio_device *mdiodev)
        struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev);
        int ret = 0;
 
+       if (!priv)
+               return;
+
        ret = regulator_disable(priv->core_pwr);
        if (ret < 0)
                dev_err(priv->dev,
@@ -3301,11 +3304,26 @@ mt7530_remove(struct mdio_device *mdiodev)
 
        dsa_unregister_switch(priv->ds);
        mutex_destroy(&priv->reg_mutex);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void mt7530_shutdown(struct mdio_device *mdiodev)
+{
+       struct mt7530_priv *priv = dev_get_drvdata(&mdiodev->dev);
+
+       if (!priv)
+               return;
+
+       dsa_switch_shutdown(priv->ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static struct mdio_driver mt7530_mdio_driver = {
        .probe  = mt7530_probe,
        .remove = mt7530_remove,
+       .shutdown = mt7530_shutdown,
        .mdiodrv.driver = {
                .name = "mt7530",
                .of_match_table = mt7530_of_match,
index 24b8219..a4c6eb9 100644 (file)
@@ -290,7 +290,24 @@ static void mv88e6060_remove(struct mdio_device *mdiodev)
 {
        struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
 
+       if (!ds)
+               return;
+
        dsa_unregister_switch(ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void mv88e6060_shutdown(struct mdio_device *mdiodev)
+{
+       struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
+
+       if (!ds)
+               return;
+
+       dsa_switch_shutdown(ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id mv88e6060_of_match[] = {
@@ -303,6 +320,7 @@ static const struct of_device_id mv88e6060_of_match[] = {
 static struct mdio_driver mv88e6060_driver = {
        .probe  = mv88e6060_probe,
        .remove = mv88e6060_remove,
+       .shutdown = mv88e6060_shutdown,
        .mdiodrv.driver = {
                .name = "mv88e6060",
                .of_match_table = mv88e6060_of_match,
index c45ca24..8dadcae 100644 (file)
@@ -12,6 +12,7 @@
 
 #include <linux/bitfield.h>
 #include <linux/delay.h>
+#include <linux/dsa/mv88e6xxx.h>
 #include <linux/etherdevice.h>
 #include <linux/ethtool.h>
 #include <linux/if_bridge.h>
@@ -749,7 +750,11 @@ static void mv88e6xxx_mac_link_down(struct dsa_switch *ds, int port,
        ops = chip->info->ops;
 
        mv88e6xxx_reg_lock(chip);
-       if ((!mv88e6xxx_port_ppu_updates(chip, port) ||
+       /* Internal PHYs propagate their configuration directly to the MAC.
+        * External PHYs depend on whether the PPU is enabled for this port.
+        */
+       if (((!mv88e6xxx_phy_is_internal(ds, port) &&
+             !mv88e6xxx_port_ppu_updates(chip, port)) ||
             mode == MLO_AN_FIXED) && ops->port_sync_link)
                err = ops->port_sync_link(chip, port, mode, false);
        mv88e6xxx_reg_unlock(chip);
@@ -772,7 +777,12 @@ static void mv88e6xxx_mac_link_up(struct dsa_switch *ds, int port,
        ops = chip->info->ops;
 
        mv88e6xxx_reg_lock(chip);
-       if (!mv88e6xxx_port_ppu_updates(chip, port) || mode == MLO_AN_FIXED) {
+       /* Internal PHYs propagate their configuration directly to the MAC.
+        * External PHYs depend on whether the PPU is enabled for this port.
+        */
+       if ((!mv88e6xxx_phy_is_internal(ds, port) &&
+            !mv88e6xxx_port_ppu_updates(chip, port)) ||
+           mode == MLO_AN_FIXED) {
                /* FIXME: for an automedia port, should we force the link
                 * down here - what if the link comes up due to "other" media
                 * while we're bringing the port up, how is the exclusivity
@@ -1677,6 +1687,30 @@ static int mv88e6xxx_port_check_hw_vlan(struct dsa_switch *ds, int port,
        return 0;
 }
 
+static int mv88e6xxx_port_commit_pvid(struct mv88e6xxx_chip *chip, int port)
+{
+       struct dsa_port *dp = dsa_to_port(chip->ds, port);
+       struct mv88e6xxx_port *p = &chip->ports[port];
+       u16 pvid = MV88E6XXX_VID_STANDALONE;
+       bool drop_untagged = false;
+       int err;
+
+       if (dp->bridge_dev) {
+               if (br_vlan_enabled(dp->bridge_dev)) {
+                       pvid = p->bridge_pvid.vid;
+                       drop_untagged = !p->bridge_pvid.valid;
+               } else {
+                       pvid = MV88E6XXX_VID_BRIDGED;
+               }
+       }
+
+       err = mv88e6xxx_port_set_pvid(chip, port, pvid);
+       if (err)
+               return err;
+
+       return mv88e6xxx_port_drop_untagged(chip, port, drop_untagged);
+}
+
 static int mv88e6xxx_port_vlan_filtering(struct dsa_switch *ds, int port,
                                         bool vlan_filtering,
                                         struct netlink_ext_ack *extack)
@@ -1690,7 +1724,16 @@ static int mv88e6xxx_port_vlan_filtering(struct dsa_switch *ds, int port,
                return -EOPNOTSUPP;
 
        mv88e6xxx_reg_lock(chip);
+
        err = mv88e6xxx_port_set_8021q_mode(chip, port, mode);
+       if (err)
+               goto unlock;
+
+       err = mv88e6xxx_port_commit_pvid(chip, port);
+       if (err)
+               goto unlock;
+
+unlock:
        mv88e6xxx_reg_unlock(chip);
 
        return err;
@@ -1725,11 +1768,15 @@ static int mv88e6xxx_port_db_load_purge(struct mv88e6xxx_chip *chip, int port,
        u16 fid;
        int err;
 
-       /* Null VLAN ID corresponds to the port private database */
+       /* Ports have two private address databases: one for when the port is
+        * standalone and one for when the port is under a bridge and the
+        * 802.1Q mode is disabled. When the port is standalone, DSA wants its
+        * address database to remain 100% empty, so we never load an ATU entry
+        * into a standalone port's database. Therefore, translate the null
+        * VLAN ID into the port's database used for VLAN-unaware bridging.
+        */
        if (vid == 0) {
-               err = mv88e6xxx_port_get_fid(chip, port, &fid);
-               if (err)
-                       return err;
+               fid = MV88E6XXX_FID_BRIDGED;
        } else {
                err = mv88e6xxx_vtu_get(chip, vid, &vlan);
                if (err)
@@ -2123,6 +2170,7 @@ static int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
        struct mv88e6xxx_chip *chip = ds->priv;
        bool untagged = vlan->flags & BRIDGE_VLAN_INFO_UNTAGGED;
        bool pvid = vlan->flags & BRIDGE_VLAN_INFO_PVID;
+       struct mv88e6xxx_port *p = &chip->ports[port];
        bool warn;
        u8 member;
        int err;
@@ -2156,13 +2204,21 @@ static int mv88e6xxx_port_vlan_add(struct dsa_switch *ds, int port,
        }
 
        if (pvid) {
-               err = mv88e6xxx_port_set_pvid(chip, port, vlan->vid);
-               if (err) {
-                       dev_err(ds->dev, "p%d: failed to set PVID %d\n",
-                               port, vlan->vid);
+               p->bridge_pvid.vid = vlan->vid;
+               p->bridge_pvid.valid = true;
+
+               err = mv88e6xxx_port_commit_pvid(chip, port);
+               if (err)
+                       goto out;
+       } else if (vlan->vid && p->bridge_pvid.vid == vlan->vid) {
+               /* The old pvid was reinstalled as a non-pvid VLAN */
+               p->bridge_pvid.valid = false;
+
+               err = mv88e6xxx_port_commit_pvid(chip, port);
+               if (err)
                        goto out;
-               }
        }
+
 out:
        mv88e6xxx_reg_unlock(chip);
 
@@ -2212,6 +2268,7 @@ static int mv88e6xxx_port_vlan_del(struct dsa_switch *ds, int port,
                                   const struct switchdev_obj_port_vlan *vlan)
 {
        struct mv88e6xxx_chip *chip = ds->priv;
+       struct mv88e6xxx_port *p = &chip->ports[port];
        int err = 0;
        u16 pvid;
 
@@ -2229,7 +2286,9 @@ static int mv88e6xxx_port_vlan_del(struct dsa_switch *ds, int port,
                goto unlock;
 
        if (vlan->vid == pvid) {
-               err = mv88e6xxx_port_set_pvid(chip, port, 0);
+               p->bridge_pvid.valid = false;
+
+               err = mv88e6xxx_port_commit_pvid(chip, port);
                if (err)
                        goto unlock;
        }
@@ -2393,7 +2452,16 @@ static int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,
        int err;
 
        mv88e6xxx_reg_lock(chip);
+
        err = mv88e6xxx_bridge_map(chip, br);
+       if (err)
+               goto unlock;
+
+       err = mv88e6xxx_port_commit_pvid(chip, port);
+       if (err)
+               goto unlock;
+
+unlock:
        mv88e6xxx_reg_unlock(chip);
 
        return err;
@@ -2403,11 +2471,20 @@ static void mv88e6xxx_port_bridge_leave(struct dsa_switch *ds, int port,
                                        struct net_device *br)
 {
        struct mv88e6xxx_chip *chip = ds->priv;
+       int err;
 
        mv88e6xxx_reg_lock(chip);
+
        if (mv88e6xxx_bridge_map(chip, br) ||
            mv88e6xxx_port_vlan_map(chip, port))
                dev_err(ds->dev, "failed to remap in-chip Port VLAN\n");
+
+       err = mv88e6xxx_port_commit_pvid(chip, port);
+       if (err)
+               dev_err(ds->dev,
+                       "port %d failed to restore standalone pvid: %pe\n",
+                       port, ERR_PTR(err));
+
        mv88e6xxx_reg_unlock(chip);
 }
 
@@ -2834,8 +2911,8 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
        if (err)
                return err;
 
-       /* Port Control 2: don't force a good FCS, set the maximum frame size to
-        * 10240 bytes, disable 802.1q tags checking, don't discard tagged or
+       /* Port Control 2: don't force a good FCS, set the MTU size to
+        * 10222 bytes, disable 802.1q tags checking, don't discard tagged or
         * untagged frames on this port, do a destination address lookup on all
         * received packets as usual, disable ARP mirroring and don't send a
         * copy of all transmitted/received frames on this port to the CPU.
@@ -2853,8 +2930,22 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
        if (err)
                return err;
 
+       /* Associate MV88E6XXX_VID_BRIDGED with MV88E6XXX_FID_BRIDGED in the
+        * ATU by virtue of the fact that mv88e6xxx_atu_new() will pick it as
+        * the first free FID after MV88E6XXX_FID_STANDALONE. This will be used
+        * as the private PVID on ports under a VLAN-unaware bridge.
+        * Shared (DSA and CPU) ports must also be members of it, to translate
+        * the VID from the DSA tag into MV88E6XXX_FID_BRIDGED, instead of
+        * relying on their port default FID.
+        */
+       err = mv88e6xxx_port_vlan_join(chip, port, MV88E6XXX_VID_BRIDGED,
+                                      MV88E6XXX_G1_VTU_DATA_MEMBER_TAG_UNTAGGED,
+                                      false);
+       if (err)
+               return err;
+
        if (chip->info->ops->port_set_jumbo_size) {
-               err = chip->info->ops->port_set_jumbo_size(chip, port, 10240);
+               err = chip->info->ops->port_set_jumbo_size(chip, port, 10218);
                if (err)
                        return err;
        }
@@ -2925,7 +3016,7 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)
         * database, and allow bidirectional communication between the
         * CPU and DSA port(s), and the other ports.
         */
-       err = mv88e6xxx_port_set_fid(chip, port, 0);
+       err = mv88e6xxx_port_set_fid(chip, port, MV88E6XXX_FID_STANDALONE);
        if (err)
                return err;
 
@@ -2944,10 +3035,10 @@ static int mv88e6xxx_get_max_mtu(struct dsa_switch *ds, int port)
        struct mv88e6xxx_chip *chip = ds->priv;
 
        if (chip->info->ops->port_set_jumbo_size)
-               return 10240;
+               return 10240 - VLAN_ETH_HLEN - EDSA_HLEN - ETH_FCS_LEN;
        else if (chip->info->ops->set_max_frame_size)
-               return 1632;
-       return 1522;
+               return 1632 - VLAN_ETH_HLEN - EDSA_HLEN - ETH_FCS_LEN;
+       return 1522 - VLAN_ETH_HLEN - EDSA_HLEN - ETH_FCS_LEN;
 }
 
 static int mv88e6xxx_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
@@ -2955,6 +3046,9 @@ static int mv88e6xxx_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
        struct mv88e6xxx_chip *chip = ds->priv;
        int ret = 0;
 
+       if (dsa_is_dsa_port(ds, port) || dsa_is_cpu_port(ds, port))
+               new_mtu += EDSA_HLEN;
+
        mv88e6xxx_reg_lock(chip);
        if (chip->info->ops->port_set_jumbo_size)
                ret = chip->info->ops->port_set_jumbo_size(chip, port, new_mtu);
@@ -3071,7 +3165,7 @@ static void mv88e6xxx_teardown(struct dsa_switch *ds)
 {
        mv88e6xxx_teardown_devlink_params(ds);
        dsa_devlink_resources_unregister(ds);
-       mv88e6xxx_teardown_devlink_regions(ds);
+       mv88e6xxx_teardown_devlink_regions_global(ds);
 }
 
 static int mv88e6xxx_setup(struct dsa_switch *ds)
@@ -3112,6 +3206,10 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
                }
        }
 
+       err = mv88e6xxx_vtu_setup(chip);
+       if (err)
+               goto unlock;
+
        /* Setup Switch Port Registers */
        for (i = 0; i < mv88e6xxx_num_ports(chip); i++) {
                if (dsa_is_unused_port(ds, i))
@@ -3141,10 +3239,6 @@ static int mv88e6xxx_setup(struct dsa_switch *ds)
        if (err)
                goto unlock;
 
-       err = mv88e6xxx_vtu_setup(chip);
-       if (err)
-               goto unlock;
-
        err = mv88e6xxx_pvt_setup(chip);
        if (err)
                goto unlock;
@@ -3215,7 +3309,7 @@ unlock:
        if (err)
                goto out_resources;
 
-       err = mv88e6xxx_setup_devlink_regions(ds);
+       err = mv88e6xxx_setup_devlink_regions_global(ds);
        if (err)
                goto out_params;
 
@@ -3229,6 +3323,16 @@ out_resources:
        return err;
 }
 
+static int mv88e6xxx_port_setup(struct dsa_switch *ds, int port)
+{
+       return mv88e6xxx_setup_devlink_regions_port(ds, port);
+}
+
+static void mv88e6xxx_port_teardown(struct dsa_switch *ds, int port)
+{
+       mv88e6xxx_teardown_devlink_regions_port(ds, port);
+}
+
 /* prod_id for switch families which do not have a PHY model number */
 static const u16 family_prod_id_table[] = {
        [MV88E6XXX_FAMILY_6341] = MV88E6XXX_PORT_SWITCH_ID_PROD_6341,
@@ -3715,7 +3819,6 @@ static const struct mv88e6xxx_ops mv88e6161_ops = {
        .port_set_ucast_flood = mv88e6352_port_set_ucast_flood,
        .port_set_mcast_flood = mv88e6352_port_set_mcast_flood,
        .port_set_ether_type = mv88e6351_port_set_ether_type,
-       .port_set_jumbo_size = mv88e6165_port_set_jumbo_size,
        .port_egress_rate_limiting = mv88e6097_port_egress_rate_limiting,
        .port_pause_limit = mv88e6097_port_pause_limit,
        .port_disable_learn_limit = mv88e6xxx_port_disable_learn_limit,
@@ -3740,6 +3843,7 @@ static const struct mv88e6xxx_ops mv88e6161_ops = {
        .avb_ops = &mv88e6165_avb_ops,
        .ptp_ops = &mv88e6165_ptp_ops,
        .phylink_validate = mv88e6185_phylink_validate,
+       .set_max_frame_size = mv88e6185_g1_set_max_frame_size,
 };
 
 static const struct mv88e6xxx_ops mv88e6165_ops = {
@@ -6116,6 +6220,8 @@ static const struct dsa_switch_ops mv88e6xxx_switch_ops = {
        .change_tag_protocol    = mv88e6xxx_change_tag_protocol,
        .setup                  = mv88e6xxx_setup,
        .teardown               = mv88e6xxx_teardown,
+       .port_setup             = mv88e6xxx_port_setup,
+       .port_teardown          = mv88e6xxx_port_teardown,
        .phylink_validate       = mv88e6xxx_validate,
        .phylink_mac_link_state = mv88e6xxx_serdes_pcs_get_state,
        .phylink_mac_config     = mv88e6xxx_mac_config,
@@ -6389,7 +6495,12 @@ out:
 static void mv88e6xxx_remove(struct mdio_device *mdiodev)
 {
        struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
-       struct mv88e6xxx_chip *chip = ds->priv;
+       struct mv88e6xxx_chip *chip;
+
+       if (!ds)
+               return;
+
+       chip = ds->priv;
 
        if (chip->info->ptp_support) {
                mv88e6xxx_hwtstamp_free(chip);
@@ -6410,6 +6521,20 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
                mv88e6xxx_g1_irq_free(chip);
        else
                mv88e6xxx_irq_poll_free(chip);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void mv88e6xxx_shutdown(struct mdio_device *mdiodev)
+{
+       struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
+
+       if (!ds)
+               return;
+
+       dsa_switch_shutdown(ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id mv88e6xxx_of_match[] = {
@@ -6433,6 +6558,7 @@ MODULE_DEVICE_TABLE(of, mv88e6xxx_of_match);
 static struct mdio_driver mv88e6xxx_driver = {
        .probe  = mv88e6xxx_probe,
        .remove = mv88e6xxx_remove,
+       .shutdown = mv88e6xxx_shutdown,
        .mdiodrv.driver = {
                .name = "mv88e6085",
                .of_match_table = mv88e6xxx_of_match,
index 675b1f3..8271b8a 100644 (file)
 #include <linux/timecounter.h>
 #include <net/dsa.h>
 
+#define EDSA_HLEN              8
 #define MV88E6XXX_N_FID                4096
 
+#define MV88E6XXX_FID_STANDALONE       0
+#define MV88E6XXX_FID_BRIDGED          1
+
 /* PVT limits for 4-bit port and 5-bit switch */
 #define MV88E6XXX_MAX_PVT_SWITCHES     32
 #define MV88E6XXX_MAX_PVT_PORTS                16
@@ -245,9 +249,15 @@ struct mv88e6xxx_policy {
        u16 vid;
 };
 
+struct mv88e6xxx_vlan {
+       u16     vid;
+       bool    valid;
+};
+
 struct mv88e6xxx_port {
        struct mv88e6xxx_chip *chip;
        int port;
+       struct mv88e6xxx_vlan bridge_pvid;
        u64 serdes_stats[2];
        u64 atu_member_violation;
        u64 atu_miss_violation;
index 0c0f5ea..3810683 100644 (file)
@@ -647,26 +647,25 @@ static struct mv88e6xxx_region mv88e6xxx_regions[] = {
        },
 };
 
-static void
-mv88e6xxx_teardown_devlink_regions_global(struct mv88e6xxx_chip *chip)
+void mv88e6xxx_teardown_devlink_regions_global(struct dsa_switch *ds)
 {
+       struct mv88e6xxx_chip *chip = ds->priv;
        int i;
 
        for (i = 0; i < ARRAY_SIZE(mv88e6xxx_regions); i++)
                dsa_devlink_region_destroy(chip->regions[i]);
 }
 
-static void
-mv88e6xxx_teardown_devlink_regions_port(struct mv88e6xxx_chip *chip,
-                                       int port)
+void mv88e6xxx_teardown_devlink_regions_port(struct dsa_switch *ds, int port)
 {
+       struct mv88e6xxx_chip *chip = ds->priv;
+
        dsa_devlink_region_destroy(chip->ports[port].region);
 }
 
-static int mv88e6xxx_setup_devlink_regions_port(struct dsa_switch *ds,
-                                               struct mv88e6xxx_chip *chip,
-                                               int port)
+int mv88e6xxx_setup_devlink_regions_port(struct dsa_switch *ds, int port)
 {
+       struct mv88e6xxx_chip *chip = ds->priv;
        struct devlink_region *region;
 
        region = dsa_devlink_port_region_create(ds,
@@ -681,40 +680,10 @@ static int mv88e6xxx_setup_devlink_regions_port(struct dsa_switch *ds,
        return 0;
 }
 
-static void
-mv88e6xxx_teardown_devlink_regions_ports(struct mv88e6xxx_chip *chip)
-{
-       int port;
-
-       for (port = 0; port < mv88e6xxx_num_ports(chip); port++)
-               mv88e6xxx_teardown_devlink_regions_port(chip, port);
-}
-
-static int mv88e6xxx_setup_devlink_regions_ports(struct dsa_switch *ds,
-                                                struct mv88e6xxx_chip *chip)
-{
-       int port;
-       int err;
-
-       for (port = 0; port < mv88e6xxx_num_ports(chip); port++) {
-               err = mv88e6xxx_setup_devlink_regions_port(ds, chip, port);
-               if (err)
-                       goto out;
-       }
-
-       return 0;
-
-out:
-       while (port-- > 0)
-               mv88e6xxx_teardown_devlink_regions_port(chip, port);
-
-       return err;
-}
-
-static int mv88e6xxx_setup_devlink_regions_global(struct dsa_switch *ds,
-                                                 struct mv88e6xxx_chip *chip)
+int mv88e6xxx_setup_devlink_regions_global(struct dsa_switch *ds)
 {
        bool (*cond)(struct mv88e6xxx_chip *chip);
+       struct mv88e6xxx_chip *chip = ds->priv;
        struct devlink_region_ops *ops;
        struct devlink_region *region;
        u64 size;
@@ -753,30 +722,6 @@ out:
        return PTR_ERR(region);
 }
 
-int mv88e6xxx_setup_devlink_regions(struct dsa_switch *ds)
-{
-       struct mv88e6xxx_chip *chip = ds->priv;
-       int err;
-
-       err = mv88e6xxx_setup_devlink_regions_global(ds, chip);
-       if (err)
-               return err;
-
-       err = mv88e6xxx_setup_devlink_regions_ports(ds, chip);
-       if (err)
-               mv88e6xxx_teardown_devlink_regions_global(chip);
-
-       return err;
-}
-
-void mv88e6xxx_teardown_devlink_regions(struct dsa_switch *ds)
-{
-       struct mv88e6xxx_chip *chip = ds->priv;
-
-       mv88e6xxx_teardown_devlink_regions_ports(chip);
-       mv88e6xxx_teardown_devlink_regions_global(chip);
-}
-
 int mv88e6xxx_devlink_info_get(struct dsa_switch *ds,
                               struct devlink_info_req *req,
                               struct netlink_ext_ack *extack)
index 3d72db3..65ce6a6 100644 (file)
@@ -12,8 +12,10 @@ int mv88e6xxx_devlink_param_get(struct dsa_switch *ds, u32 id,
                                struct devlink_param_gset_ctx *ctx);
 int mv88e6xxx_devlink_param_set(struct dsa_switch *ds, u32 id,
                                struct devlink_param_gset_ctx *ctx);
-int mv88e6xxx_setup_devlink_regions(struct dsa_switch *ds);
-void mv88e6xxx_teardown_devlink_regions(struct dsa_switch *ds);
+int mv88e6xxx_setup_devlink_regions_global(struct dsa_switch *ds);
+void mv88e6xxx_teardown_devlink_regions_global(struct dsa_switch *ds);
+int mv88e6xxx_setup_devlink_regions_port(struct dsa_switch *ds, int port);
+void mv88e6xxx_teardown_devlink_regions_port(struct dsa_switch *ds, int port);
 
 int mv88e6xxx_devlink_info_get(struct dsa_switch *ds,
                               struct devlink_info_req *req,
index 815b0f6..5848112 100644 (file)
@@ -232,6 +232,8 @@ int mv88e6185_g1_set_max_frame_size(struct mv88e6xxx_chip *chip, int mtu)
        u16 val;
        int err;
 
+       mtu += ETH_HLEN + ETH_FCS_LEN;
+
        err = mv88e6xxx_g1_read(chip, MV88E6XXX_G1_CTL1, &val);
        if (err)
                return err;
index f77e2ee..d9817b2 100644 (file)
@@ -1257,6 +1257,27 @@ int mv88e6xxx_port_set_8021q_mode(struct mv88e6xxx_chip *chip, int port,
        return 0;
 }
 
+int mv88e6xxx_port_drop_untagged(struct mv88e6xxx_chip *chip, int port,
+                                bool drop_untagged)
+{
+       u16 old, new;
+       int err;
+
+       err = mv88e6xxx_port_read(chip, port, MV88E6XXX_PORT_CTL2, &old);
+       if (err)
+               return err;
+
+       if (drop_untagged)
+               new = old | MV88E6XXX_PORT_CTL2_DISCARD_UNTAGGED;
+       else
+               new = old & ~MV88E6XXX_PORT_CTL2_DISCARD_UNTAGGED;
+
+       if (new == old)
+               return 0;
+
+       return mv88e6xxx_port_write(chip, port, MV88E6XXX_PORT_CTL2, new);
+}
+
 int mv88e6xxx_port_set_map_da(struct mv88e6xxx_chip *chip, int port)
 {
        u16 reg;
@@ -1277,6 +1298,8 @@ int mv88e6165_port_set_jumbo_size(struct mv88e6xxx_chip *chip, int port,
        u16 reg;
        int err;
 
+       size += VLAN_ETH_HLEN + ETH_FCS_LEN;
+
        err = mv88e6xxx_port_read(chip, port, MV88E6XXX_PORT_CTL2, &reg);
        if (err)
                return err;
index b10e5ae..03382b6 100644 (file)
@@ -423,6 +423,8 @@ int mv88e6393x_port_set_cmode(struct mv88e6xxx_chip *chip, int port,
                              phy_interface_t mode);
 int mv88e6185_port_get_cmode(struct mv88e6xxx_chip *chip, int port, u8 *cmode);
 int mv88e6352_port_get_cmode(struct mv88e6xxx_chip *chip, int port, u8 *cmode);
+int mv88e6xxx_port_drop_untagged(struct mv88e6xxx_chip *chip, int port,
+                                bool drop_untagged);
 int mv88e6xxx_port_set_map_da(struct mv88e6xxx_chip *chip, int port);
 int mv88e6095_port_set_upstream_port(struct mv88e6xxx_chip *chip, int port,
                                     int upstream_port);
index 3656e67..341236d 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2019-2021 NXP Semiconductors
+/* Copyright 2019-2021 NXP
  *
  * This is an umbrella module for all network switches that are
  * register-compatible with Ocelot and that perform I/O to their host CPU
@@ -266,12 +266,12 @@ static void felix_8021q_cpu_port_deinit(struct ocelot *ocelot, int port)
  */
 static int felix_setup_mmio_filtering(struct felix *felix)
 {
-       unsigned long user_ports = 0, cpu_ports = 0;
+       unsigned long user_ports = dsa_user_ports(felix->ds);
        struct ocelot_vcap_filter *redirect_rule;
        struct ocelot_vcap_filter *tagging_rule;
        struct ocelot *ocelot = &felix->ocelot;
        struct dsa_switch *ds = felix->ds;
-       int port, ret;
+       int cpu = -1, port, ret;
 
        tagging_rule = kzalloc(sizeof(struct ocelot_vcap_filter), GFP_KERNEL);
        if (!tagging_rule)
@@ -284,12 +284,15 @@ static int felix_setup_mmio_filtering(struct felix *felix)
        }
 
        for (port = 0; port < ocelot->num_phys_ports; port++) {
-               if (dsa_is_user_port(ds, port))
-                       user_ports |= BIT(port);
-               if (dsa_is_cpu_port(ds, port))
-                       cpu_ports |= BIT(port);
+               if (dsa_is_cpu_port(ds, port)) {
+                       cpu = port;
+                       break;
+               }
        }
 
+       if (cpu < 0)
+               return -EINVAL;
+
        tagging_rule->key_type = OCELOT_VCAP_KEY_ETYPE;
        *(__be16 *)tagging_rule->key.etype.etype.value = htons(ETH_P_1588);
        *(__be16 *)tagging_rule->key.etype.etype.mask = htons(0xffff);
@@ -325,7 +328,7 @@ static int felix_setup_mmio_filtering(struct felix *felix)
                 * the CPU port module
                 */
                redirect_rule->action.mask_mode = OCELOT_MASK_MODE_REDIRECT;
-               redirect_rule->action.port_mask = cpu_ports;
+               redirect_rule->action.port_mask = BIT(cpu);
        } else {
                /* Trap PTP packets only to the CPU port module (which is
                 * redirected to the NPI port)
@@ -1074,6 +1077,101 @@ static int felix_init_structs(struct felix *felix, int num_phys_ports)
        return 0;
 }
 
+static void ocelot_port_purge_txtstamp_skb(struct ocelot *ocelot, int port,
+                                          struct sk_buff *skb)
+{
+       struct ocelot_port *ocelot_port = ocelot->ports[port];
+       struct sk_buff *clone = OCELOT_SKB_CB(skb)->clone;
+       struct sk_buff *skb_match = NULL, *skb_tmp;
+       unsigned long flags;
+
+       if (!clone)
+               return;
+
+       spin_lock_irqsave(&ocelot_port->tx_skbs.lock, flags);
+
+       skb_queue_walk_safe(&ocelot_port->tx_skbs, skb, skb_tmp) {
+               if (skb != clone)
+                       continue;
+               __skb_unlink(skb, &ocelot_port->tx_skbs);
+               skb_match = skb;
+               break;
+       }
+
+       spin_unlock_irqrestore(&ocelot_port->tx_skbs.lock, flags);
+
+       WARN_ONCE(!skb_match,
+                 "Could not find skb clone in TX timestamping list\n");
+}
+
+#define work_to_xmit_work(w) \
+               container_of((w), struct felix_deferred_xmit_work, work)
+
+static void felix_port_deferred_xmit(struct kthread_work *work)
+{
+       struct felix_deferred_xmit_work *xmit_work = work_to_xmit_work(work);
+       struct dsa_switch *ds = xmit_work->dp->ds;
+       struct sk_buff *skb = xmit_work->skb;
+       u32 rew_op = ocelot_ptp_rew_op(skb);
+       struct ocelot *ocelot = ds->priv;
+       int port = xmit_work->dp->index;
+       int retries = 10;
+
+       do {
+               if (ocelot_can_inject(ocelot, 0))
+                       break;
+
+               cpu_relax();
+       } while (--retries);
+
+       if (!retries) {
+               dev_err(ocelot->dev, "port %d failed to inject skb\n",
+                       port);
+               ocelot_port_purge_txtstamp_skb(ocelot, port, skb);
+               kfree_skb(skb);
+               return;
+       }
+
+       ocelot_port_inject_frame(ocelot, port, 0, rew_op, skb);
+
+       consume_skb(skb);
+       kfree(xmit_work);
+}
+
+static int felix_port_setup_tagger_data(struct dsa_switch *ds, int port)
+{
+       struct dsa_port *dp = dsa_to_port(ds, port);
+       struct ocelot *ocelot = ds->priv;
+       struct felix *felix = ocelot_to_felix(ocelot);
+       struct felix_port *felix_port;
+
+       if (!dsa_port_is_user(dp))
+               return 0;
+
+       felix_port = kzalloc(sizeof(*felix_port), GFP_KERNEL);
+       if (!felix_port)
+               return -ENOMEM;
+
+       felix_port->xmit_worker = felix->xmit_worker;
+       felix_port->xmit_work_fn = felix_port_deferred_xmit;
+
+       dp->priv = felix_port;
+
+       return 0;
+}
+
+static void felix_port_teardown_tagger_data(struct dsa_switch *ds, int port)
+{
+       struct dsa_port *dp = dsa_to_port(ds, port);
+       struct felix_port *felix_port = dp->priv;
+
+       if (!felix_port)
+               return;
+
+       dp->priv = NULL;
+       kfree(felix_port);
+}
+
 /* Hardware initialization done here so that we can allocate structures with
  * devm without fear of dsa_register_switch returning -EPROBE_DEFER and causing
  * us to allocate structures twice (leak memory) and map PCI memory twice
@@ -1102,6 +1200,12 @@ static int felix_setup(struct dsa_switch *ds)
                }
        }
 
+       felix->xmit_worker = kthread_create_worker(0, "felix_xmit");
+       if (IS_ERR(felix->xmit_worker)) {
+               err = PTR_ERR(felix->xmit_worker);
+               goto out_deinit_timestamp;
+       }
+
        for (port = 0; port < ds->num_ports; port++) {
                if (dsa_is_unused_port(ds, port))
                        continue;
@@ -1112,6 +1216,14 @@ static int felix_setup(struct dsa_switch *ds)
                 * bits of vlan tag.
                 */
                felix_port_qos_map_init(ocelot, port);
+
+               err = felix_port_setup_tagger_data(ds, port);
+               if (err) {
+                       dev_err(ds->dev,
+                               "port %d failed to set up tagger data: %pe\n",
+                               port, ERR_PTR(err));
+                       goto out_deinit_ports;
+               }
        }
 
        err = ocelot_devlink_sb_register(ocelot);
@@ -1126,6 +1238,7 @@ static int felix_setup(struct dsa_switch *ds)
                 * there's no real point in checking for errors.
                 */
                felix_set_tag_protocol(ds, port, felix->tag_proto);
+               break;
        }
 
        ds->mtu_enforcement_ingress = true;
@@ -1138,9 +1251,13 @@ out_deinit_ports:
                if (dsa_is_unused_port(ds, port))
                        continue;
 
+               felix_port_teardown_tagger_data(ds, port);
                ocelot_deinit_port(ocelot, port);
        }
 
+       kthread_destroy_worker(felix->xmit_worker);
+
+out_deinit_timestamp:
        ocelot_deinit_timestamp(ocelot);
        ocelot_deinit(ocelot);
 
@@ -1162,19 +1279,23 @@ static void felix_teardown(struct dsa_switch *ds)
                        continue;
 
                felix_del_tag_protocol(ds, port, felix->tag_proto);
+               break;
        }
 
-       ocelot_devlink_sb_unregister(ocelot);
-       ocelot_deinit_timestamp(ocelot);
-       ocelot_deinit(ocelot);
-
        for (port = 0; port < ocelot->num_phys_ports; port++) {
                if (dsa_is_unused_port(ds, port))
                        continue;
 
+               felix_port_teardown_tagger_data(ds, port);
                ocelot_deinit_port(ocelot, port);
        }
 
+       kthread_destroy_worker(felix->xmit_worker);
+
+       ocelot_devlink_sb_unregister(ocelot);
+       ocelot_deinit_timestamp(ocelot);
+       ocelot_deinit(ocelot);
+
        if (felix->info->mdio_bus_free)
                felix->info->mdio_bus_free(ocelot);
 }
@@ -1291,8 +1412,12 @@ static void felix_txtstamp(struct dsa_switch *ds, int port,
        if (!ocelot->ptp)
                return;
 
-       if (ocelot_port_txtstamp_request(ocelot, port, skb, &clone))
+       if (ocelot_port_txtstamp_request(ocelot, port, skb, &clone)) {
+               dev_err_ratelimited(ds->dev,
+                                   "port %d delivering skb without TX timestamp\n",
+                                   port);
                return;
+       }
 
        if (clone)
                OCELOT_SKB_CB(skb)->clone = clone;
index 5854bab..be3e42e 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright 2019 NXP Semiconductors
+/* Copyright 2019 NXP
  */
 #ifndef _MSCC_FELIX_H
 #define _MSCC_FELIX_H
@@ -62,6 +62,7 @@ struct felix {
        resource_size_t                 switch_base;
        resource_size_t                 imdio_base;
        enum dsa_tag_protocol           tag_proto;
+       struct kthread_worker           *xmit_worker;
 };
 
 struct net_device *felix_port_to_netdev(struct ocelot *ocelot, int port);
index f966a25..11b42fd 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: (GPL-2.0 OR MIT)
 /* Copyright 2017 Microsemi Corporation
- * Copyright 2018-2019 NXP Semiconductors
+ * Copyright 2018-2019 NXP
  */
 #include <linux/fsl/enetc_mdio.h>
 #include <soc/mscc/ocelot_qsys.h>
@@ -1472,9 +1472,10 @@ err_pci_enable:
 
 static void felix_pci_remove(struct pci_dev *pdev)
 {
-       struct felix *felix;
+       struct felix *felix = pci_get_drvdata(pdev);
 
-       felix = pci_get_drvdata(pdev);
+       if (!felix)
+               return;
 
        dsa_unregister_switch(felix->ds);
 
@@ -1482,6 +1483,20 @@ static void felix_pci_remove(struct pci_dev *pdev)
        kfree(felix);
 
        pci_disable_device(pdev);
+
+       pci_set_drvdata(pdev, NULL);
+}
+
+static void felix_pci_shutdown(struct pci_dev *pdev)
+{
+       struct felix *felix = pci_get_drvdata(pdev);
+
+       if (!felix)
+               return;
+
+       dsa_switch_shutdown(felix->ds);
+
+       pci_set_drvdata(pdev, NULL);
 }
 
 static struct pci_device_id felix_ids[] = {
@@ -1498,6 +1513,7 @@ static struct pci_driver felix_vsc9959_pci_driver = {
        .id_table       = felix_ids,
        .probe          = felix_pci_probe,
        .remove         = felix_pci_remove,
+       .shutdown       = felix_pci_shutdown,
 };
 module_pci_driver(felix_vsc9959_pci_driver);
 
index deae923..de1d34a 100644 (file)
@@ -1245,18 +1245,33 @@ err_alloc_felix:
 
 static int seville_remove(struct platform_device *pdev)
 {
-       struct felix *felix;
+       struct felix *felix = platform_get_drvdata(pdev);
 
-       felix = platform_get_drvdata(pdev);
+       if (!felix)
+               return 0;
 
        dsa_unregister_switch(felix->ds);
 
        kfree(felix->ds);
        kfree(felix);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
+static void seville_shutdown(struct platform_device *pdev)
+{
+       struct felix *felix = platform_get_drvdata(pdev);
+
+       if (!felix)
+               return;
+
+       dsa_switch_shutdown(felix->ds);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static const struct of_device_id seville_of_match[] = {
        { .compatible = "mscc,vsc9953-switch" },
        { },
@@ -1266,6 +1281,7 @@ MODULE_DEVICE_TABLE(of, seville_of_match);
 static struct platform_driver seville_vsc9953_driver = {
        .probe          = seville_probe,
        .remove         = seville_remove,
+       .shutdown       = seville_shutdown,
        .driver = {
                .name           = "mscc_seville",
                .of_match_table = of_match_ptr(seville_of_match),
index 563d8a2..a6bfb6a 100644 (file)
@@ -1083,6 +1083,9 @@ static void ar9331_sw_remove(struct mdio_device *mdiodev)
        struct ar9331_sw_priv *priv = dev_get_drvdata(&mdiodev->dev);
        unsigned int i;
 
+       if (!priv)
+               return;
+
        for (i = 0; i < ARRAY_SIZE(priv->port); i++) {
                struct ar9331_sw_port *port = &priv->port[i];
 
@@ -1094,6 +1097,20 @@ static void ar9331_sw_remove(struct mdio_device *mdiodev)
        dsa_unregister_switch(&priv->ds);
 
        reset_control_assert(priv->sw_reset);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void ar9331_sw_shutdown(struct mdio_device *mdiodev)
+{
+       struct ar9331_sw_priv *priv = dev_get_drvdata(&mdiodev->dev);
+
+       if (!priv)
+               return;
+
+       dsa_switch_shutdown(&priv->ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id ar9331_sw_of_match[] = {
@@ -1104,6 +1121,7 @@ static const struct of_device_id ar9331_sw_of_match[] = {
 static struct mdio_driver ar9331_sw_mdio_driver = {
        .probe = ar9331_sw_probe,
        .remove = ar9331_sw_remove,
+       .shutdown = ar9331_sw_shutdown,
        .mdiodrv.driver = {
                .name = AR9331_SW_NAME,
                .of_match_table = ar9331_sw_of_match,
index 1f63f50..a984f06 100644 (file)
@@ -643,10 +643,8 @@ qca8k_mdio_busy_wait(struct mii_bus *bus, u32 reg, u32 mask)
 }
 
 static int
-qca8k_mdio_write(struct mii_bus *salve_bus, int phy, int regnum, u16 data)
+qca8k_mdio_write(struct mii_bus *bus, int phy, int regnum, u16 data)
 {
-       struct qca8k_priv *priv = salve_bus->priv;
-       struct mii_bus *bus = priv->bus;
        u16 r1, r2, page;
        u32 val;
        int ret;
@@ -682,10 +680,8 @@ exit:
 }
 
 static int
-qca8k_mdio_read(struct mii_bus *salve_bus, int phy, int regnum)
+qca8k_mdio_read(struct mii_bus *bus, int phy, int regnum)
 {
-       struct qca8k_priv *priv = salve_bus->priv;
-       struct mii_bus *bus = priv->bus;
        u16 r1, r2, page;
        u32 val;
        int ret;
@@ -726,6 +722,24 @@ exit:
        return ret;
 }
 
+static int
+qca8k_internal_mdio_write(struct mii_bus *slave_bus, int phy, int regnum, u16 data)
+{
+       struct qca8k_priv *priv = slave_bus->priv;
+       struct mii_bus *bus = priv->bus;
+
+       return qca8k_mdio_write(bus, phy, regnum, data);
+}
+
+static int
+qca8k_internal_mdio_read(struct mii_bus *slave_bus, int phy, int regnum)
+{
+       struct qca8k_priv *priv = slave_bus->priv;
+       struct mii_bus *bus = priv->bus;
+
+       return qca8k_mdio_read(bus, phy, regnum);
+}
+
 static int
 qca8k_phy_write(struct dsa_switch *ds, int port, int regnum, u16 data)
 {
@@ -775,8 +789,8 @@ qca8k_mdio_register(struct qca8k_priv *priv, struct device_node *mdio)
 
        bus->priv = (void *)priv;
        bus->name = "qca8k slave mii";
-       bus->read = qca8k_mdio_read;
-       bus->write = qca8k_mdio_write;
+       bus->read = qca8k_internal_mdio_read;
+       bus->write = qca8k_internal_mdio_write;
        snprintf(bus->id, MII_BUS_ID_SIZE, "qca8k-%d",
                 ds->index);
 
@@ -1866,10 +1880,27 @@ qca8k_sw_remove(struct mdio_device *mdiodev)
        struct qca8k_priv *priv = dev_get_drvdata(&mdiodev->dev);
        int i;
 
+       if (!priv)
+               return;
+
        for (i = 0; i < QCA8K_NUM_PORTS; i++)
                qca8k_port_set_status(priv, i, 0);
 
        dsa_unregister_switch(priv->ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void qca8k_sw_shutdown(struct mdio_device *mdiodev)
+{
+       struct qca8k_priv *priv = dev_get_drvdata(&mdiodev->dev);
+
+       if (!priv)
+               return;
+
+       dsa_switch_shutdown(priv->ds);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 #ifdef CONFIG_PM_SLEEP
@@ -1926,6 +1957,7 @@ static const struct of_device_id qca8k_of_match[] = {
 static struct mdio_driver qca8kmdio_driver = {
        .probe  = qca8k_sw_probe,
        .remove = qca8k_sw_remove,
+       .shutdown = qca8k_sw_shutdown,
        .mdiodrv.driver = {
                .name = "qca8k",
                .of_match_table = qca8k_of_match,
index 8e49d4f..2fcfd91 100644 (file)
@@ -368,7 +368,7 @@ int realtek_smi_setup_mdio(struct realtek_smi *smi)
        smi->slave_mii_bus->parent = smi->dev;
        smi->ds->slave_mii_bus = smi->slave_mii_bus;
 
-       ret = of_mdiobus_register(smi->slave_mii_bus, mdio_np);
+       ret = devm_of_mdiobus_register(smi->dev, smi->slave_mii_bus, mdio_np);
        if (ret) {
                dev_err(smi->dev, "unable to register MDIO bus %s\n",
                        smi->slave_mii_bus->id);
@@ -464,16 +464,33 @@ static int realtek_smi_probe(struct platform_device *pdev)
 
 static int realtek_smi_remove(struct platform_device *pdev)
 {
-       struct realtek_smi *smi = dev_get_drvdata(&pdev->dev);
+       struct realtek_smi *smi = platform_get_drvdata(pdev);
+
+       if (!smi)
+               return 0;
 
        dsa_unregister_switch(smi->ds);
        if (smi->slave_mii_bus)
                of_node_put(smi->slave_mii_bus->dev.of_node);
        gpiod_set_value(smi->reset, 1);
 
+       platform_set_drvdata(pdev, NULL);
+
        return 0;
 }
 
+static void realtek_smi_shutdown(struct platform_device *pdev)
+{
+       struct realtek_smi *smi = platform_get_drvdata(pdev);
+
+       if (!smi)
+               return;
+
+       dsa_switch_shutdown(smi->ds);
+
+       platform_set_drvdata(pdev, NULL);
+}
+
 static const struct of_device_id realtek_smi_of_match[] = {
        {
                .compatible = "realtek,rtl8366rb",
@@ -495,6 +512,7 @@ static struct platform_driver realtek_smi_driver = {
        },
        .probe  = realtek_smi_probe,
        .remove = realtek_smi_remove,
+       .shutdown = realtek_smi_shutdown,
 };
 module_platform_driver(realtek_smi_driver);
 
index 387a1f2..5bbf170 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BSD-3-Clause
-/* Copyright (c) 2016-2018, NXP Semiconductors
+/* Copyright 2016-2018 NXP
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
 #include <linux/packing.h>
index 05c7f4c..0569ff0 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 /* Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
- * Copyright 2020 NXP Semiconductors
+ * Copyright 2020 NXP
  */
 #include "sja1105.h"
 
index 6c10ffa..72b9b39 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2020, NXP Semiconductors
+/* Copyright 2020 NXP
  */
 #include "sja1105.h"
 #include "sja1105_vl.h"
index 2f8cc66..924c3f1 100644 (file)
@@ -3117,7 +3117,7 @@ static void sja1105_teardown(struct dsa_switch *ds)
        sja1105_static_config_free(&priv->static_config);
 }
 
-const struct dsa_switch_ops sja1105_switch_ops = {
+static const struct dsa_switch_ops sja1105_switch_ops = {
        .get_tag_protocol       = sja1105_get_tag_protocol,
        .setup                  = sja1105_setup,
        .teardown               = sja1105_teardown,
@@ -3166,7 +3166,6 @@ const struct dsa_switch_ops sja1105_switch_ops = {
        .port_bridge_tx_fwd_offload = dsa_tag_8021q_bridge_tx_fwd_offload,
        .port_bridge_tx_fwd_unoffload = dsa_tag_8021q_bridge_tx_fwd_unoffload,
 };
-EXPORT_SYMBOL_GPL(sja1105_switch_ops);
 
 static const struct of_device_id sja1105_dt_ids[];
 
@@ -3335,13 +3334,29 @@ static int sja1105_probe(struct spi_device *spi)
 static int sja1105_remove(struct spi_device *spi)
 {
        struct sja1105_private *priv = spi_get_drvdata(spi);
-       struct dsa_switch *ds = priv->ds;
 
-       dsa_unregister_switch(ds);
+       if (!priv)
+               return 0;
+
+       dsa_unregister_switch(priv->ds);
+
+       spi_set_drvdata(spi, NULL);
 
        return 0;
 }
 
+static void sja1105_shutdown(struct spi_device *spi)
+{
+       struct sja1105_private *priv = spi_get_drvdata(spi);
+
+       if (!priv)
+               return;
+
+       dsa_switch_shutdown(priv->ds);
+
+       spi_set_drvdata(spi, NULL);
+}
+
 static const struct of_device_id sja1105_dt_ids[] = {
        { .compatible = "nxp,sja1105e", .data = &sja1105e_info },
        { .compatible = "nxp,sja1105t", .data = &sja1105t_info },
@@ -3365,6 +3380,7 @@ static struct spi_driver sja1105_driver = {
        },
        .probe  = sja1105_probe,
        .remove = sja1105_remove,
+       .shutdown = sja1105_shutdown,
 };
 
 module_spi_driver(sja1105_driver);
index 705d390..215dd17 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2021, NXP Semiconductors
+/* Copyright 2021 NXP
  */
 #include <linux/pcs/pcs-xpcs.h>
 #include <linux/of_mdio.h>
index 691f6dd..5439699 100644 (file)
@@ -64,6 +64,7 @@ enum sja1105_ptp_clk_mode {
 static int sja1105_change_rxtstamping(struct sja1105_private *priv,
                                      bool on)
 {
+       struct sja1105_tagger_data *tagger_data = &priv->tagger_data;
        struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
        struct sja1105_general_params_entry *general_params;
        struct sja1105_table *table;
@@ -79,7 +80,7 @@ static int sja1105_change_rxtstamping(struct sja1105_private *priv,
                priv->tagger_data.stampable_skb = NULL;
        }
        ptp_cancel_worker_sync(ptp_data->clock);
-       skb_queue_purge(&ptp_data->skb_txtstamp_queue);
+       skb_queue_purge(&tagger_data->skb_txtstamp_queue);
        skb_queue_purge(&ptp_data->skb_rxtstamp_queue);
 
        return sja1105_static_config_reload(priv, SJA1105_RX_HWTSTAMPING);
@@ -452,40 +453,6 @@ bool sja1105_port_rxtstamp(struct dsa_switch *ds, int port,
        return priv->info->rxtstamp(ds, port, skb);
 }
 
-void sja1110_process_meta_tstamp(struct dsa_switch *ds, int port, u8 ts_id,
-                                enum sja1110_meta_tstamp dir, u64 tstamp)
-{
-       struct sja1105_private *priv = ds->priv;
-       struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
-       struct sk_buff *skb, *skb_tmp, *skb_match = NULL;
-       struct skb_shared_hwtstamps shwt = {0};
-
-       /* We don't care about RX timestamps on the CPU port */
-       if (dir == SJA1110_META_TSTAMP_RX)
-               return;
-
-       spin_lock(&ptp_data->skb_txtstamp_queue.lock);
-
-       skb_queue_walk_safe(&ptp_data->skb_txtstamp_queue, skb, skb_tmp) {
-               if (SJA1105_SKB_CB(skb)->ts_id != ts_id)
-                       continue;
-
-               __skb_unlink(skb, &ptp_data->skb_txtstamp_queue);
-               skb_match = skb;
-
-               break;
-       }
-
-       spin_unlock(&ptp_data->skb_txtstamp_queue.lock);
-
-       if (WARN_ON(!skb_match))
-               return;
-
-       shwt.hwtstamp = ns_to_ktime(sja1105_ticks_to_ns(tstamp));
-       skb_complete_tx_timestamp(skb_match, &shwt);
-}
-EXPORT_SYMBOL_GPL(sja1110_process_meta_tstamp);
-
 /* In addition to cloning the skb which is done by the common
  * sja1105_port_txtstamp, we need to generate a timestamp ID and save the
  * packet to the TX timestamping queue.
@@ -494,7 +461,6 @@ void sja1110_txtstamp(struct dsa_switch *ds, int port, struct sk_buff *skb)
 {
        struct sk_buff *clone = SJA1105_SKB_CB(skb)->clone;
        struct sja1105_private *priv = ds->priv;
-       struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
        struct sja1105_port *sp = &priv->ports[port];
        u8 ts_id;
 
@@ -510,7 +476,7 @@ void sja1110_txtstamp(struct dsa_switch *ds, int port, struct sk_buff *skb)
 
        spin_unlock(&sp->data->meta_lock);
 
-       skb_queue_tail(&ptp_data->skb_txtstamp_queue, clone);
+       skb_queue_tail(&sp->data->skb_txtstamp_queue, clone);
 }
 
 /* Called from dsa_skb_tx_timestamp. This callback is just to clone
@@ -953,7 +919,7 @@ int sja1105_ptp_clock_register(struct dsa_switch *ds)
        /* Only used on SJA1105 */
        skb_queue_head_init(&ptp_data->skb_rxtstamp_queue);
        /* Only used on SJA1110 */
-       skb_queue_head_init(&ptp_data->skb_txtstamp_queue);
+       skb_queue_head_init(&tagger_data->skb_txtstamp_queue);
        spin_lock_init(&tagger_data->meta_lock);
 
        ptp_data->clock = ptp_clock_register(&ptp_data->caps, ds->dev);
@@ -971,6 +937,7 @@ int sja1105_ptp_clock_register(struct dsa_switch *ds)
 void sja1105_ptp_clock_unregister(struct dsa_switch *ds)
 {
        struct sja1105_private *priv = ds->priv;
+       struct sja1105_tagger_data *tagger_data = &priv->tagger_data;
        struct sja1105_ptp_data *ptp_data = &priv->ptp_data;
 
        if (IS_ERR_OR_NULL(ptp_data->clock))
@@ -978,7 +945,7 @@ void sja1105_ptp_clock_unregister(struct dsa_switch *ds)
 
        del_timer_sync(&ptp_data->extts_timer);
        ptp_cancel_worker_sync(ptp_data->clock);
-       skb_queue_purge(&ptp_data->skb_txtstamp_queue);
+       skb_queue_purge(&tagger_data->skb_txtstamp_queue);
        skb_queue_purge(&ptp_data->skb_rxtstamp_queue);
        ptp_clock_unregister(ptp_data->clock);
        ptp_data->clock = NULL;
index 3c874bb..3ae6b9f 100644 (file)
@@ -8,21 +8,6 @@
 
 #if IS_ENABLED(CONFIG_NET_DSA_SJA1105_PTP)
 
-/* Timestamps are in units of 8 ns clock ticks (equivalent to
- * a fixed 125 MHz clock).
- */
-#define SJA1105_TICK_NS                        8
-
-static inline s64 ns_to_sja1105_ticks(s64 ns)
-{
-       return ns / SJA1105_TICK_NS;
-}
-
-static inline s64 sja1105_ticks_to_ns(s64 ticks)
-{
-       return ticks * SJA1105_TICK_NS;
-}
-
 /* Calculate the first base_time in the future that satisfies this
  * relationship:
  *
@@ -77,10 +62,6 @@ struct sja1105_ptp_data {
        struct timer_list extts_timer;
        /* Used only on SJA1105 to reconstruct partial timestamps */
        struct sk_buff_head skb_rxtstamp_queue;
-       /* Used on SJA1110 where meta frames are generated only for
-        * 2-step TX timestamps
-        */
-       struct sk_buff_head skb_txtstamp_queue;
        struct ptp_clock_info caps;
        struct ptp_clock *clock;
        struct sja1105_ptp_cmd cmd;
index d60a530..d3c9ad6 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BSD-3-Clause
-/* Copyright (c) 2016-2018, NXP Semiconductors
+/* Copyright 2016-2018 NXP
  * Copyright (c) 2018, Sensor-Technik Wiedemann GmbH
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
index 7a422ef..baba204 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BSD-3-Clause
-/* Copyright (c) 2016-2018, NXP Semiconductors
+/* Copyright 2016-2018 NXP
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
 #include "sja1105_static_config.h"
index bce0f5c..6a372d5 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause */
-/* Copyright (c) 2016-2018, NXP Semiconductors
+/* Copyright 2016-2018 NXP
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
 #ifndef _SJA1105_STATIC_CONFIG_H
index ec7b65d..6802f40 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2020, NXP Semiconductors
+/* Copyright 2020 NXP
  */
 #include <net/tc_act/tc_gate.h>
 #include <linux/dsa/8021q.h>
index 173d789..51fba0d 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-/* Copyright 2020, NXP Semiconductors
+/* Copyright 2020 NXP
  */
 #ifndef _SJA1105_VL_H
 #define _SJA1105_VL_H
index 19ce4aa..a4b1447 100644 (file)
@@ -1225,6 +1225,12 @@ int vsc73xx_remove(struct vsc73xx *vsc)
 }
 EXPORT_SYMBOL(vsc73xx_remove);
 
+void vsc73xx_shutdown(struct vsc73xx *vsc)
+{
+       dsa_switch_shutdown(vsc->ds);
+}
+EXPORT_SYMBOL(vsc73xx_shutdown);
+
 MODULE_AUTHOR("Linus Walleij <linus.walleij@linaro.org>");
 MODULE_DESCRIPTION("Vitesse VSC7385/7388/7395/7398 driver");
 MODULE_LICENSE("GPL v2");
index 2a57f33..fe4b154 100644 (file)
@@ -116,7 +116,26 @@ static int vsc73xx_platform_remove(struct platform_device *pdev)
 {
        struct vsc73xx_platform *vsc_platform = platform_get_drvdata(pdev);
 
-       return vsc73xx_remove(&vsc_platform->vsc);
+       if (!vsc_platform)
+               return 0;
+
+       vsc73xx_remove(&vsc_platform->vsc);
+
+       platform_set_drvdata(pdev, NULL);
+
+       return 0;
+}
+
+static void vsc73xx_platform_shutdown(struct platform_device *pdev)
+{
+       struct vsc73xx_platform *vsc_platform = platform_get_drvdata(pdev);
+
+       if (!vsc_platform)
+               return;
+
+       vsc73xx_shutdown(&vsc_platform->vsc);
+
+       platform_set_drvdata(pdev, NULL);
 }
 
 static const struct vsc73xx_ops vsc73xx_platform_ops = {
@@ -144,6 +163,7 @@ MODULE_DEVICE_TABLE(of, vsc73xx_of_match);
 static struct platform_driver vsc73xx_platform_driver = {
        .probe = vsc73xx_platform_probe,
        .remove = vsc73xx_platform_remove,
+       .shutdown = vsc73xx_platform_shutdown,
        .driver = {
                .name = "vsc73xx-platform",
                .of_match_table = vsc73xx_of_match,
index 81eca4a..6453989 100644 (file)
@@ -163,7 +163,26 @@ static int vsc73xx_spi_remove(struct spi_device *spi)
 {
        struct vsc73xx_spi *vsc_spi = spi_get_drvdata(spi);
 
-       return vsc73xx_remove(&vsc_spi->vsc);
+       if (!vsc_spi)
+               return 0;
+
+       vsc73xx_remove(&vsc_spi->vsc);
+
+       spi_set_drvdata(spi, NULL);
+
+       return 0;
+}
+
+static void vsc73xx_spi_shutdown(struct spi_device *spi)
+{
+       struct vsc73xx_spi *vsc_spi = spi_get_drvdata(spi);
+
+       if (!vsc_spi)
+               return;
+
+       vsc73xx_shutdown(&vsc_spi->vsc);
+
+       spi_set_drvdata(spi, NULL);
 }
 
 static const struct vsc73xx_ops vsc73xx_spi_ops = {
@@ -191,6 +210,7 @@ MODULE_DEVICE_TABLE(of, vsc73xx_of_match);
 static struct spi_driver vsc73xx_spi_driver = {
        .probe = vsc73xx_spi_probe,
        .remove = vsc73xx_spi_remove,
+       .shutdown = vsc73xx_spi_shutdown,
        .driver = {
                .name = "vsc73xx-spi",
                .of_match_table = vsc73xx_of_match,
index 7478f8d..30b9515 100644 (file)
@@ -27,3 +27,4 @@ struct vsc73xx_ops {
 int vsc73xx_is_addr_valid(u8 block, u8 subblock);
 int vsc73xx_probe(struct vsc73xx *vsc);
 int vsc73xx_remove(struct vsc73xx *vsc);
+void vsc73xx_shutdown(struct vsc73xx *vsc);
index 130abb0..4694209 100644 (file)
@@ -822,6 +822,12 @@ void xrs700x_switch_remove(struct xrs700x *priv)
 }
 EXPORT_SYMBOL(xrs700x_switch_remove);
 
+void xrs700x_switch_shutdown(struct xrs700x *priv)
+{
+       dsa_switch_shutdown(priv->ds);
+}
+EXPORT_SYMBOL(xrs700x_switch_shutdown);
+
 MODULE_AUTHOR("George McCollister <george.mccollister@gmail.com>");
 MODULE_DESCRIPTION("Arrow SpeedChips XRS700x DSA driver");
 MODULE_LICENSE("GPL v2");
index ff62cf6..4d58257 100644 (file)
@@ -40,3 +40,4 @@ struct xrs700x {
 struct xrs700x *xrs700x_switch_alloc(struct device *base, void *devpriv);
 int xrs700x_switch_register(struct xrs700x *priv);
 void xrs700x_switch_remove(struct xrs700x *priv);
+void xrs700x_switch_shutdown(struct xrs700x *priv);
index 489d938..6deae38 100644 (file)
@@ -109,11 +109,28 @@ static int xrs700x_i2c_remove(struct i2c_client *i2c)
 {
        struct xrs700x *priv = i2c_get_clientdata(i2c);
 
+       if (!priv)
+               return 0;
+
        xrs700x_switch_remove(priv);
 
+       i2c_set_clientdata(i2c, NULL);
+
        return 0;
 }
 
+static void xrs700x_i2c_shutdown(struct i2c_client *i2c)
+{
+       struct xrs700x *priv = i2c_get_clientdata(i2c);
+
+       if (!priv)
+               return;
+
+       xrs700x_switch_shutdown(priv);
+
+       i2c_set_clientdata(i2c, NULL);
+}
+
 static const struct i2c_device_id xrs700x_i2c_id[] = {
        { "xrs700x-switch", 0 },
        {},
@@ -137,6 +154,7 @@ static struct i2c_driver xrs700x_i2c_driver = {
        },
        .probe  = xrs700x_i2c_probe,
        .remove = xrs700x_i2c_remove,
+       .shutdown = xrs700x_i2c_shutdown,
        .id_table = xrs700x_i2c_id,
 };
 
index 44f58be..d01cf10 100644 (file)
@@ -136,7 +136,24 @@ static void xrs700x_mdio_remove(struct mdio_device *mdiodev)
 {
        struct xrs700x *priv = dev_get_drvdata(&mdiodev->dev);
 
+       if (!priv)
+               return;
+
        xrs700x_switch_remove(priv);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
+}
+
+static void xrs700x_mdio_shutdown(struct mdio_device *mdiodev)
+{
+       struct xrs700x *priv = dev_get_drvdata(&mdiodev->dev);
+
+       if (!priv)
+               return;
+
+       xrs700x_switch_shutdown(priv);
+
+       dev_set_drvdata(&mdiodev->dev, NULL);
 }
 
 static const struct of_device_id __maybe_unused xrs700x_mdio_dt_ids[] = {
@@ -155,6 +172,7 @@ static struct mdio_driver xrs700x_mdio_driver = {
        },
        .probe  = xrs700x_mdio_probe,
        .remove = xrs700x_mdio_remove,
+       .shutdown = xrs700x_mdio_shutdown,
 };
 
 mdio_module_driver(xrs700x_mdio_driver);
index 8d90fed..6f0ea2f 100644 (file)
@@ -1050,7 +1050,7 @@ static netdev_tx_t corkscrew_start_xmit(struct sk_buff *skb,
 #ifdef VORTEX_BUS_MASTER
        if (vp->bus_master) {
                /* Set the bus-master controller to transfer the packet. */
-               outl((int) (skb->data), ioaddr + Wn7_MasterAddr);
+               outl(isa_virt_to_bus(skb->data), ioaddr + Wn7_MasterAddr);
                outw((skb->len + 3) & ~3, ioaddr + Wn7_MasterLen);
                vp->tx_skb = skb;
                outw(StartDMADown, ioaddr + EL3_CMD);
index 53660bc..9afc712 100644 (file)
@@ -922,13 +922,16 @@ static void __init ne_add_devices(void)
        }
 }
 
-#ifdef MODULE
 static int __init ne_init(void)
 {
        int retval;
-       ne_add_devices();
+
+       if (IS_MODULE(CONFIG_NE2000))
+               ne_add_devices();
+
        retval = platform_driver_probe(&ne_driver, ne_drv_probe);
-       if (retval) {
+
+       if (IS_MODULE(CONFIG_NE2000) && retval) {
                if (io[0] == 0)
                        pr_notice("ne.c: You must supply \"io=0xNNN\""
                               " value(s) for ISA cards.\n");
@@ -941,18 +944,8 @@ static int __init ne_init(void)
        return retval;
 }
 module_init(ne_init);
-#else /* MODULE */
-static int __init ne_init(void)
-{
-       int retval = platform_driver_probe(&ne_driver, ne_drv_probe);
-
-       /* Unregister unused platform_devices. */
-       ne_loop_rm_unreg(0);
-       return retval;
-}
-module_init(ne_init);
 
-#ifdef CONFIG_NETDEV_LEGACY_INIT
+#if !defined(MODULE) && defined(CONFIG_NETDEV_LEGACY_INIT)
 struct net_device * __init ne_probe(int unit)
 {
        int this_dev;
@@ -994,7 +987,6 @@ struct net_device * __init ne_probe(int unit)
        return ERR_PTR(-ENODEV);
 }
 #endif
-#endif /* MODULE */
 
 static void __exit ne_exit(void)
 {
index d796684..412ae3e 100644 (file)
@@ -100,6 +100,7 @@ config JME
 config KORINA
        tristate "Korina (IDT RC32434) Ethernet support"
        depends on MIKROTIK_RB532 || COMPILE_TEST
+       select CRC32
        select MII
        help
          If you have a Mikrotik RouterBoard 500 or IDT RC32434
index b5df7ad..032e892 100644 (file)
@@ -748,7 +748,7 @@ static void ni65_stop_start(struct net_device *dev,struct priv *p)
 #ifdef XMT_VIA_SKB
                        skb_save[i] = p->tmd_skb[i];
 #endif
-                       buffer[i] = (u32) isa_bus_to_virt(tmdp->u.buffer);
+                       buffer[i] = (unsigned long)isa_bus_to_virt(tmdp->u.buffer);
                        blen[i] = tmdp->blen;
                        tmdp->u.s.status = 0x0;
                }
index dee9ff7..d4b1976 100644 (file)
@@ -413,13 +413,13 @@ static int atl_resume_common(struct device *dev, bool deep)
        if (deep) {
                /* Reinitialize Nic/Vecs objects */
                aq_nic_deinit(nic, !nic->aq_hw->aq_nic_cfg->wol);
+       }
 
+       if (netif_running(nic->ndev)) {
                ret = aq_nic_init(nic);
                if (ret)
                        goto err_exit;
-       }
 
-       if (netif_running(nic->ndev)) {
                ret = aq_nic_start(nic);
                if (ret)
                        goto err_exit;
index 37a4177..92a79c4 100644 (file)
@@ -21,6 +21,7 @@ config ARC_EMAC_CORE
        depends on ARC || ARCH_ROCKCHIP || COMPILE_TEST
        select MII
        select PHYLIB
+       select CRC32
 
 config ARC_EMAC
        tristate "ARC EMAC support"
index 85fa0ab..9513cfb 100644 (file)
@@ -129,6 +129,8 @@ static int bgmac_probe(struct bcma_device *core)
        bcma_set_drvdata(core, bgmac);
 
        err = of_get_mac_address(bgmac->dev->of_node, bgmac->net_dev->dev_addr);
+       if (err == -EPROBE_DEFER)
+               return err;
 
        /* If no MAC address assigned via device tree, check SPROM */
        if (err) {
index 4ab5bf6..df8ff83 100644 (file)
@@ -192,6 +192,9 @@ static int bgmac_probe(struct platform_device *pdev)
        bgmac->dma_dev = &pdev->dev;
 
        ret = of_get_mac_address(np, bgmac->net_dev->dev_addr);
+       if (ret == -EPROBE_DEFER)
+               return ret;
+
        if (ret)
                dev_warn(&pdev->dev,
                         "MAC address not present in device tree\n");
index f255fd0..6fbf735 100644 (file)
@@ -1224,7 +1224,7 @@ int bnx2x_iov_init_one(struct bnx2x *bp, int int_mode_param,
 
        /* SR-IOV capability was enabled but there are no VFs*/
        if (iov->total == 0) {
-               err = -EINVAL;
+               err = 0;
                goto failed;
        }
 
index ea0c45d..62f84cc 100644 (file)
@@ -391,7 +391,7 @@ static bool bnxt_txr_netif_try_stop_queue(struct bnxt *bp,
         * netif_tx_queue_stopped().
         */
        smp_mb();
-       if (bnxt_tx_avail(bp, txr) > bp->tx_wake_thresh) {
+       if (bnxt_tx_avail(bp, txr) >= bp->tx_wake_thresh) {
                netif_tx_wake_queue(txq);
                return false;
        }
@@ -764,7 +764,7 @@ next_tx_int:
        smp_mb();
 
        if (unlikely(netif_tx_queue_stopped(txq)) &&
-           bnxt_tx_avail(bp, txr) > bp->tx_wake_thresh &&
+           bnxt_tx_avail(bp, txr) >= bp->tx_wake_thresh &&
            READ_ONCE(txr->dev_state) != BNXT_DEV_STATE_CLOSING)
                netif_tx_wake_queue(txq);
 }
@@ -2213,12 +2213,11 @@ static int bnxt_async_event_process(struct bnxt *bp,
                        DIV_ROUND_UP(fw_health->polling_dsecs * HZ,
                                     bp->current_interval * 10);
                fw_health->tmr_counter = fw_health->tmr_multiplier;
-               if (!fw_health->enabled) {
+               if (!fw_health->enabled)
                        fw_health->last_fw_heartbeat =
                                bnxt_fw_health_readl(bp, BNXT_FW_HEARTBEAT_REG);
-                       fw_health->last_fw_reset_cnt =
-                               bnxt_fw_health_readl(bp, BNXT_FW_RESET_CNT_REG);
-               }
+               fw_health->last_fw_reset_cnt =
+                       bnxt_fw_health_readl(bp, BNXT_FW_RESET_CNT_REG);
                netif_info(bp, drv, bp->dev,
                           "Error recovery info: error recovery[1], master[%d], reset count[%u], health status: 0x%x\n",
                           fw_health->master, fw_health->last_fw_reset_cnt,
@@ -2417,7 +2416,7 @@ static int __bnxt_poll_work(struct bnxt *bp, struct bnxt_cp_ring_info *cpr,
                if (TX_CMP_TYPE(txcmp) == CMP_TYPE_TX_L2_CMP) {
                        tx_pkts++;
                        /* return full budget so NAPI will complete. */
-                       if (unlikely(tx_pkts > bp->tx_wake_thresh)) {
+                       if (unlikely(tx_pkts >= bp->tx_wake_thresh)) {
                                rx_pkts = budget;
                                raw_cons = NEXT_RAW_CMP(raw_cons);
                                if (budget)
@@ -2730,6 +2729,9 @@ static void bnxt_free_tx_skbs(struct bnxt *bp)
                struct bnxt_tx_ring_info *txr = &bp->tx_ring[i];
                int j;
 
+               if (!txr->tx_buf_ring)
+                       continue;
+
                for (j = 0; j < max_idx;) {
                        struct bnxt_sw_tx_bd *tx_buf = &txr->tx_buf_ring[j];
                        struct sk_buff *skb;
@@ -2814,6 +2816,9 @@ static void bnxt_free_one_rx_ring_skbs(struct bnxt *bp, int ring_nr)
        }
 
 skip_rx_tpa_free:
+       if (!rxr->rx_buf_ring)
+               goto skip_rx_buf_free;
+
        for (i = 0; i < max_idx; i++) {
                struct bnxt_sw_rx_bd *rx_buf = &rxr->rx_buf_ring[i];
                dma_addr_t mapping = rx_buf->mapping;
@@ -2836,6 +2841,11 @@ skip_rx_tpa_free:
                        kfree(data);
                }
        }
+
+skip_rx_buf_free:
+       if (!rxr->rx_agg_ring)
+               goto skip_rx_agg_free;
+
        for (i = 0; i < max_agg_idx; i++) {
                struct bnxt_sw_rx_agg_bd *rx_agg_buf = &rxr->rx_agg_ring[i];
                struct page *page = rx_agg_buf->page;
@@ -2852,6 +2862,8 @@ skip_rx_tpa_free:
 
                __free_page(page);
        }
+
+skip_rx_agg_free:
        if (rxr->rx_page) {
                __free_page(rxr->rx_page);
                rxr->rx_page = NULL;
@@ -2900,6 +2912,9 @@ static void bnxt_free_ring(struct bnxt *bp, struct bnxt_ring_mem_info *rmem)
        struct pci_dev *pdev = bp->pdev;
        int i;
 
+       if (!rmem->pg_arr)
+               goto skip_pages;
+
        for (i = 0; i < rmem->nr_pages; i++) {
                if (!rmem->pg_arr[i])
                        continue;
@@ -2909,6 +2924,7 @@ static void bnxt_free_ring(struct bnxt *bp, struct bnxt_ring_mem_info *rmem)
 
                rmem->pg_arr[i] = NULL;
        }
+skip_pages:
        if (rmem->pg_tbl) {
                size_t pg_tbl_size = rmem->nr_pages * 8;
 
@@ -3228,10 +3244,14 @@ static int bnxt_alloc_tx_rings(struct bnxt *bp)
 
 static void bnxt_free_cp_arrays(struct bnxt_cp_ring_info *cpr)
 {
+       struct bnxt_ring_struct *ring = &cpr->cp_ring_struct;
+
        kfree(cpr->cp_desc_ring);
        cpr->cp_desc_ring = NULL;
+       ring->ring_mem.pg_arr = NULL;
        kfree(cpr->cp_desc_mapping);
        cpr->cp_desc_mapping = NULL;
+       ring->ring_mem.dma_arr = NULL;
 }
 
 static int bnxt_alloc_cp_arrays(struct bnxt_cp_ring_info *cpr, int n)
@@ -3620,7 +3640,7 @@ static int bnxt_init_tx_rings(struct bnxt *bp)
        u16 i;
 
        bp->tx_wake_thresh = max_t(int, bp->tx_ring_size / 2,
-                                  MAX_SKB_FRAGS + 1);
+                                  BNXT_MIN_TX_DESC_CNT);
 
        for (i = 0; i < bp->tx_nr_rings; i++) {
                struct bnxt_tx_ring_info *txr = &bp->tx_ring[i];
@@ -12207,6 +12227,11 @@ static void bnxt_fw_reset_task(struct work_struct *work)
                        return;
                }
 
+               if ((bp->fw_cap & BNXT_FW_CAP_ERROR_RECOVERY) &&
+                   bp->fw_health->enabled) {
+                       bp->fw_health->last_fw_reset_cnt =
+                               bnxt_fw_health_readl(bp, BNXT_FW_RESET_CNT_REG);
+               }
                bp->fw_reset_state = 0;
                /* Make sure fw_reset_state is 0 before clearing the flag */
                smp_mb__before_atomic();
index ec046e7..19fe647 100644 (file)
@@ -629,6 +629,11 @@ struct nqe_cn {
 #define BNXT_MAX_RX_JUM_DESC_CNT       (RX_DESC_CNT * MAX_RX_AGG_PAGES - 1)
 #define BNXT_MAX_TX_DESC_CNT           (TX_DESC_CNT * MAX_TX_PAGES - 1)
 
+/* Minimum TX BDs for a TX packet with MAX_SKB_FRAGS + 1.  We need one extra
+ * BD because the first TX BD is always a long BD.
+ */
+#define BNXT_MIN_TX_DESC_CNT           (MAX_SKB_FRAGS + 2)
+
 #define RX_RING(x)     (((x) & ~(RX_DESC_CNT - 1)) >> (BNXT_PAGE_SHIFT - 4))
 #define RX_IDX(x)      ((x) & (RX_DESC_CNT - 1))
 
index b056e3c..7260910 100644 (file)
@@ -798,7 +798,7 @@ static int bnxt_set_ringparam(struct net_device *dev,
 
        if ((ering->rx_pending > BNXT_MAX_RX_DESC_CNT) ||
            (ering->tx_pending > BNXT_MAX_TX_DESC_CNT) ||
-           (ering->tx_pending <= MAX_SKB_FRAGS))
+           (ering->tx_pending < BNXT_MIN_TX_DESC_CNT))
                return -EINVAL;
 
        if (netif_running(dev))
index 46fae1a..e6a4a76 100644 (file)
@@ -1884,9 +1884,6 @@ bnxt_tc_indr_block_cb_lookup(struct bnxt *bp, struct net_device *netdev)
 {
        struct bnxt_flower_indr_block_cb_priv *cb_priv;
 
-       /* All callback list access should be protected by RTNL. */
-       ASSERT_RTNL();
-
        list_for_each_entry(cb_priv, &bp->tc_indr_block_list, list)
                if (cb_priv->tunnel_netdev == netdev)
                        return cb_priv;
index 8b7b599..f66d22d 100644 (file)
@@ -111,9 +111,9 @@ static void macb_remove(struct pci_dev *pdev)
        struct platform_device *plat_dev = pci_get_drvdata(pdev);
        struct macb_platform_data *plat_data = dev_get_platdata(&plat_dev->dev);
 
-       platform_device_unregister(plat_dev);
        clk_unregister(plat_data->pclk);
        clk_unregister(plat_data->hclk);
+       platform_device_unregister(plat_dev);
 }
 
 static const struct pci_device_id dev_id_table[] = {
index 3ca93ad..042327b 100644 (file)
@@ -419,7 +419,7 @@ static void enetc_rx_dim_work(struct work_struct *w)
 
 static void enetc_rx_net_dim(struct enetc_int_vector *v)
 {
-       struct dim_sample dim_sample;
+       struct dim_sample dim_sample = {};
 
        v->comp_cnt++;
 
@@ -1879,7 +1879,6 @@ static void enetc_clear_bdrs(struct enetc_ndev_priv *priv)
 static int enetc_setup_irqs(struct enetc_ndev_priv *priv)
 {
        struct pci_dev *pdev = priv->si->pdev;
-       cpumask_t cpu_mask;
        int i, j, err;
 
        for (i = 0; i < priv->bdr_int_num; i++) {
@@ -1908,9 +1907,7 @@ static int enetc_setup_irqs(struct enetc_ndev_priv *priv)
 
                        enetc_wr(hw, ENETC_SIMSITRV(idx), entry);
                }
-               cpumask_clear(&cpu_mask);
-               cpumask_set_cpu(i % num_online_cpus(), &cpu_mask);
-               irq_set_affinity_hint(irq, &cpu_mask);
+               irq_set_affinity_hint(irq, get_cpu_mask(i % num_online_cpus()));
        }
 
        return 0;
index ee1468e..91f02c5 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause)
-/* Copyright 2021 NXP Semiconductors
+/* Copyright 2021 NXP
  *
  * The Integrated Endpoint Register Block (IERB) is configured by pre-boot
  * software and is supposed to be to ENETC what a NVRAM is to a 'real' PCIe
index b3b774e..c2ce47c 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: (GPL-2.0+ OR BSD-3-Clause) */
-/* Copyright 2021 NXP Semiconductors */
+/* Copyright 2021 NXP */
 
 #include <linux/pci.h>
 #include <linux/platform_device.h>
index 60d94e0..4c977df 100644 (file)
@@ -541,8 +541,7 @@ static void enetc_mac_config(struct enetc_hw *hw, phy_interface_t phy_mode)
 
        if (phy_interface_mode_is_rgmii(phy_mode)) {
                val = enetc_port_rd(hw, ENETC_PM0_IF_MODE);
-               val &= ~ENETC_PM0_IFM_EN_AUTO;
-               val &= ENETC_PM0_IFM_IFMODE_MASK;
+               val &= ~(ENETC_PM0_IFM_EN_AUTO | ENETC_PM0_IFM_IFMODE_MASK);
                val |= ENETC_PM0_IFM_IFMODE_GMII | ENETC_PM0_IFM_RG;
                enetc_port_wr(hw, ENETC_PM0_IF_MODE, val);
        }
index 80bd5c6..ec87b37 100644 (file)
@@ -4176,5 +4176,4 @@ static struct platform_driver fec_driver = {
 
 module_platform_driver(fec_driver);
 
-MODULE_ALIAS("platform:"DRIVER_NAME);
 MODULE_LICENSE("GPL");
index 1d3188e..92dc18a 100644 (file)
@@ -780,7 +780,7 @@ struct gve_queue_page_list *gve_assign_rx_qpl(struct gve_priv *priv)
                                    gve_num_tx_qpls(priv));
 
        /* we are out of rx qpls */
-       if (id == priv->qpl_cfg.qpl_map_size)
+       if (id == gve_num_tx_qpls(priv) + gve_num_rx_qpls(priv))
                return NULL;
 
        set_bit(id, priv->qpl_cfg.qpl_id_map);
index 099a2bc..bf8a4a7 100644 (file)
@@ -41,6 +41,7 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
 {
        struct gve_priv *priv = netdev_priv(dev);
        unsigned int start;
+       u64 packets, bytes;
        int ring;
 
        if (priv->rx) {
@@ -48,10 +49,12 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
                        do {
                                start =
                                  u64_stats_fetch_begin(&priv->rx[ring].statss);
-                               s->rx_packets += priv->rx[ring].rpackets;
-                               s->rx_bytes += priv->rx[ring].rbytes;
+                               packets = priv->rx[ring].rpackets;
+                               bytes = priv->rx[ring].rbytes;
                        } while (u64_stats_fetch_retry(&priv->rx[ring].statss,
                                                       start));
+                       s->rx_packets += packets;
+                       s->rx_bytes += bytes;
                }
        }
        if (priv->tx) {
@@ -59,10 +62,12 @@ static void gve_get_stats(struct net_device *dev, struct rtnl_link_stats64 *s)
                        do {
                                start =
                                  u64_stats_fetch_begin(&priv->tx[ring].statss);
-                               s->tx_packets += priv->tx[ring].pkt_done;
-                               s->tx_bytes += priv->tx[ring].bytes_done;
+                               packets = priv->tx[ring].pkt_done;
+                               bytes = priv->tx[ring].bytes_done;
                        } while (u64_stats_fetch_retry(&priv->tx[ring].statss,
                                                       start));
+                       s->tx_packets += packets;
+                       s->tx_bytes += bytes;
                }
        }
 }
@@ -82,6 +87,9 @@ static int gve_alloc_counter_array(struct gve_priv *priv)
 
 static void gve_free_counter_array(struct gve_priv *priv)
 {
+       if (!priv->counter_array)
+               return;
+
        dma_free_coherent(&priv->pdev->dev,
                          priv->num_event_counters *
                          sizeof(*priv->counter_array),
@@ -142,6 +150,9 @@ static int gve_alloc_stats_report(struct gve_priv *priv)
 
 static void gve_free_stats_report(struct gve_priv *priv)
 {
+       if (!priv->stats_report)
+               return;
+
        del_timer_sync(&priv->stats_report_timer);
        dma_free_coherent(&priv->pdev->dev, priv->stats_report_len,
                          priv->stats_report, priv->stats_report_bus);
@@ -370,18 +381,19 @@ static void gve_free_notify_blocks(struct gve_priv *priv)
 {
        int i;
 
-       if (priv->msix_vectors) {
-               /* Free the irqs */
-               for (i = 0; i < priv->num_ntfy_blks; i++) {
-                       struct gve_notify_block *block = &priv->ntfy_blocks[i];
-                       int msix_idx = i;
+       if (!priv->msix_vectors)
+               return;
 
-                       irq_set_affinity_hint(priv->msix_vectors[msix_idx].vector,
-                                             NULL);
-                       free_irq(priv->msix_vectors[msix_idx].vector, block);
-               }
-               free_irq(priv->msix_vectors[priv->mgmt_msix_idx].vector, priv);
+       /* Free the irqs */
+       for (i = 0; i < priv->num_ntfy_blks; i++) {
+               struct gve_notify_block *block = &priv->ntfy_blocks[i];
+               int msix_idx = i;
+
+               irq_set_affinity_hint(priv->msix_vectors[msix_idx].vector,
+                                     NULL);
+               free_irq(priv->msix_vectors[msix_idx].vector, block);
        }
+       free_irq(priv->msix_vectors[priv->mgmt_msix_idx].vector, priv);
        dma_free_coherent(&priv->pdev->dev,
                          priv->num_ntfy_blks * sizeof(*priv->ntfy_blocks),
                          priv->ntfy_blocks, priv->ntfy_block_bus);
@@ -1185,9 +1197,10 @@ static void gve_handle_reset(struct gve_priv *priv)
 
 void gve_handle_report_stats(struct gve_priv *priv)
 {
-       int idx, stats_idx = 0, tx_bytes;
-       unsigned int start = 0;
        struct stats *stats = priv->stats_report->stats;
+       int idx, stats_idx = 0;
+       unsigned int start = 0;
+       u64 tx_bytes;
 
        if (!gve_get_report_stats(priv))
                return;
index bb82613..94941d4 100644 (file)
@@ -104,8 +104,14 @@ static int gve_prefill_rx_pages(struct gve_rx_ring *rx)
        if (!rx->data.page_info)
                return -ENOMEM;
 
-       if (!rx->data.raw_addressing)
+       if (!rx->data.raw_addressing) {
                rx->data.qpl = gve_assign_rx_qpl(priv);
+               if (!rx->data.qpl) {
+                       kvfree(rx->data.page_info);
+                       rx->data.page_info = NULL;
+                       return -ENOMEM;
+               }
+       }
        for (i = 0; i < slots; i++) {
                if (!rx->data.raw_addressing) {
                        struct page *page = rx->data.qpl->pages[i];
index 546a605..8ba21d6 100644 (file)
@@ -752,7 +752,6 @@ struct hnae3_tc_info {
        u8 prio_tc[HNAE3_MAX_USER_PRIO]; /* TC indexed by prio */
        u16 tqp_count[HNAE3_MAX_TC];
        u16 tqp_offset[HNAE3_MAX_TC];
-       unsigned long tc_en; /* bitmap of TC enabled */
        u8 num_tc; /* Total number of enabled TCs */
        bool mqprio_active;
 };
index 22af3d6..468b8f0 100644 (file)
@@ -61,6 +61,9 @@ static unsigned int tx_sgl = 1;
 module_param(tx_sgl, uint, 0600);
 MODULE_PARM_DESC(tx_sgl, "Minimum number of frags when using dma_map_sg() to optimize the IOMMU mapping");
 
+static bool page_pool_enabled = true;
+module_param(page_pool_enabled, bool, 0400);
+
 #define HNS3_SGL_SIZE(nfrag)   (sizeof(struct scatterlist) * (nfrag) + \
                                 sizeof(struct sg_table))
 #define HNS3_MAX_SGL_SIZE      ALIGN(HNS3_SGL_SIZE(HNS3_MAX_TSO_BD_NUM), \
@@ -73,6 +76,7 @@ MODULE_PARM_DESC(tx_sgl, "Minimum number of frags when using dma_map_sg() to opt
 #define HNS3_OUTER_VLAN_TAG    2
 
 #define HNS3_MIN_TX_LEN                33U
+#define HNS3_MIN_TUN_PKT_LEN   65U
 
 /* hns3_pci_tbl - PCI Device ID Table
  *
@@ -619,13 +623,9 @@ static int hns3_nic_set_real_num_queue(struct net_device *netdev)
                        return ret;
                }
 
-               for (i = 0; i < HNAE3_MAX_TC; i++) {
-                       if (!test_bit(i, &tc_info->tc_en))
-                               continue;
-
+               for (i = 0; i < tc_info->num_tc; i++)
                        netdev_set_tc_queue(netdev, i, tc_info->tqp_count[i],
                                            tc_info->tqp_offset[i]);
-               }
        }
 
        ret = netif_set_real_num_tx_queues(netdev, queue_size);
@@ -775,6 +775,11 @@ static int hns3_nic_net_open(struct net_device *netdev)
        if (hns3_nic_resetting(netdev))
                return -EBUSY;
 
+       if (!test_bit(HNS3_NIC_STATE_DOWN, &priv->state)) {
+               netdev_warn(netdev, "net open repeatedly!\n");
+               return 0;
+       }
+
        netif_carrier_off(netdev);
 
        ret = hns3_nic_set_real_num_queue(netdev);
@@ -1424,8 +1429,11 @@ static int hns3_set_l2l3l4(struct sk_buff *skb, u8 ol4_proto,
                               l4.tcp->doff);
                break;
        case IPPROTO_UDP:
-               if (hns3_tunnel_csum_bug(skb))
-                       return skb_checksum_help(skb);
+               if (hns3_tunnel_csum_bug(skb)) {
+                       int ret = skb_put_padto(skb, HNS3_MIN_TUN_PKT_LEN);
+
+                       return ret ? ret : skb_checksum_help(skb);
+               }
 
                hns3_set_field(*type_cs_vlan_tso, HNS3_TXD_L4CS_B, 1);
                hns3_set_field(*type_cs_vlan_tso, HNS3_TXD_L4T_S,
@@ -4753,7 +4761,8 @@ static int hns3_alloc_ring_memory(struct hns3_enet_ring *ring)
                goto out_with_desc_cb;
 
        if (!HNAE3_IS_TX_RING(ring)) {
-               hns3_alloc_page_pool(ring);
+               if (page_pool_enabled)
+                       hns3_alloc_page_pool(ring);
 
                ret = hns3_alloc_ring_buffers(ring);
                if (ret)
@@ -4857,12 +4866,9 @@ static void hns3_init_tx_ring_tc(struct hns3_nic_priv *priv)
        struct hnae3_tc_info *tc_info = &kinfo->tc_info;
        int i;
 
-       for (i = 0; i < HNAE3_MAX_TC; i++) {
+       for (i = 0; i < tc_info->num_tc; i++) {
                int j;
 
-               if (!test_bit(i, &tc_info->tc_en))
-                       continue;
-
                for (j = 0; j < tc_info->tqp_count[i]; j++) {
                        struct hnae3_queue *q;
 
index 7ea511d..5ebd96f 100644 (file)
@@ -334,7 +334,8 @@ static void hns3_selftest_prepare(struct net_device *ndev,
 
 #if IS_ENABLED(CONFIG_VLAN_8021Q)
        /* Disable the vlan filter for selftest does not support it */
-       if (h->ae_algo->ops->enable_vlan_filter)
+       if (h->ae_algo->ops->enable_vlan_filter &&
+           ndev->features & NETIF_F_HW_VLAN_CTAG_FILTER)
                h->ae_algo->ops->enable_vlan_filter(h, false);
 #endif
 
@@ -359,7 +360,8 @@ static void hns3_selftest_restore(struct net_device *ndev, bool if_running)
                h->ae_algo->ops->halt_autoneg(h, false);
 
 #if IS_ENABLED(CONFIG_VLAN_8021Q)
-       if (h->ae_algo->ops->enable_vlan_filter)
+       if (h->ae_algo->ops->enable_vlan_filter &&
+           ndev->features & NETIF_F_HW_VLAN_CTAG_FILTER)
                h->ae_algo->ops->enable_vlan_filter(h, true);
 #endif
 
index ac9b695..9c2eeaa 100644 (file)
@@ -467,7 +467,7 @@ err_csq:
        return ret;
 }
 
-static int hclge_firmware_compat_config(struct hclge_dev *hdev)
+static int hclge_firmware_compat_config(struct hclge_dev *hdev, bool en)
 {
        struct hclge_firmware_compat_cmd *req;
        struct hclge_desc desc;
@@ -475,13 +475,16 @@ static int hclge_firmware_compat_config(struct hclge_dev *hdev)
 
        hclge_cmd_setup_basic_desc(&desc, HCLGE_OPC_IMP_COMPAT_CFG, false);
 
-       req = (struct hclge_firmware_compat_cmd *)desc.data;
+       if (en) {
+               req = (struct hclge_firmware_compat_cmd *)desc.data;
 
-       hnae3_set_bit(compat, HCLGE_LINK_EVENT_REPORT_EN_B, 1);
-       hnae3_set_bit(compat, HCLGE_NCSI_ERROR_REPORT_EN_B, 1);
-       if (hnae3_dev_phy_imp_supported(hdev))
-               hnae3_set_bit(compat, HCLGE_PHY_IMP_EN_B, 1);
-       req->compat = cpu_to_le32(compat);
+               hnae3_set_bit(compat, HCLGE_LINK_EVENT_REPORT_EN_B, 1);
+               hnae3_set_bit(compat, HCLGE_NCSI_ERROR_REPORT_EN_B, 1);
+               if (hnae3_dev_phy_imp_supported(hdev))
+                       hnae3_set_bit(compat, HCLGE_PHY_IMP_EN_B, 1);
+
+               req->compat = cpu_to_le32(compat);
+       }
 
        return hclge_cmd_send(&hdev->hw, &desc, 1);
 }
@@ -538,7 +541,7 @@ int hclge_cmd_init(struct hclge_dev *hdev)
        /* ask the firmware to enable some features, driver can work without
         * it.
         */
-       ret = hclge_firmware_compat_config(hdev);
+       ret = hclge_firmware_compat_config(hdev, true);
        if (ret)
                dev_warn(&hdev->pdev->dev,
                         "Firmware compatible features not enabled(%d).\n",
@@ -568,6 +571,8 @@ static void hclge_cmd_uninit_regs(struct hclge_hw *hw)
 
 void hclge_cmd_uninit(struct hclge_dev *hdev)
 {
+       hclge_firmware_compat_config(hdev, false);
+
        set_bit(HCLGE_STATE_CMD_DISABLE, &hdev->state);
        /* wait to ensure that the firmware completes the possible left
         * over commands.
index 4a619e5..307c9e8 100644 (file)
@@ -247,6 +247,10 @@ static int hclge_ieee_setets(struct hnae3_handle *h, struct ieee_ets *ets)
        }
 
        hclge_tm_schd_info_update(hdev, num_tc);
+       if (num_tc > 1)
+               hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
+       else
+               hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
 
        ret = hclge_ieee_ets_to_tm_info(hdev, ets);
        if (ret)
@@ -306,8 +310,7 @@ static int hclge_ieee_setpfc(struct hnae3_handle *h, struct ieee_pfc *pfc)
        u8 i, j, pfc_map, *prio_tc;
        int ret;
 
-       if (!(hdev->dcbx_cap & DCB_CAP_DCBX_VER_IEEE) ||
-           hdev->flag & HCLGE_FLAG_MQPRIO_ENABLE)
+       if (!(hdev->dcbx_cap & DCB_CAP_DCBX_VER_IEEE))
                return -EINVAL;
 
        if (pfc->pfc_en == hdev->tm_info.pfc_en)
@@ -441,8 +444,6 @@ static int hclge_mqprio_qopt_check(struct hclge_dev *hdev,
 static void hclge_sync_mqprio_qopt(struct hnae3_tc_info *tc_info,
                                   struct tc_mqprio_qopt_offload *mqprio_qopt)
 {
-       int i;
-
        memset(tc_info, 0, sizeof(*tc_info));
        tc_info->num_tc = mqprio_qopt->qopt.num_tc;
        memcpy(tc_info->prio_tc, mqprio_qopt->qopt.prio_tc_map,
@@ -451,9 +452,6 @@ static void hclge_sync_mqprio_qopt(struct hnae3_tc_info *tc_info,
               sizeof_field(struct hnae3_tc_info, tqp_count));
        memcpy(tc_info->tqp_offset, mqprio_qopt->qopt.offset,
               sizeof_field(struct hnae3_tc_info, tqp_offset));
-
-       for (i = 0; i < HNAE3_MAX_USER_PRIO; i++)
-               set_bit(tc_info->prio_tc[i], &tc_info->tc_en);
 }
 
 static int hclge_config_tc(struct hclge_dev *hdev,
@@ -519,12 +517,17 @@ static int hclge_setup_tc(struct hnae3_handle *h,
        return hclge_notify_init_up(hdev);
 
 err_out:
-       /* roll-back */
-       memcpy(&kinfo->tc_info, &old_tc_info, sizeof(old_tc_info));
-       if (hclge_config_tc(hdev, &kinfo->tc_info))
-               dev_err(&hdev->pdev->dev,
-                       "failed to roll back tc configuration\n");
-
+       if (!tc) {
+               dev_warn(&hdev->pdev->dev,
+                        "failed to destroy mqprio, will active after reset, ret = %d\n",
+                        ret);
+       } else {
+               /* roll-back */
+               memcpy(&kinfo->tc_info, &old_tc_info, sizeof(old_tc_info));
+               if (hclge_config_tc(hdev, &kinfo->tc_info))
+                       dev_err(&hdev->pdev->dev,
+                               "failed to roll back tc configuration\n");
+       }
        hclge_notify_init_up(hdev);
 
        return ret;
index 68ed171..32f62cd 100644 (file)
@@ -719,9 +719,9 @@ static void hclge_dbg_fill_shaper_content(struct hclge_tm_shaper_para *para,
        sprintf(result[(*index)++], "%6u", para->rate);
 }
 
-static int hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *buf, int len)
+static int __hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *data_str,
+                                 char *buf, int len)
 {
-       char data_str[ARRAY_SIZE(tm_pg_items)][HCLGE_DBG_DATA_STR_LEN];
        struct hclge_tm_shaper_para c_shaper_para, p_shaper_para;
        char *result[ARRAY_SIZE(tm_pg_items)], *sch_mode_str;
        u8 pg_id, sch_mode, weight, pri_bit_map, i, j;
@@ -729,8 +729,10 @@ static int hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *buf, int len)
        int pos = 0;
        int ret;
 
-       for (i = 0; i < ARRAY_SIZE(tm_pg_items); i++)
-               result[i] = &data_str[i][0];
+       for (i = 0; i < ARRAY_SIZE(tm_pg_items); i++) {
+               result[i] = data_str;
+               data_str += HCLGE_DBG_DATA_STR_LEN;
+       }
 
        hclge_dbg_fill_content(content, sizeof(content), tm_pg_items,
                               NULL, ARRAY_SIZE(tm_pg_items));
@@ -781,6 +783,24 @@ static int hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *buf, int len)
        return 0;
 }
 
+static int hclge_dbg_dump_tm_pg(struct hclge_dev *hdev, char *buf, int len)
+{
+       char *data_str;
+       int ret;
+
+       data_str = kcalloc(ARRAY_SIZE(tm_pg_items),
+                          HCLGE_DBG_DATA_STR_LEN, GFP_KERNEL);
+
+       if (!data_str)
+               return -ENOMEM;
+
+       ret = __hclge_dbg_dump_tm_pg(hdev, data_str, buf, len);
+
+       kfree(data_str);
+
+       return ret;
+}
+
 static int hclge_dbg_dump_tm_port(struct hclge_dev *hdev,  char *buf, int len)
 {
        struct hclge_tm_shaper_para shaper_para;
@@ -1724,6 +1744,10 @@ hclge_dbg_get_imp_stats_info(struct hclge_dev *hdev, char *buf, int len)
        }
 
        bd_num = le32_to_cpu(req->bd_num);
+       if (!bd_num) {
+               dev_err(&hdev->pdev->dev, "imp statistics bd number is 0!\n");
+               return -EINVAL;
+       }
 
        desc_src = kcalloc(bd_num, sizeof(struct hclge_desc), GFP_KERNEL);
        if (!desc_src)
index 718c16d..bb9b026 100644 (file)
@@ -2445,12 +2445,12 @@ static void hclge_handle_over_8bd_err(struct hclge_dev *hdev,
                return;
        }
 
-       dev_err(dev, "PPU_PF_ABNORMAL_INT_ST over_8bd_no_fe found, vf_id(%u), queue_id(%u)\n",
+       dev_err(dev, "PPU_PF_ABNORMAL_INT_ST over_8bd_no_fe found, vport(%u), queue_id(%u)\n",
                vf_id, q_id);
 
        if (vf_id) {
                if (vf_id >= hdev->num_alloc_vport) {
-                       dev_err(dev, "invalid vf id(%u)\n", vf_id);
+                       dev_err(dev, "invalid vport(%u)\n", vf_id);
                        return;
                }
 
@@ -2463,8 +2463,8 @@ static void hclge_handle_over_8bd_err(struct hclge_dev *hdev,
 
                ret = hclge_inform_reset_assert_to_vf(&hdev->vport[vf_id]);
                if (ret)
-                       dev_err(dev, "inform reset to vf(%u) failed %d!\n",
-                               hdev->vport->vport_id, ret);
+                       dev_err(dev, "inform reset to vport(%u) failed %d!\n",
+                               vf_id, ret);
        } else {
                set_bit(HNAE3_FUNC_RESET, reset_requests);
        }
index e55ba2e..f5b8d1f 100644 (file)
@@ -1528,9 +1528,10 @@ static void hclge_init_kdump_kernel_config(struct hclge_dev *hdev)
 static int hclge_configure(struct hclge_dev *hdev)
 {
        struct hnae3_ae_dev *ae_dev = pci_get_drvdata(hdev->pdev);
+       const struct cpumask *cpumask = cpu_online_mask;
        struct hclge_cfg cfg;
        unsigned int i;
-       int ret;
+       int node, ret;
 
        ret = hclge_get_cfg(hdev, &cfg);
        if (ret)
@@ -1595,11 +1596,12 @@ static int hclge_configure(struct hclge_dev *hdev)
 
        hclge_init_kdump_kernel_config(hdev);
 
-       /* Set the init affinity based on pci func number */
-       i = cpumask_weight(cpumask_of_node(dev_to_node(&hdev->pdev->dev)));
-       i = i ? PCI_FUNC(hdev->pdev->devfn) % i : 0;
-       cpumask_set_cpu(cpumask_local_spread(i, dev_to_node(&hdev->pdev->dev)),
-                       &hdev->affinity_mask);
+       /* Set the affinity based on numa node */
+       node = dev_to_node(&hdev->pdev->dev);
+       if (node != NUMA_NO_NODE)
+               cpumask = cpumask_of_node(node);
+
+       cpumask_copy(&hdev->affinity_mask, cpumask);
 
        return ret;
 }
@@ -3659,7 +3661,8 @@ static int hclge_set_all_vf_rst(struct hclge_dev *hdev, bool reset)
                if (ret) {
                        dev_err(&hdev->pdev->dev,
                                "set vf(%u) rst failed %d!\n",
-                               vport->vport_id, ret);
+                               vport->vport_id - HCLGE_VF_VPORT_START_NUM,
+                               ret);
                        return ret;
                }
 
@@ -3674,7 +3677,8 @@ static int hclge_set_all_vf_rst(struct hclge_dev *hdev, bool reset)
                if (ret)
                        dev_warn(&hdev->pdev->dev,
                                 "inform reset to vf(%u) failed %d!\n",
-                                vport->vport_id, ret);
+                                vport->vport_id - HCLGE_VF_VPORT_START_NUM,
+                                ret);
        }
 
        return 0;
@@ -4739,6 +4743,24 @@ static int hclge_get_rss(struct hnae3_handle *handle, u32 *indir,
        return 0;
 }
 
+static int hclge_parse_rss_hfunc(struct hclge_vport *vport, const u8 hfunc,
+                                u8 *hash_algo)
+{
+       switch (hfunc) {
+       case ETH_RSS_HASH_TOP:
+               *hash_algo = HCLGE_RSS_HASH_ALGO_TOEPLITZ;
+               return 0;
+       case ETH_RSS_HASH_XOR:
+               *hash_algo = HCLGE_RSS_HASH_ALGO_SIMPLE;
+               return 0;
+       case ETH_RSS_HASH_NO_CHANGE:
+               *hash_algo = vport->rss_algo;
+               return 0;
+       default:
+               return -EINVAL;
+       }
+}
+
 static int hclge_set_rss(struct hnae3_handle *handle, const u32 *indir,
                         const  u8 *key, const  u8 hfunc)
 {
@@ -4748,30 +4770,27 @@ static int hclge_set_rss(struct hnae3_handle *handle, const u32 *indir,
        u8 hash_algo;
        int ret, i;
 
+       ret = hclge_parse_rss_hfunc(vport, hfunc, &hash_algo);
+       if (ret) {
+               dev_err(&hdev->pdev->dev, "invalid hfunc type %u\n", hfunc);
+               return ret;
+       }
+
        /* Set the RSS Hash Key if specififed by the user */
        if (key) {
-               switch (hfunc) {
-               case ETH_RSS_HASH_TOP:
-                       hash_algo = HCLGE_RSS_HASH_ALGO_TOEPLITZ;
-                       break;
-               case ETH_RSS_HASH_XOR:
-                       hash_algo = HCLGE_RSS_HASH_ALGO_SIMPLE;
-                       break;
-               case ETH_RSS_HASH_NO_CHANGE:
-                       hash_algo = vport->rss_algo;
-                       break;
-               default:
-                       return -EINVAL;
-               }
-
                ret = hclge_set_rss_algo_key(hdev, hash_algo, key);
                if (ret)
                        return ret;
 
                /* Update the shadow RSS key with user specified qids */
                memcpy(vport->rss_hash_key, key, HCLGE_RSS_KEY_SIZE);
-               vport->rss_algo = hash_algo;
+       } else {
+               ret = hclge_set_rss_algo_key(hdev, hash_algo,
+                                            vport->rss_hash_key);
+               if (ret)
+                       return ret;
        }
+       vport->rss_algo = hash_algo;
 
        /* Update the shadow RSS table with user specified qids */
        for (i = 0; i < ae_dev->dev_specs.rss_ind_tbl_size; i++)
@@ -6625,10 +6644,13 @@ static int hclge_fd_parse_ring_cookie(struct hclge_dev *hdev, u64 ring_cookie,
                u8 vf = ethtool_get_flow_spec_ring_vf(ring_cookie);
                u16 tqps;
 
+               /* To keep consistent with user's configuration, minus 1 when
+                * printing 'vf', because vf id from ethtool is added 1 for vf.
+                */
                if (vf > hdev->num_req_vfs) {
                        dev_err(&hdev->pdev->dev,
-                               "Error: vf id (%u) > max vf num (%u)\n",
-                               vf, hdev->num_req_vfs);
+                               "Error: vf id (%u) should be less than %u\n",
+                               vf - 1, hdev->num_req_vfs);
                        return -EINVAL;
                }
 
@@ -8125,11 +8147,12 @@ static void hclge_ae_stop(struct hnae3_handle *handle)
        hclge_clear_arfs_rules(hdev);
        spin_unlock_bh(&hdev->fd_rule_lock);
 
-       /* If it is not PF reset, the firmware will disable the MAC,
+       /* If it is not PF reset or FLR, the firmware will disable the MAC,
         * so it only need to stop phy here.
         */
        if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state) &&
-           hdev->reset_type != HNAE3_FUNC_RESET) {
+           hdev->reset_type != HNAE3_FUNC_RESET &&
+           hdev->reset_type != HNAE3_FLR_RESET) {
                hclge_mac_stop_phy(hdev);
                hclge_update_link_status(hdev);
                return;
@@ -8685,15 +8708,8 @@ int hclge_add_uc_addr_common(struct hclge_vport *vport,
        }
 
        /* check if we just hit the duplicate */
-       if (!ret) {
-               dev_warn(&hdev->pdev->dev, "VF %u mac(%pM) exists\n",
-                        vport->vport_id, addr);
-               return 0;
-       }
-
-       dev_err(&hdev->pdev->dev,
-               "PF failed to add unicast entry(%pM) in the MAC table\n",
-               addr);
+       if (!ret)
+               return -EEXIST;
 
        return ret;
 }
@@ -8845,7 +8861,13 @@ static void hclge_sync_vport_mac_list(struct hclge_vport *vport,
                } else {
                        set_bit(HCLGE_VPORT_STATE_MAC_TBL_CHANGE,
                                &vport->state);
-                       break;
+
+                       /* If one unicast mac address is existing in hardware,
+                        * we need to try whether other unicast mac addresses
+                        * are new addresses that can be added.
+                        */
+                       if (ret != -EEXIST)
+                               break;
                }
        }
 }
@@ -9794,6 +9816,9 @@ static int hclge_set_vlan_filter_hw(struct hclge_dev *hdev, __be16 proto,
        if (is_kill && !vlan_id)
                return 0;
 
+       if (vlan_id >= VLAN_N_VID)
+               return -EINVAL;
+
        ret = hclge_set_vf_vlan_common(hdev, vport_id, is_kill, vlan_id);
        if (ret) {
                dev_err(&hdev->pdev->dev,
@@ -10700,7 +10725,8 @@ static int hclge_reset_tqp_cmd_send(struct hclge_dev *hdev, u16 queue_id,
        return 0;
 }
 
-static int hclge_get_reset_status(struct hclge_dev *hdev, u16 queue_id)
+static int hclge_get_reset_status(struct hclge_dev *hdev, u16 queue_id,
+                                 u8 *reset_status)
 {
        struct hclge_reset_tqp_queue_cmd *req;
        struct hclge_desc desc;
@@ -10718,7 +10744,9 @@ static int hclge_get_reset_status(struct hclge_dev *hdev, u16 queue_id)
                return ret;
        }
 
-       return hnae3_get_bit(req->ready_to_reset, HCLGE_TQP_RESET_B);
+       *reset_status = hnae3_get_bit(req->ready_to_reset, HCLGE_TQP_RESET_B);
+
+       return 0;
 }
 
 u16 hclge_covert_handle_qid_global(struct hnae3_handle *handle, u16 queue_id)
@@ -10737,7 +10765,7 @@ static int hclge_reset_tqp_cmd(struct hnae3_handle *handle)
        struct hclge_vport *vport = hclge_get_vport(handle);
        struct hclge_dev *hdev = vport->back;
        u16 reset_try_times = 0;
-       int reset_status;
+       u8 reset_status;
        u16 queue_gid;
        int ret;
        u16 i;
@@ -10753,7 +10781,11 @@ static int hclge_reset_tqp_cmd(struct hnae3_handle *handle)
                }
 
                while (reset_try_times++ < HCLGE_TQP_RESET_TRY_TIMES) {
-                       reset_status = hclge_get_reset_status(hdev, queue_gid);
+                       ret = hclge_get_reset_status(hdev, queue_gid,
+                                                    &reset_status);
+                       if (ret)
+                               return ret;
+
                        if (reset_status)
                                break;
 
@@ -11446,11 +11478,11 @@ static void hclge_clear_resetting_state(struct hclge_dev *hdev)
                struct hclge_vport *vport = &hdev->vport[i];
                int ret;
 
-                /* Send cmd to clear VF's FUNC_RST_ING */
+                /* Send cmd to clear vport's FUNC_RST_ING */
                ret = hclge_set_vf_rst(hdev, vport->vport_id, false);
                if (ret)
                        dev_warn(&hdev->pdev->dev,
-                                "clear vf(%u) rst failed %d!\n",
+                                "clear vport(%u) rst failed %d!\n",
                                 vport->vport_id, ret);
        }
 }
@@ -12764,8 +12796,12 @@ static void hclge_sync_promisc_mode(struct hclge_dev *hdev)
                        continue;
 
                if (vport->vf_info.trusted) {
-                       uc_en = vport->vf_info.request_uc_en > 0;
-                       mc_en = vport->vf_info.request_mc_en > 0;
+                       uc_en = vport->vf_info.request_uc_en > 0 ||
+                               vport->overflow_promisc_flags &
+                               HNAE3_OVERFLOW_UPE;
+                       mc_en = vport->vf_info.request_mc_en > 0 ||
+                               vport->overflow_promisc_flags &
+                               HNAE3_OVERFLOW_MPE;
                }
                bc_en = vport->vf_info.request_bc_en > 0;
 
index 2ce5302..65d78ee 100644 (file)
@@ -566,7 +566,7 @@ static int hclge_reset_vf(struct hclge_vport *vport)
        struct hclge_dev *hdev = vport->back;
 
        dev_warn(&hdev->pdev->dev, "PF received VF reset request from VF %u!",
-                vport->vport_id);
+                vport->vport_id - HCLGE_VF_VPORT_START_NUM);
 
        return hclge_func_reset_cmd(hdev, vport->vport_id);
 }
@@ -590,9 +590,17 @@ static void hclge_get_queue_id_in_pf(struct hclge_vport *vport,
                                     struct hclge_mbx_vf_to_pf_cmd *mbx_req,
                                     struct hclge_respond_to_vf_msg *resp_msg)
 {
+       struct hnae3_handle *handle = &vport->nic;
+       struct hclge_dev *hdev = vport->back;
        u16 queue_id, qid_in_pf;
 
        memcpy(&queue_id, mbx_req->msg.data, sizeof(queue_id));
+       if (queue_id >= handle->kinfo.num_tqps) {
+               dev_err(&hdev->pdev->dev, "Invalid queue id(%u) from VF %u\n",
+                       queue_id, mbx_req->mbx_src_vfid);
+               return;
+       }
+
        qid_in_pf = hclge_covert_handle_qid_global(&vport->nic, queue_id);
        memcpy(resp_msg->data, &qid_in_pf, sizeof(qid_in_pf));
        resp_msg->len = sizeof(qid_in_pf);
index 78d5bf1..f314dbd 100644 (file)
@@ -581,7 +581,7 @@ int hclge_tm_qs_shaper_cfg(struct hclge_vport *vport, int max_tx_rate)
                ret = hclge_cmd_send(&hdev->hw, &desc, 1);
                if (ret) {
                        dev_err(&hdev->pdev->dev,
-                               "vf%u, qs%u failed to set tx_rate:%d, ret=%d\n",
+                               "vport%u, qs%u failed to set tx_rate:%d, ret=%d\n",
                                vport->vport_id, shap_cfg_cmd->qs_id,
                                max_tx_rate, ret);
                        return ret;
@@ -687,12 +687,10 @@ static void hclge_tm_vport_tc_info_update(struct hclge_vport *vport)
 
        for (i = 0; i < HNAE3_MAX_TC; i++) {
                if (hdev->hw_tc_map & BIT(i) && i < kinfo->tc_info.num_tc) {
-                       set_bit(i, &kinfo->tc_info.tc_en);
                        kinfo->tc_info.tqp_offset[i] = i * kinfo->rss_size;
                        kinfo->tc_info.tqp_count[i] = kinfo->rss_size;
                } else {
                        /* Set to default queue if TC is disable */
-                       clear_bit(i, &kinfo->tc_info.tc_en);
                        kinfo->tc_info.tqp_offset[i] = 0;
                        kinfo->tc_info.tqp_count[i] = 1;
                }
@@ -729,14 +727,6 @@ static void hclge_tm_tc_info_init(struct hclge_dev *hdev)
        for (i = 0; i < HNAE3_MAX_USER_PRIO; i++)
                hdev->tm_info.prio_tc[i] =
                        (i >= hdev->tm_info.num_tc) ? 0 : i;
-
-       /* DCB is enabled if we have more than 1 TC or pfc_en is
-        * non-zero.
-        */
-       if (hdev->tm_info.num_tc > 1 || hdev->tm_info.pfc_en)
-               hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
-       else
-               hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
 }
 
 static void hclge_tm_pg_info_init(struct hclge_dev *hdev)
@@ -767,10 +757,10 @@ static void hclge_tm_pg_info_init(struct hclge_dev *hdev)
 
 static void hclge_update_fc_mode_by_dcb_flag(struct hclge_dev *hdev)
 {
-       if (!(hdev->flag & HCLGE_FLAG_DCB_ENABLE)) {
+       if (hdev->tm_info.num_tc == 1 && !hdev->tm_info.pfc_en) {
                if (hdev->fc_mode_last_time == HCLGE_FC_PFC)
                        dev_warn(&hdev->pdev->dev,
-                                "DCB is disable, but last mode is FC_PFC\n");
+                                "Only 1 tc used, but last mode is FC_PFC\n");
 
                hdev->tm_info.fc_mode = hdev->fc_mode_last_time;
        } else if (hdev->tm_info.fc_mode != HCLGE_FC_PFC) {
@@ -796,7 +786,7 @@ static void hclge_update_fc_mode(struct hclge_dev *hdev)
        }
 }
 
-static void hclge_pfc_info_init(struct hclge_dev *hdev)
+void hclge_tm_pfc_info_update(struct hclge_dev *hdev)
 {
        if (hdev->ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V3)
                hclge_update_fc_mode(hdev);
@@ -812,7 +802,7 @@ static void hclge_tm_schd_info_init(struct hclge_dev *hdev)
 
        hclge_tm_vport_info_update(hdev);
 
-       hclge_pfc_info_init(hdev);
+       hclge_tm_pfc_info_update(hdev);
 }
 
 static int hclge_tm_pg_to_pri_map(struct hclge_dev *hdev)
@@ -1558,19 +1548,6 @@ void hclge_tm_schd_info_update(struct hclge_dev *hdev, u8 num_tc)
        hclge_tm_schd_info_init(hdev);
 }
 
-void hclge_tm_pfc_info_update(struct hclge_dev *hdev)
-{
-       /* DCB is enabled if we have more than 1 TC or pfc_en is
-        * non-zero.
-        */
-       if (hdev->tm_info.num_tc > 1 || hdev->tm_info.pfc_en)
-               hdev->flag |= HCLGE_FLAG_DCB_ENABLE;
-       else
-               hdev->flag &= ~HCLGE_FLAG_DCB_ENABLE;
-
-       hclge_pfc_info_init(hdev);
-}
-
 int hclge_tm_init_hw(struct hclge_dev *hdev, bool init)
 {
        int ret;
@@ -1616,7 +1593,7 @@ int hclge_tm_vport_map_update(struct hclge_dev *hdev)
        if (ret)
                return ret;
 
-       if (!(hdev->flag & HCLGE_FLAG_DCB_ENABLE))
+       if (hdev->tm_info.num_tc == 1 && !hdev->tm_info.pfc_en)
                return 0;
 
        return hclge_tm_bp_setup(hdev);
index 82e7270..5fdac86 100644 (file)
@@ -816,40 +816,56 @@ static int hclgevf_get_rss(struct hnae3_handle *handle, u32 *indir, u8 *key,
        return 0;
 }
 
+static int hclgevf_parse_rss_hfunc(struct hclgevf_dev *hdev, const u8 hfunc,
+                                  u8 *hash_algo)
+{
+       switch (hfunc) {
+       case ETH_RSS_HASH_TOP:
+               *hash_algo = HCLGEVF_RSS_HASH_ALGO_TOEPLITZ;
+               return 0;
+       case ETH_RSS_HASH_XOR:
+               *hash_algo = HCLGEVF_RSS_HASH_ALGO_SIMPLE;
+               return 0;
+       case ETH_RSS_HASH_NO_CHANGE:
+               *hash_algo = hdev->rss_cfg.hash_algo;
+               return 0;
+       default:
+               return -EINVAL;
+       }
+}
+
 static int hclgevf_set_rss(struct hnae3_handle *handle, const u32 *indir,
                           const u8 *key, const u8 hfunc)
 {
        struct hclgevf_dev *hdev = hclgevf_ae_get_hdev(handle);
        struct hclgevf_rss_cfg *rss_cfg = &hdev->rss_cfg;
+       u8 hash_algo;
        int ret, i;
 
        if (hdev->ae_dev->dev_version >= HNAE3_DEVICE_VERSION_V2) {
+               ret = hclgevf_parse_rss_hfunc(hdev, hfunc, &hash_algo);
+               if (ret)
+                       return ret;
+
                /* Set the RSS Hash Key if specififed by the user */
                if (key) {
-                       switch (hfunc) {
-                       case ETH_RSS_HASH_TOP:
-                               rss_cfg->hash_algo =
-                                       HCLGEVF_RSS_HASH_ALGO_TOEPLITZ;
-                               break;
-                       case ETH_RSS_HASH_XOR:
-                               rss_cfg->hash_algo =
-                                       HCLGEVF_RSS_HASH_ALGO_SIMPLE;
-                               break;
-                       case ETH_RSS_HASH_NO_CHANGE:
-                               break;
-                       default:
-                               return -EINVAL;
-                       }
-
-                       ret = hclgevf_set_rss_algo_key(hdev, rss_cfg->hash_algo,
-                                                      key);
-                       if (ret)
+                       ret = hclgevf_set_rss_algo_key(hdev, hash_algo, key);
+                       if (ret) {
+                               dev_err(&hdev->pdev->dev,
+                                       "invalid hfunc type %u\n", hfunc);
                                return ret;
+                       }
 
                        /* Update the shadow RSS key with user specified qids */
                        memcpy(rss_cfg->rss_hash_key, key,
                               HCLGEVF_RSS_KEY_SIZE);
+               } else {
+                       ret = hclgevf_set_rss_algo_key(hdev, hash_algo,
+                                                      rss_cfg->rss_hash_key);
+                       if (ret)
+                               return ret;
                }
+               rss_cfg->hash_algo = hash_algo;
        }
 
        /* update the shadow RSS table with user specified qids */
@@ -2465,6 +2481,8 @@ static irqreturn_t hclgevf_misc_irq_handle(int irq, void *data)
 
        hclgevf_enable_vector(&hdev->misc_vector, false);
        event_cause = hclgevf_check_evt_cause(hdev, &clearval);
+       if (event_cause != HCLGEVF_VECTOR0_EVENT_OTHER)
+               hclgevf_clear_event_cause(hdev, clearval);
 
        switch (event_cause) {
        case HCLGEVF_VECTOR0_EVENT_RST:
@@ -2477,10 +2495,8 @@ static irqreturn_t hclgevf_misc_irq_handle(int irq, void *data)
                break;
        }
 
-       if (event_cause != HCLGEVF_VECTOR0_EVENT_OTHER) {
-               hclgevf_clear_event_cause(hdev, clearval);
+       if (event_cause != HCLGEVF_VECTOR0_EVENT_OTHER)
                hclgevf_enable_vector(&hdev->misc_vector, true);
-       }
 
        return IRQ_HANDLED;
 }
index 3e54017..07fdab5 100644 (file)
@@ -354,7 +354,7 @@ static int hns_mdio_reset(struct mii_bus *bus)
 
        if (dev_of_node(bus->parent)) {
                if (!mdio_dev->subctrl_vbase) {
-                       dev_err(&bus->dev, "mdio sys ctl reg has not maped\n");
+                       dev_err(&bus->dev, "mdio sys ctl reg has not mapped\n");
                        return -ENODEV;
                }
 
index b8a4014..b482f6f 100644 (file)
@@ -1144,7 +1144,7 @@ static struct net_device * __init i82596_probe(void)
                        err = -ENODEV;
                        goto out;
                }
-               memcpy(eth_addr, (void *) 0xfffc1f2c, ETH_ALEN);        /* YUCK! Get addr from NOVRAM */
+               memcpy(eth_addr, absolute_pointer(0xfffc1f2c), ETH_ALEN); /* YUCK! Get addr from NOVRAM */
                dev->base_addr = MVME_I596_BASE;
                dev->irq = (unsigned) MVME16x_IRQ_I596;
                goto found;
index a775c69..6aa6ff8 100644 (file)
@@ -4700,6 +4700,14 @@ static int handle_login_rsp(union ibmvnic_crq *login_rsp_crq,
                return 0;
        }
 
+       if (adapter->failover_pending) {
+               adapter->init_done_rc = -EAGAIN;
+               netdev_dbg(netdev, "Failover pending, ignoring login response\n");
+               complete(&adapter->init_done);
+               /* login response buffer will be released on reset */
+               return 0;
+       }
+
        netdev->mtu = adapter->req_mtu - ETH_HLEN;
 
        netdev_dbg(adapter->netdev, "Login Response Buffer:\n");
index b0b6f90..ed8ea63 100644 (file)
@@ -335,6 +335,7 @@ config IGC
        tristate "Intel(R) Ethernet Controller I225-LM/I225-V support"
        default n
        depends on PCI
+       depends on PTP_1588_CLOCK_OPTIONAL
        help
          This driver supports Intel(R) Ethernet Controller I225-LM/I225-V
          family of adapters.
index 373eb02..09ae193 100644 (file)
@@ -2437,11 +2437,15 @@ static void e100_get_drvinfo(struct net_device *netdev,
                sizeof(info->bus_info));
 }
 
-#define E100_PHY_REGS 0x1C
+#define E100_PHY_REGS 0x1D
 static int e100_get_regs_len(struct net_device *netdev)
 {
        struct nic *nic = netdev_priv(netdev);
-       return 1 + E100_PHY_REGS + sizeof(nic->mem->dump_buf);
+
+       /* We know the number of registers, and the size of the dump buffer.
+        * Calculate the total size in bytes.
+        */
+       return (1 + E100_PHY_REGS) * sizeof(u32) + sizeof(nic->mem->dump_buf);
 }
 
 static void e100_get_regs(struct net_device *netdev,
@@ -2455,14 +2459,18 @@ static void e100_get_regs(struct net_device *netdev,
        buff[0] = ioread8(&nic->csr->scb.cmd_hi) << 24 |
                ioread8(&nic->csr->scb.cmd_lo) << 16 |
                ioread16(&nic->csr->scb.status);
-       for (i = E100_PHY_REGS; i >= 0; i--)
-               buff[1 + E100_PHY_REGS - i] =
-                       mdio_read(netdev, nic->mii.phy_id, i);
+       for (i = 0; i < E100_PHY_REGS; i++)
+               /* Note that we read the registers in reverse order. This
+                * ordering is the ABI apparently used by ethtool and other
+                * applications.
+                */
+               buff[1 + i] = mdio_read(netdev, nic->mii.phy_id,
+                                       E100_PHY_REGS - 1 - i);
        memset(nic->mem->dump_buf, 0, sizeof(nic->mem->dump_buf));
        e100_exec_cb(nic, NULL, e100_dump);
        msleep(10);
-       memcpy(&buff[2 + E100_PHY_REGS], nic->mem->dump_buf,
-               sizeof(nic->mem->dump_buf));
+       memcpy(&buff[1 + E100_PHY_REGS], nic->mem->dump_buf,
+              sizeof(nic->mem->dump_buf));
 }
 
 static void e100_get_wol(struct net_device *netdev, struct ethtool_wolinfo *wol)
index 2f20980..e04b540 100644 (file)
@@ -4871,7 +4871,8 @@ static void i40e_clear_interrupt_scheme(struct i40e_pf *pf)
 {
        int i;
 
-       i40e_free_misc_vector(pf);
+       if (test_bit(__I40E_MISC_IRQ_REQUESTED, pf->state))
+               i40e_free_misc_vector(pf);
 
        i40e_put_lump(pf->irq_pile, pf->iwarp_base_vector,
                      I40E_IWARP_IRQ_PILE_ID);
@@ -10113,7 +10114,7 @@ static int i40e_get_capabilities(struct i40e_pf *pf,
                if (pf->hw.aq.asq_last_status == I40E_AQ_RC_ENOMEM) {
                        /* retry with a larger buffer */
                        buf_len = data_size;
-               } else if (pf->hw.aq.asq_last_status != I40E_AQ_RC_OK) {
+               } else if (pf->hw.aq.asq_last_status != I40E_AQ_RC_OK || err) {
                        dev_info(&pf->pdev->dev,
                                 "capability discovery failed, err %s aq_err %s\n",
                                 i40e_stat_str(&pf->hw, err),
index 23762a7..cada4e0 100644 (file)
@@ -1965,7 +1965,6 @@ static void iavf_watchdog_task(struct work_struct *work)
                }
                adapter->aq_required = 0;
                adapter->current_op = VIRTCHNL_OP_UNKNOWN;
-               mutex_unlock(&adapter->crit_lock);
                queue_delayed_work(iavf_wq,
                                   &adapter->watchdog_task,
                                   msecs_to_jiffies(10));
index eadcb99..3c4f08d 100644 (file)
@@ -695,6 +695,7 @@ static inline void ice_set_rdma_cap(struct ice_pf *pf)
 {
        if (pf->hw.func_caps.common_cap.rdma && pf->num_rdma_msix) {
                set_bit(ICE_FLAG_RDMA_ENA, pf->flags);
+               set_bit(ICE_FLAG_AUX_ENA, pf->flags);
                ice_plug_aux_dev(pf);
        }
 }
@@ -707,5 +708,6 @@ static inline void ice_clear_rdma_cap(struct ice_pf *pf)
 {
        ice_unplug_aux_dev(pf);
        clear_bit(ICE_FLAG_RDMA_ENA, pf->flags);
+       clear_bit(ICE_FLAG_AUX_ENA, pf->flags);
 }
 #endif /* _ICE_H_ */
index 1f2afdf..adcc9a2 100644 (file)
@@ -271,6 +271,12 @@ int ice_plug_aux_dev(struct ice_pf *pf)
        struct auxiliary_device *adev;
        int ret;
 
+       /* if this PF doesn't support a technology that requires auxiliary
+        * devices, then gracefully exit
+        */
+       if (!ice_is_aux_ena(pf))
+               return 0;
+
        iadev = kzalloc(sizeof(*iadev), GFP_KERNEL);
        if (!iadev)
                return -ENOMEM;
index 05cc587..80380ae 100644 (file)
@@ -1313,22 +1313,21 @@ ice_ptp_flush_tx_tracker(struct ice_pf *pf, struct ice_ptp_tx *tx)
 {
        u8 idx;
 
-       spin_lock(&tx->lock);
-
        for (idx = 0; idx < tx->len; idx++) {
                u8 phy_idx = idx + tx->quad_offset;
 
-               /* Clear any potential residual timestamp in the PHY block */
-               if (!pf->hw.reset_ongoing)
-                       ice_clear_phy_tstamp(&pf->hw, tx->quad, phy_idx);
-
+               spin_lock(&tx->lock);
                if (tx->tstamps[idx].skb) {
                        dev_kfree_skb_any(tx->tstamps[idx].skb);
                        tx->tstamps[idx].skb = NULL;
                }
-       }
+               clear_bit(idx, tx->in_use);
+               spin_unlock(&tx->lock);
 
-       spin_unlock(&tx->lock);
+               /* Clear any potential residual timestamp in the PHY block */
+               if (!pf->hw.reset_ongoing)
+                       ice_clear_phy_tstamp(&pf->hw, tx->quad, phy_idx);
+       }
 }
 
 /**
index b877efa..0e19b4d 100644 (file)
@@ -6350,7 +6350,9 @@ static int igc_probe(struct pci_dev *pdev,
        if (pci_using_dac)
                netdev->features |= NETIF_F_HIGHDMA;
 
-       netdev->vlan_features |= netdev->features;
+       netdev->vlan_features |= netdev->features | NETIF_F_TSO_MANGLEID;
+       netdev->mpls_features |= NETIF_F_HW_CSUM;
+       netdev->hw_enc_features |= netdev->vlan_features;
 
        /* MTU range: 68 - 9216 */
        netdev->min_mtu = ETH_MIN_MTU;
index fc26e4d..beda8e0 100644 (file)
@@ -3208,7 +3208,7 @@ static unsigned int ixgbe_max_channels(struct ixgbe_adapter *adapter)
                max_combined = ixgbe_max_rss_indices(adapter);
        }
 
-       return max_combined;
+       return min_t(int, max_combined, num_online_cpus());
 }
 
 static void ixgbe_get_channels(struct net_device *dev,
index 24e06ba..13c4782 100644 (file)
@@ -10112,6 +10112,7 @@ static int ixgbe_xdp_setup(struct net_device *dev, struct bpf_prog *prog)
        struct ixgbe_adapter *adapter = netdev_priv(dev);
        struct bpf_prog *old_prog;
        bool need_reset;
+       int num_queues;
 
        if (adapter->flags & IXGBE_FLAG_SRIOV_ENABLED)
                return -EINVAL;
@@ -10161,11 +10162,14 @@ static int ixgbe_xdp_setup(struct net_device *dev, struct bpf_prog *prog)
        /* Kick start the NAPI context if there is an AF_XDP socket open
         * on that queue id. This so that receiving will start.
         */
-       if (need_reset && prog)
-               for (i = 0; i < adapter->num_rx_queues; i++)
+       if (need_reset && prog) {
+               num_queues = min_t(int, adapter->num_rx_queues,
+                                  adapter->num_xdp_queues);
+               for (i = 0; i < num_queues; i++)
                        if (adapter->xdp_ring[i]->xsk_pool)
                                (void)ixgbe_xsk_wakeup(adapter->netdev, i,
                                                       XDP_WAKEUP_RX);
+       }
 
        return 0;
 }
index b5f68f6..7bb1f20 100644 (file)
@@ -186,6 +186,9 @@ mtk_flow_offload_replace(struct mtk_eth *eth, struct flow_cls_offload *f)
        int hash;
        int i;
 
+       if (rhashtable_lookup(&eth->flow_table, &f->cookie, mtk_flow_ht_params))
+               return -EEXIST;
+
        if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_META)) {
                struct flow_match_meta match;
 
index a2f61a8..8af7f28 100644 (file)
@@ -372,6 +372,9 @@ mlx4_en_filter_rfs(struct net_device *net_dev, const struct sk_buff *skb,
        int nhoff = skb_network_offset(skb);
        int ret = 0;
 
+       if (skb->encapsulation)
+               return -EPROTONOSUPPORT;
+
        if (skb->protocol != htons(ETH_P_IP))
                return -EPROTONOSUPPORT;
 
@@ -1269,7 +1272,6 @@ static void mlx4_en_do_set_rx_mode(struct work_struct *work)
        if (!netif_carrier_ok(dev)) {
                if (!mlx4_en_QUERY_PORT(mdev, priv->port)) {
                        if (priv->port_state.link_state) {
-                               priv->last_link_state = MLX4_DEV_EVENT_PORT_UP;
                                netif_carrier_on(dev);
                                en_dbg(LINK, priv, "Link Up\n");
                        }
@@ -1557,26 +1559,36 @@ static void mlx4_en_service_task(struct work_struct *work)
        mutex_unlock(&mdev->state_lock);
 }
 
-static void mlx4_en_linkstate(struct work_struct *work)
+static void mlx4_en_linkstate(struct mlx4_en_priv *priv)
+{
+       struct mlx4_en_port_state *port_state = &priv->port_state;
+       struct mlx4_en_dev *mdev = priv->mdev;
+       struct net_device *dev = priv->dev;
+       bool up;
+
+       if (mlx4_en_QUERY_PORT(mdev, priv->port))
+               port_state->link_state = MLX4_PORT_STATE_DEV_EVENT_PORT_DOWN;
+
+       up = port_state->link_state == MLX4_PORT_STATE_DEV_EVENT_PORT_UP;
+       if (up == netif_carrier_ok(dev))
+               netif_carrier_event(dev);
+       if (!up) {
+               en_info(priv, "Link Down\n");
+               netif_carrier_off(dev);
+       } else {
+               en_info(priv, "Link Up\n");
+               netif_carrier_on(dev);
+       }
+}
+
+static void mlx4_en_linkstate_work(struct work_struct *work)
 {
        struct mlx4_en_priv *priv = container_of(work, struct mlx4_en_priv,
                                                 linkstate_task);
        struct mlx4_en_dev *mdev = priv->mdev;
-       int linkstate = priv->link_state;
 
        mutex_lock(&mdev->state_lock);
-       /* If observable port state changed set carrier state and
-        * report to system log */
-       if (priv->last_link_state != linkstate) {
-               if (linkstate == MLX4_DEV_EVENT_PORT_DOWN) {
-                       en_info(priv, "Link Down\n");
-                       netif_carrier_off(priv->dev);
-               } else {
-                       en_info(priv, "Link Up\n");
-                       netif_carrier_on(priv->dev);
-               }
-       }
-       priv->last_link_state = linkstate;
+       mlx4_en_linkstate(priv);
        mutex_unlock(&mdev->state_lock);
 }
 
@@ -2079,9 +2091,11 @@ static int mlx4_en_open(struct net_device *dev)
        mlx4_en_clear_stats(dev);
 
        err = mlx4_en_start_port(dev);
-       if (err)
+       if (err) {
                en_err(priv, "Failed starting port:%d\n", priv->port);
-
+               goto out;
+       }
+       mlx4_en_linkstate(priv);
 out:
        mutex_unlock(&mdev->state_lock);
        return err;
@@ -3168,7 +3182,7 @@ int mlx4_en_init_netdev(struct mlx4_en_dev *mdev, int port,
        spin_lock_init(&priv->stats_lock);
        INIT_WORK(&priv->rx_mode_task, mlx4_en_do_set_rx_mode);
        INIT_WORK(&priv->restart_task, mlx4_en_restart);
-       INIT_WORK(&priv->linkstate_task, mlx4_en_linkstate);
+       INIT_WORK(&priv->linkstate_task, mlx4_en_linkstate_work);
        INIT_DELAYED_WORK(&priv->stats_task, mlx4_en_do_get_stats);
        INIT_DELAYED_WORK(&priv->service_task, mlx4_en_service_task);
 #ifdef CONFIG_RFS_ACCEL
index f3d1a20..6bf558c 100644 (file)
@@ -552,7 +552,6 @@ struct mlx4_en_priv {
 
        struct mlx4_hwq_resources res;
        int link_state;
-       int last_link_state;
        bool port_up;
        int port;
        int registered;
index cf97985..02e77ff 100644 (file)
@@ -155,6 +155,8 @@ int mlx5_core_destroy_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq)
        u32 in[MLX5_ST_SZ_DW(destroy_cq_in)] = {};
        int err;
 
+       mlx5_debug_cq_remove(dev, cq);
+
        mlx5_eq_del_cq(mlx5_get_async_eq(dev), cq);
        mlx5_eq_del_cq(&cq->eq->core, cq);
 
@@ -162,16 +164,13 @@ int mlx5_core_destroy_cq(struct mlx5_core_dev *dev, struct mlx5_core_cq *cq)
        MLX5_SET(destroy_cq_in, in, cqn, cq->cqn);
        MLX5_SET(destroy_cq_in, in, uid, cq->uid);
        err = mlx5_cmd_exec_in(dev, destroy_cq, in);
-       if (err)
-               return err;
 
        synchronize_irq(cq->irqn);
 
-       mlx5_debug_cq_remove(dev, cq);
        mlx5_cq_put(cq);
        wait_for_completion(&cq->free);
 
-       return 0;
+       return err;
 }
 EXPORT_SYMBOL(mlx5_core_destroy_cq);
 
index e84287f..dcf9f27 100644 (file)
@@ -658,11 +658,10 @@ static const struct devlink_param enable_rdma_param =
 
 static int mlx5_devlink_rdma_param_register(struct devlink *devlink)
 {
-       struct mlx5_core_dev *dev = devlink_priv(devlink);
        union devlink_param_value value;
        int err;
 
-       if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND) || MLX5_ESWITCH_MANAGER(dev))
+       if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND))
                return 0;
 
        err = devlink_param_register(devlink, &enable_rdma_param);
@@ -679,9 +678,7 @@ static int mlx5_devlink_rdma_param_register(struct devlink *devlink)
 
 static void mlx5_devlink_rdma_param_unregister(struct devlink *devlink)
 {
-       struct mlx5_core_dev *dev = devlink_priv(devlink);
-
-       if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND) || MLX5_ESWITCH_MANAGER(dev))
+       if (!IS_ENABLED(CONFIG_MLX5_INFINIBAND))
                return;
 
        devlink_param_unpublish(devlink, &enable_rdma_param);
index 3f8a980..f9cf9fb 100644 (file)
@@ -1007,7 +1007,7 @@ int mlx5_fw_tracer_init(struct mlx5_fw_tracer *tracer)
        err = mlx5_core_alloc_pd(dev, &tracer->buff.pdn);
        if (err) {
                mlx5_core_warn(dev, "FWTracer: Failed to allocate PD %d\n", err);
-               return err;
+               goto err_cancel_work;
        }
 
        err = mlx5_fw_tracer_create_mkey(tracer);
@@ -1031,6 +1031,7 @@ err_notifier_unregister:
        mlx5_core_destroy_mkey(dev, &tracer->buff.mkey);
 err_dealloc_pd:
        mlx5_core_dealloc_pd(dev, tracer->buff.pdn);
+err_cancel_work:
        cancel_work_sync(&tracer->read_fw_strings_work);
        return err;
 }
index 669a75f..03a7a4c 100644 (file)
@@ -252,6 +252,7 @@ struct mlx5e_params {
        struct {
                u16 mode;
                u8 num_tc;
+               struct netdev_tc_txq tc_to_txq[TC_MAX_QUEUE];
        } mqprio;
        bool rx_cqe_compress_def;
        bool tunneled_offload_en;
@@ -845,6 +846,7 @@ struct mlx5e_priv {
        struct mlx5e_channel_stats channel_stats[MLX5E_MAX_NUM_CHANNELS];
        struct mlx5e_channel_stats trap_stats;
        struct mlx5e_ptp_stats     ptp_stats;
+       u16                        stats_nch;
        u16                        max_nch;
        u8                         max_opened_tc;
        bool                       tx_ptp_opened;
@@ -922,7 +924,7 @@ void mlx5e_set_rx_mode_work(struct work_struct *work);
 
 int mlx5e_hwstamp_set(struct mlx5e_priv *priv, struct ifreq *ifr);
 int mlx5e_hwstamp_get(struct mlx5e_priv *priv, struct ifreq *ifr);
-int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool val);
+int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool val, bool rx_filter);
 
 int mlx5e_vlan_rx_add_vid(struct net_device *dev, __always_unused __be16 proto,
                          u16 vid);
@@ -1100,12 +1102,6 @@ int mlx5e_ethtool_set_pauseparam(struct mlx5e_priv *priv,
                                 struct ethtool_pauseparam *pauseparam);
 
 /* mlx5e generic netdev management API */
-static inline unsigned int
-mlx5e_calc_max_nch(struct mlx5e_priv *priv, const struct mlx5e_profile *profile)
-{
-       return priv->netdev->num_rx_queues / max_t(u8, profile->rq_groups, 1);
-}
-
 static inline bool
 mlx5e_tx_mpwqe_supported(struct mlx5_core_dev *mdev)
 {
@@ -1114,11 +1110,13 @@ mlx5e_tx_mpwqe_supported(struct mlx5_core_dev *mdev)
 }
 
 int mlx5e_priv_init(struct mlx5e_priv *priv,
+                   const struct mlx5e_profile *profile,
                    struct net_device *netdev,
                    struct mlx5_core_dev *mdev);
 void mlx5e_priv_cleanup(struct mlx5e_priv *priv);
 struct net_device *
-mlx5e_create_netdev(struct mlx5_core_dev *mdev, unsigned int txqs, unsigned int rxqs);
+mlx5e_create_netdev(struct mlx5_core_dev *mdev, const struct mlx5e_profile *profile,
+                   unsigned int txqs, unsigned int rxqs);
 int mlx5e_attach_netdev(struct mlx5e_priv *priv);
 void mlx5e_detach_netdev(struct mlx5e_priv *priv);
 void mlx5e_destroy_netdev(struct mlx5e_priv *priv);
index ac44bbe..d290d72 100644 (file)
@@ -35,7 +35,7 @@ static void mlx5e_hv_vhca_fill_stats(struct mlx5e_priv *priv, void *data,
 {
        int ch, i = 0;
 
-       for (ch = 0; ch < priv->max_nch; ch++) {
+       for (ch = 0; ch < priv->stats_nch; ch++) {
                void *buf = data + i;
 
                if (WARN_ON_ONCE(buf +
@@ -51,7 +51,7 @@ static void mlx5e_hv_vhca_fill_stats(struct mlx5e_priv *priv, void *data,
 static int mlx5e_hv_vhca_stats_buf_size(struct mlx5e_priv *priv)
 {
        return (sizeof(struct mlx5e_hv_vhca_per_ring_stats) *
-               priv->max_nch);
+               priv->stats_nch);
 }
 
 static void mlx5e_hv_vhca_stats_work(struct work_struct *work)
@@ -100,7 +100,7 @@ static void mlx5e_hv_vhca_stats_control(struct mlx5_hv_vhca_agent *agent,
        sagent = &priv->stats_agent;
 
        block->version = MLX5_HV_VHCA_STATS_VERSION;
-       block->rings   = priv->max_nch;
+       block->rings   = priv->stats_nch;
 
        if (!block->command) {
                cancel_delayed_work_sync(&priv->stats_agent.work);
index ee688de..3a86f66 100644 (file)
@@ -13,8 +13,6 @@ struct mlx5e_ptp_fs {
        bool valid;
 };
 
-#define MLX5E_PTP_CHANNEL_IX 0
-
 struct mlx5e_ptp_params {
        struct mlx5e_params params;
        struct mlx5e_sq_param txq_sq_param;
@@ -509,6 +507,7 @@ static int mlx5e_init_ptp_rq(struct mlx5e_ptp *c, struct mlx5e_params *params,
        rq->mdev         = mdev;
        rq->hw_mtu       = MLX5E_SW2HW_MTU(params, params->sw_mtu);
        rq->stats        = &c->priv->ptp_stats.rq;
+       rq->ix           = MLX5E_PTP_CHANNEL_IX;
        rq->ptp_cyc2time = mlx5_rq_ts_translator(mdev);
        err = mlx5e_rq_set_handlers(rq, params, false);
        if (err)
index c96668b..a71a32e 100644 (file)
@@ -8,6 +8,8 @@
 #include "en_stats.h"
 #include <linux/ptp_classify.h>
 
+#define MLX5E_PTP_CHANNEL_IX 0
+
 struct mlx5e_ptpsq {
        struct mlx5e_txqsq       txqsq;
        struct mlx5e_cq          ts_cq;
index 0c38c2e..c6d2f8c 100644 (file)
@@ -137,7 +137,7 @@ static int mlx5_esw_bridge_port_changeupper(struct notifier_block *nb, void *ptr
        u16 vport_num, esw_owner_vhca_id;
        struct netlink_ext_ack *extack;
        int ifindex = upper->ifindex;
-       int err;
+       int err = 0;
 
        if (!netif_is_bridge_master(upper))
                return 0;
@@ -244,7 +244,7 @@ mlx5_esw_bridge_port_obj_attr_set(struct net_device *dev,
        struct netlink_ext_ack *extack = switchdev_notifier_info_to_extack(&port_attr_info->info);
        const struct switchdev_attr *attr = port_attr_info->attr;
        u16 vport_num, esw_owner_vhca_id;
-       int err;
+       int err = 0;
 
        if (!mlx5_esw_bridge_lower_rep_vport_num_vhca_id_get(dev, br_offloads->esw, &vport_num,
                                                             &esw_owner_vhca_id))
@@ -475,9 +475,6 @@ void mlx5e_rep_bridge_init(struct mlx5e_priv *priv)
                esw_warn(mdev, "Failed to allocate bridge offloads workqueue\n");
                goto err_alloc_wq;
        }
-       INIT_DELAYED_WORK(&br_offloads->update_work, mlx5_esw_bridge_update_work);
-       queue_delayed_work(br_offloads->wq, &br_offloads->update_work,
-                          msecs_to_jiffies(MLX5_ESW_BRIDGE_UPDATE_INTERVAL));
 
        br_offloads->nb.notifier_call = mlx5_esw_bridge_switchdev_event;
        err = register_switchdev_notifier(&br_offloads->nb);
@@ -500,6 +497,9 @@ void mlx5e_rep_bridge_init(struct mlx5e_priv *priv)
                         err);
                goto err_register_netdev;
        }
+       INIT_DELAYED_WORK(&br_offloads->update_work, mlx5_esw_bridge_update_work);
+       queue_delayed_work(br_offloads->wq, &br_offloads->update_work,
+                          msecs_to_jiffies(MLX5_ESW_BRIDGE_UPDATE_INTERVAL));
        return;
 
 err_register_netdev:
@@ -523,10 +523,10 @@ void mlx5e_rep_bridge_cleanup(struct mlx5e_priv *priv)
        if (!br_offloads)
                return;
 
+       cancel_delayed_work_sync(&br_offloads->update_work);
        unregister_netdevice_notifier(&br_offloads->netdev_nb);
        unregister_switchdev_blocking_notifier(&br_offloads->nb_blk);
        unregister_switchdev_notifier(&br_offloads->nb);
-       cancel_delayed_work(&br_offloads->update_work);
        destroy_workqueue(br_offloads->wq);
        rtnl_lock();
        mlx5_esw_bridge_cleanup(esw);
index 51a4d80..de03684 100644 (file)
@@ -300,9 +300,6 @@ mlx5e_rep_indr_block_priv_lookup(struct mlx5e_rep_priv *rpriv,
 {
        struct mlx5e_rep_indr_block_priv *cb_priv;
 
-       /* All callback list access should be protected by RTNL. */
-       ASSERT_RTNL();
-
        list_for_each_entry(cb_priv,
                            &rpriv->uplink_priv.tc_indr_block_priv_list,
                            list)
index bf0313e..13056cb 100644 (file)
@@ -572,7 +572,7 @@ void mlx5e_rx_res_channels_activate(struct mlx5e_rx_res *res, struct mlx5e_chann
        if (res->features & MLX5E_RX_RES_FEATURE_PTP) {
                u32 rqn;
 
-               if (mlx5e_channels_get_ptp_rqn(chs, &rqn))
+               if (!mlx5e_channels_get_ptp_rqn(chs, &rqn))
                        rqn = res->drop_rqn;
 
                err = mlx5e_rqt_redirect_direct(&res->ptp.rqt, rqn);
index 2cfd129..9d451b8 100644 (file)
@@ -1884,7 +1884,7 @@ static int set_pflag_rx_cqe_based_moder(struct net_device *netdev, bool enable)
        return set_pflag_cqe_based_moder(netdev, enable, true);
 }
 
-int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool new_val)
+int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool new_val, bool rx_filter)
 {
        bool curr_val = MLX5E_GET_PFLAG(&priv->channels.params, MLX5E_PFLAG_RX_CQE_COMPRESS);
        struct mlx5e_params new_params;
@@ -1896,8 +1896,7 @@ int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool new_val
        if (curr_val == new_val)
                return 0;
 
-       if (new_val && !priv->profile->rx_ptp_support &&
-           priv->tstamp.rx_filter != HWTSTAMP_FILTER_NONE) {
+       if (new_val && !priv->profile->rx_ptp_support && rx_filter) {
                netdev_err(priv->netdev,
                           "Profile doesn't support enabling of CQE compression while hardware time-stamping is enabled.\n");
                return -EINVAL;
@@ -1905,7 +1904,7 @@ int mlx5e_modify_rx_cqe_compression_locked(struct mlx5e_priv *priv, bool new_val
 
        new_params = priv->channels.params;
        MLX5E_SET_PFLAG(&new_params, MLX5E_PFLAG_RX_CQE_COMPRESS, new_val);
-       if (priv->tstamp.rx_filter != HWTSTAMP_FILTER_NONE)
+       if (rx_filter)
                new_params.ptp_rx = new_val;
 
        if (new_params.ptp_rx == priv->channels.params.ptp_rx)
@@ -1928,12 +1927,14 @@ static int set_pflag_rx_cqe_compress(struct net_device *netdev,
 {
        struct mlx5e_priv *priv = netdev_priv(netdev);
        struct mlx5_core_dev *mdev = priv->mdev;
+       bool rx_filter;
        int err;
 
        if (!MLX5_CAP_GEN(mdev, cqe_compression))
                return -EOPNOTSUPP;
 
-       err = mlx5e_modify_rx_cqe_compression_locked(priv, enable);
+       rx_filter = priv->tstamp.rx_filter != HWTSTAMP_FILTER_NONE;
+       err = mlx5e_modify_rx_cqe_compression_locked(priv, enable, rx_filter);
        if (err)
                return err;
 
@@ -2035,6 +2036,17 @@ static int set_pflag_tx_port_ts(struct net_device *netdev, bool enable)
        }
 
        new_params = priv->channels.params;
+       /* Don't allow enabling TX-port-TS if MQPRIO mode channel  offload is
+        * active, since it defines explicitly which TC accepts the packet.
+        * This conflicts with TX-port-TS hijacking the PTP traffic to a specific
+        * HW TX-queue.
+        */
+       if (enable && new_params.mqprio.mode == TC_MQPRIO_MODE_CHANNEL) {
+               netdev_err(priv->netdev,
+                          "%s: MQPRIO mode channel offload is active, cannot set the TX-port-TS\n",
+                          __func__);
+               return -EINVAL;
+       }
        MLX5E_SET_PFLAG(&new_params, MLX5E_PFLAG_TX_PORT_TS, enable);
        /* No need to verify SQ stop room as
         * ptpsq.txqsq.stop_room <= generic_sq->stop_room, and both
index 47efd85..09c8b71 100644 (file)
@@ -2264,7 +2264,7 @@ void mlx5e_set_netdev_mtu_boundaries(struct mlx5e_priv *priv)
 }
 
 static int mlx5e_netdev_set_tcs(struct net_device *netdev, u16 nch, u8 ntc,
-                               struct tc_mqprio_qopt_offload *mqprio)
+                               struct netdev_tc_txq *tc_to_txq)
 {
        int tc, err;
 
@@ -2282,11 +2282,8 @@ static int mlx5e_netdev_set_tcs(struct net_device *netdev, u16 nch, u8 ntc,
        for (tc = 0; tc < ntc; tc++) {
                u16 count, offset;
 
-               /* For DCB mode, map netdev TCs to offset 0
-                * We have our own UP to TXQ mapping for QoS
-                */
-               count = mqprio ? mqprio->qopt.count[tc] : nch;
-               offset = mqprio ? mqprio->qopt.offset[tc] : 0;
+               count = tc_to_txq[tc].count;
+               offset = tc_to_txq[tc].offset;
                netdev_set_tc_queue(netdev, tc, count, offset);
        }
 
@@ -2315,19 +2312,24 @@ int mlx5e_update_tx_netdev_queues(struct mlx5e_priv *priv)
 
 static int mlx5e_update_netdev_queues(struct mlx5e_priv *priv)
 {
+       struct netdev_tc_txq old_tc_to_txq[TC_MAX_QUEUE], *tc_to_txq;
        struct net_device *netdev = priv->netdev;
        int old_num_txqs, old_ntc;
        int num_rxqs, nch, ntc;
        int err;
+       int i;
 
        old_num_txqs = netdev->real_num_tx_queues;
        old_ntc = netdev->num_tc ? : 1;
+       for (i = 0; i < ARRAY_SIZE(old_tc_to_txq); i++)
+               old_tc_to_txq[i] = netdev->tc_to_txq[i];
 
        nch = priv->channels.params.num_channels;
-       ntc = mlx5e_get_dcb_num_tc(&priv->channels.params);
+       ntc = priv->channels.params.mqprio.num_tc;
        num_rxqs = nch * priv->profile->rq_groups;
+       tc_to_txq = priv->channels.params.mqprio.tc_to_txq;
 
-       err = mlx5e_netdev_set_tcs(netdev, nch, ntc, NULL);
+       err = mlx5e_netdev_set_tcs(netdev, nch, ntc, tc_to_txq);
        if (err)
                goto err_out;
        err = mlx5e_update_tx_netdev_queues(priv);
@@ -2350,11 +2352,14 @@ err_txqs:
        WARN_ON_ONCE(netif_set_real_num_tx_queues(netdev, old_num_txqs));
 
 err_tcs:
-       mlx5e_netdev_set_tcs(netdev, old_num_txqs / old_ntc, old_ntc, NULL);
+       WARN_ON_ONCE(mlx5e_netdev_set_tcs(netdev, old_num_txqs / old_ntc, old_ntc,
+                                         old_tc_to_txq));
 err_out:
        return err;
 }
 
+static MLX5E_DEFINE_PREACTIVATE_WRAPPER_CTX(mlx5e_update_netdev_queues);
+
 static void mlx5e_set_default_xps_cpumasks(struct mlx5e_priv *priv,
                                           struct mlx5e_params *params)
 {
@@ -2861,6 +2866,58 @@ static int mlx5e_modify_channels_vsd(struct mlx5e_channels *chs, bool vsd)
        return 0;
 }
 
+static void mlx5e_mqprio_build_default_tc_to_txq(struct netdev_tc_txq *tc_to_txq,
+                                                int ntc, int nch)
+{
+       int tc;
+
+       memset(tc_to_txq, 0, sizeof(*tc_to_txq) * TC_MAX_QUEUE);
+
+       /* Map netdev TCs to offset 0.
+        * We have our own UP to TXQ mapping for DCB mode of QoS
+        */
+       for (tc = 0; tc < ntc; tc++) {
+               tc_to_txq[tc] = (struct netdev_tc_txq) {
+                       .count = nch,
+                       .offset = 0,
+               };
+       }
+}
+
+static void mlx5e_mqprio_build_tc_to_txq(struct netdev_tc_txq *tc_to_txq,
+                                        struct tc_mqprio_qopt *qopt)
+{
+       int tc;
+
+       for (tc = 0; tc < TC_MAX_QUEUE; tc++) {
+               tc_to_txq[tc] = (struct netdev_tc_txq) {
+                       .count = qopt->count[tc],
+                       .offset = qopt->offset[tc],
+               };
+       }
+}
+
+static void mlx5e_params_mqprio_dcb_set(struct mlx5e_params *params, u8 num_tc)
+{
+       params->mqprio.mode = TC_MQPRIO_MODE_DCB;
+       params->mqprio.num_tc = num_tc;
+       mlx5e_mqprio_build_default_tc_to_txq(params->mqprio.tc_to_txq, num_tc,
+                                            params->num_channels);
+}
+
+static void mlx5e_params_mqprio_channel_set(struct mlx5e_params *params,
+                                           struct tc_mqprio_qopt *qopt)
+{
+       params->mqprio.mode = TC_MQPRIO_MODE_CHANNEL;
+       params->mqprio.num_tc = qopt->num_tc;
+       mlx5e_mqprio_build_tc_to_txq(params->mqprio.tc_to_txq, qopt);
+}
+
+static void mlx5e_params_mqprio_reset(struct mlx5e_params *params)
+{
+       mlx5e_params_mqprio_dcb_set(params, 1);
+}
+
 static int mlx5e_setup_tc_mqprio_dcb(struct mlx5e_priv *priv,
                                     struct tc_mqprio_qopt *mqprio)
 {
@@ -2874,8 +2931,7 @@ static int mlx5e_setup_tc_mqprio_dcb(struct mlx5e_priv *priv,
                return -EINVAL;
 
        new_params = priv->channels.params;
-       new_params.mqprio.mode = TC_MQPRIO_MODE_DCB;
-       new_params.mqprio.num_tc = tc ? tc : 1;
+       mlx5e_params_mqprio_dcb_set(&new_params, tc ? tc : 1);
 
        err = mlx5e_safe_switch_params(priv, &new_params,
                                       mlx5e_num_channels_changed_ctx, NULL, true);
@@ -2889,9 +2945,17 @@ static int mlx5e_mqprio_channel_validate(struct mlx5e_priv *priv,
                                         struct tc_mqprio_qopt_offload *mqprio)
 {
        struct net_device *netdev = priv->netdev;
+       struct mlx5e_ptp *ptp_channel;
        int agg_count = 0;
        int i;
 
+       ptp_channel = priv->channels.ptp;
+       if (ptp_channel && test_bit(MLX5E_PTP_STATE_TX, ptp_channel->state)) {
+               netdev_err(netdev,
+                          "Cannot activate MQPRIO mode channel since it conflicts with TX port TS\n");
+               return -EINVAL;
+       }
+
        if (mqprio->qopt.offset[0] != 0 || mqprio->qopt.num_tc < 1 ||
            mqprio->qopt.num_tc > MLX5E_MAX_NUM_MQPRIO_CH_TC)
                return -EINVAL;
@@ -2917,8 +2981,8 @@ static int mlx5e_mqprio_channel_validate(struct mlx5e_priv *priv,
                agg_count += mqprio->qopt.count[i];
        }
 
-       if (priv->channels.params.num_channels < agg_count) {
-               netdev_err(netdev, "Num of queues (%d) exceeds available (%d)\n",
+       if (priv->channels.params.num_channels != agg_count) {
+               netdev_err(netdev, "Num of queues (%d) does not match available (%d)\n",
                           agg_count, priv->channels.params.num_channels);
                return -EINVAL;
        }
@@ -2926,25 +2990,12 @@ static int mlx5e_mqprio_channel_validate(struct mlx5e_priv *priv,
        return 0;
 }
 
-static int mlx5e_mqprio_channel_set_tcs_ctx(struct mlx5e_priv *priv, void *ctx)
-{
-       struct tc_mqprio_qopt_offload *mqprio = (struct tc_mqprio_qopt_offload *)ctx;
-       struct net_device *netdev = priv->netdev;
-       u8 num_tc;
-
-       if (priv->channels.params.mqprio.mode != TC_MQPRIO_MODE_CHANNEL)
-               return -EINVAL;
-
-       num_tc = priv->channels.params.mqprio.num_tc;
-       mlx5e_netdev_set_tcs(netdev, 0, num_tc, mqprio);
-
-       return 0;
-}
-
 static int mlx5e_setup_tc_mqprio_channel(struct mlx5e_priv *priv,
                                         struct tc_mqprio_qopt_offload *mqprio)
 {
+       mlx5e_fp_preactivate preactivate;
        struct mlx5e_params new_params;
+       bool nch_changed;
        int err;
 
        err = mlx5e_mqprio_channel_validate(priv, mqprio);
@@ -2952,12 +3003,12 @@ static int mlx5e_setup_tc_mqprio_channel(struct mlx5e_priv *priv,
                return err;
 
        new_params = priv->channels.params;
-       new_params.mqprio.mode = TC_MQPRIO_MODE_CHANNEL;
-       new_params.mqprio.num_tc = mqprio->qopt.num_tc;
-       err = mlx5e_safe_switch_params(priv, &new_params,
-                                      mlx5e_mqprio_channel_set_tcs_ctx, mqprio, true);
+       mlx5e_params_mqprio_channel_set(&new_params, &mqprio->qopt);
 
-       return err;
+       nch_changed = mlx5e_get_dcb_num_tc(&priv->channels.params) > 1;
+       preactivate = nch_changed ? mlx5e_num_channels_changed_ctx :
+               mlx5e_update_netdev_queues_ctx;
+       return mlx5e_safe_switch_params(priv, &new_params, preactivate, NULL, true);
 }
 
 static int mlx5e_setup_tc_mqprio(struct mlx5e_priv *priv,
@@ -3065,7 +3116,7 @@ void mlx5e_fold_sw_stats64(struct mlx5e_priv *priv, struct rtnl_link_stats64 *s)
 {
        int i;
 
-       for (i = 0; i < priv->max_nch; i++) {
+       for (i = 0; i < priv->stats_nch; i++) {
                struct mlx5e_channel_stats *channel_stats = &priv->channel_stats[i];
                struct mlx5e_rq_stats *xskrq_stats = &channel_stats->xskrq;
                struct mlx5e_rq_stats *rq_stats = &channel_stats->rq;
@@ -3274,20 +3325,67 @@ static int set_feature_rx_all(struct net_device *netdev, bool enable)
        return mlx5_set_port_fcs(mdev, !enable);
 }
 
+static int mlx5e_set_rx_port_ts(struct mlx5_core_dev *mdev, bool enable)
+{
+       u32 in[MLX5_ST_SZ_DW(pcmr_reg)] = {};
+       bool supported, curr_state;
+       int err;
+
+       if (!MLX5_CAP_GEN(mdev, ports_check))
+               return 0;
+
+       err = mlx5_query_ports_check(mdev, in, sizeof(in));
+       if (err)
+               return err;
+
+       supported = MLX5_GET(pcmr_reg, in, rx_ts_over_crc_cap);
+       curr_state = MLX5_GET(pcmr_reg, in, rx_ts_over_crc);
+
+       if (!supported || enable == curr_state)
+               return 0;
+
+       MLX5_SET(pcmr_reg, in, local_port, 1);
+       MLX5_SET(pcmr_reg, in, rx_ts_over_crc, enable);
+
+       return mlx5_set_ports_check(mdev, in, sizeof(in));
+}
+
 static int set_feature_rx_fcs(struct net_device *netdev, bool enable)
 {
        struct mlx5e_priv *priv = netdev_priv(netdev);
+       struct mlx5e_channels *chs = &priv->channels;
+       struct mlx5_core_dev *mdev = priv->mdev;
        int err;
 
        mutex_lock(&priv->state_lock);
 
-       priv->channels.params.scatter_fcs_en = enable;
-       err = mlx5e_modify_channels_scatter_fcs(&priv->channels, enable);
-       if (err)
-               priv->channels.params.scatter_fcs_en = !enable;
+       if (enable) {
+               err = mlx5e_set_rx_port_ts(mdev, false);
+               if (err)
+                       goto out;
 
-       mutex_unlock(&priv->state_lock);
+               chs->params.scatter_fcs_en = true;
+               err = mlx5e_modify_channels_scatter_fcs(chs, true);
+               if (err) {
+                       chs->params.scatter_fcs_en = false;
+                       mlx5e_set_rx_port_ts(mdev, true);
+               }
+       } else {
+               chs->params.scatter_fcs_en = false;
+               err = mlx5e_modify_channels_scatter_fcs(chs, false);
+               if (err) {
+                       chs->params.scatter_fcs_en = true;
+                       goto out;
+               }
+               err = mlx5e_set_rx_port_ts(mdev, true);
+               if (err) {
+                       mlx5_core_warn(mdev, "Failed to set RX port timestamp %d\n", err);
+                       err = 0;
+               }
+       }
 
+out:
+       mutex_unlock(&priv->state_lock);
        return err;
 }
 
@@ -3554,14 +3652,14 @@ static int mlx5e_hwstamp_config_no_ptp_rx(struct mlx5e_priv *priv, bool rx_filte
 
        if (!rx_filter)
                /* Reset CQE compression to Admin default */
-               return mlx5e_modify_rx_cqe_compression_locked(priv, rx_cqe_compress_def);
+               return mlx5e_modify_rx_cqe_compression_locked(priv, rx_cqe_compress_def, false);
 
        if (!MLX5E_GET_PFLAG(&priv->channels.params, MLX5E_PFLAG_RX_CQE_COMPRESS))
                return 0;
 
        /* Disable CQE compression */
        netdev_warn(priv->netdev, "Disabling RX cqe compression\n");
-       err = mlx5e_modify_rx_cqe_compression_locked(priv, false);
+       err = mlx5e_modify_rx_cqe_compression_locked(priv, false, true);
        if (err)
                netdev_err(priv->netdev, "Failed disabling cqe compression err=%d\n", err);
 
@@ -4186,13 +4284,11 @@ void mlx5e_build_nic_params(struct mlx5e_priv *priv, struct mlx5e_xsk *xsk, u16
        struct mlx5_core_dev *mdev = priv->mdev;
        u8 rx_cq_period_mode;
 
-       priv->max_nch = mlx5e_calc_max_nch(priv, priv->profile);
-
        params->sw_mtu = mtu;
        params->hard_mtu = MLX5E_ETH_HARD_MTU;
        params->num_channels = min_t(unsigned int, MLX5E_MAX_NUM_CHANNELS / 2,
                                     priv->max_nch);
-       params->mqprio.num_tc = 1;
+       mlx5e_params_mqprio_reset(params);
 
        /* Set an initial non-zero value, so that mlx5e_select_queue won't
         * divide by zero if called before first activating channels.
@@ -4682,8 +4778,35 @@ static const struct mlx5e_profile mlx5e_nic_profile = {
        .rx_ptp_support    = true,
 };
 
+static unsigned int
+mlx5e_calc_max_nch(struct mlx5_core_dev *mdev, struct net_device *netdev,
+                  const struct mlx5e_profile *profile)
+
+{
+       unsigned int max_nch, tmp;
+
+       /* core resources */
+       max_nch = mlx5e_get_max_num_channels(mdev);
+
+       /* netdev rx queues */
+       tmp = netdev->num_rx_queues / max_t(u8, profile->rq_groups, 1);
+       max_nch = min_t(unsigned int, max_nch, tmp);
+
+       /* netdev tx queues */
+       tmp = netdev->num_tx_queues;
+       if (mlx5_qos_is_supported(mdev))
+               tmp -= mlx5e_qos_max_leaf_nodes(mdev);
+       if (MLX5_CAP_GEN(mdev, ts_cqe_to_dest_cqn))
+               tmp -= profile->max_tc;
+       tmp = tmp / profile->max_tc;
+       max_nch = min_t(unsigned int, max_nch, tmp);
+
+       return max_nch;
+}
+
 /* mlx5e generic netdev management API (move to en_common.c) */
 int mlx5e_priv_init(struct mlx5e_priv *priv,
+                   const struct mlx5e_profile *profile,
                    struct net_device *netdev,
                    struct mlx5_core_dev *mdev)
 {
@@ -4691,6 +4814,8 @@ int mlx5e_priv_init(struct mlx5e_priv *priv,
        priv->mdev        = mdev;
        priv->netdev      = netdev;
        priv->msglevel    = MLX5E_MSG_LEVEL;
+       priv->max_nch     = mlx5e_calc_max_nch(mdev, netdev, profile);
+       priv->stats_nch   = priv->max_nch;
        priv->max_opened_tc = 1;
 
        if (!alloc_cpumask_var(&priv->scratchpad.cpumask, GFP_KERNEL))
@@ -4734,7 +4859,8 @@ void mlx5e_priv_cleanup(struct mlx5e_priv *priv)
 }
 
 struct net_device *
-mlx5e_create_netdev(struct mlx5_core_dev *mdev, unsigned int txqs, unsigned int rxqs)
+mlx5e_create_netdev(struct mlx5_core_dev *mdev, const struct mlx5e_profile *profile,
+                   unsigned int txqs, unsigned int rxqs)
 {
        struct net_device *netdev;
        int err;
@@ -4745,7 +4871,7 @@ mlx5e_create_netdev(struct mlx5_core_dev *mdev, unsigned int txqs, unsigned int
                return NULL;
        }
 
-       err = mlx5e_priv_init(netdev_priv(netdev), netdev, mdev);
+       err = mlx5e_priv_init(netdev_priv(netdev), profile, netdev, mdev);
        if (err) {
                mlx5_core_err(mdev, "mlx5e_priv_init failed, err=%d\n", err);
                goto err_free_netdev;
@@ -4787,7 +4913,7 @@ int mlx5e_attach_netdev(struct mlx5e_priv *priv)
        clear_bit(MLX5E_STATE_DESTROYING, &priv->state);
 
        /* max number of channels may have changed */
-       max_nch = mlx5e_get_max_num_channels(priv->mdev);
+       max_nch = mlx5e_calc_max_nch(priv->mdev, priv->netdev, profile);
        if (priv->channels.params.num_channels > max_nch) {
                mlx5_core_warn(priv->mdev, "MLX5E: Reducing number of channels to %d\n", max_nch);
                /* Reducing the number of channels - RXFH has to be reset, and
@@ -4795,7 +4921,18 @@ int mlx5e_attach_netdev(struct mlx5e_priv *priv)
                 */
                priv->netdev->priv_flags &= ~IFF_RXFH_CONFIGURED;
                priv->channels.params.num_channels = max_nch;
+               if (priv->channels.params.mqprio.mode == TC_MQPRIO_MODE_CHANNEL) {
+                       mlx5_core_warn(priv->mdev, "MLX5E: Disabling MQPRIO channel mode\n");
+                       mlx5e_params_mqprio_reset(&priv->channels.params);
+               }
        }
+       if (max_nch != priv->max_nch) {
+               mlx5_core_warn(priv->mdev,
+                              "MLX5E: Updating max number of channels from %u to %u\n",
+                              priv->max_nch, max_nch);
+               priv->max_nch = max_nch;
+       }
+
        /* 1. Set the real number of queues in the kernel the first time.
         * 2. Set our default XPS cpumask.
         * 3. Build the RQT.
@@ -4860,7 +4997,7 @@ mlx5e_netdev_attach_profile(struct net_device *netdev, struct mlx5_core_dev *mde
        struct mlx5e_priv *priv = netdev_priv(netdev);
        int err;
 
-       err = mlx5e_priv_init(priv, netdev, mdev);
+       err = mlx5e_priv_init(priv, new_profile, netdev, mdev);
        if (err) {
                mlx5_core_err(mdev, "mlx5e_priv_init failed, err=%d\n", err);
                return err;
@@ -4886,20 +5023,12 @@ priv_cleanup:
 int mlx5e_netdev_change_profile(struct mlx5e_priv *priv,
                                const struct mlx5e_profile *new_profile, void *new_ppriv)
 {
-       unsigned int new_max_nch = mlx5e_calc_max_nch(priv, new_profile);
        const struct mlx5e_profile *orig_profile = priv->profile;
        struct net_device *netdev = priv->netdev;
        struct mlx5_core_dev *mdev = priv->mdev;
        void *orig_ppriv = priv->ppriv;
        int err, rollback_err;
 
-       /* sanity */
-       if (new_max_nch != priv->max_nch) {
-               netdev_warn(netdev, "%s: Replacing profile with different max channels\n",
-                           __func__);
-               return -EINVAL;
-       }
-
        /* cleanup old profile */
        mlx5e_detach_netdev(priv);
        priv->profile->cleanup(priv);
@@ -4995,7 +5124,7 @@ static int mlx5e_probe(struct auxiliary_device *adev,
        nch = mlx5e_get_max_num_channels(mdev);
        txqs = nch * profile->max_tc + ptp_txqs + qos_sqs;
        rxqs = nch * profile->rq_groups;
-       netdev = mlx5e_create_netdev(mdev, txqs, rxqs);
+       netdev = mlx5e_create_netdev(mdev, profile, txqs, rxqs);
        if (!netdev) {
                mlx5_core_err(mdev, "mlx5e_create_netdev failed\n");
                return -ENOMEM;
index ae71a17..0684ac6 100644 (file)
@@ -596,7 +596,6 @@ static void mlx5e_build_rep_params(struct net_device *netdev)
                                         MLX5_CQ_PERIOD_MODE_START_FROM_CQE :
                                         MLX5_CQ_PERIOD_MODE_START_FROM_EQE;
 
-       priv->max_nch = mlx5e_calc_max_nch(priv, priv->profile);
        params = &priv->channels.params;
 
        params->num_channels = MLX5E_REP_PARAMS_DEF_NUM_CHANNELS;
@@ -619,6 +618,11 @@ static void mlx5e_build_rep_params(struct net_device *netdev)
        params->mqprio.num_tc       = 1;
        params->tunneled_offload_en = false;
 
+       /* Set an initial non-zero value, so that mlx5e_select_queue won't
+        * divide by zero if called before first activating channels.
+        */
+       priv->num_tc_x_num_ch = params->num_channels * params->mqprio.num_tc;
+
        mlx5_query_min_inline(mdev, &params->tx_min_inline_mode);
 }
 
@@ -644,7 +648,6 @@ static void mlx5e_build_rep_netdev(struct net_device *netdev,
        netdev->hw_features    |= NETIF_F_RXCSUM;
 
        netdev->features |= netdev->hw_features;
-       netdev->features |= NETIF_F_VLAN_CHALLENGED;
        netdev->features |= NETIF_F_NETNS_LOCAL;
 }
 
@@ -1169,7 +1172,7 @@ mlx5e_vport_vf_rep_load(struct mlx5_core_dev *dev, struct mlx5_eswitch_rep *rep)
        nch = mlx5e_get_max_num_channels(dev);
        txqs = nch * profile->max_tc;
        rxqs = nch * profile->rq_groups;
-       netdev = mlx5e_create_netdev(dev, txqs, rxqs);
+       netdev = mlx5e_create_netdev(dev, profile, txqs, rxqs);
        if (!netdev) {
                mlx5_core_warn(dev,
                               "Failed to create representor netdev for vport %d\n",
index 3c65fd0..29a6586 100644 (file)
@@ -1001,14 +1001,9 @@ static inline void mlx5e_handle_csum(struct net_device *netdev,
                goto csum_unnecessary;
 
        if (likely(is_last_ethertype_ip(skb, &network_depth, &proto))) {
-               u8 ipproto = get_ip_proto(skb, network_depth, proto);
-
-               if (unlikely(ipproto == IPPROTO_SCTP))
+               if (unlikely(get_ip_proto(skb, network_depth, proto) == IPPROTO_SCTP))
                        goto csum_unnecessary;
 
-               if (unlikely(mlx5_ipsec_is_rx_flow(cqe)))
-                       goto csum_none;
-
                stats->csum_complete++;
                skb->ip_summed = CHECKSUM_COMPLETE;
                skb->csum = csum_unfold((__force __sum16)cqe->check_sum);
index e4f5b63..e1dd170 100644 (file)
@@ -34,6 +34,7 @@
 #include "en.h"
 #include "en_accel/tls.h"
 #include "en_accel/en_accel.h"
+#include "en/ptp.h"
 
 static unsigned int stats_grps_num(struct mlx5e_priv *priv)
 {
@@ -450,7 +451,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(sw)
 
        memset(s, 0, sizeof(*s));
 
-       for (i = 0; i < priv->max_nch; i++) {
+       for (i = 0; i < priv->stats_nch; i++) {
                struct mlx5e_channel_stats *channel_stats =
                        &priv->channel_stats[i];
                int j;
@@ -2076,7 +2077,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STRS(ptp)
        if (priv->rx_ptp_opened) {
                for (i = 0; i < NUM_PTP_RQ_STATS; i++)
                        sprintf(data + (idx++) * ETH_GSTRING_LEN,
-                               ptp_rq_stats_desc[i].format);
+                               ptp_rq_stats_desc[i].format, MLX5E_PTP_CHANNEL_IX);
        }
        return idx;
 }
@@ -2119,7 +2120,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_UPDATE_STATS(ptp) { return; }
 
 static MLX5E_DECLARE_STATS_GRP_OP_NUM_STATS(channels)
 {
-       int max_nch = priv->max_nch;
+       int max_nch = priv->stats_nch;
 
        return (NUM_RQ_STATS * max_nch) +
               (NUM_CH_STATS * max_nch) +
@@ -2133,7 +2134,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_NUM_STATS(channels)
 static MLX5E_DECLARE_STATS_GRP_OP_FILL_STRS(channels)
 {
        bool is_xsk = priv->xsk.ever_used;
-       int max_nch = priv->max_nch;
+       int max_nch = priv->stats_nch;
        int i, j, tc;
 
        for (i = 0; i < max_nch; i++)
@@ -2175,7 +2176,7 @@ static MLX5E_DECLARE_STATS_GRP_OP_FILL_STRS(channels)
 static MLX5E_DECLARE_STATS_GRP_OP_FILL_STATS(channels)
 {
        bool is_xsk = priv->xsk.ever_used;
-       int max_nch = priv->max_nch;
+       int max_nch = priv->stats_nch;
        int i, j, tc;
 
        for (i = 0; i < max_nch; i++)
index 0399a39..60a7399 100644 (file)
@@ -79,12 +79,16 @@ int esw_acl_egress_lgcy_setup(struct mlx5_eswitch *esw,
        int dest_num = 0;
        int err = 0;
 
-       if (MLX5_CAP_ESW_EGRESS_ACL(esw->dev, flow_counter)) {
+       if (vport->egress.legacy.drop_counter) {
+               drop_counter = vport->egress.legacy.drop_counter;
+       } else if (MLX5_CAP_ESW_EGRESS_ACL(esw->dev, flow_counter)) {
                drop_counter = mlx5_fc_create(esw->dev, false);
-               if (IS_ERR(drop_counter))
+               if (IS_ERR(drop_counter)) {
                        esw_warn(esw->dev,
                                 "vport[%d] configure egress drop rule counter err(%ld)\n",
                                 vport->vport, PTR_ERR(drop_counter));
+                       drop_counter = NULL;
+               }
                vport->egress.legacy.drop_counter = drop_counter;
        }
 
@@ -123,7 +127,7 @@ int esw_acl_egress_lgcy_setup(struct mlx5_eswitch *esw,
        flow_act.action = MLX5_FLOW_CONTEXT_ACTION_DROP;
 
        /* Attach egress drop flow counter */
-       if (!IS_ERR_OR_NULL(drop_counter)) {
+       if (drop_counter) {
                flow_act.action |= MLX5_FLOW_CONTEXT_ACTION_COUNT;
                drop_ctr_dst.type = MLX5_FLOW_DESTINATION_TYPE_COUNTER;
                drop_ctr_dst.counter_id = mlx5_fc_id(drop_counter);
@@ -162,7 +166,7 @@ void esw_acl_egress_lgcy_cleanup(struct mlx5_eswitch *esw,
        esw_acl_egress_table_destroy(vport);
 
 clean_drop_counter:
-       if (!IS_ERR_OR_NULL(vport->egress.legacy.drop_counter)) {
+       if (vport->egress.legacy.drop_counter) {
                mlx5_fc_destroy(esw->dev, vport->egress.legacy.drop_counter);
                vport->egress.legacy.drop_counter = NULL;
        }
index f75b86a..b1a5199 100644 (file)
@@ -160,7 +160,9 @@ int esw_acl_ingress_lgcy_setup(struct mlx5_eswitch *esw,
 
        esw_acl_ingress_lgcy_rules_destroy(vport);
 
-       if (MLX5_CAP_ESW_INGRESS_ACL(esw->dev, flow_counter)) {
+       if (vport->ingress.legacy.drop_counter) {
+               counter = vport->ingress.legacy.drop_counter;
+       } else if (MLX5_CAP_ESW_INGRESS_ACL(esw->dev, flow_counter)) {
                counter = mlx5_fc_create(esw->dev, false);
                if (IS_ERR(counter)) {
                        esw_warn(esw->dev,
index 9fe8e3c..fe501ba 100644 (file)
@@ -1682,14 +1682,13 @@ static int build_match_list(struct match_list *match_head,
 
                curr_match = kmalloc(sizeof(*curr_match), GFP_ATOMIC);
                if (!curr_match) {
+                       rcu_read_unlock();
                        free_match_list(match_head, ft_locked);
-                       err = -ENOMEM;
-                       goto out;
+                       return -ENOMEM;
                }
                curr_match->g = g;
                list_add_tail(&curr_match->list, &match_head->list);
        }
-out:
        rcu_read_unlock();
        return err;
 }
index 67571e5..269ebb5 100644 (file)
@@ -113,7 +113,7 @@ static void mlx5i_grp_sw_update_stats(struct mlx5e_priv *priv)
        struct mlx5e_sw_stats s = { 0 };
        int i, j;
 
-       for (i = 0; i < priv->max_nch; i++) {
+       for (i = 0; i < priv->stats_nch; i++) {
                struct mlx5e_channel_stats *channel_stats;
                struct mlx5e_rq_stats *rq_stats;
 
@@ -711,7 +711,7 @@ static int mlx5_rdma_setup_rn(struct ib_device *ibdev, u32 port_num,
                        goto destroy_ht;
        }
 
-       err = mlx5e_priv_init(epriv, netdev, mdev);
+       err = mlx5e_priv_init(epriv, prof, netdev, mdev);
        if (err)
                goto destroy_mdev_resources;
 
index 49ca57c..ca5690b 100644 (file)
@@ -927,9 +927,12 @@ void mlx5_lag_disable_change(struct mlx5_core_dev *dev)
        struct mlx5_core_dev *dev1;
        struct mlx5_lag *ldev;
 
+       ldev = mlx5_lag_dev(dev);
+       if (!ldev)
+               return;
+
        mlx5_dev_list_lock();
 
-       ldev = mlx5_lag_dev(dev);
        dev0 = ldev->pf[MLX5_LAG_P1].dev;
        dev1 = ldev->pf[MLX5_LAG_P2].dev;
 
@@ -946,8 +949,11 @@ void mlx5_lag_enable_change(struct mlx5_core_dev *dev)
 {
        struct mlx5_lag *ldev;
 
-       mlx5_dev_list_lock();
        ldev = mlx5_lag_dev(dev);
+       if (!ldev)
+               return;
+
+       mlx5_dev_list_lock();
        ldev->mode_changes_in_progress--;
        mlx5_dev_list_unlock();
        mlx5_queue_bond_work(ldev, 0);
index ffac8a0..91e806c 100644 (file)
@@ -448,22 +448,20 @@ static u64 find_target_cycles(struct mlx5_core_dev *mdev, s64 target_ns)
        return cycles_now + cycles_delta;
 }
 
-static u64 perout_conf_internal_timer(struct mlx5_core_dev *mdev,
-                                     s64 sec, u32 nsec)
+static u64 perout_conf_internal_timer(struct mlx5_core_dev *mdev, s64 sec)
 {
-       struct timespec64 ts;
+       struct timespec64 ts = {};
        s64 target_ns;
 
        ts.tv_sec = sec;
-       ts.tv_nsec = nsec;
        target_ns = timespec64_to_ns(&ts);
 
        return find_target_cycles(mdev, target_ns);
 }
 
-static u64 perout_conf_real_time(s64 sec, u32 nsec)
+static u64 perout_conf_real_time(s64 sec)
 {
-       return (u64)nsec | (u64)sec << 32;
+       return (u64)sec << 32;
 }
 
 static int mlx5_perout_configure(struct ptp_clock_info *ptp,
@@ -474,6 +472,7 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,
                        container_of(ptp, struct mlx5_clock, ptp_info);
        struct mlx5_core_dev *mdev =
                        container_of(clock, struct mlx5_core_dev, clock);
+       bool rt_mode = mlx5_real_time_mode(mdev);
        u32 in[MLX5_ST_SZ_DW(mtpps_reg)] = {0};
        struct timespec64 ts;
        u32 field_select = 0;
@@ -501,8 +500,10 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,
 
        if (on) {
                bool rt_mode = mlx5_real_time_mode(mdev);
-               u32 nsec;
-               s64 sec;
+               s64 sec = rq->perout.start.sec;
+
+               if (rq->perout.start.nsec)
+                       return -EINVAL;
 
                pin_mode = MLX5_PIN_MODE_OUT;
                pattern = MLX5_OUT_PATTERN_PERIODIC;
@@ -513,14 +514,11 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,
                if ((ns >> 1) != 500000000LL)
                        return -EINVAL;
 
-               nsec = rq->perout.start.nsec;
-               sec = rq->perout.start.sec;
-
                if (rt_mode && sec > U32_MAX)
                        return -EINVAL;
 
-               time_stamp = rt_mode ? perout_conf_real_time(sec, nsec) :
-                                      perout_conf_internal_timer(mdev, sec, nsec);
+               time_stamp = rt_mode ? perout_conf_real_time(sec) :
+                                      perout_conf_internal_timer(mdev, sec);
 
                field_select |= MLX5_MTPPS_FS_PIN_MODE |
                                MLX5_MTPPS_FS_PATTERN |
@@ -538,6 +536,9 @@ static int mlx5_perout_configure(struct ptp_clock_info *ptp,
        if (err)
                return err;
 
+       if (rt_mode)
+               return 0;
+
        return mlx5_set_mtppse(mdev, pin, 0,
                               MLX5_EVENT_MODE_REPETETIVE & on);
 }
@@ -705,20 +706,14 @@ static void ts_next_sec(struct timespec64 *ts)
 static u64 perout_conf_next_event_timer(struct mlx5_core_dev *mdev,
                                        struct mlx5_clock *clock)
 {
-       bool rt_mode = mlx5_real_time_mode(mdev);
        struct timespec64 ts;
        s64 target_ns;
 
-       if (rt_mode)
-               ts = mlx5_ptp_gettimex_real_time(mdev, NULL);
-       else
-               mlx5_ptp_gettimex(&clock->ptp_info, &ts, NULL);
-
+       mlx5_ptp_gettimex(&clock->ptp_info, &ts, NULL);
        ts_next_sec(&ts);
        target_ns = timespec64_to_ns(&ts);
 
-       return rt_mode ? perout_conf_real_time(ts.tv_sec, ts.tv_nsec) :
-                        find_target_cycles(mdev, target_ns);
+       return find_target_cycles(mdev, target_ns);
 }
 
 static int mlx5_pps_event(struct notifier_block *nb,
index c79a10b..763c83a 100644 (file)
@@ -13,8 +13,8 @@
 #endif
 
 #define MLX5_MAX_IRQ_NAME (32)
-/* max irq_index is 255. three chars */
-#define MLX5_MAX_IRQ_IDX_CHARS (3)
+/* max irq_index is 2047, so four chars */
+#define MLX5_MAX_IRQ_IDX_CHARS (4)
 
 #define MLX5_SFS_PER_CTRL_IRQ 64
 #define MLX5_IRQ_CTRL_SF_MAX 8
@@ -633,8 +633,9 @@ void mlx5_irq_table_destroy(struct mlx5_core_dev *dev)
 int mlx5_irq_table_get_sfs_vec(struct mlx5_irq_table *table)
 {
        if (table->sf_comp_pool)
-               return table->sf_comp_pool->xa_num_irqs.max -
-                       table->sf_comp_pool->xa_num_irqs.min + 1;
+               return min_t(int, num_online_cpus(),
+                            table->sf_comp_pool->xa_num_irqs.max -
+                            table->sf_comp_pool->xa_num_irqs.min + 1);
        else
                return mlx5_irq_table_get_num_comp(table);
 }
index 3e85b17..6704f5c 100644 (file)
@@ -142,6 +142,13 @@ static int mlxbf_gige_open(struct net_device *netdev)
        err = mlxbf_gige_clean_port(priv);
        if (err)
                goto free_irqs;
+
+       /* Clear driver's valid_polarity to match hardware,
+        * since the above call to clean_port() resets the
+        * receive polarity used by hardware.
+        */
+       priv->valid_polarity = 0;
+
        err = mlxbf_gige_rx_init(priv);
        if (err)
                goto free_irqs;
index 0998dcc..b298244 100644 (file)
 #define MLXSW_THERMAL_ZONE_MAX_NAME    16
 #define MLXSW_THERMAL_TEMP_SCORE_MAX   GENMASK(31, 0)
 #define MLXSW_THERMAL_MAX_STATE        10
+#define MLXSW_THERMAL_MIN_STATE        2
 #define MLXSW_THERMAL_MAX_DUTY 255
-/* Minimum and maximum fan allowed speed in percent: from 20% to 100%. Values
- * MLXSW_THERMAL_MAX_STATE + x, where x is between 2 and 10 are used for
- * setting fan speed dynamic minimum. For example, if value is set to 14 (40%)
- * cooling levels vector will be set to 4, 4, 4, 4, 4, 5, 6, 7, 8, 9, 10 to
- * introduce PWM speed in percent: 40, 40, 40, 40, 40, 50, 60. 70, 80, 90, 100.
- */
-#define MLXSW_THERMAL_SPEED_MIN                (MLXSW_THERMAL_MAX_STATE + 2)
-#define MLXSW_THERMAL_SPEED_MAX                (MLXSW_THERMAL_MAX_STATE * 2)
-#define MLXSW_THERMAL_SPEED_MIN_LEVEL  2               /* 20% */
 
 /* External cooling devices, allowed for binding to mlxsw thermal zones. */
 static char * const mlxsw_thermal_external_allowed_cdev[] = {
@@ -646,49 +638,16 @@ static int mlxsw_thermal_set_cur_state(struct thermal_cooling_device *cdev,
        struct mlxsw_thermal *thermal = cdev->devdata;
        struct device *dev = thermal->bus_info->dev;
        char mfsc_pl[MLXSW_REG_MFSC_LEN];
-       unsigned long cur_state, i;
        int idx;
-       u8 duty;
        int err;
 
+       if (state > MLXSW_THERMAL_MAX_STATE)
+               return -EINVAL;
+
        idx = mlxsw_get_cooling_device_idx(thermal, cdev);
        if (idx < 0)
                return idx;
 
-       /* Verify if this request is for changing allowed fan dynamical
-        * minimum. If it is - update cooling levels accordingly and update
-        * state, if current state is below the newly requested minimum state.
-        * For example, if current state is 5, and minimal state is to be
-        * changed from 4 to 6, thermal->cooling_levels[0 to 5] will be changed
-        * all from 4 to 6. And state 5 (thermal->cooling_levels[4]) should be
-        * overwritten.
-        */
-       if (state >= MLXSW_THERMAL_SPEED_MIN &&
-           state <= MLXSW_THERMAL_SPEED_MAX) {
-               state -= MLXSW_THERMAL_MAX_STATE;
-               for (i = 0; i <= MLXSW_THERMAL_MAX_STATE; i++)
-                       thermal->cooling_levels[i] = max(state, i);
-
-               mlxsw_reg_mfsc_pack(mfsc_pl, idx, 0);
-               err = mlxsw_reg_query(thermal->core, MLXSW_REG(mfsc), mfsc_pl);
-               if (err)
-                       return err;
-
-               duty = mlxsw_reg_mfsc_pwm_duty_cycle_get(mfsc_pl);
-               cur_state = mlxsw_duty_to_state(duty);
-
-               /* If current fan state is lower than requested dynamical
-                * minimum, increase fan speed up to dynamical minimum.
-                */
-               if (state < cur_state)
-                       return 0;
-
-               state = cur_state;
-       }
-
-       if (state > MLXSW_THERMAL_MAX_STATE)
-               return -EINVAL;
-
        /* Normalize the state to the valid speed range. */
        state = thermal->cooling_levels[state];
        mlxsw_reg_mfsc_pack(mfsc_pl, idx, mlxsw_state_to_duty(state));
@@ -998,8 +957,7 @@ int mlxsw_thermal_init(struct mlxsw_core *core,
 
        /* Initialize cooling levels per PWM state. */
        for (i = 0; i < MLXSW_THERMAL_MAX_STATE; i++)
-               thermal->cooling_levels[i] = max(MLXSW_THERMAL_SPEED_MIN_LEVEL,
-                                                i);
+               thermal->cooling_levels[i] = max(MLXSW_THERMAL_MIN_STATE, i);
 
        thermal->polling_delay = bus_info->low_frequency ?
                                 MLXSW_THERMAL_SLOW_POLL_INT :
index 5cc00d2..6ecc4eb 100644 (file)
@@ -4,8 +4,6 @@
 #
 
 obj-$(CONFIG_KS8842) += ks8842.o
-obj-$(CONFIG_KS8851) += ks8851.o
-ks8851-objs = ks8851_common.o ks8851_spi.o
-obj-$(CONFIG_KS8851_MLL) += ks8851_mll.o
-ks8851_mll-objs = ks8851_common.o ks8851_par.o
+obj-$(CONFIG_KS8851) += ks8851_common.o ks8851_spi.o
+obj-$(CONFIG_KS8851_MLL) += ks8851_common.o ks8851_par.o
 obj-$(CONFIG_KSZ884X_PCI) += ksz884x.o
index 3f69bb5..a6db1a8 100644 (file)
@@ -1057,6 +1057,7 @@ int ks8851_suspend(struct device *dev)
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(ks8851_suspend);
 
 int ks8851_resume(struct device *dev)
 {
@@ -1070,6 +1071,7 @@ int ks8851_resume(struct device *dev)
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(ks8851_resume);
 #endif
 
 static int ks8851_register_mdiobus(struct ks8851_net *ks, struct device *dev)
@@ -1243,6 +1245,7 @@ err_reg:
 err_reg_io:
        return ret;
 }
+EXPORT_SYMBOL_GPL(ks8851_probe_common);
 
 int ks8851_remove_common(struct device *dev)
 {
@@ -1261,3 +1264,8 @@ int ks8851_remove_common(struct device *dev)
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(ks8851_remove_common);
+
+MODULE_DESCRIPTION("KS8851 Network driver");
+MODULE_AUTHOR("Ben Dooks <ben@simtec.co.uk>");
+MODULE_LICENSE("GPL");
index 796e46a..81a8ccc 100644 (file)
@@ -497,13 +497,19 @@ static struct regmap_bus phymap_encx24j600 = {
        .reg_read = regmap_encx24j600_phy_reg_read,
 };
 
-void devm_regmap_init_encx24j600(struct device *dev,
-                                struct encx24j600_context *ctx)
+int devm_regmap_init_encx24j600(struct device *dev,
+                               struct encx24j600_context *ctx)
 {
        mutex_init(&ctx->mutex);
        regcfg.lock_arg = ctx;
        ctx->regmap = devm_regmap_init(dev, &regmap_encx24j600, ctx, &regcfg);
+       if (IS_ERR(ctx->regmap))
+               return PTR_ERR(ctx->regmap);
        ctx->phymap = devm_regmap_init(dev, &phymap_encx24j600, ctx, &phycfg);
+       if (IS_ERR(ctx->phymap))
+               return PTR_ERR(ctx->phymap);
+
+       return 0;
 }
 EXPORT_SYMBOL_GPL(devm_regmap_init_encx24j600);
 
index ee921a9..0bc6b31 100644 (file)
@@ -1023,10 +1023,13 @@ static int encx24j600_spi_probe(struct spi_device *spi)
        priv->speed = SPEED_100;
 
        priv->ctx.spi = spi;
-       devm_regmap_init_encx24j600(&spi->dev, &priv->ctx);
        ndev->irq = spi->irq;
        ndev->netdev_ops = &encx24j600_netdev_ops;
 
+       ret = devm_regmap_init_encx24j600(&spi->dev, &priv->ctx);
+       if (ret)
+               goto out_free;
+
        mutex_init(&priv->lock);
 
        /* Reset device and check if it is connected */
index fac61a8..34c5a28 100644 (file)
@@ -15,8 +15,8 @@ struct encx24j600_context {
        int bank;
 };
 
-void devm_regmap_init_encx24j600(struct device *dev,
-                                struct encx24j600_context *ctx);
+int devm_regmap_init_encx24j600(struct device *dev,
+                               struct encx24j600_context *ctx);
 
 /* Single-byte instructions */
 #define BANK_SELECT(bank) (0xC0 | ((bank & (BANK_MASK >> BANK_SHIFT)) << 1))
index c1310ea..d5c485a 100644 (file)
@@ -398,9 +398,7 @@ static int mana_hwc_alloc_dma_buf(struct hw_channel_context *hwc, u16 q_depth,
        int err;
        u16 i;
 
-       dma_buf = kzalloc(sizeof(*dma_buf) +
-                         q_depth * sizeof(struct hwc_work_request),
-                         GFP_KERNEL);
+       dma_buf = kzalloc(struct_size(dma_buf, reqs, q_depth), GFP_KERNEL);
        if (!dma_buf)
                return -ENOMEM;
 
index 1b21030..030ae89 100644 (file)
@@ -1477,8 +1477,10 @@ static struct mana_rxq *mana_create_rxq(struct mana_port_context *apc,
        if (err)
                goto out;
 
-       if (cq->gdma_id >= gc->max_num_cqs)
+       if (WARN_ON(cq->gdma_id >= gc->max_num_cqs)) {
+               err = -EINVAL;
                goto out;
+       }
 
        gc->cq_table[cq->gdma_id] = cq->gdma_cq;
 
index c581b95..a08e4f5 100644 (file)
@@ -472,9 +472,9 @@ void ocelot_phylink_mac_link_down(struct ocelot *ocelot, int port,
            !(quirks & OCELOT_QUIRK_QSGMII_PORTS_MUST_BE_UP))
                ocelot_port_rmwl(ocelot_port,
                                 DEV_CLOCK_CFG_MAC_TX_RST |
-                                DEV_CLOCK_CFG_MAC_TX_RST,
+                                DEV_CLOCK_CFG_MAC_RX_RST,
                                 DEV_CLOCK_CFG_MAC_TX_RST |
-                                DEV_CLOCK_CFG_MAC_TX_RST,
+                                DEV_CLOCK_CFG_MAC_RX_RST,
                                 DEV_CLOCK_CFG);
 }
 EXPORT_SYMBOL_GPL(ocelot_phylink_mac_link_down);
@@ -563,65 +563,50 @@ void ocelot_phylink_mac_link_up(struct ocelot *ocelot, int port,
        ocelot_port_writel(ocelot_port, DEV_MAC_ENA_CFG_RX_ENA |
                           DEV_MAC_ENA_CFG_TX_ENA, DEV_MAC_ENA_CFG);
 
-       /* Take MAC, Port, Phy (intern) and PCS (SGMII/Serdes) clock out of
-        * reset
-        */
-       ocelot_port_writel(ocelot_port, DEV_CLOCK_CFG_LINK_SPEED(speed),
-                          DEV_CLOCK_CFG);
-
-       /* No PFC */
-       ocelot_write_gix(ocelot, ANA_PFC_PFC_CFG_FC_LINK_SPEED(speed),
-                        ANA_PFC_PFC_CFG, port);
-
        /* Core: Enable port for frame transfer */
        ocelot_fields_write(ocelot, port,
                            QSYS_SWITCH_PORT_MODE_PORT_ENA, 1);
 }
 EXPORT_SYMBOL_GPL(ocelot_phylink_mac_link_up);
 
-static void ocelot_port_add_txtstamp_skb(struct ocelot *ocelot, int port,
-                                        struct sk_buff *clone)
+static int ocelot_port_add_txtstamp_skb(struct ocelot *ocelot, int port,
+                                       struct sk_buff *clone)
 {
        struct ocelot_port *ocelot_port = ocelot->ports[port];
+       unsigned long flags;
+
+       spin_lock_irqsave(&ocelot->ts_id_lock, flags);
 
-       spin_lock(&ocelot_port->ts_id_lock);
+       if (ocelot_port->ptp_skbs_in_flight == OCELOT_MAX_PTP_ID ||
+           ocelot->ptp_skbs_in_flight == OCELOT_PTP_FIFO_SIZE) {
+               spin_unlock_irqrestore(&ocelot->ts_id_lock, flags);
+               return -EBUSY;
+       }
 
        skb_shinfo(clone)->tx_flags |= SKBTX_IN_PROGRESS;
        /* Store timestamp ID in OCELOT_SKB_CB(clone)->ts_id */
        OCELOT_SKB_CB(clone)->ts_id = ocelot_port->ts_id;
-       ocelot_port->ts_id = (ocelot_port->ts_id + 1) % 4;
-       skb_queue_tail(&ocelot_port->tx_skbs, clone);
 
-       spin_unlock(&ocelot_port->ts_id_lock);
-}
+       ocelot_port->ts_id++;
+       if (ocelot_port->ts_id == OCELOT_MAX_PTP_ID)
+               ocelot_port->ts_id = 0;
 
-u32 ocelot_ptp_rew_op(struct sk_buff *skb)
-{
-       struct sk_buff *clone = OCELOT_SKB_CB(skb)->clone;
-       u8 ptp_cmd = OCELOT_SKB_CB(skb)->ptp_cmd;
-       u32 rew_op = 0;
+       ocelot_port->ptp_skbs_in_flight++;
+       ocelot->ptp_skbs_in_flight++;
 
-       if (ptp_cmd == IFH_REW_OP_TWO_STEP_PTP && clone) {
-               rew_op = ptp_cmd;
-               rew_op |= OCELOT_SKB_CB(clone)->ts_id << 3;
-       } else if (ptp_cmd == IFH_REW_OP_ORIGIN_PTP) {
-               rew_op = ptp_cmd;
-       }
+       skb_queue_tail(&ocelot_port->tx_skbs, clone);
+
+       spin_unlock_irqrestore(&ocelot->ts_id_lock, flags);
 
-       return rew_op;
+       return 0;
 }
-EXPORT_SYMBOL(ocelot_ptp_rew_op);
 
-static bool ocelot_ptp_is_onestep_sync(struct sk_buff *skb)
+static bool ocelot_ptp_is_onestep_sync(struct sk_buff *skb,
+                                      unsigned int ptp_class)
 {
        struct ptp_header *hdr;
-       unsigned int ptp_class;
        u8 msgtype, twostep;
 
-       ptp_class = ptp_classify_raw(skb);
-       if (ptp_class == PTP_CLASS_NONE)
-               return false;
-
        hdr = ptp_parse_header(skb, ptp_class);
        if (!hdr)
                return false;
@@ -641,10 +626,20 @@ int ocelot_port_txtstamp_request(struct ocelot *ocelot, int port,
 {
        struct ocelot_port *ocelot_port = ocelot->ports[port];
        u8 ptp_cmd = ocelot_port->ptp_cmd;
+       unsigned int ptp_class;
+       int err;
+
+       /* Don't do anything if PTP timestamping not enabled */
+       if (!ptp_cmd)
+               return 0;
+
+       ptp_class = ptp_classify_raw(skb);
+       if (ptp_class == PTP_CLASS_NONE)
+               return -EINVAL;
 
        /* Store ptp_cmd in OCELOT_SKB_CB(skb)->ptp_cmd */
        if (ptp_cmd == IFH_REW_OP_ORIGIN_PTP) {
-               if (ocelot_ptp_is_onestep_sync(skb)) {
+               if (ocelot_ptp_is_onestep_sync(skb, ptp_class)) {
                        OCELOT_SKB_CB(skb)->ptp_cmd = ptp_cmd;
                        return 0;
                }
@@ -658,8 +653,12 @@ int ocelot_port_txtstamp_request(struct ocelot *ocelot, int port,
                if (!(*clone))
                        return -ENOMEM;
 
-               ocelot_port_add_txtstamp_skb(ocelot, port, *clone);
+               err = ocelot_port_add_txtstamp_skb(ocelot, port, *clone);
+               if (err)
+                       return err;
+
                OCELOT_SKB_CB(skb)->ptp_cmd = ptp_cmd;
+               OCELOT_SKB_CB(*clone)->ptp_class = ptp_class;
        }
 
        return 0;
@@ -693,6 +692,17 @@ static void ocelot_get_hwtimestamp(struct ocelot *ocelot,
        spin_unlock_irqrestore(&ocelot->ptp_clock_lock, flags);
 }
 
+static bool ocelot_validate_ptp_skb(struct sk_buff *clone, u16 seqid)
+{
+       struct ptp_header *hdr;
+
+       hdr = ptp_parse_header(clone, OCELOT_SKB_CB(clone)->ptp_class);
+       if (WARN_ON(!hdr))
+               return false;
+
+       return seqid == ntohs(hdr->sequence_id);
+}
+
 void ocelot_get_txtstamp(struct ocelot *ocelot)
 {
        int budget = OCELOT_PTP_QUEUE_SZ;
@@ -700,10 +710,10 @@ void ocelot_get_txtstamp(struct ocelot *ocelot)
        while (budget--) {
                struct sk_buff *skb, *skb_tmp, *skb_match = NULL;
                struct skb_shared_hwtstamps shhwtstamps;
+               u32 val, id, seqid, txport;
                struct ocelot_port *port;
                struct timespec64 ts;
                unsigned long flags;
-               u32 val, id, txport;
 
                val = ocelot_read(ocelot, SYS_PTP_STATUS);
 
@@ -716,10 +726,17 @@ void ocelot_get_txtstamp(struct ocelot *ocelot)
                /* Retrieve the ts ID and Tx port */
                id = SYS_PTP_STATUS_PTP_MESS_ID_X(val);
                txport = SYS_PTP_STATUS_PTP_MESS_TXPORT_X(val);
+               seqid = SYS_PTP_STATUS_PTP_MESS_SEQ_ID(val);
 
-               /* Retrieve its associated skb */
                port = ocelot->ports[txport];
 
+               spin_lock(&ocelot->ts_id_lock);
+               port->ptp_skbs_in_flight--;
+               ocelot->ptp_skbs_in_flight--;
+               spin_unlock(&ocelot->ts_id_lock);
+
+               /* Retrieve its associated skb */
+try_again:
                spin_lock_irqsave(&port->tx_skbs.lock, flags);
 
                skb_queue_walk_safe(&port->tx_skbs, skb, skb_tmp) {
@@ -732,12 +749,20 @@ void ocelot_get_txtstamp(struct ocelot *ocelot)
 
                spin_unlock_irqrestore(&port->tx_skbs.lock, flags);
 
+               if (WARN_ON(!skb_match))
+                       continue;
+
+               if (!ocelot_validate_ptp_skb(skb_match, seqid)) {
+                       dev_err_ratelimited(ocelot->dev,
+                                           "port %d received stale TX timestamp for seqid %d, discarding\n",
+                                           txport, seqid);
+                       dev_kfree_skb_any(skb);
+                       goto try_again;
+               }
+
                /* Get the h/w timestamp */
                ocelot_get_hwtimestamp(ocelot, &ts);
 
-               if (unlikely(!skb_match))
-                       continue;
-
                /* Set the timestamp into the skb */
                memset(&shhwtstamps, 0, sizeof(shhwtstamps));
                shhwtstamps.hwtstamp = ktime_set(ts.tv_sec, ts.tv_nsec);
@@ -1303,14 +1328,19 @@ static u32 ocelot_get_bond_mask(struct ocelot *ocelot, struct net_device *bond,
        return mask;
 }
 
-static u32 ocelot_get_bridge_fwd_mask(struct ocelot *ocelot,
+static u32 ocelot_get_bridge_fwd_mask(struct ocelot *ocelot, int src_port,
                                      struct net_device *bridge)
 {
+       struct ocelot_port *ocelot_port = ocelot->ports[src_port];
        u32 mask = 0;
        int port;
 
+       if (!ocelot_port || ocelot_port->bridge != bridge ||
+           ocelot_port->stp_state != BR_STATE_FORWARDING)
+               return 0;
+
        for (port = 0; port < ocelot->num_phys_ports; port++) {
-               struct ocelot_port *ocelot_port = ocelot->ports[port];
+               ocelot_port = ocelot->ports[port];
 
                if (!ocelot_port)
                        continue;
@@ -1376,7 +1406,7 @@ void ocelot_apply_bridge_fwd_mask(struct ocelot *ocelot)
                        struct net_device *bridge = ocelot_port->bridge;
                        struct net_device *bond = ocelot_port->bond;
 
-                       mask = ocelot_get_bridge_fwd_mask(ocelot, bridge);
+                       mask = ocelot_get_bridge_fwd_mask(ocelot, port, bridge);
                        mask |= cpu_fwd_mask;
                        mask &= ~BIT(port);
                        if (bond) {
@@ -1953,7 +1983,6 @@ void ocelot_init_port(struct ocelot *ocelot, int port)
        struct ocelot_port *ocelot_port = ocelot->ports[port];
 
        skb_queue_head_init(&ocelot_port->tx_skbs);
-       spin_lock_init(&ocelot_port->ts_id_lock);
 
        /* Basic L2 initialization */
 
@@ -2086,6 +2115,7 @@ int ocelot_init(struct ocelot *ocelot)
        mutex_init(&ocelot->stats_lock);
        mutex_init(&ocelot->ptp_lock);
        spin_lock_init(&ocelot->ptp_clock_lock);
+       spin_lock_init(&ocelot->ts_id_lock);
        snprintf(queue_name, sizeof(queue_name), "%s-stats",
                 dev_name(ocelot->dev));
        ocelot->stats_queue = create_singlethread_workqueue(queue_name);
index edafbd3..b8737ef 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: (GPL-2.0 OR MIT)
-/* Copyright 2020-2021 NXP Semiconductors
+/* Copyright 2020-2021 NXP
  */
 #include <net/devlink.h>
 #include "ocelot.h"
index 08b481a..4b0941f 100644 (file)
@@ -2,7 +2,7 @@
 /* Microsemi Ocelot Switch driver
  *
  * Copyright (c) 2017, 2019 Microsemi Corporation
- * Copyright 2020-2021 NXP Semiconductors
+ * Copyright 2020-2021 NXP
  */
 
 #include <linux/if_bridge.h>
index c0c465a..2545727 100644 (file)
@@ -5,9 +5,10 @@
  * mscc_ocelot_switch_lib.
  *
  * Copyright (c) 2017, 2019 Microsemi Corporation
- * Copyright 2020-2021 NXP Semiconductors
+ * Copyright 2020-2021 NXP
  */
 
+#include <linux/dsa/ocelot.h>
 #include <linux/if_bridge.h>
 #include <linux/of_net.h>
 #include <linux/phy/phy.h>
@@ -1625,7 +1626,7 @@ static int ocelot_port_phylink_create(struct ocelot *ocelot, int port,
        if (phy_mode == PHY_INTERFACE_MODE_QSGMII)
                ocelot_port_rmwl(ocelot_port, 0,
                                 DEV_CLOCK_CFG_MAC_TX_RST |
-                                DEV_CLOCK_CFG_MAC_TX_RST,
+                                DEV_CLOCK_CFG_MAC_RX_RST,
                                 DEV_CLOCK_CFG);
 
        ocelot_port->phy_mode = phy_mode;
index 7945393..99d7376 100644 (file)
@@ -998,8 +998,8 @@ ocelot_vcap_block_find_filter_by_index(struct ocelot_vcap_block *block,
 }
 
 struct ocelot_vcap_filter *
-ocelot_vcap_block_find_filter_by_id(struct ocelot_vcap_block *block, int cookie,
-                                   bool tc_offload)
+ocelot_vcap_block_find_filter_by_id(struct ocelot_vcap_block *block,
+                                   unsigned long cookie, bool tc_offload)
 {
        struct ocelot_vcap_filter *filter;
 
index 09c0e83..3b6b2e6 100644 (file)
@@ -8566,7 +8566,7 @@ static void s2io_io_resume(struct pci_dev *pdev)
                        return;
                }
 
-               if (s2io_set_mac_addr(netdev, netdev->dev_addr) == FAILURE) {
+               if (do_s2io_prog_unicast(netdev, netdev->dev_addr) == FAILURE) {
                        s2io_card_down(sp);
                        pr_err("Can't restore mac addr after reset.\n");
                        return;
index c029950..ac1dcfa 100644 (file)
@@ -830,10 +830,6 @@ static int nfp_flower_init(struct nfp_app *app)
        if (err)
                goto err_cleanup;
 
-       err = flow_indr_dev_register(nfp_flower_indr_setup_tc_cb, app);
-       if (err)
-               goto err_cleanup;
-
        if (app_priv->flower_ext_feats & NFP_FL_FEATS_VF_RLIM)
                nfp_flower_qos_init(app);
 
@@ -942,7 +938,20 @@ static int nfp_flower_start(struct nfp_app *app)
                        return err;
        }
 
-       return nfp_tunnel_config_start(app);
+       err = flow_indr_dev_register(nfp_flower_indr_setup_tc_cb, app);
+       if (err)
+               return err;
+
+       err = nfp_tunnel_config_start(app);
+       if (err)
+               goto err_tunnel_config;
+
+       return 0;
+
+err_tunnel_config:
+       flow_indr_dev_unregister(nfp_flower_indr_setup_tc_cb, app,
+                                nfp_flower_setup_indr_tc_release);
+       return err;
 }
 
 static void nfp_flower_stop(struct nfp_app *app)
index 556c349..64c0ef5 100644 (file)
@@ -1767,9 +1767,6 @@ nfp_flower_indr_block_cb_priv_lookup(struct nfp_app *app,
        struct nfp_flower_indr_block_cb_priv *cb_priv;
        struct nfp_flower_priv *priv = app->priv;
 
-       /* All callback list access should be protected by RTNL. */
-       ASSERT_RTNL();
-
        list_for_each_entry(cb_priv, &priv->indr_block_cb_priv, list)
                if (cb_priv->netdev == netdev)
                        return cb_priv;
index 381966e..7f3322c 100644 (file)
@@ -1292,8 +1292,10 @@ int ionic_lif_addr_add(struct ionic_lif *lif, const u8 *addr)
        if (err && err != -EEXIST) {
                /* set the state back to NEW so we can try again later */
                f = ionic_rx_filter_by_addr(lif, addr);
-               if (f && f->state == IONIC_FILTER_STATE_SYNCED)
+               if (f && f->state == IONIC_FILTER_STATE_SYNCED) {
                        f->state = IONIC_FILTER_STATE_NEW;
+                       set_bit(IONIC_LIF_F_FILTER_SYNC_NEEDED, lif->state);
+               }
 
                spin_unlock_bh(&lif->rx_filters.lock);
 
@@ -1377,6 +1379,10 @@ static int ionic_addr_add(struct net_device *netdev, const u8 *addr)
 
 static int ionic_addr_del(struct net_device *netdev, const u8 *addr)
 {
+       /* Don't delete our own address from the uc list */
+       if (ether_addr_equal(addr, netdev->dev_addr))
+               return 0;
+
        return ionic_lif_list_addr(netdev_priv(netdev), addr, DEL_ADDR);
 }
 
index 25ecfcf..69728f9 100644 (file)
@@ -349,9 +349,6 @@ loop_out:
        list_for_each_entry_safe(sync_item, spos, &sync_add_list, list) {
                (void)ionic_lif_addr_add(lif, sync_item->f.cmd.mac.addr);
 
-               if (sync_item->f.state != IONIC_FILTER_STATE_SYNCED)
-                       set_bit(IONIC_LIF_F_FILTER_SYNC_NEEDED, lif->state);
-
                list_del(&sync_item->list);
                devm_kfree(dev, sync_item);
        }
index 58a8546..c14de5f 100644 (file)
@@ -380,15 +380,6 @@ static void ionic_sw_stats_get_txq_values(struct ionic_lif *lif, u64 **buf,
                                          &ionic_dbg_intr_stats_desc[i]);
                (*buf)++;
        }
-       for (i = 0; i < IONIC_NUM_DBG_NAPI_STATS; i++) {
-               **buf = IONIC_READ_STAT64(&txqcq->napi_stats,
-                                         &ionic_dbg_napi_stats_desc[i]);
-               (*buf)++;
-       }
-       for (i = 0; i < IONIC_MAX_NUM_NAPI_CNTR; i++) {
-               **buf = txqcq->napi_stats.work_done_cntr[i];
-               (*buf)++;
-       }
        for (i = 0; i < IONIC_MAX_NUM_SG_CNTR; i++) {
                **buf = txstats->sg_cntr[i];
                (*buf)++;
index fc8b3e6..186d004 100644 (file)
@@ -1297,6 +1297,14 @@ qed_iwarp_wait_cid_map_cleared(struct qed_hwfn *p_hwfn, struct qed_bmap *bmap)
        prev_weight = weight;
 
        while (weight) {
+               /* If the HW device is during recovery, all resources are
+                * immediately reset without receiving a per-cid indication
+                * from HW. In this case we don't expect the cid_map to be
+                * cleared.
+                */
+               if (p_hwfn->cdev->recov_in_prog)
+                       return 0;
+
                msleep(QED_IWARP_MAX_CID_CLEAN_TIME);
 
                weight = bitmap_weight(bmap->bitmap, bmap->max_count);
index 15ef59a..d10e1cd 100644 (file)
@@ -1299,6 +1299,7 @@ static int qed_slowpath_start(struct qed_dev *cdev,
                        } else {
                                DP_NOTICE(cdev,
                                          "Failed to acquire PTT for aRFS\n");
+                               rc = -EINVAL;
                                goto err;
                        }
                }
index 6e5a6cc..24cd415 100644 (file)
@@ -3367,6 +3367,7 @@ qed_mcp_get_nvm_image_att(struct qed_hwfn *p_hwfn,
                          struct qed_nvm_image_att *p_image_att)
 {
        enum nvm_image_type type;
+       int rc;
        u32 i;
 
        /* Translate image_id into MFW definitions */
@@ -3395,7 +3396,10 @@ qed_mcp_get_nvm_image_att(struct qed_hwfn *p_hwfn,
                return -EINVAL;
        }
 
-       qed_mcp_nvm_info_populate(p_hwfn);
+       rc = qed_mcp_nvm_info_populate(p_hwfn);
+       if (rc)
+               return rc;
+
        for (i = 0; i < p_hwfn->nvm_info.num_images; i++)
                if (type == p_hwfn->nvm_info.image_att[i].image_type)
                        break;
index f16a157..cf5baa5 100644 (file)
@@ -77,6 +77,14 @@ void qed_roce_stop(struct qed_hwfn *p_hwfn)
         * Beyond the added delay we clear the bitmap anyway.
         */
        while (bitmap_weight(rcid_map->bitmap, rcid_map->max_count)) {
+               /* If the HW device is during recovery, all resources are
+                * immediately reset without receiving a per-cid indication
+                * from HW. In this case we don't expect the cid bitmap to be
+                * cleared.
+                */
+               if (p_hwfn->cdev->recov_in_prog)
+                       return;
+
                msleep(100);
                if (wait_count++ > 20) {
                        DP_NOTICE(p_hwfn, "cid bitmap wait timed out\n");
index 0a2f34f..27dffa2 100644 (file)
@@ -1354,10 +1354,10 @@ static int qlcnic_83xx_copy_fw_file(struct qlcnic_adapter *adapter)
        struct qlc_83xx_fw_info *fw_info = adapter->ahw->fw_info;
        const struct firmware *fw = fw_info->fw;
        u32 dest, *p_cache, *temp;
-       int i, ret = -EIO;
        __le32 *temp_le;
        u8 data[16];
        size_t size;
+       int i, ret;
        u64 addr;
 
        temp = vzalloc(fw->size);
index 4b2eca5..01ef5ef 100644 (file)
 #define PHY_ST         0x8A    /* PHY status register */
 #define MAC_SM         0xAC    /* MAC status machine */
 #define  MAC_SM_RST    0x0002  /* MAC status machine reset */
+#define MD_CSC         0xb6    /* MDC speed control register */
+#define  MD_CSC_DEFAULT        0x0030
 #define MAC_ID         0xBE    /* Identifier register */
 
 #define TX_DCNT                0x80    /* TX descriptor count */
@@ -355,8 +357,9 @@ static void r6040_reset_mac(struct r6040_private *lp)
 {
        void __iomem *ioaddr = lp->base;
        int limit = MAC_DEF_TIMEOUT;
-       u16 cmd;
+       u16 cmd, md_csc;
 
+       md_csc = ioread16(ioaddr + MD_CSC);
        iowrite16(MAC_RST, ioaddr + MCR1);
        while (limit--) {
                cmd = ioread16(ioaddr + MCR1);
@@ -368,6 +371,10 @@ static void r6040_reset_mac(struct r6040_private *lp)
        iowrite16(MAC_SM_RST, ioaddr + MAC_SM);
        iowrite16(0, ioaddr + MAC_SM);
        mdelay(5);
+
+       /* Restore MDIO clock frequency */
+       if (md_csc != MD_CSC_DEFAULT)
+               iowrite16(md_csc, ioaddr + MD_CSC);
 }
 
 static void r6040_init_mac_regs(struct net_device *dev)
index e5b0d79..3dbea02 100644 (file)
@@ -166,32 +166,46 @@ static int efx_allocate_msix_channels(struct efx_nic *efx,
         * We need a channel per event queue, plus a VI per tx queue.
         * This may be more pessimistic than it needs to be.
         */
-       if (n_channels + n_xdp_ev > max_channels) {
-               netif_err(efx, drv, efx->net_dev,
-                         "Insufficient resources for %d XDP event queues (%d other channels, max %d)\n",
-                         n_xdp_ev, n_channels, max_channels);
-               netif_err(efx, drv, efx->net_dev,
-                         "XDP_TX and XDP_REDIRECT will not work on this interface");
-               efx->n_xdp_channels = 0;
-               efx->xdp_tx_per_channel = 0;
-               efx->xdp_tx_queue_count = 0;
+       if (n_channels >= max_channels) {
+               efx->xdp_txq_queues_mode = EFX_XDP_TX_QUEUES_BORROWED;
+               netif_warn(efx, drv, efx->net_dev,
+                          "Insufficient resources for %d XDP event queues (%d other channels, max %d)\n",
+                          n_xdp_ev, n_channels, max_channels);
+               netif_warn(efx, drv, efx->net_dev,
+                          "XDP_TX and XDP_REDIRECT might decrease device's performance\n");
        } else if (n_channels + n_xdp_tx > efx->max_vis) {
-               netif_err(efx, drv, efx->net_dev,
-                         "Insufficient resources for %d XDP TX queues (%d other channels, max VIs %d)\n",
-                         n_xdp_tx, n_channels, efx->max_vis);
-               netif_err(efx, drv, efx->net_dev,
-                         "XDP_TX and XDP_REDIRECT will not work on this interface");
-               efx->n_xdp_channels = 0;
-               efx->xdp_tx_per_channel = 0;
-               efx->xdp_tx_queue_count = 0;
+               efx->xdp_txq_queues_mode = EFX_XDP_TX_QUEUES_BORROWED;
+               netif_warn(efx, drv, efx->net_dev,
+                          "Insufficient resources for %d XDP TX queues (%d other channels, max VIs %d)\n",
+                          n_xdp_tx, n_channels, efx->max_vis);
+               netif_warn(efx, drv, efx->net_dev,
+                          "XDP_TX and XDP_REDIRECT might decrease device's performance\n");
+       } else if (n_channels + n_xdp_ev > max_channels) {
+               efx->xdp_txq_queues_mode = EFX_XDP_TX_QUEUES_SHARED;
+               netif_warn(efx, drv, efx->net_dev,
+                          "Insufficient resources for %d XDP event queues (%d other channels, max %d)\n",
+                          n_xdp_ev, n_channels, max_channels);
+
+               n_xdp_ev = max_channels - n_channels;
+               netif_warn(efx, drv, efx->net_dev,
+                          "XDP_TX and XDP_REDIRECT will work with reduced performance (%d cpus/tx_queue)\n",
+                          DIV_ROUND_UP(n_xdp_tx, tx_per_ev * n_xdp_ev));
        } else {
+               efx->xdp_txq_queues_mode = EFX_XDP_TX_QUEUES_DEDICATED;
+       }
+
+       if (efx->xdp_txq_queues_mode != EFX_XDP_TX_QUEUES_BORROWED) {
                efx->n_xdp_channels = n_xdp_ev;
                efx->xdp_tx_per_channel = tx_per_ev;
                efx->xdp_tx_queue_count = n_xdp_tx;
                n_channels += n_xdp_ev;
                netif_dbg(efx, drv, efx->net_dev,
                          "Allocating %d TX and %d event queues for XDP\n",
-                         n_xdp_tx, n_xdp_ev);
+                         n_xdp_ev * tx_per_ev, n_xdp_ev);
+       } else {
+               efx->n_xdp_channels = 0;
+               efx->xdp_tx_per_channel = 0;
+               efx->xdp_tx_queue_count = n_xdp_tx;
        }
 
        if (vec_count < n_channels) {
@@ -858,6 +872,20 @@ rollback:
        goto out;
 }
 
+static inline int
+efx_set_xdp_tx_queue(struct efx_nic *efx, int xdp_queue_number,
+                    struct efx_tx_queue *tx_queue)
+{
+       if (xdp_queue_number >= efx->xdp_tx_queue_count)
+               return -EINVAL;
+
+       netif_dbg(efx, drv, efx->net_dev, "Channel %u TXQ %u is XDP %u, HW %u\n",
+                 tx_queue->channel->channel, tx_queue->label,
+                 xdp_queue_number, tx_queue->queue);
+       efx->xdp_tx_queues[xdp_queue_number] = tx_queue;
+       return 0;
+}
+
 int efx_set_channels(struct efx_nic *efx)
 {
        struct efx_tx_queue *tx_queue;
@@ -896,20 +924,9 @@ int efx_set_channels(struct efx_nic *efx)
                        if (efx_channel_is_xdp_tx(channel)) {
                                efx_for_each_channel_tx_queue(tx_queue, channel) {
                                        tx_queue->queue = next_queue++;
-
-                                       /* We may have a few left-over XDP TX
-                                        * queues owing to xdp_tx_queue_count
-                                        * not dividing evenly by EFX_MAX_TXQ_PER_CHANNEL.
-                                        * We still allocate and probe those
-                                        * TXQs, but never use them.
-                                        */
-                                       if (xdp_queue_number < efx->xdp_tx_queue_count) {
-                                               netif_dbg(efx, drv, efx->net_dev, "Channel %u TXQ %u is XDP %u, HW %u\n",
-                                                         channel->channel, tx_queue->label,
-                                                         xdp_queue_number, tx_queue->queue);
-                                               efx->xdp_tx_queues[xdp_queue_number] = tx_queue;
+                                       rc = efx_set_xdp_tx_queue(efx, xdp_queue_number, tx_queue);
+                                       if (rc == 0)
                                                xdp_queue_number++;
-                                       }
                                }
                        } else {
                                efx_for_each_channel_tx_queue(tx_queue, channel) {
@@ -918,10 +935,35 @@ int efx_set_channels(struct efx_nic *efx)
                                                  channel->channel, tx_queue->label,
                                                  tx_queue->queue);
                                }
+
+                               /* If XDP is borrowing queues from net stack, it must use the queue
+                                * with no csum offload, which is the first one of the channel
+                                * (note: channel->tx_queue_by_type is not initialized yet)
+                                */
+                               if (efx->xdp_txq_queues_mode == EFX_XDP_TX_QUEUES_BORROWED) {
+                                       tx_queue = &channel->tx_queue[0];
+                                       rc = efx_set_xdp_tx_queue(efx, xdp_queue_number, tx_queue);
+                                       if (rc == 0)
+                                               xdp_queue_number++;
+                               }
                        }
                }
        }
-       WARN_ON(xdp_queue_number != efx->xdp_tx_queue_count);
+       WARN_ON(efx->xdp_txq_queues_mode == EFX_XDP_TX_QUEUES_DEDICATED &&
+               xdp_queue_number != efx->xdp_tx_queue_count);
+       WARN_ON(efx->xdp_txq_queues_mode != EFX_XDP_TX_QUEUES_DEDICATED &&
+               xdp_queue_number > efx->xdp_tx_queue_count);
+
+       /* If we have more CPUs than assigned XDP TX queues, assign the already
+        * existing queues to the exceeding CPUs
+        */
+       next_queue = 0;
+       while (xdp_queue_number < efx->xdp_tx_queue_count) {
+               tx_queue = efx->xdp_tx_queues[next_queue++];
+               rc = efx_set_xdp_tx_queue(efx, xdp_queue_number, tx_queue);
+               if (rc == 0)
+                       xdp_queue_number++;
+       }
 
        rc = netif_set_real_num_tx_queues(efx->net_dev, efx->n_tx_channels);
        if (rc)
index 9b4b257..f698181 100644 (file)
@@ -782,6 +782,12 @@ struct efx_async_filter_insertion {
 #define EFX_RPS_MAX_IN_FLIGHT  8
 #endif /* CONFIG_RFS_ACCEL */
 
+enum efx_xdp_tx_queues_mode {
+       EFX_XDP_TX_QUEUES_DEDICATED,    /* one queue per core, locking not needed */
+       EFX_XDP_TX_QUEUES_SHARED,       /* each queue used by more than 1 core */
+       EFX_XDP_TX_QUEUES_BORROWED      /* queues borrowed from net stack */
+};
+
 /**
  * struct efx_nic - an Efx NIC
  * @name: Device name (net device name or bus id before net device registered)
@@ -820,6 +826,7 @@ struct efx_async_filter_insertion {
  *     should be allocated for this NIC
  * @xdp_tx_queue_count: Number of entries in %xdp_tx_queues.
  * @xdp_tx_queues: Array of pointers to tx queues used for XDP transmit.
+ * @xdp_txq_queues_mode: XDP TX queues sharing strategy.
  * @rxq_entries: Size of receive queues requested by user.
  * @txq_entries: Size of transmit queues requested by user.
  * @txq_stop_thresh: TX queue fill level at or above which we stop it.
@@ -979,6 +986,7 @@ struct efx_nic {
 
        unsigned int xdp_tx_queue_count;
        struct efx_tx_queue **xdp_tx_queues;
+       enum efx_xdp_tx_queues_mode xdp_txq_queues_mode;
 
        unsigned rxq_entries;
        unsigned txq_entries;
index 0c6650d..d16e031 100644 (file)
@@ -428,23 +428,32 @@ int efx_xdp_tx_buffers(struct efx_nic *efx, int n, struct xdp_frame **xdpfs,
        unsigned int len;
        int space;
        int cpu;
-       int i;
+       int i = 0;
 
-       cpu = raw_smp_processor_id();
+       if (unlikely(n && !xdpfs))
+               return -EINVAL;
+       if (unlikely(!n))
+               return 0;
 
-       if (!efx->xdp_tx_queue_count ||
-           unlikely(cpu >= efx->xdp_tx_queue_count))
+       cpu = raw_smp_processor_id();
+       if (unlikely(cpu >= efx->xdp_tx_queue_count))
                return -EINVAL;
 
        tx_queue = efx->xdp_tx_queues[cpu];
        if (unlikely(!tx_queue))
                return -EINVAL;
 
-       if (unlikely(n && !xdpfs))
-               return -EINVAL;
+       if (efx->xdp_txq_queues_mode != EFX_XDP_TX_QUEUES_DEDICATED)
+               HARD_TX_LOCK(efx->net_dev, tx_queue->core_txq, cpu);
 
-       if (!n)
-               return 0;
+       /* If we're borrowing net stack queues we have to handle stop-restart
+        * or we might block the queue and it will be considered as frozen
+        */
+       if (efx->xdp_txq_queues_mode == EFX_XDP_TX_QUEUES_BORROWED) {
+               if (netif_tx_queue_stopped(tx_queue->core_txq))
+                       goto unlock;
+               efx_tx_maybe_stop_queue(tx_queue);
+       }
 
        /* Check for available space. We should never need multiple
         * descriptors per frame.
@@ -484,6 +493,10 @@ int efx_xdp_tx_buffers(struct efx_nic *efx, int n, struct xdp_frame **xdpfs,
        if (flush && i > 0)
                efx_nic_push_buffers(tx_queue);
 
+unlock:
+       if (efx->xdp_txq_queues_mode != EFX_XDP_TX_QUEUES_DEDICATED)
+               HARD_TX_UNLOCK(efx->net_dev, tx_queue->core_txq);
+
        return i == 0 ? -EIO : i;
 }
 
index fbfda55..5e731a7 100644 (file)
@@ -71,6 +71,7 @@ err_remove_config_dt:
 
 static const struct of_device_id dwmac_generic_match[] = {
        { .compatible = "st,spear600-gmac"},
+       { .compatible = "snps,dwmac-3.40a"},
        { .compatible = "snps,dwmac-3.50a"},
        { .compatible = "snps,dwmac-3.610"},
        { .compatible = "snps,dwmac-3.70a"},
index ed81701..6924a6a 100644 (file)
@@ -21,6 +21,7 @@
 #include <linux/delay.h>
 #include <linux/mfd/syscon.h>
 #include <linux/regmap.h>
+#include <linux/pm_runtime.h>
 
 #include "stmmac_platform.h"
 
@@ -1528,6 +1529,8 @@ static int rk_gmac_powerup(struct rk_priv_data *bsp_priv)
                return ret;
        }
 
+       pm_runtime_get_sync(dev);
+
        if (bsp_priv->integrated_phy)
                rk_gmac_integrated_phy_powerup(bsp_priv);
 
@@ -1539,6 +1542,8 @@ static void rk_gmac_powerdown(struct rk_priv_data *gmac)
        if (gmac->integrated_phy)
                rk_gmac_integrated_phy_powerdown(gmac);
 
+       pm_runtime_put_sync(&gmac->pdev->dev);
+
        phy_power_on(gmac, false);
        gmac_clk_enable(gmac, false);
 }
index 90383ab..f5581db 100644 (file)
@@ -218,11 +218,18 @@ static void dwmac1000_dump_dma_regs(void __iomem *ioaddr, u32 *reg_space)
                                readl(ioaddr + DMA_BUS_MODE + i * 4);
 }
 
-static void dwmac1000_get_hw_feature(void __iomem *ioaddr,
-                                    struct dma_features *dma_cap)
+static int dwmac1000_get_hw_feature(void __iomem *ioaddr,
+                                   struct dma_features *dma_cap)
 {
        u32 hw_cap = readl(ioaddr + DMA_HW_FEATURE);
 
+       if (!hw_cap) {
+               /* 0x00000000 is the value read on old hardware that does not
+                * implement this register
+                */
+               return -EOPNOTSUPP;
+       }
+
        dma_cap->mbps_10_100 = (hw_cap & DMA_HW_FEAT_MIISEL);
        dma_cap->mbps_1000 = (hw_cap & DMA_HW_FEAT_GMIISEL) >> 1;
        dma_cap->half_duplex = (hw_cap & DMA_HW_FEAT_HDSEL) >> 2;
@@ -252,6 +259,8 @@ static void dwmac1000_get_hw_feature(void __iomem *ioaddr,
        dma_cap->number_tx_channel = (hw_cap & DMA_HW_FEAT_TXCHCNT) >> 22;
        /* Alternate (enhanced) DESC mode */
        dma_cap->enh_desc = (hw_cap & DMA_HW_FEAT_ENHDESSEL) >> 24;
+
+       return 0;
 }
 
 static void dwmac1000_rx_watchdog(void __iomem *ioaddr, u32 riwt,
index 5be8e6a..d99fa02 100644 (file)
@@ -347,8 +347,8 @@ static void dwmac4_dma_tx_chan_op_mode(void __iomem *ioaddr, int mode,
        writel(mtl_tx_op, ioaddr +  MTL_CHAN_TX_OP_MODE(channel));
 }
 
-static void dwmac4_get_hw_feature(void __iomem *ioaddr,
-                                 struct dma_features *dma_cap)
+static int dwmac4_get_hw_feature(void __iomem *ioaddr,
+                                struct dma_features *dma_cap)
 {
        u32 hw_cap = readl(ioaddr + GMAC_HW_FEATURE0);
 
@@ -437,6 +437,8 @@ static void dwmac4_get_hw_feature(void __iomem *ioaddr,
        dma_cap->frpbs = (hw_cap & GMAC_HW_FEAT_FRPBS) >> 11;
        dma_cap->frpsel = (hw_cap & GMAC_HW_FEAT_FRPSEL) >> 10;
        dma_cap->dvlan = (hw_cap & GMAC_HW_FEAT_DVLAN) >> 5;
+
+       return 0;
 }
 
 /* Enable/disable TSO feature and set MSS */
index 906e985..5e98355 100644 (file)
@@ -371,8 +371,8 @@ static int dwxgmac2_dma_interrupt(void __iomem *ioaddr,
        return ret;
 }
 
-static void dwxgmac2_get_hw_feature(void __iomem *ioaddr,
-                                   struct dma_features *dma_cap)
+static int dwxgmac2_get_hw_feature(void __iomem *ioaddr,
+                                  struct dma_features *dma_cap)
 {
        u32 hw_cap;
 
@@ -445,6 +445,8 @@ static void dwxgmac2_get_hw_feature(void __iomem *ioaddr,
        dma_cap->frpes = (hw_cap & XGMAC_HWFEAT_FRPES) >> 11;
        dma_cap->frpbs = (hw_cap & XGMAC_HWFEAT_FRPPB) >> 9;
        dma_cap->frpsel = (hw_cap & XGMAC_HWFEAT_FRPSEL) >> 3;
+
+       return 0;
 }
 
 static void dwxgmac2_rx_watchdog(void __iomem *ioaddr, u32 riwt, u32 queue)
index 6dc1c98..fe2660d 100644 (file)
@@ -203,8 +203,8 @@ struct stmmac_dma_ops {
        int (*dma_interrupt) (void __iomem *ioaddr,
                              struct stmmac_extra_stats *x, u32 chan, u32 dir);
        /* If supported then get the optional core features */
-       void (*get_hw_feature)(void __iomem *ioaddr,
-                              struct dma_features *dma_cap);
+       int (*get_hw_feature)(void __iomem *ioaddr,
+                             struct dma_features *dma_cap);
        /* Program the HW RX Watchdog */
        void (*rx_watchdog)(void __iomem *ioaddr, u32 riwt, u32 queue);
        void (*set_tx_ring_len)(void __iomem *ioaddr, u32 len, u32 chan);
@@ -255,7 +255,7 @@ struct stmmac_dma_ops {
 #define stmmac_dma_interrupt_status(__priv, __args...) \
        stmmac_do_callback(__priv, dma, dma_interrupt, __args)
 #define stmmac_get_hw_feature(__priv, __args...) \
-       stmmac_do_void_callback(__priv, dma, get_hw_feature, __args)
+       stmmac_do_callback(__priv, dma, get_hw_feature, __args)
 #define stmmac_rx_watchdog(__priv, __args...) \
        stmmac_do_void_callback(__priv, dma, rx_watchdog, __args)
 #define stmmac_set_tx_ring_len(__priv, __args...) \
index ece02b3..eb3b7bf 100644 (file)
@@ -309,7 +309,7 @@ static void stmmac_clk_csr_set(struct stmmac_priv *priv)
                        priv->clk_csr = STMMAC_CSR_100_150M;
                else if ((clk_rate >= CSR_F_150M) && (clk_rate < CSR_F_250M))
                        priv->clk_csr = STMMAC_CSR_150_250M;
-               else if ((clk_rate >= CSR_F_250M) && (clk_rate < CSR_F_300M))
+               else if ((clk_rate >= CSR_F_250M) && (clk_rate <= CSR_F_300M))
                        priv->clk_csr = STMMAC_CSR_250_300M;
        }
 
@@ -477,6 +477,10 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
                        stmmac_lpi_entry_timer_config(priv, 0);
                        del_timer_sync(&priv->eee_ctrl_timer);
                        stmmac_set_eee_timer(priv, priv->hw, 0, eee_tw_timer);
+                       if (priv->hw->xpcs)
+                               xpcs_config_eee(priv->hw->xpcs,
+                                               priv->plat->mult_fact_100ns,
+                                               false);
                }
                mutex_unlock(&priv->lock);
                return false;
@@ -486,6 +490,10 @@ bool stmmac_eee_init(struct stmmac_priv *priv)
                timer_setup(&priv->eee_ctrl_timer, stmmac_eee_ctrl_timer, 0);
                stmmac_set_eee_timer(priv, priv->hw, STMMAC_DEFAULT_LIT_LS,
                                     eee_tw_timer);
+               if (priv->hw->xpcs)
+                       xpcs_config_eee(priv->hw->xpcs,
+                                       priv->plat->mult_fact_100ns,
+                                       true);
        }
 
        if (priv->plat->has_gmac4 && priv->tx_lpi_timer <= STMMAC_ET_MAX) {
@@ -1034,7 +1042,7 @@ static void stmmac_mac_link_down(struct phylink_config *config,
        stmmac_mac_set(priv, priv->ioaddr, false);
        priv->eee_active = false;
        priv->tx_lpi_enabled = false;
-       stmmac_eee_init(priv);
+       priv->eee_enabled = stmmac_eee_init(priv);
        stmmac_set_eee_pls(priv, priv->hw, false);
 
        if (priv->dma_cap.fpesel)
@@ -7118,7 +7126,6 @@ int stmmac_suspend(struct device *dev)
        struct net_device *ndev = dev_get_drvdata(dev);
        struct stmmac_priv *priv = netdev_priv(ndev);
        u32 chan;
-       int ret;
 
        if (!ndev || !netif_running(ndev))
                return 0;
@@ -7150,13 +7157,6 @@ int stmmac_suspend(struct device *dev)
        } else {
                stmmac_mac_set(priv, priv->ioaddr, false);
                pinctrl_pm_select_sleep_state(priv->device);
-               /* Disable clock in case of PWM is off */
-               clk_disable_unprepare(priv->plat->clk_ptp_ref);
-               ret = pm_runtime_force_suspend(dev);
-               if (ret) {
-                       mutex_unlock(&priv->lock);
-                       return ret;
-               }
        }
 
        mutex_unlock(&priv->lock);
@@ -7242,12 +7242,6 @@ int stmmac_resume(struct device *dev)
                priv->irq_wake = 0;
        } else {
                pinctrl_pm_select_default_state(priv->device);
-               /* enable the clk previously disabled */
-               ret = pm_runtime_force_resume(dev);
-               if (ret)
-                       return ret;
-               if (priv->plat->clk_ptp_ref)
-                       clk_prepare_enable(priv->plat->clk_ptp_ref);
                /* reset the phy so that it's ready */
                if (priv->mii)
                        stmmac_mdio_reset(priv->mii);
index 5ca7108..232ac98 100644 (file)
@@ -9,6 +9,7 @@
 *******************************************************************************/
 
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/module.h>
 #include <linux/io.h>
 #include <linux/of.h>
@@ -507,6 +508,14 @@ stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac)
                plat->pmt = 1;
        }
 
+       if (of_device_is_compatible(np, "snps,dwmac-3.40a")) {
+               plat->has_gmac = 1;
+               plat->enh_desc = 1;
+               plat->tx_coe = 1;
+               plat->bugged_jumbo = 1;
+               plat->pmt = 1;
+       }
+
        if (of_device_is_compatible(np, "snps,dwmac-4.00") ||
            of_device_is_compatible(np, "snps,dwmac-4.10a") ||
            of_device_is_compatible(np, "snps,dwmac-4.20a") ||
@@ -771,9 +780,52 @@ static int __maybe_unused stmmac_runtime_resume(struct device *dev)
        return stmmac_bus_clks_config(priv, true);
 }
 
+static int __maybe_unused stmmac_pltfr_noirq_suspend(struct device *dev)
+{
+       struct net_device *ndev = dev_get_drvdata(dev);
+       struct stmmac_priv *priv = netdev_priv(ndev);
+       int ret;
+
+       if (!netif_running(ndev))
+               return 0;
+
+       if (!device_may_wakeup(priv->device) || !priv->plat->pmt) {
+               /* Disable clock in case of PWM is off */
+               clk_disable_unprepare(priv->plat->clk_ptp_ref);
+
+               ret = pm_runtime_force_suspend(dev);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int __maybe_unused stmmac_pltfr_noirq_resume(struct device *dev)
+{
+       struct net_device *ndev = dev_get_drvdata(dev);
+       struct stmmac_priv *priv = netdev_priv(ndev);
+       int ret;
+
+       if (!netif_running(ndev))
+               return 0;
+
+       if (!device_may_wakeup(priv->device) || !priv->plat->pmt) {
+               /* enable the clk previously disabled */
+               ret = pm_runtime_force_resume(dev);
+               if (ret)
+                       return ret;
+
+               clk_prepare_enable(priv->plat->clk_ptp_ref);
+       }
+
+       return 0;
+}
+
 const struct dev_pm_ops stmmac_pltfr_pm_ops = {
        SET_SYSTEM_SLEEP_PM_OPS(stmmac_pltfr_suspend, stmmac_pltfr_resume)
        SET_RUNTIME_PM_OPS(stmmac_runtime_suspend, stmmac_runtime_resume, NULL)
+       SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stmmac_pltfr_noirq_suspend, stmmac_pltfr_noirq_resume)
 };
 EXPORT_SYMBOL_GPL(stmmac_pltfr_pm_ops);
 
index 309de38..b0d3f9a 100644 (file)
@@ -73,6 +73,7 @@ config CASSINI
 config SUNVNET_COMMON
        tristate "Common routines to support Sun Virtual Networking"
        depends on SUN_LDOMS
+       depends on INET
        default m
 
 config SUNVNET
index 8fe8887..6192244 100644 (file)
@@ -68,9 +68,9 @@
 #define SIXP_DAMA_OFF          0
 
 /* default level 2 parameters */
-#define SIXP_TXDELAY                   (HZ/4)  /* in 1 s */
+#define SIXP_TXDELAY                   25      /* 250 ms */
 #define SIXP_PERSIST                   50      /* in 256ths */
-#define SIXP_SLOTTIME                  (HZ/10) /* in 1 s */
+#define SIXP_SLOTTIME                  10      /* 100 ms */
 #define SIXP_INIT_RESYNC_TIMEOUT       (3*HZ/2) /* in 1 s */
 #define SIXP_RESYNC_TIMEOUT            5*HZ    /* in 1 s */
 
index f4843f9..441da03 100644 (file)
@@ -48,6 +48,7 @@ config BPQETHER
 config DMASCC
        tristate "High-speed (DMA) SCC driver for AX.25"
        depends on ISA && AX25 && BROKEN_ON_SMP && ISA_DMA_API
+       depends on VIRT_TO_BUS
        help
          This is a driver for high-speed SCC boards, i.e. those supporting
          DMA on one port. You usually use those boards to connect your
index b50b7fa..f4c3efc 100644 (file)
@@ -973,7 +973,7 @@ static inline void tx_on(struct scc_priv *priv)
                flags = claim_dma_lock();
                set_dma_mode(priv->param.dma, DMA_MODE_WRITE);
                set_dma_addr(priv->param.dma,
-                            (int) priv->tx_buf[priv->tx_tail] + n);
+                            virt_to_bus(priv->tx_buf[priv->tx_tail]) + n);
                set_dma_count(priv->param.dma,
                              priv->tx_len[priv->tx_tail] - n);
                release_dma_lock(flags);
@@ -1020,7 +1020,7 @@ static inline void rx_on(struct scc_priv *priv)
                flags = claim_dma_lock();
                set_dma_mode(priv->param.dma, DMA_MODE_READ);
                set_dma_addr(priv->param.dma,
-                            (int) priv->rx_buf[priv->rx_head]);
+                            virt_to_bus(priv->rx_buf[priv->rx_head]));
                set_dma_count(priv->param.dma, BUF_SIZE);
                release_dma_lock(flags);
                enable_dma(priv->param.dma);
@@ -1233,7 +1233,7 @@ static void special_condition(struct scc_priv *priv, int rc)
                if (priv->param.dma >= 0) {
                        flags = claim_dma_lock();
                        set_dma_addr(priv->param.dma,
-                                    (int) priv->rx_buf[priv->rx_head]);
+                                    virt_to_bus(priv->rx_buf[priv->rx_head]));
                        set_dma_count(priv->param.dma, BUF_SIZE);
                        release_dma_lock(flags);
                } else {
index 8f99cfa..d037682 100644 (file)
@@ -4,6 +4,7 @@ config QCOM_IPA
        depends on ARCH_QCOM || COMPILE_TEST
        depends on QCOM_RPROC_COMMON || (QCOM_RPROC_COMMON=n && COMPILE_TEST)
        select QCOM_MDT_LOADER if ARCH_QCOM
+       select QCOM_SCM
        select QCOM_QMI_HELPERS
        help
          Choose Y or M here to include support for the Qualcomm
index 2324e1b..1da334f 100644 (file)
@@ -430,7 +430,8 @@ static void ipa_table_init_add(struct gsi_trans *trans, bool filter,
         * table region determines the number of entries it has.
         */
        if (filter) {
-               count = hweight32(ipa->filter_map);
+               /* Include one extra "slot" to hold the filter map itself */
+               count = 1 + hweight32(ipa->filter_map);
                hash_count = hash_mem->size ? count : 0;
        } else {
                count = mem->size / sizeof(__le64);
index 0d7d3e1..5f4cd24 100644 (file)
@@ -207,6 +207,7 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
 {
        struct ipq4019_mdio_data *priv;
        struct mii_bus *bus;
+       struct resource *res;
        int ret;
 
        bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*priv));
@@ -224,7 +225,10 @@ static int ipq4019_mdio_probe(struct platform_device *pdev)
                return PTR_ERR(priv->mdio_clk);
 
        /* The platform resource is provided on the chipset IPQ5018 */
-       priv->eth_ldo_rdy = devm_platform_ioremap_resource(pdev, 1);
+       /* This resource is optional */
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+       if (res)
+               priv->eth_ldo_rdy = devm_ioremap_resource(&pdev->dev, res);
 
        bus->name = "ipq4019_mdio";
        bus->read = ipq4019_mdio_read;
index 1ee592d..17f98f6 100644 (file)
@@ -134,8 +134,9 @@ static int mscc_miim_reset(struct mii_bus *bus)
 
 static int mscc_miim_probe(struct platform_device *pdev)
 {
-       struct mii_bus *bus;
        struct mscc_miim_dev *dev;
+       struct resource *res;
+       struct mii_bus *bus;
        int ret;
 
        bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
@@ -156,10 +157,14 @@ static int mscc_miim_probe(struct platform_device *pdev)
                return PTR_ERR(dev->regs);
        }
 
-       dev->phy_regs = devm_platform_ioremap_resource(pdev, 1);
-       if (IS_ERR(dev->phy_regs)) {
-               dev_err(&pdev->dev, "Unable to map internal phy registers\n");
-               return PTR_ERR(dev->phy_regs);
+       /* This resource is optional */
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
+       if (res) {
+               dev->phy_regs = devm_ioremap_resource(&pdev->dev, res);
+               if (IS_ERR(dev->phy_regs)) {
+                       dev_err(&pdev->dev, "Unable to map internal phy registers\n");
+                       return PTR_ERR(dev->phy_regs);
+               }
        }
 
        ret = of_mdiobus_register(bus, pdev->dev.of_node);
index d127eb6..aaa628f 100644 (file)
@@ -321,7 +321,7 @@ static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev)
        /* Start MHI channels */
        err = mhi_prepare_for_transfer(mhi_dev);
        if (err)
-               goto out_err;
+               return err;
 
        /* Number of transfer descriptors determines size of the queue */
        mhi_netdev->rx_queue_sz = mhi_get_free_desc_count(mhi_dev, DMA_FROM_DEVICE);
@@ -331,10 +331,6 @@ static int mhi_net_newlink(struct mhi_device *mhi_dev, struct net_device *ndev)
                return err;
 
        return 0;
-
-out_err:
-       free_netdev(ndev);
-       return err;
 }
 
 static void mhi_net_dellink(struct mhi_device *mhi_dev, struct net_device *ndev)
index 984c9f7..d16fc58 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2021 NXP Semiconductors
+/* Copyright 2021 NXP
  */
 #include <linux/pcs/pcs-xpcs.h>
 #include "pcs-xpcs.h"
index fb0a83d..7de631f 100644 (file)
@@ -666,6 +666,10 @@ int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable)
 {
        int ret;
 
+       ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_EEE_MCTRL0);
+       if (ret < 0)
+               return ret;
+
        if (enable) {
        /* Enable EEE */
                ret = DW_VR_MII_EEE_LTX_EN | DW_VR_MII_EEE_LRX_EN |
@@ -673,9 +677,6 @@ int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable)
                      DW_VR_MII_EEE_TX_EN_CTRL | DW_VR_MII_EEE_RX_EN_CTRL |
                      mult_fact_100ns << DW_VR_MII_EEE_MULT_FACT_100NS_SHIFT;
        } else {
-               ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_EEE_MCTRL0);
-               if (ret < 0)
-                       return ret;
                ret &= ~(DW_VR_MII_EEE_LTX_EN | DW_VR_MII_EEE_LRX_EN |
                       DW_VR_MII_EEE_TX_QUIET_EN | DW_VR_MII_EEE_RX_QUIET_EN |
                       DW_VR_MII_EEE_TX_EN_CTRL | DW_VR_MII_EEE_RX_EN_CTRL |
@@ -690,21 +691,28 @@ int xpcs_config_eee(struct dw_xpcs *xpcs, int mult_fact_100ns, int enable)
        if (ret < 0)
                return ret;
 
-       ret |= DW_VR_MII_EEE_TRN_LPI;
+       if (enable)
+               ret |= DW_VR_MII_EEE_TRN_LPI;
+       else
+               ret &= ~DW_VR_MII_EEE_TRN_LPI;
+
        return xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_EEE_MCTRL1, ret);
 }
 EXPORT_SYMBOL_GPL(xpcs_config_eee);
 
 static int xpcs_config_aneg_c37_sgmii(struct dw_xpcs *xpcs, unsigned int mode)
 {
-       int ret;
+       int ret, mdio_ctrl;
 
        /* For AN for C37 SGMII mode, the settings are :-
-        * 1) VR_MII_AN_CTRL Bit(2:1)[PCS_MODE] = 10b (SGMII AN)
-        * 2) VR_MII_AN_CTRL Bit(3) [TX_CONFIG] = 0b (MAC side SGMII)
+        * 1) VR_MII_MMD_CTRL Bit(12) [AN_ENABLE] = 0b (Disable SGMII AN in case
+             it is already enabled)
+        * 2) VR_MII_AN_CTRL Bit(2:1)[PCS_MODE] = 10b (SGMII AN)
+        * 3) VR_MII_AN_CTRL Bit(3) [TX_CONFIG] = 0b (MAC side SGMII)
         *    DW xPCS used with DW EQoS MAC is always MAC side SGMII.
-        * 3) VR_MII_DIG_CTRL1 Bit(9) [MAC_AUTO_SW] = 1b (Automatic
+        * 4) VR_MII_DIG_CTRL1 Bit(9) [MAC_AUTO_SW] = 1b (Automatic
         *    speed/duplex mode change by HW after SGMII AN complete)
+        * 5) VR_MII_MMD_CTRL Bit(12) [AN_ENABLE] = 1b (Enable SGMII AN)
         *
         * Note: Since it is MAC side SGMII, there is no need to set
         *       SR_MII_AN_ADV. MAC side SGMII receives AN Tx Config from
@@ -712,6 +720,17 @@ static int xpcs_config_aneg_c37_sgmii(struct dw_xpcs *xpcs, unsigned int mode)
         *       between PHY and Link Partner. There is also no need to
         *       trigger AN restart for MAC-side SGMII.
         */
+       mdio_ctrl = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL);
+       if (mdio_ctrl < 0)
+               return mdio_ctrl;
+
+       if (mdio_ctrl & AN_CL37_EN) {
+               ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL,
+                                mdio_ctrl & ~AN_CL37_EN);
+               if (ret < 0)
+                       return ret;
+       }
+
        ret = xpcs_read(xpcs, MDIO_MMD_VEND2, DW_VR_MII_AN_CTRL);
        if (ret < 0)
                return ret;
@@ -736,7 +755,15 @@ static int xpcs_config_aneg_c37_sgmii(struct dw_xpcs *xpcs, unsigned int mode)
        else
                ret &= ~DW_VR_MII_DIG_CTRL1_MAC_AUTO_SW;
 
-       return xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_DIG_CTRL1, ret);
+       ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_DIG_CTRL1, ret);
+       if (ret < 0)
+               return ret;
+
+       if (phylink_autoneg_inband(mode))
+               ret = xpcs_write(xpcs, MDIO_MMD_VEND2, DW_VR_MII_MMD_CTRL,
+                                mdio_ctrl | AN_CL37_EN);
+
+       return ret;
 }
 
 static int xpcs_config_2500basex(struct dw_xpcs *xpcs)
index e79297a..27b6a3f 100644 (file)
 #define MII_BCM7XXX_SHD_2_ADDR_CTRL    0xe
 #define MII_BCM7XXX_SHD_2_CTRL_STAT    0xf
 #define MII_BCM7XXX_SHD_2_BIAS_TRIM    0x1a
+#define MII_BCM7XXX_SHD_3_PCS_CTRL     0x0
+#define MII_BCM7XXX_SHD_3_PCS_STATUS   0x1
+#define MII_BCM7XXX_SHD_3_EEE_CAP      0x2
 #define MII_BCM7XXX_SHD_3_AN_EEE_ADV   0x3
+#define MII_BCM7XXX_SHD_3_EEE_LP       0x4
+#define MII_BCM7XXX_SHD_3_EEE_WK_ERR   0x5
 #define MII_BCM7XXX_SHD_3_PCS_CTRL_2   0x6
 #define  MII_BCM7XXX_PCS_CTRL_2_DEF    0x4400
 #define MII_BCM7XXX_SHD_3_AN_STAT      0xb
@@ -216,25 +221,37 @@ static int bcm7xxx_28nm_resume(struct phy_device *phydev)
        return genphy_config_aneg(phydev);
 }
 
-static int phy_set_clr_bits(struct phy_device *dev, int location,
-                                       int set_mask, int clr_mask)
+static int __phy_set_clr_bits(struct phy_device *dev, int location,
+                             int set_mask, int clr_mask)
 {
        int v, ret;
 
-       v = phy_read(dev, location);
+       v = __phy_read(dev, location);
        if (v < 0)
                return v;
 
        v &= ~clr_mask;
        v |= set_mask;
 
-       ret = phy_write(dev, location, v);
+       ret = __phy_write(dev, location, v);
        if (ret < 0)
                return ret;
 
        return v;
 }
 
+static int phy_set_clr_bits(struct phy_device *dev, int location,
+                           int set_mask, int clr_mask)
+{
+       int ret;
+
+       mutex_lock(&dev->mdio.bus->mdio_lock);
+       ret = __phy_set_clr_bits(dev, location, set_mask, clr_mask);
+       mutex_unlock(&dev->mdio.bus->mdio_lock);
+
+       return ret;
+}
+
 static int bcm7xxx_28nm_ephy_01_afe_config_init(struct phy_device *phydev)
 {
        int ret;
@@ -398,6 +415,93 @@ static int bcm7xxx_28nm_ephy_config_init(struct phy_device *phydev)
        return bcm7xxx_28nm_ephy_apd_enable(phydev);
 }
 
+#define MII_BCM7XXX_REG_INVALID        0xff
+
+static u8 bcm7xxx_28nm_ephy_regnum_to_shd(u16 regnum)
+{
+       switch (regnum) {
+       case MDIO_CTRL1:
+               return MII_BCM7XXX_SHD_3_PCS_CTRL;
+       case MDIO_STAT1:
+               return MII_BCM7XXX_SHD_3_PCS_STATUS;
+       case MDIO_PCS_EEE_ABLE:
+               return MII_BCM7XXX_SHD_3_EEE_CAP;
+       case MDIO_AN_EEE_ADV:
+               return MII_BCM7XXX_SHD_3_AN_EEE_ADV;
+       case MDIO_AN_EEE_LPABLE:
+               return MII_BCM7XXX_SHD_3_EEE_LP;
+       case MDIO_PCS_EEE_WK_ERR:
+               return MII_BCM7XXX_SHD_3_EEE_WK_ERR;
+       default:
+               return MII_BCM7XXX_REG_INVALID;
+       }
+}
+
+static bool bcm7xxx_28nm_ephy_dev_valid(int devnum)
+{
+       return devnum == MDIO_MMD_AN || devnum == MDIO_MMD_PCS;
+}
+
+static int bcm7xxx_28nm_ephy_read_mmd(struct phy_device *phydev,
+                                     int devnum, u16 regnum)
+{
+       u8 shd = bcm7xxx_28nm_ephy_regnum_to_shd(regnum);
+       int ret;
+
+       if (!bcm7xxx_28nm_ephy_dev_valid(devnum) ||
+           shd == MII_BCM7XXX_REG_INVALID)
+               return -EOPNOTSUPP;
+
+       /* set shadow mode 2 */
+       ret = __phy_set_clr_bits(phydev, MII_BCM7XXX_TEST,
+                                MII_BCM7XXX_SHD_MODE_2, 0);
+       if (ret < 0)
+               return ret;
+
+       /* Access the desired shadow register address */
+       ret = __phy_write(phydev, MII_BCM7XXX_SHD_2_ADDR_CTRL, shd);
+       if (ret < 0)
+               goto reset_shadow_mode;
+
+       ret = __phy_read(phydev, MII_BCM7XXX_SHD_2_CTRL_STAT);
+
+reset_shadow_mode:
+       /* reset shadow mode 2 */
+       __phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, 0,
+                          MII_BCM7XXX_SHD_MODE_2);
+       return ret;
+}
+
+static int bcm7xxx_28nm_ephy_write_mmd(struct phy_device *phydev,
+                                      int devnum, u16 regnum, u16 val)
+{
+       u8 shd = bcm7xxx_28nm_ephy_regnum_to_shd(regnum);
+       int ret;
+
+       if (!bcm7xxx_28nm_ephy_dev_valid(devnum) ||
+           shd == MII_BCM7XXX_REG_INVALID)
+               return -EOPNOTSUPP;
+
+       /* set shadow mode 2 */
+       ret = __phy_set_clr_bits(phydev, MII_BCM7XXX_TEST,
+                                MII_BCM7XXX_SHD_MODE_2, 0);
+       if (ret < 0)
+               return ret;
+
+       /* Access the desired shadow register address */
+       ret = __phy_write(phydev, MII_BCM7XXX_SHD_2_ADDR_CTRL, shd);
+       if (ret < 0)
+               goto reset_shadow_mode;
+
+       /* Write the desired value in the shadow register */
+       __phy_write(phydev, MII_BCM7XXX_SHD_2_CTRL_STAT, val);
+
+reset_shadow_mode:
+       /* reset shadow mode 2 */
+       return __phy_set_clr_bits(phydev, MII_BCM7XXX_TEST, 0,
+                                 MII_BCM7XXX_SHD_MODE_2);
+}
+
 static int bcm7xxx_28nm_ephy_resume(struct phy_device *phydev)
 {
        int ret;
@@ -595,6 +699,8 @@ static void bcm7xxx_28nm_remove(struct phy_device *phydev)
        .get_stats      = bcm7xxx_28nm_get_phy_stats,                   \
        .probe          = bcm7xxx_28nm_probe,                           \
        .remove         = bcm7xxx_28nm_remove,                          \
+       .read_mmd       = bcm7xxx_28nm_ephy_read_mmd,                   \
+       .write_mmd      = bcm7xxx_28nm_ephy_write_mmd,                  \
 }
 
 #define BCM7XXX_40NM_EPHY(_oui, _name)                                 \
index 21aa24c..daae7fa 100644 (file)
@@ -5,7 +5,7 @@
 #ifndef HAVE_DP83640_REGISTERS
 #define HAVE_DP83640_REGISTERS
 
-#define PAGE0                     0x0000
+/* #define PAGE0                  0x0000 */
 #define PHYCR2                    0x001c /* PHY Control Register 2 */
 
 #define PAGE4                     0x0004
index 53f034f..6865d93 100644 (file)
@@ -525,6 +525,10 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
            NULL == bus->read || NULL == bus->write)
                return -EINVAL;
 
+       if (bus->parent && bus->parent->of_node)
+               bus->parent->of_node->fwnode.flags |=
+                                       FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD;
+
        BUG_ON(bus->state != MDIOBUS_ALLOCATED &&
               bus->state != MDIOBUS_UNREGISTERED);
 
@@ -534,6 +538,13 @@ int __mdiobus_register(struct mii_bus *bus, struct module *owner)
        bus->dev.groups = NULL;
        dev_set_name(&bus->dev, "%s", bus->id);
 
+       /* We need to set state to MDIOBUS_UNREGISTERED to correctly release
+        * the device in mdiobus_free()
+        *
+        * State will be updated later in this function in case of success
+        */
+       bus->state = MDIOBUS_UNREGISTERED;
+
        err = device_register(&bus->dev);
        if (err) {
                pr_err("mii_bus %s failed to register\n", bus->id);
index c94cb53..250742f 100644 (file)
@@ -179,6 +179,16 @@ static int mdio_remove(struct device *dev)
        return 0;
 }
 
+static void mdio_shutdown(struct device *dev)
+{
+       struct mdio_device *mdiodev = to_mdio_device(dev);
+       struct device_driver *drv = mdiodev->dev.driver;
+       struct mdio_driver *mdiodrv = to_mdio_driver(drv);
+
+       if (mdiodrv->shutdown)
+               mdiodrv->shutdown(mdiodev);
+}
+
 /**
  * mdio_driver_register - register an mdio_driver with the MDIO layer
  * @drv: new mdio_driver to register
@@ -193,6 +203,7 @@ int mdio_driver_register(struct mdio_driver *drv)
        mdiodrv->driver.bus = &mdio_bus_type;
        mdiodrv->driver.probe = mdio_probe;
        mdiodrv->driver.remove = mdio_remove;
+       mdiodrv->driver.shutdown = mdio_shutdown;
 
        retval = driver_register(&mdiodrv->driver);
        if (retval) {
index 2d5d508..5ce1bf0 100644 (file)
@@ -493,6 +493,25 @@ static int gpy_loopback(struct phy_device *phydev, bool enable)
        return ret;
 }
 
+static int gpy115_loopback(struct phy_device *phydev, bool enable)
+{
+       int ret;
+       int fw_minor;
+
+       if (enable)
+               return gpy_loopback(phydev, enable);
+
+       ret = phy_read(phydev, PHY_FWV);
+       if (ret < 0)
+               return ret;
+
+       fw_minor = FIELD_GET(PHY_FWV_MINOR_MASK, ret);
+       if (fw_minor > 0x0076)
+               return gpy_loopback(phydev, 0);
+
+       return genphy_soft_reset(phydev);
+}
+
 static struct phy_driver gpy_drivers[] = {
        {
                PHY_ID_MATCH_MODEL(PHY_ID_GPY2xx),
@@ -527,7 +546,7 @@ static struct phy_driver gpy_drivers[] = {
                .handle_interrupt = gpy_handle_interrupt,
                .set_wol        = gpy_set_wol,
                .get_wol        = gpy_get_wol,
-               .set_loopback   = gpy_loopback,
+               .set_loopback   = gpy115_loopback,
        },
        {
                PHY_ID_MATCH_MODEL(PHY_ID_GPY115C),
@@ -544,7 +563,7 @@ static struct phy_driver gpy_drivers[] = {
                .handle_interrupt = gpy_handle_interrupt,
                .set_wol        = gpy_set_wol,
                .get_wol        = gpy_get_wol,
-               .set_loopback   = gpy_loopback,
+               .set_loopback   = gpy115_loopback,
        },
        {
                .phy_id         = PHY_ID_GPY211B,
index 9e2891d..4f9990b 100644 (file)
@@ -233,9 +233,11 @@ static DEFINE_MUTEX(phy_fixup_lock);
 
 static bool mdio_bus_phy_may_suspend(struct phy_device *phydev)
 {
+       struct device_driver *drv = phydev->mdio.dev.driver;
+       struct phy_driver *phydrv = to_phy_driver(drv);
        struct net_device *netdev = phydev->attached_dev;
 
-       if (!phydev->drv->suspend)
+       if (!drv || !phydrv->suspend)
                return false;
 
        /* PHY not attached? May suspend if the PHY has not already been
@@ -3123,6 +3125,9 @@ static void phy_shutdown(struct device *dev)
 {
        struct phy_device *phydev = to_phy_device(dev);
 
+       if (phydev->state == PHY_READY || !phydev->attached_dev)
+               return;
+
        phy_disable_interrupts(phydev);
 }
 
index a1464b7..0a0abe8 100644 (file)
@@ -1607,6 +1607,32 @@ int phylink_ethtool_ksettings_set(struct phylink *pl,
        if (config.an_enabled && phylink_is_empty_linkmode(config.advertising))
                return -EINVAL;
 
+       /* If this link is with an SFP, ensure that changes to advertised modes
+        * also cause the associated interface to be selected such that the
+        * link can be configured correctly.
+        */
+       if (pl->sfp_port && pl->sfp_bus) {
+               config.interface = sfp_select_interface(pl->sfp_bus,
+                                                       config.advertising);
+               if (config.interface == PHY_INTERFACE_MODE_NA) {
+                       phylink_err(pl,
+                                   "selection of interface failed, advertisement %*pb\n",
+                                   __ETHTOOL_LINK_MODE_MASK_NBITS,
+                                   config.advertising);
+                       return -EINVAL;
+               }
+
+               /* Revalidate with the selected interface */
+               linkmode_copy(support, pl->supported);
+               if (phylink_validate(pl, support, &config)) {
+                       phylink_err(pl, "validation of %s/%s with support %*pb failed\n",
+                                   phylink_an_mode_str(pl->cur_link_an_mode),
+                                   phy_modes(config.interface),
+                                   __ETHTOOL_LINK_MODE_MASK_NBITS, support);
+                       return -EINVAL;
+               }
+       }
+
        mutex_lock(&pl->state_mutex);
        pl->link_config.speed = config.speed;
        pl->link_config.duplex = config.duplex;
@@ -2186,7 +2212,9 @@ static int phylink_sfp_config(struct phylink *pl, u8 mode,
        if (phy_interface_mode_is_8023z(iface) && pl->phydev)
                return -EINVAL;
 
-       changed = !linkmode_equal(pl->supported, support);
+       changed = !linkmode_equal(pl->supported, support) ||
+                 !linkmode_equal(pl->link_config.advertising,
+                                 config.advertising);
        if (changed) {
                linkmode_copy(pl->supported, support);
                linkmode_copy(pl->link_config.advertising, config.advertising);
index 34e9021..ab77a9f 100644 (file)
@@ -134,7 +134,7 @@ static const char * const sm_state_strings[] = {
        [SFP_S_LINK_UP] = "link_up",
        [SFP_S_TX_FAULT] = "tx_fault",
        [SFP_S_REINIT] = "reinit",
-       [SFP_S_TX_DISABLE] = "rx_disable",
+       [SFP_S_TX_DISABLE] = "tx_disable",
 };
 
 static const char *sm_state_to_str(unsigned short sm_state)
index 4c5d697..f87f175 100644 (file)
@@ -99,6 +99,10 @@ config USB_RTL8150
 config USB_RTL8152
        tristate "Realtek RTL8152/RTL8153 Based USB Ethernet Adapters"
        select MII
+       select CRC32
+       select CRYPTO
+       select CRYPTO_HASH
+       select CRYPTO_SHA256
        help
          This option adds support for Realtek RTL8152 based USB 2.0
          10/100 Ethernet adapters and RTL8153 based USB 3.0 10/100/1000
index a57251b..f97813a 100644 (file)
@@ -2719,14 +2719,14 @@ struct hso_device *hso_create_mux_serial_device(struct usb_interface *interface,
 
        serial = kzalloc(sizeof(*serial), GFP_KERNEL);
        if (!serial)
-               goto exit;
+               goto err_free_dev;
 
        hso_dev->port_data.dev_serial = serial;
        serial->parent = hso_dev;
 
        if (hso_serial_common_create
            (serial, 1, CTRL_URB_RX_SIZE, CTRL_URB_TX_SIZE))
-               goto exit;
+               goto err_free_serial;
 
        serial->tx_data_length--;
        serial->write_data = hso_mux_serial_write_data;
@@ -2742,11 +2742,9 @@ struct hso_device *hso_create_mux_serial_device(struct usb_interface *interface,
        /* done, return it */
        return hso_dev;
 
-exit:
-       if (serial) {
-               tty_unregister_device(tty_drv, serial->minor);
-               kfree(serial);
-       }
+err_free_serial:
+       kfree(serial);
+err_free_dev:
        kfree(hso_dev);
        return NULL;
 
index 60ba9b7..f329e39 100644 (file)
@@ -767,6 +767,7 @@ enum rtl8152_flags {
        PHY_RESET,
        SCHEDULE_TASKLET,
        GREEN_ETHERNET,
+       RX_EPROTO,
 };
 
 #define DEVICE_ID_THINKPAD_THUNDERBOLT3_DOCK_GEN2      0x3082
@@ -1770,6 +1771,14 @@ static void read_bulk_callback(struct urb *urb)
                rtl_set_unplug(tp);
                netif_device_detach(tp->netdev);
                return;
+       case -EPROTO:
+               urb->actual_length = 0;
+               spin_lock_irqsave(&tp->rx_lock, flags);
+               list_add_tail(&agg->list, &tp->rx_done);
+               spin_unlock_irqrestore(&tp->rx_lock, flags);
+               set_bit(RX_EPROTO, &tp->flags);
+               schedule_delayed_work(&tp->schedule, 1);
+               return;
        case -ENOENT:
                return; /* the urb is in unlink state */
        case -ETIME:
@@ -2425,6 +2434,7 @@ static int rx_bottom(struct r8152 *tp, int budget)
        if (list_empty(&tp->rx_done))
                goto out1;
 
+       clear_bit(RX_EPROTO, &tp->flags);
        INIT_LIST_HEAD(&rx_queue);
        spin_lock_irqsave(&tp->rx_lock, flags);
        list_splice_init(&tp->rx_done, &rx_queue);
@@ -2441,7 +2451,7 @@ static int rx_bottom(struct r8152 *tp, int budget)
 
                agg = list_entry(cursor, struct rx_agg, list);
                urb = agg->urb;
-               if (urb->actual_length < ETH_ZLEN)
+               if (urb->status != 0 || urb->actual_length < ETH_ZLEN)
                        goto submit;
 
                agg_free = rtl_get_free_rx(tp, GFP_ATOMIC);
@@ -6643,6 +6653,10 @@ static void rtl_work_func_t(struct work_struct *work)
            netif_carrier_ok(tp->netdev))
                tasklet_schedule(&tp->tx_tl);
 
+       if (test_and_clear_bit(RX_EPROTO, &tp->flags) &&
+           !list_empty(&tp->rx_done))
+               napi_schedule(&tp->napi);
+
        mutex_unlock(&tp->control);
 
 out1:
index 7d95397..26b1bd8 100644 (file)
@@ -1178,7 +1178,10 @@ static void smsc95xx_unbind(struct usbnet *dev, struct usb_interface *intf)
 
 static void smsc95xx_handle_link_change(struct net_device *net)
 {
+       struct usbnet *dev = netdev_priv(net);
+
        phy_print_status(net->phydev);
+       usbnet_defer_kevent(dev, EVENT_LINK_CHANGE);
 }
 
 static int smsc95xx_start_phy(struct usbnet *dev)
index 271d38c..4ad25a8 100644 (file)
@@ -406,7 +406,7 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi,
         * add_recvbuf_mergeable() + get_mergeable_buf_len()
         */
        truesize = headroom ? PAGE_SIZE : truesize;
-       tailroom = truesize - len - headroom;
+       tailroom = truesize - len - headroom - (hdr_padded_len - hdr_len);
        buf = p - headroom;
 
        len -= hdr_len;
@@ -423,6 +423,10 @@ static struct sk_buff *page_to_skb(struct virtnet_info *vi,
 
                skb_reserve(skb, p - buf);
                skb_put(skb, len);
+
+               page = (struct page *)page->private;
+               if (page)
+                       give_pages(rq, page);
                goto ok;
        }
 
index 5a8df5a..141635a 100644 (file)
@@ -4756,12 +4756,12 @@ static void __net_exit vxlan_exit_batch_net(struct list_head *net_list)
        LIST_HEAD(list);
        unsigned int h;
 
-       rtnl_lock();
        list_for_each_entry(net, net_list, exit_list) {
                struct vxlan_net *vn = net_generic(net, vxlan_net_id);
 
                unregister_nexthop_notifier(net, &vn->nexthop_notifier_block);
        }
+       rtnl_lock();
        list_for_each_entry(net, net_list, exit_list)
                vxlan_destroy_tunnels(net, &list);
 
index f6b92ef..480bcd1 100644 (file)
@@ -34,6 +34,8 @@ obj-$(CONFIG_SLIC_DS26522)    += slic_ds26522.o
 clean-files := wanxlfw.inc
 $(obj)/wanxl.o:        $(obj)/wanxlfw.inc
 
+CROSS_COMPILE_M68K = m68k-linux-gnu-
+
 ifeq ($(CONFIG_WANXL_BUILD_FIRMWARE),y)
 ifeq ($(ARCH),m68k)
   M68KCC = $(CC)
index 741289e..ca007b8 100644 (file)
@@ -44,7 +44,7 @@ config ATH10K_SNOC
        tristate "Qualcomm ath10k SNOC support"
        depends on ATH10K
        depends on ARCH_QCOM || COMPILE_TEST
-       depends on QCOM_SCM || !QCOM_SCM #if QCOM_SCM=m this can't be =y
+       select QCOM_SCM
        select QCOM_QMI_HELPERS
        help
          This module adds support for integrated WCN3990 chip connected
index f35cd8d..6914b37 100644 (file)
@@ -3,9 +3,7 @@ config ATH5K
        tristate "Atheros 5xxx wireless cards support"
        depends on (PCI || ATH25) && MAC80211
        select ATH_COMMON
-       select MAC80211_LEDS
-       select LEDS_CLASS
-       select NEW_LEDS
+       select MAC80211_LEDS if LEDS_CLASS=y || LEDS_CLASS=MAC80211
        select ATH5K_AHB if ATH25
        select ATH5K_PCI if !ATH25
        help
index 6a2a168..33e9928 100644 (file)
@@ -89,7 +89,8 @@ static const struct pci_device_id ath5k_led_devices[] = {
 
 void ath5k_led_enable(struct ath5k_hw *ah)
 {
-       if (test_bit(ATH_STAT_LEDSOFT, ah->status)) {
+       if (IS_ENABLED(CONFIG_MAC80211_LEDS) &&
+           test_bit(ATH_STAT_LEDSOFT, ah->status)) {
                ath5k_hw_set_gpio_output(ah, ah->led_pin);
                ath5k_led_off(ah);
        }
@@ -104,7 +105,8 @@ static void ath5k_led_on(struct ath5k_hw *ah)
 
 void ath5k_led_off(struct ath5k_hw *ah)
 {
-       if (!test_bit(ATH_STAT_LEDSOFT, ah->status))
+       if (!IS_ENABLED(CONFIG_MAC80211_LEDS) ||
+           !test_bit(ATH_STAT_LEDSOFT, ah->status))
                return;
        ath5k_hw_set_gpio(ah, ah->led_pin, !ah->led_on);
 }
@@ -146,7 +148,7 @@ ath5k_register_led(struct ath5k_hw *ah, struct ath5k_led *led,
 static void
 ath5k_unregister_led(struct ath5k_led *led)
 {
-       if (!led->ah)
+       if (!IS_ENABLED(CONFIG_MAC80211_LEDS) || !led->ah)
                return;
        led_classdev_unregister(&led->led_dev);
        ath5k_led_off(led->ah);
@@ -169,7 +171,7 @@ int ath5k_init_leds(struct ath5k_hw *ah)
        char name[ATH5K_LED_MAX_NAME_LEN + 1];
        const struct pci_device_id *match;
 
-       if (!ah->pdev)
+       if (!IS_ENABLED(CONFIG_MAC80211_LEDS) || !ah->pdev)
                return 0;
 
 #ifdef CONFIG_ATH5K_AHB
index f7b96cd..9db12ff 100644 (file)
@@ -7463,23 +7463,18 @@ static s32 brcmf_translate_country_code(struct brcmf_pub *drvr, char alpha2[2],
        s32 found_index;
        int i;
 
+       country_codes = drvr->settings->country_codes;
+       if (!country_codes) {
+               brcmf_dbg(TRACE, "No country codes configured for device\n");
+               return -EINVAL;
+       }
+
        if ((alpha2[0] == ccreq->country_abbrev[0]) &&
            (alpha2[1] == ccreq->country_abbrev[1])) {
                brcmf_dbg(TRACE, "Country code already set\n");
                return -EAGAIN;
        }
 
-       country_codes = drvr->settings->country_codes;
-       if (!country_codes) {
-               brcmf_dbg(TRACE, "No country codes configured for device, using ISO3166 code and 0 rev\n");
-               memset(ccreq, 0, sizeof(*ccreq));
-               ccreq->country_abbrev[0] = alpha2[0];
-               ccreq->country_abbrev[1] = alpha2[1];
-               ccreq->ccode[0] = alpha2[0];
-               ccreq->ccode[1] = alpha2[1];
-               return 0;
-       }
-
        found_index = -1;
        for (i = 0; i < country_codes->table_size; i++) {
                cc = &country_codes->table[i];
index 0e97d5e..9f706ff 100644 (file)
@@ -160,6 +160,7 @@ static void iwl_mvm_wowlan_program_keys(struct ieee80211_hw *hw,
                mvm->ptk_icvlen = key->icv_len;
                mvm->gtk_ivlen = key->iv_len;
                mvm->gtk_icvlen = key->icv_len;
+               mutex_unlock(&mvm->mutex);
 
                /* don't upload key again */
                return;
@@ -360,11 +361,11 @@ static void iwl_mvm_wowlan_get_rsc_v5_data(struct ieee80211_hw *hw,
        if (sta) {
                rsc = data->rsc->ucast_rsc;
        } else {
-               if (WARN_ON(data->gtks > ARRAY_SIZE(data->gtk_ids)))
+               if (WARN_ON(data->gtks >= ARRAY_SIZE(data->gtk_ids)))
                        return;
                data->gtk_ids[data->gtks] = key->keyidx;
                rsc = data->rsc->mcast_rsc[data->gtks % 2];
-               if (WARN_ON(key->keyidx >
+               if (WARN_ON(key->keyidx >=
                                ARRAY_SIZE(data->rsc->mcast_key_id_map)))
                        return;
                data->rsc->mcast_key_id_map[key->keyidx] = data->gtks % 2;
index 25af88a..e91f8e8 100644 (file)
@@ -662,12 +662,13 @@ static bool __iwl_mvm_remove_time_event(struct iwl_mvm *mvm,
                                        u32 *uid)
 {
        u32 id;
-       struct iwl_mvm_vif *mvmvif = iwl_mvm_vif_from_mac80211(te_data->vif);
+       struct iwl_mvm_vif *mvmvif;
        enum nl80211_iftype iftype;
 
        if (!te_data->vif)
                return false;
 
+       mvmvif = iwl_mvm_vif_from_mac80211(te_data->vif);
        iftype = te_data->vif->type;
 
        /*
index 61b2797..e3996ff 100644 (file)
@@ -547,6 +547,8 @@ static const struct iwl_dev_info iwl_dev_info_table[] = {
        IWL_DEV_INFO(0x43F0, 0x0074, iwl_ax201_cfg_qu_hr, NULL),
        IWL_DEV_INFO(0x43F0, 0x0078, iwl_ax201_cfg_qu_hr, NULL),
        IWL_DEV_INFO(0x43F0, 0x007C, iwl_ax201_cfg_qu_hr, NULL),
+       IWL_DEV_INFO(0x43F0, 0x1651, killer1650s_2ax_cfg_qu_b0_hr_b0, iwl_ax201_killer_1650s_name),
+       IWL_DEV_INFO(0x43F0, 0x1652, killer1650i_2ax_cfg_qu_b0_hr_b0, iwl_ax201_killer_1650i_name),
        IWL_DEV_INFO(0x43F0, 0x2074, iwl_ax201_cfg_qu_hr, NULL),
        IWL_DEV_INFO(0x43F0, 0x4070, iwl_ax201_cfg_qu_hr, NULL),
        IWL_DEV_INFO(0xA0F0, 0x0070, iwl_ax201_cfg_qu_hr, NULL),
index ffa894f..0adae76 100644 (file)
@@ -1867,8 +1867,8 @@ mac80211_hwsim_beacon(struct hrtimer *timer)
                bcn_int -= data->bcn_delta;
                data->bcn_delta = 0;
        }
-       hrtimer_forward(&data->beacon_timer, hrtimer_get_expires(timer),
-                       ns_to_ktime(bcn_int * NSEC_PER_USEC));
+       hrtimer_forward_now(&data->beacon_timer,
+                           ns_to_ktime(bcn_int * NSEC_PER_USEC));
        return HRTIMER_RESTART;
 }
 
index 2413053..a9b5eb9 100644 (file)
@@ -62,8 +62,8 @@ void *mwifiex_process_sta_txpd(struct mwifiex_private *priv,
 
        pkt_type = mwifiex_is_skb_mgmt_frame(skb) ? PKT_TYPE_MGMT : 0;
 
-       pad = ((void *)skb->data - (sizeof(*local_tx_pd) + hroom)-
-                        NULL) & (MWIFIEX_DMA_ALIGN_SZ - 1);
+       pad = ((uintptr_t)skb->data - (sizeof(*local_tx_pd) + hroom)) &
+              (MWIFIEX_DMA_ALIGN_SZ - 1);
        skb_push(skb, sizeof(*local_tx_pd) + pad);
 
        local_tx_pd = (struct txpd *) skb->data;
index 9bbdb8d..245ff64 100644 (file)
@@ -475,8 +475,8 @@ void *mwifiex_process_uap_txpd(struct mwifiex_private *priv,
 
        pkt_type = mwifiex_is_skb_mgmt_frame(skb) ? PKT_TYPE_MGMT : 0;
 
-       pad = ((void *)skb->data - (sizeof(*txpd) + hroom) - NULL) &
-                       (MWIFIEX_DMA_ALIGN_SZ - 1);
+       pad = ((uintptr_t)skb->data - (sizeof(*txpd) + hroom)) &
+              (MWIFIEX_DMA_ALIGN_SZ - 1);
 
        skb_push(skb, sizeof(*txpd) + pad);
 
index 39a01c2..32d5bc4 100644 (file)
@@ -499,7 +499,7 @@ check_frags:
                                 * the header's copy failed, and they are
                                 * sharing a slot, send an error
                                 */
-                               if (i == 0 && sharedslot)
+                               if (i == 0 && !first_shinfo && sharedslot)
                                        xenvif_idx_release(queue, pending_idx,
                                                           XEN_NETIF_RSP_ERROR);
                                else
index a620c34..0875b77 100644 (file)
@@ -278,6 +278,7 @@ static int st_nci_spi_remove(struct spi_device *dev)
 
 static struct spi_device_id st_nci_spi_id_table[] = {
        {ST_NCI_SPI_DRIVER_NAME, 0},
+       {"st21nfcb-spi", 0},
        {}
 };
 MODULE_DEVICE_TABLE(spi, st_nci_spi_id_table);
index 72de88f..ef4950f 100644 (file)
@@ -380,7 +380,6 @@ static int pmem_attach_disk(struct device *dev,
        struct nd_pfn_sb *pfn_sb;
        struct pmem_device *pmem;
        struct request_queue *q;
-       struct device *gendev;
        struct gendisk *disk;
        void *addr;
        int rc;
@@ -489,10 +488,8 @@ static int pmem_attach_disk(struct device *dev,
        }
        dax_write_cache(dax_dev, nvdimm_has_cache(nd_region));
        pmem->dax_dev = dax_dev;
-       gendev = disk_to_dev(disk);
-       gendev->groups = pmem_attribute_groups;
 
-       device_add_disk(dev, disk, NULL);
+       device_add_disk(dev, disk, pmem_attribute_groups);
        if (devm_add_action_or_reset(dev, pmem_release_disk, pmem))
                return -ENOMEM;
 
index 7efb31b..f8dd664 100644 (file)
@@ -13,7 +13,6 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/backing-dev.h>
-#include <linux/list_sort.h>
 #include <linux/slab.h>
 #include <linux/types.h>
 #include <linux/pr.h>
@@ -979,6 +978,7 @@ EXPORT_SYMBOL_GPL(nvme_cleanup_cmd);
 blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
 {
        struct nvme_command *cmd = nvme_req(req)->cmd;
+       struct nvme_ctrl *ctrl = nvme_req(req)->ctrl;
        blk_status_t ret = BLK_STS_OK;
 
        if (!(req->rq_flags & RQF_DONTPREP)) {
@@ -1027,7 +1027,8 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
                return BLK_STS_IOERR;
        }
 
-       nvme_req(req)->genctr++;
+       if (!(ctrl->quirks & NVME_QUIRK_SKIP_CID_GEN))
+               nvme_req(req)->genctr++;
        cmd->common.command_id = nvme_cid(req);
        trace_nvme_setup_cmd(req, cmd);
        return ret;
@@ -3524,7 +3525,9 @@ static struct nvme_ns_head *nvme_find_ns_head(struct nvme_subsystem *subsys,
        lockdep_assert_held(&subsys->lock);
 
        list_for_each_entry(h, &subsys->nsheads, entry) {
-               if (h->ns_id == nsid && nvme_tryget_ns_head(h))
+               if (h->ns_id != nsid)
+                       continue;
+               if (!list_empty(&h->list) && nvme_tryget_ns_head(h))
                        return h;
        }
 
@@ -3547,10 +3550,15 @@ static int __nvme_check_ids(struct nvme_subsystem *subsys,
        return 0;
 }
 
+static void nvme_cdev_rel(struct device *dev)
+{
+       ida_simple_remove(&nvme_ns_chr_minor_ida, MINOR(dev->devt));
+}
+
 void nvme_cdev_del(struct cdev *cdev, struct device *cdev_device)
 {
        cdev_device_del(cdev, cdev_device);
-       ida_simple_remove(&nvme_ns_chr_minor_ida, MINOR(cdev_device->devt));
+       put_device(cdev_device);
 }
 
 int nvme_cdev_add(struct cdev *cdev, struct device *cdev_device,
@@ -3563,14 +3571,14 @@ int nvme_cdev_add(struct cdev *cdev, struct device *cdev_device,
                return minor;
        cdev_device->devt = MKDEV(MAJOR(nvme_ns_chr_devt), minor);
        cdev_device->class = nvme_ns_chr_class;
+       cdev_device->release = nvme_cdev_rel;
        device_initialize(cdev_device);
        cdev_init(cdev, fops);
        cdev->owner = owner;
        ret = cdev_device_add(cdev, cdev_device);
-       if (ret) {
+       if (ret)
                put_device(cdev_device);
-               ida_simple_remove(&nvme_ns_chr_minor_ida, minor);
-       }
+
        return ret;
 }
 
@@ -3602,11 +3610,9 @@ static int nvme_add_ns_cdev(struct nvme_ns *ns)
                           ns->ctrl->instance, ns->head->instance);
        if (ret)
                return ret;
-       ret = nvme_cdev_add(&ns->cdev, &ns->cdev_device, &nvme_ns_chr_fops,
-                           ns->ctrl->ops->module);
-       if (ret)
-               kfree_const(ns->cdev_device.kobj.name);
-       return ret;
+
+       return nvme_cdev_add(&ns->cdev, &ns->cdev_device, &nvme_ns_chr_fops,
+                            ns->ctrl->ops->module);
 }
 
 static struct nvme_ns_head *nvme_alloc_ns_head(struct nvme_ctrl *ctrl,
@@ -3714,15 +3720,6 @@ out_unlock:
        return ret;
 }
 
-static int ns_cmp(void *priv, const struct list_head *a,
-               const struct list_head *b)
-{
-       struct nvme_ns *nsa = container_of(a, struct nvme_ns, list);
-       struct nvme_ns *nsb = container_of(b, struct nvme_ns, list);
-
-       return nsa->head->ns_id - nsb->head->ns_id;
-}
-
 struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
 {
        struct nvme_ns *ns, *ret = NULL;
@@ -3743,6 +3740,22 @@ struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
 }
 EXPORT_SYMBOL_NS_GPL(nvme_find_get_ns, NVME_TARGET_PASSTHRU);
 
+/*
+ * Add the namespace to the controller list while keeping the list ordered.
+ */
+static void nvme_ns_add_to_ctrl_list(struct nvme_ns *ns)
+{
+       struct nvme_ns *tmp;
+
+       list_for_each_entry_reverse(tmp, &ns->ctrl->namespaces, list) {
+               if (tmp->head->ns_id < ns->head->ns_id) {
+                       list_add(&ns->list, &tmp->list);
+                       return;
+               }
+       }
+       list_add(&ns->list, &ns->ctrl->namespaces);
+}
+
 static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid,
                struct nvme_ns_ids *ids)
 {
@@ -3793,9 +3806,8 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, unsigned nsid,
                goto out_unlink_ns;
 
        down_write(&ctrl->namespaces_rwsem);
-       list_add_tail(&ns->list, &ctrl->namespaces);
+       nvme_ns_add_to_ctrl_list(ns);
        up_write(&ctrl->namespaces_rwsem);
-
        nvme_get_ctrl(ctrl);
 
        if (device_add_disk(ctrl->device, ns->disk, nvme_ns_id_attr_groups))
@@ -3843,6 +3855,10 @@ static void nvme_ns_remove(struct nvme_ns *ns)
 
        mutex_lock(&ns->ctrl->subsys->lock);
        list_del_rcu(&ns->siblings);
+       if (list_empty(&ns->head->list)) {
+               list_del_init(&ns->head->entry);
+               last_path = true;
+       }
        mutex_unlock(&ns->ctrl->subsys->lock);
 
        /* guarantee not available in head->list */
@@ -3856,20 +3872,11 @@ static void nvme_ns_remove(struct nvme_ns *ns)
                nvme_cdev_del(&ns->cdev, &ns->cdev_device);
        del_gendisk(ns->disk);
        blk_cleanup_queue(ns->queue);
-       if (blk_get_integrity(ns->disk))
-               blk_integrity_unregister(ns->disk);
 
        down_write(&ns->ctrl->namespaces_rwsem);
        list_del_init(&ns->list);
        up_write(&ns->ctrl->namespaces_rwsem);
 
-       /* Synchronize with nvme_init_ns_head() */
-       mutex_lock(&ns->head->subsys->lock);
-       if (list_empty(&ns->head->list)) {
-               list_del_init(&ns->head->entry);
-               last_path = true;
-       }
-       mutex_unlock(&ns->head->subsys->lock);
        if (last_path)
                nvme_mpath_shutdown_disk(ns->head);
        nvme_put_ns(ns);
@@ -4083,10 +4090,6 @@ static void nvme_scan_work(struct work_struct *work)
        if (nvme_scan_ns_list(ctrl) != 0)
                nvme_scan_ns_sequential(ctrl);
        mutex_unlock(&ctrl->scan_lock);
-
-       down_write(&ctrl->namespaces_rwsem);
-       list_sort(NULL, &ctrl->namespaces, ns_cmp);
-       up_write(&ctrl->namespaces_rwsem);
 }
 
 /*
index b08a61c..aa14ad9 100644 (file)
@@ -2487,6 +2487,7 @@ __nvme_fc_abort_outstanding_ios(struct nvme_fc_ctrl *ctrl, bool start_queues)
         */
        if (ctrl->ctrl.queue_count > 1) {
                nvme_stop_queues(&ctrl->ctrl);
+               nvme_sync_io_queues(&ctrl->ctrl);
                blk_mq_tagset_busy_iter(&ctrl->tag_set,
                                nvme_fc_terminate_exchange, &ctrl->ctrl);
                blk_mq_tagset_wait_completed_request(&ctrl->tag_set);
@@ -2510,6 +2511,7 @@ __nvme_fc_abort_outstanding_ios(struct nvme_fc_ctrl *ctrl, bool start_queues)
         * clean up the admin queue. Same thing as above.
         */
        blk_mq_quiesce_queue(ctrl->ctrl.admin_q);
+       blk_sync_queue(ctrl->ctrl.admin_q);
        blk_mq_tagset_busy_iter(&ctrl->admin_tag_set,
                                nvme_fc_terminate_exchange, &ctrl->ctrl);
        blk_mq_tagset_wait_completed_request(&ctrl->admin_tag_set);
@@ -2951,6 +2953,13 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ctrl)
        if (ctrl->ctrl.queue_count == 1)
                return 0;
 
+       if (prior_ioq_cnt != nr_io_queues) {
+               dev_info(ctrl->ctrl.device,
+                       "reconnect: revising io queue count from %d to %d\n",
+                       prior_ioq_cnt, nr_io_queues);
+               blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
+       }
+
        ret = nvme_fc_create_hw_io_queues(ctrl, ctrl->ctrl.sqsize + 1);
        if (ret)
                goto out_free_io_queues;
@@ -2959,15 +2968,6 @@ nvme_fc_recreate_io_queues(struct nvme_fc_ctrl *ctrl)
        if (ret)
                goto out_delete_hw_queues;
 
-       if (prior_ioq_cnt != nr_io_queues) {
-               dev_info(ctrl->ctrl.device,
-                       "reconnect: revising io queue count from %d to %d\n",
-                       prior_ioq_cnt, nr_io_queues);
-               nvme_wait_freeze(&ctrl->ctrl);
-               blk_mq_update_nr_hw_queues(&ctrl->tag_set, nr_io_queues);
-               nvme_unfreeze(&ctrl->ctrl);
-       }
-
        return 0;
 
 out_delete_hw_queues:
index 5d7bc58..fba0661 100644 (file)
@@ -431,8 +431,6 @@ static int nvme_add_ns_head_cdev(struct nvme_ns_head *head)
                return ret;
        ret = nvme_cdev_add(&head->cdev, &head->cdev_device,
                            &nvme_ns_head_chr_fops, THIS_MODULE);
-       if (ret)
-               kfree_const(head->cdev_device.kobj.name);
        return ret;
 }
 
@@ -600,14 +598,17 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl,
 
        down_read(&ctrl->namespaces_rwsem);
        list_for_each_entry(ns, &ctrl->namespaces, list) {
-               unsigned nsid = le32_to_cpu(desc->nsids[n]);
-
+               unsigned nsid;
+again:
+               nsid = le32_to_cpu(desc->nsids[n]);
                if (ns->head->ns_id < nsid)
                        continue;
                if (ns->head->ns_id == nsid)
                        nvme_update_ns_ana_state(desc, ns);
                if (++n == nr_nsids)
                        break;
+               if (ns->head->ns_id > nsid)
+                       goto again;
        }
        up_read(&ctrl->namespaces_rwsem);
        return 0;
index 9871c0c..ed79a6c 100644 (file)
@@ -138,6 +138,12 @@ enum nvme_quirks {
         * 48 bits.
         */
        NVME_QUIRK_DMA_ADDRESS_BITS_48          = (1 << 16),
+
+       /*
+        * The controller requires the command_id value be be limited, so skip
+        * encoding the generation sequence number.
+        */
+       NVME_QUIRK_SKIP_CID_GEN                 = (1 << 17),
 };
 
 /*
index b82492c..149ecf7 100644 (file)
@@ -1330,7 +1330,7 @@ static enum blk_eh_timer_return nvme_timeout(struct request *req, bool reserved)
        iod->aborted = 1;
 
        cmd.abort.opcode = nvme_admin_abort_cmd;
-       cmd.abort.cid = req->tag;
+       cmd.abort.cid = nvme_cid(req);
        cmd.abort.sqid = cpu_to_le16(nvmeq->qid);
 
        dev_warn(nvmeq->dev->ctrl.device,
@@ -3369,7 +3369,8 @@ static const struct pci_device_id nvme_id_table[] = {
        { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2005),
                .driver_data = NVME_QUIRK_SINGLE_VECTOR |
                                NVME_QUIRK_128_BYTES_SQES |
-                               NVME_QUIRK_SHARED_TAGS },
+                               NVME_QUIRK_SHARED_TAGS |
+                               NVME_QUIRK_SKIP_CID_GEN },
 
        { PCI_DEVICE_CLASS(PCI_CLASS_STORAGE_EXPRESS, 0xffffff) },
        { 0, }
index a68704e..042c594 100644 (file)
@@ -656,8 +656,8 @@ static void nvme_rdma_free_queue(struct nvme_rdma_queue *queue)
        if (!test_and_clear_bit(NVME_RDMA_Q_ALLOCATED, &queue->flags))
                return;
 
-       nvme_rdma_destroy_queue_ib(queue);
        rdma_destroy_id(queue->cm_id);
+       nvme_rdma_destroy_queue_ib(queue);
        mutex_destroy(&queue->queue_lock);
 }
 
@@ -1815,14 +1815,10 @@ static int nvme_rdma_conn_established(struct nvme_rdma_queue *queue)
        for (i = 0; i < queue->queue_size; i++) {
                ret = nvme_rdma_post_recv(queue, &queue->rsp_ring[i]);
                if (ret)
-                       goto out_destroy_queue_ib;
+                       return ret;
        }
 
        return 0;
-
-out_destroy_queue_ib:
-       nvme_rdma_destroy_queue_ib(queue);
-       return ret;
 }
 
 static int nvme_rdma_conn_rejected(struct nvme_rdma_queue *queue,
@@ -1916,14 +1912,10 @@ static int nvme_rdma_route_resolved(struct nvme_rdma_queue *queue)
        if (ret) {
                dev_err(ctrl->ctrl.device,
                        "rdma_connect_locked failed (%d).\n", ret);
-               goto out_destroy_queue_ib;
+               return ret;
        }
 
        return 0;
-
-out_destroy_queue_ib:
-       nvme_rdma_destroy_queue_ib(queue);
-       return ret;
 }
 
 static int nvme_rdma_cm_handler(struct rdma_cm_id *cm_id,
@@ -1954,8 +1946,6 @@ static int nvme_rdma_cm_handler(struct rdma_cm_id *cm_id,
        case RDMA_CM_EVENT_ROUTE_ERROR:
        case RDMA_CM_EVENT_CONNECT_ERROR:
        case RDMA_CM_EVENT_UNREACHABLE:
-               nvme_rdma_destroy_queue_ib(queue);
-               fallthrough;
        case RDMA_CM_EVENT_ADDR_ERROR:
                dev_dbg(queue->ctrl->ctrl.device,
                        "CM error event %d\n", ev->event);
index e2ab12f..3c1c29d 100644 (file)
@@ -274,6 +274,12 @@ static inline void nvme_tcp_send_all(struct nvme_tcp_queue *queue)
        } while (ret > 0);
 }
 
+static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)
+{
+       return !list_empty(&queue->send_list) ||
+               !llist_empty(&queue->req_list) || queue->more_requests;
+}
+
 static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req,
                bool sync, bool last)
 {
@@ -294,9 +300,10 @@ static inline void nvme_tcp_queue_request(struct nvme_tcp_request *req,
                nvme_tcp_send_all(queue);
                queue->more_requests = false;
                mutex_unlock(&queue->send_mutex);
-       } else if (last) {
-               queue_work_on(queue->io_cpu, nvme_tcp_wq, &queue->io_work);
        }
+
+       if (last && nvme_tcp_queue_more(queue))
+               queue_work_on(queue->io_cpu, nvme_tcp_wq, &queue->io_work);
 }
 
 static void nvme_tcp_process_req_list(struct nvme_tcp_queue *queue)
@@ -613,7 +620,7 @@ static int nvme_tcp_setup_h2c_data_pdu(struct nvme_tcp_request *req,
                cpu_to_le32(data->hdr.hlen + hdgst + req->pdu_len + ddgst);
        data->ttag = pdu->ttag;
        data->command_id = nvme_cid(rq);
-       data->data_offset = cpu_to_le32(req->data_sent);
+       data->data_offset = pdu->r2t_offset;
        data->data_length = cpu_to_le32(req->pdu_len);
        return 0;
 }
@@ -906,12 +913,6 @@ done:
        read_unlock_bh(&sk->sk_callback_lock);
 }
 
-static inline bool nvme_tcp_queue_more(struct nvme_tcp_queue *queue)
-{
-       return !list_empty(&queue->send_list) ||
-               !llist_empty(&queue->req_list) || queue->more_requests;
-}
-
 static inline void nvme_tcp_done_send_req(struct nvme_tcp_queue *queue)
 {
        queue->request = NULL;
@@ -952,7 +953,15 @@ static int nvme_tcp_try_send_data(struct nvme_tcp_request *req)
                        nvme_tcp_ddgst_update(queue->snd_hash, page,
                                        offset, ret);
 
-               /* fully successful last write*/
+               /*
+                * update the request iterator except for the last payload send
+                * in the request where we don't want to modify it as we may
+                * compete with the RX path completing the request.
+                */
+               if (req->data_sent + ret < req->data_len)
+                       nvme_tcp_advance_req(req, ret);
+
+               /* fully successful last send in current PDU */
                if (last && ret == len) {
                        if (queue->data_digest) {
                                nvme_tcp_ddgst_final(queue->snd_hash,
@@ -964,7 +973,6 @@ static int nvme_tcp_try_send_data(struct nvme_tcp_request *req)
                        }
                        return 1;
                }
-               nvme_tcp_advance_req(req, ret);
        }
        return -EAGAIN;
 }
@@ -1145,8 +1153,7 @@ static void nvme_tcp_io_work(struct work_struct *w)
                                pending = true;
                        else if (unlikely(result < 0))
                                break;
-               } else
-                       pending = !llist_empty(&queue->req_list);
+               }
 
                result = nvme_tcp_try_recv(queue);
                if (result > 0)
index d784f3c..be5d824 100644 (file)
@@ -1067,7 +1067,7 @@ static ssize_t nvmet_subsys_attr_serial_show(struct config_item *item,
 {
        struct nvmet_subsys *subsys = to_subsys(item);
 
-       return snprintf(page, PAGE_SIZE, "%*s\n",
+       return snprintf(page, PAGE_SIZE, "%.*s\n",
                        NVMET_SN_MAX_SIZE, subsys->serial);
 }
 
index 39854d4..da41461 100644 (file)
@@ -109,6 +109,7 @@ config MTK_EFUSE
 
 config NVMEM_NINTENDO_OTP
        tristate "Nintendo Wii and Wii U OTP Support"
+       depends on WII || COMPILE_TEST
        help
          This is a driver exposing the OTP of a Nintendo Wii or Wii U console.
 
index 3d87fad..8976da3 100644 (file)
@@ -1383,7 +1383,8 @@ static void nvmem_shift_read_buffer_in_place(struct nvmem_cell *cell, void *buf)
                *p-- = 0;
 
        /* clear msb bits if any leftover in the last byte */
-       *p &= GENMASK((cell->nbits%BITS_PER_BYTE) - 1, 0);
+       if (cell->nbits % BITS_PER_BYTE)
+               *p &= GENMASK((cell->nbits % BITS_PER_BYTE) - 1, 0);
 }
 
 static int __nvmem_cell_read(struct nvmem_device *nvmem,
index f720c0d..0ac1725 100644 (file)
@@ -36,6 +36,7 @@ LIST_HEAD(aliases_lookup);
 struct device_node *of_root;
 EXPORT_SYMBOL(of_root);
 struct device_node *of_chosen;
+EXPORT_SYMBOL(of_chosen);
 struct device_node *of_aliases;
 struct device_node *of_stdout;
 static const char *of_stdout_options;
index 5b043ee..b0800c2 100644 (file)
@@ -85,7 +85,11 @@ of_dma_set_restricted_buffer(struct device *dev, struct device_node *np)
                        break;
        }
 
-       if (i != count && of_reserved_mem_device_init_by_idx(dev, of_node, i))
+       /*
+        * Attempt to initialize a restricted-dma-pool region if one was found.
+        * Note that count can hold a negative error code.
+        */
+       if (i < count && of_reserved_mem_device_init_by_idx(dev, of_node, i))
                dev_warn(dev, "failed to initialise \"restricted-dma-pool\" memory node\n");
 }
 
index 3fd74bb..a348348 100644 (file)
@@ -1291,7 +1291,6 @@ DEFINE_SIMPLE_PROP(pwms, "pwms", "#pwm-cells")
 DEFINE_SIMPLE_PROP(resets, "resets", "#reset-cells")
 DEFINE_SIMPLE_PROP(leds, "leds", NULL)
 DEFINE_SIMPLE_PROP(backlight, "backlight", NULL)
-DEFINE_SIMPLE_PROP(phy_handle, "phy-handle", NULL)
 DEFINE_SUFFIX_PROP(regulators, "-supply", NULL)
 DEFINE_SUFFIX_PROP(gpio, "-gpio", "#gpio-cells")
 
@@ -1380,7 +1379,6 @@ static const struct supplier_bindings of_supplier_bindings[] = {
        { .parse_prop = parse_resets, },
        { .parse_prop = parse_leds, },
        { .parse_prop = parse_backlight, },
-       { .parse_prop = parse_phy_handle, },
        { .parse_prop = parse_gpio_compat, },
        { .parse_prop = parse_interrupts, },
        { .parse_prop = parse_regulators, },
index 0c473d7..43e615a 100644 (file)
@@ -110,7 +110,7 @@ config PCI_PF_STUB
 
 config XEN_PCIDEV_FRONTEND
        tristate "Xen PCI Frontend"
-       depends on X86 && XEN
+       depends on XEN_PV
        select PCI_XEN
        select XEN_XENBUS_FRONTEND
        default y
index eaec915..67c46e5 100644 (file)
@@ -3301,9 +3301,17 @@ static int hv_pci_bus_exit(struct hv_device *hdev, bool keep_devs)
                return 0;
 
        if (!keep_devs) {
-               /* Delete any children which might still exist. */
+               struct list_head removed;
+
+               /* Move all present children to the list on stack */
+               INIT_LIST_HEAD(&removed);
                spin_lock_irqsave(&hbus->device_list_lock, flags);
-               list_for_each_entry_safe(hpdev, tmp, &hbus->children, list_entry) {
+               list_for_each_entry_safe(hpdev, tmp, &hbus->children, list_entry)
+                       list_move_tail(&hpdev->list_entry, &removed);
+               spin_unlock_irqrestore(&hbus->device_list_lock, flags);
+
+               /* Remove all children in the list */
+               list_for_each_entry_safe(hpdev, tmp, &removed, list_entry) {
                        list_del(&hpdev->list_entry);
                        if (hpdev->pci_slot)
                                pci_destroy_slot(hpdev->pci_slot);
@@ -3311,7 +3319,6 @@ static int hv_pci_bus_exit(struct hv_device *hdev, bool keep_devs)
                        put_pcichild(hpdev);
                        put_pcichild(hpdev);
                }
-               spin_unlock_irqrestore(&hbus->device_list_lock, flags);
        }
 
        ret = hv_send_resources_released(hdev);
index 0148687..dcefdb4 100644 (file)
@@ -62,14 +62,7 @@ static int get_power_status(struct hotplug_slot *hotplug_slot, u8 *value)
        struct zpci_dev *zdev = container_of(hotplug_slot, struct zpci_dev,
                                             hotplug_slot);
 
-       switch (zdev->state) {
-       case ZPCI_FN_STATE_STANDBY:
-               *value = 0;
-               break;
-       default:
-               *value = 1;
-               break;
-       }
+       *value = zpci_is_device_configured(zdev) ? 1 : 0;
        return 0;
 }
 
index 0099a00..4b47929 100644 (file)
@@ -535,6 +535,7 @@ static int msi_verify_entries(struct pci_dev *dev)
 static int msi_capability_init(struct pci_dev *dev, int nvec,
                               struct irq_affinity *affd)
 {
+       const struct attribute_group **groups;
        struct msi_desc *entry;
        int ret;
 
@@ -558,12 +559,14 @@ static int msi_capability_init(struct pci_dev *dev, int nvec,
        if (ret)
                goto err;
 
-       dev->msi_irq_groups = msi_populate_sysfs(&dev->dev);
-       if (IS_ERR(dev->msi_irq_groups)) {
-               ret = PTR_ERR(dev->msi_irq_groups);
+       groups = msi_populate_sysfs(&dev->dev);
+       if (IS_ERR(groups)) {
+               ret = PTR_ERR(groups);
                goto err;
        }
 
+       dev->msi_irq_groups = groups;
+
        /* Set MSI enabled bits */
        pci_intx_for_msi(dev, 0);
        pci_msi_set_enable(dev, 1);
@@ -691,6 +694,7 @@ static void msix_mask_all(void __iomem *base, int tsize)
 static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
                                int nvec, struct irq_affinity *affd)
 {
+       const struct attribute_group **groups;
        void __iomem *base;
        int ret, tsize;
        u16 control;
@@ -730,12 +734,14 @@ static int msix_capability_init(struct pci_dev *dev, struct msix_entry *entries,
 
        msix_update_entries(dev, entries);
 
-       dev->msi_irq_groups = msi_populate_sysfs(&dev->dev);
-       if (IS_ERR(dev->msi_irq_groups)) {
-               ret = PTR_ERR(dev->msi_irq_groups);
+       groups = msi_populate_sysfs(&dev->dev);
+       if (IS_ERR(groups)) {
+               ret = PTR_ERR(groups);
                goto out_free;
        }
 
+       dev->msi_irq_groups = groups;
+
        /* Set MSI-X enabled bits and unmask the function */
        pci_intx_for_msi(dev, 0);
        dev->msix_enabled = 1;
index a1b1e2a..260a06f 100644 (file)
@@ -937,7 +937,7 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev);
 
 void pci_set_acpi_fwnode(struct pci_dev *dev)
 {
-       if (!ACPI_COMPANION(&dev->dev) && !pci_dev_is_added(dev))
+       if (!dev_fwnode(&dev->dev) && !pci_dev_is_added(dev))
                ACPI_COMPANION_SET(&dev->dev,
                                   acpi_pci_find_companion(&dev->dev));
 }
@@ -1249,6 +1249,9 @@ static struct acpi_device *acpi_pci_find_companion(struct device *dev)
        bool check_children;
        u64 addr;
 
+       if (!dev->parent)
+               return NULL;
+
        down_read(&pci_acpi_companion_lookup_sem);
 
        adev = pci_acpi_find_companion_hook ?
index e5089af..4537d1e 100644 (file)
@@ -5435,7 +5435,7 @@ DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
                              PCI_CLASS_MULTIMEDIA_HD_AUDIO, 8, quirk_gpu_hda);
 
 /*
- * Create device link for NVIDIA GPU with integrated USB xHCI Host
+ * Create device link for GPUs with integrated USB xHCI Host
  * controller to VGA.
  */
 static void quirk_gpu_usb(struct pci_dev *usb)
@@ -5444,9 +5444,11 @@ static void quirk_gpu_usb(struct pci_dev *usb)
 }
 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
                              PCI_CLASS_SERIAL_USB, 8, quirk_gpu_usb);
+DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID,
+                             PCI_CLASS_SERIAL_USB, 8, quirk_gpu_usb);
 
 /*
- * Create device link for NVIDIA GPU with integrated Type-C UCSI controller
+ * Create device link for GPUs with integrated Type-C UCSI controller
  * to VGA. Currently there is no class code defined for UCSI device over PCI
  * so using UNKNOWN class for now and it will be updated when UCSI
  * over PCI gets a class code.
@@ -5459,6 +5461,9 @@ static void quirk_gpu_usb_typec_ucsi(struct pci_dev *ucsi)
 DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, PCI_ANY_ID,
                              PCI_CLASS_SERIAL_UNKNOWN, 8,
                              quirk_gpu_usb_typec_ucsi);
+DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_ATI, PCI_ANY_ID,
+                             PCI_CLASS_SERIAL_UNKNOWN, 8,
+                             quirk_gpu_usb_typec_ucsi);
 
 /*
  * Enable the NVIDIA GPU integrated HDA controller if the BIOS left it
index 25557b2..4be2489 100644 (file)
@@ -99,6 +99,24 @@ error:
        return off ?: PCI_VPD_SZ_INVALID;
 }
 
+static bool pci_vpd_available(struct pci_dev *dev)
+{
+       struct pci_vpd *vpd = &dev->vpd;
+
+       if (!vpd->cap)
+               return false;
+
+       if (vpd->len == 0) {
+               vpd->len = pci_vpd_size(dev);
+               if (vpd->len == PCI_VPD_SZ_INVALID) {
+                       vpd->cap = 0;
+                       return false;
+               }
+       }
+
+       return true;
+}
+
 /*
  * Wait for last operation to complete.
  * This code has to spin since there is no other notification from the PCI
@@ -145,7 +163,7 @@ static ssize_t pci_vpd_read(struct pci_dev *dev, loff_t pos, size_t count,
        loff_t end = pos + count;
        u8 *buf = arg;
 
-       if (!vpd->cap)
+       if (!pci_vpd_available(dev))
                return -ENODEV;
 
        if (pos < 0)
@@ -206,7 +224,7 @@ static ssize_t pci_vpd_write(struct pci_dev *dev, loff_t pos, size_t count,
        loff_t end = pos + count;
        int ret = 0;
 
-       if (!vpd->cap)
+       if (!pci_vpd_available(dev))
                return -ENODEV;
 
        if (pos < 0 || (pos & 3) || (count & 3))
@@ -242,14 +260,11 @@ static ssize_t pci_vpd_write(struct pci_dev *dev, loff_t pos, size_t count,
 
 void pci_vpd_init(struct pci_dev *dev)
 {
+       if (dev->vpd.len == PCI_VPD_SZ_INVALID)
+               return;
+
        dev->vpd.cap = pci_find_capability(dev, PCI_CAP_ID_VPD);
        mutex_init(&dev->vpd.lock);
-
-       if (!dev->vpd.len)
-               dev->vpd.len = pci_vpd_size(dev);
-
-       if (dev->vpd.len == PCI_VPD_SZ_INVALID)
-               dev->vpd.cap = 0;
 }
 
 static ssize_t vpd_read(struct file *filp, struct kobject *kobj,
@@ -294,13 +309,14 @@ const struct attribute_group pci_dev_vpd_attr_group = {
 
 void *pci_vpd_alloc(struct pci_dev *dev, unsigned int *size)
 {
-       unsigned int len = dev->vpd.len;
+       unsigned int len;
        void *buf;
        int cnt;
 
-       if (!dev->vpd.cap)
+       if (!pci_vpd_available(dev))
                return ERR_PTR(-ENODEV);
 
+       len = dev->vpd.len;
        buf = kmalloc(len, GFP_KERNEL);
        if (!buf)
                return ERR_PTR(-ENOMEM);
index 3cbc3ba..295cc79 100644 (file)
@@ -952,6 +952,8 @@ int armpmu_register(struct arm_pmu *pmu)
                pmu->name, pmu->num_events,
                has_nmi ? ", using NMIs" : "");
 
+       kvm_host_pmu_init(pmu);
+
        return 0;
 
 out_destroy:
index a4ac87c..5082102 100644 (file)
@@ -2306,7 +2306,7 @@ EXPORT_SYMBOL_GPL(devm_pinctrl_register_and_init);
 
 /**
  * devm_pinctrl_unregister() - Resource managed version of pinctrl_unregister().
- * @dev: device for which which resource was allocated
+ * @dev: device for which resource was allocated
  * @pctldev: the pinctrl device to unregister.
  */
 void devm_pinctrl_unregister(struct device *dev, struct pinctrl_dev *pctldev)
index c001f2e..8d0f88e 100644 (file)
@@ -445,6 +445,7 @@ static int amd_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
        struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
        struct amd_gpio *gpio_dev = gpiochip_get_data(gc);
        u32 wake_mask = BIT(WAKE_CNTRL_OFF_S0I3) | BIT(WAKE_CNTRL_OFF_S3);
+       int err;
 
        raw_spin_lock_irqsave(&gpio_dev->lock, flags);
        pin_reg = readl(gpio_dev->base + (d->hwirq)*4);
@@ -457,6 +458,15 @@ static int amd_gpio_irq_set_wake(struct irq_data *d, unsigned int on)
        writel(pin_reg, gpio_dev->base + (d->hwirq)*4);
        raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);
 
+       if (on)
+               err = enable_irq_wake(gpio_dev->irq);
+       else
+               err = disable_irq_wake(gpio_dev->irq);
+
+       if (err)
+               dev_err(&gpio_dev->pdev->dev, "failed to %s wake-up interrupt\n",
+                       on ? "enable" : "disable");
+
        return 0;
 }
 
@@ -902,7 +912,6 @@ static struct pinctrl_desc amd_pinctrl_desc = {
 static int amd_gpio_probe(struct platform_device *pdev)
 {
        int ret = 0;
-       int irq_base;
        struct resource *res;
        struct amd_gpio *gpio_dev;
        struct gpio_irq_chip *girq;
@@ -925,9 +934,9 @@ static int amd_gpio_probe(struct platform_device *pdev)
        if (!gpio_dev->base)
                return -ENOMEM;
 
-       irq_base = platform_get_irq(pdev, 0);
-       if (irq_base < 0)
-               return irq_base;
+       gpio_dev->irq = platform_get_irq(pdev, 0);
+       if (gpio_dev->irq < 0)
+               return gpio_dev->irq;
 
 #ifdef CONFIG_PM_SLEEP
        gpio_dev->saved_regs = devm_kcalloc(&pdev->dev, amd_pinctrl_desc.npins,
@@ -987,7 +996,7 @@ static int amd_gpio_probe(struct platform_device *pdev)
                goto out2;
        }
 
-       ret = devm_request_irq(&pdev->dev, irq_base, amd_gpio_irq_handler,
+       ret = devm_request_irq(&pdev->dev, gpio_dev->irq, amd_gpio_irq_handler,
                               IRQF_SHARED, KBUILD_MODNAME, gpio_dev);
        if (ret)
                goto out2;
index 95e7634..1d43170 100644 (file)
@@ -98,6 +98,7 @@ struct amd_gpio {
        struct resource         *res;
        struct platform_device  *pdev;
        u32                     *saved_regs;
+       int                     irq;
 };
 
 /*  KERNCZ configuration*/
index ae33e37..5ce260f 100644 (file)
@@ -2092,6 +2092,23 @@ static bool rockchip_pinconf_pull_valid(struct rockchip_pin_ctrl *ctrl,
        return false;
 }
 
+static int rockchip_pinconf_defer_output(struct rockchip_pin_bank *bank,
+                                        unsigned int pin, u32 arg)
+{
+       struct rockchip_pin_output_deferred *cfg;
+
+       cfg = kzalloc(sizeof(*cfg), GFP_KERNEL);
+       if (!cfg)
+               return -ENOMEM;
+
+       cfg->pin = pin;
+       cfg->arg = arg;
+
+       list_add_tail(&cfg->head, &bank->deferred_output);
+
+       return 0;
+}
+
 /* set the pin config settings for a specified pin */
 static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                                unsigned long *configs, unsigned num_configs)
@@ -2136,6 +2153,22 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
                        if (rc != RK_FUNC_GPIO)
                                return -EINVAL;
 
+                       /*
+                        * Check for gpio driver not being probed yet.
+                        * The lock makes sure that either gpio-probe has completed
+                        * or the gpio driver hasn't probed yet.
+                        */
+                       mutex_lock(&bank->deferred_lock);
+                       if (!gpio || !gpio->direction_output) {
+                               rc = rockchip_pinconf_defer_output(bank, pin - bank->pin_base, arg);
+                               mutex_unlock(&bank->deferred_lock);
+                               if (rc)
+                                       return rc;
+
+                               break;
+                       }
+                       mutex_unlock(&bank->deferred_lock);
+
                        rc = gpio->direction_output(gpio, pin - bank->pin_base,
                                                    arg);
                        if (rc)
@@ -2204,6 +2237,11 @@ static int rockchip_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
                if (rc != RK_FUNC_GPIO)
                        return -EINVAL;
 
+               if (!gpio || !gpio->get) {
+                       arg = 0;
+                       break;
+               }
+
                rc = gpio->get(gpio, pin - bank->pin_base);
                if (rc < 0)
                        return rc;
@@ -2450,6 +2488,9 @@ static int rockchip_pinctrl_register(struct platform_device *pdev,
                                                pin_bank->name, pin);
                        pdesc++;
                }
+
+               INIT_LIST_HEAD(&pin_bank->deferred_output);
+               mutex_init(&pin_bank->deferred_lock);
        }
 
        ret = rockchip_pinctrl_parse_dt(pdev, info);
@@ -2716,6 +2757,31 @@ static int rockchip_pinctrl_probe(struct platform_device *pdev)
        return 0;
 }
 
+static int rockchip_pinctrl_remove(struct platform_device *pdev)
+{
+       struct rockchip_pinctrl *info = platform_get_drvdata(pdev);
+       struct rockchip_pin_bank *bank;
+       struct rockchip_pin_output_deferred *cfg;
+       int i;
+
+       of_platform_depopulate(&pdev->dev);
+
+       for (i = 0; i < info->ctrl->nr_banks; i++) {
+               bank = &info->ctrl->pin_banks[i];
+
+               mutex_lock(&bank->deferred_lock);
+               while (!list_empty(&bank->deferred_output)) {
+                       cfg = list_first_entry(&bank->deferred_output,
+                                              struct rockchip_pin_output_deferred, head);
+                       list_del(&cfg->head);
+                       kfree(cfg);
+               }
+               mutex_unlock(&bank->deferred_lock);
+       }
+
+       return 0;
+}
+
 static struct rockchip_pin_bank px30_pin_banks[] = {
        PIN_BANK_IOMUX_FLAGS(0, 32, "gpio0", IOMUX_SOURCE_PMU,
                                             IOMUX_SOURCE_PMU,
@@ -3175,6 +3241,7 @@ static const struct of_device_id rockchip_pinctrl_dt_match[] = {
 
 static struct platform_driver rockchip_pinctrl_driver = {
        .probe          = rockchip_pinctrl_probe,
+       .remove         = rockchip_pinctrl_remove,
        .driver = {
                .name   = "rockchip-pinctrl",
                .pm = &rockchip_pinctrl_dev_pm_ops,
index 589d4d2..91f1027 100644 (file)
@@ -141,6 +141,8 @@ struct rockchip_drv {
  * @toggle_edge_mode: bit mask to toggle (falling/rising) edge mode
  * @recalced_mask: bit mask to indicate a need to recalulate the mask
  * @route_mask: bits describing the routing pins of per bank
+ * @deferred_output: gpio output settings to be done after gpio bank probed
+ * @deferred_lock: mutex for the deferred_output shared btw gpio and pinctrl
  */
 struct rockchip_pin_bank {
        struct device                   *dev;
@@ -169,6 +171,8 @@ struct rockchip_pin_bank {
        u32                             toggle_edge_mode;
        u32                             recalced_mask;
        u32                             route_mask;
+       struct list_head                deferred_output;
+       struct mutex                    deferred_lock;
 };
 
 /**
@@ -243,6 +247,12 @@ struct rockchip_pin_config {
        unsigned int            nconfigs;
 };
 
+struct rockchip_pin_output_deferred {
+       struct list_head head;
+       unsigned int pin;
+       u32 arg;
+};
+
 /**
  * struct rockchip_pin_group: represent group of pins of a pinmux function.
  * @name: name of the pin group, used to lookup the group.
index 32ea2a8..5ff4207 100644 (file)
@@ -3,7 +3,8 @@ if (ARCH_QCOM || COMPILE_TEST)
 
 config PINCTRL_MSM
        tristate "Qualcomm core pin controller driver"
-       depends on GPIOLIB && (QCOM_SCM || !QCOM_SCM) #if QCOM_SCM=m this can't be =y
+       depends on GPIOLIB
+       select QCOM_SCM
        select PINMUX
        select PINCONF
        select GENERIC_PINCONF
index afddf6d..9017ede 100644 (file)
@@ -1496,6 +1496,7 @@ static const struct of_device_id sc7280_pinctrl_of_match[] = {
 static struct platform_driver sc7280_pinctrl_driver = {
        .driver = {
                .name = "sc7280-pinctrl",
+               .pm = &msm_pinctrl_dev_pm_ops,
                .of_match_table = sc7280_pinctrl_of_match,
        },
        .probe = sc7280_pinctrl_probe,
index 98bf0e2..b2562e8 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0-only
 /*
- * Copyright (c) 2012-2014, The Linux Foundation. All rights reserved.
+ * Copyright (c) 2012-2014, 2016-2021 The Linux Foundation. All rights reserved.
  */
 
 #include <linux/gpio/driver.h>
@@ -14,6 +14,7 @@
 #include <linux/platform_device.h>
 #include <linux/regmap.h>
 #include <linux/slab.h>
+#include <linux/spmi.h>
 #include <linux/types.h>
 
 #include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
@@ -171,6 +172,8 @@ struct pmic_gpio_state {
        struct pinctrl_dev *ctrl;
        struct gpio_chip chip;
        struct irq_chip irq;
+       u8 usid;
+       u8 pid_base;
 };
 
 static const struct pinconf_generic_params pmic_gpio_bindings[] = {
@@ -949,12 +952,36 @@ static int pmic_gpio_child_to_parent_hwirq(struct gpio_chip *chip,
                                           unsigned int *parent_hwirq,
                                           unsigned int *parent_type)
 {
-       *parent_hwirq = child_hwirq + 0xc0;
+       struct pmic_gpio_state *state = gpiochip_get_data(chip);
+
+       *parent_hwirq = child_hwirq + state->pid_base;
        *parent_type = child_type;
 
        return 0;
 }
 
+static void *pmic_gpio_populate_parent_fwspec(struct gpio_chip *chip,
+                                            unsigned int parent_hwirq,
+                                            unsigned int parent_type)
+{
+       struct pmic_gpio_state *state = gpiochip_get_data(chip);
+       struct irq_fwspec *fwspec;
+
+       fwspec = kzalloc(sizeof(*fwspec), GFP_KERNEL);
+       if (!fwspec)
+               return NULL;
+
+       fwspec->fwnode = chip->irq.parent_domain->fwnode;
+
+       fwspec->param_count = 4;
+       fwspec->param[0] = state->usid;
+       fwspec->param[1] = parent_hwirq;
+       /* param[2] must be left as 0 */
+       fwspec->param[3] = parent_type;
+
+       return fwspec;
+}
+
 static int pmic_gpio_probe(struct platform_device *pdev)
 {
        struct irq_domain *parent_domain;
@@ -965,6 +992,7 @@ static int pmic_gpio_probe(struct platform_device *pdev)
        struct pmic_gpio_pad *pad, *pads;
        struct pmic_gpio_state *state;
        struct gpio_irq_chip *girq;
+       const struct spmi_device *parent_spmi_dev;
        int ret, npins, i;
        u32 reg;
 
@@ -984,6 +1012,9 @@ static int pmic_gpio_probe(struct platform_device *pdev)
 
        state->dev = &pdev->dev;
        state->map = dev_get_regmap(dev->parent, NULL);
+       parent_spmi_dev = to_spmi_device(dev->parent);
+       state->usid = parent_spmi_dev->usid;
+       state->pid_base = reg >> 8;
 
        pindesc = devm_kcalloc(dev, npins, sizeof(*pindesc), GFP_KERNEL);
        if (!pindesc)
@@ -1059,7 +1090,7 @@ static int pmic_gpio_probe(struct platform_device *pdev)
        girq->fwnode = of_node_to_fwnode(state->dev->of_node);
        girq->parent_domain = parent_domain;
        girq->child_to_parent_hwirq = pmic_gpio_child_to_parent_hwirq;
-       girq->populate_parent_alloc_arg = gpiochip_populate_parent_fwspec_fourcell;
+       girq->populate_parent_alloc_arg = pmic_gpio_populate_parent_fwspec;
        girq->child_offset_to_irq = pmic_gpio_child_offset_to_irq;
        girq->child_irq_domain_ops.translate = pmic_gpio_domain_translate;
 
index 7646708..a916cd8 100644 (file)
@@ -98,7 +98,7 @@ mlxreg_io_get_reg(void *regmap, struct mlxreg_core_data *data, u32 in_val,
                        if (ret)
                                goto access_error;
 
-                       *regval |= rol32(val, regsize * i);
+                       *regval |= rol32(val, regsize * i * 8);
                }
        }
 
@@ -141,7 +141,7 @@ mlxreg_io_attr_store(struct device *dev, struct device_attribute *attr,
                return -EINVAL;
 
        /* Convert buffer to input value. */
-       ret = kstrtou32(buf, len, &input_val);
+       ret = kstrtou32(buf, 0, &input_val);
        if (ret)
                return ret;
 
index 3481479..fc95620 100644 (file)
@@ -71,7 +71,7 @@
 #define AMD_CPU_ID_YC                  0x14B5
 
 #define PMC_MSG_DELAY_MIN_US           100
-#define RESPONSE_REGISTER_LOOP_MAX     200
+#define RESPONSE_REGISTER_LOOP_MAX     20000
 
 #define SOC_SUBSYSTEM_IP_MAX   12
 #define DELAY_MIN_US           2000
@@ -476,6 +476,7 @@ static const struct acpi_device_id amd_pmc_acpi_ids[] = {
        {"AMDI0006", 0},
        {"AMDI0007", 0},
        {"AMD0004", 0},
+       {"AMD0005", 0},
        { }
 };
 MODULE_DEVICE_TABLE(acpi, amd_pmc_acpi_ids);
index 821aba3..2fffa57 100644 (file)
@@ -166,8 +166,8 @@ config DELL_WMI
 
 config DELL_WMI_PRIVACY
        bool "Dell WMI Hardware Privacy Support"
+       depends on LEDS_TRIGGER_AUDIO = y || DELL_WMI = LEDS_TRIGGER_AUDIO
        depends on DELL_WMI
-       depends on LEDS_TRIGGER_AUDIO
        help
          This option adds integration with the "Dell Hardware Privacy"
          feature of Dell laptops to the dell-wmi driver.
index 7f3a03f..658bab4 100644 (file)
@@ -141,9 +141,11 @@ static u8 gigabyte_wmi_detect_sensor_usability(struct wmi_device *wdev)
 
 static const struct dmi_system_id gigabyte_wmi_known_working_platforms[] = {
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B450M S2H V2"),
+       DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550 AORUS ELITE AX V2"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550 AORUS ELITE"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550 AORUS ELITE V2"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550 GAMING X V2"),
+       DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550I AORUS PRO AX"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550M AORUS PRO-P"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("B550M DS3H"),
        DMI_EXACT_MATCH_GIGABYTE_BOARD_NAME("Z390 I AORUS PRO WIFI-CF"),
index a33a582..0859894 100644 (file)
@@ -118,12 +118,30 @@ static const struct dmi_system_id dmi_vgbs_allow_list[] = {
        { }
 };
 
+/*
+ * Some devices, even non convertible ones, can send incorrect SW_TABLET_MODE
+ * reports. Accept such reports only from devices in this list.
+ */
+static const struct dmi_system_id dmi_auto_add_switch[] = {
+       {
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_CHASSIS_TYPE, "31" /* Convertible */),
+               },
+       },
+       {
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_CHASSIS_TYPE, "32" /* Detachable */),
+               },
+       },
+       {} /* Array terminator */
+};
+
 struct intel_hid_priv {
        struct input_dev *input_dev;
        struct input_dev *array;
        struct input_dev *switches;
        bool wakeup_mode;
-       bool dual_accel;
+       bool auto_add_switch;
 };
 
 #define HID_EVENT_FILTER_UUID  "eeec56b3-4442-408f-a792-4edd4d758054"
@@ -452,10 +470,8 @@ static void notify_handler(acpi_handle handle, u32 event, void *context)
         * Some convertible have unreliable VGBS return which could cause incorrect
         * SW_TABLET_MODE report, in these cases we enable support when receiving
         * the first event instead of during driver setup.
-        *
-        * See dual_accel_detect.h for more info on the dual_accel check.
         */
-       if (!priv->switches && !priv->dual_accel && (event == 0xcc || event == 0xcd)) {
+       if (!priv->switches && priv->auto_add_switch && (event == 0xcc || event == 0xcd)) {
                dev_info(&device->dev, "switch event received, enable switches supports\n");
                err = intel_hid_switches_setup(device);
                if (err)
@@ -596,7 +612,8 @@ static int intel_hid_probe(struct platform_device *device)
                return -ENOMEM;
        dev_set_drvdata(&device->dev, priv);
 
-       priv->dual_accel = dual_accel_detect();
+       /* See dual_accel_detect.h for more info on the dual_accel check. */
+       priv->auto_add_switch = dmi_check_system(dmi_auto_add_switch) && !dual_accel_detect();
 
        err = intel_hid_input_setup(device);
        if (err) {
index 379560f..e03943e 100644 (file)
@@ -42,12 +42,20 @@ static void update_sar_data(struct wwan_sar_context *context)
 
        if (config->device_mode_info &&
            context->sar_data.device_mode < config->total_dev_mode) {
-               struct wwan_device_mode_info *dev_mode =
-                       &config->device_mode_info[context->sar_data.device_mode];
-
-               context->sar_data.antennatable_index = dev_mode->antennatable_index;
-               context->sar_data.bandtable_index = dev_mode->bandtable_index;
-               context->sar_data.sartable_index = dev_mode->sartable_index;
+               int itr = 0;
+
+               for (itr = 0; itr < config->total_dev_mode; itr++) {
+                       if (context->sar_data.device_mode ==
+                               config->device_mode_info[itr].device_mode) {
+                               struct wwan_device_mode_info *dev_mode =
+                               &config->device_mode_info[itr];
+
+                               context->sar_data.antennatable_index = dev_mode->antennatable_index;
+                               context->sar_data.bandtable_index = dev_mode->bandtable_index;
+                               context->sar_data.sartable_index = dev_mode->sartable_index;
+                               break;
+                       }
+               }
        }
 }
 
@@ -305,7 +313,6 @@ static struct platform_driver sar_driver = {
        .remove = sar_remove,
        .driver = {
                .name = DRVNAME,
-               .owner = THIS_MODULE,
                .acpi_match_table = ACPI_PTR(sar_device_ids)
        }
 };
@@ -313,4 +320,4 @@ module_platform_driver(sar_driver);
 
 MODULE_LICENSE("GPL v2");
 MODULE_DESCRIPTION("Platform device driver for INTEL MODEM BIOS SAR");
-MODULE_AUTHOR("Shravan S <s.shravan@intel.com>");
+MODULE_AUTHOR("Shravan Sudhakar <s.shravan@intel.com>");
index 9fe0a25..e59d79c 100644 (file)
@@ -401,7 +401,7 @@ int skl_int3472_discrete_remove(struct platform_device *pdev)
 
        gpiod_remove_lookup_table(&int3472->gpios);
 
-       if (int3472->clock.ena_gpio)
+       if (int3472->clock.cl)
                skl_int3472_unregister_clock(int3472);
 
        gpiod_put(int3472->clock.ena_gpio);
index f58b854..66bb39f 100644 (file)
@@ -8,7 +8,6 @@
  * which provide mailbox interface for power management usage.
  */
 
-#include <linux/acpi.h>
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/device.h>
@@ -319,7 +318,7 @@ static struct platform_driver intel_punit_ipc_driver = {
        .remove = intel_punit_ipc_remove,
        .driver = {
                .name = "intel_punit_ipc",
-               .acpi_match_table = ACPI_PTR(punit_ipc_acpi_ids),
+               .acpi_match_table = punit_ipc_acpi_ids,
        },
 };
 
index bfa0cc2..7cc9089 100644 (file)
@@ -75,7 +75,7 @@ struct intel_scu_ipc_dev {
 #define IPC_READ_BUFFER                0x90
 
 /* Timeout in jiffies */
-#define IPC_TIMEOUT            (5 * HZ)
+#define IPC_TIMEOUT            (10 * HZ)
 
 static struct intel_scu_ipc_dev *ipcdev; /* Only one for now */
 static DEFINE_MUTEX(ipclock); /* lock used to prevent multiple call to SCU */
@@ -232,7 +232,7 @@ static inline u32 ipc_data_readl(struct intel_scu_ipc_dev *scu, u32 offset)
 /* Wait till scu status is busy */
 static inline int busy_loop(struct intel_scu_ipc_dev *scu)
 {
-       unsigned long end = jiffies + msecs_to_jiffies(IPC_TIMEOUT);
+       unsigned long end = jiffies + IPC_TIMEOUT;
 
        do {
                u32 status;
@@ -247,7 +247,7 @@ static inline int busy_loop(struct intel_scu_ipc_dev *scu)
        return -ETIMEDOUT;
 }
 
-/* Wait till ipc ioc interrupt is received or timeout in 3 HZ */
+/* Wait till ipc ioc interrupt is received or timeout in 10 HZ */
 static inline int ipc_wait_for_interrupt(struct intel_scu_ipc_dev *scu)
 {
        int status;
index 3e520d5..88b551c 100644 (file)
@@ -655,7 +655,7 @@ static int acpi_add(struct acpi_device *device)
                goto out_platform_registered;
        }
        product = dmi_get_system_info(DMI_PRODUCT_NAME);
-       if (strlen(product) > 4)
+       if (product && strlen(product) > 4)
                switch (product[4]) {
                case '5':
                case '6':
index 0e1451b..033f797 100644 (file)
@@ -100,10 +100,10 @@ static const struct ts_dmi_data chuwi_hi10_air_data = {
 };
 
 static const struct property_entry chuwi_hi10_plus_props[] = {
-       PROPERTY_ENTRY_U32("touchscreen-min-x", 0),
-       PROPERTY_ENTRY_U32("touchscreen-min-y", 5),
-       PROPERTY_ENTRY_U32("touchscreen-size-x", 1914),
-       PROPERTY_ENTRY_U32("touchscreen-size-y", 1283),
+       PROPERTY_ENTRY_U32("touchscreen-min-x", 12),
+       PROPERTY_ENTRY_U32("touchscreen-min-y", 10),
+       PROPERTY_ENTRY_U32("touchscreen-size-x", 1908),
+       PROPERTY_ENTRY_U32("touchscreen-size-y", 1270),
        PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hi10plus.fw"),
        PROPERTY_ENTRY_U32("silead,max-fingers", 10),
        PROPERTY_ENTRY_BOOL("silead,home-button"),
@@ -111,6 +111,15 @@ static const struct property_entry chuwi_hi10_plus_props[] = {
 };
 
 static const struct ts_dmi_data chuwi_hi10_plus_data = {
+       .embedded_fw = {
+               .name   = "silead/gsl1680-chuwi-hi10plus.fw",
+               .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 },
+               .length = 34056,
+               .sha256 = { 0xfd, 0x0a, 0x08, 0x08, 0x3c, 0xa6, 0x34, 0x4e,
+                           0x2c, 0x49, 0x9c, 0xcd, 0x7d, 0x44, 0x9d, 0x38,
+                           0x10, 0x68, 0xb5, 0xbd, 0xb7, 0x2a, 0x63, 0xb5,
+                           0x67, 0x0b, 0x96, 0xbd, 0x89, 0x67, 0x85, 0x09 },
+       },
        .acpi_name      = "MSSL0017:00",
        .properties     = chuwi_hi10_plus_props,
 };
@@ -141,6 +150,33 @@ static const struct ts_dmi_data chuwi_hi10_pro_data = {
        .properties     = chuwi_hi10_pro_props,
 };
 
+static const struct property_entry chuwi_hibook_props[] = {
+       PROPERTY_ENTRY_U32("touchscreen-min-x", 30),
+       PROPERTY_ENTRY_U32("touchscreen-min-y", 4),
+       PROPERTY_ENTRY_U32("touchscreen-size-x", 1892),
+       PROPERTY_ENTRY_U32("touchscreen-size-y", 1276),
+       PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"),
+       PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"),
+       PROPERTY_ENTRY_STRING("firmware-name", "gsl1680-chuwi-hibook.fw"),
+       PROPERTY_ENTRY_U32("silead,max-fingers", 10),
+       PROPERTY_ENTRY_BOOL("silead,home-button"),
+       { }
+};
+
+static const struct ts_dmi_data chuwi_hibook_data = {
+       .embedded_fw = {
+               .name   = "silead/gsl1680-chuwi-hibook.fw",
+               .prefix = { 0xf0, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00 },
+               .length = 40392,
+               .sha256 = { 0xf7, 0xc0, 0xe8, 0x5a, 0x6c, 0xf2, 0xeb, 0x8d,
+                           0x12, 0xc4, 0x45, 0xbf, 0x55, 0x13, 0x4c, 0x1a,
+                           0x13, 0x04, 0x31, 0x08, 0x65, 0x73, 0xf7, 0xa8,
+                           0x1b, 0x7d, 0x59, 0xc9, 0xe6, 0x97, 0xf7, 0x38 },
+       },
+       .acpi_name      = "MSSL0017:00",
+       .properties     = chuwi_hibook_props,
+};
+
 static const struct property_entry chuwi_vi8_props[] = {
        PROPERTY_ENTRY_U32("touchscreen-min-x", 4),
        PROPERTY_ENTRY_U32("touchscreen-min-y", 6),
@@ -979,6 +1015,16 @@ const struct dmi_system_id touchscreen_dmi_table[] = {
                        DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
                },
        },
+       {
+               /* Chuwi HiBook (CWI514) */
+               .driver_data = (void *)&chuwi_hibook_data,
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "Hampoo"),
+                       DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
+                       /* Above matches are too generic, add bios-date match */
+                       DMI_MATCH(DMI_BIOS_DATE, "05/07/2016"),
+               },
+       },
        {
                /* Chuwi Vi8 (CWI506) */
                .driver_data = (void *)&chuwi_vi8_data,
index f02bedf..458218f 100644 (file)
@@ -174,6 +174,7 @@ config PTP_1588_CLOCK_OCP
        depends on I2C && MTD
        depends on SERIAL_8250
        depends on !S390
+       depends on COMMON_CLK
        select NET_DEVLINK
        help
          This driver adds support for an OpenCompute time card.
index 3dd519d..d0096cd 100644 (file)
@@ -15,8 +15,6 @@
 #include <linux/ptp_clock_kernel.h>
 #include <linux/ptp_kvm.h>
 
-struct pvclock_vsyscall_time_info *hv_clock;
-
 static phys_addr_t clock_pair_gpa;
 static struct kvm_clock_pairing clock_pair;
 
@@ -28,8 +26,7 @@ int kvm_arch_ptp_init(void)
                return -ENODEV;
 
        clock_pair_gpa = slow_virt_to_phys(&clock_pair);
-       hv_clock = pvclock_get_pvti_cpu0_va();
-       if (!hv_clock)
+       if (!pvclock_get_pvti_cpu0_va())
                return -ENODEV;
 
        ret = kvm_hypercall2(KVM_HC_CLOCK_PAIRING, clock_pair_gpa,
@@ -64,10 +61,8 @@ int kvm_arch_ptp_get_crosststamp(u64 *cycle, struct timespec64 *tspec,
        struct pvclock_vcpu_time_info *src;
        unsigned int version;
        long ret;
-       int cpu;
 
-       cpu = smp_processor_id();
-       src = &hv_clock[cpu].pvti;
+       src = this_cpu_pvti();
 
        do {
                /*
index a17e8cc..8070f3f 100644 (file)
@@ -644,6 +644,7 @@ static const struct pci_device_id pch_ieee1588_pcidev_id[] = {
         },
        {0}
 };
+MODULE_DEVICE_TABLE(pci, pch_ieee1588_pcidev_id);
 
 static SIMPLE_DEV_PM_OPS(pch_pm_ops, pch_suspend, pch_resume);
 
index 1d78b45..e34face 100644 (file)
@@ -269,5 +269,3 @@ module_exit(max14577_regulator_exit);
 MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>");
 MODULE_DESCRIPTION("Maxim 14577/77836 regulator driver");
 MODULE_LICENSE("GPL");
-MODULE_ALIAS("platform:max14577-regulator");
-MODULE_ALIAS("platform:max77836-regulator");
index 6cca910..7f458d5 100644 (file)
@@ -991,7 +991,7 @@ static const struct rpmh_vreg_init_data pm8009_1_vreg_data[] = {
        RPMH_VREG("ldo4",   "ldo%s4",  &pmic5_nldo,      "vdd-l4"),
        RPMH_VREG("ldo5",   "ldo%s5",  &pmic5_pldo,      "vdd-l5-l6"),
        RPMH_VREG("ldo6",   "ldo%s6",  &pmic5_pldo,      "vdd-l5-l6"),
-       RPMH_VREG("ldo7",   "ldo%s6",  &pmic5_pldo_lv,   "vdd-l7"),
+       RPMH_VREG("ldo7",   "ldo%s7",  &pmic5_pldo_lv,   "vdd-l7"),
        {}
 };
 
index eb15067..4eb5341 100644 (file)
@@ -1047,7 +1047,9 @@ static void cmos_check_wkalrm(struct device *dev)
         * ACK the rtc irq here
         */
        if (t_now >= cmos->alarm_expires && cmos_use_acpi_alarm()) {
+               local_irq_disable();
                cmos_interrupt(0, (void *)cmos->rtc);
+               local_irq_enable();
                return;
        }
 
index 2f3515f..f3d5c7f 100644 (file)
@@ -45,13 +45,14 @@ static void __init sclp_early_facilities_detect(void)
        sclp.has_gisaf = !!(sccb->fac118 & 0x08);
        sclp.has_hvs = !!(sccb->fac119 & 0x80);
        sclp.has_kss = !!(sccb->fac98 & 0x01);
-       sclp.has_sipl = !!(sccb->cbl & 0x4000);
        if (sccb->fac85 & 0x02)
                S390_lowcore.machine_flags |= MACHINE_FLAG_ESOP;
        if (sccb->fac91 & 0x40)
                S390_lowcore.machine_flags |= MACHINE_FLAG_TLB_GUEST;
        if (sccb->cpuoff > 134)
                sclp.has_diag318 = !!(sccb->byte_134 & 0x80);
+       if (sccb->cpuoff > 137)
+               sclp.has_sipl = !!(sccb->cbl & 0x4000);
        sclp.rnmax = sccb->rnmax ? sccb->rnmax : sccb->rnmax2;
        sclp.rzm = sccb->rnsize ? sccb->rnsize : sccb->rnsize2;
        sclp.rzm <<= 20;
index f3c6569..93695d5 100644 (file)
@@ -262,10 +262,12 @@ static int blacklist_parse_proc_parameters(char *buf)
 
        if (strcmp("free", parm) == 0) {
                rc = blacklist_parse_parameters(buf, free, 0);
-               /* There could be subchannels without proper devices connected.
-                * evaluate all the entries
+               /*
+                * Evaluate the subchannels without an online device. This way,
+                * no path-verification will be triggered on those subchannels
+                * and it avoids unnecessary delays.
                 */
-               css_schedule_eval_all();
+               css_schedule_eval_cond(CSS_EVAL_NOT_ONLINE, 0);
        } else if (strcmp("add", parm) == 0)
                rc = blacklist_parse_parameters(buf, add, 0);
        else if (strcmp("purge", parm) == 0)
index 2ec7411..f053860 100644 (file)
@@ -77,12 +77,13 @@ EXPORT_SYMBOL(ccwgroup_set_online);
 /**
  * ccwgroup_set_offline() - disable a ccwgroup device
  * @gdev: target ccwgroup device
+ * @call_gdrv: Call the registered gdrv set_offline function
  *
  * This function attempts to put the ccwgroup device into the offline state.
  * Returns:
  *  %0 on success and a negative error value on failure.
  */
-int ccwgroup_set_offline(struct ccwgroup_device *gdev)
+int ccwgroup_set_offline(struct ccwgroup_device *gdev, bool call_gdrv)
 {
        struct ccwgroup_driver *gdrv = to_ccwgroupdrv(gdev->dev.driver);
        int ret = -EINVAL;
@@ -91,11 +92,16 @@ int ccwgroup_set_offline(struct ccwgroup_device *gdev)
                return -EAGAIN;
        if (gdev->state == CCWGROUP_OFFLINE)
                goto out;
+       if (!call_gdrv) {
+               ret = 0;
+               goto offline;
+       }
        if (gdrv->set_offline)
                ret = gdrv->set_offline(gdev);
        if (ret)
                goto out;
 
+offline:
        gdev->state = CCWGROUP_OFFLINE;
 out:
        atomic_set(&gdev->onoff, 0);
@@ -124,7 +130,7 @@ static ssize_t ccwgroup_online_store(struct device *dev,
        if (value == 1)
                ret = ccwgroup_set_online(gdev);
        else if (value == 0)
-               ret = ccwgroup_set_offline(gdev);
+               ret = ccwgroup_set_offline(gdev, true);
        else
                ret = -EINVAL;
 out:
index 3377097..4446192 100644 (file)
@@ -788,27 +788,49 @@ static int __unset_registered(struct device *dev, void *data)
        return 0;
 }
 
-void css_schedule_eval_all_unreg(unsigned long delay)
+static int __unset_online(struct device *dev, void *data)
+{
+       struct idset *set = data;
+       struct subchannel *sch = to_subchannel(dev);
+       struct ccw_device *cdev = sch_get_cdev(sch);
+
+       if (cdev && cdev->online)
+               idset_sch_del(set, sch->schid);
+
+       return 0;
+}
+
+void css_schedule_eval_cond(enum css_eval_cond cond, unsigned long delay)
 {
        unsigned long flags;
-       struct idset *unreg_set;
+       struct idset *set;
 
        /* Find unregistered subchannels. */
-       unreg_set = idset_sch_new();
-       if (!unreg_set) {
+       set = idset_sch_new();
+       if (!set) {
                /* Fallback. */
                css_schedule_eval_all();
                return;
        }
-       idset_fill(unreg_set);
-       bus_for_each_dev(&css_bus_type, NULL, unreg_set, __unset_registered);
+       idset_fill(set);
+       switch (cond) {
+       case CSS_EVAL_UNREG:
+               bus_for_each_dev(&css_bus_type, NULL, set, __unset_registered);
+               break;
+       case CSS_EVAL_NOT_ONLINE:
+               bus_for_each_dev(&css_bus_type, NULL, set, __unset_online);
+               break;
+       default:
+               break;
+       }
+
        /* Apply to slow_subchannel_set. */
        spin_lock_irqsave(&slow_subchannel_lock, flags);
-       idset_add_set(slow_subchannel_set, unreg_set);
+       idset_add_set(slow_subchannel_set, set);
        atomic_set(&css_eval_scheduled, 1);
        queue_delayed_work(cio_work_q, &slow_path_work, delay);
        spin_unlock_irqrestore(&slow_subchannel_lock, flags);
-       idset_free(unreg_set);
+       idset_free(set);
 }
 
 void css_wait_for_slow_path(void)
@@ -820,7 +842,7 @@ void css_wait_for_slow_path(void)
 void css_schedule_reprobe(void)
 {
        /* Schedule with a delay to allow merging of subsequent calls. */
-       css_schedule_eval_all_unreg(1 * HZ);
+       css_schedule_eval_cond(CSS_EVAL_UNREG, 1 * HZ);
 }
 EXPORT_SYMBOL_GPL(css_schedule_reprobe);
 
index c98522c..ede0b90 100644 (file)
 #define SNID_STATE3_MULTI_PATH    1
 #define SNID_STATE3_SINGLE_PATH           0
 
+/*
+ * Conditions used to specify which subchannels need evaluation
+ */
+enum css_eval_cond {
+       CSS_EVAL_UNREG,         /* unregistered subchannels */
+       CSS_EVAL_NOT_ONLINE     /* sch without an online-device */
+};
+
 struct path_state {
        __u8  state1 : 2;       /* path state value 1 */
        __u8  state2 : 2;       /* path state value 2 */
@@ -136,7 +144,7 @@ static inline struct channel_subsystem *css_by_id(u8 cssid)
 /* Helper functions to build lists for the slow path. */
 void css_schedule_eval(struct subchannel_id schid);
 void css_schedule_eval_all(void);
-void css_schedule_eval_all_unreg(unsigned long delay);
+void css_schedule_eval_cond(enum css_eval_cond, unsigned long delay);
 int css_complete_work(void);
 
 int sch_is_pseudo_sch(struct subchannel *);
index f433428..d9b8049 100644 (file)
@@ -213,7 +213,6 @@ static inline int ap_fetch_qci_info(struct ap_config_info *info)
  * ap_init_qci_info(): Allocate and query qci config info.
  * Does also update the static variables ap_max_domain_id
  * and ap_max_adapter_id if this info is available.
-
  */
 static void __init ap_init_qci_info(void)
 {
@@ -439,6 +438,7 @@ static enum hrtimer_restart ap_poll_timeout(struct hrtimer *unused)
 /**
  * ap_interrupt_handler() - Schedule ap_tasklet on interrupt
  * @airq: pointer to adapter interrupt descriptor
+ * @floating: ignored
  */
 static void ap_interrupt_handler(struct airq_struct *airq, bool floating)
 {
@@ -1786,6 +1786,7 @@ static inline void ap_scan_adapter(int ap)
 /**
  * ap_scan_bus(): Scan the AP bus for new devices
  * Runs periodically, workqueue timer (ap_config_time)
+ * @unused: Unused pointer.
  */
 static void ap_scan_bus(struct work_struct *unused)
 {
index d70c4d3..9ea48bf 100644 (file)
@@ -20,7 +20,7 @@ static void __ap_flush_queue(struct ap_queue *aq);
 
 /**
  * ap_queue_enable_irq(): Enable interrupt support on this AP queue.
- * @qid: The AP queue number
+ * @aq: The AP queue
  * @ind: the notification indicator byte
  *
  * Enables interruption on AP queue via ap_aqic(). Based on the return
@@ -311,7 +311,7 @@ static enum ap_sm_wait ap_sm_read_write(struct ap_queue *aq)
 
 /**
  * ap_sm_reset(): Reset an AP queue.
- * @qid: The AP queue number
+ * @aq: The AP queue
  *
  * Submit the Reset command to an AP queue.
  */
index 118939a..623d526 100644 (file)
@@ -361,6 +361,7 @@ err_list:
        mutex_lock(&matrix_dev->lock);
        list_del(&matrix_mdev->node);
        mutex_unlock(&matrix_dev->lock);
+       vfio_uninit_group_dev(&matrix_mdev->vdev);
        kfree(matrix_mdev);
 err_dec_available:
        atomic_inc(&matrix_dev->available_instances);
@@ -376,9 +377,10 @@ static void vfio_ap_mdev_remove(struct mdev_device *mdev)
        mutex_lock(&matrix_dev->lock);
        vfio_ap_mdev_reset_queues(matrix_mdev);
        list_del(&matrix_mdev->node);
+       mutex_unlock(&matrix_dev->lock);
+       vfio_uninit_group_dev(&matrix_mdev->vdev);
        kfree(matrix_mdev);
        atomic_inc(&matrix_dev->available_instances);
-       mutex_unlock(&matrix_dev->lock);
 }
 
 static ssize_t name_show(struct mdev_type *mtype,
index 535a60b..a5aa0bd 100644 (file)
@@ -858,7 +858,6 @@ struct qeth_card {
        struct napi_struct napi;
        struct qeth_rx rx;
        struct delayed_work buffer_reclaim_work;
-       struct work_struct close_dev_work;
 };
 
 static inline bool qeth_card_hw_is_reachable(struct qeth_card *card)
index 41ca627..e9807d2 100644 (file)
@@ -70,15 +70,6 @@ static void qeth_issue_next_read_cb(struct qeth_card *card,
 static int qeth_qdio_establish(struct qeth_card *);
 static void qeth_free_qdio_queues(struct qeth_card *card);
 
-static void qeth_close_dev_handler(struct work_struct *work)
-{
-       struct qeth_card *card;
-
-       card = container_of(work, struct qeth_card, close_dev_work);
-       QETH_CARD_TEXT(card, 2, "cldevhdl");
-       ccwgroup_set_offline(card->gdev);
-}
-
 static const char *qeth_get_cardname(struct qeth_card *card)
 {
        if (IS_VM_NIC(card)) {
@@ -202,6 +193,9 @@ static void qeth_clear_working_pool_list(struct qeth_card *card)
                                 &card->qdio.in_buf_pool.entry_list, list)
                list_del(&pool_entry->list);
 
+       if (!queue)
+               return;
+
        for (i = 0; i < ARRAY_SIZE(queue->bufs); i++)
                queue->bufs[i].pool_entry = NULL;
 }
@@ -792,10 +786,12 @@ static struct qeth_ipa_cmd *qeth_check_ipa_data(struct qeth_card *card,
        case IPA_CMD_STOPLAN:
                if (cmd->hdr.return_code == IPA_RC_VEPA_TO_VEB_TRANSITION) {
                        dev_err(&card->gdev->dev,
-                               "Interface %s is down because the adjacent port is no longer in reflective relay mode\n",
+                               "Adjacent port of interface %s is no longer in reflective relay mode, trigger recovery\n",
                                netdev_name(card->dev));
-                       schedule_work(&card->close_dev_work);
+                       /* Set offline, then probably fail to set online: */
+                       qeth_schedule_recovery(card);
                } else {
+                       /* stay online for subsequent STARTLAN */
                        dev_warn(&card->gdev->dev,
                                 "The link for interface %s on CHPID 0x%X failed\n",
                                 netdev_name(card->dev), card->info.chpid);
@@ -1537,7 +1533,6 @@ static void qeth_setup_card(struct qeth_card *card)
        INIT_LIST_HEAD(&card->ipato.entries);
        qeth_init_qdio_info(card);
        INIT_DELAYED_WORK(&card->buffer_reclaim_work, qeth_buffer_reclaim_work);
-       INIT_WORK(&card->close_dev_work, qeth_close_dev_handler);
        hash_init(card->rx_mode_addrs);
        hash_init(card->local_addrs4);
        hash_init(card->local_addrs6);
@@ -5519,7 +5514,8 @@ static int qeth_do_reset(void *data)
                dev_info(&card->gdev->dev,
                         "Device successfully recovered!\n");
        } else {
-               ccwgroup_set_offline(card->gdev);
+               qeth_set_offline(card, disc, true);
+               ccwgroup_set_offline(card->gdev, false);
                dev_warn(&card->gdev->dev,
                         "The qeth device driver failed to recover an error on the device\n");
        }
index 72e84ff..dc6c007 100644 (file)
@@ -2307,7 +2307,6 @@ static void qeth_l2_remove_device(struct ccwgroup_device *gdev)
        if (gdev->state == CCWGROUP_ONLINE)
                qeth_set_offline(card, card->discipline, false);
 
-       cancel_work_sync(&card->close_dev_work);
        if (card->dev->reg_state == NETREG_REGISTERED) {
                priv = netdev_priv(card->dev);
                if (priv->brport_features & BR_LEARNING_SYNC) {
index 3a523e7..6fd3e28 100644 (file)
@@ -1969,7 +1969,6 @@ static void qeth_l3_remove_device(struct ccwgroup_device *cgdev)
        if (cgdev->state == CCWGROUP_ONLINE)
                qeth_set_offline(card, card->discipline, false);
 
-       cancel_work_sync(&card->close_dev_work);
        if (card->dev->reg_state == NETREG_REGISTERED)
                unregister_netdev(card->dev);
 
index f34badc..9f64133 100644 (file)
@@ -10,17 +10,6 @@ config SCSI_ACORNSCSI_3
          This enables support for the Acorn SCSI card (aka30). If you have an
          Acorn system with one of these, say Y. If unsure, say N.
 
-config SCSI_ACORNSCSI_TAGGED_QUEUE
-       bool "Support SCSI 2 Tagged queueing"
-       depends on SCSI_ACORNSCSI_3
-       help
-         Say Y here to enable tagged queuing support on the Acorn SCSI card.
-
-         This is a feature of SCSI-2 which improves performance: the host
-         adapter can send several SCSI commands to a device's queue even if
-         previous commands haven't finished yet. Some SCSI devices don't
-         implement this properly, so the safe answer is N.
-
 config SCSI_ACORNSCSI_SYNC
        bool "Support SCSI 2 Synchronous Transfers"
        depends on SCSI_ACORNSCSI_3
index 4a84599..0cc62c1 100644 (file)
  * You can tell if you have a device that supports tagged queueing my
  * cating (eg) /proc/scsi/acornscsi/0 and see if the SCSI revision is reported
  * as '2 TAG'.
- *
- * Also note that CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE is normally set in the config
- * scripts, but disabled here.  Once debugged, remove the #undef, otherwise to debug,
- * comment out the undef.
  */
-#undef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
+
 /*
  * SCSI-II Synchronous transfer support.
  *
@@ -171,7 +167,7 @@ static void acornscsi_done(AS_Host *host, struct scsi_cmnd **SCpntp,
                           unsigned int result);
 static int acornscsi_reconnect_finish(AS_Host *host);
 static void acornscsi_dma_cleanup(AS_Host *host);
-static void acornscsi_abortcmd(AS_Host *host, unsigned char tag);
+static void acornscsi_abortcmd(AS_Host *host);
 
 /* ====================================================================================
  * Miscellaneous
@@ -741,17 +737,6 @@ intr_ret_t acornscsi_kick(AS_Host *host)
 #endif
 
     if (from_queue) {
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-       /*
-        * tagged queueing - allocate a new tag to this command
-        */
-       if (SCpnt->device->simple_tags) {
-           SCpnt->device->current_tag += 1;
-           if (SCpnt->device->current_tag == 0)
-               SCpnt->device->current_tag = 1;
-           SCpnt->tag = SCpnt->device->current_tag;
-       } else
-#endif
            set_bit(SCpnt->device->id * 8 +
                    (u8)(SCpnt->device->lun & 0x07), host->busyluns);
 
@@ -1192,7 +1177,7 @@ void acornscsi_dma_intr(AS_Host *host)
         * the device recognises the attention.
         */
        if (dmac_read(host, DMAC_STATUS) & STATUS_RQ0) {
-           acornscsi_abortcmd(host, host->SCpnt->tag);
+           acornscsi_abortcmd(host);
 
            dmac_write(host, DMAC_TXCNTLO, 0);
            dmac_write(host, DMAC_TXCNTHI, 0);
@@ -1560,23 +1545,6 @@ void acornscsi_message(AS_Host *host)
            acornscsi_sbic_issuecmd(host, CMND_ASSERTATN);
 
        switch (host->scsi.last_message) {
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-       case HEAD_OF_QUEUE_TAG:
-       case ORDERED_QUEUE_TAG:
-       case SIMPLE_QUEUE_TAG:
-           /*
-            * ANSI standard says: (Section SCSI-2 Rev. 10c Sect 5.6.17)
-            *  If a target does not implement tagged queuing and a queue tag
-            *  message is received, it shall respond with a MESSAGE REJECT
-            *  message and accept the I/O process as if it were untagged.
-            */
-           printk(KERN_NOTICE "scsi%d.%c: disabling tagged queueing\n",
-                   host->host->host_no, acornscsi_target(host));
-           host->SCpnt->device->simple_tags = 0;
-           set_bit(host->SCpnt->device->id * 8 +
-                   (u8)(host->SCpnt->device->lun & 0x7), host->busyluns);
-           break;
-#endif
        case EXTENDED_MESSAGE | (EXTENDED_SDTR << 8):
            /*
             * Target can't handle synchronous transfers
@@ -1687,24 +1655,11 @@ void acornscsi_buildmessages(AS_Host *host)
 #if 0
     /* does the device need the current command aborted */
     if (cmd_aborted) {
-       acornscsi_abortcmd(host->SCpnt->tag);
+       acornscsi_abortcmd(host);
        return;
     }
 #endif
 
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-    if (host->SCpnt->tag) {
-       unsigned int tag_type;
-
-       if (host->SCpnt->cmnd[0] == REQUEST_SENSE ||
-           host->SCpnt->cmnd[0] == TEST_UNIT_READY ||
-           host->SCpnt->cmnd[0] == INQUIRY)
-           tag_type = HEAD_OF_QUEUE_TAG;
-       else
-           tag_type = SIMPLE_QUEUE_TAG;
-       msgqueue_addmsg(&host->scsi.msgs, 2, tag_type, host->SCpnt->tag);
-    }
-#endif
 
 #ifdef CONFIG_SCSI_ACORNSCSI_SYNC
     if (host->device[host->SCpnt->device->id].sync_state == SYNC_NEGOCIATE) {
@@ -1798,7 +1753,7 @@ int acornscsi_reconnect(AS_Host *host)
                "to reconnect with\n",
                host->host->host_no, '0' + target);
        acornscsi_dumplog(host, target);
-       acornscsi_abortcmd(host, 0);
+       acornscsi_abortcmd(host);
        if (host->SCpnt) {
            queue_add_cmd_tail(&host->queues.disconnected, host->SCpnt);
            host->SCpnt = NULL;
@@ -1821,7 +1776,7 @@ int acornscsi_reconnect_finish(AS_Host *host)
        host->scsi.disconnectable = 0;
        if (host->SCpnt->device->id  == host->scsi.reconnected.target &&
            host->SCpnt->device->lun == host->scsi.reconnected.lun &&
-           host->SCpnt->tag         == host->scsi.reconnected.tag) {
+           scsi_cmd_to_rq(host->SCpnt)->tag == host->scsi.reconnected.tag) {
 #if (DEBUG & (DEBUG_QUEUES|DEBUG_DISCON))
            DBG(host->SCpnt, printk("scsi%d.%c: reconnected",
                    host->host->host_no, acornscsi_target(host)));
@@ -1848,7 +1803,7 @@ int acornscsi_reconnect_finish(AS_Host *host)
     }
 
     if (!host->SCpnt)
-       acornscsi_abortcmd(host, host->scsi.reconnected.tag);
+       acornscsi_abortcmd(host);
     else {
        /*
         * Restore data pointer from SAVED pointers.
@@ -1889,21 +1844,15 @@ void acornscsi_disconnect_unexpected(AS_Host *host)
  * Function: void acornscsi_abortcmd(AS_host *host, unsigned char tag)
  * Purpose : abort a currently executing command
  * Params  : host - host with connected command to abort
- *          tag  - tag to abort
  */
 static
-void acornscsi_abortcmd(AS_Host *host, unsigned char tag)
+void acornscsi_abortcmd(AS_Host *host)
 {
     host->scsi.phase = PHASE_ABORTED;
     sbic_arm_write(host, SBIC_CMND, CMND_ASSERTATN);
 
     msgqueue_flush(&host->scsi.msgs);
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-    if (tag)
-       msgqueue_addmsg(&host->scsi.msgs, 2, ABORT_TAG, tag);
-    else
-#endif
-       msgqueue_addmsg(&host->scsi.msgs, 1, ABORT);
+    msgqueue_addmsg(&host->scsi.msgs, 1, ABORT);
 }
 
 /* ==========================================================================================
@@ -1993,7 +1942,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
            printk(KERN_ERR "scsi%d.%c: PHASE_CONNECTING, SSR %02X?\n",
                    host->host->host_no, acornscsi_target(host), ssr);
            acornscsi_dumplog(host, host->SCpnt ? host->SCpnt->device->id : 8);
-           acornscsi_abortcmd(host, host->SCpnt->tag);
+           acornscsi_abortcmd(host);
        }
        return INTR_PROCESSING;
 
@@ -2029,7 +1978,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
            printk(KERN_ERR "scsi%d.%c: PHASE_CONNECTED, SSR %02X?\n",
                    host->host->host_no, acornscsi_target(host), ssr);
            acornscsi_dumplog(host, host->SCpnt ? host->SCpnt->device->id : 8);
-           acornscsi_abortcmd(host, host->SCpnt->tag);
+           acornscsi_abortcmd(host);
        }
        return INTR_PROCESSING;
 
@@ -2075,20 +2024,20 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
        case 0x18:                      /* -> PHASE_DATAOUT                             */
            /* COMMAND -> DATA OUT */
            if (host->scsi.SCp.sent_command != host->SCpnt->cmd_len)
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            acornscsi_dma_setup(host, DMA_OUT);
            if (!acornscsi_starttransfer(host))
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            host->scsi.phase = PHASE_DATAOUT;
            return INTR_IDLE;
 
        case 0x19:                      /* -> PHASE_DATAIN                              */
            /* COMMAND -> DATA IN */
            if (host->scsi.SCp.sent_command != host->SCpnt->cmd_len)
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            acornscsi_dma_setup(host, DMA_IN);
            if (!acornscsi_starttransfer(host))
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            host->scsi.phase = PHASE_DATAIN;
            return INTR_IDLE;
 
@@ -2156,7 +2105,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
            /* MESSAGE IN -> DATA OUT */
            acornscsi_dma_setup(host, DMA_OUT);
            if (!acornscsi_starttransfer(host))
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            host->scsi.phase = PHASE_DATAOUT;
            return INTR_IDLE;
 
@@ -2165,7 +2114,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
            /* MESSAGE IN -> DATA IN */
            acornscsi_dma_setup(host, DMA_IN);
            if (!acornscsi_starttransfer(host))
-               acornscsi_abortcmd(host, host->SCpnt->tag);
+               acornscsi_abortcmd(host);
            host->scsi.phase = PHASE_DATAIN;
            return INTR_IDLE;
 
@@ -2206,7 +2155,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
        switch (ssr) {
        case 0x19:                      /* -> PHASE_DATAIN                              */
        case 0x89:                      /* -> PHASE_DATAIN                              */
-           acornscsi_abortcmd(host, host->SCpnt->tag);
+           acornscsi_abortcmd(host);
            return INTR_IDLE;
 
        case 0x1b:                      /* -> PHASE_STATUSIN                            */
@@ -2255,7 +2204,7 @@ intr_ret_t acornscsi_sbicintr(AS_Host *host, int in_irq)
        switch (ssr) {
        case 0x18:                      /* -> PHASE_DATAOUT                             */
        case 0x88:                      /* -> PHASE_DATAOUT                             */
-           acornscsi_abortcmd(host, host->SCpnt->tag);
+           acornscsi_abortcmd(host);
            return INTR_IDLE;
 
        case 0x1b:                      /* -> PHASE_STATUSIN                            */
@@ -2482,7 +2431,6 @@ static int acornscsi_queuecmd_lck(struct scsi_cmnd *SCpnt,
     SCpnt->scsi_done = done;
     SCpnt->host_scribble = NULL;
     SCpnt->result = 0;
-    SCpnt->tag = 0;
     SCpnt->SCp.phase = (int)acornscsi_datadirection(SCpnt->cmnd[0]);
     SCpnt->SCp.sent_command = 0;
     SCpnt->SCp.scsi_xferred = 0;
@@ -2581,7 +2529,7 @@ static enum res_abort acornscsi_do_abort(AS_Host *host, struct scsi_cmnd *SCpnt)
                        break;
 
                default:
-                       acornscsi_abortcmd(host, host->SCpnt->tag);
+                       acornscsi_abortcmd(host);
                        res = res_snooze;
                }
                local_irq_restore(flags);
@@ -2747,9 +2695,6 @@ char *acornscsi_info(struct Scsi_Host *host)
 #ifdef CONFIG_SCSI_ACORNSCSI_SYNC
     " SYNC"
 #endif
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-    " TAG"
-#endif
 #if (DEBUG & DEBUG_NO_WRITE)
     " NOWRITE (" __stringify(NO_WRITE) ")"
 #endif
@@ -2770,9 +2715,6 @@ static int acornscsi_show_info(struct seq_file *m, struct Scsi_Host *instance)
 #ifdef CONFIG_SCSI_ACORNSCSI_SYNC
     " SYNC"
 #endif
-#ifdef CONFIG_SCSI_ACORNSCSI_TAGGED_QUEUE
-    " TAG"
-#endif
 #if (DEBUG & DEBUG_NO_WRITE)
     " NOWRITE (" __stringify(NO_WRITE) ")"
 #endif
@@ -2827,9 +2769,8 @@ static int acornscsi_show_info(struct seq_file *m, struct Scsi_Host *instance)
        seq_printf(m, "Device/Lun TaggedQ      Sync\n");
        seq_printf(m, "     %d/%llu   ", scd->id, scd->lun);
        if (scd->tagged_supported)
-               seq_printf(m, "%3sabled(%3d) ",
-                            scd->simple_tags ? "en" : "dis",
-                            scd->current_tag);
+               seq_printf(m, "%3sabled ",
+                            scd->simple_tags ? "en" : "dis");
        else
                seq_printf(m, "unsupported  ");
 
index 9c4458a..cf71ef4 100644 (file)
@@ -77,7 +77,6 @@
  *  I was thinking that this was a good chip until I found this restriction ;(
  */
 #define SCSI2_SYNC
-#undef  SCSI2_TAG
 
 #undef DEBUG_CONNECT
 #undef DEBUG_MESSAGES
@@ -990,7 +989,7 @@ fas216_reselected_intr(FAS216_Info *info)
                info->scsi.disconnectable = 0;
                if (info->SCpnt->device->id  == target &&
                    info->SCpnt->device->lun == lun &&
-                   info->SCpnt->tag         == tag) {
+                   scsi_cmd_to_rq(info->SCpnt)->tag == tag) {
                        fas216_log(info, LOG_CONNECT, "reconnected previously executing command");
                } else {
                        queue_add_cmd_tail(&info->queues.disconnected, info->SCpnt);
@@ -1791,8 +1790,9 @@ static void fas216_start_command(FAS216_Info *info, struct scsi_cmnd *SCpnt)
        /*
         * add tag message if required
         */
-       if (SCpnt->tag)
-               msgqueue_addmsg(&info->scsi.msgs, 2, SIMPLE_QUEUE_TAG, SCpnt->tag);
+       if (SCpnt->device->simple_tags)
+               msgqueue_addmsg(&info->scsi.msgs, 2, SIMPLE_QUEUE_TAG,
+                               scsi_cmd_to_rq(SCpnt)->tag);
 
        do {
 #ifdef SCSI2_SYNC
@@ -1815,20 +1815,8 @@ static void fas216_start_command(FAS216_Info *info, struct scsi_cmnd *SCpnt)
 
 static void fas216_allocate_tag(FAS216_Info *info, struct scsi_cmnd *SCpnt)
 {
-#ifdef SCSI2_TAG
-       /*
-        * tagged queuing - allocate a new tag to this command
-        */
-       if (SCpnt->device->simple_tags && SCpnt->cmnd[0] != REQUEST_SENSE &&
-           SCpnt->cmnd[0] != INQUIRY) {
-           SCpnt->device->current_tag += 1;
-               if (SCpnt->device->current_tag == 0)
-                   SCpnt->device->current_tag = 1;
-                       SCpnt->tag = SCpnt->device->current_tag;
-       } else
-#endif
-               set_bit(SCpnt->device->id * 8 +
-                       (u8)(SCpnt->device->lun & 0x7), info->busyluns);
+       set_bit(SCpnt->device->id * 8 +
+               (u8)(SCpnt->device->lun & 0x7), info->busyluns);
 
        info->stats.removes += 1;
        switch (SCpnt->cmnd[0]) {
@@ -2117,7 +2105,6 @@ request_sense:
        init_SCp(SCpnt);
        SCpnt->SCp.Message = 0;
        SCpnt->SCp.Status = 0;
-       SCpnt->tag = 0;
        SCpnt->host_scribble = (void *)fas216_rq_sns_done;
 
        /*
@@ -2223,7 +2210,6 @@ static int fas216_queue_command_lck(struct scsi_cmnd *SCpnt,
        init_SCp(SCpnt);
 
        info->stats.queues += 1;
-       SCpnt->tag = 0;
 
        spin_lock(&info->host_lock);
 
@@ -3003,9 +2989,8 @@ void fas216_print_devices(FAS216_Info *info, struct seq_file *m)
                dev = &info->device[scd->id];
                seq_printf(m, "     %d/%llu   ", scd->id, scd->lun);
                if (scd->tagged_supported)
-                       seq_printf(m, "%3sabled(%3d) ",
-                                    scd->simple_tags ? "en" : "dis",
-                                    scd->current_tag);
+                       seq_printf(m, "%3sabled ",
+                                    scd->simple_tags ? "en" : "dis");
                else
                        seq_puts(m, "unsupported   ");
 
index e5559f2..c6f71a7 100644 (file)
@@ -214,7 +214,7 @@ struct scsi_cmnd *queue_remove_tgtluntag(Queue_t *queue, int target, int lun,
        list_for_each(l, &queue->head) {
                QE_t *q = list_entry(l, QE_t, list);
                if (q->SCpnt->device->id == target && q->SCpnt->device->lun == lun &&
-                   q->SCpnt->tag == tag) {
+                   scsi_cmd_to_rq(q->SCpnt)->tag == tag) {
                        SCpnt = __queue_remove(queue, l);
                        break;
                }
index 390b07b..ccbded3 100644 (file)
@@ -1254,3 +1254,4 @@ MODULE_DEVICE_TABLE(pci, csio_pci_tbl);
 MODULE_VERSION(CSIO_DRV_VERSION);
 MODULE_FIRMWARE(FW_FNAME_T5);
 MODULE_FIRMWARE(FW_FNAME_T6);
+MODULE_SOFTDEP("pre: cxgb4");
index bb3b460..4d73e92 100644 (file)
@@ -880,11 +880,11 @@ efct_lio_npiv_drop_nport(struct se_wwn *wwn)
        struct efct *efct = lio_vport->efct;
        unsigned long flags = 0;
 
-       spin_lock_irqsave(&efct->tgt_efct.efct_lio_lock, flags);
-
        if (lio_vport->fc_vport)
                fc_vport_terminate(lio_vport->fc_vport);
 
+       spin_lock_irqsave(&efct->tgt_efct.efct_lio_lock, flags);
+
        list_for_each_entry_safe(vport, next_vport, &efct->tgt_efct.vport_list,
                                 list_entry) {
                if (vport->lio_vport == lio_vport) {
index 40fb3a7..cf2e41d 100644 (file)
@@ -32,7 +32,7 @@ efct_scsi_io_alloc(struct efct_node *node)
        struct efct *efct;
        struct efct_xport *xport;
        struct efct_io *io;
-       unsigned long flags = 0;
+       unsigned long flags;
 
        efct = node->efct;
 
@@ -44,7 +44,6 @@ efct_scsi_io_alloc(struct efct_node *node)
        if (!io) {
                efc_log_err(efct, "IO alloc Failed\n");
                atomic_add_return(1, &xport->io_alloc_failed_count);
-               spin_unlock_irqrestore(&node->active_ios_lock, flags);
                return NULL;
        }
 
index 725ca2a..52be013 100644 (file)
@@ -928,22 +928,21 @@ __efc_d_wait_topology_notify(struct efc_sm_ctx *ctx,
                break;
 
        case EFC_EVT_NPORT_TOPOLOGY_NOTIFY: {
-               enum efc_nport_topology topology =
-                                       (enum efc_nport_topology)arg;
+               enum efc_nport_topology *topology = arg;
 
                WARN_ON(node->nport->domain->attached);
 
                WARN_ON(node->send_ls_acc != EFC_NODE_SEND_LS_ACC_PLOGI);
 
                node_printf(node, "topology notification, topology=%d\n",
-                           topology);
+                           *topology);
 
                /* At the time the PLOGI was received, the topology was unknown,
                 * so we didn't know which node would perform the domain attach:
                 * 1. The node from which the PLOGI was sent (p2p) or
                 * 2. The node to which the FLOGI was sent (fabric).
                 */
-               if (topology == EFC_NPORT_TOPO_P2P) {
+               if (*topology == EFC_NPORT_TOPO_P2P) {
                        /* if this is p2p, need to attach to the domain using
                         * the d_id from the PLOGI received
                         */
index d397220..3270ce4 100644 (file)
@@ -107,7 +107,6 @@ void
 efc_fabric_notify_topology(struct efc_node *node)
 {
        struct efc_node *tmp_node;
-       enum efc_nport_topology topology = node->nport->topology;
        unsigned long index;
 
        /*
@@ -118,7 +117,7 @@ efc_fabric_notify_topology(struct efc_node *node)
                if (tmp_node != node) {
                        efc_node_post_event(tmp_node,
                                            EFC_EVT_NPORT_TOPOLOGY_NOTIFY,
-                                           (void *)topology);
+                                           &node->nport->topology);
                }
        }
 }
index 4683c18..5bc91d3 100644 (file)
@@ -2281,11 +2281,6 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)
                return FAILED;
        }
 
-       conn = session->leadconn;
-       iscsi_get_conn(conn->cls_conn);
-       conn->eh_abort_cnt++;
-       age = session->age;
-
        spin_lock(&session->back_lock);
        task = (struct iscsi_task *)sc->SCp.ptr;
        if (!task || !task->sc) {
@@ -2293,8 +2288,16 @@ int iscsi_eh_abort(struct scsi_cmnd *sc)
                ISCSI_DBG_EH(session, "sc completed while abort in progress\n");
 
                spin_unlock(&session->back_lock);
-               goto success;
+               spin_unlock_bh(&session->frwd_lock);
+               mutex_unlock(&session->eh_mutex);
+               return SUCCESS;
        }
+
+       conn = session->leadconn;
+       iscsi_get_conn(conn->cls_conn);
+       conn->eh_abort_cnt++;
+       age = session->age;
+
        ISCSI_DBG_EH(session, "aborting [sc %p itt 0x%x]\n", sc, task->itt);
        __iscsi_get_task(task);
        spin_unlock(&session->back_lock);
index b35bf70..ebe4179 100644 (file)
@@ -285,11 +285,8 @@ buffer_done:
                                "6312 Catching potential buffer "
                                "overflow > PAGE_SIZE = %lu bytes\n",
                                PAGE_SIZE);
-               strscpy(buf + PAGE_SIZE - 1 -
-                       strnlen(LPFC_INFO_MORE_STR, PAGE_SIZE - 1),
-                       LPFC_INFO_MORE_STR,
-                       strnlen(LPFC_INFO_MORE_STR, PAGE_SIZE - 1)
-                       + 1);
+               strscpy(buf + PAGE_SIZE - 1 - sizeof(LPFC_INFO_MORE_STR),
+                       LPFC_INFO_MORE_STR, sizeof(LPFC_INFO_MORE_STR) + 1);
        }
        return len;
 }
@@ -6204,7 +6201,8 @@ lpfc_sg_seg_cnt_show(struct device *dev, struct device_attribute *attr,
        len = scnprintf(buf, PAGE_SIZE, "SGL sz: %d  total SGEs: %d\n",
                       phba->cfg_sg_dma_buf_size, phba->cfg_total_seg_cnt);
 
-       len += scnprintf(buf + len, PAGE_SIZE, "Cfg: %d  SCSI: %d  NVME: %d\n",
+       len += scnprintf(buf + len, PAGE_SIZE - len,
+                       "Cfg: %d  SCSI: %d  NVME: %d\n",
                        phba->cfg_sg_seg_cnt, phba->cfg_scsi_seg_cnt,
                        phba->cfg_nvme_seg_cnt);
        return len;
index 1254a57..052c0e5 100644 (file)
@@ -4015,11 +4015,11 @@ lpfc_cmpl_els_edc(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
                                be32_to_cpu(pcgd->desc_tag),
                                be32_to_cpu(pcgd->desc_len),
                                be32_to_cpu(pcgd->xmt_signal_capability),
-                               be32_to_cpu(pcgd->xmt_signal_frequency.count),
-                               be32_to_cpu(pcgd->xmt_signal_frequency.units),
+                               be16_to_cpu(pcgd->xmt_signal_frequency.count),
+                               be16_to_cpu(pcgd->xmt_signal_frequency.units),
                                be32_to_cpu(pcgd->rcv_signal_capability),
-                               be32_to_cpu(pcgd->rcv_signal_frequency.count),
-                               be32_to_cpu(pcgd->rcv_signal_frequency.units));
+                               be16_to_cpu(pcgd->rcv_signal_frequency.count),
+                               be16_to_cpu(pcgd->rcv_signal_frequency.units));
 
                        /* Compare driver and Fport capabilities and choose
                         * least common.
@@ -9387,7 +9387,7 @@ lpfc_display_fpin_wwpn(struct lpfc_hba *phba, __be64 *wwnlist, u32 cnt)
                /* Extract the next WWPN from the payload */
                wwn = *wwnlist++;
                wwpn = be64_to_cpu(wwn);
-               len += scnprintf(buf + len, LPFC_FPIN_WWPN_LINE_SZ,
+               len += scnprintf(buf + len, LPFC_FPIN_WWPN_LINE_SZ - len,
                                 " %016llx", wwpn);
 
                /* Log a message if we are on the last WWPN
index 79a4872..7359505 100644 (file)
@@ -1167,7 +1167,7 @@ struct lpfc_mbx_read_object {  /* Version 0 */
 #define lpfc_mbx_rd_object_rlen_MASK   0x00FFFFFF
 #define lpfc_mbx_rd_object_rlen_WORD   word0
                        uint32_t rd_object_offset;
-                       uint32_t rd_object_name[LPFC_MBX_OBJECT_NAME_LEN_DW];
+                       __le32 rd_object_name[LPFC_MBX_OBJECT_NAME_LEN_DW];
 #define LPFC_OBJ_NAME_SZ 104   /* 26 x sizeof(uint32_t) is 104. */
                        uint32_t rd_object_cnt;
                        struct lpfc_mbx_host_buf rd_object_hbuf[4];
index 0ec322f..195169b 100644 (file)
@@ -5518,7 +5518,7 @@ lpfc_cgn_update_stat(struct lpfc_hba *phba, uint32_t dtag)
        if (phba->cgn_fpin_frequency &&
            phba->cgn_fpin_frequency != LPFC_FPIN_INIT_FREQ) {
                value = LPFC_CGN_TIMER_TO_MIN / phba->cgn_fpin_frequency;
-               cp->cgn_stat_npm = cpu_to_le32(value);
+               cp->cgn_stat_npm = value;
        }
        value = lpfc_cgn_calc_crc32(cp, LPFC_CGN_INFO_SZ,
                                    LPFC_CGN_CRC32_SEED);
@@ -5547,9 +5547,9 @@ lpfc_cgn_save_evt_cnt(struct lpfc_hba *phba)
        uint32_t mbps;
        uint32_t dvalue, wvalue, lvalue, avalue;
        uint64_t latsum;
-       uint16_t *ptr;
-       uint32_t *lptr;
-       uint16_t *mptr;
+       __le16 *ptr;
+       __le32 *lptr;
+       __le16 *mptr;
 
        /* Make sure we have a congestion info buffer */
        if (!phba->cgn_i)
@@ -5570,7 +5570,7 @@ lpfc_cgn_save_evt_cnt(struct lpfc_hba *phba)
        if (phba->cgn_fpin_frequency &&
            phba->cgn_fpin_frequency != LPFC_FPIN_INIT_FREQ) {
                value = LPFC_CGN_TIMER_TO_MIN / phba->cgn_fpin_frequency;
-               cp->cgn_stat_npm = cpu_to_le32(value);
+               cp->cgn_stat_npm = value;
        }
 
        /* Read and clear the latency counters for this minute */
@@ -5753,7 +5753,7 @@ lpfc_cgn_save_evt_cnt(struct lpfc_hba *phba)
                        dvalue += le32_to_cpu(cp->cgn_drvr_hr[i]);
                        wvalue += le32_to_cpu(cp->cgn_warn_hr[i]);
                        lvalue += le32_to_cpu(cp->cgn_latency_hr[i]);
-                       mbps += le32_to_cpu(cp->cgn_bw_hr[i]);
+                       mbps += le16_to_cpu(cp->cgn_bw_hr[i]);
                        avalue += le32_to_cpu(cp->cgn_alarm_hr[i]);
                }
                if (lvalue)             /* Avg of latency averages */
@@ -8277,11 +8277,11 @@ lpfc_sli4_driver_resource_setup(struct lpfc_hba *phba)
        return 0;
 
 out_free_hba_hdwq_info:
-       free_percpu(phba->sli4_hba.c_stat);
 #ifdef CONFIG_SCSI_LPFC_DEBUG_FS
+       free_percpu(phba->sli4_hba.c_stat);
 out_free_hba_idle_stat:
-       kfree(phba->sli4_hba.idle_stat);
 #endif
+       kfree(phba->sli4_hba.idle_stat);
 out_free_hba_eq_info:
        free_percpu(phba->sli4_hba.eq_info);
 out_free_hba_cpu_map:
@@ -13411,8 +13411,8 @@ lpfc_init_congestion_buf(struct lpfc_hba *phba)
 
        /* last used Index initialized to 0xff already */
 
-       cp->cgn_warn_freq = LPFC_FPIN_INIT_FREQ;
-       cp->cgn_alarm_freq = LPFC_FPIN_INIT_FREQ;
+       cp->cgn_warn_freq = cpu_to_le16(LPFC_FPIN_INIT_FREQ);
+       cp->cgn_alarm_freq = cpu_to_le16(LPFC_FPIN_INIT_FREQ);
        crc = lpfc_cgn_calc_crc32(cp, LPFC_CGN_INFO_SZ, LPFC_CGN_CRC32_SEED);
        cp->cgn_info_crc = cpu_to_le32(crc);
 
index 73a3568..479b3ee 100644 (file)
@@ -1489,9 +1489,7 @@ lpfc_nvme_fcp_io_submit(struct nvme_fc_local_port *pnvme_lport,
        struct lpfc_nvme_qhandle *lpfc_queue_info;
        struct lpfc_nvme_fcpreq_priv *freqpriv;
        struct nvme_common_command *sqe;
-#ifdef CONFIG_SCSI_LPFC_DEBUG_FS
        uint64_t start = 0;
-#endif
 
        /* Validate pointers. LLDD fault handling with transport does
         * have timing races.
index 0fde1e8..befdf86 100644 (file)
@@ -1495,7 +1495,6 @@ static int
 lpfc_bg_err_opcodes(struct lpfc_hba *phba, struct scsi_cmnd *sc,
                uint8_t *txop, uint8_t *rxop)
 {
-       uint8_t ret = 0;
 
        if (sc->prot_flags & SCSI_PROT_IP_CHECKSUM) {
                switch (scsi_get_prot_op(sc)) {
@@ -1548,7 +1547,7 @@ lpfc_bg_err_opcodes(struct lpfc_hba *phba, struct scsi_cmnd *sc,
                }
        }
 
-       return ret;
+       return 0;
 }
 #endif
 
@@ -5578,12 +5577,8 @@ lpfc_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *cmnd)
        struct fc_rport *rport = starget_to_rport(scsi_target(cmnd->device));
        int err, idx;
        u8 *uuid = NULL;
-#ifdef CONFIG_SCSI_LPFC_DEBUG_FS
-       uint64_t start = 0L;
+       uint64_t start;
 
-       if (phba->ktime_on)
-               start = ktime_get_ns();
-#endif
        start = ktime_get_ns();
        rdata = lpfc_rport_data_from_scsi_device(cmnd->device);
 
index ffd8a14..026a119 100644 (file)
@@ -12292,12 +12292,12 @@ void
 lpfc_ignore_els_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
                     struct lpfc_iocbq *rspiocb)
 {
-       struct lpfc_nodelist *ndlp = (struct lpfc_nodelist *) cmdiocb->context1;
+       struct lpfc_nodelist *ndlp = NULL;
        IOCB_t *irsp = &rspiocb->iocb;
 
        /* ELS cmd tag <ulpIoTag> completes */
        lpfc_printf_log(phba, KERN_INFO, LOG_ELS,
-                       "0139 Ignoring ELS cmd tag x%x completion Data: "
+                       "0139 Ignoring ELS cmd code x%x completion Data: "
                        "x%x x%x x%x\n",
                        irsp->ulpIoTag, irsp->ulpStatus,
                        irsp->un.ulpWord[4], irsp->ulpTimeout);
@@ -12305,10 +12305,13 @@ lpfc_ignore_els_cmpl(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
         * Deref the ndlp after free_iocb. sli_release_iocb will access the ndlp
         * if exchange is busy.
         */
-       if (cmdiocb->iocb.ulpCommand == CMD_GEN_REQUEST64_CR)
+       if (cmdiocb->iocb.ulpCommand == CMD_GEN_REQUEST64_CR) {
+               ndlp = cmdiocb->context_un.ndlp;
                lpfc_ct_free_iocb(phba, cmdiocb);
-       else
+       } else {
+               ndlp = (struct lpfc_nodelist *) cmdiocb->context1;
                lpfc_els_free_iocb(phba, cmdiocb);
+       }
 
        lpfc_nlp_put(ndlp);
 }
@@ -22090,6 +22093,7 @@ lpfc_read_object(struct lpfc_hba *phba, char *rdobject, uint32_t *datap,
        uint32_t shdr_status, shdr_add_status;
        union lpfc_sli4_cfg_shdr *shdr;
        struct lpfc_dmabuf *pcmd;
+       u32 rd_object_name[LPFC_MBX_OBJECT_NAME_LEN_DW] = {0};
 
        /* sanity check on queue memory */
        if (!datap)
@@ -22113,10 +22117,10 @@ lpfc_read_object(struct lpfc_hba *phba, char *rdobject, uint32_t *datap,
 
        memset((void *)read_object->u.request.rd_object_name, 0,
               LPFC_OBJ_NAME_SZ);
-       sprintf((uint8_t *)read_object->u.request.rd_object_name, rdobject);
+       scnprintf((char *)rd_object_name, sizeof(rd_object_name), rdobject);
        for (j = 0; j < strlen(rdobject); j++)
                read_object->u.request.rd_object_name[j] =
-                       cpu_to_le32(read_object->u.request.rd_object_name[j]);
+                       cpu_to_le32(rd_object_name[j]);
 
        pcmd = kmalloc(sizeof(*pcmd), GFP_KERNEL);
        if (pcmd)
index e4298bf..39d8754 100644 (file)
@@ -1916,7 +1916,7 @@ void megasas_set_dynamic_target_properties(struct scsi_device *sdev,
                raid = MR_LdRaidGet(ld, local_map_ptr);
 
                if (raid->capability.ldPiMode == MR_PROT_INFO_TYPE_CONTROLLER)
-               blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
+                       blk_queue_update_dma_alignment(sdev->request_queue, 0x7);
 
                mr_device_priv_data->is_tm_capable =
                        raid->capability.tmCapable;
@@ -8033,7 +8033,7 @@ skip_firing_dcmds:
 
        if (instance->adapter_type != MFI_SERIES) {
                megasas_release_fusion(instance);
-                       pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
+               pd_seq_map_sz = sizeof(struct MR_PD_CFG_SEQ_NUM_SYNC) +
                                (sizeof(struct MR_PD_CFG_SEQ) *
                                        (MAX_PHYSICAL_DEVICES - 1));
                for (i = 0; i < 2 ; i++) {
@@ -8773,8 +8773,7 @@ int megasas_update_device_list(struct megasas_instance *instance,
 
                if (event_type & SCAN_VD_CHANNEL) {
                        if (!instance->requestorId ||
-                           (instance->requestorId &&
-                            megasas_get_ld_vf_affiliation(instance, 0))) {
+                       megasas_get_ld_vf_affiliation(instance, 0)) {
                                dcmd_ret = megasas_ld_list_query(instance,
                                                MR_LD_QUERY_TYPE_EXPOSED_TO_HOST);
                                if (dcmd_ret != DCMD_SUCCESS)
index 6c82435..27eb652 100644 (file)
@@ -1582,8 +1582,10 @@ mpt3sas_base_pause_mq_polling(struct MPT3SAS_ADAPTER *ioc)
         * wait for current poll to complete.
         */
        for (qid = 0; qid < iopoll_q_count; qid++) {
-               while (atomic_read(&ioc->io_uring_poll_queues[qid].busy))
+               while (atomic_read(&ioc->io_uring_poll_queues[qid].busy)) {
+                       cpu_relax();
                        udelay(500);
+               }
        }
 }
 
index 770b241..1b79f01 100644 (file)
@@ -2178,7 +2178,7 @@ mpt3sas_send_diag_release(struct MPT3SAS_ADAPTER *ioc, u8 buffer_type,
                mpt3sas_check_cmd_timeout(ioc,
                    ioc->ctl_cmds.status, mpi_request,
                    sizeof(Mpi2DiagReleaseRequest_t)/4, reset_needed);
-                *issue_reset = reset_needed;
+               *issue_reset = reset_needed;
                rc = -EFAULT;
                goto out;
        }
index 2f82b1e..d383d4a 100644 (file)
@@ -10749,8 +10749,7 @@ _mpt3sas_fw_work(struct MPT3SAS_ADAPTER *ioc, struct fw_event_work *fw_event)
        case MPI2_EVENT_PCIE_TOPOLOGY_CHANGE_LIST:
                _scsih_pcie_topology_change_event(ioc, fw_event);
                ioc->current_event = NULL;
-                       return;
-       break;
+               return;
        }
 out:
        fw_event_work_put(fw_event);
index 7a4f5d4..2b8c6fa 100644 (file)
@@ -1939,11 +1939,8 @@ static   void    ncr_start_next_ccb (struct ncb *np, struct lcb * lp, int maxn);
 static void    ncr_put_start_queue(struct ncb *np, struct ccb *cp);
 
 static void insert_into_waiting_list(struct ncb *np, struct scsi_cmnd *cmd);
-static struct scsi_cmnd *retrieve_from_waiting_list(int to_remove, struct ncb *np, struct scsi_cmnd *cmd);
 static void process_waiting_list(struct ncb *np, int sts);
 
-#define remove_from_waiting_list(np, cmd) \
-               retrieve_from_waiting_list(1, (np), (cmd))
 #define requeue_waiting_list(np) process_waiting_list((np), DID_OK)
 #define reset_waiting_list(np) process_waiting_list((np), DID_RESET)
 
@@ -7997,26 +7994,6 @@ static void insert_into_waiting_list(struct ncb *np, struct scsi_cmnd *cmd)
        }
 }
 
-static struct scsi_cmnd *retrieve_from_waiting_list(int to_remove, struct ncb *np, struct scsi_cmnd *cmd)
-{
-       struct scsi_cmnd **pcmd = &np->waiting_list;
-
-       while (*pcmd) {
-               if (cmd == *pcmd) {
-                       if (to_remove) {
-                               *pcmd = (struct scsi_cmnd *) cmd->next_wcmd;
-                               cmd->next_wcmd = NULL;
-                       }
-#ifdef DEBUG_WAITING_LIST
-       printk("%s: cmd %lx retrieved from waiting list\n", ncr_name(np), (u_long) cmd);
-#endif
-                       return cmd;
-               }
-               pcmd = (struct scsi_cmnd **) &(*pcmd)->next_wcmd;
-       }
-       return NULL;
-}
-
 static void process_waiting_list(struct ncb *np, int sts)
 {
        struct scsi_cmnd *waiting_list, *wcmd;
index 1e4e3e8..5fc7697 100644 (file)
@@ -7169,7 +7169,8 @@ qla2x00_abort_isp(scsi_qla_host_t *vha)
                                return 0;
                        break;
                case QLA2XXX_INI_MODE_DUAL:
-                       if (!qla_dual_mode_enabled(vha))
+                       if (!qla_dual_mode_enabled(vha) &&
+                           !qla_ini_mode_enabled(vha))
                                return 0;
                        break;
                case QLA2XXX_INI_MODE_ENABLED:
index ece6026..b26f269 100644 (file)
@@ -2634,7 +2634,7 @@ static void qla24xx_nvme_iocb_entry(scsi_qla_host_t *vha, struct req_que *req,
        }
 
        if (unlikely(logit))
-               ql_log(ql_log_warn, fcport->vha, 0x5060,
+               ql_log(ql_dbg_io, fcport->vha, 0x5060,
                   "NVME-%s ERR Handling - hdl=%x status(%x) tr_len:%x resid=%x  ox_id=%x\n",
                   sp->name, sp->handle, comp_status,
                   fd->transferred_length, le32_to_cpu(sts->residual_len),
@@ -3491,7 +3491,7 @@ check_scsi_status:
 
 out:
        if (logit)
-               ql_log(ql_log_warn, fcport->vha, 0x3022,
+               ql_log(ql_dbg_io, fcport->vha, 0x3022,
                       "FCP command status: 0x%x-0x%x (0x%x) nexus=%ld:%d:%llu portid=%02x%02x%02x oxid=0x%x cdb=%10phN len=0x%x rsp_info=0x%x resid=0x%x fw_resid=0x%x sp=%p cp=%p.\n",
                       comp_status, scsi_status, res, vha->host_no,
                       cp->device->id, cp->device->lun, fcport->d_id.b.domain,
index d8b05d8..922e4c7 100644 (file)
@@ -441,9 +441,7 @@ static umode_t iscsi_iface_attr_is_visible(struct kobject *kobj,
        struct iscsi_transport *t = iface->transport;
        int param = -1;
 
-       if (attr == &dev_attr_iface_enabled.attr)
-               param = ISCSI_NET_PARAM_IFACE_ENABLE;
-       else if (attr == &dev_attr_iface_def_taskmgmt_tmo.attr)
+       if (attr == &dev_attr_iface_def_taskmgmt_tmo.attr)
                param = ISCSI_IFACE_PARAM_DEF_TASKMGMT_TMO;
        else if (attr == &dev_attr_iface_header_digest.attr)
                param = ISCSI_IFACE_PARAM_HDRDGST_EN;
@@ -483,7 +481,9 @@ static umode_t iscsi_iface_attr_is_visible(struct kobject *kobj,
        if (param != -1)
                return t->attr_is_visible(ISCSI_IFACE_PARAM, param);
 
-       if (attr == &dev_attr_iface_vlan_id.attr)
+       if (attr == &dev_attr_iface_enabled.attr)
+               param = ISCSI_NET_PARAM_IFACE_ENABLE;
+       else if (attr == &dev_attr_iface_vlan_id.attr)
                param = ISCSI_NET_PARAM_VLAN_ID;
        else if (attr == &dev_attr_iface_vlan_priority.attr)
                param = ISCSI_NET_PARAM_VLAN_PRIORITY;
index cbd9999..523bf2f 100644 (file)
@@ -2124,6 +2124,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
                retries = 0;
 
                do {
+                       bool media_was_present = sdkp->media_present;
+
                        cmd[0] = TEST_UNIT_READY;
                        memset((void *) &cmd[1], 0, 9);
 
@@ -2138,7 +2140,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
                         * with any more polling.
                         */
                        if (media_not_present(sdkp, &sshdr)) {
-                               sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n");
+                               if (media_was_present)
+                                       sd_printk(KERN_NOTICE, sdkp, "Media removed, stopped polling\n");
                                return;
                        }
 
@@ -3401,15 +3404,16 @@ static int sd_probe(struct device *dev)
        }
 
        device_initialize(&sdkp->dev);
-       sdkp->dev.parent = dev;
+       sdkp->dev.parent = get_device(dev);
        sdkp->dev.class = &sd_disk_class;
        dev_set_name(&sdkp->dev, "%s", dev_name(dev));
 
        error = device_add(&sdkp->dev);
-       if (error)
-               goto out_free_index;
+       if (error) {
+               put_device(&sdkp->dev);
+               goto out;
+       }
 
-       get_device(dev);
        dev_set_drvdata(dev, sdkp);
 
        gd->major = sd_major((index & 0xf0) >> 4);
index b9757f2..ed06798 100644 (file)
@@ -154,8 +154,8 @@ static void *sd_zbc_alloc_report_buffer(struct scsi_disk *sdkp,
 
        /*
         * Report zone buffer size should be at most 64B times the number of
-        * zones requested plus the 64B reply header, but should be at least
-        * SECTOR_SIZE for ATA devices.
+        * zones requested plus the 64B reply header, but should be aligned
+        * to SECTOR_SIZE for ATA devices.
         * Make sure that this size does not exceed the hardware capabilities.
         * Furthermore, since the report zone command cannot be split, make
         * sure that the allocated buffer can always be mapped by limiting the
@@ -174,7 +174,7 @@ static void *sd_zbc_alloc_report_buffer(struct scsi_disk *sdkp,
                        *buflen = bufsize;
                        return buf;
                }
-               bufsize >>= 1;
+               bufsize = rounddown(bufsize >> 1, SECTOR_SIZE);
        }
 
        return NULL;
@@ -280,7 +280,7 @@ static void sd_zbc_update_wp_offset_workfn(struct work_struct *work)
 {
        struct scsi_disk *sdkp;
        unsigned long flags;
-       unsigned int zno;
+       sector_t zno;
        int ret;
 
        sdkp = container_of(work, struct scsi_disk, zone_wp_offset_work);
index c2afba2..0a1734f 100644 (file)
@@ -87,9 +87,16 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
                0
        };
        unsigned char recv_page_code;
+       unsigned int retries = SES_RETRIES;
+       struct scsi_sense_hdr sshdr;
+
+       do {
+               ret = scsi_execute_req(sdev, cmd, DMA_FROM_DEVICE, buf, bufflen,
+                                      &sshdr, SES_TIMEOUT, 1, NULL);
+       } while (ret > 0 && --retries && scsi_sense_valid(&sshdr) &&
+                (sshdr.sense_key == NOT_READY ||
+                 (sshdr.sense_key == UNIT_ATTENTION && sshdr.asc == 0x29)));
 
-       ret =  scsi_execute_req(sdev, cmd, DMA_FROM_DEVICE, buf, bufflen,
-                               NULL, SES_TIMEOUT, SES_RETRIES, NULL);
        if (unlikely(ret))
                return ret;
 
@@ -111,7 +118,7 @@ static int ses_recv_diag(struct scsi_device *sdev, int page_code,
 static int ses_send_diag(struct scsi_device *sdev, int page_code,
                         void *buf, int bufflen)
 {
-       u32 result;
+       int result;
 
        unsigned char cmd[] = {
                SEND_DIAGNOSTIC,
@@ -121,9 +128,16 @@ static int ses_send_diag(struct scsi_device *sdev, int page_code,
                bufflen & 0xff,
                0
        };
+       struct scsi_sense_hdr sshdr;
+       unsigned int retries = SES_RETRIES;
+
+       do {
+               result = scsi_execute_req(sdev, cmd, DMA_TO_DEVICE, buf, bufflen,
+                                         &sshdr, SES_TIMEOUT, 1, NULL);
+       } while (result > 0 && --retries && scsi_sense_valid(&sshdr) &&
+                (sshdr.sense_key == NOT_READY ||
+                 (sshdr.sense_key == UNIT_ATTENTION && sshdr.asc == 0x29)));
 
-       result = scsi_execute_req(sdev, cmd, DMA_TO_DEVICE, buf, bufflen,
-                                 NULL, SES_TIMEOUT, SES_RETRIES, NULL);
        if (result)
                sdev_printk(KERN_ERR, sdev, "SEND DIAGNOSTIC result: %8x\n",
                            result);
index 79d9aa2..ddd00ef 100644 (file)
@@ -523,7 +523,7 @@ static int sr_read_sector(Scsi_CD *cd, int lba, int blksize, unsigned char *dest
                        return rc;
                cd->readcd_known = 0;
                sr_printk(KERN_INFO, cd,
-                         "CDROM does'nt support READ CD (0xbe) command\n");
+                         "CDROM doesn't support READ CD (0xbe) command\n");
                /* fall & retry the other way */
        }
        /* ... if this fails, we switch the blocksize using MODE SELECT */
index 9d04929..ae8636d 100644 (file)
@@ -3823,6 +3823,7 @@ static long st_ioctl(struct file *file, unsigned int cmd_in, unsigned long arg)
        case CDROM_SEND_PACKET:
                if (!capable(CAP_SYS_RAWIO))
                        return -EPERM;
+               break;
        default:
                break;
        }
index b3bcc5c..149c1aa 100644 (file)
@@ -128,6 +128,81 @@ static int ufs_intel_link_startup_notify(struct ufs_hba *hba,
        return err;
 }
 
+static int ufs_intel_set_lanes(struct ufs_hba *hba, u32 lanes)
+{
+       struct ufs_pa_layer_attr pwr_info = hba->pwr_info;
+       int ret;
+
+       pwr_info.lane_rx = lanes;
+       pwr_info.lane_tx = lanes;
+       ret = ufshcd_config_pwr_mode(hba, &pwr_info);
+       if (ret)
+               dev_err(hba->dev, "%s: Setting %u lanes, err = %d\n",
+                       __func__, lanes, ret);
+       return ret;
+}
+
+static int ufs_intel_lkf_pwr_change_notify(struct ufs_hba *hba,
+                               enum ufs_notify_change_status status,
+                               struct ufs_pa_layer_attr *dev_max_params,
+                               struct ufs_pa_layer_attr *dev_req_params)
+{
+       int err = 0;
+
+       switch (status) {
+       case PRE_CHANGE:
+               if (ufshcd_is_hs_mode(dev_max_params) &&
+                   (hba->pwr_info.lane_rx != 2 || hba->pwr_info.lane_tx != 2))
+                       ufs_intel_set_lanes(hba, 2);
+               memcpy(dev_req_params, dev_max_params, sizeof(*dev_req_params));
+               break;
+       case POST_CHANGE:
+               if (ufshcd_is_hs_mode(dev_req_params)) {
+                       u32 peer_granularity;
+
+                       usleep_range(1000, 1250);
+                       err = ufshcd_dme_peer_get(hba, UIC_ARG_MIB(PA_GRANULARITY),
+                                                 &peer_granularity);
+               }
+               break;
+       default:
+               break;
+       }
+
+       return err;
+}
+
+static int ufs_intel_lkf_apply_dev_quirks(struct ufs_hba *hba)
+{
+       u32 granularity, peer_granularity;
+       u32 pa_tactivate, peer_pa_tactivate;
+       int ret;
+
+       ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_GRANULARITY), &granularity);
+       if (ret)
+               goto out;
+
+       ret = ufshcd_dme_peer_get(hba, UIC_ARG_MIB(PA_GRANULARITY), &peer_granularity);
+       if (ret)
+               goto out;
+
+       ret = ufshcd_dme_get(hba, UIC_ARG_MIB(PA_TACTIVATE), &pa_tactivate);
+       if (ret)
+               goto out;
+
+       ret = ufshcd_dme_peer_get(hba, UIC_ARG_MIB(PA_TACTIVATE), &peer_pa_tactivate);
+       if (ret)
+               goto out;
+
+       if (granularity == peer_granularity) {
+               u32 new_peer_pa_tactivate = pa_tactivate + 2;
+
+               ret = ufshcd_dme_peer_set(hba, UIC_ARG_MIB(PA_TACTIVATE), new_peer_pa_tactivate);
+       }
+out:
+       return ret;
+}
+
 #define INTEL_ACTIVELTR                0x804
 #define INTEL_IDLELTR          0x808
 
@@ -351,6 +426,7 @@ static int ufs_intel_lkf_init(struct ufs_hba *hba)
        struct ufs_host *ufs_host;
        int err;
 
+       hba->nop_out_timeout = 200;
        hba->quirks |= UFSHCD_QUIRK_BROKEN_AUTO_HIBERN8;
        hba->caps |= UFSHCD_CAP_CRYPTO;
        err = ufs_intel_common_init(hba);
@@ -381,6 +457,8 @@ static struct ufs_hba_variant_ops ufs_intel_lkf_hba_vops = {
        .exit                   = ufs_intel_common_exit,
        .hce_enable_notify      = ufs_intel_hce_enable_notify,
        .link_startup_notify    = ufs_intel_link_startup_notify,
+       .pwr_change_notify      = ufs_intel_lkf_pwr_change_notify,
+       .apply_dev_quirks       = ufs_intel_lkf_apply_dev_quirks,
        .resume                 = ufs_intel_resume,
        .device_reset           = ufs_intel_device_reset,
 };
index 3841ab4..95be7ec 100644 (file)
@@ -17,8 +17,6 @@
 #include <linux/blk-pm.h>
 #include <linux/blkdev.h>
 #include <scsi/scsi_driver.h>
-#include <scsi/scsi_transport.h>
-#include "../scsi_transport_api.h"
 #include "ufshcd.h"
 #include "ufs_quirks.h"
 #include "unipro.h"
@@ -237,6 +235,7 @@ static int ufshcd_scale_clks(struct ufs_hba *hba, bool scale_up);
 static irqreturn_t ufshcd_intr(int irq, void *__hba);
 static int ufshcd_change_power_mode(struct ufs_hba *hba,
                             struct ufs_pa_layer_attr *pwr_mode);
+static void ufshcd_schedule_eh_work(struct ufs_hba *hba);
 static int ufshcd_setup_hba_vreg(struct ufs_hba *hba, bool on);
 static int ufshcd_setup_vreg(struct ufs_hba *hba, bool on);
 static inline int ufshcd_config_vreg_hpm(struct ufs_hba *hba,
@@ -319,8 +318,7 @@ static void ufshcd_add_query_upiu_trace(struct ufs_hba *hba,
 static void ufshcd_add_tm_upiu_trace(struct ufs_hba *hba, unsigned int tag,
                                     enum ufs_trace_str_t str_t)
 {
-       int off = (int)tag - hba->nutrs;
-       struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[off];
+       struct utp_task_req_desc *descp = &hba->utmrdl_base_addr[tag];
 
        if (!trace_ufshcd_upiu_enabled())
                return;
@@ -2759,8 +2757,13 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd)
 out:
        up_read(&hba->clk_scaling_lock);
 
-       if (ufs_trigger_eh())
-               scsi_schedule_eh(hba->host);
+       if (ufs_trigger_eh()) {
+               unsigned long flags;
+
+               spin_lock_irqsave(hba->host->host_lock, flags);
+               ufshcd_schedule_eh_work(hba);
+               spin_unlock_irqrestore(hba->host->host_lock, flags);
+       }
 
        return err;
 }
@@ -3919,35 +3922,6 @@ out:
 }
 EXPORT_SYMBOL_GPL(ufshcd_dme_get_attr);
 
-static inline bool ufshcd_is_saved_err_fatal(struct ufs_hba *hba)
-{
-       lockdep_assert_held(hba->host->host_lock);
-
-       return (hba->saved_uic_err & UFSHCD_UIC_DL_PA_INIT_ERROR) ||
-              (hba->saved_err & (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK));
-}
-
-static void ufshcd_schedule_eh(struct ufs_hba *hba)
-{
-       bool schedule_eh = false;
-       unsigned long flags;
-
-       spin_lock_irqsave(hba->host->host_lock, flags);
-       /* handle fatal errors only when link is not in error state */
-       if (hba->ufshcd_state != UFSHCD_STATE_ERROR) {
-               if (hba->force_reset || ufshcd_is_link_broken(hba) ||
-                   ufshcd_is_saved_err_fatal(hba))
-                       hba->ufshcd_state = UFSHCD_STATE_EH_SCHEDULED_FATAL;
-               else
-                       hba->ufshcd_state = UFSHCD_STATE_EH_SCHEDULED_NON_FATAL;
-               schedule_eh = true;
-       }
-       spin_unlock_irqrestore(hba->host->host_lock, flags);
-
-       if (schedule_eh)
-               scsi_schedule_eh(hba->host);
-}
-
 /**
  * ufshcd_uic_pwr_ctrl - executes UIC commands (which affects the link power
  * state) and waits for it to take effect.
@@ -3968,7 +3942,6 @@ static int ufshcd_uic_pwr_ctrl(struct ufs_hba *hba, struct uic_command *cmd)
 {
        DECLARE_COMPLETION_ONSTACK(uic_async_done);
        unsigned long flags;
-       bool schedule_eh = false;
        u8 status;
        int ret;
        bool reenable_intr = false;
@@ -4038,14 +4011,10 @@ out:
                ufshcd_enable_intr(hba, UIC_COMMAND_COMPL);
        if (ret) {
                ufshcd_set_link_broken(hba);
-               schedule_eh = true;
+               ufshcd_schedule_eh_work(hba);
        }
-
 out_unlock:
        spin_unlock_irqrestore(hba->host->host_lock, flags);
-
-       if (schedule_eh)
-               ufshcd_schedule_eh(hba);
        mutex_unlock(&hba->uic_cmd_mutex);
 
        return ret;
@@ -4776,7 +4745,7 @@ static int ufshcd_verify_dev_init(struct ufs_hba *hba)
        mutex_lock(&hba->dev_cmd.lock);
        for (retries = NOP_OUT_RETRIES; retries > 0; retries--) {
                err = ufshcd_exec_dev_cmd(hba, DEV_CMD_TYPE_NOP,
-                                              NOP_OUT_TIMEOUT);
+                                         hba->nop_out_timeout);
 
                if (!err || err == -ETIMEDOUT)
                        break;
@@ -5911,6 +5880,27 @@ out:
        return err_handling;
 }
 
+/* host lock must be held before calling this func */
+static inline bool ufshcd_is_saved_err_fatal(struct ufs_hba *hba)
+{
+       return (hba->saved_uic_err & UFSHCD_UIC_DL_PA_INIT_ERROR) ||
+              (hba->saved_err & (INT_FATAL_ERRORS | UFSHCD_UIC_HIBERN8_MASK));
+}
+
+/* host lock must be held before calling this func */
+static inline void ufshcd_schedule_eh_work(struct ufs_hba *hba)
+{
+       /* handle fatal errors only when link is not in error state */
+       if (hba->ufshcd_state != UFSHCD_STATE_ERROR) {
+               if (hba->force_reset || ufshcd_is_link_broken(hba) ||
+                   ufshcd_is_saved_err_fatal(hba))
+                       hba->ufshcd_state = UFSHCD_STATE_EH_SCHEDULED_FATAL;
+               else
+                       hba->ufshcd_state = UFSHCD_STATE_EH_SCHEDULED_NON_FATAL;
+               queue_work(hba->eh_wq, &hba->eh_work);
+       }
+}
+
 static void ufshcd_clk_scaling_allow(struct ufs_hba *hba, bool allow)
 {
        down_write(&hba->clk_scaling_lock);
@@ -6044,11 +6034,11 @@ static bool ufshcd_is_pwr_mode_restore_needed(struct ufs_hba *hba)
 
 /**
  * ufshcd_err_handler - handle UFS errors that require s/w attention
- * @host: SCSI host pointer
+ * @work: pointer to work structure
  */
-static void ufshcd_err_handler(struct Scsi_Host *host)
+static void ufshcd_err_handler(struct work_struct *work)
 {
-       struct ufs_hba *hba = shost_priv(host);
+       struct ufs_hba *hba;
        unsigned long flags;
        bool err_xfer = false;
        bool err_tm = false;
@@ -6056,9 +6046,10 @@ static void ufshcd_err_handler(struct Scsi_Host *host)
        int tag;
        bool needs_reset = false, needs_restore = false;
 
+       hba = container_of(work, struct ufs_hba, eh_work);
+
        down(&hba->host_sem);
        spin_lock_irqsave(hba->host->host_lock, flags);
-       hba->host->host_eh_scheduled = 0;
        if (ufshcd_err_handling_should_stop(hba)) {
                if (hba->ufshcd_state != UFSHCD_STATE_ERROR)
                        hba->ufshcd_state = UFSHCD_STATE_OPERATIONAL;
@@ -6371,6 +6362,7 @@ static irqreturn_t ufshcd_check_errors(struct ufs_hba *hba, u32 intr_status)
                                         "host_regs: ");
                        ufshcd_print_pwr_info(hba);
                }
+               ufshcd_schedule_eh_work(hba);
                retval |= IRQ_HANDLED;
        }
        /*
@@ -6382,34 +6374,9 @@ static irqreturn_t ufshcd_check_errors(struct ufs_hba *hba, u32 intr_status)
        hba->errors = 0;
        hba->uic_error = 0;
        spin_unlock(hba->host->host_lock);
-
-       if (queue_eh_work)
-               ufshcd_schedule_eh(hba);
-
        return retval;
 }
 
-struct ctm_info {
-       struct ufs_hba  *hba;
-       unsigned long   pending;
-       unsigned int    ncpl;
-};
-
-static bool ufshcd_compl_tm(struct request *req, void *priv, bool reserved)
-{
-       struct ctm_info *const ci = priv;
-       struct completion *c;
-
-       WARN_ON_ONCE(reserved);
-       if (test_bit(req->tag, &ci->pending))
-               return true;
-       ci->ncpl++;
-       c = req->end_io_data;
-       if (c)
-               complete(c);
-       return true;
-}
-
 /**
  * ufshcd_tmc_handler - handle task management function completion
  * @hba: per adapter instance
@@ -6420,18 +6387,24 @@ static bool ufshcd_compl_tm(struct request *req, void *priv, bool reserved)
  */
 static irqreturn_t ufshcd_tmc_handler(struct ufs_hba *hba)
 {
-       unsigned long flags;
-       struct request_queue *q = hba->tmf_queue;
-       struct ctm_info ci = {
-               .hba     = hba,
-       };
+       unsigned long flags, pending, issued;
+       irqreturn_t ret = IRQ_NONE;
+       int tag;
+
+       pending = ufshcd_readl(hba, REG_UTP_TASK_REQ_DOOR_BELL);
 
        spin_lock_irqsave(hba->host->host_lock, flags);
-       ci.pending = ufshcd_readl(hba, REG_UTP_TASK_REQ_DOOR_BELL);
-       blk_mq_tagset_busy_iter(q->tag_set, ufshcd_compl_tm, &ci);
+       issued = hba->outstanding_tasks & ~pending;
+       for_each_set_bit(tag, &issued, hba->nutmrs) {
+               struct request *req = hba->tmf_rqs[tag];
+               struct completion *c = req->end_io_data;
+
+               complete(c);
+               ret = IRQ_HANDLED;
+       }
        spin_unlock_irqrestore(hba->host->host_lock, flags);
 
-       return ci.ncpl ? IRQ_HANDLED : IRQ_NONE;
+       return ret;
 }
 
 /**
@@ -6554,9 +6527,9 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba,
        ufshcd_hold(hba, false);
 
        spin_lock_irqsave(host->host_lock, flags);
-       blk_mq_start_request(req);
 
        task_tag = req->tag;
+       hba->tmf_rqs[req->tag] = req;
        treq->upiu_req.req_header.dword_0 |= cpu_to_be32(task_tag);
 
        memcpy(hba->utmrdl_base_addr + task_tag, treq, sizeof(*treq));
@@ -6597,6 +6570,7 @@ static int __ufshcd_issue_tm_cmd(struct ufs_hba *hba,
        }
 
        spin_lock_irqsave(hba->host->host_lock, flags);
+       hba->tmf_rqs[req->tag] = NULL;
        __clear_bit(task_tag, &hba->outstanding_tasks);
        spin_unlock_irqrestore(hba->host->host_lock, flags);
 
@@ -6876,7 +6850,7 @@ static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd)
                        err = ufshcd_clear_cmd(hba, pos);
                        if (err)
                                break;
-                       __ufshcd_transfer_req_compl(hba, pos, /*retry_requests=*/true);
+                       __ufshcd_transfer_req_compl(hba, 1U << pos, false);
                }
        }
 
@@ -7048,17 +7022,15 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
         * will be to send LU reset which, again, is a spec violation.
         * To avoid these unnecessary/illegal steps, first we clean up
         * the lrb taken by this cmd and re-set it in outstanding_reqs,
-        * then queue the error handler and bail.
+        * then queue the eh_work and bail.
         */
        if (lrbp->lun == UFS_UPIU_UFS_DEVICE_WLUN) {
                ufshcd_update_evt_hist(hba, UFS_EVT_ABORT, lrbp->lun);
 
                spin_lock_irqsave(host->host_lock, flags);
                hba->force_reset = true;
+               ufshcd_schedule_eh_work(hba);
                spin_unlock_irqrestore(host->host_lock, flags);
-
-               ufshcd_schedule_eh(hba);
-
                goto release;
        }
 
@@ -7191,10 +7163,11 @@ static int ufshcd_eh_host_reset_handler(struct scsi_cmnd *cmd)
 
        spin_lock_irqsave(hba->host->host_lock, flags);
        hba->force_reset = true;
+       ufshcd_schedule_eh_work(hba);
        dev_err(hba->dev, "%s: reset in progress - 1\n", __func__);
        spin_unlock_irqrestore(hba->host->host_lock, flags);
 
-       ufshcd_err_handler(hba->host);
+       flush_work(&hba->eh_work);
 
        spin_lock_irqsave(hba->host->host_lock, flags);
        if (hba->ufshcd_state == UFSHCD_STATE_ERROR)
@@ -8604,6 +8577,8 @@ static void ufshcd_hba_exit(struct ufs_hba *hba)
        if (hba->is_powered) {
                ufshcd_exit_clk_scaling(hba);
                ufshcd_exit_clk_gating(hba);
+               if (hba->eh_wq)
+                       destroy_workqueue(hba->eh_wq);
                ufs_debugfs_hba_exit(hba);
                ufshcd_variant_hba_exit(hba);
                ufshcd_setup_vreg(hba, false);
@@ -9448,10 +9423,6 @@ static int ufshcd_set_dma_mask(struct ufs_hba *hba)
        return dma_set_mask_and_coherent(hba->dev, DMA_BIT_MASK(32));
 }
 
-static struct scsi_transport_template ufshcd_transport_template = {
-       .eh_strategy_handler = ufshcd_err_handler,
-};
-
 /**
  * ufshcd_alloc_host - allocate Host Bus Adapter (HBA)
  * @dev: pointer to device handle
@@ -9478,11 +9449,11 @@ int ufshcd_alloc_host(struct device *dev, struct ufs_hba **hba_handle)
                err = -ENOMEM;
                goto out_error;
        }
-       host->transportt = &ufshcd_transport_template;
        hba = shost_priv(host);
        hba->host = host;
        hba->dev = dev;
        hba->dev_ref_clk_freq = REF_CLK_FREQ_INVAL;
+       hba->nop_out_timeout = NOP_OUT_TIMEOUT;
        INIT_LIST_HEAD(&hba->clk_list_head);
        spin_lock_init(&hba->outstanding_lock);
 
@@ -9517,6 +9488,7 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
        int err;
        struct Scsi_Host *host = hba->host;
        struct device *dev = hba->dev;
+       char eh_wq_name[sizeof("ufs_eh_wq_00")];
 
        if (!mmio_base) {
                dev_err(hba->dev,
@@ -9570,6 +9542,17 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
 
        hba->max_pwr_info.is_valid = false;
 
+       /* Initialize work queues */
+       snprintf(eh_wq_name, sizeof(eh_wq_name), "ufs_eh_wq_%d",
+                hba->host->host_no);
+       hba->eh_wq = create_singlethread_workqueue(eh_wq_name);
+       if (!hba->eh_wq) {
+               dev_err(hba->dev, "%s: failed to create eh workqueue\n",
+                       __func__);
+               err = -ENOMEM;
+               goto out_disable;
+       }
+       INIT_WORK(&hba->eh_work, ufshcd_err_handler);
        INIT_WORK(&hba->eeh_work, ufshcd_exception_event_handler);
 
        sema_init(&hba->host_sem, 1);
@@ -9638,6 +9621,12 @@ int ufshcd_init(struct ufs_hba *hba, void __iomem *mmio_base, unsigned int irq)
                err = PTR_ERR(hba->tmf_queue);
                goto free_tmf_tag_set;
        }
+       hba->tmf_rqs = devm_kcalloc(hba->dev, hba->nutmrs,
+                                   sizeof(*hba->tmf_rqs), GFP_KERNEL);
+       if (!hba->tmf_rqs) {
+               err = -ENOMEM;
+               goto free_tmf_queue;
+       }
 
        /* Reset the attached device */
        ufshcd_device_reset(hba);
index 52ea6f3..41f6e06 100644 (file)
@@ -741,6 +741,8 @@ struct ufs_hba_monitor {
  * @is_powered: flag to check if HBA is powered
  * @shutting_down: flag to check if shutdown has been invoked
  * @host_sem: semaphore used to serialize concurrent contexts
+ * @eh_wq: Workqueue that eh_work works on
+ * @eh_work: Worker to handle UFS errors that require s/w attention
  * @eeh_work: Worker to handle exception events
  * @errors: HBA errors
  * @uic_error: UFS interconnect layer error status
@@ -826,6 +828,7 @@ struct ufs_hba {
 
        struct blk_mq_tag_set tmf_tag_set;
        struct request_queue *tmf_queue;
+       struct request **tmf_rqs;
 
        struct uic_command *active_uic_cmd;
        struct mutex uic_cmd_mutex;
@@ -843,6 +846,8 @@ struct ufs_hba {
        struct semaphore host_sem;
 
        /* Work Queues */
+       struct workqueue_struct *eh_wq;
+       struct work_struct eh_work;
        struct work_struct eeh_work;
 
        /* HBA Errors */
@@ -858,6 +863,7 @@ struct ufs_hba {
        /* Device management request data */
        struct ufs_dev_cmd dev_cmd;
        ktime_t last_dme_cmd_tstamp;
+       int nop_out_timeout;
 
        /* Keeps information of the UFS device connected to this host */
        struct ufs_dev_info dev_info;
index 02fb51a..589af5f 100644 (file)
@@ -333,9 +333,8 @@ ufshpb_get_pos_from_lpn(struct ufshpb_lu *hpb, unsigned long lpn, int *rgn_idx,
 }
 
 static void
-ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshpb_lu *hpb,
-                           struct ufshcd_lrb *lrbp, u32 lpn, __be64 ppn,
-                           u8 transfer_len, int read_id)
+ufshpb_set_hpb_read_to_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp,
+                           __be64 ppn, u8 transfer_len, int read_id)
 {
        unsigned char *cdb = lrbp->cmd->cmnd;
        __be64 ppn_tmp = ppn;
@@ -703,8 +702,7 @@ int ufshpb_prep(struct ufs_hba *hba, struct ufshcd_lrb *lrbp)
                }
        }
 
-       ufshpb_set_hpb_read_to_upiu(hba, hpb, lrbp, lpn, ppn, transfer_len,
-                                   read_id);
+       ufshpb_set_hpb_read_to_upiu(hba, lrbp, ppn, transfer_len, read_id);
 
        hpb->stats.hit_cnt++;
        return 0;
index c25ce8f..07d0250 100644 (file)
@@ -300,7 +300,7 @@ static void virtscsi_handle_transport_reset(struct virtio_scsi *vscsi,
                }
                break;
        default:
-               pr_info("Unsupport virtio scsi event reason %x\n", event->reason);
+               pr_info("Unsupported virtio scsi event reason %x\n", event->reason);
        }
 }
 
@@ -392,7 +392,7 @@ static void virtscsi_handle_event(struct work_struct *work)
                virtscsi_handle_param_change(vscsi, event);
                break;
        default:
-               pr_err("Unsupport virtio scsi event %x\n", event->event);
+               pr_err("Unsupported virtio scsi event %x\n", event->event);
        }
        virtscsi_kick_event(vscsi, event_node);
 }
index 8179b69..853096b 100644 (file)
@@ -5,7 +5,6 @@ config SOC_K210_SYSCTL
        depends on RISCV && SOC_CANAAN && OF
        default SOC_CANAAN
         select PM
-        select SIMPLE_PM_BUS
         select SYSCON
         select MFD_SYSCON
        help
index 79b568f..bfa2ab5 100644 (file)
@@ -199,7 +199,7 @@ config QCOM_WCNSS_CTRL
          firmware to a newly booted WCNSS chip.
 
 config QCOM_APR
-       tristate "Qualcomm APR Bus (Asynchronous Packet Router)"
+       tristate "Qualcomm APR/GPR Bus (Asynchronous/Generic Packet Router)"
        depends on ARCH_QCOM || COMPILE_TEST
        depends on RPMSG
        depends on NET
index 475a57b..8a9bfbc 100644 (file)
 #include <linux/rpmsg.h>
 #include <linux/of.h>
 
-struct apr {
+enum {
+       PR_TYPE_APR = 0,
+       PR_TYPE_GPR,
+};
+
+/* Some random values tbh which does not collide with static modules */
+#define GPR_DYNAMIC_PORT_START 0x10000000
+#define GPR_DYNAMIC_PORT_END   0x20000000
+
+struct packet_router {
        struct rpmsg_endpoint *ch;
        struct device *dev;
        spinlock_t svcs_lock;
        spinlock_t rx_lock;
        struct idr svcs_idr;
        int dest_domain_id;
+       int type;
        struct pdr_handle *pdr;
        struct workqueue_struct *rxwq;
        struct work_struct rx_work;
@@ -44,26 +54,103 @@ struct apr_rx_buf {
  */
 int apr_send_pkt(struct apr_device *adev, struct apr_pkt *pkt)
 {
-       struct apr *apr = dev_get_drvdata(adev->dev.parent);
+       struct packet_router *apr = dev_get_drvdata(adev->dev.parent);
        struct apr_hdr *hdr;
        unsigned long flags;
        int ret;
 
-       spin_lock_irqsave(&adev->lock, flags);
+       spin_lock_irqsave(&adev->svc.lock, flags);
 
        hdr = &pkt->hdr;
        hdr->src_domain = APR_DOMAIN_APPS;
-       hdr->src_svc = adev->svc_id;
+       hdr->src_svc = adev->svc.id;
        hdr->dest_domain = adev->domain_id;
-       hdr->dest_svc = adev->svc_id;
+       hdr->dest_svc = adev->svc.id;
 
        ret = rpmsg_trysend(apr->ch, pkt, hdr->pkt_size);
-       spin_unlock_irqrestore(&adev->lock, flags);
+       spin_unlock_irqrestore(&adev->svc.lock, flags);
 
        return ret ? ret : hdr->pkt_size;
 }
 EXPORT_SYMBOL_GPL(apr_send_pkt);
 
+void gpr_free_port(gpr_port_t *port)
+{
+       struct packet_router *gpr = port->pr;
+       unsigned long flags;
+
+       spin_lock_irqsave(&gpr->svcs_lock, flags);
+       idr_remove(&gpr->svcs_idr, port->id);
+       spin_unlock_irqrestore(&gpr->svcs_lock, flags);
+
+       kfree(port);
+}
+EXPORT_SYMBOL_GPL(gpr_free_port);
+
+gpr_port_t *gpr_alloc_port(struct apr_device *gdev, struct device *dev,
+                               gpr_port_cb cb, void *priv)
+{
+       struct packet_router *pr = dev_get_drvdata(gdev->dev.parent);
+       gpr_port_t *port;
+       struct pkt_router_svc *svc;
+       int id;
+
+       port = kzalloc(sizeof(*port), GFP_KERNEL);
+       if (!port)
+               return ERR_PTR(-ENOMEM);
+
+       svc = port;
+       svc->callback = cb;
+       svc->pr = pr;
+       svc->priv = priv;
+       svc->dev = dev;
+       spin_lock_init(&svc->lock);
+
+       spin_lock(&pr->svcs_lock);
+       id = idr_alloc_cyclic(&pr->svcs_idr, svc, GPR_DYNAMIC_PORT_START,
+                             GPR_DYNAMIC_PORT_END, GFP_ATOMIC);
+       if (id < 0) {
+               dev_err(dev, "Unable to allocate dynamic GPR src port\n");
+               kfree(port);
+               spin_unlock(&pr->svcs_lock);
+               return ERR_PTR(id);
+       }
+
+       svc->id = id;
+       spin_unlock(&pr->svcs_lock);
+
+       return port;
+}
+EXPORT_SYMBOL_GPL(gpr_alloc_port);
+
+static int pkt_router_send_svc_pkt(struct pkt_router_svc *svc, struct gpr_pkt *pkt)
+{
+       struct packet_router *pr = svc->pr;
+       struct gpr_hdr *hdr;
+       unsigned long flags;
+       int ret;
+
+       hdr = &pkt->hdr;
+
+       spin_lock_irqsave(&svc->lock, flags);
+       ret = rpmsg_trysend(pr->ch, pkt, hdr->pkt_size);
+       spin_unlock_irqrestore(&svc->lock, flags);
+
+       return ret ? ret : hdr->pkt_size;
+}
+
+int gpr_send_pkt(struct apr_device *gdev, struct gpr_pkt *pkt)
+{
+       return pkt_router_send_svc_pkt(&gdev->svc, pkt);
+}
+EXPORT_SYMBOL_GPL(gpr_send_pkt);
+
+int gpr_send_port_pkt(gpr_port_t *port, struct gpr_pkt *pkt)
+{
+       return pkt_router_send_svc_pkt(port, pkt);
+}
+EXPORT_SYMBOL_GPL(gpr_send_port_pkt);
+
 static void apr_dev_release(struct device *dev)
 {
        struct apr_device *adev = to_apr_device(dev);
@@ -74,7 +161,7 @@ static void apr_dev_release(struct device *dev)
 static int apr_callback(struct rpmsg_device *rpdev, void *buf,
                                  int len, void *priv, u32 addr)
 {
-       struct apr *apr = dev_get_drvdata(&rpdev->dev);
+       struct packet_router *apr = dev_get_drvdata(&rpdev->dev);
        struct apr_rx_buf *abuf;
        unsigned long flags;
 
@@ -100,11 +187,11 @@ static int apr_callback(struct rpmsg_device *rpdev, void *buf,
        return 0;
 }
 
-
-static int apr_do_rx_callback(struct apr *apr, struct apr_rx_buf *abuf)
+static int apr_do_rx_callback(struct packet_router *apr, struct apr_rx_buf *abuf)
 {
        uint16_t hdr_size, msg_type, ver, svc_id;
-       struct apr_device *svc = NULL;
+       struct pkt_router_svc *svc;
+       struct apr_device *adev;
        struct apr_driver *adrv = NULL;
        struct apr_resp_pkt resp;
        struct apr_hdr *hdr;
@@ -145,12 +232,15 @@ static int apr_do_rx_callback(struct apr *apr, struct apr_rx_buf *abuf)
        svc_id = hdr->dest_svc;
        spin_lock_irqsave(&apr->svcs_lock, flags);
        svc = idr_find(&apr->svcs_idr, svc_id);
-       if (svc && svc->dev.driver)
-               adrv = to_apr_driver(svc->dev.driver);
+       if (svc && svc->dev->driver) {
+               adev = svc_to_apr_device(svc);
+               adrv = to_apr_driver(adev->dev.driver);
+       }
        spin_unlock_irqrestore(&apr->svcs_lock, flags);
 
-       if (!adrv) {
-               dev_err(apr->dev, "APR: service is not registered\n");
+       if (!adrv || !adev) {
+               dev_err(apr->dev, "APR: service is not registered (%d)\n",
+                       svc_id);
                return -EINVAL;
        }
 
@@ -164,20 +254,82 @@ static int apr_do_rx_callback(struct apr *apr, struct apr_rx_buf *abuf)
        if (resp.payload_size > 0)
                resp.payload = buf + hdr_size;
 
-       adrv->callback(svc, &resp);
+       adrv->callback(adev, &resp);
+
+       return 0;
+}
+
+static int gpr_do_rx_callback(struct packet_router *gpr, struct apr_rx_buf *abuf)
+{
+       uint16_t hdr_size, ver;
+       struct pkt_router_svc *svc = NULL;
+       struct gpr_resp_pkt resp;
+       struct gpr_hdr *hdr;
+       unsigned long flags;
+       void *buf = abuf->buf;
+       int len = abuf->len;
+
+       hdr = buf;
+       ver = hdr->version;
+       if (ver > GPR_PKT_VER + 1)
+               return -EINVAL;
+
+       hdr_size = hdr->hdr_size;
+       if (hdr_size < GPR_PKT_HEADER_WORD_SIZE) {
+               dev_err(gpr->dev, "GPR: Wrong hdr size:%d\n", hdr_size);
+               return -EINVAL;
+       }
+
+       if (hdr->pkt_size < GPR_PKT_HEADER_BYTE_SIZE || hdr->pkt_size != len) {
+               dev_err(gpr->dev, "GPR: Wrong packet size\n");
+               return -EINVAL;
+       }
+
+       resp.hdr = *hdr;
+       resp.payload_size = hdr->pkt_size - (hdr_size * 4);
+
+       /*
+        * NOTE: hdr_size is not same as GPR_HDR_SIZE as remote can include
+        * optional headers in to gpr_hdr which should be ignored
+        */
+       if (resp.payload_size > 0)
+               resp.payload = buf + (hdr_size *  4);
+
+
+       spin_lock_irqsave(&gpr->svcs_lock, flags);
+       svc = idr_find(&gpr->svcs_idr, hdr->dest_port);
+       spin_unlock_irqrestore(&gpr->svcs_lock, flags);
+
+       if (!svc) {
+               dev_err(gpr->dev, "GPR: Port(%x) is not registered\n",
+                       hdr->dest_port);
+               return -EINVAL;
+       }
+
+       if (svc->callback)
+               svc->callback(&resp, svc->priv, 0);
 
        return 0;
 }
 
 static void apr_rxwq(struct work_struct *work)
 {
-       struct apr *apr = container_of(work, struct apr, rx_work);
+       struct packet_router *apr = container_of(work, struct packet_router, rx_work);
        struct apr_rx_buf *abuf, *b;
        unsigned long flags;
 
        if (!list_empty(&apr->rx_list)) {
                list_for_each_entry_safe(abuf, b, &apr->rx_list, node) {
-                       apr_do_rx_callback(apr, abuf);
+                       switch (apr->type) {
+                       case PR_TYPE_APR:
+                               apr_do_rx_callback(apr, abuf);
+                               break;
+                       case PR_TYPE_GPR:
+                               gpr_do_rx_callback(apr, abuf);
+                               break;
+                       default:
+                               break;
+                       }
                        spin_lock_irqsave(&apr->rx_lock, flags);
                        list_del(&abuf->node);
                        spin_unlock_irqrestore(&apr->rx_lock, flags);
@@ -201,7 +353,7 @@ static int apr_device_match(struct device *dev, struct device_driver *drv)
 
        while (id->domain_id != 0 || id->svc_id != 0) {
                if (id->domain_id == adev->domain_id &&
-                   id->svc_id == adev->svc_id)
+                   id->svc_id == adev->svc.id)
                        return 1;
                id++;
        }
@@ -213,22 +365,27 @@ static int apr_device_probe(struct device *dev)
 {
        struct apr_device *adev = to_apr_device(dev);
        struct apr_driver *adrv = to_apr_driver(dev->driver);
+       int ret;
 
-       return adrv->probe(adev);
+       ret = adrv->probe(adev);
+       if (!ret)
+               adev->svc.callback = adrv->gpr_callback;
+
+       return ret;
 }
 
 static void apr_device_remove(struct device *dev)
 {
        struct apr_device *adev = to_apr_device(dev);
        struct apr_driver *adrv;
-       struct apr *apr = dev_get_drvdata(adev->dev.parent);
+       struct packet_router *apr = dev_get_drvdata(adev->dev.parent);
 
        if (dev->driver) {
                adrv = to_apr_driver(dev->driver);
                if (adrv->remove)
                        adrv->remove(adev);
                spin_lock(&apr->svcs_lock);
-               idr_remove(&apr->svcs_idr, adev->svc_id);
+               idr_remove(&apr->svcs_idr, adev->svc.id);
                spin_unlock(&apr->svcs_lock);
        }
 }
@@ -255,28 +412,43 @@ struct bus_type aprbus = {
 EXPORT_SYMBOL_GPL(aprbus);
 
 static int apr_add_device(struct device *dev, struct device_node *np,
-                         const struct apr_device_id *id)
+                         u32 svc_id, u32 domain_id)
 {
-       struct apr *apr = dev_get_drvdata(dev);
+       struct packet_router *apr = dev_get_drvdata(dev);
        struct apr_device *adev = NULL;
+       struct pkt_router_svc *svc;
        int ret;
 
        adev = kzalloc(sizeof(*adev), GFP_KERNEL);
        if (!adev)
                return -ENOMEM;
 
-       spin_lock_init(&adev->lock);
+       adev->svc_id = svc_id;
+       svc = &adev->svc;
+
+       svc->id = svc_id;
+       svc->pr = apr;
+       svc->priv = adev;
+       svc->dev = dev;
+       spin_lock_init(&svc->lock);
+
+       adev->domain_id = domain_id;
 
-       adev->svc_id = id->svc_id;
-       adev->domain_id = id->domain_id;
-       adev->version = id->svc_version;
        if (np)
                snprintf(adev->name, APR_NAME_SIZE, "%pOFn", np);
-       else
-               strscpy(adev->name, id->name, APR_NAME_SIZE);
 
-       dev_set_name(&adev->dev, "aprsvc:%s:%x:%x", adev->name,
-                    id->domain_id, id->svc_id);
+       switch (apr->type) {
+       case PR_TYPE_APR:
+               dev_set_name(&adev->dev, "aprsvc:%s:%x:%x", adev->name,
+                            domain_id, svc_id);
+               break;
+       case PR_TYPE_GPR:
+               dev_set_name(&adev->dev, "gprsvc:%s:%x:%x", adev->name,
+                            domain_id, svc_id);
+               break;
+       default:
+               break;
+       }
 
        adev->dev.bus = &aprbus;
        adev->dev.parent = dev;
@@ -285,14 +457,13 @@ static int apr_add_device(struct device *dev, struct device_node *np,
        adev->dev.driver = NULL;
 
        spin_lock(&apr->svcs_lock);
-       idr_alloc(&apr->svcs_idr, adev, id->svc_id,
-                 id->svc_id + 1, GFP_ATOMIC);
+       idr_alloc(&apr->svcs_idr, svc, svc_id, svc_id + 1, GFP_ATOMIC);
        spin_unlock(&apr->svcs_lock);
 
        of_property_read_string_index(np, "qcom,protection-domain",
                                      1, &adev->service_path);
 
-       dev_info(dev, "Adding APR dev: %s\n", dev_name(&adev->dev));
+       dev_info(dev, "Adding APR/GPR dev: %s\n", dev_name(&adev->dev));
 
        ret = device_register(&adev->dev);
        if (ret) {
@@ -306,7 +477,7 @@ static int apr_add_device(struct device *dev, struct device_node *np,
 static int of_apr_add_pd_lookups(struct device *dev)
 {
        const char *service_name, *service_path;
-       struct apr *apr = dev_get_drvdata(dev);
+       struct packet_router *apr = dev_get_drvdata(dev);
        struct device_node *node;
        struct pdr_service *pds;
        int ret;
@@ -336,13 +507,14 @@ static int of_apr_add_pd_lookups(struct device *dev)
 
 static void of_register_apr_devices(struct device *dev, const char *svc_path)
 {
-       struct apr *apr = dev_get_drvdata(dev);
+       struct packet_router *apr = dev_get_drvdata(dev);
        struct device_node *node;
        const char *service_path;
        int ret;
 
        for_each_child_of_node(dev->of_node, node) {
-               struct apr_device_id id = { {0} };
+               u32 svc_id;
+               u32 domain_id;
 
                /*
                 * This function is called with svc_path NULL during
@@ -372,13 +544,13 @@ static void of_register_apr_devices(struct device *dev, const char *svc_path)
                                continue;
                }
 
-               if (of_property_read_u32(node, "reg", &id.svc_id))
+               if (of_property_read_u32(node, "reg", &svc_id))
                        continue;
 
-               id.domain_id = apr->dest_domain_id;
+               domain_id = apr->dest_domain_id;
 
-               if (apr_add_device(dev, node, &id))
-                       dev_err(dev, "Failed to add apr %d svc\n", id.svc_id);
+               if (apr_add_device(dev, node, svc_id, domain_id))
+                       dev_err(dev, "Failed to add apr %d svc\n", svc_id);
        }
 }
 
@@ -398,7 +570,7 @@ static int apr_remove_device(struct device *dev, void *svc_path)
 
 static void apr_pd_status(int state, char *svc_path, void *priv)
 {
-       struct apr *apr = (struct apr *)priv;
+       struct packet_router *apr = (struct packet_router *)priv;
 
        switch (state) {
        case SERVREG_SERVICE_STATE_UP:
@@ -413,16 +585,26 @@ static void apr_pd_status(int state, char *svc_path, void *priv)
 static int apr_probe(struct rpmsg_device *rpdev)
 {
        struct device *dev = &rpdev->dev;
-       struct apr *apr;
+       struct packet_router *apr;
        int ret;
 
        apr = devm_kzalloc(dev, sizeof(*apr), GFP_KERNEL);
        if (!apr)
                return -ENOMEM;
 
-       ret = of_property_read_u32(dev->of_node, "qcom,apr-domain", &apr->dest_domain_id);
+       ret = of_property_read_u32(dev->of_node, "qcom,domain", &apr->dest_domain_id);
+
+       if (of_device_is_compatible(dev->of_node, "qcom,gpr")) {
+               apr->type = PR_TYPE_GPR;
+       } else {
+               if (ret) /* try deprecated apr-domain property */
+                       ret = of_property_read_u32(dev->of_node, "qcom,apr-domain",
+                                                  &apr->dest_domain_id);
+               apr->type = PR_TYPE_APR;
+       }
+
        if (ret) {
-               dev_err(dev, "APR Domain ID not specified in DT\n");
+               dev_err(dev, "Domain ID not specified in DT\n");
                return ret;
        }
 
@@ -465,7 +647,7 @@ destroy_wq:
 
 static void apr_remove(struct rpmsg_device *rpdev)
 {
-       struct apr *apr = dev_get_drvdata(&rpdev->dev);
+       struct packet_router *apr = dev_get_drvdata(&rpdev->dev);
 
        pdr_handle_release(apr->pdr);
        device_for_each_child(&rpdev->dev, NULL, apr_remove_device);
@@ -502,20 +684,21 @@ void apr_driver_unregister(struct apr_driver *drv)
 }
 EXPORT_SYMBOL_GPL(apr_driver_unregister);
 
-static const struct of_device_id apr_of_match[] = {
+static const struct of_device_id pkt_router_of_match[] = {
        { .compatible = "qcom,apr"},
        { .compatible = "qcom,apr-v2"},
+       { .compatible = "qcom,gpr"},
        {}
 };
-MODULE_DEVICE_TABLE(of, apr_of_match);
+MODULE_DEVICE_TABLE(of, pkt_router_of_match);
 
-static struct rpmsg_driver apr_driver = {
+static struct rpmsg_driver packet_router_driver = {
        .probe = apr_probe,
        .remove = apr_remove,
        .callback = apr_callback,
        .drv = {
                .name = "qcom,apr",
-               .of_match_table = apr_of_match,
+               .of_match_table = pkt_router_of_match,
        },
 };
 
@@ -525,7 +708,7 @@ static int __init apr_init(void)
 
        ret = bus_register(&aprbus);
        if (!ret)
-               ret = register_rpmsg_driver(&apr_driver);
+               ret = register_rpmsg_driver(&packet_router_driver);
        else
                bus_unregister(&aprbus);
 
@@ -535,7 +718,7 @@ static int __init apr_init(void)
 static void __exit apr_exit(void)
 {
        bus_unregister(&aprbus);
-       unregister_rpmsg_driver(&apr_driver);
+       unregister_rpmsg_driver(&packet_router_driver);
 }
 
 subsys_initcall(apr_init);
index bda170d..72fc2b5 100644 (file)
@@ -98,7 +98,7 @@ void *qcom_mdt_read_metadata(const struct firmware *fw, size_t *data_len)
        if (ehdr->e_phnum < 2)
                return ERR_PTR(-EINVAL);
 
-       if (phdrs[0].p_type == PT_LOAD || phdrs[1].p_type == PT_LOAD)
+       if (phdrs[0].p_type == PT_LOAD)
                return ERR_PTR(-EINVAL);
 
        if ((phdrs[1].p_flags & QCOM_MDT_TYPE_MASK) != QCOM_MDT_TYPE_HASH)
index 9faf483..52e5811 100644 (file)
@@ -628,7 +628,7 @@ static int qcom_socinfo_probe(struct platform_device *pdev)
        /* Feed the soc specific unique data into entropy pool */
        add_device_randomness(info, item_size);
 
-       platform_set_drvdata(pdev, qs->soc_dev);
+       platform_set_drvdata(pdev, qs);
 
        return 0;
 }
index ea64e18..f32e1cb 100644 (file)
@@ -825,25 +825,28 @@ static int omap_reset_deassert(struct reset_controller_dev *rcdev,
        writel_relaxed(v, reset->prm->base + reset->prm->data->rstctrl);
        spin_unlock_irqrestore(&reset->lock, flags);
 
-       if (!has_rstst)
-               goto exit;
+       /* wait for the reset bit to clear */
+       ret = readl_relaxed_poll_timeout_atomic(reset->prm->base +
+                                               reset->prm->data->rstctrl,
+                                               v, !(v & BIT(id)), 1,
+                                               OMAP_RESET_MAX_WAIT);
+       if (ret)
+               pr_err("%s: timedout waiting for %s:%lu\n", __func__,
+                      reset->prm->data->name, id);
 
        /* wait for the status to be set */
-       ret = readl_relaxed_poll_timeout_atomic(reset->prm->base +
+       if (has_rstst) {
+               ret = readl_relaxed_poll_timeout_atomic(reset->prm->base +
                                                 reset->prm->data->rstst,
                                                 v, v & BIT(st_bit), 1,
                                                 OMAP_RESET_MAX_WAIT);
-       if (ret)
-               pr_err("%s: timedout waiting for %s:%lu\n", __func__,
-                      reset->prm->data->name, id);
+               if (ret)
+                       pr_err("%s: timedout waiting for %s:%lu\n", __func__,
+                              reset->prm->data->name, id);
+       }
 
-exit:
-       if (reset->clkdm) {
-               /* At least dra7 iva needs a delay before clkdm idle */
-               if (has_rstst)
-                       udelay(1);
+       if (reset->clkdm)
                pdata->clkdm_allow_idle(reset->clkdm);
-       }
 
        return ret;
 }
index 788dcdf..f872cf1 100644 (file)
@@ -1301,7 +1301,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
         * DMA map early, for performance (empties dcache ASAP) and
         * better fault reporting.
         */
-       if ((!master->cur_msg_mapped)
+       if ((!master->cur_msg->is_dma_mapped)
                && as->use_pdc) {
                if (atmel_spi_dma_map_xfer(as, xfer) < 0)
                        return -ENOMEM;
@@ -1381,7 +1381,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
                }
        }
 
-       if (!master->cur_msg_mapped
+       if (!master->cur_msg->is_dma_mapped
                && as->use_pdc)
                atmel_spi_dma_unmap_xfer(master, xfer);
 
index a78e56f..3043677 100644 (file)
@@ -1250,10 +1250,14 @@ static void bcm_qspi_hw_init(struct bcm_qspi *qspi)
 
 static void bcm_qspi_hw_uninit(struct bcm_qspi *qspi)
 {
+       u32 status = bcm_qspi_read(qspi, MSPI, MSPI_MSPI_STATUS);
+
        bcm_qspi_write(qspi, MSPI, MSPI_SPCR2, 0);
        if (has_bspi(qspi))
                bcm_qspi_write(qspi, MSPI, MSPI_WRITE_LOCK, 0);
 
+       /* clear interrupt */
+       bcm_qspi_write(qspi, MSPI, MSPI_MSPI_STATUS, status & ~1);
 }
 
 static const struct spi_controller_mem_ops bcm_qspi_mem_ops = {
@@ -1397,6 +1401,47 @@ int bcm_qspi_probe(struct platform_device *pdev,
        if (!qspi->dev_ids)
                return -ENOMEM;
 
+       /*
+        * Some SoCs integrate spi controller (e.g., its interrupt bits)
+        * in specific ways
+        */
+       if (soc_intc) {
+               qspi->soc_intc = soc_intc;
+               soc_intc->bcm_qspi_int_set(soc_intc, MSPI_DONE, true);
+       } else {
+               qspi->soc_intc = NULL;
+       }
+
+       if (qspi->clk) {
+               ret = clk_prepare_enable(qspi->clk);
+               if (ret) {
+                       dev_err(dev, "failed to prepare clock\n");
+                       goto qspi_probe_err;
+               }
+               qspi->base_clk = clk_get_rate(qspi->clk);
+       } else {
+               qspi->base_clk = MSPI_BASE_FREQ;
+       }
+
+       if (data->has_mspi_rev) {
+               rev = bcm_qspi_read(qspi, MSPI, MSPI_REV);
+               /* some older revs do not have a MSPI_REV register */
+               if ((rev & 0xff) == 0xff)
+                       rev = 0;
+       }
+
+       qspi->mspi_maj_rev = (rev >> 4) & 0xf;
+       qspi->mspi_min_rev = rev & 0xf;
+       qspi->mspi_spcr3_sysclk = data->has_spcr3_sysclk;
+
+       qspi->max_speed_hz = qspi->base_clk / (bcm_qspi_spbr_min(qspi) * 2);
+
+       /*
+        * On SW resets it is possible to have the mask still enabled
+        * Need to disable the mask and clear the status while we init
+        */
+       bcm_qspi_hw_uninit(qspi);
+
        for (val = 0; val < num_irqs; val++) {
                irq = -1;
                name = qspi_irq_tab[val].irq_name;
@@ -1433,38 +1478,6 @@ int bcm_qspi_probe(struct platform_device *pdev,
                goto qspi_probe_err;
        }
 
-       /*
-        * Some SoCs integrate spi controller (e.g., its interrupt bits)
-        * in specific ways
-        */
-       if (soc_intc) {
-               qspi->soc_intc = soc_intc;
-               soc_intc->bcm_qspi_int_set(soc_intc, MSPI_DONE, true);
-       } else {
-               qspi->soc_intc = NULL;
-       }
-
-       ret = clk_prepare_enable(qspi->clk);
-       if (ret) {
-               dev_err(dev, "failed to prepare clock\n");
-               goto qspi_probe_err;
-       }
-
-       qspi->base_clk = clk_get_rate(qspi->clk);
-
-       if (data->has_mspi_rev) {
-               rev = bcm_qspi_read(qspi, MSPI, MSPI_REV);
-               /* some older revs do not have a MSPI_REV register */
-               if ((rev & 0xff) == 0xff)
-                       rev = 0;
-       }
-
-       qspi->mspi_maj_rev = (rev >> 4) & 0xf;
-       qspi->mspi_min_rev = rev & 0xf;
-       qspi->mspi_spcr3_sysclk = data->has_spcr3_sysclk;
-
-       qspi->max_speed_hz = qspi->base_clk / (bcm_qspi_spbr_min(qspi) * 2);
-
        bcm_qspi_hw_init(qspi);
        init_completion(&qspi->mspi_done);
        init_completion(&qspi->bspi_done);
index 386e8c8..a15de10 100644 (file)
@@ -233,36 +233,44 @@ static int mtk_spi_set_hw_cs_timing(struct spi_device *spi)
                return delay;
        inactive = (delay * DIV_ROUND_UP(mdata->spi_clk_hz, 1000000)) / 1000;
 
-       setup    = setup ? setup : 1;
-       hold     = hold ? hold : 1;
-       inactive = inactive ? inactive : 1;
-
-       reg_val = readl(mdata->base + SPI_CFG0_REG);
-       if (mdata->dev_comp->enhance_timing) {
-               hold = min_t(u32, hold, 0x10000);
-               setup = min_t(u32, setup, 0x10000);
-               reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_HOLD_OFFSET);
-               reg_val |= (((hold - 1) & 0xffff)
-                          << SPI_ADJUST_CFG0_CS_HOLD_OFFSET);
-               reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_SETUP_OFFSET);
-               reg_val |= (((setup - 1) & 0xffff)
-                          << SPI_ADJUST_CFG0_CS_SETUP_OFFSET);
-       } else {
-               hold = min_t(u32, hold, 0x100);
-               setup = min_t(u32, setup, 0x100);
-               reg_val &= ~(0xff << SPI_CFG0_CS_HOLD_OFFSET);
-               reg_val |= (((hold - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET);
-               reg_val &= ~(0xff << SPI_CFG0_CS_SETUP_OFFSET);
-               reg_val |= (((setup - 1) & 0xff)
-                           << SPI_CFG0_CS_SETUP_OFFSET);
+       if (hold || setup) {
+               reg_val = readl(mdata->base + SPI_CFG0_REG);
+               if (mdata->dev_comp->enhance_timing) {
+                       if (hold) {
+                               hold = min_t(u32, hold, 0x10000);
+                               reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_HOLD_OFFSET);
+                               reg_val |= (((hold - 1) & 0xffff)
+                                       << SPI_ADJUST_CFG0_CS_HOLD_OFFSET);
+                       }
+                       if (setup) {
+                               setup = min_t(u32, setup, 0x10000);
+                               reg_val &= ~(0xffff << SPI_ADJUST_CFG0_CS_SETUP_OFFSET);
+                               reg_val |= (((setup - 1) & 0xffff)
+                                       << SPI_ADJUST_CFG0_CS_SETUP_OFFSET);
+                       }
+               } else {
+                       if (hold) {
+                               hold = min_t(u32, hold, 0x100);
+                               reg_val &= ~(0xff << SPI_CFG0_CS_HOLD_OFFSET);
+                               reg_val |= (((hold - 1) & 0xff) << SPI_CFG0_CS_HOLD_OFFSET);
+                       }
+                       if (setup) {
+                               setup = min_t(u32, setup, 0x100);
+                               reg_val &= ~(0xff << SPI_CFG0_CS_SETUP_OFFSET);
+                               reg_val |= (((setup - 1) & 0xff)
+                                       << SPI_CFG0_CS_SETUP_OFFSET);
+                       }
+               }
+               writel(reg_val, mdata->base + SPI_CFG0_REG);
        }
-       writel(reg_val, mdata->base + SPI_CFG0_REG);
 
-       inactive = min_t(u32, inactive, 0x100);
-       reg_val = readl(mdata->base + SPI_CFG1_REG);
-       reg_val &= ~SPI_CFG1_CS_IDLE_MASK;
-       reg_val |= (((inactive - 1) & 0xff) << SPI_CFG1_CS_IDLE_OFFSET);
-       writel(reg_val, mdata->base + SPI_CFG1_REG);
+       if (inactive) {
+               inactive = min_t(u32, inactive, 0x100);
+               reg_val = readl(mdata->base + SPI_CFG1_REG);
+               reg_val &= ~SPI_CFG1_CS_IDLE_MASK;
+               reg_val |= (((inactive - 1) & 0xff) << SPI_CFG1_CS_IDLE_OFFSET);
+               writel(reg_val, mdata->base + SPI_CFG1_REG);
+       }
 
        return 0;
 }
index 9708b78..f5d32ec 100644 (file)
@@ -137,6 +137,13 @@ static int spi_mux_probe(struct spi_device *spi)
        priv = spi_controller_get_devdata(ctlr);
        priv->spi = spi;
 
+       /*
+        * Increase lockdep class as these lock are taken while the parent bus
+        * already holds their instance's lock.
+        */
+       lockdep_set_subclass(&ctlr->io_mutex, 1);
+       lockdep_set_subclass(&ctlr->add_lock, 1);
+
        priv->mux = devm_mux_control_get(&spi->dev, NULL);
        if (IS_ERR(priv->mux)) {
                ret = dev_err_probe(&spi->dev, PTR_ERR(priv->mux),
index a66fa97..2b0301f 100644 (file)
@@ -33,6 +33,7 @@
 
 #include <linux/acpi.h>
 #include <linux/bitops.h>
+#include <linux/bitfield.h>
 #include <linux/clk.h>
 #include <linux/completion.h>
 #include <linux/delay.h>
 #define NXP_FSPI_MIN_IOMAP     SZ_4M
 
 #define DCFG_RCWSR1            0x100
+#define SYS_PLL_RAT            GENMASK(6, 2)
 
 /* Access flash memory using IP bus only */
 #define FSPI_QUIRK_USE_IP_ONLY BIT(0)
@@ -926,9 +928,8 @@ static void erratum_err050568(struct nxp_fspi *f)
                { .family = "QorIQ LS1028A" },
                { /* sentinel */ }
        };
-       struct device_node *np;
        struct regmap *map;
-       u32 val = 0, sysclk = 0;
+       u32 val, sys_pll_ratio;
        int ret;
 
        /* Check for LS1028A family */
@@ -937,7 +938,6 @@ static void erratum_err050568(struct nxp_fspi *f)
                return;
        }
 
-       /* Compute system clock frequency multiplier ratio */
        map = syscon_regmap_lookup_by_compatible("fsl,ls1028a-dcfg");
        if (IS_ERR(map)) {
                dev_err(f->dev, "No syscon regmap\n");
@@ -948,23 +948,11 @@ static void erratum_err050568(struct nxp_fspi *f)
        if (ret < 0)
                goto err;
 
-       /* Strap bits 6:2 define SYS_PLL_RAT i.e frequency multiplier ratio */
-       val = (val >> 2) & 0x1F;
-       WARN(val == 0, "Strapping is zero: Cannot determine ratio");
+       sys_pll_ratio = FIELD_GET(SYS_PLL_RAT, val);
+       dev_dbg(f->dev, "val: 0x%08x, sys_pll_ratio: %d\n", val, sys_pll_ratio);
 
-       /* Compute system clock frequency */
-       np = of_find_node_by_name(NULL, "clock-sysclk");
-       if (!np)
-               goto err;
-
-       if (of_property_read_u32(np, "clock-frequency", &sysclk))
-               goto err;
-
-       sysclk = (sysclk * val) / 1000000; /* Convert sysclk to Mhz */
-       dev_dbg(f->dev, "val: 0x%08x, sysclk: %dMhz\n", val, sysclk);
-
-       /* Use IP bus only if PLL is 300MHz */
-       if (sysclk == 300)
+       /* Use IP bus only if platform clock is 300MHz */
+       if (sys_pll_ratio == 3)
                f->devtype_data->quirks |= FSPI_QUIRK_USE_IP_ONLY;
 
        return;
index 540861c..553b6b9 100644 (file)
@@ -600,6 +600,12 @@ static int rockchip_spi_transfer_one(
        int ret;
        bool use_dma;
 
+       /* Zero length transfers won't trigger an interrupt on completion */
+       if (!xfer->len) {
+               spi_finalize_current_transfer(ctlr);
+               return 1;
+       }
+
        WARN_ON(readl_relaxed(rs->regs + ROCKCHIP_SPI_SSIENR) &&
                (readl_relaxed(rs->regs + ROCKCHIP_SPI_SR) & SR_BUSY));
 
index ebd27f8..713292b 100644 (file)
@@ -204,9 +204,6 @@ struct tegra_slink_data {
        struct dma_async_tx_descriptor          *tx_dma_desc;
 };
 
-static int tegra_slink_runtime_suspend(struct device *dev);
-static int tegra_slink_runtime_resume(struct device *dev);
-
 static inline u32 tegra_slink_readl(struct tegra_slink_data *tspi,
                unsigned long reg)
 {
@@ -1185,7 +1182,7 @@ static int tegra_slink_resume(struct device *dev)
 }
 #endif
 
-static int tegra_slink_runtime_suspend(struct device *dev)
+static int __maybe_unused tegra_slink_runtime_suspend(struct device *dev)
 {
        struct spi_master *master = dev_get_drvdata(dev);
        struct tegra_slink_data *tspi = spi_master_get_devdata(master);
index 57e2499..926b68a 100644 (file)
@@ -58,10 +58,6 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
        const struct spi_device *spi = to_spi_device(dev);
        int len;
 
-       len = of_device_modalias(dev, buf, PAGE_SIZE);
-       if (len != -ENODEV)
-               return len;
-
        len = acpi_device_modalias(dev, buf, PAGE_SIZE - 1);
        if (len != -ENODEV)
                return len;
@@ -367,10 +363,6 @@ static int spi_uevent(struct device *dev, struct kobj_uevent_env *env)
        const struct spi_device         *spi = to_spi_device(dev);
        int rc;
 
-       rc = of_device_uevent_modalias(dev, env);
-       if (rc != -ENODEV)
-               return rc;
-
        rc = acpi_device_uevent_modalias(dev, env);
        if (rc != -ENODEV)
                return rc;
@@ -486,12 +478,6 @@ static LIST_HEAD(spi_controller_list);
  */
 static DEFINE_MUTEX(board_lock);
 
-/*
- * Prevents addition of devices with same chip select and
- * addition of devices below an unregistering controller.
- */
-static DEFINE_MUTEX(spi_add_lock);
-
 /**
  * spi_alloc_device - Allocate a new SPI device
  * @ctlr: Controller to which device is connected
@@ -644,9 +630,9 @@ int spi_add_device(struct spi_device *spi)
         * chipselect **BEFORE** we call setup(), else we'll trash
         * its configuration.  Lock against concurrent add() calls.
         */
-       mutex_lock(&spi_add_lock);
+       mutex_lock(&ctlr->add_lock);
        status = __spi_add_device(spi);
-       mutex_unlock(&spi_add_lock);
+       mutex_unlock(&ctlr->add_lock);
        return status;
 }
 EXPORT_SYMBOL_GPL(spi_add_device);
@@ -666,7 +652,7 @@ static int spi_add_device_locked(struct spi_device *spi)
        /* Set the bus ID string */
        spi_dev_set_name(spi);
 
-       WARN_ON(!mutex_is_locked(&spi_add_lock));
+       WARN_ON(!mutex_is_locked(&ctlr->add_lock));
        return __spi_add_device(spi);
 }
 
@@ -2561,6 +2547,12 @@ struct spi_controller *__spi_alloc_controller(struct device *dev,
                return NULL;
 
        device_initialize(&ctlr->dev);
+       INIT_LIST_HEAD(&ctlr->queue);
+       spin_lock_init(&ctlr->queue_lock);
+       spin_lock_init(&ctlr->bus_lock_spinlock);
+       mutex_init(&ctlr->bus_lock_mutex);
+       mutex_init(&ctlr->io_mutex);
+       mutex_init(&ctlr->add_lock);
        ctlr->bus_num = -1;
        ctlr->num_chipselect = 1;
        ctlr->slave = slave;
@@ -2833,11 +2825,6 @@ int spi_register_controller(struct spi_controller *ctlr)
                        return id;
                ctlr->bus_num = id;
        }
-       INIT_LIST_HEAD(&ctlr->queue);
-       spin_lock_init(&ctlr->queue_lock);
-       spin_lock_init(&ctlr->bus_lock_spinlock);
-       mutex_init(&ctlr->bus_lock_mutex);
-       mutex_init(&ctlr->io_mutex);
        ctlr->bus_lock_flag = 0;
        init_completion(&ctlr->xfer_completion);
        if (!ctlr->max_dma_len)
@@ -2974,7 +2961,7 @@ void spi_unregister_controller(struct spi_controller *ctlr)
 
        /* Prevent addition of new devices, unregister existing ones */
        if (IS_ENABLED(CONFIG_SPI_DYNAMIC))
-               mutex_lock(&spi_add_lock);
+               mutex_lock(&ctlr->add_lock);
 
        device_for_each_child(&ctlr->dev, NULL, __unregister);
 
@@ -3005,7 +2992,7 @@ void spi_unregister_controller(struct spi_controller *ctlr)
        mutex_unlock(&board_lock);
 
        if (IS_ENABLED(CONFIG_SPI_DYNAMIC))
-               mutex_unlock(&spi_add_lock);
+               mutex_unlock(&ctlr->add_lock);
 }
 EXPORT_SYMBOL_GPL(spi_unregister_controller);
 
index 6dc29ce..1bd73e3 100644 (file)
@@ -673,6 +673,19 @@ static const struct file_operations spidev_fops = {
 
 static struct class *spidev_class;
 
+static const struct spi_device_id spidev_spi_ids[] = {
+       { .name = "dh2228fv" },
+       { .name = "ltc2488" },
+       { .name = "sx1301" },
+       { .name = "bk4" },
+       { .name = "dhcom-board" },
+       { .name = "m53cpld" },
+       { .name = "spi-petra" },
+       { .name = "spi-authenta" },
+       {},
+};
+MODULE_DEVICE_TABLE(spi, spidev_spi_ids);
+
 #ifdef CONFIG_OF
 static const struct of_device_id spidev_dt_ids[] = {
        { .compatible = "rohm,dh2228fv" },
@@ -818,6 +831,7 @@ static struct spi_driver spidev_spi_driver = {
        },
        .probe =        spidev_probe,
        .remove =       spidev_remove,
+       .id_table =     spidev_spi_ids,
 
        /* NOTE:  suspend/resume methods are not necessary here.
         * We don't do anything except pass the requests to/from
index e6d860a..dc4ed0f 100644 (file)
@@ -761,6 +761,17 @@ out:
        gbphy_runtime_put_autosuspend(gb_tty->gbphy_dev);
 }
 
+static void gb_tty_port_destruct(struct tty_port *port)
+{
+       struct gb_tty *gb_tty = container_of(port, struct gb_tty, port);
+
+       if (gb_tty->minor != GB_NUM_MINORS)
+               release_minor(gb_tty);
+       kfifo_free(&gb_tty->write_fifo);
+       kfree(gb_tty->buffer);
+       kfree(gb_tty);
+}
+
 static const struct tty_operations gb_ops = {
        .install =              gb_tty_install,
        .open =                 gb_tty_open,
@@ -786,6 +797,7 @@ static const struct tty_port_operations gb_port_ops = {
        .dtr_rts =              gb_tty_dtr_rts,
        .activate =             gb_tty_port_activate,
        .shutdown =             gb_tty_port_shutdown,
+       .destruct =             gb_tty_port_destruct,
 };
 
 static int gb_uart_probe(struct gbphy_device *gbphy_dev,
@@ -798,17 +810,11 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
        int retval;
        int minor;
 
-       gb_tty = kzalloc(sizeof(*gb_tty), GFP_KERNEL);
-       if (!gb_tty)
-               return -ENOMEM;
-
        connection = gb_connection_create(gbphy_dev->bundle,
                                          le16_to_cpu(gbphy_dev->cport_desc->id),
                                          gb_uart_request_handler);
-       if (IS_ERR(connection)) {
-               retval = PTR_ERR(connection);
-               goto exit_tty_free;
-       }
+       if (IS_ERR(connection))
+               return PTR_ERR(connection);
 
        max_payload = gb_operation_get_payload_size_max(connection);
        if (max_payload < sizeof(struct gb_uart_send_data_request)) {
@@ -816,13 +822,23 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
                goto exit_connection_destroy;
        }
 
+       gb_tty = kzalloc(sizeof(*gb_tty), GFP_KERNEL);
+       if (!gb_tty) {
+               retval = -ENOMEM;
+               goto exit_connection_destroy;
+       }
+
+       tty_port_init(&gb_tty->port);
+       gb_tty->port.ops = &gb_port_ops;
+       gb_tty->minor = GB_NUM_MINORS;
+
        gb_tty->buffer_payload_max = max_payload -
                        sizeof(struct gb_uart_send_data_request);
 
        gb_tty->buffer = kzalloc(gb_tty->buffer_payload_max, GFP_KERNEL);
        if (!gb_tty->buffer) {
                retval = -ENOMEM;
-               goto exit_connection_destroy;
+               goto exit_put_port;
        }
 
        INIT_WORK(&gb_tty->tx_work, gb_uart_tx_write_work);
@@ -830,7 +846,7 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
        retval = kfifo_alloc(&gb_tty->write_fifo, GB_UART_WRITE_FIFO_SIZE,
                             GFP_KERNEL);
        if (retval)
-               goto exit_buf_free;
+               goto exit_put_port;
 
        gb_tty->credits = GB_UART_FIRMWARE_CREDITS;
        init_completion(&gb_tty->credits_complete);
@@ -844,7 +860,7 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
                } else {
                        retval = minor;
                }
-               goto exit_kfifo_free;
+               goto exit_put_port;
        }
 
        gb_tty->minor = minor;
@@ -853,9 +869,6 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
        init_waitqueue_head(&gb_tty->wioctl);
        mutex_init(&gb_tty->mutex);
 
-       tty_port_init(&gb_tty->port);
-       gb_tty->port.ops = &gb_port_ops;
-
        gb_tty->connection = connection;
        gb_tty->gbphy_dev = gbphy_dev;
        gb_connection_set_data(connection, gb_tty);
@@ -863,7 +876,7 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 
        retval = gb_connection_enable_tx(connection);
        if (retval)
-               goto exit_release_minor;
+               goto exit_put_port;
 
        send_control(gb_tty, gb_tty->ctrlout);
 
@@ -890,16 +903,10 @@ static int gb_uart_probe(struct gbphy_device *gbphy_dev,
 
 exit_connection_disable:
        gb_connection_disable(connection);
-exit_release_minor:
-       release_minor(gb_tty);
-exit_kfifo_free:
-       kfifo_free(&gb_tty->write_fifo);
-exit_buf_free:
-       kfree(gb_tty->buffer);
+exit_put_port:
+       tty_port_put(&gb_tty->port);
 exit_connection_destroy:
        gb_connection_destroy(connection);
-exit_tty_free:
-       kfree(gb_tty);
 
        return retval;
 }
@@ -930,15 +937,10 @@ static void gb_uart_remove(struct gbphy_device *gbphy_dev)
        gb_connection_disable_rx(connection);
        tty_unregister_device(gb_tty_driver, gb_tty->minor);
 
-       /* FIXME - free transmit / receive buffers */
-
        gb_connection_disable(connection);
-       tty_port_destroy(&gb_tty->port);
        gb_connection_destroy(connection);
-       release_minor(gb_tty);
-       kfifo_free(&gb_tty->write_fifo);
-       kfree(gb_tty->buffer);
-       kfree(gb_tty);
+
+       tty_port_put(&gb_tty->port);
 }
 
 static int gb_tty_init(void)
index 8e085dd..712e01c 100644 (file)
@@ -1646,6 +1646,8 @@ static input_system_err_t input_system_configure_channel_sensor(
        default:
                return INPUT_SYSTEM_ERR_PARAMETER_NOT_SUPPORTED;
        }
+
+       return INPUT_SYSTEM_ERR_NO_ERROR;
 }
 
 // Test flags and set structure.
index 8a2edd6..20e5081 100644 (file)
@@ -919,7 +919,7 @@ static int hantro_probe(struct platform_device *pdev)
                if (!vpu->variant->irqs[i].handler)
                        continue;
 
-               if (vpu->variant->num_clocks > 1) {
+               if (vpu->variant->num_irqs > 1) {
                        irq_name = vpu->variant->irqs[i].name;
                        irq = platform_get_irq_byname(vpu->pdev, irq_name);
                } else {
index c589fe9..825af5f 100644 (file)
@@ -135,7 +135,7 @@ void cedrus_prepare_format(struct v4l2_pix_format *pix_fmt)
                sizeimage = bytesperline * height;
 
                /* Chroma plane size. */
-               sizeimage += bytesperline * height / 2;
+               sizeimage += bytesperline * ALIGN(height, 64) / 2;
 
                break;
 
index a6d589e..f27eba7 100644 (file)
@@ -248,7 +248,7 @@ void rtw_hal_update_ra_mask(struct adapter *adapt, u32 mac_id, u8 rssi_level)
 #ifdef CONFIG_88EU_AP_MODE
                struct sta_info *psta = NULL;
                struct sta_priv *pstapriv = &adapt->stapriv;
-               if ((mac_id - 1) > 0)
+               if (mac_id >= 2)
                        psta = pstapriv->sta_aid[(mac_id - 1) - 1];
                if (psta)
                        add_RATid(adapt, psta, 0);/* todo: based on rssi_level*/
index 81d4255..1fd3750 100644 (file)
@@ -5372,8 +5372,8 @@ static int rtw_mp_read_reg(struct net_device *dev,
 
                        pnext++;
                        if (*pnext != '\0') {
-                                 strtout = simple_strtoul(pnext, &ptmp, 16);
-                                 sprintf(extra, "%s %d", extra, strtout);
+                               strtout = simple_strtoul(pnext, &ptmp, 16);
+                               sprintf(extra + strlen(extra), " %d", strtout);
                        } else {
                                  break;
                        }
@@ -5405,7 +5405,7 @@ static int rtw_mp_read_reg(struct net_device *dev,
                        pnext++;
                        if (*pnext != '\0') {
                                strtout = simple_strtoul(pnext, &ptmp, 16);
-                               sprintf(extra, "%s %d", extra, strtout);
+                               sprintf(extra + strlen(extra), " %d", strtout);
                        } else {
                                break;
                        }
@@ -5512,7 +5512,7 @@ static int rtw_mp_read_rf(struct net_device *dev,
                pnext++;
                if (*pnext != '\0') {
                          strtou = simple_strtoul(pnext, &ptmp, 16);
-                         sprintf(extra, "%s %d", extra, strtou);
+                         sprintf(extra + strlen(extra), " %d", strtou);
                } else {
                          break;
                }
index b25369a..967f10b 100644 (file)
@@ -182,7 +182,7 @@ create_pagelist(char *buf, char __user *ubuf,
                offset = (uintptr_t)ubuf & (PAGE_SIZE - 1);
        num_pages = DIV_ROUND_UP(count + offset, PAGE_SIZE);
 
-       if (num_pages > (SIZE_MAX - sizeof(struct pagelist) -
+       if ((size_t)num_pages > (SIZE_MAX - sizeof(struct pagelist) -
                         sizeof(struct vchiq_pagelist_info)) /
                        (sizeof(u32) + sizeof(pages[0]) +
                         sizeof(struct scatterlist)))
index 102ec64..023bd45 100644 (file)
@@ -1110,20 +1110,24 @@ static ssize_t alua_support_store(struct config_item *item,
 {
        struct se_dev_attrib *da = to_attrib(item);
        struct se_device *dev = da->da_dev;
-       bool flag;
+       bool flag, oldflag;
        int ret;
 
+       ret = strtobool(page, &flag);
+       if (ret < 0)
+               return ret;
+
+       oldflag = !(dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_ALUA);
+       if (flag == oldflag)
+               return count;
+
        if (!(dev->transport->transport_flags_changeable &
              TRANSPORT_FLAG_PASSTHROUGH_ALUA)) {
                pr_err("dev[%p]: Unable to change SE Device alua_support:"
                        " alua_support has fixed value\n", dev);
-               return -EINVAL;
+               return -ENOSYS;
        }
 
-       ret = strtobool(page, &flag);
-       if (ret < 0)
-               return ret;
-
        if (flag)
                dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_ALUA;
        else
@@ -1145,20 +1149,24 @@ static ssize_t pgr_support_store(struct config_item *item,
 {
        struct se_dev_attrib *da = to_attrib(item);
        struct se_device *dev = da->da_dev;
-       bool flag;
+       bool flag, oldflag;
        int ret;
 
+       ret = strtobool(page, &flag);
+       if (ret < 0)
+               return ret;
+
+       oldflag = !(dev->transport_flags & TRANSPORT_FLAG_PASSTHROUGH_PGR);
+       if (flag == oldflag)
+               return count;
+
        if (!(dev->transport->transport_flags_changeable &
              TRANSPORT_FLAG_PASSTHROUGH_PGR)) {
                pr_err("dev[%p]: Unable to change SE Device pgr_support:"
                        " pgr_support has fixed value\n", dev);
-               return -EINVAL;
+               return -ENOSYS;
        }
 
-       ret = strtobool(page, &flag);
-       if (ret < 0)
-               return ret;
-
        if (flag)
                dev->transport_flags &= ~TRANSPORT_FLAG_PASSTHROUGH_PGR;
        else
index 4b94b08..3829b61 100644 (file)
@@ -269,7 +269,7 @@ target_scsi2_reservation_reserve(struct se_cmd *cmd)
        spin_lock(&dev->dev_reservation_lock);
        if (dev->reservation_holder &&
            dev->reservation_holder->se_node_acl != sess->se_node_acl) {
-               pr_err("SCSI-2 RESERVATION CONFLIFT for %s fabric\n",
+               pr_err("SCSI-2 RESERVATION CONFLICT for %s fabric\n",
                        tpg->se_tpg_tfo->fabric_name);
                pr_err("Original reserver LUN: %llu %s\n",
                        cmd->se_lun->unpacked_lun,
index 5ce13b0..5363ebe 100644 (file)
@@ -585,6 +585,9 @@ static int optee_remove(struct platform_device *pdev)
 {
        struct optee *optee = platform_get_drvdata(pdev);
 
+       /* Unregister OP-TEE specific client devices on TEE bus */
+       optee_unregister_devices();
+
        /*
         * Ask OP-TEE to free all cached shared memory objects to decrease
         * reference counters and also avoid wild pointers in secure world
index ec1d246..128a2d2 100644 (file)
@@ -53,6 +53,13 @@ static int get_devices(struct tee_context *ctx, u32 session,
        return 0;
 }
 
+static void optee_release_device(struct device *dev)
+{
+       struct tee_client_device *optee_device = to_tee_client_device(dev);
+
+       kfree(optee_device);
+}
+
 static int optee_register_device(const uuid_t *device_uuid)
 {
        struct tee_client_device *optee_device = NULL;
@@ -63,6 +70,7 @@ static int optee_register_device(const uuid_t *device_uuid)
                return -ENOMEM;
 
        optee_device->dev.bus = &tee_bus_type;
+       optee_device->dev.release = optee_release_device;
        if (dev_set_name(&optee_device->dev, "optee-ta-%pUb", device_uuid)) {
                kfree(optee_device);
                return -ENOMEM;
@@ -154,3 +162,17 @@ int optee_enumerate_devices(u32 func)
 {
        return  __optee_enumerate_devices(func);
 }
+
+static int __optee_unregister_device(struct device *dev, void *data)
+{
+       if (!strncmp(dev_name(dev), "optee-ta", strlen("optee-ta")))
+               device_unregister(dev);
+
+       return 0;
+}
+
+void optee_unregister_devices(void)
+{
+       bus_for_each_dev(&tee_bus_type, NULL, NULL,
+                        __optee_unregister_device);
+}
index dbdd367..f6bb4a7 100644 (file)
@@ -184,6 +184,7 @@ void optee_fill_pages_list(u64 *dst, struct page **pages, int num_pages,
 #define PTA_CMD_GET_DEVICES            0x0
 #define PTA_CMD_GET_DEVICES_SUPP       0x1
 int optee_enumerate_devices(u32 func);
+void optee_unregister_devices(void);
 
 /*
  * Small helpers
index c41a9a5..d167039 100644 (file)
@@ -35,7 +35,7 @@ static int pool_op_alloc(struct tee_shm_pool_mgr *poolm,
                unsigned int nr_pages = 1 << order, i;
                struct page **pages;
 
-               pages = kcalloc(nr_pages, sizeof(pages), GFP_KERNEL);
+               pages = kcalloc(nr_pages, sizeof(*pages), GFP_KERNEL);
                if (!pages) {
                        rc = -ENOMEM;
                        goto err;
index 0f0038a..fb64acf 100644 (file)
@@ -107,7 +107,7 @@ static int tcc_offset_update(unsigned int tcc)
        return 0;
 }
 
-static unsigned int tcc_offset_save;
+static int tcc_offset_save = -1;
 
 static ssize_t tcc_offset_degree_celsius_store(struct device *dev,
                                struct device_attribute *attr, const char *buf,
@@ -352,7 +352,8 @@ int proc_thermal_resume(struct device *dev)
        proc_dev = dev_get_drvdata(dev);
        proc_thermal_read_ppcc(proc_dev);
 
-       tcc_offset_update(tcc_offset_save);
+       if (tcc_offset_save >= 0)
+               tcc_offset_update(tcc_offset_save);
 
        return 0;
 }
index 4c7ebd1..b1162e5 100644 (file)
@@ -417,7 +417,7 @@ static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
                const struct tsens_sensor *s = &priv->sensor[i];
                u32 hw_id = s->hw_id;
 
-               if (IS_ERR(s->tzd))
+               if (!s->tzd)
                        continue;
                if (!tsens_threshold_violated(priv, hw_id, &d))
                        continue;
@@ -467,7 +467,7 @@ static irqreturn_t tsens_irq_thread(int irq, void *data)
                const struct tsens_sensor *s = &priv->sensor[i];
                u32 hw_id = s->hw_id;
 
-               if (IS_ERR(s->tzd))
+               if (!s->tzd)
                        continue;
                if (!tsens_threshold_violated(priv, hw_id, &d))
                        continue;
index 97ef9b0..51374f4 100644 (file)
@@ -222,15 +222,14 @@ int thermal_build_list_of_policies(char *buf)
 {
        struct thermal_governor *pos;
        ssize_t count = 0;
-       ssize_t size = PAGE_SIZE;
 
        mutex_lock(&thermal_governor_lock);
 
        list_for_each_entry(pos, &thermal_governor_list, governor_list) {
-               size = PAGE_SIZE - count;
-               count += scnprintf(buf + count, size, "%s ", pos->name);
+               count += scnprintf(buf + count, PAGE_SIZE - count, "%s ",
+                                  pos->name);
        }
-       count += scnprintf(buf + count, size, "\n");
+       count += scnprintf(buf + count, PAGE_SIZE - count, "\n");
 
        mutex_unlock(&thermal_governor_lock);
 
index da19d79..78fd365 100644 (file)
@@ -7,6 +7,7 @@ thunderbolt-objs += usb4_port.o nvm.o retimer.o quirks.o
 thunderbolt-${CONFIG_ACPI} += acpi.o
 thunderbolt-$(CONFIG_DEBUG_FS) += debugfs.o
 thunderbolt-${CONFIG_USB4_KUNIT_TEST} += test.o
+CFLAGS_test.o += $(DISABLE_STRUCTLEAK_PLUGIN)
 
 thunderbolt_dma_test-${CONFIG_USB4_DMA_TEST} += dma_test.o
 obj-$(CONFIG_USB4_DMA_TEST) += thunderbolt_dma_test.o
index 8f143c0..f0bf01e 100644 (file)
@@ -618,10 +618,8 @@ static int __init xenboot_console_setup(struct console *console, char *string)
 {
        static struct xencons_info xenboot;
 
-       if (xen_initial_domain())
+       if (xen_initial_domain() || !xen_pv_domain())
                return 0;
-       if (!xen_pv_domain())
-               return -ENODEV;
 
        return xencons_info_pv_init(&xenboot, 0);
 }
@@ -632,17 +630,16 @@ static void xenboot_write_console(struct console *console, const char *string,
        unsigned int linelen, off = 0;
        const char *pos;
 
+       if (dom0_write_console(0, string, len) >= 0)
+               return;
+
        if (!xen_pv_domain()) {
                xen_hvm_early_write(0, string, len);
                return;
        }
 
-       dom0_write_console(0, string, len);
-
-       if (xen_initial_domain())
+       if (domU_write_console(0, "(early) ", 8) < 0)
                return;
-
-       domU_write_console(0, "(early) ", 8);
        while (off < len && NULL != (pos = strchr(string+off, '\n'))) {
                linelen = pos-string+off;
                if (off + linelen > len)
index 891fd83..73e5f1d 100644 (file)
 #define UART_OMAP_EFR2_TIMEOUT_BEHAVE  BIT(6)
 
 /* RX FIFO occupancy indicator */
-#define UART_OMAP_RX_LVL               0x64
+#define UART_OMAP_RX_LVL               0x19
 
 struct omap8250_priv {
        int line;
index 71ae16d..39fc96d 100644 (file)
@@ -361,9 +361,13 @@ config SERIAL_8250_BCM2835AUX
          If unsure, say N.
 
 config SERIAL_8250_FSL
-       bool
+       bool "Freescale 16550 UART support" if COMPILE_TEST && !(PPC || ARM || ARM64)
        depends on SERIAL_8250_CONSOLE
-       default PPC || ARM || ARM64 || COMPILE_TEST
+       default PPC || ARM || ARM64
+       help
+         Selecting this option enables a workaround for a break-detection
+         erratum for Freescale 16550 UARTs in the 8250 driver. It also
+         enables support for ACPI enumeration.
 
 config SERIAL_8250_DW
        tristate "Support for Synopsys DesignWare 8250 quirks"
index 231de29..ab226da 100644 (file)
@@ -163,7 +163,7 @@ static unsigned int mvebu_uart_tx_empty(struct uart_port *port)
        st = readl(port->membase + UART_STAT);
        spin_unlock_irqrestore(&port->lock, flags);
 
-       return (st & STAT_TX_FIFO_EMP) ? TIOCSER_TEMT : 0;
+       return (st & STAT_TX_EMP) ? TIOCSER_TEMT : 0;
 }
 
 static unsigned int mvebu_uart_get_mctrl(struct uart_port *port)
index a9acd93..25c558e 100644 (file)
@@ -438,8 +438,8 @@ static void reset_tbufs(struct slgt_info *info);
 static void tdma_reset(struct slgt_info *info);
 static bool tx_load(struct slgt_info *info, const char *buf, unsigned int count);
 
-static void get_signals(struct slgt_info *info);
-static void set_signals(struct slgt_info *info);
+static void get_gtsignals(struct slgt_info *info);
+static void set_gtsignals(struct slgt_info *info);
 static void set_rate(struct slgt_info *info, u32 data_rate);
 
 static void bh_transmit(struct slgt_info *info);
@@ -720,7 +720,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
        if ((old_termios->c_cflag & CBAUD) && !C_BAUD(tty)) {
                info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
                spin_lock_irqsave(&info->lock,flags);
-               set_signals(info);
+               set_gtsignals(info);
                spin_unlock_irqrestore(&info->lock,flags);
        }
 
@@ -730,7 +730,7 @@ static void set_termios(struct tty_struct *tty, struct ktermios *old_termios)
                if (!C_CRTSCTS(tty) || !tty_throttled(tty))
                        info->signals |= SerialSignal_RTS;
                spin_lock_irqsave(&info->lock,flags);
-               set_signals(info);
+               set_gtsignals(info);
                spin_unlock_irqrestore(&info->lock,flags);
        }
 
@@ -1181,7 +1181,7 @@ static inline void line_info(struct seq_file *m, struct slgt_info *info)
 
        /* output current serial signal states */
        spin_lock_irqsave(&info->lock,flags);
-       get_signals(info);
+       get_gtsignals(info);
        spin_unlock_irqrestore(&info->lock,flags);
 
        stat_buf[0] = 0;
@@ -1281,7 +1281,7 @@ static void throttle(struct tty_struct * tty)
        if (C_CRTSCTS(tty)) {
                spin_lock_irqsave(&info->lock,flags);
                info->signals &= ~SerialSignal_RTS;
-               set_signals(info);
+               set_gtsignals(info);
                spin_unlock_irqrestore(&info->lock,flags);
        }
 }
@@ -1306,7 +1306,7 @@ static void unthrottle(struct tty_struct * tty)
        if (C_CRTSCTS(tty)) {
                spin_lock_irqsave(&info->lock,flags);
                info->signals |= SerialSignal_RTS;
-               set_signals(info);
+               set_gtsignals(info);
                spin_unlock_irqrestore(&info->lock,flags);
        }
 }
@@ -1477,7 +1477,7 @@ static int hdlcdev_open(struct net_device *dev)
 
        /* inform generic HDLC layer of current DCD status */
        spin_lock_irqsave(&info->lock, flags);
-       get_signals(info);
+       get_gtsignals(info);
        spin_unlock_irqrestore(&info->lock, flags);
        if (info->signals & SerialSignal_DCD)
                netif_carrier_on(dev);
@@ -2229,7 +2229,7 @@ static void isr_txeom(struct slgt_info *info, unsigned short status)
                if (info->params.mode != MGSL_MODE_ASYNC && info->drop_rts_on_tx_done) {
                        info->signals &= ~SerialSignal_RTS;
                        info->drop_rts_on_tx_done = false;
-                       set_signals(info);
+                       set_gtsignals(info);
                }
 
 #if SYNCLINK_GENERIC_HDLC
@@ -2394,7 +2394,7 @@ static void shutdown(struct slgt_info *info)
 
        if (!info->port.tty || info->port.tty->termios.c_cflag & HUPCL) {
                info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
-               set_signals(info);
+               set_gtsignals(info);
        }
 
        flush_cond_wait(&info->gpio_wait_q);
@@ -2422,7 +2422,7 @@ static void program_hw(struct slgt_info *info)
        else
                async_mode(info);
 
-       set_signals(info);
+       set_gtsignals(info);
 
        info->dcd_chkcount = 0;
        info->cts_chkcount = 0;
@@ -2430,7 +2430,7 @@ static void program_hw(struct slgt_info *info)
        info->dsr_chkcount = 0;
 
        slgt_irq_on(info, IRQ_DCD | IRQ_CTS | IRQ_DSR | IRQ_RI);
-       get_signals(info);
+       get_gtsignals(info);
 
        if (info->netcount ||
            (info->port.tty && info->port.tty->termios.c_cflag & CREAD))
@@ -2667,7 +2667,7 @@ static int wait_mgsl_event(struct slgt_info *info, int __user *mask_ptr)
        spin_lock_irqsave(&info->lock,flags);
 
        /* return immediately if state matches requested events */
-       get_signals(info);
+       get_gtsignals(info);
        s = info->signals;
 
        events = mask &
@@ -3085,7 +3085,7 @@ static int tiocmget(struct tty_struct *tty)
        unsigned long flags;
 
        spin_lock_irqsave(&info->lock,flags);
-       get_signals(info);
+       get_gtsignals(info);
        spin_unlock_irqrestore(&info->lock,flags);
 
        result = ((info->signals & SerialSignal_RTS) ? TIOCM_RTS:0) +
@@ -3124,7 +3124,7 @@ static int tiocmset(struct tty_struct *tty,
                info->signals &= ~SerialSignal_DTR;
 
        spin_lock_irqsave(&info->lock,flags);
-       set_signals(info);
+       set_gtsignals(info);
        spin_unlock_irqrestore(&info->lock,flags);
        return 0;
 }
@@ -3135,7 +3135,7 @@ static int carrier_raised(struct tty_port *port)
        struct slgt_info *info = container_of(port, struct slgt_info, port);
 
        spin_lock_irqsave(&info->lock,flags);
-       get_signals(info);
+       get_gtsignals(info);
        spin_unlock_irqrestore(&info->lock,flags);
        return (info->signals & SerialSignal_DCD) ? 1 : 0;
 }
@@ -3150,7 +3150,7 @@ static void dtr_rts(struct tty_port *port, int on)
                info->signals |= SerialSignal_RTS | SerialSignal_DTR;
        else
                info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
-       set_signals(info);
+       set_gtsignals(info);
        spin_unlock_irqrestore(&info->lock,flags);
 }
 
@@ -3948,10 +3948,10 @@ static void tx_start(struct slgt_info *info)
 
                if (info->params.mode != MGSL_MODE_ASYNC) {
                        if (info->params.flags & HDLC_FLAG_AUTO_RTS) {
-                               get_signals(info);
+                               get_gtsignals(info);
                                if (!(info->signals & SerialSignal_RTS)) {
                                        info->signals |= SerialSignal_RTS;
-                                       set_signals(info);
+                                       set_gtsignals(info);
                                        info->drop_rts_on_tx_done = true;
                                }
                        }
@@ -4005,7 +4005,7 @@ static void reset_port(struct slgt_info *info)
        rx_stop(info);
 
        info->signals &= ~(SerialSignal_RTS | SerialSignal_DTR);
-       set_signals(info);
+       set_gtsignals(info);
 
        slgt_irq_off(info, IRQ_ALL | IRQ_MASTER);
 }
@@ -4427,7 +4427,7 @@ static void tx_set_idle(struct slgt_info *info)
 /*
  * get state of V24 status (input) signals
  */
-static void get_signals(struct slgt_info *info)
+static void get_gtsignals(struct slgt_info *info)
 {
        unsigned short status = rd_reg16(info, SSR);
 
@@ -4489,7 +4489,7 @@ static void msc_set_vcr(struct slgt_info *info)
 /*
  * set state of V24 control (output) signals
  */
-static void set_signals(struct slgt_info *info)
+static void set_gtsignals(struct slgt_info *info)
 {
        unsigned char val = rd_reg8(info, VCR);
        if (info->signals & SerialSignal_DTR)
index 756a4bf..3e4e0b2 100644 (file)
@@ -812,7 +812,6 @@ void tty_ldisc_release(struct tty_struct *tty)
 
        tty_ldisc_debug(tty, "released\n");
 }
-EXPORT_SYMBOL_GPL(tty_ldisc_release);
 
 /**
  *     tty_ldisc_init          -       ldisc setup for new tty
index 5d8c982..1f3b4a1 100644 (file)
@@ -1100,6 +1100,19 @@ static int cdns3_ep_run_stream_transfer(struct cdns3_endpoint *priv_ep,
        return 0;
 }
 
+static void cdns3_rearm_drdy_if_needed(struct cdns3_endpoint *priv_ep)
+{
+       struct cdns3_device *priv_dev = priv_ep->cdns3_dev;
+
+       if (priv_dev->dev_ver < DEV_VER_V3)
+               return;
+
+       if (readl(&priv_dev->regs->ep_sts) & EP_STS_TRBERR) {
+               writel(EP_STS_TRBERR, &priv_dev->regs->ep_sts);
+               writel(EP_CMD_DRDY, &priv_dev->regs->ep_cmd);
+       }
+}
+
 /**
  * cdns3_ep_run_transfer - start transfer on no-default endpoint hardware
  * @priv_ep: endpoint object
@@ -1351,6 +1364,7 @@ static int cdns3_ep_run_transfer(struct cdns3_endpoint *priv_ep,
                /*clearing TRBERR and EP_STS_DESCMIS before seting DRDY*/
                writel(EP_STS_TRBERR | EP_STS_DESCMIS, &priv_dev->regs->ep_sts);
                writel(EP_CMD_DRDY, &priv_dev->regs->ep_cmd);
+               cdns3_rearm_drdy_if_needed(priv_ep);
                trace_cdns3_doorbell_epx(priv_ep->name,
                                         readl(&priv_dev->regs->ep_traddr));
        }
index 8b7bc10..f1d1006 100644 (file)
@@ -420,11 +420,16 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
        data->phy = devm_usb_get_phy_by_phandle(dev, "fsl,usbphy", 0);
        if (IS_ERR(data->phy)) {
                ret = PTR_ERR(data->phy);
-               /* Return -EINVAL if no usbphy is available */
-               if (ret == -ENODEV)
-                       data->phy = NULL;
-               else
-                       goto err_clk;
+               if (ret == -ENODEV) {
+                       data->phy = devm_usb_get_phy_by_phandle(dev, "phys", 0);
+                       if (IS_ERR(data->phy)) {
+                               ret = PTR_ERR(data->phy);
+                               if (ret == -ENODEV)
+                                       data->phy = NULL;
+                               else
+                                       goto err_clk;
+                       }
+               }
        }
 
        pdata.usb_phy = data->phy;
index 8bbd8e2..7b2e242 100644 (file)
@@ -340,6 +340,9 @@ static void acm_process_notification(struct acm *acm, unsigned char *buf)
                        acm->iocount.overrun++;
                spin_unlock_irqrestore(&acm->read_lock, flags);
 
+               if (newctrl & ACM_CTRL_BRK)
+                       tty_flip_buffer_push(&acm->port);
+
                if (difference)
                        wake_up_all(&acm->wioctl);
 
@@ -475,11 +478,16 @@ static int acm_submit_read_urbs(struct acm *acm, gfp_t mem_flags)
 
 static void acm_process_read_urb(struct acm *acm, struct urb *urb)
 {
+       unsigned long flags;
+
        if (!urb->actual_length)
                return;
 
+       spin_lock_irqsave(&acm->read_lock, flags);
        tty_insert_flip_string(&acm->port, urb->transfer_buffer,
                        urb->actual_length);
+       spin_unlock_irqrestore(&acm->read_lock, flags);
+
        tty_flip_buffer_push(&acm->port);
 }
 
@@ -726,7 +734,8 @@ static void acm_port_destruct(struct tty_port *port)
 {
        struct acm *acm = container_of(port, struct acm, port);
 
-       acm_release_minor(acm);
+       if (acm->minor != ACM_MINOR_INVALID)
+               acm_release_minor(acm);
        usb_put_intf(acm->control);
        kfree(acm->country_codes);
        kfree(acm);
@@ -1323,8 +1332,10 @@ made_compressed_probe:
        usb_get_intf(acm->control); /* undone in destruct() */
 
        minor = acm_alloc_minor(acm);
-       if (minor < 0)
+       if (minor < 0) {
+               acm->minor = ACM_MINOR_INVALID;
                goto err_put_port;
+       }
 
        acm->minor = minor;
        acm->dev = usb_dev;
index 8aef5eb..3aa7f0a 100644 (file)
@@ -22,6 +22,8 @@
 #define ACM_TTY_MAJOR          166
 #define ACM_TTY_MINORS         256
 
+#define ACM_MINOR_INVALID      ACM_TTY_MINORS
+
 /*
  * Requests.
  */
index 35d5908..fdf79bc 100644 (file)
@@ -824,7 +824,7 @@ static struct usb_class_driver wdm_class = {
 };
 
 /* --- WWAN framework integration --- */
-#ifdef CONFIG_WWAN_CORE
+#ifdef CONFIG_WWAN
 static int wdm_wwan_port_start(struct wwan_port *port)
 {
        struct wdm_device *desc = wwan_port_get_drvdata(port);
@@ -963,11 +963,11 @@ static void wdm_wwan_rx(struct wdm_device *desc, int length)
        /* inbuf has been copied, it is safe to check for outstanding data */
        schedule_work(&desc->service_outs_intr);
 }
-#else /* CONFIG_WWAN_CORE */
+#else /* CONFIG_WWAN */
 static void wdm_wwan_init(struct wdm_device *desc) {}
 static void wdm_wwan_deinit(struct wdm_device *desc) {}
 static void wdm_wwan_rx(struct wdm_device *desc, int length) {}
-#endif /* CONFIG_WWAN_CORE */
+#endif /* CONFIG_WWAN */
 
 /* --- error handling --- */
 static void wdm_rxwork(struct work_struct *work)
index 5e8a04e..b856622 100644 (file)
@@ -6,8 +6,7 @@ config USB_COMMON
 
 config USB_LED_TRIG
        bool "USB LED Triggers"
-       depends on LEDS_CLASS && LEDS_TRIGGERS
-       select USB_COMMON
+       depends on LEDS_CLASS && USB_COMMON && LEDS_TRIGGERS
        help
          This option adds LED triggers for USB host and/or gadget activity.
 
index 0f8b7c9..7ee6e4c 100644 (file)
@@ -2760,6 +2760,26 @@ static void usb_put_invalidate_rhdev(struct usb_hcd *hcd)
        usb_put_dev(rhdev);
 }
 
+/**
+ * usb_stop_hcd - Halt the HCD
+ * @hcd: the usb_hcd that has to be halted
+ *
+ * Stop the root-hub polling timer and invoke the HCD's ->stop callback.
+ */
+static void usb_stop_hcd(struct usb_hcd *hcd)
+{
+       hcd->rh_pollable = 0;
+       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
+       del_timer_sync(&hcd->rh_timer);
+
+       hcd->driver->stop(hcd);
+       hcd->state = HC_STATE_HALT;
+
+       /* In case the HCD restarted the timer, stop it again. */
+       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
+       del_timer_sync(&hcd->rh_timer);
+}
+
 /**
  * usb_add_hcd - finish generic HCD structure initialization and register
  * @hcd: the usb_hcd structure to initialize
@@ -2775,6 +2795,7 @@ int usb_add_hcd(struct usb_hcd *hcd,
 {
        int retval;
        struct usb_device *rhdev;
+       struct usb_hcd *shared_hcd;
 
        if (!hcd->skip_phy_initialization && usb_hcd_is_primary_hcd(hcd)) {
                hcd->phy_roothub = usb_phy_roothub_alloc(hcd->self.sysdev);
@@ -2935,24 +2956,31 @@ int usb_add_hcd(struct usb_hcd *hcd,
                goto err_hcd_driver_start;
        }
 
+       /* starting here, usbcore will pay attention to the shared HCD roothub */
+       shared_hcd = hcd->shared_hcd;
+       if (!usb_hcd_is_primary_hcd(hcd) && shared_hcd && HCD_DEFER_RH_REGISTER(shared_hcd)) {
+               retval = register_root_hub(shared_hcd);
+               if (retval != 0)
+                       goto err_register_root_hub;
+
+               if (shared_hcd->uses_new_polling && HCD_POLL_RH(shared_hcd))
+                       usb_hcd_poll_rh_status(shared_hcd);
+       }
+
        /* starting here, usbcore will pay attention to this root hub */
-       retval = register_root_hub(hcd);
-       if (retval != 0)
-               goto err_register_root_hub;
+       if (!HCD_DEFER_RH_REGISTER(hcd)) {
+               retval = register_root_hub(hcd);
+               if (retval != 0)
+                       goto err_register_root_hub;
 
-       if (hcd->uses_new_polling && HCD_POLL_RH(hcd))
-               usb_hcd_poll_rh_status(hcd);
+               if (hcd->uses_new_polling && HCD_POLL_RH(hcd))
+                       usb_hcd_poll_rh_status(hcd);
+       }
 
        return retval;
 
 err_register_root_hub:
-       hcd->rh_pollable = 0;
-       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
-       del_timer_sync(&hcd->rh_timer);
-       hcd->driver->stop(hcd);
-       hcd->state = HC_STATE_HALT;
-       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
-       del_timer_sync(&hcd->rh_timer);
+       usb_stop_hcd(hcd);
 err_hcd_driver_start:
        if (usb_hcd_is_primary_hcd(hcd) && hcd->irq > 0)
                free_irq(irqnum, hcd);
@@ -2985,6 +3013,7 @@ EXPORT_SYMBOL_GPL(usb_add_hcd);
 void usb_remove_hcd(struct usb_hcd *hcd)
 {
        struct usb_device *rhdev = hcd->self.root_hub;
+       bool rh_registered;
 
        dev_info(hcd->self.controller, "remove, state %x\n", hcd->state);
 
@@ -2995,6 +3024,7 @@ void usb_remove_hcd(struct usb_hcd *hcd)
 
        dev_dbg(hcd->self.controller, "roothub graceful disconnect\n");
        spin_lock_irq (&hcd_root_hub_lock);
+       rh_registered = hcd->rh_registered;
        hcd->rh_registered = 0;
        spin_unlock_irq (&hcd_root_hub_lock);
 
@@ -3004,7 +3034,8 @@ void usb_remove_hcd(struct usb_hcd *hcd)
        cancel_work_sync(&hcd->died_work);
 
        mutex_lock(&usb_bus_idr_lock);
-       usb_disconnect(&rhdev);         /* Sets rhdev to NULL */
+       if (rh_registered)
+               usb_disconnect(&rhdev);         /* Sets rhdev to NULL */
        mutex_unlock(&usb_bus_idr_lock);
 
        /*
@@ -3022,16 +3053,7 @@ void usb_remove_hcd(struct usb_hcd *hcd)
         * interrupt occurs), but usb_hcd_poll_rh_status() won't invoke
         * the hub_status_data() callback.
         */
-       hcd->rh_pollable = 0;
-       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
-       del_timer_sync(&hcd->rh_timer);
-
-       hcd->driver->stop(hcd);
-       hcd->state = HC_STATE_HALT;
-
-       /* In case the HCD restarted the timer, stop it again. */
-       clear_bit(HCD_FLAG_POLL_RH, &hcd->flags);
-       del_timer_sync(&hcd->rh_timer);
+       usb_stop_hcd(hcd);
 
        if (usb_hcd_is_primary_hcd(hcd)) {
                if (hcd->irq > 0)
index 837237e..11d85a6 100644 (file)
@@ -115,10 +115,16 @@ static inline bool using_desc_dma(struct dwc2_hsotg *hsotg)
  */
 static inline void dwc2_gadget_incr_frame_num(struct dwc2_hsotg_ep *hs_ep)
 {
+       struct dwc2_hsotg *hsotg = hs_ep->parent;
+       u16 limit = DSTS_SOFFN_LIMIT;
+
+       if (hsotg->gadget.speed != USB_SPEED_HIGH)
+               limit >>= 3;
+
        hs_ep->target_frame += hs_ep->interval;
-       if (hs_ep->target_frame > DSTS_SOFFN_LIMIT) {
+       if (hs_ep->target_frame > limit) {
                hs_ep->frame_overrun = true;
-               hs_ep->target_frame &= DSTS_SOFFN_LIMIT;
+               hs_ep->target_frame &= limit;
        } else {
                hs_ep->frame_overrun = false;
        }
@@ -136,10 +142,16 @@ static inline void dwc2_gadget_incr_frame_num(struct dwc2_hsotg_ep *hs_ep)
  */
 static inline void dwc2_gadget_dec_frame_num_by_one(struct dwc2_hsotg_ep *hs_ep)
 {
+       struct dwc2_hsotg *hsotg = hs_ep->parent;
+       u16 limit = DSTS_SOFFN_LIMIT;
+
+       if (hsotg->gadget.speed != USB_SPEED_HIGH)
+               limit >>= 3;
+
        if (hs_ep->target_frame)
                hs_ep->target_frame -= 1;
        else
-               hs_ep->target_frame = DSTS_SOFFN_LIMIT;
+               hs_ep->target_frame = limit;
 }
 
 /**
@@ -1018,6 +1030,12 @@ static void dwc2_gadget_start_isoc_ddma(struct dwc2_hsotg_ep *hs_ep)
        dwc2_writel(hsotg, ctrl, depctl);
 }
 
+static bool dwc2_gadget_target_frame_elapsed(struct dwc2_hsotg_ep *hs_ep);
+static void dwc2_hsotg_complete_request(struct dwc2_hsotg *hsotg,
+                                       struct dwc2_hsotg_ep *hs_ep,
+                                      struct dwc2_hsotg_req *hs_req,
+                                      int result);
+
 /**
  * dwc2_hsotg_start_req - start a USB request from an endpoint's queue
  * @hsotg: The controller state.
@@ -1170,14 +1188,19 @@ static void dwc2_hsotg_start_req(struct dwc2_hsotg *hsotg,
                }
        }
 
-       if (hs_ep->isochronous && hs_ep->interval == 1) {
-               hs_ep->target_frame = dwc2_hsotg_read_frameno(hsotg);
-               dwc2_gadget_incr_frame_num(hs_ep);
-
-               if (hs_ep->target_frame & 0x1)
-                       ctrl |= DXEPCTL_SETODDFR;
-               else
-                       ctrl |= DXEPCTL_SETEVENFR;
+       if (hs_ep->isochronous) {
+               if (!dwc2_gadget_target_frame_elapsed(hs_ep)) {
+                       if (hs_ep->interval == 1) {
+                               if (hs_ep->target_frame & 0x1)
+                                       ctrl |= DXEPCTL_SETODDFR;
+                               else
+                                       ctrl |= DXEPCTL_SETEVENFR;
+                       }
+                       ctrl |= DXEPCTL_CNAK;
+               } else {
+                       dwc2_hsotg_complete_request(hsotg, hs_ep, hs_req, -ENODATA);
+                       return;
+               }
        }
 
        ctrl |= DXEPCTL_EPENA;  /* ensure ep enabled */
@@ -1325,12 +1348,16 @@ static bool dwc2_gadget_target_frame_elapsed(struct dwc2_hsotg_ep *hs_ep)
        u32 target_frame = hs_ep->target_frame;
        u32 current_frame = hsotg->frame_number;
        bool frame_overrun = hs_ep->frame_overrun;
+       u16 limit = DSTS_SOFFN_LIMIT;
+
+       if (hsotg->gadget.speed != USB_SPEED_HIGH)
+               limit >>= 3;
 
        if (!frame_overrun && current_frame >= target_frame)
                return true;
 
        if (frame_overrun && current_frame >= target_frame &&
-           ((current_frame - target_frame) < DSTS_SOFFN_LIMIT / 2))
+           ((current_frame - target_frame) < limit / 2))
                return true;
 
        return false;
@@ -1713,11 +1740,9 @@ static struct dwc2_hsotg_req *get_ep_head(struct dwc2_hsotg_ep *hs_ep)
  */
 static void dwc2_gadget_start_next_request(struct dwc2_hsotg_ep *hs_ep)
 {
-       u32 mask;
        struct dwc2_hsotg *hsotg = hs_ep->parent;
        int dir_in = hs_ep->dir_in;
        struct dwc2_hsotg_req *hs_req;
-       u32 epmsk_reg = dir_in ? DIEPMSK : DOEPMSK;
 
        if (!list_empty(&hs_ep->queue)) {
                hs_req = get_ep_head(hs_ep);
@@ -1733,9 +1758,6 @@ static void dwc2_gadget_start_next_request(struct dwc2_hsotg_ep *hs_ep)
        } else {
                dev_dbg(hsotg->dev, "%s: No more ISOC-OUT requests\n",
                        __func__);
-               mask = dwc2_readl(hsotg, epmsk_reg);
-               mask |= DOEPMSK_OUTTKNEPDISMSK;
-               dwc2_writel(hsotg, mask, epmsk_reg);
        }
 }
 
@@ -2306,19 +2328,6 @@ static void dwc2_hsotg_ep0_zlp(struct dwc2_hsotg *hsotg, bool dir_in)
        dwc2_hsotg_program_zlp(hsotg, hsotg->eps_out[0]);
 }
 
-static void dwc2_hsotg_change_ep_iso_parity(struct dwc2_hsotg *hsotg,
-                                           u32 epctl_reg)
-{
-       u32 ctrl;
-
-       ctrl = dwc2_readl(hsotg, epctl_reg);
-       if (ctrl & DXEPCTL_EOFRNUM)
-               ctrl |= DXEPCTL_SETEVENFR;
-       else
-               ctrl |= DXEPCTL_SETODDFR;
-       dwc2_writel(hsotg, ctrl, epctl_reg);
-}
-
 /*
  * dwc2_gadget_get_xfersize_ddma - get transferred bytes amount from desc
  * @hs_ep - The endpoint on which transfer went
@@ -2439,20 +2448,11 @@ static void dwc2_hsotg_handle_outdone(struct dwc2_hsotg *hsotg, int epnum)
                        dwc2_hsotg_ep0_zlp(hsotg, true);
        }
 
-       /*
-        * Slave mode OUT transfers do not go through XferComplete so
-        * adjust the ISOC parity here.
-        */
-       if (!using_dma(hsotg)) {
-               if (hs_ep->isochronous && hs_ep->interval == 1)
-                       dwc2_hsotg_change_ep_iso_parity(hsotg, DOEPCTL(epnum));
-               else if (hs_ep->isochronous && hs_ep->interval > 1)
-                       dwc2_gadget_incr_frame_num(hs_ep);
-       }
-
        /* Set actual frame number for completed transfers */
-       if (!using_desc_dma(hsotg) && hs_ep->isochronous)
-               req->frame_number = hsotg->frame_number;
+       if (!using_desc_dma(hsotg) && hs_ep->isochronous) {
+               req->frame_number = hs_ep->target_frame;
+               dwc2_gadget_incr_frame_num(hs_ep);
+       }
 
        dwc2_hsotg_complete_request(hsotg, hs_ep, hs_req, result);
 }
@@ -2766,6 +2766,12 @@ static void dwc2_hsotg_complete_in(struct dwc2_hsotg *hsotg,
                return;
        }
 
+       /* Set actual frame number for completed transfers */
+       if (!using_desc_dma(hsotg) && hs_ep->isochronous) {
+               hs_req->req.frame_number = hs_ep->target_frame;
+               dwc2_gadget_incr_frame_num(hs_ep);
+       }
+
        dwc2_hsotg_complete_request(hsotg, hs_ep, hs_req, 0);
 }
 
@@ -2826,23 +2832,18 @@ static void dwc2_gadget_handle_ep_disabled(struct dwc2_hsotg_ep *hs_ep)
 
                dwc2_hsotg_txfifo_flush(hsotg, hs_ep->fifo_index);
 
-               if (hs_ep->isochronous) {
-                       dwc2_hsotg_complete_in(hsotg, hs_ep);
-                       return;
-               }
-
                if ((epctl & DXEPCTL_STALL) && (epctl & DXEPCTL_EPTYPE_BULK)) {
                        int dctl = dwc2_readl(hsotg, DCTL);
 
                        dctl |= DCTL_CGNPINNAK;
                        dwc2_writel(hsotg, dctl, DCTL);
                }
-               return;
-       }
+       } else {
 
-       if (dctl & DCTL_GOUTNAKSTS) {
-               dctl |= DCTL_CGOUTNAK;
-               dwc2_writel(hsotg, dctl, DCTL);
+               if (dctl & DCTL_GOUTNAKSTS) {
+                       dctl |= DCTL_CGOUTNAK;
+                       dwc2_writel(hsotg, dctl, DCTL);
+               }
        }
 
        if (!hs_ep->isochronous)
@@ -2863,8 +2864,6 @@ static void dwc2_gadget_handle_ep_disabled(struct dwc2_hsotg_ep *hs_ep)
                /* Update current frame number value. */
                hsotg->frame_number = dwc2_hsotg_read_frameno(hsotg);
        } while (dwc2_gadget_target_frame_elapsed(hs_ep));
-
-       dwc2_gadget_start_next_request(hs_ep);
 }
 
 /**
@@ -2881,8 +2880,8 @@ static void dwc2_gadget_handle_ep_disabled(struct dwc2_hsotg_ep *hs_ep)
 static void dwc2_gadget_handle_out_token_ep_disabled(struct dwc2_hsotg_ep *ep)
 {
        struct dwc2_hsotg *hsotg = ep->parent;
+       struct dwc2_hsotg_req *hs_req;
        int dir_in = ep->dir_in;
-       u32 doepmsk;
 
        if (dir_in || !ep->isochronous)
                return;
@@ -2896,28 +2895,39 @@ static void dwc2_gadget_handle_out_token_ep_disabled(struct dwc2_hsotg_ep *ep)
                return;
        }
 
-       if (ep->interval > 1 &&
-           ep->target_frame == TARGET_FRAME_INITIAL) {
+       if (ep->target_frame == TARGET_FRAME_INITIAL) {
                u32 ctrl;
 
                ep->target_frame = hsotg->frame_number;
-               dwc2_gadget_incr_frame_num(ep);
+               if (ep->interval > 1) {
+                       ctrl = dwc2_readl(hsotg, DOEPCTL(ep->index));
+                       if (ep->target_frame & 0x1)
+                               ctrl |= DXEPCTL_SETODDFR;
+                       else
+                               ctrl |= DXEPCTL_SETEVENFR;
 
-               ctrl = dwc2_readl(hsotg, DOEPCTL(ep->index));
-               if (ep->target_frame & 0x1)
-                       ctrl |= DXEPCTL_SETODDFR;
-               else
-                       ctrl |= DXEPCTL_SETEVENFR;
+                       dwc2_writel(hsotg, ctrl, DOEPCTL(ep->index));
+               }
+       }
+
+       while (dwc2_gadget_target_frame_elapsed(ep)) {
+               hs_req = get_ep_head(ep);
+               if (hs_req)
+                       dwc2_hsotg_complete_request(hsotg, ep, hs_req, -ENODATA);
 
-               dwc2_writel(hsotg, ctrl, DOEPCTL(ep->index));
+               dwc2_gadget_incr_frame_num(ep);
+               /* Update current frame number value. */
+               hsotg->frame_number = dwc2_hsotg_read_frameno(hsotg);
        }
 
-       dwc2_gadget_start_next_request(ep);
-       doepmsk = dwc2_readl(hsotg, DOEPMSK);
-       doepmsk &= ~DOEPMSK_OUTTKNEPDISMSK;
-       dwc2_writel(hsotg, doepmsk, DOEPMSK);
+       if (!ep->req)
+               dwc2_gadget_start_next_request(ep);
+
 }
 
+static void dwc2_hsotg_ep_stop_xfr(struct dwc2_hsotg *hsotg,
+                                  struct dwc2_hsotg_ep *hs_ep);
+
 /**
  * dwc2_gadget_handle_nak - handle NAK interrupt
  * @hs_ep: The endpoint on which interrupt is asserted.
@@ -2935,7 +2945,9 @@ static void dwc2_gadget_handle_out_token_ep_disabled(struct dwc2_hsotg_ep *ep)
 static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
 {
        struct dwc2_hsotg *hsotg = hs_ep->parent;
+       struct dwc2_hsotg_req *hs_req;
        int dir_in = hs_ep->dir_in;
+       u32 ctrl;
 
        if (!dir_in || !hs_ep->isochronous)
                return;
@@ -2977,13 +2989,29 @@ static void dwc2_gadget_handle_nak(struct dwc2_hsotg_ep *hs_ep)
 
                        dwc2_writel(hsotg, ctrl, DIEPCTL(hs_ep->index));
                }
-
-               dwc2_hsotg_complete_request(hsotg, hs_ep,
-                                           get_ep_head(hs_ep), 0);
        }
 
-       if (!using_desc_dma(hsotg))
+       if (using_desc_dma(hsotg))
+               return;
+
+       ctrl = dwc2_readl(hsotg, DIEPCTL(hs_ep->index));
+       if (ctrl & DXEPCTL_EPENA)
+               dwc2_hsotg_ep_stop_xfr(hsotg, hs_ep);
+       else
+               dwc2_hsotg_txfifo_flush(hsotg, hs_ep->fifo_index);
+
+       while (dwc2_gadget_target_frame_elapsed(hs_ep)) {
+               hs_req = get_ep_head(hs_ep);
+               if (hs_req)
+                       dwc2_hsotg_complete_request(hsotg, hs_ep, hs_req, -ENODATA);
+
                dwc2_gadget_incr_frame_num(hs_ep);
+               /* Update current frame number value. */
+               hsotg->frame_number = dwc2_hsotg_read_frameno(hsotg);
+       }
+
+       if (!hs_ep->req)
+               dwc2_gadget_start_next_request(hs_ep);
 }
 
 /**
@@ -3039,21 +3067,15 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx,
 
                /* In DDMA handle isochronous requests separately */
                if (using_desc_dma(hsotg) && hs_ep->isochronous) {
-                       /* XferCompl set along with BNA */
-                       if (!(ints & DXEPINT_BNAINTR))
-                               dwc2_gadget_complete_isoc_request_ddma(hs_ep);
+                       dwc2_gadget_complete_isoc_request_ddma(hs_ep);
                } else if (dir_in) {
                        /*
                         * We get OutDone from the FIFO, so we only
                         * need to look at completing IN requests here
                         * if operating slave mode
                         */
-                       if (hs_ep->isochronous && hs_ep->interval > 1)
-                               dwc2_gadget_incr_frame_num(hs_ep);
-
-                       dwc2_hsotg_complete_in(hsotg, hs_ep);
-                       if (ints & DXEPINT_NAKINTRPT)
-                               ints &= ~DXEPINT_NAKINTRPT;
+                       if (!hs_ep->isochronous || !(ints & DXEPINT_NAKINTRPT))
+                               dwc2_hsotg_complete_in(hsotg, hs_ep);
 
                        if (idx == 0 && !hs_ep->req)
                                dwc2_hsotg_enqueue_setup(hsotg);
@@ -3062,10 +3084,8 @@ static void dwc2_hsotg_epint(struct dwc2_hsotg *hsotg, unsigned int idx,
                         * We're using DMA, we need to fire an OutDone here
                         * as we ignore the RXFIFO.
                         */
-                       if (hs_ep->isochronous && hs_ep->interval > 1)
-                               dwc2_gadget_incr_frame_num(hs_ep);
-
-                       dwc2_hsotg_handle_outdone(hsotg, idx);
+                       if (!hs_ep->isochronous || !(ints & DXEPINT_OUTTKNEPDIS))
+                               dwc2_hsotg_handle_outdone(hsotg, idx);
                }
        }
 
@@ -4085,6 +4105,7 @@ static int dwc2_hsotg_ep_enable(struct usb_ep *ep,
                        mask |= DIEPMSK_NAKMSK;
                        dwc2_writel(hsotg, mask, DIEPMSK);
                } else {
+                       epctrl |= DXEPCTL_SNAK;
                        mask = dwc2_readl(hsotg, DOEPMSK);
                        mask |= DOEPMSK_OUTTKNEPDISMSK;
                        dwc2_writel(hsotg, mask, DOEPMSK);
index 2a78289..a215ec9 100644 (file)
@@ -5191,6 +5191,10 @@ int dwc2_hcd_init(struct dwc2_hsotg *hsotg)
        hcd->has_tt = 1;
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!res) {
+               retval = -EINVAL;
+               goto error1;
+       }
        hcd->rsrc_start = res->start;
        hcd->rsrc_len = resource_size(res);
 
index 01866dc..0104a80 100644 (file)
@@ -264,19 +264,6 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc)
 {
        u32             reg;
        int             retries = 1000;
-       int             ret;
-
-       usb_phy_init(dwc->usb2_phy);
-       usb_phy_init(dwc->usb3_phy);
-       ret = phy_init(dwc->usb2_generic_phy);
-       if (ret < 0)
-               return ret;
-
-       ret = phy_init(dwc->usb3_generic_phy);
-       if (ret < 0) {
-               phy_exit(dwc->usb2_generic_phy);
-               return ret;
-       }
 
        /*
         * We're resetting only the device side because, if we're in host mode,
@@ -310,9 +297,6 @@ static int dwc3_core_soft_reset(struct dwc3 *dwc)
                        udelay(1);
        } while (--retries);
 
-       phy_exit(dwc->usb3_generic_phy);
-       phy_exit(dwc->usb2_generic_phy);
-
        return -ETIMEDOUT;
 
 done:
@@ -982,9 +966,21 @@ static int dwc3_core_init(struct dwc3 *dwc)
                dwc->phys_ready = true;
        }
 
+       usb_phy_init(dwc->usb2_phy);
+       usb_phy_init(dwc->usb3_phy);
+       ret = phy_init(dwc->usb2_generic_phy);
+       if (ret < 0)
+               goto err0a;
+
+       ret = phy_init(dwc->usb3_generic_phy);
+       if (ret < 0) {
+               phy_exit(dwc->usb2_generic_phy);
+               goto err0a;
+       }
+
        ret = dwc3_core_soft_reset(dwc);
        if (ret)
-               goto err0a;
+               goto err1;
 
        if (hw_mode == DWC3_GHWPARAMS0_MODE_DRD &&
            !DWC3_VER_IS_WITHIN(DWC3, ANY, 194A)) {
index 804b505..4519d06 100644 (file)
@@ -4243,7 +4243,7 @@ int dwc3_gadget_init(struct dwc3 *dwc)
        }
 
 
-       usb_initialize_gadget(dwc->sysdev, dwc->gadget, dwc_gadget_release);
+       usb_initialize_gadget(dwc->dev, dwc->gadget, dwc_gadget_release);
        dev                             = &dwc->gadget->dev;
        dev->platform_data              = dwc;
        dwc->gadget->ops                = &dwc3_gadget_ops;
index 3c34995..ef55b8b 100644 (file)
@@ -406,6 +406,14 @@ static struct usb_endpoint_descriptor ss_epin_fback_desc = {
        .bInterval = 4,
 };
 
+static struct usb_ss_ep_comp_descriptor ss_epin_fback_desc_comp = {
+       .bLength                = sizeof(ss_epin_fback_desc_comp),
+       .bDescriptorType        = USB_DT_SS_ENDPOINT_COMP,
+       .bMaxBurst              = 0,
+       .bmAttributes           = 0,
+       .wBytesPerInterval      = cpu_to_le16(4),
+};
+
 
 /* Audio Streaming IN Interface - Alt0 */
 static struct usb_interface_descriptor std_as_in_if0_desc = {
@@ -597,6 +605,7 @@ static struct usb_descriptor_header *ss_audio_desc[] = {
        (struct usb_descriptor_header *)&ss_epout_desc_comp,
        (struct usb_descriptor_header *)&as_iso_out_desc,
        (struct usb_descriptor_header *)&ss_epin_fback_desc,
+       (struct usb_descriptor_header *)&ss_epin_fback_desc_comp,
 
        (struct usb_descriptor_header *)&std_as_in_if0_desc,
        (struct usb_descriptor_header *)&std_as_in_if1_desc,
@@ -665,11 +674,17 @@ static int set_ep_max_packet_size(const struct f_uac2_opts *uac2_opts,
                ssize = uac2_opts->c_ssize;
        }
 
-       if (!is_playback && (uac2_opts->c_sync == USB_ENDPOINT_SYNC_ASYNC))
+       if (!is_playback && (uac2_opts->c_sync == USB_ENDPOINT_SYNC_ASYNC)) {
+         // Win10 requires max packet size + 1 frame
                srate = srate * (1000 + uac2_opts->fb_max) / 1000;
-
-       max_size_bw = num_channels(chmask) * ssize *
-               DIV_ROUND_UP(srate, factor / (1 << (ep_desc->bInterval - 1)));
+               // updated srate is always bigger, therefore DIV_ROUND_UP always yields +1
+               max_size_bw = num_channels(chmask) * ssize *
+                       (DIV_ROUND_UP(srate, factor / (1 << (ep_desc->bInterval - 1))));
+       } else {
+               // adding 1 frame provision for Win10
+               max_size_bw = num_channels(chmask) * ssize *
+                       (DIV_ROUND_UP(srate, factor / (1 << (ep_desc->bInterval - 1))) + 1);
+       }
        ep_desc->wMaxPacketSize = cpu_to_le16(min_t(u16, max_size_bw,
                                                    max_size_ep));
 
@@ -705,6 +720,7 @@ static void setup_headers(struct f_uac2_opts *opts,
 {
        struct usb_ss_ep_comp_descriptor *epout_desc_comp = NULL;
        struct usb_ss_ep_comp_descriptor *epin_desc_comp = NULL;
+       struct usb_ss_ep_comp_descriptor *epin_fback_desc_comp = NULL;
        struct usb_endpoint_descriptor *epout_desc;
        struct usb_endpoint_descriptor *epin_desc;
        struct usb_endpoint_descriptor *epin_fback_desc;
@@ -730,6 +746,7 @@ static void setup_headers(struct f_uac2_opts *opts,
                epout_desc_comp = &ss_epout_desc_comp;
                epin_desc_comp = &ss_epin_desc_comp;
                epin_fback_desc = &ss_epin_fback_desc;
+               epin_fback_desc_comp = &ss_epin_fback_desc_comp;
                ep_int_desc = &ss_ep_int_desc;
        }
 
@@ -773,8 +790,11 @@ static void setup_headers(struct f_uac2_opts *opts,
 
                headers[i++] = USBDHDR(&as_iso_out_desc);
 
-               if (EPOUT_FBACK_IN_EN(opts))
+               if (EPOUT_FBACK_IN_EN(opts)) {
                        headers[i++] = USBDHDR(epin_fback_desc);
+                       if (epin_fback_desc_comp)
+                               headers[i++] = USBDHDR(epin_fback_desc_comp);
+               }
        }
 
        if (EPIN_EN(opts)) {
@@ -1164,6 +1184,9 @@ afunc_bind(struct usb_configuration *cfg, struct usb_function *fn)
        agdev->out_ep_maxpsize = max_t(u16, agdev->out_ep_maxpsize,
                                le16_to_cpu(ss_epout_desc.wMaxPacketSize));
 
+       ss_epin_desc_comp.wBytesPerInterval = ss_epin_desc.wMaxPacketSize;
+       ss_epout_desc_comp.wBytesPerInterval = ss_epout_desc.wMaxPacketSize;
+
        // HS and SS endpoint addresses are copied from autoconfigured FS descriptors
        hs_ep_int_desc.bEndpointAddress = fs_ep_int_desc.bEndpointAddress;
        hs_epout_desc.bEndpointAddress = fs_epout_desc.bEndpointAddress;
index 32ef228..ad16163 100644 (file)
@@ -96,11 +96,13 @@ static const struct snd_pcm_hardware uac_pcm_hardware = {
 };
 
 static void u_audio_set_fback_frequency(enum usb_device_speed speed,
+                                       struct usb_ep *out_ep,
                                        unsigned long long freq,
                                        unsigned int pitch,
                                        void *buf)
 {
        u32 ff = 0;
+       const struct usb_endpoint_descriptor *ep_desc;
 
        /*
         * Because the pitch base is 1000000, the final divider here
@@ -128,8 +130,13 @@ static void u_audio_set_fback_frequency(enum usb_device_speed speed,
                 * byte fromat (that is Q16.16)
                 *
                 * ff = (freq << 16) / 8000
+                *
+                * Win10 and OSX UAC2 drivers require number of samples per packet
+                * in order to honor the feedback value.
+                * Linux snd-usb-audio detects the applied bit-shift automatically.
                 */
-               freq <<= 4;
+               ep_desc = out_ep->desc;
+               freq <<= 4 + (ep_desc->bInterval - 1);
        }
 
        ff = DIV_ROUND_CLOSEST_ULL((freq * pitch), 1953125);
@@ -267,7 +274,7 @@ static void u_audio_iso_fback_complete(struct usb_ep *ep,
                pr_debug("%s: iso_complete status(%d) %d/%d\n",
                        __func__, status, req->actual, req->length);
 
-       u_audio_set_fback_frequency(audio_dev->gadget->speed,
+       u_audio_set_fback_frequency(audio_dev->gadget->speed, audio_dev->out_ep,
                                    params->c_srate, prm->pitch,
                                    req->buf);
 
@@ -526,7 +533,7 @@ int u_audio_start_capture(struct g_audio *audio_dev)
         * be meauserd at start of playback
         */
        prm->pitch = 1000000;
-       u_audio_set_fback_frequency(audio_dev->gadget->speed,
+       u_audio_set_fback_frequency(audio_dev->gadget->speed, ep,
                                    params->c_srate, prm->pitch,
                                    req_fback->buf);
 
index 65cae48..38e4d6b 100644 (file)
@@ -1250,7 +1250,7 @@ static void set_feature(struct r8a66597 *r8a66597, struct usb_ctrlrequest *ctrl)
                        do {
                                tmp = r8a66597_read(r8a66597, INTSTS0) & CTSQ;
                                udelay(1);
-                       } while (tmp != CS_IDST || timeout-- > 0);
+                       } while (tmp != CS_IDST && timeout-- > 0);
 
                        if (tmp == CS_IDST)
                                r8a66597_bset(r8a66597,
index 337b425..2df52f7 100644 (file)
@@ -406,12 +406,9 @@ static int bcma_hcd_probe(struct bcma_device *core)
                return -ENOMEM;
        usb_dev->core = core;
 
-       if (core->dev.of_node) {
+       if (core->dev.of_node)
                usb_dev->gpio_desc = devm_gpiod_get(&core->dev, "vcc",
                                                    GPIOD_OUT_HIGH);
-               if (IS_ERR(usb_dev->gpio_desc))
-                       return PTR_ERR(usb_dev->gpio_desc);
-       }
 
        switch (core->id.id) {
        case BCMA_CORE_USB20_HOST:
index 6bdc6d6..1776c05 100644 (file)
@@ -26,6 +26,7 @@
 #include <linux/moduleparam.h>
 #include <linux/dma-mapping.h>
 #include <linux/debugfs.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 
 #include <asm/byteorder.h>
@@ -1278,29 +1279,39 @@ MODULE_LICENSE ("GPL");
 
 #ifdef CONFIG_USB_EHCI_SH
 #include "ehci-sh.c"
-#define PLATFORM_DRIVER                ehci_hcd_sh_driver
 #endif
 
 #ifdef CONFIG_PPC_PS3
 #include "ehci-ps3.c"
-#define        PS3_SYSTEM_BUS_DRIVER   ps3_ehci_driver
 #endif
 
 #ifdef CONFIG_USB_EHCI_HCD_PPC_OF
 #include "ehci-ppc-of.c"
-#define OF_PLATFORM_DRIVER     ehci_hcd_ppc_of_driver
 #endif
 
 #ifdef CONFIG_XPS_USB_HCD_XILINX
 #include "ehci-xilinx-of.c"
-#define XILINX_OF_PLATFORM_DRIVER      ehci_hcd_xilinx_of_driver
 #endif
 
 #ifdef CONFIG_SPARC_LEON
 #include "ehci-grlib.c"
-#define PLATFORM_DRIVER                ehci_grlib_driver
 #endif
 
+static struct platform_driver * const platform_drivers[] = {
+#ifdef CONFIG_USB_EHCI_SH
+       &ehci_hcd_sh_driver,
+#endif
+#ifdef CONFIG_USB_EHCI_HCD_PPC_OF
+       &ehci_hcd_ppc_of_driver,
+#endif
+#ifdef CONFIG_XPS_USB_HCD_XILINX
+       &ehci_hcd_xilinx_of_driver,
+#endif
+#ifdef CONFIG_SPARC_LEON
+       &ehci_grlib_driver,
+#endif
+};
+
 static int __init ehci_hcd_init(void)
 {
        int retval = 0;
@@ -1324,47 +1335,23 @@ static int __init ehci_hcd_init(void)
        ehci_debug_root = debugfs_create_dir("ehci", usb_debug_root);
 #endif
 
-#ifdef PLATFORM_DRIVER
-       retval = platform_driver_register(&PLATFORM_DRIVER);
+       retval = platform_register_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
        if (retval < 0)
                goto clean0;
-#endif
-
-#ifdef PS3_SYSTEM_BUS_DRIVER
-       retval = ps3_ehci_driver_register(&PS3_SYSTEM_BUS_DRIVER);
-       if (retval < 0)
-               goto clean2;
-#endif
 
-#ifdef OF_PLATFORM_DRIVER
-       retval = platform_driver_register(&OF_PLATFORM_DRIVER);
+#ifdef CONFIG_PPC_PS3
+       retval = ps3_ehci_driver_register(&ps3_ehci_driver);
        if (retval < 0)
-               goto clean3;
+               goto clean1;
 #endif
 
-#ifdef XILINX_OF_PLATFORM_DRIVER
-       retval = platform_driver_register(&XILINX_OF_PLATFORM_DRIVER);
-       if (retval < 0)
-               goto clean4;
-#endif
-       return retval;
+       return 0;
 
-#ifdef XILINX_OF_PLATFORM_DRIVER
-       /* platform_driver_unregister(&XILINX_OF_PLATFORM_DRIVER); */
-clean4:
-#endif
-#ifdef OF_PLATFORM_DRIVER
-       platform_driver_unregister(&OF_PLATFORM_DRIVER);
-clean3:
-#endif
-#ifdef PS3_SYSTEM_BUS_DRIVER
-       ps3_ehci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER);
-clean2:
+#ifdef CONFIG_PPC_PS3
+clean1:
 #endif
-#ifdef PLATFORM_DRIVER
-       platform_driver_unregister(&PLATFORM_DRIVER);
+       platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
 clean0:
-#endif
 #ifdef CONFIG_DYNAMIC_DEBUG
        debugfs_remove(ehci_debug_root);
        ehci_debug_root = NULL;
@@ -1376,18 +1363,10 @@ module_init(ehci_hcd_init);
 
 static void __exit ehci_hcd_cleanup(void)
 {
-#ifdef XILINX_OF_PLATFORM_DRIVER
-       platform_driver_unregister(&XILINX_OF_PLATFORM_DRIVER);
-#endif
-#ifdef OF_PLATFORM_DRIVER
-       platform_driver_unregister(&OF_PLATFORM_DRIVER);
-#endif
-#ifdef PLATFORM_DRIVER
-       platform_driver_unregister(&PLATFORM_DRIVER);
-#endif
-#ifdef PS3_SYSTEM_BUS_DRIVER
-       ps3_ehci_driver_unregister(&PS3_SYSTEM_BUS_DRIVER);
+#ifdef CONFIG_PPC_PS3
+       ps3_ehci_driver_unregister(&ps3_ehci_driver);
 #endif
+       platform_unregister_drivers(platform_drivers, ARRAY_SIZE(platform_drivers));
 #ifdef CONFIG_DYNAMIC_DEBUG
        debugfs_remove(ehci_debug_root);
 #endif
index 0b37227..ded9738 100644 (file)
 #include <mach/usb.h>
 
 
-/* OMAP-1510 OHCI has its own MMU for DMA */
-#define OMAP1510_LB_MEMSIZE    32      /* Should be same as SDRAM size */
-#define OMAP1510_LB_CLOCK_DIV  0xfffec10c
-#define OMAP1510_LB_MMU_CTL    0xfffec208
-#define OMAP1510_LB_MMU_LCK    0xfffec224
-#define OMAP1510_LB_MMU_LD_TLB 0xfffec228
-#define OMAP1510_LB_MMU_CAM_H  0xfffec22c
-#define OMAP1510_LB_MMU_CAM_L  0xfffec230
-#define OMAP1510_LB_MMU_RAM_H  0xfffec234
-#define OMAP1510_LB_MMU_RAM_L  0xfffec238
-
 #define DRIVER_DESC "OHCI OMAP driver"
 
 struct ohci_omap_priv {
@@ -104,61 +93,6 @@ static int omap_ohci_transceiver_power(struct ohci_omap_priv *priv, int on)
        return 0;
 }
 
-#ifdef CONFIG_ARCH_OMAP15XX
-/*
- * OMAP-1510 specific Local Bus clock on/off
- */
-static int omap_1510_local_bus_power(int on)
-{
-       if (on) {
-               omap_writel((1 << 1) | (1 << 0), OMAP1510_LB_MMU_CTL);
-               udelay(200);
-       } else {
-               omap_writel(0, OMAP1510_LB_MMU_CTL);
-       }
-
-       return 0;
-}
-
-/*
- * OMAP-1510 specific Local Bus initialization
- * NOTE: This assumes 32MB memory size in OMAP1510LB_MEMSIZE.
- *       See also arch/mach-omap/memory.h for __virt_to_dma() and
- *       __dma_to_virt() which need to match with the physical
- *       Local Bus address below.
- */
-static int omap_1510_local_bus_init(void)
-{
-       unsigned int tlb;
-       unsigned long lbaddr, physaddr;
-
-       omap_writel((omap_readl(OMAP1510_LB_CLOCK_DIV) & 0xfffffff8) | 0x4,
-              OMAP1510_LB_CLOCK_DIV);
-
-       /* Configure the Local Bus MMU table */
-       for (tlb = 0; tlb < OMAP1510_LB_MEMSIZE; tlb++) {
-               lbaddr = tlb * 0x00100000 + OMAP1510_LB_OFFSET;
-               physaddr = tlb * 0x00100000 + PHYS_OFFSET;
-               omap_writel((lbaddr & 0x0fffffff) >> 22, OMAP1510_LB_MMU_CAM_H);
-               omap_writel(((lbaddr & 0x003ffc00) >> 6) | 0xc,
-                      OMAP1510_LB_MMU_CAM_L);
-               omap_writel(physaddr >> 16, OMAP1510_LB_MMU_RAM_H);
-               omap_writel((physaddr & 0x0000fc00) | 0x300, OMAP1510_LB_MMU_RAM_L);
-               omap_writel(tlb << 4, OMAP1510_LB_MMU_LCK);
-               omap_writel(0x1, OMAP1510_LB_MMU_LD_TLB);
-       }
-
-       /* Enable the walking table */
-       omap_writel(omap_readl(OMAP1510_LB_MMU_CTL) | (1 << 3), OMAP1510_LB_MMU_CTL);
-       udelay(200);
-
-       return 0;
-}
-#else
-#define omap_1510_local_bus_power(x)   {}
-#define omap_1510_local_bus_init()     {}
-#endif
-
 #ifdef CONFIG_USB_OTG
 
 static void start_hnp(struct ohci_hcd *ohci)
@@ -229,10 +163,8 @@ static int ohci_omap_reset(struct usb_hcd *hcd)
 
        omap_ohci_clock_power(priv, 1);
 
-       if (cpu_is_omap15xx()) {
-               omap_1510_local_bus_power(1);
-               omap_1510_local_bus_init();
-       }
+       if (config->lb_reset)
+               config->lb_reset();
 
        ret = ohci_setup(hcd);
        if (ret < 0)
index 6e784f2..eb46e64 100644 (file)
@@ -408,40 +408,38 @@ static int xhci_dbc_tty_register_device(struct xhci_dbc *dbc)
                return -EBUSY;
 
        xhci_dbc_tty_init_port(dbc, port);
-       tty_dev = tty_port_register_device(&port->port,
-                                          dbc_tty_driver, 0, NULL);
-       if (IS_ERR(tty_dev)) {
-               ret = PTR_ERR(tty_dev);
-               goto register_fail;
-       }
 
        ret = kfifo_alloc(&port->write_fifo, DBC_WRITE_BUF_SIZE, GFP_KERNEL);
        if (ret)
-               goto buf_alloc_fail;
+               goto err_exit_port;
 
        ret = xhci_dbc_alloc_requests(dbc, BULK_IN, &port->read_pool,
                                      dbc_read_complete);
        if (ret)
-               goto request_fail;
+               goto err_free_fifo;
 
        ret = xhci_dbc_alloc_requests(dbc, BULK_OUT, &port->write_pool,
                                      dbc_write_complete);
        if (ret)
-               goto request_fail;
+               goto err_free_requests;
+
+       tty_dev = tty_port_register_device(&port->port,
+                                          dbc_tty_driver, 0, NULL);
+       if (IS_ERR(tty_dev)) {
+               ret = PTR_ERR(tty_dev);
+               goto err_free_requests;
+       }
 
        port->registered = true;
 
        return 0;
 
-request_fail:
+err_free_requests:
        xhci_dbc_free_requests(&port->read_pool);
        xhci_dbc_free_requests(&port->write_pool);
+err_free_fifo:
        kfifo_free(&port->write_fifo);
-
-buf_alloc_fail:
-       tty_unregister_device(dbc_tty_driver, 0);
-
-register_fail:
+err_exit_port:
        xhci_dbc_tty_exit_port(port);
 
        dev_err(dbc->dev, "can't register tty port, err %d\n", ret);
index 2c9f25c..2484a9d 100644 (file)
@@ -30,6 +30,7 @@
 #define PCI_VENDOR_ID_FRESCO_LOGIC     0x1b73
 #define PCI_DEVICE_ID_FRESCO_LOGIC_PDK 0x1000
 #define PCI_DEVICE_ID_FRESCO_LOGIC_FL1009      0x1009
+#define PCI_DEVICE_ID_FRESCO_LOGIC_FL1100      0x1100
 #define PCI_DEVICE_ID_FRESCO_LOGIC_FL1400      0x1400
 
 #define PCI_VENDOR_ID_ETRON            0x1b6f
@@ -113,6 +114,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
        /* Look for vendor-specific quirks */
        if (pdev->vendor == PCI_VENDOR_ID_FRESCO_LOGIC &&
                        (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK ||
+                        pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_FL1100 ||
                         pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_FL1400)) {
                if (pdev->device == PCI_DEVICE_ID_FRESCO_LOGIC_PDK &&
                                pdev->revision == 0x0) {
@@ -279,8 +281,10 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
                        pdev->device == 0x3432)
                xhci->quirks |= XHCI_BROKEN_STREAMS;
 
-       if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483)
+       if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483) {
                xhci->quirks |= XHCI_LPM_SUPPORT;
+               xhci->quirks |= XHCI_EP_CTX_BROKEN_DCS;
+       }
 
        if (pdev->vendor == PCI_VENDOR_ID_ASMEDIA &&
                pdev->device == PCI_DEVICE_ID_ASMEDIA_1042_XHCI)
index e676749..311597b 100644 (file)
@@ -366,16 +366,22 @@ static void xhci_handle_stopped_cmd_ring(struct xhci_hcd *xhci,
 /* Must be called with xhci->lock held, releases and aquires lock back */
 static int xhci_abort_cmd_ring(struct xhci_hcd *xhci, unsigned long flags)
 {
-       u64 temp_64;
+       u32 temp_32;
        int ret;
 
        xhci_dbg(xhci, "Abort command ring\n");
 
        reinit_completion(&xhci->cmd_ring_stop_completion);
 
-       temp_64 = xhci_read_64(xhci, &xhci->op_regs->cmd_ring);
-       xhci_write_64(xhci, temp_64 | CMD_RING_ABORT,
-                       &xhci->op_regs->cmd_ring);
+       /*
+        * The control bits like command stop, abort are located in lower
+        * dword of the command ring control register. Limit the write
+        * to the lower dword to avoid corrupting the command ring pointer
+        * in case if the command ring is stopped by the time upper dword
+        * is written.
+        */
+       temp_32 = readl(&xhci->op_regs->cmd_ring);
+       writel(temp_32 | CMD_RING_ABORT, &xhci->op_regs->cmd_ring);
 
        /* Section 4.6.1.2 of xHCI 1.0 spec says software should also time the
         * completion of the Command Abort operation. If CRR is not negated in 5
@@ -559,8 +565,11 @@ static int xhci_move_dequeue_past_td(struct xhci_hcd *xhci,
        struct xhci_ring *ep_ring;
        struct xhci_command *cmd;
        struct xhci_segment *new_seg;
+       struct xhci_segment *halted_seg = NULL;
        union xhci_trb *new_deq;
        int new_cycle;
+       union xhci_trb *halted_trb;
+       int index = 0;
        dma_addr_t addr;
        u64 hw_dequeue;
        bool cycle_found = false;
@@ -598,7 +607,27 @@ static int xhci_move_dequeue_past_td(struct xhci_hcd *xhci,
        hw_dequeue = xhci_get_hw_deq(xhci, dev, ep_index, stream_id);
        new_seg = ep_ring->deq_seg;
        new_deq = ep_ring->dequeue;
-       new_cycle = hw_dequeue & 0x1;
+
+       /*
+        * Quirk: xHC write-back of the DCS field in the hardware dequeue
+        * pointer is wrong - use the cycle state of the TRB pointed to by
+        * the dequeue pointer.
+        */
+       if (xhci->quirks & XHCI_EP_CTX_BROKEN_DCS &&
+           !(ep->ep_state & EP_HAS_STREAMS))
+               halted_seg = trb_in_td(xhci, td->start_seg,
+                                      td->first_trb, td->last_trb,
+                                      hw_dequeue & ~0xf, false);
+       if (halted_seg) {
+               index = ((dma_addr_t)(hw_dequeue & ~0xf) - halted_seg->dma) /
+                        sizeof(*halted_trb);
+               halted_trb = &halted_seg->trbs[index];
+               new_cycle = halted_trb->generic.field[3] & 0x1;
+               xhci_dbg(xhci, "Endpoint DCS = %d TRB index = %d cycle = %d\n",
+                        (u8)(hw_dequeue & 0x1), index, new_cycle);
+       } else {
+               new_cycle = hw_dequeue & 0x1;
+       }
 
        /*
         * We want to find the pointer, segment and cycle state of the new trb
index 575fa89..1bf494b 100644 (file)
@@ -1787,7 +1787,6 @@ static int tegra_xusb_remove(struct platform_device *pdev)
        return 0;
 }
 
-#if IS_ENABLED(CONFIG_PM) || IS_ENABLED(CONFIG_PM_SLEEP)
 static bool xhci_hub_ports_suspended(struct xhci_hub *hub)
 {
        struct device *dev = hub->hcd->self.controller;
@@ -2102,7 +2101,7 @@ out:
        return err;
 }
 
-static int tegra_xusb_suspend(struct device *dev)
+static __maybe_unused int tegra_xusb_suspend(struct device *dev)
 {
        struct tegra_xusb *tegra = dev_get_drvdata(dev);
        int err;
@@ -2144,7 +2143,7 @@ out:
        return err;
 }
 
-static int tegra_xusb_resume(struct device *dev)
+static __maybe_unused int tegra_xusb_resume(struct device *dev)
 {
        struct tegra_xusb *tegra = dev_get_drvdata(dev);
        int err;
@@ -2174,10 +2173,8 @@ static int tegra_xusb_resume(struct device *dev)
 
        return 0;
 }
-#endif
 
-#ifdef CONFIG_PM
-static int tegra_xusb_runtime_suspend(struct device *dev)
+static __maybe_unused int tegra_xusb_runtime_suspend(struct device *dev)
 {
        struct tegra_xusb *tegra = dev_get_drvdata(dev);
        int ret;
@@ -2190,7 +2187,7 @@ static int tegra_xusb_runtime_suspend(struct device *dev)
        return ret;
 }
 
-static int tegra_xusb_runtime_resume(struct device *dev)
+static __maybe_unused int tegra_xusb_runtime_resume(struct device *dev)
 {
        struct tegra_xusb *tegra = dev_get_drvdata(dev);
        int err;
@@ -2201,7 +2198,6 @@ static int tegra_xusb_runtime_resume(struct device *dev)
 
        return err;
 }
-#endif
 
 static const struct dev_pm_ops tegra_xusb_pm_ops = {
        SET_RUNTIME_PM_OPS(tegra_xusb_runtime_suspend,
index f3dabd0..541fe4d 100644 (file)
@@ -692,6 +692,7 @@ int xhci_run(struct usb_hcd *hcd)
                if (ret)
                        xhci_free_command(xhci, command);
        }
+       set_bit(HCD_FLAG_DEFER_RH_REGISTER, &hcd->flags);
        xhci_dbg_trace(xhci, trace_xhci_dbg_init,
                        "Finished xhci_run for USB2 roothub");
 
@@ -3213,10 +3214,13 @@ static void xhci_endpoint_reset(struct usb_hcd *hcd,
                return;
 
        /* Bail out if toggle is already being cleared by a endpoint reset */
+       spin_lock_irqsave(&xhci->lock, flags);
        if (ep->ep_state & EP_HARD_CLEAR_TOGGLE) {
                ep->ep_state &= ~EP_HARD_CLEAR_TOGGLE;
+               spin_unlock_irqrestore(&xhci->lock, flags);
                return;
        }
+       spin_unlock_irqrestore(&xhci->lock, flags);
        /* Only interrupt and bulk ep's use data toggle, USB2 spec 5.5.4-> */
        if (usb_endpoint_xfer_control(&host_ep->desc) ||
            usb_endpoint_xfer_isoc(&host_ep->desc))
@@ -3302,8 +3306,10 @@ static void xhci_endpoint_reset(struct usb_hcd *hcd,
        xhci_free_command(xhci, cfg_cmd);
 cleanup:
        xhci_free_command(xhci, stop_cmd);
+       spin_lock_irqsave(&xhci->lock, flags);
        if (ep->ep_state & EP_SOFT_CLEAR_TOGGLE)
                ep->ep_state &= ~EP_SOFT_CLEAR_TOGGLE;
+       spin_unlock_irqrestore(&xhci->lock, flags);
 }
 
 static int xhci_check_streams_endpoint(struct xhci_hcd *xhci,
index dca6181..5a75fe5 100644 (file)
@@ -1899,6 +1899,7 @@ struct xhci_hcd {
 #define XHCI_SG_TRB_CACHE_SIZE_QUIRK   BIT_ULL(39)
 #define XHCI_NO_SOFT_RETRY     BIT_ULL(40)
 #define XHCI_BROKEN_D3COLD     BIT_ULL(41)
+#define XHCI_EP_CTX_BROKEN_DCS BIT_ULL(42)
 
        unsigned int            num_active_eps;
        unsigned int            limit_active_eps;
index ce9fc46..b593583 100644 (file)
@@ -899,11 +899,13 @@ static int dsps_probe(struct platform_device *pdev)
        if (usb_get_dr_mode(&pdev->dev) == USB_DR_MODE_PERIPHERAL) {
                ret = dsps_setup_optional_vbus_irq(pdev, glue);
                if (ret)
-                       goto err;
+                       goto unregister_pdev;
        }
 
        return 0;
 
+unregister_pdev:
+       platform_device_unregister(glue->musb);
 err:
        pm_runtime_disable(&pdev->dev);
        iounmap(glue->usbss_base);
index c429376..c968ecd 100644 (file)
@@ -190,6 +190,7 @@ tusb_fifo_write_unaligned(void __iomem *fifo, const u8 *buf, u16 len)
        }
        if (len > 0) {
                /* Write the rest 1 - 3 bytes to FIFO */
+               val = 0;
                memcpy(&val, buf, len);
                musb_writel(fifo, 0, val);
        }
index 66a6ac5..1892798 100644 (file)
@@ -233,6 +233,7 @@ static const struct usb_device_id id_table[] = {
        { USB_DEVICE(0x1FB9, 0x0602) }, /* Lake Shore Model 648 Magnet Power Supply */
        { USB_DEVICE(0x1FB9, 0x0700) }, /* Lake Shore Model 737 VSM Controller */
        { USB_DEVICE(0x1FB9, 0x0701) }, /* Lake Shore Model 776 Hall Matrix */
+       { USB_DEVICE(0x2184, 0x0030) }, /* GW Instek GDM-834x Digital Multimeter */
        { USB_DEVICE(0x2626, 0xEA60) }, /* Aruba Networks 7xxx USB Serial Console */
        { USB_DEVICE(0x3195, 0xF190) }, /* Link Instruments MSO-19 */
        { USB_DEVICE(0x3195, 0xF280) }, /* Link Instruments MSO-28 */
@@ -258,6 +259,7 @@ struct cp210x_serial_private {
        speed_t                 max_speed;
        bool                    use_actual_rate;
        bool                    no_flow_control;
+       bool                    no_event_mode;
 };
 
 enum cp210x_event_state {
@@ -1113,12 +1115,16 @@ static void cp210x_change_speed(struct tty_struct *tty,
 
 static void cp210x_enable_event_mode(struct usb_serial_port *port)
 {
+       struct cp210x_serial_private *priv = usb_get_serial_data(port->serial);
        struct cp210x_port_private *port_priv = usb_get_serial_port_data(port);
        int ret;
 
        if (port_priv->event_mode)
                return;
 
+       if (priv->no_event_mode)
+               return;
+
        port_priv->event_state = ES_DATA;
        port_priv->event_mode = true;
 
@@ -2074,6 +2080,33 @@ static void cp210x_init_max_speed(struct usb_serial *serial)
        priv->use_actual_rate = use_actual_rate;
 }
 
+static void cp2102_determine_quirks(struct usb_serial *serial)
+{
+       struct cp210x_serial_private *priv = usb_get_serial_data(serial);
+       u8 *buf;
+       int ret;
+
+       buf = kmalloc(2, GFP_KERNEL);
+       if (!buf)
+               return;
+       /*
+        * Some (possibly counterfeit) CP2102 do not support event-insertion
+        * mode and respond differently to malformed vendor requests.
+        * Specifically, they return one instead of two bytes when sent a
+        * two-byte part-number request.
+        */
+       ret = usb_control_msg(serial->dev, usb_rcvctrlpipe(serial->dev, 0),
+                       CP210X_VENDOR_SPECIFIC, REQTYPE_DEVICE_TO_HOST,
+                       CP210X_GET_PARTNUM, 0, buf, 2, USB_CTRL_GET_TIMEOUT);
+       if (ret == 1) {
+               dev_dbg(&serial->interface->dev,
+                               "device does not support event-insertion mode\n");
+               priv->no_event_mode = true;
+       }
+
+       kfree(buf);
+}
+
 static int cp210x_get_fw_version(struct usb_serial *serial, u16 value)
 {
        struct cp210x_serial_private *priv = usb_get_serial_data(serial);
@@ -2108,7 +2141,12 @@ static void cp210x_determine_type(struct usb_serial *serial)
                return;
        }
 
+       dev_dbg(&serial->interface->dev, "partnum = 0x%02x\n", priv->partnum);
+
        switch (priv->partnum) {
+       case CP210X_PARTNUM_CP2102:
+               cp2102_determine_quirks(serial);
+               break;
        case CP210X_PARTNUM_CP2105:
        case CP210X_PARTNUM_CP2108:
                cp210x_get_fw_version(serial, CP210X_GET_FW_VER);
index d7fe33c..925067a 100644 (file)
 #define BANDB_DEVICE_ID_USOPTL4_2P       0xBC02
 #define BANDB_DEVICE_ID_USOPTL4_4        0xAC44
 #define BANDB_DEVICE_ID_USOPTL4_4P       0xBC03
-#define BANDB_DEVICE_ID_USOPTL2_4        0xAC24
 
 /* Interrupt Routine Defines    */
 
@@ -186,7 +185,6 @@ static const struct usb_device_id id_table[] = {
        { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_2P) },
        { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4) },
        { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL4_4P) },
-       { USB_DEVICE(USB_VENDOR_ID_BANDB, BANDB_DEVICE_ID_USOPTL2_4) },
        {}                      /* terminating entry */
 };
 MODULE_DEVICE_TABLE(usb, id_table);
index 29c765c..a484ff5 100644 (file)
@@ -246,11 +246,13 @@ static void option_instat_callback(struct urb *urb);
 /* These Quectel products use Quectel's vendor ID */
 #define QUECTEL_PRODUCT_EC21                   0x0121
 #define QUECTEL_PRODUCT_EC25                   0x0125
+#define QUECTEL_PRODUCT_EG91                   0x0191
 #define QUECTEL_PRODUCT_EG95                   0x0195
 #define QUECTEL_PRODUCT_BG96                   0x0296
 #define QUECTEL_PRODUCT_EP06                   0x0306
 #define QUECTEL_PRODUCT_EM12                   0x0512
 #define QUECTEL_PRODUCT_RM500Q                 0x0800
+#define QUECTEL_PRODUCT_EC200S_CN              0x6002
 #define QUECTEL_PRODUCT_EC200T                 0x6026
 
 #define CMOTECH_VENDOR_ID                      0x16d8
@@ -1111,6 +1113,9 @@ static const struct usb_device_id option_ids[] = {
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25, 0xff, 0xff, 0xff),
          .driver_info = NUMEP2 },
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC25, 0xff, 0, 0) },
+       { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG91, 0xff, 0xff, 0xff),
+         .driver_info = NUMEP2 },
+       { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG91, 0xff, 0, 0) },
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95, 0xff, 0xff, 0xff),
          .driver_info = NUMEP2 },
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EG95, 0xff, 0, 0) },
@@ -1128,6 +1133,7 @@ static const struct usb_device_id option_ids[] = {
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0, 0) },
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_RM500Q, 0xff, 0xff, 0x10),
          .driver_info = ZLP },
+       { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200S_CN, 0xff, 0, 0) },
        { USB_DEVICE_AND_INTERFACE_INFO(QUECTEL_VENDOR_ID, QUECTEL_PRODUCT_EC200T, 0xff, 0, 0) },
 
        { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
@@ -1205,6 +1211,14 @@ static const struct usb_device_id option_ids[] = {
          .driver_info = NCTRL(0) | RSVD(1) },
        { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1056, 0xff),    /* Telit FD980 */
          .driver_info = NCTRL(2) | RSVD(3) },
+       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1060, 0xff),    /* Telit LN920 (rmnet) */
+         .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
+       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1061, 0xff),    /* Telit LN920 (MBIM) */
+         .driver_info = NCTRL(0) | RSVD(1) },
+       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1062, 0xff),    /* Telit LN920 (RNDIS) */
+         .driver_info = NCTRL(2) | RSVD(3) },
+       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1063, 0xff),    /* Telit LN920 (ECM) */
+         .driver_info = NCTRL(0) | RSVD(1) },
        { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910),
          .driver_info = NCTRL(0) | RSVD(1) | RSVD(3) },
        { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_ME910_DUAL_MODEM),
@@ -1219,6 +1233,8 @@ static const struct usb_device_id option_ids[] = {
          .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) },
        { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1203, 0xff),    /* Telit LE910Cx (RNDIS) */
          .driver_info = NCTRL(2) | RSVD(3) },
+       { USB_DEVICE_INTERFACE_CLASS(TELIT_VENDOR_ID, 0x1204, 0xff),    /* Telit LE910Cx (MBIM) */
+         .driver_info = NCTRL(0) | RSVD(1) },
        { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE910_USBCFG4),
          .driver_info = NCTRL(0) | RSVD(1) | RSVD(2) | RSVD(3) },
        { USB_DEVICE(TELIT_VENDOR_ID, TELIT_PRODUCT_LE920),
@@ -1650,7 +1666,6 @@ static const struct usb_device_id option_ids[] = {
        { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0060, 0xff, 0xff, 0xff) },
        { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0070, 0xff, 0xff, 0xff) },
        { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0073, 0xff, 0xff, 0xff) },
-       { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0094, 0xff, 0xff, 0xff) },
        { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0130, 0xff, 0xff, 0xff),
          .driver_info = RSVD(1) },
        { USB_DEVICE_AND_INTERFACE_INFO(ZTE_VENDOR_ID, 0x0133, 0xff, 0xff, 0xff),
@@ -2068,6 +2083,8 @@ static const struct usb_device_id option_ids[] = {
          .driver_info = RSVD(0) | RSVD(1) | RSVD(6) },
        { USB_DEVICE(0x0489, 0xe0b5),                                           /* Foxconn T77W968 ESIM */
          .driver_info = RSVD(0) | RSVD(1) | RSVD(6) },
+       { USB_DEVICE_INTERFACE_CLASS(0x0489, 0xe0db, 0xff),                     /* Foxconn T99W265 MBIM */
+         .driver_info = RSVD(3) },
        { USB_DEVICE(0x1508, 0x1001),                                           /* Fibocom NL668 (IOT version) */
          .driver_info = RSVD(4) | RSVD(5) | RSVD(6) },
        { USB_DEVICE(0x2cb7, 0x0104),                                           /* Fibocom NL678 series */
index 83da823..c18bf81 100644 (file)
@@ -165,6 +165,7 @@ static const struct usb_device_id id_table[] = {
        {DEVICE_SWI(0x1199, 0x907b)},   /* Sierra Wireless EM74xx */
        {DEVICE_SWI(0x1199, 0x9090)},   /* Sierra Wireless EM7565 QDL */
        {DEVICE_SWI(0x1199, 0x9091)},   /* Sierra Wireless EM7565 */
+       {DEVICE_SWI(0x1199, 0x90d2)},   /* Sierra Wireless EM9191 QDL */
        {DEVICE_SWI(0x413c, 0x81a2)},   /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
        {DEVICE_SWI(0x413c, 0x81a3)},   /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
        {DEVICE_SWI(0x413c, 0x81a4)},   /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
index efa972b..c6b3fcf 100644 (file)
@@ -416,9 +416,16 @@ UNUSUAL_DEV(  0x04cb, 0x0100, 0x0000, 0x2210,
                USB_SC_UFI, USB_PR_DEVICE, NULL, US_FL_FIX_INQUIRY | US_FL_SINGLE_LUN),
 
 /*
- * Reported by Ondrej Zary <linux@rainbow-software.org>
+ * Reported by Ondrej Zary <linux@zary.sk>
  * The device reports one sector more and breaks when that sector is accessed
+ * Firmwares older than 2.6c (the latest one and the only that claims Linux
+ * support) have also broken tag handling
  */
+UNUSUAL_DEV(  0x04ce, 0x0002, 0x0000, 0x026b,
+               "ScanLogic",
+               "SL11R-IDE",
+               USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+               US_FL_FIX_CAPACITY | US_FL_BULK_IGNORE_TAG),
 UNUSUAL_DEV(  0x04ce, 0x0002, 0x026c, 0x026c,
                "ScanLogic",
                "SL11R-IDE",
index c35a6db..4051c8c 100644 (file)
@@ -50,7 +50,7 @@ UNUSUAL_DEV(0x059f, 0x1061, 0x0000, 0x9999,
                "LaCie",
                "Rugged USB3-FW",
                USB_SC_DEVICE, USB_PR_DEVICE, NULL,
-               US_FL_IGNORE_UAS),
+               US_FL_NO_REPORT_OPCODES | US_FL_NO_SAME),
 
 /*
  * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
index 9858716..c15eec9 100644 (file)
@@ -696,7 +696,7 @@ irqreturn_t tcpci_irq(struct tcpci *tcpci)
                tcpm_pd_receive(tcpci->port, &msg);
        }
 
-       if (status & TCPC_ALERT_EXTENDED_STATUS) {
+       if (tcpci->data->vbus_vsafe0v && (status & TCPC_ALERT_EXTENDED_STATUS)) {
                ret = regmap_read(tcpci->regmap, TCPC_EXTENDED_STATUS, &raw);
                if (!ret && (raw & TCPC_EXTENDED_STATUS_VSAFE0V))
                        tcpm_vbus_change(tcpci->port);
index a4d3720..7f2f3ff 100644 (file)
@@ -4876,6 +4876,7 @@ static void _tcpm_cc_change(struct tcpm_port *port, enum typec_cc_status cc1,
                        tcpm_set_state(port, SRC_ATTACH_WAIT, 0);
                break;
        case SRC_ATTACHED:
+       case SRC_STARTUP:
        case SRC_SEND_CAPABILITIES:
        case SRC_READY:
                if (tcpm_port_is_disconnected(port) ||
index 21b3ae2..ea4cc0a 100644 (file)
@@ -625,10 +625,6 @@ static int tps6598x_probe(struct i2c_client *client)
        if (ret < 0)
                return ret;
 
-       fwnode = device_get_named_child_node(&client->dev, "connector");
-       if (!fwnode)
-               return -ENODEV;
-
        /*
         * This fwnode has a "compatible" property, but is never populated as a
         * struct device. Instead we simply parse it to read the properties.
@@ -636,7 +632,9 @@ static int tps6598x_probe(struct i2c_client *client)
         * with existing DT files, we work around this by deleting any
         * fwnode_links to/from this fwnode.
         */
-       fw_devlink_purge_absent_suppliers(fwnode);
+       fwnode = device_get_named_child_node(&client->dev, "connector");
+       if (fwnode)
+               fw_devlink_purge_absent_suppliers(fwnode);
 
        tps->role_sw = fwnode_usb_role_switch_get(fwnode);
        if (IS_ERR(tps->role_sw)) {
index 294ba05..bd56de7 100644 (file)
@@ -1714,6 +1714,9 @@ static void mlx5_vdpa_set_vq_ready(struct vdpa_device *vdev, u16 idx, bool ready
        struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
        struct mlx5_vdpa_virtqueue *mvq;
 
+       if (!mvdev->actual_features)
+               return;
+
        if (!is_index_valid(mvdev, idx))
                return;
 
@@ -2145,6 +2148,8 @@ static void clear_vqs_ready(struct mlx5_vdpa_net *ndev)
 
        for (i = 0; i < ndev->mvdev.max_vqs; i++)
                ndev->vqs[i].ready = false;
+
+       ndev->mvdev.cvq.ready = false;
 }
 
 static void mlx5_vdpa_set_status(struct vdpa_device *vdev, u8 status)
index 29a38ec..26e3d90 100644 (file)
@@ -665,13 +665,11 @@ static void vduse_vdpa_set_config(struct vdpa_device *vdpa, unsigned int offset,
 static int vduse_vdpa_reset(struct vdpa_device *vdpa)
 {
        struct vduse_dev *dev = vdpa_to_vduse(vdpa);
-
-       if (vduse_dev_set_status(dev, 0))
-               return -EIO;
+       int ret = vduse_dev_set_status(dev, 0);
 
        vduse_dev_reset(dev);
 
-       return 0;
+       return ret;
 }
 
 static u32 vduse_vdpa_get_generation(struct vdpa_device *vdpa)
@@ -1593,8 +1591,10 @@ static int vduse_init(void)
 
        vduse_irq_wq = alloc_workqueue("vduse-irq",
                                WQ_HIGHPRI | WQ_SYSFS | WQ_UNBOUND, 0);
-       if (!vduse_irq_wq)
+       if (!vduse_irq_wq) {
+               ret = -ENOMEM;
                goto err_wq;
+       }
 
        ret = vduse_domain_init();
        if (ret)
index 68198e0..a03b5a9 100644 (file)
@@ -565,7 +565,7 @@ static bool vfio_pci_dev_below_slot(struct pci_dev *pdev, struct pci_slot *slot)
 }
 
 struct vfio_pci_walk_info {
-       int (*fn)(struct pci_dev *, void *data);
+       int (*fn)(struct pci_dev *pdev, void *data);
        void *data;
        struct pci_dev *pdev;
        bool slot;
index 3a249ee..28ef323 100644 (file)
@@ -467,7 +467,7 @@ static void vhost_tx_batch(struct vhost_net *net,
                .num = nvq->batched_xdp,
                .ptr = nvq->xdp,
        };
-       int err;
+       int i, err;
 
        if (nvq->batched_xdp == 0)
                goto signal_used;
@@ -476,6 +476,15 @@ static void vhost_tx_batch(struct vhost_net *net,
        err = sock->ops->sendmsg(sock, msghdr, 0);
        if (unlikely(err < 0)) {
                vq_err(&nvq->vq, "Fail to batch sending packets\n");
+
+               /* free pages owned by XDP; since this is an unlikely error path,
+                * keep it simple and avoid more complex bulk update for the
+                * used pages
+                */
+               for (i = 0; i < nvq->batched_xdp; ++i)
+                       put_page(virt_to_head_page(nvq->xdp[i].data));
+               nvq->batched_xdp = 0;
+               nvq->done_idx = 0;
                return;
        }
 
index f41d081..39039e0 100644 (file)
@@ -173,6 +173,10 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
        if (status != 0 && (ops->get_status(vdpa) & ~status) != 0)
                return -EINVAL;
 
+       if ((status_old & VIRTIO_CONFIG_S_DRIVER_OK) && !(status & VIRTIO_CONFIG_S_DRIVER_OK))
+               for (i = 0; i < nvqs; i++)
+                       vhost_vdpa_unsetup_vq_irq(v, i);
+
        if (status == 0) {
                ret = ops->reset(vdpa);
                if (ret)
@@ -184,10 +188,6 @@ static long vhost_vdpa_set_status(struct vhost_vdpa *v, u8 __user *statusp)
                for (i = 0; i < nvqs; i++)
                        vhost_vdpa_setup_vq_irq(v, i);
 
-       if ((status_old & VIRTIO_CONFIG_S_DRIVER_OK) && !(status & VIRTIO_CONFIG_S_DRIVER_OK))
-               for (i = 0; i < nvqs; i++)
-                       vhost_vdpa_unsetup_vq_irq(v, i);
-
        return 0;
 }
 
@@ -322,7 +322,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa *v, u32 __user *argp)
        struct eventfd_ctx *ctx;
 
        cb.callback = vhost_vdpa_config_cb;
-       cb.private = v->vdpa;
+       cb.private = v;
        if (copy_from_user(&fd, argp, sizeof(fd)))
                return  -EFAULT;
 
@@ -640,7 +640,7 @@ static int vhost_vdpa_va_map(struct vhost_vdpa *v,
        u64 offset, map_size, map_iova = iova;
        struct vdpa_map_file *map_file;
        struct vm_area_struct *vma;
-       int ret;
+       int ret = 0;
 
        mmap_read_lock(dev->mm);
 
index d33c5cd..6ed5e60 100644 (file)
@@ -582,7 +582,9 @@ config FB_HP300
 
 config FB_TGA
        tristate "TGA/SFB+ framebuffer support"
-       depends on FB && (ALPHA || TC)
+       depends on FB
+       depends on PCI || TC
+       depends on ALPHA || TC
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
@@ -2191,8 +2193,9 @@ config FB_HYPERV
          This framebuffer driver supports Microsoft Hyper-V Synthetic Video.
 
 config FB_SIMPLE
-       bool "Simple framebuffer support"
-       depends on (FB = y) && !DRM_SIMPLEDRM
+       tristate "Simple framebuffer support"
+       depends on FB
+       depends on !DRM_SIMPLEDRM
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
index c5b99a4..6b4d5a7 100644 (file)
@@ -1267,7 +1267,7 @@ static struct platform_device *gbefb_device;
 static int __init gbefb_init(void)
 {
        int ret = platform_driver_register(&gbefb_driver);
-       if (!ret) {
+       if (IS_ENABLED(CONFIG_SGI_IP32) && !ret) {
                gbefb_device = platform_device_alloc("gbefb", 0);
                if (gbefb_device) {
                        ret = platform_device_add(gbefb_device);
index 588e02f..236081a 100644 (file)
@@ -239,6 +239,17 @@ static int virtio_dev_probe(struct device *_d)
                driver_features_legacy = driver_features;
        }
 
+       /*
+        * Some devices detect legacy solely via F_VERSION_1. Write
+        * F_VERSION_1 to force LE config space accesses before FEATURES_OK for
+        * these when needed.
+        */
+       if (drv->validate && !virtio_legacy_is_little_endian()
+                         && device_features & BIT_ULL(VIRTIO_F_VERSION_1)) {
+               dev->features = BIT_ULL(VIRTIO_F_VERSION_1);
+               dev->config->finalize_features(dev);
+       }
+
        if (device_features & (1ULL << VIRTIO_F_VERSION_1))
                dev->features = driver_features & device_features;
        else
@@ -345,8 +356,13 @@ static int virtio_device_of_init(struct virtio_device *dev)
        ret = snprintf(compat, sizeof(compat), "virtio,device%x", dev->id.device);
        BUG_ON(ret >= sizeof(compat));
 
+       /*
+        * On powerpc/pseries virtio devices are PCI devices so PCI
+        * vendor/device ids play the role of the "compatible" property.
+        * Simply don't init of_node in this case.
+        */
        if (!of_device_is_compatible(np, compat)) {
-               ret = -EINVAL;
+               ret = 0;
                goto out;
        }
 
index b81fe4f..bf59fae 100644 (file)
@@ -1666,7 +1666,7 @@ config WDT_MTX1
 
 config SIBYTE_WDOG
        tristate "Sibyte SoC hardware watchdog"
-       depends on CPU_SB1 || (MIPS && COMPILE_TEST)
+       depends on CPU_SB1
        help
          Watchdog driver for the built in watchdog hardware in Sibyte
          SoC processors.  There are apparently two watchdog timers
index 5f1ce59..1b2c3ac 100644 (file)
@@ -177,6 +177,7 @@ config XEN_GRANT_DMA_ALLOC
 
 config SWIOTLB_XEN
        def_bool y
+       depends on XEN_PV || ARM || ARM64
        select DMA_OPS
        select SWIOTLB
 
@@ -214,7 +215,7 @@ config XEN_PVCALLS_FRONTEND
          implements them.
 
 config XEN_PVCALLS_BACKEND
-       bool "XEN PV Calls backend driver"
+       tristate "XEN PV Calls backend driver"
        depends on INET && XEN && XEN_BACKEND
        help
          Experimental backend for the Xen PV Calls protocol
@@ -240,7 +241,7 @@ config XEN_PRIVCMD
 
 config XEN_ACPI_PROCESSOR
        tristate "Xen ACPI processor"
-       depends on XEN && XEN_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
+       depends on XEN && XEN_PV_DOM0 && X86 && ACPI_PROCESSOR && CPU_FREQ
        default m
        help
          This ACPI processor uploads Power Management information to the Xen
@@ -258,7 +259,7 @@ config XEN_ACPI_PROCESSOR
 
 config XEN_MCE_LOG
        bool "Xen platform mcelog"
-       depends on XEN_DOM0 && X86_MCE
+       depends on XEN_PV_DOM0 && X86_MCE
        help
          Allow kernel fetching MCE error from Xen platform and
          converting it into Linux mcelog format for mcelog tools
index 671c712..3a50f09 100644 (file)
@@ -43,6 +43,8 @@
 #include <linux/sched.h>
 #include <linux/cred.h>
 #include <linux/errno.h>
+#include <linux/freezer.h>
+#include <linux/kthread.h>
 #include <linux/mm.h>
 #include <linux/memblock.h>
 #include <linux/pagemap.h>
@@ -115,7 +117,7 @@ static struct ctl_table xen_root[] = {
 #define EXTENT_ORDER (fls(XEN_PFN_PER_PAGE) - 1)
 
 /*
- * balloon_process() state:
+ * balloon_thread() state:
  *
  * BP_DONE: done or nothing to do,
  * BP_WAIT: wait to be rescheduled,
@@ -130,6 +132,8 @@ enum bp_state {
        BP_ECANCELED
 };
 
+/* Main waiting point for xen-balloon thread. */
+static DECLARE_WAIT_QUEUE_HEAD(balloon_thread_wq);
 
 static DEFINE_MUTEX(balloon_mutex);
 
@@ -144,10 +148,6 @@ static xen_pfn_t frame_list[PAGE_SIZE / sizeof(xen_pfn_t)];
 static LIST_HEAD(ballooned_pages);
 static DECLARE_WAIT_QUEUE_HEAD(balloon_wq);
 
-/* Main work function, always executed in process context. */
-static void balloon_process(struct work_struct *work);
-static DECLARE_DELAYED_WORK(balloon_worker, balloon_process);
-
 /* When ballooning out (allocating memory to return to Xen) we don't really
    want the kernel to try too hard since that can trigger the oom killer. */
 #define GFP_BALLOON \
@@ -366,7 +366,7 @@ static void xen_online_page(struct page *page, unsigned int order)
 static int xen_memory_notifier(struct notifier_block *nb, unsigned long val, void *v)
 {
        if (val == MEM_ONLINE)
-               schedule_delayed_work(&balloon_worker, 0);
+               wake_up(&balloon_thread_wq);
 
        return NOTIFY_OK;
 }
@@ -491,18 +491,52 @@ static enum bp_state decrease_reservation(unsigned long nr_pages, gfp_t gfp)
 }
 
 /*
- * As this is a work item it is guaranteed to run as a single instance only.
+ * Stop waiting if either state is BP_DONE and ballooning action is
+ * needed, or if the credit has changed while state is not BP_DONE.
+ */
+static bool balloon_thread_cond(enum bp_state state, long credit)
+{
+       if (state == BP_DONE)
+               credit = 0;
+
+       return current_credit() != credit || kthread_should_stop();
+}
+
+/*
+ * As this is a kthread it is guaranteed to run as a single instance only.
  * We may of course race updates of the target counts (which are protected
  * by the balloon lock), or with changes to the Xen hard limit, but we will
  * recover from these in time.
  */
-static void balloon_process(struct work_struct *work)
+static int balloon_thread(void *unused)
 {
        enum bp_state state = BP_DONE;
        long credit;
+       unsigned long timeout;
+
+       set_freezable();
+       for (;;) {
+               switch (state) {
+               case BP_DONE:
+               case BP_ECANCELED:
+                       timeout = 3600 * HZ;
+                       break;
+               case BP_EAGAIN:
+                       timeout = balloon_stats.schedule_delay * HZ;
+                       break;
+               case BP_WAIT:
+                       timeout = HZ;
+                       break;
+               }
+
+               credit = current_credit();
 
+               wait_event_freezable_timeout(balloon_thread_wq,
+                       balloon_thread_cond(state, credit), timeout);
+
+               if (kthread_should_stop())
+                       return 0;
 
-       do {
                mutex_lock(&balloon_mutex);
 
                credit = current_credit();
@@ -529,12 +563,7 @@ static void balloon_process(struct work_struct *work)
                mutex_unlock(&balloon_mutex);
 
                cond_resched();
-
-       } while (credit && state == BP_DONE);
-
-       /* Schedule more work if there is some still to be done. */
-       if (state == BP_EAGAIN)
-               schedule_delayed_work(&balloon_worker, balloon_stats.schedule_delay * HZ);
+       }
 }
 
 /* Resets the Xen limit, sets new target, and kicks off processing. */
@@ -542,7 +571,7 @@ void balloon_set_new_target(unsigned long target)
 {
        /* No need for lock. Not read-modify-write updates. */
        balloon_stats.target_pages = target;
-       schedule_delayed_work(&balloon_worker, 0);
+       wake_up(&balloon_thread_wq);
 }
 EXPORT_SYMBOL_GPL(balloon_set_new_target);
 
@@ -647,7 +676,7 @@ void free_xenballooned_pages(int nr_pages, struct page **pages)
 
        /* The balloon may be too large now. Shrink it if needed. */
        if (current_credit())
-               schedule_delayed_work(&balloon_worker, 0);
+               wake_up(&balloon_thread_wq);
 
        mutex_unlock(&balloon_mutex);
 }
@@ -679,6 +708,8 @@ static void __init balloon_add_region(unsigned long start_pfn,
 
 static int __init balloon_init(void)
 {
+       struct task_struct *task;
+
        if (!xen_domain())
                return -ENODEV;
 
@@ -722,6 +753,12 @@ static int __init balloon_init(void)
        }
 #endif
 
+       task = kthread_run(balloon_thread, NULL, "xen-balloon");
+       if (IS_ERR(task)) {
+               pr_err("xen-balloon thread could not be started, ballooning will not work!\n");
+               return PTR_ERR(task);
+       }
+
        /* Init the xen-balloon driver. */
        xen_balloon_init();
 
index 1e7f6b1..fec1b65 100644 (file)
@@ -381,6 +381,14 @@ static int __unmap_grant_pages(struct gntdev_grant_map *map, int offset,
                        map->unmap_ops[offset+i].handle,
                        map->unmap_ops[offset+i].status);
                map->unmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
+               if (use_ptemod) {
+                       if (map->kunmap_ops[offset+i].status)
+                               err = -EINVAL;
+                       pr_debug("kunmap handle=%u st=%d\n",
+                                map->kunmap_ops[offset+i].handle,
+                                map->kunmap_ops[offset+i].status);
+                       map->kunmap_ops[offset+i].handle = INVALID_GRANT_HANDLE;
+               }
        }
        return err;
 }
index 720a7b7..3369734 100644 (file)
@@ -257,7 +257,7 @@ static long privcmd_ioctl_mmap(struct file *file, void __user *udata)
        LIST_HEAD(pagelist);
        struct mmap_gfn_state state;
 
-       /* We only support privcmd_ioctl_mmap_batch for auto translated. */
+       /* We only support privcmd_ioctl_mmap_batch for non-auto-translated. */
        if (xen_feature(XENFEAT_auto_translated_physmap))
                return -ENOSYS;
 
@@ -420,7 +420,7 @@ static int alloc_empty_pages(struct vm_area_struct *vma, int numpgs)
        int rc;
        struct page **pages;
 
-       pages = kcalloc(numpgs, sizeof(pages[0]), GFP_KERNEL);
+       pages = kvcalloc(numpgs, sizeof(pages[0]), GFP_KERNEL);
        if (pages == NULL)
                return -ENOMEM;
 
@@ -428,7 +428,7 @@ static int alloc_empty_pages(struct vm_area_struct *vma, int numpgs)
        if (rc != 0) {
                pr_warn("%s Could not alloc %d pfns rc:%d\n", __func__,
                        numpgs, rc);
-               kfree(pages);
+               kvfree(pages);
                return -ENOMEM;
        }
        BUG_ON(vma->vm_private_data != NULL);
@@ -803,21 +803,21 @@ static long privcmd_ioctl_mmap_resource(struct file *file,
                unsigned int domid =
                        (xdata.flags & XENMEM_rsrc_acq_caller_owned) ?
                        DOMID_SELF : kdata.dom;
-               int num;
+               int num, *errs = (int *)pfns;
 
+               BUILD_BUG_ON(sizeof(*errs) > sizeof(*pfns));
                num = xen_remap_domain_mfn_array(vma,
                                                 kdata.addr & PAGE_MASK,
-                                                pfns, kdata.num, (int *)pfns,
+                                                pfns, kdata.num, errs,
                                                 vma->vm_page_prot,
-                                                domid,
-                                                vma->vm_private_data);
+                                                domid);
                if (num < 0)
                        rc = num;
                else if (num != kdata.num) {
                        unsigned int i;
 
                        for (i = 0; i < num; i++) {
-                               rc = pfns[i];
+                               rc = errs[i];
                                if (rc < 0)
                                        break;
                        }
@@ -912,7 +912,7 @@ static void privcmd_close(struct vm_area_struct *vma)
        else
                pr_crit("unable to unmap MFN range: leaking %d pages. rc=%d\n",
                        numpgs, rc);
-       kfree(pages);
+       kvfree(pages);
 }
 
 static vm_fault_t privcmd_fault(struct vm_fault *vmf)
index 643fe44..e56a5fa 100644 (file)
@@ -106,27 +106,26 @@ static int is_xen_swiotlb_buffer(struct device *dev, dma_addr_t dma_addr)
 
 static int xen_swiotlb_fixup(void *buf, unsigned long nslabs)
 {
-       int i, rc;
-       int dma_bits;
+       int rc;
+       unsigned int order = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT);
+       unsigned int i, dma_bits = order + PAGE_SHIFT;
        dma_addr_t dma_handle;
        phys_addr_t p = virt_to_phys(buf);
 
-       dma_bits = get_order(IO_TLB_SEGSIZE << IO_TLB_SHIFT) + PAGE_SHIFT;
+       BUILD_BUG_ON(IO_TLB_SEGSIZE & (IO_TLB_SEGSIZE - 1));
+       BUG_ON(nslabs % IO_TLB_SEGSIZE);
 
        i = 0;
        do {
-               int slabs = min(nslabs - i, (unsigned long)IO_TLB_SEGSIZE);
-
                do {
                        rc = xen_create_contiguous_region(
-                               p + (i << IO_TLB_SHIFT),
-                               get_order(slabs << IO_TLB_SHIFT),
+                               p + (i << IO_TLB_SHIFT), order,
                                dma_bits, &dma_handle);
                } while (rc && dma_bits++ < MAX_DMA_BITS);
                if (rc)
                        return rc;
 
-               i += slabs;
+               i += IO_TLB_SEGSIZE;
        } while (i < nslabs);
        return 0;
 }
@@ -153,9 +152,7 @@ static const char *xen_swiotlb_error(enum xen_swiotlb_err err)
        return "";
 }
 
-#define DEFAULT_NSLABS         ALIGN(SZ_64M >> IO_TLB_SHIFT, IO_TLB_SEGSIZE)
-
-int __ref xen_swiotlb_init(void)
+int xen_swiotlb_init(void)
 {
        enum xen_swiotlb_err m_ret = XEN_SWIOTLB_UNKNOWN;
        unsigned long bytes = swiotlb_size_or_default();
@@ -185,7 +182,7 @@ retry:
                order--;
        }
        if (!start)
-               goto error;
+               goto exit;
        if (order != get_order(bytes)) {
                pr_warn("Warning: only able to allocate %ld MB for software IO TLB\n",
                        (PAGE_SIZE << order) >> 20);
@@ -208,15 +205,15 @@ retry:
        swiotlb_set_max_segment(PAGE_SIZE);
        return 0;
 error:
-       if (repeat--) {
+       if (nslabs > 1024 && repeat--) {
                /* Min is 2MB */
-               nslabs = max(1024UL, (nslabs >> 1));
-               pr_info("Lowering to %luMB\n",
-                       (nslabs << IO_TLB_SHIFT) >> 20);
+               nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
+               bytes = nslabs << IO_TLB_SHIFT;
+               pr_info("Lowering to %luMB\n", bytes >> 20);
                goto retry;
        }
+exit:
        pr_err("%s (rc:%d)\n", xen_swiotlb_error(m_ret), rc);
-       free_pages((unsigned long)start, order);
        return rc;
 }
 
@@ -233,10 +230,11 @@ retry:
        /*
         * Get IO TLB memory from any location.
         */
-       start = memblock_alloc(PAGE_ALIGN(bytes), PAGE_SIZE);
+       start = memblock_alloc(PAGE_ALIGN(bytes),
+                              IO_TLB_SEGSIZE << IO_TLB_SHIFT);
        if (!start)
-               panic("%s: Failed to allocate %lu bytes align=0x%lx\n",
-                     __func__, PAGE_ALIGN(bytes), PAGE_SIZE);
+               panic("%s: Failed to allocate %lu bytes\n",
+                     __func__, PAGE_ALIGN(bytes));
 
        /*
         * And replace that memory with pages under 4GB.
@@ -244,9 +242,9 @@ retry:
        rc = xen_swiotlb_fixup(start, nslabs);
        if (rc) {
                memblock_free(__pa(start), PAGE_ALIGN(bytes));
-               if (repeat--) {
+               if (nslabs > 1024 && repeat--) {
                        /* Min is 2MB */
-                       nslabs = max(1024UL, (nslabs >> 1));
+                       nslabs = max(1024UL, ALIGN(nslabs >> 1, IO_TLB_SEGSIZE));
                        bytes = nslabs << IO_TLB_SHIFT;
                        pr_info("Lowering to %luMB\n", bytes >> 20);
                        goto retry;
@@ -254,7 +252,7 @@ retry:
                panic("%s (rc:%d)", xen_swiotlb_error(XEN_SWIOTLB_EFIXUP), rc);
        }
 
-       if (swiotlb_init_with_tbl(start, nslabs, false))
+       if (swiotlb_init_with_tbl(start, nslabs, true))
                panic("Cannot allocate SWIOTLB buffer");
        swiotlb_set_max_segment(PAGE_SIZE);
 }
index eb2151f..1769a44 100644 (file)
@@ -23,7 +23,7 @@ struct fscache_netfs v9fs_cache_netfs = {
        .version        = 0,
 };
 
-/**
+/*
  * v9fs_random_cachetag - Generate a random tag to be associated
  *                       with a new cache session.
  *
@@ -233,7 +233,7 @@ static void v9fs_vfs_readpage_complete(struct page *page, void *data,
        unlock_page(page);
 }
 
-/**
+/*
  * __v9fs_readpage_from_fscache - read a page from cache
  *
  * Returns 0 if the pages are in cache and a BIO is submitted,
@@ -268,7 +268,7 @@ int __v9fs_readpage_from_fscache(struct inode *inode, struct page *page)
        }
 }
 
-/**
+/*
  * __v9fs_readpages_from_fscache - read multiple pages from cache
  *
  * Returns 0 if the pages are in cache and a BIO is submitted,
@@ -308,7 +308,7 @@ int __v9fs_readpages_from_fscache(struct inode *inode,
        }
 }
 
-/**
+/*
  * __v9fs_readpage_to_fscache - write a page to the cache
  *
  */
index 9d9de62..b8863dd 100644 (file)
 #include "v9fs_vfs.h"
 #include "fid.h"
 
+static inline void __add_fid(struct dentry *dentry, struct p9_fid *fid)
+{
+       hlist_add_head(&fid->dlist, (struct hlist_head *)&dentry->d_fsdata);
+}
+
+
 /**
  * v9fs_fid_add - add a fid to a dentry
  * @dentry: dentry that the fid is being added to
  * @fid: fid to add
  *
  */
-
-static inline void __add_fid(struct dentry *dentry, struct p9_fid *fid)
-{
-       hlist_add_head(&fid->dlist, (struct hlist_head *)&dentry->d_fsdata);
-}
-
 void v9fs_fid_add(struct dentry *dentry, struct p9_fid *fid)
 {
        spin_lock(&dentry->d_lock);
@@ -67,7 +67,7 @@ static struct p9_fid *v9fs_fid_find_inode(struct inode *inode, kuid_t uid)
 
 /**
  * v9fs_open_fid_add - add an open fid to an inode
- * @dentry: inode that the fid is being added to
+ * @inode: inode that the fid is being added to
  * @fid: fid to add
  *
  */
index cdb9950..2e0fa7c 100644 (file)
@@ -155,6 +155,7 @@ int v9fs_show_options(struct seq_file *m, struct dentry *root)
 /**
  * v9fs_parse_options - parse mount options into session structure
  * @v9ses: existing v9fs session information
+ * @opts: The mount option string
  *
  * Return 0 upon success, -ERRNO upon failure.
  */
@@ -542,12 +543,9 @@ extern int v9fs_error_init(void);
 static struct kobject *v9fs_kobj;
 
 #ifdef CONFIG_9P_FSCACHE
-/**
- * caches_show - list caches associated with a session
- *
- * Returns the size of buffer written.
+/*
+ * List caches associated with a session
  */
-
 static ssize_t caches_show(struct kobject *kobj,
                           struct kobj_attribute *attr,
                           char *buf)
index cce9ace..1c4f1b3 100644 (file)
@@ -30,8 +30,7 @@
 
 /**
  * v9fs_fid_readpage - read an entire page in from 9P
- *
- * @fid: fid being read
+ * @data: Opaque pointer to the fid being read
  * @page: structure to page
  *
  */
@@ -116,6 +115,8 @@ static int v9fs_vfs_readpages(struct file *filp, struct address_space *mapping,
 
 /**
  * v9fs_release_page - release the private state associated with a page
+ * @page: The page to be released
+ * @gfp: The caller's allocation restrictions
  *
  * Returns 1 if the page can be released, false otherwise.
  */
@@ -129,9 +130,9 @@ static int v9fs_release_page(struct page *page, gfp_t gfp)
 
 /**
  * v9fs_invalidate_page - Invalidate a page completely or partially
- *
- * @page: structure to page
- * @offset: offset in the page
+ * @page: The page to be invalidated
+ * @offset: offset of the invalidated region
+ * @length: length of the invalidated region
  */
 
 static void v9fs_invalidate_page(struct page *page, unsigned int offset,
@@ -199,6 +200,8 @@ static int v9fs_vfs_writepage(struct page *page, struct writeback_control *wbc)
 
 /**
  * v9fs_launder_page - Writeback a dirty page
+ * @page: The page to be cleaned up
+ *
  * Returns 0 on success.
  */
 
@@ -219,6 +222,7 @@ static int v9fs_launder_page(struct page *page)
 /**
  * v9fs_direct_IO - 9P address space operation for direct I/O
  * @iocb: target I/O control block
+ * @iter: The data/buffer to use
  *
  * The presence of v9fs_direct_IO() in the address space ops vector
  * allowes open() O_DIRECT flags which would have failed otherwise.
index aab5e65..246235e 100644 (file)
@@ -359,14 +359,11 @@ out_err:
 }
 
 /**
- * v9fs_file_read - read from a file
- * @filp: file pointer to read
- * @udata: user data buffer to read data into
- * @count: size of buffer
- * @offset: offset at which to read data
+ * v9fs_file_read_iter - read from a file
+ * @iocb: The operation parameters
+ * @to: The buffer to read into
  *
  */
-
 static ssize_t
 v9fs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
 {
@@ -388,11 +385,9 @@ v9fs_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
 }
 
 /**
- * v9fs_file_write - write to a file
- * @filp: file pointer to write
- * @data: data buffer to write data from
- * @count: size of buffer
- * @offset: offset at which to write data
+ * v9fs_file_write_iter - write to a file
+ * @iocb: The operation parameters
+ * @from: The data to write
  *
  */
 static ssize_t
@@ -561,11 +556,9 @@ out_unlock:
 }
 
 /**
- * v9fs_mmap_file_read - read from a file
- * @filp: file pointer to read
- * @data: user data buffer to read data into
- * @count: size of buffer
- * @offset: offset at which to read data
+ * v9fs_mmap_file_read_iter - read from a file
+ * @iocb: The operation parameters
+ * @to: The buffer to read into
  *
  */
 static ssize_t
@@ -576,11 +569,9 @@ v9fs_mmap_file_read_iter(struct kiocb *iocb, struct iov_iter *to)
 }
 
 /**
- * v9fs_mmap_file_write - write to a file
- * @filp: file pointer to write
- * @data: data buffer to write data from
- * @count: size of buffer
- * @offset: offset at which to write data
+ * v9fs_mmap_file_write_iter - write to a file
+ * @iocb: The operation parameters
+ * @from: The data to write
  *
  */
 static ssize_t
index 7957065..08f48b7 100644 (file)
@@ -218,7 +218,7 @@ v9fs_blank_wstat(struct p9_wstat *wstat)
 
 /**
  * v9fs_alloc_inode - helper function to allocate an inode
- *
+ * @sb: The superblock to allocate the inode from
  */
 struct inode *v9fs_alloc_inode(struct super_block *sb)
 {
@@ -238,7 +238,7 @@ struct inode *v9fs_alloc_inode(struct super_block *sb)
 
 /**
  * v9fs_free_inode - destroy an inode
- *
+ * @inode: The inode to be freed
  */
 
 void v9fs_free_inode(struct inode *inode)
@@ -343,7 +343,7 @@ error:
  * v9fs_get_inode - helper function to setup an inode
  * @sb: superblock
  * @mode: mode to setup inode with
- *
+ * @rdev: The device numbers to set
  */
 
 struct inode *v9fs_get_inode(struct super_block *sb, umode_t mode, dev_t rdev)
@@ -369,7 +369,7 @@ struct inode *v9fs_get_inode(struct super_block *sb, umode_t mode, dev_t rdev)
 }
 
 /**
- * v9fs_clear_inode - release an inode
+ * v9fs_evict_inode - Remove an inode from the inode cache
  * @inode: inode to release
  *
  */
@@ -665,14 +665,15 @@ error:
 
 /**
  * v9fs_vfs_create - VFS hook to create a regular file
+ * @mnt_userns: The user namespace of the mount
+ * @dir: The parent directory
+ * @dentry: The name of file to be created
+ * @mode: The UNIX file mode to set
+ * @excl: True if the file must not yet exist
  *
  * open(.., O_CREAT) is handled in v9fs_vfs_atomic_open().  This is only called
  * for mknod(2).
  *
- * @dir: directory inode that is being created
- * @dentry:  dentry that is being deleted
- * @mode: create permissions
- *
  */
 
 static int
@@ -696,6 +697,7 @@ v9fs_vfs_create(struct user_namespace *mnt_userns, struct inode *dir,
 
 /**
  * v9fs_vfs_mkdir - VFS mkdir hook to create a directory
+ * @mnt_userns: The user namespace of the mount
  * @dir:  inode that is being unlinked
  * @dentry: dentry that is being unlinked
  * @mode: mode for new directory
@@ -900,10 +902,12 @@ int v9fs_vfs_rmdir(struct inode *i, struct dentry *d)
 
 /**
  * v9fs_vfs_rename - VFS hook to rename an inode
+ * @mnt_userns: The user namespace of the mount
  * @old_dir:  old dir inode
  * @old_dentry: old dentry
  * @new_dir: new dir inode
  * @new_dentry: new dentry
+ * @flags: RENAME_* flags
  *
  */
 
@@ -1009,6 +1013,7 @@ done:
 
 /**
  * v9fs_vfs_getattr - retrieve file metadata
+ * @mnt_userns: The user namespace of the mount
  * @path: Object to query
  * @stat: metadata structure to populate
  * @request_mask: Mask of STATX_xxx flags indicating the caller's interests
@@ -1050,6 +1055,7 @@ v9fs_vfs_getattr(struct user_namespace *mnt_userns, const struct path *path,
 
 /**
  * v9fs_vfs_setattr - set file metadata
+ * @mnt_userns: The user namespace of the mount
  * @dentry: file whose metadata to set
  * @iattr: metadata assignment structure
  *
@@ -1285,6 +1291,7 @@ static int v9fs_vfs_mkspecial(struct inode *dir, struct dentry *dentry,
 
 /**
  * v9fs_vfs_symlink - helper function to create symlinks
+ * @mnt_userns: The user namespace of the mount
  * @dir: directory inode containing symlink
  * @dentry: dentry for symlink
  * @symname: symlink data
@@ -1340,6 +1347,7 @@ v9fs_vfs_link(struct dentry *old_dentry, struct inode *dir,
 
 /**
  * v9fs_vfs_mknod - create a special file
+ * @mnt_userns: The user namespace of the mount
  * @dir: inode destination for new link
  * @dentry: dentry for file
  * @mode: mode for creation
index e1c0240..01b9e12 100644 (file)
@@ -37,7 +37,10 @@ v9fs_vfs_mknod_dotl(struct user_namespace *mnt_userns, struct inode *dir,
                    struct dentry *dentry, umode_t omode, dev_t rdev);
 
 /**
- * v9fs_get_fsgid_for_create - Helper function to get the gid for creating a
+ * v9fs_get_fsgid_for_create - Helper function to get the gid for a new object
+ * @dir_inode: The directory inode
+ *
+ * Helper function to get the gid for creating a
  * new file system object. This checks the S_ISGID to determine the owning
  * group of the new file system object.
  */
@@ -211,12 +214,13 @@ int v9fs_open_to_dotl_flags(int flags)
 
 /**
  * v9fs_vfs_create_dotl - VFS hook to create files for 9P2000.L protocol.
+ * @mnt_userns: The user namespace of the mount
  * @dir: directory inode that is being created
  * @dentry:  dentry that is being deleted
  * @omode: create permissions
+ * @excl: True if the file must not yet exist
  *
  */
-
 static int
 v9fs_vfs_create_dotl(struct user_namespace *mnt_userns, struct inode *dir,
                     struct dentry *dentry, umode_t omode, bool excl)
@@ -361,6 +365,7 @@ err_clunk_old_fid:
 
 /**
  * v9fs_vfs_mkdir_dotl - VFS mkdir hook to create a directory
+ * @mnt_userns: The user namespace of the mount
  * @dir:  inode that is being unlinked
  * @dentry: dentry that is being unlinked
  * @omode: mode for new directory
@@ -537,6 +542,7 @@ static int v9fs_mapped_iattr_valid(int iattr_valid)
 
 /**
  * v9fs_vfs_setattr_dotl - set file metadata
+ * @mnt_userns: The user namespace of the mount
  * @dentry: file whose metadata to set
  * @iattr: metadata assignment structure
  *
@@ -816,6 +822,7 @@ v9fs_vfs_link_dotl(struct dentry *old_dentry, struct inode *dir,
 
 /**
  * v9fs_vfs_mknod_dotl - create a special file
+ * @mnt_userns: The user namespace of the mount
  * @dir: inode destination for new link
  * @dentry: dentry for file
  * @omode: mode for creation
index 7d9b23d..1b4d580 100644 (file)
 #include <linux/sched.h>
 #include "internal.h"
 
+/*
+ * Handle invalidation of an mmap'd file.  We invalidate all the PTEs referring
+ * to the pages in this file's pagecache, forcing the kernel to go through
+ * ->fault() or ->page_mkwrite() - at which point we can handle invalidation
+ * more fully.
+ */
+void afs_invalidate_mmap_work(struct work_struct *work)
+{
+       struct afs_vnode *vnode = container_of(work, struct afs_vnode, cb_work);
+
+       unmap_mapping_pages(vnode->vfs_inode.i_mapping, 0, 0, false);
+}
+
+void afs_server_init_callback_work(struct work_struct *work)
+{
+       struct afs_server *server = container_of(work, struct afs_server, initcb_work);
+       struct afs_vnode *vnode;
+       struct afs_cell *cell = server->cell;
+
+       down_read(&cell->fs_open_mmaps_lock);
+
+       list_for_each_entry(vnode, &cell->fs_open_mmaps, cb_mmap_link) {
+               if (vnode->cb_server == server) {
+                       clear_bit(AFS_VNODE_CB_PROMISED, &vnode->flags);
+                       queue_work(system_unbound_wq, &vnode->cb_work);
+               }
+       }
+
+       up_read(&cell->fs_open_mmaps_lock);
+}
+
 /*
  * Allow the fileserver to request callback state (re-)initialisation.
  * Unfortunately, UUIDs are not guaranteed unique.
@@ -29,8 +60,11 @@ void afs_init_callback_state(struct afs_server *server)
        rcu_read_lock();
        do {
                server->cb_s_break++;
-               server = rcu_dereference(server->uuid_next);
-       } while (0);
+               atomic_inc(&server->cell->fs_s_break);
+               if (!list_empty(&server->cell->fs_open_mmaps))
+                       queue_work(system_unbound_wq, &server->initcb_work);
+
+       } while ((server = rcu_dereference(server->uuid_next)));
        rcu_read_unlock();
 }
 
@@ -44,11 +78,17 @@ void __afs_break_callback(struct afs_vnode *vnode, enum afs_cb_break_reason reas
        clear_bit(AFS_VNODE_NEW_CONTENT, &vnode->flags);
        if (test_and_clear_bit(AFS_VNODE_CB_PROMISED, &vnode->flags)) {
                vnode->cb_break++;
+               vnode->cb_v_break = vnode->volume->cb_v_break;
                afs_clear_permits(vnode);
 
                if (vnode->lock_state == AFS_VNODE_LOCK_WAITING_FOR_CB)
                        afs_lock_may_be_available(vnode);
 
+               if (reason != afs_cb_break_for_deleted &&
+                   vnode->status.type == AFS_FTYPE_FILE &&
+                   atomic_read(&vnode->cb_nr_mmap))
+                       queue_work(system_unbound_wq, &vnode->cb_work);
+
                trace_afs_cb_break(&vnode->fid, vnode->cb_break, reason, true);
        } else {
                trace_afs_cb_break(&vnode->fid, vnode->cb_break, reason, false);
index 887b673..d88407f 100644 (file)
@@ -166,6 +166,8 @@ static struct afs_cell *afs_alloc_cell(struct afs_net *net,
        seqlock_init(&cell->volume_lock);
        cell->fs_servers = RB_ROOT;
        seqlock_init(&cell->fs_lock);
+       INIT_LIST_HEAD(&cell->fs_open_mmaps);
+       init_rwsem(&cell->fs_open_mmaps_lock);
        rwlock_init(&cell->vl_servers_lock);
        cell->flags = (1 << AFS_CELL_FL_CHECK_ALIAS);
 
index ac829e6..4579bbd 100644 (file)
@@ -1077,9 +1077,9 @@ static struct dentry *afs_lookup(struct inode *dir, struct dentry *dentry,
  */
 static int afs_d_revalidate_rcu(struct dentry *dentry)
 {
-       struct afs_vnode *dvnode, *vnode;
+       struct afs_vnode *dvnode;
        struct dentry *parent;
-       struct inode *dir, *inode;
+       struct inode *dir;
        long dir_version, de_version;
 
        _enter("%p", dentry);
@@ -1109,18 +1109,6 @@ static int afs_d_revalidate_rcu(struct dentry *dentry)
                        return -ECHILD;
        }
 
-       /* Check to see if the vnode referred to by the dentry still
-        * has a callback.
-        */
-       if (d_really_is_positive(dentry)) {
-               inode = d_inode_rcu(dentry);
-               if (inode) {
-                       vnode = AFS_FS_I(inode);
-                       if (!afs_check_validity(vnode))
-                               return -ECHILD;
-               }
-       }
-
        return 1; /* Still valid */
 }
 
@@ -1156,17 +1144,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)
        if (IS_ERR(key))
                key = NULL;
 
-       if (d_really_is_positive(dentry)) {
-               inode = d_inode(dentry);
-               if (inode) {
-                       vnode = AFS_FS_I(inode);
-                       afs_validate(vnode, key);
-                       if (test_bit(AFS_VNODE_DELETED, &vnode->flags))
-                               goto out_bad;
-               }
-       }
-
-       /* lock down the parent dentry so we can peer at it */
+       /* Hold the parent dentry so we can peer at it */
        parent = dget_parent(dentry);
        dir = AFS_FS_I(d_inode(parent));
 
@@ -1175,7 +1153,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)
 
        if (test_bit(AFS_VNODE_DELETED, &dir->flags)) {
                _debug("%pd: parent dir deleted", dentry);
-               goto out_bad_parent;
+               goto not_found;
        }
 
        /* We only need to invalidate a dentry if the server's copy changed
@@ -1201,12 +1179,12 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)
        case 0:
                /* the filename maps to something */
                if (d_really_is_negative(dentry))
-                       goto out_bad_parent;
+                       goto not_found;
                inode = d_inode(dentry);
                if (is_bad_inode(inode)) {
                        printk("kAFS: afs_d_revalidate: %pd2 has bad inode\n",
                               dentry);
-                       goto out_bad_parent;
+                       goto not_found;
                }
 
                vnode = AFS_FS_I(inode);
@@ -1228,9 +1206,6 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)
                               dentry, fid.unique,
                               vnode->fid.unique,
                               vnode->vfs_inode.i_generation);
-                       write_seqlock(&vnode->cb_lock);
-                       set_bit(AFS_VNODE_DELETED, &vnode->flags);
-                       write_sequnlock(&vnode->cb_lock);
                        goto not_found;
                }
                goto out_valid;
@@ -1245,7 +1220,7 @@ static int afs_d_revalidate(struct dentry *dentry, unsigned int flags)
        default:
                _debug("failed to iterate dir %pd: %d",
                       parent, ret);
-               goto out_bad_parent;
+               goto not_found;
        }
 
 out_valid:
@@ -1256,16 +1231,9 @@ out_valid_noupdate:
        _leave(" = 1 [valid]");
        return 1;
 
-       /* the dirent, if it exists, now points to a different vnode */
 not_found:
-       spin_lock(&dentry->d_lock);
-       dentry->d_flags |= DCACHE_NFSFS_RENAMED;
-       spin_unlock(&dentry->d_lock);
-
-out_bad_parent:
        _debug("dropping dentry %pd2", dentry);
        dput(parent);
-out_bad:
        key_put(key);
 
        _leave(" = 0 [bad]");
@@ -1792,6 +1760,10 @@ static int afs_link(struct dentry *from, struct inode *dir,
                goto error;
        }
 
+       ret = afs_validate(vnode, op->key);
+       if (ret < 0)
+               goto error_op;
+
        afs_op_set_vnode(op, 0, dvnode);
        afs_op_set_vnode(op, 1, vnode);
        op->file[0].dv_delta = 1;
@@ -1805,6 +1777,8 @@ static int afs_link(struct dentry *from, struct inode *dir,
        op->create.reason       = afs_edit_dir_for_link;
        return afs_do_sync_operation(op);
 
+error_op:
+       afs_put_operation(op);
 error:
        d_drop(dentry);
        _leave(" = %d", ret);
@@ -1989,6 +1963,11 @@ static int afs_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
        if (IS_ERR(op))
                return PTR_ERR(op);
 
+       ret = afs_validate(vnode, op->key);
+       op->error = ret;
+       if (ret < 0)
+               goto error;
+
        afs_op_set_vnode(op, 0, orig_dvnode);
        afs_op_set_vnode(op, 1, new_dvnode); /* May be same as orig_dvnode */
        op->file[0].dv_delta = 1;
index f4600c1..540b9fc 100644 (file)
@@ -263,7 +263,7 @@ void afs_edit_dir_add(struct afs_vnode *vnode,
                if (b == nr_blocks) {
                        _debug("init %u", b);
                        afs_edit_init_block(meta, block, b);
-                       i_size_write(&vnode->vfs_inode, (b + 1) * AFS_DIR_BLOCK_SIZE);
+                       afs_set_i_size(vnode, (b + 1) * AFS_DIR_BLOCK_SIZE);
                }
 
                /* Only lower dir pages have a counter in the header. */
@@ -296,7 +296,7 @@ void afs_edit_dir_add(struct afs_vnode *vnode,
 new_directory:
        afs_edit_init_block(meta, meta, 0);
        i_size = AFS_DIR_BLOCK_SIZE;
-       i_size_write(&vnode->vfs_inode, i_size);
+       afs_set_i_size(vnode, i_size);
        slot = AFS_DIR_RESV_BLOCKS0;
        page = page0;
        block = meta;
index dae9a57..45cfd50 100644 (file)
@@ -86,8 +86,8 @@ static int afs_do_silly_rename(struct afs_vnode *dvnode, struct afs_vnode *vnode
        return afs_do_sync_operation(op);
 }
 
-/**
- * afs_sillyrename - Perform a silly-rename of a dentry
+/*
+ * Perform silly-rename of a dentry.
  *
  * AFS is stateless and the server doesn't know when the client is holding a
  * file open.  To prevent application problems when a file is unlinked while
index db035ae..e6c447a 100644 (file)
@@ -24,12 +24,16 @@ static void afs_invalidatepage(struct page *page, unsigned int offset,
 static int afs_releasepage(struct page *page, gfp_t gfp_flags);
 
 static void afs_readahead(struct readahead_control *ractl);
+static ssize_t afs_file_read_iter(struct kiocb *iocb, struct iov_iter *iter);
+static void afs_vm_open(struct vm_area_struct *area);
+static void afs_vm_close(struct vm_area_struct *area);
+static vm_fault_t afs_vm_map_pages(struct vm_fault *vmf, pgoff_t start_pgoff, pgoff_t end_pgoff);
 
 const struct file_operations afs_file_operations = {
        .open           = afs_open,
        .release        = afs_release,
        .llseek         = generic_file_llseek,
-       .read_iter      = generic_file_read_iter,
+       .read_iter      = afs_file_read_iter,
        .write_iter     = afs_file_write,
        .mmap           = afs_file_mmap,
        .splice_read    = generic_file_splice_read,
@@ -59,8 +63,10 @@ const struct address_space_operations afs_fs_aops = {
 };
 
 static const struct vm_operations_struct afs_vm_ops = {
+       .open           = afs_vm_open,
+       .close          = afs_vm_close,
        .fault          = filemap_fault,
-       .map_pages      = filemap_map_pages,
+       .map_pages      = afs_vm_map_pages,
        .page_mkwrite   = afs_page_mkwrite,
 };
 
@@ -295,7 +301,7 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
        fsreq->subreq   = subreq;
        fsreq->pos      = subreq->start + subreq->transferred;
        fsreq->len      = subreq->len   - subreq->transferred;
-       fsreq->key      = subreq->rreq->netfs_priv;
+       fsreq->key      = key_get(subreq->rreq->netfs_priv);
        fsreq->vnode    = vnode;
        fsreq->iter     = &fsreq->def_iter;
 
@@ -304,6 +310,7 @@ static void afs_req_issue_op(struct netfs_read_subrequest *subreq)
                        fsreq->pos, fsreq->len);
 
        afs_fetch_data(fsreq->vnode, fsreq);
+       afs_put_read(fsreq);
 }
 
 static int afs_symlink_readpage(struct page *page)
@@ -490,15 +497,88 @@ static int afs_releasepage(struct page *page, gfp_t gfp_flags)
        return 1;
 }
 
+static void afs_add_open_mmap(struct afs_vnode *vnode)
+{
+       if (atomic_inc_return(&vnode->cb_nr_mmap) == 1) {
+               down_write(&vnode->volume->cell->fs_open_mmaps_lock);
+
+               list_add_tail(&vnode->cb_mmap_link,
+                             &vnode->volume->cell->fs_open_mmaps);
+
+               up_write(&vnode->volume->cell->fs_open_mmaps_lock);
+       }
+}
+
+static void afs_drop_open_mmap(struct afs_vnode *vnode)
+{
+       if (!atomic_dec_and_test(&vnode->cb_nr_mmap))
+               return;
+
+       down_write(&vnode->volume->cell->fs_open_mmaps_lock);
+
+       if (atomic_read(&vnode->cb_nr_mmap) == 0)
+               list_del_init(&vnode->cb_mmap_link);
+
+       up_write(&vnode->volume->cell->fs_open_mmaps_lock);
+       flush_work(&vnode->cb_work);
+}
+
 /*
  * Handle setting up a memory mapping on an AFS file.
  */
 static int afs_file_mmap(struct file *file, struct vm_area_struct *vma)
 {
+       struct afs_vnode *vnode = AFS_FS_I(file_inode(file));
        int ret;
 
+       afs_add_open_mmap(vnode);
+
        ret = generic_file_mmap(file, vma);
        if (ret == 0)
                vma->vm_ops = &afs_vm_ops;
+       else
+               afs_drop_open_mmap(vnode);
        return ret;
 }
+
+static void afs_vm_open(struct vm_area_struct *vma)
+{
+       afs_add_open_mmap(AFS_FS_I(file_inode(vma->vm_file)));
+}
+
+static void afs_vm_close(struct vm_area_struct *vma)
+{
+       afs_drop_open_mmap(AFS_FS_I(file_inode(vma->vm_file)));
+}
+
+static vm_fault_t afs_vm_map_pages(struct vm_fault *vmf, pgoff_t start_pgoff, pgoff_t end_pgoff)
+{
+       struct afs_vnode *vnode = AFS_FS_I(file_inode(vmf->vma->vm_file));
+       struct afs_file *af = vmf->vma->vm_file->private_data;
+
+       switch (afs_validate(vnode, af->key)) {
+       case 0:
+               return filemap_map_pages(vmf, start_pgoff, end_pgoff);
+       case -ENOMEM:
+               return VM_FAULT_OOM;
+       case -EINTR:
+       case -ERESTARTSYS:
+               return VM_FAULT_RETRY;
+       case -ESTALE:
+       default:
+               return VM_FAULT_SIGBUS;
+       }
+}
+
+static ssize_t afs_file_read_iter(struct kiocb *iocb, struct iov_iter *iter)
+{
+       struct afs_vnode *vnode = AFS_FS_I(file_inode(iocb->ki_filp));
+       struct afs_file *af = iocb->ki_filp->private_data;
+       int ret;
+
+       ret = afs_validate(vnode, af->key);
+       if (ret < 0)
+               return ret;
+
+       return generic_file_read_iter(iocb, iter);
+}
index e7e98ad..c0031a3 100644 (file)
@@ -9,6 +9,7 @@
 #include <linux/slab.h>
 #include "afs_fs.h"
 #include "internal.h"
+#include "protocol_afs.h"
 #include "protocol_yfs.h"
 
 static unsigned int afs_fs_probe_fast_poll_interval = 30 * HZ;
@@ -102,7 +103,7 @@ void afs_fileserver_probe_result(struct afs_call *call)
        struct afs_addr_list *alist = call->alist;
        struct afs_server *server = call->server;
        unsigned int index = call->addr_ix;
-       unsigned int rtt_us = 0;
+       unsigned int rtt_us = 0, cap0;
        int ret = call->error;
 
        _enter("%pU,%u", &server->uuid, index);
@@ -159,6 +160,11 @@ responded:
                        clear_bit(AFS_SERVER_FL_IS_YFS, &server->flags);
                        alist->addrs[index].srx_service = call->service_id;
                }
+               cap0 = ntohl(call->tmp);
+               if (cap0 & AFS3_VICED_CAPABILITY_64BITFILES)
+                       set_bit(AFS_SERVER_FL_HAS_FS64, &server->flags);
+               else
+                       clear_bit(AFS_SERVER_FL_HAS_FS64, &server->flags);
        }
 
        if (rxrpc_kernel_get_srtt(call->net->socket, call->rxcall, &rtt_us) &&
index dd3f45d..4943413 100644 (file)
@@ -456,9 +456,7 @@ void afs_fs_fetch_data(struct afs_operation *op)
        struct afs_read *req = op->fetch.req;
        __be32 *bp;
 
-       if (upper_32_bits(req->pos) ||
-           upper_32_bits(req->len) ||
-           upper_32_bits(req->pos + req->len))
+       if (test_bit(AFS_SERVER_FL_HAS_FS64, &op->server->flags))
                return afs_fs_fetch_data64(op);
 
        _enter("");
@@ -1113,9 +1111,7 @@ void afs_fs_store_data(struct afs_operation *op)
               (unsigned long long)op->store.pos,
               (unsigned long long)op->store.i_size);
 
-       if (upper_32_bits(op->store.pos) ||
-           upper_32_bits(op->store.size) ||
-           upper_32_bits(op->store.i_size))
+       if (test_bit(AFS_SERVER_FL_HAS_FS64, &op->server->flags))
                return afs_fs_store_data64(op);
 
        call = afs_alloc_flat_call(op->net, &afs_RXFSStoreData,
@@ -1229,7 +1225,7 @@ static void afs_fs_setattr_size(struct afs_operation *op)
               key_serial(op->key), vp->fid.vid, vp->fid.vnode);
 
        ASSERT(attr->ia_valid & ATTR_SIZE);
-       if (upper_32_bits(attr->ia_size))
+       if (test_bit(AFS_SERVER_FL_HAS_FS64, &op->server->flags))
                return afs_fs_setattr_size64(op);
 
        call = afs_alloc_flat_call(op->net, &afs_RXFSStoreData_as_Status,
@@ -1657,20 +1653,33 @@ static int afs_deliver_fs_get_capabilities(struct afs_call *call)
                        return ret;
 
                count = ntohl(call->tmp);
-
                call->count = count;
                call->count2 = count;
-               afs_extract_discard(call, count * sizeof(__be32));
+               if (count == 0) {
+                       call->unmarshall = 4;
+                       call->tmp = 0;
+                       break;
+               }
+
+               /* Extract the first word of the capabilities to call->tmp */
+               afs_extract_to_tmp(call);
                call->unmarshall++;
                fallthrough;
 
-               /* Extract capabilities words */
        case 2:
                ret = afs_extract_data(call, false);
                if (ret < 0)
                        return ret;
 
-               /* TODO: Examine capabilities */
+               afs_extract_discard(call, (count - 1) * sizeof(__be32));
+               call->unmarshall++;
+               fallthrough;
+
+               /* Extract remaining capabilities words */
+       case 3:
+               ret = afs_extract_data(call, false);
+               if (ret < 0)
+                       return ret;
 
                call->unmarshall++;
                break;
index 80b6c8d..8fcffea 100644 (file)
@@ -53,16 +53,6 @@ static noinline void dump_vnode(struct afs_vnode *vnode, struct afs_vnode *paren
                dump_stack();
 }
 
-/*
- * Set the file size and block count.  Estimate the number of 512 bytes blocks
- * used, rounded up to nearest 1K for consistency with other AFS clients.
- */
-static void afs_set_i_size(struct afs_vnode *vnode, u64 size)
-{
-       i_size_write(&vnode->vfs_inode, size);
-       vnode->vfs_inode.i_blocks = ((size + 1023) >> 10) << 1;
-}
-
 /*
  * Initialise an inode from the vnode status.
  */
@@ -587,22 +577,32 @@ static void afs_zap_data(struct afs_vnode *vnode)
 }
 
 /*
- * Get the server reinit counter for a vnode's current server.
+ * Check to see if we have a server currently serving this volume and that it
+ * hasn't been reinitialised or dropped from the list.
  */
-static bool afs_get_s_break_rcu(struct afs_vnode *vnode, unsigned int *_s_break)
+static bool afs_check_server_good(struct afs_vnode *vnode)
 {
-       struct afs_server_list *slist = rcu_dereference(vnode->volume->servers);
+       struct afs_server_list *slist;
        struct afs_server *server;
+       bool good;
        int i;
 
+       if (vnode->cb_fs_s_break == atomic_read(&vnode->volume->cell->fs_s_break))
+               return true;
+
+       rcu_read_lock();
+
+       slist = rcu_dereference(vnode->volume->servers);
        for (i = 0; i < slist->nr_servers; i++) {
                server = slist->servers[i].server;
                if (server == vnode->cb_server) {
-                       *_s_break = READ_ONCE(server->cb_s_break);
-                       return true;
+                       good = (vnode->cb_s_break == server->cb_s_break);
+                       rcu_read_unlock();
+                       return good;
                }
        }
 
+       rcu_read_unlock();
        return false;
 }
 
@@ -611,57 +611,46 @@ static bool afs_get_s_break_rcu(struct afs_vnode *vnode, unsigned int *_s_break)
  */
 bool afs_check_validity(struct afs_vnode *vnode)
 {
-       struct afs_volume *volume = vnode->volume;
        enum afs_cb_break_reason need_clear = afs_cb_break_no_break;
        time64_t now = ktime_get_real_seconds();
-       bool valid;
-       unsigned int cb_break, cb_s_break, cb_v_break;
+       unsigned int cb_break;
        int seq = 0;
 
        do {
                read_seqbegin_or_lock(&vnode->cb_lock, &seq);
-               cb_v_break = READ_ONCE(volume->cb_v_break);
                cb_break = vnode->cb_break;
 
-               if (test_bit(AFS_VNODE_CB_PROMISED, &vnode->flags) &&
-                   afs_get_s_break_rcu(vnode, &cb_s_break)) {
-                       if (vnode->cb_s_break != cb_s_break ||
-                           vnode->cb_v_break != cb_v_break) {
-                               vnode->cb_s_break = cb_s_break;
-                               vnode->cb_v_break = cb_v_break;
-                               need_clear = afs_cb_break_for_vsbreak;
-                               valid = false;
-                       } else if (test_bit(AFS_VNODE_ZAP_DATA, &vnode->flags)) {
+               if (test_bit(AFS_VNODE_CB_PROMISED, &vnode->flags)) {
+                       if (vnode->cb_v_break != vnode->volume->cb_v_break)
+                               need_clear = afs_cb_break_for_v_break;
+                       else if (!afs_check_server_good(vnode))
+                               need_clear = afs_cb_break_for_s_reinit;
+                       else if (test_bit(AFS_VNODE_ZAP_DATA, &vnode->flags))
                                need_clear = afs_cb_break_for_zap;
-                               valid = false;
-                       } else if (vnode->cb_expires_at - 10 <= now) {
+                       else if (vnode->cb_expires_at - 10 <= now)
                                need_clear = afs_cb_break_for_lapsed;
-                               valid = false;
-                       } else {
-                               valid = true;
-                       }
                } else if (test_bit(AFS_VNODE_DELETED, &vnode->flags)) {
-                       valid = true;
+                       ;
                } else {
-                       vnode->cb_v_break = cb_v_break;
-                       valid = false;
+                       need_clear = afs_cb_break_no_promise;
                }
 
        } while (need_seqretry(&vnode->cb_lock, seq));
 
        done_seqretry(&vnode->cb_lock, seq);
 
-       if (need_clear != afs_cb_break_no_break) {
-               write_seqlock(&vnode->cb_lock);
-               if (cb_break == vnode->cb_break)
-                       __afs_break_callback(vnode, need_clear);
-               else
-                       trace_afs_cb_miss(&vnode->fid, need_clear);
-               write_sequnlock(&vnode->cb_lock);
-               valid = false;
-       }
+       if (need_clear == afs_cb_break_no_break)
+               return true;
 
-       return valid;
+       write_seqlock(&vnode->cb_lock);
+       if (need_clear == afs_cb_break_no_promise)
+               vnode->cb_v_break = vnode->volume->cb_v_break;
+       else if (cb_break == vnode->cb_break)
+               __afs_break_callback(vnode, need_clear);
+       else
+               trace_afs_cb_miss(&vnode->fid, need_clear);
+       write_sequnlock(&vnode->cb_lock);
+       return false;
 }
 
 /*
@@ -675,21 +664,20 @@ bool afs_check_validity(struct afs_vnode *vnode)
  */
 int afs_validate(struct afs_vnode *vnode, struct key *key)
 {
-       bool valid;
        int ret;
 
        _enter("{v={%llx:%llu} fl=%lx},%x",
               vnode->fid.vid, vnode->fid.vnode, vnode->flags,
               key_serial(key));
 
-       rcu_read_lock();
-       valid = afs_check_validity(vnode);
-       rcu_read_unlock();
-
-       if (test_bit(AFS_VNODE_DELETED, &vnode->flags))
-               clear_nlink(&vnode->vfs_inode);
+       if (unlikely(test_bit(AFS_VNODE_DELETED, &vnode->flags))) {
+               if (vnode->vfs_inode.i_nlink)
+                       clear_nlink(&vnode->vfs_inode);
+               goto valid;
+       }
 
-       if (valid)
+       if (test_bit(AFS_VNODE_CB_PROMISED, &vnode->flags) &&
+           afs_check_validity(vnode))
                goto valid;
 
        down_write(&vnode->validate_lock);
index 5ed416f..0ad97a8 100644 (file)
@@ -390,6 +390,9 @@ struct afs_cell {
        /* Active fileserver interaction state. */
        struct rb_root          fs_servers;     /* afs_server (by server UUID) */
        seqlock_t               fs_lock;        /* For fs_servers  */
+       struct rw_semaphore     fs_open_mmaps_lock;
+       struct list_head        fs_open_mmaps;  /* List of vnodes that are mmapped */
+       atomic_t                fs_s_break;     /* Counter of CB.InitCallBackState messages */
 
        /* VL server list. */
        rwlock_t                vl_servers_lock; /* Lock on vl_servers */
@@ -503,6 +506,7 @@ struct afs_server {
        struct hlist_node       addr4_link;     /* Link in net->fs_addresses4 */
        struct hlist_node       addr6_link;     /* Link in net->fs_addresses6 */
        struct hlist_node       proc_link;      /* Link in net->fs_proc */
+       struct work_struct      initcb_work;    /* Work for CB.InitCallBackState* */
        struct afs_server       *gc_next;       /* Next server in manager's list */
        time64_t                unuse_time;     /* Time at which last unused */
        unsigned long           flags;
@@ -516,6 +520,7 @@ struct afs_server {
 #define AFS_SERVER_FL_IS_YFS   16              /* Server is YFS not AFS */
 #define AFS_SERVER_FL_NO_IBULK 17              /* Fileserver doesn't support FS.InlineBulkStatus */
 #define AFS_SERVER_FL_NO_RM2   18              /* Fileserver doesn't support YFS.RemoveFile2 */
+#define AFS_SERVER_FL_HAS_FS64 19              /* Fileserver supports FS.{Fetch,Store}Data64 */
        atomic_t                ref;            /* Object refcount */
        atomic_t                active;         /* Active user count */
        u32                     addr_version;   /* Address list version */
@@ -657,7 +662,11 @@ struct afs_vnode {
        afs_lock_type_t         lock_type : 8;
 
        /* outstanding callback notification on this file */
+       struct work_struct      cb_work;        /* Work for mmap'd files */
+       struct list_head        cb_mmap_link;   /* Link in cell->fs_open_mmaps */
        void                    *cb_server;     /* Server with callback/filelock */
+       atomic_t                cb_nr_mmap;     /* Number of mmaps */
+       unsigned int            cb_fs_s_break;  /* Mass server break counter (cell->fs_s_break) */
        unsigned int            cb_s_break;     /* Mass break counter on ->server */
        unsigned int            cb_v_break;     /* Mass break counter on ->volume */
        unsigned int            cb_break;       /* Break counter on vnode */
@@ -965,6 +974,8 @@ extern struct fscache_cookie_def afs_vnode_cache_index_def;
 /*
  * callback.c
  */
+extern void afs_invalidate_mmap_work(struct work_struct *);
+extern void afs_server_init_callback_work(struct work_struct *work);
 extern void afs_init_callback_state(struct afs_server *);
 extern void __afs_break_callback(struct afs_vnode *, enum afs_cb_break_reason);
 extern void afs_break_callback(struct afs_vnode *, enum afs_cb_break_reason);
@@ -1585,6 +1596,16 @@ static inline void afs_update_dentry_version(struct afs_operation *op,
                        (void *)(unsigned long)dir_vp->scb.status.data_version;
 }
 
+/*
+ * Set the file size and block count.  Estimate the number of 512 bytes blocks
+ * used, rounded up to nearest 1K for consistency with other AFS clients.
+ */
+static inline void afs_set_i_size(struct afs_vnode *vnode, u64 size)
+{
+       i_size_write(&vnode->vfs_inode, size);
+       vnode->vfs_inode.i_blocks = ((size + 1023) >> 10) << 1;
+}
+
 /*
  * Check for a conflicting operation on a directory that we just unlinked from.
  * If someone managed to sneak a link or an unlink in on the file we just
diff --git a/fs/afs/protocol_afs.h b/fs/afs/protocol_afs.h
new file mode 100644 (file)
index 0000000..0c39358
--- /dev/null
@@ -0,0 +1,15 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/* AFS protocol bits
+ *
+ * Copyright (C) 2021 Red Hat, Inc. All Rights Reserved.
+ * Written by David Howells (dhowells@redhat.com)
+ */
+
+
+#define AFSCAPABILITIESMAX 196 /* Maximum number of words in a capability set */
+
+/* AFS3 Fileserver capabilities word 0 */
+#define AFS3_VICED_CAPABILITY_ERRORTRANS       0x0001 /* Uses UAE errors */
+#define AFS3_VICED_CAPABILITY_64BITFILES       0x0002 /* FetchData64 & StoreData64 supported */
+#define AFS3_VICED_CAPABILITY_WRITELOCKACL     0x0004 /* Can lock a file even without lock perm */
+#define AFS3_VICED_CAPABILITY_SANEACLS         0x0008 /* ACLs reviewed for sanity - don't use */
index b5bd03b..e4cd89c 100644 (file)
@@ -168,3 +168,9 @@ enum yfs_lock_type {
        yfs_LockMandatoryWrite  = 0x101,
        yfs_LockMandatoryExtend = 0x102,
 };
+
+/* RXYFS Viced Capability Flags */
+#define YFS_VICED_CAPABILITY_ERRORTRANS                0x0001 /* Deprecated v0.195 */
+#define YFS_VICED_CAPABILITY_64BITFILES                0x0002 /* Deprecated v0.195 */
+#define YFS_VICED_CAPABILITY_WRITELOCKACL      0x0004 /* Can lock a file even without lock perm */
+#define YFS_VICED_CAPABILITY_SANEACLS          0x0008 /* Deprecated v0.195 */
index d83f13c..79e1a5f 100644 (file)
@@ -374,6 +374,7 @@ selected_server:
        if (vnode->cb_server != server) {
                vnode->cb_server = server;
                vnode->cb_s_break = server->cb_s_break;
+               vnode->cb_fs_s_break = atomic_read(&server->cell->fs_s_break);
                vnode->cb_v_break = vnode->volume->cb_v_break;
                clear_bit(AFS_VNODE_CB_PROMISED, &vnode->flags);
        }
index 684a2b0..6e5b9a1 100644 (file)
@@ -235,6 +235,7 @@ static struct afs_server *afs_alloc_server(struct afs_cell *cell,
        server->addr_version = alist->version;
        server->uuid = *uuid;
        rwlock_init(&server->fs_lock);
+       INIT_WORK(&server->initcb_work, afs_server_init_callback_work);
        init_waitqueue_head(&server->probe_wq);
        INIT_LIST_HEAD(&server->probe_link);
        spin_lock_init(&server->probe_lock);
@@ -467,6 +468,7 @@ static void afs_destroy_server(struct afs_net *net, struct afs_server *server)
        if (test_bit(AFS_SERVER_FL_MAY_HAVE_CB, &server->flags))
                afs_give_up_callbacks(net, server);
 
+       flush_work(&server->initcb_work);
        afs_put_server(net, server, afs_server_trace_destroy);
 }
 
index e38bb1e..d110def 100644 (file)
@@ -698,6 +698,7 @@ static struct inode *afs_alloc_inode(struct super_block *sb)
        vnode->lock_state       = AFS_VNODE_LOCK_NONE;
 
        init_rwsem(&vnode->rmdir_lock);
+       INIT_WORK(&vnode->cb_work, afs_invalidate_mmap_work);
 
        _leave(" = %p", &vnode->vfs_inode);
        return &vnode->vfs_inode;
index c053469..f24370f 100644 (file)
@@ -137,7 +137,7 @@ int afs_write_end(struct file *file, struct address_space *mapping,
                write_seqlock(&vnode->cb_lock);
                i_size = i_size_read(&vnode->vfs_inode);
                if (maybe_i_size > i_size)
-                       i_size_write(&vnode->vfs_inode, maybe_i_size);
+                       afs_set_i_size(vnode, maybe_i_size);
                write_sequnlock(&vnode->cb_lock);
        }
 
@@ -471,13 +471,18 @@ static void afs_extend_writeback(struct address_space *mapping,
                        }
 
                        /* Has the page moved or been split? */
-                       if (unlikely(page != xas_reload(&xas)))
+                       if (unlikely(page != xas_reload(&xas))) {
+                               put_page(page);
                                break;
+                       }
 
-                       if (!trylock_page(page))
+                       if (!trylock_page(page)) {
+                               put_page(page);
                                break;
+                       }
                        if (!PageDirty(page) || PageWriteback(page)) {
                                unlock_page(page);
+                               put_page(page);
                                break;
                        }
 
@@ -487,6 +492,7 @@ static void afs_extend_writeback(struct address_space *mapping,
                        t = afs_page_dirty_to(page, priv);
                        if (f != 0 && !new_content) {
                                unlock_page(page);
+                               put_page(page);
                                break;
                        }
 
@@ -801,6 +807,7 @@ int afs_writepages(struct address_space *mapping,
 ssize_t afs_file_write(struct kiocb *iocb, struct iov_iter *from)
 {
        struct afs_vnode *vnode = AFS_FS_I(file_inode(iocb->ki_filp));
+       struct afs_file *af = iocb->ki_filp->private_data;
        ssize_t result;
        size_t count = iov_iter_count(from);
 
@@ -816,6 +823,10 @@ ssize_t afs_file_write(struct kiocb *iocb, struct iov_iter *from)
        if (!count)
                return 0;
 
+       result = afs_validate(vnode, af->key);
+       if (result < 0)
+               return result;
+
        result = generic_file_write_iter(iocb, from);
 
        _leave(" = %zd", result);
@@ -829,13 +840,18 @@ ssize_t afs_file_write(struct kiocb *iocb, struct iov_iter *from)
  */
 int afs_fsync(struct file *file, loff_t start, loff_t end, int datasync)
 {
-       struct inode *inode = file_inode(file);
-       struct afs_vnode *vnode = AFS_FS_I(inode);
+       struct afs_vnode *vnode = AFS_FS_I(file_inode(file));
+       struct afs_file *af = file->private_data;
+       int ret;
 
        _enter("{%llx:%llu},{n=%pD},%d",
               vnode->fid.vid, vnode->fid.vnode, file,
               datasync);
 
+       ret = afs_validate(vnode, af->key);
+       if (ret < 0)
+               return ret;
+
        return file_write_and_wait_range(file, start, end);
 }
 
@@ -849,11 +865,14 @@ vm_fault_t afs_page_mkwrite(struct vm_fault *vmf)
        struct file *file = vmf->vma->vm_file;
        struct inode *inode = file_inode(file);
        struct afs_vnode *vnode = AFS_FS_I(inode);
+       struct afs_file *af = file->private_data;
        unsigned long priv;
        vm_fault_t ret = VM_FAULT_RETRY;
 
        _enter("{{%llx:%llu}},{%lx}", vnode->fid.vid, vnode->fid.vnode, page->index);
 
+       afs_validate(vnode, af->key);
+
        sb_start_pagefault(inode->i_sb);
 
        /* Wait for the page to be written to the cache before we allow it to
@@ -955,8 +974,7 @@ int afs_launder_page(struct page *page)
                iov_iter_bvec(&iter, WRITE, bv, 1, bv[0].bv_len);
 
                trace_afs_page_dirty(vnode, tracepoint_string("launder"), page);
-               ret = afs_store_data(vnode, &iter, (loff_t)page->index * PAGE_SIZE,
-                                    true);
+               ret = afs_store_data(vnode, &iter, page_offset(page) + f, true);
        }
 
        trace_afs_page_dirty(vnode, tracepoint_string("laundered"), page);
index 69d900a..a813b70 100644 (file)
@@ -630,7 +630,7 @@ static unsigned long load_elf_interp(struct elfhdr *interp_elf_ex,
 
                        vaddr = eppnt->p_vaddr;
                        if (interp_elf_ex->e_type == ET_EXEC || load_addr_set)
-                               elf_type |= MAP_FIXED_NOREPLACE;
+                               elf_type |= MAP_FIXED;
                        else if (no_base && interp_elf_ex->e_type == ET_DYN)
                                load_addr = -vaddr;
 
index dff2c8a..c0cebcf 100644 (file)
@@ -3030,7 +3030,7 @@ struct btrfs_dir_item *
 btrfs_lookup_dir_index_item(struct btrfs_trans_handle *trans,
                            struct btrfs_root *root,
                            struct btrfs_path *path, u64 dir,
-                           u64 objectid, const char *name, int name_len,
+                           u64 index, const char *name, int name_len,
                            int mod);
 struct btrfs_dir_item *
 btrfs_search_dir_index_item(struct btrfs_root *root,
index f1274d5..7721ce0 100644 (file)
@@ -190,9 +190,20 @@ static struct btrfs_dir_item *btrfs_lookup_match_dir(
 }
 
 /*
- * lookup a directory item based on name.  'dir' is the objectid
- * we're searching in, and 'mod' tells us if you plan on deleting the
- * item (use mod < 0) or changing the options (use mod > 0)
+ * Lookup for a directory item by name.
+ *
+ * @trans:     The transaction handle to use. Can be NULL if @mod is 0.
+ * @root:      The root of the target tree.
+ * @path:      Path to use for the search.
+ * @dir:       The inode number (objectid) of the directory.
+ * @name:      The name associated to the directory entry we are looking for.
+ * @name_len:  The length of the name.
+ * @mod:       Used to indicate if the tree search is meant for a read only
+ *             lookup, for a modification lookup or for a deletion lookup, so
+ *             its value should be 0, 1 or -1, respectively.
+ *
+ * Returns: NULL if the dir item does not exists, an error pointer if an error
+ * happened, or a pointer to a dir item if a dir item exists for the given name.
  */
 struct btrfs_dir_item *btrfs_lookup_dir_item(struct btrfs_trans_handle *trans,
                                             struct btrfs_root *root,
@@ -273,27 +284,42 @@ out:
 }
 
 /*
- * lookup a directory item based on index.  'dir' is the objectid
- * we're searching in, and 'mod' tells us if you plan on deleting the
- * item (use mod < 0) or changing the options (use mod > 0)
+ * Lookup for a directory index item by name and index number.
  *
- * The name is used to make sure the index really points to the name you were
- * looking for.
+ * @trans:     The transaction handle to use. Can be NULL if @mod is 0.
+ * @root:      The root of the target tree.
+ * @path:      Path to use for the search.
+ * @dir:       The inode number (objectid) of the directory.
+ * @index:     The index number.
+ * @name:      The name associated to the directory entry we are looking for.
+ * @name_len:  The length of the name.
+ * @mod:       Used to indicate if the tree search is meant for a read only
+ *             lookup, for a modification lookup or for a deletion lookup, so
+ *             its value should be 0, 1 or -1, respectively.
+ *
+ * Returns: NULL if the dir index item does not exists, an error pointer if an
+ * error happened, or a pointer to a dir item if the dir index item exists and
+ * matches the criteria (name and index number).
  */
 struct btrfs_dir_item *
 btrfs_lookup_dir_index_item(struct btrfs_trans_handle *trans,
                            struct btrfs_root *root,
                            struct btrfs_path *path, u64 dir,
-                           u64 objectid, const char *name, int name_len,
+                           u64 index, const char *name, int name_len,
                            int mod)
 {
+       struct btrfs_dir_item *di;
        struct btrfs_key key;
 
        key.objectid = dir;
        key.type = BTRFS_DIR_INDEX_KEY;
-       key.offset = objectid;
+       key.offset = index;
 
-       return btrfs_lookup_match_dir(trans, root, path, &key, name, name_len, mod);
+       di = btrfs_lookup_match_dir(trans, root, path, &key, name, name_len, mod);
+       if (di == ERR_PTR(-ENOENT))
+               return NULL;
+
+       return di;
 }
 
 struct btrfs_dir_item *
index fc3da75..0ab456c 100644 (file)
@@ -4859,6 +4859,7 @@ struct extent_buffer *btrfs_alloc_tree_block(struct btrfs_trans_handle *trans,
 out_free_delayed:
        btrfs_free_delayed_extent_op(extent_op);
 out_free_buf:
+       btrfs_tree_unlock(buf);
        free_extent_buffer(buf);
 out_free_reserved:
        btrfs_free_reserved_extent(fs_info, ins.objectid, ins.offset, 0);
index 2673c6b..0b9401a 100644 (file)
@@ -665,7 +665,18 @@ blk_status_t btrfs_csum_one_bio(struct btrfs_inode *inode, struct bio *bio,
 
                if (!ordered) {
                        ordered = btrfs_lookup_ordered_extent(inode, offset);
-                       BUG_ON(!ordered); /* Logic error */
+                       /*
+                        * The bio range is not covered by any ordered extent,
+                        * must be a code logic error.
+                        */
+                       if (unlikely(!ordered)) {
+                               WARN(1, KERN_WARNING
+                       "no ordered extent for root %llu ino %llu offset %llu\n",
+                                    inode->root->root_key.objectid,
+                                    btrfs_ino(inode), offset);
+                               kvfree(sums);
+                               return BLK_STS_IOERR;
+                       }
                }
 
                nr_sectors = BTRFS_BYTES_TO_BLKS(fs_info,
index 7ff5770..a176236 100644 (file)
@@ -734,8 +734,7 @@ int btrfs_drop_extents(struct btrfs_trans_handle *trans,
        if (args->start >= inode->disk_i_size && !args->replace_extent)
                modify_tree = 0;
 
-       update_refs = (test_bit(BTRFS_ROOT_SHAREABLE, &root->state) ||
-                      root == fs_info->tree_root);
+       update_refs = (root->root_key.objectid != BTRFS_TREE_LOG_OBJECTID);
        while (1) {
                recow = 0;
                ret = btrfs_lookup_file_extent(trans, root, path, ino,
@@ -2704,14 +2703,16 @@ int btrfs_replace_file_extents(struct btrfs_inode *inode,
                                                 drop_args.bytes_found);
                if (ret != -ENOSPC) {
                        /*
-                        * When cloning we want to avoid transaction aborts when
-                        * nothing was done and we are attempting to clone parts
-                        * of inline extents, in such cases -EOPNOTSUPP is
-                        * returned by __btrfs_drop_extents() without having
-                        * changed anything in the file.
+                        * The only time we don't want to abort is if we are
+                        * attempting to clone a partial inline extent, in which
+                        * case we'll get EOPNOTSUPP.  However if we aren't
+                        * clone we need to abort no matter what, because if we
+                        * got EOPNOTSUPP via prealloc then we messed up and
+                        * need to abort.
                         */
-                       if (extent_info && !extent_info->is_new_extent &&
-                           ret && ret != -EOPNOTSUPP)
+                       if (ret &&
+                           (ret != -EOPNOTSUPP ||
+                            (extent_info && extent_info->is_new_extent)))
                                btrfs_abort_transaction(trans, ret);
                        break;
                }
index 5ada02e..aa5be0b 100644 (file)
@@ -414,9 +414,10 @@ static void __btrfs_dump_space_info(struct btrfs_fs_info *fs_info,
 {
        lockdep_assert_held(&info->lock);
 
-       btrfs_info(fs_info, "space_info %llu has %llu free, is %sfull",
+       /* The free space could be negative in case of overcommit */
+       btrfs_info(fs_info, "space_info %llu has %lld free, is %sfull",
                   info->flags,
-                  info->total_bytes - btrfs_space_info_used(info, true),
+                  (s64)(info->total_bytes - btrfs_space_info_used(info, true)),
                   info->full ? "" : "not ");
        btrfs_info(fs_info,
                "space_info total=%llu, used=%llu, pinned=%llu, reserved=%llu, may_use=%llu, readonly=%llu zone_unusable=%llu",
index f7efc26..b415c5e 100644 (file)
@@ -939,9 +939,11 @@ out:
 }
 
 /*
- * helper function to see if a given name and sequence number found
- * in an inode back reference are already in a directory and correctly
- * point to this inode
+ * See if a given name and sequence number found in an inode back reference are
+ * already in a directory and correctly point to this inode.
+ *
+ * Returns: < 0 on error, 0 if the directory entry does not exists and 1 if it
+ * exists.
  */
 static noinline int inode_in_dir(struct btrfs_root *root,
                                 struct btrfs_path *path,
@@ -950,29 +952,34 @@ static noinline int inode_in_dir(struct btrfs_root *root,
 {
        struct btrfs_dir_item *di;
        struct btrfs_key location;
-       int match = 0;
+       int ret = 0;
 
        di = btrfs_lookup_dir_index_item(NULL, root, path, dirid,
                                         index, name, name_len, 0);
-       if (di && !IS_ERR(di)) {
+       if (IS_ERR(di)) {
+               ret = PTR_ERR(di);
+               goto out;
+       } else if (di) {
                btrfs_dir_item_key_to_cpu(path->nodes[0], di, &location);
                if (location.objectid != objectid)
                        goto out;
-       } else
+       } else {
                goto out;
-       btrfs_release_path(path);
+       }
 
+       btrfs_release_path(path);
        di = btrfs_lookup_dir_item(NULL, root, path, dirid, name, name_len, 0);
-       if (di && !IS_ERR(di)) {
-               btrfs_dir_item_key_to_cpu(path->nodes[0], di, &location);
-               if (location.objectid != objectid)
-                       goto out;
-       } else
+       if (IS_ERR(di)) {
+               ret = PTR_ERR(di);
                goto out;
-       match = 1;
+       } else if (di) {
+               btrfs_dir_item_key_to_cpu(path->nodes[0], di, &location);
+               if (location.objectid == objectid)
+                       ret = 1;
+       }
 out:
        btrfs_release_path(path);
-       return match;
+       return ret;
 }
 
 /*
@@ -1182,7 +1189,9 @@ next:
        /* look for a conflicting sequence number */
        di = btrfs_lookup_dir_index_item(trans, root, path, btrfs_ino(dir),
                                         ref_index, name, namelen, 0);
-       if (di && !IS_ERR(di)) {
+       if (IS_ERR(di)) {
+               return PTR_ERR(di);
+       } else if (di) {
                ret = drop_one_dir_item(trans, root, path, dir, di);
                if (ret)
                        return ret;
@@ -1192,7 +1201,9 @@ next:
        /* look for a conflicting name */
        di = btrfs_lookup_dir_item(trans, root, path, btrfs_ino(dir),
                                   name, namelen, 0);
-       if (di && !IS_ERR(di)) {
+       if (IS_ERR(di)) {
+               return PTR_ERR(di);
+       } else if (di) {
                ret = drop_one_dir_item(trans, root, path, dir, di);
                if (ret)
                        return ret;
@@ -1517,10 +1528,12 @@ static noinline int add_inode_ref(struct btrfs_trans_handle *trans,
                if (ret)
                        goto out;
 
-               /* if we already have a perfect match, we're done */
-               if (!inode_in_dir(root, path, btrfs_ino(BTRFS_I(dir)),
-                                       btrfs_ino(BTRFS_I(inode)), ref_index,
-                                       name, namelen)) {
+               ret = inode_in_dir(root, path, btrfs_ino(BTRFS_I(dir)),
+                                  btrfs_ino(BTRFS_I(inode)), ref_index,
+                                  name, namelen);
+               if (ret < 0) {
+                       goto out;
+               } else if (ret == 0) {
                        /*
                         * look for a conflicting back reference in the
                         * metadata. if we find one we have to unlink that name
@@ -1580,6 +1593,7 @@ static noinline int add_inode_ref(struct btrfs_trans_handle *trans,
                        if (ret)
                                goto out;
                }
+               /* Else, ret == 1, we already have a perfect match, we're done. */
 
                ref_ptr = (unsigned long)(ref_ptr + ref_struct_size) + namelen;
                kfree(name);
@@ -1936,8 +1950,8 @@ static noinline int replay_one_name(struct btrfs_trans_handle *trans,
        struct btrfs_key log_key;
        struct inode *dir;
        u8 log_type;
-       int exists;
-       int ret = 0;
+       bool exists;
+       int ret;
        bool update_size = (key->type == BTRFS_DIR_INDEX_KEY);
        bool name_added = false;
 
@@ -1957,12 +1971,12 @@ static noinline int replay_one_name(struct btrfs_trans_handle *trans,
                   name_len);
 
        btrfs_dir_item_key_to_cpu(eb, di, &log_key);
-       exists = btrfs_lookup_inode(trans, root, path, &log_key, 0);
-       if (exists == 0)
-               exists = 1;
-       else
-               exists = 0;
+       ret = btrfs_lookup_inode(trans, root, path, &log_key, 0);
        btrfs_release_path(path);
+       if (ret < 0)
+               goto out;
+       exists = (ret == 0);
+       ret = 0;
 
        if (key->type == BTRFS_DIR_ITEM_KEY) {
                dst_di = btrfs_lookup_dir_item(trans, root, path, key->objectid,
@@ -1977,7 +1991,11 @@ static noinline int replay_one_name(struct btrfs_trans_handle *trans,
                ret = -EINVAL;
                goto out;
        }
-       if (IS_ERR_OR_NULL(dst_di)) {
+
+       if (IS_ERR(dst_di)) {
+               ret = PTR_ERR(dst_di);
+               goto out;
+       } else if (!dst_di) {
                /* we need a sequence number to insert, so we only
                 * do inserts for the BTRFS_DIR_INDEX_KEY types
                 */
@@ -2281,7 +2299,7 @@ again:
                                                     dir_key->offset,
                                                     name, name_len, 0);
                }
-               if (!log_di || log_di == ERR_PTR(-ENOENT)) {
+               if (!log_di) {
                        btrfs_dir_item_key_to_cpu(eb, di, &location);
                        btrfs_release_path(path);
                        btrfs_release_path(log_path);
@@ -3540,8 +3558,7 @@ out_unlock:
        if (err == -ENOSPC) {
                btrfs_set_log_full_commit(trans);
                err = 0;
-       } else if (err < 0 && err != -ENOENT) {
-               /* ENOENT can be returned if the entry hasn't been fsynced yet */
+       } else if (err < 0) {
                btrfs_abort_transaction(trans, err);
        }
 
index 28d443d..4968535 100644 (file)
@@ -451,7 +451,7 @@ static int del_orphan(struct btrfs_trans_handle *trans, struct btrfs_inode *inod
  */
 static int rollback_verity(struct btrfs_inode *inode)
 {
-       struct btrfs_trans_handle *trans;
+       struct btrfs_trans_handle *trans = NULL;
        struct btrfs_root *root = inode->root;
        int ret;
 
@@ -473,6 +473,7 @@ static int rollback_verity(struct btrfs_inode *inode)
        trans = btrfs_start_transaction(root, 2);
        if (IS_ERR(trans)) {
                ret = PTR_ERR(trans);
+               trans = NULL;
                btrfs_handle_fs_error(root->fs_info, ret,
                        "failed to start transaction in verity rollback %llu",
                        (u64)inode->vfs_inode.i_ino);
@@ -490,8 +491,9 @@ static int rollback_verity(struct btrfs_inode *inode)
                btrfs_abort_transaction(trans, ret);
                goto out;
        }
-       btrfs_end_transaction(trans);
 out:
+       if (trans)
+               btrfs_end_transaction(trans);
        return ret;
 }
 
index 464485a..2ec3b8a 100644 (file)
@@ -1137,6 +1137,19 @@ static void btrfs_close_one_device(struct btrfs_device *device)
        atomic_set(&device->dev_stats_ccnt, 0);
        extent_io_tree_release(&device->alloc_state);
 
+       /*
+        * Reset the flush error record. We might have a transient flush error
+        * in this mount, and if so we aborted the current transaction and set
+        * the fs to an error state, guaranteeing no super blocks can be further
+        * committed. However that error might be transient and if we unmount the
+        * filesystem and mount it again, we should allow the mount to succeed
+        * (btrfs_check_rw_degradable() should not fail) - if after mounting the
+        * filesystem again we still get flush errors, then we will again abort
+        * any transaction and set the error state, guaranteeing no commits of
+        * unsafe super blocks.
+        */
+       device->last_flush_error = 0;
+
        /* Verify the device is back in a pristine state  */
        ASSERT(!test_bit(BTRFS_DEV_STATE_FLUSH_SENT, &device->dev_state));
        ASSERT(!test_bit(BTRFS_DEV_STATE_REPLACE_TGT, &device->dev_state));
index ab7573d..c615387 100644 (file)
@@ -1425,12 +1425,16 @@ void invalidate_bh_lrus(void)
 }
 EXPORT_SYMBOL_GPL(invalidate_bh_lrus);
 
-void invalidate_bh_lrus_cpu(int cpu)
+/*
+ * It's called from workqueue context so we need a bh_lru_lock to close
+ * the race with preemption/irq.
+ */
+void invalidate_bh_lrus_cpu(void)
 {
        struct bh_lru *b;
 
        bh_lru_lock();
-       b = per_cpu_ptr(&bh_lrus, cpu);
+       b = this_cpu_ptr(&bh_lrus);
        __invalidate_bh_lrus(b);
        bh_lru_unlock();
 }
index 6c0e52f..3e42d04 100644 (file)
@@ -2263,7 +2263,7 @@ retry:
                        list_for_each_entry(req, &ci->i_unsafe_dirops,
                                            r_unsafe_dir_item) {
                                s = req->r_session;
-                               if (unlikely(s->s_mds > max)) {
+                               if (unlikely(s->s_mds >= max)) {
                                        spin_unlock(&ci->i_unsafe_lock);
                                        goto retry;
                                }
@@ -2277,7 +2277,7 @@ retry:
                        list_for_each_entry(req, &ci->i_unsafe_iops,
                                            r_unsafe_target_item) {
                                s = req->r_session;
-                               if (unlikely(s->s_mds > max)) {
+                               if (unlikely(s->s_mds >= max)) {
                                        spin_unlock(&ci->i_unsafe_lock);
                                        goto retry;
                                }
index 8a3b30e..8be57aa 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cache.c - CIFS filesystem cache index structure definitions
+ *   CIFS filesystem cache index structure definitions
  *
  *   Copyright (c) 2010 Novell, Inc.
  *   Authors(s): Suresh Jayaraman (sjayaraman@suse.de>
index 51a824f..de2c12b 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- *   fs/cifs_debug.c
  *
  *   Copyright (C) International Business Machines  Corp., 2000,2005
  *
index 4fd7885..f974075 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifs_fs_sb.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2004
  *   Author(s): Steve French (sfrench@us.ibm.com)
index ef723be..b87cbbe 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifs_ioctl.h
  *
  *   Structure definitions for io control for cifs/smb3
  *
index 8fa26a8..353bd0d 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cifs_spnego.c -- SPNEGO upcall management for CIFS
+ *   SPNEGO upcall management for CIFS
  *
  *   Copyright (c) 2007 Red Hat, Inc.
  *   Author(s): Jeff Layton (jlayton@redhat.com)
index 31387d0..e6a0451 100644 (file)
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifs_spnego.h -- SPNEGO upcall management for CIFS
+ *   SPNEGO upcall management for CIFS
  *
  *   Copyright (c) 2007 Red Hat, Inc.
  *   Author(s): Jeff Layton (jlayton@redhat.com)
index 171ad8b..e7582dd 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- *   fs/cifs/cifs_unicode.c
  *
  *   Copyright (c) International Business Machines  Corp., 2000,2009
  *   Modified by Steve French (sfrench@us.ibm.com)
index 388eb53..ee3aab3 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cifsacl.c
  *
  *   Copyright (C) International Business Machines  Corp., 2007,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index f8292bc..ccbfc75 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifsacl.h
  *
  *   Copyright (c) International Business Machines  Corp., 2007
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 2e6f403..d118282 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cifsencrypt.c
  *
  *   Encryption and hashing operations relating to NTLM, NTLMv2.  See MS-NLMP
  *   for more detailed information
index 8c20bfa..9fa930d 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cifsfs.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index d25a409..b50da19 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifsfs.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002, 2007
  *   Author(s): Steve French (sfrench@us.ibm.com)
index c068f7d..e916470 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifsglob.h
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
@@ -1400,6 +1399,7 @@ struct cifsInodeInfo {
 #define CIFS_INO_INVALID_MAPPING         (4) /* pagecache is invalid */
 #define CIFS_INO_LOCK                    (5) /* lock bit for synchronization */
 #define CIFS_INO_MODIFIED_ATTR            (6) /* Indicate change in mtime/ctime */
+#define CIFS_INO_CLOSE_ON_LOCK            (7) /* Not to defer the close when lock is set */
        unsigned long flags;
        spinlock_t writers_lock;
        unsigned int writers;           /* Number of writers on this inode */
index 98e8e5a..d2ff438 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifspdu.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2009
  *   Author(s): Steve French (sfrench@us.ibm.com)
index f9740c2..d0f85b6 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/cifsproto.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
@@ -268,6 +267,9 @@ extern void cifs_close_deferred_file(struct cifsInodeInfo *cifs_inode);
 
 extern void cifs_close_all_deferred_files(struct cifs_tcon *cifs_tcon);
 
+extern void cifs_close_deferred_file_under_dentry(struct cifs_tcon *cifs_tcon,
+                               const char *path);
+
 extern struct TCP_Server_Info *cifs_get_tcp_session(struct smb3_fs_context *ctx);
 extern void cifs_put_tcp_session(struct TCP_Server_Info *server,
                                 int from_reconnect);
index a8e41c1..243d176 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/cifssmb.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2010
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 0db3448..c3b94c1 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/connect.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2011
  *   Author(s): Steve French (sfrench@us.ibm.com)
@@ -1090,7 +1089,7 @@ next_pdu:
        module_put_and_exit(0);
 }
 
-/**
+/*
  * Returns true if srcaddr isn't specified and rhs isn't specified, or
  * if srcaddr is specified and matches the IP address of the rhs argument
  */
@@ -1550,6 +1549,9 @@ static int match_session(struct cifs_ses *ses, struct smb3_fs_context *ctx)
 
 /**
  * cifs_setup_ipc - helper to setup the IPC tcon for the session
+ * @ses: smb session to issue the request on
+ * @ctx: the superblock configuration context to use for building the
+ *       new tree connection for the IPC (interprocess communication RPC)
  *
  * A new IPC connection is made and stored in the session
  * tcon_ipc. The IPC tcon has the same lifetime as the session.
@@ -1605,6 +1607,7 @@ out:
 
 /**
  * cifs_free_ipc - helper to release the session IPC tcon
+ * @ses: smb session to unmount the IPC from
  *
  * Needs to be called everytime a session is destroyed.
  *
@@ -1855,6 +1858,8 @@ cifs_set_cifscreds(struct smb3_fs_context *ctx __attribute__((unused)),
 
 /**
  * cifs_get_smb_ses - get a session matching @ctx data from @server
+ * @server: server to setup the session to
+ * @ctx: superblock configuration context to use to setup the session
  *
  * This function assumes it is being called from cifs_mount() where we
  * already got a server reference (server refcount +1). See
@@ -2065,6 +2070,8 @@ cifs_put_tcon(struct cifs_tcon *tcon)
 
 /**
  * cifs_get_tcon - get a tcon matching @ctx data from @ses
+ * @ses: smb session to issue the request on
+ * @ctx: the superblock configuration context to use for building the
  *
  * - tcon refcount is the number of mount points using the tcon.
  * - ses refcount is the number of tcon using the session.
@@ -2382,9 +2389,10 @@ cifs_match_super(struct super_block *sb, void *data)
        spin_lock(&cifs_tcp_ses_lock);
        cifs_sb = CIFS_SB(sb);
        tlink = cifs_get_tlink(cifs_sb_master_tlink(cifs_sb));
-       if (IS_ERR(tlink)) {
+       if (tlink == NULL) {
+               /* can not match superblock if tlink were ever null */
                spin_unlock(&cifs_tcp_ses_lock);
-               return rc;
+               return 0;
        }
        tcon = tlink_tcon(tlink);
        ses = tcon->ses;
@@ -3030,7 +3038,7 @@ build_unc_path_to_root(const struct smb3_fs_context *ctx,
        return full_path;
 }
 
-/**
+/*
  * expand_dfs_referral - Perform a dfs referral query and update the cifs_sb
  *
  * If a referral is found, cifs_sb->ctx->mount_options will be (re-)allocated
index 5f8a302..6e8e7cc 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/dir.c
  *
  *   vfs operations that deal with dentries
  *
index 8c616aa..0458d28 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *  fs/cifs/dns_resolve.c
  *
  *   Copyright (c) 2007 Igor Mammedov
  *   Author(s): Igor Mammedov (niallain@gmail.com)
index 9fa2807..afc0df3 100644 (file)
@@ -1,7 +1,7 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/dns_resolve.h -- DNS Resolver upcall management for CIFS DFS
- *                            Handles host name to IP address resolution
+ *   DNS Resolver upcall management for CIFS DFS
+ *   Handles host name to IP address resolution
  *
  *   Copyright (c) International Business Machines  Corp., 2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 747a540..37c2841 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/export.c
  *
  *   Copyright (C) International Business Machines  Corp., 2007
  *   Author(s): Steve French (sfrench@us.ibm.com)
index d021647..13f3182 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/file.c
  *
  *   vfs operations that deal with files
  *
@@ -883,8 +882,9 @@ int cifs_close(struct inode *inode, struct file *file)
                dclose = kmalloc(sizeof(struct cifs_deferred_close), GFP_KERNEL);
                if ((cinode->oplock == CIFS_CACHE_RHW_FLG) &&
                    cinode->lease_granted &&
+                   !test_bit(CIFS_INO_CLOSE_ON_LOCK, &cinode->flags) &&
                    dclose) {
-                       if (test_bit(CIFS_INO_MODIFIED_ATTR, &cinode->flags)) {
+                       if (test_and_clear_bit(CIFS_INO_MODIFIED_ATTR, &cinode->flags)) {
                                inode->i_ctime = inode->i_mtime = current_time(inode);
                                cifs_fscache_update_inode_cookie(inode);
                        }
@@ -1865,6 +1865,7 @@ int cifs_lock(struct file *file, int cmd, struct file_lock *flock)
        cifs_read_flock(flock, &type, &lock, &unlock, &wait_flag,
                        tcon->ses->server);
        cifs_sb = CIFS_FILE_SB(file);
+       set_bit(CIFS_INO_CLOSE_ON_LOCK, &CIFS_I(d_inode(cfile->dentry))->flags);
 
        if (cap_unix(tcon->ses) &&
            (CIFS_UNIX_FCNTL_CAP & le64_to_cpu(tcon->fsUnixInfo.Capability)) &&
@@ -3112,7 +3113,7 @@ static void collect_uncached_write_data(struct cifs_aio_ctx *ctx)
        struct cifs_tcon *tcon;
        struct cifs_sb_info *cifs_sb;
        struct dentry *dentry = ctx->cfile->dentry;
-       int rc;
+       ssize_t rc;
 
        tcon = tlink_tcon(ctx->cfile->tlink);
        cifs_sb = CIFS_SB(dentry->d_sb);
index fab47fa..8eedd20 100644 (file)
@@ -1,6 +1,6 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/fscache.c - CIFS filesystem cache interface
+ *   CIFS filesystem cache interface
  *
  *   Copyright (c) 2010 Novell, Inc.
  *   Author(s): Suresh Jayaraman <sjayaraman@suse.de>
index 82e856b..9baa1d0 100644 (file)
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/fscache.h - CIFS filesystem cache interface definitions
+ *   CIFS filesystem cache interface definitions
  *
  *   Copyright (c) 2010 Novell, Inc.
  *   Authors(s): Suresh Jayaraman (sjayaraman@suse.de>
index 50c01cf..8284841 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/inode.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2010
  *   Author(s): Steve French (sfrench@us.ibm.com)
@@ -1625,7 +1624,7 @@ int cifs_unlink(struct inode *dir, struct dentry *dentry)
                goto unlink_out;
        }
 
-       cifs_close_deferred_file(CIFS_I(inode));
+       cifs_close_deferred_file_under_dentry(tcon, full_path);
        if (cap_unix(tcon->ses) && (CIFS_UNIX_POSIX_PATH_OPS_CAP &
                                le64_to_cpu(tcon->fsUnixInfo.Capability))) {
                rc = CIFSPOSIXDelFile(xid, tcon, full_path,
@@ -2114,9 +2113,9 @@ cifs_rename2(struct user_namespace *mnt_userns, struct inode *source_dir,
                goto cifs_rename_exit;
        }
 
-       cifs_close_deferred_file(CIFS_I(d_inode(source_dentry)));
+       cifs_close_deferred_file_under_dentry(tcon, from_name);
        if (d_inode(target_dentry) != NULL)
-               cifs_close_deferred_file(CIFS_I(d_inode(target_dentry)));
+               cifs_close_deferred_file_under_dentry(tcon, to_name);
 
        rc = cifs_do_rename(xid, source_dentry, from_name, target_dentry,
                            to_name);
index 42c6a0b..0359b60 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/ioctl.c
  *
  *   vfs operations that deal with io control
  *
@@ -359,7 +358,7 @@ long cifs_ioctl(struct file *filep, unsigned int command, unsigned long arg)
                        if (pSMBFile == NULL)
                                break;
                        tcon = tlink_tcon(pSMBFile->tlink);
-                       caps = le64_to_cpu(tcon->fsUnixInfo.Capability);
+                       /* caps = le64_to_cpu(tcon->fsUnixInfo.Capability); */
 
                        if (get_user(ExtAttrBits, (int __user *)arg)) {
                                rc = -EFAULT;
index f0a6d63..852e54e 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/link.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 9469f1c..bb1185f 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/misc.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
@@ -265,7 +264,8 @@ header_assemble(struct smb_hdr *buffer, char smb_command /* command */ ,
 
                        /* Uid is not converted */
                        buffer->Uid = treeCon->ses->Suid;
-                       buffer->Mid = get_next_mid(treeCon->ses->server);
+                       if (treeCon->ses->server)
+                               buffer->Mid = get_next_mid(treeCon->ses->server);
                }
                if (treeCon->Flags & SMB_SHARE_IS_IN_DFS)
                        buffer->Flags2 |= SMBFLG2_DFS;
@@ -591,6 +591,7 @@ void cifs_put_writer(struct cifsInodeInfo *cinode)
 
 /**
  * cifs_queue_oplock_break - queue the oplock break handler for cfile
+ * @cfile: The file to break the oplock on
  *
  * This function is called from the demultiplex thread when it
  * receives an oplock break for @cfile.
@@ -736,7 +737,7 @@ cifs_close_deferred_file(struct cifsInodeInfo *cifs_inode)
                        if (cancel_delayed_work(&cfile->deferred)) {
                                tmp_list = kmalloc(sizeof(struct file_list), GFP_ATOMIC);
                                if (tmp_list == NULL)
-                                       continue;
+                                       break;
                                tmp_list->cfile = cfile;
                                list_add_tail(&tmp_list->list, &file_head);
                        }
@@ -767,7 +768,7 @@ cifs_close_all_deferred_files(struct cifs_tcon *tcon)
                        if (cancel_delayed_work(&cfile->deferred)) {
                                tmp_list = kmalloc(sizeof(struct file_list), GFP_ATOMIC);
                                if (tmp_list == NULL)
-                                       continue;
+                                       break;
                                tmp_list->cfile = cfile;
                                list_add_tail(&tmp_list->list, &file_head);
                        }
@@ -781,6 +782,43 @@ cifs_close_all_deferred_files(struct cifs_tcon *tcon)
                kfree(tmp_list);
        }
 }
+void
+cifs_close_deferred_file_under_dentry(struct cifs_tcon *tcon, const char *path)
+{
+       struct cifsFileInfo *cfile;
+       struct list_head *tmp;
+       struct file_list *tmp_list, *tmp_next_list;
+       struct list_head file_head;
+       void *page;
+       const char *full_path;
+
+       INIT_LIST_HEAD(&file_head);
+       page = alloc_dentry_path();
+       spin_lock(&tcon->open_file_lock);
+       list_for_each(tmp, &tcon->openFileList) {
+               cfile = list_entry(tmp, struct cifsFileInfo, tlist);
+               full_path = build_path_from_dentry(cfile->dentry, page);
+               if (strstr(full_path, path)) {
+                       if (delayed_work_pending(&cfile->deferred)) {
+                               if (cancel_delayed_work(&cfile->deferred)) {
+                                       tmp_list = kmalloc(sizeof(struct file_list), GFP_ATOMIC);
+                                       if (tmp_list == NULL)
+                                               break;
+                                       tmp_list->cfile = cfile;
+                                       list_add_tail(&tmp_list->list, &file_head);
+                               }
+                       }
+               }
+       }
+       spin_unlock(&tcon->open_file_lock);
+
+       list_for_each_entry_safe(tmp_list, tmp_next_list, &file_head, list) {
+               _cifsFileInfo_put(tmp_list->cfile, true, false);
+               list_del(&tmp_list->list);
+               kfree(tmp_list);
+       }
+       free_dentry_path(page);
+}
 
 /* parses DFS refferal V3 structure
  * caller is responsible for freeing target_nodes
@@ -1029,6 +1067,9 @@ setup_aio_ctx_iter(struct cifs_aio_ctx *ctx, struct iov_iter *iter, int rw)
 
 /**
  * cifs_alloc_hash - allocate hash and hash context together
+ * @name: The name of the crypto hash algo
+ * @shash: Where to put the pointer to the hash algo
+ * @sdesc: Where to put the pointer to the hash descriptor
  *
  * The caller has to make sure @sdesc is initialized to either NULL or
  * a valid context. Both can be freed via cifs_free_hash().
@@ -1067,6 +1108,8 @@ cifs_alloc_hash(const char *name,
 
 /**
  * cifs_free_hash - free hash and hash context together
+ * @shash: Where to find the pointer to the hash algo
+ * @sdesc: Where to find the pointer to the hash descriptor
  *
  * Freeing a NULL hash or context is safe.
  */
@@ -1082,8 +1125,10 @@ cifs_free_hash(struct crypto_shash **shash, struct sdesc **sdesc)
 
 /**
  * rqst_page_get_length - obtain the length and offset for a page in smb_rqst
- * Input: rqst - a smb_rqst, page - a page index for rqst
- * Output: *len - the length for this page, *offset - the offset for this page
+ * @rqst: The request descriptor
+ * @page: The index of the page to query
+ * @len: Where to store the length for this page:
+ * @offset: Where to store the offset for this page
  */
 void rqst_page_get_length(struct smb_rqst *rqst, unsigned int page,
                                unsigned int *len, unsigned int *offset)
@@ -1116,6 +1161,8 @@ void extract_unc_hostname(const char *unc, const char **h, size_t *len)
 
 /**
  * copy_path_name - copy src path to dst, possibly truncating
+ * @dst: The destination buffer
+ * @src: The source name
  *
  * returns number of bytes written (including trailing nul)
  */
index 0e728aa..fa9fbd6 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- *   fs/cifs/netmisc.c
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 378133c..25a2b8e 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/ntlmssp.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2007
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 54d77c9..1929e80 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/readdir.c
  *
  *   Directory search handling
  *
index 137f7c9..ae1d025 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/rfc1002pdu.h
  *
  *   Protocol Data Unit definitions for RFC 1001/1002 support
  *
index 118403f..23e02db 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/sess.c
  *
  *   SMB/CIFS session setup handling routines
  *
index c9d8a50..f5dcc49 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/smb2file.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002, 2011
  *   Author(s): Steve French (sfrench@us.ibm.com),
index d0e9f37..ca692b2 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/smb2glob.h
  *
  *   Definitions for various global variables and structures
  *
index 957b259..8297703 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/smb2inode.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002, 2011
  *                 Etersoft, 2012
index 668f771..29b5554 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/smb2misc.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2011
  *                 Etersoft, 2012
index b6d2e35..7829c59 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/smb2pdu.c
  *
  *   Copyright (C) International Business Machines  Corp., 2009, 2013
  *                 Etersoft, 2012
@@ -2398,7 +2397,7 @@ create_sd_buf(umode_t mode, bool set_owner, unsigned int *len)
        buf->sd.OffsetDacl = cpu_to_le32(ptr - (__u8 *)&buf->sd);
        /* Ship the ACL for now. we will copy it into buf later. */
        aclptr = ptr;
-       ptr += sizeof(struct cifs_acl);
+       ptr += sizeof(struct smb3_acl);
 
        /* create one ACE to hold the mode embedded in reserved special SID */
        acelen = setup_special_mode_ACE((struct cifs_ace *)ptr, (__u64)mode);
@@ -2423,7 +2422,7 @@ create_sd_buf(umode_t mode, bool set_owner, unsigned int *len)
        acl.AclRevision = ACL_REVISION; /* See 2.4.4.1 of MS-DTYP */
        acl.AclSize = cpu_to_le16(acl_size);
        acl.AceCount = cpu_to_le16(ace_count);
-       memcpy(aclptr, &acl, sizeof(struct cifs_acl));
+       memcpy(aclptr, &acl, sizeof(struct smb3_acl));
 
        buf->ccontext.DataLength = cpu_to_le32(ptr - (__u8 *)&buf->sd);
        *len = roundup(ptr - (__u8 *)buf, 8);
index e9cac79..f32c99c 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/smb2pdu.h
  *
  *   Copyright (c) International Business Machines  Corp., 2009, 2013
  *                 Etersoft, 2012
index 263767f..5479454 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/smb2proto.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002, 2011
  *                 Etersoft, 2012
index 0215ef3..a9e9581 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/smb2status.h
  *
  *   SMB2 Status code (network error) definitions
  *   Definitions are from MS-ERREF
index 6f7952e..f59b956 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/smb2transport.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002, 2011
  *                 Etersoft, 2012
index 60189ef..aeffdad 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1 */
 /*
- *   fs/cifs/smberr.h
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2004
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 75a95de..b737932 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/transport.c
  *
  *   Copyright (C) International Business Machines  Corp., 2002,2008
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 59b6c57..2f075b5 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
- * fs/cifs/winucase.c
  *
  * Copyright (c) Jeffrey Layton <jlayton@redhat.com>, 2013
  *
index 9ed481e..7d8b72d 100644 (file)
@@ -1,6 +1,5 @@
 // SPDX-License-Identifier: LGPL-2.1
 /*
- *   fs/cifs/xattr.c
  *
  *   Copyright (c) International Business Machines  Corp., 2003, 2007
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 8129a43..2f117c5 100644 (file)
@@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
 {
        struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
 
-       if (de)
+       if (!IS_ERR(de))
                d_inode(de)->i_size = file_size;
 }
 EXPORT_SYMBOL_GPL(debugfs_create_file_size);
index 31ac3a7..a552399 100644 (file)
@@ -176,7 +176,7 @@ static struct page *erofs_read_inode(struct inode *inode,
        }
 
        if (vi->datalayout == EROFS_INODE_CHUNK_BASED) {
-               if (!(vi->chunkformat & EROFS_CHUNK_FORMAT_ALL)) {
+               if (vi->chunkformat & ~EROFS_CHUNK_FORMAT_ALL) {
                        erofs_err(inode->i_sb,
                                  "unsupported chunk format %x of nid %llu",
                                  vi->chunkformat, vi->nid);
index 9fb98d8..7a6df35 100644 (file)
@@ -369,7 +369,8 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m,
        if (compacted_4b_initial == 32 / 4)
                compacted_4b_initial = 0;
 
-       if (vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B)
+       if ((vi->z_advise & Z_EROFS_ADVISE_COMPACTED_2B) &&
+           compacted_4b_initial < totalidx)
                compacted_2b = rounddown(totalidx - compacted_4b_initial, 16);
        else
                compacted_2b = 0;
index 1f3f432..c17ccc1 100644 (file)
@@ -48,10 +48,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb,
        struct ext2_sb_info *sbi = EXT2_SB(sb);
 
        if (block_group >= sbi->s_groups_count) {
-               ext2_error (sb, "ext2_get_group_desc",
-                           "block_group >= groups_count - "
-                           "block_group = %d, groups_count = %lu",
-                           block_group, sbi->s_groups_count);
+               WARN(1, "block_group >= groups_count - "
+                    "block_group = %d, groups_count = %lu",
+                    block_group, sbi->s_groups_count);
 
                return NULL;
        }
@@ -59,10 +58,9 @@ struct ext2_group_desc * ext2_get_group_desc(struct super_block * sb,
        group_desc = block_group >> EXT2_DESC_PER_BLOCK_BITS(sb);
        offset = block_group & (EXT2_DESC_PER_BLOCK(sb) - 1);
        if (!sbi->s_group_desc[group_desc]) {
-               ext2_error (sb, "ext2_get_group_desc",
-                           "Group descriptor not loaded - "
-                           "block_group = %d, group_desc = %lu, desc = %lu",
-                            block_group, group_desc, offset);
+               WARN(1, "Group descriptor not loaded - "
+                    "block_group = %d, group_desc = %lu, desc = %lu",
+                     block_group, group_desc, offset);
                return NULL;
        }
 
index ffb295a..74b172a 100644 (file)
@@ -551,7 +551,7 @@ static int ext4_dx_readdir(struct file *file, struct dir_context *ctx)
        struct dir_private_info *info = file->private_data;
        struct inode *inode = file_inode(file);
        struct fname *fname;
-       int     ret;
+       int ret = 0;
 
        if (!info) {
                info = ext4_htree_create_dir_info(file, ctx->pos);
@@ -599,7 +599,7 @@ static int ext4_dx_readdir(struct file *file, struct dir_context *ctx)
                                                   info->curr_minor_hash,
                                                   &info->next_hash);
                        if (ret < 0)
-                               return ret;
+                               goto finished;
                        if (ret == 0) {
                                ctx->pos = ext4_get_htree_eof(file);
                                break;
@@ -630,7 +630,7 @@ static int ext4_dx_readdir(struct file *file, struct dir_context *ctx)
        }
 finished:
        info->last_pos = ctx->pos;
-       return 0;
+       return ret < 0 ? ret : 0;
 }
 
 static int ext4_release_dir(struct inode *inode, struct file *filp)
index 90ff5ac..3825195 100644 (file)
@@ -3593,9 +3593,6 @@ extern int ext4_da_write_inline_data_begin(struct address_space *mapping,
                                           unsigned flags,
                                           struct page **pagep,
                                           void **fsdata);
-extern int ext4_da_write_inline_data_end(struct inode *inode, loff_t pos,
-                                        unsigned len, unsigned copied,
-                                        struct page *page);
 extern int ext4_try_add_inline_entry(handle_t *handle,
                                     struct ext4_filename *fname,
                                     struct inode *dir, struct inode *inode);
index c0de30f..0e02571 100644 (file)
@@ -5916,7 +5916,7 @@ void ext4_ext_replay_shrink_inode(struct inode *inode, ext4_lblk_t end)
 }
 
 /* Check if *cur is a hole and if it is, skip it */
-static void skip_hole(struct inode *inode, ext4_lblk_t *cur)
+static int skip_hole(struct inode *inode, ext4_lblk_t *cur)
 {
        int ret;
        struct ext4_map_blocks map;
@@ -5925,9 +5925,12 @@ static void skip_hole(struct inode *inode, ext4_lblk_t *cur)
        map.m_len = ((inode->i_size) >> inode->i_sb->s_blocksize_bits) - *cur;
 
        ret = ext4_map_blocks(NULL, inode, &map, 0);
+       if (ret < 0)
+               return ret;
        if (ret != 0)
-               return;
+               return 0;
        *cur = *cur + map.m_len;
+       return 0;
 }
 
 /* Count number of blocks used by this inode and update i_blocks */
@@ -5976,7 +5979,9 @@ int ext4_ext_replay_set_iblocks(struct inode *inode)
         * iblocks by total number of differences found.
         */
        cur = 0;
-       skip_hole(inode, &cur);
+       ret = skip_hole(inode, &cur);
+       if (ret < 0)
+               goto out;
        path = ext4_find_extent(inode, cur, NULL, 0);
        if (IS_ERR(path))
                goto out;
@@ -5995,8 +6000,12 @@ int ext4_ext_replay_set_iblocks(struct inode *inode)
                }
                cur = max(cur + 1, le32_to_cpu(ex->ee_block) +
                                        ext4_ext_get_actual_len(ex));
-               skip_hole(inode, &cur);
-
+               ret = skip_hole(inode, &cur);
+               if (ret < 0) {
+                       ext4_ext_drop_refs(path);
+                       kfree(path);
+                       break;
+               }
                path2 = ext4_find_extent(inode, cur, NULL, 0);
                if (IS_ERR(path2)) {
                        ext4_ext_drop_refs(path);
index 8e610a3..8ea5a81 100644 (file)
@@ -892,6 +892,12 @@ static int ext4_fc_write_inode_data(struct inode *inode, u32 *crc)
                                            sizeof(lrange), (u8 *)&lrange, crc))
                                return -ENOSPC;
                } else {
+                       unsigned int max = (map.m_flags & EXT4_MAP_UNWRITTEN) ?
+                               EXT_UNWRITTEN_MAX_LEN : EXT_INIT_MAX_LEN;
+
+                       /* Limit the number of blocks in one extent */
+                       map.m_len = min(max, map.m_len);
+
                        fc_ext.fc_ino = cpu_to_le32(inode->i_ino);
                        ex = (struct ext4_extent *)&fc_ext.fc_ex;
                        ex->ee_block = cpu_to_le32(map.m_lblk);
index 82bf4ff..39a1ab1 100644 (file)
@@ -7,6 +7,7 @@
 #include <linux/iomap.h>
 #include <linux/fiemap.h>
 #include <linux/iversion.h>
+#include <linux/backing-dev.h>
 
 #include "ext4_jbd2.h"
 #include "ext4.h"
@@ -733,45 +734,83 @@ convert:
 int ext4_write_inline_data_end(struct inode *inode, loff_t pos, unsigned len,
                               unsigned copied, struct page *page)
 {
-       int ret, no_expand;
+       handle_t *handle = ext4_journal_current_handle();
+       int no_expand;
        void *kaddr;
        struct ext4_iloc iloc;
+       int ret = 0, ret2;
+
+       if (unlikely(copied < len) && !PageUptodate(page))
+               copied = 0;
 
-       if (unlikely(copied < len)) {
-               if (!PageUptodate(page)) {
-                       copied = 0;
+       if (likely(copied)) {
+               ret = ext4_get_inode_loc(inode, &iloc);
+               if (ret) {
+                       unlock_page(page);
+                       put_page(page);
+                       ext4_std_error(inode->i_sb, ret);
                        goto out;
                }
-       }
+               ext4_write_lock_xattr(inode, &no_expand);
+               BUG_ON(!ext4_has_inline_data(inode));
 
-       ret = ext4_get_inode_loc(inode, &iloc);
-       if (ret) {
-               ext4_std_error(inode->i_sb, ret);
-               copied = 0;
-               goto out;
-       }
+               /*
+                * ei->i_inline_off may have changed since
+                * ext4_write_begin() called
+                * ext4_try_to_write_inline_data()
+                */
+               (void) ext4_find_inline_data_nolock(inode);
 
-       ext4_write_lock_xattr(inode, &no_expand);
-       BUG_ON(!ext4_has_inline_data(inode));
+               kaddr = kmap_atomic(page);
+               ext4_write_inline_data(inode, &iloc, kaddr, pos, copied);
+               kunmap_atomic(kaddr);
+               SetPageUptodate(page);
+               /* clear page dirty so that writepages wouldn't work for us. */
+               ClearPageDirty(page);
 
-       /*
-        * ei->i_inline_off may have changed since ext4_write_begin()
-        * called ext4_try_to_write_inline_data()
-        */
-       (void) ext4_find_inline_data_nolock(inode);
+               ext4_write_unlock_xattr(inode, &no_expand);
+               brelse(iloc.bh);
 
-       kaddr = kmap_atomic(page);
-       ext4_write_inline_data(inode, &iloc, kaddr, pos, len);
-       kunmap_atomic(kaddr);
-       SetPageUptodate(page);
-       /* clear page dirty so that writepages wouldn't work for us. */
-       ClearPageDirty(page);
+               /*
+                * It's important to update i_size while still holding page
+                * lock: page writeout could otherwise come in and zero
+                * beyond i_size.
+                */
+               ext4_update_inode_size(inode, pos + copied);
+       }
+       unlock_page(page);
+       put_page(page);
 
-       ext4_write_unlock_xattr(inode, &no_expand);
-       brelse(iloc.bh);
-       mark_inode_dirty(inode);
+       /*
+        * Don't mark the inode dirty under page lock. First, it unnecessarily
+        * makes the holding time of page lock longer. Second, it forces lock
+        * ordering of page lock and transaction start for journaling
+        * filesystems.
+        */
+       if (likely(copied))
+               mark_inode_dirty(inode);
 out:
-       return copied;
+       /*
+        * If we didn't copy as much data as expected, we need to trim back
+        * size of xattr containing inline data.
+        */
+       if (pos + len > inode->i_size && ext4_can_truncate(inode))
+               ext4_orphan_add(handle, inode);
+
+       ret2 = ext4_journal_stop(handle);
+       if (!ret)
+               ret = ret2;
+       if (pos + len > inode->i_size) {
+               ext4_truncate_failed_write(inode);
+               /*
+                * If truncate failed early the inode might still be
+                * on the orphan list; we need to make sure the inode
+                * is removed from the orphan list in that case.
+                */
+               if (inode->i_nlink)
+                       ext4_orphan_del(NULL, inode);
+       }
+       return ret ? ret : copied;
 }
 
 struct buffer_head *
@@ -953,43 +992,6 @@ out:
        return ret;
 }
 
-int ext4_da_write_inline_data_end(struct inode *inode, loff_t pos,
-                                 unsigned len, unsigned copied,
-                                 struct page *page)
-{
-       int ret;
-
-       ret = ext4_write_inline_data_end(inode, pos, len, copied, page);
-       if (ret < 0) {
-               unlock_page(page);
-               put_page(page);
-               return ret;
-       }
-       copied = ret;
-
-       /*
-        * No need to use i_size_read() here, the i_size
-        * cannot change under us because we hold i_mutex.
-        *
-        * But it's important to update i_size while still holding page lock:
-        * page writeout could otherwise come in and zero beyond i_size.
-        */
-       if (pos+copied > inode->i_size)
-               i_size_write(inode, pos+copied);
-       unlock_page(page);
-       put_page(page);
-
-       /*
-        * Don't mark the inode dirty under page lock. First, it unnecessarily
-        * makes the holding time of page lock longer. Second, it forces lock
-        * ordering of page lock and transaction start for journaling
-        * filesystems.
-        */
-       mark_inode_dirty(inode);
-
-       return copied;
-}
-
 #ifdef INLINE_DIR_DEBUG
 void ext4_show_inline_dir(struct inode *dir, struct buffer_head *bh,
                          void *inline_start, int inline_size)
@@ -1917,6 +1919,24 @@ int ext4_inline_data_truncate(struct inode *inode, int *has_inline)
        EXT4_I(inode)->i_disksize = i_size;
 
        if (i_size < inline_size) {
+               /*
+                * if there's inline data to truncate and this file was
+                * converted to extents after that inline data was written,
+                * the extent status cache must be cleared to avoid leaving
+                * behind stale delayed allocated extent entries
+                */
+               if (!ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA)) {
+retry:
+                       err = ext4_es_remove_extent(inode, 0, EXT_MAX_BLOCKS);
+                       if (err == -ENOMEM) {
+                               cond_resched();
+                               congestion_wait(BLK_RW_ASYNC, HZ/50);
+                               goto retry;
+                       }
+                       if (err)
+                               goto out_error;
+               }
+
                /* Clear the content in the xattr space. */
                if (inline_size > EXT4_MIN_INLINE_DATA_SIZE) {
                        if ((err = ext4_xattr_ibody_find(inode, &i, &is)) != 0)
index d18852d..0f06305 100644 (file)
@@ -1284,22 +1284,14 @@ static int ext4_write_end(struct file *file,
        loff_t old_size = inode->i_size;
        int ret = 0, ret2;
        int i_size_changed = 0;
-       int inline_data = ext4_has_inline_data(inode);
        bool verity = ext4_verity_in_progress(inode);
 
        trace_ext4_write_end(inode, pos, len, copied);
-       if (inline_data) {
-               ret = ext4_write_inline_data_end(inode, pos, len,
-                                                copied, page);
-               if (ret < 0) {
-                       unlock_page(page);
-                       put_page(page);
-                       goto errout;
-               }
-               copied = ret;
-       } else
-               copied = block_write_end(file, mapping, pos,
-                                        len, copied, page, fsdata);
+
+       if (ext4_has_inline_data(inode))
+               return ext4_write_inline_data_end(inode, pos, len, copied, page);
+
+       copied = block_write_end(file, mapping, pos, len, copied, page, fsdata);
        /*
         * it's important to update i_size while still holding page lock:
         * page writeout could otherwise come in and zero beyond i_size.
@@ -1320,7 +1312,7 @@ static int ext4_write_end(struct file *file,
         * ordering of page lock and transaction start for journaling
         * filesystems.
         */
-       if (i_size_changed || inline_data)
+       if (i_size_changed)
                ret = ext4_mark_inode_dirty(handle, inode);
 
        if (pos + len > inode->i_size && !verity && ext4_can_truncate(inode))
@@ -1329,7 +1321,7 @@ static int ext4_write_end(struct file *file,
                 * inode->i_size. So truncate them
                 */
                ext4_orphan_add(handle, inode);
-errout:
+
        ret2 = ext4_journal_stop(handle);
        if (!ret)
                ret = ret2;
@@ -1395,7 +1387,6 @@ static int ext4_journalled_write_end(struct file *file,
        int partial = 0;
        unsigned from, to;
        int size_changed = 0;
-       int inline_data = ext4_has_inline_data(inode);
        bool verity = ext4_verity_in_progress(inode);
 
        trace_ext4_journalled_write_end(inode, pos, len, copied);
@@ -1404,16 +1395,10 @@ static int ext4_journalled_write_end(struct file *file,
 
        BUG_ON(!ext4_handle_valid(handle));
 
-       if (inline_data) {
-               ret = ext4_write_inline_data_end(inode, pos, len,
-                                                copied, page);
-               if (ret < 0) {
-                       unlock_page(page);
-                       put_page(page);
-                       goto errout;
-               }
-               copied = ret;
-       } else if (unlikely(copied < len) && !PageUptodate(page)) {
+       if (ext4_has_inline_data(inode))
+               return ext4_write_inline_data_end(inode, pos, len, copied, page);
+
+       if (unlikely(copied < len) && !PageUptodate(page)) {
                copied = 0;
                ext4_journalled_zero_new_buffers(handle, inode, page, from, to);
        } else {
@@ -1436,7 +1421,7 @@ static int ext4_journalled_write_end(struct file *file,
        if (old_size < pos && !verity)
                pagecache_isize_extended(inode, old_size, pos);
 
-       if (size_changed || inline_data) {
+       if (size_changed) {
                ret2 = ext4_mark_inode_dirty(handle, inode);
                if (!ret)
                        ret = ret2;
@@ -1449,7 +1434,6 @@ static int ext4_journalled_write_end(struct file *file,
                 */
                ext4_orphan_add(handle, inode);
 
-errout:
        ret2 = ext4_journal_stop(handle);
        if (!ret)
                ret = ret2;
@@ -1644,6 +1628,7 @@ static int ext4_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk)
        struct ext4_sb_info *sbi = EXT4_SB(inode->i_sb);
        int ret;
        bool allocated = false;
+       bool reserved = false;
 
        /*
         * If the cluster containing lblk is shared with a delayed,
@@ -1660,6 +1645,7 @@ static int ext4_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk)
                ret = ext4_da_reserve_space(inode);
                if (ret != 0)   /* ENOSPC */
                        goto errout;
+               reserved = true;
        } else {   /* bigalloc */
                if (!ext4_es_scan_clu(inode, &ext4_es_is_delonly, lblk)) {
                        if (!ext4_es_scan_clu(inode,
@@ -1672,6 +1658,7 @@ static int ext4_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk)
                                        ret = ext4_da_reserve_space(inode);
                                        if (ret != 0)   /* ENOSPC */
                                                goto errout;
+                                       reserved = true;
                                } else {
                                        allocated = true;
                                }
@@ -1682,6 +1669,8 @@ static int ext4_insert_delayed_block(struct inode *inode, ext4_lblk_t lblk)
        }
 
        ret = ext4_es_insert_delayed_block(inode, lblk, allocated);
+       if (ret && reserved)
+               ext4_da_release_space(inode, 1);
 
 errout:
        return ret;
@@ -1722,13 +1711,16 @@ static int ext4_da_map_blocks(struct inode *inode, sector_t iblock,
                }
 
                /*
-                * Delayed extent could be allocated by fallocate.
-                * So we need to check it.
+                * the buffer head associated with a delayed and not unwritten
+                * block found in the extent status cache must contain an
+                * invalid block number and have its BH_New and BH_Delay bits
+                * set, reflecting the state assigned when the block was
+                * initially delayed allocated
                 */
-               if (ext4_es_is_delayed(&es) && !ext4_es_is_unwritten(&es)) {
-                       map_bh(bh, inode->i_sb, invalid_block);
-                       set_buffer_new(bh);
-                       set_buffer_delay(bh);
+               if (ext4_es_is_delonly(&es)) {
+                       BUG_ON(bh->b_blocknr != invalid_block);
+                       BUG_ON(!buffer_new(bh));
+                       BUG_ON(!buffer_delay(bh));
                        return 0;
                }
 
@@ -2932,19 +2924,6 @@ static int ext4_nonda_switch(struct super_block *sb)
        return 0;
 }
 
-/* We always reserve for an inode update; the superblock could be there too */
-static int ext4_da_write_credits(struct inode *inode, loff_t pos, unsigned len)
-{
-       if (likely(ext4_has_feature_large_file(inode->i_sb)))
-               return 1;
-
-       if (pos + len <= 0x7fffffffULL)
-               return 1;
-
-       /* We might need to update the superblock to set LARGE_FILE */
-       return 2;
-}
-
 static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
                               loff_t pos, unsigned len, unsigned flags,
                               struct page **pagep, void **fsdata)
@@ -2953,7 +2932,6 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
        struct page *page;
        pgoff_t index;
        struct inode *inode = mapping->host;
-       handle_t *handle;
 
        if (unlikely(ext4_forced_shutdown(EXT4_SB(inode->i_sb))))
                return -EIO;
@@ -2979,41 +2957,11 @@ static int ext4_da_write_begin(struct file *file, struct address_space *mapping,
                        return 0;
        }
 
-       /*
-        * grab_cache_page_write_begin() can take a long time if the
-        * system is thrashing due to memory pressure, or if the page
-        * is being written back.  So grab it first before we start
-        * the transaction handle.  This also allows us to allocate
-        * the page (if needed) without using GFP_NOFS.
-        */
-retry_grab:
+retry:
        page = grab_cache_page_write_begin(mapping, index, flags);
        if (!page)
                return -ENOMEM;
-       unlock_page(page);
 
-       /*
-        * With delayed allocation, we don't log the i_disksize update
-        * if there is delayed block allocation. But we still need
-        * to journalling the i_disksize update if writes to the end
-        * of file which has an already mapped buffer.
-        */
-retry_journal:
-       handle = ext4_journal_start(inode, EXT4_HT_WRITE_PAGE,
-                               ext4_da_write_credits(inode, pos, len));
-       if (IS_ERR(handle)) {
-               put_page(page);
-               return PTR_ERR(handle);
-       }
-
-       lock_page(page);
-       if (page->mapping != mapping) {
-               /* The page got truncated from under us */
-               unlock_page(page);
-               put_page(page);
-               ext4_journal_stop(handle);
-               goto retry_grab;
-       }
        /* In case writeback began while the page was unlocked */
        wait_for_stable_page(page);
 
@@ -3025,20 +2973,18 @@ retry_journal:
 #endif
        if (ret < 0) {
                unlock_page(page);
-               ext4_journal_stop(handle);
+               put_page(page);
                /*
                 * block_write_begin may have instantiated a few blocks
                 * outside i_size.  Trim these off again. Don't need
-                * i_size_read because we hold i_mutex.
+                * i_size_read because we hold inode lock.
                 */
                if (pos + len > inode->i_size)
                        ext4_truncate_failed_write(inode);
 
                if (ret == -ENOSPC &&
                    ext4_should_retry_alloc(inode->i_sb, &retries))
-                       goto retry_journal;
-
-               put_page(page);
+                       goto retry;
                return ret;
        }
 
@@ -3075,8 +3021,6 @@ static int ext4_da_write_end(struct file *file,
                             struct page *page, void *fsdata)
 {
        struct inode *inode = mapping->host;
-       int ret = 0, ret2;
-       handle_t *handle = ext4_journal_current_handle();
        loff_t new_i_size;
        unsigned long start, end;
        int write_mode = (int)(unsigned long)fsdata;
@@ -3086,44 +3030,36 @@ static int ext4_da_write_end(struct file *file,
                                      len, copied, page, fsdata);
 
        trace_ext4_da_write_end(inode, pos, len, copied);
+
+       if (write_mode != CONVERT_INLINE_DATA &&
+           ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) &&
+           ext4_has_inline_data(inode))
+               return ext4_write_inline_data_end(inode, pos, len, copied, page);
+
        start = pos & (PAGE_SIZE - 1);
        end = start + copied - 1;
 
        /*
-        * generic_write_end() will run mark_inode_dirty() if i_size
-        * changes.  So let's piggyback the i_disksize mark_inode_dirty
-        * into that.
+        * Since we are holding inode lock, we are sure i_disksize <=
+        * i_size. We also know that if i_disksize < i_size, there are
+        * delalloc writes pending in the range upto i_size. If the end of
+        * the current write is <= i_size, there's no need to touch
+        * i_disksize since writeback will push i_disksize upto i_size
+        * eventually. If the end of the current write is > i_size and
+        * inside an allocated block (ext4_da_should_update_i_disksize()
+        * check), we need to update i_disksize here as neither
+        * ext4_writepage() nor certain ext4_writepages() paths not
+        * allocating blocks update i_disksize.
+        *
+        * Note that we defer inode dirtying to generic_write_end() /
+        * ext4_da_write_inline_data_end().
         */
        new_i_size = pos + copied;
-       if (copied && new_i_size > EXT4_I(inode)->i_disksize) {
-               if (ext4_has_inline_data(inode) ||
-                   ext4_da_should_update_i_disksize(page, end)) {
-                       ext4_update_i_disksize(inode, new_i_size);
-                       /* We need to mark inode dirty even if
-                        * new_i_size is less that inode->i_size
-                        * bu greater than i_disksize.(hint delalloc)
-                        */
-                       ret = ext4_mark_inode_dirty(handle, inode);
-               }
-       }
+       if (copied && new_i_size > inode->i_size &&
+           ext4_da_should_update_i_disksize(page, end))
+               ext4_update_i_disksize(inode, new_i_size);
 
-       if (write_mode != CONVERT_INLINE_DATA &&
-           ext4_test_inode_state(inode, EXT4_STATE_MAY_INLINE_DATA) &&
-           ext4_has_inline_data(inode))
-               ret2 = ext4_da_write_inline_data_end(inode, pos, len, copied,
-                                                    page);
-       else
-               ret2 = generic_write_end(file, mapping, pos, len, copied,
-                                                       page, fsdata);
-
-       copied = ret2;
-       if (ret2 < 0)
-               ret = ret2;
-       ret2 = ext4_journal_stop(handle);
-       if (unlikely(ret2 && !ret))
-               ret = ret2;
-
-       return ret ? ret : copied;
+       return generic_write_end(file, mapping, pos, len, copied, page, fsdata);
 }
 
 /*
@@ -4340,6 +4276,12 @@ static int __ext4_get_inode_loc(struct super_block *sb, unsigned long ino,
                goto has_buffer;
 
        lock_buffer(bh);
+       if (ext4_buffer_uptodate(bh)) {
+               /* Someone brought it uptodate while we waited */
+               unlock_buffer(bh);
+               goto has_buffer;
+       }
+
        /*
         * If we have all information of the inode in memory and this
         * is the only valid inode in the block, we need not read the
index 0775950..88d5d27 100644 (file)
@@ -658,7 +658,7 @@ static void ext4_handle_error(struct super_block *sb, bool force_ro, int error,
                 * constraints, it may not be safe to do it right here so we
                 * defer superblock flushing to a workqueue.
                 */
-               if (continue_fs)
+               if (continue_fs && journal)
                        schedule_work(&EXT4_SB(sb)->s_error_work);
                else
                        ext4_commit_super(sb);
@@ -1350,6 +1350,12 @@ static void ext4_destroy_inode(struct inode *inode)
                                true);
                dump_stack();
        }
+
+       if (EXT4_I(inode)->i_reserved_data_blocks)
+               ext4_msg(inode->i_sb, KERN_ERR,
+                        "Inode %lu (%p): i_reserved_data_blocks (%u) not cleared!",
+                        inode->i_ino, EXT4_I(inode),
+                        EXT4_I(inode)->i_reserved_data_blocks);
 }
 
 static void init_once(void *foo)
@@ -3021,17 +3027,17 @@ static loff_t ext4_max_size(int blkbits, int has_huge_files)
  */
 static loff_t ext4_max_bitmap_size(int bits, int has_huge_files)
 {
-       loff_t res = EXT4_NDIR_BLOCKS;
+       unsigned long long upper_limit, res = EXT4_NDIR_BLOCKS;
        int meta_blocks;
-       loff_t upper_limit;
-       /* This is calculated to be the largest file size for a dense, block
+
+       /*
+        * This is calculated to be the largest file size for a dense, block
         * mapped file such that the file's total number of 512-byte sectors,
         * including data and all indirect blocks, does not exceed (2^48 - 1).
         *
         * __u32 i_blocks_lo and _u16 i_blocks_high represent the total
         * number of 512-byte sectors of the file.
         */
-
        if (!has_huge_files) {
                /*
                 * !has_huge_files or implies that the inode i_block field
@@ -3074,7 +3080,7 @@ static loff_t ext4_max_bitmap_size(int bits, int has_huge_files)
        if (res > MAX_LFS_FILESIZE)
                res = MAX_LFS_FILESIZE;
 
-       return res;
+       return (loff_t)res;
 }
 
 static ext4_fsblk_t descriptor_loc(struct super_block *sb,
@@ -5042,12 +5048,15 @@ failed_mount_wq:
        sbi->s_ea_block_cache = NULL;
 
        if (sbi->s_journal) {
+               /* flush s_error_work before journal destroy. */
+               flush_work(&sbi->s_error_work);
                jbd2_journal_destroy(sbi->s_journal);
                sbi->s_journal = NULL;
        }
 failed_mount3a:
        ext4_es_unregister_shrinker(sbi);
 failed_mount3:
+       /* flush s_error_work before sbi destroy */
        flush_work(&sbi->s_error_work);
        del_timer_sync(&sbi->s_err_report);
        ext4_stop_mmpd(sbi);
index f346a78..6a67565 100644 (file)
@@ -77,7 +77,6 @@ static WORK_STATE(INIT_OBJECT,                "INIT", fscache_initialise_object);
 static WORK_STATE(PARENT_READY,                "PRDY", fscache_parent_ready);
 static WORK_STATE(ABORT_INIT,          "ABRT", fscache_abort_initialisation);
 static WORK_STATE(LOOK_UP_OBJECT,      "LOOK", fscache_look_up_object);
-static WORK_STATE(CREATE_OBJECT,       "CRTO", fscache_look_up_object);
 static WORK_STATE(OBJECT_AVAILABLE,    "AVBL", fscache_object_available);
 static WORK_STATE(JUMPSTART_DEPS,      "JUMP", fscache_jumpstart_dependents);
 
@@ -907,6 +906,7 @@ static void fscache_dequeue_object(struct fscache_object *object)
  * @object: The object to ask about
  * @data: The auxiliary data for the object
  * @datalen: The size of the auxiliary data
+ * @object_size: The size of the object according to the server.
  *
  * This function consults the netfs about the coherency state of an object.
  * The caller must be holding a ref on cookie->n_active (held by
index 4338771..e002cdf 100644 (file)
@@ -22,7 +22,10 @@ static void fscache_operation_dummy_cancel(struct fscache_operation *op)
 
 /**
  * fscache_operation_init - Do basic initialisation of an operation
+ * @cookie: The cookie to operate on
  * @op: The operation to initialise
+ * @processor: The function to perform the operation
+ * @cancel: A function to handle operation cancellation
  * @release: The release function to assign
  *
  * Do basic initialisation of an operation.  The caller must still set flags,
index 37710ca..ed0cab8 100644 (file)
@@ -190,8 +190,10 @@ int inode_init_always(struct super_block *sb, struct inode *inode)
        mapping_set_gfp_mask(mapping, GFP_HIGHUSER_MOVABLE);
        mapping->private_data = NULL;
        mapping->writeback_index = 0;
-       __init_rwsem(&mapping->invalidate_lock, "mapping.invalidate_lock",
-                    &sb->s_type->invalidate_lock_key);
+       init_rwsem(&mapping->invalidate_lock);
+       lockdep_set_class_and_name(&mapping->invalidate_lock,
+                                  &sb->s_type->invalidate_lock_key,
+                                  "mapping.invalidate_lock");
        inode->i_private = NULL;
        inode->i_mapping = mapping;
        INIT_HLIST_HEAD(&inode->i_dentry);      /* buggered by rcu freeing */
index 6c55362..5bf8aa8 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/rculist_nulls.h>
 #include <linux/cpu.h>
 #include <linux/tracehook.h>
+#include <uapi/linux/io_uring.h>
 
 #include "io-wq.h"
 
@@ -176,7 +177,6 @@ static void io_worker_ref_put(struct io_wq *wq)
 static void io_worker_exit(struct io_worker *worker)
 {
        struct io_wqe *wqe = worker->wqe;
-       struct io_wqe_acct *acct = io_wqe_get_acct(worker);
 
        if (refcount_dec_and_test(&worker->ref))
                complete(&worker->ref_done);
@@ -186,7 +186,6 @@ static void io_worker_exit(struct io_worker *worker)
        if (worker->flags & IO_WORKER_F_FREE)
                hlist_nulls_del_rcu(&worker->nulls_node);
        list_del_rcu(&worker->all_list);
-       acct->nr_workers--;
        preempt_disable();
        io_wqe_dec_running(worker);
        worker->flags = 0;
@@ -246,8 +245,6 @@ static bool io_wqe_activate_free_worker(struct io_wqe *wqe,
  */
 static bool io_wqe_create_worker(struct io_wqe *wqe, struct io_wqe_acct *acct)
 {
-       bool do_create = false;
-
        /*
         * Most likely an attempt to queue unbounded work on an io_wq that
         * wasn't setup with any unbounded workers.
@@ -256,18 +253,15 @@ static bool io_wqe_create_worker(struct io_wqe *wqe, struct io_wqe_acct *acct)
                pr_warn_once("io-wq is not configured for unbound workers");
 
        raw_spin_lock(&wqe->lock);
-       if (acct->nr_workers < acct->max_workers) {
-               acct->nr_workers++;
-               do_create = true;
+       if (acct->nr_workers == acct->max_workers) {
+               raw_spin_unlock(&wqe->lock);
+               return true;
        }
+       acct->nr_workers++;
        raw_spin_unlock(&wqe->lock);
-       if (do_create) {
-               atomic_inc(&acct->nr_running);
-               atomic_inc(&wqe->wq->worker_refs);
-               return create_io_worker(wqe->wq, wqe, acct->index);
-       }
-
-       return true;
+       atomic_inc(&acct->nr_running);
+       atomic_inc(&wqe->wq->worker_refs);
+       return create_io_worker(wqe->wq, wqe, acct->index);
 }
 
 static void io_wqe_inc_running(struct io_worker *worker)
@@ -574,6 +568,7 @@ loop:
                }
                /* timed out, exit unless we're the last worker */
                if (last_timeout && acct->nr_workers > 1) {
+                       acct->nr_workers--;
                        raw_spin_unlock(&wqe->lock);
                        __set_current_state(TASK_RUNNING);
                        break;
@@ -589,9 +584,7 @@ loop:
 
                        if (!get_signal(&ksig))
                                continue;
-                       if (fatal_signal_pending(current))
-                               break;
-                       continue;
+                       break;
                }
                last_timeout = !ret;
        }
@@ -1287,6 +1280,10 @@ int io_wq_max_workers(struct io_wq *wq, int *new_count)
 {
        int i, node, prev = 0;
 
+       BUILD_BUG_ON((int) IO_WQ_ACCT_BOUND   != (int) IO_WQ_BOUND);
+       BUILD_BUG_ON((int) IO_WQ_ACCT_UNBOUND != (int) IO_WQ_UNBOUND);
+       BUILD_BUG_ON((int) IO_WQ_ACCT_NR      != 2);
+
        for (i = 0; i < 2; i++) {
                if (new_count[i] > task_rlimit(current, RLIMIT_NPROC))
                        new_count[i] = task_rlimit(current, RLIMIT_NPROC);
index 16fb743..e68d278 100644 (file)
@@ -403,7 +403,6 @@ struct io_ring_ctx {
                struct wait_queue_head  cq_wait;
                unsigned                cq_extra;
                atomic_t                cq_timeouts;
-               struct fasync_struct    *cq_fasync;
                unsigned                cq_last_tm_flush;
        } ____cacheline_aligned_in_smp;
 
@@ -502,6 +501,7 @@ struct io_poll_update {
 struct io_close {
        struct file                     *file;
        int                             fd;
+       u32                             file_slot;
 };
 
 struct io_timeout_data {
@@ -712,6 +712,7 @@ struct io_async_rw {
        struct iovec                    fast_iov[UIO_FASTIOV];
        const struct iovec              *free_iovec;
        struct iov_iter                 iter;
+       struct iov_iter_state           iter_state;
        size_t                          bytes_done;
        struct wait_page_queue          wpq;
 };
@@ -735,7 +736,6 @@ enum {
        REQ_F_BUFFER_SELECTED_BIT,
        REQ_F_COMPLETE_INLINE_BIT,
        REQ_F_REISSUE_BIT,
-       REQ_F_DONT_REISSUE_BIT,
        REQ_F_CREDS_BIT,
        REQ_F_REFCOUNT_BIT,
        REQ_F_ARM_LTIMEOUT_BIT,
@@ -782,8 +782,6 @@ enum {
        REQ_F_COMPLETE_INLINE   = BIT(REQ_F_COMPLETE_INLINE_BIT),
        /* caller should reissue async */
        REQ_F_REISSUE           = BIT(REQ_F_REISSUE_BIT),
-       /* don't attempt request reissue, see io_rw_reissue() */
-       REQ_F_DONT_REISSUE      = BIT(REQ_F_DONT_REISSUE_BIT),
        /* supports async reads */
        REQ_F_NOWAIT_READ       = BIT(REQ_F_NOWAIT_READ_BIT),
        /* supports async writes */
@@ -1100,6 +1098,8 @@ static int io_req_prep_async(struct io_kiocb *req);
 
 static int io_install_fixed_file(struct io_kiocb *req, struct file *file,
                                 unsigned int issue_flags, u32 slot_index);
+static int io_close_fixed(struct io_kiocb *req, unsigned int issue_flags);
+
 static enum hrtimer_restart io_link_timeout_fn(struct hrtimer *timer);
 
 static struct kmem_cache *req_cachep;
@@ -1613,10 +1613,8 @@ static void io_cqring_ev_posted(struct io_ring_ctx *ctx)
                wake_up(&ctx->sq_data->wait);
        if (io_should_trigger_evfd(ctx))
                eventfd_signal(ctx->cq_ev_fd, 1);
-       if (waitqueue_active(&ctx->poll_wait)) {
+       if (waitqueue_active(&ctx->poll_wait))
                wake_up_interruptible(&ctx->poll_wait);
-               kill_fasync(&ctx->cq_fasync, SIGIO, POLL_IN);
-       }
 }
 
 static void io_cqring_ev_posted_iopoll(struct io_ring_ctx *ctx)
@@ -1630,10 +1628,8 @@ static void io_cqring_ev_posted_iopoll(struct io_ring_ctx *ctx)
        }
        if (io_should_trigger_evfd(ctx))
                eventfd_signal(ctx->cq_ev_fd, 1);
-       if (waitqueue_active(&ctx->poll_wait)) {
+       if (waitqueue_active(&ctx->poll_wait))
                wake_up_interruptible(&ctx->poll_wait);
-               kill_fasync(&ctx->cq_fasync, SIGIO, POLL_IN);
-       }
 }
 
 /* Returns true if there are no backlogged entries after the flush */
@@ -2444,13 +2440,6 @@ static void io_iopoll_complete(struct io_ring_ctx *ctx, unsigned int *nr_events,
                req = list_first_entry(done, struct io_kiocb, inflight_entry);
                list_del(&req->inflight_entry);
 
-               if (READ_ONCE(req->result) == -EAGAIN &&
-                   !(req->flags & REQ_F_DONT_REISSUE)) {
-                       req->iopoll_completed = 0;
-                       io_req_task_queue_reissue(req);
-                       continue;
-               }
-
                __io_cqring_fill_event(ctx, req->user_data, req->result,
                                        io_put_rw_kbuf(req));
                (*nr_events)++;
@@ -2613,8 +2602,7 @@ static bool io_resubmit_prep(struct io_kiocb *req)
 
        if (!rw)
                return !io_req_prep_async(req);
-       /* may have left rw->iter inconsistent on -EIOCBQUEUED */
-       iov_iter_revert(&rw->iter, req->result - iov_iter_count(&rw->iter));
+       iov_iter_restore(&rw->iter, &rw->iter_state);
        return true;
 }
 
@@ -2714,10 +2702,9 @@ static void io_complete_rw_iopoll(struct kiocb *kiocb, long res, long res2)
        if (kiocb->ki_flags & IOCB_WRITE)
                kiocb_end_write(req);
        if (unlikely(res != req->result)) {
-               if (!(res == -EAGAIN && io_rw_should_reissue(req) &&
-                   io_resubmit_prep(req))) {
-                       req_set_fail(req);
-                       req->flags |= REQ_F_DONT_REISSUE;
+               if (res == -EAGAIN && io_rw_should_reissue(req)) {
+                       req->flags |= REQ_F_REISSUE;
+                       return;
                }
        }
 
@@ -2843,7 +2830,8 @@ static bool io_file_supports_nowait(struct io_kiocb *req, int rw)
        return __io_file_supports_nowait(req->file, rw);
 }
 
-static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe)
+static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe,
+                     int rw)
 {
        struct io_ring_ctx *ctx = req->ctx;
        struct kiocb *kiocb = &req->rw.kiocb;
@@ -2865,8 +2853,13 @@ static int io_prep_rw(struct io_kiocb *req, const struct io_uring_sqe *sqe)
        if (unlikely(ret))
                return ret;
 
-       /* don't allow async punt for O_NONBLOCK or RWF_NOWAIT */
-       if ((kiocb->ki_flags & IOCB_NOWAIT) || (file->f_flags & O_NONBLOCK))
+       /*
+        * If the file is marked O_NONBLOCK, still allow retry for it if it
+        * supports async. Otherwise it's impossible to use O_NONBLOCK files
+        * reliably. If not, or it IOCB_NOWAIT is set, don't retry.
+        */
+       if ((kiocb->ki_flags & IOCB_NOWAIT) ||
+           ((file->f_flags & O_NONBLOCK) && !io_file_supports_nowait(req, rw)))
                req->flags |= REQ_F_NOWAIT;
 
        ioprio = READ_ONCE(sqe->ioprio);
@@ -2931,7 +2924,6 @@ static void kiocb_done(struct kiocb *kiocb, ssize_t ret,
 {
        struct io_kiocb *req = container_of(kiocb, struct io_kiocb, rw.kiocb);
        struct io_async_rw *io = req->async_data;
-       bool check_reissue = kiocb->ki_complete == io_complete_rw;
 
        /* add previously done IO, if any */
        if (io && io->bytes_done > 0) {
@@ -2943,19 +2935,27 @@ static void kiocb_done(struct kiocb *kiocb, ssize_t ret,
 
        if (req->flags & REQ_F_CUR_POS)
                req->file->f_pos = kiocb->ki_pos;
-       if (ret >= 0 && check_reissue)
+       if (ret >= 0 && (kiocb->ki_complete == io_complete_rw))
                __io_complete_rw(req, ret, 0, issue_flags);
        else
                io_rw_done(kiocb, ret);
 
-       if (check_reissue && (req->flags & REQ_F_REISSUE)) {
+       if (req->flags & REQ_F_REISSUE) {
                req->flags &= ~REQ_F_REISSUE;
                if (io_resubmit_prep(req)) {
                        io_req_task_queue_reissue(req);
                } else {
+                       unsigned int cflags = io_put_rw_kbuf(req);
+                       struct io_ring_ctx *ctx = req->ctx;
+
                        req_set_fail(req);
-                       __io_req_complete(req, issue_flags, ret,
-                                         io_put_rw_kbuf(req));
+                       if (!(issue_flags & IO_URING_F_NONBLOCK)) {
+                               mutex_lock(&ctx->uring_lock);
+                               __io_req_complete(req, issue_flags, ret, cflags);
+                               mutex_unlock(&ctx->uring_lock);
+                       } else {
+                               __io_req_complete(req, issue_flags, ret, cflags);
+                       }
                }
        }
 }
@@ -3263,12 +3263,15 @@ static ssize_t loop_rw_iter(int rw, struct io_kiocb *req, struct iov_iter *iter)
                                ret = nr;
                        break;
                }
+               if (!iov_iter_is_bvec(iter)) {
+                       iov_iter_advance(iter, nr);
+               } else {
+                       req->rw.len -= nr;
+                       req->rw.addr += nr;
+               }
                ret += nr;
                if (nr != iovec.iov_len)
                        break;
-               req->rw.len -= nr;
-               req->rw.addr += nr;
-               iov_iter_advance(iter, nr);
        }
 
        return ret;
@@ -3315,12 +3318,17 @@ static int io_setup_async_rw(struct io_kiocb *req, const struct iovec *iovec,
        if (!force && !io_op_defs[req->opcode].needs_async_setup)
                return 0;
        if (!req->async_data) {
+               struct io_async_rw *iorw;
+
                if (io_alloc_async_data(req)) {
                        kfree(iovec);
                        return -ENOMEM;
                }
 
                io_req_map_rw(req, iovec, fast_iov, iter);
+               iorw = req->async_data;
+               /* we've copied and mapped the iter, ensure state is saved */
+               iov_iter_save_state(&iorw->iter, &iorw->iter_state);
        }
        return 0;
 }
@@ -3339,6 +3347,7 @@ static inline int io_rw_prep_async(struct io_kiocb *req, int rw)
        iorw->free_iovec = iov;
        if (iov)
                req->flags |= REQ_F_NEED_CLEANUP;
+       iov_iter_save_state(&iorw->iter, &iorw->iter_state);
        return 0;
 }
 
@@ -3346,7 +3355,7 @@ static int io_read_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 {
        if (unlikely(!(req->file->f_mode & FMODE_READ)))
                return -EBADF;
-       return io_prep_rw(req, sqe);
+       return io_prep_rw(req, sqe, READ);
 }
 
 /*
@@ -3442,19 +3451,28 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags)
        struct kiocb *kiocb = &req->rw.kiocb;
        struct iov_iter __iter, *iter = &__iter;
        struct io_async_rw *rw = req->async_data;
-       ssize_t io_size, ret, ret2;
        bool force_nonblock = issue_flags & IO_URING_F_NONBLOCK;
+       struct iov_iter_state __state, *state;
+       ssize_t ret, ret2;
 
        if (rw) {
                iter = &rw->iter;
+               state = &rw->iter_state;
+               /*
+                * We come here from an earlier attempt, restore our state to
+                * match in case it doesn't. It's cheap enough that we don't
+                * need to make this conditional.
+                */
+               iov_iter_restore(iter, state);
                iovec = NULL;
        } else {
                ret = io_import_iovec(READ, req, &iovec, iter, !force_nonblock);
                if (ret < 0)
                        return ret;
+               state = &__state;
+               iov_iter_save_state(iter, state);
        }
-       io_size = iov_iter_count(iter);
-       req->result = io_size;
+       req->result = iov_iter_count(iter);
 
        /* Ensure we clear previously set non-block flag */
        if (!force_nonblock)
@@ -3468,7 +3486,7 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags)
                return ret ?: -EAGAIN;
        }
 
-       ret = rw_verify_area(READ, req->file, io_kiocb_ppos(kiocb), io_size);
+       ret = rw_verify_area(READ, req->file, io_kiocb_ppos(kiocb), req->result);
        if (unlikely(ret)) {
                kfree(iovec);
                return ret;
@@ -3484,30 +3502,49 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags)
                /* no retry on NONBLOCK nor RWF_NOWAIT */
                if (req->flags & REQ_F_NOWAIT)
                        goto done;
-               /* some cases will consume bytes even on error returns */
-               iov_iter_reexpand(iter, iter->count + iter->truncated);
-               iov_iter_revert(iter, io_size - iov_iter_count(iter));
                ret = 0;
        } else if (ret == -EIOCBQUEUED) {
                goto out_free;
-       } else if (ret <= 0 || ret == io_size || !force_nonblock ||
+       } else if (ret <= 0 || ret == req->result || !force_nonblock ||
                   (req->flags & REQ_F_NOWAIT) || !need_read_all(req)) {
                /* read all, failed, already did sync or don't want to retry */
                goto done;
        }
 
+       /*
+        * Don't depend on the iter state matching what was consumed, or being
+        * untouched in case of error. Restore it and we'll advance it
+        * manually if we need to.
+        */
+       iov_iter_restore(iter, state);
+
        ret2 = io_setup_async_rw(req, iovec, inline_vecs, iter, true);
        if (ret2)
                return ret2;
 
        iovec = NULL;
        rw = req->async_data;
-       /* now use our persistent iterator, if we aren't already */
-       iter = &rw->iter;
+       /*
+        * Now use our persistent iterator and state, if we aren't already.
+        * We've restored and mapped the iter to match.
+        */
+       if (iter != &rw->iter) {
+               iter = &rw->iter;
+               state = &rw->iter_state;
+       }
 
        do {
-               io_size -= ret;
+               /*
+                * We end up here because of a partial read, either from
+                * above or inside this loop. Advance the iter by the bytes
+                * that were consumed.
+                */
+               iov_iter_advance(iter, ret);
+               if (!iov_iter_count(iter))
+                       break;
                rw->bytes_done += ret;
+               iov_iter_save_state(iter, state);
+
                /* if we can retry, do so with the callbacks armed */
                if (!io_rw_should_retry(req)) {
                        kiocb->ki_flags &= ~IOCB_WAITQ;
@@ -3525,7 +3562,8 @@ static int io_read(struct io_kiocb *req, unsigned int issue_flags)
                        return 0;
                /* we got some bytes, but not all. retry. */
                kiocb->ki_flags &= ~IOCB_WAITQ;
-       } while (ret > 0 && ret < io_size);
+               iov_iter_restore(iter, state);
+       } while (ret > 0);
 done:
        kiocb_done(kiocb, ret, issue_flags);
 out_free:
@@ -3539,7 +3577,7 @@ static int io_write_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
 {
        if (unlikely(!(req->file->f_mode & FMODE_WRITE)))
                return -EBADF;
-       return io_prep_rw(req, sqe);
+       return io_prep_rw(req, sqe, WRITE);
 }
 
 static int io_write(struct io_kiocb *req, unsigned int issue_flags)
@@ -3548,19 +3586,23 @@ static int io_write(struct io_kiocb *req, unsigned int issue_flags)
        struct kiocb *kiocb = &req->rw.kiocb;
        struct iov_iter __iter, *iter = &__iter;
        struct io_async_rw *rw = req->async_data;
-       ssize_t ret, ret2, io_size;
        bool force_nonblock = issue_flags & IO_URING_F_NONBLOCK;
+       struct iov_iter_state __state, *state;
+       ssize_t ret, ret2;
 
        if (rw) {
                iter = &rw->iter;
+               state = &rw->iter_state;
+               iov_iter_restore(iter, state);
                iovec = NULL;
        } else {
                ret = io_import_iovec(WRITE, req, &iovec, iter, !force_nonblock);
                if (ret < 0)
                        return ret;
+               state = &__state;
+               iov_iter_save_state(iter, state);
        }
-       io_size = iov_iter_count(iter);
-       req->result = io_size;
+       req->result = iov_iter_count(iter);
 
        /* Ensure we clear previously set non-block flag */
        if (!force_nonblock)
@@ -3577,7 +3619,7 @@ static int io_write(struct io_kiocb *req, unsigned int issue_flags)
            (req->flags & REQ_F_ISREG))
                goto copy_iov;
 
-       ret = rw_verify_area(WRITE, req->file, io_kiocb_ppos(kiocb), io_size);
+       ret = rw_verify_area(WRITE, req->file, io_kiocb_ppos(kiocb), req->result);
        if (unlikely(ret))
                goto out_free;
 
@@ -3624,9 +3666,7 @@ done:
                kiocb_done(kiocb, ret2, issue_flags);
        } else {
 copy_iov:
-               /* some cases will consume bytes even on error returns */
-               iov_iter_reexpand(iter, iter->count + iter->truncated);
-               iov_iter_revert(iter, io_size - iov_iter_count(iter));
+               iov_iter_restore(iter, state);
                ret = io_setup_async_rw(req, iovec, inline_vecs, iter, false);
                return ret ?: -EAGAIN;
        }
@@ -4342,7 +4382,7 @@ static int io_add_buffers(struct io_provide_buf *pbuf, struct io_buffer **head)
        int i, bid = pbuf->bid;
 
        for (i = 0; i < pbuf->nbufs; i++) {
-               buf = kmalloc(sizeof(*buf), GFP_KERNEL);
+               buf = kmalloc(sizeof(*buf), GFP_KERNEL_ACCOUNT);
                if (!buf)
                        break;
 
@@ -4549,12 +4589,16 @@ static int io_close_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
        if (unlikely(req->ctx->flags & IORING_SETUP_IOPOLL))
                return -EINVAL;
        if (sqe->ioprio || sqe->off || sqe->addr || sqe->len ||
-           sqe->rw_flags || sqe->buf_index || sqe->splice_fd_in)
+           sqe->rw_flags || sqe->buf_index)
                return -EINVAL;
        if (req->flags & REQ_F_FIXED_FILE)
                return -EBADF;
 
        req->close.fd = READ_ONCE(sqe->fd);
+       req->close.file_slot = READ_ONCE(sqe->file_index);
+       if (req->close.file_slot && req->close.fd)
+               return -EINVAL;
+
        return 0;
 }
 
@@ -4566,6 +4610,11 @@ static int io_close(struct io_kiocb *req, unsigned int issue_flags)
        struct file *file = NULL;
        int ret = -EBADF;
 
+       if (req->close.file_slot) {
+               ret = io_close_fixed(req, issue_flags);
+               goto err;
+       }
+
        spin_lock(&files->file_lock);
        fdt = files_fdtable(files);
        if (close->fd >= fdt->max_fds) {
@@ -5293,7 +5342,7 @@ static bool __io_poll_complete(struct io_kiocb *req, __poll_t mask)
        if (req->poll.events & EPOLLONESHOT)
                flags = 0;
        if (!io_cqring_fill_event(ctx, req->user_data, error, flags)) {
-               req->poll.done = true;
+               req->poll.events |= EPOLLONESHOT;
                flags = 0;
        }
        if (flags & IORING_CQE_F_MORE)
@@ -5322,10 +5371,15 @@ static void io_poll_task_func(struct io_kiocb *req, bool *locked)
        } else {
                bool done;
 
+               if (req->poll.done) {
+                       spin_unlock(&ctx->completion_lock);
+                       return;
+               }
                done = __io_poll_complete(req, req->result);
                if (done) {
                        io_poll_remove_double(req);
                        hash_del(&req->hash_node);
+                       req->poll.done = true;
                } else {
                        req->result = 0;
                        add_wait_queue(req->poll.head, &req->poll.wait);
@@ -5463,6 +5517,7 @@ static void io_async_task_func(struct io_kiocb *req, bool *locked)
 
        hash_del(&req->hash_node);
        io_poll_remove_double(req);
+       apoll->poll.done = true;
        spin_unlock(&ctx->completion_lock);
 
        if (!READ_ONCE(apoll->poll.canceled))
@@ -5783,6 +5838,7 @@ static int io_poll_add(struct io_kiocb *req, unsigned int issue_flags)
        struct io_ring_ctx *ctx = req->ctx;
        struct io_poll_table ipt;
        __poll_t mask;
+       bool done;
 
        ipt.pt._qproc = io_poll_queue_proc;
 
@@ -5791,13 +5847,13 @@ static int io_poll_add(struct io_kiocb *req, unsigned int issue_flags)
 
        if (mask) { /* no async, we'd stolen it */
                ipt.error = 0;
-               io_poll_complete(req, mask);
+               done = io_poll_complete(req, mask);
        }
        spin_unlock(&ctx->completion_lock);
 
        if (mask) {
                io_cqring_ev_posted(ctx);
-               if (poll->events & EPOLLONESHOT)
+               if (done)
                        io_put_req(req);
        }
        return ipt.error;
@@ -6288,19 +6344,16 @@ static int io_files_update(struct io_kiocb *req, unsigned int issue_flags)
        struct io_uring_rsrc_update2 up;
        int ret;
 
-       if (issue_flags & IO_URING_F_NONBLOCK)
-               return -EAGAIN;
-
        up.offset = req->rsrc_update.offset;
        up.data = req->rsrc_update.arg;
        up.nr = 0;
        up.tags = 0;
        up.resv = 0;
 
-       mutex_lock(&ctx->uring_lock);
+       io_ring_submit_lock(ctx, !(issue_flags & IO_URING_F_NONBLOCK));
        ret = __io_register_rsrc_update(ctx, IORING_RSRC_FILE,
                                        &up, req->rsrc_update.nr_args);
-       mutex_unlock(&ctx->uring_lock);
+       io_ring_submit_unlock(ctx, !(issue_flags & IO_URING_F_NONBLOCK));
 
        if (ret < 0)
                req_set_fail(req);
@@ -7515,6 +7568,14 @@ static int io_cqring_wait(struct io_ring_ctx *ctx, int min_events,
                        break;
        } while (1);
 
+       if (uts) {
+               struct timespec64 ts;
+
+               if (get_timespec64(&ts, uts))
+                       return -EFAULT;
+               timeout = timespec64_to_jiffies(&ts);
+       }
+
        if (sig) {
 #ifdef CONFIG_COMPAT
                if (in_compat_syscall())
@@ -7528,14 +7589,6 @@ static int io_cqring_wait(struct io_ring_ctx *ctx, int min_events,
                        return ret;
        }
 
-       if (uts) {
-               struct timespec64 ts;
-
-               if (get_timespec64(&ts, uts))
-                       return -EFAULT;
-               timeout = timespec64_to_jiffies(&ts);
-       }
-
        init_waitqueue_func_entry(&iowq.wq, io_wake_function);
        iowq.wq.private = current;
        INIT_LIST_HEAD(&iowq.wq.entry);
@@ -8284,11 +8337,27 @@ static int io_sqe_file_register(struct io_ring_ctx *ctx, struct file *file,
 #endif
 }
 
+static int io_queue_rsrc_removal(struct io_rsrc_data *data, unsigned idx,
+                                struct io_rsrc_node *node, void *rsrc)
+{
+       struct io_rsrc_put *prsrc;
+
+       prsrc = kzalloc(sizeof(*prsrc), GFP_KERNEL);
+       if (!prsrc)
+               return -ENOMEM;
+
+       prsrc->tag = *io_get_tag_slot(data, idx);
+       prsrc->rsrc = rsrc;
+       list_add(&prsrc->list, &node->rsrc_list);
+       return 0;
+}
+
 static int io_install_fixed_file(struct io_kiocb *req, struct file *file,
                                 unsigned int issue_flags, u32 slot_index)
 {
        struct io_ring_ctx *ctx = req->ctx;
        bool force_nonblock = issue_flags & IO_URING_F_NONBLOCK;
+       bool needs_switch = false;
        struct io_fixed_file *file_slot;
        int ret = -EBADF;
 
@@ -8304,9 +8373,22 @@ static int io_install_fixed_file(struct io_kiocb *req, struct file *file,
 
        slot_index = array_index_nospec(slot_index, ctx->nr_user_files);
        file_slot = io_fixed_file_slot(&ctx->file_table, slot_index);
-       ret = -EBADF;
-       if (file_slot->file_ptr)
-               goto err;
+
+       if (file_slot->file_ptr) {
+               struct file *old_file;
+
+               ret = io_rsrc_node_switch_start(ctx);
+               if (ret)
+                       goto err;
+
+               old_file = (struct file *)(file_slot->file_ptr & FFS_MASK);
+               ret = io_queue_rsrc_removal(ctx->file_data, slot_index,
+                                           ctx->rsrc_node, old_file);
+               if (ret)
+                       goto err;
+               file_slot->file_ptr = 0;
+               needs_switch = true;
+       }
 
        *io_get_tag_slot(ctx->file_data, slot_index) = 0;
        io_fixed_file_set(file_slot, file);
@@ -8318,25 +8400,50 @@ static int io_install_fixed_file(struct io_kiocb *req, struct file *file,
 
        ret = 0;
 err:
+       if (needs_switch)
+               io_rsrc_node_switch(ctx, ctx->file_data);
        io_ring_submit_unlock(ctx, !force_nonblock);
        if (ret)
                fput(file);
        return ret;
 }
 
-static int io_queue_rsrc_removal(struct io_rsrc_data *data, unsigned idx,
-                                struct io_rsrc_node *node, void *rsrc)
+static int io_close_fixed(struct io_kiocb *req, unsigned int issue_flags)
 {
-       struct io_rsrc_put *prsrc;
+       unsigned int offset = req->close.file_slot - 1;
+       struct io_ring_ctx *ctx = req->ctx;
+       struct io_fixed_file *file_slot;
+       struct file *file;
+       int ret, i;
 
-       prsrc = kzalloc(sizeof(*prsrc), GFP_KERNEL);
-       if (!prsrc)
-               return -ENOMEM;
+       io_ring_submit_lock(ctx, !(issue_flags & IO_URING_F_NONBLOCK));
+       ret = -ENXIO;
+       if (unlikely(!ctx->file_data))
+               goto out;
+       ret = -EINVAL;
+       if (offset >= ctx->nr_user_files)
+               goto out;
+       ret = io_rsrc_node_switch_start(ctx);
+       if (ret)
+               goto out;
 
-       prsrc->tag = *io_get_tag_slot(data, idx);
-       prsrc->rsrc = rsrc;
-       list_add(&prsrc->list, &node->rsrc_list);
-       return 0;
+       i = array_index_nospec(offset, ctx->nr_user_files);
+       file_slot = io_fixed_file_slot(&ctx->file_table, i);
+       ret = -EBADF;
+       if (!file_slot->file_ptr)
+               goto out;
+
+       file = (struct file *)(file_slot->file_ptr & FFS_MASK);
+       ret = io_queue_rsrc_removal(ctx->file_data, offset, ctx->rsrc_node, file);
+       if (ret)
+               goto out;
+
+       file_slot->file_ptr = 0;
+       io_rsrc_node_switch(ctx, ctx->file_data);
+       ret = 0;
+out:
+       io_ring_submit_unlock(ctx, !(issue_flags & IO_URING_F_NONBLOCK));
+       return ret;
 }
 
 static int __io_sqe_files_update(struct io_ring_ctx *ctx,
@@ -9105,8 +9212,10 @@ static void io_destroy_buffers(struct io_ring_ctx *ctx)
        struct io_buffer *buf;
        unsigned long index;
 
-       xa_for_each(&ctx->io_buffers, index, buf)
+       xa_for_each(&ctx->io_buffers, index, buf) {
                __io_remove_buffers(ctx, buf, index, -1U);
+               cond_resched();
+       }
 }
 
 static void io_req_cache_free(struct list_head *list)
@@ -9231,13 +9340,6 @@ static __poll_t io_uring_poll(struct file *file, poll_table *wait)
        return mask;
 }
 
-static int io_uring_fasync(int fd, struct file *file, int on)
-{
-       struct io_ring_ctx *ctx = file->private_data;
-
-       return fasync_helper(fd, file, on, &ctx->cq_fasync);
-}
-
 static int io_unregister_personality(struct io_ring_ctx *ctx, unsigned id)
 {
        const struct cred *creds;
@@ -9604,8 +9706,10 @@ static void io_uring_clean_tctx(struct io_uring_task *tctx)
        struct io_tctx_node *node;
        unsigned long index;
 
-       xa_for_each(&tctx->xa, index, node)
+       xa_for_each(&tctx->xa, index, node) {
                io_uring_del_tctx_node(index);
+               cond_resched();
+       }
        if (wq) {
                /*
                 * Must be after io_uring_del_task_file() (removes nodes under
@@ -10029,7 +10133,6 @@ static const struct file_operations io_uring_fops = {
        .mmap_capabilities = io_uring_nommu_mmap_capabilities,
 #endif
        .poll           = io_uring_poll,
-       .fasync         = io_uring_fasync,
 #ifdef CONFIG_PROC_FS
        .show_fdinfo    = io_uring_show_fdinfo,
 #endif
@@ -10560,10 +10663,12 @@ static int io_register_iowq_max_workers(struct io_ring_ctx *ctx,
                         * ordering. Fine to drop uring_lock here, we hold
                         * a ref to the ctx.
                         */
+                       refcount_inc(&sqd->refs);
                        mutex_unlock(&ctx->uring_lock);
                        mutex_lock(&sqd->lock);
                        mutex_lock(&ctx->uring_lock);
-                       tctx = sqd->thread->io_uring;
+                       if (sqd->thread)
+                               tctx = sqd->thread->io_uring;
                }
        } else {
                tctx = current->io_uring;
@@ -10577,16 +10682,20 @@ static int io_register_iowq_max_workers(struct io_ring_ctx *ctx,
        if (ret)
                goto err;
 
-       if (sqd)
+       if (sqd) {
                mutex_unlock(&sqd->lock);
+               io_put_sq_data(sqd);
+       }
 
        if (copy_to_user(arg, new_count, sizeof(new_count)))
                return -EFAULT;
 
        return 0;
 err:
-       if (sqd)
+       if (sqd) {
                mutex_unlock(&sqd->lock);
+               io_put_sq_data(sqd);
+       }
        return ret;
 }
 
index ba58142..8e0a137 100644 (file)
@@ -1111,13 +1111,25 @@ static struct dentry *kernfs_iop_lookup(struct inode *dir,
 
        kn = kernfs_find_ns(parent, dentry->d_name.name, ns);
        /* attach dentry and inode */
-       if (kn && kernfs_active(kn)) {
+       if (kn) {
+               /* Inactive nodes are invisible to the VFS so don't
+                * create a negative.
+                */
+               if (!kernfs_active(kn)) {
+                       up_read(&kernfs_rwsem);
+                       return NULL;
+               }
                inode = kernfs_get_inode(dir->i_sb, kn);
                if (!inode)
                        inode = ERR_PTR(-ENOMEM);
        }
-       /* Needed only for negative dentry validation */
-       if (!inode)
+       /*
+        * Needed for negative dentry validation.
+        * The negative dentry can be created in kernfs_iop_lookup()
+        * or transforms from positive dentry in dentry_unlink_inode()
+        * called from vfs_rmdir().
+        */
+       if (!IS_ERR(inode))
                kernfs_set_rev(parent, dentry);
        up_read(&kernfs_rwsem);
 
index de36f12..71c989f 100644 (file)
@@ -68,125 +68,6 @@ void ksmbd_copy_gss_neg_header(void *buf)
        memcpy(buf, NEGOTIATE_GSS_HEADER, AUTH_GSS_LENGTH);
 }
 
-static void
-str_to_key(unsigned char *str, unsigned char *key)
-{
-       int i;
-
-       key[0] = str[0] >> 1;
-       key[1] = ((str[0] & 0x01) << 6) | (str[1] >> 2);
-       key[2] = ((str[1] & 0x03) << 5) | (str[2] >> 3);
-       key[3] = ((str[2] & 0x07) << 4) | (str[3] >> 4);
-       key[4] = ((str[3] & 0x0F) << 3) | (str[4] >> 5);
-       key[5] = ((str[4] & 0x1F) << 2) | (str[5] >> 6);
-       key[6] = ((str[5] & 0x3F) << 1) | (str[6] >> 7);
-       key[7] = str[6] & 0x7F;
-       for (i = 0; i < 8; i++)
-               key[i] = (key[i] << 1);
-}
-
-static int
-smbhash(unsigned char *out, const unsigned char *in, unsigned char *key)
-{
-       unsigned char key2[8];
-       struct des_ctx ctx;
-
-       if (fips_enabled) {
-               ksmbd_debug(AUTH, "FIPS compliance enabled: DES not permitted\n");
-               return -ENOENT;
-       }
-
-       str_to_key(key, key2);
-       des_expand_key(&ctx, key2, DES_KEY_SIZE);
-       des_encrypt(&ctx, out, in);
-       memzero_explicit(&ctx, sizeof(ctx));
-       return 0;
-}
-
-static int ksmbd_enc_p24(unsigned char *p21, const unsigned char *c8, unsigned char *p24)
-{
-       int rc;
-
-       rc = smbhash(p24, c8, p21);
-       if (rc)
-               return rc;
-       rc = smbhash(p24 + 8, c8, p21 + 7);
-       if (rc)
-               return rc;
-       return smbhash(p24 + 16, c8, p21 + 14);
-}
-
-/* produce a md4 message digest from data of length n bytes */
-static int ksmbd_enc_md4(unsigned char *md4_hash, unsigned char *link_str,
-                        int link_len)
-{
-       int rc;
-       struct ksmbd_crypto_ctx *ctx;
-
-       ctx = ksmbd_crypto_ctx_find_md4();
-       if (!ctx) {
-               ksmbd_debug(AUTH, "Crypto md4 allocation error\n");
-               return -ENOMEM;
-       }
-
-       rc = crypto_shash_init(CRYPTO_MD4(ctx));
-       if (rc) {
-               ksmbd_debug(AUTH, "Could not init md4 shash\n");
-               goto out;
-       }
-
-       rc = crypto_shash_update(CRYPTO_MD4(ctx), link_str, link_len);
-       if (rc) {
-               ksmbd_debug(AUTH, "Could not update with link_str\n");
-               goto out;
-       }
-
-       rc = crypto_shash_final(CRYPTO_MD4(ctx), md4_hash);
-       if (rc)
-               ksmbd_debug(AUTH, "Could not generate md4 hash\n");
-out:
-       ksmbd_release_crypto_ctx(ctx);
-       return rc;
-}
-
-static int ksmbd_enc_update_sess_key(unsigned char *md5_hash, char *nonce,
-                                    char *server_challenge, int len)
-{
-       int rc;
-       struct ksmbd_crypto_ctx *ctx;
-
-       ctx = ksmbd_crypto_ctx_find_md5();
-       if (!ctx) {
-               ksmbd_debug(AUTH, "Crypto md5 allocation error\n");
-               return -ENOMEM;
-       }
-
-       rc = crypto_shash_init(CRYPTO_MD5(ctx));
-       if (rc) {
-               ksmbd_debug(AUTH, "Could not init md5 shash\n");
-               goto out;
-       }
-
-       rc = crypto_shash_update(CRYPTO_MD5(ctx), server_challenge, len);
-       if (rc) {
-               ksmbd_debug(AUTH, "Could not update with challenge\n");
-               goto out;
-       }
-
-       rc = crypto_shash_update(CRYPTO_MD5(ctx), nonce, len);
-       if (rc) {
-               ksmbd_debug(AUTH, "Could not update with nonce\n");
-               goto out;
-       }
-
-       rc = crypto_shash_final(CRYPTO_MD5(ctx), md5_hash);
-       if (rc)
-               ksmbd_debug(AUTH, "Could not generate md5 hash\n");
-out:
-       ksmbd_release_crypto_ctx(ctx);
-       return rc;
-}
-
 /**
  * ksmbd_gen_sess_key() - function to generate session key
  * @sess:      session of connection
@@ -324,43 +205,6 @@ out:
        return ret;
 }
 
-/**
- * ksmbd_auth_ntlm() - NTLM authentication handler
- * @sess:      session of connection
- * @pw_buf:    NTLM challenge response
- * @passkey:   user password
- *
- * Return:     0 on success, error number on error
- */
-int ksmbd_auth_ntlm(struct ksmbd_session *sess, char *pw_buf)
-{
-       int rc;
-       unsigned char p21[21];
-       char key[CIFS_AUTH_RESP_SIZE];
-
-       memset(p21, '\0', 21);
-       memcpy(p21, user_passkey(sess->user), CIFS_NTHASH_SIZE);
-       rc = ksmbd_enc_p24(p21, sess->ntlmssp.cryptkey, key);
-       if (rc) {
-               pr_err("password processing failed\n");
-               return rc;
-       }
-
-       ksmbd_enc_md4(sess->sess_key, user_passkey(sess->user),
-                     CIFS_SMB1_SESSKEY_SIZE);
-       memcpy(sess->sess_key + CIFS_SMB1_SESSKEY_SIZE, key,
-              CIFS_AUTH_RESP_SIZE);
-       sess->sequence_number = 1;
-
-       if (strncmp(pw_buf, key, CIFS_AUTH_RESP_SIZE) != 0) {
-               ksmbd_debug(AUTH, "ntlmv1 authentication failed\n");
-               return -EINVAL;
-       }
-
-       ksmbd_debug(AUTH, "ntlmv1 authentication pass\n");
-       return 0;
-}
-
 /**
  * ksmbd_auth_ntlmv2() - NTLMv2 authentication handler
  * @sess:      session of connection
@@ -441,44 +285,6 @@ out:
        return rc;
 }
 
-/**
- * __ksmbd_auth_ntlmv2() - NTLM2(extended security) authentication handler
- * @sess:      session of connection
- * @client_nonce:      client nonce from LM response.
- * @ntlm_resp:         ntlm response data from client.
- *
- * Return:     0 on success, error number on error
- */
-static int __ksmbd_auth_ntlmv2(struct ksmbd_session *sess, char *client_nonce,
-                              char *ntlm_resp)
-{
-       char sess_key[CIFS_SMB1_SESSKEY_SIZE] = {0};
-       int rc;
-       unsigned char p21[21];
-       char key[CIFS_AUTH_RESP_SIZE];
-
-       rc = ksmbd_enc_update_sess_key(sess_key,
-                                      client_nonce,
-                                      (char *)sess->ntlmssp.cryptkey, 8);
-       if (rc) {
-               pr_err("password processing failed\n");
-               goto out;
-       }
-
-       memset(p21, '\0', 21);
-       memcpy(p21, user_passkey(sess->user), CIFS_NTHASH_SIZE);
-       rc = ksmbd_enc_p24(p21, sess_key, key);
-       if (rc) {
-               pr_err("password processing failed\n");
-               goto out;
-       }
-
-       if (memcmp(ntlm_resp, key, CIFS_AUTH_RESP_SIZE) != 0)
-               rc = -EINVAL;
-out:
-       return rc;
-}
-
 /**
  * ksmbd_decode_ntlmssp_auth_blob() - helper function to construct
  * authenticate blob
@@ -512,17 +318,6 @@ int ksmbd_decode_ntlmssp_auth_blob(struct authenticate_message *authblob,
        nt_off = le32_to_cpu(authblob->NtChallengeResponse.BufferOffset);
        nt_len = le16_to_cpu(authblob->NtChallengeResponse.Length);
 
-       /* process NTLM authentication */
-       if (nt_len == CIFS_AUTH_RESP_SIZE) {
-               if (le32_to_cpu(authblob->NegotiateFlags) &
-                   NTLMSSP_NEGOTIATE_EXTENDED_SEC)
-                       return __ksmbd_auth_ntlmv2(sess, (char *)authblob +
-                               lm_off, (char *)authblob + nt_off);
-               else
-                       return ksmbd_auth_ntlm(sess, (char *)authblob +
-                               nt_off);
-       }
-
        /* TODO : use domain name that imported from configuration file */
        domain_name = smb_strndup_from_utf16((const char *)authblob +
                        le32_to_cpu(authblob->DomainName.BufferOffset),
index af086d3..48b18b4 100644 (file)
@@ -296,10 +296,12 @@ int ksmbd_conn_handler_loop(void *p)
                pdu_size = get_rfc1002_len(hdr_buf);
                ksmbd_debug(CONN, "RFC1002 header %u bytes\n", pdu_size);
 
-               /* make sure we have enough to get to SMB header end */
-               if (!ksmbd_pdu_size_has_room(pdu_size)) {
-                       ksmbd_debug(CONN, "SMB request too short (%u bytes)\n",
-                                   pdu_size);
+               /*
+                * Check if pdu size is valid (min : smb header size,
+                * max : 0x00FFFFFF).
+                */
+               if (pdu_size < __SMB2_HEADER_STRUCTURE_SIZE ||
+                   pdu_size > MAX_STREAM_PROT_LEN) {
                        continue;
                }
 
index 5f4b100..81488d0 100644 (file)
@@ -81,12 +81,6 @@ static struct shash_desc *alloc_shash_desc(int id)
        case CRYPTO_SHASH_SHA512:
                tfm = crypto_alloc_shash("sha512", 0, 0);
                break;
-       case CRYPTO_SHASH_MD4:
-               tfm = crypto_alloc_shash("md4", 0, 0);
-               break;
-       case CRYPTO_SHASH_MD5:
-               tfm = crypto_alloc_shash("md5", 0, 0);
-               break;
        default:
                return NULL;
        }
@@ -214,16 +208,6 @@ struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_sha512(void)
        return ____crypto_shash_ctx_find(CRYPTO_SHASH_SHA512);
 }
 
-struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_md4(void)
-{
-       return ____crypto_shash_ctx_find(CRYPTO_SHASH_MD4);
-}
-
-struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_md5(void)
-{
-       return ____crypto_shash_ctx_find(CRYPTO_SHASH_MD5);
-}
-
 static struct ksmbd_crypto_ctx *____crypto_aead_ctx_find(int id)
 {
        struct ksmbd_crypto_ctx *ctx;
index ef11154..4a367c6 100644 (file)
@@ -15,8 +15,6 @@ enum {
        CRYPTO_SHASH_CMACAES,
        CRYPTO_SHASH_SHA256,
        CRYPTO_SHASH_SHA512,
-       CRYPTO_SHASH_MD4,
-       CRYPTO_SHASH_MD5,
        CRYPTO_SHASH_MAX,
 };
 
@@ -43,8 +41,6 @@ struct ksmbd_crypto_ctx {
 #define CRYPTO_CMACAES(c)      ((c)->desc[CRYPTO_SHASH_CMACAES])
 #define CRYPTO_SHA256(c)       ((c)->desc[CRYPTO_SHASH_SHA256])
 #define CRYPTO_SHA512(c)       ((c)->desc[CRYPTO_SHASH_SHA512])
-#define CRYPTO_MD4(c)          ((c)->desc[CRYPTO_SHASH_MD4])
-#define CRYPTO_MD5(c)          ((c)->desc[CRYPTO_SHASH_MD5])
 
 #define CRYPTO_HMACMD5_TFM(c)  ((c)->desc[CRYPTO_SHASH_HMACMD5]->tfm)
 #define CRYPTO_HMACSHA256_TFM(c)\
@@ -52,8 +48,6 @@ struct ksmbd_crypto_ctx {
 #define CRYPTO_CMACAES_TFM(c)  ((c)->desc[CRYPTO_SHASH_CMACAES]->tfm)
 #define CRYPTO_SHA256_TFM(c)   ((c)->desc[CRYPTO_SHASH_SHA256]->tfm)
 #define CRYPTO_SHA512_TFM(c)   ((c)->desc[CRYPTO_SHASH_SHA512]->tfm)
-#define CRYPTO_MD4_TFM(c)      ((c)->desc[CRYPTO_SHASH_MD4]->tfm)
-#define CRYPTO_MD5_TFM(c)      ((c)->desc[CRYPTO_SHASH_MD5]->tfm)
 
 #define CRYPTO_GCM(c)          ((c)->ccmaes[CRYPTO_AEAD_AES_GCM])
 #define CRYPTO_CCM(c)          ((c)->ccmaes[CRYPTO_AEAD_AES_CCM])
@@ -64,8 +58,6 @@ struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_hmacsha256(void);
 struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_cmacaes(void);
 struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_sha512(void);
 struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_sha256(void);
-struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_md4(void);
-struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_md5(void);
 struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_gcm(void);
 struct ksmbd_crypto_ctx *ksmbd_crypto_ctx_find_ccm(void);
 void ksmbd_crypto_destroy(void);
index 49a5a3a..5b8f3e0 100644 (file)
@@ -12,7 +12,7 @@
 #include "unicode.h"
 #include "vfs_cache.h"
 
-#define KSMBD_VERSION  "3.1.9"
+#define KSMBD_VERSION  "3.4.2"
 
 extern int ksmbd_debug_types;
 
index 0b307ca..60e7ac6 100644 (file)
@@ -158,25 +158,18 @@ out:
  * Return : windows path string or error
  */
 
-char *convert_to_nt_pathname(char *filename, char *sharepath)
+char *convert_to_nt_pathname(char *filename)
 {
        char *ab_pathname;
-       int len, name_len;
 
-       name_len = strlen(filename);
-       ab_pathname = kmalloc(name_len, GFP_KERNEL);
+       if (strlen(filename) == 0)
+               filename = "\\";
+
+       ab_pathname = kstrdup(filename, GFP_KERNEL);
        if (!ab_pathname)
                return NULL;
 
-       ab_pathname[0] = '\\';
-       ab_pathname[1] = '\0';
-
-       len = strlen(sharepath);
-       if (!strncmp(filename, sharepath, len) && name_len != len) {
-               strscpy(ab_pathname, &filename[len], name_len);
-               ksmbd_conv_path_to_windows(ab_pathname);
-       }
-
+       ksmbd_conv_path_to_windows(ab_pathname);
        return ab_pathname;
 }
 
@@ -240,7 +233,7 @@ char *ksmbd_extract_sharename(char *treename)
  *
  * Return:     converted name on success, otherwise NULL
  */
-char *convert_to_unix_name(struct ksmbd_share_config *share, char *name)
+char *convert_to_unix_name(struct ksmbd_share_config *share, const char *name)
 {
        int no_slash = 0, name_len, path_len;
        char *new_name;
index af8717d..253366b 100644 (file)
@@ -14,13 +14,13 @@ struct ksmbd_file;
 int match_pattern(const char *str, size_t len, const char *pattern);
 int ksmbd_validate_filename(char *filename);
 int parse_stream_name(char *filename, char **stream_name, int *s_type);
-char *convert_to_nt_pathname(char *filename, char *sharepath);
+char *convert_to_nt_pathname(char *filename);
 int get_nlink(struct kstat *st);
 void ksmbd_conv_path_to_unix(char *path);
 void ksmbd_strip_last_slash(char *path);
 void ksmbd_conv_path_to_windows(char *path);
 char *ksmbd_extract_sharename(char *treename);
-char *convert_to_unix_name(struct ksmbd_share_config *share, char *name);
+char *convert_to_unix_name(struct ksmbd_share_config *share, const char *name);
 
 #define KSMBD_DIR_INFO_ALIGNMENT       8
 struct ksmbd_dir_info;
index 16b6236..f9dae6e 100644 (file)
@@ -1451,26 +1451,47 @@ struct lease_ctx_info *parse_lease_state(void *open_req)
  */
 struct create_context *smb2_find_context_vals(void *open_req, const char *tag)
 {
-       char *data_offset;
        struct create_context *cc;
        unsigned int next = 0;
        char *name;
        struct smb2_create_req *req = (struct smb2_create_req *)open_req;
+       unsigned int remain_len, name_off, name_len, value_off, value_len,
+                    cc_len;
 
-       data_offset = (char *)req + 4 + le32_to_cpu(req->CreateContextsOffset);
-       cc = (struct create_context *)data_offset;
+       /*
+        * CreateContextsOffset and CreateContextsLength are guaranteed to
+        * be valid because of ksmbd_smb2_check_message().
+        */
+       cc = (struct create_context *)((char *)req + 4 +
+                                      le32_to_cpu(req->CreateContextsOffset));
+       remain_len = le32_to_cpu(req->CreateContextsLength);
        do {
-               int val;
-
                cc = (struct create_context *)((char *)cc + next);
-               name = le16_to_cpu(cc->NameOffset) + (char *)cc;
-               val = le16_to_cpu(cc->NameLength);
-               if (val < 4)
+               if (remain_len < offsetof(struct create_context, Buffer))
                        return ERR_PTR(-EINVAL);
 
-               if (memcmp(name, tag, val) == 0)
-                       return cc;
                next = le32_to_cpu(cc->Next);
+               name_off = le16_to_cpu(cc->NameOffset);
+               name_len = le16_to_cpu(cc->NameLength);
+               value_off = le16_to_cpu(cc->DataOffset);
+               value_len = le32_to_cpu(cc->DataLength);
+               cc_len = next ? next : remain_len;
+
+               if ((next & 0x7) != 0 ||
+                   next > remain_len ||
+                   name_off != offsetof(struct create_context, Buffer) ||
+                   name_len < 4 ||
+                   name_off + name_len > cc_len ||
+                   (value_off & 0x7) != 0 ||
+                   (value_off && (value_off < name_off + name_len)) ||
+                   ((u64)value_off + value_len > cc_len))
+                       return ERR_PTR(-EINVAL);
+
+               name = (char *)cc + name_off;
+               if (memcmp(name, tag, name_len) == 0)
+                       return cc;
+
+               remain_len -= next;
        } while (next != 0);
 
        return NULL;
index e6a9f6a..2a2b213 100644 (file)
@@ -584,6 +584,9 @@ static int __init ksmbd_server_init(void)
        ret = ksmbd_workqueue_init();
        if (ret)
                goto err_crypto_destroy;
+
+       pr_warn_once("The ksmbd server is experimental, use at your own risk.\n");
+
        return 0;
 
 err_crypto_destroy:
index 9aa46bb..9edd9c1 100644 (file)
@@ -80,18 +80,21 @@ static const bool has_smb2_data_area[NUMBER_OF_SMB2_COMMANDS] = {
 };
 
 /*
- * Returns the pointer to the beginning of the data area. Length of the data
- * area and the offset to it (from the beginning of the smb are also returned.
+ * Set length of the data area and the offset to arguments.
+ * if they are invalid, return error.
  */
-static char *smb2_get_data_area_len(int *off, int *len, struct smb2_hdr *hdr)
+static int smb2_get_data_area_len(unsigned int *off, unsigned int *len,
+                                 struct smb2_hdr *hdr)
 {
+       int ret = 0;
+
        *off = 0;
        *len = 0;
 
        /* error reqeusts do not have data area */
        if (hdr->Status && hdr->Status != STATUS_MORE_PROCESSING_REQUIRED &&
            (((struct smb2_err_rsp *)hdr)->StructureSize) == SMB2_ERROR_STRUCTURE_SIZE2_LE)
-               return NULL;
+               return ret;
 
        /*
         * Following commands have data areas so we have to get the location
@@ -165,69 +168,60 @@ static char *smb2_get_data_area_len(int *off, int *len, struct smb2_hdr *hdr)
        case SMB2_IOCTL:
                *off = le32_to_cpu(((struct smb2_ioctl_req *)hdr)->InputOffset);
                *len = le32_to_cpu(((struct smb2_ioctl_req *)hdr)->InputCount);
-
                break;
        default:
                ksmbd_debug(SMB, "no length check for command\n");
                break;
        }
 
-       /*
-        * Invalid length or offset probably means data area is invalid, but
-        * we have little choice but to ignore the data area in this case.
-        */
        if (*off > 4096) {
-               ksmbd_debug(SMB, "offset %d too large, data area ignored\n",
-                           *off);
-               *len = 0;
-               *off = 0;
-       } else if (*off < 0) {
-               ksmbd_debug(SMB,
-                           "negative offset %d to data invalid ignore data area\n",
-                           *off);
-               *off = 0;
-               *len = 0;
-       } else if (*len < 0) {
-               ksmbd_debug(SMB,
-                           "negative data length %d invalid, data area ignored\n",
-                           *len);
-               *len = 0;
-       } else if (*len > 128 * 1024) {
-               ksmbd_debug(SMB, "data area larger than 128K: %d\n", *len);
-               *len = 0;
+               ksmbd_debug(SMB, "offset %d too large\n", *off);
+               ret = -EINVAL;
+       } else if ((u64)*off + *len > MAX_STREAM_PROT_LEN) {
+               ksmbd_debug(SMB, "Request is larger than maximum stream protocol length(%u): %llu\n",
+                           MAX_STREAM_PROT_LEN, (u64)*off + *len);
+               ret = -EINVAL;
        }
 
-       /* return pointer to beginning of data area, ie offset from SMB start */
-       if ((*off != 0) && (*len != 0))
-               return (char *)hdr + *off;
-       else
-               return NULL;
+       return ret;
 }
 
 /*
  * Calculate the size of the SMB message based on the fixed header
  * portion, the number of word parameters and the data portion of the message.
  */
-static unsigned int smb2_calc_size(void *buf)
+static int smb2_calc_size(void *buf, unsigned int *len)
 {
        struct smb2_pdu *pdu = (struct smb2_pdu *)buf;
        struct smb2_hdr *hdr = &pdu->hdr;
-       int offset; /* the offset from the beginning of SMB to data area */
-       int data_length; /* the length of the variable length data area */
+       unsigned int offset; /* the offset from the beginning of SMB to data area */
+       unsigned int data_length; /* the length of the variable length data area */
+       int ret;
+
        /* Structure Size has already been checked to make sure it is 64 */
-       int len = le16_to_cpu(hdr->StructureSize);
+       *len = le16_to_cpu(hdr->StructureSize);
 
        /*
         * StructureSize2, ie length of fixed parameter area has already
         * been checked to make sure it is the correct length.
         */
-       len += le16_to_cpu(pdu->StructureSize2);
+       *len += le16_to_cpu(pdu->StructureSize2);
+       /*
+        * StructureSize2 of smb2_lock pdu is set to 48, indicating
+        * the size of smb2 lock request with single smb2_lock_element
+        * regardless of number of locks. Subtract single
+        * smb2_lock_element for correct buffer size check.
+        */
+       if (hdr->Command == SMB2_LOCK)
+               *len -= sizeof(struct smb2_lock_element);
 
        if (has_smb2_data_area[le16_to_cpu(hdr->Command)] == false)
                goto calc_size_exit;
 
-       smb2_get_data_area_len(&offset, &data_length, hdr);
-       ksmbd_debug(SMB, "SMB2 data length %d offset %d\n", data_length,
+       ret = smb2_get_data_area_len(&offset, &data_length, hdr);
+       if (ret)
+               return ret;
+       ksmbd_debug(SMB, "SMB2 data length %u offset %u\n", data_length,
                    offset);
 
        if (data_length > 0) {
@@ -237,16 +231,19 @@ static unsigned int smb2_calc_size(void *buf)
                 * for some commands, typically those with odd StructureSize,
                 * so we must add one to the calculation.
                 */
-               if (offset + 1 < len)
+               if (offset + 1 < *len) {
                        ksmbd_debug(SMB,
-                                   "data area offset %d overlaps SMB2 header %d\n",
-                                   offset + 1, len);
-               else
-                       len = offset + data_length;
+                                   "data area offset %d overlaps SMB2 header %u\n",
+                                   offset + 1, *len);
+                       return -EINVAL;
+               }
+
+               *len = offset + data_length;
        }
+
 calc_size_exit:
-       ksmbd_debug(SMB, "SMB2 len %d\n", len);
-       return len;
+       ksmbd_debug(SMB, "SMB2 len %u\n", *len);
+       return 0;
 }
 
 static inline int smb2_query_info_req_len(struct smb2_query_info_req *h)
@@ -391,9 +388,11 @@ int ksmbd_smb2_check_message(struct ksmbd_work *work)
                return 1;
        }
 
-       clc_len = smb2_calc_size(hdr);
+       if (smb2_calc_size(hdr, &clc_len))
+               return 1;
+
        if (len != clc_len) {
-               /* server can return one byte more due to implied bcc[0] */
+               /* client can return one byte more due to implied bcc[0] */
                if (clc_len == len + 1)
                        return 0;
 
@@ -418,9 +417,6 @@ int ksmbd_smb2_check_message(struct ksmbd_work *work)
                        return 0;
                }
 
-               if (command == SMB2_LOCK_HE && len == 88)
-                       return 0;
-
                ksmbd_debug(SMB,
                            "cli req too short, len %d not %d. cmd:%d mid:%llu\n",
                            len, clc_len, command,
index 1974738..b06456e 100644 (file)
@@ -187,11 +187,6 @@ static struct smb_version_cmds smb2_0_server_cmds[NUMBER_OF_SMB2_COMMANDS] = {
        [SMB2_CHANGE_NOTIFY_HE] =       { .proc = smb2_notify},
 };
 
-int init_smb2_0_server(struct ksmbd_conn *conn)
-{
-       return -EOPNOTSUPP;
-}
-
 /**
  * init_smb2_1_server() - initialize a smb server connection with smb2.1
  *                     command dispatcher
index c86164d..005aa93 100644 (file)
@@ -236,9 +236,6 @@ int init_smb2_neg_rsp(struct ksmbd_work *work)
 
        if (conn->need_neg == false)
                return -EINVAL;
-       if (!(conn->dialect >= SMB20_PROT_ID &&
-             conn->dialect <= SMB311_PROT_ID))
-               return -EINVAL;
 
        rsp_hdr = work->response_buf;
 
@@ -433,7 +430,7 @@ static void init_chained_smb2_rsp(struct ksmbd_work *work)
                work->compound_pfid = KSMBD_NO_FID;
        }
        memset((char *)rsp_hdr + 4, 0, sizeof(struct smb2_hdr) + 2);
-       rsp_hdr->ProtocolId = rcv_hdr->ProtocolId;
+       rsp_hdr->ProtocolId = SMB2_PROTO_NUMBER;
        rsp_hdr->StructureSize = SMB2_HEADER_STRUCTURE_SIZE;
        rsp_hdr->Command = rcv_hdr->Command;
 
@@ -459,13 +456,22 @@ static void init_chained_smb2_rsp(struct ksmbd_work *work)
 bool is_chained_smb2_message(struct ksmbd_work *work)
 {
        struct smb2_hdr *hdr = work->request_buf;
-       unsigned int len;
+       unsigned int len, next_cmd;
 
        if (hdr->ProtocolId != SMB2_PROTO_NUMBER)
                return false;
 
        hdr = ksmbd_req_buf_next(work);
-       if (le32_to_cpu(hdr->NextCommand) > 0) {
+       next_cmd = le32_to_cpu(hdr->NextCommand);
+       if (next_cmd > 0) {
+               if ((u64)work->next_smb2_rcv_hdr_off + next_cmd +
+                       __SMB2_HEADER_STRUCTURE_SIZE >
+                   get_rfc1002_len(work->request_buf)) {
+                       pr_err("next command(%u) offset exceeds smb msg size\n",
+                              next_cmd);
+                       return false;
+               }
+
                ksmbd_debug(SMB, "got SMB2 chained command\n");
                init_chained_smb2_rsp(work);
                return true;
@@ -634,7 +640,7 @@ static char *
 smb2_get_name(struct ksmbd_share_config *share, const char *src,
              const int maxlen, struct nls_table *local_nls)
 {
-       char *name, *unixname;
+       char *name;
 
        name = smb_strndup_from_utf16(src, maxlen, 1, local_nls);
        if (IS_ERR(name)) {
@@ -642,19 +648,9 @@ smb2_get_name(struct ksmbd_share_config *share, const char *src,
                return name;
        }
 
-       /* change it to absolute unix name */
        ksmbd_conv_path_to_unix(name);
        ksmbd_strip_last_slash(name);
-
-       unixname = convert_to_unix_name(share, name);
-       kfree(name);
-       if (!unixname) {
-               pr_err("can not convert absolute name\n");
-               return ERR_PTR(-ENOMEM);
-       }
-
-       ksmbd_debug(SMB, "absolute name = %s\n", unixname);
-       return unixname;
+       return name;
 }
 
 int setup_async_work(struct ksmbd_work *work, void (*fn)(void **), void **arg)
@@ -1068,6 +1064,7 @@ int smb2_handle_negotiate(struct ksmbd_work *work)
        struct smb2_negotiate_req *req = work->request_buf;
        struct smb2_negotiate_rsp *rsp = work->response_buf;
        int rc = 0;
+       unsigned int smb2_buf_len, smb2_neg_size;
        __le32 status;
 
        ksmbd_debug(SMB, "Received negotiate request\n");
@@ -1085,6 +1082,44 @@ int smb2_handle_negotiate(struct ksmbd_work *work)
                goto err_out;
        }
 
+       smb2_buf_len = get_rfc1002_len(work->request_buf);
+       smb2_neg_size = offsetof(struct smb2_negotiate_req, Dialects) - 4;
+       if (smb2_neg_size > smb2_buf_len) {
+               rsp->hdr.Status = STATUS_INVALID_PARAMETER;
+               rc = -EINVAL;
+               goto err_out;
+       }
+
+       if (conn->dialect == SMB311_PROT_ID) {
+               unsigned int nego_ctxt_off = le32_to_cpu(req->NegotiateContextOffset);
+
+               if (smb2_buf_len < nego_ctxt_off) {
+                       rsp->hdr.Status = STATUS_INVALID_PARAMETER;
+                       rc = -EINVAL;
+                       goto err_out;
+               }
+
+               if (smb2_neg_size > nego_ctxt_off) {
+                       rsp->hdr.Status = STATUS_INVALID_PARAMETER;
+                       rc = -EINVAL;
+                       goto err_out;
+               }
+
+               if (smb2_neg_size + le16_to_cpu(req->DialectCount) * sizeof(__le16) >
+                   nego_ctxt_off) {
+                       rsp->hdr.Status = STATUS_INVALID_PARAMETER;
+                       rc = -EINVAL;
+                       goto err_out;
+               }
+       } else {
+               if (smb2_neg_size + le16_to_cpu(req->DialectCount) * sizeof(__le16) >
+                   smb2_buf_len) {
+                       rsp->hdr.Status = STATUS_INVALID_PARAMETER;
+                       rc = -EINVAL;
+                       goto err_out;
+               }
+       }
+
        conn->cli_cap = le32_to_cpu(req->Capabilities);
        switch (conn->dialect) {
        case SMB311_PROT_ID:
@@ -1128,13 +1163,6 @@ int smb2_handle_negotiate(struct ksmbd_work *work)
        case SMB21_PROT_ID:
                init_smb2_1_server(conn);
                break;
-       case SMB20_PROT_ID:
-               rc = init_smb2_0_server(conn);
-               if (rc) {
-                       rsp->hdr.Status = STATUS_NOT_SUPPORTED;
-                       goto err_out;
-               }
-               break;
        case SMB2X_PROT_ID:
        case BAD_PROT_ID:
        default:
@@ -1153,11 +1181,9 @@ int smb2_handle_negotiate(struct ksmbd_work *work)
        rsp->MaxReadSize = cpu_to_le32(conn->vals->max_read_size);
        rsp->MaxWriteSize = cpu_to_le32(conn->vals->max_write_size);
 
-       if (conn->dialect > SMB20_PROT_ID) {
-               memcpy(conn->ClientGUID, req->ClientGUID,
-                      SMB2_CLIENT_GUID_SIZE);
-               conn->cli_sec_mode = le16_to_cpu(req->SecurityMode);
-       }
+       memcpy(conn->ClientGUID, req->ClientGUID,
+                       SMB2_CLIENT_GUID_SIZE);
+       conn->cli_sec_mode = le16_to_cpu(req->SecurityMode);
 
        rsp->StructureSize = cpu_to_le16(65);
        rsp->DialectRevision = cpu_to_le16(conn->dialect);
@@ -1499,11 +1525,9 @@ binding_session:
                }
        }
 
-       if (conn->dialect > SMB20_PROT_ID) {
-               if (!ksmbd_conn_lookup_dialect(conn)) {
-                       pr_err("fail to verify the dialect\n");
-                       return -ENOENT;
-               }
+       if (!ksmbd_conn_lookup_dialect(conn)) {
+               pr_err("fail to verify the dialect\n");
+               return -ENOENT;
        }
        return 0;
 }
@@ -1585,11 +1609,9 @@ static int krb5_authenticate(struct ksmbd_work *work)
                }
        }
 
-       if (conn->dialect > SMB20_PROT_ID) {
-               if (!ksmbd_conn_lookup_dialect(conn)) {
-                       pr_err("fail to verify the dialect\n");
-                       return -ENOENT;
-               }
+       if (!ksmbd_conn_lookup_dialect(conn)) {
+               pr_err("fail to verify the dialect\n");
+               return -ENOENT;
        }
        return 0;
 }
@@ -2103,16 +2125,22 @@ out:
  * smb2_set_ea() - handler for setting extended attributes using set
  *             info command
  * @eabuf:     set info command buffer
+ * @buf_len:   set info command buffer length
  * @path:      dentry path for get ea
  *
  * Return:     0 on success, otherwise error
  */
-static int smb2_set_ea(struct smb2_ea_info *eabuf, struct path *path)
+static int smb2_set_ea(struct smb2_ea_info *eabuf, unsigned int buf_len,
+                      struct path *path)
 {
        struct user_namespace *user_ns = mnt_user_ns(path->mnt);
        char *attr_name = NULL, *value;
        int rc = 0;
-       int next = 0;
+       unsigned int next = 0;
+
+       if (buf_len < sizeof(struct smb2_ea_info) + eabuf->EaNameLength +
+                       le16_to_cpu(eabuf->EaValueLength))
+               return -EINVAL;
 
        attr_name = kmalloc(XATTR_NAME_MAX + 1, GFP_KERNEL);
        if (!attr_name)
@@ -2177,7 +2205,13 @@ static int smb2_set_ea(struct smb2_ea_info *eabuf, struct path *path)
 
 next:
                next = le32_to_cpu(eabuf->NextEntryOffset);
+               if (next == 0 || buf_len < next)
+                       break;
+               buf_len -= next;
                eabuf = (struct smb2_ea_info *)((char *)eabuf + next);
+               if (next < (u32)eabuf->EaNameLength + le16_to_cpu(eabuf->EaValueLength))
+                       break;
+
        } while (next != 0);
 
        kfree(attr_name);
@@ -2348,7 +2382,7 @@ static int smb2_creat(struct ksmbd_work *work, struct path *path, char *name,
                        return rc;
        }
 
-       rc = ksmbd_vfs_kern_path(name, 0, path, 0);
+       rc = ksmbd_vfs_kern_path(work, name, 0, path, 0);
        if (rc) {
                pr_err("cannot get linux path (%s), err = %d\n",
                       name, rc);
@@ -2377,6 +2411,10 @@ static int smb2_create_sd_buffer(struct ksmbd_work *work,
        ksmbd_debug(SMB,
                    "Set ACLs using SMB2_CREATE_SD_BUFFER context\n");
        sd_buf = (struct create_sd_buf_req *)context;
+       if (le16_to_cpu(context->DataOffset) +
+           le32_to_cpu(context->DataLength) <
+           sizeof(struct create_sd_buf_req))
+               return -EINVAL;
        return set_info_sec(work->conn, work->tcon, path, &sd_buf->ntsd,
                            le32_to_cpu(sd_buf->ccontext.DataLength), true);
 }
@@ -2423,7 +2461,7 @@ int smb2_open(struct ksmbd_work *work)
        struct oplock_info *opinfo;
        __le32 *next_ptr = NULL;
        int req_op_level = 0, open_flags = 0, may_flags = 0, file_info = 0;
-       int rc = 0, len = 0;
+       int rc = 0;
        int contxt_cnt = 0, query_disk_id = 0;
        int maximal_access_ctxt = 0, posix_ctxt = 0;
        int s_type = 0;
@@ -2495,17 +2533,11 @@ int smb2_open(struct ksmbd_work *work)
                        goto err_out1;
                }
        } else {
-               len = strlen(share->path);
-               ksmbd_debug(SMB, "share path len %d\n", len);
-               name = kmalloc(len + 1, GFP_KERNEL);
+               name = kstrdup("", GFP_KERNEL);
                if (!name) {
-                       rsp->hdr.Status = STATUS_NO_MEMORY;
                        rc = -ENOMEM;
                        goto err_out1;
                }
-
-               memcpy(name, share->path, len);
-               *(name + len) = '\0';
        }
 
        req_op_level = req->RequestedOplockLevel;
@@ -2577,6 +2609,12 @@ int smb2_open(struct ksmbd_work *work)
                        goto err_out1;
                } else if (context) {
                        ea_buf = (struct create_ea_buf_req *)context;
+                       if (le16_to_cpu(context->DataOffset) +
+                           le32_to_cpu(context->DataLength) <
+                           sizeof(struct create_ea_buf_req)) {
+                               rc = -EINVAL;
+                               goto err_out1;
+                       }
                        if (req->CreateOptions & FILE_NO_EA_KNOWLEDGE_LE) {
                                rsp->hdr.Status = STATUS_ACCESS_DENIED;
                                rc = -EACCES;
@@ -2615,6 +2653,12 @@ int smb2_open(struct ksmbd_work *work)
                        } else if (context) {
                                struct create_posix *posix =
                                        (struct create_posix *)context;
+                               if (le16_to_cpu(context->DataOffset) +
+                                   le32_to_cpu(context->DataLength) <
+                                   sizeof(struct create_posix)) {
+                                       rc = -EINVAL;
+                                       goto err_out1;
+                               }
                                ksmbd_debug(SMB, "get posix context\n");
 
                                posix_mode = le32_to_cpu(posix->Mode);
@@ -2628,13 +2672,9 @@ int smb2_open(struct ksmbd_work *work)
                goto err_out1;
        }
 
-       if (req->CreateOptions & FILE_DELETE_ON_CLOSE_LE) {
-               /*
-                * On delete request, instead of following up, need to
-                * look the current entity
-                */
-               rc = ksmbd_vfs_kern_path(name, 0, &path, 1);
-               if (!rc) {
+       rc = ksmbd_vfs_kern_path(work, name, LOOKUP_NO_SYMLINKS, &path, 1);
+       if (!rc) {
+               if (req->CreateOptions & FILE_DELETE_ON_CLOSE_LE) {
                        /*
                         * If file exists with under flags, return access
                         * denied error.
@@ -2653,34 +2693,16 @@ int smb2_open(struct ksmbd_work *work)
                                path_put(&path);
                                goto err_out;
                        }
-               }
-       } else {
-               if (test_share_config_flag(work->tcon->share_conf,
-                                          KSMBD_SHARE_FLAG_FOLLOW_SYMLINKS)) {
-                       /*
-                        * Use LOOKUP_FOLLOW to follow the path of
-                        * symlink in path buildup
-                        */
-                       rc = ksmbd_vfs_kern_path(name, LOOKUP_FOLLOW, &path, 1);
-                       if (rc) { /* Case for broken link ?*/
-                               rc = ksmbd_vfs_kern_path(name, 0, &path, 1);
-                       }
-               } else {
-                       rc = ksmbd_vfs_kern_path(name, 0, &path, 1);
-                       if (!rc && d_is_symlink(path.dentry)) {
-                               rc = -EACCES;
-                               path_put(&path);
-                               goto err_out;
-                       }
+               } else if (d_is_symlink(path.dentry)) {
+                       rc = -EACCES;
+                       path_put(&path);
+                       goto err_out;
                }
        }
 
        if (rc) {
-               if (rc == -EACCES) {
-                       ksmbd_debug(SMB,
-                                   "User does not have right permission\n");
+               if (rc != -ENOENT)
                        goto err_out;
-               }
                ksmbd_debug(SMB, "can not get linux path for %s, rc = %d\n",
                            name, rc);
                rc = 0;
@@ -2786,7 +2808,15 @@ int smb2_open(struct ksmbd_work *work)
                created = true;
                user_ns = mnt_user_ns(path.mnt);
                if (ea_buf) {
-                       rc = smb2_set_ea(&ea_buf->ea, &path);
+                       if (le32_to_cpu(ea_buf->ccontext.DataLength) <
+                           sizeof(struct smb2_ea_info)) {
+                               rc = -EINVAL;
+                               goto err_out;
+                       }
+
+                       rc = smb2_set_ea(&ea_buf->ea,
+                                        le32_to_cpu(ea_buf->ccontext.DataLength),
+                                        &path);
                        if (rc == -EOPNOTSUPP)
                                rc = 0;
                        else if (rc)
@@ -3019,9 +3049,16 @@ int smb2_open(struct ksmbd_work *work)
                        rc = PTR_ERR(az_req);
                        goto err_out;
                } else if (az_req) {
-                       loff_t alloc_size = le64_to_cpu(az_req->AllocationSize);
+                       loff_t alloc_size;
                        int err;
 
+                       if (le16_to_cpu(az_req->ccontext.DataOffset) +
+                           le32_to_cpu(az_req->ccontext.DataLength) <
+                           sizeof(struct create_alloc_size_req)) {
+                               rc = -EINVAL;
+                               goto err_out;
+                       }
+                       alloc_size = le64_to_cpu(az_req->AllocationSize);
                        ksmbd_debug(SMB,
                                    "request smb2 create allocate size : %llu\n",
                                    alloc_size);
@@ -3176,7 +3213,7 @@ err_out1:
                        rsp->hdr.Status = STATUS_INVALID_PARAMETER;
                else if (rc == -EOPNOTSUPP)
                        rsp->hdr.Status = STATUS_NOT_SUPPORTED;
-               else if (rc == -EACCES || rc == -ESTALE)
+               else if (rc == -EACCES || rc == -ESTALE || rc == -EXDEV)
                        rsp->hdr.Status = STATUS_ACCESS_DENIED;
                else if (rc == -ENOENT)
                        rsp->hdr.Status = STATUS_OBJECT_NAME_INVALID;
@@ -4041,6 +4078,10 @@ static int smb2_get_ea(struct ksmbd_work *work, struct ksmbd_file *fp,
        path = &fp->filp->f_path;
        /* single EA entry is requested with given user.* name */
        if (req->InputBufferLength) {
+               if (le32_to_cpu(req->InputBufferLength) <
+                   sizeof(struct smb2_ea_info_req))
+                       return -EINVAL;
+
                ea_req = (struct smb2_ea_info_req *)req->Buffer;
        } else {
                /* need to send all EAs, if no specific EA is requested*/
@@ -4186,7 +4227,7 @@ static void get_file_access_info(struct smb2_query_info_rsp *rsp,
 static int get_file_basic_info(struct smb2_query_info_rsp *rsp,
                               struct ksmbd_file *fp, void *rsp_org)
 {
-       struct smb2_file_all_info *basic_info;
+       struct smb2_file_basic_info *basic_info;
        struct kstat stat;
        u64 time;
 
@@ -4196,7 +4237,7 @@ static int get_file_basic_info(struct smb2_query_info_rsp *rsp,
                return -EACCES;
        }
 
-       basic_info = (struct smb2_file_all_info *)rsp->Buffer;
+       basic_info = (struct smb2_file_basic_info *)rsp->Buffer;
        generic_fillattr(file_mnt_user_ns(fp->filp), file_inode(fp->filp),
                         &stat);
        basic_info->CreationTime = cpu_to_le64(fp->create_time);
@@ -4209,9 +4250,8 @@ static int get_file_basic_info(struct smb2_query_info_rsp *rsp,
        basic_info->Attributes = fp->f_ci->m_fattr;
        basic_info->Pad1 = 0;
        rsp->OutputBufferLength =
-               cpu_to_le32(offsetof(struct smb2_file_all_info, AllocationSize));
-       inc_rfc1001_len(rsp_org, offsetof(struct smb2_file_all_info,
-                                         AllocationSize));
+               cpu_to_le32(sizeof(struct smb2_file_basic_info));
+       inc_rfc1001_len(rsp_org, sizeof(struct smb2_file_basic_info));
        return 0;
 }
 
@@ -4288,8 +4328,7 @@ static int get_file_all_info(struct ksmbd_work *work,
                return -EACCES;
        }
 
-       filename = convert_to_nt_pathname(fp->filename,
-                                         work->tcon->share_conf->path);
+       filename = convert_to_nt_pathname(fp->filename);
        if (!filename)
                return -ENOMEM;
 
@@ -4420,17 +4459,15 @@ static void get_file_stream_info(struct ksmbd_work *work,
                file_info->NextEntryOffset = cpu_to_le32(next);
        }
 
-       if (nbytes) {
+       if (!S_ISDIR(stat.mode)) {
                file_info = (struct smb2_file_stream_info *)
                        &rsp->Buffer[nbytes];
                streamlen = smbConvertToUTF16((__le16 *)file_info->StreamName,
                                              "::$DATA", 7, conn->local_nls, 0);
                streamlen *= 2;
                file_info->StreamNameLength = cpu_to_le32(streamlen);
-               file_info->StreamSize = S_ISDIR(stat.mode) ? 0 :
-                       cpu_to_le64(stat.size);
-               file_info->StreamAllocationSize = S_ISDIR(stat.mode) ? 0 :
-                       cpu_to_le64(stat.size);
+               file_info->StreamSize = 0;
+               file_info->StreamAllocationSize = 0;
                nbytes += sizeof(struct smb2_file_stream_info) + streamlen;
        }
 
@@ -4745,12 +4782,8 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work,
        struct path path;
        int rc = 0, len;
        int fs_infoclass_size = 0;
-       int lookup_flags = 0;
-
-       if (test_share_config_flag(share, KSMBD_SHARE_FLAG_FOLLOW_SYMLINKS))
-               lookup_flags = LOOKUP_FOLLOW;
 
-       rc = ksmbd_vfs_kern_path(share->path, lookup_flags, &path, 0);
+       rc = kern_path(share->path, LOOKUP_NO_SYMLINKS, &path);
        if (rc) {
                pr_err("cannot create vfs path\n");
                return -EIO;
@@ -5299,7 +5332,7 @@ static int smb2_rename(struct ksmbd_work *work,
                        goto out;
 
                len = strlen(new_name);
-               if (new_name[len - 1] != '/') {
+               if (len > 0 && new_name[len - 1] != '/') {
                        pr_err("not allow base filename in rename\n");
                        rc = -ESHARE;
                        goto out;
@@ -5327,11 +5360,14 @@ static int smb2_rename(struct ksmbd_work *work,
        }
 
        ksmbd_debug(SMB, "new name %s\n", new_name);
-       rc = ksmbd_vfs_kern_path(new_name, 0, &path, 1);
-       if (rc)
+       rc = ksmbd_vfs_kern_path(work, new_name, LOOKUP_NO_SYMLINKS, &path, 1);
+       if (rc) {
+               if (rc != -ENOENT)
+                       goto out;
                file_present = false;
-       else
+       } else {
                path_put(&path);
+       }
 
        if (ksmbd_share_veto_filename(share, new_name)) {
                rc = -ENOENT;
@@ -5371,7 +5407,7 @@ out:
 static int smb2_create_link(struct ksmbd_work *work,
                            struct ksmbd_share_config *share,
                            struct smb2_file_link_info *file_info,
-                           struct file *filp,
+                           unsigned int buf_len, struct file *filp,
                            struct nls_table *local_nls)
 {
        char *link_name = NULL, *target_name = NULL, *pathname = NULL;
@@ -5379,6 +5415,10 @@ static int smb2_create_link(struct ksmbd_work *work,
        bool file_present = true;
        int rc;
 
+       if (buf_len < (u64)sizeof(struct smb2_file_link_info) +
+                       le32_to_cpu(file_info->FileNameLength))
+               return -EINVAL;
+
        ksmbd_debug(SMB, "setting FILE_LINK_INFORMATION\n");
        pathname = kmalloc(PATH_MAX, GFP_KERNEL);
        if (!pathname)
@@ -5401,11 +5441,14 @@ static int smb2_create_link(struct ksmbd_work *work,
        }
 
        ksmbd_debug(SMB, "target name is %s\n", target_name);
-       rc = ksmbd_vfs_kern_path(link_name, 0, &path, 0);
-       if (rc)
+       rc = ksmbd_vfs_kern_path(work, link_name, LOOKUP_NO_SYMLINKS, &path, 0);
+       if (rc) {
+               if (rc != -ENOENT)
+                       goto out;
                file_present = false;
-       else
+       } else {
                path_put(&path);
+       }
 
        if (file_info->ReplaceIfExists) {
                if (file_present) {
@@ -5435,12 +5478,11 @@ out:
        return rc;
 }
 
-static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
+static int set_file_basic_info(struct ksmbd_file *fp,
+                              struct smb2_file_basic_info *file_info,
                               struct ksmbd_share_config *share)
 {
-       struct smb2_file_all_info *file_info;
        struct iattr attrs;
-       struct timespec64 ctime;
        struct file *filp;
        struct inode *inode;
        struct user_namespace *user_ns;
@@ -5449,7 +5491,6 @@ static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
        if (!(fp->daccess & FILE_WRITE_ATTRIBUTES_LE))
                return -EACCES;
 
-       file_info = (struct smb2_file_all_info *)buf;
        attrs.ia_valid = 0;
        filp = fp->filp;
        inode = file_inode(filp);
@@ -5463,13 +5504,11 @@ static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
                attrs.ia_valid |= (ATTR_ATIME | ATTR_ATIME_SET);
        }
 
-       if (file_info->ChangeTime) {
+       attrs.ia_valid |= ATTR_CTIME;
+       if (file_info->ChangeTime)
                attrs.ia_ctime = ksmbd_NTtimeToUnix(file_info->ChangeTime);
-               ctime = attrs.ia_ctime;
-               attrs.ia_valid |= ATTR_CTIME;
-       } else {
-               ctime = inode->i_ctime;
-       }
+       else
+               attrs.ia_ctime = inode->i_ctime;
 
        if (file_info->LastWriteTime) {
                attrs.ia_mtime = ksmbd_NTtimeToUnix(file_info->LastWriteTime);
@@ -5515,18 +5554,17 @@ static int set_file_basic_info(struct ksmbd_file *fp, char *buf,
                        return -EACCES;
 
                inode_lock(inode);
+               inode->i_ctime = attrs.ia_ctime;
+               attrs.ia_valid &= ~ATTR_CTIME;
                rc = notify_change(user_ns, dentry, &attrs, NULL);
-               if (!rc) {
-                       inode->i_ctime = ctime;
-                       mark_inode_dirty(inode);
-               }
                inode_unlock(inode);
        }
        return rc;
 }
 
 static int set_file_allocation_info(struct ksmbd_work *work,
-                                   struct ksmbd_file *fp, char *buf)
+                                   struct ksmbd_file *fp,
+                                   struct smb2_file_alloc_info *file_alloc_info)
 {
        /*
         * TODO : It's working fine only when store dos attributes
@@ -5534,7 +5572,6 @@ static int set_file_allocation_info(struct ksmbd_work *work,
         * properly with any smb.conf option
         */
 
-       struct smb2_file_alloc_info *file_alloc_info;
        loff_t alloc_blks;
        struct inode *inode;
        int rc;
@@ -5542,7 +5579,6 @@ static int set_file_allocation_info(struct ksmbd_work *work,
        if (!(fp->daccess & FILE_WRITE_DATA_LE))
                return -EACCES;
 
-       file_alloc_info = (struct smb2_file_alloc_info *)buf;
        alloc_blks = (le64_to_cpu(file_alloc_info->AllocationSize) + 511) >> 9;
        inode = file_inode(fp->filp);
 
@@ -5565,7 +5601,7 @@ static int set_file_allocation_info(struct ksmbd_work *work,
                 * inode size is retained by backup inode size.
                 */
                size = i_size_read(inode);
-               rc = ksmbd_vfs_truncate(work, NULL, fp, alloc_blks * 512);
+               rc = ksmbd_vfs_truncate(work, fp, alloc_blks * 512);
                if (rc) {
                        pr_err("truncate failed! filename : %s, err %d\n",
                               fp->filename, rc);
@@ -5578,9 +5614,8 @@ static int set_file_allocation_info(struct ksmbd_work *work,
 }
 
 static int set_end_of_file_info(struct ksmbd_work *work, struct ksmbd_file *fp,
-                               char *buf)
+                               struct smb2_file_eof_info *file_eof_info)
 {
-       struct smb2_file_eof_info *file_eof_info;
        loff_t newsize;
        struct inode *inode;
        int rc;
@@ -5588,7 +5623,6 @@ static int set_end_of_file_info(struct ksmbd_work *work, struct ksmbd_file *fp,
        if (!(fp->daccess & FILE_WRITE_DATA_LE))
                return -EACCES;
 
-       file_eof_info = (struct smb2_file_eof_info *)buf;
        newsize = le64_to_cpu(file_eof_info->EndOfFile);
        inode = file_inode(fp->filp);
 
@@ -5602,7 +5636,7 @@ static int set_end_of_file_info(struct ksmbd_work *work, struct ksmbd_file *fp,
        if (inode->i_sb->s_magic != MSDOS_SUPER_MAGIC) {
                ksmbd_debug(SMB, "filename : %s truncated to newsize %lld\n",
                            fp->filename, newsize);
-               rc = ksmbd_vfs_truncate(work, NULL, fp, newsize);
+               rc = ksmbd_vfs_truncate(work, fp, newsize);
                if (rc) {
                        ksmbd_debug(SMB, "truncate failed! filename : %s err %d\n",
                                    fp->filename, rc);
@@ -5615,7 +5649,8 @@ static int set_end_of_file_info(struct ksmbd_work *work, struct ksmbd_file *fp,
 }
 
 static int set_rename_info(struct ksmbd_work *work, struct ksmbd_file *fp,
-                          char *buf)
+                          struct smb2_file_rename_info *rename_info,
+                          unsigned int buf_len)
 {
        struct user_namespace *user_ns;
        struct ksmbd_file *parent_fp;
@@ -5628,6 +5663,10 @@ static int set_rename_info(struct ksmbd_work *work, struct ksmbd_file *fp,
                return -EACCES;
        }
 
+       if (buf_len < (u64)sizeof(struct smb2_file_rename_info) +
+                       le32_to_cpu(rename_info->FileNameLength))
+               return -EINVAL;
+
        user_ns = file_mnt_user_ns(fp->filp);
        if (ksmbd_stream_fd(fp))
                goto next;
@@ -5650,14 +5689,13 @@ static int set_rename_info(struct ksmbd_work *work, struct ksmbd_file *fp,
                }
        }
 next:
-       return smb2_rename(work, fp, user_ns,
-                          (struct smb2_file_rename_info *)buf,
+       return smb2_rename(work, fp, user_ns, rename_info,
                           work->sess->conn->local_nls);
 }
 
-static int set_file_disposition_info(struct ksmbd_file *fp, char *buf)
+static int set_file_disposition_info(struct ksmbd_file *fp,
+                                    struct smb2_file_disposition_info *file_info)
 {
-       struct smb2_file_disposition_info *file_info;
        struct inode *inode;
 
        if (!(fp->daccess & FILE_DELETE_LE)) {
@@ -5666,7 +5704,6 @@ static int set_file_disposition_info(struct ksmbd_file *fp, char *buf)
        }
 
        inode = file_inode(fp->filp);
-       file_info = (struct smb2_file_disposition_info *)buf;
        if (file_info->DeletePending) {
                if (S_ISDIR(inode->i_mode) &&
                    ksmbd_vfs_empty_dir(fp) == -ENOTEMPTY)
@@ -5678,15 +5715,14 @@ static int set_file_disposition_info(struct ksmbd_file *fp, char *buf)
        return 0;
 }
 
-static int set_file_position_info(struct ksmbd_file *fp, char *buf)
+static int set_file_position_info(struct ksmbd_file *fp,
+                                 struct smb2_file_pos_info *file_info)
 {
-       struct smb2_file_pos_info *file_info;
        loff_t current_byte_offset;
        unsigned long sector_size;
        struct inode *inode;
 
        inode = file_inode(fp->filp);
-       file_info = (struct smb2_file_pos_info *)buf;
        current_byte_offset = le64_to_cpu(file_info->CurrentByteOffset);
        sector_size = inode->i_sb->s_blocksize;
 
@@ -5702,12 +5738,11 @@ static int set_file_position_info(struct ksmbd_file *fp, char *buf)
        return 0;
 }
 
-static int set_file_mode_info(struct ksmbd_file *fp, char *buf)
+static int set_file_mode_info(struct ksmbd_file *fp,
+                             struct smb2_file_mode_info *file_info)
 {
-       struct smb2_file_mode_info *file_info;
        __le32 mode;
 
-       file_info = (struct smb2_file_mode_info *)buf;
        mode = file_info->Mode;
 
        if ((mode & ~FILE_MODE_INFO_MASK) ||
@@ -5737,40 +5772,74 @@ static int set_file_mode_info(struct ksmbd_file *fp, char *buf)
  * TODO: need to implement an error handling for STATUS_INFO_LENGTH_MISMATCH
  */
 static int smb2_set_info_file(struct ksmbd_work *work, struct ksmbd_file *fp,
-                             int info_class, char *buf,
+                             struct smb2_set_info_req *req,
                              struct ksmbd_share_config *share)
 {
-       switch (info_class) {
+       unsigned int buf_len = le32_to_cpu(req->BufferLength);
+
+       switch (req->FileInfoClass) {
        case FILE_BASIC_INFORMATION:
-               return set_file_basic_info(fp, buf, share);
+       {
+               if (buf_len < sizeof(struct smb2_file_basic_info))
+                       return -EINVAL;
 
+               return set_file_basic_info(fp, (struct smb2_file_basic_info *)req->Buffer, share);
+       }
        case FILE_ALLOCATION_INFORMATION:
-               return set_file_allocation_info(work, fp, buf);
+       {
+               if (buf_len < sizeof(struct smb2_file_alloc_info))
+                       return -EINVAL;
 
+               return set_file_allocation_info(work, fp,
+                                               (struct smb2_file_alloc_info *)req->Buffer);
+       }
        case FILE_END_OF_FILE_INFORMATION:
-               return set_end_of_file_info(work, fp, buf);
+       {
+               if (buf_len < sizeof(struct smb2_file_eof_info))
+                       return -EINVAL;
 
+               return set_end_of_file_info(work, fp,
+                                           (struct smb2_file_eof_info *)req->Buffer);
+       }
        case FILE_RENAME_INFORMATION:
+       {
                if (!test_tree_conn_flag(work->tcon, KSMBD_TREE_CONN_FLAG_WRITABLE)) {
                        ksmbd_debug(SMB,
                                    "User does not have write permission\n");
                        return -EACCES;
                }
-               return set_rename_info(work, fp, buf);
 
+               if (buf_len < sizeof(struct smb2_file_rename_info))
+                       return -EINVAL;
+
+               return set_rename_info(work, fp,
+                                      (struct smb2_file_rename_info *)req->Buffer,
+                                      buf_len);
+       }
        case FILE_LINK_INFORMATION:
+       {
+               if (buf_len < sizeof(struct smb2_file_link_info))
+                       return -EINVAL;
+
                return smb2_create_link(work, work->tcon->share_conf,
-                                       (struct smb2_file_link_info *)buf, fp->filp,
+                                       (struct smb2_file_link_info *)req->Buffer,
+                                       buf_len, fp->filp,
                                        work->sess->conn->local_nls);
-
+       }
        case FILE_DISPOSITION_INFORMATION:
+       {
                if (!test_tree_conn_flag(work->tcon, KSMBD_TREE_CONN_FLAG_WRITABLE)) {
                        ksmbd_debug(SMB,
                                    "User does not have write permission\n");
                        return -EACCES;
                }
-               return set_file_disposition_info(fp, buf);
 
+               if (buf_len < sizeof(struct smb2_file_disposition_info))
+                       return -EINVAL;
+
+               return set_file_disposition_info(fp,
+                                                (struct smb2_file_disposition_info *)req->Buffer);
+       }
        case FILE_FULL_EA_INFORMATION:
        {
                if (!(fp->daccess & FILE_WRITE_EA_LE)) {
@@ -5779,18 +5848,29 @@ static int smb2_set_info_file(struct ksmbd_work *work, struct ksmbd_file *fp,
                        return -EACCES;
                }
 
-               return smb2_set_ea((struct smb2_ea_info *)buf,
-                                  &fp->filp->f_path);
-       }
+               if (buf_len < sizeof(struct smb2_ea_info))
+                       return -EINVAL;
 
+               return smb2_set_ea((struct smb2_ea_info *)req->Buffer,
+                                  buf_len, &fp->filp->f_path);
+       }
        case FILE_POSITION_INFORMATION:
-               return set_file_position_info(fp, buf);
+       {
+               if (buf_len < sizeof(struct smb2_file_pos_info))
+                       return -EINVAL;
 
+               return set_file_position_info(fp, (struct smb2_file_pos_info *)req->Buffer);
+       }
        case FILE_MODE_INFORMATION:
-               return set_file_mode_info(fp, buf);
+       {
+               if (buf_len < sizeof(struct smb2_file_mode_info))
+                       return -EINVAL;
+
+               return set_file_mode_info(fp, (struct smb2_file_mode_info *)req->Buffer);
+       }
        }
 
-       pr_err("Unimplemented Fileinfoclass :%d\n", info_class);
+       pr_err("Unimplemented Fileinfoclass :%d\n", req->FileInfoClass);
        return -EOPNOTSUPP;
 }
 
@@ -5851,8 +5931,7 @@ int smb2_set_info(struct ksmbd_work *work)
        switch (req->InfoType) {
        case SMB2_O_INFO_FILE:
                ksmbd_debug(SMB, "GOT SMB2_O_INFO_FILE\n");
-               rc = smb2_set_info_file(work, fp, req->FileInfoClass,
-                                       req->Buffer, work->tcon->share_conf);
+               rc = smb2_set_info_file(work, fp, req, work->tcon->share_conf);
                break;
        case SMB2_O_INFO_SECURITY:
                ksmbd_debug(SMB, "GOT SMB2_O_INFO_SECURITY\n");
@@ -5879,7 +5958,7 @@ int smb2_set_info(struct ksmbd_work *work)
        return 0;
 
 err_out:
-       if (rc == -EACCES || rc == -EPERM)
+       if (rc == -EACCES || rc == -EPERM || rc == -EXDEV)
                rsp->hdr.Status = STATUS_ACCESS_DENIED;
        else if (rc == -EINVAL)
                rsp->hdr.Status = STATUS_INVALID_PARAMETER;
@@ -8206,7 +8285,8 @@ void smb3_preauth_hash_rsp(struct ksmbd_work *work)
 
        WORK_BUFFERS(work, req, rsp);
 
-       if (le16_to_cpu(req->Command) == SMB2_NEGOTIATE_HE)
+       if (le16_to_cpu(req->Command) == SMB2_NEGOTIATE_HE &&
+           conn->preauth_info)
                ksmbd_gen_preauth_integrity_hash(conn, (char *)rsp,
                                                 conn->preauth_info->Preauth_HashValue);
 
@@ -8310,31 +8390,29 @@ int smb3_decrypt_req(struct ksmbd_work *work)
        struct smb2_hdr *hdr;
        unsigned int pdu_length = get_rfc1002_len(buf);
        struct kvec iov[2];
-       unsigned int buf_data_size = pdu_length + 4 -
+       int buf_data_size = pdu_length + 4 -
                sizeof(struct smb2_transform_hdr);
        struct smb2_transform_hdr *tr_hdr = (struct smb2_transform_hdr *)buf;
-       unsigned int orig_len = le32_to_cpu(tr_hdr->OriginalMessageSize);
        int rc = 0;
 
-       sess = ksmbd_session_lookup_all(conn, le64_to_cpu(tr_hdr->SessionId));
-       if (!sess) {
-               pr_err("invalid session id(%llx) in transform header\n",
-                      le64_to_cpu(tr_hdr->SessionId));
-               return -ECONNABORTED;
-       }
-
-       if (pdu_length + 4 <
-           sizeof(struct smb2_transform_hdr) + sizeof(struct smb2_hdr)) {
+       if (buf_data_size < sizeof(struct smb2_hdr)) {
                pr_err("Transform message is too small (%u)\n",
                       pdu_length);
                return -ECONNABORTED;
        }
 
-       if (pdu_length + 4 < orig_len + sizeof(struct smb2_transform_hdr)) {
+       if (buf_data_size < le32_to_cpu(tr_hdr->OriginalMessageSize)) {
                pr_err("Transform message is broken\n");
                return -ECONNABORTED;
        }
 
+       sess = ksmbd_session_lookup_all(conn, le64_to_cpu(tr_hdr->SessionId));
+       if (!sess) {
+               pr_err("invalid session id(%llx) in transform header\n",
+                      le64_to_cpu(tr_hdr->SessionId));
+               return -ECONNABORTED;
+       }
+
        iov[0].iov_base = buf;
        iov[0].iov_len = sizeof(struct smb2_transform_hdr);
        iov[1].iov_base = buf + sizeof(struct smb2_transform_hdr);
index bcec845..a6dec5e 100644 (file)
@@ -1464,6 +1464,15 @@ struct smb2_file_all_info { /* data block encoding of response to level 18 */
        char   FileName[1];
 } __packed; /* level 18 Query */
 
+struct smb2_file_basic_info { /* data block encoding of response to level 18 */
+       __le64 CreationTime;    /* Beginning of FILE_BASIC_INFO equivalent */
+       __le64 LastAccessTime;
+       __le64 LastWriteTime;
+       __le64 ChangeTime;
+       __le32 Attributes;
+       __u32  Pad1;            /* End of FILE_BASIC_INFO_INFO equivalent */
+} __packed;
+
 struct smb2_file_alt_name_info {
        __le32 FileNameLength;
        char FileName[0];
@@ -1628,7 +1637,6 @@ struct smb2_posix_info {
 } __packed;
 
 /* functions */
-int init_smb2_0_server(struct ksmbd_conn *conn);
 void init_smb2_1_server(struct ksmbd_conn *conn);
 void init_smb3_0_server(struct ksmbd_conn *conn);
 void init_smb3_02_server(struct ksmbd_conn *conn);
index 43d3123..707490a 100644 (file)
@@ -21,7 +21,6 @@ static const char basechars[43] = "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ_-!@#$%";
 #define MAGIC_CHAR '~'
 #define PERIOD '.'
 #define mangle(V) ((char)(basechars[(V) % MANGLE_BASE]))
-#define KSMBD_MIN_SUPPORTED_HEADER_SIZE        (sizeof(struct smb2_hdr))
 
 struct smb_protocol {
        int             index;
@@ -89,7 +88,7 @@ unsigned int ksmbd_server_side_copy_max_total_size(void)
 
 inline int ksmbd_min_protocol(void)
 {
-       return SMB2_PROT;
+       return SMB21_PROT;
 }
 
 inline int ksmbd_max_protocol(void)
@@ -129,16 +128,22 @@ int ksmbd_lookup_protocol_idx(char *str)
  *
  * check for valid smb signature and packet direction(request/response)
  *
- * Return:      0 on success, otherwise 1
+ * Return:      0 on success, otherwise -EINVAL
  */
 int ksmbd_verify_smb_message(struct ksmbd_work *work)
 {
-       struct smb2_hdr *smb2_hdr = work->request_buf;
+       struct smb2_hdr *smb2_hdr = work->request_buf + work->next_smb2_rcv_hdr_off;
+       struct smb_hdr *hdr;
 
        if (smb2_hdr->ProtocolId == SMB2_PROTO_NUMBER)
                return ksmbd_smb2_check_message(work);
 
-       return 0;
+       hdr = work->request_buf;
+       if (*(__le32 *)hdr->Protocol == SMB1_PROTO_NUMBER &&
+           hdr->Command == SMB_COM_NEGOTIATE)
+               return 0;
+
+       return -EINVAL;
 }
 
 /**
@@ -149,20 +154,7 @@ int ksmbd_verify_smb_message(struct ksmbd_work *work)
  */
 bool ksmbd_smb_request(struct ksmbd_conn *conn)
 {
-       int type = *(char *)conn->request_buf;
-
-       switch (type) {
-       case RFC1002_SESSION_MESSAGE:
-               /* Regular SMB request */
-               return true;
-       case RFC1002_SESSION_KEEP_ALIVE:
-               ksmbd_debug(SMB, "RFC 1002 session keep alive\n");
-               break;
-       default:
-               ksmbd_debug(SMB, "RFC 1002 unknown request type 0x%x\n", type);
-       }
-
-       return false;
+       return conn->request_buf[0] == 0;
 }
 
 static bool supported_protocol(int idx)
@@ -176,10 +168,12 @@ static bool supported_protocol(int idx)
                idx <= server_conf.max_protocol);
 }
 
-static char *next_dialect(char *dialect, int *next_off)
+static char *next_dialect(char *dialect, int *next_off, int bcount)
 {
        dialect = dialect + *next_off;
-       *next_off = strlen(dialect);
+       *next_off = strnlen(dialect, bcount);
+       if (dialect[*next_off] != '\0')
+               return NULL;
        return dialect;
 }
 
@@ -194,7 +188,9 @@ static int ksmbd_lookup_dialect_by_name(char *cli_dialects, __le16 byte_count)
                dialect = cli_dialects;
                bcount = le16_to_cpu(byte_count);
                do {
-                       dialect = next_dialect(dialect, &next);
+                       dialect = next_dialect(dialect, &next, bcount);
+                       if (!dialect)
+                               break;
                        ksmbd_debug(SMB, "client requested dialect %s\n",
                                    dialect);
                        if (!strcmp(dialect, smb1_protos[i].name)) {
@@ -242,13 +238,22 @@ int ksmbd_lookup_dialect_by_id(__le16 *cli_dialects, __le16 dialects_count)
 
 static int ksmbd_negotiate_smb_dialect(void *buf)
 {
-       __le32 proto;
+       int smb_buf_length = get_rfc1002_len(buf);
+       __le32 proto = ((struct smb2_hdr *)buf)->ProtocolId;
 
-       proto = ((struct smb2_hdr *)buf)->ProtocolId;
        if (proto == SMB2_PROTO_NUMBER) {
                struct smb2_negotiate_req *req;
+               int smb2_neg_size =
+                       offsetof(struct smb2_negotiate_req, Dialects) - 4;
 
                req = (struct smb2_negotiate_req *)buf;
+               if (smb2_neg_size > smb_buf_length)
+                       goto err_out;
+
+               if (smb2_neg_size + le16_to_cpu(req->DialectCount) * sizeof(__le16) >
+                   smb_buf_length)
+                       goto err_out;
+
                return ksmbd_lookup_dialect_by_id(req->Dialects,
                                                  req->DialectCount);
        }
@@ -258,14 +263,22 @@ static int ksmbd_negotiate_smb_dialect(void *buf)
                struct smb_negotiate_req *req;
 
                req = (struct smb_negotiate_req *)buf;
+               if (le16_to_cpu(req->ByteCount) < 2)
+                       goto err_out;
+
+               if (offsetof(struct smb_negotiate_req, DialectsArray) - 4 +
+                       le16_to_cpu(req->ByteCount) > smb_buf_length) {
+                       goto err_out;
+               }
+
                return ksmbd_lookup_dialect_by_name(req->DialectsArray,
                                                    req->ByteCount);
        }
 
+err_out:
        return BAD_PROT_ID;
 }
 
-#define SMB_COM_NEGOTIATE      0x72
 int ksmbd_init_smb_server(struct ksmbd_work *work)
 {
        struct ksmbd_conn *conn = work->conn;
@@ -280,11 +293,6 @@ int ksmbd_init_smb_server(struct ksmbd_work *work)
        return 0;
 }
 
-bool ksmbd_pdu_size_has_room(unsigned int pdu)
-{
-       return (pdu >= KSMBD_MIN_SUPPORTED_HEADER_SIZE - 4);
-}
-
 int ksmbd_populate_dot_dotdot_entries(struct ksmbd_work *work, int info_level,
                                      struct ksmbd_file *dir,
                                      struct ksmbd_dir_info *d_info,
@@ -419,7 +427,7 @@ int ksmbd_extract_shortname(struct ksmbd_conn *conn, const char *longname,
 
 static int __smb2_negotiate(struct ksmbd_conn *conn)
 {
-       return (conn->dialect >= SMB20_PROT_ID &&
+       return (conn->dialect >= SMB21_PROT_ID &&
                conn->dialect <= SMB311_PROT_ID);
 }
 
@@ -449,7 +457,7 @@ int ksmbd_smb_negotiate_common(struct ksmbd_work *work, unsigned int command)
                }
        }
 
-       if (command == SMB2_NEGOTIATE_HE) {
+       if (command == SMB2_NEGOTIATE_HE && __smb2_negotiate(conn)) {
                ret = smb2_handle_negotiate(work);
                init_smb2_neg_rsp(work);
                return ret;
index 57c667c..6e79e75 100644 (file)
 #define CIFS_DEFAULT_IOSIZE    (64 * 1024)
 #define MAX_CIFS_SMALL_BUFFER_SIZE 448 /* big enough for most */
 
-/* RFC 1002 session packet types */
-#define RFC1002_SESSION_MESSAGE                        0x00
-#define RFC1002_SESSION_REQUEST                        0x81
-#define RFC1002_POSITIVE_SESSION_RESPONSE      0x82
-#define RFC1002_NEGATIVE_SESSION_RESPONSE      0x83
-#define RFC1002_RETARGET_SESSION_RESPONSE      0x84
-#define RFC1002_SESSION_KEEP_ALIVE             0x85
+#define MAX_STREAM_PROT_LEN    0x00FFFFFF
 
 /* Responses when opening a file. */
 #define F_SUPERSEDED   0
                FILE_READ_ATTRIBUTES | FILE_WRITE_ATTRIBUTES)
 
 #define SMB1_PROTO_NUMBER              cpu_to_le32(0x424d53ff)
+#define SMB_COM_NEGOTIATE              0x72
 
 #define SMB1_CLIENT_GUID_SIZE          (16)
 struct smb_hdr {
@@ -500,8 +495,6 @@ int ksmbd_lookup_dialect_by_id(__le16 *cli_dialects, __le16 dialects_count);
 
 int ksmbd_init_smb_server(struct ksmbd_work *work);
 
-bool ksmbd_pdu_size_has_room(unsigned int pdu);
-
 struct ksmbd_kstat;
 int ksmbd_populate_dot_dotdot_entries(struct ksmbd_work *work,
                                      int info_level,
index 0a95cde..bd792db 100644 (file)
@@ -380,7 +380,7 @@ static void parse_dacl(struct user_namespace *user_ns,
 {
        int i, ret;
        int num_aces = 0;
-       int acl_size;
+       unsigned int acl_size;
        char *acl_base;
        struct smb_ace **ppace;
        struct posix_acl_entry *cf_pace, *cf_pdace;
@@ -392,7 +392,7 @@ static void parse_dacl(struct user_namespace *user_ns,
                return;
 
        /* validate that we do not go past end of acl */
-       if (end_of_acl <= (char *)pdacl ||
+       if (end_of_acl < (char *)pdacl + sizeof(struct smb_acl) ||
            end_of_acl < (char *)pdacl + le16_to_cpu(pdacl->size)) {
                pr_err("ACL too small to parse DACL\n");
                return;
@@ -431,8 +431,22 @@ static void parse_dacl(struct user_namespace *user_ns,
         * user/group/other have no permissions
         */
        for (i = 0; i < num_aces; ++i) {
+               if (end_of_acl - acl_base < acl_size)
+                       break;
+
                ppace[i] = (struct smb_ace *)(acl_base + acl_size);
                acl_base = (char *)ppace[i];
+               acl_size = offsetof(struct smb_ace, sid) +
+                       offsetof(struct smb_sid, sub_auth);
+
+               if (end_of_acl - acl_base < acl_size ||
+                   ppace[i]->sid.num_subauth > SID_MAX_SUB_AUTHORITIES ||
+                   (end_of_acl - acl_base <
+                    acl_size + sizeof(__le32) * ppace[i]->sid.num_subauth) ||
+                   (le16_to_cpu(ppace[i]->size) <
+                    acl_size + sizeof(__le32) * ppace[i]->sid.num_subauth))
+                       break;
+
                acl_size = le16_to_cpu(ppace[i]->size);
                ppace[i]->access_req =
                        smb_map_generic_desired_access(ppace[i]->access_req);
@@ -807,6 +821,9 @@ int parse_sec_desc(struct user_namespace *user_ns, struct smb_ntsd *pntsd,
        if (!pntsd)
                return -EIO;
 
+       if (acl_len < sizeof(struct smb_ntsd))
+               return -EINVAL;
+
        owner_sid_ptr = (struct smb_sid *)((char *)pntsd +
                        le32_to_cpu(pntsd->osidoffset));
        group_sid_ptr = (struct smb_sid *)((char *)pntsd +
index 52b2556..3a7fa23 100644 (file)
@@ -20,7 +20,6 @@
 #define SUBMOD_NAME    "smb_direct"
 
 #include <linux/kthread.h>
-#include <linux/rwlock.h>
 #include <linux/list.h>
 #include <linux/mempool.h>
 #include <linux/highmem.h>
index dc15a5e..c14320e 100644 (file)
@@ -215,7 +215,7 @@ out_error:
  * ksmbd_kthread_fn() - listen to new SMB connections and callback server
  * @p:         arguments to forker thread
  *
- * Return:     Returns a task_struct or ERR_PTR
+ * Return:     0 on success, error number otherwise
  */
 static int ksmbd_kthread_fn(void *p)
 {
@@ -387,7 +387,7 @@ static void tcp_destroy_socket(struct socket *ksmbd_socket)
 /**
  * create_socket - create socket for ksmbd/0
  *
- * Return:     Returns a task_struct or ERR_PTR
+ * Return:     0 on success, error number otherwise
  */
 static int create_socket(struct interface *iface)
 {
index b047f29..b419542 100644 (file)
@@ -19,6 +19,8 @@
 #include <linux/sched/xacct.h>
 #include <linux/crc32c.h>
 
+#include "../internal.h"       /* for vfs_path_lookup */
+
 #include "glob.h"
 #include "oplock.h"
 #include "connection.h"
@@ -44,7 +46,6 @@ static char *extract_last_component(char *path)
                p++;
        } else {
                p = NULL;
-               pr_err("Invalid path %s\n", path);
        }
        return p;
 }
@@ -155,7 +156,7 @@ int ksmbd_vfs_query_maximal_access(struct user_namespace *user_ns,
 /**
  * ksmbd_vfs_create() - vfs helper for smb create file
  * @work:      work
- * @name:      file name
+ * @name:      file name that is relative to share
  * @mode:      file create mode
  *
  * Return:     0 on success, otherwise error
@@ -166,7 +167,8 @@ int ksmbd_vfs_create(struct ksmbd_work *work, const char *name, umode_t mode)
        struct dentry *dentry;
        int err;
 
-       dentry = kern_path_create(AT_FDCWD, name, &path, 0);
+       dentry = ksmbd_vfs_kern_path_create(work, name,
+                                           LOOKUP_NO_SYMLINKS, &path);
        if (IS_ERR(dentry)) {
                err = PTR_ERR(dentry);
                if (err != -ENOENT)
@@ -191,7 +193,7 @@ int ksmbd_vfs_create(struct ksmbd_work *work, const char *name, umode_t mode)
 /**
  * ksmbd_vfs_mkdir() - vfs helper for smb create directory
  * @work:      work
- * @name:      directory name
+ * @name:      directory name that is relative to share
  * @mode:      directory create mode
  *
  * Return:     0 on success, otherwise error
@@ -203,7 +205,9 @@ int ksmbd_vfs_mkdir(struct ksmbd_work *work, const char *name, umode_t mode)
        struct dentry *dentry;
        int err;
 
-       dentry = kern_path_create(AT_FDCWD, name, &path, LOOKUP_DIRECTORY);
+       dentry = ksmbd_vfs_kern_path_create(work, name,
+                                           LOOKUP_NO_SYMLINKS | LOOKUP_DIRECTORY,
+                                           &path);
        if (IS_ERR(dentry)) {
                err = PTR_ERR(dentry);
                if (err != -EEXIST)
@@ -578,7 +582,7 @@ int ksmbd_vfs_fsync(struct ksmbd_work *work, u64 fid, u64 p_id)
 
 /**
  * ksmbd_vfs_remove_file() - vfs helper for smb rmdir or unlink
- * @name:      absolute directory or file name
+ * @name:      directory or file name that is relative to share
  *
  * Return:     0 on success, otherwise error
  */
@@ -588,16 +592,11 @@ int ksmbd_vfs_remove_file(struct ksmbd_work *work, char *name)
        struct path path;
        struct dentry *parent;
        int err;
-       int flags = 0;
 
        if (ksmbd_override_fsids(work))
                return -ENOMEM;
 
-       if (test_share_config_flag(work->tcon->share_conf,
-                                  KSMBD_SHARE_FLAG_FOLLOW_SYMLINKS))
-               flags = LOOKUP_FOLLOW;
-
-       err = kern_path(name, flags, &path);
+       err = ksmbd_vfs_kern_path(work, name, LOOKUP_NO_SYMLINKS, &path, false);
        if (err) {
                ksmbd_debug(VFS, "can't get %s, err %d\n", name, err);
                ksmbd_revert_fsids(work);
@@ -642,7 +641,7 @@ out_err:
 /**
  * ksmbd_vfs_link() - vfs helper for creating smb hardlink
  * @oldname:   source file name
- * @newname:   hardlink name
+ * @newname:   hardlink name that is relative to share
  *
  * Return:     0 on success, otherwise error
  */
@@ -652,24 +651,20 @@ int ksmbd_vfs_link(struct ksmbd_work *work, const char *oldname,
        struct path oldpath, newpath;
        struct dentry *dentry;
        int err;
-       int flags = 0;
 
        if (ksmbd_override_fsids(work))
                return -ENOMEM;
 
-       if (test_share_config_flag(work->tcon->share_conf,
-                                  KSMBD_SHARE_FLAG_FOLLOW_SYMLINKS))
-               flags = LOOKUP_FOLLOW;
-
-       err = kern_path(oldname, flags, &oldpath);
+       err = kern_path(oldname, LOOKUP_NO_SYMLINKS, &oldpath);
        if (err) {
                pr_err("cannot get linux path for %s, err = %d\n",
                       oldname, err);
                goto out1;
        }
 
-       dentry = kern_path_create(AT_FDCWD, newname, &newpath,
-                                 flags | LOOKUP_REVAL);
+       dentry = ksmbd_vfs_kern_path_create(work, newname,
+                                           LOOKUP_NO_SYMLINKS | LOOKUP_REVAL,
+                                           &newpath);
        if (IS_ERR(dentry)) {
                err = PTR_ERR(dentry);
                pr_err("path create err for %s, err %d\n", newname, err);
@@ -788,21 +783,19 @@ int ksmbd_vfs_fp_rename(struct ksmbd_work *work, struct ksmbd_file *fp,
        struct dentry *src_dent, *trap_dent, *src_child;
        char *dst_name;
        int err;
-       int flags;
 
        dst_name = extract_last_component(newname);
-       if (!dst_name)
-               return -EINVAL;
+       if (!dst_name) {
+               dst_name = newname;
+               newname = "";
+       }
 
        src_dent_parent = dget_parent(fp->filp->f_path.dentry);
        src_dent = fp->filp->f_path.dentry;
 
-       flags = LOOKUP_DIRECTORY;
-       if (test_share_config_flag(work->tcon->share_conf,
-                                  KSMBD_SHARE_FLAG_FOLLOW_SYMLINKS))
-               flags |= LOOKUP_FOLLOW;
-
-       err = kern_path(newname, flags, &dst_path);
+       err = ksmbd_vfs_kern_path(work, newname,
+                                 LOOKUP_NO_SYMLINKS | LOOKUP_DIRECTORY,
+                                 &dst_path, false);
        if (err) {
                ksmbd_debug(VFS, "Cannot get path for %s [%d]\n", newname, err);
                goto out;
@@ -848,61 +841,43 @@ out:
 /**
  * ksmbd_vfs_truncate() - vfs helper for smb file truncate
  * @work:      work
- * @name:      old filename
  * @fid:       file id of old file
  * @size:      truncate to given size
  *
  * Return:     0 on success, otherwise error
  */
-int ksmbd_vfs_truncate(struct ksmbd_work *work, const char *name,
+int ksmbd_vfs_truncate(struct ksmbd_work *work,
                       struct ksmbd_file *fp, loff_t size)
 {
-       struct path path;
        int err = 0;
+       struct file *filp;
 
-       if (name) {
-               err = kern_path(name, 0, &path);
-               if (err) {
-                       pr_err("cannot get linux path for %s, err %d\n",
-                              name, err);
-                       return err;
-               }
-               err = vfs_truncate(&path, size);
-               if (err)
-                       pr_err("truncate failed for %s err %d\n",
-                              name, err);
-               path_put(&path);
-       } else {
-               struct file *filp;
-
-               filp = fp->filp;
-
-               /* Do we need to break any of a levelII oplock? */
-               smb_break_all_levII_oplock(work, fp, 1);
+       filp = fp->filp;
 
-               if (!work->tcon->posix_extensions) {
-                       struct inode *inode = file_inode(filp);
+       /* Do we need to break any of a levelII oplock? */
+       smb_break_all_levII_oplock(work, fp, 1);
 
-                       if (size < inode->i_size) {
-                               err = check_lock_range(filp, size,
-                                                      inode->i_size - 1, WRITE);
-                       } else {
-                               err = check_lock_range(filp, inode->i_size,
-                                                      size - 1, WRITE);
-                       }
+       if (!work->tcon->posix_extensions) {
+               struct inode *inode = file_inode(filp);
 
-                       if (err) {
-                               pr_err("failed due to lock\n");
-                               return -EAGAIN;
-                       }
+               if (size < inode->i_size) {
+                       err = check_lock_range(filp, size,
+                                              inode->i_size - 1, WRITE);
+               } else {
+                       err = check_lock_range(filp, inode->i_size,
+                                              size - 1, WRITE);
                }
 
-               err = vfs_truncate(&filp->f_path, size);
-               if (err)
-                       pr_err("truncate failed for filename : %s err %d\n",
-                              fp->filename, err);
+               if (err) {
+                       pr_err("failed due to lock\n");
+                       return -EAGAIN;
+               }
        }
 
+       err = vfs_truncate(&filp->f_path, size);
+       if (err)
+               pr_err("truncate failed for filename : %s err %d\n",
+                      fp->filename, err);
        return err;
 }
 
@@ -1220,22 +1195,25 @@ static int ksmbd_vfs_lookup_in_dir(struct path *dir, char *name, size_t namelen)
 
 /**
  * ksmbd_vfs_kern_path() - lookup a file and get path info
- * @name:      name of file for lookup
+ * @name:      file path that is relative to share
  * @flags:     lookup flags
  * @path:      if lookup succeed, return path info
  * @caseless:  caseless filename lookup
  *
  * Return:     0 on success, otherwise error
  */
-int ksmbd_vfs_kern_path(char *name, unsigned int flags, struct path *path,
-                       bool caseless)
+int ksmbd_vfs_kern_path(struct ksmbd_work *work, char *name,
+                       unsigned int flags, struct path *path, bool caseless)
 {
+       struct ksmbd_share_config *share_conf = work->tcon->share_conf;
        int err;
 
-       if (name[0] != '/')
-               return -EINVAL;
-
-       err = kern_path(name, flags, path);
+       flags |= LOOKUP_BENEATH;
+       err = vfs_path_lookup(share_conf->vfs_path.dentry,
+                             share_conf->vfs_path.mnt,
+                             name,
+                             flags,
+                             path);
        if (!err)
                return 0;
 
@@ -1249,11 +1227,10 @@ int ksmbd_vfs_kern_path(char *name, unsigned int flags, struct path *path,
                        return -ENOMEM;
 
                path_len = strlen(filepath);
-               remain_len = path_len - 1;
+               remain_len = path_len;
 
-               err = kern_path("/", flags, &parent);
-               if (err)
-                       goto out;
+               parent = share_conf->vfs_path;
+               path_get(&parent);
 
                while (d_can_lookup(parent.dentry)) {
                        char *filename = filepath + path_len - remain_len;
@@ -1266,21 +1243,21 @@ int ksmbd_vfs_kern_path(char *name, unsigned int flags, struct path *path,
 
                        err = ksmbd_vfs_lookup_in_dir(&parent, filename,
                                                      filename_len);
-                       if (err) {
-                               path_put(&parent);
+                       path_put(&parent);
+                       if (err)
                                goto out;
-                       }
 
-                       path_put(&parent);
                        next[0] = '\0';
 
-                       err = kern_path(filepath, flags, &parent);
+                       err = vfs_path_lookup(share_conf->vfs_path.dentry,
+                                             share_conf->vfs_path.mnt,
+                                             filepath,
+                                             flags,
+                                             &parent);
                        if (err)
                                goto out;
-
-                       if (is_last) {
-                               path->mnt = parent.mnt;
-                               path->dentry = parent.dentry;
+                       else if (is_last) {
+                               *path = parent;
                                goto out;
                        }
 
@@ -1296,6 +1273,23 @@ out:
        return err;
 }
 
+struct dentry *ksmbd_vfs_kern_path_create(struct ksmbd_work *work,
+                                         const char *name,
+                                         unsigned int flags,
+                                         struct path *path)
+{
+       char *abs_name;
+       struct dentry *dent;
+
+       abs_name = convert_to_unix_name(work->tcon->share_conf, name);
+       if (!abs_name)
+               return ERR_PTR(-ENOMEM);
+
+       dent = kern_path_create(AT_FDCWD, abs_name, path, flags);
+       kfree(abs_name);
+       return dent;
+}
+
 int ksmbd_vfs_remove_acl_xattrs(struct user_namespace *user_ns,
                                struct dentry *dentry)
 {
index 85db50a..7b1dcaa 100644 (file)
@@ -126,7 +126,7 @@ int ksmbd_vfs_link(struct ksmbd_work *work,
 int ksmbd_vfs_getattr(struct path *path, struct kstat *stat);
 int ksmbd_vfs_fp_rename(struct ksmbd_work *work, struct ksmbd_file *fp,
                        char *newname);
-int ksmbd_vfs_truncate(struct ksmbd_work *work, const char *name,
+int ksmbd_vfs_truncate(struct ksmbd_work *work,
                       struct ksmbd_file *fp, loff_t size);
 struct srv_copychunk;
 int ksmbd_vfs_copy_file_ranges(struct ksmbd_work *work,
@@ -152,8 +152,13 @@ int ksmbd_vfs_xattr_stream_name(char *stream_name, char **xattr_stream_name,
                                size_t *xattr_stream_name_size, int s_type);
 int ksmbd_vfs_remove_xattr(struct user_namespace *user_ns,
                           struct dentry *dentry, char *attr_name);
-int ksmbd_vfs_kern_path(char *name, unsigned int flags, struct path *path,
+int ksmbd_vfs_kern_path(struct ksmbd_work *work,
+                       char *name, unsigned int flags, struct path *path,
                        bool caseless);
+struct dentry *ksmbd_vfs_kern_path_create(struct ksmbd_work *work,
+                                         const char *name,
+                                         unsigned int flags,
+                                         struct path *path);
 int ksmbd_vfs_empty_dir(struct ksmbd_file *fp);
 void ksmbd_vfs_set_fadvise(struct file *filp, __le32 option);
 int ksmbd_vfs_zero_data(struct ksmbd_work *work, struct ksmbd_file *fp,
index c69a0bb..4f1a451 100644 (file)
@@ -134,18 +134,9 @@ svcxdr_decode_owner(struct xdr_stream *xdr, struct xdr_netobj *obj)
 static inline bool
 svcxdr_encode_owner(struct xdr_stream *xdr, const struct xdr_netobj *obj)
 {
-       unsigned int quadlen = XDR_QUADLEN(obj->len);
-       __be32 *p;
-
-       if (xdr_stream_encode_u32(xdr, obj->len) < 0)
-               return false;
-       p = xdr_reserve_space(xdr, obj->len);
-       if (!p)
+       if (obj->len > XDR_MAX_NETOBJ)
                return false;
-       p[quadlen - 1] = 0;     /* XDR pad */
-       memcpy(p, obj->data, obj->len);
-
-       return true;
+       return xdr_stream_encode_opaque(xdr, obj->data, obj->len) > 0;
 }
 
 #endif /* _LOCKD_SVCXDR_H_ */
index 0b6cd3b..994ec22 100644 (file)
@@ -150,7 +150,7 @@ static void netfs_clear_unread(struct netfs_read_subrequest *subreq)
 {
        struct iov_iter iter;
 
-       iov_iter_xarray(&iter, WRITE, &subreq->rreq->mapping->i_pages,
+       iov_iter_xarray(&iter, READ, &subreq->rreq->mapping->i_pages,
                        subreq->start + subreq->transferred,
                        subreq->len   - subreq->transferred);
        iov_iter_zero(iov_iter_count(&iter), &iter);
index edec458..0a9b726 100644 (file)
@@ -42,7 +42,6 @@ EXPORT_SYMBOL_GPL(locks_start_grace);
 
 /**
  * locks_end_grace
- * @net: net namespace that this lock manager belongs to
  * @lm: who this grace period is for
  *
  * Call this function to state that the given lock manager is ready to
index 7629248..be3c1aa 100644 (file)
@@ -542,7 +542,7 @@ nfsd_file_close_inode_sync(struct inode *inode)
 }
 
 /**
- * nfsd_file_close_inode_sync - attempt to forcibly close a nfsd_file
+ * nfsd_file_close_inode - attempt a delayed close of a nfsd_file
  * @inode: inode of the file to attempt to remove
  *
  * Walk the whole hash bucket, looking for any files that correspond to "inode".
index 4235641..3f4027a 100644 (file)
@@ -3570,7 +3570,7 @@ static struct nfsd4_conn *__nfsd4_find_conn(struct svc_xprt *xpt, struct nfsd4_s
 }
 
 static __be32 nfsd4_match_existing_connection(struct svc_rqst *rqst,
-                               struct nfsd4_session *session, u32 req)
+               struct nfsd4_session *session, u32 req, struct nfsd4_conn **conn)
 {
        struct nfs4_client *clp = session->se_client;
        struct svc_xprt *xpt = rqst->rq_xprt;
@@ -3593,6 +3593,8 @@ static __be32 nfsd4_match_existing_connection(struct svc_rqst *rqst,
        else
                status = nfserr_inval;
        spin_unlock(&clp->cl_lock);
+       if (status == nfs_ok && conn)
+               *conn = c;
        return status;
 }
 
@@ -3617,8 +3619,16 @@ __be32 nfsd4_bind_conn_to_session(struct svc_rqst *rqstp,
        status = nfserr_wrong_cred;
        if (!nfsd4_mach_creds_match(session->se_client, rqstp))
                goto out;
-       status = nfsd4_match_existing_connection(rqstp, session, bcts->dir);
-       if (status == nfs_ok || status == nfserr_inval)
+       status = nfsd4_match_existing_connection(rqstp, session,
+                       bcts->dir, &conn);
+       if (status == nfs_ok) {
+               if (bcts->dir == NFS4_CDFC4_FORE_OR_BOTH ||
+                               bcts->dir == NFS4_CDFC4_BACK)
+                       conn->cn_flags |= NFS4_CDFC4_BACK;
+               nfsd4_probe_callback(session->se_client);
+               goto out;
+       }
+       if (status == nfserr_inval)
                goto out;
        status = nfsd4_map_bcts_dir(&bcts->dir);
        if (status)
index 7abeccb..cf030eb 100644 (file)
@@ -3544,15 +3544,18 @@ nfsd4_encode_dirent(void *ccdv, const char *name, int namlen,
                goto fail;
        cd->rd_maxcount -= entry_bytes;
        /*
-        * RFC 3530 14.2.24 describes rd_dircount as only a "hint", so
-        * let's always let through the first entry, at least:
+        * RFC 3530 14.2.24 describes rd_dircount as only a "hint", and
+        * notes that it could be zero. If it is zero, then the server
+        * should enforce only the rd_maxcount value.
         */
-       if (!cd->rd_dircount)
-               goto fail;
-       name_and_cookie = 4 + 4 * XDR_QUADLEN(namlen) + 8;
-       if (name_and_cookie > cd->rd_dircount && cd->cookie_offset)
-               goto fail;
-       cd->rd_dircount -= min(cd->rd_dircount, name_and_cookie);
+       if (cd->rd_dircount) {
+               name_and_cookie = 4 + 4 * XDR_QUADLEN(namlen) + 8;
+               if (name_and_cookie > cd->rd_dircount && cd->cookie_offset)
+                       goto fail;
+               cd->rd_dircount -= min(cd->rd_dircount, name_and_cookie);
+               if (!cd->rd_dircount)
+                       cd->rd_maxcount = 0;
+       }
 
        cd->cookie_offset = cookie_offset;
 skip_entry:
index c2c3d90..070e5dd 100644 (file)
@@ -793,7 +793,10 @@ out_close:
                svc_xprt_put(xprt);
        }
 out_err:
-       nfsd_destroy(net);
+       if (!list_empty(&nn->nfsd_serv->sv_permsocks))
+               nn->nfsd_serv->sv_nrthreads--;
+        else
+               nfsd_destroy(net);
        return err;
 }
 
@@ -1545,7 +1548,7 @@ static int __init init_nfsd(void)
                goto out_free_all;
        return 0;
 out_free_all:
-       unregister_pernet_subsys(&nfsd_net_ops);
+       unregister_filesystem(&nfsd_fs_type);
 out_free_exports:
        remove_proc_entry("fs/nfs/exports", NULL);
        remove_proc_entry("fs/nfs", NULL);
index 34c4cbf..e8c00dd 100644 (file)
@@ -6,13 +6,9 @@
  * TODO: Merge attr_set_size/attr_data_get_block/attr_allocate_frame?
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/hash.h>
-#include <linux/nls.h>
-#include <linux/ratelimit.h>
 #include <linux/slab.h>
+#include <linux/kernel.h>
 
 #include "debug.h"
 #include "ntfs.h"
@@ -291,7 +287,7 @@ int attr_make_nonresident(struct ntfs_inode *ni, struct ATTRIB *attr,
                if (!rsize) {
                        /* Empty resident -> Non empty nonresident. */
                } else if (!is_data) {
-                       err = ntfs_sb_write_run(sbi, run, 0, data, rsize);
+                       err = ntfs_sb_write_run(sbi, run, 0, data, rsize, 0);
                        if (err)
                                goto out2;
                } else if (!page) {
@@ -451,11 +447,8 @@ again:
 again_1:
        align = sbi->cluster_size;
 
-       if (is_ext) {
+       if (is_ext)
                align <<= attr_b->nres.c_unit;
-               if (is_attr_sparsed(attr_b))
-                       keep_prealloc = false;
-       }
 
        old_valid = le64_to_cpu(attr_b->nres.valid_size);
        old_size = le64_to_cpu(attr_b->nres.data_size);
@@ -465,9 +458,6 @@ again_1:
        new_alloc = (new_size + align - 1) & ~(u64)(align - 1);
        new_alen = new_alloc >> cluster_bits;
 
-       if (keep_prealloc && is_ext)
-               keep_prealloc = false;
-
        if (keep_prealloc && new_size < old_size) {
                attr_b->nres.data_size = cpu_to_le64(new_size);
                mi_b->dirty = true;
@@ -529,7 +519,7 @@ add_alloc_in_same_attr_seg:
                } else if (pre_alloc == -1) {
                        pre_alloc = 0;
                        if (type == ATTR_DATA && !name_len &&
-                           sbi->options.prealloc) {
+                           sbi->options->prealloc) {
                                CLST new_alen2 = bytes_to_cluster(
                                        sbi, get_pre_allocated(new_size));
                                pre_alloc = new_alen2 - new_alen;
@@ -1966,7 +1956,7 @@ int attr_punch_hole(struct ntfs_inode *ni, u64 vbo, u64 bytes, u32 *frame_size)
                        return 0;
 
                from = vbo;
-               to = (vbo + bytes) < data_size ? (vbo + bytes) : data_size;
+               to = min_t(u64, vbo + bytes, data_size);
                memset(Add2Ptr(resident_data(attr_b), from), 0, to - from);
                return 0;
        }
index fa32399..bad6d8a 100644 (file)
@@ -5,10 +5,7 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
 
 #include "debug.h"
 #include "ntfs.h"
@@ -336,7 +333,7 @@ int al_add_le(struct ntfs_inode *ni, enum ATTR_TYPE type, const __le16 *name,
 
        if (attr && attr->non_res) {
                err = ntfs_sb_write_run(ni->mi.sbi, &al->run, 0, al->le,
-                                       al->size);
+                                       al->size, 0);
                if (err)
                        return err;
                al->dirty = false;
@@ -423,7 +420,7 @@ next:
        return true;
 }
 
-int al_update(struct ntfs_inode *ni)
+int al_update(struct ntfs_inode *ni, int sync)
 {
        int err;
        struct ATTRIB *attr;
@@ -445,7 +442,7 @@ int al_update(struct ntfs_inode *ni)
                memcpy(resident_data(attr), al->le, al->size);
        } else {
                err = ntfs_sb_write_run(ni->mi.sbi, &al->run, 0, al->le,
-                                       al->size);
+                                       al->size, sync);
                if (err)
                        goto out;
 
index ce304d4..50d8380 100644 (file)
@@ -5,13 +5,8 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
-#include <linux/fs.h>
-#include <linux/nls.h>
+#include <linux/types.h>
 
-#include "debug.h"
-#include "ntfs.h"
 #include "ntfs_fs.h"
 
 #define BITS_IN_SIZE_T (sizeof(size_t) * 8)
@@ -124,8 +119,7 @@ bool are_bits_set(const ulong *lmap, size_t bit, size_t nbits)
 
        pos = nbits & 7;
        if (pos) {
-               u8 mask = fill_mask[pos];
-
+               mask = fill_mask[pos];
                if ((*map & mask) != mask)
                        return false;
        }
index 8315015..aa18440 100644 (file)
  *
  */
 
-#include <linux/blkdev.h>
 #include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
+#include <linux/kernel.h>
 
-#include "debug.h"
 #include "ntfs.h"
 #include "ntfs_fs.h"
 
@@ -435,7 +433,7 @@ static void wnd_remove_free_ext(struct wnd_bitmap *wnd, size_t bit, size_t len)
                ;
        } else {
                n3 = rb_next(&e->count.node);
-               max_new_len = len > new_len ? len : new_len;
+               max_new_len = max(len, new_len);
                if (!n3) {
                        wnd->extent_max = max_new_len;
                } else {
@@ -731,7 +729,7 @@ int wnd_set_free(struct wnd_bitmap *wnd, size_t bit, size_t bits)
                        wbits = wnd->bits_last;
 
                tail = wbits - wbit;
-               op = tail < bits ? tail : bits;
+               op = min_t(u32, tail, bits);
 
                bh = wnd_map(wnd, iw);
                if (IS_ERR(bh)) {
@@ -784,7 +782,7 @@ int wnd_set_used(struct wnd_bitmap *wnd, size_t bit, size_t bits)
                        wbits = wnd->bits_last;
 
                tail = wbits - wbit;
-               op = tail < bits ? tail : bits;
+               op = min_t(u32, tail, bits);
 
                bh = wnd_map(wnd, iw);
                if (IS_ERR(bh)) {
@@ -834,7 +832,7 @@ static bool wnd_is_free_hlp(struct wnd_bitmap *wnd, size_t bit, size_t bits)
                        wbits = wnd->bits_last;
 
                tail = wbits - wbit;
-               op = tail < bits ? tail : bits;
+               op = min_t(u32, tail, bits);
 
                if (wbits != wnd->free_bits[iw]) {
                        bool ret;
@@ -926,7 +924,7 @@ use_wnd:
                        wbits = wnd->bits_last;
 
                tail = wbits - wbit;
-               op = tail < bits ? tail : bits;
+               op = min_t(u32, tail, bits);
 
                if (wnd->free_bits[iw]) {
                        bool ret;
index 3112056..53ef748 100644 (file)
@@ -11,6 +11,9 @@
 #ifndef _LINUX_NTFS3_DEBUG_H
 #define _LINUX_NTFS3_DEBUG_H
 
+struct super_block;
+struct inode;
+
 #ifndef Add2Ptr
 #define Add2Ptr(P, I)          ((void *)((u8 *)(P) + (I)))
 #define PtrOffset(B, O)                ((size_t)((size_t)(O) - (size_t)(B)))
index 93f6d48..fb438d6 100644 (file)
@@ -7,10 +7,7 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/iversion.h>
 #include <linux/nls.h>
 
 #include "debug.h"
 #include "ntfs_fs.h"
 
 /* Convert little endian UTF-16 to NLS string. */
-int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const struct le_str *uni,
+int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const __le16 *name, u32 len,
                      u8 *buf, int buf_len)
 {
-       int ret, uni_len, warn;
-       const __le16 *ip;
+       int ret, warn;
        u8 *op;
-       struct nls_table *nls = sbi->options.nls;
+       struct nls_table *nls = sbi->options->nls;
 
        static_assert(sizeof(wchar_t) == sizeof(__le16));
 
        if (!nls) {
                /* UTF-16 -> UTF-8 */
-               ret = utf16s_to_utf8s((wchar_t *)uni->name, uni->len,
-                                     UTF16_LITTLE_ENDIAN, buf, buf_len);
+               ret = utf16s_to_utf8s(name, len, UTF16_LITTLE_ENDIAN, buf,
+                                     buf_len);
                buf[ret] = '\0';
                return ret;
        }
 
-       ip = uni->name;
        op = buf;
-       uni_len = uni->len;
        warn = 0;
 
-       while (uni_len--) {
+       while (len--) {
                u16 ec;
                int charlen;
                char dump[5];
@@ -52,7 +46,7 @@ int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const struct le_str *uni,
                        break;
                }
 
-               ec = le16_to_cpu(*ip++);
+               ec = le16_to_cpu(*name++);
                charlen = nls->uni2char(ec, op, buf_len);
 
                if (charlen > 0) {
@@ -186,7 +180,7 @@ int ntfs_nls_to_utf16(struct ntfs_sb_info *sbi, const u8 *name, u32 name_len,
 {
        int ret, slen;
        const u8 *end;
-       struct nls_table *nls = sbi->options.nls;
+       struct nls_table *nls = sbi->options->nls;
        u16 *uname = uni->name;
 
        static_assert(sizeof(wchar_t) == sizeof(u16));
@@ -301,14 +295,14 @@ static inline int ntfs_filldir(struct ntfs_sb_info *sbi, struct ntfs_inode *ni,
                return 0;
 
        /* Skip meta files. Unless option to show metafiles is set. */
-       if (!sbi->options.showmeta && ntfs_is_meta_file(sbi, ino))
+       if (!sbi->options->showmeta && ntfs_is_meta_file(sbi, ino))
                return 0;
 
-       if (sbi->options.nohidden && (fname->dup.fa & FILE_ATTRIBUTE_HIDDEN))
+       if (sbi->options->nohidden && (fname->dup.fa & FILE_ATTRIBUTE_HIDDEN))
                return 0;
 
-       name_len = ntfs_utf16_to_nls(sbi, (struct le_str *)&fname->name_len,
-                                    name, PATH_MAX);
+       name_len = ntfs_utf16_to_nls(sbi, fname->name, fname->name_len, name,
+                                    PATH_MAX);
        if (name_len <= 0) {
                ntfs_warn(sbi->sb, "failed to convert name for inode %lx.",
                          ino);
index 424450e..43b1451 100644 (file)
@@ -12,7 +12,6 @@
 #include <linux/compat.h>
 #include <linux/falloc.h>
 #include <linux/fiemap.h>
-#include <linux/nls.h>
 
 #include "debug.h"
 #include "ntfs.h"
@@ -588,8 +587,11 @@ static long ntfs_fallocate(struct file *file, int mode, loff_t vbo, loff_t len)
                truncate_pagecache(inode, vbo_down);
 
                if (!is_sparsed(ni) && !is_compressed(ni)) {
-                       /* Normal file. */
-                       err = ntfs_zero_range(inode, vbo, end);
+                       /*
+                        * Normal file, can't make hole.
+                        * TODO: Try to find way to save info about hole.
+                        */
+                       err = -EOPNOTSUPP;
                        goto out;
                }
 
@@ -737,7 +739,7 @@ int ntfs3_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
        umode_t mode = inode->i_mode;
        int err;
 
-       if (sbi->options.no_acs_rules) {
+       if (sbi->options->noacsrules) {
                /* "No access rules" - Force any changes of time etc. */
                attr->ia_valid |= ATTR_FORCE;
                /* and disable for editing some attributes. */
@@ -1185,7 +1187,7 @@ static int ntfs_file_release(struct inode *inode, struct file *file)
        int err = 0;
 
        /* If we are last writer on the inode, drop the block reservation. */
-       if (sbi->options.prealloc && ((file->f_mode & FMODE_WRITE) &&
+       if (sbi->options->prealloc && ((file->f_mode & FMODE_WRITE) &&
                                      atomic_read(&inode->i_writecount) == 1)) {
                ni_lock(ni);
                down_write(&ni->file.run_lock);
index 938b12d..6f47a9c 100644 (file)
@@ -5,11 +5,8 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fiemap.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
 #include <linux/vmalloc.h>
 
 #include "debug.h"
@@ -708,18 +705,35 @@ static int ni_try_remove_attr_list(struct ntfs_inode *ni)
                        continue;
 
                mi = ni_find_mi(ni, ino_get(&le->ref));
+               if (!mi) {
+                       /* Should never happened, 'cause already checked. */
+                       goto bad;
+               }
 
                attr = mi_find_attr(mi, NULL, le->type, le_name(le),
                                    le->name_len, &le->id);
+               if (!attr) {
+                       /* Should never happened, 'cause already checked. */
+                       goto bad;
+               }
                asize = le32_to_cpu(attr->size);
 
                /* Insert into primary record. */
                attr_ins = mi_insert_attr(&ni->mi, le->type, le_name(le),
                                          le->name_len, asize,
                                          le16_to_cpu(attr->name_off));
-               id = attr_ins->id;
+               if (!attr_ins) {
+                       /*
+                        * Internal error.
+                        * Either no space in primary record (already checked).
+                        * Either tried to insert another
+                        * non indexed attribute (logic error).
+                        */
+                       goto bad;
+               }
 
                /* Copy all except id. */
+               id = attr_ins->id;
                memcpy(attr_ins, attr, asize);
                attr_ins->id = id;
 
@@ -735,6 +749,10 @@ static int ni_try_remove_attr_list(struct ntfs_inode *ni)
        ni->attr_list.dirty = false;
 
        return 0;
+bad:
+       ntfs_inode_err(&ni->vfs_inode, "Internal error");
+       make_bad_inode(&ni->vfs_inode);
+       return -EINVAL;
 }
 
 /*
@@ -956,6 +974,13 @@ static int ni_ins_attr_ext(struct ntfs_inode *ni, struct ATTR_LIST_ENTRY *le,
                        continue;
                }
 
+               /*
+                * Do not try to insert this attribute
+                * if there is no room in record.
+                */
+               if (le32_to_cpu(mi->mrec->used) + asize > sbi->record_size)
+                       continue;
+
                /* Try to insert attribute into this subrecord. */
                attr = ni_ins_new_attr(ni, mi, le, type, name, name_len, asize,
                                       name_off, svcn, ins_le);
@@ -1451,7 +1476,7 @@ int ni_insert_resident(struct ntfs_inode *ni, u32 data_size,
                attr->res.flags = RESIDENT_FLAG_INDEXED;
 
                /* is_attr_indexed(attr)) == true */
-               le16_add_cpu(&ni->mi.mrec->hard_links, +1);
+               le16_add_cpu(&ni->mi.mrec->hard_links, 1);
                ni->mi.dirty = true;
        }
        attr->res.res = 0;
@@ -1606,7 +1631,7 @@ struct ATTR_FILE_NAME *ni_fname_type(struct ntfs_inode *ni, u8 name_type,
 
        *le = NULL;
 
-       if (FILE_NAME_POSIX == name_type)
+       if (name_type == FILE_NAME_POSIX)
                return NULL;
 
        /* Enumerate all names. */
@@ -1706,18 +1731,16 @@ out:
 /*
  * ni_parse_reparse
  *
- * Buffer is at least 24 bytes.
+ * buffer - memory for reparse buffer header
  */
 enum REPARSE_SIGN ni_parse_reparse(struct ntfs_inode *ni, struct ATTRIB *attr,
-                                  void *buffer)
+                                  struct REPARSE_DATA_BUFFER *buffer)
 {
        const struct REPARSE_DATA_BUFFER *rp = NULL;
        u8 bits;
        u16 len;
        typeof(rp->CompressReparseBuffer) *cmpr;
 
-       static_assert(sizeof(struct REPARSE_DATA_BUFFER) <= 24);
-
        /* Try to estimate reparse point. */
        if (!attr->non_res) {
                rp = resident_data_ex(attr, sizeof(struct REPARSE_DATA_BUFFER));
@@ -1803,6 +1826,9 @@ enum REPARSE_SIGN ni_parse_reparse(struct ntfs_inode *ni, struct ATTRIB *attr,
                return REPARSE_NONE;
        }
 
+       if (buffer != rp)
+               memcpy(buffer, rp, sizeof(struct REPARSE_DATA_BUFFER));
+
        /* Looks like normal symlink. */
        return REPARSE_LINK;
 }
@@ -2906,9 +2932,8 @@ bool ni_remove_name_undo(struct ntfs_inode *dir_ni, struct ntfs_inode *ni,
                memcpy(Add2Ptr(attr, SIZEOF_RESIDENT), de + 1, de_key_size);
                mi_get_ref(&ni->mi, &de->ref);
 
-               if (indx_insert_entry(&dir_ni->dir, dir_ni, de, sbi, NULL, 1)) {
+               if (indx_insert_entry(&dir_ni->dir, dir_ni, de, sbi, NULL, 1))
                        return false;
-               }
        }
 
        return true;
@@ -3077,7 +3102,9 @@ static bool ni_update_parent(struct ntfs_inode *ni, struct NTFS_DUP_INFO *dup,
                        const struct EA_INFO *info;
 
                        info = resident_data_ex(attr, sizeof(struct EA_INFO));
-                       dup->ea_size = info->size_pack;
+                       /* If ATTR_EA_INFO exists 'info' can't be NULL. */
+                       if (info)
+                               dup->ea_size = info->size_pack;
                }
        }
 
@@ -3205,7 +3232,7 @@ int ni_write_inode(struct inode *inode, int sync, const char *hint)
                                        goto out;
                        }
 
-                       err = al_update(ni);
+                       err = al_update(ni, sync);
                        if (err)
                                goto out;
                }
index b5853ae..06492f0 100644 (file)
@@ -6,12 +6,8 @@
  */
 
 #include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/hash.h>
-#include <linux/nls.h>
 #include <linux/random.h>
-#include <linux/ratelimit.h>
 #include <linux/slab.h>
 
 #include "debug.h"
@@ -2219,7 +2215,7 @@ file_is_valid:
 
                        err = ntfs_sb_write_run(log->ni->mi.sbi,
                                                &log->ni->file.run, off, page,
-                                               log->page_size);
+                                               log->page_size, 0);
 
                        if (err)
                                goto out;
@@ -3710,7 +3706,7 @@ move_data:
 
        if (a_dirty) {
                attr = oa->attr;
-               err = ntfs_sb_write_run(sbi, oa->run1, vbo, buffer_le, bytes);
+               err = ntfs_sb_write_run(sbi, oa->run1, vbo, buffer_le, bytes, 0);
                if (err)
                        goto out;
        }
@@ -5152,10 +5148,10 @@ end_reply:
 
        ntfs_fix_pre_write(&rh->rhdr, log->page_size);
 
-       err = ntfs_sb_write_run(sbi, &ni->file.run, 0, rh, log->page_size);
+       err = ntfs_sb_write_run(sbi, &ni->file.run, 0, rh, log->page_size, 0);
        if (!err)
                err = ntfs_sb_write_run(sbi, &log->ni->file.run, log->page_size,
-                                       rh, log->page_size);
+                                       rh, log->page_size, 0);
 
        kfree(rh);
        if (err)
index 91e3743..4de9acb 100644 (file)
@@ -8,7 +8,7 @@
 #include <linux/blkdev.h>
 #include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
+#include <linux/kernel.h>
 
 #include "debug.h"
 #include "ntfs.h"
@@ -358,7 +358,7 @@ int ntfs_look_for_free_space(struct ntfs_sb_info *sbi, CLST lcn, CLST len,
                             enum ALLOCATE_OPT opt)
 {
        int err;
-       CLST alen = 0;
+       CLST alen;
        struct super_block *sb = sbi->sb;
        size_t alcn, zlen, zeroes, zlcn, zlen2, ztrim, new_zlen;
        struct wnd_bitmap *wnd = &sbi->used.bitmap;
@@ -370,27 +370,28 @@ int ntfs_look_for_free_space(struct ntfs_sb_info *sbi, CLST lcn, CLST len,
                if (!zlen) {
                        err = ntfs_refresh_zone(sbi);
                        if (err)
-                               goto out;
+                               goto up_write;
+
                        zlen = wnd_zone_len(wnd);
                }
 
                if (!zlen) {
                        ntfs_err(sbi->sb, "no free space to extend mft");
-                       goto out;
+                       err = -ENOSPC;
+                       goto up_write;
                }
 
                lcn = wnd_zone_bit(wnd);
-               alen = zlen > len ? len : zlen;
+               alen = min_t(CLST, len, zlen);
 
                wnd_zone_set(wnd, lcn + alen, zlen - alen);
 
                err = wnd_set_used(wnd, lcn, alen);
-               if (err) {
-                       up_write(&wnd->rw_lock);
-                       return err;
-               }
+               if (err)
+                       goto up_write;
+
                alcn = lcn;
-               goto out;
+               goto space_found;
        }
        /*
         * 'Cause cluster 0 is always used this value means that we should use
@@ -404,49 +405,45 @@ int ntfs_look_for_free_space(struct ntfs_sb_info *sbi, CLST lcn, CLST len,
 
        alen = wnd_find(wnd, len, lcn, BITMAP_FIND_MARK_AS_USED, &alcn);
        if (alen)
-               goto out;
+               goto space_found;
 
        /* Try to use clusters from MftZone. */
        zlen = wnd_zone_len(wnd);
        zeroes = wnd_zeroes(wnd);
 
        /* Check too big request */
-       if (len > zeroes + zlen || zlen <= NTFS_MIN_MFT_ZONE)
-               goto out;
+       if (len > zeroes + zlen || zlen <= NTFS_MIN_MFT_ZONE) {
+               err = -ENOSPC;
+               goto up_write;
+       }
 
        /* How many clusters to cat from zone. */
        zlcn = wnd_zone_bit(wnd);
        zlen2 = zlen >> 1;
-       ztrim = len > zlen ? zlen : (len > zlen2 ? len : zlen2);
-       new_zlen = zlen - ztrim;
-
-       if (new_zlen < NTFS_MIN_MFT_ZONE) {
-               new_zlen = NTFS_MIN_MFT_ZONE;
-               if (new_zlen > zlen)
-                       new_zlen = zlen;
-       }
+       ztrim = clamp_val(len, zlen2, zlen);
+       new_zlen = max_t(size_t, zlen - ztrim, NTFS_MIN_MFT_ZONE);
 
        wnd_zone_set(wnd, zlcn, new_zlen);
 
        /* Allocate continues clusters. */
        alen = wnd_find(wnd, len, 0,
                        BITMAP_FIND_MARK_AS_USED | BITMAP_FIND_FULL, &alcn);
-
-out:
-       if (alen) {
-               err = 0;
-               *new_len = alen;
-               *new_lcn = alcn;
-
-               ntfs_unmap_meta(sb, alcn, alen);
-
-               /* Set hint for next requests. */
-               if (!(opt & ALLOCATE_MFT))
-                       sbi->used.next_free_lcn = alcn + alen;
-       } else {
+       if (!alen) {
                err = -ENOSPC;
+               goto up_write;
        }
 
+space_found:
+       err = 0;
+       *new_len = alen;
+       *new_lcn = alcn;
+
+       ntfs_unmap_meta(sb, alcn, alen);
+
+       /* Set hint for next requests. */
+       if (!(opt & ALLOCATE_MFT))
+               sbi->used.next_free_lcn = alcn + alen;
+up_write:
        up_write(&wnd->rw_lock);
        return err;
 }
@@ -1080,7 +1077,7 @@ int ntfs_sb_write(struct super_block *sb, u64 lbo, size_t bytes,
 }
 
 int ntfs_sb_write_run(struct ntfs_sb_info *sbi, const struct runs_tree *run,
-                     u64 vbo, const void *buf, size_t bytes)
+                     u64 vbo, const void *buf, size_t bytes, int sync)
 {
        struct super_block *sb = sbi->sb;
        u8 cluster_bits = sbi->cluster_bits;
@@ -1099,8 +1096,8 @@ int ntfs_sb_write_run(struct ntfs_sb_info *sbi, const struct runs_tree *run,
        len = ((u64)clen << cluster_bits) - off;
 
        for (;;) {
-               u32 op = len < bytes ? len : bytes;
-               int err = ntfs_sb_write(sb, lbo, op, buf, 0);
+               u32 op = min_t(u64, len, bytes);
+               int err = ntfs_sb_write(sb, lbo, op, buf, sync);
 
                if (err)
                        return err;
@@ -1300,7 +1297,7 @@ int ntfs_get_bh(struct ntfs_sb_info *sbi, const struct runs_tree *run, u64 vbo,
        nb->off = off = lbo & (blocksize - 1);
 
        for (;;) {
-               u32 len32 = len < bytes ? len : bytes;
+               u32 len32 = min_t(u64, len, bytes);
                sector_t block = lbo >> sb->s_blocksize_bits;
 
                do {
@@ -2175,7 +2172,7 @@ int ntfs_insert_security(struct ntfs_sb_info *sbi,
 
        /* Write main SDS bucket. */
        err = ntfs_sb_write_run(sbi, &ni->file.run, sbi->security.next_off,
-                               d_security, aligned_sec_size);
+                               d_security, aligned_sec_size, 0);
 
        if (err)
                goto out;
@@ -2193,7 +2190,7 @@ int ntfs_insert_security(struct ntfs_sb_info *sbi,
 
        /* Write copy SDS bucket. */
        err = ntfs_sb_write_run(sbi, &ni->file.run, mirr_off, d_security,
-                               aligned_sec_size);
+                               aligned_sec_size, 0);
        if (err)
                goto out;
 
index 0daca9a..6f81e3a 100644 (file)
@@ -8,7 +8,7 @@
 #include <linux/blkdev.h>
 #include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
+#include <linux/kernel.h>
 
 #include "debug.h"
 #include "ntfs.h"
@@ -671,138 +671,74 @@ static struct NTFS_DE *hdr_find_e(const struct ntfs_index *indx,
                                  const struct INDEX_HDR *hdr, const void *key,
                                  size_t key_len, const void *ctx, int *diff)
 {
-       struct NTFS_DE *e;
+       struct NTFS_DE *e, *found = NULL;
        NTFS_CMP_FUNC cmp = indx->cmp;
+       int min_idx = 0, mid_idx, max_idx = 0;
+       int diff2;
+       int table_size = 8;
        u32 e_size, e_key_len;
        u32 end = le32_to_cpu(hdr->used);
        u32 off = le32_to_cpu(hdr->de_off);
+       u16 offs[128];
 
-#ifdef NTFS3_INDEX_BINARY_SEARCH
-       int max_idx = 0, fnd, min_idx;
-       int nslots = 64;
-       u16 *offs;
-
-       if (end > 0x10000)
-               goto next;
-
-       offs = kmalloc(sizeof(u16) * nslots, GFP_NOFS);
-       if (!offs)
-               goto next;
+fill_table:
+       if (off + sizeof(struct NTFS_DE) > end)
+               return NULL;
 
-       /* Use binary search algorithm. */
-next1:
-       if (off + sizeof(struct NTFS_DE) > end) {
-               e = NULL;
-               goto out1;
-       }
        e = Add2Ptr(hdr, off);
        e_size = le16_to_cpu(e->size);
 
-       if (e_size < sizeof(struct NTFS_DE) || off + e_size > end) {
-               e = NULL;
-               goto out1;
-       }
-
-       if (max_idx >= nslots) {
-               u16 *ptr;
-               int new_slots = ALIGN(2 * nslots, 8);
-
-               ptr = kmalloc(sizeof(u16) * new_slots, GFP_NOFS);
-               if (ptr)
-                       memcpy(ptr, offs, sizeof(u16) * max_idx);
-               kfree(offs);
-               offs = ptr;
-               nslots = new_slots;
-               if (!ptr)
-                       goto next;
-       }
-
-       /* Store entry table. */
-       offs[max_idx] = off;
+       if (e_size < sizeof(struct NTFS_DE) || off + e_size > end)
+               return NULL;
 
        if (!de_is_last(e)) {
+               offs[max_idx] = off;
                off += e_size;
-               max_idx += 1;
-               goto next1;
-       }
 
-       /*
-        * Table of pointers is created.
-        * Use binary search to find entry that is <= to the search value.
-        */
-       fnd = -1;
-       min_idx = 0;
+               max_idx++;
+               if (max_idx < table_size)
+                       goto fill_table;
 
-       while (min_idx <= max_idx) {
-               int mid_idx = min_idx + ((max_idx - min_idx) >> 1);
-               int diff2;
-
-               e = Add2Ptr(hdr, offs[mid_idx]);
+               max_idx--;
+       }
 
-               e_key_len = le16_to_cpu(e->key_size);
+binary_search:
+       e_key_len = le16_to_cpu(e->key_size);
 
-               diff2 = (*cmp)(key, key_len, e + 1, e_key_len, ctx);
+       diff2 = (*cmp)(key, key_len, e + 1, e_key_len, ctx);
+       if (diff2 > 0) {
+               if (found) {
+                       min_idx = mid_idx + 1;
+               } else {
+                       if (de_is_last(e))
+                               return NULL;
 
-               if (!diff2) {
-                       *diff = 0;
-                       goto out1;
+                       max_idx = 0;
+                       table_size = min(table_size * 2,
+                                        (int)ARRAY_SIZE(offs));
+                       goto fill_table;
                }
-
-               if (diff2 < 0) {
+       } else if (diff2 < 0) {
+               if (found)
                        max_idx = mid_idx - 1;
-                       fnd = mid_idx;
-                       if (!fnd)
-                               break;
-               } else {
-                       min_idx = mid_idx + 1;
-               }
-       }
+               else
+                       max_idx--;
 
-       if (fnd == -1) {
-               e = NULL;
-               goto out1;
+               found = e;
+       } else {
+               *diff = 0;
+               return e;
        }
 
-       *diff = -1;
-       e = Add2Ptr(hdr, offs[fnd]);
-
-out1:
-       kfree(offs);
-
-       return e;
-#endif
-
-next:
-       /*
-        * Entries index are sorted.
-        * Enumerate all entries until we find entry
-        * that is <= to the search value.
-        */
-       if (off + sizeof(struct NTFS_DE) > end)
-               return NULL;
-
-       e = Add2Ptr(hdr, off);
-       e_size = le16_to_cpu(e->size);
-
-       if (e_size < sizeof(struct NTFS_DE) || off + e_size > end)
-               return NULL;
-
-       off += e_size;
-
-       e_key_len = le16_to_cpu(e->key_size);
-
-       *diff = (*cmp)(key, key_len, e + 1, e_key_len, ctx);
-       if (!*diff)
-               return e;
+       if (min_idx > max_idx) {
+               *diff = -1;
+               return found;
+       }
 
-       if (*diff <= 0)
-               return e;
+       mid_idx = (min_idx + max_idx) >> 1;
+       e = Add2Ptr(hdr, offs[mid_idx]);
 
-       if (de_is_last(e)) {
-               *diff = 1;
-               return e;
-       }
-       goto next;
+       goto binary_search;
 }
 
 /*
@@ -1136,9 +1072,7 @@ int indx_find(struct ntfs_index *indx, struct ntfs_inode *ni,
        if (!e)
                return -EINVAL;
 
-       if (fnd)
-               fnd->root_de = e;
-
+       fnd->root_de = e;
        err = 0;
 
        for (;;) {
@@ -1401,7 +1335,7 @@ ok:
 static int indx_create_allocate(struct ntfs_index *indx, struct ntfs_inode *ni,
                                CLST *vbn)
 {
-       int err = -ENOMEM;
+       int err;
        struct ntfs_sb_info *sbi = ni->mi.sbi;
        struct ATTRIB *bitmap;
        struct ATTRIB *alloc;
index db2a5a4..859951d 100644 (file)
@@ -5,10 +5,8 @@
  *
  */
 
-#include <linux/blkdev.h>
 #include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/iversion.h>
 #include <linux/mpage.h>
 #include <linux/namei.h>
 #include <linux/nls.h>
@@ -49,8 +47,8 @@ static struct inode *ntfs_read_mft(struct inode *inode,
 
        inode->i_op = NULL;
        /* Setup 'uid' and 'gid' */
-       inode->i_uid = sbi->options.fs_uid;
-       inode->i_gid = sbi->options.fs_gid;
+       inode->i_uid = sbi->options->fs_uid;
+       inode->i_gid = sbi->options->fs_gid;
 
        err = mi_init(&ni->mi, sbi, ino);
        if (err)
@@ -224,12 +222,9 @@ next_attr:
                if (!attr->non_res) {
                        ni->i_valid = inode->i_size = rsize;
                        inode_set_bytes(inode, rsize);
-                       t32 = asize;
-               } else {
-                       t32 = le16_to_cpu(attr->nres.run_off);
                }
 
-               mode = S_IFREG | (0777 & sbi->options.fs_fmask_inv);
+               mode = S_IFREG | (0777 & sbi->options->fs_fmask_inv);
 
                if (!attr->non_res) {
                        ni->ni_flags |= NI_FLAG_RESIDENT;
@@ -272,7 +267,7 @@ next_attr:
                        goto out;
 
                mode = sb->s_root
-                              ? (S_IFDIR | (0777 & sbi->options.fs_dmask_inv))
+                              ? (S_IFDIR | (0777 & sbi->options->fs_dmask_inv))
                               : (S_IFDIR | 0777);
                goto next_attr;
 
@@ -315,17 +310,14 @@ next_attr:
                rp_fa = ni_parse_reparse(ni, attr, &rp);
                switch (rp_fa) {
                case REPARSE_LINK:
-                       if (!attr->non_res) {
-                               inode->i_size = rsize;
-                               inode_set_bytes(inode, rsize);
-                               t32 = asize;
-                       } else {
-                               inode->i_size =
-                                       le64_to_cpu(attr->nres.data_size);
-                               t32 = le16_to_cpu(attr->nres.run_off);
-                       }
+                       /*
+                        * Normal symlink.
+                        * Assume one unicode symbol == one utf8.
+                        */
+                       inode->i_size = le16_to_cpu(rp.SymbolicLinkReparseBuffer
+                                                           .PrintNameLength) /
+                                       sizeof(u16);
 
-                       /* Looks like normal symlink. */
                        ni->i_valid = inode->i_size;
 
                        /* Clear directory bit. */
@@ -422,7 +414,7 @@ end_enum:
                ni->std_fa &= ~FILE_ATTRIBUTE_DIRECTORY;
                inode->i_op = &ntfs_link_inode_operations;
                inode->i_fop = NULL;
-               inode_nohighmem(inode); // ??
+               inode_nohighmem(inode);
        } else if (S_ISREG(mode)) {
                ni->std_fa &= ~FILE_ATTRIBUTE_DIRECTORY;
                inode->i_op = &ntfs_file_inode_operations;
@@ -443,7 +435,7 @@ end_enum:
                goto out;
        }
 
-       if ((sbi->options.sys_immutable &&
+       if ((sbi->options->sys_immutable &&
             (std5->fa & FILE_ATTRIBUTE_SYSTEM)) &&
            !S_ISFIFO(mode) && !S_ISSOCK(mode) && !S_ISLNK(mode)) {
                inode->i_flags |= S_IMMUTABLE;
@@ -1200,9 +1192,13 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
        struct REPARSE_DATA_BUFFER *rp = NULL;
        bool rp_inserted = false;
 
+       ni_lock_dir(dir_ni);
+
        dir_root = indx_get_root(&dir_ni->dir, dir_ni, NULL, NULL);
-       if (!dir_root)
-               return ERR_PTR(-EINVAL);
+       if (!dir_root) {
+               err = -EINVAL;
+               goto out1;
+       }
 
        if (S_ISDIR(mode)) {
                /* Use parent's directory attributes. */
@@ -1244,7 +1240,7 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
                 *      }
                 */
        } else if (S_ISREG(mode)) {
-               if (sbi->options.sparse) {
+               if (sbi->options->sparse) {
                        /* Sparsed regular file, cause option 'sparse'. */
                        fa = FILE_ATTRIBUTE_SPARSE_FILE |
                             FILE_ATTRIBUTE_ARCHIVE;
@@ -1486,7 +1482,10 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
                asize = ALIGN(SIZEOF_RESIDENT + nsize, 8);
                t16 = PtrOffset(rec, attr);
 
-               /* 0x78 - the size of EA + EAINFO to store WSL */
+               /*
+                * Below function 'ntfs_save_wsl_perm' requires 0x78 bytes.
+                * It is good idea to keep extened attributes resident.
+                */
                if (asize + t16 + 0x78 + 8 > sbi->record_size) {
                        CLST alen;
                        CLST clst = bytes_to_cluster(sbi, nsize);
@@ -1521,14 +1520,14 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
                        }
 
                        asize = SIZEOF_NONRESIDENT + ALIGN(err, 8);
-                       inode->i_size = nsize;
                } else {
                        attr->res.data_off = SIZEOF_RESIDENT_LE;
                        attr->res.data_size = cpu_to_le32(nsize);
                        memcpy(Add2Ptr(attr, SIZEOF_RESIDENT), rp, nsize);
-                       inode->i_size = nsize;
                        nsize = 0;
                }
+               /* Size of symlink equals the length of input string. */
+               inode->i_size = size;
 
                attr->size = cpu_to_le32(asize);
 
@@ -1551,6 +1550,9 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
        if (err)
                goto out6;
 
+       /* Unlock parent directory before ntfs_init_acl. */
+       ni_unlock(dir_ni);
+
        inode->i_generation = le16_to_cpu(rec->seq);
 
        dir->i_mtime = dir->i_ctime = inode->i_atime;
@@ -1562,6 +1564,8 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
                inode->i_op = &ntfs_link_inode_operations;
                inode->i_fop = NULL;
                inode->i_mapping->a_ops = &ntfs_aops;
+               inode->i_size = size;
+               inode_nohighmem(inode);
        } else if (S_ISREG(mode)) {
                inode->i_op = &ntfs_file_inode_operations;
                inode->i_fop = &ntfs_file_operations;
@@ -1577,7 +1581,7 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
        if (!S_ISLNK(mode) && (sb->s_flags & SB_POSIXACL)) {
                err = ntfs_init_acl(mnt_userns, inode, dir);
                if (err)
-                       goto out6;
+                       goto out7;
        } else
 #endif
        {
@@ -1586,7 +1590,7 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
 
        /* Write non resident data. */
        if (nsize) {
-               err = ntfs_sb_write_run(sbi, &ni->file.run, 0, rp, nsize);
+               err = ntfs_sb_write_run(sbi, &ni->file.run, 0, rp, nsize, 0);
                if (err)
                        goto out7;
        }
@@ -1607,8 +1611,10 @@ struct inode *ntfs_create_inode(struct user_namespace *mnt_userns,
 out7:
 
        /* Undo 'indx_insert_entry'. */
+       ni_lock_dir(dir_ni);
        indx_delete_entry(&dir_ni->dir, dir_ni, new_de + 1,
                          le16_to_cpu(new_de->key_size), sbi);
+       /* ni_unlock(dir_ni); will be called later. */
 out6:
        if (rp_inserted)
                ntfs_remove_reparse(sbi, IO_REPARSE_TAG_SYMLINK, &new_de->ref);
@@ -1632,8 +1638,10 @@ out2:
        kfree(rp);
 
 out1:
-       if (err)
+       if (err) {
+               ni_unlock(dir_ni);
                return ERR_PTR(err);
+       }
 
        unlock_new_inode(inode);
 
@@ -1754,15 +1762,15 @@ void ntfs_evict_inode(struct inode *inode)
 static noinline int ntfs_readlink_hlp(struct inode *inode, char *buffer,
                                      int buflen)
 {
-       int i, err = 0;
+       int i, err = -EINVAL;
        struct ntfs_inode *ni = ntfs_i(inode);
        struct super_block *sb = inode->i_sb;
        struct ntfs_sb_info *sbi = sb->s_fs_info;
-       u64 i_size = inode->i_size;
-       u16 nlen = 0;
+       u64 size;
+       u16 ulen = 0;
        void *to_free = NULL;
        struct REPARSE_DATA_BUFFER *rp;
-       struct le_str *uni;
+       const __le16 *uname;
        struct ATTRIB *attr;
 
        /* Reparse data present. Try to parse it. */
@@ -1771,68 +1779,64 @@ static noinline int ntfs_readlink_hlp(struct inode *inode, char *buffer,
 
        *buffer = 0;
 
-       /* Read into temporal buffer. */
-       if (i_size > sbi->reparse.max_size || i_size <= sizeof(u32)) {
-               err = -EINVAL;
-               goto out;
-       }
-
        attr = ni_find_attr(ni, NULL, NULL, ATTR_REPARSE, NULL, 0, NULL, NULL);
-       if (!attr) {
-               err = -EINVAL;
+       if (!attr)
                goto out;
-       }
 
        if (!attr->non_res) {
-               rp = resident_data_ex(attr, i_size);
-               if (!rp) {
-                       err = -EINVAL;
+               rp = resident_data_ex(attr, sizeof(struct REPARSE_DATA_BUFFER));
+               if (!rp)
                        goto out;
-               }
+               size = le32_to_cpu(attr->res.data_size);
        } else {
-               rp = kmalloc(i_size, GFP_NOFS);
+               size = le64_to_cpu(attr->nres.data_size);
+               rp = NULL;
+       }
+
+       if (size > sbi->reparse.max_size || size <= sizeof(u32))
+               goto out;
+
+       if (!rp) {
+               rp = kmalloc(size, GFP_NOFS);
                if (!rp) {
                        err = -ENOMEM;
                        goto out;
                }
                to_free = rp;
-               err = ntfs_read_run_nb(sbi, &ni->file.run, 0, rp, i_size, NULL);
+               /* Read into temporal buffer. */
+               err = ntfs_read_run_nb(sbi, &ni->file.run, 0, rp, size, NULL);
                if (err)
                        goto out;
        }
 
-       err = -EINVAL;
-
        /* Microsoft Tag. */
        switch (rp->ReparseTag) {
        case IO_REPARSE_TAG_MOUNT_POINT:
                /* Mount points and junctions. */
                /* Can we use 'Rp->MountPointReparseBuffer.PrintNameLength'? */
-               if (i_size <= offsetof(struct REPARSE_DATA_BUFFER,
-                                      MountPointReparseBuffer.PathBuffer))
+               if (size <= offsetof(struct REPARSE_DATA_BUFFER,
+                                    MountPointReparseBuffer.PathBuffer))
                        goto out;
-               uni = Add2Ptr(rp,
-                             offsetof(struct REPARSE_DATA_BUFFER,
-                                      MountPointReparseBuffer.PathBuffer) +
-                                     le16_to_cpu(rp->MountPointReparseBuffer
-                                                         .PrintNameOffset) -
-                                     2);
-               nlen = le16_to_cpu(rp->MountPointReparseBuffer.PrintNameLength);
+               uname = Add2Ptr(rp,
+                               offsetof(struct REPARSE_DATA_BUFFER,
+                                        MountPointReparseBuffer.PathBuffer) +
+                                       le16_to_cpu(rp->MountPointReparseBuffer
+                                                           .PrintNameOffset));
+               ulen = le16_to_cpu(rp->MountPointReparseBuffer.PrintNameLength);
                break;
 
        case IO_REPARSE_TAG_SYMLINK:
                /* FolderSymbolicLink */
                /* Can we use 'Rp->SymbolicLinkReparseBuffer.PrintNameLength'? */
-               if (i_size <= offsetof(struct REPARSE_DATA_BUFFER,
-                                      SymbolicLinkReparseBuffer.PathBuffer))
+               if (size <= offsetof(struct REPARSE_DATA_BUFFER,
+                                    SymbolicLinkReparseBuffer.PathBuffer))
                        goto out;
-               uni = Add2Ptr(rp,
-                             offsetof(struct REPARSE_DATA_BUFFER,
-                                      SymbolicLinkReparseBuffer.PathBuffer) +
-                                     le16_to_cpu(rp->SymbolicLinkReparseBuffer
-                                                         .PrintNameOffset) -
-                                     2);
-               nlen = le16_to_cpu(
+               uname = Add2Ptr(
+                       rp, offsetof(struct REPARSE_DATA_BUFFER,
+                                    SymbolicLinkReparseBuffer.PathBuffer) +
+                                   le16_to_cpu(rp->SymbolicLinkReparseBuffer
+                                                       .PrintNameOffset));
+               ulen = le16_to_cpu(
                        rp->SymbolicLinkReparseBuffer.PrintNameLength);
                break;
 
@@ -1864,29 +1868,28 @@ static noinline int ntfs_readlink_hlp(struct inode *inode, char *buffer,
                        goto out;
                }
                if (!IsReparseTagNameSurrogate(rp->ReparseTag) ||
-                   i_size <= sizeof(struct REPARSE_POINT)) {
+                   size <= sizeof(struct REPARSE_POINT)) {
                        goto out;
                }
 
                /* Users tag. */
-               uni = Add2Ptr(rp, sizeof(struct REPARSE_POINT) - 2);
-               nlen = le16_to_cpu(rp->ReparseDataLength) -
+               uname = Add2Ptr(rp, sizeof(struct REPARSE_POINT));
+               ulen = le16_to_cpu(rp->ReparseDataLength) -
                       sizeof(struct REPARSE_POINT);
        }
 
        /* Convert nlen from bytes to UNICODE chars. */
-       nlen >>= 1;
+       ulen >>= 1;
 
        /* Check that name is available. */
-       if (!nlen || &uni->name[nlen] > (__le16 *)Add2Ptr(rp, i_size))
+       if (!ulen || uname + ulen > (__le16 *)Add2Ptr(rp, size))
                goto out;
 
        /* If name is already zero terminated then truncate it now. */
-       if (!uni->name[nlen - 1])
-               nlen -= 1;
-       uni->len = nlen;
+       if (!uname[ulen - 1])
+               ulen -= 1;
 
-       err = ntfs_utf16_to_nls(sbi, uni, buffer, buflen);
+       err = ntfs_utf16_to_nls(sbi, uname, ulen, buffer, buflen);
 
        if (err < 0)
                goto out;
index 2d70ae4..dd7ced0 100644 (file)
@@ -5,6 +5,9 @@
  * Copyright (C) 2015 Eric Biggers
  */
 
+#ifndef _LINUX_NTFS3_LIB_DECOMPRESS_COMMON_H
+#define _LINUX_NTFS3_LIB_DECOMPRESS_COMMON_H
+
 #include <linux/string.h>
 #include <linux/compiler.h>
 #include <linux/types.h>
@@ -336,3 +339,5 @@ static forceinline u8 *lz_copy(u8 *dst, u32 length, u32 offset, const u8 *bufend
 
        return dst;
 }
+
+#endif /* _LINUX_NTFS3_LIB_DECOMPRESS_COMMON_H */
index f508fba..90309a5 100644 (file)
@@ -7,6 +7,10 @@
  * - linux kernel code style
  */
 
+#ifndef _LINUX_NTFS3_LIB_LIB_H
+#define _LINUX_NTFS3_LIB_LIB_H
+
+#include <linux/types.h>
 
 /* globals from xpress_decompress.c */
 struct xpress_decompressor *xpress_allocate_decompressor(void);
@@ -24,3 +28,5 @@ int lzx_decompress(struct lzx_decompressor *__restrict d,
                   const void *__restrict compressed_data,
                   size_t compressed_size, void *__restrict uncompressed_data,
                   size_t uncompressed_size);
+
+#endif /* _LINUX_NTFS3_LIB_LIB_H */
index f1f691a..28f6545 100644 (file)
@@ -5,13 +5,13 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
-#include <linux/fs.h>
-#include <linux/nls.h>
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/stddef.h>
+#include <linux/string.h>
+#include <linux/types.h>
 
 #include "debug.h"
-#include "ntfs.h"
 #include "ntfs_fs.h"
 
 // clang-format off
@@ -292,7 +292,7 @@ next:
 /*
  * get_lznt_ctx
  * @level: 0 - Standard compression.
- *        !0 - Best compression, requires a lot of cpu.
+ *        !0 - Best compression, requires a lot of cpu.
  */
 struct lznt *get_lznt_ctx(int level)
 {
index e58415d..bc74121 100644 (file)
@@ -5,11 +5,7 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/iversion.h>
-#include <linux/namei.h>
 #include <linux/nls.h>
 
 #include "debug.h"
@@ -99,16 +95,11 @@ static struct dentry *ntfs_lookup(struct inode *dir, struct dentry *dentry,
 static int ntfs_create(struct user_namespace *mnt_userns, struct inode *dir,
                       struct dentry *dentry, umode_t mode, bool excl)
 {
-       struct ntfs_inode *ni = ntfs_i(dir);
        struct inode *inode;
 
-       ni_lock_dir(ni);
-
        inode = ntfs_create_inode(mnt_userns, dir, dentry, NULL, S_IFREG | mode,
                                  0, NULL, 0, NULL);
 
-       ni_unlock(ni);
-
        return IS_ERR(inode) ? PTR_ERR(inode) : 0;
 }
 
@@ -120,16 +111,11 @@ static int ntfs_create(struct user_namespace *mnt_userns, struct inode *dir,
 static int ntfs_mknod(struct user_namespace *mnt_userns, struct inode *dir,
                      struct dentry *dentry, umode_t mode, dev_t rdev)
 {
-       struct ntfs_inode *ni = ntfs_i(dir);
        struct inode *inode;
 
-       ni_lock_dir(ni);
-
        inode = ntfs_create_inode(mnt_userns, dir, dentry, NULL, mode, rdev,
                                  NULL, 0, NULL);
 
-       ni_unlock(ni);
-
        return IS_ERR(inode) ? PTR_ERR(inode) : 0;
 }
 
@@ -200,15 +186,10 @@ static int ntfs_symlink(struct user_namespace *mnt_userns, struct inode *dir,
 {
        u32 size = strlen(symname);
        struct inode *inode;
-       struct ntfs_inode *ni = ntfs_i(dir);
-
-       ni_lock_dir(ni);
 
        inode = ntfs_create_inode(mnt_userns, dir, dentry, NULL, S_IFLNK | 0777,
                                  0, symname, size, NULL);
 
-       ni_unlock(ni);
-
        return IS_ERR(inode) ? PTR_ERR(inode) : 0;
 }
 
@@ -219,15 +200,10 @@ static int ntfs_mkdir(struct user_namespace *mnt_userns, struct inode *dir,
                      struct dentry *dentry, umode_t mode)
 {
        struct inode *inode;
-       struct ntfs_inode *ni = ntfs_i(dir);
-
-       ni_lock_dir(ni);
 
        inode = ntfs_create_inode(mnt_userns, dir, dentry, NULL, S_IFDIR | mode,
                                  0, NULL, 0, NULL);
 
-       ni_unlock(ni);
-
        return IS_ERR(inode) ? PTR_ERR(inode) : 0;
 }
 
index 6bb3e59..9cc396b 100644 (file)
 #ifndef _LINUX_NTFS3_NTFS_H
 #define _LINUX_NTFS3_NTFS_H
 
-/* TODO: Check 4K MFT record and 512 bytes cluster. */
+#include <linux/blkdev.h>
+#include <linux/build_bug.h>
+#include <linux/kernel.h>
+#include <linux/stddef.h>
+#include <linux/string.h>
+#include <linux/types.h>
+
+#include "debug.h"
 
-/* Activate this define to use binary search in indexes. */
-#define NTFS3_INDEX_BINARY_SEARCH
+/* TODO: Check 4K MFT record and 512 bytes cluster. */
 
 /* Check each run for marked clusters. */
 #define NTFS3_CHECK_FREE_CLST
 
 #define NTFS_NAME_LEN 255
 
-/* ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff. */
-#define NTFS_LINK_MAX 0x400
-//#define NTFS_LINK_MAX 0xffff
+/*
+ * ntfs.sys used 500 maximum links on-disk struct allows up to 0xffff.
+ * xfstest generic/041 creates 3003 hardlinks.
+ */
+#define NTFS_LINK_MAX 4000
 
 /*
  * Activate to use 64 bit clusters instead of 32 bits in ntfs.sys.
index dc71c59..8aaec7e 100644 (file)
@@ -9,6 +9,37 @@
 #ifndef _LINUX_NTFS3_NTFS_FS_H
 #define _LINUX_NTFS3_NTFS_FS_H
 
+#include <linux/blkdev.h>
+#include <linux/buffer_head.h>
+#include <linux/cleancache.h>
+#include <linux/fs.h>
+#include <linux/highmem.h>
+#include <linux/kernel.h>
+#include <linux/mm.h>
+#include <linux/mutex.h>
+#include <linux/page-flags.h>
+#include <linux/pagemap.h>
+#include <linux/rbtree.h>
+#include <linux/rwsem.h>
+#include <linux/slab.h>
+#include <linux/string.h>
+#include <linux/time64.h>
+#include <linux/types.h>
+#include <linux/uidgid.h>
+#include <asm/div64.h>
+#include <asm/page.h>
+
+#include "debug.h"
+#include "ntfs.h"
+
+struct dentry;
+struct fiemap_extent_info;
+struct user_namespace;
+struct page;
+struct writeback_control;
+enum utf16_endian;
+
+
 #define MINUS_ONE_T                    ((size_t)(-1))
 /* Biggest MFT / smallest cluster */
 #define MAXIMUM_BYTES_PER_MFT          4096
@@ -52,6 +83,7 @@
 // clang-format on
 
 struct ntfs_mount_options {
+       char *nls_name;
        struct nls_table *nls;
 
        kuid_t fs_uid;
@@ -59,19 +91,16 @@ struct ntfs_mount_options {
        u16 fs_fmask_inv;
        u16 fs_dmask_inv;
 
-       unsigned uid : 1, /* uid was set. */
-               gid : 1, /* gid was set. */
-               fmask : 1, /* fmask was set. */
-               dmask : 1, /* dmask was set. */
-               sys_immutable : 1, /* Immutable system files. */
-               discard : 1, /* Issue discard requests on deletions. */
-               sparse : 1, /* Create sparse files. */
-               showmeta : 1, /* Show meta files. */
-               nohidden : 1, /* Do not show hidden files. */
-               force : 1, /* Rw mount dirty volume. */
-               no_acs_rules : 1, /*Exclude acs rules. */
-               prealloc : 1 /* Preallocate space when file is growing. */
-               ;
+       unsigned fmask : 1; /* fmask was set. */
+       unsigned dmask : 1; /*dmask was set. */
+       unsigned sys_immutable : 1; /* Immutable system files. */
+       unsigned discard : 1; /* Issue discard requests on deletions. */
+       unsigned sparse : 1; /* Create sparse files. */
+       unsigned showmeta : 1; /* Show meta files. */
+       unsigned nohidden : 1; /* Do not show hidden files. */
+       unsigned force : 1; /* RW mount dirty volume. */
+       unsigned noacsrules : 1; /* Exclude acs rules. */
+       unsigned prealloc : 1; /* Preallocate space when file is growing. */
 };
 
 /* Special value to unpack and deallocate. */
@@ -182,10 +211,8 @@ struct ntfs_sb_info {
        u32 blocks_per_cluster; // cluster_size / sb->s_blocksize
 
        u32 record_size;
-       u32 sector_size;
        u32 index_size;
 
-       u8 sector_bits;
        u8 cluster_bits;
        u8 record_bits;
 
@@ -279,7 +306,7 @@ struct ntfs_sb_info {
 #endif
        } compress;
 
-       struct ntfs_mount_options options;
+       struct ntfs_mount_options *options;
        struct ratelimit_state msg_ratelimit;
 };
 
@@ -436,7 +463,7 @@ bool al_remove_le(struct ntfs_inode *ni, struct ATTR_LIST_ENTRY *le);
 bool al_delete_le(struct ntfs_inode *ni, enum ATTR_TYPE type, CLST vcn,
                  const __le16 *name, size_t name_len,
                  const struct MFT_REF *ref);
-int al_update(struct ntfs_inode *ni);
+int al_update(struct ntfs_inode *ni, int sync);
 static inline size_t al_aligned(size_t size)
 {
        return (size + 1023) & ~(size_t)1023;
@@ -448,7 +475,7 @@ bool are_bits_set(const ulong *map, size_t bit, size_t nbits);
 size_t get_set_bits_ex(const ulong *map, size_t bit, size_t nbits);
 
 /* Globals from dir.c */
-int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const struct le_str *uni,
+int ntfs_utf16_to_nls(struct ntfs_sb_info *sbi, const __le16 *name, u32 len,
                      u8 *buf, int buf_len);
 int ntfs_nls_to_utf16(struct ntfs_sb_info *sbi, const u8 *name, u32 name_len,
                      struct cpu_str *uni, u32 max_ulen,
@@ -520,7 +547,7 @@ struct ATTR_FILE_NAME *ni_fname_type(struct ntfs_inode *ni, u8 name_type,
                                     struct ATTR_LIST_ENTRY **entry);
 int ni_new_attr_flags(struct ntfs_inode *ni, enum FILE_ATTRIBUTE new_fa);
 enum REPARSE_SIGN ni_parse_reparse(struct ntfs_inode *ni, struct ATTRIB *attr,
-                                  void *buffer);
+                                  struct REPARSE_DATA_BUFFER *buffer);
 int ni_write_inode(struct inode *inode, int sync, const char *hint);
 #define _ni_write_inode(i, w) ni_write_inode(i, w, __func__)
 int ni_fiemap(struct ntfs_inode *ni, struct fiemap_extent_info *fieinfo,
@@ -577,7 +604,7 @@ int ntfs_sb_read(struct super_block *sb, u64 lbo, size_t bytes, void *buffer);
 int ntfs_sb_write(struct super_block *sb, u64 lbo, size_t bytes,
                  const void *buffer, int wait);
 int ntfs_sb_write_run(struct ntfs_sb_info *sbi, const struct runs_tree *run,
-                     u64 vbo, const void *buf, size_t bytes);
+                     u64 vbo, const void *buf, size_t bytes, int sync);
 struct buffer_head *ntfs_bread_run(struct ntfs_sb_info *sbi,
                                   const struct runs_tree *run, u64 vbo);
 int ntfs_read_run_nb(struct ntfs_sb_info *sbi, const struct runs_tree *run,
index 103705c..861e357 100644 (file)
@@ -5,10 +5,7 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
 
 #include "debug.h"
 #include "ntfs.h"
index 26ed2b6..a8fec65 100644 (file)
@@ -7,10 +7,8 @@
  */
 
 #include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
 #include <linux/log2.h>
-#include <linux/nls.h>
 
 #include "debug.h"
 #include "ntfs.h"
index 55bbc92..d41d769 100644 (file)
  *
  */
 
-#include <linux/backing-dev.h>
 #include <linux/blkdev.h>
 #include <linux/buffer_head.h>
 #include <linux/exportfs.h>
 #include <linux/fs.h>
-#include <linux/iversion.h>
+#include <linux/fs_context.h>
+#include <linux/fs_parser.h>
 #include <linux/log2.h>
 #include <linux/module.h>
 #include <linux/nls.h>
-#include <linux/parser.h>
 #include <linux/seq_file.h>
 #include <linux/statfs.h>
 
@@ -205,9 +204,11 @@ void *ntfs_put_shared(void *ptr)
        return ret;
 }
 
-static inline void clear_mount_options(struct ntfs_mount_options *options)
+static inline void put_mount_options(struct ntfs_mount_options *options)
 {
+       kfree(options->nls_name);
        unload_nls(options->nls);
+       kfree(options);
 }
 
 enum Opt {
@@ -223,218 +224,175 @@ enum Opt {
        Opt_nohidden,
        Opt_showmeta,
        Opt_acl,
-       Opt_noatime,
-       Opt_nls,
+       Opt_iocharset,
        Opt_prealloc,
-       Opt_no_acs_rules,
+       Opt_noacsrules,
        Opt_err,
 };
 
-static const match_table_t ntfs_tokens = {
-       { Opt_uid, "uid=%u" },
-       { Opt_gid, "gid=%u" },
-       { Opt_umask, "umask=%o" },
-       { Opt_dmask, "dmask=%o" },
-       { Opt_fmask, "fmask=%o" },
-       { Opt_immutable, "sys_immutable" },
-       { Opt_discard, "discard" },
-       { Opt_force, "force" },
-       { Opt_sparse, "sparse" },
-       { Opt_nohidden, "nohidden" },
-       { Opt_acl, "acl" },
-       { Opt_noatime, "noatime" },
-       { Opt_showmeta, "showmeta" },
-       { Opt_nls, "nls=%s" },
-       { Opt_prealloc, "prealloc" },
-       { Opt_no_acs_rules, "no_acs_rules" },
-       { Opt_err, NULL },
+static const struct fs_parameter_spec ntfs_fs_parameters[] = {
+       fsparam_u32("uid",                      Opt_uid),
+       fsparam_u32("gid",                      Opt_gid),
+       fsparam_u32oct("umask",                 Opt_umask),
+       fsparam_u32oct("dmask",                 Opt_dmask),
+       fsparam_u32oct("fmask",                 Opt_fmask),
+       fsparam_flag_no("sys_immutable",        Opt_immutable),
+       fsparam_flag_no("discard",              Opt_discard),
+       fsparam_flag_no("force",                Opt_force),
+       fsparam_flag_no("sparse",               Opt_sparse),
+       fsparam_flag_no("hidden",               Opt_nohidden),
+       fsparam_flag_no("acl",                  Opt_acl),
+       fsparam_flag_no("showmeta",             Opt_showmeta),
+       fsparam_flag_no("prealloc",             Opt_prealloc),
+       fsparam_flag_no("acsrules",             Opt_noacsrules),
+       fsparam_string("iocharset",             Opt_iocharset),
+       {}
 };
 
-static noinline int ntfs_parse_options(struct super_block *sb, char *options,
-                                      int silent,
-                                      struct ntfs_mount_options *opts)
+/*
+ * Load nls table or if @nls is utf8 then return NULL.
+ */
+static struct nls_table *ntfs_load_nls(char *nls)
 {
-       char *p;
-       substring_t args[MAX_OPT_ARGS];
-       int option;
-       char nls_name[30];
-       struct nls_table *nls;
+       struct nls_table *ret;
 
-       opts->fs_uid = current_uid();
-       opts->fs_gid = current_gid();
-       opts->fs_fmask_inv = opts->fs_dmask_inv = ~current_umask();
-       nls_name[0] = 0;
+       if (!nls)
+               nls = CONFIG_NLS_DEFAULT;
 
-       if (!options)
-               goto out;
+       if (strcmp(nls, "utf8") == 0)
+               return NULL;
 
-       while ((p = strsep(&options, ","))) {
-               int token;
+       if (strcmp(nls, CONFIG_NLS_DEFAULT) == 0)
+               return load_nls_default();
 
-               if (!*p)
-                       continue;
+       ret = load_nls(nls);
+       if (ret)
+               return ret;
 
-               token = match_token(p, ntfs_tokens, args);
-               switch (token) {
-               case Opt_immutable:
-                       opts->sys_immutable = 1;
-                       break;
-               case Opt_uid:
-                       if (match_int(&args[0], &option))
-                               return -EINVAL;
-                       opts->fs_uid = make_kuid(current_user_ns(), option);
-                       if (!uid_valid(opts->fs_uid))
-                               return -EINVAL;
-                       opts->uid = 1;
-                       break;
-               case Opt_gid:
-                       if (match_int(&args[0], &option))
-                               return -EINVAL;
-                       opts->fs_gid = make_kgid(current_user_ns(), option);
-                       if (!gid_valid(opts->fs_gid))
-                               return -EINVAL;
-                       opts->gid = 1;
-                       break;
-               case Opt_umask:
-                       if (match_octal(&args[0], &option))
-                               return -EINVAL;
-                       opts->fs_fmask_inv = opts->fs_dmask_inv = ~option;
-                       opts->fmask = opts->dmask = 1;
-                       break;
-               case Opt_dmask:
-                       if (match_octal(&args[0], &option))
-                               return -EINVAL;
-                       opts->fs_dmask_inv = ~option;
-                       opts->dmask = 1;
-                       break;
-               case Opt_fmask:
-                       if (match_octal(&args[0], &option))
-                               return -EINVAL;
-                       opts->fs_fmask_inv = ~option;
-                       opts->fmask = 1;
-                       break;
-               case Opt_discard:
-                       opts->discard = 1;
-                       break;
-               case Opt_force:
-                       opts->force = 1;
-                       break;
-               case Opt_sparse:
-                       opts->sparse = 1;
-                       break;
-               case Opt_nohidden:
-                       opts->nohidden = 1;
-                       break;
-               case Opt_acl:
+       return ERR_PTR(-EINVAL);
+}
+
+static int ntfs_fs_parse_param(struct fs_context *fc,
+                              struct fs_parameter *param)
+{
+       struct ntfs_mount_options *opts = fc->fs_private;
+       struct fs_parse_result result;
+       int opt;
+
+       opt = fs_parse(fc, ntfs_fs_parameters, param, &result);
+       if (opt < 0)
+               return opt;
+
+       switch (opt) {
+       case Opt_uid:
+               opts->fs_uid = make_kuid(current_user_ns(), result.uint_32);
+               if (!uid_valid(opts->fs_uid))
+                       return invalf(fc, "ntfs3: Invalid value for uid.");
+               break;
+       case Opt_gid:
+               opts->fs_gid = make_kgid(current_user_ns(), result.uint_32);
+               if (!gid_valid(opts->fs_gid))
+                       return invalf(fc, "ntfs3: Invalid value for gid.");
+               break;
+       case Opt_umask:
+               if (result.uint_32 & ~07777)
+                       return invalf(fc, "ntfs3: Invalid value for umask.");
+               opts->fs_fmask_inv = ~result.uint_32;
+               opts->fs_dmask_inv = ~result.uint_32;
+               opts->fmask = 1;
+               opts->dmask = 1;
+               break;
+       case Opt_dmask:
+               if (result.uint_32 & ~07777)
+                       return invalf(fc, "ntfs3: Invalid value for dmask.");
+               opts->fs_dmask_inv = ~result.uint_32;
+               opts->dmask = 1;
+               break;
+       case Opt_fmask:
+               if (result.uint_32 & ~07777)
+                       return invalf(fc, "ntfs3: Invalid value for fmask.");
+               opts->fs_fmask_inv = ~result.uint_32;
+               opts->fmask = 1;
+               break;
+       case Opt_immutable:
+               opts->sys_immutable = result.negated ? 0 : 1;
+               break;
+       case Opt_discard:
+               opts->discard = result.negated ? 0 : 1;
+               break;
+       case Opt_force:
+               opts->force = result.negated ? 0 : 1;
+               break;
+       case Opt_sparse:
+               opts->sparse = result.negated ? 0 : 1;
+               break;
+       case Opt_nohidden:
+               opts->nohidden = result.negated ? 1 : 0;
+               break;
+       case Opt_acl:
+               if (!result.negated)
 #ifdef CONFIG_NTFS3_FS_POSIX_ACL
-                       sb->s_flags |= SB_POSIXACL;
-                       break;
+                       fc->sb_flags |= SB_POSIXACL;
 #else
-                       ntfs_err(sb, "support for ACL not compiled in!");
-                       return -EINVAL;
+                       return invalf(fc, "ntfs3: Support for ACL not compiled in!");
 #endif
-               case Opt_noatime:
-                       sb->s_flags |= SB_NOATIME;
-                       break;
-               case Opt_showmeta:
-                       opts->showmeta = 1;
-                       break;
-               case Opt_nls:
-                       match_strlcpy(nls_name, &args[0], sizeof(nls_name));
-                       break;
-               case Opt_prealloc:
-                       opts->prealloc = 1;
-                       break;
-               case Opt_no_acs_rules:
-                       opts->no_acs_rules = 1;
-                       break;
-               default:
-                       if (!silent)
-                               ntfs_err(
-                                       sb,
-                                       "Unrecognized mount option \"%s\" or missing value",
-                                       p);
-                       //return -EINVAL;
-               }
-       }
-
-out:
-       if (!strcmp(nls_name[0] ? nls_name : CONFIG_NLS_DEFAULT, "utf8")) {
-               /*
-                * For UTF-8 use utf16s_to_utf8s()/utf8s_to_utf16s()
-                * instead of NLS.
-                */
-               nls = NULL;
-       } else if (nls_name[0]) {
-               nls = load_nls(nls_name);
-               if (!nls) {
-                       ntfs_err(sb, "failed to load \"%s\"", nls_name);
-                       return -EINVAL;
-               }
-       } else {
-               nls = load_nls_default();
-               if (!nls) {
-                       ntfs_err(sb, "failed to load default nls");
-                       return -EINVAL;
-               }
+               else
+                       fc->sb_flags &= ~SB_POSIXACL;
+               break;
+       case Opt_showmeta:
+               opts->showmeta = result.negated ? 0 : 1;
+               break;
+       case Opt_iocharset:
+               kfree(opts->nls_name);
+               opts->nls_name = param->string;
+               param->string = NULL;
+               break;
+       case Opt_prealloc:
+               opts->prealloc = result.negated ? 0 : 1;
+               break;
+       case Opt_noacsrules:
+               opts->noacsrules = result.negated ? 1 : 0;
+               break;
+       default:
+               /* Should not be here unless we forget add case. */
+               return -EINVAL;
        }
-       opts->nls = nls;
-
        return 0;
 }
 
-static int ntfs_remount(struct super_block *sb, int *flags, char *data)
+static int ntfs_fs_reconfigure(struct fs_context *fc)
 {
-       int err, ro_rw;
+       struct super_block *sb = fc->root->d_sb;
        struct ntfs_sb_info *sbi = sb->s_fs_info;
-       struct ntfs_mount_options old_opts;
-       char *orig_data = kstrdup(data, GFP_KERNEL);
-
-       if (data && !orig_data)
-               return -ENOMEM;
+       struct ntfs_mount_options *new_opts = fc->fs_private;
+       int ro_rw;
 
-       /* Store  original options. */
-       memcpy(&old_opts, &sbi->options, sizeof(old_opts));
-       clear_mount_options(&sbi->options);
-       memset(&sbi->options, 0, sizeof(sbi->options));
-
-       err = ntfs_parse_options(sb, data, 0, &sbi->options);
-       if (err)
-               goto restore_opts;
-
-       ro_rw = sb_rdonly(sb) && !(*flags & SB_RDONLY);
+       ro_rw = sb_rdonly(sb) && !(fc->sb_flags & SB_RDONLY);
        if (ro_rw && (sbi->flags & NTFS_FLAGS_NEED_REPLAY)) {
-               ntfs_warn(
-                       sb,
-                       "Couldn't remount rw because journal is not replayed. Please umount/remount instead\n");
-               err = -EINVAL;
-               goto restore_opts;
+               errorf(fc, "ntfs3: Couldn't remount rw because journal is not replayed. Please umount/remount instead\n");
+               return -EINVAL;
        }
 
+       new_opts->nls = ntfs_load_nls(new_opts->nls_name);
+       if (IS_ERR(new_opts->nls)) {
+               new_opts->nls = NULL;
+               errorf(fc, "ntfs3: Cannot load iocharset %s", new_opts->nls_name);
+               return -EINVAL;
+       }
+       if (new_opts->nls != sbi->options->nls)
+               return invalf(fc, "ntfs3: Cannot use different iocharset when remounting!");
+
        sync_filesystem(sb);
 
        if (ro_rw && (sbi->volume.flags & VOLUME_FLAG_DIRTY) &&
-           !sbi->options.force) {
-               ntfs_warn(sb, "volume is dirty and \"force\" flag is not set!");
-               err = -EINVAL;
-               goto restore_opts;
+           !new_opts->force) {
+               errorf(fc, "ntfs3: Volume is dirty and \"force\" flag is not set!");
+               return -EINVAL;
        }
 
-       clear_mount_options(&old_opts);
-
-       *flags = (*flags & ~SB_LAZYTIME) | (sb->s_flags & SB_LAZYTIME) |
-                SB_NODIRATIME | SB_NOATIME;
-       ntfs_info(sb, "re-mounted. Opts: %s", orig_data);
-       err = 0;
-       goto out;
+       memcpy(sbi->options, new_opts, sizeof(*new_opts));
 
-restore_opts:
-       clear_mount_options(&sbi->options);
-       memcpy(&sbi->options, &old_opts, sizeof(old_opts));
-
-out:
-       kfree(orig_data);
-       return err;
+       return 0;
 }
 
 static struct kmem_cache *ntfs_inode_cachep;
@@ -513,8 +471,6 @@ static noinline void put_ntfs(struct ntfs_sb_info *sbi)
        xpress_free_decompressor(sbi->compress.xpress);
        lzx_free_decompressor(sbi->compress.lzx);
 #endif
-       clear_mount_options(&sbi->options);
-
        kfree(sbi);
 }
 
@@ -525,7 +481,9 @@ static void ntfs_put_super(struct super_block *sb)
        /* Mark rw ntfs as clear, if possible. */
        ntfs_set_state(sbi, NTFS_DIRTY_CLEAR);
 
+       put_mount_options(sbi->options);
        put_ntfs(sbi);
+       sb->s_fs_info = NULL;
 
        sync_blockdev(sb->s_bdev);
 }
@@ -552,23 +510,21 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
 {
        struct super_block *sb = root->d_sb;
        struct ntfs_sb_info *sbi = sb->s_fs_info;
-       struct ntfs_mount_options *opts = &sbi->options;
+       struct ntfs_mount_options *opts = sbi->options;
        struct user_namespace *user_ns = seq_user_ns(m);
 
-       if (opts->uid)
-               seq_printf(m, ",uid=%u",
-                          from_kuid_munged(user_ns, opts->fs_uid));
-       if (opts->gid)
-               seq_printf(m, ",gid=%u",
-                          from_kgid_munged(user_ns, opts->fs_gid));
+       seq_printf(m, ",uid=%u",
+                 from_kuid_munged(user_ns, opts->fs_uid));
+       seq_printf(m, ",gid=%u",
+                 from_kgid_munged(user_ns, opts->fs_gid));
        if (opts->fmask)
                seq_printf(m, ",fmask=%04o", ~opts->fs_fmask_inv);
        if (opts->dmask)
                seq_printf(m, ",dmask=%04o", ~opts->fs_dmask_inv);
        if (opts->nls)
-               seq_printf(m, ",nls=%s", opts->nls->charset);
+               seq_printf(m, ",iocharset=%s", opts->nls->charset);
        else
-               seq_puts(m, ",nls=utf8");
+               seq_puts(m, ",iocharset=utf8");
        if (opts->sys_immutable)
                seq_puts(m, ",sys_immutable");
        if (opts->discard)
@@ -581,14 +537,12 @@ static int ntfs_show_options(struct seq_file *m, struct dentry *root)
                seq_puts(m, ",nohidden");
        if (opts->force)
                seq_puts(m, ",force");
-       if (opts->no_acs_rules)
-               seq_puts(m, ",no_acs_rules");
+       if (opts->noacsrules)
+               seq_puts(m, ",noacsrules");
        if (opts->prealloc)
                seq_puts(m, ",prealloc");
        if (sb->s_flags & SB_POSIXACL)
                seq_puts(m, ",acl");
-       if (sb->s_flags & SB_NOATIME)
-               seq_puts(m, ",noatime");
 
        return 0;
 }
@@ -643,7 +597,6 @@ static const struct super_operations ntfs_sops = {
        .statfs = ntfs_statfs,
        .show_options = ntfs_show_options,
        .sync_fs = ntfs_sync_fs,
-       .remount_fs = ntfs_remount,
        .write_inode = ntfs3_write_inode,
 };
 
@@ -729,7 +682,7 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
        struct ntfs_sb_info *sbi = sb->s_fs_info;
        int err;
        u32 mb, gb, boot_sector_size, sct_per_clst, record_size;
-       u64 sectors, clusters, fs_size, mlcn, mlcn2;
+       u64 sectors, clusters, mlcn, mlcn2;
        struct NTFS_BOOT *boot;
        struct buffer_head *bh;
        struct MFT_REC *rec;
@@ -787,20 +740,20 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
                goto out;
        }
 
-       sbi->sector_size = boot_sector_size;
-       sbi->sector_bits = blksize_bits(boot_sector_size);
-       fs_size = (sectors + 1) << sbi->sector_bits;
+       sbi->volume.size = sectors * boot_sector_size;
 
-       gb = format_size_gb(fs_size, &mb);
+       gb = format_size_gb(sbi->volume.size + boot_sector_size, &mb);
 
        /*
         * - Volume formatted and mounted with the same sector size.
         * - Volume formatted 4K and mounted as 512.
         * - Volume formatted 512 and mounted as 4K.
         */
-       if (sbi->sector_size != sector_size) {
-               ntfs_warn(sb,
-                         "Different NTFS' sector size and media sector size");
+       if (boot_sector_size != sector_size) {
+               ntfs_warn(
+                       sb,
+                       "Different NTFS' sector size (%u) and media sector size (%u)",
+                       boot_sector_size, sector_size);
                dev_size += sector_size - 1;
        }
 
@@ -810,8 +763,19 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
        sbi->mft.lbo = mlcn << sbi->cluster_bits;
        sbi->mft.lbo2 = mlcn2 << sbi->cluster_bits;
 
-       if (sbi->cluster_size < sbi->sector_size)
+       /* Compare boot's cluster and sector. */
+       if (sbi->cluster_size < boot_sector_size)
+               goto out;
+
+       /* Compare boot's cluster and media sector. */
+       if (sbi->cluster_size < sector_size) {
+               /* No way to use ntfs_get_block in this case. */
+               ntfs_err(
+                       sb,
+                       "Failed to mount 'cause NTFS's cluster size (%u) is less than media sector size (%u)",
+                       sbi->cluster_size, sector_size);
                goto out;
+       }
 
        sbi->cluster_mask = sbi->cluster_size - 1;
        sbi->cluster_mask_inv = ~(u64)sbi->cluster_mask;
@@ -836,10 +800,9 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
                                  : (u32)boot->index_size << sbi->cluster_bits;
 
        sbi->volume.ser_num = le64_to_cpu(boot->serial_num);
-       sbi->volume.size = sectors << sbi->sector_bits;
 
        /* Warning if RAW volume. */
-       if (dev_size < fs_size) {
+       if (dev_size < sbi->volume.size + boot_sector_size) {
                u32 mb0, gb0;
 
                gb0 = format_size_gb(dev_size, &mb0);
@@ -883,8 +846,7 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
        rec->total = cpu_to_le32(sbi->record_size);
        ((struct ATTRIB *)Add2Ptr(rec, ao))->type = ATTR_END;
 
-       if (sbi->cluster_size < PAGE_SIZE)
-               sb_set_blocksize(sb, sbi->cluster_size);
+       sb_set_blocksize(sb, min_t(u32, sbi->cluster_size, PAGE_SIZE));
 
        sbi->block_mask = sb->s_blocksize - 1;
        sbi->blocks_per_cluster = sbi->cluster_size >> sb->s_blocksize_bits;
@@ -897,9 +859,11 @@ static int ntfs_init_from_boot(struct super_block *sb, u32 sector_size,
        if (clusters >= (1ull << (64 - sbi->cluster_bits)))
                sbi->maxbytes = -1;
        sbi->maxbytes_sparse = -1;
+       sb->s_maxbytes = MAX_LFS_FILESIZE;
 #else
        /* Maximum size for sparse file. */
        sbi->maxbytes_sparse = (1ull << (sbi->cluster_bits + 32)) - 1;
+       sb->s_maxbytes = 0xFFFFFFFFull << sbi->cluster_bits;
 #endif
 
        err = 0;
@@ -913,14 +877,13 @@ out:
 /*
  * ntfs_fill_super - Try to mount.
  */
-static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
+static int ntfs_fill_super(struct super_block *sb, struct fs_context *fc)
 {
        int err;
-       struct ntfs_sb_info *sbi;
+       struct ntfs_sb_info *sbi = sb->s_fs_info;
        struct block_device *bdev = sb->s_bdev;
-       struct inode *bd_inode = bdev->bd_inode;
-       struct request_queue *rq = bdev_get_queue(bdev);
-       struct inode *inode = NULL;
+       struct request_queue *rq;
+       struct inode *inode;
        struct ntfs_inode *ni;
        size_t i, tt;
        CLST vcn, lcn, len;
@@ -928,18 +891,11 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        const struct VOLUME_INFO *info;
        u32 idx, done, bytes;
        struct ATTR_DEF_ENTRY *t;
-       u16 *upcase = NULL;
        u16 *shared;
-       bool is_ro;
        struct MFT_REF ref;
 
        ref.high = 0;
 
-       sbi = kzalloc(sizeof(struct ntfs_sb_info), GFP_NOFS);
-       if (!sbi)
-               return -ENOMEM;
-
-       sb->s_fs_info = sbi;
        sbi->sb = sb;
        sb->s_flags |= SB_NODIRATIME;
        sb->s_magic = 0x7366746e; // "ntfs"
@@ -948,41 +904,27 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        sb->s_time_gran = NTFS_TIME_GRAN; // 100 nsec
        sb->s_xattr = ntfs_xattr_handlers;
 
-       ratelimit_state_init(&sbi->msg_ratelimit, DEFAULT_RATELIMIT_INTERVAL,
-                            DEFAULT_RATELIMIT_BURST);
-
-       err = ntfs_parse_options(sb, data, silent, &sbi->options);
-       if (err)
+       sbi->options->nls = ntfs_load_nls(sbi->options->nls_name);
+       if (IS_ERR(sbi->options->nls)) {
+               sbi->options->nls = NULL;
+               errorf(fc, "Cannot load nls %s", sbi->options->nls_name);
+               err = -EINVAL;
                goto out;
+       }
 
-       if (!rq || !blk_queue_discard(rq) || !rq->limits.discard_granularity) {
-               ;
-       } else {
+       rq = bdev_get_queue(bdev);
+       if (blk_queue_discard(rq) && rq->limits.discard_granularity) {
                sbi->discard_granularity = rq->limits.discard_granularity;
                sbi->discard_granularity_mask_inv =
                        ~(u64)(sbi->discard_granularity - 1);
        }
 
-       sb_set_blocksize(sb, PAGE_SIZE);
-
        /* Parse boot. */
        err = ntfs_init_from_boot(sb, rq ? queue_logical_block_size(rq) : 512,
-                                 bd_inode->i_size);
+                                 bdev->bd_inode->i_size);
        if (err)
                goto out;
 
-#ifdef CONFIG_NTFS3_64BIT_CLUSTER
-       sb->s_maxbytes = MAX_LFS_FILESIZE;
-#else
-       sb->s_maxbytes = 0xFFFFFFFFull << sbi->cluster_bits;
-#endif
-
-       mutex_init(&sbi->compress.mtx_lznt);
-#ifdef CONFIG_NTFS3_LZX_XPRESS
-       mutex_init(&sbi->compress.mtx_xpress);
-       mutex_init(&sbi->compress.mtx_lzx);
-#endif
-
        /*
         * Load $Volume. This should be done before $LogFile
         * 'cause 'sbi->volume.ni' is used 'ntfs_set_state'.
@@ -991,9 +933,8 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        ref.seq = cpu_to_le16(MFT_REC_VOL);
        inode = ntfs_iget5(sb, &ref, &NAME_VOLUME);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $Volume.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
@@ -1015,36 +956,33 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        } else {
                /* Should we break mounting here? */
                //err = -EINVAL;
-               //goto out;
+               //goto put_inode_out;
        }
 
        attr = ni_find_attr(ni, attr, NULL, ATTR_VOL_INFO, NULL, 0, NULL, NULL);
        if (!attr || is_attr_ext(attr)) {
                err = -EINVAL;
-               goto out;
+               goto put_inode_out;
        }
 
        info = resident_data_ex(attr, SIZEOF_ATTRIBUTE_VOLUME_INFO);
        if (!info) {
                err = -EINVAL;
-               goto out;
+               goto put_inode_out;
        }
 
        sbi->volume.major_ver = info->major_ver;
        sbi->volume.minor_ver = info->minor_ver;
        sbi->volume.flags = info->flags;
-
        sbi->volume.ni = ni;
-       inode = NULL;
 
        /* Load $MFTMirr to estimate recs_mirr. */
        ref.low = cpu_to_le32(MFT_REC_MIRR);
        ref.seq = cpu_to_le16(MFT_REC_MIRR);
        inode = ntfs_iget5(sb, &ref, &NAME_MIRROR);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $MFTMirr.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
@@ -1058,9 +996,8 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        ref.seq = cpu_to_le16(MFT_REC_LOG);
        inode = ntfs_iget5(sb, &ref, &NAME_LOGFILE);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load \x24LogFile.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
@@ -1068,22 +1005,19 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
 
        err = ntfs_loadlog_and_replay(ni, sbi);
        if (err)
-               goto out;
+               goto put_inode_out;
 
        iput(inode);
-       inode = NULL;
-
-       is_ro = sb_rdonly(sbi->sb);
 
        if (sbi->flags & NTFS_FLAGS_NEED_REPLAY) {
-               if (!is_ro) {
+               if (!sb_rdonly(sb)) {
                        ntfs_warn(sb,
                                  "failed to replay log file. Can't mount rw!");
                        err = -EINVAL;
                        goto out;
                }
        } else if (sbi->volume.flags & VOLUME_FLAG_DIRTY) {
-               if (!is_ro && !sbi->options.force) {
+               if (!sb_rdonly(sb) && !sbi->options->force) {
                        ntfs_warn(
                                sb,
                                "volume is dirty and \"force\" flag is not set!");
@@ -1098,9 +1032,8 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
 
        inode = ntfs_iget5(sb, &ref, &NAME_MFT);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $MFT.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
@@ -1112,11 +1045,11 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
 
        err = wnd_init(&sbi->mft.bitmap, sb, tt);
        if (err)
-               goto out;
+               goto put_inode_out;
 
        err = ni_load_all_mi(ni);
        if (err)
-               goto out;
+               goto put_inode_out;
 
        sbi->mft.ni = ni;
 
@@ -1125,9 +1058,8 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        ref.seq = cpu_to_le16(MFT_REC_BADCLUST);
        inode = ntfs_iget5(sb, &ref, &NAME_BADCLUS);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $BadClus.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
@@ -1150,18 +1082,15 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        ref.seq = cpu_to_le16(MFT_REC_BITMAP);
        inode = ntfs_iget5(sb, &ref, &NAME_BITMAP);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $Bitmap.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
-       ni = ntfs_i(inode);
-
 #ifndef CONFIG_NTFS3_64BIT_CLUSTER
        if (inode->i_size >> 32) {
                err = -EINVAL;
-               goto out;
+               goto put_inode_out;
        }
 #endif
 
@@ -1169,14 +1098,14 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        tt = sbi->used.bitmap.nbits;
        if (inode->i_size < bitmap_size(tt)) {
                err = -EINVAL;
-               goto out;
+               goto put_inode_out;
        }
 
        /* Not necessary. */
        sbi->used.bitmap.set_tail = true;
-       err = wnd_init(&sbi->used.bitmap, sbi->sb, tt);
+       err = wnd_init(&sbi->used.bitmap, sb, tt);
        if (err)
-               goto out;
+               goto put_inode_out;
 
        iput(inode);
 
@@ -1188,23 +1117,22 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        /* Load $AttrDef. */
        ref.low = cpu_to_le32(MFT_REC_ATTR);
        ref.seq = cpu_to_le16(MFT_REC_ATTR);
-       inode = ntfs_iget5(sbi->sb, &ref, &NAME_ATTRDEF);
+       inode = ntfs_iget5(sb, &ref, &NAME_ATTRDEF);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load $AttrDef -> %d", err);
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
        if (inode->i_size < sizeof(struct ATTR_DEF_ENTRY)) {
                err = -EINVAL;
-               goto out;
+               goto put_inode_out;
        }
        bytes = inode->i_size;
        sbi->def_table = t = kmalloc(bytes, GFP_NOFS);
        if (!t) {
                err = -ENOMEM;
-               goto out;
+               goto put_inode_out;
        }
 
        for (done = idx = 0; done < bytes; done += PAGE_SIZE, idx++) {
@@ -1213,7 +1141,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
 
                if (IS_ERR(page)) {
                        err = PTR_ERR(page);
-                       goto out;
+                       goto put_inode_out;
                }
                memcpy(Add2Ptr(t, done), page_address(page),
                       min(PAGE_SIZE, tail));
@@ -1221,7 +1149,7 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
 
                if (!idx && ATTR_STD != t->type) {
                        err = -EINVAL;
-                       goto out;
+                       goto put_inode_out;
                }
        }
 
@@ -1254,33 +1182,24 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
        ref.seq = cpu_to_le16(MFT_REC_UPCASE);
        inode = ntfs_iget5(sb, &ref, &NAME_UPCASE);
        if (IS_ERR(inode)) {
+               ntfs_err(sb, "Failed to load $UpCase.");
                err = PTR_ERR(inode);
-               ntfs_err(sb, "Failed to load \x24LogFile.");
-               inode = NULL;
                goto out;
        }
 
-       ni = ntfs_i(inode);
-
        if (inode->i_size != 0x10000 * sizeof(short)) {
                err = -EINVAL;
-               goto out;
-       }
-
-       sbi->upcase = upcase = kvmalloc(0x10000 * sizeof(short), GFP_KERNEL);
-       if (!upcase) {
-               err = -ENOMEM;
-               goto out;
+               goto put_inode_out;
        }
 
        for (idx = 0; idx < (0x10000 * sizeof(short) >> PAGE_SHIFT); idx++) {
                const __le16 *src;
-               u16 *dst = Add2Ptr(upcase, idx << PAGE_SHIFT);
+               u16 *dst = Add2Ptr(sbi->upcase, idx << PAGE_SHIFT);
                struct page *page = ntfs_map_page(inode->i_mapping, idx);
 
                if (IS_ERR(page)) {
                        err = PTR_ERR(page);
-                       goto out;
+                       goto put_inode_out;
                }
 
                src = page_address(page);
@@ -1294,14 +1213,13 @@ static int ntfs_fill_super(struct super_block *sb, void *data, int silent)
                ntfs_unmap_page(page);
        }
 
-       shared = ntfs_set_shared(upcase, 0x10000 * sizeof(short));
-       if (shared && upcase != shared) {
+       shared = ntfs_set_shared(sbi->upcase, 0x10000 * sizeof(short));
+       if (shared && sbi->upcase != shared) {
+               kvfree(sbi->upcase);
                sbi->upcase = shared;
-               kvfree(upcase);
        }
 
        iput(inode);
-       inode = NULL;
 
        if (is_ntfs3(sbi)) {
                /* Load $Secure. */
@@ -1331,34 +1249,31 @@ load_root:
        ref.seq = cpu_to_le16(MFT_REC_ROOT);
        inode = ntfs_iget5(sb, &ref, &NAME_ROOT);
        if (IS_ERR(inode)) {
-               err = PTR_ERR(inode);
                ntfs_err(sb, "Failed to load root.");
-               inode = NULL;
+               err = PTR_ERR(inode);
                goto out;
        }
 
-       ni = ntfs_i(inode);
-
        sb->s_root = d_make_root(inode);
-
        if (!sb->s_root) {
-               err = -EINVAL;
-               goto out;
+               err = -ENOMEM;
+               goto put_inode_out;
        }
 
+       fc->fs_private = NULL;
+
        return 0;
 
-out:
+put_inode_out:
        iput(inode);
-
-       if (sb->s_root) {
-               d_drop(sb->s_root);
-               sb->s_root = NULL;
-       }
-
+out:
+       /*
+        * Free resources here.
+        * ntfs_fs_free will be called with fc->s_fs_info = NULL
+        */
        put_ntfs(sbi);
-
        sb->s_fs_info = NULL;
+
        return err;
 }
 
@@ -1403,7 +1318,7 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
        if (sbi->flags & NTFS_FLAGS_NODISCARD)
                return -EOPNOTSUPP;
 
-       if (!sbi->options.discard)
+       if (!sbi->options->discard)
                return -EOPNOTSUPP;
 
        lbo = (u64)lcn << sbi->cluster_bits;
@@ -1428,19 +1343,99 @@ int ntfs_discard(struct ntfs_sb_info *sbi, CLST lcn, CLST len)
        return err;
 }
 
-static struct dentry *ntfs_mount(struct file_system_type *fs_type, int flags,
-                                const char *dev_name, void *data)
+static int ntfs_fs_get_tree(struct fs_context *fc)
+{
+       return get_tree_bdev(fc, ntfs_fill_super);
+}
+
+/*
+ * ntfs_fs_free - Free fs_context.
+ *
+ * Note that this will be called after fill_super and reconfigure
+ * even when they pass. So they have to take pointers if they pass.
+ */
+static void ntfs_fs_free(struct fs_context *fc)
 {
-       return mount_bdev(fs_type, flags, dev_name, data, ntfs_fill_super);
+       struct ntfs_mount_options *opts = fc->fs_private;
+       struct ntfs_sb_info *sbi = fc->s_fs_info;
+
+       if (sbi)
+               put_ntfs(sbi);
+
+       if (opts)
+               put_mount_options(opts);
+}
+
+static const struct fs_context_operations ntfs_context_ops = {
+       .parse_param    = ntfs_fs_parse_param,
+       .get_tree       = ntfs_fs_get_tree,
+       .reconfigure    = ntfs_fs_reconfigure,
+       .free           = ntfs_fs_free,
+};
+
+/*
+ * ntfs_init_fs_context - Initialize spi and opts
+ *
+ * This will called when mount/remount. We will first initiliaze
+ * options so that if remount we can use just that.
+ */
+static int ntfs_init_fs_context(struct fs_context *fc)
+{
+       struct ntfs_mount_options *opts;
+       struct ntfs_sb_info *sbi;
+
+       opts = kzalloc(sizeof(struct ntfs_mount_options), GFP_NOFS);
+       if (!opts)
+               return -ENOMEM;
+
+       /* Default options. */
+       opts->fs_uid = current_uid();
+       opts->fs_gid = current_gid();
+       opts->fs_fmask_inv = ~current_umask();
+       opts->fs_dmask_inv = ~current_umask();
+
+       if (fc->purpose == FS_CONTEXT_FOR_RECONFIGURE)
+               goto ok;
+
+       sbi = kzalloc(sizeof(struct ntfs_sb_info), GFP_NOFS);
+       if (!sbi)
+               goto free_opts;
+
+       sbi->upcase = kvmalloc(0x10000 * sizeof(short), GFP_KERNEL);
+       if (!sbi->upcase)
+               goto free_sbi;
+
+       ratelimit_state_init(&sbi->msg_ratelimit, DEFAULT_RATELIMIT_INTERVAL,
+                            DEFAULT_RATELIMIT_BURST);
+
+       mutex_init(&sbi->compress.mtx_lznt);
+#ifdef CONFIG_NTFS3_LZX_XPRESS
+       mutex_init(&sbi->compress.mtx_xpress);
+       mutex_init(&sbi->compress.mtx_lzx);
+#endif
+
+       sbi->options = opts;
+       fc->s_fs_info = sbi;
+ok:
+       fc->fs_private = opts;
+       fc->ops = &ntfs_context_ops;
+
+       return 0;
+free_sbi:
+       kfree(sbi);
+free_opts:
+       kfree(opts);
+       return -ENOMEM;
 }
 
 // clang-format off
 static struct file_system_type ntfs_fs_type = {
-       .owner          = THIS_MODULE,
-       .name           = "ntfs3",
-       .mount          = ntfs_mount,
-       .kill_sb        = kill_block_super,
-       .fs_flags       = FS_REQUIRES_DEV | FS_ALLOW_IDMAP,
+       .owner                  = THIS_MODULE,
+       .name                   = "ntfs3",
+       .init_fs_context        = ntfs_init_fs_context,
+       .parameters             = ntfs_fs_parameters,
+       .kill_sb                = kill_block_super,
+       .fs_flags               = FS_REQUIRES_DEV | FS_ALLOW_IDMAP,
 };
 // clang-format on
 
index bbeba77..b5e8256 100644 (file)
@@ -5,13 +5,9 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
-#include <linux/module.h>
-#include <linux/nls.h>
+#include <linux/kernel.h>
+#include <linux/types.h>
 
-#include "debug.h"
-#include "ntfs.h"
 #include "ntfs_fs.h"
 
 static inline u16 upcase_unicode_char(const u16 *upcase, u16 chr)
index 7282d85..afd0dda 100644 (file)
@@ -5,10 +5,7 @@
  *
  */
 
-#include <linux/blkdev.h>
-#include <linux/buffer_head.h>
 #include <linux/fs.h>
-#include <linux/nls.h>
 #include <linux/posix_acl.h>
 #include <linux/posix_acl_xattr.h>
 #include <linux/xattr.h>
@@ -78,6 +75,7 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
                        size_t add_bytes, const struct EA_INFO **info)
 {
        int err;
+       struct ntfs_sb_info *sbi = ni->mi.sbi;
        struct ATTR_LIST_ENTRY *le = NULL;
        struct ATTRIB *attr_info, *attr_ea;
        void *ea_p;
@@ -102,10 +100,10 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
 
        /* Check Ea limit. */
        size = le32_to_cpu((*info)->size);
-       if (size > ni->mi.sbi->ea_max_size)
+       if (size > sbi->ea_max_size)
                return -EFBIG;
 
-       if (attr_size(attr_ea) > ni->mi.sbi->ea_max_size)
+       if (attr_size(attr_ea) > sbi->ea_max_size)
                return -EFBIG;
 
        /* Allocate memory for packed Ea. */
@@ -113,15 +111,16 @@ static int ntfs_read_ea(struct ntfs_inode *ni, struct EA_FULL **ea,
        if (!ea_p)
                return -ENOMEM;
 
-       if (attr_ea->non_res) {
+       if (!size) {
+               ;
+       } else if (attr_ea->non_res) {
                struct runs_tree run;
 
                run_init(&run);
 
                err = attr_load_runs(attr_ea, ni, &run, NULL);
                if (!err)
-                       err = ntfs_read_run_nb(ni->mi.sbi, &run, 0, ea_p, size,
-                                              NULL);
+                       err = ntfs_read_run_nb(sbi, &run, 0, ea_p, size, NULL);
                run_close(&run);
 
                if (err)
@@ -260,7 +259,7 @@ out:
 
 static noinline int ntfs_set_ea(struct inode *inode, const char *name,
                                size_t name_len, const void *value,
-                               size_t val_size, int flags, int locked)
+                               size_t val_size, int flags)
 {
        struct ntfs_inode *ni = ntfs_i(inode);
        struct ntfs_sb_info *sbi = ni->mi.sbi;
@@ -279,8 +278,7 @@ static noinline int ntfs_set_ea(struct inode *inode, const char *name,
        u64 new_sz;
        void *p;
 
-       if (!locked)
-               ni_lock(ni);
+       ni_lock(ni);
 
        run_init(&ea_run);
 
@@ -370,21 +368,22 @@ static noinline int ntfs_set_ea(struct inode *inode, const char *name,
        new_ea->name[name_len] = 0;
        memcpy(new_ea->name + name_len + 1, value, val_size);
        new_pack = le16_to_cpu(ea_info.size_pack) + packed_ea_size(new_ea);
-
-       /* Should fit into 16 bits. */
-       if (new_pack > 0xffff) {
-               err = -EFBIG; // -EINVAL?
-               goto out;
-       }
        ea_info.size_pack = cpu_to_le16(new_pack);
-
        /* New size of ATTR_EA. */
        size += add;
-       if (size > sbi->ea_max_size) {
+       ea_info.size = cpu_to_le32(size);
+
+       /*
+        * 1. Check ea_info.size_pack for overflow.
+        * 2. New attibute size must fit value from $AttrDef
+        */
+       if (new_pack > 0xffff || size > sbi->ea_max_size) {
+               ntfs_inode_warn(
+                       inode,
+                       "The size of extended attributes must not exceed 64KiB");
                err = -EFBIG; // -EINVAL?
                goto out;
        }
-       ea_info.size = cpu_to_le32(size);
 
 update_ea:
 
@@ -444,7 +443,7 @@ update_ea:
                /* Delete xattr, ATTR_EA */
                ni_remove_attr_le(ni, attr, mi, le);
        } else if (attr->non_res) {
-               err = ntfs_sb_write_run(sbi, &ea_run, 0, ea_all, size);
+               err = ntfs_sb_write_run(sbi, &ea_run, 0, ea_all, size, 0);
                if (err)
                        goto out;
        } else {
@@ -468,8 +467,7 @@ update_ea:
        mark_inode_dirty(&ni->vfs_inode);
 
 out:
-       if (!locked)
-               ni_unlock(ni);
+       ni_unlock(ni);
 
        run_close(&ea_run);
        kfree(ea_all);
@@ -478,12 +476,6 @@ out:
 }
 
 #ifdef CONFIG_NTFS3_FS_POSIX_ACL
-static inline void ntfs_posix_acl_release(struct posix_acl *acl)
-{
-       if (acl && refcount_dec_and_test(&acl->a_refcount))
-               kfree(acl);
-}
-
 static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns,
                                         struct inode *inode, int type,
                                         int locked)
@@ -521,12 +513,15 @@ static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns,
        /* Translate extended attribute to acl. */
        if (err >= 0) {
                acl = posix_acl_from_xattr(mnt_userns, buf, err);
-               if (!IS_ERR(acl))
-                       set_cached_acl(inode, type, acl);
+       } else if (err == -ENODATA) {
+               acl = NULL;
        } else {
-               acl = err == -ENODATA ? NULL : ERR_PTR(err);
+               acl = ERR_PTR(err);
        }
 
+       if (!IS_ERR(acl))
+               set_cached_acl(inode, type, acl);
+
        __putname(buf);
 
        return acl;
@@ -546,12 +541,13 @@ struct posix_acl *ntfs_get_acl(struct inode *inode, int type, bool rcu)
 
 static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
                                    struct inode *inode, struct posix_acl *acl,
-                                   int type, int locked)
+                                   int type)
 {
        const char *name;
        size_t size, name_len;
        void *value = NULL;
        int err = 0;
+       int flags;
 
        if (S_ISLNK(inode->i_mode))
                return -EOPNOTSUPP;
@@ -561,22 +557,15 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
                if (acl) {
                        umode_t mode = inode->i_mode;
 
-                       err = posix_acl_equiv_mode(acl, &mode);
-                       if (err < 0)
-                               return err;
+                       err = posix_acl_update_mode(mnt_userns, inode, &mode,
+                                                   &acl);
+                       if (err)
+                               goto out;
 
                        if (inode->i_mode != mode) {
                                inode->i_mode = mode;
                                mark_inode_dirty(inode);
                        }
-
-                       if (!err) {
-                               /*
-                                * ACL can be exactly represented in the
-                                * traditional file mode permission bits.
-                                */
-                               acl = NULL;
-                       }
                }
                name = XATTR_NAME_POSIX_ACL_ACCESS;
                name_len = sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1;
@@ -594,20 +583,24 @@ static noinline int ntfs_set_acl_ex(struct user_namespace *mnt_userns,
        }
 
        if (!acl) {
+               /* Remove xattr if it can be presented via mode. */
                size = 0;
                value = NULL;
+               flags = XATTR_REPLACE;
        } else {
                size = posix_acl_xattr_size(acl->a_count);
                value = kmalloc(size, GFP_NOFS);
                if (!value)
                        return -ENOMEM;
-
                err = posix_acl_to_xattr(mnt_userns, acl, value, size);
                if (err < 0)
                        goto out;
+               flags = 0;
        }
 
-       err = ntfs_set_ea(inode, name, name_len, value, size, 0, locked);
+       err = ntfs_set_ea(inode, name, name_len, value, size, flags);
+       if (err == -ENODATA && !size)
+               err = 0; /* Removing non existed xattr. */
        if (!err)
                set_cached_acl(inode, type, acl);
 
@@ -623,68 +616,7 @@ out:
 int ntfs_set_acl(struct user_namespace *mnt_userns, struct inode *inode,
                 struct posix_acl *acl, int type)
 {
-       return ntfs_set_acl_ex(mnt_userns, inode, acl, type, 0);
-}
-
-static int ntfs_xattr_get_acl(struct user_namespace *mnt_userns,
-                             struct inode *inode, int type, void *buffer,
-                             size_t size)
-{
-       struct posix_acl *acl;
-       int err;
-
-       if (!(inode->i_sb->s_flags & SB_POSIXACL)) {
-               ntfs_inode_warn(inode, "add mount option \"acl\" to use acl");
-               return -EOPNOTSUPP;
-       }
-
-       acl = ntfs_get_acl(inode, type, false);
-       if (IS_ERR(acl))
-               return PTR_ERR(acl);
-
-       if (!acl)
-               return -ENODATA;
-
-       err = posix_acl_to_xattr(mnt_userns, acl, buffer, size);
-       ntfs_posix_acl_release(acl);
-
-       return err;
-}
-
-static int ntfs_xattr_set_acl(struct user_namespace *mnt_userns,
-                             struct inode *inode, int type, const void *value,
-                             size_t size)
-{
-       struct posix_acl *acl;
-       int err;
-
-       if (!(inode->i_sb->s_flags & SB_POSIXACL)) {
-               ntfs_inode_warn(inode, "add mount option \"acl\" to use acl");
-               return -EOPNOTSUPP;
-       }
-
-       if (!inode_owner_or_capable(mnt_userns, inode))
-               return -EPERM;
-
-       if (!value) {
-               acl = NULL;
-       } else {
-               acl = posix_acl_from_xattr(mnt_userns, value, size);
-               if (IS_ERR(acl))
-                       return PTR_ERR(acl);
-
-               if (acl) {
-                       err = posix_acl_valid(mnt_userns, acl);
-                       if (err)
-                               goto release_and_out;
-               }
-       }
-
-       err = ntfs_set_acl(mnt_userns, inode, acl, type);
-
-release_and_out:
-       ntfs_posix_acl_release(acl);
-       return err;
+       return ntfs_set_acl_ex(mnt_userns, inode, acl, type);
 }
 
 /*
@@ -698,54 +630,27 @@ int ntfs_init_acl(struct user_namespace *mnt_userns, struct inode *inode,
        struct posix_acl *default_acl, *acl;
        int err;
 
-       /*
-        * TODO: Refactoring lock.
-        * ni_lock(dir) ... -> posix_acl_create(dir,...) -> ntfs_get_acl -> ni_lock(dir)
-        */
-       inode->i_default_acl = NULL;
-
-       default_acl = ntfs_get_acl_ex(mnt_userns, dir, ACL_TYPE_DEFAULT, 1);
-
-       if (!default_acl || default_acl == ERR_PTR(-EOPNOTSUPP)) {
-               inode->i_mode &= ~current_umask();
-               err = 0;
-               goto out;
-       }
-
-       if (IS_ERR(default_acl)) {
-               err = PTR_ERR(default_acl);
-               goto out;
-       }
-
-       acl = default_acl;
-       err = __posix_acl_create(&acl, GFP_NOFS, &inode->i_mode);
-       if (err < 0)
-               goto out1;
-       if (!err) {
-               posix_acl_release(acl);
-               acl = NULL;
-       }
+       err = posix_acl_create(dir, &inode->i_mode, &default_acl, &acl);
+       if (err)
+               return err;
 
-       if (!S_ISDIR(inode->i_mode)) {
+       if (default_acl) {
+               err = ntfs_set_acl_ex(mnt_userns, inode, default_acl,
+                                     ACL_TYPE_DEFAULT);
                posix_acl_release(default_acl);
-               default_acl = NULL;
+       } else {
+               inode->i_default_acl = NULL;
        }
 
-       if (default_acl)
-               err = ntfs_set_acl_ex(mnt_userns, inode, default_acl,
-                                     ACL_TYPE_DEFAULT, 1);
-
        if (!acl)
                inode->i_acl = NULL;
-       else if (!err)
-               err = ntfs_set_acl_ex(mnt_userns, inode, acl, ACL_TYPE_ACCESS,
-                                     1);
-
-       posix_acl_release(acl);
-out1:
-       posix_acl_release(default_acl);
+       else {
+               if (!err)
+                       err = ntfs_set_acl_ex(mnt_userns, inode, acl,
+                                             ACL_TYPE_ACCESS);
+               posix_acl_release(acl);
+       }
 
-out:
        return err;
 }
 #endif
@@ -772,7 +677,7 @@ int ntfs_acl_chmod(struct user_namespace *mnt_userns, struct inode *inode)
 int ntfs_permission(struct user_namespace *mnt_userns, struct inode *inode,
                    int mask)
 {
-       if (ntfs_sb(inode->i_sb)->options.no_acs_rules) {
+       if (ntfs_sb(inode->i_sb)->options->noacsrules) {
                /* "No access rules" mode - Allow all changes. */
                return 0;
        }
@@ -880,23 +785,6 @@ static int ntfs_getxattr(const struct xattr_handler *handler, struct dentry *de,
                goto out;
        }
 
-#ifdef CONFIG_NTFS3_FS_POSIX_ACL
-       if ((name_len == sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1 &&
-            !memcmp(name, XATTR_NAME_POSIX_ACL_ACCESS,
-                    sizeof(XATTR_NAME_POSIX_ACL_ACCESS))) ||
-           (name_len == sizeof(XATTR_NAME_POSIX_ACL_DEFAULT) - 1 &&
-            !memcmp(name, XATTR_NAME_POSIX_ACL_DEFAULT,
-                    sizeof(XATTR_NAME_POSIX_ACL_DEFAULT)))) {
-               /* TODO: init_user_ns? */
-               err = ntfs_xattr_get_acl(
-                       &init_user_ns, inode,
-                       name_len == sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1
-                               ? ACL_TYPE_ACCESS
-                               : ACL_TYPE_DEFAULT,
-                       buffer, size);
-               goto out;
-       }
-#endif
        /* Deal with NTFS extended attribute. */
        err = ntfs_get_ea(inode, name, name_len, buffer, size, NULL);
 
@@ -1009,24 +897,8 @@ set_new_fa:
                goto out;
        }
 
-#ifdef CONFIG_NTFS3_FS_POSIX_ACL
-       if ((name_len == sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1 &&
-            !memcmp(name, XATTR_NAME_POSIX_ACL_ACCESS,
-                    sizeof(XATTR_NAME_POSIX_ACL_ACCESS))) ||
-           (name_len == sizeof(XATTR_NAME_POSIX_ACL_DEFAULT) - 1 &&
-            !memcmp(name, XATTR_NAME_POSIX_ACL_DEFAULT,
-                    sizeof(XATTR_NAME_POSIX_ACL_DEFAULT)))) {
-               err = ntfs_xattr_set_acl(
-                       mnt_userns, inode,
-                       name_len == sizeof(XATTR_NAME_POSIX_ACL_ACCESS) - 1
-                               ? ACL_TYPE_ACCESS
-                               : ACL_TYPE_DEFAULT,
-                       value, size);
-               goto out;
-       }
-#endif
        /* Deal with NTFS extended attribute. */
-       err = ntfs_set_ea(inode, name, name_len, value, size, flags, 0);
+       err = ntfs_set_ea(inode, name, name_len, value, size, flags);
 
 out:
        return err;
@@ -1042,28 +914,29 @@ int ntfs_save_wsl_perm(struct inode *inode)
        int err;
        __le32 value;
 
+       /* TODO: refactor this, so we don't lock 4 times in ntfs_set_ea */
        value = cpu_to_le32(i_uid_read(inode));
        err = ntfs_set_ea(inode, "$LXUID", sizeof("$LXUID") - 1, &value,
-                         sizeof(value), 0, 0);
+                         sizeof(value), 0);
        if (err)
                goto out;
 
        value = cpu_to_le32(i_gid_read(inode));
        err = ntfs_set_ea(inode, "$LXGID", sizeof("$LXGID") - 1, &value,
-                         sizeof(value), 0, 0);
+                         sizeof(value), 0);
        if (err)
                goto out;
 
        value = cpu_to_le32(inode->i_mode);
        err = ntfs_set_ea(inode, "$LXMOD", sizeof("$LXMOD") - 1, &value,
-                         sizeof(value), 0, 0);
+                         sizeof(value), 0);
        if (err)
                goto out;
 
        if (S_ISCHR(inode->i_mode) || S_ISBLK(inode->i_mode)) {
                value = cpu_to_le32(inode->i_rdev);
                err = ntfs_set_ea(inode, "$LXDEV", sizeof("$LXDEV") - 1, &value,
-                                 sizeof(value), 0, 0);
+                                 sizeof(value), 0);
                if (err)
                        goto out;
        }
index 359524b..801e60b 100644 (file)
@@ -3951,7 +3951,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
                oi = OCFS2_I(inode);
                oi->ip_dir_lock_gen++;
                mlog(0, "generation: %u\n", oi->ip_dir_lock_gen);
-               goto out;
+               goto out_forget;
        }
 
        if (!S_ISREG(inode->i_mode))
@@ -3982,6 +3982,7 @@ static int ocfs2_data_convert_worker(struct ocfs2_lock_res *lockres,
                filemap_fdatawait(mapping);
        }
 
+out_forget:
        forget_all_cached_acls(inode);
 
 out:
index 1fefb2b..93c7c26 100644 (file)
@@ -1219,9 +1219,13 @@ static int ovl_rename(struct user_namespace *mnt_userns, struct inode *olddir,
                                goto out_dput;
                }
        } else {
-               if (!d_is_negative(newdentry) &&
-                   (!new_opaque || !ovl_is_whiteout(newdentry)))
-                       goto out_dput;
+               if (!d_is_negative(newdentry)) {
+                       if (!new_opaque || !ovl_is_whiteout(newdentry))
+                               goto out_dput;
+               } else {
+                       if (flags & RENAME_EXCHANGE)
+                               goto out_dput;
+               }
        }
 
        if (olddentry == trap)
index d081faa..c88ac57 100644 (file)
@@ -296,6 +296,12 @@ static ssize_t ovl_read_iter(struct kiocb *iocb, struct iov_iter *iter)
        if (ret)
                return ret;
 
+       ret = -EINVAL;
+       if (iocb->ki_flags & IOCB_DIRECT &&
+           (!real.file->f_mapping->a_ops ||
+            !real.file->f_mapping->a_ops->direct_IO))
+               goto out_fdput;
+
        old_cred = ovl_override_creds(file_inode(file)->i_sb);
        if (is_sync_kiocb(iocb)) {
                ret = vfs_iter_read(real.file, iter, &iocb->ki_pos,
@@ -320,7 +326,7 @@ static ssize_t ovl_read_iter(struct kiocb *iocb, struct iov_iter *iter)
 out:
        revert_creds(old_cred);
        ovl_file_accessed(file);
-
+out_fdput:
        fdput(real);
 
        return ret;
@@ -349,6 +355,12 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
        if (ret)
                goto out_unlock;
 
+       ret = -EINVAL;
+       if (iocb->ki_flags & IOCB_DIRECT &&
+           (!real.file->f_mapping->a_ops ||
+            !real.file->f_mapping->a_ops->direct_IO))
+               goto out_fdput;
+
        if (!ovl_should_sync(OVL_FS(inode->i_sb)))
                ifl &= ~(IOCB_DSYNC | IOCB_SYNC);
 
@@ -384,6 +396,7 @@ static ssize_t ovl_write_iter(struct kiocb *iocb, struct iov_iter *iter)
        }
 out:
        revert_creds(old_cred);
+out_fdput:
        fdput(real);
 
 out_unlock:
index a6ee23a..66645a5 100644 (file)
 #include <linux/buffer_head.h>
 #include "qnx4.h"
 
+/*
+ * A qnx4 directory entry is an inode entry or link info
+ * depending on the status field in the last byte. The
+ * first byte is where the name start either way, and a
+ * zero means it's empty.
+ *
+ * Also, due to a bug in gcc, we don't want to use the
+ * real (differently sized) name arrays in the inode and
+ * link entries, but always the 'de_name[]' one in the
+ * fake struct entry.
+ *
+ * See
+ *
+ *   https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99578#c6
+ *
+ * for details, but basically gcc will take the size of the
+ * 'name' array from one of the used union entries randomly.
+ *
+ * This use of 'de_name[]' (48 bytes) avoids the false positive
+ * warnings that would happen if gcc decides to use 'inode.di_name'
+ * (16 bytes) even when the pointer and size were to come from
+ * 'link.dl_name' (48 bytes).
+ *
+ * In all cases the actual name pointer itself is the same, it's
+ * only the gcc internal 'what is the size of this field' logic
+ * that can get confused.
+ */
+union qnx4_directory_entry {
+       struct {
+               const char de_name[48];
+               u8 de_pad[15];
+               u8 de_status;
+       };
+       struct qnx4_inode_entry inode;
+       struct qnx4_link_info link;
+};
+
 static int qnx4_readdir(struct file *file, struct dir_context *ctx)
 {
        struct inode *inode = file_inode(file);
        unsigned int offset;
        struct buffer_head *bh;
-       struct qnx4_inode_entry *de;
-       struct qnx4_link_info *le;
        unsigned long blknum;
        int ix, ino;
        int size;
@@ -38,27 +73,27 @@ static int qnx4_readdir(struct file *file, struct dir_context *ctx)
                }
                ix = (ctx->pos >> QNX4_DIR_ENTRY_SIZE_BITS) % QNX4_INODES_PER_BLOCK;
                for (; ix < QNX4_INODES_PER_BLOCK; ix++, ctx->pos += QNX4_DIR_ENTRY_SIZE) {
+                       union qnx4_directory_entry *de;
+
                        offset = ix * QNX4_DIR_ENTRY_SIZE;
-                       de = (struct qnx4_inode_entry *) (bh->b_data + offset);
-                       if (!de->di_fname[0])
+                       de = (union qnx4_directory_entry *) (bh->b_data + offset);
+
+                       if (!de->de_name[0])
                                continue;
-                       if (!(de->di_status & (QNX4_FILE_USED|QNX4_FILE_LINK)))
+                       if (!(de->de_status & (QNX4_FILE_USED|QNX4_FILE_LINK)))
                                continue;
-                       if (!(de->di_status & QNX4_FILE_LINK))
-                               size = QNX4_SHORT_NAME_MAX;
-                       else
-                               size = QNX4_NAME_MAX;
-                       size = strnlen(de->di_fname, size);
-                       QNX4DEBUG((KERN_INFO "qnx4_readdir:%.*s\n", size, de->di_fname));
-                       if (!(de->di_status & QNX4_FILE_LINK))
+                       if (!(de->de_status & QNX4_FILE_LINK)) {
+                               size = sizeof(de->inode.di_fname);
                                ino = blknum * QNX4_INODES_PER_BLOCK + ix - 1;
-                       else {
-                               le  = (struct qnx4_link_info*)de;
-                               ino = ( le32_to_cpu(le->dl_inode_blk) - 1 ) *
+                       else {
+                               size = sizeof(de->link.dl_fname);
+                               ino = ( le32_to_cpu(de->link.dl_inode_blk) - 1 ) *
                                        QNX4_INODES_PER_BLOCK +
-                                       le->dl_inode_ndx;
+                                       de->link.dl_inode_ndx;
                        }
-                       if (!dir_emit(ctx, de->di_fname, size, ino, DT_UNKNOWN)) {
+                       size = strnlen(de->de_name, size);
+                       QNX4DEBUG((KERN_INFO "qnx4_readdir:%.*s\n", size, name));
+                       if (!dir_emit(ctx, de->de_name, size, ino, DT_UNKNOWN)) {
                                brelse(bh);
                                return 0;
                        }
index d01e8c9..926f87c 100644 (file)
@@ -1,6 +1,6 @@
 /* SPDX-License-Identifier: LGPL-2.1+ */
 /*
- *   fs/cifs/smbfsctl.h: SMB, CIFS, SMB2 FSCTL definitions
+ *   SMB, CIFS, SMB2 FSCTL definitions
  *
  *   Copyright (c) International Business Machines  Corp., 2002,2013
  *   Author(s): Steve French (sfrench@us.ibm.com)
index 4f5e59f..37dd3fe 100644 (file)
 
 #define VBOXSF_SUPER_MAGIC 0x786f4256 /* 'VBox' little endian */
 
-#define VBSF_MOUNT_SIGNATURE_BYTE_0 ('\000')
-#define VBSF_MOUNT_SIGNATURE_BYTE_1 ('\377')
-#define VBSF_MOUNT_SIGNATURE_BYTE_2 ('\376')
-#define VBSF_MOUNT_SIGNATURE_BYTE_3 ('\375')
+static const unsigned char VBSF_MOUNT_SIGNATURE[4] = "\000\377\376\375";
 
 static int follow_symlinks;
 module_param(follow_symlinks, int, 0444);
@@ -386,12 +383,7 @@ fail_nomem:
 
 static int vboxsf_parse_monolithic(struct fs_context *fc, void *data)
 {
-       unsigned char *options = data;
-
-       if (options && options[0] == VBSF_MOUNT_SIGNATURE_BYTE_0 &&
-                      options[1] == VBSF_MOUNT_SIGNATURE_BYTE_1 &&
-                      options[2] == VBSF_MOUNT_SIGNATURE_BYTE_2 &&
-                      options[3] == VBSF_MOUNT_SIGNATURE_BYTE_3) {
+       if (data && !memcmp(data, VBSF_MOUNT_SIGNATURE, 4)) {
                vbg_err("vboxsf: Old binary mount data not supported, remove obsolete mount.vboxsf and/or update your VBoxService.\n");
                return -EINVAL;
        }
index 77e159a..60a4372 100644 (file)
@@ -177,7 +177,7 @@ static int build_merkle_tree(struct file *filp,
         * (level 0) and ascending to the root node (level 'num_levels - 1').
         * Then at the end (level 'num_levels'), calculate the root hash.
         */
-       blocks = (inode->i_size + params->block_size - 1) >>
+       blocks = ((u64)inode->i_size + params->block_size - 1) >>
                 params->log_blocksize;
        for (level = 0; level <= params->num_levels; level++) {
                err = build_merkle_tree_level(filp, level, blocks, params,
index 60ff8af..92df87f 100644 (file)
@@ -89,7 +89,7 @@ int fsverity_init_merkle_tree_params(struct merkle_tree_params *params,
         */
 
        /* Compute number of levels and the number of blocks in each level */
-       blocks = (inode->i_size + params->block_size - 1) >> log_blocksize;
+       blocks = ((u64)inode->i_size + params->block_size - 1) >> log_blocksize;
        pr_debug("Data is %lld bytes (%llu blocks)\n", inode->i_size, blocks);
        while (blocks > 1) {
                if (params->num_levels >= FS_VERITY_MAX_LEVELS) {
index a0212e6..027faa8 100644 (file)
@@ -14,14 +14,6 @@ static inline void __iomem *acpi_os_ioremap(acpi_physical_address phys,
 }
 #endif
 
-#ifndef acpi_os_memmap
-static inline void __iomem *acpi_os_memmap(acpi_physical_address phys,
-                                           acpi_size size)
-{
-       return ioremap_cache(phys, size);
-}
-#endif
-
 extern bool acpi_permanent_mmap;
 
 void __iomem __ref
index e93375c..7ce93aa 100644 (file)
@@ -957,7 +957,7 @@ static inline void __iomem *ioremap(phys_addr_t offset, size_t size)
 
 #ifndef iounmap
 #define iounmap iounmap
-static inline void iounmap(void __iomem *addr)
+static inline void iounmap(volatile void __iomem *addr)
 {
 }
 #endif
@@ -1023,16 +1023,7 @@ static inline void __iomem *ioport_map(unsigned long port, unsigned int nr)
        port &= IO_SPACE_LIMIT;
        return (port > MMIO_UPPER_LIMIT) ? NULL : PCI_IOBASE + port;
 }
-#define __pci_ioport_unmap __pci_ioport_unmap
-static inline void __pci_ioport_unmap(void __iomem *p)
-{
-       uintptr_t start = (uintptr_t) PCI_IOBASE;
-       uintptr_t addr = (uintptr_t) p;
-
-       if (addr >= start && addr < start + IO_SPACE_LIMIT)
-               return;
-       iounmap(p);
-}
+#define ARCH_HAS_GENERIC_IOPORT_MAP
 #endif
 
 #ifndef ioport_unmap
@@ -1048,21 +1039,10 @@ extern void ioport_unmap(void __iomem *p);
 #endif /* CONFIG_HAS_IOPORT_MAP */
 
 #ifndef CONFIG_GENERIC_IOMAP
-struct pci_dev;
-extern void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max);
-
-#ifndef __pci_ioport_unmap
-static inline void __pci_ioport_unmap(void __iomem *p) {}
-#endif
-
 #ifndef pci_iounmap
-#define pci_iounmap pci_iounmap
-static inline void pci_iounmap(struct pci_dev *dev, void __iomem *p)
-{
-       __pci_ioport_unmap(p);
-}
+#define ARCH_WANTS_GENERIC_PCI_IOUNMAP
+#endif
 #endif
-#endif /* CONFIG_GENERIC_IOMAP */
 
 #ifndef xlate_dev_mem_ptr
 #define xlate_dev_mem_ptr xlate_dev_mem_ptr
index 9b3eb6d..08237ae 100644 (file)
@@ -110,16 +110,6 @@ static inline void __iomem *ioremap_np(phys_addr_t offset, size_t size)
 }
 #endif
 
-#ifdef CONFIG_PCI
-/* Destroy a virtual mapping cookie for a PCI BAR (memory or IO) */
-struct pci_dev;
-extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
-#elif defined(CONFIG_GENERIC_IOMAP)
-struct pci_dev;
-static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
-{ }
-#endif
-
 #include <asm-generic/pci_iomap.h>
 
 #endif
index c1ab6a6..d3eae6c 100644 (file)
@@ -197,10 +197,12 @@ static inline int hv_cpu_number_to_vp_number(int cpu_number)
        return hv_vp_index[cpu_number];
 }
 
-static inline int cpumask_to_vpset(struct hv_vpset *vpset,
-                                   const struct cpumask *cpus)
+static inline int __cpumask_to_vpset(struct hv_vpset *vpset,
+                                   const struct cpumask *cpus,
+                                   bool exclude_self)
 {
        int cpu, vcpu, vcpu_bank, vcpu_offset, nr_bank = 1;
+       int this_cpu = smp_processor_id();
 
        /* valid_bank_mask can represent up to 64 banks */
        if (hv_max_vp_index / 64 >= 64)
@@ -218,6 +220,8 @@ static inline int cpumask_to_vpset(struct hv_vpset *vpset,
         * Some banks may end up being empty but this is acceptable.
         */
        for_each_cpu(cpu, cpus) {
+               if (exclude_self && cpu == this_cpu)
+                       continue;
                vcpu = hv_cpu_number_to_vp_number(cpu);
                if (vcpu == VP_INVAL)
                        return -1;
@@ -232,6 +236,19 @@ static inline int cpumask_to_vpset(struct hv_vpset *vpset,
        return nr_bank;
 }
 
+static inline int cpumask_to_vpset(struct hv_vpset *vpset,
+                                   const struct cpumask *cpus)
+{
+       return __cpumask_to_vpset(vpset, cpus, false);
+}
+
+static inline int cpumask_to_vpset_noself(struct hv_vpset *vpset,
+                                   const struct cpumask *cpus)
+{
+       WARN_ON_ONCE(preemptible());
+       return __cpumask_to_vpset(vpset, cpus, true);
+}
+
 void hyperv_report_panic(struct pt_regs *regs, long err, bool in_die);
 bool hv_is_hyperv_initialized(void);
 bool hv_is_hibernation_supported(void);
index df636c6..5a2f9bf 100644 (file)
@@ -18,6 +18,7 @@ extern void __iomem *pci_iomap_range(struct pci_dev *dev, int bar,
 extern void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar,
                                        unsigned long offset,
                                        unsigned long maxlen);
+extern void pci_iounmap(struct pci_dev *dev, void __iomem *);
 /* Create a virtual mapping cookie for a port on a given PCI device.
  * Do not call this directly, it exists to make it easier for architectures
  * to override */
@@ -50,6 +51,8 @@ static inline void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar,
 {
        return NULL;
 }
+static inline void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
+{ }
 #endif
 
 #endif /* __ASM_GENERIC_PCI_IOMAP_H */
index aa50bf2..f2984af 100644 (file)
  * GCC 4.5 and later have a 32 bytes section alignment for structures.
  * Except GCC 4.9, that feels the need to align on 64 bytes.
  */
-#if __GNUC__ == 4 && __GNUC_MINOR__ == 9
-#define STRUCT_ALIGNMENT 64
-#else
 #define STRUCT_ALIGNMENT 32
-#endif
 #define STRUCT_ALIGN() . = ALIGN(STRUCT_ALIGNMENT)
 
 /*
diff --git a/include/dt-bindings/soc/qcom,gpr.h b/include/dt-bindings/soc/qcom,gpr.h
new file mode 100644 (file)
index 0000000..3107da5
--- /dev/null
@@ -0,0 +1,19 @@
+/* SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause */
+
+#ifndef __DT_BINDINGS_QCOM_GPR_H
+#define __DT_BINDINGS_QCOM_GPR_H
+
+/* DOMAINS */
+
+#define GPR_DOMAIN_ID_MODEM    1
+#define GPR_DOMAIN_ID_ADSP     2
+#define GPR_DOMAIN_ID_APPS     3
+
+/* Static Services */
+
+#define GPR_APM_MODULE_IID             1
+#define GPR_PRM_MODULE_IID             2
+#define GPR_AMDB_MODULE_IID            3
+#define GPR_VCPM_MODULE_IID            4
+
+#endif /* __DT_BINDINGS_QCOM_GPR_H */
index 7b0b80b..a9404c3 100644 (file)
 
 #define LPASS_DP_RX    5
 
+#define LPASS_CDC_DMA_RX0 6
+#define LPASS_CDC_DMA_RX1 7
+#define LPASS_CDC_DMA_RX2 8
+#define LPASS_CDC_DMA_RX3 9
+#define LPASS_CDC_DMA_RX4 10
+#define LPASS_CDC_DMA_RX5 11
+#define LPASS_CDC_DMA_RX6 12
+#define LPASS_CDC_DMA_RX7 13
+#define LPASS_CDC_DMA_RX8 14
+#define LPASS_CDC_DMA_RX9 15
+
+#define LPASS_CDC_DMA_TX0 16
+#define LPASS_CDC_DMA_TX1 17
+#define LPASS_CDC_DMA_TX2 18
+#define LPASS_CDC_DMA_TX3 19
+#define LPASS_CDC_DMA_TX4 20
+#define LPASS_CDC_DMA_TX5 21
+#define LPASS_CDC_DMA_TX6 22
+#define LPASS_CDC_DMA_TX7 23
+#define LPASS_CDC_DMA_TX8 24
+
+#define LPASS_CDC_DMA_VA_TX0 25
+#define LPASS_CDC_DMA_VA_TX1 26
+#define LPASS_CDC_DMA_VA_TX2 27
+#define LPASS_CDC_DMA_VA_TX3 28
+#define LPASS_CDC_DMA_VA_TX4 29
+#define LPASS_CDC_DMA_VA_TX5 30
+#define LPASS_CDC_DMA_VA_TX6 31
+#define LPASS_CDC_DMA_VA_TX7 32
+#define LPASS_CDC_DMA_VA_TX8 33
+
 #define LPASS_MCLK0    0
 
 #endif /* __DT_QCOM_LPASS_H */
index 66c21ab..9d5d89c 100644 (file)
@@ -2,207 +2,8 @@
 #ifndef __DT_BINDINGS_Q6_AFE_H__
 #define __DT_BINDINGS_Q6_AFE_H__
 
-/* Audio Front End (AFE) virtual ports IDs */
-#define HDMI_RX                1
-#define SLIMBUS_0_RX    2
-#define SLIMBUS_0_TX    3
-#define SLIMBUS_1_RX    4
-#define SLIMBUS_1_TX    5
-#define SLIMBUS_2_RX    6
-#define SLIMBUS_2_TX    7
-#define SLIMBUS_3_RX    8
-#define SLIMBUS_3_TX    9
-#define SLIMBUS_4_RX    10
-#define SLIMBUS_4_TX    11
-#define SLIMBUS_5_RX    12
-#define SLIMBUS_5_TX    13
-#define SLIMBUS_6_RX    14
-#define SLIMBUS_6_TX    15
-#define PRIMARY_MI2S_RX                16
-#define PRIMARY_MI2S_TX                17
-#define SECONDARY_MI2S_RX      18
-#define SECONDARY_MI2S_TX      19
-#define TERTIARY_MI2S_RX       20
-#define TERTIARY_MI2S_TX       21
-#define QUATERNARY_MI2S_RX     22
-#define QUATERNARY_MI2S_TX     23
-#define PRIMARY_TDM_RX_0       24
-#define PRIMARY_TDM_TX_0       25
-#define PRIMARY_TDM_RX_1       26
-#define PRIMARY_TDM_TX_1       27
-#define PRIMARY_TDM_RX_2       28
-#define PRIMARY_TDM_TX_2       29
-#define PRIMARY_TDM_RX_3       30
-#define PRIMARY_TDM_TX_3       31
-#define PRIMARY_TDM_RX_4       32
-#define PRIMARY_TDM_TX_4       33
-#define PRIMARY_TDM_RX_5       34
-#define PRIMARY_TDM_TX_5       35
-#define PRIMARY_TDM_RX_6       36
-#define PRIMARY_TDM_TX_6       37
-#define PRIMARY_TDM_RX_7       38
-#define PRIMARY_TDM_TX_7       39
-#define SECONDARY_TDM_RX_0     40
-#define SECONDARY_TDM_TX_0     41
-#define SECONDARY_TDM_RX_1     42
-#define SECONDARY_TDM_TX_1     43
-#define SECONDARY_TDM_RX_2     44
-#define SECONDARY_TDM_TX_2     45
-#define SECONDARY_TDM_RX_3     46
-#define SECONDARY_TDM_TX_3     47
-#define SECONDARY_TDM_RX_4     48
-#define SECONDARY_TDM_TX_4     49
-#define SECONDARY_TDM_RX_5     50
-#define SECONDARY_TDM_TX_5     51
-#define SECONDARY_TDM_RX_6     52
-#define SECONDARY_TDM_TX_6     53
-#define SECONDARY_TDM_RX_7     54
-#define SECONDARY_TDM_TX_7     55
-#define TERTIARY_TDM_RX_0      56
-#define TERTIARY_TDM_TX_0      57
-#define TERTIARY_TDM_RX_1      58
-#define TERTIARY_TDM_TX_1      59
-#define TERTIARY_TDM_RX_2      60
-#define TERTIARY_TDM_TX_2      61
-#define TERTIARY_TDM_RX_3      62
-#define TERTIARY_TDM_TX_3      63
-#define TERTIARY_TDM_RX_4      64
-#define TERTIARY_TDM_TX_4      65
-#define TERTIARY_TDM_RX_5      66
-#define TERTIARY_TDM_TX_5      67
-#define TERTIARY_TDM_RX_6      68
-#define TERTIARY_TDM_TX_6      69
-#define TERTIARY_TDM_RX_7      70
-#define TERTIARY_TDM_TX_7      71
-#define QUATERNARY_TDM_RX_0    72
-#define QUATERNARY_TDM_TX_0    73
-#define QUATERNARY_TDM_RX_1    74
-#define QUATERNARY_TDM_TX_1    75
-#define QUATERNARY_TDM_RX_2    76
-#define QUATERNARY_TDM_TX_2    77
-#define QUATERNARY_TDM_RX_3    78
-#define QUATERNARY_TDM_TX_3    79
-#define QUATERNARY_TDM_RX_4    80
-#define QUATERNARY_TDM_TX_4    81
-#define QUATERNARY_TDM_RX_5    82
-#define QUATERNARY_TDM_TX_5    83
-#define QUATERNARY_TDM_RX_6    84
-#define QUATERNARY_TDM_TX_6    85
-#define QUATERNARY_TDM_RX_7    86
-#define QUATERNARY_TDM_TX_7    87
-#define QUINARY_TDM_RX_0       88
-#define QUINARY_TDM_TX_0       89
-#define QUINARY_TDM_RX_1       90
-#define QUINARY_TDM_TX_1       91
-#define QUINARY_TDM_RX_2       92
-#define QUINARY_TDM_TX_2       93
-#define QUINARY_TDM_RX_3       94
-#define QUINARY_TDM_TX_3       95
-#define QUINARY_TDM_RX_4       96
-#define QUINARY_TDM_TX_4       97
-#define QUINARY_TDM_RX_5       98
-#define QUINARY_TDM_TX_5       99
-#define QUINARY_TDM_RX_6       100
-#define QUINARY_TDM_TX_6       101
-#define QUINARY_TDM_RX_7       102
-#define QUINARY_TDM_TX_7       103
-#define DISPLAY_PORT_RX                104
-#define WSA_CODEC_DMA_RX_0     105
-#define WSA_CODEC_DMA_TX_0     106
-#define WSA_CODEC_DMA_RX_1     107
-#define WSA_CODEC_DMA_TX_1     108
-#define WSA_CODEC_DMA_TX_2     109
-#define VA_CODEC_DMA_TX_0      110
-#define VA_CODEC_DMA_TX_1      111
-#define VA_CODEC_DMA_TX_2      112
-#define RX_CODEC_DMA_RX_0      113
-#define TX_CODEC_DMA_TX_0      114
-#define RX_CODEC_DMA_RX_1      115
-#define TX_CODEC_DMA_TX_1      116
-#define RX_CODEC_DMA_RX_2      117
-#define TX_CODEC_DMA_TX_2      118
-#define RX_CODEC_DMA_RX_3      119
-#define TX_CODEC_DMA_TX_3      120
-#define RX_CODEC_DMA_RX_4      121
-#define TX_CODEC_DMA_TX_4      122
-#define RX_CODEC_DMA_RX_5      123
-#define TX_CODEC_DMA_TX_5      124
-#define RX_CODEC_DMA_RX_6      125
-#define RX_CODEC_DMA_RX_7      126
-#define QUINARY_MI2S_RX                127
-#define QUINARY_MI2S_TX                128
+/* This file exists due to backward compatibility reasons, Please do not DELETE! */
 
-#define LPASS_CLK_ID_PRI_MI2S_IBIT     1
-#define LPASS_CLK_ID_PRI_MI2S_EBIT     2
-#define LPASS_CLK_ID_SEC_MI2S_IBIT     3
-#define LPASS_CLK_ID_SEC_MI2S_EBIT     4
-#define LPASS_CLK_ID_TER_MI2S_IBIT     5
-#define LPASS_CLK_ID_TER_MI2S_EBIT     6
-#define LPASS_CLK_ID_QUAD_MI2S_IBIT    7
-#define LPASS_CLK_ID_QUAD_MI2S_EBIT    8
-#define LPASS_CLK_ID_SPEAKER_I2S_IBIT  9
-#define LPASS_CLK_ID_SPEAKER_I2S_EBIT  10
-#define LPASS_CLK_ID_SPEAKER_I2S_OSR   11
-#define LPASS_CLK_ID_QUI_MI2S_IBIT     12
-#define LPASS_CLK_ID_QUI_MI2S_EBIT     13
-#define LPASS_CLK_ID_SEN_MI2S_IBIT     14
-#define LPASS_CLK_ID_SEN_MI2S_EBIT     15
-#define LPASS_CLK_ID_INT0_MI2S_IBIT    16
-#define LPASS_CLK_ID_INT1_MI2S_IBIT    17
-#define LPASS_CLK_ID_INT2_MI2S_IBIT    18
-#define LPASS_CLK_ID_INT3_MI2S_IBIT    19
-#define LPASS_CLK_ID_INT4_MI2S_IBIT    20
-#define LPASS_CLK_ID_INT5_MI2S_IBIT    21
-#define LPASS_CLK_ID_INT6_MI2S_IBIT    22
-#define LPASS_CLK_ID_QUI_MI2S_OSR      23
-#define LPASS_CLK_ID_PRI_PCM_IBIT      24
-#define LPASS_CLK_ID_PRI_PCM_EBIT      25
-#define LPASS_CLK_ID_SEC_PCM_IBIT      26
-#define LPASS_CLK_ID_SEC_PCM_EBIT      27
-#define LPASS_CLK_ID_TER_PCM_IBIT      28
-#define LPASS_CLK_ID_TER_PCM_EBIT      29
-#define LPASS_CLK_ID_QUAD_PCM_IBIT     30
-#define LPASS_CLK_ID_QUAD_PCM_EBIT     31
-#define LPASS_CLK_ID_QUIN_PCM_IBIT     32
-#define LPASS_CLK_ID_QUIN_PCM_EBIT     33
-#define LPASS_CLK_ID_QUI_PCM_OSR       34
-#define LPASS_CLK_ID_PRI_TDM_IBIT      35
-#define LPASS_CLK_ID_PRI_TDM_EBIT      36
-#define LPASS_CLK_ID_SEC_TDM_IBIT      37
-#define LPASS_CLK_ID_SEC_TDM_EBIT      38
-#define LPASS_CLK_ID_TER_TDM_IBIT      39
-#define LPASS_CLK_ID_TER_TDM_EBIT      40
-#define LPASS_CLK_ID_QUAD_TDM_IBIT     41
-#define LPASS_CLK_ID_QUAD_TDM_EBIT     42
-#define LPASS_CLK_ID_QUIN_TDM_IBIT     43
-#define LPASS_CLK_ID_QUIN_TDM_EBIT     44
-#define LPASS_CLK_ID_QUIN_TDM_OSR      45
-#define LPASS_CLK_ID_MCLK_1            46
-#define LPASS_CLK_ID_MCLK_2            47
-#define LPASS_CLK_ID_MCLK_3            48
-#define LPASS_CLK_ID_MCLK_4            49
-#define LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE       50
-#define LPASS_CLK_ID_INT_MCLK_0                51
-#define LPASS_CLK_ID_INT_MCLK_1                52
-#define LPASS_CLK_ID_MCLK_5            53
-#define LPASS_CLK_ID_WSA_CORE_MCLK     54
-#define LPASS_CLK_ID_WSA_CORE_NPL_MCLK 55
-#define LPASS_CLK_ID_VA_CORE_MCLK      56
-#define LPASS_CLK_ID_TX_CORE_MCLK      57
-#define LPASS_CLK_ID_TX_CORE_NPL_MCLK  58
-#define LPASS_CLK_ID_RX_CORE_MCLK      59
-#define LPASS_CLK_ID_RX_CORE_NPL_MCLK  60
-#define LPASS_CLK_ID_VA_CORE_2X_MCLK   61
-
-#define LPASS_HW_AVTIMER_VOTE          101
-#define LPASS_HW_MACRO_VOTE            102
-#define LPASS_HW_DCODEC_VOTE           103
-
-#define Q6AFE_MAX_CLK_ID                       104
-
-#define LPASS_CLK_ATTRIBUTE_INVALID            0x0
-#define LPASS_CLK_ATTRIBUTE_COUPLE_NO          0x1
-#define LPASS_CLK_ATTRIBUTE_COUPLE_DIVIDEND    0x2
-#define LPASS_CLK_ATTRIBUTE_COUPLE_DIVISOR     0x3
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
 
 #endif /* __DT_BINDINGS_Q6_AFE_H__ */
diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
new file mode 100644 (file)
index 0000000..0d3276c
--- /dev/null
@@ -0,0 +1,208 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __DT_BINDINGS_Q6_AUDIO_PORTS_H__
+#define __DT_BINDINGS_Q6_AUDIO_PORTS_H__
+
+/* LPASS Audio virtual ports IDs */
+#define HDMI_RX                1
+#define SLIMBUS_0_RX    2
+#define SLIMBUS_0_TX    3
+#define SLIMBUS_1_RX    4
+#define SLIMBUS_1_TX    5
+#define SLIMBUS_2_RX    6
+#define SLIMBUS_2_TX    7
+#define SLIMBUS_3_RX    8
+#define SLIMBUS_3_TX    9
+#define SLIMBUS_4_RX    10
+#define SLIMBUS_4_TX    11
+#define SLIMBUS_5_RX    12
+#define SLIMBUS_5_TX    13
+#define SLIMBUS_6_RX    14
+#define SLIMBUS_6_TX    15
+#define PRIMARY_MI2S_RX                16
+#define PRIMARY_MI2S_TX                17
+#define SECONDARY_MI2S_RX      18
+#define SECONDARY_MI2S_TX      19
+#define TERTIARY_MI2S_RX       20
+#define TERTIARY_MI2S_TX       21
+#define QUATERNARY_MI2S_RX     22
+#define QUATERNARY_MI2S_TX     23
+#define PRIMARY_TDM_RX_0       24
+#define PRIMARY_TDM_TX_0       25
+#define PRIMARY_TDM_RX_1       26
+#define PRIMARY_TDM_TX_1       27
+#define PRIMARY_TDM_RX_2       28
+#define PRIMARY_TDM_TX_2       29
+#define PRIMARY_TDM_RX_3       30
+#define PRIMARY_TDM_TX_3       31
+#define PRIMARY_TDM_RX_4       32
+#define PRIMARY_TDM_TX_4       33
+#define PRIMARY_TDM_RX_5       34
+#define PRIMARY_TDM_TX_5       35
+#define PRIMARY_TDM_RX_6       36
+#define PRIMARY_TDM_TX_6       37
+#define PRIMARY_TDM_RX_7       38
+#define PRIMARY_TDM_TX_7       39
+#define SECONDARY_TDM_RX_0     40
+#define SECONDARY_TDM_TX_0     41
+#define SECONDARY_TDM_RX_1     42
+#define SECONDARY_TDM_TX_1     43
+#define SECONDARY_TDM_RX_2     44
+#define SECONDARY_TDM_TX_2     45
+#define SECONDARY_TDM_RX_3     46
+#define SECONDARY_TDM_TX_3     47
+#define SECONDARY_TDM_RX_4     48
+#define SECONDARY_TDM_TX_4     49
+#define SECONDARY_TDM_RX_5     50
+#define SECONDARY_TDM_TX_5     51
+#define SECONDARY_TDM_RX_6     52
+#define SECONDARY_TDM_TX_6     53
+#define SECONDARY_TDM_RX_7     54
+#define SECONDARY_TDM_TX_7     55
+#define TERTIARY_TDM_RX_0      56
+#define TERTIARY_TDM_TX_0      57
+#define TERTIARY_TDM_RX_1      58
+#define TERTIARY_TDM_TX_1      59
+#define TERTIARY_TDM_RX_2      60
+#define TERTIARY_TDM_TX_2      61
+#define TERTIARY_TDM_RX_3      62
+#define TERTIARY_TDM_TX_3      63
+#define TERTIARY_TDM_RX_4      64
+#define TERTIARY_TDM_TX_4      65
+#define TERTIARY_TDM_RX_5      66
+#define TERTIARY_TDM_TX_5      67
+#define TERTIARY_TDM_RX_6      68
+#define TERTIARY_TDM_TX_6      69
+#define TERTIARY_TDM_RX_7      70
+#define TERTIARY_TDM_TX_7      71
+#define QUATERNARY_TDM_RX_0    72
+#define QUATERNARY_TDM_TX_0    73
+#define QUATERNARY_TDM_RX_1    74
+#define QUATERNARY_TDM_TX_1    75
+#define QUATERNARY_TDM_RX_2    76
+#define QUATERNARY_TDM_TX_2    77
+#define QUATERNARY_TDM_RX_3    78
+#define QUATERNARY_TDM_TX_3    79
+#define QUATERNARY_TDM_RX_4    80
+#define QUATERNARY_TDM_TX_4    81
+#define QUATERNARY_TDM_RX_5    82
+#define QUATERNARY_TDM_TX_5    83
+#define QUATERNARY_TDM_RX_6    84
+#define QUATERNARY_TDM_TX_6    85
+#define QUATERNARY_TDM_RX_7    86
+#define QUATERNARY_TDM_TX_7    87
+#define QUINARY_TDM_RX_0       88
+#define QUINARY_TDM_TX_0       89
+#define QUINARY_TDM_RX_1       90
+#define QUINARY_TDM_TX_1       91
+#define QUINARY_TDM_RX_2       92
+#define QUINARY_TDM_TX_2       93
+#define QUINARY_TDM_RX_3       94
+#define QUINARY_TDM_TX_3       95
+#define QUINARY_TDM_RX_4       96
+#define QUINARY_TDM_TX_4       97
+#define QUINARY_TDM_RX_5       98
+#define QUINARY_TDM_TX_5       99
+#define QUINARY_TDM_RX_6       100
+#define QUINARY_TDM_TX_6       101
+#define QUINARY_TDM_RX_7       102
+#define QUINARY_TDM_TX_7       103
+#define DISPLAY_PORT_RX                104
+#define WSA_CODEC_DMA_RX_0     105
+#define WSA_CODEC_DMA_TX_0     106
+#define WSA_CODEC_DMA_RX_1     107
+#define WSA_CODEC_DMA_TX_1     108
+#define WSA_CODEC_DMA_TX_2     109
+#define VA_CODEC_DMA_TX_0      110
+#define VA_CODEC_DMA_TX_1      111
+#define VA_CODEC_DMA_TX_2      112
+#define RX_CODEC_DMA_RX_0      113
+#define TX_CODEC_DMA_TX_0      114
+#define RX_CODEC_DMA_RX_1      115
+#define TX_CODEC_DMA_TX_1      116
+#define RX_CODEC_DMA_RX_2      117
+#define TX_CODEC_DMA_TX_2      118
+#define RX_CODEC_DMA_RX_3      119
+#define TX_CODEC_DMA_TX_3      120
+#define RX_CODEC_DMA_RX_4      121
+#define TX_CODEC_DMA_TX_4      122
+#define RX_CODEC_DMA_RX_5      123
+#define TX_CODEC_DMA_TX_5      124
+#define RX_CODEC_DMA_RX_6      125
+#define RX_CODEC_DMA_RX_7      126
+#define QUINARY_MI2S_RX                127
+#define QUINARY_MI2S_TX                128
+
+#define LPASS_CLK_ID_PRI_MI2S_IBIT     1
+#define LPASS_CLK_ID_PRI_MI2S_EBIT     2
+#define LPASS_CLK_ID_SEC_MI2S_IBIT     3
+#define LPASS_CLK_ID_SEC_MI2S_EBIT     4
+#define LPASS_CLK_ID_TER_MI2S_IBIT     5
+#define LPASS_CLK_ID_TER_MI2S_EBIT     6
+#define LPASS_CLK_ID_QUAD_MI2S_IBIT    7
+#define LPASS_CLK_ID_QUAD_MI2S_EBIT    8
+#define LPASS_CLK_ID_SPEAKER_I2S_IBIT  9
+#define LPASS_CLK_ID_SPEAKER_I2S_EBIT  10
+#define LPASS_CLK_ID_SPEAKER_I2S_OSR   11
+#define LPASS_CLK_ID_QUI_MI2S_IBIT     12
+#define LPASS_CLK_ID_QUI_MI2S_EBIT     13
+#define LPASS_CLK_ID_SEN_MI2S_IBIT     14
+#define LPASS_CLK_ID_SEN_MI2S_EBIT     15
+#define LPASS_CLK_ID_INT0_MI2S_IBIT    16
+#define LPASS_CLK_ID_INT1_MI2S_IBIT    17
+#define LPASS_CLK_ID_INT2_MI2S_IBIT    18
+#define LPASS_CLK_ID_INT3_MI2S_IBIT    19
+#define LPASS_CLK_ID_INT4_MI2S_IBIT    20
+#define LPASS_CLK_ID_INT5_MI2S_IBIT    21
+#define LPASS_CLK_ID_INT6_MI2S_IBIT    22
+#define LPASS_CLK_ID_QUI_MI2S_OSR      23
+#define LPASS_CLK_ID_PRI_PCM_IBIT      24
+#define LPASS_CLK_ID_PRI_PCM_EBIT      25
+#define LPASS_CLK_ID_SEC_PCM_IBIT      26
+#define LPASS_CLK_ID_SEC_PCM_EBIT      27
+#define LPASS_CLK_ID_TER_PCM_IBIT      28
+#define LPASS_CLK_ID_TER_PCM_EBIT      29
+#define LPASS_CLK_ID_QUAD_PCM_IBIT     30
+#define LPASS_CLK_ID_QUAD_PCM_EBIT     31
+#define LPASS_CLK_ID_QUIN_PCM_IBIT     32
+#define LPASS_CLK_ID_QUIN_PCM_EBIT     33
+#define LPASS_CLK_ID_QUI_PCM_OSR       34
+#define LPASS_CLK_ID_PRI_TDM_IBIT      35
+#define LPASS_CLK_ID_PRI_TDM_EBIT      36
+#define LPASS_CLK_ID_SEC_TDM_IBIT      37
+#define LPASS_CLK_ID_SEC_TDM_EBIT      38
+#define LPASS_CLK_ID_TER_TDM_IBIT      39
+#define LPASS_CLK_ID_TER_TDM_EBIT      40
+#define LPASS_CLK_ID_QUAD_TDM_IBIT     41
+#define LPASS_CLK_ID_QUAD_TDM_EBIT     42
+#define LPASS_CLK_ID_QUIN_TDM_IBIT     43
+#define LPASS_CLK_ID_QUIN_TDM_EBIT     44
+#define LPASS_CLK_ID_QUIN_TDM_OSR      45
+#define LPASS_CLK_ID_MCLK_1            46
+#define LPASS_CLK_ID_MCLK_2            47
+#define LPASS_CLK_ID_MCLK_3            48
+#define LPASS_CLK_ID_MCLK_4            49
+#define LPASS_CLK_ID_INTERNAL_DIGITAL_CODEC_CORE       50
+#define LPASS_CLK_ID_INT_MCLK_0                51
+#define LPASS_CLK_ID_INT_MCLK_1                52
+#define LPASS_CLK_ID_MCLK_5            53
+#define LPASS_CLK_ID_WSA_CORE_MCLK     54
+#define LPASS_CLK_ID_WSA_CORE_NPL_MCLK 55
+#define LPASS_CLK_ID_VA_CORE_MCLK      56
+#define LPASS_CLK_ID_TX_CORE_MCLK      57
+#define LPASS_CLK_ID_TX_CORE_NPL_MCLK  58
+#define LPASS_CLK_ID_RX_CORE_MCLK      59
+#define LPASS_CLK_ID_RX_CORE_NPL_MCLK  60
+#define LPASS_CLK_ID_VA_CORE_2X_MCLK   61
+
+#define LPASS_HW_AVTIMER_VOTE          101
+#define LPASS_HW_MACRO_VOTE            102
+#define LPASS_HW_DCODEC_VOTE           103
+
+#define Q6AFE_MAX_CLK_ID                       104
+
+#define LPASS_CLK_ATTRIBUTE_INVALID            0x0
+#define LPASS_CLK_ATTRIBUTE_COUPLE_NO          0x1
+#define LPASS_CLK_ATTRIBUTE_COUPLE_DIVIDEND    0x2
+#define LPASS_CLK_ATTRIBUTE_COUPLE_DIVISOR     0x3
+
+#endif /* __DT_BINDINGS_Q6_AUDIO_PORTS_H__ */
index 24b40e5..018e776 100644 (file)
@@ -613,7 +613,7 @@ void kunit_remove_resource(struct kunit *test, struct kunit_resource *res);
  * and is automatically cleaned up after the test case concludes. See &struct
  * kunit_resource for more information.
  */
-void *kunit_kmalloc_array(struct kunit *test, size_t n, size_t size, gfp_t flags);
+void *kunit_kmalloc_array(struct kunit *test, size_t n, size_t size, gfp_t gfp);
 
 /**
  * kunit_kmalloc() - Like kmalloc() except the allocation is *test managed*.
@@ -657,9 +657,9 @@ static inline void *kunit_kzalloc(struct kunit *test, size_t size, gfp_t gfp)
  *
  * See kcalloc() and kunit_kmalloc_array() for more information.
  */
-static inline void *kunit_kcalloc(struct kunit *test, size_t n, size_t size, gfp_t flags)
+static inline void *kunit_kcalloc(struct kunit *test, size_t n, size_t size, gfp_t gfp)
 {
-       return kunit_kmalloc_array(test, n, size, flags | __GFP_ZERO);
+       return kunit_kmalloc_array(test, n, size, gfp | __GFP_ZERO);
 }
 
 void kunit_cleanup(struct kunit *test);
index 864b999..90f2189 100644 (file)
@@ -61,7 +61,6 @@ int kvm_arm_pmu_v3_get_attr(struct kvm_vcpu *vcpu,
 int kvm_arm_pmu_v3_has_attr(struct kvm_vcpu *vcpu,
                            struct kvm_device_attr *attr);
 int kvm_arm_pmu_v3_enable(struct kvm_vcpu *vcpu);
-int kvm_pmu_probe_pmuver(void);
 #else
 struct kvm_pmu {
 };
@@ -118,8 +117,6 @@ static inline u64 kvm_pmu_get_pmceid(struct kvm_vcpu *vcpu, bool pmceid1)
        return 0;
 }
 
-static inline int kvm_pmu_probe_pmuver(void) { return 0xf; }
-
 #endif
 
 #endif
index 7d1cabe..63ccb52 100644 (file)
@@ -321,10 +321,20 @@ asmlinkage unsigned long __arm_smccc_sve_check(unsigned long x0);
  * from register 0 to 3 on return from the SMC instruction.  An optional
  * quirk structure provides vendor specific behavior.
  */
+#ifdef CONFIG_HAVE_ARM_SMCCC
 asmlinkage void __arm_smccc_smc(unsigned long a0, unsigned long a1,
                        unsigned long a2, unsigned long a3, unsigned long a4,
                        unsigned long a5, unsigned long a6, unsigned long a7,
                        struct arm_smccc_res *res, struct arm_smccc_quirk *quirk);
+#else
+static inline void __arm_smccc_smc(unsigned long a0, unsigned long a1,
+                       unsigned long a2, unsigned long a3, unsigned long a4,
+                       unsigned long a5, unsigned long a6, unsigned long a7,
+                       struct arm_smccc_res *res, struct arm_smccc_quirk *quirk)
+{
+       *res = (struct arm_smccc_res){};
+}
+#endif
 
 /**
  * __arm_smccc_hvc() - make HVC calls
index f4c16f1..020a7d5 100644 (file)
@@ -578,11 +578,12 @@ struct btf_func_model {
  * programs only. Should not be used with normal calls and indirect calls.
  */
 #define BPF_TRAMP_F_SKIP_FRAME         BIT(2)
-
 /* Store IP address of the caller on the trampoline stack,
  * so it's available for trampoline's programs.
  */
 #define BPF_TRAMP_F_IP_ARG             BIT(3)
+/* Return the return value of fentry prog. Only used by bpf_struct_ops. */
+#define BPF_TRAMP_F_RET_FENTRY_RET     BIT(4)
 
 /* Each call __bpf_prog_enter + call bpf_func + call __bpf_prog_exit is ~50
  * bytes on x86.  Pick a number to fit into BPF_IMAGE_SIZE / 2
index 6486d3c..36f3368 100644 (file)
@@ -194,7 +194,7 @@ void __breadahead_gfp(struct block_device *, sector_t block, unsigned int size,
 struct buffer_head *__bread_gfp(struct block_device *,
                                sector_t block, unsigned size, gfp_t gfp);
 void invalidate_bh_lrus(void);
-void invalidate_bh_lrus_cpu(int cpu);
+void invalidate_bh_lrus_cpu(void);
 bool has_bh_in_lru(int cpu, void *dummy);
 struct buffer_head *alloc_buffer_head(gfp_t gfp_flags);
 void free_buffer_head(struct buffer_head * bh);
@@ -408,7 +408,7 @@ static inline int inode_has_buffers(struct inode *inode) { return 0; }
 static inline void invalidate_inode_buffers(struct inode *inode) {}
 static inline int remove_inode_buffers(struct inode *inode) { return 1; }
 static inline int sync_mapping_buffers(struct address_space *mapping) { return 0; }
-static inline void invalidate_bh_lrus_cpu(int cpu) {}
+static inline void invalidate_bh_lrus_cpu(void) {}
 static inline bool has_bh_in_lru(int cpu, void *dummy) { return false; }
 #define buffer_heads_over_limit 0
 
index e1c705f..db2e147 100644 (file)
@@ -752,107 +752,54 @@ static inline void cgroup_threadgroup_change_end(struct task_struct *tsk) {}
  * sock_cgroup_data is embedded at sock->sk_cgrp_data and contains
  * per-socket cgroup information except for memcg association.
  *
- * On legacy hierarchies, net_prio and net_cls controllers directly set
- * attributes on each sock which can then be tested by the network layer.
- * On the default hierarchy, each sock is associated with the cgroup it was
- * created in and the networking layer can match the cgroup directly.
- *
- * To avoid carrying all three cgroup related fields separately in sock,
- * sock_cgroup_data overloads (prioidx, classid) and the cgroup pointer.
- * On boot, sock_cgroup_data records the cgroup that the sock was created
- * in so that cgroup2 matches can be made; however, once either net_prio or
- * net_cls starts being used, the area is overridden to carry prioidx and/or
- * classid.  The two modes are distinguished by whether the lowest bit is
- * set.  Clear bit indicates cgroup pointer while set bit prioidx and
- * classid.
- *
- * While userland may start using net_prio or net_cls at any time, once
- * either is used, cgroup2 matching no longer works.  There is no reason to
- * mix the two and this is in line with how legacy and v2 compatibility is
- * handled.  On mode switch, cgroup references which are already being
- * pointed to by socks may be leaked.  While this can be remedied by adding
- * synchronization around sock_cgroup_data, given that the number of leaked
- * cgroups is bound and highly unlikely to be high, this seems to be the
- * better trade-off.
+ * On legacy hierarchies, net_prio and net_cls controllers directly
+ * set attributes on each sock which can then be tested by the network
+ * layer. On the default hierarchy, each sock is associated with the
+ * cgroup it was created in and the networking layer can match the
+ * cgroup directly.
  */
 struct sock_cgroup_data {
-       union {
-#ifdef __LITTLE_ENDIAN
-               struct {
-                       u8      is_data : 1;
-                       u8      no_refcnt : 1;
-                       u8      unused : 6;
-                       u8      padding;
-                       u16     prioidx;
-                       u32     classid;
-               } __packed;
-#else
-               struct {
-                       u32     classid;
-                       u16     prioidx;
-                       u8      padding;
-                       u8      unused : 6;
-                       u8      no_refcnt : 1;
-                       u8      is_data : 1;
-               } __packed;
+       struct cgroup   *cgroup; /* v2 */
+#ifdef CONFIG_CGROUP_NET_CLASSID
+       u32             classid; /* v1 */
+#endif
+#ifdef CONFIG_CGROUP_NET_PRIO
+       u16             prioidx; /* v1 */
 #endif
-               u64             val;
-       };
 };
 
-/*
- * There's a theoretical window where the following accessors race with
- * updaters and return part of the previous pointer as the prioidx or
- * classid.  Such races are short-lived and the result isn't critical.
- */
 static inline u16 sock_cgroup_prioidx(const struct sock_cgroup_data *skcd)
 {
-       /* fallback to 1 which is always the ID of the root cgroup */
-       return (skcd->is_data & 1) ? skcd->prioidx : 1;
+#ifdef CONFIG_CGROUP_NET_PRIO
+       return READ_ONCE(skcd->prioidx);
+#else
+       return 1;
+#endif
 }
 
 static inline u32 sock_cgroup_classid(const struct sock_cgroup_data *skcd)
 {
-       /* fallback to 0 which is the unconfigured default classid */
-       return (skcd->is_data & 1) ? skcd->classid : 0;
+#ifdef CONFIG_CGROUP_NET_CLASSID
+       return READ_ONCE(skcd->classid);
+#else
+       return 0;
+#endif
 }
 
-/*
- * If invoked concurrently, the updaters may clobber each other.  The
- * caller is responsible for synchronization.
- */
 static inline void sock_cgroup_set_prioidx(struct sock_cgroup_data *skcd,
                                           u16 prioidx)
 {
-       struct sock_cgroup_data skcd_buf = {{ .val = READ_ONCE(skcd->val) }};
-
-       if (sock_cgroup_prioidx(&skcd_buf) == prioidx)
-               return;
-
-       if (!(skcd_buf.is_data & 1)) {
-               skcd_buf.val = 0;
-               skcd_buf.is_data = 1;
-       }
-
-       skcd_buf.prioidx = prioidx;
-       WRITE_ONCE(skcd->val, skcd_buf.val);    /* see sock_cgroup_ptr() */
+#ifdef CONFIG_CGROUP_NET_PRIO
+       WRITE_ONCE(skcd->prioidx, prioidx);
+#endif
 }
 
 static inline void sock_cgroup_set_classid(struct sock_cgroup_data *skcd,
                                           u32 classid)
 {
-       struct sock_cgroup_data skcd_buf = {{ .val = READ_ONCE(skcd->val) }};
-
-       if (sock_cgroup_classid(&skcd_buf) == classid)
-               return;
-
-       if (!(skcd_buf.is_data & 1)) {
-               skcd_buf.val = 0;
-               skcd_buf.is_data = 1;
-       }
-
-       skcd_buf.classid = classid;
-       WRITE_ONCE(skcd->val, skcd_buf.val);    /* see sock_cgroup_ptr() */
+#ifdef CONFIG_CGROUP_NET_CLASSID
+       WRITE_ONCE(skcd->classid, classid);
+#endif
 }
 
 #else  /* CONFIG_SOCK_CGROUP_DATA */
index 7bf6045..75c1514 100644 (file)
@@ -829,33 +829,13 @@ static inline void cgroup_account_cputime_field(struct task_struct *task,
  */
 #ifdef CONFIG_SOCK_CGROUP_DATA
 
-#if defined(CONFIG_CGROUP_NET_PRIO) || defined(CONFIG_CGROUP_NET_CLASSID)
-extern spinlock_t cgroup_sk_update_lock;
-#endif
-
-void cgroup_sk_alloc_disable(void);
 void cgroup_sk_alloc(struct sock_cgroup_data *skcd);
 void cgroup_sk_clone(struct sock_cgroup_data *skcd);
 void cgroup_sk_free(struct sock_cgroup_data *skcd);
 
 static inline struct cgroup *sock_cgroup_ptr(struct sock_cgroup_data *skcd)
 {
-#if defined(CONFIG_CGROUP_NET_PRIO) || defined(CONFIG_CGROUP_NET_CLASSID)
-       unsigned long v;
-
-       /*
-        * @skcd->val is 64bit but the following is safe on 32bit too as we
-        * just need the lower ulong to be written and read atomically.
-        */
-       v = READ_ONCE(skcd->val);
-
-       if (v & 3)
-               return &cgrp_dfl_root.cgrp;
-
-       return (struct cgroup *)(unsigned long)v ?: &cgrp_dfl_root.cgrp;
-#else
-       return (struct cgroup *)(unsigned long)skcd->val;
-#endif
+       return skcd->cgroup;
 }
 
 #else  /* CONFIG_CGROUP_DATA */
index 49b0ac8..3c4de9b 100644 (file)
 #define __no_sanitize_coverage
 #endif
 
-/*
- * Not all versions of clang implement the type-generic versions
- * of the builtin overflow checkers. Fortunately, clang implements
- * __has_builtin allowing us to avoid awkward version
- * checks. Unfortunately, we don't know which version of gcc clang
- * pretends to be, so the macro may or may not be defined.
- */
-#if __has_builtin(__builtin_mul_overflow) && \
-    __has_builtin(__builtin_add_overflow) && \
-    __has_builtin(__builtin_sub_overflow)
-#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
-#endif
-
 #if __has_feature(shadow_call_stack)
 # define __noscs       __attribute__((__no_sanitize__("shadow-call-stack")))
 #endif
index 21c36b6..bd2b881 100644 (file)
 
 #if GCC_VERSION >= 70000
 #define KASAN_ABI_VERSION 5
-#elif GCC_VERSION >= 50000
+#else
 #define KASAN_ABI_VERSION 4
-#elif GCC_VERSION >= 40902
-#define KASAN_ABI_VERSION 3
 #endif
 
 #if __has_attribute(__no_sanitize_address__)
 #define __no_sanitize_coverage
 #endif
 
-#if GCC_VERSION >= 50100
-#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
-#endif
-
 /*
  * Turn individual warnings and errors on and off locally, depending
  * on version.
index b67261a..3d5af56 100644 (file)
@@ -188,6 +188,8 @@ void ftrace_likely_update(struct ftrace_likely_data *f, int val,
     (typeof(ptr)) (__ptr + (off)); })
 #endif
 
+#define absolute_pointer(val)  RELOC_HIDE((void *)(val), 0)
+
 #ifndef OPTIMIZER_HIDE_VAR
 /* Make the optimizer believe the variable can be manipulated arbitrarily. */
 #define OPTIMIZER_HIDE_VAR(var)                                                \
index 8f2106e..e6ec634 100644 (file)
  * Provide links to the documentation of each supported compiler, if it exists.
  */
 
-/*
- * __has_attribute is supported on gcc >= 5, clang >= 2.9 and icc >= 17.
- * In the meantime, to support gcc < 5, we implement __has_attribute
- * by hand.
- */
-#ifndef __has_attribute
-# define __has_attribute(x) __GCC4_has_attribute_##x
-# define __GCC4_has_attribute___assume_aligned__      1
-# define __GCC4_has_attribute___copy__                0
-# define __GCC4_has_attribute___designated_init__     0
-# define __GCC4_has_attribute___error__               1
-# define __GCC4_has_attribute___externally_visible__  1
-# define __GCC4_has_attribute___no_caller_saved_registers__ 0
-# define __GCC4_has_attribute___noclone__             1
-# define __GCC4_has_attribute___no_profile_instrument_function__ 0
-# define __GCC4_has_attribute___nonstring__           0
-# define __GCC4_has_attribute___no_sanitize_address__ 1
-# define __GCC4_has_attribute___no_sanitize_undefined__ 1
-# define __GCC4_has_attribute___no_sanitize_coverage__ 0
-# define __GCC4_has_attribute___fallthrough__         0
-# define __GCC4_has_attribute___warning__             1
-#endif
-
 /*
  *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-alias-function-attribute
  */
@@ -77,7 +54,6 @@
  * compiler should see some alignment anyway, when the return value is
  * massaged by 'flags = ptr & 3; ptr &= ~3;').
  *
- * Optional: only supported since gcc >= 4.9
  * Optional: not supported by icc
  *
  *   gcc: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#index-assume_005faligned-function-attribute
index 5d4d07a..1e7399f 100644 (file)
@@ -996,14 +996,15 @@ cpumap_print_to_pagebuf(bool list, char *buf, const struct cpumask *mask)
  * cpumask; Typically used by bin_attribute to export cpumask bitmask
  * ABI.
  *
- * Returns the length of how many bytes have been copied.
+ * Returns the length of how many bytes have been copied, excluding
+ * terminating '\0'.
  */
 static inline ssize_t
 cpumap_print_bitmask_to_buf(char *buf, const struct cpumask *mask,
                loff_t off, size_t count)
 {
        return bitmap_print_bitmask_to_buf(buf, cpumask_bits(mask),
-                                  nr_cpu_ids, off, count);
+                                  nr_cpu_ids, off, count) - 1;
 }
 
 /**
@@ -1018,7 +1019,7 @@ cpumap_print_list_to_buf(char *buf, const struct cpumask *mask,
                loff_t off, size_t count)
 {
        return bitmap_print_list_to_buf(buf, cpumask_bits(mask),
-                                  nr_cpu_ids, off, count);
+                                  nr_cpu_ids, off, count) - 1;
 }
 
 #if NR_CPUS <= BITS_PER_LONG
diff --git a/include/linux/dsa/mv88e6xxx.h b/include/linux/dsa/mv88e6xxx.h
new file mode 100644 (file)
index 0000000..8c3d45e
--- /dev/null
@@ -0,0 +1,13 @@
+/* SPDX-License-Identifier: GPL-2.0
+ * Copyright 2021 NXP
+ */
+
+#ifndef _NET_DSA_TAG_MV88E6XXX_H
+#define _NET_DSA_TAG_MV88E6XXX_H
+
+#include <linux/if_vlan.h>
+
+#define MV88E6XXX_VID_STANDALONE       0
+#define MV88E6XXX_VID_BRIDGED          (VLAN_N_VID - 1)
+
+#endif
index c6bc45a..8ae999f 100644 (file)
@@ -1,11 +1,32 @@
 /* SPDX-License-Identifier: GPL-2.0
- * Copyright 2019-2021 NXP Semiconductors
+ * Copyright 2019-2021 NXP
  */
 
 #ifndef _NET_DSA_TAG_OCELOT_H
 #define _NET_DSA_TAG_OCELOT_H
 
+#include <linux/kthread.h>
 #include <linux/packing.h>
+#include <linux/skbuff.h>
+
+struct ocelot_skb_cb {
+       struct sk_buff *clone;
+       unsigned int ptp_class; /* valid only for clones */
+       u8 ptp_cmd;
+       u8 ts_id;
+};
+
+#define OCELOT_SKB_CB(skb) \
+       ((struct ocelot_skb_cb *)((skb)->cb))
+
+#define IFH_TAG_TYPE_C                 0
+#define IFH_TAG_TYPE_S                 1
+
+#define IFH_REW_OP_NOOP                        0x0
+#define IFH_REW_OP_DSCP                        0x1
+#define IFH_REW_OP_ONE_STEP_PTP                0x2
+#define IFH_REW_OP_TWO_STEP_PTP                0x3
+#define IFH_REW_OP_ORIGIN_PTP          0x5
 
 #define OCELOT_TAG_LEN                 16
 #define OCELOT_SHORT_PREFIX_LEN                4
  *         +------+------+------+------+------+------+------+------+
  */
 
+struct felix_deferred_xmit_work {
+       struct dsa_port *dp;
+       struct sk_buff *skb;
+       struct kthread_work work;
+};
+
+struct felix_port {
+       void (*xmit_work_fn)(struct kthread_work *work);
+       struct kthread_worker *xmit_worker;
+};
+
 static inline void ocelot_xfh_get_rew_val(void *extraction, u64 *rew_val)
 {
        packing(extraction, rew_val, 116, 85, OCELOT_TAG_LEN, UNPACK, 0);
@@ -215,4 +247,21 @@ static inline void ocelot_ifh_set_vid(void *injection, u64 vid)
        packing(injection, &vid, 11, 0, OCELOT_TAG_LEN, PACK, 0);
 }
 
+/* Determine the PTP REW_OP to use for injecting the given skb */
+static inline u32 ocelot_ptp_rew_op(struct sk_buff *skb)
+{
+       struct sk_buff *clone = OCELOT_SKB_CB(skb)->clone;
+       u8 ptp_cmd = OCELOT_SKB_CB(skb)->ptp_cmd;
+       u32 rew_op = 0;
+
+       if (ptp_cmd == IFH_REW_OP_TWO_STEP_PTP && clone) {
+               rew_op = ptp_cmd;
+               rew_op |= OCELOT_SKB_CB(clone)->ts_id << 3;
+       } else if (ptp_cmd == IFH_REW_OP_ORIGIN_PTP) {
+               rew_op = ptp_cmd;
+       }
+
+       return rew_op;
+}
+
 #endif
index 1711062..9e07079 100644 (file)
@@ -48,6 +48,10 @@ struct sja1105_tagger_data {
        spinlock_t meta_lock;
        unsigned long state;
        u8 ts_id;
+       /* Used on SJA1110 where meta frames are generated only for
+        * 2-step TX timestamps
+        */
+       struct sk_buff_head skb_txtstamp_queue;
 };
 
 struct sja1105_skb_cb {
@@ -69,42 +73,24 @@ struct sja1105_port {
        bool hwts_tx_en;
 };
 
-enum sja1110_meta_tstamp {
-       SJA1110_META_TSTAMP_TX = 0,
-       SJA1110_META_TSTAMP_RX = 1,
-};
-
-#if IS_ENABLED(CONFIG_NET_DSA_SJA1105_PTP)
-
-void sja1110_process_meta_tstamp(struct dsa_switch *ds, int port, u8 ts_id,
-                                enum sja1110_meta_tstamp dir, u64 tstamp);
-
-#else
+/* Timestamps are in units of 8 ns clock ticks (equivalent to
+ * a fixed 125 MHz clock).
+ */
+#define SJA1105_TICK_NS                        8
 
-static inline void sja1110_process_meta_tstamp(struct dsa_switch *ds, int port,
-                                              u8 ts_id, enum sja1110_meta_tstamp dir,
-                                              u64 tstamp)
+static inline s64 ns_to_sja1105_ticks(s64 ns)
 {
+       return ns / SJA1105_TICK_NS;
 }
 
-#endif /* IS_ENABLED(CONFIG_NET_DSA_SJA1105_PTP) */
-
-#if IS_ENABLED(CONFIG_NET_DSA_SJA1105)
-
-extern const struct dsa_switch_ops sja1105_switch_ops;
-
-static inline bool dsa_port_is_sja1105(struct dsa_port *dp)
+static inline s64 sja1105_ticks_to_ns(s64 ticks)
 {
-       return dp->ds->ops == &sja1105_switch_ops;
+       return ticks * SJA1105_TICK_NS;
 }
 
-#else
-
 static inline bool dsa_port_is_sja1105(struct dsa_port *dp)
 {
-       return false;
+       return true;
 }
 
-#endif
-
 #endif /* _NET_DSA_SJA1105_H */
index 928c411..c58d504 100644 (file)
@@ -308,7 +308,7 @@ static inline void ether_addr_copy(u8 *dst, const u8 *src)
  */
 static inline void eth_hw_addr_set(struct net_device *dev, const u8 *addr)
 {
-       ether_addr_copy(dev->dev_addr, addr);
+       __dev_addr_set(dev, addr, ETH_ALEN);
 }
 
 /**
diff --git a/include/linux/firmware/cirrus/cs_dsp.h b/include/linux/firmware/cirrus/cs_dsp.h
new file mode 100644 (file)
index 0000000..9ad9eaa
--- /dev/null
@@ -0,0 +1,242 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * cs_dsp.h  --  Cirrus Logic DSP firmware support
+ *
+ * Based on sound/soc/codecs/wm_adsp.h
+ *
+ * Copyright 2012 Wolfson Microelectronics plc
+ * Copyright (C) 2015-2021 Cirrus Logic, Inc. and
+ *                         Cirrus Logic International Semiconductor Ltd.
+ */
+#ifndef __CS_DSP_H
+#define __CS_DSP_H
+
+#define CS_ADSP2_REGION_0 BIT(0)
+#define CS_ADSP2_REGION_1 BIT(1)
+#define CS_ADSP2_REGION_2 BIT(2)
+#define CS_ADSP2_REGION_3 BIT(3)
+#define CS_ADSP2_REGION_4 BIT(4)
+#define CS_ADSP2_REGION_5 BIT(5)
+#define CS_ADSP2_REGION_6 BIT(6)
+#define CS_ADSP2_REGION_7 BIT(7)
+#define CS_ADSP2_REGION_8 BIT(8)
+#define CS_ADSP2_REGION_9 BIT(9)
+#define CS_ADSP2_REGION_1_9 (CS_ADSP2_REGION_1 | \
+               CS_ADSP2_REGION_2 | CS_ADSP2_REGION_3 | \
+               CS_ADSP2_REGION_4 | CS_ADSP2_REGION_5 | \
+               CS_ADSP2_REGION_6 | CS_ADSP2_REGION_7 | \
+               CS_ADSP2_REGION_8 | CS_ADSP2_REGION_9)
+#define CS_ADSP2_REGION_ALL (CS_ADSP2_REGION_0 | CS_ADSP2_REGION_1_9)
+
+#define CS_DSP_DATA_WORD_SIZE                3
+
+#define CS_DSP_ACKED_CTL_TIMEOUT_MS          100
+#define CS_DSP_ACKED_CTL_N_QUICKPOLLS        10
+#define CS_DSP_ACKED_CTL_MIN_VALUE           0
+#define CS_DSP_ACKED_CTL_MAX_VALUE           0xFFFFFF
+
+/**
+ * struct cs_dsp_region - Describes a logical memory region in DSP address space
+ * @type:      Memory region type
+ * @base:      Address of region
+ */
+struct cs_dsp_region {
+       int type;
+       unsigned int base;
+};
+
+/**
+ * struct cs_dsp_alg_region - Describes a logical algorithm region in DSP address space
+ * @list:      List node for internal use
+ * @alg:       Algorithm id
+ * @type:      Memory region type
+ * @base:      Address of region
+ */
+struct cs_dsp_alg_region {
+       struct list_head list;
+       unsigned int alg;
+       int type;
+       unsigned int base;
+};
+
+/**
+ * struct cs_dsp_coeff_ctl - Describes a coefficient control
+ * @fw_name:           Name of the firmware
+ * @subname:           Name of the control parsed from the WMFW
+ * @subname_len:       Length of subname
+ * @alg_region:                Logical region associated with this control
+ * @dsp:               DSP instance associated with this control
+ * @enabled:           Flag indicating whether control is enabled
+ * @list:              List node for internal use
+ * @cache:             Cached value of the control
+ * @offset:            Offset of control within alg_region
+ * @len:               Length of the cached value
+ * @set:               Flag indicating the value has been written by the user
+ * @flags:             Bitfield of WMFW_CTL_FLAG_ control flags defined in wmfw.h
+ * @type:              One of the WMFW_CTL_TYPE_ control types defined in wmfw.h
+ * @priv:              For use by the client
+ */
+struct cs_dsp_coeff_ctl {
+       const char *fw_name;
+       /* Subname is needed to match with firmware */
+       const char *subname;
+       unsigned int subname_len;
+       struct cs_dsp_alg_region alg_region;
+       struct cs_dsp *dsp;
+       unsigned int enabled:1;
+       struct list_head list;
+       void *cache;
+       unsigned int offset;
+       size_t len;
+       unsigned int set:1;
+       unsigned int flags;
+       unsigned int type;
+
+       void *priv;
+};
+
+struct cs_dsp_ops;
+struct cs_dsp_client_ops;
+
+/**
+ * struct cs_dsp - Configuration and state of a Cirrus Logic DSP
+ * @name:              The name of the DSP instance
+ * @rev:               Revision of the DSP
+ * @num:               DSP instance number
+ * @type:              Type of DSP
+ * @dev:               Driver model representation of the device
+ * @regmap:            Register map of the device
+ * @ops:               Function pointers for internal callbacks
+ * @client_ops:                Function pointers for client callbacks
+ * @base:              Address of the DSP registers
+ * @base_sysinfo:      Address of the sysinfo register (Halo only)
+ * @sysclk_reg:                Address of the sysclk register (ADSP1 only)
+ * @sysclk_mask:       Mask of frequency bits within sysclk register (ADSP1 only)
+ * @sysclk_shift:      Shift of frequency bits within sysclk register (ADSP1 only)
+ * @alg_regions:       List of currently loaded algorithm regions
+ * @fw_file_name:      Filename of the current firmware
+ * @fw_name:           Name of the current firmware
+ * @fw_id:             ID of the current firmware, obtained from the wmfw
+ * @fw_id_version:     Version of the firmware, obtained from the wmfw
+ * @fw_vendor_id:      Vendor of the firmware, obtained from the wmfw
+ * @mem:               DSP memory region descriptions
+ * @num_mems:          Number of memory regions in this DSP
+ * @fw_ver:            Version of the wmfw file format
+ * @booted:            Flag indicating DSP has been configured
+ * @running:           Flag indicating DSP is executing firmware
+ * @ctl_list:          Controls defined within the loaded DSP firmware
+ * @lock_regions:      Enable MPU traps on specified memory regions
+ * @pwr_lock:          Lock used to serialize accesses
+ * @debugfs_root:      Debugfs directory for this DSP instance
+ * @wmfw_file_name:    Filename of the currently loaded firmware
+ * @bin_file_name:     Filename of the currently loaded coefficients
+ */
+struct cs_dsp {
+       const char *name;
+       int rev;
+       int num;
+       int type;
+       struct device *dev;
+       struct regmap *regmap;
+
+       const struct cs_dsp_ops *ops;
+       const struct cs_dsp_client_ops *client_ops;
+
+       unsigned int base;
+       unsigned int base_sysinfo;
+       unsigned int sysclk_reg;
+       unsigned int sysclk_mask;
+       unsigned int sysclk_shift;
+
+       struct list_head alg_regions;
+
+       const char *fw_name;
+       unsigned int fw_id;
+       unsigned int fw_id_version;
+       unsigned int fw_vendor_id;
+
+       const struct cs_dsp_region *mem;
+       int num_mems;
+
+       int fw_ver;
+
+       bool booted;
+       bool running;
+
+       struct list_head ctl_list;
+
+       struct mutex pwr_lock;
+
+       unsigned int lock_regions;
+
+#ifdef CONFIG_DEBUG_FS
+       struct dentry *debugfs_root;
+       char *wmfw_file_name;
+       char *bin_file_name;
+#endif
+};
+
+/**
+ * struct cs_dsp_client_ops - client callbacks
+ * @control_add:       Called under the pwr_lock when a control is created
+ * @control_remove:    Called under the pwr_lock when a control is destroyed
+ * @post_run:          Called under the pwr_lock by cs_dsp_run()
+ * @post_stop:         Called under the pwr_lock by cs_dsp_stop()
+ * @watchdog_expired:  Called when a watchdog expiry is detected
+ *
+ * These callbacks give the cs_dsp client an opportunity to respond to events
+ * or to perform actions atomically.
+ */
+struct cs_dsp_client_ops {
+       int (*control_add)(struct cs_dsp_coeff_ctl *ctl);
+       void (*control_remove)(struct cs_dsp_coeff_ctl *ctl);
+       int (*post_run)(struct cs_dsp *dsp);
+       void (*post_stop)(struct cs_dsp *dsp);
+       void (*watchdog_expired)(struct cs_dsp *dsp);
+};
+
+int cs_dsp_adsp1_init(struct cs_dsp *dsp);
+int cs_dsp_adsp2_init(struct cs_dsp *dsp);
+int cs_dsp_halo_init(struct cs_dsp *dsp);
+
+int cs_dsp_adsp1_power_up(struct cs_dsp *dsp,
+                         const struct firmware *wmfw_firmware, char *wmfw_filename,
+                         const struct firmware *coeff_firmware, char *coeff_filename,
+                         const char *fw_name);
+void cs_dsp_adsp1_power_down(struct cs_dsp *dsp);
+int cs_dsp_power_up(struct cs_dsp *dsp,
+                   const struct firmware *wmfw_firmware, char *wmfw_filename,
+                   const struct firmware *coeff_firmware, char *coeff_filename,
+                   const char *fw_name);
+void cs_dsp_power_down(struct cs_dsp *dsp);
+int cs_dsp_run(struct cs_dsp *dsp);
+void cs_dsp_stop(struct cs_dsp *dsp);
+
+void cs_dsp_remove(struct cs_dsp *dsp);
+
+int cs_dsp_set_dspclk(struct cs_dsp *dsp, unsigned int freq);
+void cs_dsp_adsp2_bus_error(struct cs_dsp *dsp);
+void cs_dsp_halo_bus_error(struct cs_dsp *dsp);
+void cs_dsp_halo_wdt_expire(struct cs_dsp *dsp);
+
+void cs_dsp_init_debugfs(struct cs_dsp *dsp, struct dentry *debugfs_root);
+void cs_dsp_cleanup_debugfs(struct cs_dsp *dsp);
+
+int cs_dsp_coeff_write_acked_control(struct cs_dsp_coeff_ctl *ctl, unsigned int event_id);
+int cs_dsp_coeff_write_ctrl(struct cs_dsp_coeff_ctl *ctl, const void *buf, size_t len);
+int cs_dsp_coeff_read_ctrl(struct cs_dsp_coeff_ctl *ctl, void *buf, size_t len);
+struct cs_dsp_coeff_ctl *cs_dsp_get_ctl(struct cs_dsp *dsp, const char *name, int type,
+                                       unsigned int alg);
+
+int cs_dsp_read_raw_data_block(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr,
+                              unsigned int num_words, __be32 *data);
+int cs_dsp_read_data_word(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr, u32 *data);
+int cs_dsp_write_data_word(struct cs_dsp *dsp, int mem_type, unsigned int mem_addr, u32 data);
+void cs_dsp_remove_padding(u32 *buf, int nwords);
+
+struct cs_dsp_alg_region *cs_dsp_find_alg_region(struct cs_dsp *dsp,
+                                                int type, unsigned int id);
+
+const char *cs_dsp_mem_region_name(unsigned int type);
+
+#endif
diff --git a/include/linux/firmware/cirrus/wmfw.h b/include/linux/firmware/cirrus/wmfw.h
new file mode 100644 (file)
index 0000000..a19bf7c
--- /dev/null
@@ -0,0 +1,202 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * wmfw.h - Wolfson firmware format information
+ *
+ * Copyright 2012 Wolfson Microelectronics plc
+ *
+ * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
+ */
+
+#ifndef __WMFW_H
+#define __WMFW_H
+
+#include <linux/types.h>
+
+#define WMFW_MAX_ALG_NAME         256
+#define WMFW_MAX_ALG_DESCR_NAME   256
+
+#define WMFW_MAX_COEFF_NAME       256
+#define WMFW_MAX_COEFF_DESCR_NAME 256
+
+#define WMFW_CTL_FLAG_SYS         0x8000
+#define WMFW_CTL_FLAG_VOLATILE    0x0004
+#define WMFW_CTL_FLAG_WRITEABLE   0x0002
+#define WMFW_CTL_FLAG_READABLE    0x0001
+
+#define WMFW_CTL_TYPE_BYTES       0x0004 /* byte control */
+
+/* Non-ALSA coefficient types start at 0x1000 */
+#define WMFW_CTL_TYPE_ACKED       0x1000 /* acked control */
+#define WMFW_CTL_TYPE_HOSTEVENT   0x1001 /* event control */
+#define WMFW_CTL_TYPE_HOST_BUFFER 0x1002 /* host buffer pointer */
+
+struct wmfw_header {
+       char magic[4];
+       __le32 len;
+       __le16 rev;
+       u8 core;
+       u8 ver;
+} __packed;
+
+struct wmfw_footer {
+       __le64 timestamp;
+       __le32 checksum;
+} __packed;
+
+struct wmfw_adsp1_sizes {
+       __le32 dm;
+       __le32 pm;
+       __le32 zm;
+} __packed;
+
+struct wmfw_adsp2_sizes {
+       __le32 xm;
+       __le32 ym;
+       __le32 pm;
+       __le32 zm;
+} __packed;
+
+struct wmfw_region {
+       union {
+               __be32 type;
+               __le32 offset;
+       };
+       __le32 len;
+       u8 data[];
+} __packed;
+
+struct wmfw_id_hdr {
+       __be32 core_id;
+       __be32 core_rev;
+       __be32 id;
+       __be32 ver;
+} __packed;
+
+struct wmfw_v3_id_hdr {
+       __be32 core_id;
+       __be32 block_rev;
+       __be32 vendor_id;
+       __be32 id;
+       __be32 ver;
+} __packed;
+
+struct wmfw_adsp1_id_hdr {
+       struct wmfw_id_hdr fw;
+       __be32 zm;
+       __be32 dm;
+       __be32 n_algs;
+} __packed;
+
+struct wmfw_adsp2_id_hdr {
+       struct wmfw_id_hdr fw;
+       __be32 zm;
+       __be32 xm;
+       __be32 ym;
+       __be32 n_algs;
+} __packed;
+
+struct wmfw_halo_id_hdr {
+       struct wmfw_v3_id_hdr fw;
+       __be32 xm_base;
+       __be32 xm_size;
+       __be32 ym_base;
+       __be32 ym_size;
+       __be32 n_algs;
+} __packed;
+
+struct wmfw_alg_hdr {
+       __be32 id;
+       __be32 ver;
+} __packed;
+
+struct wmfw_adsp1_alg_hdr {
+       struct wmfw_alg_hdr alg;
+       __be32 zm;
+       __be32 dm;
+} __packed;
+
+struct wmfw_adsp2_alg_hdr {
+       struct wmfw_alg_hdr alg;
+       __be32 zm;
+       __be32 xm;
+       __be32 ym;
+} __packed;
+
+struct wmfw_halo_alg_hdr {
+       struct wmfw_alg_hdr alg;
+       __be32 xm_base;
+       __be32 xm_size;
+       __be32 ym_base;
+       __be32 ym_size;
+} __packed;
+
+struct wmfw_adsp_alg_data {
+       __le32 id;
+       u8 name[WMFW_MAX_ALG_NAME];
+       u8 descr[WMFW_MAX_ALG_DESCR_NAME];
+       __le32 ncoeff;
+       u8 data[];
+} __packed;
+
+struct wmfw_adsp_coeff_data {
+       struct {
+               __le16 offset;
+               __le16 type;
+               __le32 size;
+       } hdr;
+       u8 name[WMFW_MAX_COEFF_NAME];
+       u8 descr[WMFW_MAX_COEFF_DESCR_NAME];
+       __le16 ctl_type;
+       __le16 flags;
+       __le32 len;
+       u8 data[];
+} __packed;
+
+struct wmfw_coeff_hdr {
+       u8 magic[4];
+       __le32 len;
+       union {
+               __be32 rev;
+               __le32 ver;
+       };
+       union {
+               __be32 core;
+               __le32 core_ver;
+       };
+       u8 data[];
+} __packed;
+
+struct wmfw_coeff_item {
+       __le16 offset;
+       __le16 type;
+       __le32 id;
+       __le32 ver;
+       __le32 sr;
+       __le32 len;
+       u8 data[];
+} __packed;
+
+#define WMFW_ADSP1 1
+#define WMFW_ADSP2 2
+#define WMFW_HALO 4
+
+#define WMFW_ABSOLUTE         0xf0
+#define WMFW_ALGORITHM_DATA   0xf2
+#define WMFW_METADATA         0xfc
+#define WMFW_NAME_TEXT        0xfe
+#define WMFW_INFO_TEXT        0xff
+
+#define WMFW_ADSP1_PM 2
+#define WMFW_ADSP1_DM 3
+#define WMFW_ADSP1_ZM 4
+
+#define WMFW_ADSP2_PM 2
+#define WMFW_ADSP2_ZM 4
+#define WMFW_ADSP2_XM 5
+#define WMFW_ADSP2_YM 6
+
+#define WMFW_HALO_PM_PACKED 0x10
+#define WMFW_HALO_XM_PACKED 0x11
+#define WMFW_HALO_YM_PACKED 0x12
+
+#endif
index 5982851..9f4ad71 100644 (file)
@@ -22,10 +22,15 @@ struct device;
  * LINKS_ADDED:        The fwnode has already be parsed to add fwnode links.
  * NOT_DEVICE: The fwnode will never be populated as a struct device.
  * INITIALIZED: The hardware corresponding to fwnode has been initialized.
+ * NEEDS_CHILD_BOUND_ON_ADD: For this fwnode/device to probe successfully, its
+ *                          driver needs its child devices to be bound with
+ *                          their respective drivers as soon as they are
+ *                          added.
  */
-#define FWNODE_FLAG_LINKS_ADDED                BIT(0)
-#define FWNODE_FLAG_NOT_DEVICE         BIT(1)
-#define FWNODE_FLAG_INITIALIZED                BIT(2)
+#define FWNODE_FLAG_LINKS_ADDED                        BIT(0)
+#define FWNODE_FLAG_NOT_DEVICE                 BIT(1)
+#define FWNODE_FLAG_INITIALIZED                        BIT(2)
+#define FWNODE_FLAG_NEEDS_CHILD_BOUND_ON_ADD   BIT(3)
 
 struct fwnode_handle {
        struct fwnode_handle *secondary;
index c68d83c..0f5315c 100644 (file)
@@ -149,6 +149,7 @@ struct gendisk {
        unsigned long state;
 #define GD_NEED_PART_SCAN              0
 #define GD_READ_ONLY                   1
+#define GD_DEAD                                2
 
        struct mutex open_mutex;        /* open/close mutex */
        unsigned open_partitions;       /* number of open partitions */
index 23e4ee5..9ee238a 100644 (file)
@@ -251,7 +251,7 @@ static inline struct fwnode_handle *irq_domain_alloc_fwnode(phys_addr_t *pa)
 }
 
 void irq_domain_free_fwnode(struct fwnode_handle *fwnode);
-struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
+struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, unsigned int size,
                                    irq_hw_number_t hwirq_max, int direct_max,
                                    const struct irq_domain_ops *ops,
                                    void *host_data);
index 041ca7f..0f18df7 100644 (file)
@@ -608,7 +608,6 @@ struct kvm {
        unsigned long mmu_notifier_range_start;
        unsigned long mmu_notifier_range_end;
 #endif
-       long tlbs_dirty;
        struct list_head devices;
        u64 manual_dirty_log_protect;
        struct dentry *debugfs_dentry;
@@ -721,11 +720,6 @@ static inline struct kvm_vcpu *kvm_get_vcpu_by_id(struct kvm *kvm, int id)
        return NULL;
 }
 
-static inline int kvm_vcpu_get_idx(struct kvm_vcpu *vcpu)
-{
-       return vcpu->vcpu_idx;
-}
-
 #define kvm_for_each_memslot(memslot, slots)                           \
        for (memslot = &slots->memslots[0];                             \
             memslot < slots->memslots + slots->used_slots; memslot++)  \
index ffb787d..5e6dc38 100644 (file)
@@ -80,6 +80,9 @@ struct mdio_driver {
 
        /* Clears up any memory if needed */
        void (*remove)(struct mdio_device *mdiodev);
+
+       /* Quiesces the device on system shutdown, turns off interrupts etc */
+       void (*shutdown)(struct mdio_device *mdiodev);
 };
 
 static inline struct mdio_driver *
index b066024..34de69b 100644 (file)
@@ -118,6 +118,7 @@ int memblock_mark_nomap(phys_addr_t base, phys_addr_t size);
 int memblock_clear_nomap(phys_addr_t base, phys_addr_t size);
 
 void memblock_free_all(void);
+void memblock_free_ptr(void *ptr, size_t size);
 void reset_node_managed_pages(pg_data_t *pgdat);
 void reset_all_zones_managed_pages(void);
 
index 3262509..c8077e9 100644 (file)
@@ -19,6 +19,11 @@ struct migration_target_control;
  */
 #define MIGRATEPAGE_SUCCESS            0
 
+/*
+ * Keep sync with:
+ * - macro MIGRATE_REASON in include/trace/events/migrate.h
+ * - migrate_reason_names[MR_TYPES] in mm/debug.c
+ */
 enum migrate_reason {
        MR_COMPACTION,
        MR_MEMORY_FAILURE,
@@ -32,7 +37,6 @@ enum migrate_reason {
        MR_TYPES
 };
 
-/* In mm/debug.c; also keep sync with include/trace/events/migrate.h */
 extern const char *migrate_reason_names[MR_TYPES];
 
 #ifdef CONFIG_MIGRATION
index f3638d0..993204a 100644 (file)
@@ -9475,16 +9475,22 @@ struct mlx5_ifc_pcmr_reg_bits {
        u8         reserved_at_0[0x8];
        u8         local_port[0x8];
        u8         reserved_at_10[0x10];
+
        u8         entropy_force_cap[0x1];
        u8         entropy_calc_cap[0x1];
        u8         entropy_gre_calc_cap[0x1];
-       u8         reserved_at_23[0x1b];
+       u8         reserved_at_23[0xf];
+       u8         rx_ts_over_crc_cap[0x1];
+       u8         reserved_at_33[0xb];
        u8         fcs_cap[0x1];
        u8         reserved_at_3f[0x1];
+
        u8         entropy_force[0x1];
        u8         entropy_calc[0x1];
        u8         entropy_gre_calc[0x1];
-       u8         reserved_at_43[0x1b];
+       u8         reserved_at_43[0xf];
+       u8         rx_ts_over_crc[0x1];
+       u8         reserved_at_53[0xb];
        u8         fcs_chk[0x1];
        u8         reserved_at_5f[0x1];
 };
index b179f1e..96e113e 100644 (file)
@@ -144,15 +144,6 @@ static inline void mmap_read_unlock(struct mm_struct *mm)
        up_read(&mm->mmap_lock);
 }
 
-static inline bool mmap_read_trylock_non_owner(struct mm_struct *mm)
-{
-       if (mmap_read_trylock(mm)) {
-               rwsem_release(&mm->mmap_lock.dep_map, _RET_IP_);
-               return true;
-       }
-       return false;
-}
-
 static inline void mmap_read_unlock_non_owner(struct mm_struct *mm)
 {
        __mmap_lock_trace_released(mm, false);
index 923dada..c0c0cef 100644 (file)
@@ -150,6 +150,20 @@ static inline int nvmem_cell_read_u64(struct device *dev,
        return -EOPNOTSUPP;
 }
 
+static inline int nvmem_cell_read_variable_le_u32(struct device *dev,
+                                                const char *cell_id,
+                                                u32 *val)
+{
+       return -EOPNOTSUPP;
+}
+
+static inline int nvmem_cell_read_variable_le_u64(struct device *dev,
+                                                 const char *cell_id,
+                                                 u64 *val)
+{
+       return -EOPNOTSUPP;
+}
+
 static inline struct nvmem_device *nvmem_device_get(struct device *dev,
                                                    const char *name)
 {
index 0f12345..4669632 100644 (file)
@@ -6,12 +6,9 @@
 #include <linux/limits.h>
 
 /*
- * In the fallback code below, we need to compute the minimum and
- * maximum values representable in a given type. These macros may also
- * be useful elsewhere, so we provide them outside the
- * COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW block.
- *
- * It would seem more obvious to do something like
+ * We need to compute the minimum and maximum values representable in a given
+ * type. These macros may also be useful elsewhere. It would seem more obvious
+ * to do something like:
  *
  * #define type_min(T) (T)(is_signed_type(T) ? (T)1 << (8*sizeof(T)-1) : 0)
  * #define type_max(T) (T)(is_signed_type(T) ? ((T)1 << (8*sizeof(T)-1)) - 1 : ~(T)0)
@@ -54,7 +51,6 @@ static inline bool __must_check __must_check_overflow(bool overflow)
        return unlikely(overflow);
 }
 
-#ifdef COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW
 /*
  * For simplicity and code hygiene, the fallback code below insists on
  * a, b and *d having the same type (similar to the min() and max()
@@ -90,134 +86,6 @@ static inline bool __must_check __must_check_overflow(bool overflow)
        __builtin_mul_overflow(__a, __b, __d);  \
 }))
 
-#else
-
-
-/* Checking for unsigned overflow is relatively easy without causing UB. */
-#define __unsigned_add_overflow(a, b, d) ({    \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = __a + __b;                       \
-       *__d < __a;                             \
-})
-#define __unsigned_sub_overflow(a, b, d) ({    \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = __a - __b;                       \
-       __a < __b;                              \
-})
-/*
- * If one of a or b is a compile-time constant, this avoids a division.
- */
-#define __unsigned_mul_overflow(a, b, d) ({            \
-       typeof(a) __a = (a);                            \
-       typeof(b) __b = (b);                            \
-       typeof(d) __d = (d);                            \
-       (void) (&__a == &__b);                          \
-       (void) (&__a == __d);                           \
-       *__d = __a * __b;                               \
-       __builtin_constant_p(__b) ?                     \
-         __b > 0 && __a > type_max(typeof(__a)) / __b : \
-         __a > 0 && __b > type_max(typeof(__b)) / __a;  \
-})
-
-/*
- * For signed types, detecting overflow is much harder, especially if
- * we want to avoid UB. But the interface of these macros is such that
- * we must provide a result in *d, and in fact we must produce the
- * result promised by gcc's builtins, which is simply the possibly
- * wrapped-around value. Fortunately, we can just formally do the
- * operations in the widest relevant unsigned type (u64) and then
- * truncate the result - gcc is smart enough to generate the same code
- * with and without the (u64) casts.
- */
-
-/*
- * Adding two signed integers can overflow only if they have the same
- * sign, and overflow has happened iff the result has the opposite
- * sign.
- */
-#define __signed_add_overflow(a, b, d) ({      \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = (u64)__a + (u64)__b;             \
-       (((~(__a ^ __b)) & (*__d ^ __a))        \
-               & type_min(typeof(__a))) != 0;  \
-})
-
-/*
- * Subtraction is similar, except that overflow can now happen only
- * when the signs are opposite. In this case, overflow has happened if
- * the result has the opposite sign of a.
- */
-#define __signed_sub_overflow(a, b, d) ({      \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = (u64)__a - (u64)__b;             \
-       ((((__a ^ __b)) & (*__d ^ __a))         \
-               & type_min(typeof(__a))) != 0;  \
-})
-
-/*
- * Signed multiplication is rather hard. gcc always follows C99, so
- * division is truncated towards 0. This means that we can write the
- * overflow check like this:
- *
- * (a > 0 && (b > MAX/a || b < MIN/a)) ||
- * (a < -1 && (b > MIN/a || b < MAX/a) ||
- * (a == -1 && b == MIN)
- *
- * The redundant casts of -1 are to silence an annoying -Wtype-limits
- * (included in -Wextra) warning: When the type is u8 or u16, the
- * __b_c_e in check_mul_overflow obviously selects
- * __unsigned_mul_overflow, but unfortunately gcc still parses this
- * code and warns about the limited range of __b.
- */
-
-#define __signed_mul_overflow(a, b, d) ({                              \
-       typeof(a) __a = (a);                                            \
-       typeof(b) __b = (b);                                            \
-       typeof(d) __d = (d);                                            \
-       typeof(a) __tmax = type_max(typeof(a));                         \
-       typeof(a) __tmin = type_min(typeof(a));                         \
-       (void) (&__a == &__b);                                          \
-       (void) (&__a == __d);                                           \
-       *__d = (u64)__a * (u64)__b;                                     \
-       (__b > 0   && (__a > __tmax/__b || __a < __tmin/__b)) ||        \
-       (__b < (typeof(__b))-1  && (__a > __tmin/__b || __a < __tmax/__b)) || \
-       (__b == (typeof(__b))-1 && __a == __tmin);                      \
-})
-
-
-#define check_add_overflow(a, b, d)    __must_check_overflow(          \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_add_overflow(a, b, d),                 \
-                       __unsigned_add_overflow(a, b, d)))
-
-#define check_sub_overflow(a, b, d)    __must_check_overflow(          \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_sub_overflow(a, b, d),                 \
-                       __unsigned_sub_overflow(a, b, d)))
-
-#define check_mul_overflow(a, b, d)    __must_check_overflow(          \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_mul_overflow(a, b, d),                 \
-                       __unsigned_mul_overflow(a, b, d)))
-
-#endif /* COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW */
-
 /** check_shl_overflow() - Calculate a left-shifted value and check overflow
  *
  * @a: Value to be shifted
index 5466773..8d6571f 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: BSD-3-Clause
- * Copyright (c) 2016-2018, NXP Semiconductors
+ * Copyright 2016-2018 NXP
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
 #ifndef _LINUX_PACKING_H
index 5054802..2512e2f 100644 (file)
@@ -163,6 +163,12 @@ int arm_pmu_acpi_probe(armpmu_init_fn init_fn);
 static inline int arm_pmu_acpi_probe(armpmu_init_fn init_fn) { return 0; }
 #endif
 
+#ifdef CONFIG_KVM
+void kvm_host_pmu_init(struct arm_pmu *pmu);
+#else
+#define kvm_host_pmu_init(x)   do { } while(0)
+#endif
+
 /* Internal functions only for core arm_pmu code */
 struct arm_pmu *armpmu_alloc(void);
 struct arm_pmu *armpmu_alloc_atomic(void);
index fe156a8..9b60bb8 100644 (file)
@@ -683,7 +683,9 @@ struct perf_event {
        /*
         * timestamp shadows the actual context timing but it can
         * be safely used in NMI interrupt context. It reflects the
-        * context time as it was when the event was last scheduled in.
+        * context time as it was when the event was last scheduled in,
+        * or when ctx_sched_in failed to schedule the event because we
+        * run out of PMC.
         *
         * ctx_time already accounts for ctx->timestamp. Therefore to
         * compute ctx_time for a sample, simply add perf_clock().
index 6beb26b..86be8bf 100644 (file)
@@ -4,6 +4,8 @@
 
 #include <linux/mm.h>
 
+#define ARCH_DEFAULT_PKEY      0
+
 #ifdef CONFIG_ARCH_HAS_PKEYS
 #include <asm/pkeys.h>
 #else /* ! CONFIG_ARCH_HAS_PKEYS */
index 43b5ce1..878e572 100644 (file)
@@ -48,6 +48,8 @@ struct omap_usb_config {
        u32 (*usb2_init)(unsigned nwires, unsigned alt_pingroup);
 
        int (*ocpi_enable)(void);
+
+       void (*lb_reset)(void);
 };
 
 #endif /* __LINUX_USB_OMAP1_H */
index c0475d1..81cad9e 100644 (file)
@@ -61,7 +61,6 @@ enum qcom_scm_ice_cipher {
 #define QCOM_SCM_PERM_RW (QCOM_SCM_PERM_READ | QCOM_SCM_PERM_WRITE)
 #define QCOM_SCM_PERM_RWX (QCOM_SCM_PERM_RW | QCOM_SCM_PERM_EXEC)
 
-#if IS_ENABLED(CONFIG_QCOM_SCM)
 extern bool qcom_scm_is_available(void);
 
 extern int qcom_scm_set_cold_boot_addr(void *entry, const cpumask_t *cpus);
@@ -115,74 +114,4 @@ extern int qcom_scm_lmh_dcvsh(u32 payload_fn, u32 payload_reg, u32 payload_val,
 extern int qcom_scm_lmh_profile_change(u32 profile_id);
 extern bool qcom_scm_lmh_dcvsh_available(void);
 
-#else
-
-#include <linux/errno.h>
-
-static inline bool qcom_scm_is_available(void) { return false; }
-
-static inline int qcom_scm_set_cold_boot_addr(void *entry,
-               const cpumask_t *cpus) { return -ENODEV; }
-static inline int qcom_scm_set_warm_boot_addr(void *entry,
-               const cpumask_t *cpus) { return -ENODEV; }
-static inline void qcom_scm_cpu_power_down(u32 flags) {}
-static inline u32 qcom_scm_set_remote_state(u32 state,u32 id)
-               { return -ENODEV; }
-
-static inline int qcom_scm_pas_init_image(u32 peripheral, const void *metadata,
-               size_t size) { return -ENODEV; }
-static inline int qcom_scm_pas_mem_setup(u32 peripheral, phys_addr_t addr,
-               phys_addr_t size) { return -ENODEV; }
-static inline int qcom_scm_pas_auth_and_reset(u32 peripheral)
-               { return -ENODEV; }
-static inline int qcom_scm_pas_shutdown(u32 peripheral) { return -ENODEV; }
-static inline bool qcom_scm_pas_supported(u32 peripheral) { return false; }
-
-static inline int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val)
-               { return -ENODEV; }
-static inline int qcom_scm_io_writel(phys_addr_t addr, unsigned int val)
-               { return -ENODEV; }
-
-static inline bool qcom_scm_restore_sec_cfg_available(void) { return false; }
-static inline int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare)
-               { return -ENODEV; }
-static inline int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size)
-               { return -ENODEV; }
-static inline int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare)
-               { return -ENODEV; }
-extern inline int qcom_scm_mem_protect_video_var(u32 cp_start, u32 cp_size,
-                                                u32 cp_nonpixel_start,
-                                                u32 cp_nonpixel_size)
-               { return -ENODEV; }
-static inline int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
-               unsigned int *src, const struct qcom_scm_vmperm *newvm,
-               unsigned int dest_cnt) { return -ENODEV; }
-
-static inline bool qcom_scm_ocmem_lock_available(void) { return false; }
-static inline int qcom_scm_ocmem_lock(enum qcom_scm_ocmem_client id, u32 offset,
-               u32 size, u32 mode) { return -ENODEV; }
-static inline int qcom_scm_ocmem_unlock(enum qcom_scm_ocmem_client id,
-               u32 offset, u32 size) { return -ENODEV; }
-
-static inline bool qcom_scm_ice_available(void) { return false; }
-static inline int qcom_scm_ice_invalidate_key(u32 index) { return -ENODEV; }
-static inline int qcom_scm_ice_set_key(u32 index, const u8 *key, u32 key_size,
-                                      enum qcom_scm_ice_cipher cipher,
-                                      u32 data_unit_size) { return -ENODEV; }
-
-static inline bool qcom_scm_hdcp_available(void) { return false; }
-static inline int qcom_scm_hdcp_req(struct qcom_scm_hdcp_req *req, u32 req_cnt,
-               u32 *resp) { return -ENODEV; }
-
-static inline int qcom_scm_qsmmu500_wait_safe_toggle(bool en)
-               { return -ENODEV; }
-
-static inline int qcom_scm_lmh_dcvsh(u32 payload_fn, u32 payload_reg, u32 payload_val,
-                                    u64 limit_node, u32 node_id, u64 version)
-               { return -ENODEV; }
-
-static inline int qcom_scm_lmh_profile_change(u32 profile_id) { return -ENODEV; }
-
-static inline bool qcom_scm_lmh_dcvsh_available(void) { return -ENODEV; }
-#endif
 #endif
index e12b524..c1a927d 100644 (file)
@@ -1471,6 +1471,7 @@ struct task_struct {
                                        mce_whole_page : 1,
                                        __mce_reserved : 62;
        struct callback_head            mce_kill_me;
+       int                             mce_count;
 #endif
 
 #ifdef CONFIG_KRETPROBES
@@ -1719,7 +1720,7 @@ extern struct pid *cad_pid;
 #define tsk_used_math(p)                       ((p)->flags & PF_USED_MATH)
 #define used_math()                            tsk_used_math(current)
 
-static inline bool is_percpu_thread(void)
+static __always_inline bool is_percpu_thread(void)
 {
 #ifdef CONFIG_SMP
        return (current->flags & PF_NO_SETAFFINITY) &&
index 6bdb0db..841e2f0 100644 (file)
@@ -1940,7 +1940,7 @@ static inline void __skb_insert(struct sk_buff *newsk,
        WRITE_ONCE(newsk->prev, prev);
        WRITE_ONCE(next->prev, newsk);
        WRITE_ONCE(prev->next, newsk);
-       list->qlen++;
+       WRITE_ONCE(list->qlen, list->qlen + 1);
 }
 
 static inline void __skb_queue_splice(const struct sk_buff_head *list,
index 137f9f2..23c5b30 100644 (file)
@@ -7,6 +7,7 @@
 #include <linux/device.h>
 #include <linux/mod_devicetable.h>
 #include <dt-bindings/soc/qcom,apr.h>
+#include <dt-bindings/soc/qcom,gpr.h>
 
 extern struct bus_type aprbus;
 
@@ -75,10 +76,65 @@ struct apr_resp_pkt {
        int payload_size;
 };
 
+struct gpr_hdr {
+       uint32_t version:4;
+       uint32_t hdr_size:4;
+       uint32_t pkt_size:24;
+       uint32_t dest_domain:8;
+       uint32_t src_domain:8;
+       uint32_t reserved:16;
+       uint32_t src_port;
+       uint32_t dest_port;
+       uint32_t token;
+       uint32_t opcode;
+} __packed;
+
+struct gpr_pkt {
+       struct gpr_hdr hdr;
+       uint32_t payload[];
+};
+
+struct gpr_resp_pkt {
+       struct gpr_hdr hdr;
+       void *payload;
+       int payload_size;
+};
+
+#define GPR_HDR_SIZE                   sizeof(struct gpr_hdr)
+#define GPR_PKT_VER                    0x0
+#define GPR_PKT_HEADER_WORD_SIZE       ((sizeof(struct gpr_pkt) + 3) >> 2)
+#define GPR_PKT_HEADER_BYTE_SIZE       (GPR_PKT_HEADER_WORD_SIZE << 2)
+
+#define GPR_BASIC_RSP_RESULT           0x02001005
+
+struct gpr_ibasic_rsp_result_t {
+       uint32_t opcode;
+       uint32_t status;
+};
+
+#define GPR_BASIC_EVT_ACCEPTED         0x02001006
+
+struct gpr_ibasic_rsp_accepted_t {
+       uint32_t opcode;
+};
+
 /* Bits 0 to 15 -- Minor version,  Bits 16 to 31 -- Major version */
 #define APR_SVC_MAJOR_VERSION(v)       ((v >> 16) & 0xFF)
 #define APR_SVC_MINOR_VERSION(v)       (v & 0xFF)
 
+typedef int (*gpr_port_cb) (struct gpr_resp_pkt *d, void *priv, int op);
+struct packet_router;
+struct pkt_router_svc {
+       struct device *dev;
+       gpr_port_cb callback;
+       struct packet_router *pr;
+       spinlock_t lock;
+       int id;
+       void *priv;
+};
+
+typedef struct pkt_router_svc gpr_port_t;
+
 struct apr_device {
        struct device   dev;
        uint16_t        svc_id;
@@ -86,21 +142,26 @@ struct apr_device {
        uint32_t        version;
        char name[APR_NAME_SIZE];
        const char *service_path;
-       spinlock_t      lock;
+       struct pkt_router_svc svc;
        struct list_head node;
 };
 
+typedef struct apr_device gpr_device_t;
+
 #define to_apr_device(d) container_of(d, struct apr_device, dev)
+#define svc_to_apr_device(d) container_of(d, struct apr_device, svc)
 
 struct apr_driver {
        int     (*probe)(struct apr_device *sl);
        int     (*remove)(struct apr_device *sl);
        int     (*callback)(struct apr_device *a,
                            struct apr_resp_pkt *d);
+       int     (*gpr_callback)(struct gpr_resp_pkt *d, void *data, int op);
        struct device_driver            driver;
        const struct apr_device_id      *id_table;
 };
 
+typedef struct apr_driver gpr_driver_t;
 #define to_apr_driver(d) container_of(d, struct apr_driver, driver)
 
 /*
@@ -123,7 +184,14 @@ void apr_driver_unregister(struct apr_driver *drv);
 #define module_apr_driver(__apr_driver) \
        module_driver(__apr_driver, apr_driver_register, \
                        apr_driver_unregister)
+#define module_gpr_driver(__gpr_driver) module_apr_driver(__gpr_driver)
 
 int apr_send_pkt(struct apr_device *adev, struct apr_pkt *pkt);
 
+gpr_port_t *gpr_alloc_port(gpr_device_t *gdev, struct device *dev,
+                               gpr_port_cb cb, void *priv);
+void gpr_free_port(gpr_port_t *port);
+int gpr_send_port_pkt(gpr_port_t *port, struct gpr_pkt *pkt);
+int gpr_send_pkt(gpr_device_t *gdev, struct gpr_pkt *pkt);
+
 #endif /* __QCOM_APR_H_ */
index 8371bca..6b0b686 100644 (file)
@@ -531,6 +531,9 @@ struct spi_controller {
        /* I/O mutex */
        struct mutex            io_mutex;
 
+       /* Used to avoid adding the same CS twice */
+       struct mutex            add_lock;
+
        /* lock and mutex for SPI bus locking */
        spinlock_t              bus_lock_spinlock;
        struct mutex            bus_lock_mutex;
index 3e80c4b..2564b74 100644 (file)
@@ -197,6 +197,8 @@ static inline void tracehook_notify_resume(struct pt_regs *regs)
 
        mem_cgroup_handle_over_high();
        blkcg_maybe_throttle_current();
+
+       rseq_handle_notify_resume(NULL, regs);
 }
 
 /*
index 5265024..207101a 100644 (file)
@@ -27,6 +27,12 @@ enum iter_type {
        ITER_DISCARD,
 };
 
+struct iov_iter_state {
+       size_t iov_offset;
+       size_t count;
+       unsigned long nr_segs;
+};
+
 struct iov_iter {
        u8 iter_type;
        bool data_source;
@@ -47,7 +53,6 @@ struct iov_iter {
                };
                loff_t xarray_start;
        };
-       size_t truncated;
 };
 
 static inline enum iter_type iov_iter_type(const struct iov_iter *i)
@@ -55,6 +60,14 @@ static inline enum iter_type iov_iter_type(const struct iov_iter *i)
        return i->iter_type;
 }
 
+static inline void iov_iter_save_state(struct iov_iter *iter,
+                                      struct iov_iter_state *state)
+{
+       state->iov_offset = iter->iov_offset;
+       state->count = iter->count;
+       state->nr_segs = iter->nr_segs;
+}
+
 static inline bool iter_is_iovec(const struct iov_iter *i)
 {
        return iov_iter_type(i) == ITER_IOVEC;
@@ -233,6 +246,7 @@ ssize_t iov_iter_get_pages(struct iov_iter *i, struct page **pages,
 ssize_t iov_iter_get_pages_alloc(struct iov_iter *i, struct page ***pages,
                        size_t maxsize, size_t *start);
 int iov_iter_npages(const struct iov_iter *i, int maxpages);
+void iov_iter_restore(struct iov_iter *i, struct iov_iter_state *state);
 
 const void *dup_iter(struct iov_iter *new, struct iov_iter *old, gfp_t flags);
 
@@ -255,10 +269,8 @@ static inline void iov_iter_truncate(struct iov_iter *i, u64 count)
         * conversion in assignement is by definition greater than all
         * values of size_t, including old i->count.
         */
-       if (i->count > count) {
-               i->truncated += i->count - count;
+       if (i->count > count)
                i->count = count;
-       }
 }
 
 /*
@@ -267,7 +279,6 @@ static inline void iov_iter_truncate(struct iov_iter *i, u64 count)
  */
 static inline void iov_iter_reexpand(struct iov_iter *i, size_t count)
 {
-       i->truncated -= count - i->count;
        i->count = count;
 }
 
index 548a028..2c1fc92 100644 (file)
@@ -124,6 +124,7 @@ struct usb_hcd {
 #define HCD_FLAG_RH_RUNNING            5       /* root hub is running? */
 #define HCD_FLAG_DEAD                  6       /* controller has died? */
 #define HCD_FLAG_INTF_AUTHORIZED       7       /* authorize interfaces? */
+#define HCD_FLAG_DEFER_RH_REGISTER     8       /* Defer roothub registration */
 
        /* The flags can be tested using these macros; they are likely to
         * be slightly faster than test_bit().
@@ -134,6 +135,7 @@ struct usb_hcd {
 #define HCD_WAKEUP_PENDING(hcd)        ((hcd)->flags & (1U << HCD_FLAG_WAKEUP_PENDING))
 #define HCD_RH_RUNNING(hcd)    ((hcd)->flags & (1U << HCD_FLAG_RH_RUNNING))
 #define HCD_DEAD(hcd)          ((hcd)->flags & (1U << HCD_FLAG_DEAD))
+#define HCD_DEFER_RH_REGISTER(hcd) ((hcd)->flags & (1U << HCD_FLAG_DEFER_RH_REGISTER))
 
        /*
         * Specifies if interfaces are authorized by default
index 2ebef6b..74d3c1e 100644 (file)
@@ -399,9 +399,8 @@ extern struct workqueue_struct *system_freezable_power_efficient_wq;
  * RETURNS:
  * Pointer to the allocated workqueue on success, %NULL on failure.
  */
-struct workqueue_struct *alloc_workqueue(const char *fmt,
-                                        unsigned int flags,
-                                        int max_active, ...);
+__printf(1, 4) struct workqueue_struct *
+alloc_workqueue(const char *fmt, unsigned int flags, int max_active, ...);
 
 /**
  * alloc_ordered_workqueue - allocate an ordered workqueue
index f9a1714..d784e76 100644 (file)
@@ -447,6 +447,11 @@ static inline bool dsa_port_is_user(struct dsa_port *dp)
        return dp->type == DSA_PORT_TYPE_USER;
 }
 
+static inline bool dsa_port_is_unused(struct dsa_port *dp)
+{
+       return dp->type == DSA_PORT_TYPE_UNUSED;
+}
+
 static inline bool dsa_is_unused_port(struct dsa_switch *ds, int p)
 {
        return dsa_to_port(ds, p)->type == DSA_PORT_TYPE_UNUSED;
@@ -580,8 +585,16 @@ struct dsa_switch_ops {
        int     (*change_tag_protocol)(struct dsa_switch *ds, int port,
                                       enum dsa_tag_protocol proto);
 
+       /* Optional switch-wide initialization and destruction methods */
        int     (*setup)(struct dsa_switch *ds);
        void    (*teardown)(struct dsa_switch *ds);
+
+       /* Per-port initialization and destruction methods. Mandatory if the
+        * driver registers devlink port regions, optional otherwise.
+        */
+       int     (*port_setup)(struct dsa_switch *ds, int port);
+       void    (*port_teardown)(struct dsa_switch *ds, int port);
+
        u32     (*get_phy_flags)(struct dsa_switch *ds, int port);
 
        /*
@@ -1041,6 +1054,7 @@ static inline int dsa_ndo_eth_ioctl(struct net_device *dev, struct ifreq *ifr,
 
 void dsa_unregister_switch(struct dsa_switch *ds);
 int dsa_register_switch(struct dsa_switch *ds);
+void dsa_switch_shutdown(struct dsa_switch *ds);
 struct dsa_switch *dsa_switch_find(int tree_index, int sw_index);
 #ifdef CONFIG_PM_SLEEP
 int dsa_switch_suspend(struct dsa_switch *ds);
index 21c5386..ab5348e 100644 (file)
@@ -597,5 +597,5 @@ int ip_valid_fib_dump_req(struct net *net, const struct nlmsghdr *nlh,
 int fib_nexthop_info(struct sk_buff *skb, const struct fib_nh_common *nh,
                     u8 rt_family, unsigned char *flags, bool skip_oif);
 int fib_add_nexthop(struct sk_buff *skb, const struct fib_nh_common *nh,
-                   int nh_weight, u8 rt_family);
+                   int nh_weight, u8 rt_family, u32 nh_tclassid);
 #endif  /* _NET_FIB_H */
index af0fc13..618d1f4 100644 (file)
@@ -2818,13 +2818,13 @@ void ieee80211_free_txskb(struct ieee80211_hw *hw, struct sk_buff *skb);
  * Mac80211 drivers should set the @NL80211_EXT_FEATURE_CAN_REPLACE_PTK0 flag
  * when they are able to replace in-use PTK keys according to the following
  * requirements:
- * 1) They do not hand over frames decrypted with the old key to
-      mac80211 once the call to set_key() with command %DISABLE_KEY has been
-      completed when also setting @IEEE80211_KEY_FLAG_GENERATE_IV for any key,
+ * 1) They do not hand over frames decrypted with the old key to mac80211
+      once the call to set_key() with command %DISABLE_KEY has been completed,
    2) either drop or continue to use the old key for any outgoing frames queued
       at the time of the key deletion (including re-transmits),
    3) never send out a frame queued prior to the set_key() %SET_KEY command
-      encrypted with the new key and
+      encrypted with the new key when also needing
+      @IEEE80211_KEY_FLAG_GENERATE_IV and
    4) never send out a frame unencrypted when it should be encrypted.
    Mac80211 will not queue any new frames for a deleted key to the driver.
  */
index 0fd8a41..ceadf8b 100644 (file)
@@ -17,7 +17,6 @@ struct inet_frags_ctl;
 struct nft_ct_frag6_pernet {
        struct ctl_table_header *nf_frag_frags_hdr;
        struct fqdir    *fqdir;
-       unsigned int users;
 };
 
 #endif /* _NF_DEFRAG_IPV6_H */
index 148f5d8..a16171c 100644 (file)
@@ -1202,7 +1202,7 @@ struct nft_object *nft_obj_lookup(const struct net *net,
 
 void nft_obj_notify(struct net *net, const struct nft_table *table,
                    struct nft_object *obj, u32 portid, u32 seq,
-                   int event, int family, int report, gfp_t gfp);
+                   int event, u16 flags, int family, int report, gfp_t gfp);
 
 /**
  *     struct nft_object_type - stateful object type
index 986a2a9..b593f95 100644 (file)
@@ -27,5 +27,11 @@ struct netns_nf {
 #if IS_ENABLED(CONFIG_DECNET)
        struct nf_hook_entries __rcu *hooks_decnet[NF_DN_NUMHOOKS];
 #endif
+#if IS_ENABLED(CONFIG_NF_DEFRAG_IPV4)
+       unsigned int defrag_ipv4_users;
+#endif
+#if IS_ENABLED(CONFIG_NF_DEFRAG_IPV6)
+       unsigned int defrag_ipv6_users;
+#endif
 };
 #endif
index 10e1777..28085b9 100644 (file)
@@ -325,7 +325,7 @@ int nexthop_mpath_fill_node(struct sk_buff *skb, struct nexthop *nh,
                struct fib_nh_common *nhc = &nhi->fib_nhc;
                int weight = nhg->nh_entries[i].weight;
 
-               if (fib_add_nexthop(skb, nhc, weight, rt_family) < 0)
+               if (fib_add_nexthop(skb, nhc, weight, rt_family, 0) < 0)
                        return -EMSGSIZE;
        }
 
index 6d7b12c..bf79f3a 100644 (file)
@@ -11,6 +11,7 @@
 #include <uapi/linux/pkt_sched.h>
 
 #define DEFAULT_TX_QUEUE_LEN   1000
+#define STAB_SIZE_LOG_MAX      30
 
 struct qdisc_walker {
        int     stop;
index 66a9a90..ea6fbc8 100644 (file)
@@ -307,6 +307,7 @@ struct bpf_local_storage;
   *    @sk_priority: %SO_PRIORITY setting
   *    @sk_type: socket type (%SOCK_STREAM, etc)
   *    @sk_protocol: which protocol this socket belongs in this network family
+  *    @sk_peer_lock: lock protecting @sk_peer_pid and @sk_peer_cred
   *    @sk_peer_pid: &struct pid for this socket's peer
   *    @sk_peer_cred: %SO_PEERCRED setting
   *    @sk_rcvlowat: %SO_RCVLOWAT setting
@@ -488,8 +489,10 @@ struct sock {
        u8                      sk_prefer_busy_poll;
        u16                     sk_busy_poll_budget;
 #endif
+       spinlock_t              sk_peer_lock;
        struct pid              *sk_peer_pid;
        const struct cred       *sk_peer_cred;
+
        long                    sk_rcvtimeo;
        ktime_t                 sk_stamp;
 #if BITS_PER_LONG==32
@@ -1623,7 +1626,36 @@ void release_sock(struct sock *sk);
                                SINGLE_DEPTH_NESTING)
 #define bh_unlock_sock(__sk)   spin_unlock(&((__sk)->sk_lock.slock))
 
-bool lock_sock_fast(struct sock *sk) __acquires(&sk->sk_lock.slock);
+bool __lock_sock_fast(struct sock *sk) __acquires(&sk->sk_lock.slock);
+
+/**
+ * lock_sock_fast - fast version of lock_sock
+ * @sk: socket
+ *
+ * This version should be used for very small section, where process wont block
+ * return false if fast path is taken:
+ *
+ *   sk_lock.slock locked, owned = 0, BH disabled
+ *
+ * return true if slow path is taken:
+ *
+ *   sk_lock.slock unlocked, owned = 1, BH enabled
+ */
+static inline bool lock_sock_fast(struct sock *sk)
+{
+       /* The sk_lock has mutex_lock() semantics here. */
+       mutex_acquire(&sk->sk_lock.dep_map, 0, 0, _RET_IP_);
+
+       return __lock_sock_fast(sk);
+}
+
+/* fast socket lock variant for caller already holding a [different] socket lock */
+static inline bool lock_sock_fast_nested(struct sock *sk)
+{
+       mutex_acquire(&sk->sk_lock.dep_map, SINGLE_DEPTH_NESTING, 0, _RET_IP_);
+
+       return __lock_sock_fast(sk);
+}
 
 /**
  * unlock_sock_fast - complement of lock_sock_fast
@@ -1640,6 +1672,7 @@ static inline void unlock_sock_fast(struct sock *sk, bool slow)
                release_sock(sk);
                __release(&sk->sk_lock.slock);
        } else {
+               mutex_release(&sk->sk_lock.dep_map, _RET_IP_);
                spin_unlock_bh(&sk->sk_lock.slock);
        }
 }
index 09a17f6..b97e142 100644 (file)
@@ -146,7 +146,6 @@ struct scsi_device {
        struct scsi_vpd __rcu *vpd_pg83;
        struct scsi_vpd __rcu *vpd_pg80;
        struct scsi_vpd __rcu *vpd_pg89;
-       unsigned char current_tag;      /* current tag */
        struct scsi_target      *sdev_target;
 
        blist_flags_t           sdev_bflags; /* black/white flags as also found in
index 06706a9..d7055b4 100644 (file)
 /* Source PGIDs, one per physical port */
 #define PGID_SRC                       80
 
-#define IFH_TAG_TYPE_C                 0
-#define IFH_TAG_TYPE_S                 1
-
-#define IFH_REW_OP_NOOP                        0x0
-#define IFH_REW_OP_DSCP                        0x1
-#define IFH_REW_OP_ONE_STEP_PTP                0x2
-#define IFH_REW_OP_TWO_STEP_PTP                0x3
-#define IFH_REW_OP_ORIGIN_PTP          0x5
-
 #define OCELOT_NUM_TC                  8
 
 #define OCELOT_SPEED_2500              0
@@ -603,10 +594,10 @@ struct ocelot_port {
        /* The VLAN ID that will be transmitted as untagged, on egress */
        struct ocelot_vlan              native_vlan;
 
+       unsigned int                    ptp_skbs_in_flight;
        u8                              ptp_cmd;
        struct sk_buff_head             tx_skbs;
        u8                              ts_id;
-       spinlock_t                      ts_id_lock;
 
        phy_interface_t                 phy_mode;
 
@@ -680,6 +671,9 @@ struct ocelot {
        struct ptp_clock                *ptp_clock;
        struct ptp_clock_info           ptp_info;
        struct hwtstamp_config          hwtstamp_config;
+       unsigned int                    ptp_skbs_in_flight;
+       /* Protects the 2-step TX timestamp ID logic */
+       spinlock_t                      ts_id_lock;
        /* Protects the PTP interface state */
        struct mutex                    ptp_lock;
        /* Protects the PTP clock */
@@ -692,15 +686,6 @@ struct ocelot_policer {
        u32 burst; /* bytes */
 };
 
-struct ocelot_skb_cb {
-       struct sk_buff *clone;
-       u8 ptp_cmd;
-       u8 ts_id;
-};
-
-#define OCELOT_SKB_CB(skb) \
-       ((struct ocelot_skb_cb *)((skb)->cb))
-
 #define ocelot_read_ix(ocelot, reg, gi, ri) __ocelot_read_ix(ocelot, reg, reg##_GSZ * (gi) + reg##_RSZ * (ri))
 #define ocelot_read_gix(ocelot, reg, gi) __ocelot_read_ix(ocelot, reg, reg##_GSZ * (gi))
 #define ocelot_read_rix(ocelot, reg, ri) __ocelot_read_ix(ocelot, reg, reg##_RSZ * (ri))
@@ -752,8 +737,6 @@ u32 __ocelot_target_read_ix(struct ocelot *ocelot, enum ocelot_target target,
 void __ocelot_target_write_ix(struct ocelot *ocelot, enum ocelot_target target,
                              u32 val, u32 reg, u32 offset);
 
-#if IS_ENABLED(CONFIG_MSCC_OCELOT_SWITCH_LIB)
-
 /* Packet I/O */
 bool ocelot_can_inject(struct ocelot *ocelot, int grp);
 void ocelot_port_inject_frame(struct ocelot *ocelot, int port, int grp,
@@ -761,36 +744,6 @@ void ocelot_port_inject_frame(struct ocelot *ocelot, int port, int grp,
 int ocelot_xtr_poll_frame(struct ocelot *ocelot, int grp, struct sk_buff **skb);
 void ocelot_drain_cpu_queue(struct ocelot *ocelot, int grp);
 
-u32 ocelot_ptp_rew_op(struct sk_buff *skb);
-#else
-
-static inline bool ocelot_can_inject(struct ocelot *ocelot, int grp)
-{
-       return false;
-}
-
-static inline void ocelot_port_inject_frame(struct ocelot *ocelot, int port,
-                                           int grp, u32 rew_op,
-                                           struct sk_buff *skb)
-{
-}
-
-static inline int ocelot_xtr_poll_frame(struct ocelot *ocelot, int grp,
-                                       struct sk_buff **skb)
-{
-       return -EIO;
-}
-
-static inline void ocelot_drain_cpu_queue(struct ocelot *ocelot, int grp)
-{
-}
-
-static inline u32 ocelot_ptp_rew_op(struct sk_buff *skb)
-{
-       return 0;
-}
-#endif
-
 /* Hardware initialization */
 int ocelot_regfields_init(struct ocelot *ocelot,
                          const struct reg_field *const regfields);
index ded497d..f085884 100644 (file)
@@ -13,6 +13,9 @@
 #include <linux/ptp_clock_kernel.h>
 #include <soc/mscc/ocelot.h>
 
+#define OCELOT_MAX_PTP_ID              63
+#define OCELOT_PTP_FIFO_SIZE           128
+
 #define PTP_PIN_CFG_RSZ                        0x20
 #define PTP_PIN_TOD_SEC_MSB_RSZ                PTP_PIN_CFG_RSZ
 #define PTP_PIN_TOD_SEC_LSB_RSZ                PTP_PIN_CFG_RSZ
index 25fd525..4869ebb 100644 (file)
@@ -694,7 +694,7 @@ int ocelot_vcap_filter_add(struct ocelot *ocelot,
 int ocelot_vcap_filter_del(struct ocelot *ocelot,
                           struct ocelot_vcap_filter *rule);
 struct ocelot_vcap_filter *
-ocelot_vcap_block_find_filter_by_id(struct ocelot_vcap_block *block, int id,
-                                   bool tc_offload);
+ocelot_vcap_block_find_filter_by_id(struct ocelot_vcap_block *block,
+                                   unsigned long cookie, bool tc_offload);
 
 #endif /* _OCELOT_VCAP_H_ */
diff --git a/include/sound/cs35l41.h b/include/sound/cs35l41.h
new file mode 100644 (file)
index 0000000..1f1e3c6
--- /dev/null
@@ -0,0 +1,34 @@
+/* SPDX-License-Identifier: GPL-2.0
+ *
+ * linux/sound/cs35l41.h -- Platform data for CS35L41
+ *
+ * Copyright (c) 2017-2021 Cirrus Logic Inc.
+ *
+ * Author: David Rhodes        <david.rhodes@cirrus.com>
+ */
+
+#ifndef __CS35L41_H
+#define __CS35L41_H
+
+enum cs35l41_clk_ids {
+       CS35L41_CLKID_SCLK = 0,
+       CS35L41_CLKID_LRCLK = 1,
+       CS35L41_CLKID_MCLK = 4,
+};
+
+struct cs35l41_irq_cfg {
+       bool irq_pol_inv;
+       bool irq_out_en;
+       int irq_src_sel;
+};
+
+struct cs35l41_platform_data {
+       int bst_ind;
+       int bst_ipk;
+       int bst_cap;
+       int dout_hiz;
+       struct cs35l41_irq_cfg irq_config1;
+       struct cs35l41_irq_cfg irq_config2;
+};
+
+#endif /* __CS35L41_H */
index 6f10bfb..4c8b94c 100644 (file)
@@ -9,6 +9,27 @@
 
 #include <sound/simple_card_utils.h>
 
+typedef int (*GRAPH2_CUSTOM)(struct asoc_simple_priv *priv,
+                            struct device_node *lnk,
+                            struct link_info *li);
+
+struct graph2_custom_hooks {
+       int (*hook_pre)(struct asoc_simple_priv *priv);
+       int (*hook_post)(struct asoc_simple_priv *priv);
+       GRAPH2_CUSTOM custom_normal;
+       GRAPH2_CUSTOM custom_dpcm;
+       GRAPH2_CUSTOM custom_c2c;
+};
+
 int audio_graph_parse_of(struct asoc_simple_priv *priv, struct device *dev);
+int audio_graph2_parse_of(struct asoc_simple_priv *priv, struct device *dev,
+                         struct graph2_custom_hooks *hooks);
+
+int audio_graph2_link_normal(struct asoc_simple_priv *priv,
+                            struct device_node *lnk, struct link_info *li);
+int audio_graph2_link_dpcm(struct asoc_simple_priv *priv,
+                          struct device_node *lnk, struct link_info *li);
+int audio_graph2_link_c2c(struct asoc_simple_priv *priv,
+                         struct device_node *lnk, struct link_info *li);
 
 #endif /* __GRAPH_CARD_H */
diff --git a/include/sound/rt5682s.h b/include/sound/rt5682s.h
new file mode 100644 (file)
index 0000000..accfbc2
--- /dev/null
@@ -0,0 +1,48 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * linux/sound/rt5682s.h -- Platform data for RT5682I-VS
+ *
+ * Copyright 2021 Realtek Microelectronics
+ */
+
+#ifndef __LINUX_SND_RT5682S_H
+#define __LINUX_SND_RT5682S_H
+
+enum rt5682s_dmic1_data_pin {
+       RT5682S_DMIC1_DATA_NULL,
+       RT5682S_DMIC1_DATA_GPIO2,
+       RT5682S_DMIC1_DATA_GPIO5,
+};
+
+enum rt5682s_dmic1_clk_pin {
+       RT5682S_DMIC1_CLK_NULL,
+       RT5682S_DMIC1_CLK_GPIO1,
+       RT5682S_DMIC1_CLK_GPIO3,
+};
+
+enum rt5682s_jd_src {
+       RT5682S_JD_NULL,
+       RT5682S_JD1,
+};
+
+enum rt5682s_dai_clks {
+       RT5682S_DAI_WCLK_IDX,
+       RT5682S_DAI_BCLK_IDX,
+       RT5682S_DAI_NUM_CLKS,
+};
+
+struct rt5682s_platform_data {
+
+       int ldo1_en; /* GPIO for LDO1_EN */
+
+       enum rt5682s_dmic1_data_pin dmic1_data_pin;
+       enum rt5682s_dmic1_clk_pin dmic1_clk_pin;
+       enum rt5682s_jd_src jd_src;
+       unsigned int dmic_clk_rate;
+       unsigned int dmic_delay;
+       bool dmic_clk_driving_high;
+
+       const char *dai_clk_names[RT5682S_DAI_NUM_CLKS];
+};
+
+#endif
index 51b3b48..df430f1 100644 (file)
@@ -42,6 +42,7 @@ struct prop_nums {
        int cpus;
        int codecs;
        int platforms;
+       int c2c;
 };
 
 struct asoc_simple_priv {
@@ -54,6 +55,7 @@ struct asoc_simple_priv {
                struct snd_soc_dai_link_component *platforms;
                struct asoc_simple_data adata;
                struct snd_soc_codec_conf *codec_conf;
+               struct snd_soc_pcm_stream *c2c_conf;
                struct prop_nums num;
                unsigned int mclk_fs;
        } *dai_props;
@@ -64,6 +66,7 @@ struct asoc_simple_priv {
        struct snd_soc_dai_link_component *dlcs;
        struct snd_soc_dai_link_component dummy;
        struct snd_soc_codec_conf *codec_conf;
+       struct snd_soc_pcm_stream *c2c_conf;
        struct gpio_desc *pa_gpio;
        const struct snd_soc_ops *ops;
        unsigned int dpcm_selectable:1;
@@ -115,7 +118,7 @@ struct asoc_simple_priv {
                     ((codec) = simple_props_to_dai_codec(props, i));   \
             (i)++)
 
-#define SNDRV_MAX_LINKS 128
+#define SNDRV_MAX_LINKS 512
 
 struct link_info {
        int link; /* number of link */
@@ -180,6 +183,7 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
 int asoc_simple_remove(struct platform_device *pdev);
 
 int asoc_graph_card_probe(struct snd_soc_card *card);
+int asoc_graph_is_ports0(struct device_node *port);
 
 #ifdef DEBUG
 static inline void asoc_simple_debug_dai(struct asoc_simple_priv *priv,
index 2f3fa38..31f4c4f 100644 (file)
@@ -129,6 +129,8 @@ struct snd_soc_acpi_link_adr {
  * all firmware/topology related fields.
  *
  * @id: ACPI ID (usually the codec's) used to find a matching machine driver.
+ * @comp_ids: list of compatible audio codecs using the same machine driver,
+ * firmware and topology
  * @link_mask: describes required board layout, e.g. for SoundWire.
  * @links: array of link _ADR descriptors, null terminated.
  * @drv_name: machine driver name
@@ -146,6 +148,7 @@ struct snd_soc_acpi_link_adr {
 /* Descriptor for SST ASoC machine driver */
 struct snd_soc_acpi_mach {
        const u8 id[ACPI_ID_LEN];
+       const struct snd_soc_acpi_codecs *comp_ids;
        const u32 link_mask;
        const struct snd_soc_acpi_link_adr *links;
        const char *drv_name;
index 8c4d683..a431714 100644 (file)
@@ -220,17 +220,15 @@ struct snd_soc_component {
        int (*init)(struct snd_soc_component *component);
 
        /* function mark */
-       struct snd_pcm_substream *mark_module;
+       void *mark_module;
        struct snd_pcm_substream *mark_open;
        struct snd_pcm_substream *mark_hw_params;
        struct snd_pcm_substream *mark_trigger;
        struct snd_compr_stream  *mark_compr_open;
        void *mark_pm;
 
-#ifdef CONFIG_DEBUG_FS
        struct dentry *debugfs_root;
        const char *debugfs_prefix;
-#endif
 };
 
 #define for_each_component_dais(component, dai)\
@@ -335,6 +333,11 @@ static inline int snd_soc_component_cache_sync(
        return regcache_sync(component->regmap);
 }
 
+static inline int snd_soc_component_is_codec(struct snd_soc_component *component)
+{
+       return component->driver->non_legacy_dai_naming;
+}
+
 void snd_soc_component_set_aux(struct snd_soc_component *component,
                               struct snd_soc_aux_dev *aux);
 int snd_soc_component_init(struct snd_soc_component *component);
@@ -391,15 +394,13 @@ void snd_soc_component_exit_regmap(struct snd_soc_component *component);
 #define snd_soc_component_module_get_when_open(component, substream)   \
        snd_soc_component_module_get(component, substream, 1)
 int snd_soc_component_module_get(struct snd_soc_component *component,
-                                struct snd_pcm_substream *substream,
-                                int upon_open);
+                                void *mark, int upon_open);
 #define snd_soc_component_module_put_when_remove(component)    \
        snd_soc_component_module_put(component, NULL, 0, 0)
 #define snd_soc_component_module_put_when_close(component, substream, rollback) \
        snd_soc_component_module_put(component, substream, 1, rollback)
 void snd_soc_component_module_put(struct snd_soc_component *component,
-                                 struct snd_pcm_substream *substream,
-                                 int upon_open, int rollback);
+                                 void *mark, int upon_open, int rollback);
 
 static inline void snd_soc_component_set_drvdata(struct snd_soc_component *c,
                                                 void *data)
@@ -455,8 +456,10 @@ int snd_soc_component_of_xlate_dai_id(struct snd_soc_component *component,
 int snd_soc_component_of_xlate_dai_name(struct snd_soc_component *component,
                                        const struct of_phandle_args *args,
                                        const char **dai_name);
-int snd_soc_component_compr_open(struct snd_compr_stream *cstream);
-void snd_soc_component_compr_free(struct snd_compr_stream *cstream,
+int snd_soc_component_compr_open(struct snd_soc_component *component,
+                                struct snd_compr_stream *cstream);
+void snd_soc_component_compr_free(struct snd_soc_component *component,
+                                 struct snd_compr_stream *cstream,
                                  int rollback);
 int snd_soc_component_compr_trigger(struct snd_compr_stream *cstream, int cmd);
 int snd_soc_component_compr_set_params(struct snd_compr_stream *cstream,
index e296a39..bc7af90 100644 (file)
@@ -159,6 +159,7 @@ int dpcm_be_dai_trigger(struct snd_soc_pcm_runtime *fe, int stream, int cmd);
 int dpcm_be_dai_prepare(struct snd_soc_pcm_runtime *fe, int stream);
 int dpcm_dapm_stream_event(struct snd_soc_pcm_runtime *fe, int dir,
        int event);
+bool dpcm_end_walk_at_be(struct snd_soc_dapm_widget *widget, enum snd_soc_dapm_direction dir);
 
 #define dpcm_be_dai_startup_rollback(fe, stream, last) \
                                                dpcm_be_dai_stop(fe, stream, 0, last)
index 4afd667..b4b896f 100644 (file)
@@ -151,7 +151,7 @@ struct snd_soc_tplg_ops {
                struct snd_soc_tplg_hdr *);
 
        /* completion - called at completion of firmware loading */
-       void (*complete)(struct snd_soc_component *);
+       int (*complete)(struct snd_soc_component *comp);
 
        /* manifest - optional to inform component of manifest */
        int (*manifest)(struct snd_soc_component *, int index,
@@ -188,8 +188,7 @@ int snd_soc_tplg_widget_bind_event(struct snd_soc_dapm_widget *w,
 
 #else
 
-static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp,
-                                               u32 index)
+static inline int snd_soc_tplg_component_remove(struct snd_soc_component *comp)
 {
        return 0;
 }
index 6a1cd8e..23b3743 100644 (file)
@@ -74,11 +74,6 @@ struct sof_dev_desc {
        int resindex_pcicfg_base;
        int resindex_imr_base;
        int irqindex_host_ipc;
-       int resindex_dma_base;
-
-       /* DMA only valid when resindex_dma_base != -1*/
-       int dma_engine;
-       int dma_size;
 
        /* IPC timeouts in ms */
        int ipc_timeout;
index 136adf6..7a266f4 100644 (file)
 #define SOF_DAI_INTEL_SSP_CLKCTRL_FS_KA                        BIT(4)
 /* bclk idle */
 #define SOF_DAI_INTEL_SSP_CLKCTRL_BCLK_IDLE_HIGH       BIT(5)
+/* mclk early start */
+#define SOF_DAI_INTEL_SSP_CLKCTRL_MCLK_ES               BIT(6)
+/* bclk early start */
+#define SOF_DAI_INTEL_SSP_CLKCTRL_BCLK_ES               BIT(7)
 
 /* DMIC max. four controllers for eight microphone channels */
 #define SOF_DAI_INTEL_DMIC_NUM_CTRL                    4
index 6bb403e..9625f47 100644 (file)
 #define SOF_DAI_FMT_INV_MASK           0x0f00
 #define SOF_DAI_FMT_CLOCK_PROVIDER_MASK        0xf000
 
+/* DAI_CONFIG flags */
+#define SOF_DAI_CONFIG_FLAGS_MASK      0x3
+#define SOF_DAI_CONFIG_FLAGS_NONE      (0 << 0) /**< DAI_CONFIG sent without stage information */
+#define SOF_DAI_CONFIG_FLAGS_HW_PARAMS (1 << 0) /**< DAI_CONFIG sent during hw_params stage */
+#define SOF_DAI_CONFIG_FLAGS_HW_FREE   (2 << 0) /**< DAI_CONFIG sent during hw_free stage */
+#define SOF_DAI_CONFIG_FLAGS_RFU       (3 << 0) /**< not used, reserved for future use */
+
 /** \brief Types of DAI */
 enum sof_ipc_dai_type {
        SOF_DAI_INTEL_NONE = 0,         /**< None */
@@ -69,7 +76,8 @@ struct sof_ipc_dai_config {
 
        /* physical protocol and clocking */
        uint16_t format;        /**< SOF_DAI_FMT_ */
-       uint16_t reserved16;    /**< alignment */
+       uint8_t group_id;       /**< group ID, 0 means no group (ABI 3.17) */
+       uint8_t flags;          /**< SOF_DAI_CONFIG_FLAGS_ (ABI 3.19) */
 
        /* reserved for future use */
        uint32_t reserved[8];
index 9f73ed2..bca73e8 100644 (file)
@@ -306,11 +306,13 @@ enum afs_flock_operation {
 
 enum afs_cb_break_reason {
        afs_cb_break_no_break,
+       afs_cb_break_no_promise,
        afs_cb_break_for_callback,
        afs_cb_break_for_deleted,
        afs_cb_break_for_lapsed,
+       afs_cb_break_for_s_reinit,
        afs_cb_break_for_unlink,
-       afs_cb_break_for_vsbreak,
+       afs_cb_break_for_v_break,
        afs_cb_break_for_volume_callback,
        afs_cb_break_for_zap,
 };
@@ -602,11 +604,13 @@ enum afs_cb_break_reason {
 
 #define afs_cb_break_reasons                                           \
        EM(afs_cb_break_no_break,               "no-break")             \
+       EM(afs_cb_break_no_promise,             "no-promise")           \
        EM(afs_cb_break_for_callback,           "break-cb")             \
        EM(afs_cb_break_for_deleted,            "break-del")            \
        EM(afs_cb_break_for_lapsed,             "break-lapsed")         \
+       EM(afs_cb_break_for_s_reinit,           "s-reinit")             \
        EM(afs_cb_break_for_unlink,             "break-unlink")         \
-       EM(afs_cb_break_for_vsbreak,            "break-vs")             \
+       EM(afs_cb_break_for_v_break,            "break-v")              \
        EM(afs_cb_break_for_volume_callback,    "break-v-cb")           \
        E_(afs_cb_break_for_zap,                "break-zap")
 
index 9a448fe..920b6a3 100644 (file)
@@ -178,7 +178,7 @@ TRACE_EVENT(cachefiles_unlink,
                             ),
 
            TP_fast_assign(
-                   __entry->obj        = obj->fscache.debug_id;
+                   __entry->obj        = obj ? obj->fscache.debug_id : UINT_MAX;
                    __entry->de         = de;
                    __entry->why        = why;
                           ),
@@ -205,7 +205,7 @@ TRACE_EVENT(cachefiles_rename,
                             ),
 
            TP_fast_assign(
-                   __entry->obj        = obj->fscache.debug_id;
+                   __entry->obj        = obj ? obj->fscache.debug_id : UINT_MAX;
                    __entry->de         = de;
                    __entry->to         = to;
                    __entry->why        = why;
@@ -305,7 +305,7 @@ TRACE_EVENT(cachefiles_mark_buried,
                             ),
 
            TP_fast_assign(
-                   __entry->obj        = obj->fscache.debug_id;
+                   __entry->obj        = obj ? obj->fscache.debug_id : UINT_MAX;
                    __entry->de         = de;
                    __entry->why        = why;
                           ),
index bf9806f..db4f2ce 100644 (file)
@@ -35,20 +35,20 @@ TRACE_EVENT(erofs_lookup,
        TP_STRUCT__entry(
                __field(dev_t,          dev     )
                __field(erofs_nid_t,    nid     )
-               __field(const char *,   name    )
+               __string(name,          dentry->d_name.name     )
                __field(unsigned int,   flags   )
        ),
 
        TP_fast_assign(
                __entry->dev    = dir->i_sb->s_dev;
                __entry->nid    = EROFS_I(dir)->nid;
-               __entry->name   = dentry->d_name.name;
+               __assign_str(name, dentry->d_name.name);
                __entry->flags  = flags;
        ),
 
        TP_printk("dev = (%d,%d), pnid = %llu, name:%s, flags:%x",
                show_dev_nid(__entry),
-               __entry->name,
+               __get_str(name),
                __entry->flags)
 );
 
index 491098a..bf7533f 100644 (file)
 
 TRACE_EVENT(kyber_latency,
 
-       TP_PROTO(struct request_queue *q, const char *domain, const char *type,
+       TP_PROTO(dev_t dev, const char *domain, const char *type,
                 unsigned int percentile, unsigned int numerator,
                 unsigned int denominator, unsigned int samples),
 
-       TP_ARGS(q, domain, type, percentile, numerator, denominator, samples),
+       TP_ARGS(dev, domain, type, percentile, numerator, denominator, samples),
 
        TP_STRUCT__entry(
                __field(        dev_t,  dev                             )
@@ -30,7 +30,7 @@ TRACE_EVENT(kyber_latency,
        ),
 
        TP_fast_assign(
-               __entry->dev            = disk_devt(q->disk);
+               __entry->dev            = dev;
                strlcpy(__entry->domain, domain, sizeof(__entry->domain));
                strlcpy(__entry->type, type, sizeof(__entry->type));
                __entry->percentile     = percentile;
@@ -47,10 +47,9 @@ TRACE_EVENT(kyber_latency,
 
 TRACE_EVENT(kyber_adjust,
 
-       TP_PROTO(struct request_queue *q, const char *domain,
-                unsigned int depth),
+       TP_PROTO(dev_t dev, const char *domain, unsigned int depth),
 
-       TP_ARGS(q, domain, depth),
+       TP_ARGS(dev, domain, depth),
 
        TP_STRUCT__entry(
                __field(        dev_t,  dev                     )
@@ -59,7 +58,7 @@ TRACE_EVENT(kyber_adjust,
        ),
 
        TP_fast_assign(
-               __entry->dev            = disk_devt(q->disk);
+               __entry->dev            = dev;
                strlcpy(__entry->domain, domain, sizeof(__entry->domain));
                __entry->depth          = depth;
        ),
@@ -71,9 +70,9 @@ TRACE_EVENT(kyber_adjust,
 
 TRACE_EVENT(kyber_throttled,
 
-       TP_PROTO(struct request_queue *q, const char *domain),
+       TP_PROTO(dev_t dev, const char *domain),
 
-       TP_ARGS(q, domain),
+       TP_ARGS(dev, domain),
 
        TP_STRUCT__entry(
                __field(        dev_t,  dev                     )
@@ -81,7 +80,7 @@ TRACE_EVENT(kyber_throttled,
        ),
 
        TP_fast_assign(
-               __entry->dev            = disk_devt(q->disk);
+               __entry->dev            = dev;
                strlcpy(__entry->domain, domain, sizeof(__entry->domain));
        ),
 
index 20e435f..3246f2c 100644 (file)
@@ -225,7 +225,14 @@ struct binder_freeze_info {
 
 struct binder_frozen_status_info {
        __u32            pid;
+
+       /* process received sync transactions since last frozen
+        * bit 0: received sync transaction after being frozen
+        * bit 1: new pending sync transaction during freezing
+        */
        __u32            sync_recv;
+
+       /* process received async transactions since last frozen */
        __u32            async_recv;
 };
 
index 6982920..8e87d27 100644 (file)
@@ -1,6 +1,5 @@
 /* SPDX-License-Identifier: LGPL-2.1+ WITH Linux-syscall-note */
 /*
- *   include/uapi/linux/cifs/cifs_mount.h
  *
  *   Author(s): Scott Lovenberg (scott.lovenberg@gmail.com)
  *
index 6135d92..daf82a2 100644 (file)
@@ -26,7 +26,7 @@
 #ifndef _UAPI_HYPERV_H
 #define _UAPI_HYPERV_H
 
-#include <linux/uuid.h>
+#include <linux/types.h>
 
 /*
  * Framework version for util services.
index 59ef351..b270a07 100644 (file)
@@ -317,13 +317,19 @@ enum {
        IORING_REGISTER_IOWQ_AFF                = 17,
        IORING_UNREGISTER_IOWQ_AFF              = 18,
 
-       /* set/get max number of workers */
+       /* set/get max number of io-wq workers */
        IORING_REGISTER_IOWQ_MAX_WORKERS        = 19,
 
        /* this goes last */
        IORING_REGISTER_LAST
 };
 
+/* io-wq worker categories */
+enum {
+       IO_WQ_BOUND,
+       IO_WQ_UNBOUND,
+};
+
 /* deprecated, see struct io_uring_rsrc_update */
 struct io_uring_files_update {
        __u32 offset;
index b96c1ea..eda0426 100644 (file)
@@ -213,13 +213,13 @@ enum {
        XFRM_MSG_GETSPDINFO,
 #define XFRM_MSG_GETSPDINFO XFRM_MSG_GETSPDINFO
 
+       XFRM_MSG_MAPPING,
+#define XFRM_MSG_MAPPING XFRM_MSG_MAPPING
+
        XFRM_MSG_SETDEFAULT,
 #define XFRM_MSG_SETDEFAULT XFRM_MSG_SETDEFAULT
        XFRM_MSG_GETDEFAULT,
 #define XFRM_MSG_GETDEFAULT XFRM_MSG_GETDEFAULT
-
-       XFRM_MSG_MAPPING,
-#define XFRM_MSG_MAPPING XFRM_MSG_MAPPING
        __XFRM_MSG_MAX
 };
 #define XFRM_MSG_MAX (__XFRM_MSG_MAX - 1)
@@ -514,9 +514,12 @@ struct xfrm_user_offload {
 #define XFRM_OFFLOAD_INBOUND   2
 
 struct xfrm_userpolicy_default {
-#define XFRM_USERPOLICY_DIRMASK_MAX    (sizeof(__u8) * 8)
-       __u8                            dirmask;
-       __u8                            action;
+#define XFRM_USERPOLICY_UNSPEC 0
+#define XFRM_USERPOLICY_BLOCK  1
+#define XFRM_USERPOLICY_ACCEPT 2
+       __u8                            in;
+       __u8                            fwd;
+       __u8                            out;
 };
 
 #ifndef __KERNEL__
index 7cc2a0f..d13bb8c 100644 (file)
@@ -917,7 +917,6 @@ struct hl_wait_cs_in {
 #define HL_WAIT_CS_STATUS_BUSY         1
 #define HL_WAIT_CS_STATUS_TIMEDOUT     2
 #define HL_WAIT_CS_STATUS_ABORTED      3
-#define HL_WAIT_CS_STATUS_INTERRUPTED  4
 
 #define HL_WAIT_CS_STATUS_FLAG_GONE            0x1
 #define HL_WAIT_CS_STATUS_FLAG_TIMESTAMP_VLD   0x2
@@ -1286,7 +1285,8 @@ struct hl_debug_args {
  * EIO       - The CS was aborted (usually because the device was reset)
  * ENODEV    - The device wants to do hard-reset (so user need to close FD)
  *
- * The driver also returns a custom define inside the IOCTL which can be:
+ * The driver also returns a custom define in case the IOCTL call returned 0.
+ * The define can be one of the following:
  *
  * HL_WAIT_CS_STATUS_COMPLETED   - The CS has been completed successfully (0)
  * HL_WAIT_CS_STATUS_BUSY        - The CS is still executing (0)
@@ -1294,8 +1294,6 @@ struct hl_debug_args {
  *                                 (ETIMEDOUT)
  * HL_WAIT_CS_STATUS_ABORTED     - The CS was aborted, usually because the
  *                                 device was reset (EIO)
- * HL_WAIT_CS_STATUS_INTERRUPTED - Waiting for the CS was interrupted (EINTR)
- *
  */
 
 #define HL_IOCTL_WAIT_CS                       \
diff --git a/include/uapi/sound/snd_ar_tokens.h b/include/uapi/sound/snd_ar_tokens.h
new file mode 100644 (file)
index 0000000..440c072
--- /dev/null
@@ -0,0 +1,208 @@
+/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
+
+#ifndef __SND_AR_TOKENS_H__
+#define __SND_AR_TOKENS_H__
+
+#define APM_SUB_GRAPH_PERF_MODE_LOW_POWER      0x1
+#define APM_SUB_GRAPH_PERF_MODE_LOW_LATENCY    0x2
+
+#define APM_SUB_GRAPH_DIRECTION_TX             0x1
+#define APM_SUB_GRAPH_DIRECTION_RX             0x2
+
+/** Scenario ID Audio Playback */
+#define APM_SUB_GRAPH_SID_AUDIO_PLAYBACK          0x1
+/* Scenario ID Audio Record */
+#define APM_SUB_GRAPH_SID_AUDIO_RECORD            0x2
+/* Scenario ID Voice call. */
+#define APM_SUB_GRAPH_SID_VOICE_CALL              0x3
+
+/* container capability ID Pre/Post Processing (PP) */
+#define APM_CONTAINER_CAP_ID_PP                   0x1
+/* container capability ID Compression/Decompression (CD) */
+#define APM_CONTAINER_CAP_ID_CD                   0x2
+/* container capability ID End Point(EP) */
+#define APM_CONTAINER_CAP_ID_EP                   0x3
+/* container capability ID Offload (OLC) */
+#define APM_CONTAINER_CAP_ID_OLC                  0x4
+
+/* container graph position Stream */
+#define APM_CONT_GRAPH_POS_STREAM                 0x1
+/* container graph position Per Stream Per Device*/
+#define APM_CONT_GRAPH_POS_PER_STR_PER_DEV        0x2
+/* container graph position Stream-Device */
+#define APM_CONT_GRAPH_POS_STR_DEV                0x3
+/* container graph position Global Device */
+#define APM_CONT_GRAPH_POS_GLOBAL_DEV             0x4
+
+#define APM_PROC_DOMAIN_ID_MDSP                        0x1
+#define APM_PROC_DOMAIN_ID_ADSP                        0x2
+#define APM_PROC_DOMAIN_ID_SDSP                        0x4
+#define APM_PROC_DOMAIN_ID_CDSP                        0x5
+
+#define PCM_INTERLEAVED                        1
+#define PCM_DEINTERLEAVED_PACKED       2
+#define PCM_DEINTERLEAVED_UNPACKED     3
+#define AR_I2S_WS_SRC_EXTERNAL 0
+#define AR_I2S_WS_SRC_INTERNAL 1
+
+enum ar_event_types {
+       AR_EVENT_NONE = 0,
+       AR_PGA_DAPM_EVENT
+};
+
+/*
+ * Kcontrol IDs
+ */
+#define SND_SOC_AR_TPLG_FE_BE_GRAPH_CTL_MIX    256
+#define SND_SOC_AR_TPLG_VOL_CTL                        257
+
+/**
+ * %AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:          Sub Graph Instance Id
+ *
+ * %AR_TKN_U32_SUB_GRAPH_PERF_MODE:            Performance mode of subgraph
+ *                                             APM_SUB_GRAPH_PERF_MODE_LOW_POWER = 1,
+ *                                             APM_SUB_GRAPH_PERF_MODE_LOW_LATENCY = 2
+ *
+ * %AR_TKN_U32_SUB_GRAPH_DIRECTION:            Direction of subgraph
+ *                                             APM_SUB_GRAPH_DIRECTION_TX = 1,
+ *                                             APM_SUB_GRAPH_DIRECTION_RX = 2
+ *
+ * %AR_TKN_U32_SUB_GRAPH_SCENARIO_ID:          Scenario ID for subgraph
+ *                                             APM_SUB_GRAPH_SID_AUDIO_PLAYBACK = 1,
+ *                                             APM_SUB_GRAPH_SID_AUDIO_RECORD = 2,
+ *                                             APM_SUB_GRAPH_SID_VOICE_CALL = 3
+ *
+ * %AR_TKN_U32_CONTAINER_INSTANCE_ID:          Container Instance ID
+ *
+ * %AR_TKN_U32_CONTAINER_CAPABILITY_ID:                Container capability ID
+ *                                             APM_CONTAINER_CAP_ID_PP = 1,
+ *                                             APM_CONTAINER_CAP_ID_CD = 2,
+ *                                             APM_CONTAINER_CAP_ID_EP = 3,
+ *                                             APM_CONTAINER_CAP_ID_OLC = 4
+ *
+ * %AR_TKN_U32_CONTAINER_STACK_SIZE:           Stack size in the container.
+ *
+ * %AR_TKN_U32_CONTAINER_GRAPH_POS:            Graph Position
+ *                                             APM_CONT_GRAPH_POS_STREAM = 1,
+ *                                             APM_CONT_GRAPH_POS_PER_STR_PER_DEV = 2,
+ *                                             APM_CONT_GRAPH_POS_STR_DEV = 3,
+ *                                             APM_CONT_GRAPH_POS_GLOBAL_DEV = 4
+ *
+ * %AR_TKN_U32_CONTAINER_PROC_DOMAIN:          Processor domain of container
+ *                                             APM_PROC_DOMAIN_ID_MDSP = 1,
+ *                                             APM_PROC_DOMAIN_ID_ADSP = 2,
+ *                                             APM_PROC_DOMAIN_ID_SDSP = 4,
+ *                                             APM_PROC_DOMAIN_ID_CDSP = 5
+ *
+ * %AR_TKN_U32_MODULE_ID:                      Module ID
+ *
+ * %AR_TKN_U32_MODULE_INSTANCE_ID:             Module Instance ID.
+ *
+ * %AR_TKN_U32_MODULE_MAX_IP_PORTS:            Module maximum input ports
+ *
+ * %AR_TKN_U32_MODULE_MAX_OP_PORTS:            Module maximum output ports.
+ *
+ * %AR_TKN_U32_MODULE_IN_PORTS:                        Number of in ports
+ *
+ * %AR_TKN_U32_MODULE_OUT_PORTS:               Number of out ports.
+ *
+ * %AR_TKN_U32_MODULE_SRC_OP_PORT_ID:          Source module output port ID
+ *
+ * %AR_TKN_U32_MODULE_DST_IN_PORT_ID:          Destination module input port ID
+ *
+ * %AR_TKN_U32_MODULE_HW_IF_IDX:               Interface index types for I2S/LPAIF
+ *
+ * %AR_TKN_U32_MODULE_HW_IF_TYPE:              Interface type
+ *                                             LPAIF = 0,
+ *                                             LPAIF_RXTX = 1,
+ *                                             LPAIF_WSA = 2,
+ *                                             LPAIF_VA = 3,
+ *                                             LPAIF_AXI = 4
+ *
+ * %AR_TKN_U32_MODULE_FMT_INTERLEAVE:          PCM Interleaving
+ *                                             PCM_INTERLEAVED = 1,
+ *                                             PCM_DEINTERLEAVED_PACKED = 2,
+ *                                             PCM_DEINTERLEAVED_UNPACKED = 3
+ *
+ * %AR_TKN_U32_MODULE_FMT_DATA:                        data format
+ *                                             FIXED POINT = 1,
+ *                                             IEC60958 PACKETIZED = 3,
+ *                                             IEC60958 PACKETIZED NON LINEAR = 8,
+ *                                             COMPR OVER PCM PACKETIZED = 7,
+ *                                             IEC61937 PACKETIZED = 2,
+ *                                             GENERIC COMPRESSED = 5
+ *
+ * %AR_TKN_U32_MODULE_FMT_SAMPLE_RATE:         sample rate
+ *
+ * %AR_TKN_U32_MODULE_FMT_BIT_DEPTH:           bit depth
+ *
+ * %AR_TKN_U32_MODULE_SD_LINE_IDX:             I2S serial data line idx
+ *                                             I2S_SD0 = 1,
+ *                                             I2S_SD1 = 2,
+ *                                             I2S_SD2 = 3,
+ *                                             I2S_SD3 = 4,
+ *                                             I2S_QUAD01 = 5,
+ *                                             I2S_QUAD23 = 6,
+ *                                             I2S_6CHS = 7,
+ *                                             I2S_8CHS = 8
+ *
+ * %AR_TKN_U32_MODULE_WS_SRC:                  Word Select Source
+ *                                             AR_I2S_WS_SRC_EXTERNAL = 0,
+ *                                             AR_I2S_WS_SRC_INTERNAL = 1,
+ *
+ * %AR_TKN_U32_MODULE_FRAME_SZ_FACTOR:         Frame size factor
+ *
+ * %AR_TKN_U32_MODULE_LOG_CODE:                        Log Module Code
+ *
+ * %AR_TKN_U32_MODULE_LOG_TAP_POINT_ID:                logging tap point of this module
+ *
+ * %AR_TKN_U32_MODULE_LOG_MODE:                        logging mode
+ *                                             LOG_WAIT = 0,
+ *                                             LOG_IMMEDIATELY = 1
+ *
+ * %AR_TKN_DAI_INDEX:                          dai index
+ *
+ */
+
+/* DAI Tokens */
+#define AR_TKN_DAI_INDEX                       1
+/* SUB GRAPH Tokens */
+#define AR_TKN_U32_SUB_GRAPH_INSTANCE_ID       2
+#define AR_TKN_U32_SUB_GRAPH_PERF_MODE         3
+#define AR_TKN_U32_SUB_GRAPH_DIRECTION         4
+#define AR_TKN_U32_SUB_GRAPH_SCENARIO_ID       5
+
+/* Container Tokens */
+#define AR_TKN_U32_CONTAINER_INSTANCE_ID       100
+#define AR_TKN_U32_CONTAINER_CAPABILITY_ID     101
+#define AR_TKN_U32_CONTAINER_STACK_SIZE                102
+#define AR_TKN_U32_CONTAINER_GRAPH_POS         103
+#define AR_TKN_U32_CONTAINER_PROC_DOMAIN       104
+
+/* Module Tokens */
+#define AR_TKN_U32_MODULE_ID                   200
+#define AR_TKN_U32_MODULE_INSTANCE_ID          201
+#define AR_TKN_U32_MODULE_MAX_IP_PORTS         202
+#define AR_TKN_U32_MODULE_MAX_OP_PORTS         203
+#define AR_TKN_U32_MODULE_IN_PORTS             204
+#define AR_TKN_U32_MODULE_OUT_PORTS            205
+#define AR_TKN_U32_MODULE_SRC_OP_PORT_ID       206
+#define AR_TKN_U32_MODULE_DST_IN_PORT_ID       207
+#define AR_TKN_U32_MODULE_SRC_INSTANCE_ID      208
+#define AR_TKN_U32_MODULE_DST_INSTANCE_ID      209
+
+
+#define AR_TKN_U32_MODULE_HW_IF_IDX            250
+#define AR_TKN_U32_MODULE_HW_IF_TYPE           251
+#define AR_TKN_U32_MODULE_FMT_INTERLEAVE       252
+#define AR_TKN_U32_MODULE_FMT_DATA             253
+#define AR_TKN_U32_MODULE_FMT_SAMPLE_RATE      254
+#define AR_TKN_U32_MODULE_FMT_BIT_DEPTH                255
+#define AR_TKN_U32_MODULE_SD_LINE_IDX          256
+#define AR_TKN_U32_MODULE_WS_SRC               257
+#define AR_TKN_U32_MODULE_FRAME_SZ_FACTOR      258
+#define AR_TKN_U32_MODULE_LOG_CODE             259
+#define AR_TKN_U32_MODULE_LOG_TAP_POINT_ID     260
+#define AR_TKN_U32_MODULE_LOG_MODE             261
+
+#endif /* __SND_AR_TOKENS_H__ */
index a642bf3..02b71a8 100644 (file)
@@ -51,6 +51,7 @@
 #define SOF_TKN_SCHED_CORE                     203
 #define SOF_TKN_SCHED_FRAMES                   204
 #define SOF_TKN_SCHED_TIME_DOMAIN              205
+#define SOF_TKN_SCHED_DYNAMIC_PIPELINE         206
 
 /* volume */
 #define SOF_TKN_VOLUME_RAMP_STEP_TYPE          250
index 39a5580..a3584a3 100644 (file)
@@ -46,30 +46,18 @@ extern unsigned long *xen_contiguous_bitmap;
 int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
                                unsigned int address_bits,
                                dma_addr_t *dma_handle);
-
 void xen_destroy_contiguous_region(phys_addr_t pstart, unsigned int order);
-#else
-static inline int xen_create_contiguous_region(phys_addr_t pstart,
-                                              unsigned int order,
-                                              unsigned int address_bits,
-                                              dma_addr_t *dma_handle)
-{
-       return 0;
-}
-
-static inline void xen_destroy_contiguous_region(phys_addr_t pstart,
-                                                unsigned int order) { }
 #endif
 
 #if defined(CONFIG_XEN_PV)
 int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
                  xen_pfn_t *pfn, int nr, int *err_ptr, pgprot_t prot,
-                 unsigned int domid, bool no_translate, struct page **pages);
+                 unsigned int domid, bool no_translate);
 #else
 static inline int xen_remap_pfn(struct vm_area_struct *vma, unsigned long addr,
                                xen_pfn_t *pfn, int nr, int *err_ptr,
                                pgprot_t prot,  unsigned int domid,
-                               bool no_translate, struct page **pages)
+                               bool no_translate)
 {
        BUG();
        return 0;
@@ -146,7 +134,7 @@ static inline int xen_remap_domain_gfn_array(struct vm_area_struct *vma,
         */
        BUG_ON(err_ptr == NULL);
        return xen_remap_pfn(vma, addr, gfn, nr, err_ptr, prot, domid,
-                            false, pages);
+                            false);
 }
 
 /*
@@ -158,7 +146,6 @@ static inline int xen_remap_domain_gfn_array(struct vm_area_struct *vma,
  * @err_ptr: Returns per-MFN error status.
  * @prot:    page protection mask
  * @domid:   Domain owning the pages
- * @pages:   Array of pages if this domain has an auto-translated physmap
  *
  * @mfn and @err_ptr may point to the same buffer, the MFNs will be
  * overwritten by the error codes after they are mapped.
@@ -169,14 +156,13 @@ static inline int xen_remap_domain_gfn_array(struct vm_area_struct *vma,
 static inline int xen_remap_domain_mfn_array(struct vm_area_struct *vma,
                                             unsigned long addr, xen_pfn_t *mfn,
                                             int nr, int *err_ptr,
-                                            pgprot_t prot, unsigned int domid,
-                                            struct page **pages)
+                                            pgprot_t prot, unsigned int domid)
 {
        if (xen_feature(XENFEAT_auto_translated_physmap))
                return -EOPNOTSUPP;
 
        return xen_remap_pfn(vma, addr, mfn, nr, err_ptr, prot, domid,
-                            true, pages);
+                            true);
 }
 
 /* xen_remap_domain_gfn_range() - map a range of foreign frames
@@ -200,8 +186,7 @@ static inline int xen_remap_domain_gfn_range(struct vm_area_struct *vma,
        if (xen_feature(XENFEAT_auto_translated_physmap))
                return -EOPNOTSUPP;
 
-       return xen_remap_pfn(vma, addr, &gfn, nr, NULL, prot, domid, false,
-                            pages);
+       return xen_remap_pfn(vma, addr, &gfn, nr, NULL, prot, domid, false);
 }
 
 int xen_unmap_domain_gfn_range(struct vm_area_struct *vma,
index 2ed30ff..762b534 100644 (file)
@@ -338,20 +338,19 @@ __setup("rootflags=", root_data_setup);
 __setup("rootfstype=", fs_names_setup);
 __setup("rootdelay=", root_delay_setup);
 
-static int __init split_fs_names(char *page, char *names)
+/* This can return zero length strings. Caller should check */
+static int __init split_fs_names(char *page, size_t size, char *names)
 {
-       int count = 0;
+       int count = 1;
        char *p = page;
 
-       strcpy(p, root_fs_names);
+       strlcpy(p, root_fs_names, size);
        while (*p++) {
-               if (p[-1] == ',')
+               if (p[-1] == ',') {
                        p[-1] = '\0';
+                       count++;
+               }
        }
-       *p = '\0';
-
-       for (p = page; *p; p += strlen(p)+1)
-               count++;
 
        return count;
 }
@@ -404,12 +403,16 @@ void __init mount_block_root(char *name, int flags)
        scnprintf(b, BDEVNAME_SIZE, "unknown-block(%u,%u)",
                  MAJOR(ROOT_DEV), MINOR(ROOT_DEV));
        if (root_fs_names)
-               num_fs = split_fs_names(fs_names, root_fs_names);
+               num_fs = split_fs_names(fs_names, PAGE_SIZE, root_fs_names);
        else
                num_fs = list_bdev_fs_names(fs_names, PAGE_SIZE);
 retry:
        for (i = 0, p = fs_names; i < num_fs; i++, p += strlen(p)+1) {
-               int err = do_mount_root(name, p, flags, root_mount_data);
+               int err;
+
+               if (!*p)
+                       continue;
+               err = do_mount_root(name, p, flags, root_mount_data);
                switch (err) {
                        case 0:
                                goto out;
@@ -543,19 +546,18 @@ static int __init mount_nodev_root(void)
        fs_names = (void *)__get_free_page(GFP_KERNEL);
        if (!fs_names)
                return -EINVAL;
-       num_fs = split_fs_names(fs_names, root_fs_names);
+       num_fs = split_fs_names(fs_names, PAGE_SIZE, root_fs_names);
 
        for (i = 0, fstype = fs_names; i < num_fs;
             i++, fstype += strlen(fstype) + 1) {
+               if (!*fstype)
+                       continue;
                if (!fs_is_nodev(fstype))
                        continue;
                err = do_mount_root(root_device_name, fstype, root_mountflags,
                                    root_mount_data);
                if (!err)
                        break;
-               if (err != -EACCES && err != -EINVAL)
-                       panic("VFS: Unable to mount root \"%s\" (%s), err=%d\n",
-                             root_device_name, fstype, err);
        }
 
        free_page((unsigned long)fs_names);
index 5c9a48d..3c4054a 100644 (file)
@@ -382,6 +382,7 @@ static char * __init xbc_make_cmdline(const char *key)
        ret = xbc_snprint_cmdline(new_cmdline, len + 1, root);
        if (ret < 0 || ret > len) {
                pr_err("Failed to print extra kernel cmdline.\n");
+               memblock_free_ptr(new_cmdline, len + 1);
                return NULL;
        }
 
@@ -924,7 +925,7 @@ static void __init print_unknown_bootoptions(void)
                end += sprintf(end, " %s", *p);
 
        pr_notice("Unknown command line parameters:%s\n", unknown_options);
-       memblock_free(__pa(unknown_options), len);
+       memblock_free_ptr(unknown_options, len);
 }
 
 asmlinkage __visible void __init __no_sanitize_address start_kernel(void)
@@ -1242,7 +1243,7 @@ trace_initcall_start_cb(void *data, initcall_t fn)
 {
        ktime_t *calltime = (ktime_t *)data;
 
-       printk(KERN_DEBUG "calling  %pS @ %i irqs_disabled() %d\n", fn, task_pid_nr(current), irqs_disabled());
+       printk(KERN_DEBUG "calling  %pS @ %i\n", fn, task_pid_nr(current));
        *calltime = ktime_get();
 }
 
@@ -1256,8 +1257,8 @@ trace_initcall_finish_cb(void *data, initcall_t fn, int ret)
        rettime = ktime_get();
        delta = ktime_sub(rettime, *calltime);
        duration = (unsigned long long) ktime_to_ns(delta) >> 10;
-       printk(KERN_DEBUG "initcall %pS returned %d after %lld usecs, irqs_disabled() %d\n",
-                fn, ret, duration, irqs_disabled());
+       printk(KERN_DEBUG "initcall %pS returned %d after %lld usecs\n",
+                fn, ret, duration);
 }
 
 static ktime_t initcall_calltime;
index f833238..6693daf 100644 (file)
--- a/ipc/sem.c
+++ b/ipc/sem.c
@@ -2238,7 +2238,7 @@ static long do_semtimedop(int semid, struct sembuf __user *tsops,
                return -EINVAL;
 
        if (nsops > SEMOPM_FAST) {
-               sops = kvmalloc_array(nsops, sizeof(*sops), GFP_KERNEL_ACCOUNT);
+               sops = kvmalloc_array(nsops, sizeof(*sops), GFP_KERNEL);
                if (sops == NULL)
                        return -ENOMEM;
        }
index d6731c3..9abcc33 100644 (file)
@@ -368,6 +368,7 @@ static int bpf_struct_ops_map_update_elem(struct bpf_map *map, void *key,
                const struct btf_type *mtype, *ptype;
                struct bpf_prog *prog;
                u32 moff;
+               u32 flags;
 
                moff = btf_member_bit_offset(t, member) / 8;
                ptype = btf_type_resolve_ptr(btf_vmlinux, member->type, NULL);
@@ -431,10 +432,12 @@ static int bpf_struct_ops_map_update_elem(struct bpf_map *map, void *key,
 
                tprogs[BPF_TRAMP_FENTRY].progs[0] = prog;
                tprogs[BPF_TRAMP_FENTRY].nr_progs = 1;
+               flags = st_ops->func_models[i].ret_size > 0 ?
+                       BPF_TRAMP_F_RET_FENTRY_RET : 0;
                err = arch_prepare_bpf_trampoline(NULL, image,
                                                  st_map->image + PAGE_SIZE,
-                                                 &st_ops->func_models[i], 0,
-                                                 tprogs, NULL);
+                                                 &st_ops->func_models[i],
+                                                 flags, tprogs, NULL);
                if (err < 0)
                        goto reset_unlock;
 
index 9f4636d..d6b7dfd 100644 (file)
@@ -827,7 +827,7 @@ int bpf_jit_charge_modmem(u32 pages)
 {
        if (atomic_long_add_return(pages, &bpf_jit_current) >
            (bpf_jit_limit >> PAGE_SHIFT)) {
-               if (!capable(CAP_SYS_ADMIN)) {
+               if (!bpf_capable()) {
                        atomic_long_sub(pages, &bpf_jit_current);
                        return -EPERM;
                }
index ca3cd9a..7b4afb7 100644 (file)
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0-only
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 /* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
  * Copyright (c) 2016 Facebook
  */
index e546b18..a4b0407 100644 (file)
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /* Copyright (c) 2011-2014 PLUMgrid, http://plumgrid.com
  * Copyright (c) 2016 Facebook
  */
index e8eefdf..6e75bbe 100644 (file)
@@ -63,7 +63,8 @@ static inline int stack_map_data_size(struct bpf_map *map)
 
 static int prealloc_elems_and_freelist(struct bpf_stack_map *smap)
 {
-       u32 elem_size = sizeof(struct stack_map_bucket) + smap->map.value_size;
+       u64 elem_size = sizeof(struct stack_map_bucket) +
+                       (u64)smap->map.value_size;
        int err;
 
        smap->elems = bpf_map_area_alloc(elem_size * smap->map.max_entries,
@@ -179,7 +180,7 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs,
         * with build_id.
         */
        if (!user || !current || !current->mm || irq_work_busy ||
-           !mmap_read_trylock_non_owner(current->mm)) {
+           !mmap_read_trylock(current->mm)) {
                /* cannot access current->mm, fall back to ips */
                for (i = 0; i < trace_nr; i++) {
                        id_offs[i].status = BPF_STACK_BUILD_ID_IP;
@@ -204,9 +205,15 @@ static void stack_map_get_build_id_offset(struct bpf_stack_build_id *id_offs,
        }
 
        if (!work) {
-               mmap_read_unlock_non_owner(current->mm);
+               mmap_read_unlock(current->mm);
        } else {
                work->mm = current->mm;
+
+               /* The lock will be released once we're out of interrupt
+                * context. Tell lockdep that we've released it now so
+                * it doesn't complain that we forgot to release it.
+                */
+               rwsem_release(&current->mm->mmap_lock.dep_map, _RET_IP_);
                irq_work_queue(&work->irq_work);
        }
 }
index 047ac4b..e76b559 100644 (file)
@@ -9912,6 +9912,8 @@ static int check_btf_line(struct bpf_verifier_env *env,
        nr_linfo = attr->line_info_cnt;
        if (!nr_linfo)
                return 0;
+       if (nr_linfo > INT_MAX / sizeof(struct bpf_line_info))
+               return -EINVAL;
 
        rec_size = attr->line_info_rec_size;
        if (rec_size < MIN_BPF_LINEINFO_SIZE ||
index 881ce14..570b0c9 100644 (file)
@@ -6572,74 +6572,51 @@ int cgroup_parse_float(const char *input, unsigned dec_shift, s64 *v)
  */
 #ifdef CONFIG_SOCK_CGROUP_DATA
 
-#if defined(CONFIG_CGROUP_NET_PRIO) || defined(CONFIG_CGROUP_NET_CLASSID)
-
-DEFINE_SPINLOCK(cgroup_sk_update_lock);
-static bool cgroup_sk_alloc_disabled __read_mostly;
-
-void cgroup_sk_alloc_disable(void)
-{
-       if (cgroup_sk_alloc_disabled)
-               return;
-       pr_info("cgroup: disabling cgroup2 socket matching due to net_prio or net_cls activation\n");
-       cgroup_sk_alloc_disabled = true;
-}
-
-#else
-
-#define cgroup_sk_alloc_disabled       false
-
-#endif
-
 void cgroup_sk_alloc(struct sock_cgroup_data *skcd)
 {
-       if (cgroup_sk_alloc_disabled) {
-               skcd->no_refcnt = 1;
-               return;
-       }
-
-       /* Don't associate the sock with unrelated interrupted task's cgroup. */
-       if (in_interrupt())
-               return;
+       struct cgroup *cgroup;
 
        rcu_read_lock();
+       /* Don't associate the sock with unrelated interrupted task's cgroup. */
+       if (in_interrupt()) {
+               cgroup = &cgrp_dfl_root.cgrp;
+               cgroup_get(cgroup);
+               goto out;
+       }
 
        while (true) {
                struct css_set *cset;
 
                cset = task_css_set(current);
                if (likely(cgroup_tryget(cset->dfl_cgrp))) {
-                       skcd->val = (unsigned long)cset->dfl_cgrp;
-                       cgroup_bpf_get(cset->dfl_cgrp);
+                       cgroup = cset->dfl_cgrp;
                        break;
                }
                cpu_relax();
        }
-
+out:
+       skcd->cgroup = cgroup;
+       cgroup_bpf_get(cgroup);
        rcu_read_unlock();
 }
 
 void cgroup_sk_clone(struct sock_cgroup_data *skcd)
 {
-       if (skcd->val) {
-               if (skcd->no_refcnt)
-                       return;
-               /*
-                * We might be cloning a socket which is left in an empty
-                * cgroup and the cgroup might have already been rmdir'd.
-                * Don't use cgroup_get_live().
-                */
-               cgroup_get(sock_cgroup_ptr(skcd));
-               cgroup_bpf_get(sock_cgroup_ptr(skcd));
-       }
+       struct cgroup *cgrp = sock_cgroup_ptr(skcd);
+
+       /*
+        * We might be cloning a socket which is left in an empty
+        * cgroup and the cgroup might have already been rmdir'd.
+        * Don't use cgroup_get_live().
+        */
+       cgroup_get(cgrp);
+       cgroup_bpf_get(cgrp);
 }
 
 void cgroup_sk_free(struct sock_cgroup_data *skcd)
 {
        struct cgroup *cgrp = sock_cgroup_ptr(skcd);
 
-       if (skcd->no_refcnt)
-               return;
        cgroup_bpf_put(cgrp);
        cgroup_put(cgrp);
 }
index df1ccf4..2a9695c 100644 (file)
@@ -311,17 +311,19 @@ static struct cpuset top_cpuset = {
                if (is_cpuset_online(((des_cs) = css_cs((pos_css)))))
 
 /*
- * There are two global locks guarding cpuset structures - cpuset_mutex and
+ * There are two global locks guarding cpuset structures - cpuset_rwsem and
  * callback_lock. We also require taking task_lock() when dereferencing a
  * task's cpuset pointer. See "The task_lock() exception", at the end of this
- * comment.
+ * comment.  The cpuset code uses only cpuset_rwsem write lock.  Other
+ * kernel subsystems can use cpuset_read_lock()/cpuset_read_unlock() to
+ * prevent change to cpuset structures.
  *
  * A task must hold both locks to modify cpusets.  If a task holds
- * cpuset_mutex, then it blocks others wanting that mutex, ensuring that it
+ * cpuset_rwsem, it blocks others wanting that rwsem, ensuring that it
  * is the only task able to also acquire callback_lock and be able to
  * modify cpusets.  It can perform various checks on the cpuset structure
  * first, knowing nothing will change.  It can also allocate memory while
- * just holding cpuset_mutex.  While it is performing these checks, various
+ * just holding cpuset_rwsem.  While it is performing these checks, various
  * callback routines can briefly acquire callback_lock to query cpusets.
  * Once it is ready to make the changes, it takes callback_lock, blocking
  * everyone else.
@@ -393,7 +395,7 @@ static inline bool is_in_v2_mode(void)
  * One way or another, we guarantee to return some non-empty subset
  * of cpu_online_mask.
  *
- * Call with callback_lock or cpuset_mutex held.
+ * Call with callback_lock or cpuset_rwsem held.
  */
 static void guarantee_online_cpus(struct task_struct *tsk,
                                  struct cpumask *pmask)
@@ -435,7 +437,7 @@ out_unlock:
  * One way or another, we guarantee to return some non-empty subset
  * of node_states[N_MEMORY].
  *
- * Call with callback_lock or cpuset_mutex held.
+ * Call with callback_lock or cpuset_rwsem held.
  */
 static void guarantee_online_mems(struct cpuset *cs, nodemask_t *pmask)
 {
@@ -447,7 +449,7 @@ static void guarantee_online_mems(struct cpuset *cs, nodemask_t *pmask)
 /*
  * update task's spread flag if cpuset's page/slab spread flag is set
  *
- * Call with callback_lock or cpuset_mutex held.
+ * Call with callback_lock or cpuset_rwsem held.
  */
 static void cpuset_update_task_spread_flag(struct cpuset *cs,
                                        struct task_struct *tsk)
@@ -468,7 +470,7 @@ static void cpuset_update_task_spread_flag(struct cpuset *cs,
  *
  * One cpuset is a subset of another if all its allowed CPUs and
  * Memory Nodes are a subset of the other, and its exclusive flags
- * are only set if the other's are set.  Call holding cpuset_mutex.
+ * are only set if the other's are set.  Call holding cpuset_rwsem.
  */
 
 static int is_cpuset_subset(const struct cpuset *p, const struct cpuset *q)
@@ -577,7 +579,7 @@ static inline void free_cpuset(struct cpuset *cs)
  * If we replaced the flag and mask values of the current cpuset
  * (cur) with those values in the trial cpuset (trial), would
  * our various subset and exclusive rules still be valid?  Presumes
- * cpuset_mutex held.
+ * cpuset_rwsem held.
  *
  * 'cur' is the address of an actual, in-use cpuset.  Operations
  * such as list traversal that depend on the actual address of the
@@ -700,7 +702,7 @@ static void update_domain_attr_tree(struct sched_domain_attr *dattr,
        rcu_read_unlock();
 }
 
-/* Must be called with cpuset_mutex held.  */
+/* Must be called with cpuset_rwsem held.  */
 static inline int nr_cpusets(void)
 {
        /* jump label reference count + the top-level cpuset */
@@ -726,7 +728,7 @@ static inline int nr_cpusets(void)
  * domains when operating in the severe memory shortage situations
  * that could cause allocation failures below.
  *
- * Must be called with cpuset_mutex held.
+ * Must be called with cpuset_rwsem held.
  *
  * The three key local variables below are:
  *    cp - cpuset pointer, used (together with pos_css) to perform a
@@ -1005,7 +1007,7 @@ partition_and_rebuild_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
  * 'cpus' is removed, then call this routine to rebuild the
  * scheduler's dynamic sched domains.
  *
- * Call with cpuset_mutex held.  Takes cpus_read_lock().
+ * Call with cpuset_rwsem held.  Takes cpus_read_lock().
  */
 static void rebuild_sched_domains_locked(void)
 {
@@ -1078,7 +1080,7 @@ void rebuild_sched_domains(void)
  * @cs: the cpuset in which each task's cpus_allowed mask needs to be changed
  *
  * Iterate through each task of @cs updating its cpus_allowed to the
- * effective cpuset's.  As this function is called with cpuset_mutex held,
+ * effective cpuset's.  As this function is called with cpuset_rwsem held,
  * cpuset membership stays stable.
  */
 static void update_tasks_cpumask(struct cpuset *cs)
@@ -1347,7 +1349,7 @@ static int update_parent_subparts_cpumask(struct cpuset *cpuset, int cmd,
  *
  * On legacy hierarchy, effective_cpus will be the same with cpu_allowed.
  *
- * Called with cpuset_mutex held
+ * Called with cpuset_rwsem held
  */
 static void update_cpumasks_hier(struct cpuset *cs, struct tmpmasks *tmp)
 {
@@ -1704,12 +1706,12 @@ static void *cpuset_being_rebound;
  * @cs: the cpuset in which each task's mems_allowed mask needs to be changed
  *
  * Iterate through each task of @cs updating its mems_allowed to the
- * effective cpuset's.  As this function is called with cpuset_mutex held,
+ * effective cpuset's.  As this function is called with cpuset_rwsem held,
  * cpuset membership stays stable.
  */
 static void update_tasks_nodemask(struct cpuset *cs)
 {
-       static nodemask_t newmems;      /* protected by cpuset_mutex */
+       static nodemask_t newmems;      /* protected by cpuset_rwsem */
        struct css_task_iter it;
        struct task_struct *task;
 
@@ -1722,7 +1724,7 @@ static void update_tasks_nodemask(struct cpuset *cs)
         * take while holding tasklist_lock.  Forks can happen - the
         * mpol_dup() cpuset_being_rebound check will catch such forks,
         * and rebind their vma mempolicies too.  Because we still hold
-        * the global cpuset_mutex, we know that no other rebind effort
+        * the global cpuset_rwsem, we know that no other rebind effort
         * will be contending for the global variable cpuset_being_rebound.
         * It's ok if we rebind the same mm twice; mpol_rebind_mm()
         * is idempotent.  Also migrate pages in each mm to new nodes.
@@ -1768,7 +1770,7 @@ static void update_tasks_nodemask(struct cpuset *cs)
  *
  * On legacy hierarchy, effective_mems will be the same with mems_allowed.
  *
- * Called with cpuset_mutex held
+ * Called with cpuset_rwsem held
  */
 static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
 {
@@ -1821,7 +1823,7 @@ static void update_nodemasks_hier(struct cpuset *cs, nodemask_t *new_mems)
  * mempolicies and if the cpuset is marked 'memory_migrate',
  * migrate the tasks pages to the new memory.
  *
- * Call with cpuset_mutex held. May take callback_lock during call.
+ * Call with cpuset_rwsem held. May take callback_lock during call.
  * Will take tasklist_lock, scan tasklist for tasks in cpuset cs,
  * lock each such tasks mm->mmap_lock, scan its vma's and rebind
  * their mempolicies to the cpusets new mems_allowed.
@@ -1911,7 +1913,7 @@ static int update_relax_domain_level(struct cpuset *cs, s64 val)
  * @cs: the cpuset in which each task's spread flags needs to be changed
  *
  * Iterate through each task of @cs updating its spread flags.  As this
- * function is called with cpuset_mutex held, cpuset membership stays
+ * function is called with cpuset_rwsem held, cpuset membership stays
  * stable.
  */
 static void update_tasks_flags(struct cpuset *cs)
@@ -1931,7 +1933,7 @@ static void update_tasks_flags(struct cpuset *cs)
  * cs:         the cpuset to update
  * turning_on:         whether the flag is being set or cleared
  *
- * Call with cpuset_mutex held.
+ * Call with cpuset_rwsem held.
  */
 
 static int update_flag(cpuset_flagbits_t bit, struct cpuset *cs,
@@ -1980,7 +1982,7 @@ out:
  * cs: the cpuset to update
  * new_prs: new partition root state
  *
- * Call with cpuset_mutex held.
+ * Call with cpuset_rwsem held.
  */
 static int update_prstate(struct cpuset *cs, int new_prs)
 {
@@ -2167,7 +2169,7 @@ static int fmeter_getrate(struct fmeter *fmp)
 
 static struct cpuset *cpuset_attach_old_cs;
 
-/* Called by cgroups to determine if a cpuset is usable; cpuset_mutex held */
+/* Called by cgroups to determine if a cpuset is usable; cpuset_rwsem held */
 static int cpuset_can_attach(struct cgroup_taskset *tset)
 {
        struct cgroup_subsys_state *css;
@@ -2219,7 +2221,7 @@ static void cpuset_cancel_attach(struct cgroup_taskset *tset)
 }
 
 /*
- * Protected by cpuset_mutex.  cpus_attach is used only by cpuset_attach()
+ * Protected by cpuset_rwsem.  cpus_attach is used only by cpuset_attach()
  * but we can't allocate it dynamically there.  Define it global and
  * allocate from cpuset_init().
  */
@@ -2227,7 +2229,7 @@ static cpumask_var_t cpus_attach;
 
 static void cpuset_attach(struct cgroup_taskset *tset)
 {
-       /* static buf protected by cpuset_mutex */
+       /* static buf protected by cpuset_rwsem */
        static nodemask_t cpuset_attach_nodemask_to;
        struct task_struct *task;
        struct task_struct *leader;
@@ -2417,7 +2419,7 @@ static ssize_t cpuset_write_resmask(struct kernfs_open_file *of,
         * operation like this one can lead to a deadlock through kernfs
         * active_ref protection.  Let's break the protection.  Losing the
         * protection is okay as we check whether @cs is online after
-        * grabbing cpuset_mutex anyway.  This only happens on the legacy
+        * grabbing cpuset_rwsem anyway.  This only happens on the legacy
         * hierarchies.
         */
        css_get(&cs->css);
@@ -3672,7 +3674,7 @@ void __cpuset_memory_pressure_bump(void)
  *  - Used for /proc/<pid>/cpuset.
  *  - No need to task_lock(tsk) on this tsk->cpuset reference, as it
  *    doesn't really matter if tsk->cpuset changes after we read it,
- *    and we take cpuset_mutex, keeping cpuset_attach() from changing it
+ *    and we take cpuset_rwsem, keeping cpuset_attach() from changing it
  *    anyway.
  */
 int proc_cpuset_show(struct seq_file *m, struct pid_namespace *ns,
index 6c90c69..95445bd 100644 (file)
@@ -567,7 +567,8 @@ static void add_dma_entry(struct dma_debug_entry *entry)
                pr_err("cacheline tracking ENOMEM, dma-debug disabled\n");
                global_disable = true;
        } else if (rc == -EEXIST) {
-               pr_err("cacheline tracking EEXIST, overlapping mappings aren't supported\n");
+               err_printk(entry->dev, entry,
+                       "cacheline tracking EEXIST, overlapping mappings aren't supported\n");
        }
 }
 
index 7ee5284..06fec55 100644 (file)
@@ -206,7 +206,8 @@ static int __dma_map_sg_attrs(struct device *dev, struct scatterlist *sg,
 /**
  * dma_map_sg_attrs - Map the given buffer for DMA
  * @dev:       The device for which to perform the DMA operation
- * @sg:        The sg_table object describing the buffer
+ * @sg:                The sg_table object describing the buffer
+ * @nents:     Number of entries to map
  * @dir:       DMA direction
  * @attrs:     Optional DMA attributes for the map operation
  *
index bf16395..d5a61d5 100644 (file)
@@ -171,10 +171,8 @@ static unsigned long exit_to_user_mode_loop(struct pt_regs *regs,
                if (ti_work & (_TIF_SIGPENDING | _TIF_NOTIFY_SIGNAL))
                        handle_signal_work(regs, ti_work);
 
-               if (ti_work & _TIF_NOTIFY_RESUME) {
+               if (ti_work & _TIF_NOTIFY_RESUME)
                        tracehook_notify_resume(regs);
-                       rseq_handle_notify_resume(NULL, regs);
-               }
 
                /* Architecture specific TIF work */
                arch_exit_to_user_mode_work(regs, ti_work);
index 744e872..f23ca26 100644 (file)
@@ -3707,6 +3707,29 @@ static noinline int visit_groups_merge(struct perf_cpu_context *cpuctx,
        return 0;
 }
 
+static inline bool event_update_userpage(struct perf_event *event)
+{
+       if (likely(!atomic_read(&event->mmap_count)))
+               return false;
+
+       perf_event_update_time(event);
+       perf_set_shadow_time(event, event->ctx);
+       perf_event_update_userpage(event);
+
+       return true;
+}
+
+static inline void group_update_userpage(struct perf_event *group_event)
+{
+       struct perf_event *event;
+
+       if (!event_update_userpage(group_event))
+               return;
+
+       for_each_sibling_event(event, group_event)
+               event_update_userpage(event);
+}
+
 static int merge_sched_in(struct perf_event *event, void *data)
 {
        struct perf_event_context *ctx = event->ctx;
@@ -3725,14 +3748,15 @@ static int merge_sched_in(struct perf_event *event, void *data)
        }
 
        if (event->state == PERF_EVENT_STATE_INACTIVE) {
+               *can_add_hw = 0;
                if (event->attr.pinned) {
                        perf_cgroup_event_disable(event, ctx);
                        perf_event_set_state(event, PERF_EVENT_STATE_ERROR);
+               } else {
+                       ctx->rotate_necessary = 1;
+                       perf_mux_hrtimer_restart(cpuctx);
+                       group_update_userpage(event);
                }
-
-               *can_add_hw = 0;
-               ctx->rotate_necessary = 1;
-               perf_mux_hrtimer_restart(cpuctx);
        }
 
        return 0;
@@ -6324,6 +6348,8 @@ accounting:
 
                ring_buffer_attach(event, rb);
 
+               perf_event_update_time(event);
+               perf_set_shadow_time(event, event->ctx);
                perf_event_init_userpage(event);
                perf_event_update_userpage(event);
        } else {
@@ -10193,7 +10219,7 @@ static void perf_event_addr_filters_apply(struct perf_event *event)
                return;
 
        if (ifh->nr_file_filters) {
-               mm = get_task_mm(event->ctx->task);
+               mm = get_task_mm(task);
                if (!mm)
                        goto restart;
 
index 19e83e9..4d8fc65 100644 (file)
@@ -136,7 +136,7 @@ EXPORT_SYMBOL_GPL(irq_domain_free_fwnode);
  * Allocates and initializes an irq_domain structure.
  * Returns pointer to IRQ domain, or NULL on failure.
  */
-struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, int size,
+struct irq_domain *__irq_domain_add(struct fwnode_handle *fwnode, unsigned int size,
                                    irq_hw_number_t hwirq_max, int direct_max,
                                    const struct irq_domain_ops *ops,
                                    void *host_data)
index 4ba1508..88191f6 100644 (file)
  * The risk of writer starvation is there, but the pathological use cases
  * which trigger it are not necessarily the typical RT workloads.
  *
+ * Fast-path orderings:
+ * The lock/unlock of readers can run in fast paths: lock and unlock are only
+ * atomic ops, and there is no inner lock to provide ACQUIRE and RELEASE
+ * semantics of rwbase_rt. Atomic ops should thus provide _acquire()
+ * and _release() (or stronger).
+ *
  * Common code shared between RT rw_semaphore and rwlock
  */
 
@@ -53,6 +59,7 @@ static __always_inline int rwbase_read_trylock(struct rwbase_rt *rwb)
         * set.
         */
        for (r = atomic_read(&rwb->readers); r < 0;) {
+               /* Fully-ordered if cmpxchg() succeeds, provides ACQUIRE */
                if (likely(atomic_try_cmpxchg(&rwb->readers, &r, r + 1)))
                        return 1;
        }
@@ -162,6 +169,8 @@ static __always_inline void rwbase_read_unlock(struct rwbase_rt *rwb,
        /*
         * rwb->readers can only hit 0 when a writer is waiting for the
         * active readers to leave the critical section.
+        *
+        * dec_and_test() is fully ordered, provides RELEASE.
         */
        if (unlikely(atomic_dec_and_test(&rwb->readers)))
                __rwbase_read_unlock(rwb, state);
@@ -172,7 +181,11 @@ static inline void __rwbase_write_unlock(struct rwbase_rt *rwb, int bias,
 {
        struct rt_mutex_base *rtm = &rwb->rtmutex;
 
-       atomic_add(READER_BIAS - bias, &rwb->readers);
+       /*
+        * _release() is needed in case that reader is in fast path, pairing
+        * with atomic_try_cmpxchg() in rwbase_read_trylock(), provides RELEASE
+        */
+       (void)atomic_add_return_release(READER_BIAS - bias, &rwb->readers);
        raw_spin_unlock_irqrestore(&rtm->wait_lock, flags);
        rwbase_rtmutex_unlock(rtm);
 }
@@ -196,6 +209,23 @@ static inline void rwbase_write_downgrade(struct rwbase_rt *rwb)
        __rwbase_write_unlock(rwb, WRITER_BIAS - 1, flags);
 }
 
+static inline bool __rwbase_write_trylock(struct rwbase_rt *rwb)
+{
+       /* Can do without CAS because we're serialized by wait_lock. */
+       lockdep_assert_held(&rwb->rtmutex.wait_lock);
+
+       /*
+        * _acquire is needed in case the reader is in the fast path, pairing
+        * with rwbase_read_unlock(), provides ACQUIRE.
+        */
+       if (!atomic_read_acquire(&rwb->readers)) {
+               atomic_set(&rwb->readers, WRITER_BIAS);
+               return 1;
+       }
+
+       return 0;
+}
+
 static int __sched rwbase_write_lock(struct rwbase_rt *rwb,
                                     unsigned int state)
 {
@@ -210,34 +240,30 @@ static int __sched rwbase_write_lock(struct rwbase_rt *rwb,
        atomic_sub(READER_BIAS, &rwb->readers);
 
        raw_spin_lock_irqsave(&rtm->wait_lock, flags);
-       /*
-        * set_current_state() for rw_semaphore
-        * current_save_and_set_rtlock_wait_state() for rwlock
-        */
-       rwbase_set_and_save_current_state(state);
+       if (__rwbase_write_trylock(rwb))
+               goto out_unlock;
 
-       /* Block until all readers have left the critical section. */
-       for (; atomic_read(&rwb->readers);) {
+       rwbase_set_and_save_current_state(state);
+       for (;;) {
                /* Optimized out for rwlocks */
                if (rwbase_signal_pending_state(state, current)) {
-                       __set_current_state(TASK_RUNNING);
+                       rwbase_restore_current_state();
                        __rwbase_write_unlock(rwb, 0, flags);
                        return -EINTR;
                }
+
+               if (__rwbase_write_trylock(rwb))
+                       break;
+
                raw_spin_unlock_irqrestore(&rtm->wait_lock, flags);
+               rwbase_schedule();
+               raw_spin_lock_irqsave(&rtm->wait_lock, flags);
 
-               /*
-                * Schedule and wait for the readers to leave the critical
-                * section. The last reader leaving it wakes the waiter.
-                */
-               if (atomic_read(&rwb->readers) != 0)
-                       rwbase_schedule();
                set_current_state(state);
-               raw_spin_lock_irqsave(&rtm->wait_lock, flags);
        }
-
-       atomic_set(&rwb->readers, WRITER_BIAS);
        rwbase_restore_current_state();
+
+out_unlock:
        raw_spin_unlock_irqrestore(&rtm->wait_lock, flags);
        return 0;
 }
@@ -253,8 +279,7 @@ static inline int rwbase_write_trylock(struct rwbase_rt *rwb)
        atomic_sub(READER_BIAS, &rwb->readers);
 
        raw_spin_lock_irqsave(&rtm->wait_lock, flags);
-       if (!atomic_read(&rwb->readers)) {
-               atomic_set(&rwb->readers, WRITER_BIAS);
+       if (__rwbase_write_trylock(rwb)) {
                raw_spin_unlock_irqrestore(&rtm->wait_lock, flags);
                return 1;
        }
index 40ec9a0..5c26a76 100644 (file)
@@ -4489,8 +4489,10 @@ static void cfi_init(struct module *mod)
        /* Fix init/exit functions to point to the CFI jump table */
        if (init)
                mod->init = *init;
+#ifdef CONFIG_MODULE_UNLOAD
        if (exit)
                mod->exit = *exit;
+#endif
 
        cfi_module_add(mod, module_addr_min);
 #endif
index 825277e..a8d0a58 100644 (file)
@@ -1166,9 +1166,9 @@ void __init setup_log_buf(int early)
        return;
 
 err_free_descs:
-       memblock_free(__pa(new_descs), new_descs_size);
+       memblock_free_ptr(new_descs, new_descs_size);
 err_free_log_buf:
-       memblock_free(__pa(new_log_buf), new_log_buf_len);
+       memblock_free_ptr(new_log_buf, new_log_buf_len);
 }
 
 static bool __read_mostly ignore_loglevel;
index 35f7bd0..6d45ac3 100644 (file)
@@ -282,9 +282,17 @@ void __rseq_handle_notify_resume(struct ksignal *ksig, struct pt_regs *regs)
 
        if (unlikely(t->flags & PF_EXITING))
                return;
-       ret = rseq_ip_fixup(regs);
-       if (unlikely(ret < 0))
-               goto error;
+
+       /*
+        * regs is NULL if and only if the caller is in a syscall path.  Skip
+        * fixup and leave rseq_cs as is so that rseq_sycall() will detect and
+        * kill a misbehaving userspace on debug kernels.
+        */
+       if (regs) {
+               ret = rseq_ip_fixup(regs);
+               if (unlikely(ret < 0))
+                       goto error;
+       }
        if (unlikely(rseq_update_cpu_id(t)))
                goto error;
        return;
index 4971622..17a653b 100644 (file)
@@ -173,16 +173,22 @@ static ssize_t sched_scaling_write(struct file *filp, const char __user *ubuf,
                                   size_t cnt, loff_t *ppos)
 {
        char buf[16];
+       unsigned int scaling;
 
        if (cnt > 15)
                cnt = 15;
 
        if (copy_from_user(&buf, ubuf, cnt))
                return -EFAULT;
+       buf[cnt] = '\0';
 
-       if (kstrtouint(buf, 10, &sysctl_sched_tunable_scaling))
+       if (kstrtouint(buf, 10, &scaling))
                return -EINVAL;
 
+       if (scaling >= SCHED_TUNABLESCALING_END)
+               return -EINVAL;
+
+       sysctl_sched_tunable_scaling = scaling;
        if (sched_update_scaling())
                return -EINVAL;
 
index ff69f24..f6a05d9 100644 (file)
@@ -4936,8 +4936,12 @@ void unthrottle_cfs_rq(struct cfs_rq *cfs_rq)
        /* update hierarchical throttle state */
        walk_tg_tree_from(cfs_rq->tg, tg_nop, tg_unthrottle_up, (void *)rq);
 
-       if (!cfs_rq->load.weight)
+       /* Nothing to run but something to decay (on_list)? Complete the branch */
+       if (!cfs_rq->load.weight) {
+               if (cfs_rq->on_list)
+                       goto unthrottle_throttle;
                return;
+       }
 
        task_delta = cfs_rq->h_nr_running;
        idle_task_delta = cfs_rq->idle_h_nr_running;
index ee73686..643d412 100644 (file)
@@ -1404,7 +1404,8 @@ void set_process_cpu_timer(struct task_struct *tsk, unsigned int clkid,
                        }
                }
 
-               *newval += now;
+               if (*newval)
+                       *newval += now;
        }
 
        /*
index c221e4c..fa91f39 100644 (file)
@@ -1605,6 +1605,14 @@ static int blk_trace_remove_queue(struct request_queue *q)
        if (bt == NULL)
                return -EINVAL;
 
+       if (bt->trace_state == Blktrace_running) {
+               bt->trace_state = Blktrace_stopped;
+               spin_lock_irq(&running_trace_lock);
+               list_del_init(&bt->running_list);
+               spin_unlock_irq(&running_trace_lock);
+               relay_flush(bt->rchan);
+       }
+
        put_probe_ref();
        synchronize_rcu();
        blk_trace_free(bt);
index 7896d30..bc677cd 100644 (file)
@@ -1744,16 +1744,15 @@ void latency_fsnotify(struct trace_array *tr)
        irq_work_queue(&tr->fsnotify_irqwork);
 }
 
-/*
- * (defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)) && \
- *  defined(CONFIG_FSNOTIFY)
- */
-#else
+#elif defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER) \
+       || defined(CONFIG_OSNOISE_TRACER)
 
 #define trace_create_maxlat_file(tr, d_tracer)                         \
        trace_create_file("tracing_max_latency", 0644, d_tracer,        \
                          &tr->max_latency, &tracing_max_lat_fops)
 
+#else
+#define trace_create_maxlat_file(tr, d_tracer)  do { } while (0)
 #endif
 
 #ifdef CONFIG_TRACER_MAX_TRACE
@@ -9473,9 +9472,7 @@ init_tracer_tracefs(struct trace_array *tr, struct dentry *d_tracer)
 
        create_trace_options_dir(tr);
 
-#if defined(CONFIG_TRACER_MAX_TRACE) || defined(CONFIG_HWLAT_TRACER)
        trace_create_maxlat_file(tr, d_tracer);
-#endif
 
        if (ftrace_create_function_files(tr, d_tracer))
                MEM_FAIL(1, "Could not allocate function filter files");
index 3044b76..c4a15ae 100644 (file)
@@ -119,10 +119,58 @@ static bool eprobe_dyn_event_match(const char *system, const char *event,
                        int argc, const char **argv, struct dyn_event *ev)
 {
        struct trace_eprobe *ep = to_trace_eprobe(ev);
+       const char *slash;
 
-       return strcmp(trace_probe_name(&ep->tp), event) == 0 &&
-           (!system || strcmp(trace_probe_group_name(&ep->tp), system) == 0) &&
-           trace_probe_match_command_args(&ep->tp, argc, argv);
+       /*
+        * We match the following:
+        *  event only                  - match all eprobes with event name
+        *  system and event only       - match all system/event probes
+        *
+        * The below has the above satisfied with more arguments:
+        *
+        *  attached system/event       - If the arg has the system and event
+        *                                the probe is attached to, match
+        *                                probes with the attachment.
+        *
+        *  If any more args are given, then it requires a full match.
+        */
+
+       /*
+        * If system exists, but this probe is not part of that system
+        * do not match.
+        */
+       if (system && strcmp(trace_probe_group_name(&ep->tp), system) != 0)
+               return false;
+
+       /* Must match the event name */
+       if (strcmp(trace_probe_name(&ep->tp), event) != 0)
+               return false;
+
+       /* No arguments match all */
+       if (argc < 1)
+               return true;
+
+       /* First argument is the system/event the probe is attached to */
+
+       slash = strchr(argv[0], '/');
+       if (!slash)
+               slash = strchr(argv[0], '.');
+       if (!slash)
+               return false;
+
+       if (strncmp(ep->event_system, argv[0], slash - argv[0]))
+               return false;
+       if (strcmp(ep->event_name, slash + 1))
+               return false;
+
+       argc--;
+       argv++;
+
+       /* If there are no other args, then match */
+       if (argc < 1)
+               return true;
+
+       return trace_probe_match_command_args(&ep->tp, argc, argv);
 }
 
 static struct dyn_event_operations eprobe_dyn_event_ops = {
@@ -632,6 +680,13 @@ static int disable_eprobe(struct trace_eprobe *ep,
 
        trace_event_trigger_enable_disable(file, 0);
        update_cond_flag(file);
+
+       /* Make sure nothing is using the edata or trigger */
+       tracepoint_synchronize_unregister();
+
+       kfree(edata);
+       kfree(trigger);
+
        return 0;
 }
 
index a6061a6..f01e442 100644 (file)
@@ -2506,7 +2506,7 @@ find_synthetic_field_var(struct hist_trigger_data *target_hist_data,
  * events.  However, for convenience, users are allowed to directly
  * specify an event field in an action, which will be automatically
  * converted into a variable on their behalf.
-
+ *
  * If a user specifies a field on an event that isn't the event the
  * histogram currently being defined (the target event histogram), the
  * only way that can be accomplished is if a new hist trigger is
index 33a6b4a..1b3eb1e 100644 (file)
@@ -4830,8 +4830,16 @@ void show_workqueue_state(void)
 
                for_each_pwq(pwq, wq) {
                        raw_spin_lock_irqsave(&pwq->pool->lock, flags);
-                       if (pwq->nr_active || !list_empty(&pwq->inactive_works))
+                       if (pwq->nr_active || !list_empty(&pwq->inactive_works)) {
+                               /*
+                                * Defer printing to avoid deadlocks in console
+                                * drivers that queue work while holding locks
+                                * also taken in their write paths.
+                                */
+                               printk_deferred_enter();
                                show_pwq(pwq);
+                               printk_deferred_exit();
+                       }
                        raw_spin_unlock_irqrestore(&pwq->pool->lock, flags);
                        /*
                         * We could be printing a lot from atomic context, e.g.
@@ -4849,7 +4857,12 @@ void show_workqueue_state(void)
                raw_spin_lock_irqsave(&pool->lock, flags);
                if (pool->nr_workers == pool->nr_idle)
                        goto next_pool;
-
+               /*
+                * Defer printing to avoid deadlocks in console drivers that
+                * queue work while holding locks also taken in their write
+                * paths.
+                */
+               printk_deferred_enter();
                pr_info("pool %d:", pool->id);
                pr_cont_pool_info(pool);
                pr_cont(" hung=%us workers=%d",
@@ -4864,6 +4877,7 @@ void show_workqueue_state(void)
                        first = false;
                }
                pr_cont("\n");
+               printk_deferred_exit();
        next_pool:
                raw_spin_unlock_irqrestore(&pool->lock, flags);
                /*
index ed4a31e..2a9b6dc 100644 (file)
@@ -295,7 +295,7 @@ config DEBUG_INFO_DWARF4
 
 config DEBUG_INFO_DWARF5
        bool "Generate DWARF Version 5 debuginfo"
-       depends on GCC_VERSION >= 50000 || (CC_IS_CLANG && (AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502)))
+       depends on !CC_IS_CLANG || (CC_IS_CLANG && (AS_IS_LLVM || (AS_IS_GNU && AS_VERSION >= 23502)))
        depends on !DEBUG_INFO_BTF
        help
          Generate DWARF v5 debug info. Requires binutils 2.35.2, gcc 5.0+ (gcc
@@ -346,7 +346,7 @@ config FRAME_WARN
        int "Warn for stack frames larger than"
        range 0 8192
        default 2048 if GCC_PLUGIN_LATENT_ENTROPY
-       default 1536 if (!64BIT && PARISC)
+       default 1536 if (!64BIT && (PARISC || XTENSA))
        default 1024 if (!64BIT && !PARISC)
        default 2048 if 64BIT
        help
index 1e2d10f..cdc842d 100644 (file)
@@ -66,6 +66,7 @@ choice
 config KASAN_GENERIC
        bool "Generic mode"
        depends on HAVE_ARCH_KASAN && CC_HAS_KASAN_GENERIC
+       depends on CC_HAS_WORKING_NOSANITIZE_ADDRESS
        select SLUB_DEBUG if SLUB
        select CONSTRUCTORS
        help
@@ -86,6 +87,7 @@ config KASAN_GENERIC
 config KASAN_SW_TAGS
        bool "Software tag-based mode"
        depends on HAVE_ARCH_KASAN_SW_TAGS && CC_HAS_KASAN_SW_TAGS
+       depends on CC_HAS_WORKING_NOSANITIZE_ADDRESS
        select SLUB_DEBUG if SLUB
        select CONSTRUCTORS
        help
index 5efd1b4..a841be5 100644 (file)
@@ -351,7 +351,7 @@ obj-$(CONFIG_OBJAGG) += objagg.o
 obj-$(CONFIG_PLDMFW) += pldmfw/
 
 # KUnit tests
-CFLAGS_bitfield_kunit.o := $(call cc-option,-Wframe-larger-than=10240)
+CFLAGS_bitfield_kunit.o := $(DISABLE_STRUCTLEAK_PLUGIN)
 obj-$(CONFIG_BITFIELD_KUNIT) += bitfield_kunit.o
 obj-$(CONFIG_LIST_KUNIT_TEST) += list-test.o
 obj-$(CONFIG_LINEAR_RANGES_TEST) += test_linear_ranges.o
index f8419cf..5ae248b 100644 (file)
@@ -792,7 +792,7 @@ void __init xbc_destroy_all(void)
        xbc_data = NULL;
        xbc_data_size = 0;
        xbc_node_num = 0;
-       memblock_free(__pa(xbc_nodes), sizeof(struct xbc_node) * XBC_NODE_MAX);
+       memblock_free_ptr(xbc_nodes, sizeof(struct xbc_node) * XBC_NODE_MAX);
        xbc_nodes = NULL;
        brace_index = 0;
 }
index f2d50d6..755c10c 100644 (file)
@@ -1972,3 +1972,39 @@ int import_single_range(int rw, void __user *buf, size_t len,
        return 0;
 }
 EXPORT_SYMBOL(import_single_range);
+
+/**
+ * iov_iter_restore() - Restore a &struct iov_iter to the same state as when
+ *     iov_iter_save_state() was called.
+ *
+ * @i: &struct iov_iter to restore
+ * @state: state to restore from
+ *
+ * Used after iov_iter_save_state() to bring restore @i, if operations may
+ * have advanced it.
+ *
+ * Note: only works on ITER_IOVEC, ITER_BVEC, and ITER_KVEC
+ */
+void iov_iter_restore(struct iov_iter *i, struct iov_iter_state *state)
+{
+       if (WARN_ON_ONCE(!iov_iter_is_bvec(i) && !iter_is_iovec(i)) &&
+                        !iov_iter_is_kvec(i))
+               return;
+       i->iov_offset = state->iov_offset;
+       i->count = state->count;
+       /*
+        * For the *vec iters, nr_segs + iov is constant - if we increment
+        * the vec, then we also decrement the nr_segs count. Hence we don't
+        * need to track both of these, just one is enough and we can deduct
+        * the other from that. ITER_KVEC and ITER_IOVEC are the same struct
+        * size, so we can just increment the iov pointer as they are unionzed.
+        * ITER_BVEC _may_ be the same size on some archs, but on others it is
+        * not. Be safe and handle it separately.
+        */
+       BUILD_BUG_ON(sizeof(struct iovec) != sizeof(struct kvec));
+       if (iov_iter_is_bvec(i))
+               i->bvec -= state->nr_segs - i->nr_segs;
+       else
+               i->iov -= state->nr_segs - i->nr_segs;
+       i->nr_segs = state->nr_segs;
+}
index cdbe54b..e14a18a 100644 (file)
@@ -116,8 +116,8 @@ static void kfree_at_end(struct kunit *test, const void *to_free)
        /* kfree() handles NULL already, but avoid allocating a no-op cleanup. */
        if (IS_ERR_OR_NULL(to_free))
                return;
-       kunit_alloc_and_get_resource(test, NULL, kfree_res_free, GFP_KERNEL,
-                                    (void *)to_free);
+       kunit_alloc_resource(test, NULL, kfree_res_free, GFP_KERNEL,
+                            (void *)to_free);
 }
 
 static struct kunit_suite *alloc_fake_suite(struct kunit *test,
index 6ed72dc..9a72f4b 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: BSD-3-Clause OR GPL-2.0
-/* Copyright (c) 2016-2018, NXP Semiconductors
+/* Copyright 2016-2018 NXP
  * Copyright (c) 2018-2019, Vladimir Oltean <olteanv@gmail.com>
  */
 #include <linux/packing.h>
index 2d3eb1c..ce39ce9 100644 (file)
@@ -134,4 +134,47 @@ void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen)
        return pci_iomap_wc_range(dev, bar, 0, maxlen);
 }
 EXPORT_SYMBOL_GPL(pci_iomap_wc);
+
+/*
+ * pci_iounmap() somewhat illogically comes from lib/iomap.c for the
+ * CONFIG_GENERIC_IOMAP case, because that's the code that knows about
+ * the different IOMAP ranges.
+ *
+ * But if the architecture does not use the generic iomap code, and if
+ * it has _not_ defined it's own private pci_iounmap function, we define
+ * it here.
+ *
+ * NOTE! This default implementation assumes that if the architecture
+ * support ioport mapping (HAS_IOPORT_MAP), the ioport mapping will
+ * be fixed to the range [ PCI_IOBASE, PCI_IOBASE+IO_SPACE_LIMIT [,
+ * and does not need unmapping with 'ioport_unmap()'.
+ *
+ * If you have different rules for your architecture, you need to
+ * implement your own pci_iounmap() that knows the rules for where
+ * and how IO vs MEM get mapped.
+ *
+ * This code is odd, and the ARCH_HAS/ARCH_WANTS #define logic comes
+ * from legacy <asm-generic/io.h> header file behavior. In particular,
+ * it would seem to make sense to do the iounmap(p) for the non-IO-space
+ * case here regardless, but that's not what the old header file code
+ * did. Probably incorrectly, but this is meant to be bug-for-bug
+ * compatible.
+ */
+#if defined(ARCH_WANTS_GENERIC_PCI_IOUNMAP)
+
+void pci_iounmap(struct pci_dev *dev, void __iomem *p)
+{
+#ifdef ARCH_HAS_GENERIC_IOPORT_MAP
+       uintptr_t start = (uintptr_t) PCI_IOBASE;
+       uintptr_t addr = (uintptr_t) p;
+
+       if (addr >= start && addr < start + IO_SPACE_LIMIT)
+               return;
+       iounmap(p);
+#endif
+}
+EXPORT_SYMBOL(pci_iounmap);
+
+#endif /* ARCH_WANTS_GENERIC_PCI_IOUNMAP */
+
 #endif /* CONFIG_PCI */
index f19c4fb..2843f9b 100644 (file)
@@ -253,13 +253,12 @@ void inflate_fast(z_streamp strm, unsigned start)
 
                        sfrom = (unsigned short *)(from);
                        loops = len >> 1;
-                       do
-#ifdef CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS
-                           *sout++ = *sfrom++;
-#else
-                           *sout++ = get_unaligned16(sfrom++);
-#endif
-                       while (--loops);
+                       do {
+                           if (IS_ENABLED(CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS))
+                               *sout++ = *sfrom++;
+                           else
+                               *sout++ = get_unaligned16(sfrom++);
+                       } while (--loops);
                        out = (unsigned char *)sout;
                        from = (unsigned char *)sfrom;
                    } else { /* dist == 1 or dist == 2 */
index 930e83b..4eddcfa 100644 (file)
@@ -20,27 +20,27 @@ static void damon_dbgfs_test_str_to_target_ids(struct kunit *test)
        ssize_t nr_integers = 0, i;
 
        question = "123";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)1, nr_integers);
        KUNIT_EXPECT_EQ(test, 123ul, answers[0]);
        kfree(answers);
 
        question = "123abc";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)1, nr_integers);
        KUNIT_EXPECT_EQ(test, 123ul, answers[0]);
        kfree(answers);
 
        question = "a123";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)0, nr_integers);
        kfree(answers);
 
        question = "12 35";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)2, nr_integers);
        for (i = 0; i < nr_integers; i++)
@@ -48,7 +48,7 @@ static void damon_dbgfs_test_str_to_target_ids(struct kunit *test)
        kfree(answers);
 
        question = "12 35 46";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)3, nr_integers);
        for (i = 0; i < nr_integers; i++)
@@ -56,7 +56,7 @@ static void damon_dbgfs_test_str_to_target_ids(struct kunit *test)
        kfree(answers);
 
        question = "12 35 abc 46";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)2, nr_integers);
        for (i = 0; i < 2; i++)
@@ -64,13 +64,13 @@ static void damon_dbgfs_test_str_to_target_ids(struct kunit *test)
        kfree(answers);
 
        question = "";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)0, nr_integers);
        kfree(answers);
 
        question = "\n";
-       answers = str_to_target_ids(question, strnlen(question, 128),
+       answers = str_to_target_ids(question, strlen(question),
                        &nr_integers);
        KUNIT_EXPECT_EQ(test, (ssize_t)0, nr_integers);
        kfree(answers);
index e73fe0a..fae0f81 100644 (file)
@@ -24,7 +24,9 @@ const char *migrate_reason_names[MR_TYPES] = {
        "syscall_or_cpuset",
        "mempolicy_mbind",
        "numa_misplaced",
-       "cma",
+       "contig_range",
+       "longterm_pin",
+       "demotion",
 };
 
 const struct trace_print_flags pageflag_names[] = {
index 0253381..a5716fd 100644 (file)
--- a/mm/ksm.c
+++ b/mm/ksm.c
@@ -651,10 +651,8 @@ static void remove_node_from_stable_tree(struct stable_node *stable_node)
         * from &migrate_nodes. This will verify that future list.h changes
         * don't break STABLE_NODE_DUP_HEAD. Only recent gcc can handle it.
         */
-#if defined(GCC_VERSION) && GCC_VERSION >= 40903
        BUILD_BUG_ON(STABLE_NODE_DUP_HEAD <= &migrate_nodes);
        BUILD_BUG_ON(STABLE_NODE_DUP_HEAD >= &migrate_nodes + 1);
-#endif
 
        if (stable_node->head == &migrate_nodes)
                list_del(&stable_node->list);
index 0ab5a74..5c3503c 100644 (file)
@@ -472,7 +472,7 @@ static int __init_memblock memblock_double_array(struct memblock_type *type,
                kfree(old_array);
        else if (old_array != memblock_memory_init_regions &&
                 old_array != memblock_reserved_init_regions)
-               memblock_free(__pa(old_array), old_alloc_size);
+               memblock_free_ptr(old_array, old_alloc_size);
 
        /*
         * Reserve the new array if that comes from the memblock.  Otherwise, we
@@ -795,6 +795,20 @@ int __init_memblock memblock_remove(phys_addr_t base, phys_addr_t size)
        return memblock_remove_range(&memblock.memory, base, size);
 }
 
+/**
+ * memblock_free_ptr - free boot memory allocation
+ * @ptr: starting address of the  boot memory allocation
+ * @size: size of the boot memory block in bytes
+ *
+ * Free boot memory block previously allocated by memblock_alloc_xx() API.
+ * The freeing memory will not be released to the buddy allocator.
+ */
+void __init_memblock memblock_free_ptr(void *ptr, size_t size)
+{
+       if (ptr)
+               memblock_free(__pa(ptr), size);
+}
+
 /**
  * memblock_free - free boot memory block
  * @base: phys starting address of the  boot memory block
@@ -922,7 +936,12 @@ int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size)
  */
 int __init_memblock memblock_mark_nomap(phys_addr_t base, phys_addr_t size)
 {
-       return memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP);
+       int ret = memblock_setclr_flag(base, size, 1, MEMBLOCK_NOMAP);
+
+       if (!ret)
+               kmemleak_free_part_phys(base, size);
+
+       return ret;
 }
 
 /**
index b762215..6da5020 100644 (file)
@@ -106,9 +106,6 @@ static bool do_memsw_account(void)
 /* memcg and lruvec stats flushing */
 static void flush_memcg_stats_dwork(struct work_struct *w);
 static DECLARE_DEFERRABLE_WORK(stats_flush_dwork, flush_memcg_stats_dwork);
-static void flush_memcg_stats_work(struct work_struct *w);
-static DECLARE_WORK(stats_flush_work, flush_memcg_stats_work);
-static DEFINE_PER_CPU(unsigned int, stats_flush_threshold);
 static DEFINE_SPINLOCK(stats_flush_lock);
 
 #define THRESHOLDS_EVENTS_TARGET 128
@@ -682,8 +679,6 @@ void __mod_memcg_lruvec_state(struct lruvec *lruvec, enum node_stat_item idx,
 
        /* Update lruvec */
        __this_cpu_add(pn->lruvec_stats_percpu->state[idx], val);
-       if (!(__this_cpu_inc_return(stats_flush_threshold) % MEMCG_CHARGE_BATCH))
-               queue_work(system_unbound_wq, &stats_flush_work);
 }
 
 /**
@@ -5361,11 +5356,6 @@ static void flush_memcg_stats_dwork(struct work_struct *w)
        queue_delayed_work(system_unbound_wq, &stats_flush_dwork, 2UL*HZ);
 }
 
-static void flush_memcg_stats_work(struct work_struct *w)
-{
-       mem_cgroup_flush_stats();
-}
-
 static void mem_cgroup_css_rstat_flush(struct cgroup_subsys_state *css, int cpu)
 {
        struct mem_cgroup *memcg = mem_cgroup_from_css(css);
index 54879c3..3e6449f 100644 (file)
@@ -306,6 +306,7 @@ static unsigned long dev_pagemap_mapping_shift(struct page *page,
                struct vm_area_struct *vma)
 {
        unsigned long address = vma_address(page, vma);
+       unsigned long ret = 0;
        pgd_t *pgd;
        p4d_t *p4d;
        pud_t *pud;
@@ -329,11 +330,10 @@ static unsigned long dev_pagemap_mapping_shift(struct page *page,
        if (pmd_devmap(*pmd))
                return PMD_SHIFT;
        pte = pte_offset_map(pmd, address);
-       if (!pte_present(*pte))
-               return 0;
-       if (pte_devmap(*pte))
-               return PAGE_SHIFT;
-       return 0;
+       if (pte_present(*pte) && pte_devmap(*pte))
+               ret = PAGE_SHIFT;
+       pte_unmap(pte);
+       return ret;
 }
 
 /*
@@ -1126,7 +1126,7 @@ static int page_action(struct page_state *ps, struct page *p,
  */
 static inline bool HWPoisonHandlable(struct page *page)
 {
-       return PageLRU(page) || __PageMovable(page);
+       return PageLRU(page) || __PageMovable(page) || is_free_buddy_page(page);
 }
 
 static int __get_hwpoison_page(struct page *page)
index 25fc46e..adf9b9e 100644 (file)
@@ -3403,6 +3403,7 @@ void unmap_mapping_pages(struct address_space *mapping, pgoff_t start,
                unmap_mapping_range_tree(&mapping->i_mmap, &details);
        i_mmap_unlock_write(mapping);
 }
+EXPORT_SYMBOL_GPL(unmap_mapping_pages);
 
 /**
  * unmap_mapping_range - unmap the portion of all mmaps in the specified
index 8874295..b5860f4 100644 (file)
@@ -490,9 +490,9 @@ bool shmem_is_huge(struct vm_area_struct *vma,
        case SHMEM_HUGE_ALWAYS:
                return true;
        case SHMEM_HUGE_WITHIN_SIZE:
-               index = round_up(index, HPAGE_PMD_NR);
+               index = round_up(index + 1, HPAGE_PMD_NR);
                i_size = round_up(i_size_read(inode), PAGE_SIZE);
-               if (i_size >= HPAGE_PMD_SIZE && (i_size >> PAGE_SHIFT) >= index)
+               if (i_size >> PAGE_SHIFT >= index)
                        return true;
                fallthrough;
        case SHMEM_HUGE_ADVISE:
index 897200d..af3cad4 100644 (file)
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -620,7 +620,6 @@ void lru_add_drain_cpu(int cpu)
                pagevec_lru_move_fn(pvec, lru_lazyfree_fn);
 
        activate_page_drain(cpu);
-       invalidate_bh_lrus_cpu(cpu);
 }
 
 /**
@@ -703,6 +702,20 @@ void lru_add_drain(void)
        local_unlock(&lru_pvecs.lock);
 }
 
+/*
+ * It's called from per-cpu workqueue context in SMP case so
+ * lru_add_drain_cpu and invalidate_bh_lrus_cpu should run on
+ * the same cpu. It shouldn't be a problem in !SMP case since
+ * the core is only one and the locks will disable preemption.
+ */
+static void lru_add_and_bh_lrus_drain(void)
+{
+       local_lock(&lru_pvecs.lock);
+       lru_add_drain_cpu(smp_processor_id());
+       local_unlock(&lru_pvecs.lock);
+       invalidate_bh_lrus_cpu();
+}
+
 void lru_add_drain_cpu_zone(struct zone *zone)
 {
        local_lock(&lru_pvecs.lock);
@@ -717,7 +730,7 @@ static DEFINE_PER_CPU(struct work_struct, lru_add_drain_work);
 
 static void lru_add_drain_per_cpu(struct work_struct *dummy)
 {
-       lru_add_drain();
+       lru_add_and_bh_lrus_drain();
 }
 
 /*
@@ -858,7 +871,7 @@ void lru_cache_disable(void)
         */
        __lru_add_drain_all(true);
 #else
-       lru_add_drain();
+       lru_add_and_bh_lrus_drain();
 #endif
 }
 
index 499b6b5..bacabe4 100644 (file)
--- a/mm/util.c
+++ b/mm/util.c
@@ -787,7 +787,7 @@ int overcommit_policy_handler(struct ctl_table *table, int write, void *buffer,
                size_t *lenp, loff_t *ppos)
 {
        struct ctl_table t;
-       int new_policy;
+       int new_policy = -1;
        int ret;
 
        /*
@@ -805,7 +805,7 @@ int overcommit_policy_handler(struct ctl_table *table, int write, void *buffer,
                t = *table;
                t.data = &new_policy;
                ret = proc_dointvec_minmax(&t, write, buffer, lenp, ppos);
-               if (ret)
+               if (ret || new_policy == -1)
                        return ret;
 
                mm_compute_batch(new_policy);
index d4268d8..d5b81e4 100644 (file)
@@ -352,6 +352,7 @@ void workingset_refault(struct page *page, void *shadow)
 
        inc_lruvec_state(lruvec, WORKINGSET_REFAULT_BASE + file);
 
+       mem_cgroup_flush_stats();
        /*
         * Compare the distance to the existing workingset size. We
         * don't activate pages that couldn't stay resident even if
index 2eb0e55..b5f4ef3 100644 (file)
@@ -552,6 +552,12 @@ static void convert_skb_to___skb(struct sk_buff *skb, struct __sk_buff *__skb)
        __skb->gso_segs = skb_shinfo(skb)->gso_segs;
 }
 
+static struct proto bpf_dummy_proto = {
+       .name   = "bpf_dummy",
+       .owner  = THIS_MODULE,
+       .obj_size = sizeof(struct sock),
+};
+
 int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
                          union bpf_attr __user *uattr)
 {
@@ -596,20 +602,19 @@ int bpf_prog_test_run_skb(struct bpf_prog *prog, const union bpf_attr *kattr,
                break;
        }
 
-       sk = kzalloc(sizeof(struct sock), GFP_USER);
+       sk = sk_alloc(net, AF_UNSPEC, GFP_USER, &bpf_dummy_proto, 1);
        if (!sk) {
                kfree(data);
                kfree(ctx);
                return -ENOMEM;
        }
-       sock_net_set(sk, net);
        sock_init_data(NULL, sk);
 
        skb = build_skb(data, 0);
        if (!skb) {
                kfree(data);
                kfree(ctx);
-               kfree(sk);
+               sk_free(sk);
                return -ENOMEM;
        }
        skb->sk = sk;
@@ -682,8 +687,7 @@ out:
        if (dev && dev != net->loopback_dev)
                dev_put(dev);
        kfree_skb(skb);
-       bpf_sk_storage_free(sk);
-       kfree(sk);
+       sk_free(sk);
        kfree(ctx);
        return ret;
 }
index 3523c8c..f3d7511 100644 (file)
@@ -1677,8 +1677,6 @@ static void br_multicast_update_querier(struct net_bridge_mcast *brmctx,
                                        int ifindex,
                                        struct br_ip *saddr)
 {
-       lockdep_assert_held_once(&brmctx->br->multicast_lock);
-
        write_seqcount_begin(&querier->seq);
        querier->port_ifidx = ifindex;
        memcpy(&querier->addr, saddr, sizeof(*saddr));
@@ -3867,13 +3865,13 @@ void br_multicast_ctx_init(struct net_bridge *br,
 
        brmctx->ip4_other_query.delay_time = 0;
        brmctx->ip4_querier.port_ifidx = 0;
-       seqcount_init(&brmctx->ip4_querier.seq);
+       seqcount_spinlock_init(&brmctx->ip4_querier.seq, &br->multicast_lock);
        brmctx->multicast_igmp_version = 2;
 #if IS_ENABLED(CONFIG_IPV6)
        brmctx->multicast_mld_version = 1;
        brmctx->ip6_other_query.delay_time = 0;
        brmctx->ip6_querier.port_ifidx = 0;
-       seqcount_init(&brmctx->ip6_querier.seq);
+       seqcount_spinlock_init(&brmctx->ip6_querier.seq, &br->multicast_lock);
 #endif
 
        timer_setup(&brmctx->ip4_mc_router_timer,
index 6c58fc1..5c6c430 100644 (file)
@@ -1666,7 +1666,8 @@ static size_t br_get_linkxstats_size(const struct net_device *dev, int attr)
        }
 
        return numvls * nla_total_size(sizeof(struct bridge_vlan_xstats)) +
-              nla_total_size(sizeof(struct br_mcast_stats)) +
+              nla_total_size_64bit(sizeof(struct br_mcast_stats)) +
+              (p ? nla_total_size_64bit(sizeof(p->stp_xstats)) : 0) +
               nla_total_size(0);
 }
 
index b4cef3a..e8136db 100644 (file)
@@ -82,7 +82,7 @@ struct bridge_mcast_other_query {
 struct bridge_mcast_querier {
        struct br_ip addr;
        int port_ifidx;
-       seqcount_t seq;
+       seqcount_spinlock_t seq;
 };
 
 /* IGMP/MLD statistics */
index 37b6719..414dc56 100644 (file)
@@ -53,20 +53,6 @@ struct chnl_net {
        enum caif_states state;
 };
 
-static void robust_list_del(struct list_head *delete_node)
-{
-       struct list_head *list_node;
-       struct list_head *n;
-       ASSERT_RTNL();
-       list_for_each_safe(list_node, n, &chnl_net_list) {
-               if (list_node == delete_node) {
-                       list_del(list_node);
-                       return;
-               }
-       }
-       WARN_ON(1);
-}
-
 static int chnl_recv_cb(struct cflayer *layr, struct cfpkt *pkt)
 {
        struct sk_buff *skb;
@@ -364,6 +350,7 @@ static int chnl_net_init(struct net_device *dev)
        ASSERT_RTNL();
        priv = netdev_priv(dev);
        strncpy(priv->name, dev->name, sizeof(priv->name));
+       INIT_LIST_HEAD(&priv->list_field);
        return 0;
 }
 
@@ -372,7 +359,7 @@ static void chnl_net_uninit(struct net_device *dev)
        struct chnl_net *priv;
        ASSERT_RTNL();
        priv = netdev_priv(dev);
-       robust_list_del(&priv->list_field);
+       list_del_init(&priv->list_field);
 }
 
 static const struct net_device_ops netdev_ops = {
@@ -537,7 +524,7 @@ static void __exit chnl_exit_module(void)
        rtnl_lock();
        list_for_each_safe(list_node, _tmp, &chnl_net_list) {
                dev = list_entry(list_node, struct chnl_net, list_field);
-               list_del(list_node);
+               list_del_init(list_node);
                delete_device(dev);
        }
        rtnl_unlock();
index 74fd402..7ee9fec 100644 (file)
@@ -6923,12 +6923,16 @@ EXPORT_SYMBOL(napi_disable);
  */
 void napi_enable(struct napi_struct *n)
 {
-       BUG_ON(!test_bit(NAPI_STATE_SCHED, &n->state));
-       smp_mb__before_atomic();
-       clear_bit(NAPI_STATE_SCHED, &n->state);
-       clear_bit(NAPI_STATE_NPSVC, &n->state);
-       if (n->dev->threaded && n->thread)
-               set_bit(NAPI_STATE_THREADED, &n->state);
+       unsigned long val, new;
+
+       do {
+               val = READ_ONCE(n->state);
+               BUG_ON(!test_bit(NAPI_STATE_SCHED, &val));
+
+               new = val & ~(NAPIF_STATE_SCHED | NAPIF_STATE_NPSVC);
+               if (n->dev->threaded && n->thread)
+                       new |= NAPIF_STATE_THREADED;
+       } while (cmpxchg(&n->state, val, new) != val);
 }
 EXPORT_SYMBOL(napi_enable);
 
index 8c39283..f0cb383 100644 (file)
@@ -50,6 +50,11 @@ static int __hw_addr_add_ex(struct netdev_hw_addr_list *list,
        if (addr_len > MAX_ADDR_LEN)
                return -EINVAL;
 
+       ha = list_first_entry(&list->list, struct netdev_hw_addr, list);
+       if (ha && !memcmp(addr, ha->addr, addr_len) &&
+           (!addr_type || addr_type == ha->type))
+               goto found_it;
+
        while (*ins_point) {
                int diff;
 
@@ -64,6 +69,7 @@ static int __hw_addr_add_ex(struct netdev_hw_addr_list *list,
                } else if (diff > 0) {
                        ins_point = &parent->rb_right;
                } else {
+found_it:
                        if (exclusive)
                                return -EEXIST;
                        if (global) {
index eab5fc8..d8b9dba 100644 (file)
@@ -77,8 +77,8 @@ static void dev_seq_printf_stats(struct seq_file *seq, struct net_device *dev)
        struct rtnl_link_stats64 temp;
        const struct rtnl_link_stats64 *stats = dev_get_stats(dev, &temp);
 
-       seq_printf(seq, "%9s: %16llu %12llu %4llu %6llu %4llu %5llu %10llu %9llu "
-                  "%16llu %12llu %4llu %6llu %4llu %5llu %7llu %10llu\n",
+       seq_printf(seq, "%6s: %7llu %7llu %4llu %4llu %4llu %5llu %10llu %9llu "
+                  "%8llu %7llu %4llu %4llu %4llu %5llu %7llu %10llu\n",
                   dev->name, stats->rx_bytes, stats->rx_packets,
                   stats->rx_errors,
                   stats->rx_dropped + stats->rx_missed_errors,
@@ -103,11 +103,11 @@ static void dev_seq_printf_stats(struct seq_file *seq, struct net_device *dev)
 static int dev_seq_show(struct seq_file *seq, void *v)
 {
        if (v == SEQ_START_TOKEN)
-               seq_puts(seq, "Interface|                            Receive                   "
-                             "                    |                                 Transmit\n"
-                             "         |            bytes      packets errs   drop fifo frame "
-                             "compressed multicast|            bytes      packets errs "
-                             "  drop fifo colls carrier compressed\n");
+               seq_puts(seq, "Inter-|   Receive                            "
+                             "                    |  Transmit\n"
+                             " face |bytes    packets errs drop fifo frame "
+                             "compressed multicast|bytes    packets errs "
+                             "drop fifo colls carrier compressed\n");
        else
                dev_seq_printf_stats(seq, v);
        return 0;
@@ -259,14 +259,14 @@ static int ptype_seq_show(struct seq_file *seq, void *v)
        struct packet_type *pt = v;
 
        if (v == SEQ_START_TOKEN)
-               seq_puts(seq, "Type      Device      Function\n");
+               seq_puts(seq, "Type Device      Function\n");
        else if (pt->dev == NULL || dev_net(pt->dev) == seq_file_net(seq)) {
                if (pt->type == htons(ETH_P_ALL))
                        seq_puts(seq, "ALL ");
                else
                        seq_printf(seq, "%04x", ntohs(pt->type));
 
-               seq_printf(seq, "      %-9s   %ps\n",
+               seq_printf(seq, " %-8s %ps\n",
                           pt->dev ? pt->dev->name : "", pt->func);
        }
 
@@ -327,14 +327,12 @@ static int dev_mc_seq_show(struct seq_file *seq, void *v)
        struct netdev_hw_addr *ha;
        struct net_device *dev = v;
 
-       if (v == SEQ_START_TOKEN) {
-               seq_puts(seq, "Ifindex Interface Refcount Global_use Address\n");
+       if (v == SEQ_START_TOKEN)
                return 0;
-       }
 
        netif_addr_lock_bh(dev);
        netdev_for_each_mc_addr(ha, dev) {
-               seq_printf(seq, "%-7d %-9s %-8d %-10d %*phN\n",
+               seq_printf(seq, "%-4d %-15s %-5d %-5d %*phN\n",
                           dev->ifindex, dev->name,
                           ha->refcount, ha->global_use,
                           (int)dev->addr_len, ha->addr);
index b49c57d..1a6a866 100644 (file)
@@ -71,11 +71,8 @@ static int update_classid_sock(const void *v, struct file *file, unsigned n)
        struct update_classid_context *ctx = (void *)v;
        struct socket *sock = sock_from_file(file);
 
-       if (sock) {
-               spin_lock(&cgroup_sk_update_lock);
+       if (sock)
                sock_cgroup_set_classid(&sock->sk->sk_cgrp_data, ctx->classid);
-               spin_unlock(&cgroup_sk_update_lock);
-       }
        if (--ctx->batch == 0) {
                ctx->batch = UPDATE_CLASSID_BATCH;
                return n + 1;
@@ -121,8 +118,6 @@ static int write_classid(struct cgroup_subsys_state *css, struct cftype *cft,
        struct css_task_iter it;
        struct task_struct *p;
 
-       cgroup_sk_alloc_disable();
-
        cs->classid = (u32)value;
 
        css_task_iter_start(css, 0, &it);
index 99a431c..8456dfb 100644 (file)
@@ -207,8 +207,6 @@ static ssize_t write_priomap(struct kernfs_open_file *of,
        if (!dev)
                return -ENODEV;
 
-       cgroup_sk_alloc_disable();
-
        rtnl_lock();
 
        ret = netprio_set_prio(of_css(of), dev, prio);
@@ -221,12 +219,10 @@ static ssize_t write_priomap(struct kernfs_open_file *of,
 static int update_netprio(const void *v, struct file *file, unsigned n)
 {
        struct socket *sock = sock_from_file(file);
-       if (sock) {
-               spin_lock(&cgroup_sk_update_lock);
+
+       if (sock)
                sock_cgroup_set_prioidx(&sock->sk->sk_cgrp_data,
                                        (unsigned long)v);
-               spin_unlock(&cgroup_sk_update_lock);
-       }
        return 0;
 }
 
@@ -235,8 +231,6 @@ static void net_prio_attach(struct cgroup_taskset *tset)
        struct task_struct *p;
        struct cgroup_subsys_state *css;
 
-       cgroup_sk_alloc_disable();
-
        cgroup_taskset_for_each(p, css, tset) {
                void *v = (void *)(unsigned long)css->id;
 
index 972c8cb..8ccce85 100644 (file)
@@ -5262,7 +5262,7 @@ nla_put_failure:
 static size_t if_nlmsg_stats_size(const struct net_device *dev,
                                  u32 filter_mask)
 {
-       size_t size = 0;
+       size_t size = NLMSG_ALIGN(sizeof(struct if_stats_msg));
 
        if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_64, 0))
                size += nla_total_size_64bit(sizeof(struct rtnl_link_stats64));
index 62627e8..c1601f7 100644 (file)
@@ -1376,6 +1376,16 @@ set_sndbuf:
 }
 EXPORT_SYMBOL(sock_setsockopt);
 
+static const struct cred *sk_get_peer_cred(struct sock *sk)
+{
+       const struct cred *cred;
+
+       spin_lock(&sk->sk_peer_lock);
+       cred = get_cred(sk->sk_peer_cred);
+       spin_unlock(&sk->sk_peer_lock);
+
+       return cred;
+}
 
 static void cred_to_ucred(struct pid *pid, const struct cred *cred,
                          struct ucred *ucred)
@@ -1552,7 +1562,11 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
                struct ucred peercred;
                if (len > sizeof(peercred))
                        len = sizeof(peercred);
+
+               spin_lock(&sk->sk_peer_lock);
                cred_to_ucred(sk->sk_peer_pid, sk->sk_peer_cred, &peercred);
+               spin_unlock(&sk->sk_peer_lock);
+
                if (copy_to_user(optval, &peercred, len))
                        return -EFAULT;
                goto lenout;
@@ -1560,20 +1574,23 @@ int sock_getsockopt(struct socket *sock, int level, int optname,
 
        case SO_PEERGROUPS:
        {
+               const struct cred *cred;
                int ret, n;
 
-               if (!sk->sk_peer_cred)
+               cred = sk_get_peer_cred(sk);
+               if (!cred)
                        return -ENODATA;
 
-               n = sk->sk_peer_cred->group_info->ngroups;
+               n = cred->group_info->ngroups;
                if (len < n * sizeof(gid_t)) {
                        len = n * sizeof(gid_t);
+                       put_cred(cred);
                        return put_user(len, optlen) ? -EFAULT : -ERANGE;
                }
                len = n * sizeof(gid_t);
 
-               ret = groups_to_user((gid_t __user *)optval,
-                                    sk->sk_peer_cred->group_info);
+               ret = groups_to_user((gid_t __user *)optval, cred->group_info);
+               put_cred(cred);
                if (ret)
                        return ret;
                goto lenout;
@@ -1935,9 +1952,10 @@ static void __sk_destruct(struct rcu_head *head)
                sk->sk_frag.page = NULL;
        }
 
-       if (sk->sk_peer_cred)
-               put_cred(sk->sk_peer_cred);
+       /* We do not need to acquire sk->sk_peer_lock, we are the last user. */
+       put_cred(sk->sk_peer_cred);
        put_pid(sk->sk_peer_pid);
+
        if (likely(sk->sk_net_refcnt))
                put_net(sock_net(sk));
        sk_prot_free(sk->sk_prot_creator, sk);
@@ -3145,6 +3163,8 @@ void sock_init_data(struct socket *sock, struct sock *sk)
 
        sk->sk_peer_pid         =       NULL;
        sk->sk_peer_cred        =       NULL;
+       spin_lock_init(&sk->sk_peer_lock);
+
        sk->sk_write_pending    =       0;
        sk->sk_rcvlowat         =       1;
        sk->sk_rcvtimeo         =       MAX_SCHEDULE_TIMEOUT;
@@ -3179,17 +3199,15 @@ EXPORT_SYMBOL(sock_init_data);
 
 void lock_sock_nested(struct sock *sk, int subclass)
 {
+       /* The sk_lock has mutex_lock() semantics here. */
+       mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_);
+
        might_sleep();
        spin_lock_bh(&sk->sk_lock.slock);
        if (sk->sk_lock.owned)
                __lock_sock(sk);
        sk->sk_lock.owned = 1;
-       spin_unlock(&sk->sk_lock.slock);
-       /*
-        * The sk_lock has mutex_lock() semantics here:
-        */
-       mutex_acquire(&sk->sk_lock.dep_map, subclass, 0, _RET_IP_);
-       local_bh_enable();
+       spin_unlock_bh(&sk->sk_lock.slock);
 }
 EXPORT_SYMBOL(lock_sock_nested);
 
@@ -3212,42 +3230,37 @@ void release_sock(struct sock *sk)
 }
 EXPORT_SYMBOL(release_sock);
 
-/**
- * lock_sock_fast - fast version of lock_sock
- * @sk: socket
- *
- * This version should be used for very small section, where process wont block
- * return false if fast path is taken:
- *
- *   sk_lock.slock locked, owned = 0, BH disabled
- *
- * return true if slow path is taken:
- *
- *   sk_lock.slock unlocked, owned = 1, BH enabled
- */
-bool lock_sock_fast(struct sock *sk) __acquires(&sk->sk_lock.slock)
+bool __lock_sock_fast(struct sock *sk) __acquires(&sk->sk_lock.slock)
 {
        might_sleep();
        spin_lock_bh(&sk->sk_lock.slock);
 
-       if (!sk->sk_lock.owned)
+       if (!sk->sk_lock.owned) {
                /*
-                * Note : We must disable BH
+                * Fast path return with bottom halves disabled and
+                * sock::sk_lock.slock held.
+                *
+                * The 'mutex' is not contended and holding
+                * sock::sk_lock.slock prevents all other lockers to
+                * proceed so the corresponding unlock_sock_fast() can
+                * avoid the slow path of release_sock() completely and
+                * just release slock.
+                *
+                * From a semantical POV this is equivalent to 'acquiring'
+                * the 'mutex', hence the corresponding lockdep
+                * mutex_release() has to happen in the fast path of
+                * unlock_sock_fast().
                 */
                return false;
+       }
 
        __lock_sock(sk);
        sk->sk_lock.owned = 1;
-       spin_unlock(&sk->sk_lock.slock);
-       /*
-        * The sk_lock has mutex_lock() semantics here:
-        */
-       mutex_acquire(&sk->sk_lock.dep_map, 0, 0, _RET_IP_);
        __acquire(&sk->sk_lock.slock);
-       local_bh_enable();
+       spin_unlock_bh(&sk->sk_lock.slock);
        return true;
 }
-EXPORT_SYMBOL(lock_sock_fast);
+EXPORT_SYMBOL(__lock_sock_fast);
 
 int sock_gettstamp(struct socket *sock, void __user *userstamp,
                   bool timeval, bool time32)
index c5c74a3..91e7a22 100644 (file)
@@ -94,6 +94,8 @@ struct sock *dccp_create_openreq_child(const struct sock *sk,
                newdp->dccps_role           = DCCP_ROLE_SERVER;
                newdp->dccps_hc_rx_ackvec   = NULL;
                newdp->dccps_service_list   = NULL;
+               newdp->dccps_hc_rx_ccid     = NULL;
+               newdp->dccps_hc_tx_ccid     = NULL;
                newdp->dccps_service        = dreq->dreq_service;
                newdp->dccps_timestamp_echo = dreq->dreq_timestamp_echo;
                newdp->dccps_timestamp_time = dreq->dreq_timestamp_time;
index 5482855..d8ee15f 100644 (file)
@@ -101,8 +101,6 @@ config NET_DSA_TAG_RTL4_A
 
 config NET_DSA_TAG_OCELOT
        tristate "Tag driver for Ocelot family of switches, using NPI port"
-       depends on MSCC_OCELOT_SWITCH_LIB || \
-                  (MSCC_OCELOT_SWITCH_LIB=n && COMPILE_TEST)
        select PACKING
        help
          Say Y or M if you want to enable NPI tagging for the Ocelot switches
@@ -114,8 +112,6 @@ config NET_DSA_TAG_OCELOT
 
 config NET_DSA_TAG_OCELOT_8021Q
        tristate "Tag driver for Ocelot family of switches, using VLAN"
-       depends on MSCC_OCELOT_SWITCH_LIB || \
-                 (MSCC_OCELOT_SWITCH_LIB=n && COMPILE_TEST)
        help
          Say Y or M if you want to enable support for tagging frames with a
          custom VLAN-based header. Frames that require timestamping, such as
@@ -138,7 +134,6 @@ config NET_DSA_TAG_LAN9303
 
 config NET_DSA_TAG_SJA1105
        tristate "Tag driver for NXP SJA1105 switches"
-       depends on NET_DSA_SJA1105 || !NET_DSA_SJA1105
        select PACKING
        help
          Say Y or M if you want to enable support for tagging frames with the
index 1dc45e4..41f36ad 100644 (file)
@@ -345,6 +345,11 @@ bool dsa_schedule_work(struct work_struct *work)
        return queue_work(dsa_owq, work);
 }
 
+void dsa_flush_workqueue(void)
+{
+       flush_workqueue(dsa_owq);
+}
+
 int dsa_devlink_param_get(struct devlink *dl, u32 id,
                          struct devlink_param_gset_ctx *ctx)
 {
index 1b2b25d..da18094 100644 (file)
@@ -170,7 +170,7 @@ void dsa_bridge_num_put(const struct net_device *bridge_dev, int bridge_num)
        /* Check if the bridge is still in use, otherwise it is time
         * to clean it up so we can reuse this bridge_num later.
         */
-       if (!dsa_bridge_num_find(bridge_dev))
+       if (dsa_bridge_num_find(bridge_dev) < 0)
                clear_bit(bridge_num, &dsa_fwd_offloading_bridges);
 }
 
@@ -429,6 +429,7 @@ static int dsa_port_setup(struct dsa_port *dp)
 {
        struct devlink_port *dlp = &dp->devlink_port;
        bool dsa_port_link_registered = false;
+       struct dsa_switch *ds = dp->ds;
        bool dsa_port_enabled = false;
        int err = 0;
 
@@ -438,6 +439,12 @@ static int dsa_port_setup(struct dsa_port *dp)
        INIT_LIST_HEAD(&dp->fdbs);
        INIT_LIST_HEAD(&dp->mdbs);
 
+       if (ds->ops->port_setup) {
+               err = ds->ops->port_setup(ds, dp->index);
+               if (err)
+                       return err;
+       }
+
        switch (dp->type) {
        case DSA_PORT_TYPE_UNUSED:
                dsa_port_disable(dp);
@@ -480,8 +487,11 @@ static int dsa_port_setup(struct dsa_port *dp)
                dsa_port_disable(dp);
        if (err && dsa_port_link_registered)
                dsa_port_link_unregister_of(dp);
-       if (err)
+       if (err) {
+               if (ds->ops->port_teardown)
+                       ds->ops->port_teardown(ds, dp->index);
                return err;
+       }
 
        dp->setup = true;
 
@@ -533,11 +543,15 @@ static int dsa_port_devlink_setup(struct dsa_port *dp)
 static void dsa_port_teardown(struct dsa_port *dp)
 {
        struct devlink_port *dlp = &dp->devlink_port;
+       struct dsa_switch *ds = dp->ds;
        struct dsa_mac_addr *a, *tmp;
 
        if (!dp->setup)
                return;
 
+       if (ds->ops->port_teardown)
+               ds->ops->port_teardown(ds, dp->index);
+
        devlink_port_type_clear(dlp);
 
        switch (dp->type) {
@@ -581,6 +595,36 @@ static void dsa_port_devlink_teardown(struct dsa_port *dp)
        dp->devlink_port_setup = false;
 }
 
+/* Destroy the current devlink port, and create a new one which has the UNUSED
+ * flavour. At this point, any call to ds->ops->port_setup has been already
+ * balanced out by a call to ds->ops->port_teardown, so we know that any
+ * devlink port regions the driver had are now unregistered. We then call its
+ * ds->ops->port_setup again, in order for the driver to re-create them on the
+ * new devlink port.
+ */
+static int dsa_port_reinit_as_unused(struct dsa_port *dp)
+{
+       struct dsa_switch *ds = dp->ds;
+       int err;
+
+       dsa_port_devlink_teardown(dp);
+       dp->type = DSA_PORT_TYPE_UNUSED;
+       err = dsa_port_devlink_setup(dp);
+       if (err)
+               return err;
+
+       if (ds->ops->port_setup) {
+               /* On error, leave the devlink port registered,
+                * dsa_switch_teardown will clean it up later.
+                */
+               err = ds->ops->port_setup(ds, dp->index);
+               if (err)
+                       return err;
+       }
+
+       return 0;
+}
+
 static int dsa_devlink_info_get(struct devlink *dl,
                                struct devlink_info_req *req,
                                struct netlink_ext_ack *extack)
@@ -767,7 +811,9 @@ static int dsa_switch_setup_tag_protocol(struct dsa_switch *ds)
                if (!dsa_is_cpu_port(ds, port))
                        continue;
 
+               rtnl_lock();
                err = ds->ops->change_tag_protocol(ds, port, tag_ops->proto);
+               rtnl_unlock();
                if (err) {
                        dev_err(ds->dev, "Unable to use tag protocol \"%s\": %pe\n",
                                tag_ops->name, ERR_PTR(err));
@@ -836,7 +882,7 @@ static int dsa_switch_setup(struct dsa_switch *ds)
        devlink_params_publish(ds->devlink);
 
        if (!ds->slave_mii_bus && ds->ops->phy_read) {
-               ds->slave_mii_bus = devm_mdiobus_alloc(ds->dev);
+               ds->slave_mii_bus = mdiobus_alloc();
                if (!ds->slave_mii_bus) {
                        err = -ENOMEM;
                        goto teardown;
@@ -846,13 +892,16 @@ static int dsa_switch_setup(struct dsa_switch *ds)
 
                err = mdiobus_register(ds->slave_mii_bus);
                if (err < 0)
-                       goto teardown;
+                       goto free_slave_mii_bus;
        }
 
        ds->setup = true;
 
        return 0;
 
+free_slave_mii_bus:
+       if (ds->slave_mii_bus && ds->ops->phy_read)
+               mdiobus_free(ds->slave_mii_bus);
 teardown:
        if (ds->ops->teardown)
                ds->ops->teardown(ds);
@@ -877,8 +926,11 @@ static void dsa_switch_teardown(struct dsa_switch *ds)
        if (!ds->setup)
                return;
 
-       if (ds->slave_mii_bus && ds->ops->phy_read)
+       if (ds->slave_mii_bus && ds->ops->phy_read) {
                mdiobus_unregister(ds->slave_mii_bus);
+               mdiobus_free(ds->slave_mii_bus);
+               ds->slave_mii_bus = NULL;
+       }
 
        dsa_switch_unregister_notifier(ds);
 
@@ -897,6 +949,33 @@ static void dsa_switch_teardown(struct dsa_switch *ds)
        ds->setup = false;
 }
 
+/* First tear down the non-shared, then the shared ports. This ensures that
+ * all work items scheduled by our switchdev handlers for user ports have
+ * completed before we destroy the refcounting kept on the shared ports.
+ */
+static void dsa_tree_teardown_ports(struct dsa_switch_tree *dst)
+{
+       struct dsa_port *dp;
+
+       list_for_each_entry(dp, &dst->ports, list)
+               if (dsa_port_is_user(dp) || dsa_port_is_unused(dp))
+                       dsa_port_teardown(dp);
+
+       dsa_flush_workqueue();
+
+       list_for_each_entry(dp, &dst->ports, list)
+               if (dsa_port_is_dsa(dp) || dsa_port_is_cpu(dp))
+                       dsa_port_teardown(dp);
+}
+
+static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
+{
+       struct dsa_port *dp;
+
+       list_for_each_entry(dp, &dst->ports, list)
+               dsa_switch_teardown(dp->ds);
+}
+
 static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
 {
        struct dsa_port *dp;
@@ -911,38 +990,22 @@ static int dsa_tree_setup_switches(struct dsa_switch_tree *dst)
        list_for_each_entry(dp, &dst->ports, list) {
                err = dsa_port_setup(dp);
                if (err) {
-                       dsa_port_devlink_teardown(dp);
-                       dp->type = DSA_PORT_TYPE_UNUSED;
-                       err = dsa_port_devlink_setup(dp);
+                       err = dsa_port_reinit_as_unused(dp);
                        if (err)
                                goto teardown;
-                       continue;
                }
        }
 
        return 0;
 
 teardown:
-       list_for_each_entry(dp, &dst->ports, list)
-               dsa_port_teardown(dp);
+       dsa_tree_teardown_ports(dst);
 
-       list_for_each_entry(dp, &dst->ports, list)
-               dsa_switch_teardown(dp->ds);
+       dsa_tree_teardown_switches(dst);
 
        return err;
 }
 
-static void dsa_tree_teardown_switches(struct dsa_switch_tree *dst)
-{
-       struct dsa_port *dp;
-
-       list_for_each_entry(dp, &dst->ports, list)
-               dsa_port_teardown(dp);
-
-       list_for_each_entry(dp, &dst->ports, list)
-               dsa_switch_teardown(dp->ds);
-}
-
 static int dsa_tree_setup_master(struct dsa_switch_tree *dst)
 {
        struct dsa_port *dp;
@@ -1034,6 +1097,7 @@ static int dsa_tree_setup(struct dsa_switch_tree *dst)
 teardown_master:
        dsa_tree_teardown_master(dst);
 teardown_switches:
+       dsa_tree_teardown_ports(dst);
        dsa_tree_teardown_switches(dst);
 teardown_cpu_ports:
        dsa_tree_teardown_cpu_ports(dst);
@@ -1052,6 +1116,8 @@ static void dsa_tree_teardown(struct dsa_switch_tree *dst)
 
        dsa_tree_teardown_master(dst);
 
+       dsa_tree_teardown_ports(dst);
+
        dsa_tree_teardown_switches(dst);
 
        dsa_tree_teardown_cpu_ports(dst);
@@ -1546,3 +1612,53 @@ void dsa_unregister_switch(struct dsa_switch *ds)
        mutex_unlock(&dsa2_mutex);
 }
 EXPORT_SYMBOL_GPL(dsa_unregister_switch);
+
+/* If the DSA master chooses to unregister its net_device on .shutdown, DSA is
+ * blocking that operation from completion, due to the dev_hold taken inside
+ * netdev_upper_dev_link. Unlink the DSA slave interfaces from being uppers of
+ * the DSA master, so that the system can reboot successfully.
+ */
+void dsa_switch_shutdown(struct dsa_switch *ds)
+{
+       struct net_device *master, *slave_dev;
+       LIST_HEAD(unregister_list);
+       struct dsa_port *dp;
+
+       mutex_lock(&dsa2_mutex);
+       rtnl_lock();
+
+       list_for_each_entry(dp, &ds->dst->ports, list) {
+               if (dp->ds != ds)
+                       continue;
+
+               if (!dsa_port_is_user(dp))
+                       continue;
+
+               master = dp->cpu_dp->master;
+               slave_dev = dp->slave;
+
+               netdev_upper_dev_unlink(master, slave_dev);
+               /* Just unlinking ourselves as uppers of the master is not
+                * sufficient. When the master net device unregisters, that will
+                * also call dev_close, which we will catch as NETDEV_GOING_DOWN
+                * and trigger a dev_close on our own devices (dsa_slave_close).
+                * In turn, that will call dev_mc_unsync on the master's net
+                * device. If the master is also a DSA switch port, this will
+                * trigger dsa_slave_set_rx_mode which will call dev_mc_sync on
+                * its own master. Lockdep will complain about the fact that
+                * all cascaded masters have the same dsa_master_addr_list_lock_key,
+                * which it normally would not do if the cascaded masters would
+                * be in a proper upper/lower relationship, which we've just
+                * destroyed.
+                * To suppress the lockdep warnings, let's actually unregister
+                * the DSA slave interfaces too, to avoid the nonsensical
+                * multicast address list synchronization on shutdown.
+                */
+               unregister_netdevice_queue(slave_dev, &unregister_list);
+       }
+       unregister_netdevice_many(&unregister_list);
+
+       rtnl_unlock();
+       mutex_unlock(&dsa2_mutex);
+}
+EXPORT_SYMBOL_GPL(dsa_switch_shutdown);
index 33ab7d7..a5c9bc7 100644 (file)
@@ -170,6 +170,7 @@ void dsa_tag_driver_put(const struct dsa_device_ops *ops);
 const struct dsa_device_ops *dsa_find_tagger_by_name(const char *buf);
 
 bool dsa_schedule_work(struct work_struct *work);
+void dsa_flush_workqueue(void);
 const char *dsa_tag_protocol_to_str(const struct dsa_device_ops *ops);
 
 static inline int dsa_tag_protocol_overhead(const struct dsa_device_ops *ops)
index 662ff53..a2bf2d8 100644 (file)
@@ -1854,13 +1854,11 @@ static int dsa_slave_phy_setup(struct net_device *slave_dev)
                 * use the switch internal MDIO bus instead
                 */
                ret = dsa_slave_phy_connect(slave_dev, dp->index, phy_flags);
-               if (ret) {
-                       netdev_err(slave_dev,
-                                  "failed to connect to port %d: %d\n",
-                                  dp->index, ret);
-                       phylink_destroy(dp->pl);
-                       return ret;
-               }
+       }
+       if (ret) {
+               netdev_err(slave_dev, "failed to connect to PHY: %pe\n",
+                          ERR_PTR(ret));
+               phylink_destroy(dp->pl);
        }
 
        return ret;
index 1c797ec..6466d05 100644 (file)
@@ -168,7 +168,7 @@ static int dsa_switch_bridge_leave(struct dsa_switch *ds,
                if (extack._msg)
                        dev_err(ds->dev, "port %d: %s\n", info->port,
                                extack._msg);
-               if (err && err != EOPNOTSUPP)
+               if (err && err != -EOPNOTSUPP)
                        return err;
        }
 
index 77d0ce8..b3da4b2 100644 (file)
@@ -45,6 +45,7 @@
  *   6    6       2        2      4    2       N
  */
 
+#include <linux/dsa/mv88e6xxx.h>
 #include <linux/etherdevice.h>
 #include <linux/list.h>
 #include <linux/slab.h>
@@ -129,12 +130,9 @@ static struct sk_buff *dsa_xmit_ll(struct sk_buff *skb, struct net_device *dev,
        u8 tag_dev, tag_port;
        enum dsa_cmd cmd;
        u8 *dsa_header;
-       u16 pvid = 0;
-       int err;
 
        if (skb->offload_fwd_mark) {
                struct dsa_switch_tree *dst = dp->ds->dst;
-               struct net_device *br = dp->bridge_dev;
 
                cmd = DSA_CMD_FORWARD;
 
@@ -144,19 +142,6 @@ static struct sk_buff *dsa_xmit_ll(struct sk_buff *skb, struct net_device *dev,
                 */
                tag_dev = dst->last_switch + 1 + dp->bridge_num;
                tag_port = 0;
-
-               /* If we are offloading forwarding for a VLAN-unaware bridge,
-                * inject packets to hardware using the bridge's pvid, since
-                * that's where the packets ingressed from.
-                */
-               if (!br_vlan_enabled(br)) {
-                       /* Safe because __dev_queue_xmit() runs under
-                        * rcu_read_lock_bh()
-                        */
-                       err = br_vlan_get_pvid_rcu(br, &pvid);
-                       if (err)
-                               return NULL;
-               }
        } else {
                cmd = DSA_CMD_FROM_CPU;
                tag_dev = dp->ds->index;
@@ -180,16 +165,21 @@ static struct sk_buff *dsa_xmit_ll(struct sk_buff *skb, struct net_device *dev,
                        dsa_header[2] &= ~0x10;
                }
        } else {
+               struct net_device *br = dp->bridge_dev;
+               u16 vid;
+
+               vid = br ? MV88E6XXX_VID_BRIDGED : MV88E6XXX_VID_STANDALONE;
+
                skb_push(skb, DSA_HLEN + extra);
                dsa_alloc_etype_header(skb, DSA_HLEN + extra);
 
-               /* Construct untagged DSA tag. */
+               /* Construct DSA header from untagged frame. */
                dsa_header = dsa_etype_header_pos_tx(skb) + extra;
 
                dsa_header[0] = (cmd << 6) | tag_dev;
                dsa_header[1] = tag_port << 3;
-               dsa_header[2] = pvid >> 8;
-               dsa_header[3] = pvid & 0xff;
+               dsa_header[2] = vid >> 8;
+               dsa_header[3] = vid & 0xff;
        }
 
        return skb;
@@ -210,7 +200,7 @@ static struct sk_buff *dsa_rcv_ll(struct sk_buff *skb, struct net_device *dev,
        cmd = dsa_header[0] >> 6;
        switch (cmd) {
        case DSA_CMD_FORWARD:
-               trunk = !!(dsa_header[1] & 7);
+               trunk = !!(dsa_header[1] & 4);
                break;
 
        case DSA_CMD_TO_CPU:
index d37ab98..605b51c 100644 (file)
@@ -1,8 +1,7 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2019 NXP Semiconductors
+/* Copyright 2019 NXP
  */
 #include <linux/dsa/ocelot.h>
-#include <soc/mscc/ocelot.h>
 #include "dsa_priv.h"
 
 static void ocelot_xmit_common(struct sk_buff *skb, struct net_device *netdev,
index 3038a25..3412051 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/* Copyright 2020-2021 NXP Semiconductors
+/* Copyright 2020-2021 NXP
  *
  * An implementation of the software-defined tag_8021q.c tagger format, which
  * also preserves full functionality under a vlan_filtering bridge. It does
@@ -9,10 +9,32 @@
  *   that on egress
  */
 #include <linux/dsa/8021q.h>
-#include <soc/mscc/ocelot.h>
-#include <soc/mscc/ocelot_ptp.h>
+#include <linux/dsa/ocelot.h>
 #include "dsa_priv.h"
 
+static struct sk_buff *ocelot_defer_xmit(struct dsa_port *dp,
+                                        struct sk_buff *skb)
+{
+       struct felix_deferred_xmit_work *xmit_work;
+       struct felix_port *felix_port = dp->priv;
+
+       xmit_work = kzalloc(sizeof(*xmit_work), GFP_ATOMIC);
+       if (!xmit_work)
+               return NULL;
+
+       /* Calls felix_port_deferred_xmit in felix.c */
+       kthread_init_work(&xmit_work->work, felix_port->xmit_work_fn);
+       /* Increase refcount so the kfree_skb in dsa_slave_xmit
+        * won't really free the packet.
+        */
+       xmit_work->dp = dp;
+       xmit_work->skb = skb_get(skb);
+
+       kthread_queue_work(felix_port->xmit_worker, &xmit_work->work);
+
+       return NULL;
+}
+
 static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
                                   struct net_device *netdev)
 {
@@ -20,18 +42,10 @@ static struct sk_buff *ocelot_xmit(struct sk_buff *skb,
        u16 tx_vid = dsa_8021q_tx_vid(dp->ds, dp->index);
        u16 queue_mapping = skb_get_queue_mapping(skb);
        u8 pcp = netdev_txq_to_tc(netdev, queue_mapping);
-       struct ocelot *ocelot = dp->ds->priv;
-       int port = dp->index;
-       u32 rew_op = 0;
+       struct ethhdr *hdr = eth_hdr(skb);
 
-       rew_op = ocelot_ptp_rew_op(skb);
-       if (rew_op) {
-               if (!ocelot_can_inject(ocelot, 0))
-                       return NULL;
-
-               ocelot_port_inject_frame(ocelot, port, 0, rew_op, skb);
-               return NULL;
-       }
+       if (ocelot_ptp_rew_op(skb) || is_link_local_ether_addr(hdr->h_dest))
+               return ocelot_defer_xmit(dp, skb);
 
        return dsa_8021q_xmit(skb, netdev, ETH_P_8021Q,
                              ((pcp << VLAN_PRIO_SHIFT) | tx_vid));
index c054f48..2edede9 100644 (file)
@@ -4,6 +4,7 @@
 #include <linux/if_vlan.h>
 #include <linux/dsa/sja1105.h>
 #include <linux/dsa/8021q.h>
+#include <linux/skbuff.h>
 #include <linux/packing.h>
 #include "dsa_priv.h"
 
 #define SJA1110_TX_TRAILER_LEN                 4
 #define SJA1110_MAX_PADDING_LEN                        15
 
+enum sja1110_meta_tstamp {
+       SJA1110_META_TSTAMP_TX = 0,
+       SJA1110_META_TSTAMP_RX = 1,
+};
+
 /* Similar to is_link_local_ether_addr(hdr->h_dest) but also covers PTP */
 static inline bool sja1105_is_link_local(const struct sk_buff *skb)
 {
@@ -520,6 +526,43 @@ static struct sk_buff *sja1105_rcv(struct sk_buff *skb,
                                              is_meta);
 }
 
+static void sja1110_process_meta_tstamp(struct dsa_switch *ds, int port,
+                                       u8 ts_id, enum sja1110_meta_tstamp dir,
+                                       u64 tstamp)
+{
+       struct sk_buff *skb, *skb_tmp, *skb_match = NULL;
+       struct dsa_port *dp = dsa_to_port(ds, port);
+       struct skb_shared_hwtstamps shwt = {0};
+       struct sja1105_port *sp = dp->priv;
+
+       if (!dsa_port_is_sja1105(dp))
+               return;
+
+       /* We don't care about RX timestamps on the CPU port */
+       if (dir == SJA1110_META_TSTAMP_RX)
+               return;
+
+       spin_lock(&sp->data->skb_txtstamp_queue.lock);
+
+       skb_queue_walk_safe(&sp->data->skb_txtstamp_queue, skb, skb_tmp) {
+               if (SJA1105_SKB_CB(skb)->ts_id != ts_id)
+                       continue;
+
+               __skb_unlink(skb, &sp->data->skb_txtstamp_queue);
+               skb_match = skb;
+
+               break;
+       }
+
+       spin_unlock(&sp->data->skb_txtstamp_queue.lock);
+
+       if (WARN_ON(!skb_match))
+               return;
+
+       shwt.hwtstamp = ns_to_ktime(sja1105_ticks_to_ns(tstamp));
+       skb_complete_tx_timestamp(skb_match, &shwt);
+}
+
 static struct sk_buff *sja1110_rcv_meta(struct sk_buff *skb, u16 rx_header)
 {
        u8 *buf = dsa_etype_header_pos_rx(skb) + SJA1110_HEADER_LEN;
index b42c429..3364cb9 100644 (file)
@@ -1661,7 +1661,7 @@ EXPORT_SYMBOL_GPL(fib_nexthop_info);
 
 #if IS_ENABLED(CONFIG_IP_ROUTE_MULTIPATH) || IS_ENABLED(CONFIG_IPV6)
 int fib_add_nexthop(struct sk_buff *skb, const struct fib_nh_common *nhc,
-                   int nh_weight, u8 rt_family)
+                   int nh_weight, u8 rt_family, u32 nh_tclassid)
 {
        const struct net_device *dev = nhc->nhc_dev;
        struct rtnexthop *rtnh;
@@ -1679,6 +1679,9 @@ int fib_add_nexthop(struct sk_buff *skb, const struct fib_nh_common *nhc,
 
        rtnh->rtnh_flags = flags;
 
+       if (nh_tclassid && nla_put_u32(skb, RTA_FLOW, nh_tclassid))
+               goto nla_put_failure;
+
        /* length of rtnetlink header + attributes */
        rtnh->rtnh_len = nlmsg_get_pos(skb) - (void *)rtnh;
 
@@ -1706,14 +1709,13 @@ static int fib_add_multipath(struct sk_buff *skb, struct fib_info *fi)
        }
 
        for_nexthops(fi) {
-               if (fib_add_nexthop(skb, &nh->nh_common, nh->fib_nh_weight,
-                                   AF_INET) < 0)
-                       goto nla_put_failure;
+               u32 nh_tclassid = 0;
 #ifdef CONFIG_IP_ROUTE_CLASSID
-               if (nh->nh_tclassid &&
-                   nla_put_u32(skb, RTA_FLOW, nh->nh_tclassid))
-                       goto nla_put_failure;
+               nh_tclassid = nh->nh_tclassid;
 #endif
+               if (fib_add_nexthop(skb, &nh->nh_common, nh->fib_nh_weight,
+                                   AF_INET, nh_tclassid) < 0)
+                       goto nla_put_failure;
        } endfor_nexthops(fi);
 
 mp_end:
index 8b30cad..b7e277d 100644 (file)
@@ -1054,14 +1054,19 @@ bool icmp_build_probe(struct sk_buff *skb, struct icmphdr *icmphdr)
        iio = skb_header_pointer(skb, sizeof(_ext_hdr), sizeof(iio->extobj_hdr), &_iio);
        if (!ext_hdr || !iio)
                goto send_mal_query;
-       if (ntohs(iio->extobj_hdr.length) <= sizeof(iio->extobj_hdr))
+       if (ntohs(iio->extobj_hdr.length) <= sizeof(iio->extobj_hdr) ||
+           ntohs(iio->extobj_hdr.length) > sizeof(_iio))
                goto send_mal_query;
        ident_len = ntohs(iio->extobj_hdr.length) - sizeof(iio->extobj_hdr);
+       iio = skb_header_pointer(skb, sizeof(_ext_hdr),
+                                sizeof(iio->extobj_hdr) + ident_len, &_iio);
+       if (!iio)
+               goto send_mal_query;
+
        status = 0;
        dev = NULL;
        switch (iio->extobj_hdr.class_type) {
        case ICMP_EXT_ECHO_CTYPE_NAME:
-               iio = skb_header_pointer(skb, sizeof(_ext_hdr), sizeof(_iio), &_iio);
                if (ident_len >= IFNAMSIZ)
                        goto send_mal_query;
                memset(buff, 0, sizeof(buff));
@@ -1069,30 +1074,24 @@ bool icmp_build_probe(struct sk_buff *skb, struct icmphdr *icmphdr)
                dev = dev_get_by_name(net, buff);
                break;
        case ICMP_EXT_ECHO_CTYPE_INDEX:
-               iio = skb_header_pointer(skb, sizeof(_ext_hdr), sizeof(iio->extobj_hdr) +
-                                        sizeof(iio->ident.ifindex), &_iio);
                if (ident_len != sizeof(iio->ident.ifindex))
                        goto send_mal_query;
                dev = dev_get_by_index(net, ntohl(iio->ident.ifindex));
                break;
        case ICMP_EXT_ECHO_CTYPE_ADDR:
-               if (ident_len != sizeof(iio->ident.addr.ctype3_hdr) +
+               if (ident_len < sizeof(iio->ident.addr.ctype3_hdr) ||
+                   ident_len != sizeof(iio->ident.addr.ctype3_hdr) +
                                 iio->ident.addr.ctype3_hdr.addrlen)
                        goto send_mal_query;
                switch (ntohs(iio->ident.addr.ctype3_hdr.afi)) {
                case ICMP_AFI_IP:
-                       iio = skb_header_pointer(skb, sizeof(_ext_hdr), sizeof(iio->extobj_hdr) +
-                                                sizeof(struct in_addr), &_iio);
-                       if (ident_len != sizeof(iio->ident.addr.ctype3_hdr) +
-                                        sizeof(struct in_addr))
+                       if (iio->ident.addr.ctype3_hdr.addrlen != sizeof(struct in_addr))
                                goto send_mal_query;
                        dev = ip_dev_find(net, iio->ident.addr.ip_addr.ipv4_addr);
                        break;
 #if IS_ENABLED(CONFIG_IPV6)
                case ICMP_AFI_IP6:
-                       iio = skb_header_pointer(skb, sizeof(_ext_hdr), sizeof(_iio), &_iio);
-                       if (ident_len != sizeof(iio->ident.addr.ctype3_hdr) +
-                                        sizeof(struct in6_addr))
+                       if (iio->ident.addr.ctype3_hdr.addrlen != sizeof(struct in6_addr))
                                goto send_mal_query;
                        dev = ipv6_stub->ipv6_dev_find(net, &iio->ident.addr.ip_addr.ipv6_addr, dev);
                        dev_hold(dev);
index 80aeaf9..bfb522e 100644 (file)
@@ -242,8 +242,10 @@ static inline int compute_score(struct sock *sk, struct net *net,
 
                if (!inet_sk_bound_dev_eq(net, sk->sk_bound_dev_if, dif, sdif))
                        return -1;
+               score =  sk->sk_bound_dev_if ? 2 : 1;
 
-               score = sk->sk_family == PF_INET ? 2 : 1;
+               if (sk->sk_family == PF_INET)
+                       score++;
                if (READ_ONCE(sk->sk_incoming_cpu) == raw_smp_processor_id())
                        score++;
        }
index b88e0f3..8265c67 100644 (file)
@@ -42,7 +42,7 @@ iptable_raw_hook(void *priv, struct sk_buff *skb,
 
 static struct nf_hook_ops *rawtable_ops __read_mostly;
 
-static int __net_init iptable_raw_table_init(struct net *net)
+static int iptable_raw_table_init(struct net *net)
 {
        struct ipt_replace *repl;
        const struct xt_table *table = &packet_raw;
index 613432a..e61ea42 100644 (file)
 #endif
 #include <net/netfilter/nf_conntrack_zones.h>
 
-static unsigned int defrag4_pernet_id __read_mostly;
 static DEFINE_MUTEX(defrag4_mutex);
 
-struct defrag4_pernet {
-       unsigned int users;
-};
-
 static int nf_ct_ipv4_gather_frags(struct net *net, struct sk_buff *skb,
                                   u_int32_t user)
 {
@@ -111,19 +106,15 @@ static const struct nf_hook_ops ipv4_defrag_ops[] = {
 
 static void __net_exit defrag4_net_exit(struct net *net)
 {
-       struct defrag4_pernet *nf_defrag = net_generic(net, defrag4_pernet_id);
-
-       if (nf_defrag->users) {
+       if (net->nf.defrag_ipv4_users) {
                nf_unregister_net_hooks(net, ipv4_defrag_ops,
                                        ARRAY_SIZE(ipv4_defrag_ops));
-               nf_defrag->users = 0;
+               net->nf.defrag_ipv4_users = 0;
        }
 }
 
 static struct pernet_operations defrag4_net_ops = {
        .exit = defrag4_net_exit,
-       .id   = &defrag4_pernet_id,
-       .size = sizeof(struct defrag4_pernet),
 };
 
 static int __init nf_defrag_init(void)
@@ -138,24 +129,23 @@ static void __exit nf_defrag_fini(void)
 
 int nf_defrag_ipv4_enable(struct net *net)
 {
-       struct defrag4_pernet *nf_defrag = net_generic(net, defrag4_pernet_id);
        int err = 0;
 
        mutex_lock(&defrag4_mutex);
-       if (nf_defrag->users == UINT_MAX) {
+       if (net->nf.defrag_ipv4_users == UINT_MAX) {
                err = -EOVERFLOW;
                goto out_unlock;
        }
 
-       if (nf_defrag->users) {
-               nf_defrag->users++;
+       if (net->nf.defrag_ipv4_users) {
+               net->nf.defrag_ipv4_users++;
                goto out_unlock;
        }
 
        err = nf_register_net_hooks(net, ipv4_defrag_ops,
                                    ARRAY_SIZE(ipv4_defrag_ops));
        if (err == 0)
-               nf_defrag->users = 1;
+               net->nf.defrag_ipv4_users = 1;
 
  out_unlock:
        mutex_unlock(&defrag4_mutex);
@@ -165,12 +155,10 @@ EXPORT_SYMBOL_GPL(nf_defrag_ipv4_enable);
 
 void nf_defrag_ipv4_disable(struct net *net)
 {
-       struct defrag4_pernet *nf_defrag = net_generic(net, defrag4_pernet_id);
-
        mutex_lock(&defrag4_mutex);
-       if (nf_defrag->users) {
-               nf_defrag->users--;
-               if (nf_defrag->users == 0)
+       if (net->nf.defrag_ipv4_users) {
+               net->nf.defrag_ipv4_users--;
+               if (net->nf.defrag_ipv4_users == 0)
                        nf_unregister_net_hooks(net, ipv4_defrag_ops,
                                                ARRAY_SIZE(ipv4_defrag_ops));
        }
index 75ca4b6..9e81007 100644 (file)
@@ -1982,6 +1982,8 @@ static int replace_nexthop_grp(struct net *net, struct nexthop *old,
        rcu_assign_pointer(old->nh_grp, newg);
 
        if (newg->resilient) {
+               /* Make sure concurrent readers are not using 'oldg' anymore. */
+               synchronize_net();
                rcu_assign_pointer(oldg->res_table, tmp_table);
                rcu_assign_pointer(oldg->spare->res_table, tmp_table);
        }
@@ -3565,6 +3567,7 @@ static struct notifier_block nh_netdev_notifier = {
 };
 
 static int nexthops_dump(struct net *net, struct notifier_block *nb,
+                        enum nexthop_event_type event_type,
                         struct netlink_ext_ack *extack)
 {
        struct rb_root *root = &net->nexthop.rb_root;
@@ -3575,8 +3578,7 @@ static int nexthops_dump(struct net *net, struct notifier_block *nb,
                struct nexthop *nh;
 
                nh = rb_entry(node, struct nexthop, rb_node);
-               err = call_nexthop_notifier(nb, net, NEXTHOP_EVENT_REPLACE, nh,
-                                           extack);
+               err = call_nexthop_notifier(nb, net, event_type, nh, extack);
                if (err)
                        break;
        }
@@ -3590,7 +3592,7 @@ int register_nexthop_notifier(struct net *net, struct notifier_block *nb,
        int err;
 
        rtnl_lock();
-       err = nexthops_dump(net, nb, extack);
+       err = nexthops_dump(net, nb, NEXTHOP_EVENT_REPLACE, extack);
        if (err)
                goto unlock;
        err = blocking_notifier_chain_register(&net->nexthop.notifier_chain,
@@ -3603,8 +3605,17 @@ EXPORT_SYMBOL(register_nexthop_notifier);
 
 int unregister_nexthop_notifier(struct net *net, struct notifier_block *nb)
 {
-       return blocking_notifier_chain_unregister(&net->nexthop.notifier_chain,
-                                                 nb);
+       int err;
+
+       rtnl_lock();
+       err = blocking_notifier_chain_unregister(&net->nexthop.notifier_chain,
+                                                nb);
+       if (err)
+               goto unlock;
+       nexthops_dump(net, nb, NEXTHOP_EVENT_DEL, NULL);
+unlock:
+       rtnl_unlock();
+       return err;
 }
 EXPORT_SYMBOL(unregister_nexthop_notifier);
 
index 3f7bd7a..141e85e 100644 (file)
@@ -1346,7 +1346,7 @@ static u8 tcp_sacktag_one(struct sock *sk,
        if (dup_sack && (sacked & TCPCB_RETRANS)) {
                if (tp->undo_marker && tp->undo_retrans > 0 &&
                    after(end_seq, tp->undo_marker))
-                       tp->undo_retrans--;
+                       tp->undo_retrans = max_t(int, 0, tp->undo_retrans - pcount);
                if ((sacked & TCPCB_SACKED_ACKED) &&
                    before(start_seq, state->reord))
                                state->reord = start_seq;
index 8851c94..8536b2a 100644 (file)
@@ -390,7 +390,8 @@ static int compute_score(struct sock *sk, struct net *net,
                                        dif, sdif);
        if (!dev_match)
                return -1;
-       score += 4;
+       if (sk->sk_bound_dev_if)
+               score += 4;
 
        if (READ_ONCE(sk->sk_incoming_cpu) == raw_smp_processor_id())
                score++;
@@ -1053,7 +1054,7 @@ int udp_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
        __be16 dport;
        u8  tos;
        int err, is_udplite = IS_UDPLITE(sk);
-       int corkreq = up->corkflag || msg->msg_flags&MSG_MORE;
+       int corkreq = READ_ONCE(up->corkflag) || msg->msg_flags&MSG_MORE;
        int (*getfrag)(void *, char *, int, int, int, struct sk_buff *);
        struct sk_buff *skb;
        struct ip_options_data opt_copy;
@@ -1361,7 +1362,7 @@ int udp_sendpage(struct sock *sk, struct page *page, int offset,
        }
 
        up->len += size;
-       if (!(up->corkflag || (flags&MSG_MORE)))
+       if (!(READ_ONCE(up->corkflag) || (flags&MSG_MORE)))
                ret = udp_push_pending_frames(sk);
        if (!ret)
                ret = size;
@@ -2662,9 +2663,9 @@ int udp_lib_setsockopt(struct sock *sk, int level, int optname,
        switch (optname) {
        case UDP_CORK:
                if (val != 0) {
-                       up->corkflag = 1;
+                       WRITE_ONCE(up->corkflag, 1);
                } else {
-                       up->corkflag = 0;
+                       WRITE_ONCE(up->corkflag, 0);
                        lock_sock(sk);
                        push_pending_frames(sk);
                        release_sock(sk);
@@ -2787,7 +2788,7 @@ int udp_lib_getsockopt(struct sock *sk, int level, int optname,
 
        switch (optname) {
        case UDP_CORK:
-               val = up->corkflag;
+               val = READ_ONCE(up->corkflag);
                break;
 
        case UDP_ENCAP:
index 0d122ed..b910035 100644 (file)
@@ -935,7 +935,7 @@ static int __init udp_tunnel_nic_init_module(void)
 {
        int err;
 
-       udp_tunnel_nic_workqueue = alloc_workqueue("udp_tunnel_nic", 0, 0);
+       udp_tunnel_nic_workqueue = alloc_ordered_workqueue("udp_tunnel_nic", 0);
        if (!udp_tunnel_nic_workqueue)
                return -ENOMEM;
 
index 55c290d..67c9114 100644 (file)
@@ -106,7 +106,7 @@ static inline int compute_score(struct sock *sk, struct net *net,
                if (!inet_sk_bound_dev_eq(net, sk->sk_bound_dev_if, dif, sdif))
                        return -1;
 
-               score = 1;
+               score =  sk->sk_bound_dev_if ? 2 : 1;
                if (READ_ONCE(sk->sk_incoming_cpu) == raw_smp_processor_id())
                        score++;
        }
index 5e89610..d128172 100644 (file)
@@ -770,6 +770,66 @@ static void __ioam6_fill_trace_data(struct sk_buff *skb,
                data += sizeof(__be32);
        }
 
+       /* bit12 undefined: filled with empty value */
+       if (trace->type.bit12) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit13 undefined: filled with empty value */
+       if (trace->type.bit13) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit14 undefined: filled with empty value */
+       if (trace->type.bit14) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit15 undefined: filled with empty value */
+       if (trace->type.bit15) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit16 undefined: filled with empty value */
+       if (trace->type.bit16) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit17 undefined: filled with empty value */
+       if (trace->type.bit17) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit18 undefined: filled with empty value */
+       if (trace->type.bit18) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit19 undefined: filled with empty value */
+       if (trace->type.bit19) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit20 undefined: filled with empty value */
+       if (trace->type.bit20) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
+       /* bit21 undefined: filled with empty value */
+       if (trace->type.bit21) {
+               *(__be32 *)data = cpu_to_be32(IOAM6_U32_UNAVAILABLE);
+               data += sizeof(__be32);
+       }
+
        /* opaque state snapshot */
        if (trace->type.bit22) {
                if (!sc) {
@@ -791,16 +851,10 @@ void ioam6_fill_trace_data(struct sk_buff *skb,
        struct ioam6_schema *sc;
        u8 sclen = 0;
 
-       /* Skip if Overflow flag is set OR
-        * if an unknown type (bit 12-21) is set
+       /* Skip if Overflow flag is set
         */
-       if (trace->overflow ||
-           trace->type.bit12 | trace->type.bit13 | trace->type.bit14 |
-           trace->type.bit15 | trace->type.bit16 | trace->type.bit17 |
-           trace->type.bit18 | trace->type.bit19 | trace->type.bit20 |
-           trace->type.bit21) {
+       if (trace->overflow)
                return;
-       }
 
        /* NodeLen does not include Opaque State Snapshot length. We need to
         * take it into account if the corresponding bit is set (bit 22) and
index f9ee045..9b7b726 100644 (file)
@@ -75,7 +75,11 @@ static bool ioam6_validate_trace_hdr(struct ioam6_trace_hdr *trace)
        u32 fields;
 
        if (!trace->type_be32 || !trace->remlen ||
-           trace->remlen > IOAM6_TRACE_DATA_SIZE_MAX / 4)
+           trace->remlen > IOAM6_TRACE_DATA_SIZE_MAX / 4 ||
+           trace->type.bit12 | trace->type.bit13 | trace->type.bit14 |
+           trace->type.bit15 | trace->type.bit16 | trace->type.bit17 |
+           trace->type.bit18 | trace->type.bit19 | trace->type.bit20 |
+           trace->type.bit21)
                return false;
 
        trace->nodelen = 0;
index 1bec5b2..0371d2c 100644 (file)
@@ -1378,7 +1378,6 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
        int err = -ENOMEM;
        int allow_create = 1;
        int replace_required = 0;
-       int sernum = fib6_new_sernum(info->nl_net);
 
        if (info->nlh) {
                if (!(info->nlh->nlmsg_flags & NLM_F_CREATE))
@@ -1478,7 +1477,7 @@ int fib6_add(struct fib6_node *root, struct fib6_info *rt,
        if (!err) {
                if (rt->nh)
                        list_add(&rt->nh_list, &rt->nh->f6i_list);
-               __fib6_update_sernum_upto_root(rt, sernum);
+               __fib6_update_sernum_upto_root(rt, fib6_new_sernum(info->nl_net));
                fib6_start_gc(info->nl_net, rt);
        }
 
index de2cf39..a579ea1 100644 (file)
@@ -273,6 +273,7 @@ ip6t_do_table(struct sk_buff *skb,
         * things we don't know, ie. tcp syn flag or ports).  If the
         * rule is also a fragment-specific rule, non-fragments won't
         * match it. */
+       acpar.fragoff = 0;
        acpar.hotdrop = false;
        acpar.state   = state;
 
index a010841..5c47be2 100644 (file)
@@ -33,7 +33,7 @@
 
 static const char nf_frags_cache_name[] = "nf-frags";
 
-unsigned int nf_frag_pernet_id __read_mostly;
+static unsigned int nf_frag_pernet_id __read_mostly;
 static struct inet_frags nf_frags;
 
 static struct nft_ct_frag6_pernet *nf_frag_pernet(struct net *net)
index e8a59d8..cb4eb1d 100644 (file)
@@ -25,8 +25,6 @@
 #include <net/netfilter/nf_conntrack_zones.h>
 #include <net/netfilter/ipv6/nf_defrag_ipv6.h>
 
-extern unsigned int nf_frag_pernet_id;
-
 static DEFINE_MUTEX(defrag6_mutex);
 
 static enum ip6_defrag_users nf_ct6_defrag_user(unsigned int hooknum,
@@ -91,12 +89,10 @@ static const struct nf_hook_ops ipv6_defrag_ops[] = {
 
 static void __net_exit defrag6_net_exit(struct net *net)
 {
-       struct nft_ct_frag6_pernet *nf_frag = net_generic(net, nf_frag_pernet_id);
-
-       if (nf_frag->users) {
+       if (net->nf.defrag_ipv6_users) {
                nf_unregister_net_hooks(net, ipv6_defrag_ops,
                                        ARRAY_SIZE(ipv6_defrag_ops));
-               nf_frag->users = 0;
+               net->nf.defrag_ipv6_users = 0;
        }
 }
 
@@ -134,24 +130,23 @@ static void __exit nf_defrag_fini(void)
 
 int nf_defrag_ipv6_enable(struct net *net)
 {
-       struct nft_ct_frag6_pernet *nf_frag = net_generic(net, nf_frag_pernet_id);
        int err = 0;
 
        mutex_lock(&defrag6_mutex);
-       if (nf_frag->users == UINT_MAX) {
+       if (net->nf.defrag_ipv6_users == UINT_MAX) {
                err = -EOVERFLOW;
                goto out_unlock;
        }
 
-       if (nf_frag->users) {
-               nf_frag->users++;
+       if (net->nf.defrag_ipv6_users) {
+               net->nf.defrag_ipv6_users++;
                goto out_unlock;
        }
 
        err = nf_register_net_hooks(net, ipv6_defrag_ops,
                                    ARRAY_SIZE(ipv6_defrag_ops));
        if (err == 0)
-               nf_frag->users = 1;
+               net->nf.defrag_ipv6_users = 1;
 
  out_unlock:
        mutex_unlock(&defrag6_mutex);
@@ -161,12 +156,10 @@ EXPORT_SYMBOL_GPL(nf_defrag_ipv6_enable);
 
 void nf_defrag_ipv6_disable(struct net *net)
 {
-       struct nft_ct_frag6_pernet *nf_frag = net_generic(net, nf_frag_pernet_id);
-
        mutex_lock(&defrag6_mutex);
-       if (nf_frag->users) {
-               nf_frag->users--;
-               if (nf_frag->users == 0)
+       if (net->nf.defrag_ipv6_users) {
+               net->nf.defrag_ipv6_users--;
+               if (net->nf.defrag_ipv6_users == 0)
                        nf_unregister_net_hooks(net, ipv6_defrag_ops,
                                                ARRAY_SIZE(ipv6_defrag_ops));
        }
index dbc2240..9b9ef09 100644 (file)
@@ -5681,14 +5681,15 @@ static int rt6_fill_node(struct net *net, struct sk_buff *skb,
                        goto nla_put_failure;
 
                if (fib_add_nexthop(skb, &rt->fib6_nh->nh_common,
-                                   rt->fib6_nh->fib_nh_weight, AF_INET6) < 0)
+                                   rt->fib6_nh->fib_nh_weight, AF_INET6,
+                                   0) < 0)
                        goto nla_put_failure;
 
                list_for_each_entry_safe(sibling, next_sibling,
                                         &rt->fib6_siblings, fib6_siblings) {
                        if (fib_add_nexthop(skb, &sibling->fib6_nh->nh_common,
                                            sibling->fib6_nh->fib_nh_weight,
-                                           AF_INET6) < 0)
+                                           AF_INET6, 0) < 0)
                                goto nla_put_failure;
                }
 
index ea53847..8d78523 100644 (file)
@@ -133,7 +133,8 @@ static int compute_score(struct sock *sk, struct net *net,
        dev_match = udp_sk_bound_dev_eq(net, sk->sk_bound_dev_if, dif, sdif);
        if (!dev_match)
                return -1;
-       score++;
+       if (sk->sk_bound_dev_if)
+               score++;
 
        if (READ_ONCE(sk->sk_incoming_cpu) == raw_smp_processor_id())
                score++;
@@ -1303,7 +1304,7 @@ int udpv6_sendmsg(struct sock *sk, struct msghdr *msg, size_t len)
        int addr_len = msg->msg_namelen;
        bool connected = false;
        int ulen = len;
-       int corkreq = up->corkflag || msg->msg_flags&MSG_MORE;
+       int corkreq = READ_ONCE(up->corkflag) || msg->msg_flags&MSG_MORE;
        int err;
        int is_udplite = IS_UDPLITE(sk);
        int (*getfrag)(void *, char *, int, int, int, struct sk_buff *);
index 53486b1..93271a2 100644 (file)
@@ -869,8 +869,10 @@ static int l2tp_udp_recv_core(struct l2tp_tunnel *tunnel, struct sk_buff *skb)
        }
 
        if (tunnel->version == L2TP_HDR_VER_3 &&
-           l2tp_v3_ensure_opt_in_linear(session, skb, &ptr, &optr))
+           l2tp_v3_ensure_opt_in_linear(session, skb, &ptr, &optr)) {
+               l2tp_session_dec_refcount(session);
                goto invalid;
+       }
 
        l2tp_recv_common(session, skb, ptr, optr, hdrflags, length);
        l2tp_session_dec_refcount(session);
index efbefcb..7cab1cf 100644 (file)
@@ -60,7 +60,10 @@ static struct mesh_table *mesh_table_alloc(void)
        atomic_set(&newtbl->entries,  0);
        spin_lock_init(&newtbl->gates_lock);
        spin_lock_init(&newtbl->walk_lock);
-       rhashtable_init(&newtbl->rhead, &mesh_rht_params);
+       if (rhashtable_init(&newtbl->rhead, &mesh_rht_params)) {
+               kfree(newtbl);
+               return NULL;
+       }
 
        return newtbl;
 }
index 204830a..3fbd0b9 100644 (file)
@@ -2,6 +2,7 @@
 /*
  * Copyright 2012-2013, Marco Porsch <marco.porsch@s2005.tu-chemnitz.de>
  * Copyright 2012-2013, cozybit Inc.
+ * Copyright (C) 2021 Intel Corporation
  */
 
 #include "mesh.h"
@@ -588,7 +589,7 @@ void ieee80211_mps_frame_release(struct sta_info *sta,
 
        /* only transmit to PS STA with announced, non-zero awake window */
        if (test_sta_flag(sta, WLAN_STA_PS_STA) &&
-           (!elems->awake_window || !le16_to_cpu(*elems->awake_window)))
+           (!elems->awake_window || !get_unaligned_le16(elems->awake_window)))
                return;
 
        if (!test_sta_flag(sta, WLAN_STA_MPSP_OWNER))
index e5935e3..8c64161 100644 (file)
@@ -392,10 +392,6 @@ static bool rate_control_send_low(struct ieee80211_sta *pubsta,
        int mcast_rate;
        bool use_basicrate = false;
 
-       if (ieee80211_is_tx_data(txrc->skb) &&
-           info->flags & IEEE80211_TX_CTL_NO_ACK)
-               return false;
-
        if (!pubsta || rc_no_data_or_no_ack_use_min(txrc)) {
                __rate_control_send_low(txrc->hw, sband, pubsta, info,
                                        txrc->rate_idx_mask);
index 99ed68f..c4071b0 100644 (file)
@@ -4131,7 +4131,8 @@ static bool ieee80211_accept_frame(struct ieee80211_rx_data *rx)
                if (!bssid)
                        return false;
                if (ether_addr_equal(sdata->vif.addr, hdr->addr2) ||
-                   ether_addr_equal(sdata->u.ibss.bssid, hdr->addr2))
+                   ether_addr_equal(sdata->u.ibss.bssid, hdr->addr2) ||
+                   !is_valid_ether_addr(hdr->addr2))
                        return false;
                if (ieee80211_is_beacon(hdr->frame_control))
                        return true;
index 2d1193e..8921088 100644 (file)
@@ -2209,7 +2209,11 @@ bool ieee80211_parse_tx_radiotap(struct sk_buff *skb,
                        }
 
                        vht_mcs = iterator.this_arg[4] >> 4;
+                       if (vht_mcs > 11)
+                               vht_mcs = 0;
                        vht_nss = iterator.this_arg[4] & 0xF;
+                       if (!vht_nss || vht_nss > 8)
+                               vht_nss = 1;
                        break;
 
                /*
@@ -3380,6 +3384,14 @@ static bool ieee80211_amsdu_aggregate(struct ieee80211_sub_if_data *sdata,
        if (!ieee80211_amsdu_prepare_head(sdata, fast_tx, head))
                goto out;
 
+       /* If n == 2, the "while (*frag_tail)" loop above didn't execute
+        * and  frag_tail should be &skb_shinfo(head)->frag_list.
+        * However, ieee80211_amsdu_prepare_head() can reallocate it.
+        * Reload frag_tail to have it pointing to the correct place.
+        */
+       if (n == 2)
+               frag_tail = &skb_shinfo(head)->frag_list;
+
        /*
         * Pad out the previous subframe to a multiple of 4 by adding the
         * padding to the next one, that's being added. Note that head->len
index bca47fa..4eed23e 100644 (file)
@@ -520,6 +520,9 @@ ieee80211_crypto_ccmp_decrypt(struct ieee80211_rx_data *rx,
                        return RX_DROP_UNUSABLE;
        }
 
+       /* reload hdr - skb might have been reallocated */
+       hdr = (void *)rx->skb->data;
+
        data_len = skb->len - hdrlen - IEEE80211_CCMP_HDR_LEN - mic_len;
        if (!rx->sta || data_len < 0)
                return RX_DROP_UNUSABLE;
@@ -749,6 +752,9 @@ ieee80211_crypto_gcmp_decrypt(struct ieee80211_rx_data *rx)
                        return RX_DROP_UNUSABLE;
        }
 
+       /* reload hdr - skb might have been reallocated */
+       hdr = (void *)rx->skb->data;
+
        data_len = skb->len - hdrlen - IEEE80211_GCMP_HDR_LEN - mic_len;
        if (!rx->sta || data_len < 0)
                return RX_DROP_UNUSABLE;
index 5265525..5ca186d 100644 (file)
@@ -1083,8 +1083,10 @@ static void __net_exit mctp_routes_net_exit(struct net *net)
 {
        struct mctp_route *rt;
 
+       rcu_read_lock();
        list_for_each_entry_rcu(rt, &net->mctp.routes, list)
                mctp_route_release(rt);
+       rcu_read_unlock();
 }
 
 static struct pernet_operations mctp_net_ops = {
index f48eb63..292374f 100644 (file)
@@ -36,7 +36,7 @@ static int mptcp_diag_dump_one(struct netlink_callback *cb,
        struct sock *sk;
 
        net = sock_net(in_skb->sk);
-       msk = mptcp_token_get_sock(req->id.idiag_cookie[0]);
+       msk = mptcp_token_get_sock(net, req->id.idiag_cookie[0]);
        if (!msk)
                goto out_nosk;
 
index c4f9a5c..050eea2 100644 (file)
@@ -1718,9 +1718,7 @@ static int mptcp_nl_cmd_set_flags(struct sk_buff *skb, struct genl_info *info)
 
        list_for_each_entry(entry, &pernet->local_addr_list, list) {
                if (addresses_equal(&entry->addr, &addr.addr, true)) {
-                       ret = mptcp_nl_addr_backup(net, &entry->addr, bkup);
-                       if (ret)
-                               return ret;
+                       mptcp_nl_addr_backup(net, &entry->addr, bkup);
 
                        if (bkup)
                                entry->flags |= MPTCP_PM_ADDR_FLAG_BACKUP;
index 2602f13..d073b21 100644 (file)
@@ -528,7 +528,6 @@ static bool mptcp_check_data_fin(struct sock *sk)
 
                sk->sk_shutdown |= RCV_SHUTDOWN;
                smp_mb__before_atomic(); /* SHUTDOWN must be visible first */
-               set_bit(MPTCP_DATA_READY, &msk->flags);
 
                switch (sk->sk_state) {
                case TCP_ESTABLISHED:
@@ -742,10 +741,9 @@ void mptcp_data_ready(struct sock *sk, struct sock *ssk)
 
        /* Wake-up the reader only for in-sequence data */
        mptcp_data_lock(sk);
-       if (move_skbs_to_msk(msk, ssk)) {
-               set_bit(MPTCP_DATA_READY, &msk->flags);
+       if (move_skbs_to_msk(msk, ssk))
                sk->sk_data_ready(sk);
-       }
+
        mptcp_data_unlock(sk);
 }
 
@@ -847,7 +845,6 @@ static void mptcp_check_for_eof(struct mptcp_sock *msk)
                sk->sk_shutdown |= RCV_SHUTDOWN;
 
                smp_mb__before_atomic(); /* SHUTDOWN must be visible first */
-               set_bit(MPTCP_DATA_READY, &msk->flags);
                sk->sk_data_ready(sk);
        }
 
@@ -1316,7 +1313,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct sock *ssk,
                        goto alloc_skb;
                }
 
-               must_collapse = (info->size_goal - skb->len > 0) &&
+               must_collapse = (info->size_goal > skb->len) &&
                                (skb_shinfo(skb)->nr_frags < sysctl_max_skb_frags);
                if (must_collapse) {
                        size_bias = skb->len;
@@ -1325,7 +1322,7 @@ static int mptcp_sendmsg_frag(struct sock *sk, struct sock *ssk,
        }
 
 alloc_skb:
-       if (!must_collapse && !ssk->sk_tx_skb_cache &&
+       if (!must_collapse &&
            !mptcp_alloc_tx_skb(sk, ssk, info->data_lock_held))
                return 0;
 
@@ -1759,21 +1756,6 @@ out:
        return copied ? : ret;
 }
 
-static void mptcp_wait_data(struct sock *sk, long *timeo)
-{
-       DEFINE_WAIT_FUNC(wait, woken_wake_function);
-       struct mptcp_sock *msk = mptcp_sk(sk);
-
-       add_wait_queue(sk_sleep(sk), &wait);
-       sk_set_bit(SOCKWQ_ASYNC_WAITDATA, sk);
-
-       sk_wait_event(sk, timeo,
-                     test_bit(MPTCP_DATA_READY, &msk->flags), &wait);
-
-       sk_clear_bit(SOCKWQ_ASYNC_WAITDATA, sk);
-       remove_wait_queue(sk_sleep(sk), &wait);
-}
-
 static int __mptcp_recvmsg_mskq(struct mptcp_sock *msk,
                                struct msghdr *msg,
                                size_t len, int flags,
@@ -2077,19 +2059,7 @@ static int mptcp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len,
                }
 
                pr_debug("block timeout %ld", timeo);
-               mptcp_wait_data(sk, &timeo);
-       }
-
-       if (skb_queue_empty_lockless(&sk->sk_receive_queue) &&
-           skb_queue_empty(&msk->receive_queue)) {
-               /* entire backlog drained, clear DATA_READY. */
-               clear_bit(MPTCP_DATA_READY, &msk->flags);
-
-               /* .. race-breaker: ssk might have gotten new data
-                * after last __mptcp_move_skbs() returned false.
-                */
-               if (unlikely(__mptcp_move_skbs(msk)))
-                       set_bit(MPTCP_DATA_READY, &msk->flags);
+               sk_wait_data(sk, &timeo, NULL);
        }
 
 out_err:
@@ -2098,9 +2068,9 @@ out_err:
                        tcp_recv_timestamp(msg, sk, &tss);
        }
 
-       pr_debug("msk=%p data_ready=%d rx queue empty=%d copied=%d",
-                msk, test_bit(MPTCP_DATA_READY, &msk->flags),
-                skb_queue_empty_lockless(&sk->sk_receive_queue), copied);
+       pr_debug("msk=%p rx queue empty=%d:%d copied=%d",
+                msk, skb_queue_empty_lockless(&sk->sk_receive_queue),
+                skb_queue_empty(&msk->receive_queue), copied);
        if (!(flags & MSG_PEEK))
                mptcp_rcv_space_adjust(msk, copied);
 
@@ -2368,7 +2338,6 @@ static void mptcp_check_fastclose(struct mptcp_sock *msk)
        inet_sk_state_store(sk, TCP_CLOSE);
        sk->sk_shutdown = SHUTDOWN_MASK;
        smp_mb__before_atomic(); /* SHUTDOWN must be visible first */
-       set_bit(MPTCP_DATA_READY, &msk->flags);
        set_bit(MPTCP_WORK_CLOSE_SUBFLOW, &msk->flags);
 
        mptcp_close_wake_up(sk);
@@ -2735,7 +2704,7 @@ cleanup:
        inet_csk(sk)->icsk_mtup.probe_timestamp = tcp_jiffies32;
        mptcp_for_each_subflow(mptcp_sk(sk), subflow) {
                struct sock *ssk = mptcp_subflow_tcp_sock(subflow);
-               bool slow = lock_sock_fast(ssk);
+               bool slow = lock_sock_fast_nested(ssk);
 
                sock_orphan(ssk);
                unlock_sock_fast(ssk, slow);
@@ -3385,8 +3354,14 @@ unlock_fail:
 
 static __poll_t mptcp_check_readable(struct mptcp_sock *msk)
 {
-       return test_bit(MPTCP_DATA_READY, &msk->flags) ? EPOLLIN | EPOLLRDNORM :
-              0;
+       /* Concurrent splices from sk_receive_queue into receive_queue will
+        * always show at least one non-empty queue when checked in this order.
+        */
+       if (skb_queue_empty_lockless(&((struct sock *)msk)->sk_receive_queue) &&
+           skb_queue_empty_lockless(&msk->receive_queue))
+               return 0;
+
+       return EPOLLIN | EPOLLRDNORM;
 }
 
 static __poll_t mptcp_check_writeable(struct mptcp_sock *msk)
@@ -3421,7 +3396,7 @@ static __poll_t mptcp_poll(struct file *file, struct socket *sock,
        state = inet_sk_state_load(sk);
        pr_debug("msk=%p state=%d flags=%lx", msk, state, msk->flags);
        if (state == TCP_LISTEN)
-               return mptcp_check_readable(msk);
+               return test_bit(MPTCP_DATA_READY, &msk->flags) ? EPOLLIN | EPOLLRDNORM : 0;
 
        if (state != TCP_SYN_SENT && state != TCP_SYN_RECV) {
                mask |= mptcp_check_readable(msk);
index d3e6fd1..dc98467 100644 (file)
@@ -709,7 +709,7 @@ int mptcp_token_new_connect(struct sock *sk);
 void mptcp_token_accept(struct mptcp_subflow_request_sock *r,
                        struct mptcp_sock *msk);
 bool mptcp_token_exists(u32 token);
-struct mptcp_sock *mptcp_token_get_sock(u32 token);
+struct mptcp_sock *mptcp_token_get_sock(struct net *net, u32 token);
 struct mptcp_sock *mptcp_token_iter_next(const struct net *net, long *s_slot,
                                         long *s_num);
 void mptcp_token_destroy(struct mptcp_sock *msk);
index 1de7ce8..6172f38 100644 (file)
@@ -86,7 +86,7 @@ static struct mptcp_sock *subflow_token_join_request(struct request_sock *req)
        struct mptcp_sock *msk;
        int local_id;
 
-       msk = mptcp_token_get_sock(subflow_req->token);
+       msk = mptcp_token_get_sock(sock_net(req_to_sk(req)), subflow_req->token);
        if (!msk) {
                SUBFLOW_REQ_INC_STATS(req, MPTCP_MIB_JOINNOTOKEN);
                return NULL;
index 3712778..7f22526 100644 (file)
@@ -108,18 +108,12 @@ bool mptcp_token_join_cookie_init_state(struct mptcp_subflow_request_sock *subfl
 
        e->valid = 0;
 
-       msk = mptcp_token_get_sock(e->token);
+       msk = mptcp_token_get_sock(net, e->token);
        if (!msk) {
                spin_unlock_bh(&join_entry_locks[i]);
                return false;
        }
 
-       /* If this fails, the token got re-used in the mean time by another
-        * mptcp socket in a different netns, i.e. entry is outdated.
-        */
-       if (!net_eq(sock_net((struct sock *)msk), net))
-               goto err_put;
-
        subflow_req->remote_nonce = e->remote_nonce;
        subflow_req->local_nonce = e->local_nonce;
        subflow_req->backup = e->backup;
@@ -128,11 +122,6 @@ bool mptcp_token_join_cookie_init_state(struct mptcp_subflow_request_sock *subfl
        subflow_req->msk = msk;
        spin_unlock_bh(&join_entry_locks[i]);
        return true;
-
-err_put:
-       spin_unlock_bh(&join_entry_locks[i]);
-       sock_put((struct sock *)msk);
-       return false;
 }
 
 void __init mptcp_join_cookie_init(void)
index a98e554..e581b34 100644 (file)
@@ -231,6 +231,7 @@ found:
 
 /**
  * mptcp_token_get_sock - retrieve mptcp connection sock using its token
+ * @net: restrict to this namespace
  * @token: token of the mptcp connection to retrieve
  *
  * This function returns the mptcp connection structure with the given token.
@@ -238,7 +239,7 @@ found:
  *
  * returns NULL if no connection with the given token value exists.
  */
-struct mptcp_sock *mptcp_token_get_sock(u32 token)
+struct mptcp_sock *mptcp_token_get_sock(struct net *net, u32 token)
 {
        struct hlist_nulls_node *pos;
        struct token_bucket *bucket;
@@ -251,11 +252,15 @@ struct mptcp_sock *mptcp_token_get_sock(u32 token)
 again:
        sk_nulls_for_each_rcu(sk, pos, &bucket->msk_chain) {
                msk = mptcp_sk(sk);
-               if (READ_ONCE(msk->token) != token)
+               if (READ_ONCE(msk->token) != token ||
+                   !net_eq(sock_net(sk), net))
                        continue;
+
                if (!refcount_inc_not_zero(&sk->sk_refcnt))
                        goto not_found;
-               if (READ_ONCE(msk->token) != token) {
+
+               if (READ_ONCE(msk->token) != token ||
+                   !net_eq(sock_net(sk), net)) {
                        sock_put(sk);
                        goto again;
                }
index e1bd6f0..5d984be 100644 (file)
@@ -11,6 +11,7 @@ static struct mptcp_subflow_request_sock *build_req_sock(struct kunit *test)
                            GFP_USER);
        KUNIT_EXPECT_NOT_ERR_OR_NULL(test, req);
        mptcp_token_init_request((struct request_sock *)req);
+       sock_net_set((struct sock *)req, &init_net);
        return req;
 }
 
@@ -22,7 +23,7 @@ static void mptcp_token_test_req_basic(struct kunit *test)
        KUNIT_ASSERT_EQ(test, 0,
                        mptcp_token_new_request((struct request_sock *)req));
        KUNIT_EXPECT_NE(test, 0, (int)req->token);
-       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(req->token));
+       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(&init_net, req->token));
 
        /* cleanup */
        mptcp_token_destroy_request((struct request_sock *)req);
@@ -55,6 +56,7 @@ static struct mptcp_sock *build_msk(struct kunit *test)
        msk = kunit_kzalloc(test, sizeof(struct mptcp_sock), GFP_USER);
        KUNIT_EXPECT_NOT_ERR_OR_NULL(test, msk);
        refcount_set(&((struct sock *)msk)->sk_refcnt, 1);
+       sock_net_set((struct sock *)msk, &init_net);
        return msk;
 }
 
@@ -74,11 +76,11 @@ static void mptcp_token_test_msk_basic(struct kunit *test)
                        mptcp_token_new_connect((struct sock *)icsk));
        KUNIT_EXPECT_NE(test, 0, (int)ctx->token);
        KUNIT_EXPECT_EQ(test, ctx->token, msk->token);
-       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(ctx->token));
+       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(&init_net, ctx->token));
        KUNIT_EXPECT_EQ(test, 2, (int)refcount_read(&sk->sk_refcnt));
 
        mptcp_token_destroy(msk);
-       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(ctx->token));
+       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(&init_net, ctx->token));
 }
 
 static void mptcp_token_test_accept(struct kunit *test)
@@ -90,11 +92,11 @@ static void mptcp_token_test_accept(struct kunit *test)
                        mptcp_token_new_request((struct request_sock *)req));
        msk->token = req->token;
        mptcp_token_accept(req, msk);
-       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(msk->token));
+       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(&init_net, msk->token));
 
        /* this is now a no-op */
        mptcp_token_destroy_request((struct request_sock *)req);
-       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(msk->token));
+       KUNIT_EXPECT_PTR_EQ(test, msk, mptcp_token_get_sock(&init_net, msk->token));
 
        /* cleanup */
        mptcp_token_destroy(msk);
@@ -116,7 +118,7 @@ static void mptcp_token_test_destroyed(struct kunit *test)
 
        /* simulate race on removal */
        refcount_set(&sk->sk_refcnt, 0);
-       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(msk->token));
+       KUNIT_EXPECT_PTR_EQ(test, null_msk, mptcp_token_get_sock(&init_net, msk->token));
 
        /* cleanup */
        mptcp_token_destroy(msk);
index 6186358..6e39130 100644 (file)
@@ -130,11 +130,11 @@ htable_size(u8 hbits)
 {
        size_t hsize;
 
-       /* We must fit both into u32 in jhash and size_t */
+       /* We must fit both into u32 in jhash and INT_MAX in kvmalloc_node() */
        if (hbits > 31)
                return 0;
        hsize = jhash_size(hbits);
-       if ((((size_t)-1) - sizeof(struct htable)) / sizeof(struct hbucket *)
+       if ((INT_MAX - sizeof(struct htable)) / sizeof(struct hbucket *)
            < hsize)
                return 0;
 
index c100c6b..2c467c4 100644 (file)
@@ -1468,6 +1468,10 @@ int __init ip_vs_conn_init(void)
        int idx;
 
        /* Compute size and mask */
+       if (ip_vs_conn_tab_bits < 8 || ip_vs_conn_tab_bits > 20) {
+               pr_info("conn_tab_bits not in [8, 20]. Using default value\n");
+               ip_vs_conn_tab_bits = CONFIG_IP_VS_TAB_BITS;
+       }
        ip_vs_conn_tab_size = 1 << ip_vs_conn_tab_bits;
        ip_vs_conn_tab_mask = ip_vs_conn_tab_size - 1;
 
index 94e18fb..770a631 100644 (file)
@@ -74,10 +74,14 @@ static __read_mostly struct kmem_cache *nf_conntrack_cachep;
 static DEFINE_SPINLOCK(nf_conntrack_locks_all_lock);
 static __read_mostly bool nf_conntrack_locks_all;
 
+/* serialize hash resizes and nf_ct_iterate_cleanup */
+static DEFINE_MUTEX(nf_conntrack_mutex);
+
 #define GC_SCAN_INTERVAL       (120u * HZ)
 #define GC_SCAN_MAX_DURATION   msecs_to_jiffies(10)
 
-#define MAX_CHAINLEN   64u
+#define MIN_CHAINLEN   8u
+#define MAX_CHAINLEN   (32u - MIN_CHAINLEN)
 
 static struct conntrack_gc_work conntrack_gc_work;
 
@@ -188,11 +192,13 @@ seqcount_spinlock_t nf_conntrack_generation __read_mostly;
 static siphash_key_t nf_conntrack_hash_rnd __read_mostly;
 
 static u32 hash_conntrack_raw(const struct nf_conntrack_tuple *tuple,
+                             unsigned int zoneid,
                              const struct net *net)
 {
        struct {
                struct nf_conntrack_man src;
                union nf_inet_addr dst_addr;
+               unsigned int zone;
                u32 net_mix;
                u16 dport;
                u16 proto;
@@ -205,6 +211,7 @@ static u32 hash_conntrack_raw(const struct nf_conntrack_tuple *tuple,
        /* The direction must be ignored, so handle usable members manually. */
        combined.src = tuple->src;
        combined.dst_addr = tuple->dst.u3;
+       combined.zone = zoneid;
        combined.net_mix = net_hash_mix(net);
        combined.dport = (__force __u16)tuple->dst.u.all;
        combined.proto = tuple->dst.protonum;
@@ -219,15 +226,17 @@ static u32 scale_hash(u32 hash)
 
 static u32 __hash_conntrack(const struct net *net,
                            const struct nf_conntrack_tuple *tuple,
+                           unsigned int zoneid,
                            unsigned int size)
 {
-       return reciprocal_scale(hash_conntrack_raw(tuple, net), size);
+       return reciprocal_scale(hash_conntrack_raw(tuple, zoneid, net), size);
 }
 
 static u32 hash_conntrack(const struct net *net,
-                         const struct nf_conntrack_tuple *tuple)
+                         const struct nf_conntrack_tuple *tuple,
+                         unsigned int zoneid)
 {
-       return scale_hash(hash_conntrack_raw(tuple, net));
+       return scale_hash(hash_conntrack_raw(tuple, zoneid, net));
 }
 
 static bool nf_ct_get_tuple_ports(const struct sk_buff *skb,
@@ -650,9 +659,11 @@ static void nf_ct_delete_from_lists(struct nf_conn *ct)
        do {
                sequence = read_seqcount_begin(&nf_conntrack_generation);
                hash = hash_conntrack(net,
-                                     &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple);
+                                     &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple,
+                                     nf_ct_zone_id(nf_ct_zone(ct), IP_CT_DIR_ORIGINAL));
                reply_hash = hash_conntrack(net,
-                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple);
+                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple,
+                                          nf_ct_zone_id(nf_ct_zone(ct), IP_CT_DIR_REPLY));
        } while (nf_conntrack_double_lock(net, hash, reply_hash, sequence));
 
        clean_from_lists(ct);
@@ -819,8 +830,20 @@ struct nf_conntrack_tuple_hash *
 nf_conntrack_find_get(struct net *net, const struct nf_conntrack_zone *zone,
                      const struct nf_conntrack_tuple *tuple)
 {
-       return __nf_conntrack_find_get(net, zone, tuple,
-                                      hash_conntrack_raw(tuple, net));
+       unsigned int rid, zone_id = nf_ct_zone_id(zone, IP_CT_DIR_ORIGINAL);
+       struct nf_conntrack_tuple_hash *thash;
+
+       thash = __nf_conntrack_find_get(net, zone, tuple,
+                                       hash_conntrack_raw(tuple, zone_id, net));
+
+       if (thash)
+               return thash;
+
+       rid = nf_ct_zone_id(zone, IP_CT_DIR_REPLY);
+       if (rid != zone_id)
+               return __nf_conntrack_find_get(net, zone, tuple,
+                                              hash_conntrack_raw(tuple, rid, net));
+       return thash;
 }
 EXPORT_SYMBOL_GPL(nf_conntrack_find_get);
 
@@ -842,6 +865,7 @@ nf_conntrack_hash_check_insert(struct nf_conn *ct)
        unsigned int hash, reply_hash;
        struct nf_conntrack_tuple_hash *h;
        struct hlist_nulls_node *n;
+       unsigned int max_chainlen;
        unsigned int chainlen = 0;
        unsigned int sequence;
        int err = -EEXIST;
@@ -852,18 +876,22 @@ nf_conntrack_hash_check_insert(struct nf_conn *ct)
        do {
                sequence = read_seqcount_begin(&nf_conntrack_generation);
                hash = hash_conntrack(net,
-                                     &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple);
+                                     &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple,
+                                     nf_ct_zone_id(nf_ct_zone(ct), IP_CT_DIR_ORIGINAL));
                reply_hash = hash_conntrack(net,
-                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple);
+                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple,
+                                          nf_ct_zone_id(nf_ct_zone(ct), IP_CT_DIR_REPLY));
        } while (nf_conntrack_double_lock(net, hash, reply_hash, sequence));
 
+       max_chainlen = MIN_CHAINLEN + prandom_u32_max(MAX_CHAINLEN);
+
        /* See if there's one in the list already, including reverse */
        hlist_nulls_for_each_entry(h, n, &nf_conntrack_hash[hash], hnnode) {
                if (nf_ct_key_equal(h, &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple,
                                    zone, net))
                        goto out;
 
-               if (chainlen++ > MAX_CHAINLEN)
+               if (chainlen++ > max_chainlen)
                        goto chaintoolong;
        }
 
@@ -873,7 +901,7 @@ nf_conntrack_hash_check_insert(struct nf_conn *ct)
                if (nf_ct_key_equal(h, &ct->tuplehash[IP_CT_DIR_REPLY].tuple,
                                    zone, net))
                        goto out;
-               if (chainlen++ > MAX_CHAINLEN)
+               if (chainlen++ > max_chainlen)
                        goto chaintoolong;
        }
 
@@ -1103,8 +1131,8 @@ drop:
 int
 __nf_conntrack_confirm(struct sk_buff *skb)
 {
+       unsigned int chainlen = 0, sequence, max_chainlen;
        const struct nf_conntrack_zone *zone;
-       unsigned int chainlen = 0, sequence;
        unsigned int hash, reply_hash;
        struct nf_conntrack_tuple_hash *h;
        struct nf_conn *ct;
@@ -1133,8 +1161,8 @@ __nf_conntrack_confirm(struct sk_buff *skb)
                hash = *(unsigned long *)&ct->tuplehash[IP_CT_DIR_REPLY].hnnode.pprev;
                hash = scale_hash(hash);
                reply_hash = hash_conntrack(net,
-                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple);
-
+                                          &ct->tuplehash[IP_CT_DIR_REPLY].tuple,
+                                          nf_ct_zone_id(nf_ct_zone(ct), IP_CT_DIR_REPLY));
        } while (nf_conntrack_double_lock(net, hash, reply_hash, sequence));
 
        /* We're not in hash table, and we refuse to set up related
@@ -1168,6 +1196,7 @@ __nf_conntrack_confirm(struct sk_buff *skb)
                goto dying;
        }
 
+       max_chainlen = MIN_CHAINLEN + prandom_u32_max(MAX_CHAINLEN);
        /* See if there's one in the list already, including reverse:
           NAT could have grabbed it without realizing, since we're
           not in the hash.  If there is, we lost race. */
@@ -1175,7 +1204,7 @@ __nf_conntrack_confirm(struct sk_buff *skb)
                if (nf_ct_key_equal(h, &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple,
                                    zone, net))
                        goto out;
-               if (chainlen++ > MAX_CHAINLEN)
+               if (chainlen++ > max_chainlen)
                        goto chaintoolong;
        }
 
@@ -1184,7 +1213,7 @@ __nf_conntrack_confirm(struct sk_buff *skb)
                if (nf_ct_key_equal(h, &ct->tuplehash[IP_CT_DIR_REPLY].tuple,
                                    zone, net))
                        goto out;
-               if (chainlen++ > MAX_CHAINLEN) {
+               if (chainlen++ > max_chainlen) {
 chaintoolong:
                        nf_ct_add_to_dying_list(ct);
                        NF_CT_STAT_INC(net, chaintoolong);
@@ -1246,7 +1275,7 @@ nf_conntrack_tuple_taken(const struct nf_conntrack_tuple *tuple,
        rcu_read_lock();
  begin:
        nf_conntrack_get_ht(&ct_hash, &hsize);
-       hash = __hash_conntrack(net, tuple, hsize);
+       hash = __hash_conntrack(net, tuple, nf_ct_zone_id(zone, IP_CT_DIR_REPLY), hsize);
 
        hlist_nulls_for_each_entry_rcu(h, n, &ct_hash[hash], hnnode) {
                ct = nf_ct_tuplehash_to_ctrack(h);
@@ -1687,8 +1716,8 @@ resolve_normal_ct(struct nf_conn *tmpl,
        struct nf_conntrack_tuple_hash *h;
        enum ip_conntrack_info ctinfo;
        struct nf_conntrack_zone tmp;
+       u32 hash, zone_id, rid;
        struct nf_conn *ct;
-       u32 hash;
 
        if (!nf_ct_get_tuple(skb, skb_network_offset(skb),
                             dataoff, state->pf, protonum, state->net,
@@ -1699,8 +1728,20 @@ resolve_normal_ct(struct nf_conn *tmpl,
 
        /* look for tuple match */
        zone = nf_ct_zone_tmpl(tmpl, skb, &tmp);
-       hash = hash_conntrack_raw(&tuple, state->net);
+
+       zone_id = nf_ct_zone_id(zone, IP_CT_DIR_ORIGINAL);
+       hash = hash_conntrack_raw(&tuple, zone_id, state->net);
        h = __nf_conntrack_find_get(state->net, zone, &tuple, hash);
+
+       if (!h) {
+               rid = nf_ct_zone_id(zone, IP_CT_DIR_REPLY);
+               if (zone_id != rid) {
+                       u32 tmp = hash_conntrack_raw(&tuple, rid, state->net);
+
+                       h = __nf_conntrack_find_get(state->net, zone, &tuple, tmp);
+               }
+       }
+
        if (!h) {
                h = init_conntrack(state->net, tmpl, &tuple,
                                   skb, dataoff, hash);
@@ -2225,28 +2266,31 @@ get_next_corpse(int (*iter)(struct nf_conn *i, void *data),
        spinlock_t *lockp;
 
        for (; *bucket < nf_conntrack_htable_size; (*bucket)++) {
+               struct hlist_nulls_head *hslot = &nf_conntrack_hash[*bucket];
+
+               if (hlist_nulls_empty(hslot))
+                       continue;
+
                lockp = &nf_conntrack_locks[*bucket % CONNTRACK_LOCKS];
                local_bh_disable();
                nf_conntrack_lock(lockp);
-               if (*bucket < nf_conntrack_htable_size) {
-                       hlist_nulls_for_each_entry(h, n, &nf_conntrack_hash[*bucket], hnnode) {
-                               if (NF_CT_DIRECTION(h) != IP_CT_DIR_REPLY)
-                                       continue;
-                               /* All nf_conn objects are added to hash table twice, one
-                                * for original direction tuple, once for the reply tuple.
-                                *
-                                * Exception: In the IPS_NAT_CLASH case, only the reply
-                                * tuple is added (the original tuple already existed for
-                                * a different object).
-                                *
-                                * We only need to call the iterator once for each
-                                * conntrack, so we just use the 'reply' direction
-                                * tuple while iterating.
-                                */
-                               ct = nf_ct_tuplehash_to_ctrack(h);
-                               if (iter(ct, data))
-                                       goto found;
-                       }
+               hlist_nulls_for_each_entry(h, n, hslot, hnnode) {
+                       if (NF_CT_DIRECTION(h) != IP_CT_DIR_REPLY)
+                               continue;
+                       /* All nf_conn objects are added to hash table twice, one
+                        * for original direction tuple, once for the reply tuple.
+                        *
+                        * Exception: In the IPS_NAT_CLASH case, only the reply
+                        * tuple is added (the original tuple already existed for
+                        * a different object).
+                        *
+                        * We only need to call the iterator once for each
+                        * conntrack, so we just use the 'reply' direction
+                        * tuple while iterating.
+                        */
+                       ct = nf_ct_tuplehash_to_ctrack(h);
+                       if (iter(ct, data))
+                               goto found;
                }
                spin_unlock(lockp);
                local_bh_enable();
@@ -2264,26 +2308,20 @@ found:
 static void nf_ct_iterate_cleanup(int (*iter)(struct nf_conn *i, void *data),
                                  void *data, u32 portid, int report)
 {
-       unsigned int bucket = 0, sequence;
+       unsigned int bucket = 0;
        struct nf_conn *ct;
 
        might_sleep();
 
-       for (;;) {
-               sequence = read_seqcount_begin(&nf_conntrack_generation);
-
-               while ((ct = get_next_corpse(iter, data, &bucket)) != NULL) {
-                       /* Time to push up daises... */
+       mutex_lock(&nf_conntrack_mutex);
+       while ((ct = get_next_corpse(iter, data, &bucket)) != NULL) {
+               /* Time to push up daises... */
 
-                       nf_ct_delete(ct, portid, report);
-                       nf_ct_put(ct);
-                       cond_resched();
-               }
-
-               if (!read_seqcount_retry(&nf_conntrack_generation, sequence))
-                       break;
-               bucket = 0;
+               nf_ct_delete(ct, portid, report);
+               nf_ct_put(ct);
+               cond_resched();
        }
+       mutex_unlock(&nf_conntrack_mutex);
 }
 
 struct iter_data {
@@ -2519,8 +2557,10 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
        if (!hash)
                return -ENOMEM;
 
+       mutex_lock(&nf_conntrack_mutex);
        old_size = nf_conntrack_htable_size;
        if (old_size == hashsize) {
+               mutex_unlock(&nf_conntrack_mutex);
                kvfree(hash);
                return 0;
        }
@@ -2537,12 +2577,16 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
 
        for (i = 0; i < nf_conntrack_htable_size; i++) {
                while (!hlist_nulls_empty(&nf_conntrack_hash[i])) {
+                       unsigned int zone_id;
+
                        h = hlist_nulls_entry(nf_conntrack_hash[i].first,
                                              struct nf_conntrack_tuple_hash, hnnode);
                        ct = nf_ct_tuplehash_to_ctrack(h);
                        hlist_nulls_del_rcu(&h->hnnode);
+
+                       zone_id = nf_ct_zone_id(nf_ct_zone(ct), NF_CT_DIRECTION(h));
                        bucket = __hash_conntrack(nf_ct_net(ct),
-                                                 &h->tuple, hashsize);
+                                                 &h->tuple, zone_id, hashsize);
                        hlist_nulls_add_head_rcu(&h->hnnode, &hash[bucket]);
                }
        }
@@ -2556,6 +2600,8 @@ int nf_conntrack_hash_resize(unsigned int hashsize)
        nf_conntrack_all_unlock();
        local_bh_enable();
 
+       mutex_unlock(&nf_conntrack_mutex);
+
        synchronize_net();
        kvfree(old_hash);
        return 0;
index 7008961..2731176 100644 (file)
@@ -150,13 +150,16 @@ static void __nf_nat_decode_session(struct sk_buff *skb, struct flowi *fl)
 
 /* We keep an extra hash for each conntrack, for fast searching. */
 static unsigned int
-hash_by_src(const struct net *n, const struct nf_conntrack_tuple *tuple)
+hash_by_src(const struct net *net,
+           const struct nf_conntrack_zone *zone,
+           const struct nf_conntrack_tuple *tuple)
 {
        unsigned int hash;
        struct {
                struct nf_conntrack_man src;
                u32 net_mix;
                u32 protonum;
+               u32 zone;
        } __aligned(SIPHASH_ALIGNMENT) combined;
 
        get_random_once(&nf_nat_hash_rnd, sizeof(nf_nat_hash_rnd));
@@ -165,9 +168,13 @@ hash_by_src(const struct net *n, const struct nf_conntrack_tuple *tuple)
 
        /* Original src, to ensure we map it consistently if poss. */
        combined.src = tuple->src;
-       combined.net_mix = net_hash_mix(n);
+       combined.net_mix = net_hash_mix(net);
        combined.protonum = tuple->dst.protonum;
 
+       /* Zone ID can be used provided its valid for both directions */
+       if (zone->dir == NF_CT_DEFAULT_ZONE_DIR)
+               combined.zone = zone->id;
+
        hash = siphash(&combined, sizeof(combined), &nf_nat_hash_rnd);
 
        return reciprocal_scale(hash, nf_nat_htable_size);
@@ -272,7 +279,7 @@ find_appropriate_src(struct net *net,
                     struct nf_conntrack_tuple *result,
                     const struct nf_nat_range2 *range)
 {
-       unsigned int h = hash_by_src(net, tuple);
+       unsigned int h = hash_by_src(net, zone, tuple);
        const struct nf_conn *ct;
 
        hlist_for_each_entry_rcu(ct, &nf_nat_bysource[h], nat_bysource) {
@@ -619,7 +626,7 @@ nf_nat_setup_info(struct nf_conn *ct,
                unsigned int srchash;
                spinlock_t *lock;
 
-               srchash = hash_by_src(net,
+               srchash = hash_by_src(net, nf_ct_zone(ct),
                                      &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple);
                lock = &nf_nat_locks[srchash % CONNTRACK_LOCKS];
                spin_lock_bh(lock);
@@ -788,7 +795,7 @@ static void __nf_nat_cleanup_conntrack(struct nf_conn *ct)
 {
        unsigned int h;
 
-       h = hash_by_src(nf_ct_net(ct), &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple);
+       h = hash_by_src(nf_ct_net(ct), nf_ct_zone(ct), &ct->tuplehash[IP_CT_DIR_ORIGINAL].tuple);
        spin_lock_bh(&nf_nat_locks[h % CONNTRACK_LOCKS]);
        hlist_del_rcu(&ct->nat_bysource);
        spin_unlock_bh(&nf_nat_locks[h % CONNTRACK_LOCKS]);
index 8e8a65d..acd73f7 100644 (file)
@@ -9,8 +9,19 @@
 
 #include <net/netfilter/nf_nat_masquerade.h>
 
+struct masq_dev_work {
+       struct work_struct work;
+       struct net *net;
+       union nf_inet_addr addr;
+       int ifindex;
+       int (*iter)(struct nf_conn *i, void *data);
+};
+
+#define MAX_MASQ_WORKER_COUNT  16
+
 static DEFINE_MUTEX(masq_mutex);
 static unsigned int masq_refcnt __read_mostly;
+static atomic_t masq_worker_count __read_mostly;
 
 unsigned int
 nf_nat_masquerade_ipv4(struct sk_buff *skb, unsigned int hooknum,
@@ -63,13 +74,71 @@ nf_nat_masquerade_ipv4(struct sk_buff *skb, unsigned int hooknum,
 }
 EXPORT_SYMBOL_GPL(nf_nat_masquerade_ipv4);
 
-static int device_cmp(struct nf_conn *i, void *ifindex)
+static void iterate_cleanup_work(struct work_struct *work)
+{
+       struct masq_dev_work *w;
+
+       w = container_of(work, struct masq_dev_work, work);
+
+       nf_ct_iterate_cleanup_net(w->net, w->iter, (void *)w, 0, 0);
+
+       put_net(w->net);
+       kfree(w);
+       atomic_dec(&masq_worker_count);
+       module_put(THIS_MODULE);
+}
+
+/* Iterate conntrack table in the background and remove conntrack entries
+ * that use the device/address being removed.
+ *
+ * In case too many work items have been queued already or memory allocation
+ * fails iteration is skipped, conntrack entries will time out eventually.
+ */
+static void nf_nat_masq_schedule(struct net *net, union nf_inet_addr *addr,
+                                int ifindex,
+                                int (*iter)(struct nf_conn *i, void *data),
+                                gfp_t gfp_flags)
+{
+       struct masq_dev_work *w;
+
+       if (atomic_read(&masq_worker_count) > MAX_MASQ_WORKER_COUNT)
+               return;
+
+       net = maybe_get_net(net);
+       if (!net)
+               return;
+
+       if (!try_module_get(THIS_MODULE))
+               goto err_module;
+
+       w = kzalloc(sizeof(*w), gfp_flags);
+       if (w) {
+               /* We can overshoot MAX_MASQ_WORKER_COUNT, no big deal */
+               atomic_inc(&masq_worker_count);
+
+               INIT_WORK(&w->work, iterate_cleanup_work);
+               w->ifindex = ifindex;
+               w->net = net;
+               w->iter = iter;
+               if (addr)
+                       w->addr = *addr;
+               schedule_work(&w->work);
+               return;
+       }
+
+       module_put(THIS_MODULE);
+ err_module:
+       put_net(net);
+}
+
+static int device_cmp(struct nf_conn *i, void *arg)
 {
        const struct nf_conn_nat *nat = nfct_nat(i);
+       const struct masq_dev_work *w = arg;
 
        if (!nat)
                return 0;
-       return nat->masq_index == (int)(long)ifindex;
+       return nat->masq_index == w->ifindex;
 }
 
 static int masq_device_event(struct notifier_block *this,
@@ -85,8 +154,8 @@ static int masq_device_event(struct notifier_block *this,
                 * and forget them.
                 */
 
-               nf_ct_iterate_cleanup_net(net, device_cmp,
-                                         (void *)(long)dev->ifindex, 0, 0);
+               nf_nat_masq_schedule(net, NULL, dev->ifindex,
+                                    device_cmp, GFP_KERNEL);
        }
 
        return NOTIFY_DONE;
@@ -94,35 +163,45 @@ static int masq_device_event(struct notifier_block *this,
 
 static int inet_cmp(struct nf_conn *ct, void *ptr)
 {
-       struct in_ifaddr *ifa = (struct in_ifaddr *)ptr;
-       struct net_device *dev = ifa->ifa_dev->dev;
        struct nf_conntrack_tuple *tuple;
+       struct masq_dev_work *w = ptr;
 
-       if (!device_cmp(ct, (void *)(long)dev->ifindex))
+       if (!device_cmp(ct, ptr))
                return 0;
 
        tuple = &ct->tuplehash[IP_CT_DIR_REPLY].tuple;
 
-       return ifa->ifa_address == tuple->dst.u3.ip;
+       return nf_inet_addr_cmp(&w->addr, &tuple->dst.u3);
 }
 
 static int masq_inet_event(struct notifier_block *this,
                           unsigned long event,
                           void *ptr)
 {
-       struct in_device *idev = ((struct in_ifaddr *)ptr)->ifa_dev;
-       struct net *net = dev_net(idev->dev);
+       const struct in_ifaddr *ifa = ptr;
+       const struct in_device *idev;
+       const struct net_device *dev;
+       union nf_inet_addr addr;
+
+       if (event != NETDEV_DOWN)
+               return NOTIFY_DONE;
 
        /* The masq_dev_notifier will catch the case of the device going
         * down.  So if the inetdev is dead and being destroyed we have
         * no work to do.  Otherwise this is an individual address removal
         * and we have to perform the flush.
         */
+       idev = ifa->ifa_dev;
        if (idev->dead)
                return NOTIFY_DONE;
 
-       if (event == NETDEV_DOWN)
-               nf_ct_iterate_cleanup_net(net, inet_cmp, ptr, 0, 0);
+       memset(&addr, 0, sizeof(addr));
+
+       addr.ip = ifa->ifa_address;
+
+       dev = idev->dev;
+       nf_nat_masq_schedule(dev_net(idev->dev), &addr, dev->ifindex,
+                            inet_cmp, GFP_KERNEL);
 
        return NOTIFY_DONE;
 }
@@ -136,8 +215,6 @@ static struct notifier_block masq_inet_notifier = {
 };
 
 #if IS_ENABLED(CONFIG_IPV6)
-static atomic_t v6_worker_count __read_mostly;
-
 static int
 nat_ipv6_dev_get_saddr(struct net *net, const struct net_device *dev,
                       const struct in6_addr *daddr, unsigned int srcprefs,
@@ -187,40 +264,6 @@ nf_nat_masquerade_ipv6(struct sk_buff *skb, const struct nf_nat_range2 *range,
 }
 EXPORT_SYMBOL_GPL(nf_nat_masquerade_ipv6);
 
-struct masq_dev_work {
-       struct work_struct work;
-       struct net *net;
-       struct in6_addr addr;
-       int ifindex;
-};
-
-static int inet6_cmp(struct nf_conn *ct, void *work)
-{
-       struct masq_dev_work *w = (struct masq_dev_work *)work;
-       struct nf_conntrack_tuple *tuple;
-
-       if (!device_cmp(ct, (void *)(long)w->ifindex))
-               return 0;
-
-       tuple = &ct->tuplehash[IP_CT_DIR_REPLY].tuple;
-
-       return ipv6_addr_equal(&w->addr, &tuple->dst.u3.in6);
-}
-
-static void iterate_cleanup_work(struct work_struct *work)
-{
-       struct masq_dev_work *w;
-
-       w = container_of(work, struct masq_dev_work, work);
-
-       nf_ct_iterate_cleanup_net(w->net, inet6_cmp, (void *)w, 0, 0);
-
-       put_net(w->net);
-       kfree(w);
-       atomic_dec(&v6_worker_count);
-       module_put(THIS_MODULE);
-}
-
 /* atomic notifier; can't call nf_ct_iterate_cleanup_net (it can sleep).
  *
  * Defer it to the system workqueue.
@@ -233,36 +276,19 @@ static int masq_inet6_event(struct notifier_block *this,
 {
        struct inet6_ifaddr *ifa = ptr;
        const struct net_device *dev;
-       struct masq_dev_work *w;
-       struct net *net;
+       union nf_inet_addr addr;
 
-       if (event != NETDEV_DOWN || atomic_read(&v6_worker_count) >= 16)
+       if (event != NETDEV_DOWN)
                return NOTIFY_DONE;
 
        dev = ifa->idev->dev;
-       net = maybe_get_net(dev_net(dev));
-       if (!net)
-               return NOTIFY_DONE;
 
-       if (!try_module_get(THIS_MODULE))
-               goto err_module;
+       memset(&addr, 0, sizeof(addr));
 
-       w = kmalloc(sizeof(*w), GFP_ATOMIC);
-       if (w) {
-               atomic_inc(&v6_worker_count);
-
-               INIT_WORK(&w->work, iterate_cleanup_work);
-               w->ifindex = dev->ifindex;
-               w->net = net;
-               w->addr = ifa->addr;
-               schedule_work(&w->work);
+       addr.in6 = ifa->addr;
 
-               return NOTIFY_DONE;
-       }
-
-       module_put(THIS_MODULE);
- err_module:
-       put_net(net);
+       nf_nat_masq_schedule(dev_net(dev), &addr, dev->ifindex, inet_cmp,
+                            GFP_ATOMIC);
        return NOTIFY_DONE;
 }
 
index 081437d..c0851fe 100644 (file)
@@ -780,6 +780,7 @@ static void nf_tables_table_notify(const struct nft_ctx *ctx, int event)
 {
        struct nftables_pernet *nft_net;
        struct sk_buff *skb;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report &&
@@ -790,8 +791,11 @@ static void nf_tables_table_notify(const struct nft_ctx *ctx, int event)
        if (skb == NULL)
                goto err;
 
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
        err = nf_tables_fill_table_info(skb, ctx->net, ctx->portid, ctx->seq,
-                                       event, 0, ctx->family, ctx->table);
+                                       event, flags, ctx->family, ctx->table);
        if (err < 0) {
                kfree_skb(skb);
                goto err;
@@ -1563,6 +1567,7 @@ static void nf_tables_chain_notify(const struct nft_ctx *ctx, int event)
 {
        struct nftables_pernet *nft_net;
        struct sk_buff *skb;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report &&
@@ -1573,8 +1578,11 @@ static void nf_tables_chain_notify(const struct nft_ctx *ctx, int event)
        if (skb == NULL)
                goto err;
 
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
        err = nf_tables_fill_chain_info(skb, ctx->net, ctx->portid, ctx->seq,
-                                       event, 0, ctx->family, ctx->table,
+                                       event, flags, ctx->family, ctx->table,
                                        ctx->chain);
        if (err < 0) {
                kfree_skb(skb);
@@ -2866,8 +2874,7 @@ static int nf_tables_fill_rule_info(struct sk_buff *skb, struct net *net,
                                    u32 flags, int family,
                                    const struct nft_table *table,
                                    const struct nft_chain *chain,
-                                   const struct nft_rule *rule,
-                                   const struct nft_rule *prule)
+                                   const struct nft_rule *rule, u64 handle)
 {
        struct nlmsghdr *nlh;
        const struct nft_expr *expr, *next;
@@ -2887,9 +2894,8 @@ static int nf_tables_fill_rule_info(struct sk_buff *skb, struct net *net,
                         NFTA_RULE_PAD))
                goto nla_put_failure;
 
-       if (event != NFT_MSG_DELRULE && prule) {
-               if (nla_put_be64(skb, NFTA_RULE_POSITION,
-                                cpu_to_be64(prule->handle),
+       if (event != NFT_MSG_DELRULE && handle) {
+               if (nla_put_be64(skb, NFTA_RULE_POSITION, cpu_to_be64(handle),
                                 NFTA_RULE_PAD))
                        goto nla_put_failure;
        }
@@ -2925,7 +2931,10 @@ static void nf_tables_rule_notify(const struct nft_ctx *ctx,
                                  const struct nft_rule *rule, int event)
 {
        struct nftables_pernet *nft_net = nft_pernet(ctx->net);
+       const struct nft_rule *prule;
        struct sk_buff *skb;
+       u64 handle = 0;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report &&
@@ -2936,9 +2945,20 @@ static void nf_tables_rule_notify(const struct nft_ctx *ctx,
        if (skb == NULL)
                goto err;
 
+       if (event == NFT_MSG_NEWRULE &&
+           !list_is_first(&rule->list, &ctx->chain->rules) &&
+           !list_is_last(&rule->list, &ctx->chain->rules)) {
+               prule = list_prev_entry(rule, list);
+               handle = prule->handle;
+       }
+       if (ctx->flags & (NLM_F_APPEND | NLM_F_REPLACE))
+               flags |= NLM_F_APPEND;
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
        err = nf_tables_fill_rule_info(skb, ctx->net, ctx->portid, ctx->seq,
-                                      event, 0, ctx->family, ctx->table,
-                                      ctx->chain, rule, NULL);
+                                      event, flags, ctx->family, ctx->table,
+                                      ctx->chain, rule, handle);
        if (err < 0) {
                kfree_skb(skb);
                goto err;
@@ -2964,6 +2984,7 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
        struct net *net = sock_net(skb->sk);
        const struct nft_rule *rule, *prule;
        unsigned int s_idx = cb->args[0];
+       u64 handle;
 
        prule = NULL;
        list_for_each_entry_rcu(rule, &chain->rules, list) {
@@ -2975,12 +2996,17 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
                        memset(&cb->args[1], 0,
                                        sizeof(cb->args) - sizeof(cb->args[0]));
                }
+               if (prule)
+                       handle = prule->handle;
+               else
+                       handle = 0;
+
                if (nf_tables_fill_rule_info(skb, net, NETLINK_CB(cb->skb).portid,
                                        cb->nlh->nlmsg_seq,
                                        NFT_MSG_NEWRULE,
                                        NLM_F_MULTI | NLM_F_APPEND,
                                        table->family,
-                                       table, chain, rule, prule) < 0)
+                                       table, chain, rule, handle) < 0)
                        return 1;
 
                nl_dump_check_consistent(cb, nlmsg_hdr(skb));
@@ -3143,7 +3169,7 @@ static int nf_tables_getrule(struct sk_buff *skb, const struct nfnl_info *info,
 
        err = nf_tables_fill_rule_info(skb2, net, NETLINK_CB(skb).portid,
                                       info->nlh->nlmsg_seq, NFT_MSG_NEWRULE, 0,
-                                      family, table, chain, rule, NULL);
+                                      family, table, chain, rule, 0);
        if (err < 0)
                goto err_fill_rule_info;
 
@@ -3403,17 +3429,15 @@ static int nf_tables_newrule(struct sk_buff *skb, const struct nfnl_info *info,
        }
 
        if (info->nlh->nlmsg_flags & NLM_F_REPLACE) {
+               err = nft_delrule(&ctx, old_rule);
+               if (err < 0)
+                       goto err_destroy_flow_rule;
+
                trans = nft_trans_rule_add(&ctx, NFT_MSG_NEWRULE, rule);
                if (trans == NULL) {
                        err = -ENOMEM;
                        goto err_destroy_flow_rule;
                }
-               err = nft_delrule(&ctx, old_rule);
-               if (err < 0) {
-                       nft_trans_destroy(trans);
-                       goto err_destroy_flow_rule;
-               }
-
                list_add_tail_rcu(&rule->list, &old_rule->list);
        } else {
                trans = nft_trans_rule_add(&ctx, NFT_MSG_NEWRULE, rule);
@@ -3943,8 +3967,9 @@ static void nf_tables_set_notify(const struct nft_ctx *ctx,
                                 gfp_t gfp_flags)
 {
        struct nftables_pernet *nft_net = nft_pernet(ctx->net);
-       struct sk_buff *skb;
        u32 portid = ctx->portid;
+       struct sk_buff *skb;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report &&
@@ -3955,7 +3980,10 @@ static void nf_tables_set_notify(const struct nft_ctx *ctx,
        if (skb == NULL)
                goto err;
 
-       err = nf_tables_fill_set(skb, ctx, set, event, 0);
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
+       err = nf_tables_fill_set(skb, ctx, set, event, flags);
        if (err < 0) {
                kfree_skb(skb);
                goto err;
@@ -4336,7 +4364,7 @@ static int nf_tables_newset(struct sk_buff *skb, const struct nfnl_info *info,
        if (ops->privsize != NULL)
                size = ops->privsize(nla, &desc);
        alloc_size = sizeof(*set) + size + udlen;
-       if (alloc_size < size)
+       if (alloc_size < size || alloc_size > INT_MAX)
                return -ENOMEM;
        set = kvzalloc(alloc_size, GFP_KERNEL);
        if (!set)
@@ -5231,12 +5259,13 @@ static int nf_tables_getsetelem(struct sk_buff *skb,
 static void nf_tables_setelem_notify(const struct nft_ctx *ctx,
                                     const struct nft_set *set,
                                     const struct nft_set_elem *elem,
-                                    int event, u16 flags)
+                                    int event)
 {
        struct nftables_pernet *nft_net;
        struct net *net = ctx->net;
        u32 portid = ctx->portid;
        struct sk_buff *skb;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report && !nfnetlink_has_listeners(net, NFNLGRP_NFTABLES))
@@ -5246,6 +5275,9 @@ static void nf_tables_setelem_notify(const struct nft_ctx *ctx,
        if (skb == NULL)
                goto err;
 
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
        err = nf_tables_fill_setelem_info(skb, ctx, 0, portid, event, flags,
                                          set, elem);
        if (err < 0) {
@@ -6921,7 +6953,7 @@ static int nf_tables_delobj(struct sk_buff *skb, const struct nfnl_info *info,
 
 void nft_obj_notify(struct net *net, const struct nft_table *table,
                    struct nft_object *obj, u32 portid, u32 seq, int event,
-                   int family, int report, gfp_t gfp)
+                   u16 flags, int family, int report, gfp_t gfp)
 {
        struct nftables_pernet *nft_net = nft_pernet(net);
        struct sk_buff *skb;
@@ -6946,8 +6978,9 @@ void nft_obj_notify(struct net *net, const struct nft_table *table,
        if (skb == NULL)
                goto err;
 
-       err = nf_tables_fill_obj_info(skb, net, portid, seq, event, 0, family,
-                                     table, obj, false);
+       err = nf_tables_fill_obj_info(skb, net, portid, seq, event,
+                                     flags & (NLM_F_CREATE | NLM_F_EXCL),
+                                     family, table, obj, false);
        if (err < 0) {
                kfree_skb(skb);
                goto err;
@@ -6964,7 +6997,7 @@ static void nf_tables_obj_notify(const struct nft_ctx *ctx,
                                 struct nft_object *obj, int event)
 {
        nft_obj_notify(ctx->net, ctx->table, obj, ctx->portid, ctx->seq, event,
-                      ctx->family, ctx->report, GFP_KERNEL);
+                      ctx->flags, ctx->family, ctx->report, GFP_KERNEL);
 }
 
 /*
@@ -7745,6 +7778,7 @@ static void nf_tables_flowtable_notify(struct nft_ctx *ctx,
 {
        struct nftables_pernet *nft_net = nft_pernet(ctx->net);
        struct sk_buff *skb;
+       u16 flags = 0;
        int err;
 
        if (!ctx->report &&
@@ -7755,8 +7789,11 @@ static void nf_tables_flowtable_notify(struct nft_ctx *ctx,
        if (skb == NULL)
                goto err;
 
+       if (ctx->flags & (NLM_F_CREATE | NLM_F_EXCL))
+               flags |= ctx->flags & (NLM_F_CREATE | NLM_F_EXCL);
+
        err = nf_tables_fill_flowtable_info(skb, ctx->net, ctx->portid,
-                                           ctx->seq, event, 0,
+                                           ctx->seq, event, flags,
                                            ctx->family, flowtable, hook_list);
        if (err < 0) {
                kfree_skb(skb);
@@ -8634,7 +8671,7 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)
                        nft_setelem_activate(net, te->set, &te->elem);
                        nf_tables_setelem_notify(&trans->ctx, te->set,
                                                 &te->elem,
-                                                NFT_MSG_NEWSETELEM, 0);
+                                                NFT_MSG_NEWSETELEM);
                        nft_trans_destroy(trans);
                        break;
                case NFT_MSG_DELSETELEM:
@@ -8642,7 +8679,7 @@ static int nf_tables_commit(struct net *net, struct sk_buff *skb)
 
                        nf_tables_setelem_notify(&trans->ctx, te->set,
                                                 &te->elem,
-                                                NFT_MSG_DELSETELEM, 0);
+                                                NFT_MSG_DELSETELEM);
                        nft_setelem_remove(net, te->set, &te->elem);
                        if (!nft_setelem_is_catchall(te->set, &te->elem)) {
                                atomic_dec(&te->set->nelems);
@@ -9599,7 +9636,6 @@ static void __nft_release_table(struct net *net, struct nft_table *table)
                table->use--;
                nf_tables_chain_destroy(&ctx);
        }
-       list_del(&table->list);
        nf_tables_table_destroy(&ctx);
 }
 
@@ -9612,6 +9648,8 @@ static void __nft_release_tables(struct net *net)
                if (nft_table_has_owner(table))
                        continue;
 
+               list_del(&table->list);
+
                __nft_release_table(net, table);
        }
 }
@@ -9619,31 +9657,38 @@ static void __nft_release_tables(struct net *net)
 static int nft_rcv_nl_event(struct notifier_block *this, unsigned long event,
                            void *ptr)
 {
+       struct nft_table *table, *to_delete[8];
        struct nftables_pernet *nft_net;
        struct netlink_notify *n = ptr;
-       struct nft_table *table, *nt;
        struct net *net = n->net;
-       bool release = false;
+       unsigned int deleted;
+       bool restart = false;
 
        if (event != NETLINK_URELEASE || n->protocol != NETLINK_NETFILTER)
                return NOTIFY_DONE;
 
        nft_net = nft_pernet(net);
+       deleted = 0;
        mutex_lock(&nft_net->commit_mutex);
+again:
        list_for_each_entry(table, &nft_net->tables, list) {
                if (nft_table_has_owner(table) &&
                    n->portid == table->nlpid) {
                        __nft_release_hook(net, table);
-                       release = true;
+                       list_del_rcu(&table->list);
+                       to_delete[deleted++] = table;
+                       if (deleted >= ARRAY_SIZE(to_delete))
+                               break;
                }
        }
-       if (release) {
+       if (deleted) {
+               restart = deleted >= ARRAY_SIZE(to_delete);
                synchronize_rcu();
-               list_for_each_entry_safe(table, nt, &nft_net->tables, list) {
-                       if (nft_table_has_owner(table) &&
-                           n->portid == table->nlpid)
-                               __nft_release_table(net, table);
-               }
+               while (deleted)
+                       __nft_release_table(net, to_delete[--deleted]);
+
+               if (restart)
+                       goto again;
        }
        mutex_unlock(&nft_net->commit_mutex);
 
index 272bcdb..f69cc73 100644 (file)
@@ -19,6 +19,7 @@
 #include <linux/netfilter_bridge/ebtables.h>
 #include <linux/netfilter_arp/arp_tables.h>
 #include <net/netfilter/nf_tables.h>
+#include <net/netfilter/nf_log.h>
 
 /* Used for matches where *info is larger than X byte */
 #define NFT_MATCH_LARGE_THRESH 192
@@ -257,8 +258,22 @@ nft_target_init(const struct nft_ctx *ctx, const struct nft_expr *expr,
        nft_compat_wait_for_destructors();
 
        ret = xt_check_target(&par, size, proto, inv);
-       if (ret < 0)
+       if (ret < 0) {
+               if (ret == -ENOENT) {
+                       const char *modname = NULL;
+
+                       if (strcmp(target->name, "LOG") == 0)
+                               modname = "nf_log_syslog";
+                       else if (strcmp(target->name, "NFLOG") == 0)
+                               modname = "nfnetlink_log";
+
+                       if (modname &&
+                           nft_request_module(ctx->net, "%s", modname) == -EAGAIN)
+                               return -EAGAIN;
+               }
+
                return ret;
+       }
 
        /* The standard target cannot be used */
        if (!target->target)
index 0363f53..c4d1389 100644 (file)
@@ -60,7 +60,7 @@ static void nft_quota_obj_eval(struct nft_object *obj,
        if (overquota &&
            !test_and_set_bit(NFT_QUOTA_DEPLETED_BIT, &priv->flags))
                nft_obj_notify(nft_net(pkt), obj->key.table, obj, 0, 0,
-                              NFT_MSG_NEWOBJ, nft_pf(pkt), 0, GFP_ATOMIC);
+                              NFT_MSG_NEWOBJ, 0, nft_pf(pkt), 0, GFP_ATOMIC);
 }
 
 static int nft_quota_do_init(const struct nlattr * const tb[],
index 2ff75f7..f39244f 100644 (file)
@@ -44,6 +44,7 @@ log_tg(struct sk_buff *skb, const struct xt_action_param *par)
 static int log_tg_check(const struct xt_tgchk_param *par)
 {
        const struct xt_log_info *loginfo = par->targinfo;
+       int ret;
 
        if (par->family != NFPROTO_IPV4 && par->family != NFPROTO_IPV6)
                return -EINVAL;
@@ -58,7 +59,14 @@ static int log_tg_check(const struct xt_tgchk_param *par)
                return -EINVAL;
        }
 
-       return nf_logger_find_get(par->family, NF_LOG_TYPE_LOG);
+       ret = nf_logger_find_get(par->family, NF_LOG_TYPE_LOG);
+       if (ret != 0 && !par->nft_compat) {
+               request_module("%s", "nf_log_syslog");
+
+               ret = nf_logger_find_get(par->family, NF_LOG_TYPE_LOG);
+       }
+
+       return ret;
 }
 
 static void log_tg_destroy(const struct xt_tgdtor_param *par)
index fb57932..e660c37 100644 (file)
@@ -42,13 +42,21 @@ nflog_tg(struct sk_buff *skb, const struct xt_action_param *par)
 static int nflog_tg_check(const struct xt_tgchk_param *par)
 {
        const struct xt_nflog_info *info = par->targinfo;
+       int ret;
 
        if (info->flags & ~XT_NFLOG_MASK)
                return -EINVAL;
        if (info->prefix[sizeof(info->prefix) - 1] != '\0')
                return -EINVAL;
 
-       return nf_logger_find_get(par->family, NF_LOG_TYPE_ULOG);
+       ret = nf_logger_find_get(par->family, NF_LOG_TYPE_ULOG);
+       if (ret != 0 && !par->nft_compat) {
+               request_module("%s", "nfnetlink_log");
+
+               ret = nf_logger_find_get(par->family, NF_LOG_TYPE_ULOG);
+       }
+
+       return ret;
 }
 
 static void nflog_tg_destroy(const struct xt_tgdtor_param *par)
index 24b7cf4..ada47e5 100644 (file)
@@ -594,7 +594,10 @@ static int netlink_insert(struct sock *sk, u32 portid)
 
        /* We need to ensure that the socket is hashed and visible. */
        smp_wmb();
-       nlk_sk(sk)->bound = portid;
+       /* Paired with lockless reads from netlink_bind(),
+        * netlink_connect() and netlink_sendmsg().
+        */
+       WRITE_ONCE(nlk_sk(sk)->bound, portid);
 
 err:
        release_sock(sk);
@@ -1012,7 +1015,8 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
        if (nlk->ngroups < BITS_PER_LONG)
                groups &= (1UL << nlk->ngroups) - 1;
 
-       bound = nlk->bound;
+       /* Paired with WRITE_ONCE() in netlink_insert() */
+       bound = READ_ONCE(nlk->bound);
        if (bound) {
                /* Ensure nlk->portid is up-to-date. */
                smp_rmb();
@@ -1098,8 +1102,9 @@ static int netlink_connect(struct socket *sock, struct sockaddr *addr,
 
        /* No need for barriers here as we return to user-space without
         * using any of the bound attributes.
+        * Paired with WRITE_ONCE() in netlink_insert().
         */
-       if (!nlk->bound)
+       if (!READ_ONCE(nlk->bound))
                err = netlink_autobind(sock);
 
        if (err == 0) {
@@ -1888,7 +1893,8 @@ static int netlink_sendmsg(struct socket *sock, struct msghdr *msg, size_t len)
                dst_group = nlk->dst_group;
        }
 
-       if (!nlk->bound) {
+       /* Paired with WRITE_ONCE() in netlink_insert() */
+       if (!READ_ONCE(nlk->bound)) {
                err = netlink_autobind(sock);
                if (err)
                        goto out;
index 6024fad..dda323e 100644 (file)
@@ -60,6 +60,9 @@ int nfc_proto_register(const struct nfc_protocol *nfc_proto)
                proto_tab[nfc_proto->id] = nfc_proto;
        write_unlock(&proto_tab_lock);
 
+       if (rc)
+               proto_unregister(nfc_proto->proto);
+
        return rc;
 }
 EXPORT_SYMBOL(nfc_proto_register);
index fefc036..d63d2e5 100644 (file)
@@ -277,6 +277,7 @@ int digital_tg_configure_hw(struct nfc_digital_dev *ddev, int type, int param)
 static int digital_tg_listen_mdaa(struct nfc_digital_dev *ddev, u8 rf_tech)
 {
        struct digital_tg_mdaa_params *params;
+       int rc;
 
        params = kzalloc(sizeof(*params), GFP_KERNEL);
        if (!params)
@@ -291,8 +292,12 @@ static int digital_tg_listen_mdaa(struct nfc_digital_dev *ddev, u8 rf_tech)
        get_random_bytes(params->nfcid2 + 2, NFC_NFCID2_MAXSIZE - 2);
        params->sc = DIGITAL_SENSF_FELICA_SC;
 
-       return digital_send_cmd(ddev, DIGITAL_CMD_TG_LISTEN_MDAA, NULL, params,
-                               500, digital_tg_recv_atr_req, NULL);
+       rc = digital_send_cmd(ddev, DIGITAL_CMD_TG_LISTEN_MDAA, NULL, params,
+                             500, digital_tg_recv_atr_req, NULL);
+       if (rc)
+               kfree(params);
+
+       return rc;
 }
 
 static int digital_tg_listen_md(struct nfc_digital_dev *ddev, u8 rf_tech)
index 84d2345..3adf458 100644 (file)
@@ -465,8 +465,12 @@ static int digital_in_send_sdd_req(struct nfc_digital_dev *ddev,
        skb_put_u8(skb, sel_cmd);
        skb_put_u8(skb, DIGITAL_SDD_REQ_SEL_PAR);
 
-       return digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res,
-                                  target);
+       rc = digital_in_send_cmd(ddev, skb, 30, digital_in_recv_sdd_res,
+                                target);
+       if (rc)
+               kfree_skb(skb);
+
+       return rc;
 }
 
 static void digital_in_recv_sens_res(struct nfc_digital_dev *ddev, void *arg,
index a2e72c0..b911ab7 100644 (file)
@@ -334,6 +334,8 @@ static void nci_core_conn_close_rsp_packet(struct nci_dev *ndev,
                                                         ndev->cur_conn_id);
                if (conn_info) {
                        list_del(&conn_info->list);
+                       if (conn_info == ndev->rf_conn_info)
+                               ndev->rf_conn_info = NULL;
                        devm_kfree(&ndev->nfc_dev->dev, conn_info);
                }
        }
index 543365f..2a2bc64 100644 (file)
@@ -46,6 +46,8 @@
  *                                     Copyright (C) 2011, <lokec@ccs.neu.edu>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/ethtool.h>
 #include <linux/types.h>
 #include <linux/mm.h>
index 23b2125..eb6345a 100644 (file)
@@ -2188,18 +2188,24 @@ static void fl_walk(struct tcf_proto *tp, struct tcf_walker *arg,
 
        arg->count = arg->skip;
 
+       rcu_read_lock();
        idr_for_each_entry_continue_ul(&head->handle_idr, f, tmp, id) {
                /* don't return filters that are being deleted */
                if (!refcount_inc_not_zero(&f->refcnt))
                        continue;
+               rcu_read_unlock();
+
                if (arg->fn(tp, f, arg) < 0) {
                        __fl_put(f);
                        arg->stop = 1;
+                       rcu_read_lock();
                        break;
                }
                __fl_put(f);
                arg->count++;
+               rcu_read_lock();
        }
+       rcu_read_unlock();
        arg->cookie = id;
 }
 
index 5e90e9b..12f39a2 100644 (file)
@@ -513,6 +513,12 @@ static struct qdisc_size_table *qdisc_get_stab(struct nlattr *opt,
                return stab;
        }
 
+       if (s->size_log > STAB_SIZE_LOG_MAX ||
+           s->cell_log > STAB_SIZE_LOG_MAX) {
+               NL_SET_ERR_MSG(extack, "Invalid logarithmic size of size table");
+               return ERR_PTR(-EINVAL);
+       }
+
        stab = kmalloc(sizeof(*stab) + tsize * sizeof(u16), GFP_KERNEL);
        if (!stab)
                return ERR_PTR(-ENOMEM);
index a579a41..e104042 100644 (file)
@@ -233,6 +233,9 @@ int fifo_set_limit(struct Qdisc *q, unsigned int limit)
        if (strncmp(q->ops->id + 1, "fifo", 4) != 0)
                return 0;
 
+       if (!q->ops->change)
+               return 0;
+
        nla = kmalloc(nla_attr_size(sizeof(struct tc_fifo_qopt)), GFP_KERNEL);
        if (nla) {
                nla->nla_type = RTM_NEWQDISC;
index 8766ab5..5eb3b1b 100644 (file)
@@ -529,22 +529,28 @@ static int mqprio_dump_class_stats(struct Qdisc *sch, unsigned long cl,
                for (i = tc.offset; i < tc.offset + tc.count; i++) {
                        struct netdev_queue *q = netdev_get_tx_queue(dev, i);
                        struct Qdisc *qdisc = rtnl_dereference(q->qdisc);
-                       struct gnet_stats_basic_cpu __percpu *cpu_bstats = NULL;
-                       struct gnet_stats_queue __percpu *cpu_qstats = NULL;
 
                        spin_lock_bh(qdisc_lock(qdisc));
+
                        if (qdisc_is_percpu_stats(qdisc)) {
-                               cpu_bstats = qdisc->cpu_bstats;
-                               cpu_qstats = qdisc->cpu_qstats;
+                               qlen = qdisc_qlen_sum(qdisc);
+
+                               __gnet_stats_copy_basic(NULL, &bstats,
+                                                       qdisc->cpu_bstats,
+                                                       &qdisc->bstats);
+                               __gnet_stats_copy_queue(&qstats,
+                                                       qdisc->cpu_qstats,
+                                                       &qdisc->qstats,
+                                                       qlen);
+                       } else {
+                               qlen            += qdisc->q.qlen;
+                               bstats.bytes    += qdisc->bstats.bytes;
+                               bstats.packets  += qdisc->bstats.packets;
+                               qstats.backlog  += qdisc->qstats.backlog;
+                               qstats.drops    += qdisc->qstats.drops;
+                               qstats.requeues += qdisc->qstats.requeues;
+                               qstats.overlimits += qdisc->qstats.overlimits;
                        }
-
-                       qlen = qdisc_qlen_sum(qdisc);
-                       __gnet_stats_copy_basic(NULL, &sch->bstats,
-                                               cpu_bstats, &qdisc->bstats);
-                       __gnet_stats_copy_queue(&sch->qstats,
-                                               cpu_qstats,
-                                               &qdisc->qstats,
-                                               qlen);
                        spin_unlock_bh(qdisc_lock(qdisc));
                }
 
index 1ab2fc9..b9fd18d 100644 (file)
@@ -1641,6 +1641,10 @@ static void taprio_destroy(struct Qdisc *sch)
        list_del(&q->taprio_list);
        spin_unlock(&taprio_list_lock);
 
+       /* Note that taprio_reset() might not be called if an error
+        * happens in qdisc_create(), after taprio_init() has been called.
+        */
+       hrtimer_cancel(&q->advance_timer);
 
        taprio_disable_offload(dev, q, NULL);
 
index 5ef86fd..1f17860 100644 (file)
@@ -702,7 +702,7 @@ static int sctp_rcv_ootb(struct sk_buff *skb)
                ch = skb_header_pointer(skb, offset, sizeof(*ch), &_ch);
 
                /* Break out if chunk length is less then minimal. */
-               if (ntohs(ch->length) < sizeof(_ch))
+               if (!ch || ntohs(ch->length) < sizeof(_ch))
                        break;
 
                ch_end = offset + SCTP_PAD4(ntohs(ch->length));
index b8fa8f1..c7503fd 100644 (file)
@@ -3697,7 +3697,7 @@ struct sctp_chunk *sctp_make_strreset_req(
        outlen = (sizeof(outreq) + stream_len) * out;
        inlen = (sizeof(inreq) + stream_len) * in;
 
-       retval = sctp_make_reconf(asoc, outlen + inlen);
+       retval = sctp_make_reconf(asoc, SCTP_PAD4(outlen) + SCTP_PAD4(inlen));
        if (!retval)
                return NULL;
 
index f23f558..99acd33 100644 (file)
@@ -150,9 +150,11 @@ static int smcr_cdc_get_slot_and_msg_send(struct smc_connection *conn)
 
 again:
        link = conn->lnk;
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_cdc_get_free_slot(conn, link, &wr_buf, NULL, &pend);
        if (rc)
-               return rc;
+               goto put_out;
 
        spin_lock_bh(&conn->send_lock);
        if (link != conn->lnk) {
@@ -160,6 +162,7 @@ again:
                spin_unlock_bh(&conn->send_lock);
                smc_wr_tx_put_slot(link,
                                   (struct smc_wr_tx_pend_priv *)pend);
+               smc_wr_tx_link_put(link);
                if (again)
                        return -ENOLINK;
                again = true;
@@ -167,6 +170,8 @@ again:
        }
        rc = smc_cdc_msg_send(conn, wr_buf, pend);
        spin_unlock_bh(&conn->send_lock);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
index e286daf..6ec1ebe 100644 (file)
@@ -230,7 +230,8 @@ static int smc_clc_prfx_set(struct socket *clcsock,
                goto out_rel;
        }
        /* get address to which the internal TCP socket is bound */
-       kernel_getsockname(clcsock, (struct sockaddr *)&addrs);
+       if (kernel_getsockname(clcsock, (struct sockaddr *)&addrs) < 0)
+               goto out_rel;
        /* analyze IP specific data of net_device belonging to TCP socket */
        addr6 = (struct sockaddr_in6 *)&addrs;
        rcu_read_lock();
index af227b6..d220674 100644 (file)
@@ -949,7 +949,7 @@ struct smc_link *smc_switch_conns(struct smc_link_group *lgr,
                to_lnk = &lgr->lnk[i];
                break;
        }
-       if (!to_lnk) {
+       if (!to_lnk || !smc_wr_tx_link_hold(to_lnk)) {
                smc_lgr_terminate_sched(lgr);
                return NULL;
        }
@@ -981,24 +981,26 @@ again:
                read_unlock_bh(&lgr->conns_lock);
                /* pre-fetch buffer outside of send_lock, might sleep */
                rc = smc_cdc_get_free_slot(conn, to_lnk, &wr_buf, NULL, &pend);
-               if (rc) {
-                       smcr_link_down_cond_sched(to_lnk);
-                       return NULL;
-               }
+               if (rc)
+                       goto err_out;
                /* avoid race with smcr_tx_sndbuf_nonempty() */
                spin_lock_bh(&conn->send_lock);
                smc_switch_link_and_count(conn, to_lnk);
                rc = smc_switch_cursor(smc, pend, wr_buf);
                spin_unlock_bh(&conn->send_lock);
                sock_put(&smc->sk);
-               if (rc) {
-                       smcr_link_down_cond_sched(to_lnk);
-                       return NULL;
-               }
+               if (rc)
+                       goto err_out;
                goto again;
        }
        read_unlock_bh(&lgr->conns_lock);
+       smc_wr_tx_link_put(to_lnk);
        return to_lnk;
+
+err_out:
+       smcr_link_down_cond_sched(to_lnk);
+       smc_wr_tx_link_put(to_lnk);
+       return NULL;
 }
 
 static void smcr_buf_unuse(struct smc_buf_desc *rmb_desc,
@@ -1474,7 +1476,9 @@ static void smc_conn_abort_work(struct work_struct *work)
                                                   abort_work);
        struct smc_sock *smc = container_of(conn, struct smc_sock, conn);
 
+       lock_sock(&smc->sk);
        smc_conn_kill(conn, true);
+       release_sock(&smc->sk);
        sock_put(&smc->sk); /* sock_hold done by schedulers of abort_work */
 }
 
index 2e7560e..72f4b72 100644 (file)
@@ -383,9 +383,11 @@ int smc_llc_send_confirm_link(struct smc_link *link,
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        confllc = (struct smc_llc_msg_confirm_link *)wr_buf;
        memset(confllc, 0, sizeof(*confllc));
        confllc->hd.common.type = SMC_LLC_CONFIRM_LINK;
@@ -402,6 +404,8 @@ int smc_llc_send_confirm_link(struct smc_link *link,
        confllc->max_links = SMC_LLC_ADD_LNK_MAX_LINKS;
        /* send llc message */
        rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
@@ -415,9 +419,11 @@ static int smc_llc_send_confirm_rkey(struct smc_link *send_link,
        struct smc_link *link;
        int i, rc, rtok_ix;
 
+       if (!smc_wr_tx_link_hold(send_link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(send_link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        rkeyllc = (struct smc_llc_msg_confirm_rkey *)wr_buf;
        memset(rkeyllc, 0, sizeof(*rkeyllc));
        rkeyllc->hd.common.type = SMC_LLC_CONFIRM_RKEY;
@@ -444,6 +450,8 @@ static int smc_llc_send_confirm_rkey(struct smc_link *send_link,
                (u64)sg_dma_address(rmb_desc->sgt[send_link->link_idx].sgl));
        /* send llc message */
        rc = smc_wr_tx_send(send_link, pend);
+put_out:
+       smc_wr_tx_link_put(send_link);
        return rc;
 }
 
@@ -456,9 +464,11 @@ static int smc_llc_send_delete_rkey(struct smc_link *link,
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        rkeyllc = (struct smc_llc_msg_delete_rkey *)wr_buf;
        memset(rkeyllc, 0, sizeof(*rkeyllc));
        rkeyllc->hd.common.type = SMC_LLC_DELETE_RKEY;
@@ -467,6 +477,8 @@ static int smc_llc_send_delete_rkey(struct smc_link *link,
        rkeyllc->rkey[0] = htonl(rmb_desc->mr_rx[link->link_idx]->rkey);
        /* send llc message */
        rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
@@ -480,9 +492,11 @@ int smc_llc_send_add_link(struct smc_link *link, u8 mac[], u8 gid[],
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        addllc = (struct smc_llc_msg_add_link *)wr_buf;
 
        memset(addllc, 0, sizeof(*addllc));
@@ -504,6 +518,8 @@ int smc_llc_send_add_link(struct smc_link *link, u8 mac[], u8 gid[],
        }
        /* send llc message */
        rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
@@ -517,9 +533,11 @@ int smc_llc_send_delete_link(struct smc_link *link, u8 link_del_id,
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        delllc = (struct smc_llc_msg_del_link *)wr_buf;
 
        memset(delllc, 0, sizeof(*delllc));
@@ -536,6 +554,8 @@ int smc_llc_send_delete_link(struct smc_link *link, u8 link_del_id,
        delllc->reason = htonl(reason);
        /* send llc message */
        rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
@@ -547,9 +567,11 @@ static int smc_llc_send_test_link(struct smc_link *link, u8 user_data[16])
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        testllc = (struct smc_llc_msg_test_link *)wr_buf;
        memset(testllc, 0, sizeof(*testllc));
        testllc->hd.common.type = SMC_LLC_TEST_LINK;
@@ -557,6 +579,8 @@ static int smc_llc_send_test_link(struct smc_link *link, u8 user_data[16])
        memcpy(testllc->user_data, user_data, sizeof(testllc->user_data));
        /* send llc message */
        rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
@@ -567,13 +591,16 @@ static int smc_llc_send_message(struct smc_link *link, void *llcbuf)
        struct smc_wr_buf *wr_buf;
        int rc;
 
-       if (!smc_link_usable(link))
+       if (!smc_wr_tx_link_hold(link))
                return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        memcpy(wr_buf, llcbuf, sizeof(union smc_llc_msg));
-       return smc_wr_tx_send(link, pend);
+       rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
+       return rc;
 }
 
 /* schedule an llc send on link, may wait for buffers,
@@ -586,13 +613,16 @@ static int smc_llc_send_message_wait(struct smc_link *link, void *llcbuf)
        struct smc_wr_buf *wr_buf;
        int rc;
 
-       if (!smc_link_usable(link))
+       if (!smc_wr_tx_link_hold(link))
                return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        memcpy(wr_buf, llcbuf, sizeof(union smc_llc_msg));
-       return smc_wr_tx_send_wait(link, pend, SMC_LLC_WAIT_TIME);
+       rc = smc_wr_tx_send_wait(link, pend, SMC_LLC_WAIT_TIME);
+put_out:
+       smc_wr_tx_link_put(link);
+       return rc;
 }
 
 /********************************* receive ***********************************/
@@ -672,9 +702,11 @@ static int smc_llc_add_link_cont(struct smc_link *link,
        struct smc_buf_desc *rmb;
        u8 n;
 
+       if (!smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_llc_add_pending_send(link, &wr_buf, &pend);
        if (rc)
-               return rc;
+               goto put_out;
        addc_llc = (struct smc_llc_msg_add_link_cont *)wr_buf;
        memset(addc_llc, 0, sizeof(*addc_llc));
 
@@ -706,7 +738,10 @@ static int smc_llc_add_link_cont(struct smc_link *link,
        addc_llc->hd.length = sizeof(struct smc_llc_msg_add_link_cont);
        if (lgr->role == SMC_CLNT)
                addc_llc->hd.flags |= SMC_LLC_FLAG_RESP;
-       return smc_wr_tx_send(link, pend);
+       rc = smc_wr_tx_send(link, pend);
+put_out:
+       smc_wr_tx_link_put(link);
+       return rc;
 }
 
 static int smc_llc_cli_rkey_exchange(struct smc_link *link,
index c79361d..738a4a9 100644 (file)
@@ -496,7 +496,7 @@ static int smc_tx_rdma_writes(struct smc_connection *conn,
 /* Wakeup sndbuf consumers from any context (IRQ or process)
  * since there is more data to transmit; usable snd_wnd as max transmit
  */
-static int _smcr_tx_sndbuf_nonempty(struct smc_connection *conn)
+static int smcr_tx_sndbuf_nonempty(struct smc_connection *conn)
 {
        struct smc_cdc_producer_flags *pflags = &conn->local_tx_ctrl.prod_flags;
        struct smc_link *link = conn->lnk;
@@ -505,8 +505,11 @@ static int _smcr_tx_sndbuf_nonempty(struct smc_connection *conn)
        struct smc_wr_buf *wr_buf;
        int rc;
 
+       if (!link || !smc_wr_tx_link_hold(link))
+               return -ENOLINK;
        rc = smc_cdc_get_free_slot(conn, link, &wr_buf, &wr_rdma_buf, &pend);
        if (rc < 0) {
+               smc_wr_tx_link_put(link);
                if (rc == -EBUSY) {
                        struct smc_sock *smc =
                                container_of(conn, struct smc_sock, conn);
@@ -547,22 +550,7 @@ static int _smcr_tx_sndbuf_nonempty(struct smc_connection *conn)
 
 out_unlock:
        spin_unlock_bh(&conn->send_lock);
-       return rc;
-}
-
-static int smcr_tx_sndbuf_nonempty(struct smc_connection *conn)
-{
-       struct smc_link *link = conn->lnk;
-       int rc = -ENOLINK;
-
-       if (!link)
-               return rc;
-
-       atomic_inc(&link->wr_tx_refcnt);
-       if (smc_link_usable(link))
-               rc = _smcr_tx_sndbuf_nonempty(conn);
-       if (atomic_dec_and_test(&link->wr_tx_refcnt))
-               wake_up_all(&link->wr_tx_wait);
+       smc_wr_tx_link_put(link);
        return rc;
 }
 
index 423b870..2bc626f 100644 (file)
@@ -60,6 +60,20 @@ static inline void smc_wr_tx_set_wr_id(atomic_long_t *wr_tx_id, long val)
        atomic_long_set(wr_tx_id, val);
 }
 
+static inline bool smc_wr_tx_link_hold(struct smc_link *link)
+{
+       if (!smc_link_usable(link))
+               return false;
+       atomic_inc(&link->wr_tx_refcnt);
+       return true;
+}
+
+static inline void smc_wr_tx_link_put(struct smc_link *link)
+{
+       if (atomic_dec_and_test(&link->wr_tx_refcnt))
+               wake_up_all(&link->wr_tx_wait);
+}
+
 static inline void smc_wr_wakeup_tx_wait(struct smc_link *lnk)
 {
        wake_up_all(&lnk->wr_tx_wait);
index 3e776e3..1f28171 100644 (file)
@@ -645,7 +645,7 @@ static bool gss_check_seq_num(const struct svc_rqst *rqstp, struct rsc *rsci,
                }
                __set_bit(seq_num % GSS_SEQ_WIN, sd->sd_win);
                goto ok;
-       } else if (seq_num <= sd->sd_max - GSS_SEQ_WIN) {
+       } else if (seq_num + GSS_SEQ_WIN <= sd->sd_max) {
                goto toolow;
        }
        if (__test_and_set_bit(seq_num % GSS_SEQ_WIN, sd->sd_win))
index a0a27d8..ad570c2 100644 (file)
@@ -2423,7 +2423,7 @@ static int tipc_sk_backlog_rcv(struct sock *sk, struct sk_buff *skb)
 static void tipc_sk_enqueue(struct sk_buff_head *inputq, struct sock *sk,
                            u32 dport, struct sk_buff_head *xmitq)
 {
-       unsigned long time_limit = jiffies + 2;
+       unsigned long time_limit = jiffies + usecs_to_jiffies(20000);
        struct sk_buff *skb;
        unsigned int lim;
        atomic_t *dcnt;
index eb47b9d..89f9e85 100644 (file)
@@ -608,20 +608,42 @@ static void unix_release_sock(struct sock *sk, int embrion)
 
 static void init_peercred(struct sock *sk)
 {
-       put_pid(sk->sk_peer_pid);
-       if (sk->sk_peer_cred)
-               put_cred(sk->sk_peer_cred);
+       const struct cred *old_cred;
+       struct pid *old_pid;
+
+       spin_lock(&sk->sk_peer_lock);
+       old_pid = sk->sk_peer_pid;
+       old_cred = sk->sk_peer_cred;
        sk->sk_peer_pid  = get_pid(task_tgid(current));
        sk->sk_peer_cred = get_current_cred();
+       spin_unlock(&sk->sk_peer_lock);
+
+       put_pid(old_pid);
+       put_cred(old_cred);
 }
 
 static void copy_peercred(struct sock *sk, struct sock *peersk)
 {
-       put_pid(sk->sk_peer_pid);
-       if (sk->sk_peer_cred)
-               put_cred(sk->sk_peer_cred);
+       const struct cred *old_cred;
+       struct pid *old_pid;
+
+       if (sk < peersk) {
+               spin_lock(&sk->sk_peer_lock);
+               spin_lock_nested(&peersk->sk_peer_lock, SINGLE_DEPTH_NESTING);
+       } else {
+               spin_lock(&peersk->sk_peer_lock);
+               spin_lock_nested(&sk->sk_peer_lock, SINGLE_DEPTH_NESTING);
+       }
+       old_pid = sk->sk_peer_pid;
+       old_cred = sk->sk_peer_cred;
        sk->sk_peer_pid  = get_pid(peersk->sk_peer_pid);
        sk->sk_peer_cred = get_cred(peersk->sk_peer_cred);
+
+       spin_unlock(&sk->sk_peer_lock);
+       spin_unlock(&peersk->sk_peer_lock);
+
+       put_pid(old_pid);
+       put_cred(old_cred);
 }
 
 static int unix_listen(struct socket *sock, int backlog)
@@ -806,7 +828,7 @@ static void unix_unhash(struct sock *sk)
 }
 
 struct proto unix_dgram_proto = {
-       .name                   = "UNIX-DGRAM",
+       .name                   = "UNIX",
        .owner                  = THIS_MODULE,
        .obj_size               = sizeof(struct unix_sock),
        .close                  = unix_close,
@@ -828,20 +850,25 @@ struct proto unix_stream_proto = {
 
 static struct sock *unix_create1(struct net *net, struct socket *sock, int kern, int type)
 {
-       struct sock *sk = NULL;
        struct unix_sock *u;
+       struct sock *sk;
+       int err;
 
        atomic_long_inc(&unix_nr_socks);
-       if (atomic_long_read(&unix_nr_socks) > 2 * get_max_files())
-               goto out;
+       if (atomic_long_read(&unix_nr_socks) > 2 * get_max_files()) {
+               err = -ENFILE;
+               goto err;
+       }
 
        if (type == SOCK_STREAM)
                sk = sk_alloc(net, PF_UNIX, GFP_KERNEL, &unix_stream_proto, kern);
        else /*dgram and  seqpacket */
                sk = sk_alloc(net, PF_UNIX, GFP_KERNEL, &unix_dgram_proto, kern);
 
-       if (!sk)
-               goto out;
+       if (!sk) {
+               err = -ENOMEM;
+               goto err;
+       }
 
        sock_init_data(sock, sk);
 
@@ -861,20 +888,23 @@ static struct sock *unix_create1(struct net *net, struct socket *sock, int kern,
        init_waitqueue_func_entry(&u->peer_wake, unix_dgram_peer_wake_relay);
        memset(&u->scm_stat, 0, sizeof(struct scm_stat));
        unix_insert_socket(unix_sockets_unbound(sk), sk);
-out:
-       if (sk == NULL)
-               atomic_long_dec(&unix_nr_socks);
-       else {
-               local_bh_disable();
-               sock_prot_inuse_add(sock_net(sk), sk->sk_prot, 1);
-               local_bh_enable();
-       }
+
+       local_bh_disable();
+       sock_prot_inuse_add(sock_net(sk), sk->sk_prot, 1);
+       local_bh_enable();
+
        return sk;
+
+err:
+       atomic_long_dec(&unix_nr_socks);
+       return ERR_PTR(err);
 }
 
 static int unix_create(struct net *net, struct socket *sock, int protocol,
                       int kern)
 {
+       struct sock *sk;
+
        if (protocol && protocol != PF_UNIX)
                return -EPROTONOSUPPORT;
 
@@ -901,7 +931,11 @@ static int unix_create(struct net *net, struct socket *sock, int protocol,
                return -ESOCKTNOSUPPORT;
        }
 
-       return unix_create1(net, sock, kern, sock->type) ? 0 : -ENOMEM;
+       sk = unix_create1(net, sock, kern, sock->type);
+       if (IS_ERR(sk))
+               return PTR_ERR(sk);
+
+       return 0;
 }
 
 static int unix_release(struct socket *sock)
@@ -1314,12 +1348,15 @@ static int unix_stream_connect(struct socket *sock, struct sockaddr *uaddr,
           we will have to recheck all again in any case.
         */
 
-       err = -ENOMEM;
-
        /* create new sock for complete connection */
        newsk = unix_create1(sock_net(sk), NULL, 0, sock->type);
-       if (newsk == NULL)
+       if (IS_ERR(newsk)) {
+               err = PTR_ERR(newsk);
+               newsk = NULL;
                goto out;
+       }
+
+       err = -ENOMEM;
 
        /* Allocate skb for sending to listening sock */
        skb = sock_wmalloc(newsk, 1, 0, GFP_KERNEL);
@@ -2845,6 +2882,9 @@ static int unix_shutdown(struct socket *sock, int mode)
 
        unix_state_lock(sk);
        sk->sk_shutdown |= mode;
+       if ((sk->sk_type == SOCK_STREAM || sk->sk_type == SOCK_SEQPACKET) &&
+           mode == SHUTDOWN_MASK)
+               sk->sk_state = TCP_CLOSE;
        other = unix_peer(sk);
        if (other)
                sock_hold(other);
@@ -2867,12 +2907,10 @@ static int unix_shutdown(struct socket *sock, int mode)
                other->sk_shutdown |= peer_mode;
                unix_state_unlock(other);
                other->sk_state_change(other);
-               if (peer_mode == SHUTDOWN_MASK) {
+               if (peer_mode == SHUTDOWN_MASK)
                        sk_wake_async(other, SOCK_WAKE_WAITD, POLL_HUP);
-                       other->sk_state = TCP_CLOSE;
-               } else if (peer_mode & RCV_SHUTDOWN) {
+               else if (peer_mode & RCV_SHUTDOWN)
                        sk_wake_async(other, SOCK_WAKE_WAITD, POLL_IN);
-               }
        }
        if (other)
                sock_put(other);
@@ -3073,7 +3111,7 @@ static __poll_t unix_dgram_poll(struct file *file, struct socket *sock,
 
                other = unix_peer(sk);
                if (other && unix_peer(other) != sk &&
-                   unix_recvq_full(other) &&
+                   unix_recvq_full_lockless(other) &&
                    unix_dgram_peer_wake_me(sk, other))
                        writable = 0;
 
index 03b66d1..3a3cb09 100644 (file)
@@ -1961,24 +1961,65 @@ static struct sk_buff *xfrm_policy_netlink(struct sk_buff *in_skb,
        return skb;
 }
 
+static int xfrm_notify_userpolicy(struct net *net)
+{
+       struct xfrm_userpolicy_default *up;
+       int len = NLMSG_ALIGN(sizeof(*up));
+       struct nlmsghdr *nlh;
+       struct sk_buff *skb;
+       int err;
+
+       skb = nlmsg_new(len, GFP_ATOMIC);
+       if (skb == NULL)
+               return -ENOMEM;
+
+       nlh = nlmsg_put(skb, 0, 0, XFRM_MSG_GETDEFAULT, sizeof(*up), 0);
+       if (nlh == NULL) {
+               kfree_skb(skb);
+               return -EMSGSIZE;
+       }
+
+       up = nlmsg_data(nlh);
+       up->in = net->xfrm.policy_default & XFRM_POL_DEFAULT_IN ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
+       up->fwd = net->xfrm.policy_default & XFRM_POL_DEFAULT_FWD ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
+       up->out = net->xfrm.policy_default & XFRM_POL_DEFAULT_OUT ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
+
+       nlmsg_end(skb, nlh);
+
+       rcu_read_lock();
+       err = xfrm_nlmsg_multicast(net, skb, 0, XFRMNLGRP_POLICY);
+       rcu_read_unlock();
+
+       return err;
+}
+
 static int xfrm_set_default(struct sk_buff *skb, struct nlmsghdr *nlh,
                            struct nlattr **attrs)
 {
        struct net *net = sock_net(skb->sk);
        struct xfrm_userpolicy_default *up = nlmsg_data(nlh);
-       u8 dirmask;
-       u8 old_default = net->xfrm.policy_default;
 
-       if (up->dirmask >= XFRM_USERPOLICY_DIRMASK_MAX)
-               return -EINVAL;
+       if (up->in == XFRM_USERPOLICY_BLOCK)
+               net->xfrm.policy_default |= XFRM_POL_DEFAULT_IN;
+       else if (up->in == XFRM_USERPOLICY_ACCEPT)
+               net->xfrm.policy_default &= ~XFRM_POL_DEFAULT_IN;
 
-       dirmask = (1 << up->dirmask) & XFRM_POL_DEFAULT_MASK;
+       if (up->fwd == XFRM_USERPOLICY_BLOCK)
+               net->xfrm.policy_default |= XFRM_POL_DEFAULT_FWD;
+       else if (up->fwd == XFRM_USERPOLICY_ACCEPT)
+               net->xfrm.policy_default &= ~XFRM_POL_DEFAULT_FWD;
 
-       net->xfrm.policy_default = (old_default & (0xff ^ dirmask))
-                                   | (up->action << up->dirmask);
+       if (up->out == XFRM_USERPOLICY_BLOCK)
+               net->xfrm.policy_default |= XFRM_POL_DEFAULT_OUT;
+       else if (up->out == XFRM_USERPOLICY_ACCEPT)
+               net->xfrm.policy_default &= ~XFRM_POL_DEFAULT_OUT;
 
        rt_genid_bump_all(net);
 
+       xfrm_notify_userpolicy(net);
        return 0;
 }
 
@@ -1988,13 +2029,11 @@ static int xfrm_get_default(struct sk_buff *skb, struct nlmsghdr *nlh,
        struct sk_buff *r_skb;
        struct nlmsghdr *r_nlh;
        struct net *net = sock_net(skb->sk);
-       struct xfrm_userpolicy_default *r_up, *up;
+       struct xfrm_userpolicy_default *r_up;
        int len = NLMSG_ALIGN(sizeof(struct xfrm_userpolicy_default));
        u32 portid = NETLINK_CB(skb).portid;
        u32 seq = nlh->nlmsg_seq;
 
-       up = nlmsg_data(nlh);
-
        r_skb = nlmsg_new(len, GFP_ATOMIC);
        if (!r_skb)
                return -ENOMEM;
@@ -2007,8 +2046,12 @@ static int xfrm_get_default(struct sk_buff *skb, struct nlmsghdr *nlh,
 
        r_up = nlmsg_data(r_nlh);
 
-       r_up->action = ((net->xfrm.policy_default & (1 << up->dirmask)) >> up->dirmask);
-       r_up->dirmask = up->dirmask;
+       r_up->in = net->xfrm.policy_default & XFRM_POL_DEFAULT_IN ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
+       r_up->fwd = net->xfrm.policy_default & XFRM_POL_DEFAULT_FWD ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
+       r_up->out = net->xfrm.policy_default & XFRM_POL_DEFAULT_OUT ?
+                       XFRM_USERPOLICY_BLOCK : XFRM_USERPOLICY_ACCEPT;
        nlmsg_end(r_skb, r_nlh);
 
        return nlmsg_unicast(net->xfrm.nlsk, r_skb, portid);
index 4dc20be..5fd48a8 100644 (file)
@@ -322,17 +322,11 @@ $(obj)/hbm_edt_kern.o: $(src)/hbm.h $(src)/hbm_kern.h
 
 -include $(BPF_SAMPLES_PATH)/Makefile.target
 
-VMLINUX_BTF_PATHS ?= $(if $(O),$(O)/vmlinux)                           \
-                    $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux)    \
-                    ../../../../vmlinux                                \
-                    /sys/kernel/btf/vmlinux                            \
-                    /boot/vmlinux-$(shell uname -r)
+VMLINUX_BTF_PATHS ?= $(abspath $(if $(O),$(O)/vmlinux))                                \
+                    $(abspath $(if $(KBUILD_OUTPUT),$(KBUILD_OUTPUT)/vmlinux)) \
+                    $(abspath ./vmlinux)
 VMLINUX_BTF ?= $(abspath $(firstword $(wildcard $(VMLINUX_BTF_PATHS))))
 
-ifeq ($(VMLINUX_BTF),)
-$(error Cannot find a vmlinux for VMLINUX_BTF at any of "$(VMLINUX_BTF_PATHS)")
-endif
-
 $(obj)/vmlinux.h: $(VMLINUX_BTF) $(BPFTOOL)
 ifeq ($(VMLINUX_H),)
        $(Q)$(BPFTOOL) btf dump file $(VMLINUX_BTF) format c > $@
@@ -340,6 +334,11 @@ else
        $(Q)cp "$(VMLINUX_H)" $@
 endif
 
+ifeq ($(VMLINUX_BTF),)
+       $(error Cannot find a vmlinux for VMLINUX_BTF at any of "$(VMLINUX_BTF_PATHS)",\
+               build the kernel or set VMLINUX_BTF variable)
+endif
+
 clean-files += vmlinux.h
 
 # Get Clang's default includes on this system, as opposed to those seen by
index aee0453..29c3bb6 100644 (file)
@@ -1,4 +1,4 @@
-/* SPDX-License-Identifier: GPL-2.0 */
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */
 /* eBPF instruction mini library */
 #ifndef __BPF_INSN_H
 #define __BPF_INSN_H
index 8f59d43..bb0a5a3 100644 (file)
@@ -5,11 +5,6 @@
 #include "xdp_sample.bpf.h"
 #include "xdp_sample_shared.h"
 
-enum {
-       BPF_F_BROADCAST         = (1ULL << 3),
-       BPF_F_EXCLUDE_INGRESS   = (1ULL << 4),
-};
-
 struct {
        __uint(type, BPF_MAP_TYPE_DEVMAP_HASH);
        __uint(key_size, sizeof(int));
index 4cce8fd..51fc23e 100644 (file)
@@ -29,7 +29,12 @@ CLANG_FLAGS  += --prefix=$(GCC_TOOLCHAIN_DIR)$(notdir $(CROSS_COMPILE))
 else
 CLANG_FLAGS    += -fintegrated-as
 endif
+# By default, clang only warns when it encounters an unknown warning flag or
+# certain optimization flags it knows it has not implemented.
+# Make it behave more like gcc by erroring when these flags are encountered
+# so they can be implemented or wrapped in cc-option.
 CLANG_FLAGS    += -Werror=unknown-warning-option
+CLANG_FLAGS    += -Werror=ignored-optimization-argument
 KBUILD_CFLAGS  += $(CLANG_FLAGS)
 KBUILD_AFLAGS  += $(CLANG_FLAGS)
 export CLANG_FLAGS
index 952e468..4aad284 100644 (file)
@@ -19,6 +19,10 @@ gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF)              \
                += -fplugin-arg-structleak_plugin-byref
 gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK_BYREF_ALL)    \
                += -fplugin-arg-structleak_plugin-byref-all
+ifdef CONFIG_GCC_PLUGIN_STRUCTLEAK
+    DISABLE_STRUCTLEAK_PLUGIN += -fplugin-arg-structleak_plugin-disable
+endif
+export DISABLE_STRUCTLEAK_PLUGIN
 gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STRUCTLEAK)              \
                += -DSTRUCTLEAK_PLUGIN
 
index 801c415..b9e94c5 100644 (file)
@@ -33,10 +33,11 @@ else
        CFLAGS_KASAN := $(CFLAGS_KASAN_SHADOW) \
         $(call cc-param,asan-globals=1) \
         $(call cc-param,asan-instrumentation-with-call-threshold=$(call_threshold)) \
-        $(call cc-param,asan-stack=$(stack_enable)) \
         $(call cc-param,asan-instrument-allocas=1)
 endif
 
+CFLAGS_KASAN += $(call cc-param,asan-stack=$(stack_enable))
+
 endif # CONFIG_KASAN_GENERIC
 
 ifdef CONFIG_KASAN_SW_TAGS
index eef56d6..48585c4 100644 (file)
@@ -13,7 +13,7 @@
 # Stage 2 is handled by this file and does the following
 # 1) Find all modules listed in modules.order
 # 2) modpost is then used to
-# 3)  create one <module>.mod.c file pr. module
+# 3)  create one <module>.mod.c file per module
 # 4)  create one Module.symvers file with CRC for all exported symbols
 
 # Step 3 is used to place certain information in the module's ELF
index b9b0f15..217d21a 100755 (executable)
@@ -34,7 +34,6 @@ REGEX_SOURCE_SYMBOL = re.compile(SOURCE_SYMBOL)
 REGEX_KCONFIG_DEF = re.compile(DEF)
 REGEX_KCONFIG_EXPR = re.compile(EXPR)
 REGEX_KCONFIG_STMT = re.compile(STMT)
-REGEX_KCONFIG_HELP = re.compile(r"^\s+help\s*$")
 REGEX_FILTER_SYMBOLS = re.compile(r"[A-Za-z0-9]$")
 REGEX_NUMERIC = re.compile(r"0[xX][0-9a-fA-F]+|[0-9]+")
 REGEX_QUOTES = re.compile("(\"(.*?)\")")
@@ -102,6 +101,9 @@ def parse_options():
                      "continue.")
 
     if args.commit:
+        if args.commit.startswith('HEAD'):
+            sys.exit("The --commit option can't use the HEAD ref")
+
         args.find = False
 
     if args.ignore:
@@ -432,7 +434,6 @@ def parse_kconfig_file(kfile):
     lines = []
     defined = []
     references = []
-    skip = False
 
     if not os.path.exists(kfile):
         return defined, references
@@ -448,12 +449,6 @@ def parse_kconfig_file(kfile):
         if REGEX_KCONFIG_DEF.match(line):
             symbol_def = REGEX_KCONFIG_DEF.findall(line)
             defined.append(symbol_def[0])
-            skip = False
-        elif REGEX_KCONFIG_HELP.match(line):
-            skip = True
-        elif skip:
-            # ignore content of help messages
-            pass
         elif REGEX_KCONFIG_STMT.match(line):
             line = REGEX_QUOTES.sub("", line)
             symbols = get_symbols_in_line(line)
index fd9777f..9dbab13 100755 (executable)
@@ -82,10 +82,8 @@ cat << EOF
 #define __IGNORE_truncate64
 #define __IGNORE_stat64
 #define __IGNORE_lstat64
-#define __IGNORE_fstat64
 #define __IGNORE_fcntl64
 #define __IGNORE_fadvise64_64
-#define __IGNORE_fstatat64
 #define __IGNORE_fstatfs64
 #define __IGNORE_statfs64
 #define __IGNORE_llseek
@@ -253,6 +251,10 @@ cat << EOF
 #define __IGNORE_getpmsg
 #define __IGNORE_putpmsg
 #define __IGNORE_vserver
+
+/* 64-bit ports never needed these, and new 32-bit ports can use statx */
+#define __IGNORE_fstat64
+#define __IGNORE_fstatat64
 EOF
 }
 
index 0033eed..1d1bde1 100755 (executable)
@@ -13,6 +13,7 @@ import logging
 import os
 import re
 import subprocess
+import sys
 
 _DEFAULT_OUTPUT = 'compile_commands.json'
 _DEFAULT_LOG_LEVEL = 'WARNING'
index 319f921..4edc708 100755 (executable)
@@ -17,13 +17,7 @@ binutils)
        echo 2.23.0
        ;;
 gcc)
-       # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63293
-       # https://lore.kernel.org/r/20210107111841.GN1551@shell.armlinux.org.uk
-       if [ "$SRCARCH" = arm64 ]; then
-               echo 5.1.0
-       else
-               echo 4.9.0
-       fi
+       echo 5.1.0
        ;;
 icc)
        # temporary
index 8f6b13a..7d631aa 100755 (executable)
@@ -189,7 +189,7 @@ if ($arch =~ /(x86(_64)?)|(i386)/) {
 $local_regex = "^[0-9a-fA-F]+\\s+t\\s+(\\S+)";
 $weak_regex = "^[0-9a-fA-F]+\\s+([wW])\\s+(\\S+)";
 $section_regex = "Disassembly of section\\s+(\\S+):";
-$function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:";
+$function_regex = "^([0-9a-fA-F]+)\\s+<([^^]*?)>:";
 $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\s(mcount|__fentry__)\$";
 $section_type = '@progbits';
 $mcount_adjust = 0;
index f355869..6ee4fa8 100644 (file)
 #define EM_ARCV2       195
 #endif
 
+#ifndef EM_RISCV
+#define EM_RISCV       243
+#endif
+
 static uint32_t (*r)(const uint32_t *);
 static uint16_t (*r2)(const uint16_t *);
 static uint64_t (*r8)(const uint64_t *);
index 6517f22..e7ebd45 100644 (file)
@@ -2157,7 +2157,7 @@ static int selinux_ptrace_access_check(struct task_struct *child,
 static int selinux_ptrace_traceme(struct task_struct *parent)
 {
        return avc_has_perm(&selinux_state,
-                           task_sid_subj(parent), task_sid_obj(current),
+                           task_sid_obj(parent), task_sid_obj(current),
                            SECCLASS_PROCESS, PROCESS__PTRACE, NULL);
 }
 
@@ -6222,7 +6222,7 @@ static int selinux_msg_queue_msgrcv(struct kern_ipc_perm *msq, struct msg_msg *m
        struct ipc_security_struct *isec;
        struct msg_security_struct *msec;
        struct common_audit_data ad;
-       u32 sid = task_sid_subj(target);
+       u32 sid = task_sid_obj(target);
        int rc;
 
        isec = selinux_ipc(msq);
index d59276f..94ea2a8 100644 (file)
@@ -126,6 +126,8 @@ static const struct nlmsg_perm nlmsg_xfrm_perms[] =
        { XFRM_MSG_NEWSPDINFO,  NETLINK_XFRM_SOCKET__NLMSG_WRITE },
        { XFRM_MSG_GETSPDINFO,  NETLINK_XFRM_SOCKET__NLMSG_READ  },
        { XFRM_MSG_MAPPING,     NETLINK_XFRM_SOCKET__NLMSG_READ  },
+       { XFRM_MSG_SETDEFAULT,  NETLINK_XFRM_SOCKET__NLMSG_WRITE },
+       { XFRM_MSG_GETDEFAULT,  NETLINK_XFRM_SOCKET__NLMSG_READ  },
 };
 
 static const struct nlmsg_perm nlmsg_audit_perms[] =
@@ -189,7 +191,7 @@ int selinux_nlmsg_lookup(u16 sclass, u16 nlmsg_type, u32 *perm)
                 * structures at the top of this file with the new mappings
                 * before updating the BUILD_BUG_ON() macro!
                 */
-               BUILD_BUG_ON(XFRM_MSG_MAX != XFRM_MSG_MAPPING);
+               BUILD_BUG_ON(XFRM_MSG_MAX != XFRM_MSG_GETDEFAULT);
                err = nlmsg_perm(nlmsg_type, perm, nlmsg_xfrm_perms,
                                 sizeof(nlmsg_xfrm_perms));
                break;
index cacbe75..21a0e7c 100644 (file)
@@ -2016,7 +2016,7 @@ static int smk_curacc_on_task(struct task_struct *p, int access,
                                const char *caller)
 {
        struct smk_audit_info ad;
-       struct smack_known *skp = smk_of_task_struct_subj(p);
+       struct smack_known *skp = smk_of_task_struct_obj(p);
        int rc;
 
        smk_ad_init(&ad, caller, LSM_AUDIT_DATA_TASK);
@@ -3480,7 +3480,7 @@ static void smack_d_instantiate(struct dentry *opt_dentry, struct inode *inode)
  */
 static int smack_getprocattr(struct task_struct *p, char *name, char **value)
 {
-       struct smack_known *skp = smk_of_task_struct_subj(p);
+       struct smack_known *skp = smk_of_task_struct_obj(p);
        char *cp;
        int slen;
 
index c9d0ba3..b9ac9e9 100644 (file)
@@ -31,6 +31,7 @@ struct config_entry {
        u16 device;
        u8 acpi_hid[ACPI_ID_LEN];
        const struct dmi_system_id *dmi_table;
+       u8 codec_hid[ACPI_ID_LEN];
 };
 
 /*
@@ -56,7 +57,7 @@ static const struct config_entry config_table[] = {
 /*
  * Apollolake (Broxton-P)
  * the legacy HDAudio driver is used except on Up Squared (SOF) and
- * Chromebooks (SST)
+ * Chromebooks (SST), as well as devices based on the ES8336 codec
  */
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_APOLLOLAKE)
        {
@@ -73,6 +74,11 @@ static const struct config_entry config_table[] = {
                        {}
                }
        },
+       {
+               .flags = FLAG_SOF,
+               .device = 0x5a98,
+               .codec_hid = "ESSX8336",
+       },
 #endif
 #if IS_ENABLED(CONFIG_SND_SOC_INTEL_APL)
        {
@@ -137,7 +143,7 @@ static const struct config_entry config_table[] = {
 
 /*
  * Geminilake uses legacy HDAudio driver except for Google
- * Chromebooks
+ * Chromebooks and devices based on the ES8336 codec
  */
 /* Geminilake */
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_GEMINILAKE)
@@ -154,6 +160,11 @@ static const struct config_entry config_table[] = {
                        {}
                }
        },
+       {
+               .flags = FLAG_SOF,
+               .device = 0x3198,
+               .codec_hid = "ESSX8336",
+       },
 #endif
 
 /*
@@ -311,6 +322,11 @@ static const struct config_entry config_table[] = {
                .flags = FLAG_SOF | FLAG_SOF_ONLY_IF_DMIC_OR_SOUNDWIRE,
                .device = 0x43c8,
        },
+       {
+               .flags = FLAG_SOF,
+               .device = 0xa0c8,
+               .codec_hid = "ESSX8336",
+       },
 #endif
 
 /* Elkhart Lake */
@@ -354,6 +370,8 @@ static const struct config_entry *snd_intel_dsp_find_config
                        continue;
                if (table->dmi_table && !dmi_check_system(table->dmi_table))
                        continue;
+               if (table->codec_hid[0] && !acpi_dev_present(table->codec_hid, NULL, -1))
+                       continue;
                return table;
        }
        return NULL;
index 49ff5e7..2c6af3f 100644 (file)
@@ -6,6 +6,7 @@ config SND_SOC_AMD_ACP
 
 config SND_SOC_AMD_CZ_DA7219MX98357_MACH
        tristate "AMD CZ support for DA7219, RT5682 and MAX9835"
+       select CLK_FIXED_FCH
        select SND_SOC_DA7219
        select SND_SOC_RT5682_I2C
        select SND_SOC_MAX98357A
@@ -30,13 +31,14 @@ config SND_SOC_AMD_ACP3x
 
 config SND_SOC_AMD_RV_RT5682_MACH
        tristate "AMD RV support for RT5682"
+       select CLK_FIXED_FCH
        select SND_SOC_RT5682_I2C
        select SND_SOC_MAX98357A
        select SND_SOC_CROS_EC_CODEC
        select I2C_CROS_EC_TUNNEL
        select SND_SOC_RT1015
        select SND_SOC_RT1015P
-       depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC
+       depends on SND_SOC_AMD_ACP3x && I2C && CROS_EC && GPIOLIB
        help
         This option enables machine driver for RT5682 and MAX9835.
 
@@ -49,7 +51,7 @@ config SND_SOC_AMD_RENOIR
 config SND_SOC_AMD_RENOIR_MACH
        tristate "AMD Renoir support for DMIC"
        select SND_SOC_DMIC
-       depends on SND_SOC_AMD_RENOIR
+       depends on SND_SOC_AMD_RENOIR && GPIOLIB
        help
         This option enables machine driver for DMIC
 
@@ -61,3 +63,37 @@ config SND_SOC_AMD_ACP5x
 
         By enabling this flag build will trigger for ACP PCI driver,
         ACP DMA driver, CPU DAI driver.
+
+config SND_SOC_AMD_VANGOGH_MACH
+       tristate "AMD Vangogh support for NAU8821 CS35L41"
+       select SND_SOC_NAU8821
+       select SND_SOC_CS35L41_SPI
+       depends on SND_SOC_AMD_ACP5x && I2C
+       help
+         This option enables machine driver for Vangogh platform
+         using NAU8821 and CS35L41 codecs.
+         Say m if you have such a device.
+         If unsure select "N".
+
+config SND_SOC_AMD_ACP6x
+       tristate "AMD Audio Coprocessor-v6.x Yellow Carp support"
+       depends on X86 && PCI
+       help
+         This option enables Audio Coprocessor i.e ACP v6.x support on
+         AMD Yellow Carp platform. By enabling this flag build will be
+         triggered for ACP PCI driver, ACP PDM DMA driver.
+         Say m if you have such a device.
+         If unsure select "N".
+
+config SND_SOC_AMD_YC_MACH
+       tristate "AMD YC support for DMIC"
+       select SND_SOC_DMIC
+       depends on SND_SOC_AMD_ACP6x
+       help
+         This option enables machine driver for Yellow Carp platform
+         using dmic. ACP IP has PDM Decoder block with DMA controller.
+         DMIC can be connected directly to ACP IP.
+         Say m if you have such a device.
+         If unsure select "N".
+
+source "sound/soc/amd/acp/Kconfig"
index 07150d2..f1d42bb 100644 (file)
@@ -11,3 +11,5 @@ obj-$(CONFIG_SND_SOC_AMD_ACP3x) += raven/
 obj-$(CONFIG_SND_SOC_AMD_RV_RT5682_MACH) += snd-soc-acp-rt5682-mach.o
 obj-$(CONFIG_SND_SOC_AMD_RENOIR) += renoir/
 obj-$(CONFIG_SND_SOC_AMD_ACP5x) += vangogh/
+obj-$(CONFIG_SND_SOC_AMD_ACP6x) += yc/
+obj-$(CONFIG_SND_SOC_AMD_ACP_COMMON) += acp/
index b3df98a..b2065f3 100644 (file)
@@ -33,7 +33,7 @@ static struct clk *da7219_dai_wclk;
 static struct clk *da7219_dai_bclk;
 static struct clk *rt5682_dai_wclk;
 static struct clk *rt5682_dai_bclk;
-extern bool bt_uart_enable;
+
 void *acp_soc_is_rltk_max(struct device *dev);
 
 static int cz_da7219_init(struct snd_soc_pcm_runtime *rtd)
@@ -760,8 +760,8 @@ static int cz_probe(struct platform_device *pdev)
                                "devm_snd_soc_register_card(%s) failed\n",
                                card->name);
        }
-       bt_uart_enable = !device_property_read_bool(&pdev->dev,
-                                                   "bt-pad-enable");
+       acp_bt_uart_enable = !device_property_read_bool(&pdev->dev,
+                                                       "bt-pad-enable");
        return 0;
 }
 
index 11b3c4f..1f322ac 100644 (file)
@@ -36,8 +36,8 @@
 #define ST_MIN_BUFFER ST_MAX_BUFFER
 
 #define DRV_NAME "acp_audio_dma"
-bool bt_uart_enable = true;
-EXPORT_SYMBOL(bt_uart_enable);
+bool acp_bt_uart_enable = true;
+EXPORT_SYMBOL(acp_bt_uart_enable);
 
 static const struct snd_pcm_hardware acp_pcm_hardware_playback = {
        .info = SNDRV_PCM_INFO_INTERLEAVED |
@@ -596,7 +596,7 @@ static int acp_init(void __iomem *acp_mmio, u32 asic_type)
        acp_reg_write(val, acp_mmio, mmACP_SOFT_RESET);
 
        /* For BT instance change pins from UART to BT */
-       if (!bt_uart_enable) {
+       if (!acp_bt_uart_enable) {
                val = acp_reg_read(acp_mmio, mmACP_BT_UART_PAD_SEL);
                val |= ACP_BT_UART_PAD_SELECT_MASK;
                acp_reg_write(val, acp_mmio, mmACP_BT_UART_PAD_SEL);
index d6ba946..6d5c547 100644 (file)
@@ -91,7 +91,7 @@ static int cz_init(struct snd_soc_pcm_runtime *rtd)
        return 0;
 }
 
-static struct snd_soc_ops cz_aif1_ops = {
+static const struct snd_soc_ops cz_aif1_ops = {
        .hw_params = cz_aif1_hw_params,
 };
 
index e5ab6c6..85529ed 100644 (file)
@@ -204,4 +204,6 @@ typedef struct acp_dma_dscr_transfer {
        u32 reserved;
 } acp_dma_dscr_transfer_t;
 
+extern bool acp_bt_uart_enable;
+
 #endif /*__ACP_HW_H */
diff --git a/sound/soc/amd/acp/Kconfig b/sound/soc/amd/acp/Kconfig
new file mode 100644 (file)
index 0000000..52a1371
--- /dev/null
@@ -0,0 +1,61 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+# This file is provided under a dual BSD/GPLv2 license. When using or
+# redistributing this file, you may do so under either license.
+#
+# Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+#
+
+config SND_SOC_AMD_ACP_COMMON
+       tristate "AMD Audio ACP Common support"
+       select SND_AMD_ACP_CONFIG
+       depends on X86 && PCI
+       help
+         This option enables common modules for Audio-Coprocessor i.e. ACP
+         IP block on AMD platforms.
+
+if SND_SOC_AMD_ACP_COMMON
+
+config SND_SOC_AMD_ACP_I2S
+       tristate
+
+config SND_SOC_AMD_ACP_PCM
+       tristate
+       select SND_SOC_ACPI if ACPI
+
+config SND_AMD_ASOC_RENOIR
+       tristate "AMD ACP ASOC Renoir Support"
+       select SND_SOC_AMD_ACP_PCM
+       select SND_SOC_AMD_ACP_I2S
+       depends on X86 && PCI
+       help
+         This option enables Renoir I2S support on AMD platform.
+
+config SND_SOC_AMD_MACH_COMMON
+       tristate
+       depends on X86 && PCI && I2C
+       select CLK_FIXED_FCH
+       select SND_SOC_RT5682_I2C
+       select SND_SOC_DMIC
+       select SND_SOC_RT1019
+       select SND_SOC_MAX98357A
+       select SND_SOC_RT5682S
+       help
+         This option enables common Machine driver module for ACP.
+
+config SND_SOC_AMD_LEGACY_MACH
+       tristate "AMD Legacy Machine Driver Support"
+       depends on X86 && PCI && I2C
+       select SND_SOC_AMD_MACH_COMMON
+       depends on X86 && PCI && I2C
+       help
+         This option enables legacy sound card support for ACP audio.
+
+config SND_SOC_AMD_SOF_MACH
+       tristate "AMD SOF Machine Driver Support"
+       depends on X86 && PCI && I2C
+       select SND_SOC_AMD_MACH_COMMON
+       depends on X86 && PCI && I2C
+       help
+         This option enables SOF sound card support for ACP audio.
+
+endif # SND_SOC_AMD_ACP_COMMON
diff --git a/sound/soc/amd/acp/Makefile b/sound/soc/amd/acp/Makefile
new file mode 100644 (file)
index 0000000..16c144c
--- /dev/null
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+# This file is provided under a dual BSD/GPLv2 license. When using or
+# redistributing this file, you may do so under either license.
+#
+# Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+
+#common acp driver
+snd-acp-pcm-objs     := acp-platform.o
+snd-acp-i2s-objs     := acp-i2s.o
+
+#platform specific driver
+snd-acp-renoir-objs     := acp-renoir.o
+
+#machine specific driver
+snd-acp-mach-objs     := acp-mach-common.o
+snd-acp-legacy-mach-objs     := acp-legacy-mach.o
+snd-acp-sof-mach-objs     := acp-sof-mach.o
+
+obj-$(CONFIG_SND_SOC_AMD_ACP_PCM) += snd-acp-pcm.o
+obj-$(CONFIG_SND_SOC_AMD_ACP_I2S) += snd-acp-i2s.o
+
+obj-$(CONFIG_SND_AMD_ASOC_RENOIR) += snd-acp-renoir.o
+
+obj-$(CONFIG_SND_SOC_AMD_MACH_COMMON) += snd-acp-mach.o
+obj-$(CONFIG_SND_SOC_AMD_LEGACY_MACH) += snd-acp-legacy-mach.o
+obj-$(CONFIG_SND_SOC_AMD_SOF_MACH) += snd-acp-sof-mach.o
diff --git a/sound/soc/amd/acp/acp-i2s.c b/sound/soc/amd/acp/acp-i2s.c
new file mode 100644 (file)
index 0000000..ce9aca8
--- /dev/null
@@ -0,0 +1,340 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+//
+
+/*
+ * Generic Hardware interface for ACP Audio I2S controller
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <linux/dma-mapping.h>
+
+#include "amd.h"
+
+#define DRV_NAME "acp_i2s_playcap"
+
+static int acp_i2s_hwparams(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params,
+                           struct snd_soc_dai *dai)
+{
+       struct device *dev = dai->component->dev;
+       struct acp_dev_data *adata;
+       u32 val;
+       u32 xfer_resolution;
+       u32 reg_val;
+
+       adata = snd_soc_dai_get_drvdata(dai);
+
+       /* These values are as per Hardware Spec */
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_U8:
+       case SNDRV_PCM_FORMAT_S8:
+               xfer_resolution = 0x0;
+               break;
+       case SNDRV_PCM_FORMAT_S16_LE:
+               xfer_resolution = 0x02;
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               xfer_resolution = 0x04;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               xfer_resolution = 0x05;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               switch (dai->driver->id) {
+               case I2S_BT_INSTANCE:
+                       reg_val = ACP_BTTDM_ITER;
+                       break;
+               case I2S_SP_INSTANCE:
+                       reg_val = ACP_I2STDM_ITER;
+                       break;
+               default:
+                       dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                       return -EINVAL;
+               }
+       } else {
+               switch (dai->driver->id) {
+               case I2S_BT_INSTANCE:
+                       reg_val = ACP_BTTDM_IRER;
+                       break;
+               case I2S_SP_INSTANCE:
+                       reg_val = ACP_I2STDM_IRER;
+                       break;
+               default:
+                       dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                       return -EINVAL;
+               }
+       }
+
+       val = readl(adata->acp_base + reg_val);
+       val &= ~ACP3x_ITER_IRER_SAMP_LEN_MASK;
+       val = val | (xfer_resolution  << 3);
+       writel(val, adata->acp_base + reg_val);
+
+       return 0;
+}
+
+static int acp_i2s_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai)
+{
+       struct acp_stream *stream = substream->runtime->private_data;
+       struct device *dev = dai->component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       u32 val, period_bytes, reg_val, ier_val, water_val, buf_size, buf_reg;
+
+       period_bytes = frames_to_bytes(substream->runtime, substream->runtime->period_size);
+       buf_size = frames_to_bytes(substream->runtime, substream->runtime->buffer_size);
+
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+               stream->bytescount = acp_get_byte_count(adata, stream->dai_id, substream->stream);
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                       switch (dai->driver->id) {
+                       case I2S_BT_INSTANCE:
+                               water_val = ACP_BT_TX_INTR_WATERMARK_SIZE;
+                               reg_val = ACP_BTTDM_ITER;
+                               ier_val = ACP_BTTDM_IER;
+                               buf_reg = ACP_BT_TX_RINGBUFSIZE;
+                               break;
+                       case I2S_SP_INSTANCE:
+                               water_val = ACP_I2S_TX_INTR_WATERMARK_SIZE;
+                               reg_val = ACP_I2STDM_ITER;
+                               ier_val = ACP_I2STDM_IER;
+                               buf_reg = ACP_I2S_TX_RINGBUFSIZE;
+                               break;
+                       default:
+                               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                               return -EINVAL;
+                       }
+               } else {
+                       switch (dai->driver->id) {
+                       case I2S_BT_INSTANCE:
+                               water_val = ACP_BT_RX_INTR_WATERMARK_SIZE;
+                               reg_val = ACP_BTTDM_IRER;
+                               ier_val = ACP_BTTDM_IER;
+                               buf_reg = ACP_BT_RX_RINGBUFSIZE;
+                               break;
+                       case I2S_SP_INSTANCE:
+                               water_val = ACP_I2S_RX_INTR_WATERMARK_SIZE;
+                               reg_val = ACP_I2STDM_IRER;
+                               ier_val = ACP_I2STDM_IER;
+                               buf_reg = ACP_I2S_RX_RINGBUFSIZE;
+                               break;
+                       default:
+                               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                               return -EINVAL;
+                       }
+               }
+               writel(period_bytes, adata->acp_base + water_val);
+               writel(buf_size, adata->acp_base + buf_reg);
+               val = readl(adata->acp_base + reg_val);
+               val = val | BIT(0);
+               writel(val, adata->acp_base + reg_val);
+               writel(1, adata->acp_base + ier_val);
+               return 0;
+       case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                       switch (dai->driver->id) {
+                       case I2S_BT_INSTANCE:
+                               reg_val = ACP_BTTDM_ITER;
+                               break;
+                       case I2S_SP_INSTANCE:
+                               reg_val = ACP_I2STDM_ITER;
+                               break;
+                       default:
+                               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                               return -EINVAL;
+                       }
+
+               } else {
+                       switch (dai->driver->id) {
+                       case I2S_BT_INSTANCE:
+                               reg_val = ACP_BTTDM_IRER;
+                               break;
+                       case I2S_SP_INSTANCE:
+                               reg_val = ACP_I2STDM_IRER;
+                               break;
+                       default:
+                               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+                               return -EINVAL;
+                       }
+               }
+               val = readl(adata->acp_base + reg_val);
+               val = val & ~BIT(0);
+               writel(val, adata->acp_base + reg_val);
+
+               if (!(readl(adata->acp_base + ACP_BTTDM_ITER) & BIT(0)) &&
+                   !(readl(adata->acp_base + ACP_BTTDM_IRER) & BIT(0)))
+                       writel(0, adata->acp_base + ACP_BTTDM_IER);
+               if (!(readl(adata->acp_base + ACP_I2STDM_ITER) & BIT(0)) &&
+                   !(readl(adata->acp_base + ACP_I2STDM_IRER) & BIT(0)))
+                       writel(0, adata->acp_base + ACP_I2STDM_IER);
+               return 0;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int acp_i2s_prepare(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       struct device *dev = dai->component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       struct acp_stream *stream = substream->runtime->private_data;
+       u32 reg_dma_size = 0, reg_fifo_size = 0, reg_fifo_addr = 0;
+       u32 phy_addr = 0, acp_fifo_addr = 0, ext_int_ctrl;
+       unsigned int dir = substream->stream;
+
+       switch (dai->driver->id) {
+       case I2S_SP_INSTANCE:
+               if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+                       reg_dma_size = ACP_I2S_TX_DMA_SIZE;
+                       acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+                                               SP_PB_FIFO_ADDR_OFFSET;
+                       reg_fifo_addr = ACP_I2S_TX_FIFOADDR;
+                       reg_fifo_size = ACP_I2S_TX_FIFOSIZE;
+
+                       phy_addr = I2S_SP_TX_MEM_WINDOW_START + stream->reg_offset;
+                       writel(phy_addr, adata->acp_base + ACP_I2S_TX_RINGBUFADDR);
+               } else {
+                       reg_dma_size = ACP_I2S_RX_DMA_SIZE;
+                       acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+                                               SP_CAPT_FIFO_ADDR_OFFSET;
+                       reg_fifo_addr = ACP_I2S_RX_FIFOADDR;
+                       reg_fifo_size = ACP_I2S_RX_FIFOSIZE;
+                       phy_addr = I2S_SP_RX_MEM_WINDOW_START + stream->reg_offset;
+                       writel(phy_addr, adata->acp_base + ACP_I2S_RX_RINGBUFADDR);
+               }
+               break;
+       case I2S_BT_INSTANCE:
+               if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+                       reg_dma_size = ACP_BT_TX_DMA_SIZE;
+                       acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+                                               BT_PB_FIFO_ADDR_OFFSET;
+                       reg_fifo_addr = ACP_BT_TX_FIFOADDR;
+                       reg_fifo_size = ACP_BT_TX_FIFOSIZE;
+
+                       phy_addr = I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset;
+                       writel(phy_addr, adata->acp_base + ACP_BT_TX_RINGBUFADDR);
+               } else {
+                       reg_dma_size = ACP_BT_RX_DMA_SIZE;
+                       acp_fifo_addr = ACP_SRAM_PTE_OFFSET +
+                                               BT_CAPT_FIFO_ADDR_OFFSET;
+                       reg_fifo_addr = ACP_BT_RX_FIFOADDR;
+                       reg_fifo_size = ACP_BT_RX_FIFOSIZE;
+
+                       phy_addr = I2S_BT_TX_MEM_WINDOW_START + stream->reg_offset;
+                       writel(phy_addr, adata->acp_base + ACP_BT_RX_RINGBUFADDR);
+               }
+               break;
+       default:
+               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+               return -EINVAL;
+       }
+
+       writel(DMA_SIZE, adata->acp_base + reg_dma_size);
+       writel(acp_fifo_addr, adata->acp_base + reg_fifo_addr);
+       writel(FIFO_SIZE, adata->acp_base + reg_fifo_size);
+
+       ext_int_ctrl = readl(adata->acp_base + ACP_EXTERNAL_INTR_CNTL);
+       ext_int_ctrl |= BIT(I2S_RX_THRESHOLD) | BIT(BT_RX_THRESHOLD)
+                       | BIT(I2S_TX_THRESHOLD) | BIT(BT_TX_THRESHOLD);
+
+       writel(ext_int_ctrl, adata->acp_base + ACP_EXTERNAL_INTR_CNTL);
+
+       return 0;
+}
+
+static int acp_i2s_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       struct acp_stream *stream = substream->runtime->private_data;
+       struct device *dev = dai->component->dev;
+       unsigned int dir = substream->stream;
+       unsigned int irq_bit = 0;
+
+       switch (dai->driver->id) {
+       case I2S_SP_INSTANCE:
+               if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+                       irq_bit = BIT(I2S_TX_THRESHOLD);
+                       stream->pte_offset = ACP_SRAM_SP_PB_PTE_OFFSET;
+                       stream->fifo_offset = SP_PB_FIFO_ADDR_OFFSET;
+               } else {
+                       irq_bit = BIT(I2S_RX_THRESHOLD);
+                       stream->pte_offset = ACP_SRAM_SP_CP_PTE_OFFSET;
+                       stream->fifo_offset = SP_CAPT_FIFO_ADDR_OFFSET;
+               }
+               break;
+       case I2S_BT_INSTANCE:
+               if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+                       irq_bit = BIT(BT_TX_THRESHOLD);
+                       stream->pte_offset = ACP_SRAM_BT_PB_PTE_OFFSET;
+                       stream->fifo_offset = BT_PB_FIFO_ADDR_OFFSET;
+               } else {
+                       irq_bit = BIT(BT_RX_THRESHOLD);
+                       stream->pte_offset = ACP_SRAM_BT_CP_PTE_OFFSET;
+                       stream->fifo_offset = BT_CAPT_FIFO_ADDR_OFFSET;
+               }
+               break;
+       default:
+               dev_err(dev, "Invalid dai id %x\n", dai->driver->id);
+               return -EINVAL;
+       }
+
+       /* Save runtime dai configuration in stream */
+       stream->id = dai->driver->id + dir;
+       stream->dai_id = dai->driver->id;
+       stream->irq_bit = irq_bit;
+
+       return 0;
+}
+
+const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops = {
+       .startup = acp_i2s_startup,
+       .hw_params = acp_i2s_hwparams,
+       .prepare = acp_i2s_prepare,
+       .trigger = acp_i2s_trigger,
+};
+EXPORT_SYMBOL_NS_GPL(asoc_acp_cpu_dai_ops, SND_SOC_ACP_COMMON);
+
+int asoc_acp_i2s_probe(struct snd_soc_dai *dai)
+{
+       struct device *dev = dai->component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       unsigned int val;
+
+       if (!adata->acp_base) {
+               dev_err(dev, "I2S base is NULL\n");
+               return -EINVAL;
+       }
+
+       val = readl(adata->acp_base + ACP_I2S_PIN_CONFIG);
+       if (val != I2S_MODE) {
+               dev_err(dev, "I2S Mode not supported val %x\n", val);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(asoc_acp_i2s_probe, SND_SOC_ACP_COMMON);
+
+MODULE_LICENSE("Dual BSD/GPL");
+MODULE_ALIAS(DRV_NAME);
diff --git a/sound/soc/amd/acp/acp-legacy-mach.c b/sound/soc/amd/acp/acp-legacy-mach.c
new file mode 100644 (file)
index 0000000..de0f802
--- /dev/null
@@ -0,0 +1,104 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+//
+
+/*
+ * Machine Driver Legacy Support for ACP HW block
+ */
+
+#include <sound/core.h>
+#include <sound/pcm_params.h>
+#include <sound/soc-acpi.h>
+#include <sound/soc-dapm.h>
+#include <linux/module.h>
+
+#include "acp-mach.h"
+
+static struct acp_card_drvdata rt5682_rt1019_data = {
+       .hs_cpu_id = I2S_SP,
+       .amp_cpu_id = I2S_SP,
+       .dmic_cpu_id = NONE,
+       .hs_codec_id = RT5682,
+       .amp_codec_id = RT1019,
+       .dmic_codec_id = NONE,
+};
+
+static const struct snd_kcontrol_new acp_controls[] = {
+       SOC_DAPM_PIN_SWITCH("Headphone Jack"),
+       SOC_DAPM_PIN_SWITCH("Headset Mic"),
+       SOC_DAPM_PIN_SWITCH("Spk"),
+       SOC_DAPM_PIN_SWITCH("Left Spk"),
+       SOC_DAPM_PIN_SWITCH("Right Spk"),
+
+};
+
+static const struct snd_soc_dapm_widget acp_widgets[] = {
+       SND_SOC_DAPM_HP("Headphone Jack", NULL),
+       SND_SOC_DAPM_MIC("Headset Mic", NULL),
+       SND_SOC_DAPM_SPK("Spk", NULL),
+       SND_SOC_DAPM_SPK("Left Spk", NULL),
+       SND_SOC_DAPM_SPK("Right Spk", NULL),
+};
+
+static int acp_asoc_probe(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = NULL;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       if (!pdev->id_entry)
+               return -EINVAL;
+
+       card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
+       if (!card)
+               return -ENOMEM;
+
+       card->dev = dev;
+       card->owner = THIS_MODULE;
+       card->name = pdev->id_entry->name;
+       card->dapm_widgets = acp_widgets;
+       card->num_dapm_widgets = ARRAY_SIZE(acp_widgets);
+       card->controls = acp_controls;
+       card->num_controls = ARRAY_SIZE(acp_controls);
+       card->drvdata = (struct acp_card_drvdata *)pdev->id_entry->driver_data;
+
+       acp_legacy_dai_links_create(card);
+
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+       if (ret) {
+               dev_err(&pdev->dev,
+                               "devm_snd_soc_register_card(%s) failed: %d\n",
+                               card->name, ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+static const struct platform_device_id board_ids[] = {
+       {
+               .name = "rn_rt5682_rt1019",
+               .driver_data = (kernel_ulong_t)&rt5682_rt1019_data,
+       },
+       { }
+};
+static struct platform_driver acp_asoc_audio = {
+       .driver = {
+               .name = "acp_mach",
+       },
+       .probe = acp_asoc_probe,
+       .id_table = board_ids,
+};
+
+module_platform_driver(acp_asoc_audio);
+
+MODULE_IMPORT_NS(SND_SOC_AMD_MACH);
+MODULE_DESCRIPTION("ACP chrome audio support");
+MODULE_ALIAS("platform:rn_rt5682_rt1019");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/acp/acp-mach-common.c b/sound/soc/amd/acp/acp-mach-common.c
new file mode 100644 (file)
index 0000000..7785f12
--- /dev/null
@@ -0,0 +1,600 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+//         Vijendar Mukunda <Vijendar.Mukunda@amd.com>
+//
+
+/*
+ * Machine Driver Interface for ACP HW block
+ */
+
+#include <sound/core.h>
+#include <sound/jack.h>
+#include <sound/pcm_params.h>
+#include <sound/soc-dapm.h>
+#include <sound/soc.h>
+#include <linux/input.h>
+#include <linux/module.h>
+
+#include "../../codecs/rt5682.h"
+#include "../../codecs/rt1019.h"
+#include "../../codecs/rt5682s.h"
+#include "acp-mach.h"
+
+#define PCO_PLAT_CLK 48000000
+#define RT5682_PLL_FREQ (48000 * 512)
+#define DUAL_CHANNEL   2
+#define FOUR_CHANNEL   4
+
+static struct snd_soc_jack pco_jack;
+
+static const unsigned int channels[] = {
+       DUAL_CHANNEL,
+};
+
+static const unsigned int rates[] = {
+       48000,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_rates = {
+       .count = ARRAY_SIZE(rates),
+       .list  = rates,
+       .mask = 0,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_channels = {
+       .count = ARRAY_SIZE(channels),
+       .list = channels,
+       .mask = 0,
+};
+
+static int acp_clk_enable(struct acp_card_drvdata *drvdata)
+{
+       clk_set_rate(drvdata->wclk, 48000);
+       clk_set_rate(drvdata->bclk, 48000 * 64);
+
+       return clk_prepare_enable(drvdata->wclk);
+}
+
+/* Declare RT5682 codec components */
+SND_SOC_DAILINK_DEF(rt5682,
+       DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC5682:00", "rt5682-aif1")));
+
+static const struct snd_soc_dapm_route rt5682_map[] = {
+       { "Headphone Jack", NULL, "HPOL" },
+       { "Headphone Jack", NULL, "HPOR" },
+       { "IN1P", NULL, "Headset Mic" },
+};
+
+/* Define card ops for RT5682 CODEC */
+static int acp_card_rt5682_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       struct snd_soc_component *component = codec_dai->component;
+       int ret;
+
+       dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name);
+
+       if (drvdata->hs_codec_id != RT5682)
+               return -EINVAL;
+
+       ret =  snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
+                                  | SND_SOC_DAIFMT_CBP_CFP);
+       if (ret < 0) {
+               dev_err(rtd->card->dev, "Failed to set dai fmt: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_pll(codec_dai, RT5682_PLL2, RT5682_PLL2_S_MCLK,
+                                 PCO_PLAT_CLK, RT5682_PLL_FREQ);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set codec PLL: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, RT5682_SCLK_S_PLL2,
+                                    RT5682_PLL_FREQ, SND_SOC_CLOCK_IN);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set codec SYSCLK: %d\n", ret);
+               return ret;
+       }
+
+       /* Set tdm/i2s1 master bclk ratio */
+       ret = snd_soc_dai_set_bclk_ratio(codec_dai, 64);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set rt5682 tdm bclk ratio: %d\n", ret);
+               return ret;
+       }
+
+       drvdata->wclk = clk_get(component->dev, "rt5682-dai-wclk");
+       drvdata->bclk = clk_get(component->dev, "rt5682-dai-bclk");
+
+       ret = snd_soc_card_jack_new(card, "Headset Jack",
+                                   SND_JACK_HEADSET | SND_JACK_LINEOUT |
+                                   SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+                                   SND_JACK_BTN_2 | SND_JACK_BTN_3,
+                                   &pco_jack, NULL, 0);
+       if (ret) {
+               dev_err(card->dev, "HP jack creation failed %d\n", ret);
+               return ret;
+       }
+
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
+
+       ret = snd_soc_component_set_jack(component, &pco_jack, NULL);
+       if (ret) {
+               dev_err(rtd->dev, "Headset Jack call-back failed: %d\n", ret);
+               return ret;
+       }
+
+       return snd_soc_dapm_add_routes(&rtd->card->dapm, rt5682_map, ARRAY_SIZE(rt5682_map));
+}
+
+static int acp_card_hs_startup(struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       int ret;
+
+       ret =  snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
+                                  | SND_SOC_DAIFMT_CBP_CFP);
+       if (ret < 0) {
+               dev_err(rtd->card->dev, "Failed to set dai fmt: %d\n", ret);
+               return ret;
+       }
+
+       runtime->hw.channels_max = DUAL_CHANNEL;
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
+                                     &constraints_channels);
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
+                                     &constraints_rates);
+
+       ret = acp_clk_enable(drvdata);
+       if (ret < 0)
+               dev_err(rtd->card->dev, "Failed to enable HS clk: %d\n", ret);
+
+       return ret;
+}
+
+static void acp_card_shutdown(struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+
+       clk_disable_unprepare(drvdata->wclk);
+}
+
+static const struct snd_soc_ops acp_card_rt5682_ops = {
+       .startup = acp_card_hs_startup,
+       .shutdown = acp_card_shutdown,
+};
+
+/* Define RT5682S CODEC component*/
+SND_SOC_DAILINK_DEF(rt5682s,
+                   DAILINK_COMP_ARRAY(COMP_CODEC("i2c-RTL5682:00", "rt5682s-aif1")));
+
+static const struct snd_soc_dapm_route rt5682s_map[] = {
+       { "Headphone Jack", NULL, "HPOL" },
+       { "Headphone Jack", NULL, "HPOR" },
+       { "IN1P", NULL, "Headset Mic" },
+};
+
+static int acp_card_rt5682s_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       struct snd_soc_component *component = codec_dai->component;
+       int ret;
+
+       dev_info(rtd->dev, "codec dai name = %s\n", codec_dai->name);
+
+       if (drvdata->hs_codec_id != RT5682S)
+               return -EINVAL;
+
+       ret =  snd_soc_dai_set_fmt(codec_dai, SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
+                                  | SND_SOC_DAIFMT_CBP_CFP);
+       if (ret < 0) {
+               dev_err(rtd->card->dev, "Failed to set dai fmt: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_pll(codec_dai, RT5682S_PLL2, RT5682S_PLL_S_MCLK,
+                                 PCO_PLAT_CLK, RT5682_PLL_FREQ);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set codec PLL: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, RT5682S_SCLK_S_PLL2,
+                                    RT5682_PLL_FREQ, SND_SOC_CLOCK_IN);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set codec SYSCLK: %d\n", ret);
+               return ret;
+       }
+
+       /* Set tdm/i2s1 master bclk ratio */
+       ret = snd_soc_dai_set_bclk_ratio(codec_dai, 64);
+       if (ret < 0) {
+               dev_err(rtd->dev, "Failed to set rt5682 tdm bclk ratio: %d\n", ret);
+               return ret;
+       }
+
+       drvdata->wclk = clk_get(component->dev, "rt5682-dai-wclk");
+       drvdata->bclk = clk_get(component->dev, "rt5682-dai-bclk");
+
+       ret = snd_soc_card_jack_new(card, "Headset Jack",
+                                   SND_JACK_HEADSET | SND_JACK_LINEOUT |
+                                   SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+                                   SND_JACK_BTN_2 | SND_JACK_BTN_3,
+                                   &pco_jack, NULL, 0);
+       if (ret) {
+               dev_err(card->dev, "HP jack creation failed %d\n", ret);
+               return ret;
+       }
+
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
+       snd_jack_set_key(pco_jack.jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
+
+       ret = snd_soc_component_set_jack(component, &pco_jack, NULL);
+       if (ret) {
+               dev_err(rtd->dev, "Headset Jack call-back failed: %d\n", ret);
+               return ret;
+       }
+
+       return snd_soc_dapm_add_routes(&rtd->card->dapm, rt5682s_map, ARRAY_SIZE(rt5682s_map));
+}
+
+static const struct snd_soc_ops acp_card_rt5682s_ops = {
+       .startup = acp_card_hs_startup,
+       .shutdown = acp_card_shutdown,
+};
+
+/* Declare RT1019 codec components */
+SND_SOC_DAILINK_DEF(rt1019,
+       DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC1019:01", "rt1019-aif"),
+                         COMP_CODEC("i2c-10EC1019:02", "rt1019-aif")));
+
+static const struct snd_soc_dapm_route rt1019_map_lr[] = {
+       { "Left Spk", NULL, "Left SPO" },
+       { "Right Spk", NULL, "Right SPO" },
+};
+
+static struct snd_soc_codec_conf rt1019_conf[] = {
+       {
+                .dlc = COMP_CODEC_CONF("i2c-10EC1019:01"),
+                .name_prefix = "Left",
+       },
+       {
+                .dlc = COMP_CODEC_CONF("i2c-10EC1019:02"),
+                .name_prefix = "Right",
+       },
+};
+
+static int acp_card_rt1019_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+
+       if (drvdata->amp_codec_id != RT1019)
+               return -EINVAL;
+
+       return snd_soc_dapm_add_routes(&rtd->card->dapm, rt1019_map_lr,
+                                      ARRAY_SIZE(rt1019_map_lr));
+}
+
+static int acp_card_rt1019_hw_params(struct snd_pcm_substream *substream,
+                                    struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+       struct snd_soc_dai *codec_dai;
+       int srate, i, ret = 0;
+
+       srate = params_rate(params);
+
+       if (drvdata->amp_codec_id != RT1019)
+               return -EINVAL;
+
+       for_each_rtd_codec_dais(rtd, i, codec_dai) {
+               if (strcmp(codec_dai->name, "rt1019-aif"))
+                       continue;
+
+               ret = snd_soc_dai_set_pll(codec_dai, 0, RT1019_PLL_S_BCLK,
+                                         64 * srate, 256 * srate);
+               if (ret < 0)
+                       return ret;
+
+               ret = snd_soc_dai_set_sysclk(codec_dai, RT1019_SCLK_S_PLL,
+                                            256 * srate, SND_SOC_CLOCK_IN);
+               if (ret < 0)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int acp_card_amp_startup(struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+       int ret;
+
+       runtime->hw.channels_max = DUAL_CHANNEL;
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
+                                     &constraints_channels);
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
+                                     &constraints_rates);
+
+       ret = acp_clk_enable(drvdata);
+       if (ret < 0)
+               dev_err(rtd->card->dev, "Failed to enable AMP clk: %d\n", ret);
+
+       return ret;
+}
+
+static const struct snd_soc_ops acp_card_rt1019_ops = {
+       .startup = acp_card_amp_startup,
+       .shutdown = acp_card_shutdown,
+       .hw_params = acp_card_rt1019_hw_params,
+};
+
+/* Declare Maxim codec components */
+SND_SOC_DAILINK_DEF(max98360a,
+       DAILINK_COMP_ARRAY(COMP_CODEC("MX98360A:00", "HiFi")));
+
+static const struct snd_soc_dapm_route max98360a_map[] = {
+       {"Spk", NULL, "Speaker"},
+};
+
+static int acp_card_maxim_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_card *card = rtd->card;
+       struct acp_card_drvdata *drvdata = card->drvdata;
+
+       if (drvdata->amp_codec_id != MAX98360A)
+               return -EINVAL;
+
+       return snd_soc_dapm_add_routes(&rtd->card->dapm, max98360a_map,
+                                      ARRAY_SIZE(max98360a_map));
+}
+
+static const struct snd_soc_ops acp_card_maxim_ops = {
+       .startup = acp_card_amp_startup,
+       .shutdown = acp_card_shutdown,
+};
+
+/* Declare DMIC codec components */
+SND_SOC_DAILINK_DEF(dmic_codec,
+               DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec", "dmic-hifi")));
+
+/* Declare ACP CPU components */
+static struct snd_soc_dai_link_component dummy_codec[] = {
+       {
+               .name = "snd-soc-dummy",
+               .dai_name = "snd-soc-dummy-dai",
+       }
+};
+
+static struct snd_soc_dai_link_component platform_component[] = {
+       {
+                .name = "acp_asoc_renoir.0",
+       }
+};
+
+static struct snd_soc_dai_link_component sof_component[] = {
+       {
+                .name = "0000:04:00.5",
+       }
+};
+
+SND_SOC_DAILINK_DEF(i2s_sp,
+       DAILINK_COMP_ARRAY(COMP_CPU("acp-i2s-sp")));
+SND_SOC_DAILINK_DEF(sof_sp,
+       DAILINK_COMP_ARRAY(COMP_CPU("acp-sof-sp")));
+SND_SOC_DAILINK_DEF(sof_dmic,
+       DAILINK_COMP_ARRAY(COMP_CPU("acp-sof-dmic")));
+
+int acp_sofdsp_dai_links_create(struct snd_soc_card *card)
+{
+       struct snd_soc_dai_link *links;
+       struct device *dev = card->dev;
+       struct acp_card_drvdata *drv_data = card->drvdata;
+       int i = 0, num_links = 0;
+
+       if (drv_data->hs_cpu_id)
+               num_links++;
+       if (drv_data->amp_cpu_id)
+               num_links++;
+       if (drv_data->dmic_cpu_id)
+               num_links++;
+
+       links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_links, GFP_KERNEL);
+       if (!links)
+               return -ENOMEM;
+
+       if (drv_data->hs_cpu_id == I2S_SP) {
+               links[i].name = "acp-headset-codec";
+               links[i].id = HEADSET_BE_ID;
+               links[i].cpus = sof_sp;
+               links[i].num_cpus = ARRAY_SIZE(sof_sp);
+               links[i].platforms = sof_component;
+               links[i].num_platforms = ARRAY_SIZE(sof_component);
+               links[i].dpcm_playback = 1;
+               links[i].dpcm_capture = 1;
+               links[i].nonatomic = true;
+               links[i].no_pcm = 1;
+               if (!drv_data->hs_codec_id) {
+                       /* Use dummy codec if codec id not specified */
+                       links[i].codecs = dummy_codec;
+                       links[i].num_codecs = ARRAY_SIZE(dummy_codec);
+               }
+               if (drv_data->hs_codec_id == RT5682) {
+                       links[i].codecs = rt5682;
+                       links[i].num_codecs = ARRAY_SIZE(rt5682);
+                       links[i].init = acp_card_rt5682_init;
+                       links[i].ops = &acp_card_rt5682_ops;
+               }
+               if (drv_data->hs_codec_id == RT5682S) {
+                       links[i].codecs = rt5682s;
+                       links[i].num_codecs = ARRAY_SIZE(rt5682s);
+                       links[i].init = acp_card_rt5682s_init;
+                       links[i].ops = &acp_card_rt5682s_ops;
+               }
+               i++;
+       }
+
+       if (drv_data->amp_cpu_id == I2S_SP) {
+               links[i].name = "acp-amp-codec";
+               links[i].id = AMP_BE_ID;
+               links[i].cpus = sof_sp;
+               links[i].num_cpus = ARRAY_SIZE(sof_sp);
+               links[i].platforms = sof_component;
+               links[i].num_platforms = ARRAY_SIZE(sof_component);
+               links[i].dpcm_playback = 1;
+               links[i].nonatomic = true;
+               links[i].no_pcm = 1;
+               if (!drv_data->amp_codec_id) {
+                       /* Use dummy codec if codec id not specified */
+                       links[i].codecs = dummy_codec;
+                       links[i].num_codecs = ARRAY_SIZE(dummy_codec);
+               }
+               if (drv_data->amp_codec_id == RT1019) {
+                       links[i].codecs = rt1019;
+                       links[i].num_codecs = ARRAY_SIZE(rt1019);
+                       links[i].ops = &acp_card_rt1019_ops;
+                       links[i].init = acp_card_rt1019_init;
+                       card->codec_conf = rt1019_conf;
+                       card->num_configs = ARRAY_SIZE(rt1019_conf);
+               }
+               if (drv_data->amp_codec_id == MAX98360A) {
+                       links[i].codecs = max98360a;
+                       links[i].num_codecs = ARRAY_SIZE(max98360a);
+                       links[i].ops = &acp_card_maxim_ops;
+                       links[i].init = acp_card_maxim_init;
+               }
+               i++;
+       }
+
+       if (drv_data->dmic_cpu_id == DMIC) {
+               links[i].name = "acp-dmic-codec";
+               links[i].id = DMIC_BE_ID;
+               links[i].codecs = dmic_codec;
+               links[i].num_codecs = ARRAY_SIZE(dmic_codec);
+               links[i].cpus = sof_dmic;
+               links[i].num_cpus = ARRAY_SIZE(sof_dmic);
+               links[i].platforms = sof_component;
+               links[i].num_platforms = ARRAY_SIZE(sof_component);
+               links[i].dpcm_capture = 1;
+               links[i].nonatomic = true;
+               links[i].no_pcm = 1;
+       }
+
+       card->dai_link = links;
+       card->num_links = num_links;
+
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(acp_sofdsp_dai_links_create, SND_SOC_AMD_MACH);
+
+int acp_legacy_dai_links_create(struct snd_soc_card *card)
+{
+       struct snd_soc_dai_link *links;
+       struct device *dev = card->dev;
+       struct acp_card_drvdata *drv_data = card->drvdata;
+       int i = 0, num_links = 0;
+
+       if (drv_data->hs_cpu_id)
+               num_links++;
+       if (drv_data->amp_cpu_id)
+               num_links++;
+       if (drv_data->dmic_cpu_id)
+               num_links++;
+
+       links = devm_kzalloc(dev, sizeof(struct snd_soc_dai_link) * num_links, GFP_KERNEL);
+
+       if (drv_data->hs_cpu_id == I2S_SP) {
+               links[i].name = "acp-headset-codec";
+               links[i].id = HEADSET_BE_ID;
+               links[i].cpus = i2s_sp;
+               links[i].num_cpus = ARRAY_SIZE(i2s_sp);
+               links[i].platforms = platform_component;
+               links[i].num_platforms = ARRAY_SIZE(platform_component);
+               links[i].dpcm_playback = 1;
+               links[i].dpcm_capture = 1;
+               if (!drv_data->hs_codec_id) {
+                       /* Use dummy codec if codec id not specified */
+                       links[i].codecs = dummy_codec;
+                       links[i].num_codecs = ARRAY_SIZE(dummy_codec);
+               }
+               if (drv_data->hs_codec_id == RT5682) {
+                       links[i].codecs = rt5682;
+                       links[i].num_codecs = ARRAY_SIZE(rt5682);
+                       links[i].init = acp_card_rt5682_init;
+                       links[i].ops = &acp_card_rt5682_ops;
+               }
+               if (drv_data->hs_codec_id == RT5682S) {
+                       links[i].codecs = rt5682s;
+                       links[i].num_codecs = ARRAY_SIZE(rt5682s);
+                       links[i].init = acp_card_rt5682s_init;
+                       links[i].ops = &acp_card_rt5682s_ops;
+               }
+               i++;
+       }
+
+       if (drv_data->amp_cpu_id == I2S_SP) {
+               links[i].name = "acp-amp-codec";
+               links[i].id = AMP_BE_ID;
+               links[i].cpus = i2s_sp;
+               links[i].num_cpus = ARRAY_SIZE(i2s_sp);
+               links[i].platforms = platform_component;
+               links[i].num_platforms = ARRAY_SIZE(platform_component);
+               links[i].dpcm_playback = 1;
+               if (!drv_data->amp_codec_id) {
+                       /* Use dummy codec if codec id not specified */
+                       links[i].codecs = dummy_codec;
+                       links[i].num_codecs = ARRAY_SIZE(dummy_codec);
+               }
+               if (drv_data->amp_codec_id == RT1019) {
+                       links[i].codecs = rt1019;
+                       links[i].num_codecs = ARRAY_SIZE(rt1019);
+                       links[i].ops = &acp_card_rt1019_ops;
+                       links[i].init = acp_card_rt1019_init;
+                       card->codec_conf = rt1019_conf;
+                       card->num_configs = ARRAY_SIZE(rt1019_conf);
+               }
+               if (drv_data->amp_codec_id == MAX98360A) {
+                       links[i].codecs = max98360a;
+                       links[i].num_codecs = ARRAY_SIZE(max98360a);
+                       links[i].ops = &acp_card_maxim_ops;
+                       links[i].init = acp_card_maxim_init;
+               }
+       }
+
+       card->dai_link = links;
+       card->num_links = num_links;
+
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(acp_legacy_dai_links_create, SND_SOC_AMD_MACH);
+
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/acp/acp-mach.h b/sound/soc/amd/acp/acp-mach.h
new file mode 100644 (file)
index 0000000..5dc47cf
--- /dev/null
@@ -0,0 +1,57 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
+/*
+ * This file is provided under a dual BSD/GPLv2 license. When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Author: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+ */
+#ifndef __ACP_MACH_H
+#define __ACP_MACH_H
+
+#include <sound/core.h>
+#include <sound/jack.h>
+#include <sound/pcm_params.h>
+#include <sound/soc-dapm.h>
+#include <linux/input.h>
+#include <linux/module.h>
+#include <sound/soc.h>
+
+enum be_id {
+       HEADSET_BE_ID = 0,
+       AMP_BE_ID,
+       DMIC_BE_ID,
+};
+
+enum cpu_endpoints {
+       NONE = 0,
+       I2S_SP,
+       I2S_BT,
+       DMIC,
+};
+
+enum codec_endpoints {
+       DUMMY = 0,
+       RT5682,
+       RT1019,
+       MAX98360A,
+       RT5682S,
+};
+
+struct acp_card_drvdata {
+       unsigned int hs_cpu_id;
+       unsigned int amp_cpu_id;
+       unsigned int dmic_cpu_id;
+       unsigned int hs_codec_id;
+       unsigned int amp_codec_id;
+       unsigned int dmic_codec_id;
+       unsigned int dai_fmt;
+       struct clk *wclk;
+       struct clk *bclk;
+};
+
+int acp_sofdsp_dai_links_create(struct snd_soc_card *card);
+int acp_legacy_dai_links_create(struct snd_soc_card *card);
+
+#endif
diff --git a/sound/soc/amd/acp/acp-platform.c b/sound/soc/amd/acp/acp-platform.c
new file mode 100644 (file)
index 0000000..65a809e
--- /dev/null
@@ -0,0 +1,315 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+
+/*
+ * Generic interface for ACP audio blck PCM component
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <linux/pm_runtime.h>
+#include <linux/dma-mapping.h>
+
+#include "amd.h"
+
+#define DRV_NAME "acp_i2s_dma"
+
+static const struct snd_pcm_hardware acp_pcm_hardware_playback = {
+       .info = SNDRV_PCM_INFO_INTERLEAVED |
+               SNDRV_PCM_INFO_BLOCK_TRANSFER |
+               SNDRV_PCM_INFO_BATCH |
+               SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
+               SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE |  SNDRV_PCM_FMTBIT_S8 |
+                  SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+       .channels_min = 2,
+       .channels_max = 8,
+       .rates = SNDRV_PCM_RATE_8000_96000,
+       .rate_min = 8000,
+       .rate_max = 96000,
+       .buffer_bytes_max = PLAYBACK_MAX_NUM_PERIODS * PLAYBACK_MAX_PERIOD_SIZE,
+       .period_bytes_min = PLAYBACK_MIN_PERIOD_SIZE,
+       .period_bytes_max = PLAYBACK_MAX_PERIOD_SIZE,
+       .periods_min = PLAYBACK_MIN_NUM_PERIODS,
+       .periods_max = PLAYBACK_MAX_NUM_PERIODS,
+};
+
+static const struct snd_pcm_hardware acp_pcm_hardware_capture = {
+       .info = SNDRV_PCM_INFO_INTERLEAVED |
+               SNDRV_PCM_INFO_BLOCK_TRANSFER |
+               SNDRV_PCM_INFO_BATCH |
+               SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_MMAP_VALID |
+               SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                  SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+       .channels_min = 2,
+       .channels_max = 2,
+       .rates = SNDRV_PCM_RATE_8000_48000,
+       .rate_min = 8000,
+       .rate_max = 48000,
+       .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
+       .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
+       .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
+       .periods_min = CAPTURE_MIN_NUM_PERIODS,
+       .periods_max = CAPTURE_MAX_NUM_PERIODS,
+};
+
+int acp_machine_select(struct acp_dev_data *adata)
+{
+       struct snd_soc_acpi_mach *mach;
+       int size;
+
+       size = sizeof(*adata->machines);
+       mach = snd_soc_acpi_find_machine(adata->machines);
+       if (!mach) {
+               dev_err(adata->dev, "warning: No matching ASoC machine driver found\n");
+               return -EINVAL;
+       }
+
+       adata->mach_dev = platform_device_register_data(adata->dev, mach->drv_name,
+                                                       PLATFORM_DEVID_NONE, mach, size);
+       if (IS_ERR(adata->mach_dev))
+               dev_warn(adata->dev, "Unable to register Machine device\n");
+
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(acp_machine_select, SND_SOC_ACP_COMMON);
+
+static irqreturn_t i2s_irq_handler(int irq, void *data)
+{
+       struct acp_dev_data *adata = data;
+       struct acp_stream *stream;
+       u16 i2s_flag = 0;
+       u32 val, i;
+
+       if (!adata)
+               return IRQ_NONE;
+
+       val = readl(adata->acp_base + ACP_EXTERNAL_INTR_STAT);
+
+       for (i = 0; i < ACP_MAX_STREAM; i++) {
+               stream = adata->stream[i];
+               if (stream && (val & stream->irq_bit)) {
+                       writel(stream->irq_bit, adata->acp_base + ACP_EXTERNAL_INTR_STAT);
+                       snd_pcm_period_elapsed(stream->substream);
+                       i2s_flag = 1;
+                       break;
+               }
+       }
+
+       if (i2s_flag)
+               return IRQ_HANDLED;
+
+       return IRQ_NONE;
+}
+
+static void config_pte_for_stream(struct acp_dev_data *adata, struct acp_stream *stream)
+{
+       u32 pte_reg, pte_size, reg_val;
+
+       /* Use ATU base Group5 */
+       pte_reg = ACPAXI2AXI_ATU_BASE_ADDR_GRP_5;
+       pte_size =  ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5;
+       stream->reg_offset = 0x02000000;
+
+       /* Group Enable */
+       reg_val = ACP_SRAM_PTE_OFFSET;
+       writel(reg_val | BIT(31), adata->acp_base + pte_reg);
+       writel(PAGE_SIZE_4K_ENABLE,  adata->acp_base + pte_size);
+}
+
+static void config_acp_dma(struct acp_dev_data *adata, int cpu_id, int size)
+{
+       struct acp_stream *stream = adata->stream[cpu_id];
+       struct snd_pcm_substream *substream = stream->substream;
+       dma_addr_t addr = substream->dma_buffer.addr;
+       int num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
+       u32 low, high, val;
+       u16 page_idx;
+
+       val = stream->pte_offset;
+
+       for (page_idx = 0; page_idx < num_pages; page_idx++) {
+               /* Load the low address of page int ACP SRAM through SRBM */
+               low = lower_32_bits(addr);
+               high = upper_32_bits(addr);
+               writel(low, adata->acp_base + ACP_SCRATCH_REG_0 + val);
+               high |= BIT(31);
+               writel(high, adata->acp_base + ACP_SCRATCH_REG_0 + val + 4);
+
+               /* Move to next physically contiguous page */
+               val += 8;
+               addr += PAGE_SIZE;
+       }
+}
+
+static int acp_dma_open(struct snd_soc_component *component, struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_runtime, 0);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct device *dev = component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       struct acp_stream *stream;
+       int stream_id = cpu_dai->driver->id * 2 + substream->stream;
+       int ret;
+
+       stream = kzalloc(sizeof(*stream), GFP_KERNEL);
+       if (!stream)
+               return -ENOMEM;
+
+       stream->substream = substream;
+       adata->stream[stream_id] = stream;
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               runtime->hw = acp_pcm_hardware_playback;
+       else
+               runtime->hw = acp_pcm_hardware_capture;
+
+       ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
+       if (ret < 0) {
+               dev_err(component->dev, "set integer constraint failed\n");
+               kfree(stream);
+               return ret;
+       }
+       runtime->private_data = stream;
+
+       writel(1, adata->acp_base + ACP_EXTERNAL_INTR_ENB);
+
+       return ret;
+}
+
+static int acp_dma_hw_params(struct snd_soc_component *component,
+                            struct snd_pcm_substream *substream,
+                            struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
+       struct acp_dev_data *adata = snd_soc_component_get_drvdata(component);
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_runtime, 0);
+       struct acp_stream *stream = substream->runtime->private_data;
+       int stream_id = cpu_dai->driver->id * 2 + substream->stream;
+       u64 size = params_buffer_bytes(params);
+
+       /* Configure ACP DMA block with params */
+       config_pte_for_stream(adata, stream);
+       config_acp_dma(adata, stream_id, size);
+
+       return 0;
+}
+
+static snd_pcm_uframes_t acp_dma_pointer(struct snd_soc_component *component,
+                                        struct snd_pcm_substream *substream)
+{
+       struct device *dev = component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       struct acp_stream *stream = substream->runtime->private_data;
+       u32 pos, buffersize;
+       u64 bytescount;
+
+       buffersize = frames_to_bytes(substream->runtime,
+                                    substream->runtime->buffer_size);
+
+       bytescount = acp_get_byte_count(adata, stream->dai_id, substream->stream);
+
+       if (bytescount > stream->bytescount)
+               bytescount -= stream->bytescount;
+
+       pos = do_div(bytescount, buffersize);
+
+       return bytes_to_frames(substream->runtime, pos);
+}
+
+static int acp_dma_new(struct snd_soc_component *component,
+                      struct snd_soc_pcm_runtime *rtd)
+{
+       struct device *parent = component->dev->parent;
+
+       snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+                                      parent, MIN_BUFFER, MAX_BUFFER);
+       return 0;
+}
+
+static int acp_dma_mmap(struct snd_soc_component *component,
+                       struct snd_pcm_substream *substream,
+                       struct vm_area_struct *vma)
+{
+       return snd_pcm_lib_default_mmap(substream, vma);
+}
+
+static int acp_dma_close(struct snd_soc_component *component,
+                        struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *soc_runtime = asoc_substream_to_rtd(substream);
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_runtime, 0);
+       struct device *dev = component->dev;
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       struct acp_stream *stream;
+       int stream_id = cpu_dai->driver->id * 2 + substream->stream;
+
+       stream = adata->stream[stream_id];
+       kfree(stream);
+       adata->stream[stream_id] = NULL;
+
+       return 0;
+}
+
+static const struct snd_soc_component_driver acp_pcm_component = {
+       .name           = DRV_NAME,
+       .open           = acp_dma_open,
+       .close          = acp_dma_close,
+       .hw_params      = acp_dma_hw_params,
+       .pointer        = acp_dma_pointer,
+       .mmap           = acp_dma_mmap,
+       .pcm_construct  = acp_dma_new,
+};
+
+int acp_platform_register(struct device *dev)
+{
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+       struct snd_soc_dai_driver;
+       unsigned int status;
+
+       status = devm_request_irq(dev, adata->i2s_irq, i2s_irq_handler,
+                                 IRQF_SHARED, "ACP_I2S_IRQ", adata);
+       if (status) {
+               dev_err(dev, "ACP I2S IRQ request failed\n");
+               return status;
+       }
+
+       status = devm_snd_soc_register_component(dev, &acp_pcm_component,
+                                                adata->dai_driver,
+                                                adata->num_dai);
+       if (status) {
+               dev_err(dev, "Fail to register acp i2s component\n");
+               return status;
+       }
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(acp_platform_register, SND_SOC_ACP_COMMON);
+
+int acp_platform_unregister(struct device *dev)
+{
+       struct acp_dev_data *adata = dev_get_drvdata(dev);
+
+       if (adata->mach_dev)
+               platform_device_unregister(adata->mach_dev);
+       return 0;
+}
+EXPORT_SYMBOL_NS_GPL(acp_platform_unregister, SND_SOC_ACP_COMMON);
+
+MODULE_DESCRIPTION("AMD ACP PCM Driver");
+MODULE_LICENSE("Dual BSD/GPL");
+MODULE_ALIAS(DRV_NAME);
diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c
new file mode 100644 (file)
index 0000000..9b321a0
--- /dev/null
@@ -0,0 +1,163 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+//
+
+/*
+ * Hardware interface for Renoir ACP block
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <linux/dma-mapping.h>
+
+#include "amd.h"
+
+#define DRV_NAME "acp_asoc_renoir"
+
+static struct snd_soc_acpi_codecs amp_rt1019 = {
+       .num_codecs = 1,
+       .codecs = {"10EC1019"}
+};
+
+static struct snd_soc_acpi_mach snd_soc_acpi_amd_acp_machines[] = {
+       {
+               .id = "10EC5682",
+               .drv_name = "rn_rt5682_rt1019",
+               .machine_quirk = snd_soc_acpi_codec_list,
+               .quirk_data = &amp_rt1019,
+       },
+       {
+               .id = "AMDI1019",
+               .drv_name = "renoir-acp",
+       },
+       {},
+};
+
+static struct snd_soc_dai_driver acp_renoir_dai[] = {
+{
+       .name = "acp-i2s-sp",
+       .id = I2S_SP_INSTANCE,
+       .playback = {
+               .stream_name = "I2S SP Playback",
+               .rates = SNDRV_PCM_RATE_8000_96000,
+               .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                          SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S32_LE,
+               .channels_min = 2,
+               .channels_max = 8,
+               .rate_min = 8000,
+               .rate_max = 96000,
+       },
+       .capture = {
+               .stream_name = "I2S SP Capture",
+               .rates = SNDRV_PCM_RATE_8000_48000,
+               .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                          SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S32_LE,
+               .channels_min = 2,
+               .channels_max = 2,
+               .rate_min = 8000,
+               .rate_max = 48000,
+       },
+       .ops = &asoc_acp_cpu_dai_ops,
+       .probe = &asoc_acp_i2s_probe,
+},
+{
+       .name = "acp-i2s-bt",
+       .id = I2S_BT_INSTANCE,
+       .playback = {
+               .stream_name = "I2S BT Playback",
+               .rates = SNDRV_PCM_RATE_8000_96000,
+               .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                          SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S32_LE,
+               .channels_min = 2,
+               .channels_max = 8,
+               .rate_min = 8000,
+               .rate_max = 96000,
+       },
+       .capture = {
+               .stream_name = "I2S BT Capture",
+               .rates = SNDRV_PCM_RATE_8000_48000,
+               .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S8 |
+                          SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S32_LE,
+               .channels_min = 2,
+               .channels_max = 2,
+               .rate_min = 8000,
+               .rate_max = 48000,
+       },
+       .ops = &asoc_acp_cpu_dai_ops,
+       .probe = &asoc_acp_i2s_probe,
+},
+};
+
+static int renoir_audio_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct acp_dev_data *adata;
+       struct resource *res;
+
+       adata = devm_kzalloc(dev, sizeof(struct acp_dev_data), GFP_KERNEL);
+       if (!adata)
+               return -ENOMEM;
+
+       res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "acp_mem");
+       if (!res) {
+               dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
+               return -ENODEV;
+       }
+
+       adata->acp_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+       if (!adata->acp_base)
+               return -ENOMEM;
+
+       res = platform_get_resource_byname(pdev, IORESOURCE_IRQ, "acp_dai_irq");
+       if (!res) {
+               dev_err(&pdev->dev, "IORESOURCE_IRQ FAILED\n");
+               return -ENODEV;
+       }
+
+       adata->i2s_irq = res->start;
+       adata->dev = dev;
+       adata->dai_driver = acp_renoir_dai;
+       adata->num_dai = ARRAY_SIZE(acp_renoir_dai);
+
+       adata->machines = snd_soc_acpi_amd_acp_machines;
+       acp_machine_select(adata);
+
+       dev_set_drvdata(dev, adata);
+       acp_platform_register(dev);
+
+       return 0;
+}
+
+static int renoir_audio_remove(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+
+       acp_platform_unregister(dev);
+       return 0;
+}
+
+static struct platform_driver renoir_driver = {
+       .probe = renoir_audio_probe,
+       .remove = renoir_audio_remove,
+       .driver = {
+               .name = "acp_asoc_renoir",
+       },
+};
+
+module_platform_driver(renoir_driver);
+
+MODULE_DESCRIPTION("AMD ACP Renoir Driver");
+MODULE_IMPORT_NS(SND_SOC_ACP_COMMON);
+MODULE_LICENSE("Dual BSD/GPL");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/sound/soc/amd/acp/acp-sof-mach.c b/sound/soc/amd/acp/acp-sof-mach.c
new file mode 100644 (file)
index 0000000..854eb72
--- /dev/null
@@ -0,0 +1,131 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license. When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2021 Advanced Micro Devices, Inc.
+//
+// Authors: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+//
+
+/*
+ * SOF Machine Driver Support for ACP HW block
+ */
+
+#include <sound/core.h>
+#include <sound/pcm_params.h>
+#include <sound/soc-acpi.h>
+#include <sound/soc-dapm.h>
+#include <linux/module.h>
+
+#include "acp-mach.h"
+
+static struct acp_card_drvdata sof_rt5682_rt1019_data = {
+       .hs_cpu_id = I2S_SP,
+       .amp_cpu_id = I2S_SP,
+       .dmic_cpu_id = DMIC,
+       .hs_codec_id = RT5682,
+       .amp_codec_id = RT1019,
+       .dmic_codec_id = DMIC,
+};
+
+static struct acp_card_drvdata sof_rt5682_max_data = {
+       .hs_cpu_id = I2S_SP,
+       .amp_cpu_id = I2S_SP,
+       .dmic_cpu_id = DMIC,
+       .hs_codec_id = RT5682,
+       .amp_codec_id = MAX98360A,
+       .dmic_codec_id = DMIC,
+};
+
+static struct acp_card_drvdata sof_rt5682s_max_data = {
+       .hs_cpu_id = I2S_SP,
+       .amp_cpu_id = I2S_SP,
+       .dmic_cpu_id = DMIC,
+       .hs_codec_id = RT5682S,
+       .amp_codec_id = MAX98360A,
+       .dmic_codec_id = DMIC,
+};
+
+static const struct snd_kcontrol_new acp_controls[] = {
+       SOC_DAPM_PIN_SWITCH("Headphone Jack"),
+       SOC_DAPM_PIN_SWITCH("Headset Mic"),
+       SOC_DAPM_PIN_SWITCH("Spk"),
+       SOC_DAPM_PIN_SWITCH("Left Spk"),
+       SOC_DAPM_PIN_SWITCH("Right Spk"),
+};
+
+static const struct snd_soc_dapm_widget acp_widgets[] = {
+       SND_SOC_DAPM_HP("Headphone Jack", NULL),
+       SND_SOC_DAPM_MIC("Headset Mic", NULL),
+       SND_SOC_DAPM_SPK("Spk", NULL),
+       SND_SOC_DAPM_SPK("Left Spk", NULL),
+       SND_SOC_DAPM_SPK("Right Spk", NULL),
+};
+
+static int acp_sof_probe(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = NULL;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       if (!pdev->id_entry)
+               return -EINVAL;
+
+       card = devm_kzalloc(dev, sizeof(*card), GFP_KERNEL);
+       if (!card)
+               return -ENOMEM;
+
+       card->dev = dev;
+       card->owner = THIS_MODULE;
+       card->name = pdev->id_entry->name;
+       card->dapm_widgets = acp_widgets;
+       card->num_dapm_widgets = ARRAY_SIZE(acp_widgets);
+       card->controls = acp_controls;
+       card->num_controls = ARRAY_SIZE(acp_controls);
+       card->drvdata = (struct acp_card_drvdata *)pdev->id_entry->driver_data;
+
+       acp_sofdsp_dai_links_create(card);
+
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+       if (ret) {
+               dev_err(&pdev->dev,
+                               "devm_snd_soc_register_card(%s) failed: %d\n",
+                               card->name, ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+static const struct platform_device_id board_ids[] = {
+       {
+               .name = "rt5682-rt1019",
+               .driver_data = (kernel_ulong_t)&sof_rt5682_rt1019_data
+       },
+       {
+               .name = "rt5682-max",
+               .driver_data = (kernel_ulong_t)&sof_rt5682_max_data
+       },
+       {
+               .name = "rt5682s-max",
+               .driver_data = (kernel_ulong_t)&sof_rt5682s_max_data
+       },
+       { }
+};
+static struct platform_driver acp_asoc_audio = {
+       .driver = {
+               .name = "sof_mach",
+       },
+       .probe = acp_sof_probe,
+       .id_table = board_ids,
+};
+
+module_platform_driver(acp_asoc_audio);
+
+MODULE_IMPORT_NS(SND_SOC_AMD_MACH);
+MODULE_DESCRIPTION("ACP chrome SOF audio support");
+MODULE_ALIAS("platform:rt5682-rt1019");
+MODULE_ALIAS("platform:rt5682-max");
+MODULE_ALIAS("platform:rt5682s-max");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/amd/acp/amd.h b/sound/soc/amd/acp/amd.h
new file mode 100644 (file)
index 0000000..8eee3d3
--- /dev/null
@@ -0,0 +1,145 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
+/*
+ * This file is provided under a dual BSD/GPLv2 license. When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Author: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+ */
+
+#ifndef __AMD_ACP_H
+#define __AMD_ACP_H
+
+#include <sound/pcm.h>
+#include <sound/soc-acpi.h>
+#include "chip_offset_byte.h"
+
+#define I2S_SP_INSTANCE                        0x00
+#define I2S_BT_INSTANCE                        0x01
+
+#define MEM_WINDOW_START               0x4000000
+
+#define ACP_I2S_REG_START              0x1242400
+#define ACP_I2S_REG_END                        0x1242810
+#define ACP3x_I2STDM_REG_START         0x1242400
+#define ACP3x_I2STDM_REG_END           0x1242410
+#define ACP3x_BT_TDM_REG_START         0x1242800
+#define ACP3x_BT_TDM_REG_END           0x1242810
+#define I2S_MODE                       0x04
+#define I2S_RX_THRESHOLD               27
+#define I2S_TX_THRESHOLD               28
+#define BT_TX_THRESHOLD                        26
+#define BT_RX_THRESHOLD                        25
+
+#define ACP_SRAM_PTE_OFFSET            0x02052800
+
+#define ACP_SRAM_SP_PB_PTE_OFFSET      0x0
+#define ACP_SRAM_SP_CP_PTE_OFFSET      0x100
+#define ACP_SRAM_BT_PB_PTE_OFFSET      0x200
+#define ACP_SRAM_BT_CP_PTE_OFFSET      0x300
+#define PAGE_SIZE_4K_ENABLE            0x2
+
+#define I2S_SP_TX_MEM_WINDOW_START     0x4000000
+#define I2S_SP_RX_MEM_WINDOW_START     0x4020000
+#define I2S_BT_TX_MEM_WINDOW_START     0x4040000
+#define I2S_BT_RX_MEM_WINDOW_START     0x4060000
+
+#define SP_PB_FIFO_ADDR_OFFSET         0x500
+#define SP_CAPT_FIFO_ADDR_OFFSET       0x700
+#define BT_PB_FIFO_ADDR_OFFSET         0x900
+#define BT_CAPT_FIFO_ADDR_OFFSET       0xB00
+#define PLAYBACK_MIN_NUM_PERIODS       2
+#define PLAYBACK_MAX_NUM_PERIODS       8
+#define PLAYBACK_MAX_PERIOD_SIZE       8192
+#define PLAYBACK_MIN_PERIOD_SIZE       1024
+#define CAPTURE_MIN_NUM_PERIODS                2
+#define CAPTURE_MAX_NUM_PERIODS                8
+#define CAPTURE_MAX_PERIOD_SIZE                8192
+#define CAPTURE_MIN_PERIOD_SIZE                1024
+
+#define MAX_BUFFER                     65536
+#define MIN_BUFFER                     MAX_BUFFER
+#define FIFO_SIZE                      0x100
+#define DMA_SIZE                       0x40
+#define FRM_LEN                                0x100
+
+#define ACP3x_ITER_IRER_SAMP_LEN_MASK  0x38
+
+#define ACP_MAX_STREAM                 6
+
+struct acp_stream {
+       struct snd_pcm_substream *substream;
+       int irq_bit;
+       int dai_id;
+       int id;
+       u64 bytescount;
+       u32 reg_offset;
+       u32 pte_offset;
+       u32 fifo_offset;
+};
+
+struct acp_dev_data {
+       char *name;
+       struct device *dev;
+       void __iomem *acp_base;
+       unsigned int i2s_irq;
+
+       /* SOC specific dais */
+       struct snd_soc_dai_driver *dai_driver;
+       int num_dai;
+
+       struct acp_stream *stream[ACP_MAX_STREAM];
+
+       struct snd_soc_acpi_mach *machines;
+       struct platform_device *mach_dev;
+};
+
+extern const struct snd_soc_dai_ops asoc_acp_cpu_dai_ops;
+
+int asoc_acp_i2s_probe(struct snd_soc_dai *dai);
+int acp_platform_register(struct device *dev);
+int acp_platform_unregister(struct device *dev);
+
+int acp_machine_select(struct acp_dev_data *adata);
+
+static inline u64 acp_get_byte_count(struct acp_dev_data *adata, int dai_id, int direction)
+{
+       u64 byte_count, low = 0, high = 0;
+
+       if (direction == SNDRV_PCM_STREAM_PLAYBACK) {
+               switch (dai_id) {
+               case I2S_BT_INSTANCE:
+                       high = readl(adata->acp_base + ACP_BT_TX_LINEARPOSITIONCNTR_HIGH);
+                       low = readl(adata->acp_base + ACP_BT_TX_LINEARPOSITIONCNTR_LOW);
+                       break;
+               case I2S_SP_INSTANCE:
+                       high = readl(adata->acp_base + ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH);
+                       low = readl(adata->acp_base + ACP_I2S_TX_LINEARPOSITIONCNTR_LOW);
+                       break;
+               default:
+                       dev_err(adata->dev, "Invalid dai id %x\n", dai_id);
+                       return -EINVAL;
+               }
+       } else {
+               switch (dai_id) {
+               case I2S_BT_INSTANCE:
+                       high = readl(adata->acp_base + ACP_BT_RX_LINEARPOSITIONCNTR_HIGH);
+                       low = readl(adata->acp_base + ACP_BT_RX_LINEARPOSITIONCNTR_LOW);
+                       break;
+               case I2S_SP_INSTANCE:
+                       high = readl(adata->acp_base + ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH);
+                       low = readl(adata->acp_base + ACP_I2S_RX_LINEARPOSITIONCNTR_LOW);
+                       break;
+               default:
+                       dev_err(adata->dev, "Invalid dai id %x\n", dai_id);
+                       return -EINVAL;
+               }
+       }
+       /* Get 64 bit value from two 32 bit registers */
+       byte_count = (high << 32) | low;
+
+       return byte_count;
+}
+
+#endif
diff --git a/sound/soc/amd/acp/chip_offset_byte.h b/sound/soc/amd/acp/chip_offset_byte.h
new file mode 100644 (file)
index 0000000..c7f77e9
--- /dev/null
@@ -0,0 +1,76 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
+/*
+ * This file is provided under a dual BSD/GPLv2 license. When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * Copyright(c) 2021 Advanced Micro Devices, Inc. All rights reserved.
+ *
+ * Author: Ajit Kumar Pandey <AjitKumar.Pandey@amd.com>
+ */
+
+#ifndef _ACP_IP_OFFSET_HEADER
+#define _ACP_IP_OFFSET_HEADER
+
+#define ACPAXI2AXI_ATU_CTRL                           0xC40
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5                0xC20
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5                0xC24
+#define ACP_EXTERNAL_INTR_ENB                         0x1800
+#define ACP_EXTERNAL_INTR_CNTL                        0x1804
+#define ACP_EXTERNAL_INTR_STAT                        0x1808
+#define ACP_I2S_PIN_CONFIG                            0x1400
+#define ACP_SCRATCH_REG_0                             0x12800
+
+/* Registers from ACP_AUDIO_BUFFERS block */
+
+#define ACP_I2S_RX_RINGBUFADDR                        0x2000
+#define ACP_I2S_RX_RINGBUFSIZE                        0x2004
+#define ACP_I2S_RX_LINKPOSITIONCNTR                   0x2008
+#define ACP_I2S_RX_FIFOADDR                           0x200C
+#define ACP_I2S_RX_FIFOSIZE                           0x2010
+#define ACP_I2S_RX_DMA_SIZE                           0x2014
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH            0x2018
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW             0x201C
+#define ACP_I2S_RX_INTR_WATERMARK_SIZE                0x2020
+#define ACP_I2S_TX_RINGBUFADDR                        0x2024
+#define ACP_I2S_TX_RINGBUFSIZE                        0x2028
+#define ACP_I2S_TX_LINKPOSITIONCNTR                   0x202C
+#define ACP_I2S_TX_FIFOADDR                           0x2030
+#define ACP_I2S_TX_FIFOSIZE                           0x2034
+#define ACP_I2S_TX_DMA_SIZE                           0x2038
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH            0x203C
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW             0x2040
+#define ACP_I2S_TX_INTR_WATERMARK_SIZE                0x2044
+#define ACP_BT_RX_RINGBUFADDR                         0x2048
+#define ACP_BT_RX_RINGBUFSIZE                         0x204C
+#define ACP_BT_RX_LINKPOSITIONCNTR                    0x2050
+#define ACP_BT_RX_FIFOADDR                            0x2054
+#define ACP_BT_RX_FIFOSIZE                            0x2058
+#define ACP_BT_RX_DMA_SIZE                            0x205C
+#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH             0x2060
+#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW              0x2064
+#define ACP_BT_RX_INTR_WATERMARK_SIZE                 0x2068
+#define ACP_BT_TX_RINGBUFADDR                         0x206C
+#define ACP_BT_TX_RINGBUFSIZE                         0x2070
+#define ACP_BT_TX_LINKPOSITIONCNTR                    0x2074
+#define ACP_BT_TX_FIFOADDR                            0x2078
+#define ACP_BT_TX_FIFOSIZE                            0x207C
+#define ACP_BT_TX_DMA_SIZE                            0x2080
+#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH             0x2084
+#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW              0x2088
+#define ACP_BT_TX_INTR_WATERMARK_SIZE                 0x208C
+
+#define ACP_I2STDM_IER                                0x2400
+#define ACP_I2STDM_IRER                               0x2404
+#define ACP_I2STDM_RXFRMT                             0x2408
+#define ACP_I2STDM_ITER                               0x240C
+#define ACP_I2STDM_TXFRMT                             0x2410
+
+/* Registers from ACP_BT_TDM block */
+
+#define ACP_BTTDM_IER                                 0x2800
+#define ACP_BTTDM_IRER                                0x2804
+#define ACP_BTTDM_RXFRMT                              0x2808
+#define ACP_BTTDM_ITER                                0x280C
+#define ACP_BTTDM_TXFRMT                              0x2810
+
+#endif
index 3353f93..c9e53e0 100644 (file)
@@ -3,7 +3,9 @@
 snd-pci-acp5x-objs     := pci-acp5x.o
 snd-acp5x-i2s-objs     := acp5x-i2s.o
 snd-acp5x-pcm-dma-objs := acp5x-pcm-dma.o
+snd-soc-acp5x-mach-objs := acp5x-mach.o
 
 obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-pci-acp5x.o
 obj-$(CONFIG_SND_SOC_AMD_ACP5x)        += snd-acp5x-i2s.o
 obj-$(CONFIG_SND_SOC_AMD_ACP5x) += snd-acp5x-pcm-dma.o
+obj-$(CONFIG_SND_SOC_AMD_VANGOGH_MACH)   += snd-soc-acp5x-mach.o
index 2705e57..002db39 100644 (file)
@@ -348,7 +348,7 @@ static int acp5x_i2s_trigger(struct snd_pcm_substream *substream,
        return ret;
 }
 
-static struct snd_soc_dai_ops acp5x_i2s_dai_ops = {
+static const struct snd_soc_dai_ops acp5x_i2s_dai_ops = {
        .hw_params = acp5x_i2s_hwparams,
        .trigger = acp5x_i2s_trigger,
        .set_fmt = acp5x_i2s_set_fmt,
diff --git a/sound/soc/amd/vangogh/acp5x-mach.c b/sound/soc/amd/vangogh/acp5x-mach.c
new file mode 100644 (file)
index 0000000..14cf325
--- /dev/null
@@ -0,0 +1,386 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Machine driver for AMD Vangogh platform using NAU8821 & CS35L41
+ * codecs.
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <linux/module.h>
+#include <linux/io.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+
+#include <sound/jack.h>
+#include <linux/clk.h>
+#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/io.h>
+#include <linux/acpi.h>
+#include <linux/dmi.h>
+
+#include "../../codecs/nau8821.h"
+#include "../../codecs/cs35l41.h"
+
+#include "acp5x.h"
+
+#define DRV_NAME "acp5x_mach"
+#define DUAL_CHANNEL           2
+#define ACP5X_NUVOTON_CODEC_DAI        "nau8821-hifi"
+#define VG_JUPITER 1
+
+static unsigned long acp5x_machine_id;
+static struct snd_soc_jack vg_headset;
+
+static struct snd_soc_jack_pin acp5x_nau8821_jack_pins[] = {
+       {
+               .pin    = "Headphone",
+               .mask   = SND_JACK_HEADPHONE,
+       },
+       {
+               .pin    = "Headset Mic",
+               .mask   = SND_JACK_MICROPHONE,
+       },
+};
+
+static int acp5x_8821_init(struct snd_soc_pcm_runtime *rtd)
+{
+       int ret;
+       struct snd_soc_card *card = rtd->card;
+       struct snd_soc_component *component =
+                                       asoc_rtd_to_codec(rtd, 0)->component;
+
+       /*
+        * Headset buttons map to the google Reference headset.
+        * These can be configured by userspace.
+        */
+       ret = snd_soc_card_jack_new(card, "Headset Jack",
+                                   SND_JACK_HEADSET | SND_JACK_BTN_0,
+                                   &vg_headset, acp5x_nau8821_jack_pins,
+                                   ARRAY_SIZE(acp5x_nau8821_jack_pins));
+       if (ret) {
+               dev_err(rtd->dev, "Headset Jack creation failed %d\n", ret);
+               return ret;
+       }
+
+       snd_jack_set_key(vg_headset.jack, SND_JACK_BTN_0, KEY_MEDIA);
+       nau8821_enable_jack_detect(component, &vg_headset);
+       return ret;
+}
+
+static int acp5x_cs35l41_init(struct snd_soc_pcm_runtime *rtd)
+{
+       return 0;
+}
+
+static const unsigned int rates[] = {
+       48000,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_rates = {
+       .count = ARRAY_SIZE(rates),
+       .list  = rates,
+       .mask = 0,
+};
+
+static const unsigned int channels[] = {
+       2,
+};
+
+static const struct snd_pcm_hw_constraint_list constraints_channels = {
+       .count = ARRAY_SIZE(channels),
+       .list = channels,
+       .mask = 0,
+};
+
+static int acp5x_8821_startup(struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct acp5x_platform_info *machine = snd_soc_card_get_drvdata(card);
+
+       machine->play_i2s_instance = I2S_SP_INSTANCE;
+       machine->cap_i2s_instance = I2S_SP_INSTANCE;
+
+       runtime->hw.channels_max = DUAL_CHANNEL;
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
+                                  &constraints_channels);
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
+                                  &constraints_rates);
+       return 0;
+}
+
+static int acp5x_nau8821_hw_params(struct snd_pcm_substream *substream,
+                                  struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct snd_soc_dai *codec_dai =
+                       snd_soc_card_get_codec_dai(card,
+                                                  ACP5X_NUVOTON_CODEC_DAI);
+       int ret;
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, NAU8821_CLK_FLL_BLK, 0,
+                                    SND_SOC_CLOCK_IN);
+       if (ret < 0)
+               dev_err(card->dev, "can't set FS clock %d\n", ret);
+       ret = snd_soc_dai_set_pll(codec_dai, 0, 0, snd_soc_params_to_bclk(params),
+                                 params_rate(params) * 256);
+       if (ret < 0)
+               dev_err(card->dev, "can't set FLL: %d\n", ret);
+
+       return ret;
+}
+
+static int acp5x_cs35l41_startup(struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct acp5x_platform_info *machine = snd_soc_card_get_drvdata(card);
+
+       machine->play_i2s_instance = I2S_HS_INSTANCE;
+
+       runtime->hw.channels_max = DUAL_CHANNEL;
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_CHANNELS,
+                                  &constraints_channels);
+       snd_pcm_hw_constraint_list(runtime, 0, SNDRV_PCM_HW_PARAM_RATE,
+                                  &constraints_rates);
+       return 0;
+}
+
+static int acp5x_cs35l41_hw_params(struct snd_pcm_substream *substream,
+                                  struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct snd_soc_dai *codec_dai;
+       int ret, i;
+       unsigned int num_codecs = rtd->num_codecs;
+       unsigned int bclk_val;
+
+       for (i = 0; i < num_codecs; i++) {
+               codec_dai = asoc_rtd_to_codec(rtd, i);
+               if ((strcmp(codec_dai->name, "spi-VLV1776:00") == 0) ||
+                   (strcmp(codec_dai->name, "spi-VLV1776:01") == 0)) {
+                       switch (params_rate(params)) {
+                       case 48000:
+                               bclk_val = 1536000;
+                               break;
+                       default:
+                               dev_err(card->dev, "Invalid Samplerate:0x%x\n",
+                                       params_rate(params));
+                               return -EINVAL;
+                       }
+                       ret = snd_soc_component_set_sysclk(codec_dai->component,
+                                                          0, 0, bclk_val, SND_SOC_CLOCK_IN);
+                       if (ret < 0) {
+                               dev_err(card->dev, "failed to set sysclk for CS35l41 dai\n");
+                               return ret;
+                       }
+               }
+       }
+
+       return ret;
+}
+
+static const struct snd_soc_ops acp5x_8821_ops = {
+       .startup = acp5x_8821_startup,
+       .hw_params = acp5x_nau8821_hw_params,
+};
+
+static const struct snd_soc_ops acp5x_cs35l41_play_ops = {
+       .startup = acp5x_cs35l41_startup,
+       .hw_params = acp5x_cs35l41_hw_params,
+};
+
+static struct snd_soc_codec_conf cs35l41_conf[] = {
+       {
+               .dlc = COMP_CODEC_CONF("spi-VLV1776:00"),
+               .name_prefix = "Left",
+       },
+       {
+               .dlc = COMP_CODEC_CONF("spi-VLV1776:01"),
+               .name_prefix = "Right",
+       },
+};
+
+SND_SOC_DAILINK_DEF(acp5x_i2s,
+                   DAILINK_COMP_ARRAY(COMP_CPU("acp5x_i2s_playcap.0")));
+
+SND_SOC_DAILINK_DEF(acp5x_bt,
+                   DAILINK_COMP_ARRAY(COMP_CPU("acp5x_i2s_playcap.1")));
+
+SND_SOC_DAILINK_DEF(nau8821,
+                   DAILINK_COMP_ARRAY(COMP_CODEC("i2c-NVTN2020:00",
+                                                 "nau8821-hifi")));
+
+SND_SOC_DAILINK_DEF(cs35l41,
+                   DAILINK_COMP_ARRAY(COMP_CODEC("spi-VLV1776:00", "cs35l41-pcm"),
+                                      COMP_CODEC("spi-VLV1776:01", "cs35l41-pcm")));
+
+SND_SOC_DAILINK_DEF(platform,
+                   DAILINK_COMP_ARRAY(COMP_PLATFORM("acp5x_i2s_dma.0")));
+
+static struct snd_soc_dai_link acp5x_dai[] = {
+       {
+               .name = "acp5x-8825-play",
+               .stream_name = "Playback/Capture",
+               .dai_fmt = SND_SOC_DAIFMT_I2S  | SND_SOC_DAIFMT_NB_NF |
+                          SND_SOC_DAIFMT_CBC_CFC,
+               .dpcm_playback = 1,
+               .dpcm_capture = 1,
+               .ops = &acp5x_8821_ops,
+               .init = acp5x_8821_init,
+               SND_SOC_DAILINK_REG(acp5x_i2s, nau8821, platform),
+       },
+       {
+               .name = "acp5x-CS35L41-Stereo",
+               .stream_name = "CS35L41 Stereo Playback",
+               .dai_fmt = SND_SOC_DAIFMT_I2S  | SND_SOC_DAIFMT_NB_NF |
+                          SND_SOC_DAIFMT_CBC_CFC,
+               .dpcm_playback = 1,
+               .playback_only = 1,
+               .ops = &acp5x_cs35l41_play_ops,
+               .init = acp5x_cs35l41_init,
+               SND_SOC_DAILINK_REG(acp5x_bt, cs35l41, platform),
+       },
+};
+
+static int platform_clock_control(struct snd_soc_dapm_widget *w,
+                                 struct snd_kcontrol *k, int  event)
+{
+       struct snd_soc_dapm_context *dapm = w->dapm;
+       struct snd_soc_card *card = dapm->card;
+       struct snd_soc_dai *codec_dai;
+       int ret = 0;
+
+       codec_dai = snd_soc_card_get_codec_dai(card, ACP5X_NUVOTON_CODEC_DAI);
+       if (!codec_dai) {
+               dev_err(card->dev, "Codec dai not found\n");
+               return -EIO;
+       }
+
+       if (SND_SOC_DAPM_EVENT_OFF(event)) {
+               ret = snd_soc_dai_set_sysclk(codec_dai, NAU8821_CLK_INTERNAL,
+                                            0, SND_SOC_CLOCK_IN);
+               if (ret < 0) {
+                       dev_err(card->dev, "set sysclk err = %d\n", ret);
+                       return -EIO;
+               }
+       }
+       return ret;
+}
+
+static const struct snd_kcontrol_new acp5x_8821_controls[] = {
+       SOC_DAPM_PIN_SWITCH("Headphone"),
+       SOC_DAPM_PIN_SWITCH("Headset Mic"),
+       SOC_DAPM_PIN_SWITCH("Int Mic"),
+};
+
+static const struct snd_soc_dapm_widget acp5x_8821_widgets[] = {
+       SND_SOC_DAPM_HP("Headphone", NULL),
+       SND_SOC_DAPM_MIC("Headset Mic", NULL),
+       SND_SOC_DAPM_MIC("Int Mic", NULL),
+       SND_SOC_DAPM_SUPPLY("Platform Clock", SND_SOC_NOPM, 0, 0,
+                           platform_clock_control, SND_SOC_DAPM_POST_PMD),
+};
+
+static const struct snd_soc_dapm_route acp5x_8821_audio_route[] = {
+       /* HP jack connectors - unknown if we have jack detection */
+       { "Headphone", NULL, "HPOL" },
+       { "Headphone", NULL, "HPOR" },
+       { "MICL", NULL, "Headset Mic" },
+       { "MICR", NULL, "Headset Mic" },
+       { "DMIC", NULL, "Int Mic" },
+
+       { "Headphone", NULL, "Platform Clock" },
+       { "Headset Mic", NULL, "Platform Clock" },
+       { "Int Mic", NULL, "Platform Clock" },
+};
+
+static struct snd_soc_card acp5x_card = {
+       .name = "acp5x",
+       .owner = THIS_MODULE,
+       .dai_link = acp5x_dai,
+       .num_links = ARRAY_SIZE(acp5x_dai),
+       .dapm_widgets = acp5x_8821_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(acp5x_8821_widgets),
+       .dapm_routes = acp5x_8821_audio_route,
+       .num_dapm_routes = ARRAY_SIZE(acp5x_8821_audio_route),
+       .codec_conf = cs35l41_conf,
+       .num_configs = ARRAY_SIZE(cs35l41_conf),
+       .controls = acp5x_8821_controls,
+       .num_controls = ARRAY_SIZE(acp5x_8821_controls),
+};
+
+
+static int acp5x_vg_quirk_cb(const struct dmi_system_id *id)
+{
+       acp5x_machine_id = VG_JUPITER;
+       return 1;
+}
+
+static const struct dmi_system_id acp5x_vg_quirk_table[] = {
+       {
+               .callback = acp5x_vg_quirk_cb,
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Valve"),
+                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Jupiter"),
+               }
+       },
+       {}
+};
+
+static int acp5x_probe(struct platform_device *pdev)
+{
+       int ret;
+       struct acp5x_platform_info *machine;
+       struct snd_soc_card *card;
+
+       machine = devm_kzalloc(&pdev->dev, sizeof(struct acp5x_platform_info),
+                              GFP_KERNEL);
+       if (!machine)
+               return -ENOMEM;
+
+       dmi_check_system(acp5x_vg_quirk_table);
+       switch(acp5x_machine_id) {
+       case VG_JUPITER:
+               card = &acp5x_card;
+               acp5x_card.dev = &pdev->dev;
+               break;
+       default:
+               return -ENODEV;
+       }
+       platform_set_drvdata(pdev, card);
+       snd_soc_card_set_drvdata(card, machine);
+
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+       if (ret) {
+               return dev_err_probe(&pdev->dev, ret,
+                                    "snd_soc_register_card(%s) failed\n",
+                                    acp5x_card.name);
+       }
+       return 0;
+}
+
+static struct platform_driver acp5x_mach_driver = {
+       .driver = {
+               .name = "acp5x_mach",
+               .pm = &snd_soc_pm_ops,
+       },
+       .probe = acp5x_probe,
+};
+
+module_platform_driver(acp5x_mach_driver);
+
+MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
+MODULE_DESCRIPTION("NAU8821 & CS35L41 audio support");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
index a808635..fe5e1fa 100644 (file)
@@ -23,7 +23,7 @@
 #define ACP_ERR_INTR_MASK      0x20000000
 #define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
 
-#define ACP5x_DEVS 3
+#define ACP5x_DEVS 4
 #define        ACP5x_REG_START 0x1240000
 #define        ACP5x_REG_END   0x1250200
 #define ACP5x_I2STDM_REG_START 0x1242400
index a57b762..2b6b9ed 100644 (file)
@@ -213,6 +213,9 @@ static int snd_acp5x_probe(struct pci_dev *pci,
                pdevinfo[2].num_res = 1;
                pdevinfo[2].res = &adata->res[2];
 
+               pdevinfo[3].name = "acp5x_mach";
+               pdevinfo[3].id = 0;
+               pdevinfo[3].parent = &pci->dev;
                for (i = 0; i < ACP5x_DEVS; i++) {
                        adata->pdev[i] =
                                platform_device_register_full(&pdevinfo[i]);
diff --git a/sound/soc/amd/yc/Makefile b/sound/soc/amd/yc/Makefile
new file mode 100644 (file)
index 0000000..dc29744
--- /dev/null
@@ -0,0 +1,9 @@
+# SPDX-License-Identifier: GPL-2.0+
+# Yellow Carp platform Support
+snd-pci-acp6x-objs     := pci-acp6x.o
+snd-acp6x-pdm-dma-objs := acp6x-pdm-dma.o
+snd-soc-acp6x-mach-objs := acp6x-mach.o
+
+obj-$(CONFIG_SND_SOC_AMD_ACP6x) += snd-pci-acp6x.o
+obj-$(CONFIG_SND_SOC_AMD_ACP6x) += snd-acp6x-pdm-dma.o
+obj-$(CONFIG_SND_SOC_AMD_YC_MACH)   += snd-soc-acp6x-mach.o
diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
new file mode 100644 (file)
index 0000000..9a767f4
--- /dev/null
@@ -0,0 +1,194 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Machine driver for AMD Yellow Carp platform using DMIC
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <linux/module.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <linux/io.h>
+#include <linux/dmi.h>
+
+#include "acp6x.h"
+
+#define DRV_NAME "acp_yc_mach"
+
+SND_SOC_DAILINK_DEF(acp6x_pdm,
+                   DAILINK_COMP_ARRAY(COMP_CPU("acp_yc_pdm_dma.0")));
+
+SND_SOC_DAILINK_DEF(dmic_codec,
+                   DAILINK_COMP_ARRAY(COMP_CODEC("dmic-codec.0",
+                                                 "dmic-hifi")));
+
+SND_SOC_DAILINK_DEF(pdm_platform,
+                   DAILINK_COMP_ARRAY(COMP_PLATFORM("acp_yc_pdm_dma.0")));
+
+static struct snd_soc_dai_link acp6x_dai_pdm[] = {
+       {
+               .name = "acp6x-dmic-capture",
+               .stream_name = "DMIC capture",
+               .capture_only = 1,
+               SND_SOC_DAILINK_REG(acp6x_pdm, dmic_codec, pdm_platform),
+       },
+};
+
+static struct snd_soc_card acp6x_card = {
+       .name = "acp6x",
+       .owner = THIS_MODULE,
+       .dai_link = acp6x_dai_pdm,
+       .num_links = 1,
+};
+
+static const struct dmi_system_id yc_acp_quirk_table[] = {
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D2"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D3"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D4"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D5"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CF"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CG"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CQ"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CR"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21AW"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21AX"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21BN"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21BQ"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CH"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CJ"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CK"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21CL"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D8"),
+               }
+       },
+       {
+               .matches = {
+                       DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "21D9"),
+               }
+       },
+       {}
+};
+
+static int acp6x_probe(struct platform_device *pdev)
+{
+       struct acp6x_pdm *machine = NULL;
+       struct snd_soc_card *card;
+       int ret;
+       const struct dmi_system_id *dmi_id;
+
+       dmi_id = dmi_first_match(yc_acp_quirk_table);
+       if (!dmi_id)
+               return -ENODEV;
+       card = &acp6x_card;
+       acp6x_card.dev = &pdev->dev;
+
+       platform_set_drvdata(pdev, card);
+       snd_soc_card_set_drvdata(card, machine);
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+       if (ret) {
+               return dev_err_probe(&pdev->dev, ret,
+                               "snd_soc_register_card(%s) failed\n",
+                               card->name);
+       }
+       return 0;
+}
+
+static struct platform_driver acp6x_mach_driver = {
+       .driver = {
+               .name = "acp_yc_mach",
+               .pm = &snd_soc_pm_ops,
+       },
+       .probe = acp6x_probe,
+};
+
+module_platform_driver(acp6x_mach_driver);
+
+MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c
new file mode 100644 (file)
index 0000000..e604f4e
--- /dev/null
@@ -0,0 +1,448 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * AMD ALSA SoC Yellow Carp PDM Driver
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#include <linux/platform_device.h>
+#include <linux/module.h>
+#include <linux/err.h>
+#include <linux/io.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <linux/pm_runtime.h>
+
+#include "acp6x.h"
+
+#define DRV_NAME "acp_yc_pdm_dma"
+
+static const struct snd_pcm_hardware acp6x_pdm_hardware_capture = {
+       .info = SNDRV_PCM_INFO_INTERLEAVED |
+               SNDRV_PCM_INFO_BLOCK_TRANSFER |
+               SNDRV_PCM_INFO_MMAP |
+               SNDRV_PCM_INFO_MMAP_VALID |
+               SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME,
+       .formats = SNDRV_PCM_FMTBIT_S32_LE,
+       .channels_min = 2,
+       .channels_max = 2,
+       .rates = SNDRV_PCM_RATE_48000,
+       .rate_min = 48000,
+       .rate_max = 48000,
+       .buffer_bytes_max = CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
+       .period_bytes_min = CAPTURE_MIN_PERIOD_SIZE,
+       .period_bytes_max = CAPTURE_MAX_PERIOD_SIZE,
+       .periods_min = CAPTURE_MIN_NUM_PERIODS,
+       .periods_max = CAPTURE_MAX_NUM_PERIODS,
+};
+
+static void acp6x_init_pdm_ring_buffer(u32 physical_addr, u32 buffer_size,
+                                      u32 watermark_size, void __iomem *acp_base)
+{
+       acp6x_writel(physical_addr, acp_base + ACP_WOV_RX_RINGBUFADDR);
+       acp6x_writel(buffer_size, acp_base + ACP_WOV_RX_RINGBUFSIZE);
+       acp6x_writel(watermark_size, acp_base + ACP_WOV_RX_INTR_WATERMARK_SIZE);
+       acp6x_writel(0x01, acp_base + ACPAXI2AXI_ATU_CTRL);
+}
+
+static void acp6x_enable_pdm_clock(void __iomem *acp_base)
+{
+       u32 pdm_clk_enable, pdm_ctrl;
+
+       pdm_clk_enable = ACP_PDM_CLK_FREQ_MASK;
+       pdm_ctrl = 0x00;
+
+       acp6x_writel(pdm_clk_enable, acp_base + ACP_WOV_CLK_CTRL);
+       pdm_ctrl = acp6x_readl(acp_base + ACP_WOV_MISC_CTRL);
+       pdm_ctrl |= ACP_WOV_MISC_CTRL_MASK;
+       acp6x_writel(pdm_ctrl, acp_base + ACP_WOV_MISC_CTRL);
+}
+
+static void acp6x_enable_pdm_interrupts(void __iomem *acp_base)
+{
+       u32 ext_int_ctrl;
+
+       ext_int_ctrl = acp6x_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
+       ext_int_ctrl |= PDM_DMA_INTR_MASK;
+       acp6x_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
+}
+
+static void acp6x_disable_pdm_interrupts(void __iomem *acp_base)
+{
+       u32 ext_int_ctrl;
+
+       ext_int_ctrl = acp6x_readl(acp_base + ACP_EXTERNAL_INTR_CNTL);
+       ext_int_ctrl &= ~PDM_DMA_INTR_MASK;
+       acp6x_writel(ext_int_ctrl, acp_base + ACP_EXTERNAL_INTR_CNTL);
+}
+
+static bool acp6x_check_pdm_dma_status(void __iomem *acp_base)
+{
+       bool pdm_dma_status;
+       u32 pdm_enable, pdm_dma_enable;
+
+       pdm_dma_status = false;
+       pdm_enable = acp6x_readl(acp_base + ACP_WOV_PDM_ENABLE);
+       pdm_dma_enable = acp6x_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+       if ((pdm_enable & ACP_PDM_ENABLE) && (pdm_dma_enable & ACP_PDM_DMA_EN_STATUS))
+               pdm_dma_status = true;
+
+       return pdm_dma_status;
+}
+
+static int acp6x_start_pdm_dma(void __iomem *acp_base)
+{
+       u32 pdm_enable;
+       u32 pdm_dma_enable;
+       int timeout;
+
+       pdm_enable = 0x01;
+       pdm_dma_enable  = 0x01;
+
+       acp6x_enable_pdm_clock(acp_base);
+       acp6x_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
+       acp6x_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
+       timeout = 0;
+       while (++timeout < ACP_COUNTER) {
+               pdm_dma_enable = acp6x_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+               if ((pdm_dma_enable & 0x02) == ACP_PDM_DMA_EN_STATUS)
+                       return 0;
+               udelay(DELAY_US);
+       }
+       return -ETIMEDOUT;
+}
+
+static int acp6x_stop_pdm_dma(void __iomem *acp_base)
+{
+       u32 pdm_enable, pdm_dma_enable;
+       int timeout;
+
+       pdm_enable = 0x00;
+       pdm_dma_enable  = 0x00;
+
+       pdm_enable = acp6x_readl(acp_base + ACP_WOV_PDM_ENABLE);
+       pdm_dma_enable = acp6x_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+       if (pdm_dma_enable & 0x01) {
+               pdm_dma_enable = 0x02;
+               acp6x_writel(pdm_dma_enable, acp_base + ACP_WOV_PDM_DMA_ENABLE);
+               timeout = 0;
+               while (++timeout < ACP_COUNTER) {
+                       pdm_dma_enable = acp6x_readl(acp_base + ACP_WOV_PDM_DMA_ENABLE);
+                       if ((pdm_dma_enable & 0x02) == 0x00)
+                               break;
+                       udelay(DELAY_US);
+               }
+               if (timeout == ACP_COUNTER)
+                       return -ETIMEDOUT;
+       }
+       if (pdm_enable == ACP_PDM_ENABLE) {
+               pdm_enable = ACP_PDM_DISABLE;
+               acp6x_writel(pdm_enable, acp_base + ACP_WOV_PDM_ENABLE);
+       }
+       acp6x_writel(0x01, acp_base + ACP_WOV_PDM_FIFO_FLUSH);
+       return 0;
+}
+
+static void acp6x_config_dma(struct pdm_stream_instance *rtd, int direction)
+{
+       u16 page_idx;
+       u32 low, high, val;
+       dma_addr_t addr;
+
+       addr = rtd->dma_addr;
+       val = PDM_PTE_OFFSET;
+
+       /* Group Enable */
+       acp6x_writel(ACP_SRAM_PTE_OFFSET | BIT(31), rtd->acp6x_base +
+                    ACPAXI2AXI_ATU_BASE_ADDR_GRP_1);
+       acp6x_writel(PAGE_SIZE_4K_ENABLE, rtd->acp6x_base +
+                    ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1);
+       for (page_idx = 0; page_idx < rtd->num_pages; page_idx++) {
+               /* Load the low address of page int ACP SRAM through SRBM */
+               low = lower_32_bits(addr);
+               high = upper_32_bits(addr);
+
+               acp6x_writel(low, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val);
+               high |= BIT(31);
+               acp6x_writel(high, rtd->acp6x_base + ACP_SCRATCH_REG_0 + val + 4);
+               val += 8;
+               addr += PAGE_SIZE;
+       }
+}
+
+static int acp6x_pdm_dma_open(struct snd_soc_component *component,
+                             struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime;
+       struct pdm_dev_data *adata;
+       struct pdm_stream_instance *pdm_data;
+       int ret;
+
+       runtime = substream->runtime;
+       adata = dev_get_drvdata(component->dev);
+       pdm_data = kzalloc(sizeof(*pdm_data), GFP_KERNEL);
+       if (!pdm_data)
+               return -EINVAL;
+
+       if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+               runtime->hw = acp6x_pdm_hardware_capture;
+
+       ret = snd_pcm_hw_constraint_integer(runtime,
+                                           SNDRV_PCM_HW_PARAM_PERIODS);
+       if (ret < 0) {
+               dev_err(component->dev, "set integer constraint failed\n");
+               kfree(pdm_data);
+               return ret;
+       }
+
+       acp6x_enable_pdm_interrupts(adata->acp6x_base);
+
+       if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+               adata->capture_stream = substream;
+
+       pdm_data->acp6x_base = adata->acp6x_base;
+       runtime->private_data = pdm_data;
+       return ret;
+}
+
+static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component,
+                                  struct snd_pcm_substream *substream,
+                                  struct snd_pcm_hw_params *params)
+{
+       struct pdm_stream_instance *rtd;
+       size_t size, period_bytes;
+
+       rtd = substream->runtime->private_data;
+       if (!rtd)
+               return -EINVAL;
+       size = params_buffer_bytes(params);
+       period_bytes = params_period_bytes(params);
+       rtd->dma_addr = substream->runtime->dma_addr;
+       rtd->num_pages = (PAGE_ALIGN(size) >> PAGE_SHIFT);
+       acp6x_config_dma(rtd, substream->stream);
+       acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, size,
+                                  period_bytes, rtd->acp6x_base);
+       return 0;
+}
+
+static u64 acp6x_pdm_get_byte_count(struct pdm_stream_instance *rtd,
+                                   int direction)
+{
+       union acp_pdm_dma_count byte_count;
+
+       byte_count.bcount.high =
+                       acp6x_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH);
+       byte_count.bcount.low =
+                       acp6x_readl(rtd->acp6x_base + ACP_WOV_RX_LINEARPOSITIONCNTR_LOW);
+       return byte_count.bytescount;
+}
+
+static snd_pcm_uframes_t acp6x_pdm_dma_pointer(struct snd_soc_component *comp,
+                                              struct snd_pcm_substream *stream)
+{
+       struct pdm_stream_instance *rtd;
+       u32 pos, buffersize;
+       u64 bytescount;
+
+       rtd = stream->runtime->private_data;
+       buffersize = frames_to_bytes(stream->runtime,
+                                    stream->runtime->buffer_size);
+       bytescount = acp6x_pdm_get_byte_count(rtd, stream->stream);
+       if (bytescount > rtd->bytescount)
+               bytescount -= rtd->bytescount;
+       pos = do_div(bytescount, buffersize);
+       return bytes_to_frames(stream->runtime, pos);
+}
+
+static int acp6x_pdm_dma_new(struct snd_soc_component *component,
+                            struct snd_soc_pcm_runtime *rtd)
+{
+       struct device *parent = component->dev->parent;
+
+       snd_pcm_set_managed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV,
+                                      parent, MIN_BUFFER, MAX_BUFFER);
+       return 0;
+}
+
+static int acp6x_pdm_dma_close(struct snd_soc_component *component,
+                              struct snd_pcm_substream *substream)
+{
+       struct pdm_dev_data *adata = dev_get_drvdata(component->dev);
+
+       acp6x_disable_pdm_interrupts(adata->acp6x_base);
+       adata->capture_stream = NULL;
+       return 0;
+}
+
+static int acp6x_pdm_dai_trigger(struct snd_pcm_substream *substream,
+                                int cmd, struct snd_soc_dai *dai)
+{
+       struct pdm_stream_instance *rtd;
+       int ret;
+       bool pdm_status;
+       unsigned int ch_mask;
+
+       rtd = substream->runtime->private_data;
+       ret = 0;
+       switch (substream->runtime->channels) {
+       case TWO_CH:
+               ch_mask = 0x00;
+               break;
+       default:
+               return -EINVAL;
+       }
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+               acp6x_writel(ch_mask, rtd->acp6x_base + ACP_WOV_PDM_NO_OF_CHANNELS);
+               acp6x_writel(PDM_DECIMATION_FACTOR, rtd->acp6x_base +
+                            ACP_WOV_PDM_DECIMATION_FACTOR);
+               rtd->bytescount = acp6x_pdm_get_byte_count(rtd, substream->stream);
+               pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
+               if (!pdm_status)
+                       ret = acp6x_start_pdm_dma(rtd->acp6x_base);
+               break;
+       case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               pdm_status = acp6x_check_pdm_dma_status(rtd->acp6x_base);
+               if (pdm_status)
+                       ret = acp6x_stop_pdm_dma(rtd->acp6x_base);
+               break;
+       default:
+               ret = -EINVAL;
+               break;
+       }
+       return ret;
+}
+
+static struct snd_soc_dai_ops acp6x_pdm_dai_ops = {
+       .trigger   = acp6x_pdm_dai_trigger,
+};
+
+static struct snd_soc_dai_driver acp6x_pdm_dai_driver = {
+       .capture = {
+               .rates = SNDRV_PCM_RATE_48000,
+               .formats = SNDRV_PCM_FMTBIT_S32_LE,
+               .channels_min = 2,
+               .channels_max = 2,
+               .rate_min = 48000,
+               .rate_max = 48000,
+       },
+       .ops = &acp6x_pdm_dai_ops,
+};
+
+static const struct snd_soc_component_driver acp6x_pdm_component = {
+       .name           = DRV_NAME,
+       .open           = acp6x_pdm_dma_open,
+       .close          = acp6x_pdm_dma_close,
+       .hw_params      = acp6x_pdm_dma_hw_params,
+       .pointer        = acp6x_pdm_dma_pointer,
+       .pcm_construct  = acp6x_pdm_dma_new,
+};
+
+static int acp6x_pdm_audio_probe(struct platform_device *pdev)
+{
+       struct resource *res;
+       struct pdm_dev_data *adata;
+       int status;
+
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (!res) {
+               dev_err(&pdev->dev, "IORESOURCE_MEM FAILED\n");
+               return -ENODEV;
+       }
+
+       adata = devm_kzalloc(&pdev->dev, sizeof(*adata), GFP_KERNEL);
+       if (!adata)
+               return -ENOMEM;
+
+       adata->acp6x_base = devm_ioremap(&pdev->dev, res->start, resource_size(res));
+       if (!adata->acp6x_base)
+               return -ENOMEM;
+
+       adata->capture_stream = NULL;
+
+       dev_set_drvdata(&pdev->dev, adata);
+       status = devm_snd_soc_register_component(&pdev->dev,
+                                                &acp6x_pdm_component,
+                                                &acp6x_pdm_dai_driver, 1);
+       if (status) {
+               dev_err(&pdev->dev, "Fail to register acp pdm dai\n");
+
+               return -ENODEV;
+       }
+       pm_runtime_set_autosuspend_delay(&pdev->dev, ACP_SUSPEND_DELAY_MS);
+       pm_runtime_use_autosuspend(&pdev->dev);
+       pm_runtime_enable(&pdev->dev);
+       pm_runtime_allow(&pdev->dev);
+       return 0;
+}
+
+static int acp6x_pdm_audio_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+       return 0;
+}
+
+static int __maybe_unused acp6x_pdm_resume(struct device *dev)
+{
+       struct pdm_dev_data *adata;
+       struct snd_pcm_runtime *runtime;
+       struct pdm_stream_instance *rtd;
+       u32 period_bytes, buffer_len;
+
+       adata = dev_get_drvdata(dev);
+       if (adata->capture_stream && adata->capture_stream->runtime) {
+               runtime = adata->capture_stream->runtime;
+               rtd = runtime->private_data;
+               period_bytes = frames_to_bytes(runtime, runtime->period_size);
+               buffer_len = frames_to_bytes(runtime, runtime->buffer_size);
+               acp6x_config_dma(rtd, SNDRV_PCM_STREAM_CAPTURE);
+               acp6x_init_pdm_ring_buffer(PDM_MEM_WINDOW_START, buffer_len,
+                                          period_bytes, adata->acp6x_base);
+       }
+       acp6x_enable_pdm_interrupts(adata->acp6x_base);
+       return 0;
+}
+
+static int __maybe_unused acp6x_pdm_suspend(struct device *dev)
+{
+       struct pdm_dev_data *adata;
+
+       adata = dev_get_drvdata(dev);
+       acp6x_disable_pdm_interrupts(adata->acp6x_base);
+       return 0;
+}
+
+static int __maybe_unused acp6x_pdm_runtime_resume(struct device *dev)
+{
+       struct pdm_dev_data *adata;
+
+       adata = dev_get_drvdata(dev);
+       acp6x_enable_pdm_interrupts(adata->acp6x_base);
+       return 0;
+}
+
+static const struct dev_pm_ops acp6x_pdm_pm_ops = {
+       SET_RUNTIME_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_runtime_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(acp6x_pdm_suspend, acp6x_pdm_resume)
+};
+
+static struct platform_driver acp6x_pdm_dma_driver = {
+       .probe = acp6x_pdm_audio_probe,
+       .remove = acp6x_pdm_audio_remove,
+       .driver = {
+               .name = "acp_yc_pdm_dma",
+               .pm = &acp6x_pdm_pm_ops,
+       },
+};
+
+module_platform_driver(acp6x_pdm_dma_driver);
+
+MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
+MODULE_DESCRIPTION("AMD ACP6x YC PDM Driver");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
diff --git a/sound/soc/amd/yc/acp6x.h b/sound/soc/amd/yc/acp6x.h
new file mode 100644 (file)
index 0000000..74b596e
--- /dev/null
@@ -0,0 +1,107 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * AMD ALSA SoC PDM Driver
+ *
+ * Copyright (C) 2021 Advanced Micro Devices, Inc. All rights reserved.
+ */
+
+#include "acp6x_chip_offset_byte.h"
+
+#define ACP_DEVICE_ID 0x15E2
+#define ACP6x_PHY_BASE_ADDRESS 0x1240000
+#define ACP6x_REG_START                0x1240000
+#define ACP6x_REG_END          0x1250200
+#define ACP6x_DEVS             3
+#define ACP6x_PDM_MODE         1
+
+#define ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK  0x00010001
+#define ACP_PGFSM_CNTL_POWER_ON_MASK   1
+#define ACP_PGFSM_CNTL_POWER_OFF_MASK  0
+#define ACP_PGFSM_STATUS_MASK          3
+#define ACP_POWERED_ON                 0
+#define ACP_POWER_ON_IN_PROGRESS       1
+#define ACP_POWERED_OFF                        2
+#define ACP_POWER_OFF_IN_PROGRESS      3
+
+#define ACP_ERROR_MASK 0x20000000
+#define ACP_EXT_INTR_STAT_CLEAR_MASK 0xFFFFFFFF
+#define PDM_DMA_STAT 0x10
+
+#define PDM_DMA_INTR_MASK      0x10000
+#define ACP_ERROR_STAT 29
+#define PDM_DECIMATION_FACTOR  2
+#define ACP_PDM_CLK_FREQ_MASK  7
+#define ACP_WOV_MISC_CTRL_MASK 0x10
+#define ACP_PDM_ENABLE         1
+#define ACP_PDM_DISABLE                0
+#define ACP_PDM_DMA_EN_STATUS  2
+#define TWO_CH         2
+#define DELAY_US       5
+#define ACP_COUNTER    20000
+
+#define ACP_SRAM_PTE_OFFSET    0x03800000
+#define PAGE_SIZE_4K_ENABLE    2
+#define PDM_PTE_OFFSET         0
+#define PDM_MEM_WINDOW_START   0x4000000
+
+#define CAPTURE_MIN_NUM_PERIODS     4
+#define CAPTURE_MAX_NUM_PERIODS     4
+#define CAPTURE_MAX_PERIOD_SIZE     8192
+#define CAPTURE_MIN_PERIOD_SIZE     4096
+
+#define MAX_BUFFER (CAPTURE_MAX_PERIOD_SIZE * CAPTURE_MAX_NUM_PERIODS)
+#define MIN_BUFFER MAX_BUFFER
+
+/* time in ms for runtime suspend delay */
+#define ACP_SUSPEND_DELAY_MS   2000
+
+enum acp_config {
+       ACP_CONFIG_0 = 0,
+       ACP_CONFIG_1,
+       ACP_CONFIG_2,
+       ACP_CONFIG_3,
+       ACP_CONFIG_4,
+       ACP_CONFIG_5,
+       ACP_CONFIG_6,
+       ACP_CONFIG_7,
+       ACP_CONFIG_8,
+       ACP_CONFIG_9,
+       ACP_CONFIG_10,
+       ACP_CONFIG_11,
+       ACP_CONFIG_12,
+       ACP_CONFIG_13,
+       ACP_CONFIG_14,
+       ACP_CONFIG_15,
+};
+
+struct pdm_dev_data {
+       u32 pdm_irq;
+       void __iomem *acp6x_base;
+       struct snd_pcm_substream *capture_stream;
+};
+
+struct pdm_stream_instance {
+       u16 num_pages;
+       u16 channels;
+       dma_addr_t dma_addr;
+       u64 bytescount;
+       void __iomem *acp6x_base;
+};
+
+union acp_pdm_dma_count {
+       struct {
+       u32 low;
+       u32 high;
+       } bcount;
+       u64 bytescount;
+};
+
+static inline u32 acp6x_readl(void __iomem *base_addr)
+{
+       return readl(base_addr - ACP6x_PHY_BASE_ADDRESS);
+}
+
+static inline void acp6x_writel(u32 val, void __iomem *base_addr)
+{
+       writel(val, base_addr - ACP6x_PHY_BASE_ADDRESS);
+}
diff --git a/sound/soc/amd/yc/acp6x_chip_offset_byte.h b/sound/soc/amd/yc/acp6x_chip_offset_byte.h
new file mode 100644 (file)
index 0000000..f05fb2d
--- /dev/null
@@ -0,0 +1,444 @@
+/* SPDX-License-Identifier: GPL-2.0+ */
+/*
+ * AMD ACP 6.x Register Documentation
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#ifndef _acp6x_OFFSET_HEADER
+#define _acp6x_OFFSET_HEADER
+
+/* Registers from ACP_DMA block */
+#define ACP_DMA_CNTL_0                                0x1240000
+#define ACP_DMA_CNTL_1                                0x1240004
+#define ACP_DMA_CNTL_2                                0x1240008
+#define ACP_DMA_CNTL_3                                0x124000C
+#define ACP_DMA_CNTL_4                                0x1240010
+#define ACP_DMA_CNTL_5                                0x1240014
+#define ACP_DMA_CNTL_6                                0x1240018
+#define ACP_DMA_CNTL_7                                0x124001C
+#define ACP_DMA_DSCR_STRT_IDX_0                       0x1240020
+#define ACP_DMA_DSCR_STRT_IDX_1                       0x1240024
+#define ACP_DMA_DSCR_STRT_IDX_2                       0x1240028
+#define ACP_DMA_DSCR_STRT_IDX_3                       0x124002C
+#define ACP_DMA_DSCR_STRT_IDX_4                       0x1240030
+#define ACP_DMA_DSCR_STRT_IDX_5                       0x1240034
+#define ACP_DMA_DSCR_STRT_IDX_6                       0x1240038
+#define ACP_DMA_DSCR_STRT_IDX_7                       0x124003C
+#define ACP_DMA_DSCR_CNT_0                            0x1240040
+#define ACP_DMA_DSCR_CNT_1                            0x1240044
+#define ACP_DMA_DSCR_CNT_2                            0x1240048
+#define ACP_DMA_DSCR_CNT_3                            0x124004C
+#define ACP_DMA_DSCR_CNT_4                            0x1240050
+#define ACP_DMA_DSCR_CNT_5                            0x1240054
+#define ACP_DMA_DSCR_CNT_6                            0x1240058
+#define ACP_DMA_DSCR_CNT_7                            0x124005C
+#define ACP_DMA_PRIO_0                                0x1240060
+#define ACP_DMA_PRIO_1                                0x1240064
+#define ACP_DMA_PRIO_2                                0x1240068
+#define ACP_DMA_PRIO_3                                0x124006C
+#define ACP_DMA_PRIO_4                                0x1240070
+#define ACP_DMA_PRIO_5                                0x1240074
+#define ACP_DMA_PRIO_6                                0x1240078
+#define ACP_DMA_PRIO_7                                0x124007C
+#define ACP_DMA_CUR_DSCR_0                            0x1240080
+#define ACP_DMA_CUR_DSCR_1                            0x1240084
+#define ACP_DMA_CUR_DSCR_2                            0x1240088
+#define ACP_DMA_CUR_DSCR_3                            0x124008C
+#define ACP_DMA_CUR_DSCR_4                            0x1240090
+#define ACP_DMA_CUR_DSCR_5                            0x1240094
+#define ACP_DMA_CUR_DSCR_6                            0x1240098
+#define ACP_DMA_CUR_DSCR_7                            0x124009C
+#define ACP_DMA_CUR_TRANS_CNT_0                       0x12400A0
+#define ACP_DMA_CUR_TRANS_CNT_1                       0x12400A4
+#define ACP_DMA_CUR_TRANS_CNT_2                       0x12400A8
+#define ACP_DMA_CUR_TRANS_CNT_3                       0x12400AC
+#define ACP_DMA_CUR_TRANS_CNT_4                       0x12400B0
+#define ACP_DMA_CUR_TRANS_CNT_5                       0x12400B4
+#define ACP_DMA_CUR_TRANS_CNT_6                       0x12400B8
+#define ACP_DMA_CUR_TRANS_CNT_7                       0x12400BC
+#define ACP_DMA_ERR_STS_0                             0x12400C0
+#define ACP_DMA_ERR_STS_1                             0x12400C4
+#define ACP_DMA_ERR_STS_2                             0x12400C8
+#define ACP_DMA_ERR_STS_3                             0x12400CC
+#define ACP_DMA_ERR_STS_4                             0x12400D0
+#define ACP_DMA_ERR_STS_5                             0x12400D4
+#define ACP_DMA_ERR_STS_6                             0x12400D8
+#define ACP_DMA_ERR_STS_7                             0x12400DC
+#define ACP_DMA_DESC_BASE_ADDR                        0x12400E0
+#define ACP_DMA_DESC_MAX_NUM_DSCR                     0x12400E4
+#define ACP_DMA_CH_STS                                0x12400E8
+#define ACP_DMA_CH_GROUP                              0x12400EC
+#define ACP_DMA_CH_RST_STS                            0x12400F0
+
+/* Registers from ACP_AXI2AXIATU block */
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_1                0x1240C00
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_1                0x1240C04
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_2                0x1240C08
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_2                0x1240C0C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_3                0x1240C10
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_3                0x1240C14
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_4                0x1240C18
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_4                0x1240C1C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_5                0x1240C20
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_5                0x1240C24
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_6                0x1240C28
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_6                0x1240C2C
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_7                0x1240C30
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_7                0x1240C34
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_8                0x1240C38
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_8                0x1240C3C
+#define ACPAXI2AXI_ATU_CTRL                           0x1240C40
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_9                0x1240C44
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_9                0x1240C48
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_10               0x1240C4C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_10               0x1240C50
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_11               0x1240C54
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_11               0x1240C58
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_12               0x1240C5C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_12               0x1240C60
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_13               0x1240C64
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_13               0x1240C68
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_14               0x1240C6C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_14               0x1240C70
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_15               0x1240C74
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_15               0x1240C78
+#define ACPAXI2AXI_ATU_PAGE_SIZE_GRP_16               0x1240C7C
+#define ACPAXI2AXI_ATU_BASE_ADDR_GRP_16               0x1240C80
+
+/* Registers from ACP_CLKRST block */
+#define ACP_SOFT_RESET                                0x1241000
+#define ACP_CONTROL                                   0x1241004
+#define ACP_STATUS                                    0x1241008
+#define ACP_DYNAMIC_CG_MASTER_CONTROL                 0x1241010
+#define ACP_ZSC_DSP_CTRL                              0x1241014
+#define ACP_ZSC_STS                                   0x1241018
+#define ACP_PGFSM_CONTROL                             0x1241024
+#define ACP_PGFSM_STATUS                              0x1241028
+#define ACP_CLKMUX_SEL                                0x124102C
+
+/* Registers from ACP_AON block */
+#define ACP_PME_EN                                    0x1241400
+#define ACP_DEVICE_STATE                              0x1241404
+#define AZ_DEVICE_STATE                               0x1241408
+#define ACP_PIN_CONFIG                                0x1241440
+#define ACP_PAD_PULLUP_CTRL                           0x1241444
+#define ACP_PAD_PULLDOWN_CTRL                         0x1241448
+#define ACP_PAD_DRIVE_STRENGTH_CTRL                   0x124144C
+#define ACP_PAD_SCHMEN_CTRL                           0x1241450
+#define ACP_SW_PAD_KEEPER_EN                          0x1241454
+#define ACP_SW_WAKE_EN                                0x1241458
+#define ACP_I2S_WAKE_EN                               0x124145C
+#define ACP_SW1_WAKE_EN                               0x1241460
+
+/* Registers from ACP_P1_MISC block */
+#define ACP_EXTERNAL_INTR_ENB                         0x1241A00
+#define ACP_EXTERNAL_INTR_CNTL                        0x1241A04
+#define ACP_EXTERNAL_INTR_CNTL1                       0x1241A08
+#define ACP_EXTERNAL_INTR_STAT                        0x1241A0C
+#define ACP_EXTERNAL_INTR_STAT1                       0x1241A10
+#define ACP_ERROR_STATUS                              0x1241A4C
+#define ACP_P1_SW_I2S_ERROR_REASON                    0x1241A50
+#define ACP_P1_SW_POS_TRACK_I2S_TX_CTRL               0x1241A6C
+#define ACP_P1_SW_I2S_TX_DMA_POS                      0x1241A70
+#define ACP_P1_SW_POS_TRACK_I2S_RX_CTRL               0x1241A74
+#define ACP_P1_SW_I2S_RX_DMA_POS                      0x1241A78
+#define ACP_P1_DMIC_I2S_GPIO_INTR_CTRL                0x1241A7C
+#define ACP_P1_DMIC_I2S_GPIO_INTR_STATUS              0x1241A80
+#define ACP_SCRATCH_REG_BASE_ADDR                     0x1241A84
+#define ACP_P1_SW_POS_TRACK_BT_TX_CTRL                0x1241A88
+#define ACP_P1_SW_BT_TX_DMA_POS                       0x1241A8C
+#define ACP_P1_SW_POS_TRACK_HS_TX_CTRL                0x1241A90
+#define ACP_P1_SW_HS_TX_DMA_POS                       0x1241A94
+#define ACP_P1_SW_POS_TRACK_BT_RX_CTRL                0x1241A98
+#define ACP_P1_SW_BT_RX_DMA_POS                       0x1241A9C
+#define ACP_P1_SW_POS_TRACK_HS_RX_CTRL                0x1241AA0
+#define ACP_P1_SW_HS_RX_DMA_POS                       0x1241AA4
+
+/* Registers from ACP_AUDIO_BUFFERS block */
+#define ACP_I2S_RX_RINGBUFADDR                        0x1242000
+#define ACP_I2S_RX_RINGBUFSIZE                        0x1242004
+#define ACP_I2S_RX_LINKPOSITIONCNTR                   0x1242008
+#define ACP_I2S_RX_FIFOADDR                           0x124200C
+#define ACP_I2S_RX_FIFOSIZE                           0x1242010
+#define ACP_I2S_RX_DMA_SIZE                           0x1242014
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_HIGH            0x1242018
+#define ACP_I2S_RX_LINEARPOSITIONCNTR_LOW             0x124201C
+#define ACP_I2S_RX_INTR_WATERMARK_SIZE                0x1242020
+#define ACP_I2S_TX_RINGBUFADDR                        0x1242024
+#define ACP_I2S_TX_RINGBUFSIZE                        0x1242028
+#define ACP_I2S_TX_LINKPOSITIONCNTR                   0x124202C
+#define ACP_I2S_TX_FIFOADDR                           0x1242030
+#define ACP_I2S_TX_FIFOSIZE                           0x1242034
+#define ACP_I2S_TX_DMA_SIZE                           0x1242038
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_HIGH            0x124203C
+#define ACP_I2S_TX_LINEARPOSITIONCNTR_LOW             0x1242040
+#define ACP_I2S_TX_INTR_WATERMARK_SIZE                0x1242044
+#define ACP_BT_RX_RINGBUFADDR                         0x1242048
+#define ACP_BT_RX_RINGBUFSIZE                         0x124204C
+#define ACP_BT_RX_LINKPOSITIONCNTR                    0x1242050
+#define ACP_BT_RX_FIFOADDR                            0x1242054
+#define ACP_BT_RX_FIFOSIZE                            0x1242058
+#define ACP_BT_RX_DMA_SIZE                            0x124205C
+#define ACP_BT_RX_LINEARPOSITIONCNTR_HIGH             0x1242060
+#define ACP_BT_RX_LINEARPOSITIONCNTR_LOW              0x1242064
+#define ACP_BT_RX_INTR_WATERMARK_SIZE                 0x1242068
+#define ACP_BT_TX_RINGBUFADDR                         0x124206C
+#define ACP_BT_TX_RINGBUFSIZE                         0x1242070
+#define ACP_BT_TX_LINKPOSITIONCNTR                    0x1242074
+#define ACP_BT_TX_FIFOADDR                            0x1242078
+#define ACP_BT_TX_FIFOSIZE                            0x124207C
+#define ACP_BT_TX_DMA_SIZE                            0x1242080
+#define ACP_BT_TX_LINEARPOSITIONCNTR_HIGH             0x1242084
+#define ACP_BT_TX_LINEARPOSITIONCNTR_LOW              0x1242088
+#define ACP_BT_TX_INTR_WATERMARK_SIZE                 0x124208C
+#define ACP_HS_RX_RINGBUFADDR                         0x1242090
+#define ACP_HS_RX_RINGBUFSIZE                         0x1242094
+#define ACP_HS_RX_LINKPOSITIONCNTR                    0x1242098
+#define ACP_HS_RX_FIFOADDR                            0x124209C
+#define ACP_HS_RX_FIFOSIZE                            0x12420A0
+#define ACP_HS_RX_DMA_SIZE                            0x12420A4
+#define ACP_HS_RX_LINEARPOSITIONCNTR_HIGH             0x12420A8
+#define ACP_HS_RX_LINEARPOSITIONCNTR_LOW              0x12420AC
+#define ACP_HS_RX_INTR_WATERMARK_SIZE                 0x12420B0
+#define ACP_HS_TX_RINGBUFADDR                         0x12420B4
+#define ACP_HS_TX_RINGBUFSIZE                         0x12420B8
+#define ACP_HS_TX_LINKPOSITIONCNTR                    0x12420BC
+#define ACP_HS_TX_FIFOADDR                            0x12420C0
+#define ACP_HS_TX_FIFOSIZE                            0x12420C4
+#define ACP_HS_TX_DMA_SIZE                            0x12420C8
+#define ACP_HS_TX_LINEARPOSITIONCNTR_HIGH             0x12420CC
+#define ACP_HS_TX_LINEARPOSITIONCNTR_LOW              0x12420D0
+#define ACP_HS_TX_INTR_WATERMARK_SIZE                 0x12420D4
+
+/* Registers from ACP_I2S_TDM block */
+#define ACP_I2STDM_IER                                0x1242400
+#define ACP_I2STDM_IRER                               0x1242404
+#define ACP_I2STDM_RXFRMT                             0x1242408
+#define ACP_I2STDM_ITER                               0x124240C
+#define ACP_I2STDM_TXFRMT                             0x1242410
+#define ACP_I2STDM0_MSTRCLKGEN                        0x1242414
+#define ACP_I2STDM1_MSTRCLKGEN                        0x1242418
+#define ACP_I2STDM2_MSTRCLKGEN                        0x124241C
+#define ACP_I2STDM_REFCLKGEN                          0x1242420
+
+/* Registers from ACP_BT_TDM block */
+#define ACP_BTTDM_IER                                 0x1242800
+#define ACP_BTTDM_IRER                                0x1242804
+#define ACP_BTTDM_RXFRMT                              0x1242808
+#define ACP_BTTDM_ITER                                0x124280C
+#define ACP_BTTDM_TXFRMT                              0x1242810
+#define ACP_HSTDM_IER                                 0x1242814
+#define ACP_HSTDM_IRER                                0x1242818
+#define ACP_HSTDM_RXFRMT                              0x124281C
+#define ACP_HSTDM_ITER                                0x1242820
+#define ACP_HSTDM_TXFRMT                              0x1242824
+
+/* Registers from ACP_WOV block */
+#define ACP_WOV_PDM_ENABLE                            0x1242C04
+#define ACP_WOV_PDM_DMA_ENABLE                        0x1242C08
+#define ACP_WOV_RX_RINGBUFADDR                        0x1242C0C
+#define ACP_WOV_RX_RINGBUFSIZE                        0x1242C10
+#define ACP_WOV_RX_LINKPOSITIONCNTR                   0x1242C14
+#define ACP_WOV_RX_LINEARPOSITIONCNTR_HIGH            0x1242C18
+#define ACP_WOV_RX_LINEARPOSITIONCNTR_LOW             0x1242C1C
+#define ACP_WOV_RX_INTR_WATERMARK_SIZE                0x1242C20
+#define ACP_WOV_PDM_FIFO_FLUSH                        0x1242C24
+#define ACP_WOV_PDM_NO_OF_CHANNELS                    0x1242C28
+#define ACP_WOV_PDM_DECIMATION_FACTOR                 0x1242C2C
+#define ACP_WOV_PDM_VAD_CTRL                          0x1242C30
+#define ACP_WOV_WAKE                                  0x1242C54
+#define ACP_WOV_BUFFER_STATUS                         0x1242C58
+#define ACP_WOV_MISC_CTRL                             0x1242C5C
+#define ACP_WOV_CLK_CTRL                              0x1242C60
+#define ACP_PDM_VAD_DYNAMIC_CLK_GATING_EN             0x1242C64
+#define ACP_WOV_ERROR_STATUS_REGISTER                 0x1242C68
+#define ACP_PDM_CLKDIV                                0x1242C6C
+
+/* Registers from ACP_P1_AUDIO_BUFFERS block */
+#define ACP_P1_I2S_RX_RINGBUFADDR                     0x1243A00
+#define ACP_P1_I2S_RX_RINGBUFSIZE                     0x1243A04
+#define ACP_P1_I2S_RX_LINKPOSITIONCNTR                0x1243A08
+#define ACP_P1_I2S_RX_FIFOADDR                        0x1243A0C
+#define ACP_P1_I2S_RX_FIFOSIZE                        0x1243A10
+#define ACP_P1_I2S_RX_DMA_SIZE                        0x1243A14
+#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_HIGH         0x1243A18
+#define ACP_P1_I2S_RX_LINEARPOSITIONCNTR_LOW          0x1243A1C
+#define ACP_P1_I2S_RX_INTR_WATERMARK_SIZE             0x1243A20
+#define ACP_P1_I2S_TX_RINGBUFADDR                     0x1243A24
+#define ACP_P1_I2S_TX_RINGBUFSIZE                     0x1243A28
+#define ACP_P1_I2S_TX_LINKPOSITIONCNTR                0x1243A2C
+#define ACP_P1_I2S_TX_FIFOADDR                        0x1243A30
+#define ACP_P1_I2S_TX_FIFOSIZE                        0x1243A34
+#define ACP_P1_I2S_TX_DMA_SIZE                        0x1243A38
+#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_HIGH         0x1243A3C
+#define ACP_P1_I2S_TX_LINEARPOSITIONCNTR_LOW          0x1243A40
+#define ACP_P1_I2S_TX_INTR_WATERMARK_SIZE             0x1243A44
+#define ACP_P1_BT_RX_RINGBUFADDR                      0x1243A48
+#define ACP_P1_BT_RX_RINGBUFSIZE                      0x1243A4C
+#define ACP_P1_BT_RX_LINKPOSITIONCNTR                 0x1243A50
+#define ACP_P1_BT_RX_FIFOADDR                         0x1243A54
+#define ACP_P1_BT_RX_FIFOSIZE                         0x1243A58
+#define ACP_P1_BT_RX_DMA_SIZE                         0x1243A5C
+#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_HIGH          0x1243A60
+#define ACP_P1_BT_RX_LINEARPOSITIONCNTR_LOW           0x1243A64
+#define ACP_P1_BT_RX_INTR_WATERMARK_SIZE              0x1243A68
+#define ACP_P1_BT_TX_RINGBUFADDR                      0x1243A6C
+#define ACP_P1_BT_TX_RINGBUFSIZE                      0x1243A70
+#define ACP_P1_BT_TX_LINKPOSITIONCNTR                 0x1243A74
+#define ACP_P1_BT_TX_FIFOADDR                         0x1243A78
+#define ACP_P1_BT_TX_FIFOSIZE                         0x1243A7C
+#define ACP_P1_BT_TX_DMA_SIZE                         0x1243A80
+#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_HIGH          0x1243A84
+#define ACP_P1_BT_TX_LINEARPOSITIONCNTR_LOW           0x1243A88
+#define ACP_P1_BT_TX_INTR_WATERMARK_SIZE              0x1243A8C
+#define ACP_P1_HS_RX_RINGBUFADDR                      0x1243A90
+#define ACP_P1_HS_RX_RINGBUFSIZE                      0x1243A94
+#define ACP_P1_HS_RX_LINKPOSITIONCNTR                 0x1243A98
+#define ACP_P1_HS_RX_FIFOADDR                         0x1243A9C
+#define ACP_P1_HS_RX_FIFOSIZE                         0x1243AA0
+#define ACP_P1_HS_RX_DMA_SIZE                         0x1243AA4
+#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_HIGH          0x1243AA8
+#define ACP_P1_HS_RX_LINEARPOSITIONCNTR_LOW           0x1243AAC
+#define ACP_P1_HS_RX_INTR_WATERMARK_SIZE              0x1243AB0
+#define ACP_P1_HS_TX_RINGBUFADDR                      0x1243AB4
+#define ACP_P1_HS_TX_RINGBUFSIZE                      0x1243AB8
+#define ACP_P1_HS_TX_LINKPOSITIONCNTR                 0x1243ABC
+#define ACP_P1_HS_TX_FIFOADDR                         0x1243AC0
+#define ACP_P1_HS_TX_FIFOSIZE                         0x1243AC4
+#define ACP_P1_HS_TX_DMA_SIZE                         0x1243AC8
+#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_HIGH          0x1243ACC
+#define ACP_P1_HS_TX_LINEARPOSITIONCNTR_LOW           0x1243AD0
+#define ACP_P1_HS_TX_INTR_WATERMARK_SIZE              0x1243AD4
+
+/* Registers from ACP_SCRATCH block */
+#define ACP_SCRATCH_REG_0                             0x1250000
+#define ACP_SCRATCH_REG_1                             0x1250004
+#define ACP_SCRATCH_REG_2                             0x1250008
+#define ACP_SCRATCH_REG_3                             0x125000C
+#define ACP_SCRATCH_REG_4                             0x1250010
+#define ACP_SCRATCH_REG_5                             0x1250014
+#define ACP_SCRATCH_REG_6                             0x1250018
+#define ACP_SCRATCH_REG_7                             0x125001C
+#define ACP_SCRATCH_REG_8                             0x1250020
+#define ACP_SCRATCH_REG_9                             0x1250024
+#define ACP_SCRATCH_REG_10                            0x1250028
+#define ACP_SCRATCH_REG_11                            0x125002C
+#define ACP_SCRATCH_REG_12                            0x1250030
+#define ACP_SCRATCH_REG_13                            0x1250034
+#define ACP_SCRATCH_REG_14                            0x1250038
+#define ACP_SCRATCH_REG_15                            0x125003C
+#define ACP_SCRATCH_REG_16                            0x1250040
+#define ACP_SCRATCH_REG_17                            0x1250044
+#define ACP_SCRATCH_REG_18                            0x1250048
+#define ACP_SCRATCH_REG_19                            0x125004C
+#define ACP_SCRATCH_REG_20                            0x1250050
+#define ACP_SCRATCH_REG_21                            0x1250054
+#define ACP_SCRATCH_REG_22                            0x1250058
+#define ACP_SCRATCH_REG_23                            0x125005C
+#define ACP_SCRATCH_REG_24                            0x1250060
+#define ACP_SCRATCH_REG_25                            0x1250064
+#define ACP_SCRATCH_REG_26                            0x1250068
+#define ACP_SCRATCH_REG_27                            0x125006C
+#define ACP_SCRATCH_REG_28                            0x1250070
+#define ACP_SCRATCH_REG_29                            0x1250074
+#define ACP_SCRATCH_REG_30                            0x1250078
+#define ACP_SCRATCH_REG_31                            0x125007C
+#define ACP_SCRATCH_REG_32                            0x1250080
+#define ACP_SCRATCH_REG_33                            0x1250084
+#define ACP_SCRATCH_REG_34                            0x1250088
+#define ACP_SCRATCH_REG_35                            0x125008C
+#define ACP_SCRATCH_REG_36                            0x1250090
+#define ACP_SCRATCH_REG_37                            0x1250094
+#define ACP_SCRATCH_REG_38                            0x1250098
+#define ACP_SCRATCH_REG_39                            0x125009C
+#define ACP_SCRATCH_REG_40                            0x12500A0
+#define ACP_SCRATCH_REG_41                            0x12500A4
+#define ACP_SCRATCH_REG_42                            0x12500A8
+#define ACP_SCRATCH_REG_43                            0x12500AC
+#define ACP_SCRATCH_REG_44                            0x12500B0
+#define ACP_SCRATCH_REG_45                            0x12500B4
+#define ACP_SCRATCH_REG_46                            0x12500B8
+#define ACP_SCRATCH_REG_47                            0x12500BC
+#define ACP_SCRATCH_REG_48                            0x12500C0
+#define ACP_SCRATCH_REG_49                            0x12500C4
+#define ACP_SCRATCH_REG_50                            0x12500C8
+#define ACP_SCRATCH_REG_51                            0x12500CC
+#define ACP_SCRATCH_REG_52                            0x12500D0
+#define ACP_SCRATCH_REG_53                            0x12500D4
+#define ACP_SCRATCH_REG_54                            0x12500D8
+#define ACP_SCRATCH_REG_55                            0x12500DC
+#define ACP_SCRATCH_REG_56                            0x12500E0
+#define ACP_SCRATCH_REG_57                            0x12500E4
+#define ACP_SCRATCH_REG_58                            0x12500E8
+#define ACP_SCRATCH_REG_59                            0x12500EC
+#define ACP_SCRATCH_REG_60                            0x12500F0
+#define ACP_SCRATCH_REG_61                            0x12500F4
+#define ACP_SCRATCH_REG_62                            0x12500F8
+#define ACP_SCRATCH_REG_63                            0x12500FC
+#define ACP_SCRATCH_REG_64                            0x1250100
+#define ACP_SCRATCH_REG_65                            0x1250104
+#define ACP_SCRATCH_REG_66                            0x1250108
+#define ACP_SCRATCH_REG_67                            0x125010C
+#define ACP_SCRATCH_REG_68                            0x1250110
+#define ACP_SCRATCH_REG_69                            0x1250114
+#define ACP_SCRATCH_REG_70                            0x1250118
+#define ACP_SCRATCH_REG_71                            0x125011C
+#define ACP_SCRATCH_REG_72                            0x1250120
+#define ACP_SCRATCH_REG_73                            0x1250124
+#define ACP_SCRATCH_REG_74                            0x1250128
+#define ACP_SCRATCH_REG_75                            0x125012C
+#define ACP_SCRATCH_REG_76                            0x1250130
+#define ACP_SCRATCH_REG_77                            0x1250134
+#define ACP_SCRATCH_REG_78                            0x1250138
+#define ACP_SCRATCH_REG_79                            0x125013C
+#define ACP_SCRATCH_REG_80                            0x1250140
+#define ACP_SCRATCH_REG_81                            0x1250144
+#define ACP_SCRATCH_REG_82                            0x1250148
+#define ACP_SCRATCH_REG_83                            0x125014C
+#define ACP_SCRATCH_REG_84                            0x1250150
+#define ACP_SCRATCH_REG_85                            0x1250154
+#define ACP_SCRATCH_REG_86                            0x1250158
+#define ACP_SCRATCH_REG_87                            0x125015C
+#define ACP_SCRATCH_REG_88                            0x1250160
+#define ACP_SCRATCH_REG_89                            0x1250164
+#define ACP_SCRATCH_REG_90                            0x1250168
+#define ACP_SCRATCH_REG_91                            0x125016C
+#define ACP_SCRATCH_REG_92                            0x1250170
+#define ACP_SCRATCH_REG_93                            0x1250174
+#define ACP_SCRATCH_REG_94                            0x1250178
+#define ACP_SCRATCH_REG_95                            0x125017C
+#define ACP_SCRATCH_REG_96                            0x1250180
+#define ACP_SCRATCH_REG_97                            0x1250184
+#define ACP_SCRATCH_REG_98                            0x1250188
+#define ACP_SCRATCH_REG_99                            0x125018C
+#define ACP_SCRATCH_REG_100                           0x1250190
+#define ACP_SCRATCH_REG_101                           0x1250194
+#define ACP_SCRATCH_REG_102                           0x1250198
+#define ACP_SCRATCH_REG_103                           0x125019C
+#define ACP_SCRATCH_REG_104                           0x12501A0
+#define ACP_SCRATCH_REG_105                           0x12501A4
+#define ACP_SCRATCH_REG_106                           0x12501A8
+#define ACP_SCRATCH_REG_107                           0x12501AC
+#define ACP_SCRATCH_REG_108                           0x12501B0
+#define ACP_SCRATCH_REG_109                           0x12501B4
+#define ACP_SCRATCH_REG_110                           0x12501B8
+#define ACP_SCRATCH_REG_111                           0x12501BC
+#define ACP_SCRATCH_REG_112                           0x12501C0
+#define ACP_SCRATCH_REG_113                           0x12501C4
+#define ACP_SCRATCH_REG_114                           0x12501C8
+#define ACP_SCRATCH_REG_115                           0x12501CC
+#define ACP_SCRATCH_REG_116                           0x12501D0
+#define ACP_SCRATCH_REG_117                           0x12501D4
+#define ACP_SCRATCH_REG_118                           0x12501D8
+#define ACP_SCRATCH_REG_119                           0x12501DC
+#define ACP_SCRATCH_REG_120                           0x12501E0
+#define ACP_SCRATCH_REG_121                           0x12501E4
+#define ACP_SCRATCH_REG_122                           0x12501E8
+#define ACP_SCRATCH_REG_123                           0x12501EC
+#define ACP_SCRATCH_REG_124                           0x12501F0
+#define ACP_SCRATCH_REG_125                           0x12501F4
+#define ACP_SCRATCH_REG_126                           0x12501F8
+#define ACP_SCRATCH_REG_127                           0x12501FC
+#define ACP_SCRATCH_REG_128                           0x1250200
+#endif
diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
new file mode 100644 (file)
index 0000000..957eeb6
--- /dev/null
@@ -0,0 +1,338 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * AMD Yellow Carp ACP PCI Driver
+ *
+ * Copyright 2021 Advanced Micro Devices, Inc.
+ */
+
+#include <linux/pci.h>
+#include <linux/module.h>
+#include <linux/io.h>
+#include <linux/delay.h>
+#include <linux/platform_device.h>
+#include <linux/interrupt.h>
+#include <sound/pcm_params.h>
+#include <linux/pm_runtime.h>
+
+#include "acp6x.h"
+
+struct acp6x_dev_data {
+       void __iomem *acp6x_base;
+       struct resource *res;
+       bool acp6x_audio_mode;
+       struct platform_device *pdev[ACP6x_DEVS];
+};
+
+static int acp6x_power_on(void __iomem *acp_base)
+{
+       u32 val;
+       int timeout;
+
+       val = acp6x_readl(acp_base + ACP_PGFSM_STATUS);
+
+       if (!val)
+               return val;
+
+       if ((val & ACP_PGFSM_STATUS_MASK) != ACP_POWER_ON_IN_PROGRESS)
+               acp6x_writel(ACP_PGFSM_CNTL_POWER_ON_MASK, acp_base + ACP_PGFSM_CONTROL);
+       timeout = 0;
+       while (++timeout < 500) {
+               val = acp6x_readl(acp_base + ACP_PGFSM_STATUS);
+               if (!val)
+                       return 0;
+               udelay(1);
+       }
+       return -ETIMEDOUT;
+}
+
+static int acp6x_reset(void __iomem *acp_base)
+{
+       u32 val;
+       int timeout;
+
+       acp6x_writel(1, acp_base + ACP_SOFT_RESET);
+       timeout = 0;
+       while (++timeout < 500) {
+               val = acp6x_readl(acp_base + ACP_SOFT_RESET);
+               if (val & ACP_SOFT_RESET_SOFTRESET_AUDDONE_MASK)
+                       break;
+               cpu_relax();
+       }
+       acp6x_writel(0, acp_base + ACP_SOFT_RESET);
+       timeout = 0;
+       while (++timeout < 500) {
+               val = acp6x_readl(acp_base + ACP_SOFT_RESET);
+               if (!val)
+                       return 0;
+               cpu_relax();
+       }
+       return -ETIMEDOUT;
+}
+
+static void acp6x_enable_interrupts(void __iomem *acp_base)
+{
+       acp6x_writel(0x01, acp_base + ACP_EXTERNAL_INTR_ENB);
+}
+
+static void acp6x_disable_interrupts(void __iomem *acp_base)
+{
+       acp6x_writel(ACP_EXT_INTR_STAT_CLEAR_MASK, acp_base +
+                    ACP_EXTERNAL_INTR_STAT);
+       acp6x_writel(0x00, acp_base + ACP_EXTERNAL_INTR_CNTL);
+       acp6x_writel(0x00, acp_base + ACP_EXTERNAL_INTR_ENB);
+}
+
+static int acp6x_init(void __iomem *acp_base)
+{
+       int ret;
+
+       /* power on */
+       ret = acp6x_power_on(acp_base);
+       if (ret) {
+               pr_err("ACP power on failed\n");
+               return ret;
+       }
+       acp6x_writel(0x01, acp_base + ACP_CONTROL);
+       /* Reset */
+       ret = acp6x_reset(acp_base);
+       if (ret) {
+               pr_err("ACP reset failed\n");
+               return ret;
+       }
+       acp6x_writel(0x03, acp_base + ACP_CLKMUX_SEL);
+       acp6x_enable_interrupts(acp_base);
+       return 0;
+}
+
+static int acp6x_deinit(void __iomem *acp_base)
+{
+       int ret;
+
+       acp6x_disable_interrupts(acp_base);
+       /* Reset */
+       ret = acp6x_reset(acp_base);
+       if (ret) {
+               pr_err("ACP reset failed\n");
+               return ret;
+       }
+       acp6x_writel(0x00, acp_base + ACP_CLKMUX_SEL);
+       acp6x_writel(0x00, acp_base + ACP_CONTROL);
+       return 0;
+}
+
+static irqreturn_t acp6x_irq_handler(int irq, void *dev_id)
+{
+       struct acp6x_dev_data *adata;
+       struct pdm_dev_data *yc_pdm_data;
+       u32 val;
+
+       adata = dev_id;
+       if (!adata)
+               return IRQ_NONE;
+
+       val = acp6x_readl(adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
+       if (val & BIT(PDM_DMA_STAT)) {
+               yc_pdm_data = dev_get_drvdata(&adata->pdev[0]->dev);
+               acp6x_writel(BIT(PDM_DMA_STAT), adata->acp6x_base + ACP_EXTERNAL_INTR_STAT);
+               if (yc_pdm_data->capture_stream)
+                       snd_pcm_period_elapsed(yc_pdm_data->capture_stream);
+               return IRQ_HANDLED;
+       }
+       return IRQ_NONE;
+}
+
+static int snd_acp6x_probe(struct pci_dev *pci,
+                          const struct pci_device_id *pci_id)
+{
+       struct acp6x_dev_data *adata;
+       struct platform_device_info pdevinfo[ACP6x_DEVS];
+       int ret, index;
+       int val = 0x00;
+       u32 addr;
+       unsigned int irqflags;
+
+       irqflags = IRQF_SHARED;
+       /* Yellow Carp device check */
+       if (pci->revision != 0x60)
+               return -ENODEV;
+
+       if (pci_enable_device(pci)) {
+               dev_err(&pci->dev, "pci_enable_device failed\n");
+               return -ENODEV;
+       }
+
+       ret = pci_request_regions(pci, "AMD ACP3x audio");
+       if (ret < 0) {
+               dev_err(&pci->dev, "pci_request_regions failed\n");
+               goto disable_pci;
+       }
+
+       adata = devm_kzalloc(&pci->dev, sizeof(struct acp6x_dev_data),
+                            GFP_KERNEL);
+       if (!adata) {
+               ret = -ENOMEM;
+               goto release_regions;
+       }
+
+       addr = pci_resource_start(pci, 0);
+       adata->acp6x_base = devm_ioremap(&pci->dev, addr,
+                                        pci_resource_len(pci, 0));
+       if (!adata->acp6x_base) {
+               ret = -ENOMEM;
+               goto release_regions;
+       }
+       pci_set_master(pci);
+       pci_set_drvdata(pci, adata);
+       ret = acp6x_init(adata->acp6x_base);
+       if (ret)
+               goto release_regions;
+       val = acp6x_readl(adata->acp6x_base + ACP_PIN_CONFIG);
+       switch (val) {
+       case ACP_CONFIG_0:
+       case ACP_CONFIG_1:
+       case ACP_CONFIG_2:
+       case ACP_CONFIG_3:
+       case ACP_CONFIG_9:
+       case ACP_CONFIG_15:
+               dev_info(&pci->dev, "Audio Mode %d\n", val);
+               break;
+       default:
+               adata->res = devm_kzalloc(&pci->dev,
+                                         sizeof(struct resource),
+                                         GFP_KERNEL);
+               if (!adata->res) {
+                       ret = -ENOMEM;
+                       goto de_init;
+               }
+
+               adata->res->name = "acp_iomem";
+               adata->res->flags = IORESOURCE_MEM;
+               adata->res->start = addr;
+               adata->res->end = addr + (ACP6x_REG_END - ACP6x_REG_START);
+
+               adata->acp6x_audio_mode = ACP6x_PDM_MODE;
+
+               memset(&pdevinfo, 0, sizeof(pdevinfo));
+               pdevinfo[0].name = "acp_yc_pdm_dma";
+               pdevinfo[0].id = 0;
+               pdevinfo[0].parent = &pci->dev;
+               pdevinfo[0].num_res = 1;
+               pdevinfo[0].res = adata->res;
+
+               pdevinfo[1].name = "dmic-codec";
+               pdevinfo[1].id = 0;
+               pdevinfo[1].parent = &pci->dev;
+
+               pdevinfo[2].name = "acp_yc_mach";
+               pdevinfo[2].id = 0;
+               pdevinfo[2].parent = &pci->dev;
+
+               for (index = 0; index < ACP6x_DEVS; index++) {
+                       adata->pdev[index] =
+                               platform_device_register_full(&pdevinfo[index]);
+                       if (IS_ERR(adata->pdev[index])) {
+                               dev_err(&pci->dev, "cannot register %s device\n",
+                                       pdevinfo[index].name);
+                               ret = PTR_ERR(adata->pdev[index]);
+                               goto unregister_devs;
+                       }
+               }
+               break;
+       }
+       ret = devm_request_irq(&pci->dev, pci->irq, acp6x_irq_handler,
+                              irqflags, "ACP_PCI_IRQ", adata);
+       if (ret) {
+               dev_err(&pci->dev, "ACP PCI IRQ request failed\n");
+               goto unregister_devs;
+       }
+       pm_runtime_set_autosuspend_delay(&pci->dev, ACP_SUSPEND_DELAY_MS);
+       pm_runtime_use_autosuspend(&pci->dev);
+       pm_runtime_put_noidle(&pci->dev);
+       pm_runtime_allow(&pci->dev);
+
+       return 0;
+unregister_devs:
+       for (--index; index >= 0; index--)
+               platform_device_unregister(adata->pdev[index]);
+de_init:
+       if (acp6x_deinit(adata->acp6x_base))
+               dev_err(&pci->dev, "ACP de-init failed\n");
+release_regions:
+       pci_release_regions(pci);
+disable_pci:
+       pci_disable_device(pci);
+
+       return ret;
+}
+
+static int __maybe_unused snd_acp6x_suspend(struct device *dev)
+{
+       struct acp6x_dev_data *adata;
+       int ret;
+
+       adata = dev_get_drvdata(dev);
+       ret = acp6x_deinit(adata->acp6x_base);
+       if (ret)
+               dev_err(dev, "ACP de-init failed\n");
+       return ret;
+}
+
+static int __maybe_unused snd_acp6x_resume(struct device *dev)
+{
+       struct acp6x_dev_data *adata;
+       int ret;
+
+       adata = dev_get_drvdata(dev);
+       ret = acp6x_init(adata->acp6x_base);
+       if (ret)
+               dev_err(dev, "ACP init failed\n");
+       return ret;
+}
+
+static const struct dev_pm_ops acp6x_pm = {
+       SET_RUNTIME_PM_OPS(snd_acp6x_suspend, snd_acp6x_resume, NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(snd_acp6x_suspend, snd_acp6x_resume)
+};
+
+static void snd_acp6x_remove(struct pci_dev *pci)
+{
+       struct acp6x_dev_data *adata;
+       int ret, index;
+
+       adata = pci_get_drvdata(pci);
+       if (adata->acp6x_audio_mode == ACP6x_PDM_MODE) {
+               for (index = 0; index < ACP6x_DEVS; index++)
+                       platform_device_unregister(adata->pdev[index]);
+       }
+       ret = acp6x_deinit(adata->acp6x_base);
+       if (ret)
+               dev_err(&pci->dev, "ACP de-init failed\n");
+       pm_runtime_forbid(&pci->dev);
+       pm_runtime_get_noresume(&pci->dev);
+       pci_release_regions(pci);
+       pci_disable_device(pci);
+}
+
+static const struct pci_device_id snd_acp6x_ids[] = {
+       { PCI_DEVICE(PCI_VENDOR_ID_AMD, ACP_DEVICE_ID),
+       .class = PCI_CLASS_MULTIMEDIA_OTHER << 8,
+       .class_mask = 0xffffff },
+       { 0, },
+};
+MODULE_DEVICE_TABLE(pci, snd_acp6x_ids);
+
+static struct pci_driver yc_acp6x_driver  = {
+       .name = KBUILD_MODNAME,
+       .id_table = snd_acp6x_ids,
+       .probe = snd_acp6x_probe,
+       .remove = snd_acp6x_remove,
+       .driver = {
+               .pm = &acp6x_pm,
+       }
+};
+
+module_pci_driver(yc_acp6x_driver);
+
+MODULE_AUTHOR("Vijendar.Mukunda@amd.com");
+MODULE_DESCRIPTION("AMD ACP Yellow Carp PCI driver");
+MODULE_LICENSE("GPL v2");
index 6b3d9c0..1934767 100644 (file)
@@ -342,8 +342,8 @@ static int atmel_i2s_hw_params(struct snd_pcm_substream *substream,
                return -EINVAL;
        }
 
-       switch (dev->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (dev->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                /* codec is slave, so cpu is master */
                mr |= ATMEL_I2SC_MR_MODE_MASTER;
                ret = atmel_i2s_get_gck_param(dev, params_rate(params));
@@ -351,7 +351,7 @@ static int atmel_i2s_hw_params(struct snd_pcm_substream *substream,
                        return ret;
                break;
 
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                /* codec is master, so cpu is slave */
                mr |= ATMEL_I2SC_MR_MODE_SLAVE;
                dev->gck_param = NULL;
index 6a63e87..26e2bc6 100644 (file)
@@ -209,8 +209,8 @@ static int atmel_ssc_hw_rule_rate(struct snd_pcm_hw_params *params,
        if (frame_size < 0)
                return frame_size;
 
-       switch (ssc_p->daifmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFS:
+       switch (ssc_p->daifmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFC:
                if ((ssc_p->dir_mask & SSC_DIR_MASK_CAPTURE)
                    && ssc->clk_from_rk_pin)
                        /* Receiver Frame Synchro (i.e. capture)
@@ -220,7 +220,7 @@ static int atmel_ssc_hw_rule_rate(struct snd_pcm_hw_params *params,
                        mck_div = 3;
                break;
 
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                if ((ssc_p->dir_mask & SSC_DIR_MASK_PLAYBACK)
                    && !ssc->clk_from_rk_pin)
                        /* Transmit Frame Synchro (i.e. playback)
@@ -232,8 +232,8 @@ static int atmel_ssc_hw_rule_rate(struct snd_pcm_hw_params *params,
                break;
        }
 
-       switch (ssc_p->daifmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (ssc_p->daifmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                r.num = ssc_p->mck_rate / mck_div / frame_size;
 
                ret = snd_interval_ratnum(i, 1, &r, &num, &den);
@@ -243,8 +243,8 @@ static int atmel_ssc_hw_rule_rate(struct snd_pcm_hw_params *params,
                }
                break;
 
-       case SND_SOC_DAIFMT_CBM_CFS:
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFC:
+       case SND_SOC_DAIFMT_CBP_CFP:
                t.min = 8000;
                t.max = ssc_p->mck_rate / mck_div / frame_size;
                t.openmin = t.openmax = 0;
@@ -429,9 +429,9 @@ static int atmel_ssc_set_dai_clkdiv(struct snd_soc_dai *cpu_dai,
 /* Is the cpu-dai master of the frame clock? */
 static int atmel_ssc_cfs(struct atmel_ssc_info *ssc_p)
 {
-       switch (ssc_p->daifmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFS:
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (ssc_p->daifmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFC:
+       case SND_SOC_DAIFMT_CBC_CFC:
                return 1;
        }
        return 0;
@@ -440,9 +440,9 @@ static int atmel_ssc_cfs(struct atmel_ssc_info *ssc_p)
 /* Is the cpu-dai master of the bit clock? */
 static int atmel_ssc_cbs(struct atmel_ssc_info *ssc_p)
 {
-       switch (ssc_p->daifmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFM:
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (ssc_p->daifmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFP:
+       case SND_SOC_DAIFMT_CBC_CFC:
                return 1;
        }
        return 0;
index 9e23758..9c974c4 100644 (file)
@@ -66,7 +66,7 @@ static struct snd_soc_dai_link atmel_asoc_wm8904_dailink = {
        .stream_name = "WM8904 PCM",
        .dai_fmt = SND_SOC_DAIFMT_I2S
                | SND_SOC_DAIFMT_NB_NF
-               | SND_SOC_DAIFMT_CBM_CFM,
+               | SND_SOC_DAIFMT_CBP_CFP,
        .ops = &atmel_asoc_wm8904_ops,
        SND_SOC_DAILINK_REG(pcm),
 };
index 8988f02..6d1227a 100644 (file)
@@ -350,7 +350,7 @@ static int mchp_i2s_mcc_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                return -EINVAL;
 
        /* We can't generate only FSYNC */
-       if ((fmt & SND_SOC_DAIFMT_MASTER_MASK) == SND_SOC_DAIFMT_CBM_CFS)
+       if ((fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) == SND_SOC_DAIFMT_CBP_CFC)
                return -EINVAL;
 
        /* We can only reconfigure the IP when it's stopped */
@@ -546,20 +546,20 @@ static int mchp_i2s_mcc_hw_params(struct snd_pcm_substream *substream,
                return -EINVAL;
        }
 
-       switch (dev->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (dev->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                /* cpu is BCLK and LRC master */
                mra |= MCHP_I2SMCC_MRA_MODE_MASTER;
                if (dev->sysclk)
                        mra |= MCHP_I2SMCC_MRA_IMCKMODE_GEN;
                set_divs = 1;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
+       case SND_SOC_DAIFMT_CBC_CFP:
                /* cpu is BCLK master */
                mrb |= MCHP_I2SMCC_MRB_CLKSEL_INT;
                set_divs = 1;
                fallthrough;
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                /* cpu is slave */
                mra |= MCHP_I2SMCC_MRA_MODE_SLAVE;
                if (dev->sysclk)
index 0be7b42..f9331f7 100644 (file)
@@ -129,9 +129,9 @@ static int snd_proto_probe(struct platform_device *pdev)
        }
        if (bitclkmaster) {
                if (codec_np == bitclkmaster)
-                       dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+                       dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
                else
-                       dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
+                       dai_fmt |= SND_SOC_DAIFMT_CBC_CFC;
        } else {
                dai_fmt |= snd_soc_daifmt_parse_clock_provider_as_flag(np, NULL);
        }
index ed1f69b..915da92 100644 (file)
@@ -126,7 +126,7 @@ static struct snd_soc_dai_link at91sam9g20ek_dai = {
        .stream_name = "WM8731 PCM",
        .init = at91sam9g20ek_wm8731_init,
        .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                  SND_SOC_DAIFMT_CBM_CFM,
+                  SND_SOC_DAIFMT_CBP_CFP,
        SND_SOC_DAILINK_REG(pcm),
 };
 
index 7745250..7c45dc4 100644 (file)
@@ -115,7 +115,7 @@ static int sam9x5_wm8731_driver_probe(struct platform_device *pdev)
        dai->codecs->dai_name = "wm8731-hifi";
        dai->init = sam9x5_wm8731_init;
        dai->dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF
-               | SND_SOC_DAIFMT_CBM_CFM;
+               | SND_SOC_DAIFMT_CBP_CFP;
 
        ret = snd_soc_of_parse_card_name(card, "atmel,model");
        if (ret) {
index 50c3dc6..1b3a312 100644 (file)
@@ -304,7 +304,7 @@ static struct snd_soc_dai_link tse850_dailink = {
        .stream_name = "TSE-850-PCM",
        .dai_fmt = SND_SOC_DAIFMT_I2S
                 | SND_SOC_DAIFMT_NB_NF
-                | SND_SOC_DAIFMT_CBM_CFS,
+                | SND_SOC_DAIFMT_CBP_CFC,
        SND_SOC_DAILINK_REG(pcm),
 };
 
index 5f8baad..400eaf9 100644 (file)
@@ -117,7 +117,7 @@ static struct snd_soc_dai_link db1200_i2s_dai = {
        .name           = "WM8731",
        .stream_name    = "WM8731 PCM",
        .dai_fmt        = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBM_CFM,
+                         SND_SOC_DAIFMT_CBP_CFP,
        .ops            = &db1200_i2s_wm8731_ops,
        SND_SOC_DAILINK_REG(db1200_i2s),
 };
@@ -138,7 +138,7 @@ static struct snd_soc_dai_link db1300_i2s_dai = {
        .name           = "WM8731",
        .stream_name    = "WM8731 PCM",
        .dai_fmt        = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBM_CFM,
+                         SND_SOC_DAIFMT_CBP_CFP,
        .ops            = &db1200_i2s_wm8731_ops,
        SND_SOC_DAILINK_REG(db1300_i2s),
 };
@@ -159,7 +159,7 @@ static struct snd_soc_dai_link db1550_i2s_dai = {
        .name           = "WM8731",
        .stream_name    = "WM8731 PCM",
        .dai_fmt        = SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBM_CFM,
+                         SND_SOC_DAIFMT_CBP_CFP,
        .ops            = &db1200_i2s_wm8731_ops,
        SND_SOC_DAILINK_REG(db1550_i2s),
 };
index 65bd39f..740d4e0 100644 (file)
@@ -119,9 +119,9 @@ static int au1xi2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
                goto out;
        }
 
-       /* I2S controller only supports master */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:    /* CODEC slave */
+       /* I2S controller only supports provider */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:    /* CODEC consumer */
                break;
        default:
                goto out;
index 767ce95..b2b8896 100644 (file)
@@ -90,12 +90,12 @@ static int au1xpsc_i2s_set_fmt(struct snd_soc_dai *cpu_dai,
                goto out;
        }
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:    /* CODEC master */
-               ct |= PSC_I2SCFG_MS;    /* PSC I2S slave mode */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:    /* CODEC provider */
+               ct |= PSC_I2SCFG_MS;    /* PSC I2S consumer mode */
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:    /* CODEC slave */
-               ct &= ~PSC_I2SCFG_MS;   /* PSC I2S Master mode */
+       case SND_SOC_DAIFMT_CBC_CFC:    /* CODEC consumer */
+               ct &= ~PSC_I2SCFG_MS;   /* PSC I2S provider mode */
                break;
        default:
                goto out;
index 3d668f4..e3fc4be 100644 (file)
@@ -127,14 +127,14 @@ struct bcm2835_i2s_dev {
 
 static void bcm2835_i2s_start_clock(struct bcm2835_i2s_dev *dev)
 {
-       unsigned int master = dev->fmt & SND_SOC_DAIFMT_MASTER_MASK;
+       unsigned int provider = dev->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK;
 
        if (dev->clk_prepared)
                return;
 
-       switch (master) {
-       case SND_SOC_DAIFMT_CBS_CFS:
-       case SND_SOC_DAIFMT_CBS_CFM:
+       switch (provider) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+       case SND_SOC_DAIFMT_CBC_CFP:
                clk_prepare_enable(dev->clk);
                dev->clk_prepared = true;
                break;
@@ -337,8 +337,8 @@ static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
        unsigned int rx_mask, tx_mask;
        unsigned int rx_ch1_pos, rx_ch2_pos, tx_ch1_pos, tx_ch2_pos;
        unsigned int mode, format;
-       bool bit_clock_master = false;
-       bool frame_sync_master = false;
+       bool bit_clock_provider = false;
+       bool frame_sync_provider = false;
        bool frame_start_falling_edge = false;
        uint32_t csreg;
        int ret = 0;
@@ -383,36 +383,36 @@ static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
        if (data_length > slot_width)
                return -EINVAL;
 
-       /* Check if CPU is bit clock master */
-       switch (dev->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
-       case SND_SOC_DAIFMT_CBS_CFM:
-               bit_clock_master = true;
+       /* Check if CPU is bit clock provider */
+       switch (dev->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+       case SND_SOC_DAIFMT_CBC_CFP:
+               bit_clock_provider = true;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
-       case SND_SOC_DAIFMT_CBM_CFM:
-               bit_clock_master = false;
+       case SND_SOC_DAIFMT_CBP_CFC:
+       case SND_SOC_DAIFMT_CBP_CFP:
+               bit_clock_provider = false;
                break;
        default:
                return -EINVAL;
        }
 
-       /* Check if CPU is frame sync master */
-       switch (dev->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
-       case SND_SOC_DAIFMT_CBM_CFS:
-               frame_sync_master = true;
+       /* Check if CPU is frame sync provider */
+       switch (dev->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+       case SND_SOC_DAIFMT_CBP_CFC:
+               frame_sync_provider = true;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
-       case SND_SOC_DAIFMT_CBM_CFM:
-               frame_sync_master = false;
+       case SND_SOC_DAIFMT_CBC_CFP:
+       case SND_SOC_DAIFMT_CBP_CFP:
+               frame_sync_provider = false;
                break;
        default:
                return -EINVAL;
        }
 
        /* Clock should only be set up here if CPU is clock master */
-       if (bit_clock_master &&
+       if (bit_clock_provider &&
            (!dev->clk_prepared || dev->clk_rate != bclk_rate)) {
                if (dev->clk_prepared)
                        bcm2835_i2s_stop_clock(dev);
@@ -501,11 +501,11 @@ static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
        /*
         * Transmitting data immediately after frame start, eg
         * in left-justified or DSP mode A, only works stable
-        * if bcm2835 is the frame clock master.
+        * if bcm2835 is the frame clock provider.
         */
-       if ((!rx_ch1_pos || !tx_ch1_pos) && !frame_sync_master)
+       if ((!rx_ch1_pos || !tx_ch1_pos) && !frame_sync_provider)
                dev_warn(dev->dev,
-                       "Unstable slave config detected, L/R may be swapped");
+                       "Unstable consumer config detected, L/R may be swapped");
 
        /*
         * Set format for both streams.
@@ -538,11 +538,11 @@ static int bcm2835_i2s_hw_params(struct snd_pcm_substream *substream,
        mode |= BCM2835_I2S_FSLEN(framesync_length);
 
        /* CLKM selects bcm2835 clock slave mode */
-       if (!bit_clock_master)
+       if (!bit_clock_provider)
                mode |= BCM2835_I2S_CLKM;
 
        /* FSM selects bcm2835 frame sync slave mode */
-       if (!frame_sync_master)
+       if (!frame_sync_provider)
                mode |= BCM2835_I2S_FSM;
 
        /* CLKI selects normal clocking mode, sampling on rising edge */
index fca5a3f..9698f45 100644 (file)
@@ -848,12 +848,12 @@ static int cygnus_ssp_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
 
        ssp_newcfg = 0;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                ssp_newcfg |= BIT(I2S_OUT_CFGX_SLAVE_MODE);
                aio->is_slave = 1;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                ssp_newcfg &= ~BIT(I2S_OUT_CFGX_SLAVE_MODE);
                aio->is_slave = 0;
                break;
index 7b6cdc9..3852902 100644 (file)
@@ -60,7 +60,7 @@ static struct snd_soc_dai_link edb93xx_dai = {
        .name           = "CS4271",
        .stream_name    = "CS4271 HiFi",
        .dai_fmt        = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBS_CFS,
+                         SND_SOC_DAIFMT_CBC_CFC,
        .ops            = &edb93xx_ops,
        SND_SOC_DAILINK_REG(hifi),
 };
index 0d26550..06c315a 100644 (file)
@@ -245,14 +245,14 @@ static int ep93xx_i2s_set_dai_fmt(struct snd_soc_dai *cpu_dai,
                return -EINVAL;
        }
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
-               /* CPU is master */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+               /* CPU is provider */
                clk_cfg |= EP93XX_I2S_CLKCFG_MASTER;
                break;
 
-       case SND_SOC_DAIFMT_CBM_CFM:
-               /* Codec is master */
+       case SND_SOC_DAIFMT_CBP_CFP:
+               /* Codec is provider */
                clk_cfg &= ~EP93XX_I2S_CLKCFG_MASTER;
                break;
 
index c4b1129..a286f5b 100644 (file)
@@ -70,7 +70,7 @@ static struct snd_soc_dai_link snappercl15_dai = {
        .name           = "tlv320aic23",
        .stream_name    = "AIC23",
        .dai_fmt        = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBS_CFS,
+                         SND_SOC_DAIFMT_CBC_CFC,
        .ops            = &snappercl15_ops,
        SND_SOC_DAILINK_REG(aic23),
 };
index cac7e55..c6043fa 100644 (file)
@@ -968,16 +968,16 @@ static int pm860x_pcm_set_dai_fmt(struct snd_soc_dai *codec_dai,
 
        mask |= PCM_INF2_BCLK | PCM_INF2_FS | PCM_INF2_MASTER;
 
-       /* set master/slave audio interface */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
-       case SND_SOC_DAIFMT_CBM_CFS:
+       /* set audio interface clocking */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+       case SND_SOC_DAIFMT_CBP_CFC:
                if (pm860x->dir == PM860X_CLK_DIR_OUT) {
                        inf |= PCM_INF2_MASTER;
                        ret = 0;
                }
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                if (pm860x->dir == PM860X_CLK_DIR_IN) {
                        inf &= ~PCM_INF2_MASTER;
                        ret = 0;
@@ -1072,15 +1072,15 @@ static int pm860x_i2s_set_dai_fmt(struct snd_soc_dai *codec_dai,
 
        mask |= PCM_INF2_BCLK | PCM_INF2_FS | PCM_INF2_MASTER;
 
-       /* set master/slave audio interface */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       /* set audio interface clocking */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                if (pm860x->dir == PM860X_CLK_DIR_OUT)
                        inf |= PCM_INF2_MASTER;
                else
                        return -EINVAL;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                if (pm860x->dir == PM860X_CLK_DIR_IN)
                        inf &= ~PCM_INF2_MASTER;
                else
index 216cea0..326f2d6 100644 (file)
@@ -61,6 +61,8 @@ config SND_SOC_ALL_CODECS
        imply SND_SOC_CS35L34
        imply SND_SOC_CS35L35
        imply SND_SOC_CS35L36
+       imply SND_SOC_CS35L41_SPI
+       imply SND_SOC_CS35L41_I2C
        imply SND_SOC_CS42L42
        imply SND_SOC_CS42L51_I2C
        imply SND_SOC_CS42L52
@@ -115,6 +117,7 @@ config SND_SOC_ALL_CODECS
        imply SND_SOC_MAX98357A
        imply SND_SOC_MAX98371
        imply SND_SOC_MAX98504
+       imply SND_SOC_MAX98520
        imply SND_SOC_MAX9867
        imply SND_SOC_MAX98925
        imply SND_SOC_MAX98926
@@ -136,6 +139,7 @@ config SND_SOC_ALL_CODECS
        imply SND_SOC_NAU8315
        imply SND_SOC_NAU8540
        imply SND_SOC_NAU8810
+       imply SND_SOC_NAU8821
        imply SND_SOC_NAU8822
        imply SND_SOC_NAU8824
        imply SND_SOC_NAU8825
@@ -180,6 +184,7 @@ config SND_SOC_ALL_CODECS
        imply SND_SOC_RT5677
        imply SND_SOC_RT5682_I2C
        imply SND_SOC_RT5682_SDW
+       imply SND_SOC_RT5682S
        imply SND_SOC_RT700_SDW
        imply SND_SOC_RT711_SDW
        imply SND_SOC_RT711_SDCA_SDW
@@ -187,6 +192,7 @@ config SND_SOC_ALL_CODECS
        imply SND_SOC_RT715_SDCA_SDW
        imply SND_SOC_RT1308_SDW
        imply SND_SOC_RT1316_SDW
+       imply SND_SOC_RT9120
        imply SND_SOC_SDW_MOCKUP
        imply SND_SOC_SGTL5000
        imply SND_SOC_SI476X
@@ -330,6 +336,7 @@ config SND_SOC_WM_HUBS
 
 config SND_SOC_WM_ADSP
        tristate
+       select CS_DSP
        select SND_SOC_COMPRESS
        default y if SND_SOC_MADERA=y
        default y if SND_SOC_CS47L24=y
@@ -602,6 +609,16 @@ config SND_SOC_CS35L36
        tristate "Cirrus Logic CS35L36 CODEC"
        depends on I2C
 
+config SND_SOC_CS35L41_SPI
+       tristate "Cirrus Logic CS35L41 CODEC (SPI)"
+       depends on SPI_MASTER
+       select REGMAP_SPI
+
+config SND_SOC_CS35L41_I2C
+       tristate "Cirrus Logic CS35L41 CODEC (I2C)"
+       depends on I2C
+       select REGMAP_I2C
+
 config SND_SOC_CS42L42
        tristate "Cirrus Logic CS42L42 CODEC"
        depends on I2C
@@ -922,6 +939,17 @@ config SND_SOC_MAX98927
        tristate "Maxim Integrated MAX98927 Speaker Amplifier"
        depends on I2C
 
+config SND_SOC_MAX98520
+       tristate "Maxim Integrated MAX98520 Speaker Amplifier"
+       depends on I2C
+       help
+         Enable support for Maxim Integrated MAX98520 audio
+         amplifier, which implements a tripler charge pump
+         based boost converter and supports sample rates of
+         8KHz to 192KHz.
+
+         To compile this driver as a module, choose M here.
+
 config SND_SOC_MAX98373
        tristate
 
@@ -1249,6 +1277,10 @@ config SND_SOC_RT5682_SDW
        select SND_SOC_RT5682
        select REGMAP_SOUNDWIRE
 
+config SND_SOC_RT5682S
+       tristate
+       depends on I2C
+
 config SND_SOC_RT700
        tristate
 
@@ -1288,6 +1320,15 @@ config SND_SOC_RT715_SDCA_SDW
        select REGMAP_SOUNDWIRE
        select REGMAP_SOUNDWIRE_MBQ
 
+config SND_SOC_RT9120
+       tristate "Richtek RT9120 Stereo Class-D Amplifier"
+       depends on I2C
+       select REGMAP_I2C
+       select GPIOLIB
+       help
+         Enable support for Richtek RT9120 20W, stereo, inductor-less,
+         high-efficiency Class-D audio amplifier.
+
 config SND_SOC_SDW_MOCKUP
        tristate "SoundWire mockup codec"
        depends on EXPERT
@@ -1905,6 +1946,10 @@ config SND_SOC_NAU8810
        tristate "Nuvoton Technology Corporation NAU88C10 CODEC"
        depends on I2C
 
+config SND_SOC_NAU8821
+       tristate "Nuvoton Technology Corporation NAU88L21 CODEC"
+       depends on I2C
+
 config SND_SOC_NAU8822
        tristate "Nuvoton Technology Corporation NAU88C22 CODEC"
        depends on I2C
index 8dcea2c..9acfbcb 100644 (file)
@@ -54,6 +54,8 @@ snd-soc-cs35l33-objs := cs35l33.o
 snd-soc-cs35l34-objs := cs35l34.o
 snd-soc-cs35l35-objs := cs35l35.o
 snd-soc-cs35l36-objs := cs35l36.o
+snd-soc-cs35l41-spi-objs := cs35l41-spi.o cs35l41.o cs35l41-tables.o
+snd-soc-cs35l41-i2c-objs := cs35l41-i2c.o cs35l41.o cs35l41-tables.o
 snd-soc-cs42l42-objs := cs42l42.o
 snd-soc-cs42l51-objs := cs42l51.o
 snd-soc-cs42l51-i2c-objs := cs42l51-i2c.o
@@ -123,6 +125,7 @@ snd-soc-max9867-objs := max9867.o
 snd-soc-max98925-objs := max98925.o
 snd-soc-max98926-objs := max98926.o
 snd-soc-max98927-objs := max98927.o
+snd-soc-max98520-objs := max98520.o
 snd-soc-max98373-objs := max98373.o
 snd-soc-max98373-i2c-objs := max98373-i2c.o
 snd-soc-max98373-sdw-objs := max98373-sdw.o
@@ -141,6 +144,7 @@ snd-soc-mt6660-objs := mt6660.o
 snd-soc-nau8315-objs := nau8315.o
 snd-soc-nau8540-objs := nau8540.o
 snd-soc-nau8810-objs := nau8810.o
+snd-soc-nau8821-objs := nau8821.o
 snd-soc-nau8822-objs := nau8822.o
 snd-soc-nau8824-objs := nau8824.o
 snd-soc-nau8825-objs := nau8825.o
@@ -198,11 +202,13 @@ snd-soc-rt5677-spi-objs := rt5677-spi.o
 snd-soc-rt5682-objs := rt5682.o
 snd-soc-rt5682-sdw-objs := rt5682-sdw.o
 snd-soc-rt5682-i2c-objs := rt5682-i2c.o
+snd-soc-rt5682s-objs := rt5682s.o
 snd-soc-rt700-objs := rt700.o rt700-sdw.o
 snd-soc-rt711-objs := rt711.o rt711-sdw.o
 snd-soc-rt711-sdca-objs := rt711-sdca.o rt711-sdca-sdw.o
 snd-soc-rt715-objs := rt715.o rt715-sdw.o
 snd-soc-rt715-sdca-objs := rt715-sdca.o rt715-sdca-sdw.o
+snd-soc-rt9120-objs := rt9120.o
 snd-soc-sdw-mockup-objs := sdw-mockup.o
 snd-soc-sgtl5000-objs := sgtl5000.o
 snd-soc-alc5623-objs := alc5623.o
@@ -385,6 +391,8 @@ obj-$(CONFIG_SND_SOC_CS35L33)       += snd-soc-cs35l33.o
 obj-$(CONFIG_SND_SOC_CS35L34)  += snd-soc-cs35l34.o
 obj-$(CONFIG_SND_SOC_CS35L35)  += snd-soc-cs35l35.o
 obj-$(CONFIG_SND_SOC_CS35L36)  += snd-soc-cs35l36.o
+obj-$(CONFIG_SND_SOC_CS35L41_SPI)      += snd-soc-cs35l41-spi.o
+obj-$(CONFIG_SND_SOC_CS35L41_I2C)      += snd-soc-cs35l41-i2c.o
 obj-$(CONFIG_SND_SOC_CS42L42)  += snd-soc-cs42l42.o
 obj-$(CONFIG_SND_SOC_CS42L51)  += snd-soc-cs42l51.o
 obj-$(CONFIG_SND_SOC_CS42L51_I2C)      += snd-soc-cs42l51-i2c.o
@@ -450,6 +458,7 @@ obj-$(CONFIG_SND_SOC_MAX9867)       += snd-soc-max9867.o
 obj-$(CONFIG_SND_SOC_MAX98925) += snd-soc-max98925.o
 obj-$(CONFIG_SND_SOC_MAX98926) += snd-soc-max98926.o
 obj-$(CONFIG_SND_SOC_MAX98927) += snd-soc-max98927.o
+obj-$(CONFIG_SND_SOC_MAX98520) += snd-soc-max98520.o
 obj-$(CONFIG_SND_SOC_MAX98373) += snd-soc-max98373.o
 obj-$(CONFIG_SND_SOC_MAX98373_I2C)   += snd-soc-max98373-i2c.o
 obj-$(CONFIG_SND_SOC_MAX98373_SDW)   += snd-soc-max98373-sdw.o
@@ -468,6 +477,7 @@ obj-$(CONFIG_SND_SOC_MT6660)        += snd-soc-mt6660.o
 obj-$(CONFIG_SND_SOC_NAU8315)   += snd-soc-nau8315.o
 obj-$(CONFIG_SND_SOC_NAU8540)   += snd-soc-nau8540.o
 obj-$(CONFIG_SND_SOC_NAU8810)   += snd-soc-nau8810.o
+obj-$(CONFIG_SND_SOC_NAU8821)   += snd-soc-nau8821.o
 obj-$(CONFIG_SND_SOC_NAU8822)   += snd-soc-nau8822.o
 obj-$(CONFIG_SND_SOC_NAU8824)   += snd-soc-nau8824.o
 obj-$(CONFIG_SND_SOC_NAU8825)   += snd-soc-nau8825.o
@@ -526,11 +536,13 @@ obj-$(CONFIG_SND_SOC_RT5677_SPI)  += snd-soc-rt5677-spi.o
 obj-$(CONFIG_SND_SOC_RT5682)   += snd-soc-rt5682.o
 obj-$(CONFIG_SND_SOC_RT5682_I2C)       += snd-soc-rt5682-i2c.o
 obj-$(CONFIG_SND_SOC_RT5682_SDW)       += snd-soc-rt5682-sdw.o
+obj-$(CONFIG_SND_SOC_RT5682S)  += snd-soc-rt5682s.o
 obj-$(CONFIG_SND_SOC_RT700)     += snd-soc-rt700.o
 obj-$(CONFIG_SND_SOC_RT711)     += snd-soc-rt711.o
 obj-$(CONFIG_SND_SOC_RT711_SDCA_SDW)     += snd-soc-rt711-sdca.o
 obj-$(CONFIG_SND_SOC_RT715)     += snd-soc-rt715.o
 obj-$(CONFIG_SND_SOC_RT715_SDCA_SDW)     += snd-soc-rt715-sdca.o
+obj-$(CONFIG_SND_SOC_RT9120)   += snd-soc-rt9120.o
 obj-$(CONFIG_SND_SOC_SDW_MOCKUP)     += snd-soc-sdw-mockup.o
 obj-$(CONFIG_SND_SOC_SGTL5000)  += snd-soc-sgtl5000.o
 obj-$(CONFIG_SND_SOC_SIGMADSP) += snd-soc-sigmadsp.o
index 5525e1c..aefafb0 100644 (file)
@@ -2104,26 +2104,26 @@ static int ab8500_codec_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                        BIT(AB8500_DIGIFCONF3_IF0MASTER);
        val = 0;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM: /* codec clk & FRM master */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                dev_dbg(dai->component->dev,
-                       "%s: IF0 Master-mode: AB8500 master.\n", __func__);
+                       "%s: IF0 Master-mode: AB8500 provider.\n", __func__);
                val |= BIT(AB8500_DIGIFCONF3_IF0MASTER);
                break;
-       case SND_SOC_DAIFMT_CBS_CFS: /* codec clk & FRM slave */
+       case SND_SOC_DAIFMT_CBC_CFC:
                dev_dbg(dai->component->dev,
-                       "%s: IF0 Master-mode: AB8500 slave.\n", __func__);
+                       "%s: IF0 Master-mode: AB8500 consumer.\n", __func__);
                break;
-       case SND_SOC_DAIFMT_CBS_CFM: /* codec clk slave & FRM master */
-       case SND_SOC_DAIFMT_CBM_CFS: /* codec clk master & frame slave */
+       case SND_SOC_DAIFMT_CBC_CFP:
+       case SND_SOC_DAIFMT_CBP_CFC:
                dev_err(dai->component->dev,
-                       "%s: ERROR: The device is either a master or a slave.\n",
+                       "%s: ERROR: The device is either a provider or a consumer.\n",
                        __func__);
                fallthrough;
        default:
                dev_err(dai->component->dev,
-                       "%s: ERROR: Unsupporter master mask 0x%x\n",
-                       __func__, fmt & SND_SOC_DAIFMT_MASTER_MASK);
+                       "%s: ERROR: Unsupporter clocking mask 0x%x\n",
+                       __func__, fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK);
                return -EINVAL;
        }
 
index 08a5651..29e1689 100644 (file)
@@ -148,9 +148,9 @@ static int ad1836_set_dai_fmt(struct snd_soc_dai *codec_dai,
                return -EINVAL;
        }
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       /* ALCLK,ABCLK are both output, AD1836 can only be master */
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       /* ALCLK,ABCLK are both output, AD1836 can only be provider */
+       case SND_SOC_DAIFMT_CBP_CFP:
                break;
        default:
                return -EINVAL;
index 278a55a..30b98b4 100644 (file)
@@ -243,22 +243,22 @@ static int ad193x_set_dai_fmt(struct snd_soc_dai *codec_dai,
        if (fmt & SND_SOC_DAIFMT_DSP_A)
                dac_fmt ^= AD193X_DAC_LEFT_HIGH;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM: /* codec clk & frm master */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                adc_fmt |= AD193X_ADC_LCR_MASTER;
                adc_fmt |= AD193X_ADC_BCLK_MASTER;
                dac_fmt |= AD193X_DAC_LCR_MASTER;
                dac_fmt |= AD193X_DAC_BCLK_MASTER;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM: /* codec clk slave & frm master */
+       case SND_SOC_DAIFMT_CBC_CFP:
                adc_fmt |= AD193X_ADC_LCR_MASTER;
                dac_fmt |= AD193X_DAC_LCR_MASTER;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS: /* codec clk master & frame slave */
+       case SND_SOC_DAIFMT_CBP_CFC:
                adc_fmt |= AD193X_ADC_BCLK_MASTER;
                dac_fmt |= AD193X_DAC_BCLK_MASTER;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS: /* codec clk & frm slave */
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index 6811a8b..1faa4c4 100644 (file)
@@ -30,7 +30,7 @@ struct adau1372 {
        void (*switch_mode)(struct device *dev);
        bool use_pll;
        bool enabled;
-       bool master;
+       bool clock_provider;
 
        struct snd_pcm_hw_constraint_list rate_constraints;
        unsigned int slot_width;
@@ -578,13 +578,13 @@ static int adau1372_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        unsigned int sai0 = 0, sai1 = 0;
        bool invert_lrclk = false;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
-               adau1372->master = true;
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               adau1372->clock_provider = true;
                sai1 |= ADAU1372_SAI1_MS;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
-               adau1372->master = false;
+       case SND_SOC_DAIFMT_CBC_CFC:
+               adau1372->clock_provider = false;
                break;
        default:
                return -EINVAL;
@@ -714,7 +714,7 @@ static int adau1372_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
                break;
        case 4:
                sai0 = ADAU1372_SAI0_SAI_TDM4;
-               if (adau1372->master)
+               if (adau1372->clock_provider)
                        adau1372->rate_constraints.mask = ADAU1372_RATE_MASK_TDM4_MASTER;
                else
                        adau1372->rate_constraints.mask = ADAU1372_RATE_MASK_TDM4;
index 9887aa6..46128aa 100644 (file)
@@ -28,7 +28,7 @@ struct adau1373_dai {
        unsigned int clk_src;
        unsigned int sysclk;
        bool enable_src;
-       bool master;
+       bool clock_provider;
 };
 
 struct adau1373 {
@@ -827,7 +827,7 @@ static int adau1373_check_aif_clk(struct snd_soc_dapm_widget *source,
 
        dai = sink->name[3] - '1';
 
-       if (!adau1373->dais[dai].master)
+       if (!adau1373->dais[dai].clock_provider)
                return 0;
 
        if (adau1373->dais[dai].clk_src == ADAU1373_CLK_SRC_PLL1)
@@ -1102,14 +1102,14 @@ static int adau1373_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        struct adau1373_dai *adau1373_dai = &adau1373->dais[dai->id];
        unsigned int ctrl;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                ctrl = ADAU1373_DAI_MASTER;
-               adau1373_dai->master = true;
+               adau1373_dai->clock_provider = true;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                ctrl = 0;
-               adau1373_dai->master = false;
+               adau1373_dai->clock_provider = false;
                break;
        default:
                return -EINVAL;
index 5ce7469..c5bf461 100644 (file)
@@ -482,13 +482,13 @@ static int adau1701_set_dai_fmt(struct snd_soc_dai *codec_dai,
        unsigned int serictl = 0x00, seroctl = 0x00;
        bool invert_lrclk;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                /* master, 64-bits per sample, 1 frame per sample */
                seroctl |= ADAU1701_SEROCTL_MASTER | ADAU1701_SEROCTL_OBF16
                                | ADAU1701_SEROCTL_OLF1024;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index 8aae7ab..af05463 100644 (file)
@@ -556,12 +556,12 @@ static int adau17x1_set_dai_fmt(struct snd_soc_dai *dai,
        unsigned int ctrl0_mask;
        int lrclk_pol;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                ctrl0 = ADAU17X1_SERIAL_PORT0_MASTER;
                adau->master = true;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                ctrl0 = 0;
                adau->master = false;
                break;
index e347a48..5fcbdf2 100644 (file)
@@ -124,10 +124,10 @@ struct adau1977 {
        struct device *dev;
        void (*switch_mode)(struct device *dev);
 
-       unsigned int max_master_fs;
+       unsigned int max_clock_provider_fs;
        unsigned int slot_width;
        bool enabled;
-       bool master;
+       bool clock_provider;
 };
 
 static const struct reg_default adau1977_reg_defaults[] = {
@@ -330,7 +330,7 @@ static int adau1977_hw_params(struct snd_pcm_substream *substream,
                ctrl0_mask |= ADAU1977_SAI_CTRL0_FMT_MASK;
        }
 
-       if (adau1977->master) {
+       if (adau1977->clock_provider) {
                switch (params_width(params)) {
                case 16:
                        ctrl1 = ADAU1977_SAI_CTRL1_DATA_WIDTH_16BIT;
@@ -504,7 +504,7 @@ static int adau1977_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
        if (slots == 0) {
                /* 0 = No fixed slot width */
                adau1977->slot_width = 0;
-               adau1977->max_master_fs = 192000;
+               adau1977->max_clock_provider_fs = 192000;
                return regmap_update_bits(adau1977->regmap,
                        ADAU1977_REG_SAI_CTRL0, ADAU1977_SAI_CTRL0_SAI_MASK,
                        ADAU1977_SAI_CTRL0_SAI_I2S);
@@ -533,7 +533,7 @@ static int adau1977_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
                break;
        case 24:
                /* We can only generate 16 bit or 32 bit wide slots */
-               if (adau1977->master)
+               if (adau1977->clock_provider)
                        return -EINVAL;
                ctrl1 = ADAU1977_SAI_CTRL1_SLOT_WIDTH_24;
                break;
@@ -593,8 +593,8 @@ static int adau1977_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
 
        adau1977->slot_width = width;
 
-       /* In master mode the maximum bitclock is 24.576 MHz */
-       adau1977->max_master_fs = min(192000, 24576000 / width / slots);
+       /* In clock provider mode the maximum bitclock is 24.576 MHz */
+       adau1977->max_clock_provider_fs = min(192000, 24576000 / width / slots);
 
        return 0;
 }
@@ -620,13 +620,13 @@ static int adau1977_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        bool invert_lrclk;
        int ret;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
-               adau1977->master = false;
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+               adau1977->clock_provider = false;
                break;
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                ctrl1 |= ADAU1977_SAI_CTRL1_MASTER;
-               adau1977->master = true;
+               adau1977->clock_provider = true;
                break;
        default:
                return -EINVAL;
@@ -714,9 +714,10 @@ static int adau1977_startup(struct snd_pcm_substream *substream,
        snd_pcm_hw_constraint_list(substream->runtime, 0,
                SNDRV_PCM_HW_PARAM_RATE, &adau1977->constraints);
 
-       if (adau1977->master)
+       if (adau1977->clock_provider)
                snd_pcm_hw_constraint_minmax(substream->runtime,
-                       SNDRV_PCM_HW_PARAM_RATE, 8000, adau1977->max_master_fs);
+                       SNDRV_PCM_HW_PARAM_RATE, 8000,
+                                            adau1977->max_clock_provider_fs);
 
        if (formats != 0)
                snd_pcm_hw_constraint_mask64(substream->runtime,
@@ -913,7 +914,7 @@ int adau1977_probe(struct device *dev, struct regmap *regmap,
        adau1977->type = type;
        adau1977->regmap = regmap;
        adau1977->switch_mode = switch_mode;
-       adau1977->max_master_fs = 192000;
+       adau1977->max_clock_provider_fs = 192000;
 
        adau1977->constraints.list = adau1977_rates;
        adau1977->constraints.count = ARRAY_SIZE(adau1977_rates);
index 75a6491..90f3a5e 100644 (file)
@@ -369,12 +369,12 @@ static int adav80x_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        unsigned int capture = 0x00;
        unsigned int playback = 0x00;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                capture |= ADAV80X_CAPTURE_MODE_MASTER;
                playback |= ADAV80X_PLAYBACK_MODE_MASTER;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index 979cfb1..dc4747c 100644 (file)
@@ -81,8 +81,8 @@ static int ak4104_set_dai_fmt(struct snd_soc_dai *codec_dai,
                return -EINVAL;
        }
 
-       /* This device can only be slave */
-       if ((format & SND_SOC_DAIFMT_MASTER_MASK) != SND_SOC_DAIFMT_CBS_CFS)
+       /* This device can only be consumer */
+       if ((format & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) != SND_SOC_DAIFMT_CBC_CFC)
                return -EINVAL;
 
        ret = regmap_update_bits(ak4104->regmap, AK4104_REG_CONTROL1,
index 5d46ae8..e0a6451 100644 (file)
@@ -151,8 +151,8 @@ static const struct snd_soc_dapm_route ak4118_dapm_routes[] = {
 };
 
 
-static int ak4118_set_dai_fmt_master(struct ak4118_priv *ak4118,
-                                    unsigned int format)
+static int ak4118_set_dai_fmt_provider(struct ak4118_priv *ak4118,
+                                      unsigned int format)
 {
        int dif;
 
@@ -173,8 +173,8 @@ static int ak4118_set_dai_fmt_master(struct ak4118_priv *ak4118,
        return dif;
 }
 
-static int ak4118_set_dai_fmt_slave(struct ak4118_priv *ak4118,
-                                   unsigned int format)
+static int ak4118_set_dai_fmt_consumer(struct ak4118_priv *ak4118,
+                                      unsigned int format)
 {
        int dif;
 
@@ -201,14 +201,12 @@ static int ak4118_set_dai_fmt(struct snd_soc_dai *dai,
        int dif;
        int ret = 0;
 
-       switch (format & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
-               /* component is master */
-               dif = ak4118_set_dai_fmt_master(ak4118, format);
+       switch (format & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               dif = ak4118_set_dai_fmt_provider(ak4118, format);
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
-               /*component is slave */
-               dif = ak4118_set_dai_fmt_slave(ak4118, format);
+       case SND_SOC_DAIFMT_CBC_CFC:
+               dif = ak4118_set_dai_fmt_consumer(ak4118, format);
                break;
        default:
                ret = -ENOTSUPP;
index 29eb787..baa9ff5 100644 (file)
@@ -464,14 +464,14 @@ static int ak4458_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        struct ak4458_priv *ak4458 = snd_soc_component_get_drvdata(component);
        int ret;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS: /* Slave Mode */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC: /* Consumer Mode */
                break;
-       case SND_SOC_DAIFMT_CBM_CFM: /* Master Mode is not supported */
-       case SND_SOC_DAIFMT_CBS_CFM:
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFP: /* Provider Mode is not supported */
+       case SND_SOC_DAIFMT_CBC_CFP:
+       case SND_SOC_DAIFMT_CBP_CFC:
        default:
-               dev_err(component->dev, "Master mode unsupported\n");
+               dev_err(component->dev, "Clock provider mode unsupported\n");
                return -EINVAL;
        }
 
index c49c58e..c284dcc 100644 (file)
@@ -392,13 +392,13 @@ static int ak4642_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        data = MCKO | PMPLL; /* use MCKO */
        bcko = 0;
 
-       /* set master/slave audio interface */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       /* set clocking for audio interface */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                data |= MS;
                bcko = BCKO_64;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index eb43523..e9d1251 100644 (file)
@@ -520,11 +520,11 @@ static int ak4671_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        /* set master/slave audio interface */
        mode = snd_soc_component_read(component, AK4671_PLL_MODE_SELECT1);
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                mode |= AK4671_M_S;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFC:
                mode &= ~(AK4671_M_S);
                break;
        default:
index 37d4600..c94cfde 100644 (file)
@@ -198,13 +198,13 @@ static int ak5558_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        struct snd_soc_component *component = dai->component;
        u8 format;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBC_CFP:
+       case SND_SOC_DAIFMT_CBP_CFC:
        default:
                dev_err(dai->dev, "Clock mode unsupported");
                return -EINVAL;
index 54f4898..b10357a 100644 (file)
@@ -641,12 +641,12 @@ static int alc5623_set_dai_fmt(struct snd_soc_dai *codec_dai,
        struct snd_soc_component *component = codec_dai->component;
        u16 iface = 0;
 
-       /* set master/slave audio interface */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       /* set audio interface clocking */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                iface = ALC5623_DAI_SDP_MASTER_MODE;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                iface = ALC5623_DAI_SDP_SLAVE_MODE;
                break;
        default:
index 7981388..6d7af37 100644 (file)
@@ -815,12 +815,12 @@ static int alc5632_set_dai_fmt(struct snd_soc_dai *codec_dai,
        struct snd_soc_component *component = codec_dai->component;
        u16 iface = 0;
 
-       /* set master/slave audio interface */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       /* set audio interface clocking */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                iface = ALC5632_DAI_SDP_MASTER_MODE;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                iface = ALC5632_DAI_SDP_SLAVE_MODE;
                break;
        default:
index 05bbacd..598e090 100644 (file)
@@ -1168,15 +1168,15 @@ static int cpcap_hifi_set_dai_fmt(struct snd_soc_dai *codec_dai,
 
        /*
         * "HiFi Playback" should always be configured as
-        * SND_SOC_DAIFMT_CBM_CFM - codec clk & frm master
+        * SND_SOC_DAIFMT_CBP_CFP - codec clk & frm provider
         * SND_SOC_DAIFMT_I2S - I2S mode
         */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                val &= ~BIT(CPCAP_BIT_SMB_ST_DAC);
                break;
        default:
-               dev_err(dev, "HiFi dai fmt failed: CPCAP should be master");
+               dev_err(dev, "HiFi dai fmt failed: CPCAP should be provider");
                return -EINVAL;
        }
 
@@ -1318,15 +1318,15 @@ static int cpcap_voice_set_dai_fmt(struct snd_soc_dai *codec_dai,
 
        /*
         * "Voice Playback" and "Voice Capture" should always be
-        * configured as SND_SOC_DAIFMT_CBM_CFM - codec clk & frm
-        * master
+        * configured as SND_SOC_DAIFMT_CBP_CFP - codec clk & frm
+        * provider
         */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                val &= ~BIT(CPCAP_BIT_SMB_CDC);
                break;
        default:
-               dev_err(component->dev, "Voice dai fmt failed: CPCAP should be the master");
+               dev_err(component->dev, "Voice dai fmt failed: CPCAP should be the provider");
                val &= ~BIT(CPCAP_BIT_SMB_CDC);
                break;
        }
index a201d65..9b92e1a 100644 (file)
@@ -283,8 +283,8 @@ static int i2s_rx_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
        struct ec_param_ec_codec_i2s_rx p;
        enum ec_codec_i2s_rx_daifmt daifmt;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
diff --git a/sound/soc/codecs/cs35l41-i2c.c b/sound/soc/codecs/cs35l41-i2c.c
new file mode 100644 (file)
index 0000000..d5fa8d2
--- /dev/null
@@ -0,0 +1,115 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// cs35l41-i2c.c -- CS35l41 I2C driver
+//
+// Copyright 2017-2021 Cirrus Logic, Inc.
+//
+// Author: David Rhodes <david.rhodes@cirrus.com>
+
+#include <linux/acpi.h>
+#include <linux/delay.h>
+#include <linux/i2c.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+
+#include <sound/cs35l41.h>
+#include "cs35l41.h"
+
+static struct regmap_config cs35l41_regmap_i2c = {
+       .reg_bits = 32,
+       .val_bits = 32,
+       .reg_stride = CS35L41_REGSTRIDE,
+       .reg_format_endian = REGMAP_ENDIAN_BIG,
+       .val_format_endian = REGMAP_ENDIAN_BIG,
+       .max_register = CS35L41_LASTREG,
+       .reg_defaults = cs35l41_reg,
+       .num_reg_defaults = ARRAY_SIZE(cs35l41_reg),
+       .volatile_reg = cs35l41_volatile_reg,
+       .readable_reg = cs35l41_readable_reg,
+       .precious_reg = cs35l41_precious_reg,
+       .cache_type = REGCACHE_RBTREE,
+};
+
+static const struct i2c_device_id cs35l41_id_i2c[] = {
+       { "cs35l40", 0 },
+       { "cs35l41", 0 },
+       {}
+};
+
+MODULE_DEVICE_TABLE(i2c, cs35l41_id_i2c);
+
+static int cs35l41_i2c_probe(struct i2c_client *client,
+                            const struct i2c_device_id *id)
+{
+       struct cs35l41_private *cs35l41;
+       struct device *dev = &client->dev;
+       struct cs35l41_platform_data *pdata = dev_get_platdata(dev);
+       const struct regmap_config *regmap_config = &cs35l41_regmap_i2c;
+       int ret;
+
+       cs35l41 = devm_kzalloc(dev, sizeof(struct cs35l41_private), GFP_KERNEL);
+
+       if (!cs35l41)
+               return -ENOMEM;
+
+       cs35l41->dev = dev;
+       cs35l41->irq = client->irq;
+
+       i2c_set_clientdata(client, cs35l41);
+       cs35l41->regmap = devm_regmap_init_i2c(client, regmap_config);
+       if (IS_ERR(cs35l41->regmap)) {
+               ret = PTR_ERR(cs35l41->regmap);
+               dev_err(cs35l41->dev, "Failed to allocate register map: %d\n", ret);
+               return ret;
+       }
+
+       return cs35l41_probe(cs35l41, pdata);
+}
+
+static int cs35l41_i2c_remove(struct i2c_client *client)
+{
+       struct cs35l41_private *cs35l41 = i2c_get_clientdata(client);
+
+       cs35l41_remove(cs35l41);
+
+       return 0;
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id cs35l41_of_match[] = {
+       { .compatible = "cirrus,cs35l40" },
+       { .compatible = "cirrus,cs35l41" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, cs35l41_of_match);
+#endif
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id cs35l41_acpi_match[] = {
+       { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */
+       {},
+};
+MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
+#endif
+
+static struct i2c_driver cs35l41_i2c_driver = {
+       .driver = {
+               .name           = "cs35l41",
+               .of_match_table = of_match_ptr(cs35l41_of_match),
+               .acpi_match_table = ACPI_PTR(cs35l41_acpi_match),
+       },
+       .id_table       = cs35l41_id_i2c,
+       .probe          = cs35l41_i2c_probe,
+       .remove         = cs35l41_i2c_remove,
+};
+
+module_i2c_driver(cs35l41_i2c_driver);
+
+MODULE_DESCRIPTION("I2C CS35L41 driver");
+MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/codecs/cs35l41-spi.c b/sound/soc/codecs/cs35l41-spi.c
new file mode 100644 (file)
index 0000000..90a921f
--- /dev/null
@@ -0,0 +1,140 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// cs35l41-spi.c -- CS35l41 SPI driver
+//
+// Copyright 2017-2021 Cirrus Logic, Inc.
+//
+// Author: David Rhodes        <david.rhodes@cirrus.com>
+
+#include <linux/acpi.h>
+#include <linux/delay.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/platform_device.h>
+#include <linux/spi/spi.h>
+
+#include <sound/cs35l41.h>
+#include "cs35l41.h"
+
+static struct regmap_config cs35l41_regmap_spi = {
+       .reg_bits = 32,
+       .val_bits = 32,
+       .pad_bits = 16,
+       .reg_stride = CS35L41_REGSTRIDE,
+       .reg_format_endian = REGMAP_ENDIAN_BIG,
+       .val_format_endian = REGMAP_ENDIAN_BIG,
+       .max_register = CS35L41_LASTREG,
+       .reg_defaults = cs35l41_reg,
+       .num_reg_defaults = ARRAY_SIZE(cs35l41_reg),
+       .volatile_reg = cs35l41_volatile_reg,
+       .readable_reg = cs35l41_readable_reg,
+       .precious_reg = cs35l41_precious_reg,
+       .cache_type = REGCACHE_RBTREE,
+};
+
+static const struct spi_device_id cs35l41_id_spi[] = {
+       { "cs35l40", 0 },
+       { "cs35l41", 0 },
+       {}
+};
+
+MODULE_DEVICE_TABLE(spi, cs35l41_id_spi);
+
+static void cs35l41_spi_otp_setup(struct cs35l41_private *cs35l41,
+                                 bool is_pre_setup, unsigned int *freq)
+{
+       struct spi_device *spi;
+       u32 orig_spi_freq;
+
+       spi = to_spi_device(cs35l41->dev);
+
+       if (!spi) {
+               dev_err(cs35l41->dev, "%s: No SPI device\n", __func__);
+               return;
+       }
+
+       if (is_pre_setup) {
+               orig_spi_freq = spi->max_speed_hz;
+               if (orig_spi_freq > CS35L41_SPI_MAX_FREQ_OTP) {
+                       spi->max_speed_hz = CS35L41_SPI_MAX_FREQ_OTP;
+                       spi_setup(spi);
+               }
+               *freq = orig_spi_freq;
+       } else {
+               if (spi->max_speed_hz != *freq) {
+                       spi->max_speed_hz = *freq;
+                       spi_setup(spi);
+               }
+       }
+}
+
+static int cs35l41_spi_probe(struct spi_device *spi)
+{
+       const struct regmap_config *regmap_config = &cs35l41_regmap_spi;
+       struct cs35l41_platform_data *pdata = dev_get_platdata(&spi->dev);
+       struct cs35l41_private *cs35l41;
+       int ret;
+
+       cs35l41 = devm_kzalloc(&spi->dev, sizeof(struct cs35l41_private), GFP_KERNEL);
+       if (!cs35l41)
+               return -ENOMEM;
+
+       spi_set_drvdata(spi, cs35l41);
+       cs35l41->regmap = devm_regmap_init_spi(spi, regmap_config);
+       if (IS_ERR(cs35l41->regmap)) {
+               ret = PTR_ERR(cs35l41->regmap);
+               dev_err(&spi->dev, "Failed to allocate register map: %d\n", ret);
+               return ret;
+       }
+
+       cs35l41->dev = &spi->dev;
+       cs35l41->irq = spi->irq;
+       cs35l41->otp_setup = cs35l41_spi_otp_setup;
+
+       return cs35l41_probe(cs35l41, pdata);
+}
+
+static int cs35l41_spi_remove(struct spi_device *spi)
+{
+       struct cs35l41_private *cs35l41 = spi_get_drvdata(spi);
+
+       cs35l41_remove(cs35l41);
+
+       return 0;
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id cs35l41_of_match[] = {
+       { .compatible = "cirrus,cs35l40" },
+       { .compatible = "cirrus,cs35l41" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, cs35l41_of_match);
+#endif
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id cs35l41_acpi_match[] = {
+       { "CSC3541", 0 }, /* Cirrus Logic PnP ID + part ID */
+       {},
+};
+MODULE_DEVICE_TABLE(acpi, cs35l41_acpi_match);
+#endif
+
+static struct spi_driver cs35l41_spi_driver = {
+       .driver = {
+               .name           = "cs35l41",
+               .of_match_table = of_match_ptr(cs35l41_of_match),
+               .acpi_match_table = ACPI_PTR(cs35l41_acpi_match),
+       },
+       .id_table       = cs35l41_id_spi,
+       .probe          = cs35l41_spi_probe,
+       .remove         = cs35l41_spi_remove,
+};
+
+module_spi_driver(cs35l41_spi_driver);
+
+MODULE_DESCRIPTION("SPI CS35L41 driver");
+MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/codecs/cs35l41-tables.c b/sound/soc/codecs/cs35l41-tables.c
new file mode 100644 (file)
index 0000000..964e530
--- /dev/null
@@ -0,0 +1,594 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// cs35l41-tables.c -- CS35L41 ALSA SoC audio driver
+//
+// Copyright 2017-2021 Cirrus Logic, Inc.
+//
+// Author: David Rhodes <david.rhodes@cirrus.com>
+
+#include "cs35l41.h"
+
+const struct reg_default cs35l41_reg[CS35L41_MAX_CACHE_REG] = {
+       { CS35L41_PWR_CTRL1,                    0x00000000 },
+       { CS35L41_PWR_CTRL3,                    0x01000010 },
+       { CS35L41_GPIO_PAD_CONTROL,             0x00000000 },
+       { CS35L41_SP_ENABLES,                   0x00000000 },
+       { CS35L41_SP_RATE_CTRL,                 0x00000028 },
+       { CS35L41_SP_FORMAT,                    0x18180200 },
+       { CS35L41_SP_HIZ_CTRL,                  0x00000002 },
+       { CS35L41_SP_FRAME_TX_SLOT,             0x03020100 },
+       { CS35L41_SP_FRAME_RX_SLOT,             0x00000100 },
+       { CS35L41_SP_TX_WL,                     0x00000018 },
+       { CS35L41_SP_RX_WL,                     0x00000018 },
+       { CS35L41_DAC_PCM1_SRC,                 0x00000008 },
+       { CS35L41_ASP_TX1_SRC,                  0x00000018 },
+       { CS35L41_ASP_TX2_SRC,                  0x00000019 },
+       { CS35L41_ASP_TX3_SRC,                  0x00000020 },
+       { CS35L41_ASP_TX4_SRC,                  0x00000021 },
+       { CS35L41_DSP1_RX1_SRC,                 0x00000008 },
+       { CS35L41_DSP1_RX2_SRC,                 0x00000009 },
+       { CS35L41_DSP1_RX3_SRC,                 0x00000018 },
+       { CS35L41_DSP1_RX4_SRC,                 0x00000019 },
+       { CS35L41_DSP1_RX5_SRC,                 0x00000020 },
+       { CS35L41_DSP1_RX6_SRC,                 0x00000021 },
+       { CS35L41_DSP1_RX7_SRC,                 0x0000003A },
+       { CS35L41_DSP1_RX8_SRC,                 0x00000001 },
+       { CS35L41_NGATE1_SRC,                   0x00000008 },
+       { CS35L41_NGATE2_SRC,                   0x00000009 },
+       { CS35L41_AMP_DIG_VOL_CTRL,             0x00008000 },
+       { CS35L41_CLASSH_CFG,                   0x000B0405 },
+       { CS35L41_WKFET_CFG,                    0x00000111 },
+       { CS35L41_NG_CFG,                       0x00000033 },
+       { CS35L41_AMP_GAIN_CTRL,                0x00000273 },
+       { CS35L41_GPIO1_CTRL1,                  0xE1000001 },
+       { CS35L41_GPIO2_CTRL1,                  0xE1000001 },
+       { CS35L41_MIXER_NGATE_CFG,              0x00000000 },
+       { CS35L41_MIXER_NGATE_CH1_CFG,          0x00000303 },
+       { CS35L41_MIXER_NGATE_CH2_CFG,          0x00000303 },
+};
+
+bool cs35l41_readable_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case CS35L41_DEVID:
+       case CS35L41_REVID:
+       case CS35L41_FABID:
+       case CS35L41_RELID:
+       case CS35L41_OTPID:
+       case CS35L41_TEST_KEY_CTL:
+       case CS35L41_USER_KEY_CTL:
+       case CS35L41_OTP_CTRL0:
+       case CS35L41_OTP_CTRL3:
+       case CS35L41_OTP_CTRL4:
+       case CS35L41_OTP_CTRL5:
+       case CS35L41_OTP_CTRL6:
+       case CS35L41_OTP_CTRL7:
+       case CS35L41_OTP_CTRL8:
+       case CS35L41_PWR_CTRL1:
+       case CS35L41_PWR_CTRL2:
+       case CS35L41_PWR_CTRL3:
+       case CS35L41_CTRL_OVRRIDE:
+       case CS35L41_AMP_OUT_MUTE:
+       case CS35L41_PROTECT_REL_ERR_IGN:
+       case CS35L41_GPIO_PAD_CONTROL:
+       case CS35L41_JTAG_CONTROL:
+       case CS35L41_PLL_CLK_CTRL:
+       case CS35L41_DSP_CLK_CTRL:
+       case CS35L41_GLOBAL_CLK_CTRL:
+       case CS35L41_DATA_FS_SEL:
+       case CS35L41_MDSYNC_EN:
+       case CS35L41_MDSYNC_TX_ID:
+       case CS35L41_MDSYNC_PWR_CTRL:
+       case CS35L41_MDSYNC_DATA_TX:
+       case CS35L41_MDSYNC_TX_STATUS:
+       case CS35L41_MDSYNC_DATA_RX:
+       case CS35L41_MDSYNC_RX_STATUS:
+       case CS35L41_MDSYNC_ERR_STATUS:
+       case CS35L41_MDSYNC_SYNC_PTE2:
+       case CS35L41_MDSYNC_SYNC_PTE3:
+       case CS35L41_MDSYNC_SYNC_MSM_STATUS:
+       case CS35L41_BSTCVRT_VCTRL1:
+       case CS35L41_BSTCVRT_VCTRL2:
+       case CS35L41_BSTCVRT_PEAK_CUR:
+       case CS35L41_BSTCVRT_SFT_RAMP:
+       case CS35L41_BSTCVRT_COEFF:
+       case CS35L41_BSTCVRT_SLOPE_LBST:
+       case CS35L41_BSTCVRT_SW_FREQ:
+       case CS35L41_BSTCVRT_DCM_CTRL:
+       case CS35L41_BSTCVRT_DCM_MODE_FORCE:
+       case CS35L41_BSTCVRT_OVERVOLT_CTRL:
+       case CS35L41_VI_VOL_POL:
+       case CS35L41_DTEMP_WARN_THLD:
+       case CS35L41_DTEMP_CFG:
+       case CS35L41_DTEMP_EN:
+       case CS35L41_VPVBST_FS_SEL:
+       case CS35L41_SP_ENABLES:
+       case CS35L41_SP_RATE_CTRL:
+       case CS35L41_SP_FORMAT:
+       case CS35L41_SP_HIZ_CTRL:
+       case CS35L41_SP_FRAME_TX_SLOT:
+       case CS35L41_SP_FRAME_RX_SLOT:
+       case CS35L41_SP_TX_WL:
+       case CS35L41_SP_RX_WL:
+       case CS35L41_DAC_PCM1_SRC:
+       case CS35L41_ASP_TX1_SRC:
+       case CS35L41_ASP_TX2_SRC:
+       case CS35L41_ASP_TX3_SRC:
+       case CS35L41_ASP_TX4_SRC:
+       case CS35L41_DSP1_RX1_SRC:
+       case CS35L41_DSP1_RX2_SRC:
+       case CS35L41_DSP1_RX3_SRC:
+       case CS35L41_DSP1_RX4_SRC:
+       case CS35L41_DSP1_RX5_SRC:
+       case CS35L41_DSP1_RX6_SRC:
+       case CS35L41_DSP1_RX7_SRC:
+       case CS35L41_DSP1_RX8_SRC:
+       case CS35L41_NGATE1_SRC:
+       case CS35L41_NGATE2_SRC:
+       case CS35L41_AMP_DIG_VOL_CTRL:
+       case CS35L41_VPBR_CFG:
+       case CS35L41_VBBR_CFG:
+       case CS35L41_VPBR_STATUS:
+       case CS35L41_VBBR_STATUS:
+       case CS35L41_OVERTEMP_CFG:
+       case CS35L41_AMP_ERR_VOL:
+       case CS35L41_VOL_STATUS_TO_DSP:
+       case CS35L41_CLASSH_CFG:
+       case CS35L41_WKFET_CFG:
+       case CS35L41_NG_CFG:
+       case CS35L41_AMP_GAIN_CTRL:
+       case CS35L41_DAC_MSM_CFG:
+       case CS35L41_IRQ1_CFG:
+       case CS35L41_IRQ1_STATUS:
+       case CS35L41_IRQ1_STATUS1:
+       case CS35L41_IRQ1_STATUS2:
+       case CS35L41_IRQ1_STATUS3:
+       case CS35L41_IRQ1_STATUS4:
+       case CS35L41_IRQ1_RAW_STATUS1:
+       case CS35L41_IRQ1_RAW_STATUS2:
+       case CS35L41_IRQ1_RAW_STATUS3:
+       case CS35L41_IRQ1_RAW_STATUS4:
+       case CS35L41_IRQ1_MASK1:
+       case CS35L41_IRQ1_MASK2:
+       case CS35L41_IRQ1_MASK3:
+       case CS35L41_IRQ1_MASK4:
+       case CS35L41_IRQ1_FRC1:
+       case CS35L41_IRQ1_FRC2:
+       case CS35L41_IRQ1_FRC3:
+       case CS35L41_IRQ1_FRC4:
+       case CS35L41_IRQ1_EDGE1:
+       case CS35L41_IRQ1_EDGE4:
+       case CS35L41_IRQ1_POL1:
+       case CS35L41_IRQ1_POL2:
+       case CS35L41_IRQ1_POL3:
+       case CS35L41_IRQ1_POL4:
+       case CS35L41_IRQ1_DB3:
+       case CS35L41_IRQ2_CFG:
+       case CS35L41_IRQ2_STATUS:
+       case CS35L41_IRQ2_STATUS1:
+       case CS35L41_IRQ2_STATUS2:
+       case CS35L41_IRQ2_STATUS3:
+       case CS35L41_IRQ2_STATUS4:
+       case CS35L41_IRQ2_RAW_STATUS1:
+       case CS35L41_IRQ2_RAW_STATUS2:
+       case CS35L41_IRQ2_RAW_STATUS3:
+       case CS35L41_IRQ2_RAW_STATUS4:
+       case CS35L41_IRQ2_MASK1:
+       case CS35L41_IRQ2_MASK2:
+       case CS35L41_IRQ2_MASK3:
+       case CS35L41_IRQ2_MASK4:
+       case CS35L41_IRQ2_FRC1:
+       case CS35L41_IRQ2_FRC2:
+       case CS35L41_IRQ2_FRC3:
+       case CS35L41_IRQ2_FRC4:
+       case CS35L41_IRQ2_EDGE1:
+       case CS35L41_IRQ2_EDGE4:
+       case CS35L41_IRQ2_POL1:
+       case CS35L41_IRQ2_POL2:
+       case CS35L41_IRQ2_POL3:
+       case CS35L41_IRQ2_POL4:
+       case CS35L41_IRQ2_DB3:
+       case CS35L41_GPIO_STATUS1:
+       case CS35L41_GPIO1_CTRL1:
+       case CS35L41_GPIO2_CTRL1:
+       case CS35L41_MIXER_NGATE_CFG:
+       case CS35L41_MIXER_NGATE_CH1_CFG:
+       case CS35L41_MIXER_NGATE_CH2_CFG:
+       case CS35L41_DSP_MBOX_1 ... CS35L41_DSP_VIRT2_MBOX_8:
+       case CS35L41_CLOCK_DETECT_1:
+       case CS35L41_DIE_STS1:
+       case CS35L41_DIE_STS2:
+       case CS35L41_TEMP_CAL1:
+       case CS35L41_TEMP_CAL2:
+       case CS35L41_OTP_TRIM_1:
+       case CS35L41_OTP_TRIM_2:
+       case CS35L41_OTP_TRIM_3:
+       case CS35L41_OTP_TRIM_4:
+       case CS35L41_OTP_TRIM_5:
+       case CS35L41_OTP_TRIM_6:
+       case CS35L41_OTP_TRIM_7:
+       case CS35L41_OTP_TRIM_8:
+       case CS35L41_OTP_TRIM_9:
+       case CS35L41_OTP_TRIM_10:
+       case CS35L41_OTP_TRIM_11:
+       case CS35L41_OTP_TRIM_12:
+       case CS35L41_OTP_TRIM_13:
+       case CS35L41_OTP_TRIM_14:
+       case CS35L41_OTP_TRIM_15:
+       case CS35L41_OTP_TRIM_16:
+       case CS35L41_OTP_TRIM_17:
+       case CS35L41_OTP_TRIM_18:
+       case CS35L41_OTP_TRIM_19:
+       case CS35L41_OTP_TRIM_20:
+       case CS35L41_OTP_TRIM_21:
+       case CS35L41_OTP_TRIM_22:
+       case CS35L41_OTP_TRIM_23:
+       case CS35L41_OTP_TRIM_24:
+       case CS35L41_OTP_TRIM_25:
+       case CS35L41_OTP_TRIM_26:
+       case CS35L41_OTP_TRIM_27:
+       case CS35L41_OTP_TRIM_28:
+       case CS35L41_OTP_TRIM_29:
+       case CS35L41_OTP_TRIM_30:
+       case CS35L41_OTP_TRIM_31:
+       case CS35L41_OTP_TRIM_32:
+       case CS35L41_OTP_TRIM_33:
+       case CS35L41_OTP_TRIM_34:
+       case CS35L41_OTP_TRIM_35:
+       case CS35L41_OTP_TRIM_36:
+       case CS35L41_OTP_MEM0 ... CS35L41_OTP_MEM31:
+       /*test regs*/
+       case CS35L41_PLL_OVR:
+       case CS35L41_BST_TEST_DUTY:
+       case CS35L41_DIGPWM_IOCTRL:
+               return true;
+       default:
+               return false;
+       }
+}
+
+bool cs35l41_precious_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case CS35L41_OTP_MEM0 ... CS35L41_OTP_MEM31:
+               return true;
+       default:
+               return false;
+       }
+}
+
+bool cs35l41_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case CS35L41_DEVID:
+       case CS35L41_SFT_RESET:
+       case CS35L41_FABID:
+       case CS35L41_REVID:
+       case CS35L41_DTEMP_EN:
+       case CS35L41_IRQ1_STATUS:
+       case CS35L41_IRQ1_STATUS1:
+       case CS35L41_IRQ1_STATUS2:
+       case CS35L41_IRQ1_STATUS3:
+       case CS35L41_IRQ1_STATUS4:
+       case CS35L41_IRQ1_RAW_STATUS1:
+       case CS35L41_IRQ1_RAW_STATUS2:
+       case CS35L41_IRQ1_RAW_STATUS3:
+       case CS35L41_IRQ1_RAW_STATUS4:
+       case CS35L41_IRQ1_FRC1:
+       case CS35L41_IRQ1_FRC2:
+       case CS35L41_IRQ1_FRC3:
+       case CS35L41_IRQ1_FRC4:
+       case CS35L41_IRQ1_EDGE1:
+       case CS35L41_IRQ1_EDGE4:
+       case CS35L41_IRQ1_POL1:
+       case CS35L41_IRQ1_POL2:
+       case CS35L41_IRQ1_POL3:
+       case CS35L41_IRQ1_POL4:
+       case CS35L41_IRQ1_DB3:
+       case CS35L41_IRQ2_STATUS:
+       case CS35L41_IRQ2_STATUS1:
+       case CS35L41_IRQ2_STATUS2:
+       case CS35L41_IRQ2_STATUS3:
+       case CS35L41_IRQ2_STATUS4:
+       case CS35L41_IRQ2_RAW_STATUS1:
+       case CS35L41_IRQ2_RAW_STATUS2:
+       case CS35L41_IRQ2_RAW_STATUS3:
+       case CS35L41_IRQ2_RAW_STATUS4:
+       case CS35L41_IRQ2_FRC1:
+       case CS35L41_IRQ2_FRC2:
+       case CS35L41_IRQ2_FRC3:
+       case CS35L41_IRQ2_FRC4:
+       case CS35L41_IRQ2_EDGE1:
+       case CS35L41_IRQ2_EDGE4:
+       case CS35L41_IRQ2_POL1:
+       case CS35L41_IRQ2_POL2:
+       case CS35L41_IRQ2_POL3:
+       case CS35L41_IRQ2_POL4:
+       case CS35L41_IRQ2_DB3:
+       case CS35L41_GPIO_STATUS1:
+       case CS35L41_OTP_TRIM_1:
+       case CS35L41_OTP_TRIM_2:
+       case CS35L41_OTP_TRIM_3:
+       case CS35L41_OTP_TRIM_4:
+       case CS35L41_OTP_TRIM_5:
+       case CS35L41_OTP_TRIM_6:
+       case CS35L41_OTP_TRIM_7:
+       case CS35L41_OTP_TRIM_8:
+       case CS35L41_OTP_TRIM_9:
+       case CS35L41_OTP_TRIM_10:
+       case CS35L41_OTP_TRIM_11:
+       case CS35L41_OTP_TRIM_12:
+       case CS35L41_OTP_TRIM_13:
+       case CS35L41_OTP_TRIM_14:
+       case CS35L41_OTP_TRIM_15:
+       case CS35L41_OTP_TRIM_16:
+       case CS35L41_OTP_TRIM_17:
+       case CS35L41_OTP_TRIM_18:
+       case CS35L41_OTP_TRIM_19:
+       case CS35L41_OTP_TRIM_20:
+       case CS35L41_OTP_TRIM_21:
+       case CS35L41_OTP_TRIM_22:
+       case CS35L41_OTP_TRIM_23:
+       case CS35L41_OTP_TRIM_24:
+       case CS35L41_OTP_TRIM_25:
+       case CS35L41_OTP_TRIM_26:
+       case CS35L41_OTP_TRIM_27:
+       case CS35L41_OTP_TRIM_28:
+       case CS35L41_OTP_TRIM_29:
+       case CS35L41_OTP_TRIM_30:
+       case CS35L41_OTP_TRIM_31:
+       case CS35L41_OTP_TRIM_32:
+       case CS35L41_OTP_TRIM_33:
+       case CS35L41_OTP_TRIM_34:
+       case CS35L41_OTP_TRIM_35:
+       case CS35L41_OTP_TRIM_36:
+       case CS35L41_OTP_MEM0 ... CS35L41_OTP_MEM31:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static const struct cs35l41_otp_packed_element_t otp_map_1[CS35L41_NUM_OTP_ELEM] = {
+       /* addr         shift   size */
+       { 0x00002030,   0,      4 }, /*TRIM_OSC_FREQ_TRIM*/
+       { 0x00002030,   7,      1 }, /*TRIM_OSC_TRIM_DONE*/
+       { 0x0000208c,   24,     6 }, /*TST_DIGREG_VREF_TRIM*/
+       { 0x00002090,   14,     4 }, /*TST_REF_TRIM*/
+       { 0x00002090,   10,     4 }, /*TST_REF_TEMPCO_TRIM*/
+       { 0x0000300C,   11,     4 }, /*PLL_LDOA_TST_VREF_TRIM*/
+       { 0x0000394C,   23,     2 }, /*BST_ATEST_CM_VOFF*/
+       { 0x00003950,   0,      7 }, /*BST_ATRIM_IADC_OFFSET*/
+       { 0x00003950,   8,      7 }, /*BST_ATRIM_IADC_GAIN1*/
+       { 0x00003950,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET1*/
+       { 0x00003950,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN1*/
+       { 0x00003954,   0,      7 }, /*BST_ATRIM_IADC_OFFSET2*/
+       { 0x00003954,   8,      7 }, /*BST_ATRIM_IADC_GAIN2*/
+       { 0x00003954,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET2*/
+       { 0x00003954,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN2*/
+       { 0x00003958,   0,      7 }, /*BST_ATRIM_IADC_OFFSET3*/
+       { 0x00003958,   8,      7 }, /*BST_ATRIM_IADC_GAIN3*/
+       { 0x00003958,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET3*/
+       { 0x00003958,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN3*/
+       { 0x0000395C,   0,      7 }, /*BST_ATRIM_IADC_OFFSET4*/
+       { 0x0000395C,   8,      7 }, /*BST_ATRIM_IADC_GAIN4*/
+       { 0x0000395C,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET4*/
+       { 0x0000395C,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN4*/
+       { 0x0000416C,   0,      8 }, /*VMON_GAIN_OTP_VAL*/
+       { 0x00004160,   0,      7 }, /*VMON_OFFSET_OTP_VAL*/
+       { 0x0000416C,   8,      8 }, /*IMON_GAIN_OTP_VAL*/
+       { 0x00004160,   16,     10 }, /*IMON_OFFSET_OTP_VAL*/
+       { 0x0000416C,   16,     12 }, /*VMON_CM_GAIN_OTP_VAL*/
+       { 0x0000416C,   28,     1 }, /*VMON_CM_GAIN_SIGN_OTP_VAL*/
+       { 0x00004170,   0,      6 }, /*IMON_CAL_TEMPCO_OTP_VAL*/
+       { 0x00004170,   6,      1 }, /*IMON_CAL_TEMPCO_SIGN_OTP*/
+       { 0x00004170,   8,      6 }, /*IMON_CAL_TEMPCO2_OTP_VAL*/
+       { 0x00004170,   14,     1 }, /*IMON_CAL_TEMPCO2_DN_UPB_OTP_VAL*/
+       { 0x00004170,   16,     9 }, /*IMON_CAL_TEMPCO_TBASE_OTP_VAL*/
+       { 0x00004360,   0,      5 }, /*TEMP_GAIN_OTP_VAL*/
+       { 0x00004360,   6,      9 }, /*TEMP_OFFSET_OTP_VAL*/
+       { 0x00004448,   0,      8 }, /*VP_SARADC_OFFSET*/
+       { 0x00004448,   8,      8 }, /*VP_GAIN_INDEX*/
+       { 0x00004448,   16,     8 }, /*VBST_SARADC_OFFSET*/
+       { 0x00004448,   24,     8 }, /*VBST_GAIN_INDEX*/
+       { 0x0000444C,   0,      3 }, /*ANA_SELINVREF*/
+       { 0x00006E30,   0,      5 }, /*GAIN_ERR_COEFF_0*/
+       { 0x00006E30,   8,      5 }, /*GAIN_ERR_COEFF_1*/
+       { 0x00006E30,   16,     5 }, /*GAIN_ERR_COEFF_2*/
+       { 0x00006E30,   24,     5 }, /*GAIN_ERR_COEFF_3*/
+       { 0x00006E34,   0,      5 }, /*GAIN_ERR_COEFF_4*/
+       { 0x00006E34,   8,      5 }, /*GAIN_ERR_COEFF_5*/
+       { 0x00006E34,   16,     5 }, /*GAIN_ERR_COEFF_6*/
+       { 0x00006E34,   24,     5 }, /*GAIN_ERR_COEFF_7*/
+       { 0x00006E38,   0,      5 }, /*GAIN_ERR_COEFF_8*/
+       { 0x00006E38,   8,      5 }, /*GAIN_ERR_COEFF_9*/
+       { 0x00006E38,   16,     5 }, /*GAIN_ERR_COEFF_10*/
+       { 0x00006E38,   24,     5 }, /*GAIN_ERR_COEFF_11*/
+       { 0x00006E3C,   0,      5 }, /*GAIN_ERR_COEFF_12*/
+       { 0x00006E3C,   8,      5 }, /*GAIN_ERR_COEFF_13*/
+       { 0x00006E3C,   16,     5 }, /*GAIN_ERR_COEFF_14*/
+       { 0x00006E3C,   24,     5 }, /*GAIN_ERR_COEFF_15*/
+       { 0x00006E40,   0,      5 }, /*GAIN_ERR_COEFF_16*/
+       { 0x00006E40,   8,      5 }, /*GAIN_ERR_COEFF_17*/
+       { 0x00006E40,   16,     5 }, /*GAIN_ERR_COEFF_18*/
+       { 0x00006E40,   24,     5 }, /*GAIN_ERR_COEFF_19*/
+       { 0x00006E44,   0,      5 }, /*GAIN_ERR_COEFF_20*/
+       { 0x00006E48,   0,      10 }, /*VOFF_GAIN_0*/
+       { 0x00006E48,   10,     10 }, /*VOFF_GAIN_1*/
+       { 0x00006E48,   20,     10 }, /*VOFF_GAIN_2*/
+       { 0x00006E4C,   0,      10 }, /*VOFF_GAIN_3*/
+       { 0x00006E4C,   10,     10 }, /*VOFF_GAIN_4*/
+       { 0x00006E4C,   20,     10 }, /*VOFF_GAIN_5*/
+       { 0x00006E50,   0,      10 }, /*VOFF_GAIN_6*/
+       { 0x00006E50,   10,     10 }, /*VOFF_GAIN_7*/
+       { 0x00006E50,   20,     10 }, /*VOFF_GAIN_8*/
+       { 0x00006E54,   0,      10 }, /*VOFF_GAIN_9*/
+       { 0x00006E54,   10,     10 }, /*VOFF_GAIN_10*/
+       { 0x00006E54,   20,     10 }, /*VOFF_GAIN_11*/
+       { 0x00006E58,   0,      10 }, /*VOFF_GAIN_12*/
+       { 0x00006E58,   10,     10 }, /*VOFF_GAIN_13*/
+       { 0x00006E58,   20,     10 }, /*VOFF_GAIN_14*/
+       { 0x00006E5C,   0,      10 }, /*VOFF_GAIN_15*/
+       { 0x00006E5C,   10,     10 }, /*VOFF_GAIN_16*/
+       { 0x00006E5C,   20,     10 }, /*VOFF_GAIN_17*/
+       { 0x00006E60,   0,      10 }, /*VOFF_GAIN_18*/
+       { 0x00006E60,   10,     10 }, /*VOFF_GAIN_19*/
+       { 0x00006E60,   20,     10 }, /*VOFF_GAIN_20*/
+       { 0x00006E64,   0,      10 }, /*VOFF_INT1*/
+       { 0x00007418,   7,      5 }, /*DS_SPK_INT1_CAP_TRIM*/
+       { 0x0000741C,   0,      5 }, /*DS_SPK_INT2_CAP_TRIM*/
+       { 0x0000741C,   11,     4 }, /*DS_SPK_LPF_CAP_TRIM*/
+       { 0x0000741C,   19,     4 }, /*DS_SPK_QUAN_CAP_TRIM*/
+       { 0x00007434,   17,     1 }, /*FORCE_CAL*/
+       { 0x00007434,   18,     7 }, /*CAL_OVERRIDE*/
+       { 0x00007068,   0,      9 }, /*MODIX*/
+       { 0x0000410C,   7,      1 }, /*VIMON_DLY_NOT_COMB*/
+       { 0x0000400C,   0,      7 }, /*VIMON_DLY*/
+       { 0x00000000,   0,      1 }, /*extra bit*/
+       { 0x00017040,   0,      8 }, /*X_COORDINATE*/
+       { 0x00017040,   8,      8 }, /*Y_COORDINATE*/
+       { 0x00017040,   16,     8 }, /*WAFER_ID*/
+       { 0x00017040,   24,     8 }, /*DVS*/
+       { 0x00017044,   0,      24 }, /*LOT_NUMBER*/
+};
+
+static const struct cs35l41_otp_packed_element_t otp_map_2[CS35L41_NUM_OTP_ELEM] = {
+       /* addr         shift   size */
+       { 0x00002030,   0,      4 }, /*TRIM_OSC_FREQ_TRIM*/
+       { 0x00002030,   7,      1 }, /*TRIM_OSC_TRIM_DONE*/
+       { 0x0000208c,   24,     6 }, /*TST_DIGREG_VREF_TRIM*/
+       { 0x00002090,   14,     4 }, /*TST_REF_TRIM*/
+       { 0x00002090,   10,     4 }, /*TST_REF_TEMPCO_TRIM*/
+       { 0x0000300C,   11,     4 }, /*PLL_LDOA_TST_VREF_TRIM*/
+       { 0x0000394C,   23,     2 }, /*BST_ATEST_CM_VOFF*/
+       { 0x00003950,   0,      7 }, /*BST_ATRIM_IADC_OFFSET*/
+       { 0x00003950,   8,      7 }, /*BST_ATRIM_IADC_GAIN1*/
+       { 0x00003950,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET1*/
+       { 0x00003950,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN1*/
+       { 0x00003954,   0,      7 }, /*BST_ATRIM_IADC_OFFSET2*/
+       { 0x00003954,   8,      7 }, /*BST_ATRIM_IADC_GAIN2*/
+       { 0x00003954,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET2*/
+       { 0x00003954,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN2*/
+       { 0x00003958,   0,      7 }, /*BST_ATRIM_IADC_OFFSET3*/
+       { 0x00003958,   8,      7 }, /*BST_ATRIM_IADC_GAIN3*/
+       { 0x00003958,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET3*/
+       { 0x00003958,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN3*/
+       { 0x0000395C,   0,      7 }, /*BST_ATRIM_IADC_OFFSET4*/
+       { 0x0000395C,   8,      7 }, /*BST_ATRIM_IADC_GAIN4*/
+       { 0x0000395C,   16,     8 }, /*BST_ATRIM_IPKCOMP_OFFSET4*/
+       { 0x0000395C,   24,     8 }, /*BST_ATRIM_IPKCOMP_GAIN4*/
+       { 0x0000416C,   0,      8 }, /*VMON_GAIN_OTP_VAL*/
+       { 0x00004160,   0,      7 }, /*VMON_OFFSET_OTP_VAL*/
+       { 0x0000416C,   8,      8 }, /*IMON_GAIN_OTP_VAL*/
+       { 0x00004160,   16,     10 }, /*IMON_OFFSET_OTP_VAL*/
+       { 0x0000416C,   16,     12 }, /*VMON_CM_GAIN_OTP_VAL*/
+       { 0x0000416C,   28,     1 }, /*VMON_CM_GAIN_SIGN_OTP_VAL*/
+       { 0x00004170,   0,      6 }, /*IMON_CAL_TEMPCO_OTP_VAL*/
+       { 0x00004170,   6,      1 }, /*IMON_CAL_TEMPCO_SIGN_OTP*/
+       { 0x00004170,   8,      6 }, /*IMON_CAL_TEMPCO2_OTP_VAL*/
+       { 0x00004170,   14,     1 }, /*IMON_CAL_TEMPCO2_DN_UPB_OTP_VAL*/
+       { 0x00004170,   16,     9 }, /*IMON_CAL_TEMPCO_TBASE_OTP_VAL*/
+       { 0x00004360,   0,      5 }, /*TEMP_GAIN_OTP_VAL*/
+       { 0x00004360,   6,      9 }, /*TEMP_OFFSET_OTP_VAL*/
+       { 0x00004448,   0,      8 }, /*VP_SARADC_OFFSET*/
+       { 0x00004448,   8,      8 }, /*VP_GAIN_INDEX*/
+       { 0x00004448,   16,     8 }, /*VBST_SARADC_OFFSET*/
+       { 0x00004448,   24,     8 }, /*VBST_GAIN_INDEX*/
+       { 0x0000444C,   0,      3 }, /*ANA_SELINVREF*/
+       { 0x00006E30,   0,      5 }, /*GAIN_ERR_COEFF_0*/
+       { 0x00006E30,   8,      5 }, /*GAIN_ERR_COEFF_1*/
+       { 0x00006E30,   16,     5 }, /*GAIN_ERR_COEFF_2*/
+       { 0x00006E30,   24,     5 }, /*GAIN_ERR_COEFF_3*/
+       { 0x00006E34,   0,      5 }, /*GAIN_ERR_COEFF_4*/
+       { 0x00006E34,   8,      5 }, /*GAIN_ERR_COEFF_5*/
+       { 0x00006E34,   16,     5 }, /*GAIN_ERR_COEFF_6*/
+       { 0x00006E34,   24,     5 }, /*GAIN_ERR_COEFF_7*/
+       { 0x00006E38,   0,      5 }, /*GAIN_ERR_COEFF_8*/
+       { 0x00006E38,   8,      5 }, /*GAIN_ERR_COEFF_9*/
+       { 0x00006E38,   16,     5 }, /*GAIN_ERR_COEFF_10*/
+       { 0x00006E38,   24,     5 }, /*GAIN_ERR_COEFF_11*/
+       { 0x00006E3C,   0,      5 }, /*GAIN_ERR_COEFF_12*/
+       { 0x00006E3C,   8,      5 }, /*GAIN_ERR_COEFF_13*/
+       { 0x00006E3C,   16,     5 }, /*GAIN_ERR_COEFF_14*/
+       { 0x00006E3C,   24,     5 }, /*GAIN_ERR_COEFF_15*/
+       { 0x00006E40,   0,      5 }, /*GAIN_ERR_COEFF_16*/
+       { 0x00006E40,   8,      5 }, /*GAIN_ERR_COEFF_17*/
+       { 0x00006E40,   16,     5 }, /*GAIN_ERR_COEFF_18*/
+       { 0x00006E40,   24,     5 }, /*GAIN_ERR_COEFF_19*/
+       { 0x00006E44,   0,      5 }, /*GAIN_ERR_COEFF_20*/
+       { 0x00006E48,   0,      10 }, /*VOFF_GAIN_0*/
+       { 0x00006E48,   10,     10 }, /*VOFF_GAIN_1*/
+       { 0x00006E48,   20,     10 }, /*VOFF_GAIN_2*/
+       { 0x00006E4C,   0,      10 }, /*VOFF_GAIN_3*/
+       { 0x00006E4C,   10,     10 }, /*VOFF_GAIN_4*/
+       { 0x00006E4C,   20,     10 }, /*VOFF_GAIN_5*/
+       { 0x00006E50,   0,      10 }, /*VOFF_GAIN_6*/
+       { 0x00006E50,   10,     10 }, /*VOFF_GAIN_7*/
+       { 0x00006E50,   20,     10 }, /*VOFF_GAIN_8*/
+       { 0x00006E54,   0,      10 }, /*VOFF_GAIN_9*/
+       { 0x00006E54,   10,     10 }, /*VOFF_GAIN_10*/
+       { 0x00006E54,   20,     10 }, /*VOFF_GAIN_11*/
+       { 0x00006E58,   0,      10 }, /*VOFF_GAIN_12*/
+       { 0x00006E58,   10,     10 }, /*VOFF_GAIN_13*/
+       { 0x00006E58,   20,     10 }, /*VOFF_GAIN_14*/
+       { 0x00006E5C,   0,      10 }, /*VOFF_GAIN_15*/
+       { 0x00006E5C,   10,     10 }, /*VOFF_GAIN_16*/
+       { 0x00006E5C,   20,     10 }, /*VOFF_GAIN_17*/
+       { 0x00006E60,   0,      10 }, /*VOFF_GAIN_18*/
+       { 0x00006E60,   10,     10 }, /*VOFF_GAIN_19*/
+       { 0x00006E60,   20,     10 }, /*VOFF_GAIN_20*/
+       { 0x00006E64,   0,      10 }, /*VOFF_INT1*/
+       { 0x00007418,   7,      5 }, /*DS_SPK_INT1_CAP_TRIM*/
+       { 0x0000741C,   0,      5 }, /*DS_SPK_INT2_CAP_TRIM*/
+       { 0x0000741C,   11,     4 }, /*DS_SPK_LPF_CAP_TRIM*/
+       { 0x0000741C,   19,     4 }, /*DS_SPK_QUAN_CAP_TRIM*/
+       { 0x00007434,   17,     1 }, /*FORCE_CAL*/
+       { 0x00007434,   18,     7 }, /*CAL_OVERRIDE*/
+       { 0x00007068,   0,      9 }, /*MODIX*/
+       { 0x0000410C,   7,      1 }, /*VIMON_DLY_NOT_COMB*/
+       { 0x0000400C,   0,      7 }, /*VIMON_DLY*/
+       { 0x00004000,   11,     1 }, /*VMON_POL*/
+       { 0x00017040,   0,      8 }, /*X_COORDINATE*/
+       { 0x00017040,   8,      8 }, /*Y_COORDINATE*/
+       { 0x00017040,   16,     8 }, /*WAFER_ID*/
+       { 0x00017040,   24,     8 }, /*DVS*/
+       { 0x00017044,   0,      24 }, /*LOT_NUMBER*/
+};
+
+const struct cs35l41_otp_map_element_t cs35l41_otp_map_map[CS35L41_NUM_OTP_MAPS] = {
+       {
+               .id = 0x01,
+               .map = otp_map_1,
+               .num_elements = CS35L41_NUM_OTP_ELEM,
+               .bit_offset = 16,
+               .word_offset = 2,
+       },
+       {
+               .id = 0x02,
+               .map = otp_map_2,
+               .num_elements = CS35L41_NUM_OTP_ELEM,
+               .bit_offset = 16,
+               .word_offset = 2,
+       },
+       {
+               .id = 0x03,
+               .map = otp_map_2,
+               .num_elements = CS35L41_NUM_OTP_ELEM,
+               .bit_offset = 16,
+               .word_offset = 2,
+       },
+       {
+               .id = 0x06,
+               .map = otp_map_2,
+               .num_elements = CS35L41_NUM_OTP_ELEM,
+               .bit_offset = 16,
+               .word_offset = 2,
+       },
+       {
+               .id = 0x08,
+               .map = otp_map_1,
+               .num_elements = CS35L41_NUM_OTP_ELEM,
+               .bit_offset = 16,
+               .word_offset = 2,
+       },
+};
diff --git a/sound/soc/codecs/cs35l41.c b/sound/soc/codecs/cs35l41.c
new file mode 100644 (file)
index 0000000..94ed21d
--- /dev/null
@@ -0,0 +1,1445 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// cs35l41.c -- CS35l41 ALSA SoC audio driver
+//
+// Copyright 2017-2021 Cirrus Logic, Inc.
+//
+// Author: David Rhodes <david.rhodes@cirrus.com>
+
+#include <linux/delay.h>
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/of_device.h>
+#include <linux/property.h>
+#include <linux/slab.h>
+#include <sound/initval.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/tlv.h>
+
+#include "cs35l41.h"
+
+static const char * const cs35l41_supplies[CS35L41_NUM_SUPPLIES] = {
+       "VA",
+       "VP",
+};
+
+struct cs35l41_pll_sysclk_config {
+       int freq;
+       int clk_cfg;
+};
+
+static const struct cs35l41_pll_sysclk_config cs35l41_pll_sysclk[] = {
+       { 32768,        0x00 },
+       { 8000,         0x01 },
+       { 11025,        0x02 },
+       { 12000,        0x03 },
+       { 16000,        0x04 },
+       { 22050,        0x05 },
+       { 24000,        0x06 },
+       { 32000,        0x07 },
+       { 44100,        0x08 },
+       { 48000,        0x09 },
+       { 88200,        0x0A },
+       { 96000,        0x0B },
+       { 128000,       0x0C },
+       { 176400,       0x0D },
+       { 192000,       0x0E },
+       { 256000,       0x0F },
+       { 352800,       0x10 },
+       { 384000,       0x11 },
+       { 512000,       0x12 },
+       { 705600,       0x13 },
+       { 750000,       0x14 },
+       { 768000,       0x15 },
+       { 1000000,      0x16 },
+       { 1024000,      0x17 },
+       { 1200000,      0x18 },
+       { 1411200,      0x19 },
+       { 1500000,      0x1A },
+       { 1536000,      0x1B },
+       { 2000000,      0x1C },
+       { 2048000,      0x1D },
+       { 2400000,      0x1E },
+       { 2822400,      0x1F },
+       { 3000000,      0x20 },
+       { 3072000,      0x21 },
+       { 3200000,      0x22 },
+       { 4000000,      0x23 },
+       { 4096000,      0x24 },
+       { 4800000,      0x25 },
+       { 5644800,      0x26 },
+       { 6000000,      0x27 },
+       { 6144000,      0x28 },
+       { 6250000,      0x29 },
+       { 6400000,      0x2A },
+       { 6500000,      0x2B },
+       { 6750000,      0x2C },
+       { 7526400,      0x2D },
+       { 8000000,      0x2E },
+       { 8192000,      0x2F },
+       { 9600000,      0x30 },
+       { 11289600,     0x31 },
+       { 12000000,     0x32 },
+       { 12288000,     0x33 },
+       { 12500000,     0x34 },
+       { 12800000,     0x35 },
+       { 13000000,     0x36 },
+       { 13500000,     0x37 },
+       { 19200000,     0x38 },
+       { 22579200,     0x39 },
+       { 24000000,     0x3A },
+       { 24576000,     0x3B },
+       { 25000000,     0x3C },
+       { 25600000,     0x3D },
+       { 26000000,     0x3E },
+       { 27000000,     0x3F },
+};
+
+struct cs35l41_fs_mon_config {
+       int freq;
+       unsigned int fs1;
+       unsigned int fs2;
+};
+
+static const struct cs35l41_fs_mon_config cs35l41_fs_mon[] = {
+       { 32768,        2254,   3754 },
+       { 8000,         9220,   15364 },
+       { 11025,        6148,   10244 },
+       { 12000,        6148,   10244 },
+       { 16000,        4612,   7684 },
+       { 22050,        3076,   5124 },
+       { 24000,        3076,   5124 },
+       { 32000,        2308,   3844 },
+       { 44100,        1540,   2564 },
+       { 48000,        1540,   2564 },
+       { 88200,        772,    1284 },
+       { 96000,        772,    1284 },
+       { 128000,       580,    964 },
+       { 176400,       388,    644 },
+       { 192000,       388,    644 },
+       { 256000,       292,    484 },
+       { 352800,       196,    324 },
+       { 384000,       196,    324 },
+       { 512000,       148,    244 },
+       { 705600,       100,    164 },
+       { 750000,       100,    164 },
+       { 768000,       100,    164 },
+       { 1000000,      76,     124 },
+       { 1024000,      76,     124 },
+       { 1200000,      64,     104 },
+       { 1411200,      52,     84 },
+       { 1500000,      52,     84 },
+       { 1536000,      52,     84 },
+       { 2000000,      40,     64 },
+       { 2048000,      40,     64 },
+       { 2400000,      34,     54 },
+       { 2822400,      28,     44 },
+       { 3000000,      28,     44 },
+       { 3072000,      28,     44 },
+       { 3200000,      27,     42 },
+       { 4000000,      22,     34 },
+       { 4096000,      22,     34 },
+       { 4800000,      19,     29 },
+       { 5644800,      16,     24 },
+       { 6000000,      16,     24 },
+       { 6144000,      16,     24 },
+};
+
+static const unsigned char cs35l41_bst_k1_table[4][5] = {
+       { 0x24, 0x32, 0x32, 0x4F, 0x57 },
+       { 0x24, 0x32, 0x32, 0x4F, 0x57 },
+       { 0x40, 0x32, 0x32, 0x4F, 0x57 },
+       { 0x40, 0x32, 0x32, 0x4F, 0x57 }
+};
+
+static const unsigned char cs35l41_bst_k2_table[4][5] = {
+       { 0x24, 0x49, 0x66, 0xA3, 0xEA },
+       { 0x24, 0x49, 0x66, 0xA3, 0xEA },
+       { 0x48, 0x49, 0x66, 0xA3, 0xEA },
+       { 0x48, 0x49, 0x66, 0xA3, 0xEA }
+};
+
+static const unsigned char cs35l41_bst_slope_table[4] = {
+       0x75, 0x6B, 0x3B, 0x28
+};
+
+static int cs35l41_get_fs_mon_config_index(int freq)
+{
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(cs35l41_fs_mon); i++) {
+               if (cs35l41_fs_mon[i].freq == freq)
+                       return i;
+       }
+
+       return -EINVAL;
+}
+
+static const DECLARE_TLV_DB_RANGE(dig_vol_tlv,
+               0, 0, TLV_DB_SCALE_ITEM(TLV_DB_GAIN_MUTE, 0, 1),
+               1, 913, TLV_DB_MINMAX_ITEM(-10200, 1200));
+static DECLARE_TLV_DB_SCALE(amp_gain_tlv, 0, 1, 1);
+
+static const struct snd_kcontrol_new dre_ctrl =
+       SOC_DAPM_SINGLE("Switch", CS35L41_PWR_CTRL3, 20, 1, 0);
+
+static const char * const cs35l41_pcm_sftramp_text[] =  {
+       "Off", ".5ms", "1ms", "2ms", "4ms", "8ms", "15ms", "30ms"
+};
+
+static SOC_ENUM_SINGLE_DECL(pcm_sft_ramp,
+                           CS35L41_AMP_DIG_VOL_CTRL, 0,
+                           cs35l41_pcm_sftramp_text);
+
+static const char * const cs35l41_pcm_source_texts[] = {"ASP", "DSP"};
+static const unsigned int cs35l41_pcm_source_values[] = {0x08, 0x32};
+static SOC_VALUE_ENUM_SINGLE_DECL(cs35l41_pcm_source_enum,
+                                 CS35L41_DAC_PCM1_SRC,
+                                 0, CS35L41_ASP_SOURCE_MASK,
+                                 cs35l41_pcm_source_texts,
+                                 cs35l41_pcm_source_values);
+
+static const struct snd_kcontrol_new pcm_source_mux =
+       SOC_DAPM_ENUM("PCM Source", cs35l41_pcm_source_enum);
+
+static const char * const cs35l41_tx_input_texts[] = {
+       "Zero", "ASPRX1", "ASPRX2", "VMON", "IMON",
+       "VPMON", "VBSTMON", "DSPTX1", "DSPTX2"
+};
+
+static const unsigned int cs35l41_tx_input_values[] = {
+       0x00, CS35L41_INPUT_SRC_ASPRX1, CS35L41_INPUT_SRC_ASPRX2,
+       CS35L41_INPUT_SRC_VMON, CS35L41_INPUT_SRC_IMON, CS35L41_INPUT_SRC_VPMON,
+       CS35L41_INPUT_SRC_VBSTMON, CS35L41_INPUT_DSP_TX1, CS35L41_INPUT_DSP_TX2
+};
+
+static SOC_VALUE_ENUM_SINGLE_DECL(cs35l41_asptx1_enum,
+                                 CS35L41_ASP_TX1_SRC,
+                                 0, CS35L41_ASP_SOURCE_MASK,
+                                 cs35l41_tx_input_texts,
+                                 cs35l41_tx_input_values);
+
+static const struct snd_kcontrol_new asp_tx1_mux =
+       SOC_DAPM_ENUM("ASPTX1 SRC", cs35l41_asptx1_enum);
+
+static SOC_VALUE_ENUM_SINGLE_DECL(cs35l41_asptx2_enum,
+                                 CS35L41_ASP_TX2_SRC,
+                                 0, CS35L41_ASP_SOURCE_MASK,
+                                 cs35l41_tx_input_texts,
+                                 cs35l41_tx_input_values);
+
+static const struct snd_kcontrol_new asp_tx2_mux =
+       SOC_DAPM_ENUM("ASPTX2 SRC", cs35l41_asptx2_enum);
+
+static SOC_VALUE_ENUM_SINGLE_DECL(cs35l41_asptx3_enum,
+                                 CS35L41_ASP_TX3_SRC,
+                                 0, CS35L41_ASP_SOURCE_MASK,
+                                 cs35l41_tx_input_texts,
+                                 cs35l41_tx_input_values);
+
+static const struct snd_kcontrol_new asp_tx3_mux =
+       SOC_DAPM_ENUM("ASPTX3 SRC", cs35l41_asptx3_enum);
+
+static SOC_VALUE_ENUM_SINGLE_DECL(cs35l41_asptx4_enum,
+                                 CS35L41_ASP_TX4_SRC,
+                                 0, CS35L41_ASP_SOURCE_MASK,
+                                 cs35l41_tx_input_texts,
+                                 cs35l41_tx_input_values);
+
+static const struct snd_kcontrol_new asp_tx4_mux =
+       SOC_DAPM_ENUM("ASPTX4 SRC", cs35l41_asptx4_enum);
+
+static const struct snd_kcontrol_new cs35l41_aud_controls[] = {
+       SOC_SINGLE_SX_TLV("Digital PCM Volume", CS35L41_AMP_DIG_VOL_CTRL,
+                         3, 0x4CF, 0x391, dig_vol_tlv),
+       SOC_SINGLE_TLV("Analog PCM Volume", CS35L41_AMP_GAIN_CTRL, 5, 0x14, 0,
+                      amp_gain_tlv),
+       SOC_ENUM("PCM Soft Ramp", pcm_sft_ramp),
+       SOC_SINGLE("HW Noise Gate Enable", CS35L41_NG_CFG, 8, 63, 0),
+       SOC_SINGLE("HW Noise Gate Delay", CS35L41_NG_CFG, 4, 7, 0),
+       SOC_SINGLE("HW Noise Gate Threshold", CS35L41_NG_CFG, 0, 7, 0),
+       SOC_SINGLE("Aux Noise Gate CH1 Enable",
+                  CS35L41_MIXER_NGATE_CH1_CFG, 16, 1, 0),
+       SOC_SINGLE("Aux Noise Gate CH1 Entry Delay",
+                  CS35L41_MIXER_NGATE_CH1_CFG, 8, 15, 0),
+       SOC_SINGLE("Aux Noise Gate CH1 Threshold",
+                  CS35L41_MIXER_NGATE_CH1_CFG, 0, 7, 0),
+       SOC_SINGLE("Aux Noise Gate CH2 Entry Delay",
+                  CS35L41_MIXER_NGATE_CH2_CFG, 8, 15, 0),
+       SOC_SINGLE("Aux Noise Gate CH2 Enable",
+                  CS35L41_MIXER_NGATE_CH2_CFG, 16, 1, 0),
+       SOC_SINGLE("Aux Noise Gate CH2 Threshold",
+                  CS35L41_MIXER_NGATE_CH2_CFG, 0, 7, 0),
+       SOC_SINGLE("SCLK Force", CS35L41_SP_FORMAT, CS35L41_SCLK_FRC_SHIFT, 1, 0),
+       SOC_SINGLE("LRCLK Force", CS35L41_SP_FORMAT, CS35L41_LRCLK_FRC_SHIFT, 1, 0),
+       SOC_SINGLE("Invert Class D", CS35L41_AMP_DIG_VOL_CTRL,
+                  CS35L41_AMP_INV_PCM_SHIFT, 1, 0),
+       SOC_SINGLE("Amp Gain ZC", CS35L41_AMP_GAIN_CTRL,
+                  CS35L41_AMP_GAIN_ZC_SHIFT, 1, 0),
+};
+
+static const struct cs35l41_otp_map_element_t *cs35l41_find_otp_map(u32 otp_id)
+{
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(cs35l41_otp_map_map); i++) {
+               if (cs35l41_otp_map_map[i].id == otp_id)
+                       return &cs35l41_otp_map_map[i];
+       }
+
+       return NULL;
+}
+
+static int cs35l41_otp_unpack(void *data)
+{
+       const struct cs35l41_otp_map_element_t *otp_map_match;
+       const struct cs35l41_otp_packed_element_t *otp_map;
+       struct cs35l41_private *cs35l41 = data;
+       int bit_offset, word_offset, ret, i;
+       unsigned int orig_spi_freq;
+       unsigned int bit_sum = 8;
+       u32 otp_val, otp_id_reg;
+       u32 *otp_mem;
+
+       otp_mem = kmalloc_array(CS35L41_OTP_SIZE_WORDS, sizeof(*otp_mem), GFP_KERNEL);
+       if (!otp_mem)
+               return -ENOMEM;
+
+       ret = regmap_read(cs35l41->regmap, CS35L41_OTPID, &otp_id_reg);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Read OTP ID failed: %d\n", ret);
+               goto err_otp_unpack;
+       }
+
+       otp_map_match = cs35l41_find_otp_map(otp_id_reg);
+
+       if (!otp_map_match) {
+               dev_err(cs35l41->dev, "OTP Map matching ID %d not found\n",
+                       otp_id_reg);
+               ret = -EINVAL;
+               goto err_otp_unpack;
+       }
+
+       if (cs35l41->otp_setup)
+               cs35l41->otp_setup(cs35l41, true, &orig_spi_freq);
+
+       ret = regmap_bulk_read(cs35l41->regmap, CS35L41_OTP_MEM0, otp_mem,
+                              CS35L41_OTP_SIZE_WORDS);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Read OTP Mem failed: %d\n", ret);
+               goto err_otp_unpack;
+       }
+
+       if (cs35l41->otp_setup)
+               cs35l41->otp_setup(cs35l41, false, &orig_spi_freq);
+
+       otp_map = otp_map_match->map;
+
+       bit_offset = otp_map_match->bit_offset;
+       word_offset = otp_map_match->word_offset;
+
+       ret = regmap_write(cs35l41->regmap, CS35L41_TEST_KEY_CTL, 0x00000055);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write Unlock key failed 1/2: %d\n", ret);
+               goto err_otp_unpack;
+       }
+       ret = regmap_write(cs35l41->regmap, CS35L41_TEST_KEY_CTL, 0x000000AA);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write Unlock key failed 2/2: %d\n", ret);
+               goto err_otp_unpack;
+       }
+
+       for (i = 0; i < otp_map_match->num_elements; i++) {
+               dev_dbg(cs35l41->dev,
+                       "bitoffset= %d, word_offset=%d, bit_sum mod 32=%d\n",
+                       bit_offset, word_offset, bit_sum % 32);
+               if (bit_offset + otp_map[i].size - 1 >= 32) {
+                       otp_val = (otp_mem[word_offset] &
+                                       GENMASK(31, bit_offset)) >>
+                                       bit_offset;
+                       otp_val |= (otp_mem[++word_offset] &
+                                       GENMASK(bit_offset +
+                                               otp_map[i].size - 33, 0)) <<
+                                       (32 - bit_offset);
+                       bit_offset += otp_map[i].size - 32;
+               } else {
+                       otp_val = (otp_mem[word_offset] &
+                               GENMASK(bit_offset + otp_map[i].size - 1,
+                                       bit_offset)) >> bit_offset;
+                       bit_offset += otp_map[i].size;
+               }
+               bit_sum += otp_map[i].size;
+
+               if (bit_offset == 32) {
+                       bit_offset = 0;
+                       word_offset++;
+               }
+
+               if (otp_map[i].reg != 0) {
+                       ret = regmap_update_bits(cs35l41->regmap,
+                                                otp_map[i].reg,
+                                                GENMASK(otp_map[i].shift +
+                                                        otp_map[i].size - 1,
+                                                otp_map[i].shift),
+                                                otp_val << otp_map[i].shift);
+                       if (ret < 0) {
+                               dev_err(cs35l41->dev, "Write OTP val failed: %d\n",
+                                       ret);
+                               goto err_otp_unpack;
+                       }
+               }
+       }
+
+       ret = regmap_write(cs35l41->regmap, CS35L41_TEST_KEY_CTL, 0x000000CC);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write Lock key failed 1/2: %d\n", ret);
+               goto err_otp_unpack;
+       }
+       ret = regmap_write(cs35l41->regmap, CS35L41_TEST_KEY_CTL, 0x00000033);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write Lock key failed 2/2: %d\n", ret);
+               goto err_otp_unpack;
+       }
+       ret = 0;
+
+err_otp_unpack:
+       kfree(otp_mem);
+       return ret;
+}
+
+static irqreturn_t cs35l41_irq(int irq, void *data)
+{
+       struct cs35l41_private *cs35l41 = data;
+       unsigned int status[4] = { 0, 0, 0, 0 };
+       unsigned int masks[4] = { 0, 0, 0, 0 };
+       int ret = IRQ_NONE;
+       unsigned int i;
+
+       for (i = 0; i < ARRAY_SIZE(status); i++) {
+               regmap_read(cs35l41->regmap,
+                           CS35L41_IRQ1_STATUS1 + (i * CS35L41_REGSTRIDE),
+                           &status[i]);
+               regmap_read(cs35l41->regmap,
+                           CS35L41_IRQ1_MASK1 + (i * CS35L41_REGSTRIDE),
+                           &masks[i]);
+       }
+
+       /* Check to see if unmasked bits are active */
+       if (!(status[0] & ~masks[0]) && !(status[1] & ~masks[1]) &&
+           !(status[2] & ~masks[2]) && !(status[3] & ~masks[3]))
+               return IRQ_NONE;
+
+       if (status[3] & CS35L41_OTP_BOOT_DONE) {
+               regmap_update_bits(cs35l41->regmap, CS35L41_IRQ1_MASK4,
+                                  CS35L41_OTP_BOOT_DONE, CS35L41_OTP_BOOT_DONE);
+       }
+
+       /*
+        * The following interrupts require a
+        * protection release cycle to get the
+        * speaker out of Safe-Mode.
+        */
+       if (status[0] & CS35L41_AMP_SHORT_ERR) {
+               dev_crit_ratelimited(cs35l41->dev, "Amp short error\n");
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_AMP_SHORT_ERR);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_AMP_SHORT_ERR_RLS,
+                                  CS35L41_AMP_SHORT_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_AMP_SHORT_ERR_RLS, 0);
+               ret = IRQ_HANDLED;
+       }
+
+       if (status[0] & CS35L41_TEMP_WARN) {
+               dev_crit_ratelimited(cs35l41->dev, "Over temperature warning\n");
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_TEMP_WARN);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_TEMP_WARN_ERR_RLS,
+                                  CS35L41_TEMP_WARN_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_TEMP_WARN_ERR_RLS, 0);
+               ret = IRQ_HANDLED;
+       }
+
+       if (status[0] & CS35L41_TEMP_ERR) {
+               dev_crit_ratelimited(cs35l41->dev, "Over temperature error\n");
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_TEMP_ERR);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_TEMP_ERR_RLS,
+                                  CS35L41_TEMP_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_TEMP_ERR_RLS, 0);
+               ret = IRQ_HANDLED;
+       }
+
+       if (status[0] & CS35L41_BST_OVP_ERR) {
+               dev_crit_ratelimited(cs35l41->dev, "VBST Over Voltage error\n");
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK, 0);
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_BST_OVP_ERR);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_OVP_ERR_RLS,
+                                  CS35L41_BST_OVP_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_OVP_ERR_RLS, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK,
+                                  CS35L41_BST_EN_DEFAULT << CS35L41_BST_EN_SHIFT);
+               ret = IRQ_HANDLED;
+       }
+
+       if (status[0] & CS35L41_BST_DCM_UVP_ERR) {
+               dev_crit_ratelimited(cs35l41->dev, "DCM VBST Under Voltage Error\n");
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK, 0);
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_BST_DCM_UVP_ERR);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_UVP_ERR_RLS,
+                                  CS35L41_BST_UVP_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_UVP_ERR_RLS, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK,
+                                  CS35L41_BST_EN_DEFAULT << CS35L41_BST_EN_SHIFT);
+               ret = IRQ_HANDLED;
+       }
+
+       if (status[0] & CS35L41_BST_SHORT_ERR) {
+               dev_crit_ratelimited(cs35l41->dev, "LBST error: powering off!\n");
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK, 0);
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_BST_SHORT_ERR);
+               regmap_write(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_SHORT_ERR_RLS,
+                                  CS35L41_BST_SHORT_ERR_RLS);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PROTECT_REL_ERR_IGN,
+                                  CS35L41_BST_SHORT_ERR_RLS, 0);
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                  CS35L41_BST_EN_MASK,
+                                  CS35L41_BST_EN_DEFAULT << CS35L41_BST_EN_SHIFT);
+               ret = IRQ_HANDLED;
+       }
+
+       return ret;
+}
+
+static const struct reg_sequence cs35l41_pup_patch[] = {
+       { 0x00000040, 0x00000055 },
+       { 0x00000040, 0x000000AA },
+       { 0x00002084, 0x002F1AA0 },
+       { 0x00000040, 0x000000CC },
+       { 0x00000040, 0x00000033 },
+};
+
+static const struct reg_sequence cs35l41_pdn_patch[] = {
+       { 0x00000040, 0x00000055 },
+       { 0x00000040, 0x000000AA },
+       { 0x00002084, 0x002F1AA3 },
+       { 0x00000040, 0x000000CC },
+       { 0x00000040, 0x00000033 },
+};
+
+static int cs35l41_main_amp_event(struct snd_soc_dapm_widget *w,
+                                 struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(component);
+       unsigned int val;
+       int ret = 0;
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               regmap_multi_reg_write_bypassed(cs35l41->regmap,
+                                               cs35l41_pup_patch,
+                                               ARRAY_SIZE(cs35l41_pup_patch));
+
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL1,
+                                  CS35L41_GLOBAL_EN_MASK,
+                                  1 << CS35L41_GLOBAL_EN_SHIFT);
+
+               usleep_range(1000, 1100);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL1,
+                                  CS35L41_GLOBAL_EN_MASK, 0);
+
+               ret = regmap_read_poll_timeout(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                                              val, val &  CS35L41_PDN_DONE_MASK,
+                                              1000, 100000);
+               if (ret)
+                       dev_warn(cs35l41->dev, "PDN failed: %d\n", ret);
+
+               regmap_write(cs35l41->regmap, CS35L41_IRQ1_STATUS1,
+                            CS35L41_PDN_DONE_MASK);
+
+               regmap_multi_reg_write_bypassed(cs35l41->regmap,
+                                               cs35l41_pdn_patch,
+                                               ARRAY_SIZE(cs35l41_pdn_patch));
+               break;
+       default:
+               dev_err(cs35l41->dev, "Invalid event = 0x%x\n", event);
+               ret = -EINVAL;
+       }
+
+       return ret;
+}
+
+static const struct snd_soc_dapm_widget cs35l41_dapm_widgets[] = {
+       SND_SOC_DAPM_OUTPUT("SPK"),
+
+       SND_SOC_DAPM_AIF_IN("ASPRX1", NULL, 0, CS35L41_SP_ENABLES, 16, 0),
+       SND_SOC_DAPM_AIF_IN("ASPRX2", NULL, 0, CS35L41_SP_ENABLES, 17, 0),
+       SND_SOC_DAPM_AIF_OUT("ASPTX1", NULL, 0, CS35L41_SP_ENABLES, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("ASPTX2", NULL, 0, CS35L41_SP_ENABLES, 1, 0),
+       SND_SOC_DAPM_AIF_OUT("ASPTX3", NULL, 0, CS35L41_SP_ENABLES, 2, 0),
+       SND_SOC_DAPM_AIF_OUT("ASPTX4", NULL, 0, CS35L41_SP_ENABLES, 3, 0),
+
+       SND_SOC_DAPM_ADC("VMON ADC", NULL, CS35L41_PWR_CTRL2, 12, 0),
+       SND_SOC_DAPM_ADC("IMON ADC", NULL, CS35L41_PWR_CTRL2, 13, 0),
+       SND_SOC_DAPM_ADC("VPMON ADC", NULL, CS35L41_PWR_CTRL2, 8, 0),
+       SND_SOC_DAPM_ADC("VBSTMON ADC", NULL, CS35L41_PWR_CTRL2, 9, 0),
+       SND_SOC_DAPM_ADC("TEMPMON ADC", NULL, CS35L41_PWR_CTRL2, 10, 0),
+       SND_SOC_DAPM_ADC("CLASS H", NULL, CS35L41_PWR_CTRL3, 4, 0),
+
+       SND_SOC_DAPM_OUT_DRV_E("Main AMP", CS35L41_PWR_CTRL2, 0, 0, NULL, 0,
+                              cs35l41_main_amp_event,
+                              SND_SOC_DAPM_POST_PMD |  SND_SOC_DAPM_POST_PMU),
+
+       SND_SOC_DAPM_INPUT("VP"),
+       SND_SOC_DAPM_INPUT("VBST"),
+       SND_SOC_DAPM_INPUT("ISENSE"),
+       SND_SOC_DAPM_INPUT("VSENSE"),
+       SND_SOC_DAPM_INPUT("TEMP"),
+
+       SND_SOC_DAPM_MUX("ASP TX1 Source", SND_SOC_NOPM, 0, 0, &asp_tx1_mux),
+       SND_SOC_DAPM_MUX("ASP TX2 Source", SND_SOC_NOPM, 0, 0, &asp_tx2_mux),
+       SND_SOC_DAPM_MUX("ASP TX3 Source", SND_SOC_NOPM, 0, 0, &asp_tx3_mux),
+       SND_SOC_DAPM_MUX("ASP TX4 Source", SND_SOC_NOPM, 0, 0, &asp_tx4_mux),
+       SND_SOC_DAPM_MUX("PCM Source", SND_SOC_NOPM, 0, 0, &pcm_source_mux),
+       SND_SOC_DAPM_SWITCH("DRE", SND_SOC_NOPM, 0, 0, &dre_ctrl),
+};
+
+static const struct snd_soc_dapm_route cs35l41_audio_map[] = {
+       {"ASP TX1 Source", "VMON", "VMON ADC"},
+       {"ASP TX1 Source", "IMON", "IMON ADC"},
+       {"ASP TX1 Source", "VPMON", "VPMON ADC"},
+       {"ASP TX1 Source", "VBSTMON", "VBSTMON ADC"},
+       {"ASP TX1 Source", "ASPRX1", "ASPRX1" },
+       {"ASP TX1 Source", "ASPRX2", "ASPRX2" },
+       {"ASP TX2 Source", "VMON", "VMON ADC"},
+       {"ASP TX2 Source", "IMON", "IMON ADC"},
+       {"ASP TX2 Source", "VPMON", "VPMON ADC"},
+       {"ASP TX2 Source", "VBSTMON", "VBSTMON ADC"},
+       {"ASP TX2 Source", "ASPRX1", "ASPRX1" },
+       {"ASP TX2 Source", "ASPRX2", "ASPRX2" },
+       {"ASP TX3 Source", "VMON", "VMON ADC"},
+       {"ASP TX3 Source", "IMON", "IMON ADC"},
+       {"ASP TX3 Source", "VPMON", "VPMON ADC"},
+       {"ASP TX3 Source", "VBSTMON", "VBSTMON ADC"},
+       {"ASP TX3 Source", "ASPRX1", "ASPRX1" },
+       {"ASP TX3 Source", "ASPRX2", "ASPRX2" },
+       {"ASP TX4 Source", "VMON", "VMON ADC"},
+       {"ASP TX4 Source", "IMON", "IMON ADC"},
+       {"ASP TX4 Source", "VPMON", "VPMON ADC"},
+       {"ASP TX4 Source", "VBSTMON", "VBSTMON ADC"},
+       {"ASP TX4 Source", "ASPRX1", "ASPRX1" },
+       {"ASP TX4 Source", "ASPRX2", "ASPRX2" },
+       {"ASPTX1", NULL, "ASP TX1 Source"},
+       {"ASPTX2", NULL, "ASP TX2 Source"},
+       {"ASPTX3", NULL, "ASP TX3 Source"},
+       {"ASPTX4", NULL, "ASP TX4 Source"},
+       {"AMP Capture", NULL, "ASPTX1"},
+       {"AMP Capture", NULL, "ASPTX2"},
+       {"AMP Capture", NULL, "ASPTX3"},
+       {"AMP Capture", NULL, "ASPTX4"},
+
+       {"VMON ADC", NULL, "VSENSE"},
+       {"IMON ADC", NULL, "ISENSE"},
+       {"VPMON ADC", NULL, "VP"},
+       {"TEMPMON ADC", NULL, "TEMP"},
+       {"VBSTMON ADC", NULL, "VBST"},
+
+       {"ASPRX1", NULL, "AMP Playback"},
+       {"ASPRX2", NULL, "AMP Playback"},
+       {"DRE", "Switch", "CLASS H"},
+       {"Main AMP", NULL, "CLASS H"},
+       {"Main AMP", NULL, "DRE"},
+       {"SPK", NULL, "Main AMP"},
+
+       {"PCM Source", "ASP", "ASPRX1"},
+       {"CLASS H", NULL, "PCM Source"},
+};
+
+static int cs35l41_set_channel_map(struct snd_soc_dai *dai, unsigned int tx_num,
+                                  unsigned int *tx_slot, unsigned int rx_num,
+                                  unsigned int *rx_slot)
+{
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(dai->component);
+       unsigned int val, mask;
+       int i;
+
+       if (tx_num > 4 || rx_num > 2)
+               return -EINVAL;
+
+       val = 0;
+       mask = 0;
+       for (i = 0; i < rx_num; i++) {
+               dev_dbg(cs35l41->dev, "rx slot %d position = %d\n", i, rx_slot[i]);
+               val |= rx_slot[i] << (i * 8);
+               mask |= 0x3F << (i * 8);
+       }
+       regmap_update_bits(cs35l41->regmap, CS35L41_SP_FRAME_RX_SLOT, mask, val);
+
+       val = 0;
+       mask = 0;
+       for (i = 0; i < tx_num; i++) {
+               dev_dbg(cs35l41->dev, "tx slot %d position = %d\n", i, tx_slot[i]);
+               val |= tx_slot[i] << (i * 8);
+               mask |= 0x3F << (i * 8);
+       }
+       regmap_update_bits(cs35l41->regmap, CS35L41_SP_FRAME_TX_SLOT, mask, val);
+
+       return 0;
+}
+
+static int cs35l41_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(dai->component);
+       unsigned int daifmt = 0;
+
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               daifmt |= CS35L41_SCLK_MSTR_MASK | CS35L41_LRCLK_MSTR_MASK;
+               break;
+       case SND_SOC_DAIFMT_CBC_CFC:
+               break;
+       default:
+               dev_warn(cs35l41->dev, "Mixed provider/consumer mode unsupported\n");
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_DSP_A:
+               break;
+       case SND_SOC_DAIFMT_I2S:
+               daifmt |= 2 << CS35L41_ASP_FMT_SHIFT;
+               break;
+       default:
+               dev_warn(cs35l41->dev, "Invalid or unsupported DAI format\n");
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+       case SND_SOC_DAIFMT_NB_IF:
+               daifmt |= CS35L41_LRCLK_INV_MASK;
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               daifmt |= CS35L41_SCLK_INV_MASK;
+               break;
+       case SND_SOC_DAIFMT_IB_IF:
+               daifmt |= CS35L41_LRCLK_INV_MASK | CS35L41_SCLK_INV_MASK;
+               break;
+       case SND_SOC_DAIFMT_NB_NF:
+               break;
+       default:
+               dev_warn(cs35l41->dev, "Invalid DAI clock INV\n");
+               return -EINVAL;
+       }
+
+       return regmap_update_bits(cs35l41->regmap, CS35L41_SP_FORMAT,
+                                 CS35L41_SCLK_MSTR_MASK | CS35L41_LRCLK_MSTR_MASK |
+                                 CS35L41_ASP_FMT_MASK | CS35L41_LRCLK_INV_MASK |
+                                 CS35L41_SCLK_INV_MASK, daifmt);
+}
+
+struct cs35l41_global_fs_config {
+       int rate;
+       int fs_cfg;
+};
+
+static const struct cs35l41_global_fs_config cs35l41_fs_rates[] = {
+       { 12000,        0x01 },
+       { 24000,        0x02 },
+       { 48000,        0x03 },
+       { 96000,        0x04 },
+       { 192000,       0x05 },
+       { 11025,        0x09 },
+       { 22050,        0x0A },
+       { 44100,        0x0B },
+       { 88200,        0x0C },
+       { 176400,       0x0D },
+       { 8000,         0x11 },
+       { 16000,        0x12 },
+       { 32000,        0x13 },
+};
+
+static int cs35l41_pcm_hw_params(struct snd_pcm_substream *substream,
+                                struct snd_pcm_hw_params *params,
+                                struct snd_soc_dai *dai)
+{
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(dai->component);
+       unsigned int rate = params_rate(params);
+       u8 asp_wl;
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(cs35l41_fs_rates); i++) {
+               if (rate == cs35l41_fs_rates[i].rate)
+                       break;
+       }
+
+       if (i >= ARRAY_SIZE(cs35l41_fs_rates)) {
+               dev_err(cs35l41->dev, "Unsupported rate: %u\n", rate);
+               return -EINVAL;
+       }
+
+       asp_wl = params_width(params);
+
+       if (i < ARRAY_SIZE(cs35l41_fs_rates))
+               regmap_update_bits(cs35l41->regmap, CS35L41_GLOBAL_CLK_CTRL,
+                                  CS35L41_GLOBAL_FS_MASK,
+                                  cs35l41_fs_rates[i].fs_cfg << CS35L41_GLOBAL_FS_SHIFT);
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               regmap_update_bits(cs35l41->regmap, CS35L41_SP_FORMAT,
+                                  CS35L41_ASP_WIDTH_RX_MASK,
+                                  asp_wl << CS35L41_ASP_WIDTH_RX_SHIFT);
+               regmap_update_bits(cs35l41->regmap, CS35L41_SP_RX_WL,
+                                  CS35L41_ASP_RX_WL_MASK,
+                                  asp_wl << CS35L41_ASP_RX_WL_SHIFT);
+       } else {
+               regmap_update_bits(cs35l41->regmap, CS35L41_SP_FORMAT,
+                                  CS35L41_ASP_WIDTH_TX_MASK,
+                                  asp_wl << CS35L41_ASP_WIDTH_TX_SHIFT);
+               regmap_update_bits(cs35l41->regmap, CS35L41_SP_TX_WL,
+                                  CS35L41_ASP_TX_WL_MASK,
+                                  asp_wl << CS35L41_ASP_TX_WL_SHIFT);
+       }
+
+       return 0;
+}
+
+static int cs35l41_get_clk_config(int freq)
+{
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(cs35l41_pll_sysclk); i++) {
+               if (cs35l41_pll_sysclk[i].freq == freq)
+                       return cs35l41_pll_sysclk[i].clk_cfg;
+       }
+
+       return -EINVAL;
+}
+
+static const unsigned int cs35l41_src_rates[] = {
+       8000, 12000, 11025, 16000, 22050, 24000, 32000,
+       44100, 48000, 88200, 96000, 176400, 192000
+};
+
+static const struct snd_pcm_hw_constraint_list cs35l41_constraints = {
+       .count = ARRAY_SIZE(cs35l41_src_rates),
+       .list = cs35l41_src_rates,
+};
+
+static int cs35l41_pcm_startup(struct snd_pcm_substream *substream,
+                              struct snd_soc_dai *dai)
+{
+       if (substream->runtime)
+               return snd_pcm_hw_constraint_list(substream->runtime, 0,
+                                                 SNDRV_PCM_HW_PARAM_RATE,
+                                                 &cs35l41_constraints);
+       return 0;
+}
+
+static int cs35l41_component_set_sysclk(struct snd_soc_component *component,
+                                       int clk_id, int source,
+                                       unsigned int freq, int dir)
+{
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(component);
+       int extclk_cfg, clksrc;
+
+       switch (clk_id) {
+       case CS35L41_CLKID_SCLK:
+               clksrc = CS35L41_PLLSRC_SCLK;
+               break;
+       case CS35L41_CLKID_LRCLK:
+               clksrc = CS35L41_PLLSRC_LRCLK;
+               break;
+       case CS35L41_CLKID_MCLK:
+               clksrc = CS35L41_PLLSRC_MCLK;
+               break;
+       default:
+               dev_err(cs35l41->dev, "Invalid CLK Config\n");
+               return -EINVAL;
+       }
+
+       extclk_cfg = cs35l41_get_clk_config(freq);
+
+       if (extclk_cfg < 0) {
+               dev_err(cs35l41->dev, "Invalid CLK Config: %d, freq: %u\n",
+                       extclk_cfg, freq);
+               return -EINVAL;
+       }
+
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_PLL_OPENLOOP_MASK,
+                          1 << CS35L41_PLL_OPENLOOP_SHIFT);
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_REFCLK_FREQ_MASK,
+                          extclk_cfg << CS35L41_REFCLK_FREQ_SHIFT);
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_PLL_CLK_EN_MASK,
+                          0 << CS35L41_PLL_CLK_EN_SHIFT);
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_PLL_CLK_SEL_MASK, clksrc);
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_PLL_OPENLOOP_MASK,
+                          0 << CS35L41_PLL_OPENLOOP_SHIFT);
+       regmap_update_bits(cs35l41->regmap, CS35L41_PLL_CLK_CTRL,
+                          CS35L41_PLL_CLK_EN_MASK,
+                          1 << CS35L41_PLL_CLK_EN_SHIFT);
+
+       return 0;
+}
+
+static int cs35l41_dai_set_sysclk(struct snd_soc_dai *dai,
+                                 int clk_id, unsigned int freq, int dir)
+{
+       struct cs35l41_private *cs35l41 = snd_soc_component_get_drvdata(dai->component);
+       unsigned int fs1_val;
+       unsigned int fs2_val;
+       unsigned int val;
+       int fsindex;
+
+       fsindex = cs35l41_get_fs_mon_config_index(freq);
+       if (fsindex < 0) {
+               dev_err(cs35l41->dev, "Invalid CLK Config freq: %u\n", freq);
+               return -EINVAL;
+       }
+
+       dev_dbg(cs35l41->dev, "Set DAI sysclk %d\n", freq);
+
+       if (freq <= 6144000) {
+               /* Use the lookup table */
+               fs1_val = cs35l41_fs_mon[fsindex].fs1;
+               fs2_val = cs35l41_fs_mon[fsindex].fs2;
+       } else {
+               /* Use hard-coded values */
+               fs1_val = 0x10;
+               fs2_val = 0x24;
+       }
+
+       val = fs1_val;
+       val |= (fs2_val << CS35L41_FS2_WINDOW_SHIFT) & CS35L41_FS2_WINDOW_MASK;
+       regmap_write(cs35l41->regmap, CS35L41_TST_FS_MON0, val);
+
+       return 0;
+}
+
+static int cs35l41_boost_config(struct cs35l41_private *cs35l41,
+                               int boost_ind, int boost_cap, int boost_ipk)
+{
+       unsigned char bst_lbst_val, bst_cbst_range, bst_ipk_scaled;
+       struct regmap *regmap = cs35l41->regmap;
+       struct device *dev = cs35l41->dev;
+       int ret;
+
+       switch (boost_ind) {
+       case 1000:      /* 1.0 uH */
+               bst_lbst_val = 0;
+               break;
+       case 1200:      /* 1.2 uH */
+               bst_lbst_val = 1;
+               break;
+       case 1500:      /* 1.5 uH */
+               bst_lbst_val = 2;
+               break;
+       case 2200:      /* 2.2 uH */
+               bst_lbst_val = 3;
+               break;
+       default:
+               dev_err(dev, "Invalid boost inductor value: %d nH\n", boost_ind);
+               return -EINVAL;
+       }
+
+       switch (boost_cap) {
+       case 0 ... 19:
+               bst_cbst_range = 0;
+               break;
+       case 20 ... 50:
+               bst_cbst_range = 1;
+               break;
+       case 51 ... 100:
+               bst_cbst_range = 2;
+               break;
+       case 101 ... 200:
+               bst_cbst_range = 3;
+               break;
+       default:        /* 201 uF and greater */
+               bst_cbst_range = 4;
+       }
+
+       ret = regmap_update_bits(regmap, CS35L41_BSTCVRT_COEFF,
+                                CS35L41_BST_K1_MASK | CS35L41_BST_K2_MASK,
+                                cs35l41_bst_k1_table[bst_lbst_val][bst_cbst_range]
+                                       << CS35L41_BST_K1_SHIFT |
+                                cs35l41_bst_k2_table[bst_lbst_val][bst_cbst_range]
+                                       << CS35L41_BST_K2_SHIFT);
+       if (ret) {
+               dev_err(dev, "Failed to write boost coefficients: %d\n", ret);
+               return ret;
+       }
+
+       ret = regmap_update_bits(regmap, CS35L41_BSTCVRT_SLOPE_LBST,
+                                CS35L41_BST_SLOPE_MASK | CS35L41_BST_LBST_VAL_MASK,
+                                cs35l41_bst_slope_table[bst_lbst_val]
+                                       << CS35L41_BST_SLOPE_SHIFT |
+                                bst_lbst_val << CS35L41_BST_LBST_VAL_SHIFT);
+       if (ret) {
+               dev_err(dev, "Failed to write boost slope/inductor value: %d\n", ret);
+               return ret;
+       }
+
+       if (boost_ipk < 1600 || boost_ipk > 4500) {
+               dev_err(dev, "Invalid boost inductor peak current: %d mA\n",
+                       boost_ipk);
+               return -EINVAL;
+       }
+       bst_ipk_scaled = ((boost_ipk - 1600) / 50) + 0x10;
+
+       ret = regmap_update_bits(regmap, CS35L41_BSTCVRT_PEAK_CUR,
+                                CS35L41_BST_IPK_MASK,
+                                bst_ipk_scaled << CS35L41_BST_IPK_SHIFT);
+       if (ret) {
+               dev_err(dev, "Failed to write boost inductor peak current: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+static int cs35l41_set_pdata(struct cs35l41_private *cs35l41)
+{
+       int ret;
+
+       /* Set Platform Data */
+       /* Required */
+       if (cs35l41->pdata.bst_ipk &&
+           cs35l41->pdata.bst_ind && cs35l41->pdata.bst_cap) {
+               ret = cs35l41_boost_config(cs35l41, cs35l41->pdata.bst_ind,
+                                          cs35l41->pdata.bst_cap,
+                                          cs35l41->pdata.bst_ipk);
+               if (ret) {
+                       dev_err(cs35l41->dev, "Error in Boost DT config: %d\n", ret);
+                       return ret;
+               }
+       } else {
+               dev_err(cs35l41->dev, "Incomplete Boost component DT config\n");
+               return -EINVAL;
+       }
+
+       /* Optional */
+       if (cs35l41->pdata.dout_hiz <= CS35L41_ASP_DOUT_HIZ_MASK &&
+           cs35l41->pdata.dout_hiz >= 0)
+               regmap_update_bits(cs35l41->regmap, CS35L41_SP_HIZ_CTRL,
+                                  CS35L41_ASP_DOUT_HIZ_MASK,
+                                  cs35l41->pdata.dout_hiz);
+
+       return 0;
+}
+
+static int cs35l41_irq_gpio_config(struct cs35l41_private *cs35l41)
+{
+       struct cs35l41_irq_cfg *irq_gpio_cfg1 = &cs35l41->pdata.irq_config1;
+       struct cs35l41_irq_cfg *irq_gpio_cfg2 = &cs35l41->pdata.irq_config2;
+       int irq_pol = IRQF_TRIGGER_NONE;
+
+       regmap_update_bits(cs35l41->regmap, CS35L41_GPIO1_CTRL1,
+                          CS35L41_GPIO_POL_MASK | CS35L41_GPIO_DIR_MASK,
+                          irq_gpio_cfg1->irq_pol_inv << CS35L41_GPIO_POL_SHIFT |
+                          !irq_gpio_cfg1->irq_out_en << CS35L41_GPIO_DIR_SHIFT);
+
+       regmap_update_bits(cs35l41->regmap, CS35L41_GPIO2_CTRL1,
+                          CS35L41_GPIO_POL_MASK | CS35L41_GPIO_DIR_MASK,
+                          irq_gpio_cfg1->irq_pol_inv << CS35L41_GPIO_POL_SHIFT |
+                          !irq_gpio_cfg1->irq_out_en << CS35L41_GPIO_DIR_SHIFT);
+
+       regmap_update_bits(cs35l41->regmap, CS35L41_GPIO_PAD_CONTROL,
+                          CS35L41_GPIO1_CTRL_MASK | CS35L41_GPIO2_CTRL_MASK,
+                          irq_gpio_cfg1->irq_src_sel << CS35L41_GPIO1_CTRL_SHIFT |
+                          irq_gpio_cfg2->irq_src_sel << CS35L41_GPIO2_CTRL_SHIFT);
+
+       if ((irq_gpio_cfg2->irq_src_sel ==
+                       (CS35L41_GPIO_CTRL_ACTV_LO | CS35L41_VALID_PDATA)) ||
+               (irq_gpio_cfg2->irq_src_sel ==
+                       (CS35L41_GPIO_CTRL_OPEN_INT | CS35L41_VALID_PDATA)))
+               irq_pol = IRQF_TRIGGER_LOW;
+       else if (irq_gpio_cfg2->irq_src_sel ==
+                       (CS35L41_GPIO_CTRL_ACTV_HI | CS35L41_VALID_PDATA))
+               irq_pol = IRQF_TRIGGER_HIGH;
+
+       return irq_pol;
+}
+
+static const struct snd_soc_dai_ops cs35l41_ops = {
+       .startup = cs35l41_pcm_startup,
+       .set_fmt = cs35l41_set_dai_fmt,
+       .hw_params = cs35l41_pcm_hw_params,
+       .set_sysclk = cs35l41_dai_set_sysclk,
+       .set_channel_map = cs35l41_set_channel_map,
+};
+
+static struct snd_soc_dai_driver cs35l41_dai[] = {
+       {
+               .name = "cs35l41-pcm",
+               .id = 0,
+               .playback = {
+                       .stream_name = "AMP Playback",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = SNDRV_PCM_RATE_KNOT,
+                       .formats = CS35L41_RX_FORMATS,
+               },
+               .capture = {
+                       .stream_name = "AMP Capture",
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rates = SNDRV_PCM_RATE_KNOT,
+                       .formats = CS35L41_TX_FORMATS,
+               },
+               .ops = &cs35l41_ops,
+               .symmetric_rate = 1,
+       },
+};
+
+static const struct snd_soc_component_driver soc_component_dev_cs35l41 = {
+       .name = "cs35l41-codec",
+
+       .dapm_widgets = cs35l41_dapm_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(cs35l41_dapm_widgets),
+       .dapm_routes = cs35l41_audio_map,
+       .num_dapm_routes = ARRAY_SIZE(cs35l41_audio_map),
+
+       .controls = cs35l41_aud_controls,
+       .num_controls = ARRAY_SIZE(cs35l41_aud_controls),
+       .set_sysclk = cs35l41_component_set_sysclk,
+};
+
+static int cs35l41_handle_pdata(struct device *dev,
+                               struct cs35l41_platform_data *pdata,
+                               struct cs35l41_private *cs35l41)
+{
+       struct cs35l41_irq_cfg *irq_gpio1_config = &pdata->irq_config1;
+       struct cs35l41_irq_cfg *irq_gpio2_config = &pdata->irq_config2;
+       unsigned int val;
+       int ret;
+
+       ret = device_property_read_u32(dev, "cirrus,boost-peak-milliamp", &val);
+       if (ret >= 0)
+               pdata->bst_ipk = val;
+
+       ret = device_property_read_u32(dev, "cirrus,boost-ind-nanohenry", &val);
+       if (ret >= 0)
+               pdata->bst_ind = val;
+
+       ret = device_property_read_u32(dev, "cirrus,boost-cap-microfarad", &val);
+       if (ret >= 0)
+               pdata->bst_cap = val;
+
+       ret = device_property_read_u32(dev, "cirrus,asp-sdout-hiz", &val);
+       if (ret >= 0)
+               pdata->dout_hiz = val;
+       else
+               pdata->dout_hiz = -1;
+
+       /* GPIO1 Pin Config */
+       irq_gpio1_config->irq_pol_inv = device_property_read_bool(dev,
+                                       "cirrus,gpio1-polarity-invert");
+       irq_gpio1_config->irq_out_en = device_property_read_bool(dev,
+                                       "cirrus,gpio1-output-enable");
+       ret = device_property_read_u32(dev, "cirrus,gpio1-src-select",
+                                      &val);
+       if (ret >= 0)
+               irq_gpio1_config->irq_src_sel = val | CS35L41_VALID_PDATA;
+
+       /* GPIO2 Pin Config */
+       irq_gpio2_config->irq_pol_inv = device_property_read_bool(dev,
+                                       "cirrus,gpio2-polarity-invert");
+       irq_gpio2_config->irq_out_en = device_property_read_bool(dev,
+                                       "cirrus,gpio2-output-enable");
+       ret = device_property_read_u32(dev, "cirrus,gpio2-src-select",
+                                      &val);
+       if (ret >= 0)
+               irq_gpio2_config->irq_src_sel = val | CS35L41_VALID_PDATA;
+
+       return 0;
+}
+
+static const struct reg_sequence cs35l41_reva0_errata_patch[] = {
+       { 0x00000040,                    0x00005555 },
+       { 0x00000040,                    0x0000AAAA },
+       { 0x00003854,                    0x05180240 },
+       { CS35L41_VIMON_SPKMON_RESYNC,   0x00000000 },
+       { 0x00004310,                    0x00000000 },
+       { CS35L41_VPVBST_FS_SEL,         0x00000000 },
+       { CS35L41_OTP_TRIM_30,           0x9091A1C8 },
+       { 0x00003014,                    0x0200EE0E },
+       { CS35L41_BSTCVRT_DCM_CTRL,      0x00000051 },
+       { 0x00000054,                    0x00000004 },
+       { CS35L41_IRQ1_DB3,              0x00000000 },
+       { CS35L41_IRQ2_DB3,              0x00000000 },
+       { CS35L41_DSP1_YM_ACCEL_PL0_PRI, 0x00000000 },
+       { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 },
+       { 0x00000040,                    0x0000CCCC },
+       { 0x00000040,                    0x00003333 },
+};
+
+static const struct reg_sequence cs35l41_revb0_errata_patch[] = {
+       { 0x00000040,                    0x00005555 },
+       { 0x00000040,                    0x0000AAAA },
+       { CS35L41_VIMON_SPKMON_RESYNC,   0x00000000 },
+       { 0x00004310,                    0x00000000 },
+       { CS35L41_VPVBST_FS_SEL,         0x00000000 },
+       { CS35L41_BSTCVRT_DCM_CTRL,      0x00000051 },
+       { CS35L41_DSP1_YM_ACCEL_PL0_PRI, 0x00000000 },
+       { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 },
+       { 0x00000040,                    0x0000CCCC },
+       { 0x00000040,                    0x00003333 },
+};
+
+static const struct reg_sequence cs35l41_revb2_errata_patch[] = {
+       { 0x00000040,                    0x00005555 },
+       { 0x00000040,                    0x0000AAAA },
+       { CS35L41_VIMON_SPKMON_RESYNC,   0x00000000 },
+       { 0x00004310,                    0x00000000 },
+       { CS35L41_VPVBST_FS_SEL,         0x00000000 },
+       { CS35L41_BSTCVRT_DCM_CTRL,      0x00000051 },
+       { CS35L41_DSP1_YM_ACCEL_PL0_PRI, 0x00000000 },
+       { CS35L41_DSP1_XM_ACCEL_PL0_PRI, 0x00000000 },
+       { 0x00000040,                    0x0000CCCC },
+       { 0x00000040,                    0x00003333 },
+};
+
+int cs35l41_probe(struct cs35l41_private *cs35l41,
+                 struct cs35l41_platform_data *pdata)
+{
+       u32 regid, reg_revid, i, mtl_revid, int_status, chipid_match;
+       int irq_pol = 0;
+       int ret;
+
+       if (pdata) {
+               cs35l41->pdata = *pdata;
+       } else {
+               ret = cs35l41_handle_pdata(cs35l41->dev, &cs35l41->pdata, cs35l41);
+               if (ret != 0)
+                       return ret;
+       }
+
+       for (i = 0; i < CS35L41_NUM_SUPPLIES; i++)
+               cs35l41->supplies[i].supply = cs35l41_supplies[i];
+
+       ret = devm_regulator_bulk_get(cs35l41->dev, CS35L41_NUM_SUPPLIES,
+                                     cs35l41->supplies);
+       if (ret != 0) {
+               dev_err(cs35l41->dev, "Failed to request core supplies: %d\n", ret);
+               return ret;
+       }
+
+       ret = regulator_bulk_enable(CS35L41_NUM_SUPPLIES, cs35l41->supplies);
+       if (ret != 0) {
+               dev_err(cs35l41->dev, "Failed to enable core supplies: %d\n", ret);
+               return ret;
+       }
+
+       /* returning NULL can be an option if in stereo mode */
+       cs35l41->reset_gpio = devm_gpiod_get_optional(cs35l41->dev, "reset",
+                                                     GPIOD_OUT_LOW);
+       if (IS_ERR(cs35l41->reset_gpio)) {
+               ret = PTR_ERR(cs35l41->reset_gpio);
+               cs35l41->reset_gpio = NULL;
+               if (ret == -EBUSY) {
+                       dev_info(cs35l41->dev,
+                                "Reset line busy, assuming shared reset\n");
+               } else {
+                       dev_err(cs35l41->dev,
+                               "Failed to get reset GPIO: %d\n", ret);
+                       goto err;
+               }
+       }
+       if (cs35l41->reset_gpio) {
+               /* satisfy minimum reset pulse width spec */
+               usleep_range(2000, 2100);
+               gpiod_set_value_cansleep(cs35l41->reset_gpio, 1);
+       }
+
+       usleep_range(2000, 2100);
+
+       ret = regmap_read_poll_timeout(cs35l41->regmap, CS35L41_IRQ1_STATUS4,
+                                      int_status, int_status & CS35L41_OTP_BOOT_DONE,
+                                      1000, 100000);
+       if (ret) {
+               dev_err(cs35l41->dev,
+                       "Failed waiting for OTP_BOOT_DONE: %d\n", ret);
+               goto err;
+       }
+
+       regmap_read(cs35l41->regmap, CS35L41_IRQ1_STATUS3, &int_status);
+       if (int_status & CS35L41_OTP_BOOT_ERR) {
+               dev_err(cs35l41->dev, "OTP Boot error\n");
+               ret = -EINVAL;
+               goto err;
+       }
+
+       ret = regmap_read(cs35l41->regmap, CS35L41_DEVID, &regid);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Get Device ID failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = regmap_read(cs35l41->regmap, CS35L41_REVID, &reg_revid);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Get Revision ID failed: %d\n", ret);
+               goto err;
+       }
+
+       mtl_revid = reg_revid & CS35L41_MTLREVID_MASK;
+
+       /* CS35L41 will have even MTLREVID
+        * CS35L41R will have odd MTLREVID
+        */
+       chipid_match = (mtl_revid % 2) ? CS35L41R_CHIP_ID : CS35L41_CHIP_ID;
+       if (regid != chipid_match) {
+               dev_err(cs35l41->dev, "CS35L41 Device ID (%X). Expected ID %X\n",
+                       regid, chipid_match);
+               ret = -ENODEV;
+               goto err;
+       }
+
+       switch (reg_revid) {
+       case CS35L41_REVID_A0:
+               ret = regmap_register_patch(cs35l41->regmap,
+                                           cs35l41_reva0_errata_patch,
+                                           ARRAY_SIZE(cs35l41_reva0_errata_patch));
+               if (ret < 0) {
+                       dev_err(cs35l41->dev,
+                               "Failed to apply A0 errata patch: %d\n", ret);
+                       goto err;
+               }
+               break;
+       case CS35L41_REVID_B0:
+               ret = regmap_register_patch(cs35l41->regmap,
+                                           cs35l41_revb0_errata_patch,
+                                           ARRAY_SIZE(cs35l41_revb0_errata_patch));
+               if (ret < 0) {
+                       dev_err(cs35l41->dev,
+                               "Failed to apply B0 errata patch: %d\n", ret);
+                       goto err;
+               }
+               break;
+       case CS35L41_REVID_B2:
+               ret = regmap_register_patch(cs35l41->regmap,
+                                           cs35l41_revb2_errata_patch,
+                                           ARRAY_SIZE(cs35l41_revb2_errata_patch));
+               if (ret < 0) {
+                       dev_err(cs35l41->dev,
+                               "Failed to apply B2 errata patch: %d\n", ret);
+                       goto err;
+               }
+               break;
+       }
+
+       irq_pol = cs35l41_irq_gpio_config(cs35l41);
+
+       /* Set interrupt masks for critical errors */
+       regmap_write(cs35l41->regmap, CS35L41_IRQ1_MASK1,
+                    CS35L41_INT1_MASK_DEFAULT);
+
+       ret = devm_request_threaded_irq(cs35l41->dev, cs35l41->irq, NULL, cs35l41_irq,
+                                       IRQF_ONESHOT | IRQF_SHARED | irq_pol,
+                                       "cs35l41", cs35l41);
+
+       /* CS35L41 needs INT for PDN_DONE */
+       if (ret != 0) {
+               dev_err(cs35l41->dev, "Failed to request IRQ: %d\n", ret);
+               goto err;
+       }
+
+       ret = cs35l41_otp_unpack(cs35l41);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "OTP Unpack failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = regmap_write(cs35l41->regmap, CS35L41_DSP1_CCM_CORE_CTRL, 0);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write CCM_CORE_CTRL failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = regmap_update_bits(cs35l41->regmap, CS35L41_PWR_CTRL2,
+                                CS35L41_AMP_EN_MASK, 0);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write CS35L41_PWR_CTRL2 failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = regmap_update_bits(cs35l41->regmap, CS35L41_AMP_GAIN_CTRL,
+                                CS35L41_AMP_GAIN_PCM_MASK, 0);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Write CS35L41_AMP_GAIN_CTRL failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = cs35l41_set_pdata(cs35l41);
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Set pdata failed: %d\n", ret);
+               goto err;
+       }
+
+       ret = devm_snd_soc_register_component(cs35l41->dev,
+                                             &soc_component_dev_cs35l41,
+                                             cs35l41_dai, ARRAY_SIZE(cs35l41_dai));
+       if (ret < 0) {
+               dev_err(cs35l41->dev, "Register codec failed: %d\n", ret);
+               goto err;
+       }
+
+       dev_info(cs35l41->dev, "Cirrus Logic CS35L41 (%x), Revision: %02X\n",
+                regid, reg_revid);
+
+       return 0;
+
+err:
+       regulator_bulk_disable(CS35L41_NUM_SUPPLIES, cs35l41->supplies);
+       gpiod_set_value_cansleep(cs35l41->reset_gpio, 0);
+
+       return ret;
+}
+
+void cs35l41_remove(struct cs35l41_private *cs35l41)
+{
+       regmap_write(cs35l41->regmap, CS35L41_IRQ1_MASK1, 0xFFFFFFFF);
+       regulator_bulk_disable(CS35L41_NUM_SUPPLIES, cs35l41->supplies);
+       gpiod_set_value_cansleep(cs35l41->reset_gpio, 0);
+}
+
+MODULE_DESCRIPTION("ASoC CS35L41 driver");
+MODULE_AUTHOR("David Rhodes, Cirrus Logic Inc, <david.rhodes@cirrus.com>");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/codecs/cs35l41.h b/sound/soc/codecs/cs35l41.h
new file mode 100644 (file)
index 0000000..6cffe8a
--- /dev/null
@@ -0,0 +1,775 @@
+/* SPDX-License-Identifier: GPL-2.0
+ *
+ * cs35l41.h -- CS35L41 ALSA SoC audio driver
+ *
+ * Copyright 2017-2021 Cirrus Logic, Inc.
+ *
+ * Author: David Rhodes <david.rhodes@cirrus.com>
+ */
+
+#ifndef __CS35L41_H__
+#define __CS35L41_H__
+
+#include <linux/gpio/consumer.h>
+#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
+#include <sound/core.h>
+#include <sound/cs35l41.h>
+
+#define CS35L41_FIRSTREG               0x00000000
+#define CS35L41_LASTREG                        0x03804FE8
+#define CS35L41_DEVID                  0x00000000
+#define CS35L41_REVID                  0x00000004
+#define CS35L41_FABID                  0x00000008
+#define CS35L41_RELID                  0x0000000C
+#define CS35L41_OTPID                  0x00000010
+#define CS35L41_SFT_RESET              0x00000020
+#define CS35L41_TEST_KEY_CTL           0x00000040
+#define CS35L41_USER_KEY_CTL           0x00000044
+#define CS35L41_OTP_MEM0               0x00000400
+#define CS35L41_OTP_MEM31              0x0000047C
+#define CS35L41_OTP_CTRL0              0x00000500
+#define CS35L41_OTP_CTRL1              0x00000504
+#define CS35L41_OTP_CTRL3              0x00000508
+#define CS35L41_OTP_CTRL4              0x0000050C
+#define CS35L41_OTP_CTRL5              0x00000510
+#define CS35L41_OTP_CTRL6              0x00000514
+#define CS35L41_OTP_CTRL7              0x00000518
+#define CS35L41_OTP_CTRL8              0x0000051C
+#define CS35L41_PWR_CTRL1              0x00002014
+#define CS35L41_PWR_CTRL2              0x00002018
+#define CS35L41_PWR_CTRL3              0x0000201C
+#define CS35L41_CTRL_OVRRIDE           0x00002020
+#define CS35L41_AMP_OUT_MUTE           0x00002024
+#define CS35L41_PROTECT_REL_ERR_IGN    0x00002034
+#define CS35L41_GPIO_PAD_CONTROL       0x0000242C
+#define CS35L41_JTAG_CONTROL           0x00002438
+#define CS35L41_PLL_CLK_CTRL           0x00002C04
+#define CS35L41_DSP_CLK_CTRL           0x00002C08
+#define CS35L41_GLOBAL_CLK_CTRL                0x00002C0C
+#define CS35L41_DATA_FS_SEL            0x00002C10
+#define CS35L41_TST_FS_MON0            0x00002D10
+#define CS35L41_MDSYNC_EN              0x00003400
+#define CS35L41_MDSYNC_TX_ID           0x00003408
+#define CS35L41_MDSYNC_PWR_CTRL                0x0000340C
+#define CS35L41_MDSYNC_DATA_TX         0x00003410
+#define CS35L41_MDSYNC_TX_STATUS       0x00003414
+#define CS35L41_MDSYNC_DATA_RX         0x0000341C
+#define CS35L41_MDSYNC_RX_STATUS       0x00003420
+#define CS35L41_MDSYNC_ERR_STATUS      0x00003424
+#define CS35L41_MDSYNC_SYNC_PTE2       0x00003528
+#define CS35L41_MDSYNC_SYNC_PTE3       0x0000352C
+#define CS35L41_MDSYNC_SYNC_MSM_STATUS 0x0000353C
+#define CS35L41_BSTCVRT_VCTRL1         0x00003800
+#define CS35L41_BSTCVRT_VCTRL2         0x00003804
+#define CS35L41_BSTCVRT_PEAK_CUR       0x00003808
+#define CS35L41_BSTCVRT_SFT_RAMP       0x0000380C
+#define CS35L41_BSTCVRT_COEFF          0x00003810
+#define CS35L41_BSTCVRT_SLOPE_LBST     0x00003814
+#define CS35L41_BSTCVRT_SW_FREQ                0x00003818
+#define CS35L41_BSTCVRT_DCM_CTRL       0x0000381C
+#define CS35L41_BSTCVRT_DCM_MODE_FORCE 0x00003820
+#define CS35L41_BSTCVRT_OVERVOLT_CTRL  0x00003830
+#define CS35L41_VI_VOL_POL             0x00004000
+#define CS35L41_VIMON_SPKMON_RESYNC    0x00004100
+#define CS35L41_DTEMP_WARN_THLD                0x00004220
+#define CS35L41_DTEMP_CFG              0x00004224
+#define CS35L41_DTEMP_EN               0x00004308
+#define CS35L41_VPVBST_FS_SEL          0x00004400
+#define CS35L41_SP_ENABLES             0x00004800
+#define CS35L41_SP_RATE_CTRL           0x00004804
+#define CS35L41_SP_FORMAT              0x00004808
+#define CS35L41_SP_HIZ_CTRL            0x0000480C
+#define CS35L41_SP_FRAME_TX_SLOT       0x00004810
+#define CS35L41_SP_FRAME_RX_SLOT       0x00004820
+#define CS35L41_SP_TX_WL               0x00004830
+#define CS35L41_SP_RX_WL               0x00004840
+#define CS35L41_ASP_CONTROL4           0x00004854
+#define CS35L41_DAC_PCM1_SRC           0x00004C00
+#define CS35L41_ASP_TX1_SRC            0x00004C20
+#define CS35L41_ASP_TX2_SRC            0x00004C24
+#define CS35L41_ASP_TX3_SRC            0x00004C28
+#define CS35L41_ASP_TX4_SRC            0x00004C2C
+#define CS35L41_DSP1_RX1_SRC           0x00004C40
+#define CS35L41_DSP1_RX2_SRC           0x00004C44
+#define CS35L41_DSP1_RX3_SRC           0x00004C48
+#define CS35L41_DSP1_RX4_SRC           0x00004C4C
+#define CS35L41_DSP1_RX5_SRC           0x00004C50
+#define CS35L41_DSP1_RX6_SRC           0x00004C54
+#define CS35L41_DSP1_RX7_SRC           0x00004C58
+#define CS35L41_DSP1_RX8_SRC           0x00004C5C
+#define CS35L41_NGATE1_SRC             0x00004C60
+#define CS35L41_NGATE2_SRC             0x00004C64
+#define CS35L41_AMP_DIG_VOL_CTRL       0x00006000
+#define CS35L41_VPBR_CFG               0x00006404
+#define CS35L41_VBBR_CFG               0x00006408
+#define CS35L41_VPBR_STATUS            0x0000640C
+#define CS35L41_VBBR_STATUS            0x00006410
+#define CS35L41_OVERTEMP_CFG           0x00006414
+#define CS35L41_AMP_ERR_VOL            0x00006418
+#define CS35L41_VOL_STATUS_TO_DSP      0x00006450
+#define CS35L41_CLASSH_CFG             0x00006800
+#define CS35L41_WKFET_CFG              0x00006804
+#define CS35L41_NG_CFG                 0x00006808
+#define CS35L41_AMP_GAIN_CTRL          0x00006C04
+#define CS35L41_DAC_MSM_CFG            0x00007400
+#define CS35L41_IRQ1_CFG               0x00010000
+#define CS35L41_IRQ1_STATUS            0x00010004
+#define CS35L41_IRQ1_STATUS1           0x00010010
+#define CS35L41_IRQ1_STATUS2           0x00010014
+#define CS35L41_IRQ1_STATUS3           0x00010018
+#define CS35L41_IRQ1_STATUS4           0x0001001C
+#define CS35L41_IRQ1_RAW_STATUS1       0x00010090
+#define CS35L41_IRQ1_RAW_STATUS2       0x00010094
+#define CS35L41_IRQ1_RAW_STATUS3       0x00010098
+#define CS35L41_IRQ1_RAW_STATUS4       0x0001009C
+#define CS35L41_IRQ1_MASK1             0x00010110
+#define CS35L41_IRQ1_MASK2             0x00010114
+#define CS35L41_IRQ1_MASK3             0x00010118
+#define CS35L41_IRQ1_MASK4             0x0001011C
+#define CS35L41_IRQ1_FRC1              0x00010190
+#define CS35L41_IRQ1_FRC2              0x00010194
+#define CS35L41_IRQ1_FRC3              0x00010198
+#define CS35L41_IRQ1_FRC4              0x0001019C
+#define CS35L41_IRQ1_EDGE1             0x00010210
+#define CS35L41_IRQ1_EDGE4             0x0001021C
+#define CS35L41_IRQ1_POL1              0x00010290
+#define CS35L41_IRQ1_POL2              0x00010294
+#define CS35L41_IRQ1_POL3              0x00010298
+#define CS35L41_IRQ1_POL4              0x0001029C
+#define CS35L41_IRQ1_DB3               0x00010318
+#define CS35L41_IRQ2_CFG               0x00010800
+#define CS35L41_IRQ2_STATUS            0x00010804
+#define CS35L41_IRQ2_STATUS1           0x00010810
+#define CS35L41_IRQ2_STATUS2           0x00010814
+#define CS35L41_IRQ2_STATUS3           0x00010818
+#define CS35L41_IRQ2_STATUS4           0x0001081C
+#define CS35L41_IRQ2_RAW_STATUS1       0x00010890
+#define CS35L41_IRQ2_RAW_STATUS2       0x00010894
+#define CS35L41_IRQ2_RAW_STATUS3       0x00010898
+#define CS35L41_IRQ2_RAW_STATUS4       0x0001089C
+#define CS35L41_IRQ2_MASK1             0x00010910
+#define CS35L41_IRQ2_MASK2             0x00010914
+#define CS35L41_IRQ2_MASK3             0x00010918
+#define CS35L41_IRQ2_MASK4             0x0001091C
+#define CS35L41_IRQ2_FRC1              0x00010990
+#define CS35L41_IRQ2_FRC2              0x00010994
+#define CS35L41_IRQ2_FRC3              0x00010998
+#define CS35L41_IRQ2_FRC4              0x0001099C
+#define CS35L41_IRQ2_EDGE1             0x00010A10
+#define CS35L41_IRQ2_EDGE4             0x00010A1C
+#define CS35L41_IRQ2_POL1              0x00010A90
+#define CS35L41_IRQ2_POL2              0x00010A94
+#define CS35L41_IRQ2_POL3              0x00010A98
+#define CS35L41_IRQ2_POL4              0x00010A9C
+#define CS35L41_IRQ2_DB3               0x00010B18
+#define CS35L41_GPIO_STATUS1           0x00011000
+#define CS35L41_GPIO1_CTRL1            0x00011008
+#define CS35L41_GPIO2_CTRL1            0x0001100C
+#define CS35L41_MIXER_NGATE_CFG                0x00012000
+#define CS35L41_MIXER_NGATE_CH1_CFG    0x00012004
+#define CS35L41_MIXER_NGATE_CH2_CFG    0x00012008
+#define CS35L41_DSP_MBOX_1             0x00013000
+#define CS35L41_DSP_MBOX_2             0x00013004
+#define CS35L41_DSP_MBOX_3             0x00013008
+#define CS35L41_DSP_MBOX_4             0x0001300C
+#define CS35L41_DSP_MBOX_5             0x00013010
+#define CS35L41_DSP_MBOX_6             0x00013014
+#define CS35L41_DSP_MBOX_7             0x00013018
+#define CS35L41_DSP_MBOX_8             0x0001301C
+#define CS35L41_DSP_VIRT1_MBOX_1       0x00013020
+#define CS35L41_DSP_VIRT1_MBOX_2       0x00013024
+#define CS35L41_DSP_VIRT1_MBOX_3       0x00013028
+#define CS35L41_DSP_VIRT1_MBOX_4       0x0001302C
+#define CS35L41_DSP_VIRT1_MBOX_5       0x00013030
+#define CS35L41_DSP_VIRT1_MBOX_6       0x00013034
+#define CS35L41_DSP_VIRT1_MBOX_7       0x00013038
+#define CS35L41_DSP_VIRT1_MBOX_8       0x0001303C
+#define CS35L41_DSP_VIRT2_MBOX_1       0x00013040
+#define CS35L41_DSP_VIRT2_MBOX_2       0x00013044
+#define CS35L41_DSP_VIRT2_MBOX_3       0x00013048
+#define CS35L41_DSP_VIRT2_MBOX_4       0x0001304C
+#define CS35L41_DSP_VIRT2_MBOX_5       0x00013050
+#define CS35L41_DSP_VIRT2_MBOX_6       0x00013054
+#define CS35L41_DSP_VIRT2_MBOX_7       0x00013058
+#define CS35L41_DSP_VIRT2_MBOX_8       0x0001305C
+#define CS35L41_CLOCK_DETECT_1         0x00014000
+#define CS35L41_TIMER1_CONTROL         0x00015000
+#define CS35L41_TIMER1_COUNT_PRESET    0x00015004
+#define CS35L41_TIMER1_START_STOP      0x0001500C
+#define CS35L41_TIMER1_STATUS          0x00015010
+#define CS35L41_TIMER1_COUNT_READBACK  0x00015014
+#define CS35L41_TIMER1_DSP_CLK_CFG     0x00015018
+#define CS35L41_TIMER1_DSP_CLK_STATUS  0x0001501C
+#define CS35L41_TIMER2_CONTROL         0x00015100
+#define CS35L41_TIMER2_COUNT_PRESET    0x00015104
+#define CS35L41_TIMER2_START_STOP      0x0001510C
+#define CS35L41_TIMER2_STATUS          0x00015110
+#define CS35L41_TIMER2_COUNT_READBACK  0x00015114
+#define CS35L41_TIMER2_DSP_CLK_CFG     0x00015118
+#define CS35L41_TIMER2_DSP_CLK_STATUS  0x0001511C
+#define CS35L41_DFT_JTAG_CONTROL       0x00016000
+#define CS35L41_DIE_STS1               0x00017040
+#define CS35L41_DIE_STS2               0x00017044
+#define CS35L41_TEMP_CAL1              0x00017048
+#define CS35L41_TEMP_CAL2              0x0001704C
+#define CS35L41_DSP1_XMEM_PACK_0       0x02000000
+#define CS35L41_DSP1_XMEM_PACK_3068    0x02002FF0
+#define CS35L41_DSP1_XMEM_UNPACK32_0   0x02400000
+#define CS35L41_DSP1_XMEM_UNPACK32_2046        0x02401FF8
+#define CS35L41_DSP1_TIMESTAMP_COUNT   0x025C0800
+#define CS35L41_DSP1_SYS_ID            0x025E0000
+#define CS35L41_DSP1_SYS_VERSION       0x025E0004
+#define CS35L41_DSP1_SYS_CORE_ID       0x025E0008
+#define CS35L41_DSP1_SYS_AHB_ADDR      0x025E000C
+#define CS35L41_DSP1_SYS_XSRAM_SIZE    0x025E0010
+#define CS35L41_DSP1_SYS_YSRAM_SIZE    0x025E0018
+#define CS35L41_DSP1_SYS_PSRAM_SIZE    0x025E0020
+#define CS35L41_DSP1_SYS_PM_BOOT_SIZE  0x025E0028
+#define CS35L41_DSP1_SYS_FEATURES      0x025E002C
+#define CS35L41_DSP1_SYS_FIR_FILTERS   0x025E0030
+#define CS35L41_DSP1_SYS_LMS_FILTERS   0x025E0034
+#define CS35L41_DSP1_SYS_XM_BANK_SIZE  0x025E0038
+#define CS35L41_DSP1_SYS_YM_BANK_SIZE  0x025E003C
+#define CS35L41_DSP1_SYS_PM_BANK_SIZE  0x025E0040
+#define CS35L41_DSP1_AHBM_WIN0_CTRL0   0x025E2000
+#define CS35L41_DSP1_AHBM_WIN0_CTRL1   0x025E2004
+#define CS35L41_DSP1_AHBM_WIN1_CTRL0   0x025E2008
+#define CS35L41_DSP1_AHBM_WIN1_CTRL1   0x025E200C
+#define CS35L41_DSP1_AHBM_WIN2_CTRL0   0x025E2010
+#define CS35L41_DSP1_AHBM_WIN2_CTRL1   0x025E2014
+#define CS35L41_DSP1_AHBM_WIN3_CTRL0   0x025E2018
+#define CS35L41_DSP1_AHBM_WIN3_CTRL1   0x025E201C
+#define CS35L41_DSP1_AHBM_WIN4_CTRL0   0x025E2020
+#define CS35L41_DSP1_AHBM_WIN4_CTRL1   0x025E2024
+#define CS35L41_DSP1_AHBM_WIN5_CTRL0   0x025E2028
+#define CS35L41_DSP1_AHBM_WIN5_CTRL1   0x025E202C
+#define CS35L41_DSP1_AHBM_WIN6_CTRL0   0x025E2030
+#define CS35L41_DSP1_AHBM_WIN6_CTRL1   0x025E2034
+#define CS35L41_DSP1_AHBM_WIN7_CTRL0   0x025E2038
+#define CS35L41_DSP1_AHBM_WIN7_CTRL1   0x025E203C
+#define CS35L41_DSP1_AHBM_WIN_DBG_CTRL0        0x025E2040
+#define CS35L41_DSP1_AHBM_WIN_DBG_CTRL1        0x025E2044
+#define CS35L41_DSP1_XMEM_UNPACK24_0   0x02800000
+#define CS35L41_DSP1_XMEM_UNPACK24_4093        0x02803FF4
+#define CS35L41_DSP1_CTRL_BASE         0x02B80000
+#define CS35L41_DSP1_CORE_SOFT_RESET   0x02B80010
+#define CS35L41_DSP1_DEBUG             0x02B80040
+#define CS35L41_DSP1_TIMER_CTRL                0x02B80048
+#define CS35L41_DSP1_STREAM_ARB_CTRL   0x02B80050
+#define CS35L41_DSP1_RX1_RATE          0x02B80080
+#define CS35L41_DSP1_RX2_RATE          0x02B80088
+#define CS35L41_DSP1_RX3_RATE          0x02B80090
+#define CS35L41_DSP1_RX4_RATE          0x02B80098
+#define CS35L41_DSP1_RX5_RATE          0x02B800A0
+#define CS35L41_DSP1_RX6_RATE          0x02B800A8
+#define CS35L41_DSP1_RX7_RATE          0x02B800B0
+#define CS35L41_DSP1_RX8_RATE          0x02B800B8
+#define CS35L41_DSP1_TX1_RATE          0x02B80280
+#define CS35L41_DSP1_TX2_RATE          0x02B80288
+#define CS35L41_DSP1_TX3_RATE          0x02B80290
+#define CS35L41_DSP1_TX4_RATE          0x02B80298
+#define CS35L41_DSP1_TX5_RATE          0x02B802A0
+#define CS35L41_DSP1_TX6_RATE          0x02B802A8
+#define CS35L41_DSP1_TX7_RATE          0x02B802B0
+#define CS35L41_DSP1_TX8_RATE          0x02B802B8
+#define CS35L41_DSP1_NMI_CTRL1         0x02B80480
+#define CS35L41_DSP1_NMI_CTRL2         0x02B80488
+#define CS35L41_DSP1_NMI_CTRL3         0x02B80490
+#define CS35L41_DSP1_NMI_CTRL4         0x02B80498
+#define CS35L41_DSP1_NMI_CTRL5         0x02B804A0
+#define CS35L41_DSP1_NMI_CTRL6         0x02B804A8
+#define CS35L41_DSP1_NMI_CTRL7         0x02B804B0
+#define CS35L41_DSP1_NMI_CTRL8         0x02B804B8
+#define CS35L41_DSP1_RESUME_CTRL       0x02B80500
+#define CS35L41_DSP1_IRQ1_CTRL         0x02B80508
+#define CS35L41_DSP1_IRQ2_CTRL         0x02B80510
+#define CS35L41_DSP1_IRQ3_CTRL         0x02B80518
+#define CS35L41_DSP1_IRQ4_CTRL         0x02B80520
+#define CS35L41_DSP1_IRQ5_CTRL         0x02B80528
+#define CS35L41_DSP1_IRQ6_CTRL         0x02B80530
+#define CS35L41_DSP1_IRQ7_CTRL         0x02B80538
+#define CS35L41_DSP1_IRQ8_CTRL         0x02B80540
+#define CS35L41_DSP1_IRQ9_CTRL         0x02B80548
+#define CS35L41_DSP1_IRQ10_CTRL                0x02B80550
+#define CS35L41_DSP1_IRQ11_CTRL                0x02B80558
+#define CS35L41_DSP1_IRQ12_CTRL                0x02B80560
+#define CS35L41_DSP1_IRQ13_CTRL                0x02B80568
+#define CS35L41_DSP1_IRQ14_CTRL                0x02B80570
+#define CS35L41_DSP1_IRQ15_CTRL                0x02B80578
+#define CS35L41_DSP1_IRQ16_CTRL                0x02B80580
+#define CS35L41_DSP1_IRQ17_CTRL                0x02B80588
+#define CS35L41_DSP1_IRQ18_CTRL                0x02B80590
+#define CS35L41_DSP1_IRQ19_CTRL                0x02B80598
+#define CS35L41_DSP1_IRQ20_CTRL                0x02B805A0
+#define CS35L41_DSP1_IRQ21_CTRL                0x02B805A8
+#define CS35L41_DSP1_IRQ22_CTRL                0x02B805B0
+#define CS35L41_DSP1_IRQ23_CTRL                0x02B805B8
+#define CS35L41_DSP1_SCRATCH1          0x02B805C0
+#define CS35L41_DSP1_SCRATCH2          0x02B805C8
+#define CS35L41_DSP1_SCRATCH3          0x02B805D0
+#define CS35L41_DSP1_SCRATCH4          0x02B805D8
+#define CS35L41_DSP1_CCM_CORE_CTRL     0x02BC1000
+#define CS35L41_DSP1_CCM_CLK_OVERRIDE  0x02BC1008
+#define CS35L41_DSP1_XM_MSTR_EN                0x02BC2000
+#define CS35L41_DSP1_XM_CORE_PRI       0x02BC2008
+#define CS35L41_DSP1_XM_AHB_PACK_PL_PRI        0x02BC2010
+#define CS35L41_DSP1_XM_AHB_UP_PL_PRI  0x02BC2018
+#define CS35L41_DSP1_XM_ACCEL_PL0_PRI  0x02BC2020
+#define CS35L41_DSP1_XM_NPL0_PRI       0x02BC2078
+#define CS35L41_DSP1_YM_MSTR_EN                0x02BC20C0
+#define CS35L41_DSP1_YM_CORE_PRI       0x02BC20C8
+#define CS35L41_DSP1_YM_AHB_PACK_PL_PRI        0x02BC20D0
+#define CS35L41_DSP1_YM_AHB_UP_PL_PRI  0x02BC20D8
+#define CS35L41_DSP1_YM_ACCEL_PL0_PRI  0x02BC20E0
+#define CS35L41_DSP1_YM_NPL0_PRI       0x02BC2138
+#define CS35L41_DSP1_PM_MSTR_EN                0x02BC2180
+#define CS35L41_DSP1_PM_PATCH0_ADDR    0x02BC2188
+#define CS35L41_DSP1_PM_PATCH0_EN      0x02BC218C
+#define CS35L41_DSP1_PM_PATCH0_DATA_LO 0x02BC2190
+#define CS35L41_DSP1_PM_PATCH0_DATA_HI 0x02BC2194
+#define CS35L41_DSP1_PM_PATCH1_ADDR    0x02BC2198
+#define CS35L41_DSP1_PM_PATCH1_EN      0x02BC219C
+#define CS35L41_DSP1_PM_PATCH1_DATA_LO 0x02BC21A0
+#define CS35L41_DSP1_PM_PATCH1_DATA_HI 0x02BC21A4
+#define CS35L41_DSP1_PM_PATCH2_ADDR    0x02BC21A8
+#define CS35L41_DSP1_PM_PATCH2_EN      0x02BC21AC
+#define CS35L41_DSP1_PM_PATCH2_DATA_LO 0x02BC21B0
+#define CS35L41_DSP1_PM_PATCH2_DATA_HI 0x02BC21B4
+#define CS35L41_DSP1_PM_PATCH3_ADDR    0x02BC21B8
+#define CS35L41_DSP1_PM_PATCH3_EN      0x02BC21BC
+#define CS35L41_DSP1_PM_PATCH3_DATA_LO 0x02BC21C0
+#define CS35L41_DSP1_PM_PATCH3_DATA_HI 0x02BC21C4
+#define CS35L41_DSP1_PM_PATCH4_ADDR    0x02BC21C8
+#define CS35L41_DSP1_PM_PATCH4_EN      0x02BC21CC
+#define CS35L41_DSP1_PM_PATCH4_DATA_LO 0x02BC21D0
+#define CS35L41_DSP1_PM_PATCH4_DATA_HI 0x02BC21D4
+#define CS35L41_DSP1_PM_PATCH5_ADDR    0x02BC21D8
+#define CS35L41_DSP1_PM_PATCH5_EN      0x02BC21DC
+#define CS35L41_DSP1_PM_PATCH5_DATA_LO 0x02BC21E0
+#define CS35L41_DSP1_PM_PATCH5_DATA_HI 0x02BC21E4
+#define CS35L41_DSP1_PM_PATCH6_ADDR    0x02BC21E8
+#define CS35L41_DSP1_PM_PATCH6_EN      0x02BC21EC
+#define CS35L41_DSP1_PM_PATCH6_DATA_LO 0x02BC21F0
+#define CS35L41_DSP1_PM_PATCH6_DATA_HI 0x02BC21F4
+#define CS35L41_DSP1_PM_PATCH7_ADDR    0x02BC21F8
+#define CS35L41_DSP1_PM_PATCH7_EN      0x02BC21FC
+#define CS35L41_DSP1_PM_PATCH7_DATA_LO 0x02BC2200
+#define CS35L41_DSP1_PM_PATCH7_DATA_HI 0x02BC2204
+#define CS35L41_DSP1_MPU_XM_ACCESS0    0x02BC3000
+#define CS35L41_DSP1_MPU_YM_ACCESS0    0x02BC3004
+#define CS35L41_DSP1_MPU_WNDW_ACCESS0  0x02BC3008
+#define CS35L41_DSP1_MPU_XREG_ACCESS0  0x02BC300C
+#define CS35L41_DSP1_MPU_YREG_ACCESS0  0x02BC3014
+#define CS35L41_DSP1_MPU_XM_ACCESS1    0x02BC3018
+#define CS35L41_DSP1_MPU_YM_ACCESS1    0x02BC301C
+#define CS35L41_DSP1_MPU_WNDW_ACCESS1  0x02BC3020
+#define CS35L41_DSP1_MPU_XREG_ACCESS1  0x02BC3024
+#define CS35L41_DSP1_MPU_YREG_ACCESS1  0x02BC302C
+#define CS35L41_DSP1_MPU_XM_ACCESS2    0x02BC3030
+#define CS35L41_DSP1_MPU_YM_ACCESS2    0x02BC3034
+#define CS35L41_DSP1_MPU_WNDW_ACCESS2  0x02BC3038
+#define CS35L41_DSP1_MPU_XREG_ACCESS2  0x02BC303C
+#define CS35L41_DSP1_MPU_YREG_ACCESS2  0x02BC3044
+#define CS35L41_DSP1_MPU_XM_ACCESS3    0x02BC3048
+#define CS35L41_DSP1_MPU_YM_ACCESS3    0x02BC304C
+#define CS35L41_DSP1_MPU_WNDW_ACCESS3  0x02BC3050
+#define CS35L41_DSP1_MPU_XREG_ACCESS3  0x02BC3054
+#define CS35L41_DSP1_MPU_YREG_ACCESS3  0x02BC305C
+#define CS35L41_DSP1_MPU_XM_VIO_ADDR   0x02BC3100
+#define CS35L41_DSP1_MPU_XM_VIO_STATUS 0x02BC3104
+#define CS35L41_DSP1_MPU_YM_VIO_ADDR   0x02BC3108
+#define CS35L41_DSP1_MPU_YM_VIO_STATUS 0x02BC310C
+#define CS35L41_DSP1_MPU_PM_VIO_ADDR   0x02BC3110
+#define CS35L41_DSP1_MPU_PM_VIO_STATUS 0x02BC3114
+#define CS35L41_DSP1_MPU_LOCK_CONFIG   0x02BC3140
+#define CS35L41_DSP1_MPU_WDT_RST_CTRL  0x02BC3180
+#define CS35L41_DSP1_STRMARB_MSTR0_CFG0        0x02BC5000
+#define CS35L41_DSP1_STRMARB_MSTR0_CFG1        0x02BC5004
+#define CS35L41_DSP1_STRMARB_MSTR0_CFG2        0x02BC5008
+#define CS35L41_DSP1_STRMARB_MSTR1_CFG0        0x02BC5010
+#define CS35L41_DSP1_STRMARB_MSTR1_CFG1        0x02BC5014
+#define CS35L41_DSP1_STRMARB_MSTR1_CFG2        0x02BC5018
+#define CS35L41_DSP1_STRMARB_MSTR2_CFG0        0x02BC5020
+#define CS35L41_DSP1_STRMARB_MSTR2_CFG1        0x02BC5024
+#define CS35L41_DSP1_STRMARB_MSTR2_CFG2        0x02BC5028
+#define CS35L41_DSP1_STRMARB_MSTR3_CFG0        0x02BC5030
+#define CS35L41_DSP1_STRMARB_MSTR3_CFG1        0x02BC5034
+#define CS35L41_DSP1_STRMARB_MSTR3_CFG2        0x02BC5038
+#define CS35L41_DSP1_STRMARB_MSTR4_CFG0        0x02BC5040
+#define CS35L41_DSP1_STRMARB_MSTR4_CFG1        0x02BC5044
+#define CS35L41_DSP1_STRMARB_MSTR4_CFG2        0x02BC5048
+#define CS35L41_DSP1_STRMARB_MSTR5_CFG0        0x02BC5050
+#define CS35L41_DSP1_STRMARB_MSTR5_CFG1        0x02BC5054
+#define CS35L41_DSP1_STRMARB_MSTR5_CFG2        0x02BC5058
+#define CS35L41_DSP1_STRMARB_MSTR6_CFG0        0x02BC5060
+#define CS35L41_DSP1_STRMARB_MSTR6_CFG1        0x02BC5064
+#define CS35L41_DSP1_STRMARB_MSTR6_CFG2        0x02BC5068
+#define CS35L41_DSP1_STRMARB_MSTR7_CFG0        0x02BC5070
+#define CS35L41_DSP1_STRMARB_MSTR7_CFG1        0x02BC5074
+#define CS35L41_DSP1_STRMARB_MSTR7_CFG2        0x02BC5078
+#define CS35L41_DSP1_STRMARB_TX0_CFG0  0x02BC5200
+#define CS35L41_DSP1_STRMARB_TX0_CFG1  0x02BC5204
+#define CS35L41_DSP1_STRMARB_TX1_CFG0  0x02BC5208
+#define CS35L41_DSP1_STRMARB_TX1_CFG1  0x02BC520C
+#define CS35L41_DSP1_STRMARB_TX2_CFG0  0x02BC5210
+#define CS35L41_DSP1_STRMARB_TX2_CFG1  0x02BC5214
+#define CS35L41_DSP1_STRMARB_TX3_CFG0  0x02BC5218
+#define CS35L41_DSP1_STRMARB_TX3_CFG1  0x02BC521C
+#define CS35L41_DSP1_STRMARB_TX4_CFG0  0x02BC5220
+#define CS35L41_DSP1_STRMARB_TX4_CFG1  0x02BC5224
+#define CS35L41_DSP1_STRMARB_TX5_CFG0  0x02BC5228
+#define CS35L41_DSP1_STRMARB_TX5_CFG1  0x02BC522C
+#define CS35L41_DSP1_STRMARB_TX6_CFG0  0x02BC5230
+#define CS35L41_DSP1_STRMARB_TX6_CFG1  0x02BC5234
+#define CS35L41_DSP1_STRMARB_TX7_CFG0  0x02BC5238
+#define CS35L41_DSP1_STRMARB_TX7_CFG1  0x02BC523C
+#define CS35L41_DSP1_STRMARB_RX0_CFG0  0x02BC5400
+#define CS35L41_DSP1_STRMARB_RX0_CFG1  0x02BC5404
+#define CS35L41_DSP1_STRMARB_RX1_CFG0  0x02BC5408
+#define CS35L41_DSP1_STRMARB_RX1_CFG1  0x02BC540C
+#define CS35L41_DSP1_STRMARB_RX2_CFG0  0x02BC5410
+#define CS35L41_DSP1_STRMARB_RX2_CFG1  0x02BC5414
+#define CS35L41_DSP1_STRMARB_RX3_CFG0  0x02BC5418
+#define CS35L41_DSP1_STRMARB_RX3_CFG1  0x02BC541C
+#define CS35L41_DSP1_STRMARB_RX4_CFG0  0x02BC5420
+#define CS35L41_DSP1_STRMARB_RX4_CFG1  0x02BC5424
+#define CS35L41_DSP1_STRMARB_RX5_CFG0  0x02BC5428
+#define CS35L41_DSP1_STRMARB_RX5_CFG1  0x02BC542C
+#define CS35L41_DSP1_STRMARB_RX6_CFG0  0x02BC5430
+#define CS35L41_DSP1_STRMARB_RX6_CFG1  0x02BC5434
+#define CS35L41_DSP1_STRMARB_RX7_CFG0  0x02BC5438
+#define CS35L41_DSP1_STRMARB_RX7_CFG1  0x02BC543C
+#define CS35L41_DSP1_STRMARB_IRQ0_CFG0 0x02BC5600
+#define CS35L41_DSP1_STRMARB_IRQ0_CFG1 0x02BC5604
+#define CS35L41_DSP1_STRMARB_IRQ0_CFG2 0x02BC5608
+#define CS35L41_DSP1_STRMARB_IRQ1_CFG0 0x02BC5610
+#define CS35L41_DSP1_STRMARB_IRQ1_CFG1 0x02BC5614
+#define CS35L41_DSP1_STRMARB_IRQ1_CFG2 0x02BC5618
+#define CS35L41_DSP1_STRMARB_IRQ2_CFG0 0x02BC5620
+#define CS35L41_DSP1_STRMARB_IRQ2_CFG1 0x02BC5624
+#define CS35L41_DSP1_STRMARB_IRQ2_CFG2 0x02BC5628
+#define CS35L41_DSP1_STRMARB_IRQ3_CFG0 0x02BC5630
+#define CS35L41_DSP1_STRMARB_IRQ3_CFG1 0x02BC5634
+#define CS35L41_DSP1_STRMARB_IRQ3_CFG2 0x02BC5638
+#define CS35L41_DSP1_STRMARB_IRQ4_CFG0 0x02BC5640
+#define CS35L41_DSP1_STRMARB_IRQ4_CFG1 0x02BC5644
+#define CS35L41_DSP1_STRMARB_IRQ4_CFG2 0x02BC5648
+#define CS35L41_DSP1_STRMARB_IRQ5_CFG0 0x02BC5650
+#define CS35L41_DSP1_STRMARB_IRQ5_CFG1 0x02BC5654
+#define CS35L41_DSP1_STRMARB_IRQ5_CFG2 0x02BC5658
+#define CS35L41_DSP1_STRMARB_IRQ6_CFG0 0x02BC5660
+#define CS35L41_DSP1_STRMARB_IRQ6_CFG1 0x02BC5664
+#define CS35L41_DSP1_STRMARB_IRQ6_CFG2 0x02BC5668
+#define CS35L41_DSP1_STRMARB_IRQ7_CFG0 0x02BC5670
+#define CS35L41_DSP1_STRMARB_IRQ7_CFG1 0x02BC5674
+#define CS35L41_DSP1_STRMARB_IRQ7_CFG2 0x02BC5678
+#define CS35L41_DSP1_STRMARB_RESYNC_MSK        0x02BC5A00
+#define CS35L41_DSP1_STRMARB_ERR_STATUS        0x02BC5A08
+#define CS35L41_DSP1_INTPCTL_RES_STATIC        0x02BC6000
+#define CS35L41_DSP1_INTPCTL_RES_DYN   0x02BC6004
+#define CS35L41_DSP1_INTPCTL_NMI_CTRL  0x02BC6008
+#define CS35L41_DSP1_INTPCTL_IRQ_INV   0x02BC6010
+#define CS35L41_DSP1_INTPCTL_IRQ_MODE  0x02BC6014
+#define CS35L41_DSP1_INTPCTL_IRQ_EN    0x02BC6018
+#define CS35L41_DSP1_INTPCTL_IRQ_MSK   0x02BC601C
+#define CS35L41_DSP1_INTPCTL_IRQ_FLUSH 0x02BC6020
+#define CS35L41_DSP1_INTPCTL_IRQ_MSKCLR        0x02BC6024
+#define CS35L41_DSP1_INTPCTL_IRQ_FRC   0x02BC6028
+#define CS35L41_DSP1_INTPCTL_IRQ_MSKSET        0x02BC602C
+#define CS35L41_DSP1_INTPCTL_IRQ_ERR   0x02BC6030
+#define CS35L41_DSP1_INTPCTL_IRQ_PEND  0x02BC6034
+#define CS35L41_DSP1_INTPCTL_IRQ_GEN   0x02BC6038
+#define CS35L41_DSP1_INTPCTL_TESTBITS  0x02BC6040
+#define CS35L41_DSP1_WDT_CONTROL       0x02BC7000
+#define CS35L41_DSP1_WDT_STATUS                0x02BC7008
+#define CS35L41_DSP1_YMEM_PACK_0       0x02C00000
+#define CS35L41_DSP1_YMEM_PACK_1532    0x02C017F0
+#define CS35L41_DSP1_YMEM_UNPACK32_0   0x03000000
+#define CS35L41_DSP1_YMEM_UNPACK32_1022        0x03000FF8
+#define CS35L41_DSP1_YMEM_UNPACK24_0   0x03400000
+#define CS35L41_DSP1_YMEM_UNPACK24_2045        0x03401FF4
+#define CS35L41_DSP1_PMEM_0            0x03800000
+#define CS35L41_DSP1_PMEM_5114         0x03804FE8
+
+/*test regs for emulation bringup*/
+#define CS35L41_PLL_OVR                        0x00003018
+#define CS35L41_BST_TEST_DUTY          0x00003900
+#define CS35L41_DIGPWM_IOCTRL          0x0000706C
+
+/*registers populated by OTP*/
+#define CS35L41_OTP_TRIM_1             0x0000208c
+#define CS35L41_OTP_TRIM_2             0x00002090
+#define CS35L41_OTP_TRIM_3             0x00003010
+#define CS35L41_OTP_TRIM_4             0x0000300C
+#define CS35L41_OTP_TRIM_5             0x0000394C
+#define CS35L41_OTP_TRIM_6             0x00003950
+#define CS35L41_OTP_TRIM_7             0x00003954
+#define CS35L41_OTP_TRIM_8             0x00003958
+#define CS35L41_OTP_TRIM_9             0x0000395C
+#define CS35L41_OTP_TRIM_10            0x0000416C
+#define CS35L41_OTP_TRIM_11            0x00004160
+#define CS35L41_OTP_TRIM_12            0x00004170
+#define CS35L41_OTP_TRIM_13            0x00004360
+#define CS35L41_OTP_TRIM_14            0x00004448
+#define CS35L41_OTP_TRIM_15            0x0000444C
+#define CS35L41_OTP_TRIM_16            0x00006E30
+#define CS35L41_OTP_TRIM_17            0x00006E34
+#define CS35L41_OTP_TRIM_18            0x00006E38
+#define CS35L41_OTP_TRIM_19            0x00006E3C
+#define CS35L41_OTP_TRIM_20            0x00006E40
+#define CS35L41_OTP_TRIM_21            0x00006E44
+#define CS35L41_OTP_TRIM_22            0x00006E48
+#define CS35L41_OTP_TRIM_23            0x00006E4C
+#define CS35L41_OTP_TRIM_24            0x00006E50
+#define CS35L41_OTP_TRIM_25            0x00006E54
+#define CS35L41_OTP_TRIM_26            0x00006E58
+#define CS35L41_OTP_TRIM_27            0x00006E5C
+#define CS35L41_OTP_TRIM_28            0x00006E60
+#define CS35L41_OTP_TRIM_29            0x00006E64
+#define CS35L41_OTP_TRIM_30            0x00007418
+#define CS35L41_OTP_TRIM_31            0x0000741C
+#define CS35L41_OTP_TRIM_32            0x00007434
+#define CS35L41_OTP_TRIM_33            0x00007068
+#define CS35L41_OTP_TRIM_34            0x0000410C
+#define CS35L41_OTP_TRIM_35            0x0000400C
+#define CS35L41_OTP_TRIM_36            0x00002030
+
+#define CS35L41_MAX_CACHE_REG          36
+#define CS35L41_OTP_SIZE_WORDS         32
+#define CS35L41_NUM_OTP_ELEM           100
+#define CS35L41_NUM_OTP_MAPS           5
+
+#define CS35L41_VALID_PDATA            0x80000000
+#define CS35L41_NUM_SUPPLIES            2
+
+#define CS35L41_SCLK_MSTR_MASK         0x10
+#define CS35L41_SCLK_MSTR_SHIFT                4
+#define CS35L41_LRCLK_MSTR_MASK                0x01
+#define CS35L41_LRCLK_MSTR_SHIFT       0
+#define CS35L41_SCLK_INV_MASK          0x40
+#define CS35L41_SCLK_INV_SHIFT         6
+#define CS35L41_LRCLK_INV_MASK         0x04
+#define CS35L41_LRCLK_INV_SHIFT                2
+#define CS35L41_SCLK_FRC_MASK          0x20
+#define CS35L41_SCLK_FRC_SHIFT         5
+#define CS35L41_LRCLK_FRC_MASK         0x02
+#define CS35L41_LRCLK_FRC_SHIFT                1
+
+#define CS35L41_AMP_GAIN_PCM_MASK      0x3E0
+#define CS35L41_AMP_GAIN_ZC_MASK       0x0400
+#define CS35L41_AMP_GAIN_ZC_SHIFT      10
+
+#define CS35L41_BST_CTL_MASK           0xFF
+#define CS35L41_BST_CTL_SEL_MASK       0x03
+#define CS35L41_BST_CTL_SEL_REG                0x00
+#define CS35L41_BST_CTL_SEL_CLASSH     0x01
+#define CS35L41_BST_IPK_MASK           0x7F
+#define CS35L41_BST_IPK_SHIFT          0
+#define CS35L41_BST_LIM_MASK           0x4
+#define CS35L41_BST_LIM_SHIFT          2
+#define CS35L41_BST_K1_MASK            0x000000FF
+#define CS35L41_BST_K1_SHIFT           0
+#define CS35L41_BST_K2_MASK            0x0000FF00
+#define CS35L41_BST_K2_SHIFT           8
+#define CS35L41_BST_SLOPE_MASK         0x0000FF00
+#define CS35L41_BST_SLOPE_SHIFT                8
+#define CS35L41_BST_LBST_VAL_MASK      0x00000003
+#define CS35L41_BST_LBST_VAL_SHIFT     0
+
+#define CS35L41_TEMP_THLD_MASK         0x03
+#define CS35L41_VMON_IMON_VOL_MASK     0x07FF07FF
+#define CS35L41_PDM_MODE_MASK          0x01
+#define CS35L41_PDM_MODE_SHIFT         0
+
+#define CS35L41_CH_MEM_DEPTH_MASK      0x07
+#define CS35L41_CH_MEM_DEPTH_SHIFT     0
+#define CS35L41_CH_HDRM_CTL_MASK       0x007F0000
+#define CS35L41_CH_HDRM_CTL_SHIFT      16
+#define CS35L41_CH_REL_RATE_MASK       0xFF00
+#define CS35L41_CH_REL_RATE_SHIFT      8
+#define CS35L41_CH_WKFET_DLY_MASK      0x001C
+#define CS35L41_CH_WKFET_DLY_SHIFT     2
+#define CS35L41_CH_WKFET_THLD_MASK     0x0F00
+#define CS35L41_CH_WKFET_THLD_SHIFT    8
+
+#define CS35L41_HW_NG_SEL_MASK         0x3F00
+#define CS35L41_HW_NG_SEL_SHIFT                8
+#define CS35L41_HW_NG_DLY_MASK         0x0070
+#define CS35L41_HW_NG_DLY_SHIFT                4
+#define CS35L41_HW_NG_THLD_MASK                0x0007
+#define CS35L41_HW_NG_THLD_SHIFT       0
+
+#define CS35L41_DSP_NG_ENABLE_MASK     0x00010000
+#define CS35L41_DSP_NG_ENABLE_SHIFT    16
+#define CS35L41_DSP_NG_THLD_MASK       0x7
+#define CS35L41_DSP_NG_THLD_SHIFT      0
+#define CS35L41_DSP_NG_DELAY_MASK      0x0F00
+#define CS35L41_DSP_NG_DELAY_SHIFT     8
+
+#define CS35L41_ASP_FMT_MASK           0x0700
+#define CS35L41_ASP_FMT_SHIFT          8
+#define CS35L41_ASP_DOUT_HIZ_MASK      0x03
+#define CS35L41_ASP_DOUT_HIZ_SHIFT     0
+#define CS35L41_ASP_WIDTH_16           0x10
+#define CS35L41_ASP_WIDTH_24           0x18
+#define CS35L41_ASP_WIDTH_32           0x20
+#define CS35L41_ASP_WIDTH_TX_MASK      0xFF0000
+#define CS35L41_ASP_WIDTH_TX_SHIFT     16
+#define CS35L41_ASP_WIDTH_RX_MASK      0xFF000000
+#define CS35L41_ASP_WIDTH_RX_SHIFT     24
+#define CS35L41_ASP_RX1_SLOT_MASK      0x3F
+#define CS35L41_ASP_RX1_SLOT_SHIFT     0
+#define CS35L41_ASP_RX2_SLOT_MASK      0x3F00
+#define CS35L41_ASP_RX2_SLOT_SHIFT     8
+#define CS35L41_ASP_RX_WL_MASK         0x3F
+#define CS35L41_ASP_TX_WL_MASK         0x3F
+#define CS35L41_ASP_RX_WL_SHIFT                0
+#define CS35L41_ASP_TX_WL_SHIFT                0
+#define CS35L41_ASP_SOURCE_MASK                0x7F
+
+#define CS35L41_INPUT_SRC_ASPRX1       0x08
+#define CS35L41_INPUT_SRC_ASPRX2       0x09
+#define CS35L41_INPUT_SRC_VMON         0x18
+#define CS35L41_INPUT_SRC_IMON         0x19
+#define CS35L41_INPUT_SRC_CLASSH       0x21
+#define CS35L41_INPUT_SRC_VPMON                0x28
+#define CS35L41_INPUT_SRC_VBSTMON      0x29
+#define CS35L41_INPUT_SRC_TEMPMON      0x3A
+#define CS35L41_INPUT_SRC_RSVD         0x3B
+#define CS35L41_INPUT_DSP_TX1          0x32
+#define CS35L41_INPUT_DSP_TX2          0x33
+
+#define CS35L41_PLL_CLK_SEL_MASK       0x07
+#define CS35L41_PLL_CLK_SEL_SHIFT      0
+#define CS35L41_PLL_CLK_EN_MASK                0x10
+#define CS35L41_PLL_CLK_EN_SHIFT       4
+#define CS35L41_PLL_OPENLOOP_MASK      0x0800
+#define CS35L41_PLL_OPENLOOP_SHIFT     11
+#define CS35L41_PLLSRC_SCLK            0
+#define CS35L41_PLLSRC_LRCLK           1
+#define CS35L41_PLLSRC_SELF            3
+#define CS35L41_PLLSRC_PDMCLK          4
+#define CS35L41_PLLSRC_MCLK            5
+#define CS35L41_PLLSRC_SWIRE           7
+#define CS35L41_REFCLK_FREQ_MASK       0x7E0
+#define CS35L41_REFCLK_FREQ_SHIFT      5
+
+#define CS35L41_GLOBAL_FS_MASK         0x1F
+#define CS35L41_GLOBAL_FS_SHIFT                0
+
+#define CS35L41_GLOBAL_EN_MASK         0x01
+#define CS35L41_GLOBAL_EN_SHIFT                0
+#define CS35L41_BST_EN_MASK            0x0030
+#define CS35L41_BST_EN_SHIFT           4
+#define CS35L41_BST_EN_DEFAULT         0x2
+#define CS35L41_AMP_EN_SHIFT           0
+#define CS35L41_AMP_EN_MASK            1
+
+#define CS35L41_PDN_DONE_MASK          0x00800000
+#define CS35L41_PDN_DONE_SHIFT         23
+#define CS35L41_PUP_DONE_MASK          0x01000000
+#define CS35L41_PUP_DONE_SHIFT         24
+
+#define CS35L36_PUP_DONE_IRQ_UNMASK    0x5F
+#define CS35L36_PUP_DONE_IRQ_MASK      0xBF
+
+#define CS35L41_AMP_SHORT_ERR          0x80000000
+#define CS35L41_BST_SHORT_ERR          0x0100
+#define CS35L41_TEMP_WARN              0x8000
+#define CS35L41_TEMP_ERR               0x00020000
+#define CS35L41_BST_OVP_ERR            0x40
+#define CS35L41_BST_DCM_UVP_ERR                0x80
+#define CS35L41_OTP_BOOT_DONE          0x02
+#define CS35L41_PLL_UNLOCK             0x10
+#define CS35L41_OTP_BOOT_ERR           0x80000000
+
+#define CS35L41_AMP_SHORT_ERR_RLS      0x02
+#define CS35L41_BST_SHORT_ERR_RLS      0x04
+#define CS35L41_BST_OVP_ERR_RLS                0x08
+#define CS35L41_BST_UVP_ERR_RLS                0x10
+#define CS35L41_TEMP_WARN_ERR_RLS      0x20
+#define CS35L41_TEMP_ERR_RLS           0x40
+
+#define CS35L41_INT1_MASK_DEFAULT      0x7FFCFE3F
+#define CS35L41_INT1_UNMASK_PUP                0xFEFFFFFF
+#define CS35L41_INT1_UNMASK_PDN                0xFF7FFFFF
+
+#define CS35L41_GPIO_DIR_MASK          0x80000000
+#define CS35L41_GPIO_DIR_SHIFT         31
+#define CS35L41_GPIO1_CTRL_MASK                0x00030000
+#define CS35L41_GPIO1_CTRL_SHIFT       16
+#define CS35L41_GPIO2_CTRL_MASK                0x07000000
+#define CS35L41_GPIO2_CTRL_SHIFT       24
+#define CS35L41_GPIO_CTRL_OPEN_INT     2
+#define CS35L41_GPIO_CTRL_ACTV_LO      4
+#define CS35L41_GPIO_CTRL_ACTV_HI      5
+#define CS35L41_GPIO_POL_MASK          0x1000
+#define CS35L41_GPIO_POL_SHIFT         12
+
+#define CS35L41_AMP_INV_PCM_SHIFT      14
+#define CS35L41_AMP_INV_PCM_MASK       BIT(CS35L41_AMP_INV_PCM_SHIFT)
+#define CS35L41_AMP_PCM_VOL_SHIFT      3
+#define CS35L41_AMP_PCM_VOL_MASK       (0x7FF << 3)
+#define CS35L41_AMP_PCM_VOL_MUTE       0x4CF
+
+#define CS35L41_CHIP_ID                        0x35a40
+#define CS35L41R_CHIP_ID               0x35b40
+#define CS35L41_MTLREVID_MASK          0x0F
+#define CS35L41_REVID_A0               0xA0
+#define CS35L41_REVID_B0               0xB0
+#define CS35L41_REVID_B2               0xB2
+
+#define CS35L41_HALO_CORE_RESET                0x00000200
+
+#define CS35L41_FS1_WINDOW_MASK                0x000007FF
+#define CS35L41_FS2_WINDOW_MASK                0x00FFF800
+#define CS35L41_FS2_WINDOW_SHIFT       12
+
+#define CS35L41_SPI_MAX_FREQ_OTP       4000000
+
+#define CS35L41_RX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE)
+#define CS35L41_TX_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE)
+
+bool cs35l41_readable_reg(struct device *dev, unsigned int reg);
+bool cs35l41_precious_reg(struct device *dev, unsigned int reg);
+bool cs35l41_volatile_reg(struct device *dev, unsigned int reg);
+
+struct cs35l41_otp_packed_element_t {
+       u32 reg;
+       u8 shift;
+       u8 size;
+};
+
+struct cs35l41_otp_map_element_t {
+       u32 id;
+       u32 num_elements;
+       const struct cs35l41_otp_packed_element_t *map;
+       u32 bit_offset;
+       u32 word_offset;
+};
+
+extern const struct reg_default cs35l41_reg[CS35L41_MAX_CACHE_REG];
+extern const struct cs35l41_otp_map_element_t
+                               cs35l41_otp_map_map[CS35L41_NUM_OTP_MAPS];
+
+#define CS35L41_REGSTRIDE              4
+
+struct cs35l41_private {
+       struct snd_soc_codec *codec;
+       struct cs35l41_platform_data pdata;
+       struct device *dev;
+       struct regmap *regmap;
+       struct regulator_bulk_data supplies[CS35L41_NUM_SUPPLIES];
+       int irq;
+       /* GPIO for /RST */
+       struct gpio_desc *reset_gpio;
+       void (*otp_setup)(struct cs35l41_private *cs35l41, bool is_pre_setup,
+                         unsigned int *freq);
+};
+
+int cs35l41_probe(struct cs35l41_private *cs35l41,
+                 struct cs35l41_platform_data *pdata);
+void cs35l41_remove(struct cs35l41_private *cs35l41);
+
+#endif /*__CS35L41_H__*/
index 9a463ab..27a1c4c 100644 (file)
@@ -25,7 +25,6 @@
 #include <linux/regulator/consumer.h>
 #include <linux/gpio/consumer.h>
 #include <linux/of_device.h>
-#include <linux/pm_runtime.h>
 #include <sound/core.h>
 #include <sound/pcm.h>
 #include <sound/pcm_params.h>
@@ -41,7 +40,6 @@
 static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_FRZ_CTL,                      0x00 },
        { CS42L42_SRC_CTL,                      0x10 },
-       { CS42L42_MCLK_STATUS,                  0x02 },
        { CS42L42_MCLK_CTL,                     0x02 },
        { CS42L42_SFTRAMP_RATE,                 0xA4 },
        { CS42L42_I2C_DEBOUNCE,                 0x88 },
@@ -53,15 +51,12 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_RSENSE_CTL1,                  0x40 },
        { CS42L42_RSENSE_CTL2,                  0x00 },
        { CS42L42_OSC_SWITCH,                   0x00 },
-       { CS42L42_OSC_SWITCH_STATUS,            0x05 },
        { CS42L42_RSENSE_CTL3,                  0x1B },
        { CS42L42_TSENSE_CTL,                   0x1B },
        { CS42L42_TSRS_INT_DISABLE,             0x00 },
-       { CS42L42_TRSENSE_STATUS,               0x00 },
        { CS42L42_HSDET_CTL1,                   0x77 },
        { CS42L42_HSDET_CTL2,                   0x00 },
        { CS42L42_HS_SWITCH_CTL,                0xF3 },
-       { CS42L42_HS_DET_STATUS,                0x00 },
        { CS42L42_HS_CLAMP_DISABLE,             0x00 },
        { CS42L42_MCLK_SRC_SEL,                 0x00 },
        { CS42L42_SPDIF_CLK_CFG,                0x00 },
@@ -75,25 +70,13 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_IN_ASRC_CLK,                  0x00 },
        { CS42L42_OUT_ASRC_CLK,                 0x00 },
        { CS42L42_PLL_DIV_CFG1,                 0x00 },
-       { CS42L42_ADC_OVFL_STATUS,              0x00 },
-       { CS42L42_MIXER_STATUS,                 0x00 },
-       { CS42L42_SRC_STATUS,                   0x00 },
-       { CS42L42_ASP_RX_STATUS,                0x00 },
-       { CS42L42_ASP_TX_STATUS,                0x00 },
-       { CS42L42_CODEC_STATUS,                 0x00 },
-       { CS42L42_DET_INT_STATUS1,              0x00 },
-       { CS42L42_DET_INT_STATUS2,              0x00 },
-       { CS42L42_SRCPL_INT_STATUS,             0x00 },
-       { CS42L42_VPMON_STATUS,                 0x00 },
-       { CS42L42_PLL_LOCK_STATUS,              0x00 },
-       { CS42L42_TSRS_PLUG_STATUS,             0x00 },
        { CS42L42_ADC_OVFL_INT_MASK,            0x01 },
        { CS42L42_MIXER_INT_MASK,               0x0F },
        { CS42L42_SRC_INT_MASK,                 0x0F },
        { CS42L42_ASP_RX_INT_MASK,              0x1F },
        { CS42L42_ASP_TX_INT_MASK,              0x0F },
        { CS42L42_CODEC_INT_MASK,               0x03 },
-       { CS42L42_SRCPL_INT_MASK,               0xFF },
+       { CS42L42_SRCPL_INT_MASK,               0x7F },
        { CS42L42_VPMON_INT_MASK,               0x01 },
        { CS42L42_PLL_LOCK_INT_MASK,            0x01 },
        { CS42L42_TSRS_PLUG_INT_MASK,           0x0F },
@@ -105,8 +88,6 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_PLL_CTL3,                     0x10 },
        { CS42L42_PLL_CAL_RATIO,                0x80 },
        { CS42L42_PLL_CTL4,                     0x03 },
-       { CS42L42_LOAD_DET_RCSTAT,              0x00 },
-       { CS42L42_LOAD_DET_DONE,                0x00 },
        { CS42L42_LOAD_DET_EN,                  0x00 },
        { CS42L42_HSBIAS_SC_AUTOCTL,            0x03 },
        { CS42L42_WAKE_CTL,                     0xC0 },
@@ -115,8 +96,6 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_MISC_DET_CTL,                 0x03 },
        { CS42L42_MIC_DET_CTL1,                 0x1F },
        { CS42L42_MIC_DET_CTL2,                 0x2F },
-       { CS42L42_DET_STATUS1,                  0x00 },
-       { CS42L42_DET_STATUS2,                  0x00 },
        { CS42L42_DET_INT1_MASK,                0xE0 },
        { CS42L42_DET_INT2_MASK,                0xFF },
        { CS42L42_HS_BIAS_CTL,                  0xC2 },
@@ -130,7 +109,7 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_MIXER_CHA_VOL,                0x3F },
        { CS42L42_MIXER_ADC_VOL,                0x3F },
        { CS42L42_MIXER_CHB_VOL,                0x3F },
-       { CS42L42_EQ_COEF_IN0,                  0x22 },
+       { CS42L42_EQ_COEF_IN0,                  0x00 },
        { CS42L42_EQ_COEF_IN1,                  0x00 },
        { CS42L42_EQ_COEF_IN2,                  0x00 },
        { CS42L42_EQ_COEF_IN3,                  0x00 },
@@ -182,7 +161,6 @@ static const struct reg_default cs42l42_reg_defaults[] = {
        { CS42L42_ASP_RX_DAI1_CH2_AP_RES,       0x03 },
        { CS42L42_ASP_RX_DAI1_CH2_BIT_MSB,      0x00 },
        { CS42L42_ASP_RX_DAI1_CH2_BIT_LSB,      0x00 },
-       { CS42L42_SUB_REVID,                    0x03 },
 };
 
 static bool cs42l42_readable_register(struct device *dev, unsigned int reg)
@@ -351,6 +329,7 @@ static bool cs42l42_volatile_register(struct device *dev, unsigned int reg)
        case CS42L42_DEVID_CD:
        case CS42L42_DEVID_E:
        case CS42L42_MCLK_STATUS:
+       case CS42L42_OSC_SWITCH_STATUS:
        case CS42L42_TRSENSE_STATUS:
        case CS42L42_HS_DET_STATUS:
        case CS42L42_ADC_OVFL_STATUS:
@@ -455,10 +434,36 @@ static const struct snd_kcontrol_new cs42l42_snd_controls[] = {
                                0x3f, 1, mixer_tlv)
 };
 
+static int cs42l42_hp_adc_ev(struct snd_soc_dapm_widget *w,
+                            struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               cs42l42->hp_adc_up_pending = true;
+               break;
+       case SND_SOC_DAPM_POST_PMU:
+               /* Only need one delay if HP and ADC are both powering-up */
+               if (cs42l42->hp_adc_up_pending) {
+                       usleep_range(CS42L42_HP_ADC_EN_TIME_US,
+                                    CS42L42_HP_ADC_EN_TIME_US + 1000);
+                       cs42l42->hp_adc_up_pending = false;
+               }
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
 static const struct snd_soc_dapm_widget cs42l42_dapm_widgets[] = {
        /* Playback Path */
        SND_SOC_DAPM_OUTPUT("HP"),
-       SND_SOC_DAPM_DAC("DAC", NULL, CS42L42_PWR_CTL1, CS42L42_HP_PDN_SHIFT, 1),
+       SND_SOC_DAPM_DAC_E("DAC", NULL, CS42L42_PWR_CTL1, CS42L42_HP_PDN_SHIFT, 1,
+                          cs42l42_hp_adc_ev, SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU),
        SND_SOC_DAPM_MIXER("MIXER", CS42L42_PWR_CTL1, CS42L42_MIXER_PDN_SHIFT, 1, NULL, 0),
        SND_SOC_DAPM_AIF_IN("SDIN1", NULL, 0, SND_SOC_NOPM, 0, 0),
        SND_SOC_DAPM_AIF_IN("SDIN2", NULL, 1, SND_SOC_NOPM, 0, 0),
@@ -468,7 +473,8 @@ static const struct snd_soc_dapm_widget cs42l42_dapm_widgets[] = {
 
        /* Capture Path */
        SND_SOC_DAPM_INPUT("HS"),
-       SND_SOC_DAPM_ADC("ADC", NULL, CS42L42_PWR_CTL1, CS42L42_ADC_PDN_SHIFT, 1),
+       SND_SOC_DAPM_ADC_E("ADC", NULL, CS42L42_PWR_CTL1, CS42L42_ADC_PDN_SHIFT, 1,
+                          cs42l42_hp_adc_ev, SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMU),
        SND_SOC_DAPM_AIF_OUT("SDOUT1", NULL, 0, CS42L42_ASP_TX_CH_EN, CS42L42_ASP_TX0_CH1_SHIFT, 0),
        SND_SOC_DAPM_AIF_OUT("SDOUT2", NULL, 1, CS42L42_ASP_TX_CH_EN, CS42L42_ASP_TX0_CH2_SHIFT, 0),
 
@@ -517,26 +523,10 @@ static int cs42l42_set_jack(struct snd_soc_component *component, struct snd_soc_
 
        cs42l42->jack = jk;
 
-       regmap_update_bits(cs42l42->regmap, CS42L42_TSRS_PLUG_INT_MASK,
-                          CS42L42_RS_PLUG_MASK | CS42L42_RS_UNPLUG_MASK |
-                          CS42L42_TS_PLUG_MASK | CS42L42_TS_UNPLUG_MASK,
-                          (1 << CS42L42_RS_PLUG_SHIFT) | (1 << CS42L42_RS_UNPLUG_SHIFT) |
-                          (0 << CS42L42_TS_PLUG_SHIFT) | (0 << CS42L42_TS_UNPLUG_SHIFT));
-
-       return 0;
-}
-
-static int cs42l42_component_probe(struct snd_soc_component *component)
-{
-       struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
-
-       cs42l42->component = component;
-
        return 0;
 }
 
 static const struct snd_soc_component_driver soc_component_dev_cs42l42 = {
-       .probe                  = cs42l42_component_probe,
        .set_jack               = cs42l42_set_jack,
        .dapm_widgets           = cs42l42_dapm_widgets,
        .num_dapm_widgets       = ARRAY_SIZE(cs42l42_dapm_widgets),
@@ -569,7 +559,6 @@ static const struct reg_sequence cs42l42_to_osc_seq[] = {
 
 struct cs42l42_pll_params {
        u32 sclk;
-       u8 mclk_div;
        u8 mclk_src_sel;
        u8 sclk_prediv;
        u8 pll_div_int;
@@ -586,24 +575,24 @@ struct cs42l42_pll_params {
  * Table 4-5 from the Datasheet
  */
 static const struct cs42l42_pll_params pll_ratio_table[] = {
-       { 1411200, 0, 1, 0x00, 0x80, 0x000000, 0x03, 0x10, 11289600, 128, 2},
-       { 1536000, 0, 1, 0x00, 0x7D, 0x000000, 0x03, 0x10, 12000000, 125, 2},
-       { 2304000, 0, 1, 0x00, 0x55, 0xC00000, 0x02, 0x10, 12288000,  85, 2},
-       { 2400000, 0, 1, 0x00, 0x50, 0x000000, 0x03, 0x10, 12000000,  80, 2},
-       { 2822400, 0, 1, 0x00, 0x40, 0x000000, 0x03, 0x10, 11289600, 128, 1},
-       { 3000000, 0, 1, 0x00, 0x40, 0x000000, 0x03, 0x10, 12000000, 128, 1},
-       { 3072000, 0, 1, 0x00, 0x3E, 0x800000, 0x03, 0x10, 12000000, 125, 1},
-       { 4000000, 0, 1, 0x00, 0x30, 0x800000, 0x03, 0x10, 12000000,  96, 1},
-       { 4096000, 0, 1, 0x00, 0x2E, 0xE00000, 0x03, 0x10, 12000000,  94, 1},
-       { 5644800, 0, 1, 0x01, 0x40, 0x000000, 0x03, 0x10, 11289600, 128, 1},
-       { 6000000, 0, 1, 0x01, 0x40, 0x000000, 0x03, 0x10, 12000000, 128, 1},
-       { 6144000, 0, 1, 0x01, 0x3E, 0x800000, 0x03, 0x10, 12000000, 125, 1},
-       { 11289600, 0, 0, 0, 0, 0, 0, 0, 11289600, 0, 1},
-       { 12000000, 0, 0, 0, 0, 0, 0, 0, 12000000, 0, 1},
-       { 12288000, 0, 0, 0, 0, 0, 0, 0, 12288000, 0, 1},
-       { 22579200, 1, 0, 0, 0, 0, 0, 0, 22579200, 0, 1},
-       { 24000000, 1, 0, 0, 0, 0, 0, 0, 24000000, 0, 1},
-       { 24576000, 1, 0, 0, 0, 0, 0, 0, 24576000, 0, 1}
+       { 1411200,  1, 0x00, 0x80, 0x000000, 0x03, 0x10, 11289600, 128, 2},
+       { 1536000,  1, 0x00, 0x7D, 0x000000, 0x03, 0x10, 12000000, 125, 2},
+       { 2304000,  1, 0x00, 0x55, 0xC00000, 0x02, 0x10, 12288000,  85, 2},
+       { 2400000,  1, 0x00, 0x50, 0x000000, 0x03, 0x10, 12000000,  80, 2},
+       { 2822400,  1, 0x00, 0x40, 0x000000, 0x03, 0x10, 11289600, 128, 1},
+       { 3000000,  1, 0x00, 0x40, 0x000000, 0x03, 0x10, 12000000, 128, 1},
+       { 3072000,  1, 0x00, 0x3E, 0x800000, 0x03, 0x10, 12000000, 125, 1},
+       { 4000000,  1, 0x00, 0x30, 0x800000, 0x03, 0x10, 12000000,  96, 1},
+       { 4096000,  1, 0x00, 0x2E, 0xE00000, 0x03, 0x10, 12000000,  94, 1},
+       { 5644800,  1, 0x01, 0x40, 0x000000, 0x03, 0x10, 11289600, 128, 1},
+       { 6000000,  1, 0x01, 0x40, 0x000000, 0x03, 0x10, 12000000, 128, 1},
+       { 6144000,  1, 0x01, 0x3E, 0x800000, 0x03, 0x10, 12000000, 125, 1},
+       { 11289600, 0, 0, 0, 0, 0, 0, 11289600, 0, 1},
+       { 12000000, 0, 0, 0, 0, 0, 0, 12000000, 0, 1},
+       { 12288000, 0, 0, 0, 0, 0, 0, 12288000, 0, 1},
+       { 22579200, 1, 0x03, 0x40, 0x000000, 0x03, 0x10, 11289600, 128, 1},
+       { 24000000, 1, 0x03, 0x40, 0x000000, 0x03, 0x10, 12000000, 128, 1},
+       { 24576000, 1, 0x03, 0x40, 0x000000, 0x03, 0x10, 12288000, 128, 1}
 };
 
 static int cs42l42_pll_config(struct snd_soc_component *component)
@@ -618,6 +607,14 @@ static int cs42l42_pll_config(struct snd_soc_component *component)
        else
                clk = cs42l42->sclk;
 
+       /* Don't reconfigure if there is an audio stream running */
+       if (cs42l42->stream_use) {
+               if (pll_ratio_table[cs42l42->pll_config].sclk == clk)
+                       return 0;
+               else
+                       return -EBUSY;
+       }
+
        for (i = 0; i < ARRAY_SIZE(pll_ratio_table); i++) {
                if (pll_ratio_table[i].sclk == clk) {
                        cs42l42->pll_config = i;
@@ -631,10 +628,6 @@ static int cs42l42_pll_config(struct snd_soc_component *component)
                                        24000000)) <<
                                        CS42L42_INTERNAL_FS_SHIFT);
 
-                       snd_soc_component_update_bits(component, CS42L42_MCLK_SRC_SEL,
-                                       CS42L42_MCLKDIV_MASK,
-                                       (pll_ratio_table[i].mclk_div <<
-                                       CS42L42_MCLKDIV_SHIFT));
                        /* Set up the LRCLK */
                        fsync = clk / cs42l42->srate;
                        if (((fsync * cs42l42->srate) != clk)
@@ -668,22 +661,6 @@ static int cs42l42_pll_config(struct snd_soc_component *component)
                                        CS42L42_FSYNC_PULSE_WIDTH_MASK,
                                        CS42L42_FRAC1_VAL(fsync - 1) <<
                                        CS42L42_FSYNC_PULSE_WIDTH_SHIFT);
-                       /* Set the sample rates (96k or lower) */
-                       snd_soc_component_update_bits(component, CS42L42_FS_RATE_EN,
-                                       CS42L42_FS_EN_MASK,
-                                       (CS42L42_FS_EN_IASRC_96K |
-                                       CS42L42_FS_EN_OASRC_96K) <<
-                                       CS42L42_FS_EN_SHIFT);
-                       /* Set the input/output internal MCLK clock ~12 MHz */
-                       snd_soc_component_update_bits(component, CS42L42_IN_ASRC_CLK,
-                                       CS42L42_CLK_IASRC_SEL_MASK,
-                                       CS42L42_CLK_IASRC_SEL_12 <<
-                                       CS42L42_CLK_IASRC_SEL_SHIFT);
-                       snd_soc_component_update_bits(component,
-                                       CS42L42_OUT_ASRC_CLK,
-                                       CS42L42_CLK_OASRC_SEL_MASK,
-                                       CS42L42_CLK_OASRC_SEL_12 <<
-                                       CS42L42_CLK_OASRC_SEL_SHIFT);
                        if (pll_ratio_table[i].mclk_src_sel == 0) {
                                /* Pass the clock straight through */
                                snd_soc_component_update_bits(component,
@@ -746,6 +723,39 @@ static int cs42l42_pll_config(struct snd_soc_component *component)
        return -EINVAL;
 }
 
+static void cs42l42_src_config(struct snd_soc_component *component, unsigned int sample_rate)
+{
+       struct cs42l42_private *cs42l42 = snd_soc_component_get_drvdata(component);
+       unsigned int fs;
+
+       /* Don't reconfigure if there is an audio stream running */
+       if (cs42l42->stream_use)
+               return;
+
+       /* SRC MCLK must be as close as possible to 125 * sample rate */
+       if (sample_rate <= 48000)
+               fs = CS42L42_CLK_IASRC_SEL_6;
+       else
+               fs = CS42L42_CLK_IASRC_SEL_12;
+
+       /* Set the sample rates (96k or lower) */
+       snd_soc_component_update_bits(component,
+                                     CS42L42_FS_RATE_EN,
+                                     CS42L42_FS_EN_MASK,
+                                     (CS42L42_FS_EN_IASRC_96K |
+                                      CS42L42_FS_EN_OASRC_96K) <<
+                                     CS42L42_FS_EN_SHIFT);
+
+       snd_soc_component_update_bits(component,
+                                     CS42L42_IN_ASRC_CLK,
+                                     CS42L42_CLK_IASRC_SEL_MASK,
+                                     fs << CS42L42_CLK_IASRC_SEL_SHIFT);
+       snd_soc_component_update_bits(component,
+                                     CS42L42_OUT_ASRC_CLK,
+                                     CS42L42_CLK_OASRC_SEL_MASK,
+                                     fs << CS42L42_CLK_OASRC_SEL_SHIFT);
+}
+
 static int cs42l42_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
 {
        struct snd_soc_component *component = codec_dai->component;
@@ -824,7 +834,7 @@ static int cs42l42_dai_startup(struct snd_pcm_substream *substream, struct snd_s
        /* Machine driver has not set a SCLK, limit bottom end to 44.1 kHz */
        return snd_pcm_hw_constraint_minmax(substream->runtime,
                                            SNDRV_PCM_HW_PARAM_RATE,
-                                           44100, 192000);
+                                           44100, 96000);
 }
 
 static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
@@ -836,6 +846,7 @@ static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
        unsigned int channels = params_channels(params);
        unsigned int width = (params_width(params) / 8) - 1;
        unsigned int val = 0;
+       int ret;
 
        cs42l42->srate = params_rate(params);
        cs42l42->bclk = snd_soc_params_to_bclk(params);
@@ -851,13 +862,12 @@ static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
        if (params_width(params) == 24)
                cs42l42->bclk = (cs42l42->bclk / 3) * 4;
 
-       switch(substream->stream) {
+       switch (substream->stream) {
        case SNDRV_PCM_STREAM_CAPTURE:
-               if (channels == 2) {
-                       val |= CS42L42_ASP_TX_CH2_AP_MASK;
-                       val |= width << CS42L42_ASP_TX_CH2_RES_SHIFT;
-               }
-               val |= width << CS42L42_ASP_TX_CH1_RES_SHIFT;
+               /* channel 2 on high LRCLK */
+               val = CS42L42_ASP_TX_CH2_AP_MASK |
+                     (width << CS42L42_ASP_TX_CH2_RES_SHIFT) |
+                     (width << CS42L42_ASP_TX_CH1_RES_SHIFT);
 
                snd_soc_component_update_bits(component, CS42L42_ASP_TX_CH_AP_RES,
                                CS42L42_ASP_TX_CH1_AP_MASK | CS42L42_ASP_TX_CH2_AP_MASK |
@@ -890,7 +900,13 @@ static int cs42l42_pcm_hw_params(struct snd_pcm_substream *substream,
                break;
        }
 
-       return cs42l42_pll_config(component);
+       ret = cs42l42_pll_config(component);
+       if (ret)
+               return ret;
+
+       cs42l42_src_config(component, params_rate(params));
+
+       return 0;
 }
 
 static int cs42l42_set_sysclk(struct snd_soc_dai *dai,
@@ -934,7 +950,7 @@ static int cs42l42_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
                                                      CS42L42_HP_ANA_BMUTE_MASK);
 
                cs42l42->stream_use &= ~(1 << stream);
-               if(!cs42l42->stream_use) {
+               if (!cs42l42->stream_use) {
                        /*
                         * Switch to the internal oscillator.
                         * SCLK must remain running until after this clock switch.
@@ -1005,7 +1021,7 @@ static int cs42l42_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
 
 #define CS42L42_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |\
                         SNDRV_PCM_FMTBIT_S24_LE |\
-                        SNDRV_PCM_FMTBIT_S32_LE )
+                        SNDRV_PCM_FMTBIT_S32_LE)
 
 static const struct snd_soc_dai_ops cs42l42_ops = {
        .startup        = cs42l42_dai_startup,
@@ -1021,14 +1037,14 @@ static struct snd_soc_dai_driver cs42l42_dai = {
                        .stream_name = "Playback",
                        .channels_min = 1,
                        .channels_max = 2,
-                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .rates = SNDRV_PCM_RATE_8000_96000,
                        .formats = CS42L42_FORMATS,
                },
                .capture = {
                        .stream_name = "Capture",
                        .channels_min = 1,
                        .channels_max = 2,
-                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .rates = SNDRV_PCM_RATE_8000_96000,
                        .formats = CS42L42_FORMATS,
                },
                .symmetric_rate = 1,
@@ -1036,11 +1052,121 @@ static struct snd_soc_dai_driver cs42l42_dai = {
                .ops = &cs42l42_ops,
 };
 
+static void cs42l42_manual_hs_type_detect(struct cs42l42_private *cs42l42)
+{
+       unsigned int hs_det_status;
+       unsigned int hs_det_comp1;
+       unsigned int hs_det_comp2;
+       unsigned int hs_det_sw;
+
+       /* Set hs detect to manual, active mode */
+       regmap_update_bits(cs42l42->regmap,
+               CS42L42_HSDET_CTL2,
+               CS42L42_HSDET_CTRL_MASK |
+               CS42L42_HSDET_SET_MASK |
+               CS42L42_HSBIAS_REF_MASK |
+               CS42L42_HSDET_AUTO_TIME_MASK,
+               (1 << CS42L42_HSDET_CTRL_SHIFT) |
+               (0 << CS42L42_HSDET_SET_SHIFT) |
+               (0 << CS42L42_HSBIAS_REF_SHIFT) |
+               (0 << CS42L42_HSDET_AUTO_TIME_SHIFT));
+
+       /* Configure HS DET comparator reference levels. */
+       regmap_update_bits(cs42l42->regmap,
+                               CS42L42_HSDET_CTL1,
+                               CS42L42_HSDET_COMP1_LVL_MASK |
+                               CS42L42_HSDET_COMP2_LVL_MASK,
+                               (CS42L42_HSDET_COMP1_LVL_VAL << CS42L42_HSDET_COMP1_LVL_SHIFT) |
+                               (CS42L42_HSDET_COMP2_LVL_VAL << CS42L42_HSDET_COMP2_LVL_SHIFT));
+
+       /* Open the SW_HSB_HS3 switch and close SW_HSB_HS4 for a Type 1 headset. */
+       regmap_write(cs42l42->regmap, CS42L42_HS_SWITCH_CTL, CS42L42_HSDET_SW_COMP1);
+
+       msleep(100);
+
+       regmap_read(cs42l42->regmap, CS42L42_HS_DET_STATUS, &hs_det_status);
+
+       hs_det_comp1 = (hs_det_status & CS42L42_HSDET_COMP1_OUT_MASK) >>
+                       CS42L42_HSDET_COMP1_OUT_SHIFT;
+       hs_det_comp2 = (hs_det_status & CS42L42_HSDET_COMP2_OUT_MASK) >>
+                       CS42L42_HSDET_COMP2_OUT_SHIFT;
+
+       /* Close the SW_HSB_HS3 switch for a Type 2 headset. */
+       regmap_write(cs42l42->regmap, CS42L42_HS_SWITCH_CTL, CS42L42_HSDET_SW_COMP2);
+
+       msleep(100);
+
+       regmap_read(cs42l42->regmap, CS42L42_HS_DET_STATUS, &hs_det_status);
+
+       hs_det_comp1 |= ((hs_det_status & CS42L42_HSDET_COMP1_OUT_MASK) >>
+                       CS42L42_HSDET_COMP1_OUT_SHIFT) << 1;
+       hs_det_comp2 |= ((hs_det_status & CS42L42_HSDET_COMP2_OUT_MASK) >>
+                       CS42L42_HSDET_COMP2_OUT_SHIFT) << 1;
+
+       /* Use Comparator 1 with 1.25V Threshold. */
+       switch (hs_det_comp1) {
+       case CS42L42_HSDET_COMP_TYPE1:
+               cs42l42->hs_type = CS42L42_PLUG_CTIA;
+               hs_det_sw = CS42L42_HSDET_SW_TYPE1;
+               break;
+       case CS42L42_HSDET_COMP_TYPE2:
+               cs42l42->hs_type = CS42L42_PLUG_OMTP;
+               hs_det_sw = CS42L42_HSDET_SW_TYPE2;
+               break;
+       default:
+               /* Fallback to Comparator 2 with 1.75V Threshold. */
+               switch (hs_det_comp2) {
+               case CS42L42_HSDET_COMP_TYPE1:
+                       cs42l42->hs_type = CS42L42_PLUG_CTIA;
+                       hs_det_sw = CS42L42_HSDET_SW_TYPE1;
+                       break;
+               case CS42L42_HSDET_COMP_TYPE2:
+                       cs42l42->hs_type = CS42L42_PLUG_OMTP;
+                       hs_det_sw = CS42L42_HSDET_SW_TYPE2;
+                       break;
+               case CS42L42_HSDET_COMP_TYPE3:
+                       cs42l42->hs_type = CS42L42_PLUG_HEADPHONE;
+                       hs_det_sw = CS42L42_HSDET_SW_TYPE3;
+                       break;
+               default:
+                       cs42l42->hs_type = CS42L42_PLUG_INVALID;
+                       hs_det_sw = CS42L42_HSDET_SW_TYPE4;
+                       break;
+               }
+       }
+
+       /* Set Switches */
+       regmap_write(cs42l42->regmap, CS42L42_HS_SWITCH_CTL, hs_det_sw);
+
+       /* Set HSDET mode to Manual—Disabled */
+       regmap_update_bits(cs42l42->regmap,
+               CS42L42_HSDET_CTL2,
+               CS42L42_HSDET_CTRL_MASK |
+               CS42L42_HSDET_SET_MASK |
+               CS42L42_HSBIAS_REF_MASK |
+               CS42L42_HSDET_AUTO_TIME_MASK,
+               (0 << CS42L42_HSDET_CTRL_SHIFT) |
+               (0 << CS42L42_HSDET_SET_SHIFT) |
+               (0 << CS42L42_HSBIAS_REF_SHIFT) |
+               (0 << CS42L42_HSDET_AUTO_TIME_SHIFT));
+
+       /* Configure HS DET comparator reference levels. */
+       regmap_update_bits(cs42l42->regmap,
+                               CS42L42_HSDET_CTL1,
+                               CS42L42_HSDET_COMP1_LVL_MASK |
+                               CS42L42_HSDET_COMP2_LVL_MASK,
+                               (CS42L42_HSDET_COMP1_LVL_DEFAULT << CS42L42_HSDET_COMP1_LVL_SHIFT) |
+                               (CS42L42_HSDET_COMP2_LVL_DEFAULT << CS42L42_HSDET_COMP2_LVL_SHIFT));
+}
+
 static void cs42l42_process_hs_type_detect(struct cs42l42_private *cs42l42)
 {
        unsigned int hs_det_status;
        unsigned int int_status;
 
+       /* Read and save the hs detection result */
+       regmap_read(cs42l42->regmap, CS42L42_HS_DET_STATUS, &hs_det_status);
+
        /* Mask the auto detect interrupt */
        regmap_update_bits(cs42l42->regmap,
                CS42L42_CODEC_INT_MASK,
@@ -1049,6 +1175,10 @@ static void cs42l42_process_hs_type_detect(struct cs42l42_private *cs42l42)
                (1 << CS42L42_PDN_DONE_SHIFT) |
                (1 << CS42L42_HSDET_AUTO_DONE_SHIFT));
 
+
+       cs42l42->hs_type = (hs_det_status & CS42L42_HSDET_TYPE_MASK) >>
+                               CS42L42_HSDET_TYPE_SHIFT;
+
        /* Set hs detect to automatic, disabled mode */
        regmap_update_bits(cs42l42->regmap,
                CS42L42_HSDET_CTL2,
@@ -1061,11 +1191,15 @@ static void cs42l42_process_hs_type_detect(struct cs42l42_private *cs42l42)
                (0 << CS42L42_HSBIAS_REF_SHIFT) |
                (3 << CS42L42_HSDET_AUTO_TIME_SHIFT));
 
-       /* Read and save the hs detection result */
-       regmap_read(cs42l42->regmap, CS42L42_HS_DET_STATUS, &hs_det_status);
-
-       cs42l42->hs_type = (hs_det_status & CS42L42_HSDET_TYPE_MASK) >>
-                               CS42L42_HSDET_TYPE_SHIFT;
+       /* Run Manual detection if auto detect has not found a headset.
+        * We Re-Run with Manual Detection if the original detection was invalid or headphones,
+        * to ensure that a headset mic is detected in all cases.
+        */
+       if (cs42l42->hs_type == CS42L42_PLUG_INVALID ||
+               cs42l42->hs_type == CS42L42_PLUG_HEADPHONE) {
+               dev_dbg(cs42l42->dev, "Running Manual Detection Fallback\n");
+               cs42l42_manual_hs_type_detect(cs42l42);
+       }
 
        /* Set up button detection */
        if ((cs42l42->hs_type == CS42L42_PLUG_CTIA) ||
@@ -1362,19 +1496,19 @@ static int cs42l42_handle_button_press(struct cs42l42_private *cs42l42)
        switch (bias_level) {
        case 1: /* Function C button press */
                bias_level = SND_JACK_BTN_2;
-               dev_dbg(cs42l42->component->dev, "Function C button press\n");
+               dev_dbg(cs42l42->dev, "Function C button press\n");
                break;
        case 2: /* Function B button press */
                bias_level = SND_JACK_BTN_1;
-               dev_dbg(cs42l42->component->dev, "Function B button press\n");
+               dev_dbg(cs42l42->dev, "Function B button press\n");
                break;
        case 3: /* Function D button press */
                bias_level = SND_JACK_BTN_3;
-               dev_dbg(cs42l42->component->dev, "Function D button press\n");
+               dev_dbg(cs42l42->dev, "Function D button press\n");
                break;
        case 4: /* Function A button press */
                bias_level = SND_JACK_BTN_0;
-               dev_dbg(cs42l42->component->dev, "Function A button press\n");
+               dev_dbg(cs42l42->dev, "Function A button press\n");
                break;
        default:
                bias_level = 0;
@@ -1448,7 +1582,6 @@ static const struct cs42l42_irq_params irq_params_table[] = {
 static irqreturn_t cs42l42_irq_thread(int irq, void *data)
 {
        struct cs42l42_private *cs42l42 = (struct cs42l42_private *)data;
-       struct snd_soc_component *component = cs42l42->component;
        unsigned int stickies[12];
        unsigned int masks[12];
        unsigned int current_plug_status;
@@ -1482,7 +1615,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data)
        if ((~masks[5]) & irq_params_table[5].mask) {
                if (stickies[5] & CS42L42_HSDET_AUTO_DONE_MASK) {
                        cs42l42_process_hs_type_detect(cs42l42);
-                       switch(cs42l42->hs_type){
+                       switch (cs42l42->hs_type) {
                        case CS42L42_PLUG_CTIA:
                        case CS42L42_PLUG_OMTP:
                                snd_soc_jack_report(cs42l42->jack, SND_JACK_HEADSET,
@@ -1495,7 +1628,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data)
                        default:
                                break;
                        }
-                       dev_dbg(component->dev, "Auto detect done (%d)\n", cs42l42->hs_type);
+                       dev_dbg(cs42l42->dev, "Auto detect done (%d)\n", cs42l42->hs_type);
                }
        }
 
@@ -1514,7 +1647,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data)
                                cs42l42->plug_state = CS42L42_TS_UNPLUG;
                                cs42l42_cancel_hs_type_detect(cs42l42);
 
-                               switch(cs42l42->hs_type){
+                               switch (cs42l42->hs_type) {
                                case CS42L42_PLUG_CTIA:
                                case CS42L42_PLUG_OMTP:
                                        snd_soc_jack_report(cs42l42->jack, 0, SND_JACK_HEADSET);
@@ -1529,7 +1662,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data)
                                                    SND_JACK_BTN_0 | SND_JACK_BTN_1 |
                                                    SND_JACK_BTN_2 | SND_JACK_BTN_3);
 
-                               dev_dbg(component->dev, "Unplug event\n");
+                               dev_dbg(cs42l42->dev, "Unplug event\n");
                        }
                        break;
 
@@ -1545,7 +1678,7 @@ static irqreturn_t cs42l42_irq_thread(int irq, void *data)
                        CS42L42_M_HSBIAS_HIZ_MASK)) {
 
                        if (current_button_status & CS42L42_M_DETECT_TF_MASK) {
-                               dev_dbg(component->dev, "Button released\n");
+                               dev_dbg(cs42l42->dev, "Button released\n");
                                report = 0;
                        } else if (current_button_status & CS42L42_M_DETECT_FT_MASK) {
                                report = cs42l42_handle_button_press(cs42l42);
@@ -1658,8 +1791,8 @@ static void cs42l42_set_interrupt_masks(struct cs42l42_private *cs42l42)
                        CS42L42_TS_UNPLUG_MASK,
                        (1 << CS42L42_RS_PLUG_SHIFT) |
                        (1 << CS42L42_RS_UNPLUG_SHIFT) |
-                       (1 << CS42L42_TS_PLUG_SHIFT) |
-                       (1 << CS42L42_TS_UNPLUG_SHIFT));
+                       (0 << CS42L42_TS_PLUG_SHIFT) |
+                       (0 << CS42L42_TS_UNPLUG_SHIFT));
 }
 
 static void cs42l42_setup_hs_type_detect(struct cs42l42_private *cs42l42)
@@ -1685,12 +1818,15 @@ static void cs42l42_setup_hs_type_detect(struct cs42l42_private *cs42l42)
                        (1 << CS42L42_HS_CLAMP_DISABLE_SHIFT));
 
        /* Enable the tip sense circuit */
+       regmap_update_bits(cs42l42->regmap, CS42L42_TSENSE_CTL,
+                          CS42L42_TS_INV_MASK, CS42L42_TS_INV_MASK);
+
        regmap_update_bits(cs42l42->regmap, CS42L42_TIPSENSE_CTL,
                        CS42L42_TIP_SENSE_CTRL_MASK |
                        CS42L42_TIP_SENSE_INV_MASK |
                        CS42L42_TIP_SENSE_DEBOUNCE_MASK,
                        (3 << CS42L42_TIP_SENSE_CTRL_SHIFT) |
-                       (0 << CS42L42_TIP_SENSE_INV_SHIFT) |
+                       (!cs42l42->ts_inv << CS42L42_TIP_SENSE_INV_SHIFT) |
                        (2 << CS42L42_TIP_SENSE_DEBOUNCE_SHIFT));
 
        /* Save the initial status of the tip sense */
@@ -1734,10 +1870,6 @@ static int cs42l42_handle_device_data(struct device *dev,
                cs42l42->ts_inv = CS42L42_TS_INV_DIS;
        }
 
-       regmap_update_bits(cs42l42->regmap, CS42L42_TSENSE_CTL,
-                       CS42L42_TS_INV_MASK,
-                       (cs42l42->ts_inv << CS42L42_TS_INV_SHIFT));
-
        ret = device_property_read_u32(dev, "cirrus,ts-dbnc-rise", &val);
        if (!ret) {
                switch (val) {
@@ -1899,6 +2031,7 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
        if (!cs42l42)
                return -ENOMEM;
 
+       cs42l42->dev = &i2c_client->dev;
        i2c_set_clientdata(i2c_client, cs42l42);
 
        cs42l42->regmap = devm_regmap_init_i2c(i2c_client, &cs42l42_regmap);
@@ -1933,7 +2066,7 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
                "reset", GPIOD_OUT_LOW);
        if (IS_ERR(cs42l42->reset_gpio)) {
                ret = PTR_ERR(cs42l42->reset_gpio);
-               goto err_disable;
+               goto err_disable_noreset;
        }
 
        if (cs42l42->reset_gpio) {
@@ -1942,16 +2075,20 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
        }
        usleep_range(CS42L42_BOOT_TIME_US, CS42L42_BOOT_TIME_US * 2);
 
-       /* Request IRQ */
-       ret = devm_request_threaded_irq(&i2c_client->dev,
-                       i2c_client->irq,
-                       NULL, cs42l42_irq_thread,
-                       IRQF_ONESHOT | IRQF_TRIGGER_LOW,
-                       "cs42l42", cs42l42);
-
-       if (ret != 0)
-               dev_err(&i2c_client->dev,
-                       "Failed to request IRQ: %d\n", ret);
+       /* Request IRQ if one was specified */
+       if (i2c_client->irq) {
+               ret = request_threaded_irq(i2c_client->irq,
+                                          NULL, cs42l42_irq_thread,
+                                          IRQF_ONESHOT | IRQF_TRIGGER_LOW,
+                                          "cs42l42", cs42l42);
+               if (ret == -EPROBE_DEFER) {
+                       goto err_disable_noirq;
+               } else if (ret != 0) {
+                       dev_err(&i2c_client->dev,
+                               "Failed to request IRQ: %d\n", ret);
+                       goto err_disable_noirq;
+               }
+       }
 
        /* initialize codec */
        devid = cirrus_read_device_id(cs42l42->regmap, CS42L42_DEVID_AB);
@@ -1972,7 +2109,7 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
        ret = regmap_read(cs42l42->regmap, CS42L42_REVID, &reg);
        if (ret < 0) {
                dev_err(&i2c_client->dev, "Get Revision ID failed\n");
-               goto err_disable;
+               goto err_shutdown;
        }
 
        dev_info(&i2c_client->dev,
@@ -1997,7 +2134,7 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
 
        ret = cs42l42_handle_device_data(&i2c_client->dev, cs42l42);
        if (ret != 0)
-               goto err_disable;
+               goto err_shutdown;
 
        /* Setup headset detection */
        cs42l42_setup_hs_type_detect(cs42l42);
@@ -2009,10 +2146,22 @@ static int cs42l42_i2c_probe(struct i2c_client *i2c_client,
        ret = devm_snd_soc_register_component(&i2c_client->dev,
                        &soc_component_dev_cs42l42, &cs42l42_dai, 1);
        if (ret < 0)
-               goto err_disable;
+               goto err_shutdown;
+
        return 0;
 
+err_shutdown:
+       regmap_write(cs42l42->regmap, CS42L42_CODEC_INT_MASK, 0xff);
+       regmap_write(cs42l42->regmap, CS42L42_TSRS_PLUG_INT_MASK, 0xff);
+       regmap_write(cs42l42->regmap, CS42L42_PWR_CTL1, 0xff);
+
 err_disable:
+       if (i2c_client->irq)
+               free_irq(i2c_client->irq, cs42l42);
+
+err_disable_noirq:
+       gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
+err_disable_noreset:
        regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies),
                                cs42l42->supplies);
        return ret;
@@ -2022,59 +2171,22 @@ static int cs42l42_i2c_remove(struct i2c_client *i2c_client)
 {
        struct cs42l42_private *cs42l42 = i2c_get_clientdata(i2c_client);
 
-       devm_free_irq(&i2c_client->dev, i2c_client->irq, cs42l42);
-       pm_runtime_suspend(&i2c_client->dev);
-       pm_runtime_disable(&i2c_client->dev);
+       if (i2c_client->irq)
+               free_irq(i2c_client->irq, cs42l42);
 
-       return 0;
-}
-
-#ifdef CONFIG_PM
-static int cs42l42_runtime_suspend(struct device *dev)
-{
-       struct cs42l42_private *cs42l42 = dev_get_drvdata(dev);
-
-       regcache_cache_only(cs42l42->regmap, true);
-       regcache_mark_dirty(cs42l42->regmap);
+       /*
+        * The driver might not have control of reset and power supplies,
+        * so ensure that the chip internals are powered down.
+        */
+       regmap_write(cs42l42->regmap, CS42L42_CODEC_INT_MASK, 0xff);
+       regmap_write(cs42l42->regmap, CS42L42_TSRS_PLUG_INT_MASK, 0xff);
+       regmap_write(cs42l42->regmap, CS42L42_PWR_CTL1, 0xff);
 
-       /* Hold down reset */
        gpiod_set_value_cansleep(cs42l42->reset_gpio, 0);
-
-       /* remove power */
-       regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies),
-                               cs42l42->supplies);
-
-       return 0;
-}
-
-static int cs42l42_runtime_resume(struct device *dev)
-{
-       struct cs42l42_private *cs42l42 = dev_get_drvdata(dev);
-       int ret;
-
-       /* Enable power */
-       ret = regulator_bulk_enable(ARRAY_SIZE(cs42l42->supplies),
-                                       cs42l42->supplies);
-       if (ret != 0) {
-               dev_err(dev, "Failed to enable supplies: %d\n",
-                       ret);
-               return ret;
-       }
-
-       gpiod_set_value_cansleep(cs42l42->reset_gpio, 1);
-       usleep_range(CS42L42_BOOT_TIME_US, CS42L42_BOOT_TIME_US * 2);
-
-       regcache_cache_only(cs42l42->regmap, false);
-       regcache_sync(cs42l42->regmap);
+       regulator_bulk_disable(ARRAY_SIZE(cs42l42->supplies), cs42l42->supplies);
 
        return 0;
 }
-#endif
-
-static const struct dev_pm_ops cs42l42_runtime_pm = {
-       SET_RUNTIME_PM_OPS(cs42l42_runtime_suspend, cs42l42_runtime_resume,
-                          NULL)
-};
 
 #ifdef CONFIG_OF
 static const struct of_device_id cs42l42_of_match[] = {
@@ -2102,7 +2214,6 @@ MODULE_DEVICE_TABLE(i2c, cs42l42_id);
 static struct i2c_driver cs42l42_i2c_driver = {
        .driver = {
                .name = "cs42l42",
-               .pm = &cs42l42_runtime_pm,
                .of_match_table = of_match_ptr(cs42l42_of_match),
                .acpi_match_table = ACPI_PTR(cs42l42_acpi_match),
                },
index 8734f68..f45bcc9 100644 (file)
 #define CS42L42_HSDET_COMP2_LVL_SHIFT  4
 #define CS42L42_HSDET_COMP2_LVL_MASK   (15 << CS42L42_HSDET_COMP2_LVL_SHIFT)
 
+#define CS42L42_HSDET_COMP1_LVL_VAL    12 /* 1.25V Comparator */
+#define CS42L42_HSDET_COMP2_LVL_VAL    2  /* 1.75V Comparator */
+#define CS42L42_HSDET_COMP1_LVL_DEFAULT        7  /* 1V Comparator */
+#define CS42L42_HSDET_COMP2_LVL_DEFAULT        7  /* 2V Comparator */
+
 #define CS42L42_HSDET_CTL2             (CS42L42_PAGE_11 + 0x20)
 #define CS42L42_HSDET_AUTO_TIME_SHIFT  0
 #define CS42L42_HSDET_AUTO_TIME_MASK   (3 << CS42L42_HSDET_AUTO_TIME_SHIFT)
 #define CS42L42_PLUG_HEADPHONE         2
 #define CS42L42_PLUG_INVALID           3
 
+#define CS42L42_HSDET_SW_COMP1         ((0 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS3_SHIFT))
+#define CS42L42_HSDET_SW_COMP2         ((1 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_REF_HS3_SHIFT))
+#define CS42L42_HSDET_SW_TYPE1         ((0 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS3_SHIFT))
+#define CS42L42_HSDET_SW_TYPE2         ((1 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_REF_HS3_SHIFT))
+#define CS42L42_HSDET_SW_TYPE3         ((1 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS3_SHIFT))
+#define CS42L42_HSDET_SW_TYPE4         ((0 << CS42L42_SW_GNDHS_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_GNDHS_HS3_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_HS4_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_HSB_FILT_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_HSB_FILT_HS3_SHIFT) | \
+                                        (0 << CS42L42_SW_REF_HS4_SHIFT) | \
+                                        (1 << CS42L42_SW_REF_HS3_SHIFT))
+
+#define CS42L42_HSDET_COMP_TYPE1       1
+#define CS42L42_HSDET_COMP_TYPE2       2
+#define CS42L42_HSDET_COMP_TYPE3       0
+#define CS42L42_HSDET_COMP_TYPE4       3
+
 #define CS42L42_HS_CLAMP_DISABLE       (CS42L42_PAGE_11 + 0x29)
 #define CS42L42_HS_CLAMP_DISABLE_SHIFT 0
 #define CS42L42_HS_CLAMP_DISABLE_MASK  (1 << CS42L42_HS_CLAMP_DISABLE_SHIFT)
 #define CS42L42_IN_ASRC_CLK            (CS42L42_PAGE_12 + 0x0A)
 #define CS42L42_CLK_IASRC_SEL_SHIFT    0
 #define CS42L42_CLK_IASRC_SEL_MASK     (1 << CS42L42_CLK_IASRC_SEL_SHIFT)
+#define CS42L42_CLK_IASRC_SEL_6                0
 #define CS42L42_CLK_IASRC_SEL_12       1
 
 #define CS42L42_OUT_ASRC_CLK           (CS42L42_PAGE_12 + 0x0B)
 #define CS42L42_CLOCK_SWITCH_DELAY_US 150
 #define CS42L42_PLL_LOCK_POLL_US       250
 #define CS42L42_PLL_LOCK_TIMEOUT_US    1250
+#define CS42L42_HP_ADC_EN_TIME_US      20000
 
 static const char *const cs42l42_supply_names[CS42L42_NUM_SUPPLIES] = {
        "VA",
@@ -772,7 +833,7 @@ static const char *const cs42l42_supply_names[CS42L42_NUM_SUPPLIES] = {
 
 struct  cs42l42_private {
        struct regmap *regmap;
-       struct snd_soc_component *component;
+       struct device *dev;
        struct regulator_bulk_data supplies[CS42L42_NUM_SUPPLIES];
        struct gpio_desc *reset_gpio;
        struct completion pdn_done;
@@ -794,6 +855,7 @@ struct  cs42l42_private {
        u8 hs_bias_ramp_time;
        u8 hs_bias_sense_en;
        u8 stream_use;
+       bool hp_adc_up_pending;
 };
 
 #endif /* __CS42L42_H__ */
index 1ee8316..391fd7d 100644 (file)
@@ -45,7 +45,7 @@ struct cs47l15 {
        bool in1_lp_mode;
 };
 
-static const struct wm_adsp_region cs47l15_dsp1_regions[] = {
+static const struct cs_dsp_region cs47l15_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x080000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x0e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x0a0000 },
@@ -1402,18 +1402,18 @@ static int cs47l15_probe(struct platform_device *pdev)
                dev_warn(&pdev->dev, "Failed to set DSP IRQ wake: %d\n", ret);
 
        cs47l15->core.adsp[0].part = "cs47l15";
-       cs47l15->core.adsp[0].num = 1;
-       cs47l15->core.adsp[0].type = WMFW_ADSP2;
-       cs47l15->core.adsp[0].rev = 2;
-       cs47l15->core.adsp[0].dev = madera->dev;
-       cs47l15->core.adsp[0].regmap = madera->regmap_32bit;
-
-       cs47l15->core.adsp[0].base = MADERA_DSP1_CONFIG_1;
-       cs47l15->core.adsp[0].mem = cs47l15_dsp1_regions;
-       cs47l15->core.adsp[0].num_mems = ARRAY_SIZE(cs47l15_dsp1_regions);
-
-       cs47l15->core.adsp[0].lock_regions =
-               WM_ADSP2_REGION_1 | WM_ADSP2_REGION_2 | WM_ADSP2_REGION_3;
+       cs47l15->core.adsp[0].cs_dsp.num = 1;
+       cs47l15->core.adsp[0].cs_dsp.type = WMFW_ADSP2;
+       cs47l15->core.adsp[0].cs_dsp.rev = 2;
+       cs47l15->core.adsp[0].cs_dsp.dev = madera->dev;
+       cs47l15->core.adsp[0].cs_dsp.regmap = madera->regmap_32bit;
+
+       cs47l15->core.adsp[0].cs_dsp.base = MADERA_DSP1_CONFIG_1;
+       cs47l15->core.adsp[0].cs_dsp.mem = cs47l15_dsp1_regions;
+       cs47l15->core.adsp[0].cs_dsp.num_mems = ARRAY_SIZE(cs47l15_dsp1_regions);
+
+       cs47l15->core.adsp[0].cs_dsp.lock_regions =
+               CS_ADSP2_REGION_1 | CS_ADSP2_REGION_2 | CS_ADSP2_REGION_3;
 
        ret = wm_adsp2_init(&cs47l15->core.adsp[0]);
        if (ret != 0)
index 6b6d088..6356f81 100644 (file)
@@ -37,21 +37,21 @@ struct cs47l24_priv {
        struct arizona_fll fll[2];
 };
 
-static const struct wm_adsp_region cs47l24_dsp2_regions[] = {
+static const struct cs_dsp_region cs47l24_dsp2_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x200000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x280000 },
        { .type = WMFW_ADSP2_XM, .base = 0x290000 },
        { .type = WMFW_ADSP2_YM, .base = 0x2a8000 },
 };
 
-static const struct wm_adsp_region cs47l24_dsp3_regions[] = {
+static const struct cs_dsp_region cs47l24_dsp3_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x300000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x380000 },
        { .type = WMFW_ADSP2_XM, .base = 0x390000 },
        { .type = WMFW_ADSP2_YM, .base = 0x3a8000 },
 };
 
-static const struct wm_adsp_region *cs47l24_dsp_regions[] = {
+static const struct cs_dsp_region *cs47l24_dsp_regions[] = {
        cs47l24_dsp2_regions,
        cs47l24_dsp3_regions,
 };
@@ -1234,15 +1234,15 @@ static int cs47l24_probe(struct platform_device *pdev)
 
        for (i = 1; i <= 2; i++) {
                cs47l24->core.adsp[i].part = "cs47l24";
-               cs47l24->core.adsp[i].num = i + 1;
-               cs47l24->core.adsp[i].type = WMFW_ADSP2;
-               cs47l24->core.adsp[i].dev = arizona->dev;
-               cs47l24->core.adsp[i].regmap = arizona->regmap;
+               cs47l24->core.adsp[i].cs_dsp.num = i + 1;
+               cs47l24->core.adsp[i].cs_dsp.type = WMFW_ADSP2;
+               cs47l24->core.adsp[i].cs_dsp.dev = arizona->dev;
+               cs47l24->core.adsp[i].cs_dsp.regmap = arizona->regmap;
 
-               cs47l24->core.adsp[i].base = ARIZONA_DSP1_CONTROL_1 +
+               cs47l24->core.adsp[i].cs_dsp.base = ARIZONA_DSP1_CONTROL_1 +
                                             (0x100 * i);
-               cs47l24->core.adsp[i].mem = cs47l24_dsp_regions[i - 1];
-               cs47l24->core.adsp[i].num_mems =
+               cs47l24->core.adsp[i].cs_dsp.mem = cs47l24_dsp_regions[i - 1];
+               cs47l24->core.adsp[i].cs_dsp.num_mems =
                                ARRAY_SIZE(cs47l24_dsp2_regions);
 
                ret = wm_adsp2_init(&cs47l24->core.adsp[i]);
index 3f04a2a..db2f844 100644 (file)
@@ -37,28 +37,28 @@ struct cs47l35 {
        struct madera_fll fll;
 };
 
-static const struct wm_adsp_region cs47l35_dsp1_regions[] = {
+static const struct cs_dsp_region cs47l35_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x080000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x0e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x0a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x0c0000 },
 };
 
-static const struct wm_adsp_region cs47l35_dsp2_regions[] = {
+static const struct cs_dsp_region cs47l35_dsp2_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x100000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x160000 },
        { .type = WMFW_ADSP2_XM, .base = 0x120000 },
        { .type = WMFW_ADSP2_YM, .base = 0x140000 },
 };
 
-static const struct wm_adsp_region cs47l35_dsp3_regions[] = {
+static const struct cs_dsp_region cs47l35_dsp3_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x180000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x1e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x1a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x1c0000 },
 };
 
-static const struct wm_adsp_region *cs47l35_dsp_regions[] = {
+static const struct cs_dsp_region *cs47l35_dsp_regions[] = {
        cs47l35_dsp1_regions,
        cs47l35_dsp2_regions,
        cs47l35_dsp3_regions,
@@ -1686,15 +1686,15 @@ static int cs47l35_probe(struct platform_device *pdev)
 
        for (i = 0; i < CS47L35_NUM_ADSP; i++) {
                cs47l35->core.adsp[i].part = "cs47l35";
-               cs47l35->core.adsp[i].num = i + 1;
-               cs47l35->core.adsp[i].type = WMFW_ADSP2;
-               cs47l35->core.adsp[i].rev = 1;
-               cs47l35->core.adsp[i].dev = madera->dev;
-               cs47l35->core.adsp[i].regmap = madera->regmap_32bit;
-
-               cs47l35->core.adsp[i].base = wm_adsp2_control_bases[i];
-               cs47l35->core.adsp[i].mem = cs47l35_dsp_regions[i];
-               cs47l35->core.adsp[i].num_mems =
+               cs47l35->core.adsp[i].cs_dsp.num = i + 1;
+               cs47l35->core.adsp[i].cs_dsp.type = WMFW_ADSP2;
+               cs47l35->core.adsp[i].cs_dsp.rev = 1;
+               cs47l35->core.adsp[i].cs_dsp.dev = madera->dev;
+               cs47l35->core.adsp[i].cs_dsp.regmap = madera->regmap_32bit;
+
+               cs47l35->core.adsp[i].cs_dsp.base = wm_adsp2_control_bases[i];
+               cs47l35->core.adsp[i].cs_dsp.mem = cs47l35_dsp_regions[i];
+               cs47l35->core.adsp[i].cs_dsp.num_mems =
                        ARRAY_SIZE(cs47l35_dsp1_regions);
 
                ret = wm_adsp2_init(&cs47l35->core.adsp[i]);
index 748a180..d4fedc5 100644 (file)
@@ -37,56 +37,56 @@ struct cs47l85 {
        struct madera_fll fll[3];
 };
 
-static const struct wm_adsp_region cs47l85_dsp1_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x080000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x0e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x0a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x0c0000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp2_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp2_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x100000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x160000 },
        { .type = WMFW_ADSP2_XM, .base = 0x120000 },
        { .type = WMFW_ADSP2_YM, .base = 0x140000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp3_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp3_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x180000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x1e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x1a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x1c0000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp4_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp4_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x200000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x260000 },
        { .type = WMFW_ADSP2_XM, .base = 0x220000 },
        { .type = WMFW_ADSP2_YM, .base = 0x240000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp5_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp5_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x280000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x2e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x2a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x2c0000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp6_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp6_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x300000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x360000 },
        { .type = WMFW_ADSP2_XM, .base = 0x320000 },
        { .type = WMFW_ADSP2_YM, .base = 0x340000 },
 };
 
-static const struct wm_adsp_region cs47l85_dsp7_regions[] = {
+static const struct cs_dsp_region cs47l85_dsp7_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x380000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x3e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x3a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x3c0000 },
 };
 
-static const struct wm_adsp_region *cs47l85_dsp_regions[] = {
+static const struct cs_dsp_region *cs47l85_dsp_regions[] = {
        cs47l85_dsp1_regions,
        cs47l85_dsp2_regions,
        cs47l85_dsp3_regions,
@@ -2632,15 +2632,15 @@ static int cs47l85_probe(struct platform_device *pdev)
 
        for (i = 0; i < CS47L85_NUM_ADSP; i++) {
                cs47l85->core.adsp[i].part = "cs47l85";
-               cs47l85->core.adsp[i].num = i + 1;
-               cs47l85->core.adsp[i].type = WMFW_ADSP2;
-               cs47l85->core.adsp[i].rev = 1;
-               cs47l85->core.adsp[i].dev = madera->dev;
-               cs47l85->core.adsp[i].regmap = madera->regmap_32bit;
-
-               cs47l85->core.adsp[i].base = wm_adsp2_control_bases[i];
-               cs47l85->core.adsp[i].mem = cs47l85_dsp_regions[i];
-               cs47l85->core.adsp[i].num_mems =
+               cs47l85->core.adsp[i].cs_dsp.num = i + 1;
+               cs47l85->core.adsp[i].cs_dsp.type = WMFW_ADSP2;
+               cs47l85->core.adsp[i].cs_dsp.rev = 1;
+               cs47l85->core.adsp[i].cs_dsp.dev = madera->dev;
+               cs47l85->core.adsp[i].cs_dsp.regmap = madera->regmap_32bit;
+
+               cs47l85->core.adsp[i].cs_dsp.base = wm_adsp2_control_bases[i];
+               cs47l85->core.adsp[i].cs_dsp.mem = cs47l85_dsp_regions[i];
+               cs47l85->core.adsp[i].cs_dsp.num_mems =
                        ARRAY_SIZE(cs47l85_dsp1_regions);
 
                ret = wm_adsp2_init(&cs47l85->core.adsp[i]);
index d2911c0..5aec937 100644 (file)
@@ -37,56 +37,56 @@ struct cs47l90 {
        struct madera_fll fll[3];
 };
 
-static const struct wm_adsp_region cs47l90_dsp1_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x080000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x0e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x0a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x0c0000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp2_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp2_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x100000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x160000 },
        { .type = WMFW_ADSP2_XM, .base = 0x120000 },
        { .type = WMFW_ADSP2_YM, .base = 0x140000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp3_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp3_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x180000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x1e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x1a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x1c0000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp4_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp4_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x200000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x260000 },
        { .type = WMFW_ADSP2_XM, .base = 0x220000 },
        { .type = WMFW_ADSP2_YM, .base = 0x240000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp5_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp5_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x280000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x2e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x2a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x2c0000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp6_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp6_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x300000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x360000 },
        { .type = WMFW_ADSP2_XM, .base = 0x320000 },
        { .type = WMFW_ADSP2_YM, .base = 0x340000 },
 };
 
-static const struct wm_adsp_region cs47l90_dsp7_regions[] = {
+static const struct cs_dsp_region cs47l90_dsp7_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x380000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x3e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x3a0000 },
        { .type = WMFW_ADSP2_YM, .base = 0x3c0000 },
 };
 
-static const struct wm_adsp_region *cs47l90_dsp_regions[] = {
+static const struct cs_dsp_region *cs47l90_dsp_regions[] = {
        cs47l90_dsp1_regions,
        cs47l90_dsp2_regions,
        cs47l90_dsp3_regions,
@@ -2543,18 +2543,18 @@ static int cs47l90_probe(struct platform_device *pdev)
 
        for (i = 0; i < CS47L90_NUM_ADSP; i++) {
                cs47l90->core.adsp[i].part = "cs47l90";
-               cs47l90->core.adsp[i].num = i + 1;
-               cs47l90->core.adsp[i].type = WMFW_ADSP2;
-               cs47l90->core.adsp[i].rev = 2;
-               cs47l90->core.adsp[i].dev = madera->dev;
-               cs47l90->core.adsp[i].regmap = madera->regmap_32bit;
-
-               cs47l90->core.adsp[i].base = cs47l90_dsp_control_bases[i];
-               cs47l90->core.adsp[i].mem = cs47l90_dsp_regions[i];
-               cs47l90->core.adsp[i].num_mems =
+               cs47l90->core.adsp[i].cs_dsp.num = i + 1;
+               cs47l90->core.adsp[i].cs_dsp.type = WMFW_ADSP2;
+               cs47l90->core.adsp[i].cs_dsp.rev = 2;
+               cs47l90->core.adsp[i].cs_dsp.dev = madera->dev;
+               cs47l90->core.adsp[i].cs_dsp.regmap = madera->regmap_32bit;
+
+               cs47l90->core.adsp[i].cs_dsp.base = cs47l90_dsp_control_bases[i];
+               cs47l90->core.adsp[i].cs_dsp.mem = cs47l90_dsp_regions[i];
+               cs47l90->core.adsp[i].cs_dsp.num_mems =
                        ARRAY_SIZE(cs47l90_dsp1_regions);
 
-               cs47l90->core.adsp[i].lock_regions = WM_ADSP2_REGION_1_9;
+               cs47l90->core.adsp[i].cs_dsp.lock_regions = CS_ADSP2_REGION_1_9;
 
                ret = wm_adsp2_init(&cs47l90->core.adsp[i]);
 
index 1a02804..a1b8dcd 100644 (file)
@@ -37,7 +37,7 @@ struct cs47l92 {
        struct madera_fll fll[2];
 };
 
-static const struct wm_adsp_region cs47l92_dsp1_regions[] = {
+static const struct cs_dsp_region cs47l92_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x080000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x0e0000 },
        { .type = WMFW_ADSP2_XM, .base = 0x0a0000 },
@@ -2002,17 +2002,17 @@ static int cs47l92_probe(struct platform_device *pdev)
                dev_warn(&pdev->dev, "Failed to set DSP IRQ wake: %d\n", ret);
 
        cs47l92->core.adsp[0].part = "cs47l92";
-       cs47l92->core.adsp[0].num = 1;
-       cs47l92->core.adsp[0].type = WMFW_ADSP2;
-       cs47l92->core.adsp[0].rev = 2;
-       cs47l92->core.adsp[0].dev = madera->dev;
-       cs47l92->core.adsp[0].regmap = madera->regmap_32bit;
+       cs47l92->core.adsp[0].cs_dsp.num = 1;
+       cs47l92->core.adsp[0].cs_dsp.type = WMFW_ADSP2;
+       cs47l92->core.adsp[0].cs_dsp.rev = 2;
+       cs47l92->core.adsp[0].cs_dsp.dev = madera->dev;
+       cs47l92->core.adsp[0].cs_dsp.regmap = madera->regmap_32bit;
 
-       cs47l92->core.adsp[0].base = MADERA_DSP1_CONFIG_1;
-       cs47l92->core.adsp[0].mem = cs47l92_dsp1_regions;
-       cs47l92->core.adsp[0].num_mems = ARRAY_SIZE(cs47l92_dsp1_regions);
+       cs47l92->core.adsp[0].cs_dsp.base = MADERA_DSP1_CONFIG_1;
+       cs47l92->core.adsp[0].cs_dsp.mem = cs47l92_dsp1_regions;
+       cs47l92->core.adsp[0].cs_dsp.num_mems = ARRAY_SIZE(cs47l92_dsp1_regions);
 
-       cs47l92->core.adsp[0].lock_regions = WM_ADSP2_REGION_1_9;
+       cs47l92->core.adsp[0].cs_dsp.lock_regions = CS_ADSP2_REGION_1_9;
 
        ret = wm_adsp2_init(&cs47l92->core.adsp[0]);
        if (ret != 0)
index 067757d..8f30a3e 100644 (file)
@@ -811,12 +811,9 @@ static int es8316_i2c_probe(struct i2c_client *i2c_client,
        mutex_init(&es8316->lock);
 
        ret = devm_request_threaded_irq(dev, es8316->irq, NULL, es8316_irq,
-                                       IRQF_TRIGGER_HIGH | IRQF_ONESHOT,
+                                       IRQF_TRIGGER_HIGH | IRQF_ONESHOT | IRQF_NO_AUTOEN,
                                        "es8316", es8316);
-       if (ret == 0) {
-               /* Gets re-enabled by es8316_set_jack() */
-               disable_irq(es8316->irq);
-       } else {
+       if (ret) {
                dev_warn(dev, "Failed to get IRQ %d: %d\n", es8316->irq, ret);
                es8316->irq = -ENXIO;
        }
@@ -843,6 +840,7 @@ MODULE_DEVICE_TABLE(of, es8316_of_match);
 #ifdef CONFIG_ACPI
 static const struct acpi_device_id es8316_acpi_match[] = {
        {"ESSX8316", 0},
+       {"ESSX8336", 0},
        {},
 };
 MODULE_DEVICE_TABLE(acpi, es8316_acpi_match);
index 196b068..2bed5cf 100644 (file)
@@ -3531,7 +3531,7 @@ static int rx_macro_probe(struct platform_device *pdev)
        rx->clks[3].id = "npl";
        rx->clks[4].id = "fsgen";
 
-       ret = devm_clk_bulk_get(dev, RX_NUM_CLKS_MAX, rx->clks);
+       ret = devm_clk_bulk_get_optional(dev, RX_NUM_CLKS_MAX, rx->clks);
        if (ret) {
                dev_err(dev, "Error getting RX Clocks (%d)\n", ret);
                return ret;
@@ -3577,6 +3577,7 @@ static int rx_macro_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id rx_macro_dt_match[] = {
+       { .compatible = "qcom,sc7280-lpass-rx-macro" },
        { .compatible = "qcom,sm8250-lpass-rx-macro" },
        { }
 };
index 27a0d5d..a4c0a15 100644 (file)
@@ -272,7 +272,7 @@ struct tx_macro {
 
 static const DECLARE_TLV_DB_SCALE(digital_gain, -8400, 100, -8400);
 
-static const struct reg_default tx_defaults[] = {
+static struct reg_default tx_defaults[] = {
        /* TX Macro */
        { CDC_TX_CLK_RST_CTRL_MCLK_CONTROL, 0x00 },
        { CDC_TX_CLK_RST_CTRL_FS_CNT_CONTROL, 0x00 },
@@ -1674,6 +1674,9 @@ static int tx_macro_component_probe(struct snd_soc_component *comp)
 
        snd_soc_component_update_bits(comp, CDC_TX0_TX_PATH_SEC7, 0x3F,
                                      0x0A);
+       /* Enable swr mic0 and mic1 clock */
+       snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_AMIC0_CTL, 0xFF, 0x00);
+       snd_soc_component_update_bits(comp, CDC_TX_TOP_CSR_SWR_AMIC1_CTL, 0xFF, 0x00);
 
        return 0;
 }
@@ -1778,9 +1781,10 @@ static const struct snd_soc_component_driver tx_macro_component_drv = {
 static int tx_macro_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
+       struct device_node *np = dev->of_node;
        struct tx_macro *tx;
        void __iomem *base;
-       int ret;
+       int ret, reg;
 
        tx = devm_kzalloc(dev, sizeof(*tx), GFP_KERNEL);
        if (!tx)
@@ -1792,7 +1796,7 @@ static int tx_macro_probe(struct platform_device *pdev)
        tx->clks[3].id = "npl";
        tx->clks[4].id = "fsgen";
 
-       ret = devm_clk_bulk_get(dev, TX_NUM_CLKS_MAX, tx->clks);
+       ret = devm_clk_bulk_get_optional(dev, TX_NUM_CLKS_MAX, tx->clks);
        if (ret) {
                dev_err(dev, "Error getting RX Clocks (%d)\n", ret);
                return ret;
@@ -1802,6 +1806,20 @@ static int tx_macro_probe(struct platform_device *pdev)
        if (IS_ERR(base))
                return PTR_ERR(base);
 
+       /* Update defaults for lpass sc7280 */
+       if (of_device_is_compatible(np, "qcom,sc7280-lpass-tx-macro")) {
+               for (reg = 0; reg < ARRAY_SIZE(tx_defaults); reg++) {
+                       switch (tx_defaults[reg].reg) {
+                       case CDC_TX_TOP_CSR_SWR_AMIC0_CTL:
+                       case CDC_TX_TOP_CSR_SWR_AMIC1_CTL:
+                               tx_defaults[reg].def = 0x0E;
+                               break;
+                       default:
+                               break;
+                       }
+               }
+       }
+
        tx->regmap = devm_regmap_init_mmio(dev, base, &tx_regmap_config);
 
        dev_set_drvdata(dev, tx);
@@ -1843,6 +1861,7 @@ static int tx_macro_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id tx_macro_dt_match[] = {
+       { .compatible = "qcom,sc7280-lpass-tx-macro" },
        { .compatible = "qcom,sm8250-lpass-tx-macro" },
        { }
 };
index 56c93f4..11147e3 100644 (file)
@@ -1408,7 +1408,7 @@ static int va_macro_probe(struct platform_device *pdev)
        va->clks[1].id = "dcodec";
        va->clks[2].id = "mclk";
 
-       ret = devm_clk_bulk_get(dev, VA_NUM_CLKS_MAX, va->clks);
+       ret = devm_clk_bulk_get_optional(dev, VA_NUM_CLKS_MAX, va->clks);
        if (ret) {
                dev_err(dev, "Error getting VA Clocks (%d)\n", ret);
                return ret;
@@ -1472,6 +1472,7 @@ static int va_macro_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id va_macro_dt_match[] = {
+       { .compatible = "qcom,sc7280-lpass-va-macro" },
        { .compatible = "qcom,sm8250-lpass-va-macro" },
        {}
 };
index d3ac318..75baf8e 100644 (file)
@@ -2445,6 +2445,7 @@ static int wsa_macro_remove(struct platform_device *pdev)
 }
 
 static const struct of_device_id wsa_macro_dt_match[] = {
+       {.compatible = "qcom,sc7280-lpass-wsa-macro"},
        {.compatible = "qcom,sm8250-lpass-wsa-macro"},
        {}
 };
index f4ed7e0..272041c 100644 (file)
@@ -905,7 +905,7 @@ static int madera_adsp_rate_put(struct snd_kcontrol *kcontrol,
         */
        mutex_lock(&priv->rate_lock);
 
-       if (!madera_can_change_grp_rate(priv, priv->adsp[adsp_num].base)) {
+       if (!madera_can_change_grp_rate(priv, priv->adsp[adsp_num].cs_dsp.base)) {
                dev_warn(priv->madera->dev,
                         "Cannot change '%s' while in use by active audio paths\n",
                         kcontrol->id.name);
@@ -964,7 +964,7 @@ static int madera_write_adsp_clk_setting(struct madera_priv *priv,
        unsigned int mask = MADERA_DSP_RATE_MASK;
        int ret;
 
-       val = priv->adsp_rate_cache[dsp->num - 1] << MADERA_DSP_RATE_SHIFT;
+       val = priv->adsp_rate_cache[dsp->cs_dsp.num - 1] << MADERA_DSP_RATE_SHIFT;
 
        switch (priv->madera->type) {
        case CS47L35:
@@ -978,15 +978,15 @@ static int madera_write_adsp_clk_setting(struct madera_priv *priv,
                /* Configure exact dsp frequency */
                dev_dbg(priv->madera->dev, "Set DSP frequency to 0x%x\n", freq);
 
-               ret = regmap_write(dsp->regmap,
-                                  dsp->base + MADERA_DSP_CONFIG_2_OFFS, freq);
+               ret = regmap_write(dsp->cs_dsp.regmap,
+                                  dsp->cs_dsp.base + MADERA_DSP_CONFIG_2_OFFS, freq);
                if (ret)
                        goto err;
                break;
        }
 
-       ret = regmap_update_bits(dsp->regmap,
-                                dsp->base + MADERA_DSP_CONFIG_1_OFFS,
+       ret = regmap_update_bits(dsp->cs_dsp.regmap,
+                                dsp->cs_dsp.base + MADERA_DSP_CONFIG_1_OFFS,
                                 mask, val);
        if (ret)
                goto err;
@@ -996,7 +996,7 @@ static int madera_write_adsp_clk_setting(struct madera_priv *priv,
        return 0;
 
 err:
-       dev_err(dsp->dev, "Failed to set DSP%d clock: %d\n", dsp->num, ret);
+       dev_err(dsp->cs_dsp.dev, "Failed to set DSP%d clock: %d\n", dsp->cs_dsp.num, ret);
 
        return ret;
 }
@@ -1018,7 +1018,7 @@ int madera_set_adsp_clk(struct madera_priv *priv, int dsp_num,
         * changes are locked out by the domain_group_ref reference count.
         */
 
-       ret = regmap_read(dsp->regmap,  dsp->base, &cur);
+       ret = regmap_read(dsp->cs_dsp.regmap,  dsp->cs_dsp.base, &cur);
        if (ret) {
                dev_err(madera->dev,
                        "Failed to read current DSP rate: %d\n", ret);
@@ -1027,7 +1027,7 @@ int madera_set_adsp_clk(struct madera_priv *priv, int dsp_num,
 
        cur &= MADERA_DSP_RATE_MASK;
 
-       new = priv->adsp_rate_cache[dsp->num - 1] << MADERA_DSP_RATE_SHIFT;
+       new = priv->adsp_rate_cache[dsp->cs_dsp.num - 1] << MADERA_DSP_RATE_SHIFT;
 
        if (new == cur) {
                dev_dbg(madera->dev, "DSP rate not changed\n");
index b392567..d1882cb 100644 (file)
@@ -1021,7 +1021,7 @@ static int max98390_i2c_probe(struct i2c_client *i2c,
        int reg = 0;
 
        struct max98390_priv *max98390 = NULL;
-       struct i2c_adapter *adapter = to_i2c_adapter(i2c->dev.parent);
+       struct i2c_adapter *adapter = i2c->adapter;
 
        ret = i2c_check_functionality(adapter,
                I2C_FUNC_SMBUS_BYTE
diff --git a/sound/soc/codecs/max98520.c b/sound/soc/codecs/max98520.c
new file mode 100644 (file)
index 0000000..bb8649c
--- /dev/null
@@ -0,0 +1,769 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2021, Maxim Integrated
+
+#include <linux/acpi.h>
+#include <linux/delay.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+#include <linux/cdev.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/of.h>
+#include <linux/of_gpio.h>
+#include <sound/tlv.h>
+#include "max98520.h"
+
+static struct reg_default max98520_reg[] = {
+       {MAX98520_R2000_SW_RESET, 0x00},
+       {MAX98520_R2001_STATUS_1, 0x00},
+       {MAX98520_R2002_STATUS_2, 0x00},
+       {MAX98520_R2020_THERM_WARN_THRESH, 0x46},
+       {MAX98520_R2021_THERM_SHDN_THRESH, 0x64},
+       {MAX98520_R2022_THERM_HYSTERESIS, 0x02},
+       {MAX98520_R2023_THERM_FOLDBACK_SET, 0x31},
+       {MAX98520_R2027_THERM_FOLDBACK_EN, 0x01},
+       {MAX98520_R2030_CLK_MON_CTRL, 0x00},
+       {MAX98520_R2037_ERR_MON_CTRL, 0x01},
+       {MAX98520_R2040_PCM_MODE_CFG, 0xC0},
+       {MAX98520_R2041_PCM_CLK_SETUP, 0x04},
+       {MAX98520_R2042_PCM_SR_SETUP, 0x08},
+       {MAX98520_R2043_PCM_RX_SRC1, 0x00},
+       {MAX98520_R2044_PCM_RX_SRC2, 0x00},
+       {MAX98520_R204F_PCM_RX_EN, 0x00},
+       {MAX98520_R2090_AMP_VOL_CTRL, 0x00},
+       {MAX98520_R2091_AMP_PATH_GAIN, 0x03},
+       {MAX98520_R2092_AMP_DSP_CFG, 0x02},
+       {MAX98520_R2094_SSM_CFG, 0x01},
+       {MAX98520_R2095_AMP_CFG, 0xF0},
+       {MAX98520_R209F_AMP_EN, 0x00},
+       {MAX98520_R20B0_ADC_SR, 0x00},
+       {MAX98520_R20B1_ADC_RESOLUTION, 0x00},
+       {MAX98520_R20B2_ADC_PVDD0_CFG, 0x02},
+       {MAX98520_R20B3_ADC_THERMAL_CFG, 0x02},
+       {MAX98520_R20B4_ADC_READBACK_CTRL, 0x00},
+       {MAX98520_R20B5_ADC_READBACK_UPDATE, 0x00},
+       {MAX98520_R20B6_ADC_PVDD_READBACK_MSB, 0x00},
+       {MAX98520_R20B7_ADC_PVDD_READBACK_LSB, 0x00},
+       {MAX98520_R20B8_ADC_TEMP_READBACK_MSB, 0x00},
+       {MAX98520_R20B9_ADC_TEMP_READBACK_LSB, 0x00},
+       {MAX98520_R20BA_ADC_LOW_PVDD_READBACK_MSB, 0xFF},
+       {MAX98520_R20BB_ADC_LOW_READBACK_LSB, 0x01},
+       {MAX98520_R20BC_ADC_HIGH_TEMP_READBACK_MSB, 0x00},
+       {MAX98520_R20BD_ADC_HIGH_TEMP_READBACK_LSB, 0x00},
+       {MAX98520_R20CF_MEAS_ADC_CFG, 0x00},
+       {MAX98520_R20D0_DHT_CFG1, 0x00},
+       {MAX98520_R20D1_LIMITER_CFG1, 0x08},
+       {MAX98520_R20D2_LIMITER_CFG2, 0x00},
+       {MAX98520_R20D3_DHT_CFG2, 0x14},
+       {MAX98520_R20D4_DHT_CFG3, 0x02},
+       {MAX98520_R20D5_DHT_CFG4, 0x04},
+       {MAX98520_R20D6_DHT_HYSTERESIS_CFG, 0x07},
+       {MAX98520_R20D8_DHT_EN, 0x00},
+       {MAX98520_R210E_AUTO_RESTART_BEHAVIOR, 0x00},
+       {MAX98520_R210F_GLOBAL_EN, 0x00},
+       {MAX98520_R21FF_REVISION_ID, 0x00},
+};
+
+static int max98520_dai_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
+{
+       struct snd_soc_component *component = codec_dai->component;
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+       unsigned int format = 0;
+       unsigned int invert = 0;
+
+       dev_dbg(component->dev, "%s: fmt 0x%08X\n", __func__, fmt);
+
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+       case SND_SOC_DAIFMT_NB_NF:
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               invert = MAX98520_PCM_MODE_CFG_PCM_BCLKEDGE;
+               break;
+       default:
+               dev_err(component->dev, "DAI invert mode unsupported\n");
+               return -EINVAL;
+       }
+
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2041_PCM_CLK_SETUP,
+                          MAX98520_PCM_MODE_CFG_PCM_BCLKEDGE,
+                          invert);
+
+       /* interface format */
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_I2S:
+               format = MAX98520_PCM_FORMAT_I2S;
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               format = MAX98520_PCM_FORMAT_LJ;
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               format = MAX98520_PCM_FORMAT_TDM_MODE1;
+               break;
+       case SND_SOC_DAIFMT_DSP_B:
+               format = MAX98520_PCM_FORMAT_TDM_MODE0;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2040_PCM_MODE_CFG,
+                          MAX98520_PCM_MODE_CFG_FORMAT_MASK,
+                          format << MAX98520_PCM_MODE_CFG_FORMAT_SHIFT);
+
+       return 0;
+}
+
+/* BCLKs per LRCLK */
+static const int bclk_sel_table[] = {
+       32, 48, 64, 96, 128, 192, 256, 384, 512, 320,
+};
+
+static int max98520_get_bclk_sel(int bclk)
+{
+       int i;
+       /* match BCLKs per LRCLK */
+       for (i = 0; i < ARRAY_SIZE(bclk_sel_table); i++) {
+               if (bclk_sel_table[i] == bclk)
+                       return i + 2;
+       }
+       return 0;
+}
+
+static int max98520_set_clock(struct snd_soc_component *component,
+                             struct snd_pcm_hw_params *params)
+{
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+       /* BCLK/LRCLK ratio calculation */
+       int blr_clk_ratio = params_channels(params) * max98520->ch_size;
+       int value;
+
+       if (!max98520->tdm_mode) {
+               /* BCLK configuration */
+               value = max98520_get_bclk_sel(blr_clk_ratio);
+               if (!value) {
+                       dev_err(component->dev, "format unsupported %d\n",
+                               params_format(params));
+                       return -EINVAL;
+               }
+
+               regmap_update_bits(max98520->regmap,
+                                  MAX98520_R2041_PCM_CLK_SETUP,
+                                  MAX98520_PCM_CLK_SETUP_BSEL_MASK,
+                                  value);
+       }
+       dev_dbg(component->dev, "%s tdm_mode:%d out\n", __func__, max98520->tdm_mode);
+       return 0;
+}
+
+static int max98520_dai_hw_params(struct snd_pcm_substream *substream,
+                                 struct snd_pcm_hw_params *params,
+                                 struct snd_soc_dai *dai)
+{
+       struct snd_soc_component *component = dai->component;
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+       unsigned int sampling_rate = 0;
+       unsigned int chan_sz = 0;
+
+       /* pcm mode configuration */
+       switch (snd_pcm_format_width(params_format(params))) {
+       case 16:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_16;
+               break;
+       case 24:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_24;
+               break;
+       case 32:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_32;
+               break;
+       default:
+               dev_err(component->dev, "format unsupported %d\n",
+                       params_format(params));
+               goto err;
+       }
+
+       max98520->ch_size = snd_pcm_format_width(params_format(params));
+
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2040_PCM_MODE_CFG,
+                          MAX98520_PCM_MODE_CFG_CHANSZ_MASK, chan_sz);
+
+       dev_dbg(component->dev, "format supported %d",
+               params_format(params));
+
+       /* sampling rate configuration */
+       switch (params_rate(params)) {
+       case 8000:
+               sampling_rate = MAX98520_PCM_SR_8000;
+               break;
+       case 11025:
+               sampling_rate = MAX98520_PCM_SR_11025;
+               break;
+       case 12000:
+               sampling_rate = MAX98520_PCM_SR_12000;
+               break;
+       case 16000:
+               sampling_rate = MAX98520_PCM_SR_16000;
+               break;
+       case 22050:
+               sampling_rate = MAX98520_PCM_SR_22050;
+               break;
+       case 24000:
+               sampling_rate = MAX98520_PCM_SR_24000;
+               break;
+       case 32000:
+               sampling_rate = MAX98520_PCM_SR_32000;
+               break;
+       case 44100:
+               sampling_rate = MAX98520_PCM_SR_44100;
+               break;
+       case 48000:
+               sampling_rate = MAX98520_PCM_SR_48000;
+               break;
+       case 88200:
+               sampling_rate = MAX98520_PCM_SR_88200;
+               break;
+       case 96000:
+               sampling_rate = MAX98520_PCM_SR_96000;
+               break;
+       case 176400:
+               sampling_rate = MAX98520_PCM_SR_176400;
+               break;
+       case 192000:
+               sampling_rate = MAX98520_PCM_SR_192000;
+               break;
+       default:
+               dev_err(component->dev, "rate %d not supported\n",
+                       params_rate(params));
+               goto err;
+       }
+
+       dev_dbg(component->dev, " %s ch_size: %d, sampling rate : %d out\n", __func__,
+               snd_pcm_format_width(params_format(params)), params_rate(params));
+       /* set DAI_SR to correct LRCLK frequency */
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2042_PCM_SR_SETUP,
+                          MAX98520_PCM_SR_MASK,
+                          sampling_rate);
+
+       return max98520_set_clock(component, params);
+err:
+       dev_dbg(component->dev, "%s out error", __func__);
+       return -EINVAL;
+}
+
+static int max98520_dai_tdm_slot(struct snd_soc_dai *dai,
+                                unsigned int tx_mask, unsigned int rx_mask,
+                                int slots, int slot_width)
+{
+       struct snd_soc_component *component = dai->component;
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+       int bsel;
+       unsigned int chan_sz = 0;
+
+       if (!tx_mask && !rx_mask && !slots && !slot_width)
+               max98520->tdm_mode = false;
+       else
+               max98520->tdm_mode = true;
+
+       /* BCLK configuration */
+       bsel = max98520_get_bclk_sel(slots * slot_width);
+       if (bsel == 0) {
+               dev_err(component->dev, "BCLK %d not supported\n",
+                       slots * slot_width);
+               return -EINVAL;
+       }
+
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2041_PCM_CLK_SETUP,
+                          MAX98520_PCM_CLK_SETUP_BSEL_MASK,
+                          bsel);
+
+       /* Channel size configuration */
+       switch (slot_width) {
+       case 16:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_16;
+               break;
+       case 24:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_24;
+               break;
+       case 32:
+               chan_sz = MAX98520_PCM_MODE_CFG_CHANSZ_32;
+               break;
+       default:
+               dev_err(component->dev, "format unsupported %d\n",
+                       slot_width);
+               return -EINVAL;
+       }
+
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2040_PCM_MODE_CFG,
+                          MAX98520_PCM_MODE_CFG_CHANSZ_MASK, chan_sz);
+
+       /* Rx slot configuration */
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2044_PCM_RX_SRC2,
+                          MAX98520_PCM_DMIX_CH0_SRC_MASK,
+                          rx_mask);
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R2044_PCM_RX_SRC2,
+                          MAX98520_PCM_DMIX_CH1_SRC_MASK,
+                          rx_mask << MAX98520_PCM_DMIX_CH1_SHIFT);
+
+       return 0;
+}
+
+#define MAX98520_RATES SNDRV_PCM_RATE_8000_192000
+
+#define MAX98520_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | \
+       SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S32_LE)
+
+static const struct snd_soc_dai_ops max98520_dai_ops = {
+       .set_fmt = max98520_dai_set_fmt,
+       .hw_params = max98520_dai_hw_params,
+       .set_tdm_slot = max98520_dai_tdm_slot,
+};
+
+static int max98520_dac_event(struct snd_soc_dapm_widget *w,
+                             struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               dev_dbg(component->dev, " AMP ON\n");
+
+               regmap_write(max98520->regmap, MAX98520_R209F_AMP_EN, 1);
+               regmap_write(max98520->regmap, MAX98520_R210F_GLOBAL_EN, 1);
+               usleep_range(30000, 31000);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               dev_dbg(component->dev, " AMP OFF\n");
+
+               regmap_write(max98520->regmap, MAX98520_R210F_GLOBAL_EN, 0);
+               regmap_write(max98520->regmap, MAX98520_R209F_AMP_EN, 0);
+               usleep_range(30000, 31000);
+               break;
+       default:
+               return 0;
+       }
+       return 0;
+}
+
+static const char * const max98520_switch_text[] = {
+       "Left", "Right", "LeftRight"};
+
+static const struct soc_enum dai_sel_enum =
+       SOC_ENUM_SINGLE(MAX98520_R2043_PCM_RX_SRC1,
+                       0, 3, max98520_switch_text);
+
+static const struct snd_kcontrol_new max98520_dai_controls =
+       SOC_DAPM_ENUM("DAI Sel", dai_sel_enum);
+
+static const struct snd_kcontrol_new max98520_left_input_mixer_controls[] = {
+       SOC_DAPM_SINGLE("PCM_INPUT_CH0", MAX98520_R2044_PCM_RX_SRC2, 0, 0x0, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH1", MAX98520_R2044_PCM_RX_SRC2, 0, 0x1, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH2", MAX98520_R2044_PCM_RX_SRC2, 0, 0x2, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH3", MAX98520_R2044_PCM_RX_SRC2, 0, 0x3, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH4", MAX98520_R2044_PCM_RX_SRC2, 0, 0x4, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH5", MAX98520_R2044_PCM_RX_SRC2, 0, 0x5, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH6", MAX98520_R2044_PCM_RX_SRC2, 0, 0x6, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH7", MAX98520_R2044_PCM_RX_SRC2, 0, 0x7, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH8", MAX98520_R2044_PCM_RX_SRC2, 0, 0x8, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH9", MAX98520_R2044_PCM_RX_SRC2, 0, 0x9, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH10", MAX98520_R2044_PCM_RX_SRC2, 0, 0xa, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH11", MAX98520_R2044_PCM_RX_SRC2, 0, 0xb, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH12", MAX98520_R2044_PCM_RX_SRC2, 0, 0xc, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH13", MAX98520_R2044_PCM_RX_SRC2, 0, 0xd, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH14", MAX98520_R2044_PCM_RX_SRC2, 0, 0xe, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH15", MAX98520_R2044_PCM_RX_SRC2, 0, 0xf, 0),
+};
+
+static const struct snd_kcontrol_new max98520_right_input_mixer_controls[] = {
+       SOC_DAPM_SINGLE("PCM_INPUT_CH0", MAX98520_R2044_PCM_RX_SRC2, 4, 0x0, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH1", MAX98520_R2044_PCM_RX_SRC2, 4, 0x1, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH2", MAX98520_R2044_PCM_RX_SRC2, 4, 0x2, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH3", MAX98520_R2044_PCM_RX_SRC2, 4, 0x3, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH4", MAX98520_R2044_PCM_RX_SRC2, 4, 0x4, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH5", MAX98520_R2044_PCM_RX_SRC2, 4, 0x5, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH6", MAX98520_R2044_PCM_RX_SRC2, 4, 0x6, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH7", MAX98520_R2044_PCM_RX_SRC2, 4, 0x7, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH8", MAX98520_R2044_PCM_RX_SRC2, 4, 0x8, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH9", MAX98520_R2044_PCM_RX_SRC2, 4, 0x9, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH10", MAX98520_R2044_PCM_RX_SRC2, 4, 0xa, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH11", MAX98520_R2044_PCM_RX_SRC2, 4, 0xb, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH12", MAX98520_R2044_PCM_RX_SRC2, 4, 0xc, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH13", MAX98520_R2044_PCM_RX_SRC2, 4, 0xd, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH14", MAX98520_R2044_PCM_RX_SRC2, 4, 0xe, 0),
+       SOC_DAPM_SINGLE("PCM_INPUT_CH15", MAX98520_R2044_PCM_RX_SRC2, 4, 0xf, 0),
+};
+
+static const struct snd_soc_dapm_widget max98520_dapm_widgets[] = {
+       SND_SOC_DAPM_DAC_E("Amp Enable", "HiFi Playback",
+                          SND_SOC_NOPM, 0, 0, max98520_dac_event,
+       SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
+       SND_SOC_DAPM_MUX("DAI Sel Mux", SND_SOC_NOPM, 0, 0,     &max98520_dai_controls),
+       SND_SOC_DAPM_OUTPUT("BE_OUT"),
+       /* Left Input Selection */
+       SND_SOC_DAPM_MIXER("Left Input Selection", SND_SOC_NOPM, 0, 0,
+                          &max98520_left_input_mixer_controls[0],
+                          ARRAY_SIZE(max98520_left_input_mixer_controls)),
+       /* Right Input Selection */
+       SND_SOC_DAPM_MIXER("Right Input Selection", SND_SOC_NOPM, 0, 0,
+                          &max98520_right_input_mixer_controls[0],
+                          ARRAY_SIZE(max98520_right_input_mixer_controls)),
+};
+
+static const DECLARE_TLV_DB_SCALE(max98520_digital_tlv, -6300, 50, 1);
+static const DECLARE_TLV_DB_SCALE(max98520_spk_tlv, -600, 300, 0);
+
+static const DECLARE_TLV_DB_RANGE(max98520_dht_lim_thresh_tlv,
+       0, 15, TLV_DB_SCALE_ITEM(-1500, 100, 0),
+);
+
+static const DECLARE_TLV_DB_RANGE(max98520_dht_hysteresis_tlv,
+       0, 3, TLV_DB_SCALE_ITEM(100, 100, 0),
+       4, 7, TLV_DB_SCALE_ITEM(600, 200, 0),
+);
+
+static const DECLARE_TLV_DB_RANGE(max98520_dht_rotation_point_tlv,
+       0, 1, TLV_DB_SCALE_ITEM(-1500, 300, 0),
+       2, 4, TLV_DB_SCALE_ITEM(-1000, 200, 0),
+       5, 10, TLV_DB_SCALE_ITEM(-500, 100, 0),
+);
+
+static const DECLARE_TLV_DB_RANGE(max98520_dht_supply_hr_tlv,
+       0, 16, TLV_DB_SCALE_ITEM(-2000, 250, 0),
+);
+
+static const DECLARE_TLV_DB_RANGE(max98520_dht_max_atten_tlv,
+       1, 20, TLV_DB_SCALE_ITEM(-2000, 100, 0),
+);
+
+static const char * const max98520_dht_attack_rate_text[] = {
+       "20us", "40us", "80us", "160us", "320us", "640us",
+       "1.28ms", "2.56ms",     "5.12ms", "10.24ms", "20.48ms", "40.96ms",
+       "81.92ms", "163.84ms"
+};
+
+static SOC_ENUM_SINGLE_DECL(max98520_dht_attack_rate_enum,
+                           MAX98520_R20D4_DHT_CFG3, 0,
+                           max98520_dht_attack_rate_text);
+
+static const char * const max98520_dht_release_rate_text[] = {
+       "2ms", "4ms", "8ms", "16ms", "32ms", "64ms", "128ms", "256ms", "512ms",
+       "1.024s", "2.048s", "4.096s", "8.192s", "16.384s"
+};
+
+static SOC_ENUM_SINGLE_DECL(max98520_dht_release_rate_enum,
+                           MAX98520_R20D5_DHT_CFG4, 0,
+                           max98520_dht_release_rate_text);
+
+static bool max98520_readable_register(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case MAX98520_R2000_SW_RESET:
+       case MAX98520_R2027_THERM_FOLDBACK_EN:
+       case MAX98520_R2030_CLK_MON_CTRL:
+       case MAX98520_R2037_ERR_MON_CTRL:
+       case MAX98520_R204F_PCM_RX_EN:
+       case MAX98520_R209F_AMP_EN:
+       case MAX98520_R20CF_MEAS_ADC_CFG:
+       case MAX98520_R20D8_DHT_EN:
+       case MAX98520_R21FF_REVISION_ID:
+       case MAX98520_R2001_STATUS_1... MAX98520_R2002_STATUS_2:
+       case MAX98520_R2020_THERM_WARN_THRESH... MAX98520_R2023_THERM_FOLDBACK_SET:
+       case MAX98520_R2040_PCM_MODE_CFG... MAX98520_R2044_PCM_RX_SRC2:
+       case MAX98520_R2090_AMP_VOL_CTRL... MAX98520_R2092_AMP_DSP_CFG:
+       case MAX98520_R2094_SSM_CFG... MAX98520_R2095_AMP_CFG:
+       case MAX98520_R20B0_ADC_SR... MAX98520_R20BD_ADC_HIGH_TEMP_READBACK_LSB:
+       case MAX98520_R20D0_DHT_CFG1... MAX98520_R20D6_DHT_HYSTERESIS_CFG:
+       case MAX98520_R210E_AUTO_RESTART_BEHAVIOR... MAX98520_R210F_GLOBAL_EN:
+       case MAX98520_R2161_BOOST_TM1... MAX98520_R2163_BOOST_TM3:
+               return true;
+       default:
+               return false;
+       }
+};
+
+static bool max98520_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case MAX98520_R210F_GLOBAL_EN:
+       case MAX98520_R21FF_REVISION_ID:
+       case MAX98520_R2000_SW_RESET:
+       case MAX98520_R2001_STATUS_1 ... MAX98520_R2002_STATUS_2:
+       case MAX98520_R20B4_ADC_READBACK_CTRL
+               ... MAX98520_R20BD_ADC_HIGH_TEMP_READBACK_LSB:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static const struct snd_kcontrol_new max98520_snd_controls[] = {
+/* Volume */
+SOC_SINGLE_TLV("Digital Volume", MAX98520_R2090_AMP_VOL_CTRL,
+              0, 0x7F, 1, max98520_digital_tlv),
+SOC_SINGLE_TLV("Speaker Volume", MAX98520_R2091_AMP_PATH_GAIN,
+              0, 0x5, 0, max98520_spk_tlv),
+/* Volume Ramp Up/Down Enable*/
+SOC_SINGLE("Ramp Up Switch", MAX98520_R2092_AMP_DSP_CFG,
+          MAX98520_DSP_SPK_VOL_RMPUP_SHIFT, 1, 0),
+SOC_SINGLE("Ramp Down Switch", MAX98520_R2092_AMP_DSP_CFG,
+          MAX98520_DSP_SPK_VOL_RMPDN_SHIFT, 1, 0),
+/* Clock Monitor Enable */
+SOC_SINGLE("CLK Monitor Switch", MAX98520_R2037_ERR_MON_CTRL,
+          MAX98520_CTRL_CMON_EN_SHIFT, 1, 0),
+/* Clock Monitor Config */
+SOC_SINGLE("CLKMON Autorestart Switch", MAX98520_R2030_CLK_MON_CTRL,
+          MAX98520_CMON_AUTORESTART_SHIFT, 1, 0),
+/* Dither Enable */
+SOC_SINGLE("Dither Switch", MAX98520_R2092_AMP_DSP_CFG,
+          MAX98520_DSP_SPK_DITH_EN_SHIFT, 1, 0),
+/* DC Blocker Enable */
+SOC_SINGLE("DC Blocker Switch", MAX98520_R2092_AMP_DSP_CFG,
+          MAX98520_DSP_SPK_DCBLK_EN_SHIFT, 1, 0),
+/* Speaker Safe Mode Enable */
+SOC_SINGLE("Speaker Safemode Switch", MAX98520_R2092_AMP_DSP_CFG,
+          MAX98520_DSP_SPK_SAFE_EN_SHIFT, 1, 0),
+/* AMP SSM Enable */
+SOC_SINGLE("CP Bypass Switch", MAX98520_R2094_SSM_CFG,
+          MAX98520_SSM_RCVR_MODE_SHIFT, 1, 0),
+/* Dynamic Headroom Tracking */
+SOC_SINGLE("DHT Switch", MAX98520_R20D8_DHT_EN, 0, 1, 0),
+SOC_SINGLE("DHT Limiter Mode", MAX98520_R20D2_LIMITER_CFG2,
+          MAX98520_DHT_LIMITER_MODE_SHIFT, 1, 0),
+SOC_SINGLE("DHT Hysteresis Switch", MAX98520_R20D6_DHT_HYSTERESIS_CFG,
+          MAX98520_DHT_HYSTERESIS_SWITCH_SHIFT, 1, 0),
+SOC_SINGLE_TLV("DHT Rot Pnt", MAX98520_R20D0_DHT_CFG1,
+              MAX98520_DHT_VROT_PNT_SHIFT, 10, 1, max98520_dht_rotation_point_tlv),
+SOC_SINGLE_TLV("DHT Supply Headroom", MAX98520_R20D1_LIMITER_CFG1,
+              MAX98520_DHT_SUPPLY_HR_SHIFT, 16, 0, max98520_dht_supply_hr_tlv),
+SOC_SINGLE_TLV("DHT Limiter Threshold", MAX98520_R20D2_LIMITER_CFG2,
+              MAX98520_DHT_LIMITER_THRESHOLD_SHIFT, 0xF, 1, max98520_dht_lim_thresh_tlv),
+SOC_SINGLE_TLV("DHT Max Attenuation", MAX98520_R20D3_DHT_CFG2,
+              MAX98520_DHT_MAX_ATTEN_SHIFT, 20, 1, max98520_dht_max_atten_tlv),
+SOC_SINGLE_TLV("DHT Hysteresis", MAX98520_R20D6_DHT_HYSTERESIS_CFG,
+              MAX98520_DHT_HYSTERESIS_SHIFT, 0x7, 0, max98520_dht_hysteresis_tlv),
+SOC_ENUM("DHT Attack Rate", max98520_dht_attack_rate_enum),
+SOC_ENUM("DHT Release Rate", max98520_dht_release_rate_enum),
+/* ADC configuration */
+SOC_SINGLE("ADC PVDD CH Switch", MAX98520_R20CF_MEAS_ADC_CFG, 0, 1, 0),
+SOC_SINGLE("ADC PVDD FLT Switch", MAX98520_R20B2_ADC_PVDD0_CFG,        MAX98520_FLT_EN_SHIFT, 1, 0),
+SOC_SINGLE("ADC TEMP FLT Switch", MAX98520_R20B3_ADC_THERMAL_CFG, MAX98520_FLT_EN_SHIFT, 1, 0),
+SOC_SINGLE("ADC PVDD MSB", MAX98520_R20B6_ADC_PVDD_READBACK_MSB, 0, 0xFF, 0),
+SOC_SINGLE("ADC PVDD LSB", MAX98520_R20B7_ADC_PVDD_READBACK_LSB, 0, 0x01, 0),
+SOC_SINGLE("ADC TEMP MSB", MAX98520_R20B8_ADC_TEMP_READBACK_MSB, 0, 0xFF, 0),
+SOC_SINGLE("ADC TEMP LSB", MAX98520_R20B9_ADC_TEMP_READBACK_LSB, 0, 0x01, 0),
+};
+
+static const struct snd_soc_dapm_route max98520_audio_map[] = {
+       /* Plabyack */
+       {"DAI Sel Mux", "Left", "Amp Enable"},
+       {"DAI Sel Mux", "Right", "Amp Enable"},
+       {"DAI Sel Mux", "LeftRight", "Amp Enable"},
+       {"BE_OUT", NULL, "DAI Sel Mux"},
+};
+
+static struct snd_soc_dai_driver max98520_dai[] = {
+       {
+               .name = "max98520-aif1",
+               .playback = {
+                       .stream_name = "HiFi Playback",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = MAX98520_RATES,
+                       .formats = MAX98520_FORMATS,
+               },
+               .ops = &max98520_dai_ops,
+       }
+
+};
+
+static int max98520_probe(struct snd_soc_component *component)
+{
+       struct max98520_priv *max98520 =
+               snd_soc_component_get_drvdata(component);
+
+       /* Software Reset */
+       regmap_write(max98520->regmap, MAX98520_R2000_SW_RESET, 1);
+
+       /* L/R mono mix configuration : "DAI Sel" for 0x2043 */
+       regmap_write(max98520->regmap, MAX98520_R2043_PCM_RX_SRC1, 0x2);
+
+       /* PCM input channles configuration : "Left Input Selection" for 0x2044 */
+       /* PCM input channles configuration : "Right Input Selection" for 0x2044 */
+       regmap_write(max98520->regmap, MAX98520_R2044_PCM_RX_SRC2, 0x10);
+
+       /* Enable DC blocker */
+       regmap_update_bits(max98520->regmap, MAX98520_R2092_AMP_DSP_CFG, 1, 1);
+       /* Enable Clock Monitor Auto-restart */
+       regmap_write(max98520->regmap, MAX98520_R2030_CLK_MON_CTRL, 0x1);
+
+       /* set Rx Enable */
+       regmap_update_bits(max98520->regmap,
+                          MAX98520_R204F_PCM_RX_EN,
+                          MAX98520_PCM_RX_EN_MASK,
+                          1);
+
+       return 0;
+}
+
+static int __maybe_unused max98520_suspend(struct device *dev)
+{
+       struct max98520_priv *max98520 = dev_get_drvdata(dev);
+
+       regcache_cache_only(max98520->regmap, true);
+       regcache_mark_dirty(max98520->regmap);
+       return 0;
+}
+
+static int __maybe_unused max98520_resume(struct device *dev)
+{
+       struct max98520_priv *max98520 = dev_get_drvdata(dev);
+
+       regcache_cache_only(max98520->regmap, false);
+       regmap_write(max98520->regmap, MAX98520_R2000_SW_RESET, 1);
+       regcache_sync(max98520->regmap);
+       return 0;
+}
+
+static const struct dev_pm_ops max98520_pm = {
+       SET_SYSTEM_SLEEP_PM_OPS(max98520_suspend, max98520_resume)
+};
+
+static const struct snd_soc_component_driver soc_codec_dev_max98520 = {
+       .probe                  = max98520_probe,
+       .controls               = max98520_snd_controls,
+       .num_controls           = ARRAY_SIZE(max98520_snd_controls),
+       .dapm_widgets           = max98520_dapm_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(max98520_dapm_widgets),
+       .dapm_routes            = max98520_audio_map,
+       .num_dapm_routes        = ARRAY_SIZE(max98520_audio_map),
+       .idle_bias_on           = 1,
+       .use_pmdown_time        = 1,
+       .endianness             = 1,
+       .non_legacy_dai_naming  = 1,
+};
+
+static const struct regmap_config max98520_regmap = {
+       .reg_bits = 16,
+       .val_bits = 8,
+       .max_register = MAX98520_R21FF_REVISION_ID,
+       .reg_defaults  = max98520_reg,
+       .num_reg_defaults = ARRAY_SIZE(max98520_reg),
+       .readable_reg = max98520_readable_register,
+       .volatile_reg = max98520_volatile_reg,
+       .cache_type = REGCACHE_RBTREE,
+};
+
+static void max98520_power_on(struct max98520_priv *max98520, bool poweron)
+{
+       if (max98520->reset_gpio)
+               gpiod_set_value_cansleep(max98520->reset_gpio, !poweron);
+}
+
+static int max98520_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
+{
+       int ret;
+       int reg = 0;
+       struct max98520_priv *max98520;
+       struct i2c_adapter *adapter = to_i2c_adapter(i2c->dev.parent);
+
+       ret = i2c_check_functionality(adapter, I2C_FUNC_SMBUS_BYTE | I2C_FUNC_SMBUS_BYTE_DATA);
+       if (!ret) {
+               dev_err(&i2c->dev, "I2C check functionality failed\n");
+               return -ENXIO;
+       }
+
+       max98520 = devm_kzalloc(&i2c->dev, sizeof(*max98520), GFP_KERNEL);
+
+       if (!max98520)
+               return -ENOMEM;
+
+       i2c_set_clientdata(i2c, max98520);
+
+       /* regmap initialization */
+       max98520->regmap = devm_regmap_init_i2c(i2c, &max98520_regmap);
+       if (IS_ERR(max98520->regmap)) {
+               ret = PTR_ERR(max98520->regmap);
+               dev_err(&i2c->dev, "Failed to allocate regmap: %d\n", ret);
+               return ret;
+       }
+
+       /* Power on device */
+       max98520->reset_gpio = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_HIGH);
+       if (max98520->reset_gpio) {
+               if (IS_ERR(max98520->reset_gpio)) {
+                       ret = PTR_ERR(max98520->reset_gpio);
+                       dev_err(&i2c->dev, "Unable to request GPIO pin: %d.\n", ret);
+                       return ret;
+               }
+
+               max98520_power_on(max98520, 1);
+       }
+
+       /* Check Revision ID */
+       ret = regmap_read(max98520->regmap, MAX98520_R21FF_REVISION_ID, &reg);
+       if (ret < 0) {
+               dev_err(&i2c->dev,
+                       "Failed to read: 0x%02X\n", MAX98520_R21FF_REVISION_ID);
+               return ret;
+       }
+       dev_info(&i2c->dev, "MAX98520 revisionID: 0x%02X\n", reg);
+
+       /* codec registration */
+       ret = devm_snd_soc_register_component(&i2c->dev,
+                                             &soc_codec_dev_max98520,
+                                                 max98520_dai, ARRAY_SIZE(max98520_dai));
+       if (ret < 0)
+               dev_err(&i2c->dev, "Failed to register codec: %d\n", ret);
+
+       return ret;
+}
+
+static const struct i2c_device_id max98520_i2c_id[] = {
+       { "max98520", 0},
+       { },
+};
+
+MODULE_DEVICE_TABLE(i2c, max98520_i2c_id);
+
+#if defined(CONFIG_OF)
+static const struct of_device_id max98520_of_match[] = {
+       { .compatible = "maxim,max98520", },
+       { }
+};
+MODULE_DEVICE_TABLE(of, max98520_of_match);
+#endif
+
+static struct i2c_driver max98520_i2c_driver = {
+       .driver = {
+               .name = "max98520",
+               .of_match_table = of_match_ptr(max98520_of_match),
+               .pm = &max98520_pm,
+       },
+       .probe = max98520_i2c_probe,
+       .id_table = max98520_i2c_id,
+};
+
+module_i2c_driver(max98520_i2c_driver)
+
+MODULE_DESCRIPTION("ALSA SoC MAX98520 driver");
+MODULE_AUTHOR("George Song <george.song@maximintegrated.com>");
+MODULE_LICENSE("GPL");
+
diff --git a/sound/soc/codecs/max98520.h b/sound/soc/codecs/max98520.h
new file mode 100644 (file)
index 0000000..89a95c2
--- /dev/null
@@ -0,0 +1,159 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2021, Maxim Integrated.
+ */
+
+#ifndef _MAX98520_H
+#define _MAX98520_H
+
+#define MAX98520_R2000_SW_RESET 0x2000
+#define MAX98520_R2001_STATUS_1 0x2001
+#define MAX98520_R2002_STATUS_2 0x2002
+#define MAX98520_R2020_THERM_WARN_THRESH 0x2020
+#define MAX98520_R2021_THERM_SHDN_THRESH 0x2021
+#define MAX98520_R2022_THERM_HYSTERESIS 0x2022
+#define MAX98520_R2023_THERM_FOLDBACK_SET 0x2023
+#define MAX98520_R2027_THERM_FOLDBACK_EN 0x2027
+#define MAX98520_R2030_CLK_MON_CTRL 0x2030
+#define MAX98520_R2037_ERR_MON_CTRL 0x2037
+#define MAX98520_R2040_PCM_MODE_CFG    0x2040
+#define MAX98520_R2041_PCM_CLK_SETUP 0x2041
+#define MAX98520_R2042_PCM_SR_SETUP 0x2042
+#define MAX98520_R2043_PCM_RX_SRC1 0x2043
+#define MAX98520_R2044_PCM_RX_SRC2 0x2044
+#define MAX98520_R204F_PCM_RX_EN 0x204F
+#define MAX98520_R2090_AMP_VOL_CTRL 0x2090
+#define MAX98520_R2091_AMP_PATH_GAIN 0x2091
+#define MAX98520_R2092_AMP_DSP_CFG 0x2092
+#define MAX98520_R2094_SSM_CFG 0x2094
+#define MAX98520_R2095_AMP_CFG 0x2095
+#define MAX98520_R209F_AMP_EN 0x209F
+#define MAX98520_R20B0_ADC_SR 0x20B0
+#define MAX98520_R20B1_ADC_RESOLUTION 0x20B1
+#define MAX98520_R20B2_ADC_PVDD0_CFG 0x20B2
+#define MAX98520_R20B3_ADC_THERMAL_CFG 0x20B3
+#define MAX98520_R20B4_ADC_READBACK_CTRL 0x20B4
+#define MAX98520_R20B5_ADC_READBACK_UPDATE 0x20B5
+#define MAX98520_R20B6_ADC_PVDD_READBACK_MSB 0x20B6
+#define MAX98520_R20B7_ADC_PVDD_READBACK_LSB 0x20B7
+#define MAX98520_R20B8_ADC_TEMP_READBACK_MSB 0x20B8
+#define MAX98520_R20B9_ADC_TEMP_READBACK_LSB 0x20B9
+#define MAX98520_R20BA_ADC_LOW_PVDD_READBACK_MSB 0x20BA
+#define MAX98520_R20BB_ADC_LOW_READBACK_LSB 0x20BB
+#define MAX98520_R20BC_ADC_HIGH_TEMP_READBACK_MSB 0x20BC
+#define MAX98520_R20BD_ADC_HIGH_TEMP_READBACK_LSB 0x20BD
+#define MAX98520_R20CF_MEAS_ADC_CFG 0x20CF
+#define MAX98520_R20D0_DHT_CFG1 0x20D0
+#define MAX98520_R20D1_LIMITER_CFG1 0x20D1
+#define MAX98520_R20D2_LIMITER_CFG2 0x20D2
+#define MAX98520_R20D3_DHT_CFG2 0x20D3
+#define MAX98520_R20D4_DHT_CFG3 0x20D4
+#define MAX98520_R20D5_DHT_CFG4 0x20D5
+#define MAX98520_R20D6_DHT_HYSTERESIS_CFG 0x20D6
+#define MAX98520_R20D8_DHT_EN 0x20D8
+#define MAX98520_R210E_AUTO_RESTART_BEHAVIOR 0x210E
+#define MAX98520_R210F_GLOBAL_EN 0x210F
+#define MAX98520_R2161_BOOST_TM1 0x2161
+#define MAX98520_R2162_BOOST_TM2 0x2162
+#define MAX98520_R2163_BOOST_TM3 0x2163
+#define MAX98520_R21FF_REVISION_ID 0x21FF
+
+/* MAX98520_R2030_CLK_MON_CTRL */
+#define MAX98520_CMON_AUTORESTART_SHIFT (0)
+
+/* MAX98520_R2037_ERR_MON_CTRL */
+#define MAX98520_CTRL_CMON_EN_SHIFT (0)
+
+/* MAX98520_R2040_PCM_MODE_CFG */
+#define MAX98520_PCM_MODE_CFG_FORMAT_MASK (0x7 << 3)
+#define MAX98520_PCM_MODE_CFG_FORMAT_SHIFT (3)
+#define MAX98520_PCM_TX_CH_INTERLEAVE_MASK (0x1 << 2)
+#define MAX98520_PCM_FORMAT_I2S (0x0 << 3)
+#define MAX98520_PCM_FORMAT_LJ (0x1 << 3)
+#define MAX98520_PCM_FORMAT_TDM_MODE0 (0x3 << 3)
+#define MAX98520_PCM_FORMAT_TDM_MODE1 (0x4 << 3)
+#define MAX98520_PCM_FORMAT_TDM_MODE2 (0x5 << 3)
+#define MAX98520_PCM_MODE_CFG_CHANSZ_MASK (0x3 << 6)
+#define MAX98520_PCM_MODE_CFG_CHANSZ_16 (0x1 << 6)
+#define MAX98520_PCM_MODE_CFG_CHANSZ_24 (0x2 << 6)
+#define MAX98520_PCM_MODE_CFG_CHANSZ_32 (0x3 << 6)
+
+/* MAX98520_R2041_PCM_CLK_SETUP */
+#define MAX98520_PCM_MODE_CFG_PCM_BCLKEDGE (0x1 << 4)
+#define MAX98520_PCM_CLK_SETUP_BSEL_MASK (0xF << 0)
+
+/* MAX98520_R2042_PCM_SR_SETUP */
+#define MAX98520_PCM_SR_SHIFT (0)
+#define MAX98520_IVADC_SR_SHIFT (4)
+#define MAX98520_PCM_SR_MASK (0xF << MAX98520_PCM_SR_SHIFT)
+#define MAX98520_IVADC_SR_MASK (0xF << MAX98520_IVADC_SR_SHIFT)
+#define MAX98520_PCM_SR_8000 (0x0)
+#define MAX98520_PCM_SR_11025 (0x1)
+#define MAX98520_PCM_SR_12000 (0x2)
+#define MAX98520_PCM_SR_16000 (0x3)
+#define MAX98520_PCM_SR_22050 (0x4)
+#define MAX98520_PCM_SR_24000 (0x5)
+#define MAX98520_PCM_SR_32000 (0x6)
+#define MAX98520_PCM_SR_44100 (0x7)
+#define MAX98520_PCM_SR_48000 (0x8)
+#define MAX98520_PCM_SR_88200 (0x9)
+#define MAX98520_PCM_SR_96000 (0xA)
+#define MAX98520_PCM_SR_176400 (0xB)
+#define MAX98520_PCM_SR_192000 (0xC)
+
+/* MAX98520_R2044_PCM_RX_SRC2 */
+#define MAX98520_PCM_DMIX_CH1_SHIFT (0xF << 0)
+#define MAX98520_PCM_DMIX_CH0_SRC_MASK (0xF << 0)
+#define MAX98520_PCM_DMIX_CH1_SRC_MASK (0xF << MAX98520_PCM_DMIX_CH1_SHIFT)
+
+/* MAX98520_R204F_PCM_RX_EN */
+#define MAX98520_PCM_RX_EN_MASK (0x1 << 0)
+#define MAX98520_PCM_RX_BYP_EN_MASK (0x1 << 1)
+
+/* MAX98520_R2092_AMP_DSP_CFG */
+#define MAX98520_DSP_SPK_DCBLK_EN_SHIFT (0)
+#define MAX98520_DSP_SPK_DITH_EN_SHIFT (1)
+#define MAX98520_DSP_SPK_INVERT_SHIFT (2)
+#define MAX98520_DSP_SPK_VOL_RMPUP_SHIFT (3)
+#define MAX98520_DSP_SPK_VOL_RMPDN_SHIFT (4)
+#define MAX98520_DSP_SPK_SAFE_EN_SHIFT (5)
+
+#define MAX98520_SPK_SAFE_EN_MASK (0x1 << MAX98520_DSP_SPK_SAFE_EN_SHIFT)
+
+/* MAX98520_R2094_SSM_CFG */
+#define MAX98520_SSM_EN_SHIFT (0)
+#define MAX98520_SSM_MOD_SHIFT (1)
+#define MAX98520_SSM_RCVR_MODE_SHIFT (3)
+
+/* MAX98520_R2095_AMP_CFG */
+#define MAX98520_CFG_DYN_MODE_SHIFT (4)
+#define MAX98520_CFG_SPK_MODE_SHIFT (3)
+
+/* MAX98520_R20D0_DHT_CFG1 */
+#define MAX98520_DHT_VROT_PNT_SHIFT    (0)
+
+/* MAX98520_R20D1_LIMITER_CFG1 */
+#define MAX98520_DHT_SUPPLY_HR_SHIFT (0)
+
+/* MAX98520_R20D2_DHT_CFG2 */
+#define MAX98520_DHT_LIMITER_MODE_SHIFT (0)
+#define MAX98520_DHT_LIMITER_THRESHOLD_SHIFT (1)
+
+/* MAX98520_R20D3_DHT_CFG2 */
+#define MAX98520_DHT_MAX_ATTEN_SHIFT (0)
+
+/* MAX98520_R20D6_DHT_HYSTERESIS_CFG */
+#define MAX98520_DHT_HYSTERESIS_SWITCH_SHIFT (0)
+#define MAX98520_DHT_HYSTERESIS_SHIFT (1)
+
+/* MAX98520_R20B2_ADC_PVDD0_CFG, MAX98520_R20B3_ADC_THERMAL_CFG */
+#define MAX98520_FLT_EN_SHIFT (4)
+
+struct max98520_priv {
+       struct regmap *regmap;
+       struct gpio_desc *reset_gpio;
+       unsigned int ch_size;
+       bool tdm_mode;
+};
+#endif
+
index 8b206ee..5ba5f87 100644 (file)
@@ -897,6 +897,19 @@ static int max98927_i2c_probe(struct i2c_client *i2c,
                        "Failed to allocate regmap: %d\n", ret);
                return ret;
        }
+       
+       max98927->reset_gpio 
+               = devm_gpiod_get_optional(&i2c->dev, "reset", GPIOD_OUT_HIGH);
+       if (IS_ERR(max98927->reset_gpio)) {
+               ret = PTR_ERR(max98927->reset_gpio);
+               return dev_err_probe(&i2c->dev, ret, "failed to request GPIO reset pin");
+       }
+
+       if (max98927->reset_gpio) {
+               gpiod_set_value_cansleep(max98927->reset_gpio, 0);
+               /* Wait for i2c port to be ready */
+               usleep_range(5000, 6000);
+       }
 
        /* Check Revision ID */
        ret = regmap_read(max98927->regmap,
@@ -921,6 +934,17 @@ static int max98927_i2c_probe(struct i2c_client *i2c,
        return ret;
 }
 
+static int max98927_i2c_remove(struct i2c_client *i2c)
+{
+       struct max98927_priv *max98927 = i2c_get_clientdata(i2c);
+
+       if (max98927->reset_gpio) {
+               gpiod_set_value_cansleep(max98927->reset_gpio, 1);
+       }
+
+       return 0;
+}
+
 static const struct i2c_device_id max98927_i2c_id[] = {
        { "max98927", 0},
        { },
@@ -952,6 +976,7 @@ static struct i2c_driver max98927_i2c_driver = {
                .pm = &max98927_pm,
        },
        .probe  = max98927_i2c_probe,
+       .remove = max98927_i2c_remove,
        .id_table = max98927_i2c_id,
 };
 
index 05f495d..13f5066 100644 (file)
@@ -255,6 +255,7 @@ struct max98927_priv {
        struct regmap *regmap;
        struct snd_soc_component *component;
        struct max98927_pdata *pdata;
+       struct gpio_desc *reset_gpio; 
        unsigned int spk_gain;
        unsigned int sysclk;
        unsigned int v_l_slot;
index 2d6a4a2..f8532aa 100644 (file)
@@ -2697,7 +2697,7 @@ static int mt6359_codec_probe(struct snd_soc_component *cmpnt)
 
 static void mt6359_codec_remove(struct snd_soc_component *cmpnt)
 {
-       snd_soc_component_exit_regmap(cmpnt);
+       cmpnt->regmap = NULL;
 }
 
 static const DECLARE_TLV_DB_SCALE(hp_playback_tlv, -2200, 100, 0);
diff --git a/sound/soc/codecs/nau8821.c b/sound/soc/codecs/nau8821.c
new file mode 100644 (file)
index 0000000..2de8183
--- /dev/null
@@ -0,0 +1,1714 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// nau8821.c -- Nuvoton NAU88L21 audio codec driver
+//
+// Copyright 2021 Nuvoton Technology Corp.
+// Author: John Hsu <kchsu0@nuvoton.com>
+// Co-author: Seven Lee <wtli@nuvoton.com>
+//
+
+#include <linux/acpi.h>
+#include <linux/clk.h>
+#include <linux/delay.h>
+#include <linux/init.h>
+#include <linux/i2c.h>
+#include <linux/module.h>
+#include <linux/math64.h>
+#include <linux/regmap.h>
+#include <linux/slab.h>
+#include <sound/core.h>
+#include <sound/initval.h>
+#include <sound/jack.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/tlv.h>
+#include "nau8821.h"
+
+#define NAU_FREF_MAX 13500000
+#define NAU_FVCO_MAX 100000000
+#define NAU_FVCO_MIN 90000000
+
+/* the maximum frequency of CLK_ADC and CLK_DAC */
+#define CLK_DA_AD_MAX 6144000
+
+static int nau8821_configure_sysclk(struct nau8821 *nau8821,
+       int clk_id, unsigned int freq);
+
+struct nau8821_fll {
+       int mclk_src;
+       int ratio;
+       int fll_frac;
+       int fll_int;
+       int clk_ref_div;
+};
+
+struct nau8821_fll_attr {
+       unsigned int param;
+       unsigned int val;
+};
+
+/* scaling for mclk from sysclk_src output */
+static const struct nau8821_fll_attr mclk_src_scaling[] = {
+       { 1, 0x0 },
+       { 2, 0x2 },
+       { 4, 0x3 },
+       { 8, 0x4 },
+       { 16, 0x5 },
+       { 32, 0x6 },
+       { 3, 0x7 },
+       { 6, 0xa },
+       { 12, 0xb },
+       { 24, 0xc },
+       { 48, 0xd },
+       { 96, 0xe },
+       { 5, 0xf },
+};
+
+/* ratio for input clk freq */
+static const struct nau8821_fll_attr fll_ratio[] = {
+       { 512000, 0x01 },
+       { 256000, 0x02 },
+       { 128000, 0x04 },
+       { 64000, 0x08 },
+       { 32000, 0x10 },
+       { 8000, 0x20 },
+       { 4000, 0x40 },
+};
+
+static const struct nau8821_fll_attr fll_pre_scalar[] = {
+       { 0, 0x0 },
+       { 1, 0x1 },
+       { 2, 0x2 },
+       { 3, 0x3 },
+};
+
+/* over sampling rate */
+struct nau8821_osr_attr {
+       unsigned int osr;
+       unsigned int clk_src;
+};
+
+static const struct nau8821_osr_attr osr_dac_sel[] = {
+       { 64, 2 },      /* OSR 64, SRC 1/4 */
+       { 256, 0 },     /* OSR 256, SRC 1 */
+       { 128, 1 },     /* OSR 128, SRC 1/2 */
+       { 0, 0 },
+       { 32, 3 },      /* OSR 32, SRC 1/8 */
+};
+
+static const struct nau8821_osr_attr osr_adc_sel[] = {
+       { 32, 3 },      /* OSR 32, SRC 1/8 */
+       { 64, 2 },      /* OSR 64, SRC 1/4 */
+       { 128, 1 },     /* OSR 128, SRC 1/2 */
+       { 256, 0 },     /* OSR 256, SRC 1 */
+};
+
+struct nau8821_dmic_speed {
+       unsigned int param;
+       unsigned int val;
+};
+
+static const struct nau8821_dmic_speed dmic_speed_sel[] = {
+       { 0, 0x0 },     /*SPEED 1, SRC 1 */
+       { 1, 0x1 },     /*SPEED 2, SRC 1/2 */
+       { 2, 0x2 },     /*SPEED 4, SRC 1/4 */
+       { 3, 0x3 },     /*SPEED 8, SRC 1/8 */
+};
+
+static const struct reg_default nau8821_reg_defaults[] = {
+       { NAU8821_R01_ENA_CTRL, 0x00ff },
+       { NAU8821_R03_CLK_DIVIDER, 0x0050 },
+       { NAU8821_R04_FLL1, 0x0 },
+       { NAU8821_R05_FLL2, 0x00bc },
+       { NAU8821_R06_FLL3, 0x0008 },
+       { NAU8821_R07_FLL4, 0x0010 },
+       { NAU8821_R08_FLL5, 0x4000 },
+       { NAU8821_R09_FLL6, 0x6900 },
+       { NAU8821_R0A_FLL7, 0x0031 },
+       { NAU8821_R0B_FLL8, 0x26e9 },
+       { NAU8821_R0D_JACK_DET_CTRL, 0x0 },
+       { NAU8821_R0F_INTERRUPT_MASK, 0x0 },
+       { NAU8821_R12_INTERRUPT_DIS_CTRL, 0xffff },
+       { NAU8821_R13_DMIC_CTRL, 0x0 },
+       { NAU8821_R1A_GPIO12_CTRL, 0x0 },
+       { NAU8821_R1B_TDM_CTRL, 0x0 },
+       { NAU8821_R1C_I2S_PCM_CTRL1, 0x000a },
+       { NAU8821_R1D_I2S_PCM_CTRL2, 0x8010 },
+       { NAU8821_R1E_LEFT_TIME_SLOT, 0x0 },
+       { NAU8821_R1F_RIGHT_TIME_SLOT, 0x0 },
+       { NAU8821_R21_BIQ0_COF1, 0x0 },
+       { NAU8821_R22_BIQ0_COF2, 0x0 },
+       { NAU8821_R23_BIQ0_COF3, 0x0 },
+       { NAU8821_R24_BIQ0_COF4, 0x0 },
+       { NAU8821_R25_BIQ0_COF5, 0x0 },
+       { NAU8821_R26_BIQ0_COF6, 0x0 },
+       { NAU8821_R27_BIQ0_COF7, 0x0 },
+       { NAU8821_R28_BIQ0_COF8, 0x0 },
+       { NAU8821_R29_BIQ0_COF9, 0x0 },
+       { NAU8821_R2A_BIQ0_COF10, 0x0 },
+       { NAU8821_R2B_ADC_RATE, 0x0002 },
+       { NAU8821_R2C_DAC_CTRL1, 0x0082 },
+       { NAU8821_R2D_DAC_CTRL2, 0x0 },
+       { NAU8821_R2F_DAC_DGAIN_CTRL, 0x0 },
+       { NAU8821_R30_ADC_DGAIN_CTRL, 0x0 },
+       { NAU8821_R31_MUTE_CTRL, 0x0 },
+       { NAU8821_R32_HSVOL_CTRL, 0x0 },
+       { NAU8821_R34_DACR_CTRL, 0xcfcf },
+       { NAU8821_R35_ADC_DGAIN_CTRL1, 0xcfcf },
+       { NAU8821_R36_ADC_DRC_KNEE_IP12, 0x1486 },
+       { NAU8821_R37_ADC_DRC_KNEE_IP34, 0x0f12 },
+       { NAU8821_R38_ADC_DRC_SLOPES, 0x25ff },
+       { NAU8821_R39_ADC_DRC_ATKDCY, 0x3457 },
+       { NAU8821_R3A_DAC_DRC_KNEE_IP12, 0x1486 },
+       { NAU8821_R3B_DAC_DRC_KNEE_IP34, 0x0f12 },
+       { NAU8821_R3C_DAC_DRC_SLOPES, 0x25f9 },
+       { NAU8821_R3D_DAC_DRC_ATKDCY, 0x3457 },
+       { NAU8821_R41_BIQ1_COF1, 0x0 },
+       { NAU8821_R42_BIQ1_COF2, 0x0 },
+       { NAU8821_R43_BIQ1_COF3, 0x0 },
+       { NAU8821_R44_BIQ1_COF4, 0x0 },
+       { NAU8821_R45_BIQ1_COF5, 0x0 },
+       { NAU8821_R46_BIQ1_COF6, 0x0 },
+       { NAU8821_R47_BIQ1_COF7, 0x0 },
+       { NAU8821_R48_BIQ1_COF8, 0x0 },
+       { NAU8821_R49_BIQ1_COF9, 0x0 },
+       { NAU8821_R4A_BIQ1_COF10, 0x0 },
+       { NAU8821_R4B_CLASSG_CTRL, 0x0 },
+       { NAU8821_R4C_IMM_MODE_CTRL, 0x0 },
+       { NAU8821_R4D_IMM_RMS_L, 0x0 },
+       { NAU8821_R53_OTPDOUT_1, 0xaad8 },
+       { NAU8821_R54_OTPDOUT_2, 0x0002 },
+       { NAU8821_R55_MISC_CTRL, 0x0 },
+       { NAU8821_R66_BIAS_ADJ, 0x0 },
+       { NAU8821_R68_TRIM_SETTINGS, 0x0 },
+       { NAU8821_R69_ANALOG_CONTROL_1, 0x0 },
+       { NAU8821_R6A_ANALOG_CONTROL_2, 0x0 },
+       { NAU8821_R6B_PGA_MUTE, 0x0 },
+       { NAU8821_R71_ANALOG_ADC_1, 0x0011 },
+       { NAU8821_R72_ANALOG_ADC_2, 0x0020 },
+       { NAU8821_R73_RDAC, 0x0008 },
+       { NAU8821_R74_MIC_BIAS, 0x0006 },
+       { NAU8821_R76_BOOST, 0x0 },
+       { NAU8821_R77_FEPGA, 0x0 },
+       { NAU8821_R7E_PGA_GAIN, 0x0 },
+       { NAU8821_R7F_POWER_UP_CONTROL, 0x0 },
+       { NAU8821_R80_CHARGE_PUMP, 0x0 },
+};
+
+static bool nau8821_readable_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case NAU8821_R00_RESET ... NAU8821_R01_ENA_CTRL:
+       case NAU8821_R03_CLK_DIVIDER ... NAU8821_R0B_FLL8:
+       case NAU8821_R0D_JACK_DET_CTRL:
+       case NAU8821_R0F_INTERRUPT_MASK ... NAU8821_R13_DMIC_CTRL:
+       case NAU8821_R1A_GPIO12_CTRL ... NAU8821_R1F_RIGHT_TIME_SLOT:
+       case NAU8821_R21_BIQ0_COF1 ... NAU8821_R2D_DAC_CTRL2:
+       case NAU8821_R2F_DAC_DGAIN_CTRL ... NAU8821_R32_HSVOL_CTRL:
+       case NAU8821_R34_DACR_CTRL ... NAU8821_R3D_DAC_DRC_ATKDCY:
+       case NAU8821_R41_BIQ1_COF1 ... NAU8821_R4F_FUSE_CTRL3:
+       case NAU8821_R51_FUSE_CTRL1:
+       case NAU8821_R53_OTPDOUT_1 ... NAU8821_R55_MISC_CTRL:
+       case NAU8821_R58_I2C_DEVICE_ID ... NAU8821_R5A_SOFTWARE_RST:
+       case NAU8821_R66_BIAS_ADJ:
+       case NAU8821_R68_TRIM_SETTINGS ... NAU8821_R6B_PGA_MUTE:
+       case NAU8821_R71_ANALOG_ADC_1 ... NAU8821_R74_MIC_BIAS:
+       case NAU8821_R76_BOOST ... NAU8821_R77_FEPGA:
+       case NAU8821_R7E_PGA_GAIN ... NAU8821_R82_GENERAL_STATUS:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool nau8821_writeable_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case NAU8821_R00_RESET ... NAU8821_R01_ENA_CTRL:
+       case NAU8821_R03_CLK_DIVIDER ... NAU8821_R0B_FLL8:
+       case NAU8821_R0D_JACK_DET_CTRL:
+       case NAU8821_R0F_INTERRUPT_MASK:
+       case NAU8821_R11_INT_CLR_KEY_STATUS ... NAU8821_R13_DMIC_CTRL:
+       case NAU8821_R1A_GPIO12_CTRL ... NAU8821_R1F_RIGHT_TIME_SLOT:
+       case NAU8821_R21_BIQ0_COF1 ... NAU8821_R2D_DAC_CTRL2:
+       case NAU8821_R2F_DAC_DGAIN_CTRL ... NAU8821_R32_HSVOL_CTRL:
+       case NAU8821_R34_DACR_CTRL ... NAU8821_R3D_DAC_DRC_ATKDCY:
+       case NAU8821_R41_BIQ1_COF1 ... NAU8821_R4C_IMM_MODE_CTRL:
+       case NAU8821_R4E_FUSE_CTRL2 ... NAU8821_R4F_FUSE_CTRL3:
+       case NAU8821_R51_FUSE_CTRL1:
+       case NAU8821_R55_MISC_CTRL:
+       case NAU8821_R5A_SOFTWARE_RST:
+       case NAU8821_R66_BIAS_ADJ:
+       case NAU8821_R68_TRIM_SETTINGS ... NAU8821_R6B_PGA_MUTE:
+       case NAU8821_R71_ANALOG_ADC_1 ... NAU8821_R74_MIC_BIAS:
+       case NAU8821_R76_BOOST ... NAU8821_R77_FEPGA:
+       case NAU8821_R7E_PGA_GAIN ... NAU8821_R80_CHARGE_PUMP:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool nau8821_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case NAU8821_R00_RESET:
+       case NAU8821_R10_IRQ_STATUS ... NAU8821_R11_INT_CLR_KEY_STATUS:
+       case NAU8821_R21_BIQ0_COF1 ... NAU8821_R2A_BIQ0_COF10:
+       case NAU8821_R41_BIQ1_COF1 ... NAU8821_R4A_BIQ1_COF10:
+       case NAU8821_R4D_IMM_RMS_L:
+       case NAU8821_R53_OTPDOUT_1 ... NAU8821_R54_OTPDOUT_2:
+       case NAU8821_R58_I2C_DEVICE_ID ... NAU8821_R5A_SOFTWARE_RST:
+       case NAU8821_R81_CHARGE_PUMP_INPUT_READ ... NAU8821_R82_GENERAL_STATUS:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static int nau8821_biq_coeff_get(struct snd_kcontrol *kcontrol,
+       struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
+       struct soc_bytes_ext *params = (void *)kcontrol->private_value;
+
+       if (!component->regmap)
+               return -EINVAL;
+
+       regmap_raw_read(component->regmap, NAU8821_R21_BIQ0_COF1,
+               ucontrol->value.bytes.data, params->max);
+
+       return 0;
+}
+
+static int nau8821_biq_coeff_put(struct snd_kcontrol *kcontrol,
+       struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *component = snd_kcontrol_chip(kcontrol);
+       struct soc_bytes_ext *params = (void *)kcontrol->private_value;
+       void *data;
+
+       if (!component->regmap)
+               return -EINVAL;
+
+       data = kmemdup(ucontrol->value.bytes.data,
+               params->max, GFP_KERNEL | GFP_DMA);
+       if (!data)
+               return -ENOMEM;
+
+       regmap_raw_write(component->regmap, NAU8821_R21_BIQ0_COF1,
+               data, params->max);
+
+       kfree(data);
+
+       return 0;
+}
+
+static const char * const nau8821_adc_decimation[] = {
+       "32", "64", "128", "256" };
+
+static const struct soc_enum nau8821_adc_decimation_enum =
+       SOC_ENUM_SINGLE(NAU8821_R2B_ADC_RATE, NAU8821_ADC_SYNC_DOWN_SFT,
+               ARRAY_SIZE(nau8821_adc_decimation), nau8821_adc_decimation);
+
+static const char * const nau8821_dac_oversampl[] = {
+       "64", "256", "128", "", "32" };
+
+static const struct soc_enum nau8821_dac_oversampl_enum =
+       SOC_ENUM_SINGLE(NAU8821_R2C_DAC_CTRL1, NAU8821_DAC_OVERSAMPLE_SFT,
+               ARRAY_SIZE(nau8821_dac_oversampl), nau8821_dac_oversampl);
+
+static const DECLARE_TLV_DB_MINMAX_MUTE(adc_vol_tlv, -6600, 2400);
+static const DECLARE_TLV_DB_MINMAX_MUTE(sidetone_vol_tlv, -4200, 0);
+static const DECLARE_TLV_DB_MINMAX(hp_vol_tlv, -900, 0);
+static const DECLARE_TLV_DB_SCALE(playback_vol_tlv, -6600, 50, 1);
+static const DECLARE_TLV_DB_MINMAX(fepga_gain_tlv, -100, 3600);
+static const DECLARE_TLV_DB_MINMAX_MUTE(crosstalk_vol_tlv, -7000, 2400);
+
+static const struct snd_kcontrol_new nau8821_controls[] = {
+       SOC_DOUBLE_TLV("Mic Volume", NAU8821_R35_ADC_DGAIN_CTRL1,
+               NAU8821_ADCL_CH_VOL_SFT, NAU8821_ADCR_CH_VOL_SFT,
+               0xff, 0, adc_vol_tlv),
+       SOC_DOUBLE_TLV("Headphone Bypass Volume", NAU8821_R30_ADC_DGAIN_CTRL,
+               12, 8, 0x0f, 0, sidetone_vol_tlv),
+       SOC_DOUBLE_TLV("Headphone Volume", NAU8821_R32_HSVOL_CTRL,
+               NAU8821_HPL_VOL_SFT, NAU8821_HPR_VOL_SFT, 0x3, 1, hp_vol_tlv),
+       SOC_DOUBLE_TLV("Digital Playback Volume", NAU8821_R34_DACR_CTRL,
+               NAU8821_DACL_CH_VOL_SFT, NAU8821_DACR_CH_VOL_SFT,
+               0xcf, 0, playback_vol_tlv),
+       SOC_DOUBLE_TLV("Frontend PGA Volume", NAU8821_R7E_PGA_GAIN,
+               NAU8821_PGA_GAIN_L_SFT, NAU8821_PGA_GAIN_R_SFT,
+               37, 0, fepga_gain_tlv),
+       SOC_DOUBLE_TLV("Headphone Crosstalk Volume",
+               NAU8821_R2F_DAC_DGAIN_CTRL,
+               0, 8, 0xff, 0, crosstalk_vol_tlv),
+
+       SOC_ENUM("ADC Decimation Rate", nau8821_adc_decimation_enum),
+       SOC_ENUM("DAC Oversampling Rate", nau8821_dac_oversampl_enum),
+       SND_SOC_BYTES_EXT("BIQ Coefficients", 20,
+               nau8821_biq_coeff_get, nau8821_biq_coeff_put),
+       SOC_SINGLE("ADC Phase Switch", NAU8821_R1B_TDM_CTRL,
+               NAU8821_ADCPHS_SFT, 1, 0),
+};
+
+static const struct snd_kcontrol_new nau8821_dmic_mode_switch =
+       SOC_DAPM_SINGLE("Switch", NAU8821_R13_DMIC_CTRL,
+               NAU8821_DMIC_EN_SFT, 1, 0);
+
+static int dmic_clock_control(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *k, int  event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       int i, speed_selection = -1, clk_adc_src, clk_adc;
+       unsigned int clk_divider_r03;
+
+       /* The DMIC clock is gotten from adc clock divided by
+        * CLK_DMIC_SRC (1, 2, 4, 8). The clock has to be equal or
+        * less than nau8821->dmic_clk_threshold.
+        */
+       regmap_read(nau8821->regmap, NAU8821_R03_CLK_DIVIDER,
+               &clk_divider_r03);
+       clk_adc_src = (clk_divider_r03 & NAU8821_CLK_ADC_SRC_MASK)
+               >> NAU8821_CLK_ADC_SRC_SFT;
+       clk_adc = (nau8821->fs * 256) >> clk_adc_src;
+
+       for (i = 0 ; i < 4 ; i++)
+               if ((clk_adc >> dmic_speed_sel[i].param) <=
+                       nau8821->dmic_clk_threshold) {
+                       speed_selection = dmic_speed_sel[i].val;
+                       break;
+               }
+       if (i == 4)
+               return -EINVAL;
+
+       dev_dbg(nau8821->dev,
+               "clk_adc=%d, dmic_clk_threshold = %d, param=%d, val = %d\n",
+               clk_adc, nau8821->dmic_clk_threshold,
+               dmic_speed_sel[i].param, dmic_speed_sel[i].val);
+       regmap_update_bits(nau8821->regmap, NAU8821_R13_DMIC_CTRL,
+               NAU8821_DMIC_SRC_MASK,
+               (speed_selection << NAU8821_DMIC_SRC_SFT));
+
+       return 0;
+}
+
+static int nau8821_left_adc_event(struct snd_soc_dapm_widget *w,
+       struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               msleep(125);
+               regmap_update_bits(nau8821->regmap, NAU8821_R01_ENA_CTRL,
+                       NAU8821_EN_ADCL, NAU8821_EN_ADCL);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               regmap_update_bits(nau8821->regmap,
+                       NAU8821_R01_ENA_CTRL, NAU8821_EN_ADCL, 0);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int nau8821_right_adc_event(struct snd_soc_dapm_widget *w,
+       struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               msleep(125);
+               regmap_update_bits(nau8821->regmap, NAU8821_R01_ENA_CTRL,
+                       NAU8821_EN_ADCR, NAU8821_EN_ADCR);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               regmap_update_bits(nau8821->regmap,
+                       NAU8821_R01_ENA_CTRL, NAU8821_EN_ADCR, 0);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int nau8821_pump_event(struct snd_soc_dapm_widget *w,
+       struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct nau8821 *nau8821 =
+               snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               /* Prevent startup click by letting charge pump to ramp up */
+               msleep(20);
+               regmap_update_bits(nau8821->regmap, NAU8821_R80_CHARGE_PUMP,
+                       NAU8821_JAMNODCLOW, NAU8821_JAMNODCLOW);
+               break;
+       case SND_SOC_DAPM_PRE_PMD:
+               regmap_update_bits(nau8821->regmap, NAU8821_R80_CHARGE_PUMP,
+                       NAU8821_JAMNODCLOW, 0);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int nau8821_output_dac_event(struct snd_soc_dapm_widget *w,
+       struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component =
+               snd_soc_dapm_to_component(w->dapm);
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               /* Disables the TESTDAC to let DAC signal pass through. */
+               regmap_update_bits(nau8821->regmap, NAU8821_R66_BIAS_ADJ,
+                       NAU8821_BIAS_TESTDAC_EN, 0);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               regmap_update_bits(nau8821->regmap, NAU8821_R66_BIAS_ADJ,
+                       NAU8821_BIAS_TESTDAC_EN, NAU8821_BIAS_TESTDAC_EN);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_dapm_widget nau8821_dapm_widgets[] = {
+       SND_SOC_DAPM_SUPPLY("MICBIAS", NAU8821_R74_MIC_BIAS,
+               NAU8821_MICBIAS_POWERUP_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("DMIC Clock", SND_SOC_NOPM, 0, 0,
+               dmic_clock_control, SND_SOC_DAPM_POST_PMU),
+       SND_SOC_DAPM_ADC("ADCL Power", NULL, NAU8821_R72_ANALOG_ADC_2,
+               NAU8821_POWERUP_ADCL_SFT, 0),
+       SND_SOC_DAPM_ADC("ADCR Power", NULL, NAU8821_R72_ANALOG_ADC_2,
+               NAU8821_POWERUP_ADCR_SFT, 0),
+       SND_SOC_DAPM_PGA_S("Frontend PGA L", 1, NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_PGA_L_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Frontend PGA R", 1, NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_PGA_R_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("ADCL Digital path", 0, NAU8821_R01_ENA_CTRL,
+               NAU8821_EN_ADCL_SFT, 0, nau8821_left_adc_event,
+               SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
+       SND_SOC_DAPM_PGA_S("ADCR Digital path", 0, NAU8821_R01_ENA_CTRL,
+               NAU8821_EN_ADCR_SFT, 0, nau8821_right_adc_event,
+               SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
+       SND_SOC_DAPM_SWITCH("DMIC Enable", SND_SOC_NOPM,
+               0, 0, &nau8821_dmic_mode_switch),
+       SND_SOC_DAPM_AIF_OUT("AIFTX", "Capture", 0, NAU8821_R1D_I2S_PCM_CTRL2,
+               NAU8821_I2S_TRISTATE_SFT, 1),
+       SND_SOC_DAPM_AIF_IN("AIFRX", "Playback", 0, SND_SOC_NOPM, 0, 0),
+
+       SND_SOC_DAPM_PGA_S("ADACL", 2, NAU8821_R73_RDAC,
+               NAU8821_DACL_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("ADACR", 2, NAU8821_R73_RDAC,
+               NAU8821_DACR_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("ADACL Clock", 3, NAU8821_R73_RDAC,
+               NAU8821_DACL_CLK_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("ADACR Clock", 3, NAU8821_R73_RDAC,
+               NAU8821_DACR_CLK_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_DAC("DDACR", NULL, NAU8821_R01_ENA_CTRL,
+               NAU8821_EN_DACR_SFT, 0),
+       SND_SOC_DAPM_DAC("DDACL", NULL, NAU8821_R01_ENA_CTRL,
+               NAU8821_EN_DACL_SFT, 0),
+       SND_SOC_DAPM_PGA_S("HP amp L", 0, NAU8821_R4B_CLASSG_CTRL,
+               NAU8821_CLASSG_LDAC_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("HP amp R", 0, NAU8821_R4B_CLASSG_CTRL,
+               NAU8821_CLASSG_RDAC_EN_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Charge Pump", 1, NAU8821_R80_CHARGE_PUMP,
+               NAU8821_CHANRGE_PUMP_EN_SFT, 0, nau8821_pump_event,
+               SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_PRE_PMD),
+       SND_SOC_DAPM_PGA_S("Output Driver R Stage 1", 4,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_INTEG_R_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output Driver L Stage 1", 4,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_INTEG_L_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output Driver R Stage 2", 5,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_DRV_INSTG_R_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output Driver L Stage 2", 5,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_DRV_INSTG_L_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output Driver R Stage 3", 6,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_MAIN_DRV_R_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output Driver L Stage 3", 6,
+               NAU8821_R7F_POWER_UP_CONTROL,
+               NAU8821_PUP_MAIN_DRV_L_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("Output DACL", 7,
+               NAU8821_R80_CHARGE_PUMP, NAU8821_POWER_DOWN_DACL_SFT,
+               0, nau8821_output_dac_event,
+               SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
+       SND_SOC_DAPM_PGA_S("Output DACR", 7,
+               NAU8821_R80_CHARGE_PUMP, NAU8821_POWER_DOWN_DACR_SFT,
+               0, nau8821_output_dac_event,
+               SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
+
+       /* HPOL/R are ungrounded by disabling 16 Ohm pull-downs on playback */
+       SND_SOC_DAPM_PGA_S("HPOL Pulldown", 8,
+               NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_SPKR_DWN1L_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_PGA_S("HPOR Pulldown", 8,
+               NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_SPKR_DWN1R_SFT, 0, NULL, 0),
+
+       /* High current HPOL/R boost driver */
+       SND_SOC_DAPM_PGA_S("HP Boost Driver", 9,
+               NAU8821_R76_BOOST, NAU8821_HP_BOOST_DIS_SFT, 1, NULL, 0),
+       SND_SOC_DAPM_PGA("Class G", NAU8821_R4B_CLASSG_CTRL,
+               NAU8821_CLASSG_EN_SFT, 0, NULL, 0),
+
+       SND_SOC_DAPM_INPUT("MICL"),
+       SND_SOC_DAPM_INPUT("MICR"),
+       SND_SOC_DAPM_INPUT("DMIC"),
+       SND_SOC_DAPM_OUTPUT("HPOL"),
+       SND_SOC_DAPM_OUTPUT("HPOR"),
+};
+
+static const struct snd_soc_dapm_route nau8821_dapm_routes[] = {
+       {"DMIC Enable", "Switch", "DMIC"},
+       {"DMIC Enable", NULL, "DMIC Clock"},
+
+       {"Frontend PGA L", NULL, "MICL"},
+       {"Frontend PGA R", NULL, "MICR"},
+       {"Frontend PGA L", NULL, "MICBIAS"},
+       {"Frontend PGA R", NULL, "MICBIAS"},
+
+       {"ADCL Power", NULL, "Frontend PGA L"},
+       {"ADCR Power", NULL, "Frontend PGA R"},
+
+       {"ADCL Digital path", NULL, "ADCL Power"},
+       {"ADCR Digital path", NULL, "ADCR Power"},
+       {"ADCL Digital path", NULL, "DMIC Enable"},
+       {"ADCR Digital path", NULL, "DMIC Enable"},
+
+       {"AIFTX", NULL, "ADCL Digital path"},
+       {"AIFTX", NULL, "ADCR Digital path"},
+
+       {"DDACL", NULL, "AIFRX"},
+       {"DDACR", NULL, "AIFRX"},
+
+       {"HP amp L", NULL, "DDACL"},
+       {"HP amp R", NULL, "DDACR"},
+
+       {"Charge Pump", NULL, "HP amp L"},
+       {"Charge Pump", NULL, "HP amp R"},
+
+       {"ADACL", NULL, "Charge Pump"},
+       {"ADACR", NULL, "Charge Pump"},
+       {"ADACL Clock", NULL, "ADACL"},
+       {"ADACR Clock", NULL, "ADACR"},
+
+       {"Output Driver L Stage 1", NULL, "ADACL Clock"},
+       {"Output Driver R Stage 1", NULL, "ADACR Clock"},
+       {"Output Driver L Stage 2", NULL, "Output Driver L Stage 1"},
+       {"Output Driver R Stage 2", NULL, "Output Driver R Stage 1"},
+       {"Output Driver L Stage 3", NULL, "Output Driver L Stage 2"},
+       {"Output Driver R Stage 3", NULL, "Output Driver R Stage 2"},
+       {"Output DACL", NULL, "Output Driver L Stage 3"},
+       {"Output DACR", NULL, "Output Driver R Stage 3"},
+
+       {"HPOL Pulldown", NULL, "Output DACL"},
+       {"HPOR Pulldown", NULL, "Output DACR"},
+       {"HP Boost Driver", NULL, "HPOL Pulldown"},
+       {"HP Boost Driver", NULL, "HPOR Pulldown"},
+
+       {"Class G", NULL, "HP Boost Driver"},
+       {"HPOL", NULL, "Class G"},
+       {"HPOR", NULL, "Class G"},
+};
+
+static int nau8821_clock_check(struct nau8821 *nau8821,
+       int stream, int rate, int osr)
+{
+       int osrate = 0;
+
+       if (stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               if (osr >= ARRAY_SIZE(osr_dac_sel))
+                       return -EINVAL;
+               osrate = osr_dac_sel[osr].osr;
+       } else {
+               if (osr >= ARRAY_SIZE(osr_adc_sel))
+                       return -EINVAL;
+               osrate = osr_adc_sel[osr].osr;
+       }
+
+       if (!osrate || rate * osrate > CLK_DA_AD_MAX) {
+               dev_err(nau8821->dev,
+                       "exceed the maximum frequency of CLK_ADC or CLK_DAC");
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int nau8821_hw_params(struct snd_pcm_substream *substream,
+       struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
+{
+       struct snd_soc_component *component = dai->component;
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       unsigned int val_len = 0, osr, ctrl_val, bclk_fs, clk_div;
+
+       nau8821->fs = params_rate(params);
+       /* CLK_DAC or CLK_ADC = OSR * FS
+        * DAC or ADC clock frequency is defined as Over Sampling Rate (OSR)
+        * multiplied by the audio sample rate (Fs). Note that the OSR and Fs
+        * values must be selected such that the maximum frequency is less
+        * than 6.144 MHz.
+        */
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               regmap_read(nau8821->regmap, NAU8821_R2C_DAC_CTRL1, &osr);
+               osr &= NAU8821_DAC_OVERSAMPLE_MASK;
+               if (nau8821_clock_check(nau8821, substream->stream,
+                       nau8821->fs, osr)) {
+                       return -EINVAL;
+               }
+               regmap_update_bits(nau8821->regmap, NAU8821_R03_CLK_DIVIDER,
+                       NAU8821_CLK_DAC_SRC_MASK,
+                       osr_dac_sel[osr].clk_src << NAU8821_CLK_DAC_SRC_SFT);
+       } else {
+               regmap_read(nau8821->regmap, NAU8821_R2B_ADC_RATE, &osr);
+               osr &= NAU8821_ADC_SYNC_DOWN_MASK;
+               if (nau8821_clock_check(nau8821, substream->stream,
+                       nau8821->fs, osr)) {
+                       return -EINVAL;
+               }
+               regmap_update_bits(nau8821->regmap, NAU8821_R03_CLK_DIVIDER,
+                       NAU8821_CLK_ADC_SRC_MASK,
+                       osr_adc_sel[osr].clk_src << NAU8821_CLK_ADC_SRC_SFT);
+       }
+
+       /* make BCLK and LRC divde configuration if the codec as master. */
+       regmap_read(nau8821->regmap, NAU8821_R1D_I2S_PCM_CTRL2, &ctrl_val);
+       if (ctrl_val & NAU8821_I2S_MS_MASTER) {
+               /* get the bclk and fs ratio */
+               bclk_fs = snd_soc_params_to_bclk(params) / nau8821->fs;
+               if (bclk_fs <= 32)
+                       clk_div = 3;
+               else if (bclk_fs <= 64)
+                       clk_div = 2;
+               else if (bclk_fs <= 128)
+                       clk_div = 1;
+               else {
+                       return -EINVAL;
+               }
+               regmap_update_bits(nau8821->regmap, NAU8821_R1D_I2S_PCM_CTRL2,
+                       NAU8821_I2S_LRC_DIV_MASK | NAU8821_I2S_BLK_DIV_MASK,
+                       (clk_div << NAU8821_I2S_LRC_DIV_SFT) | clk_div);
+       }
+
+       switch (params_width(params)) {
+       case 16:
+               val_len |= NAU8821_I2S_DL_16;
+               break;
+       case 20:
+               val_len |= NAU8821_I2S_DL_20;
+               break;
+       case 24:
+               val_len |= NAU8821_I2S_DL_24;
+               break;
+       case 32:
+               val_len |= NAU8821_I2S_DL_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       regmap_update_bits(nau8821->regmap, NAU8821_R1C_I2S_PCM_CTRL1,
+               NAU8821_I2S_DL_MASK, val_len);
+
+       return 0;
+}
+
+static int nau8821_set_dai_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
+{
+       struct snd_soc_component *component = codec_dai->component;
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       unsigned int ctrl1_val = 0, ctrl2_val = 0;
+
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               ctrl2_val |= NAU8821_I2S_MS_MASTER;
+               break;
+       case SND_SOC_DAIFMT_CBC_CFC:
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+       case SND_SOC_DAIFMT_NB_NF:
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               ctrl1_val |= NAU8821_I2S_BP_INV;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_I2S:
+               ctrl1_val |= NAU8821_I2S_DF_I2S;
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               ctrl1_val |= NAU8821_I2S_DF_LEFT;
+               break;
+       case SND_SOC_DAIFMT_RIGHT_J:
+               ctrl1_val |= NAU8821_I2S_DF_RIGTH;
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               ctrl1_val |= NAU8821_I2S_DF_PCM_AB;
+               break;
+       case SND_SOC_DAIFMT_DSP_B:
+               ctrl1_val |= NAU8821_I2S_DF_PCM_AB;
+               ctrl1_val |= NAU8821_I2S_PCMB_EN;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       regmap_update_bits(nau8821->regmap, NAU8821_R1C_I2S_PCM_CTRL1,
+               NAU8821_I2S_DL_MASK | NAU8821_I2S_DF_MASK |
+               NAU8821_I2S_BP_MASK | NAU8821_I2S_PCMB_MASK, ctrl1_val);
+       regmap_update_bits(nau8821->regmap, NAU8821_R1D_I2S_PCM_CTRL2,
+               NAU8821_I2S_MS_MASK, ctrl2_val);
+
+       return 0;
+}
+
+static int nau8821_digital_mute(struct snd_soc_dai *dai, int mute,
+               int direction)
+{
+       struct snd_soc_component *component = dai->component;
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       unsigned int val = 0;
+
+       if (mute)
+               val = NAU8821_DAC_SOFT_MUTE;
+
+       return regmap_update_bits(nau8821->regmap,
+               NAU8821_R31_MUTE_CTRL, NAU8821_DAC_SOFT_MUTE, val);
+}
+
+static const struct snd_soc_dai_ops nau8821_dai_ops = {
+       .hw_params = nau8821_hw_params,
+       .set_fmt = nau8821_set_dai_fmt,
+       .mute_stream = nau8821_digital_mute,
+};
+
+#define NAU8821_RATES SNDRV_PCM_RATE_8000_192000
+#define NAU8821_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE \
+       | SNDRV_PCM_FMTBIT_S24_3LE | SNDRV_PCM_FMTBIT_S32_LE)
+
+static struct snd_soc_dai_driver nau8821_dai = {
+       .name = NUVOTON_CODEC_DAI,
+       .playback = {
+               .stream_name = "Playback",
+               .channels_min = 1,
+               .channels_max = 2,
+               .rates = NAU8821_RATES,
+               .formats = NAU8821_FORMATS,
+       },
+       .capture = {
+               .stream_name = "Capture",
+               .channels_min = 1,
+               .channels_max = 2,
+               .rates = NAU8821_RATES,
+               .formats = NAU8821_FORMATS,
+       },
+       .ops = &nau8821_dai_ops,
+};
+
+
+static bool nau8821_is_jack_inserted(struct regmap *regmap)
+{
+       bool active_high, is_high;
+       int status, jkdet;
+
+       regmap_read(regmap, NAU8821_R0D_JACK_DET_CTRL, &jkdet);
+       active_high = jkdet & NAU8821_JACK_POLARITY;
+       regmap_read(regmap, NAU8821_R82_GENERAL_STATUS, &status);
+       is_high = status & NAU8821_GPIO2_IN;
+       /* return jack connection status according to jack insertion logic
+        * active high or active low.
+        */
+       return active_high == is_high;
+}
+
+static void nau8821_int_status_clear_all(struct regmap *regmap)
+{
+       int active_irq, clear_irq, i;
+
+       /* Reset the intrruption status from rightmost bit if the corres-
+        * ponding irq event occurs.
+        */
+       regmap_read(regmap, NAU8821_R10_IRQ_STATUS, &active_irq);
+       for (i = 0; i < NAU8821_REG_DATA_LEN; i++) {
+               clear_irq = (0x1 << i);
+               if (active_irq & clear_irq)
+                       regmap_write(regmap,
+                               NAU8821_R11_INT_CLR_KEY_STATUS, clear_irq);
+       }
+}
+
+static void nau8821_eject_jack(struct nau8821 *nau8821)
+{
+       struct snd_soc_dapm_context *dapm = nau8821->dapm;
+       struct regmap *regmap = nau8821->regmap;
+       struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
+
+       /* Detach 2kOhm Resistors from MICBIAS to MICGND */
+       regmap_update_bits(regmap, NAU8821_R74_MIC_BIAS,
+               NAU8821_MICBIAS_JKR2, 0);
+       /* HPL/HPR short to ground */
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_SPKR_DWN1R | NAU8821_SPKR_DWN1L, 0);
+       snd_soc_component_disable_pin(component, "MICBIAS");
+       snd_soc_dapm_sync(dapm);
+
+       /* Clear all interruption status */
+       nau8821_int_status_clear_all(regmap);
+
+       /* Enable the insertion interruption, disable the ejection inter-
+        * ruption, and then bypass de-bounce circuit.
+        */
+       regmap_update_bits(regmap, NAU8821_R12_INTERRUPT_DIS_CTRL,
+               NAU8821_IRQ_EJECT_DIS | NAU8821_IRQ_INSERT_DIS,
+               NAU8821_IRQ_EJECT_DIS);
+       /* Mask unneeded IRQs: 1 - disable, 0 - enable */
+       regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK,
+               NAU8821_IRQ_EJECT_EN | NAU8821_IRQ_INSERT_EN,
+               NAU8821_IRQ_EJECT_EN);
+
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_JACK_DET_DB_BYPASS, NAU8821_JACK_DET_DB_BYPASS);
+
+       /* Close clock for jack type detection at manual mode */
+       if (dapm->bias_level < SND_SOC_BIAS_PREPARE)
+               nau8821_configure_sysclk(nau8821, NAU8821_CLK_DIS, 0);
+
+       /* Recover to normal channel input */
+       regmap_update_bits(regmap, NAU8821_R2B_ADC_RATE,
+                       NAU8821_ADC_R_SRC_EN, 0);
+}
+
+static void nau8821_jdet_work(struct work_struct *work)
+{
+       struct nau8821 *nau8821 =
+               container_of(work, struct nau8821, jdet_work);
+       struct snd_soc_dapm_context *dapm = nau8821->dapm;
+       struct snd_soc_component *component = snd_soc_dapm_to_component(dapm);
+       struct regmap *regmap = nau8821->regmap;
+       int jack_status_reg, mic_detected, event = 0, event_mask = 0;
+
+       snd_soc_component_force_enable_pin(component, "MICBIAS");
+       snd_soc_dapm_sync(dapm);
+       msleep(20);
+
+       regmap_read(regmap, NAU8821_R58_I2C_DEVICE_ID, &jack_status_reg);
+       mic_detected = !(jack_status_reg & NAU8821_KEYDET);
+       if (mic_detected) {
+               dev_dbg(nau8821->dev, "Headset connected\n");
+               event |= SND_JACK_HEADSET;
+
+               /* 2kOhm Resistor from MICBIAS to MICGND1 */
+               regmap_update_bits(regmap, NAU8821_R74_MIC_BIAS,
+                       NAU8821_MICBIAS_JKR2, NAU8821_MICBIAS_JKR2);
+               /* Latch Right Channel Analog data
+                * input into the Right Channel Filter
+                */
+               regmap_update_bits(regmap, NAU8821_R2B_ADC_RATE,
+                       NAU8821_ADC_R_SRC_EN, NAU8821_ADC_R_SRC_EN);
+       } else {
+               dev_dbg(nau8821->dev, "Headphone connected\n");
+               event |= SND_JACK_HEADPHONE;
+               snd_soc_component_disable_pin(component, "MICBIAS");
+               snd_soc_dapm_sync(dapm);
+       }
+       event_mask |= SND_JACK_HEADSET;
+       snd_soc_jack_report(nau8821->jack, event, event_mask);
+}
+
+/* Enable interruptions with internal clock. */
+static void nau8821_setup_inserted_irq(struct nau8821 *nau8821)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       /* Enable internal VCO needed for interruptions */
+       if (nau8821->dapm->bias_level < SND_SOC_BIAS_PREPARE)
+               nau8821_configure_sysclk(nau8821, NAU8821_CLK_INTERNAL, 0);
+
+       /* Chip needs one FSCLK cycle in order to generate interruptions,
+        * as we cannot guarantee one will be provided by the system. Turning
+        * master mode on then off enables us to generate that FSCLK cycle
+        * with a minimum of contention on the clock bus.
+        */
+       regmap_update_bits(regmap, NAU8821_R1D_I2S_PCM_CTRL2,
+               NAU8821_I2S_MS_MASK, NAU8821_I2S_MS_MASTER);
+       regmap_update_bits(regmap, NAU8821_R1D_I2S_PCM_CTRL2,
+               NAU8821_I2S_MS_MASK, NAU8821_I2S_MS_SLAVE);
+
+       /* Not bypass de-bounce circuit */
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_JACK_DET_DB_BYPASS, 0);
+
+       regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK,
+               NAU8821_IRQ_EJECT_EN, 0);
+       regmap_update_bits(regmap, NAU8821_R12_INTERRUPT_DIS_CTRL,
+               NAU8821_IRQ_EJECT_DIS, 0);
+}
+
+static irqreturn_t nau8821_interrupt(int irq, void *data)
+{
+       struct nau8821 *nau8821 = (struct nau8821 *)data;
+       struct regmap *regmap = nau8821->regmap;
+       int active_irq, clear_irq = 0, event = 0, event_mask = 0;
+
+       if (regmap_read(regmap, NAU8821_R10_IRQ_STATUS, &active_irq)) {
+               dev_err(nau8821->dev, "failed to read irq status\n");
+               return IRQ_NONE;
+       }
+
+       dev_dbg(nau8821->dev, "IRQ %d\n", active_irq);
+
+       if ((active_irq & NAU8821_JACK_EJECT_IRQ_MASK) ==
+               NAU8821_JACK_EJECT_DETECTED) {
+               regmap_update_bits(regmap, NAU8821_R71_ANALOG_ADC_1,
+                       NAU8821_MICDET_MASK, NAU8821_MICDET_DIS);
+               nau8821_eject_jack(nau8821);
+               event_mask |= SND_JACK_HEADSET;
+               clear_irq = NAU8821_JACK_EJECT_IRQ_MASK;
+       } else if ((active_irq & NAU8821_JACK_INSERT_IRQ_MASK) ==
+               NAU8821_JACK_INSERT_DETECTED) {
+               regmap_update_bits(regmap, NAU8821_R71_ANALOG_ADC_1,
+                       NAU8821_MICDET_MASK, NAU8821_MICDET_EN);
+               if (nau8821_is_jack_inserted(regmap)) {
+                       /* detect microphone and jack type */
+                       cancel_work_sync(&nau8821->jdet_work);
+                       schedule_work(&nau8821->jdet_work);
+                       /* Turn off insertion interruption at manual mode */
+                       regmap_update_bits(regmap,
+                               NAU8821_R12_INTERRUPT_DIS_CTRL,
+                               NAU8821_IRQ_INSERT_DIS,
+                               NAU8821_IRQ_INSERT_DIS);
+                       regmap_update_bits(regmap,
+                               NAU8821_R0F_INTERRUPT_MASK,
+                               NAU8821_IRQ_INSERT_EN,
+                               NAU8821_IRQ_INSERT_EN);
+                       nau8821_setup_inserted_irq(nau8821);
+               } else {
+                       dev_warn(nau8821->dev,
+                               "Inserted IRQ fired but not connected\n");
+                       nau8821_eject_jack(nau8821);
+               }
+       }
+
+       if (!clear_irq)
+               clear_irq = active_irq;
+       /* clears the rightmost interruption */
+       regmap_write(regmap, NAU8821_R11_INT_CLR_KEY_STATUS, clear_irq);
+
+       if (event_mask)
+               snd_soc_jack_report(nau8821->jack, event, event_mask);
+
+       return IRQ_HANDLED;
+}
+
+static const struct regmap_config nau8821_regmap_config = {
+       .val_bits = NAU8821_REG_DATA_LEN,
+       .reg_bits = NAU8821_REG_ADDR_LEN,
+
+       .max_register = NAU8821_REG_MAX,
+       .readable_reg = nau8821_readable_reg,
+       .writeable_reg = nau8821_writeable_reg,
+       .volatile_reg = nau8821_volatile_reg,
+
+       .cache_type = REGCACHE_RBTREE,
+       .reg_defaults = nau8821_reg_defaults,
+       .num_reg_defaults = ARRAY_SIZE(nau8821_reg_defaults),
+};
+
+static int nau8821_component_probe(struct snd_soc_component *component)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       struct snd_soc_dapm_context *dapm =
+               snd_soc_component_get_dapm(component);
+
+       nau8821->dapm = dapm;
+
+       return 0;
+}
+
+/**
+ * nau8821_calc_fll_param - Calculate FLL parameters.
+ * @fll_in: external clock provided to codec.
+ * @fs: sampling rate.
+ * @fll_param: Pointer to structure of FLL parameters.
+ *
+ * Calculate FLL parameters to configure codec.
+ *
+ * Returns 0 for success or negative error code.
+ */
+static int nau8821_calc_fll_param(unsigned int fll_in,
+       unsigned int fs, struct nau8821_fll *fll_param)
+{
+       u64 fvco, fvco_max;
+       unsigned int fref, i, fvco_sel;
+
+       /* Ensure the reference clock frequency (FREF) is <= 13.5MHz by
+        * dividing freq_in by 1, 2, 4, or 8 using FLL pre-scalar.
+        * FREF = freq_in / NAU8821_FLL_REF_DIV_MASK
+        */
+       for (i = 0; i < ARRAY_SIZE(fll_pre_scalar); i++) {
+               fref = fll_in >> fll_pre_scalar[i].param;
+               if (fref <= NAU_FREF_MAX)
+                       break;
+       }
+       if (i == ARRAY_SIZE(fll_pre_scalar))
+               return -EINVAL;
+       fll_param->clk_ref_div = fll_pre_scalar[i].val;
+
+       /* Choose the FLL ratio based on FREF */
+       for (i = 0; i < ARRAY_SIZE(fll_ratio); i++) {
+               if (fref >= fll_ratio[i].param)
+                       break;
+       }
+       if (i == ARRAY_SIZE(fll_ratio))
+               return -EINVAL;
+       fll_param->ratio = fll_ratio[i].val;
+
+       /* Calculate the frequency of DCO (FDCO) given freq_out = 256 * Fs.
+        * FDCO must be within the 90MHz - 100MHz or the FFL cannot be
+        * guaranteed across the full range of operation.
+        * FDCO = freq_out * 2 * mclk_src_scaling
+        */
+       fvco_max = 0;
+       fvco_sel = ARRAY_SIZE(mclk_src_scaling);
+       for (i = 0; i < ARRAY_SIZE(mclk_src_scaling); i++) {
+               fvco = 256ULL * fs * 2 * mclk_src_scaling[i].param;
+               if (fvco > NAU_FVCO_MIN && fvco < NAU_FVCO_MAX &&
+                       fvco_max < fvco) {
+                       fvco_max = fvco;
+                       fvco_sel = i;
+               }
+       }
+       if (ARRAY_SIZE(mclk_src_scaling) == fvco_sel)
+               return -EINVAL;
+       fll_param->mclk_src = mclk_src_scaling[fvco_sel].val;
+
+       /* Calculate the FLL 10-bit integer input and the FLL 24-bit fractional
+        * input based on FDCO, FREF and FLL ratio.
+        */
+       fvco = div_u64(fvco_max << 24, fref * fll_param->ratio);
+       fll_param->fll_int = (fvco >> 24) & 0x3ff;
+       fll_param->fll_frac = fvco & 0xffffff;
+
+       return 0;
+}
+
+static void nau8821_fll_apply(struct nau8821 *nau8821,
+               struct nau8821_fll *fll_param)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       regmap_update_bits(regmap, NAU8821_R03_CLK_DIVIDER,
+               NAU8821_CLK_SRC_MASK | NAU8821_CLK_MCLK_SRC_MASK,
+               NAU8821_CLK_SRC_MCLK | fll_param->mclk_src);
+       /* Make DSP operate at high speed for better performance. */
+       regmap_update_bits(regmap, NAU8821_R04_FLL1,
+               NAU8821_FLL_RATIO_MASK | NAU8821_ICTRL_LATCH_MASK,
+               fll_param->ratio | (0x6 << NAU8821_ICTRL_LATCH_SFT));
+       /* FLL 24-bit fractional input */
+       regmap_write(regmap, NAU8821_R0A_FLL7,
+               (fll_param->fll_frac >> 16) & 0xff);
+       regmap_write(regmap, NAU8821_R0B_FLL8, fll_param->fll_frac & 0xffff);
+       /* FLL 10-bit integer input */
+       regmap_update_bits(regmap, NAU8821_R06_FLL3,
+               NAU8821_FLL_INTEGER_MASK, fll_param->fll_int);
+       /* FLL pre-scaler */
+       regmap_update_bits(regmap, NAU8821_R07_FLL4,
+               NAU8821_HIGHBW_EN | NAU8821_FLL_REF_DIV_MASK,
+               NAU8821_HIGHBW_EN |
+               (fll_param->clk_ref_div << NAU8821_FLL_REF_DIV_SFT));
+       /* select divided VCO input */
+       regmap_update_bits(regmap, NAU8821_R08_FLL5,
+               NAU8821_FLL_CLK_SW_MASK, NAU8821_FLL_CLK_SW_REF);
+       /* Disable free-running mode */
+       regmap_update_bits(regmap,
+               NAU8821_R09_FLL6, NAU8821_DCO_EN, 0);
+       if (fll_param->fll_frac) {
+               /* set FLL loop filter enable and cutoff frequency at 500Khz */
+               regmap_update_bits(regmap, NAU8821_R08_FLL5,
+                       NAU8821_FLL_PDB_DAC_EN | NAU8821_FLL_LOOP_FTR_EN |
+                       NAU8821_FLL_FTR_SW_MASK,
+                       NAU8821_FLL_PDB_DAC_EN | NAU8821_FLL_LOOP_FTR_EN |
+                       NAU8821_FLL_FTR_SW_FILTER);
+               regmap_update_bits(regmap, NAU8821_R09_FLL6,
+                       NAU8821_SDM_EN | NAU8821_CUTOFF500,
+                       NAU8821_SDM_EN | NAU8821_CUTOFF500);
+       } else {
+               /* disable FLL loop filter and cutoff frequency */
+               regmap_update_bits(regmap, NAU8821_R08_FLL5,
+                       NAU8821_FLL_PDB_DAC_EN | NAU8821_FLL_LOOP_FTR_EN |
+                       NAU8821_FLL_FTR_SW_MASK, NAU8821_FLL_FTR_SW_ACCU);
+               regmap_update_bits(regmap, NAU8821_R09_FLL6,
+                       NAU8821_SDM_EN | NAU8821_CUTOFF500, 0);
+       }
+}
+
+/**
+ * nau8821_set_fll - FLL configuration of nau8821
+ * @component:  codec component
+ * @pll_id:  PLL requested
+ * @source:  clock source
+ * @freq_in:  frequency of input clock source
+ * @freq_out:  must be 256*Fs in order to achieve the best performance
+ *
+ * The FLL function can select BCLK or MCLK as the input clock source.
+ *
+ * Returns 0 if the parameters have been applied successfully
+ * or negative error code.
+ */
+static int nau8821_set_fll(struct snd_soc_component *component,
+       int pll_id, int source, unsigned int freq_in, unsigned int freq_out)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       struct nau8821_fll fll_set_param, *fll_param = &fll_set_param;
+       int ret, fs;
+
+       fs = freq_out >> 8;
+       ret = nau8821_calc_fll_param(freq_in, fs, fll_param);
+       if (ret) {
+               dev_err(nau8821->dev,
+                       "Unsupported input clock %d to output clock %d\n",
+                       freq_in, freq_out);
+               return ret;
+       }
+       dev_dbg(nau8821->dev,
+               "mclk_src=%x ratio=%x fll_frac=%x fll_int=%x clk_ref_div=%x\n",
+               fll_param->mclk_src, fll_param->ratio, fll_param->fll_frac,
+               fll_param->fll_int, fll_param->clk_ref_div);
+
+       nau8821_fll_apply(nau8821, fll_param);
+       mdelay(2);
+       regmap_update_bits(nau8821->regmap, NAU8821_R03_CLK_DIVIDER,
+               NAU8821_CLK_SRC_MASK, NAU8821_CLK_SRC_VCO);
+
+       return 0;
+}
+
+static void nau8821_configure_mclk_as_sysclk(struct regmap *regmap)
+{
+       regmap_update_bits(regmap, NAU8821_R03_CLK_DIVIDER,
+               NAU8821_CLK_SRC_MASK, NAU8821_CLK_SRC_MCLK);
+       regmap_update_bits(regmap, NAU8821_R09_FLL6,
+               NAU8821_DCO_EN, 0);
+       /* Make DSP operate as default setting for power saving. */
+       regmap_update_bits(regmap, NAU8821_R04_FLL1,
+               NAU8821_ICTRL_LATCH_MASK, 0);
+}
+
+static int nau8821_configure_sysclk(struct nau8821 *nau8821,
+       int clk_id, unsigned int freq)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       switch (clk_id) {
+       case NAU8821_CLK_DIS:
+               /* Clock provided externally and disable internal VCO clock */
+               nau8821_configure_mclk_as_sysclk(regmap);
+               break;
+       case NAU8821_CLK_MCLK:
+               nau8821_configure_mclk_as_sysclk(regmap);
+               /* MCLK not changed by clock tree */
+               regmap_update_bits(regmap, NAU8821_R03_CLK_DIVIDER,
+                       NAU8821_CLK_MCLK_SRC_MASK, 0);
+               break;
+       case NAU8821_CLK_INTERNAL:
+               if (nau8821_is_jack_inserted(regmap)) {
+                       regmap_update_bits(regmap, NAU8821_R09_FLL6,
+                               NAU8821_DCO_EN, NAU8821_DCO_EN);
+                       regmap_update_bits(regmap, NAU8821_R03_CLK_DIVIDER,
+                               NAU8821_CLK_SRC_MASK, NAU8821_CLK_SRC_VCO);
+                       /* Decrease the VCO frequency and make DSP operate
+                        * as default setting for power saving.
+                        */
+                       regmap_update_bits(regmap, NAU8821_R03_CLK_DIVIDER,
+                               NAU8821_CLK_MCLK_SRC_MASK, 0xf);
+                       regmap_update_bits(regmap, NAU8821_R04_FLL1,
+                               NAU8821_ICTRL_LATCH_MASK |
+                               NAU8821_FLL_RATIO_MASK, 0x10);
+                       regmap_update_bits(regmap, NAU8821_R09_FLL6,
+                               NAU8821_SDM_EN, NAU8821_SDM_EN);
+               }
+               break;
+       case NAU8821_CLK_FLL_MCLK:
+               /* Higher FLL reference input frequency can only set lower
+                * gain error, such as 0000 for input reference from MCLK
+                * 12.288Mhz.
+                */
+               regmap_update_bits(regmap, NAU8821_R06_FLL3,
+                       NAU8821_FLL_CLK_SRC_MASK | NAU8821_GAIN_ERR_MASK,
+                       NAU8821_FLL_CLK_SRC_MCLK | 0);
+               break;
+       case NAU8821_CLK_FLL_BLK:
+               /* If FLL reference input is from low frequency source,
+                * higher error gain can apply such as 0xf which has
+                * the most sensitive gain error correction threshold,
+                * Therefore, FLL has the most accurate DCO to
+                * target frequency.
+                */
+               regmap_update_bits(regmap, NAU8821_R06_FLL3,
+                       NAU8821_FLL_CLK_SRC_MASK | NAU8821_GAIN_ERR_MASK,
+                       NAU8821_FLL_CLK_SRC_BLK |
+                       (0xf << NAU8821_GAIN_ERR_SFT));
+               break;
+       case NAU8821_CLK_FLL_FS:
+               /* If FLL reference input is from low frequency source,
+                * higher error gain can apply such as 0xf which has
+                * the most sensitive gain error correction threshold,
+                * Therefore, FLL has the most accurate DCO to
+                * target frequency.
+                */
+               regmap_update_bits(regmap, NAU8821_R06_FLL3,
+                       NAU8821_FLL_CLK_SRC_MASK | NAU8821_GAIN_ERR_MASK,
+                       NAU8821_FLL_CLK_SRC_FS |
+                       (0xf << NAU8821_GAIN_ERR_SFT));
+               break;
+       default:
+               dev_err(nau8821->dev, "Invalid clock id (%d)\n", clk_id);
+               return -EINVAL;
+       }
+       nau8821->clk_id = clk_id;
+       dev_dbg(nau8821->dev, "Sysclk is %dHz and clock id is %d\n", freq,
+               nau8821->clk_id);
+
+       return 0;
+}
+
+static int nau8821_set_sysclk(struct snd_soc_component *component, int clk_id,
+       int source, unsigned int freq, int dir)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       return nau8821_configure_sysclk(nau8821, clk_id, freq);
+}
+
+static int nau8821_resume_setup(struct nau8821 *nau8821)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       /* Close clock when jack type detection at manual mode */
+       nau8821_configure_sysclk(nau8821, NAU8821_CLK_DIS, 0);
+       if (nau8821->irq) {
+               /* Clear all interruption status */
+               nau8821_int_status_clear_all(regmap);
+
+               /* Enable both insertion and ejection interruptions, and then
+                * bypass de-bounce circuit.
+                */
+               regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK,
+                       NAU8821_IRQ_EJECT_EN | NAU8821_IRQ_INSERT_EN, 0);
+               regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+                       NAU8821_JACK_DET_DB_BYPASS,
+                       NAU8821_JACK_DET_DB_BYPASS);
+               regmap_update_bits(regmap, NAU8821_R12_INTERRUPT_DIS_CTRL,
+                       NAU8821_IRQ_INSERT_DIS | NAU8821_IRQ_EJECT_DIS, 0);
+       }
+
+       return 0;
+}
+
+static int nau8821_set_bias_level(struct snd_soc_component *component,
+               enum snd_soc_bias_level level)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       struct regmap *regmap = nau8821->regmap;
+
+       switch (level) {
+       case SND_SOC_BIAS_ON:
+               break;
+
+       case SND_SOC_BIAS_PREPARE:
+               break;
+
+       case SND_SOC_BIAS_STANDBY:
+               /* Setup codec configuration after resume */
+               if (snd_soc_component_get_bias_level(component) ==
+                       SND_SOC_BIAS_OFF)
+                       nau8821_resume_setup(nau8821);
+               break;
+
+       case SND_SOC_BIAS_OFF:
+               /* HPL/HPR short to ground */
+               regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+                       NAU8821_SPKR_DWN1R | NAU8821_SPKR_DWN1L, 0);
+               if (nau8821->irq) {
+                       /* Reset the configuration of jack type for detection.
+                        * Detach 2kOhm Resistors from MICBIAS to MICGND1/2.
+                        */
+                       regmap_update_bits(regmap, NAU8821_R74_MIC_BIAS,
+                               NAU8821_MICBIAS_JKR2, 0);
+                       /* Turn off all interruptions before system shutdown.
+                        * Keep theinterruption quiet before resume
+                        * setup completes.
+                        */
+                       regmap_write(regmap,
+                               NAU8821_R12_INTERRUPT_DIS_CTRL, 0xffff);
+                       regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK,
+                               NAU8821_IRQ_EJECT_EN | NAU8821_IRQ_INSERT_EN,
+                               NAU8821_IRQ_EJECT_EN | NAU8821_IRQ_INSERT_EN);
+               }
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
+static int __maybe_unused nau8821_suspend(struct snd_soc_component *component)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       if (nau8821->irq)
+               disable_irq(nau8821->irq);
+       snd_soc_component_force_bias_level(component, SND_SOC_BIAS_OFF);
+       /* Power down codec power; don't support button wakeup */
+       snd_soc_component_disable_pin(component, "MICBIAS");
+       snd_soc_dapm_sync(nau8821->dapm);
+       regcache_cache_only(nau8821->regmap, true);
+       regcache_mark_dirty(nau8821->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused nau8821_resume(struct snd_soc_component *component)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+
+       regcache_cache_only(nau8821->regmap, false);
+       regcache_sync(nau8821->regmap);
+       if (nau8821->irq)
+               enable_irq(nau8821->irq);
+
+       return 0;
+}
+
+static const struct snd_soc_component_driver nau8821_component_driver = {
+       .probe                  = nau8821_component_probe,
+       .set_sysclk             = nau8821_set_sysclk,
+       .set_pll                = nau8821_set_fll,
+       .set_bias_level         = nau8821_set_bias_level,
+       .suspend                = nau8821_suspend,
+       .resume                 = nau8821_resume,
+       .controls               = nau8821_controls,
+       .num_controls           = ARRAY_SIZE(nau8821_controls),
+       .dapm_widgets           = nau8821_dapm_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(nau8821_dapm_widgets),
+       .dapm_routes            = nau8821_dapm_routes,
+       .num_dapm_routes        = ARRAY_SIZE(nau8821_dapm_routes),
+       .suspend_bias_off       = 1,
+       .non_legacy_dai_naming  = 1,
+       .idle_bias_on           = 1,
+       .use_pmdown_time        = 1,
+       .endianness             = 1,
+};
+
+/**
+ * nau8821_enable_jack_detect - Specify a jack for event reporting
+ *
+ * @component:  component to register the jack with
+ * @jack: jack to use to report headset and button events on
+ *
+ * After this function has been called the headset insert/remove and button
+ * events will be routed to the given jack.  Jack can be null to stop
+ * reporting.
+ */
+int nau8821_enable_jack_detect(struct snd_soc_component *component,
+       struct snd_soc_jack *jack)
+{
+       struct nau8821 *nau8821 = snd_soc_component_get_drvdata(component);
+       int ret;
+
+       nau8821->jack = jack;
+       /* Initiate jack detection work queue */
+       INIT_WORK(&nau8821->jdet_work, nau8821_jdet_work);
+       ret = devm_request_threaded_irq(nau8821->dev, nau8821->irq, NULL,
+               nau8821_interrupt, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
+               "nau8821", nau8821);
+       if (ret) {
+               dev_err(nau8821->dev, "Cannot request irq %d (%d)\n",
+                       nau8821->irq, ret);
+               return ret;
+       }
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(nau8821_enable_jack_detect);
+
+static void nau8821_reset_chip(struct regmap *regmap)
+{
+       regmap_write(regmap, NAU8821_R00_RESET, 0xffff);
+       regmap_write(regmap, NAU8821_R00_RESET, 0xffff);
+}
+
+static void nau8821_print_device_properties(struct nau8821 *nau8821)
+{
+       struct device *dev = nau8821->dev;
+
+       dev_dbg(dev, "jkdet-enable:         %d\n", nau8821->jkdet_enable);
+       dev_dbg(dev, "jkdet-pull-enable:    %d\n", nau8821->jkdet_pull_enable);
+       dev_dbg(dev, "jkdet-pull-up:        %d\n", nau8821->jkdet_pull_up);
+       dev_dbg(dev, "jkdet-polarity:       %d\n", nau8821->jkdet_polarity);
+       dev_dbg(dev, "micbias-voltage:      %d\n", nau8821->micbias_voltage);
+       dev_dbg(dev, "vref-impedance:       %d\n", nau8821->vref_impedance);
+       dev_dbg(dev, "jack-insert-debounce: %d\n",
+               nau8821->jack_insert_debounce);
+       dev_dbg(dev, "jack-eject-debounce:  %d\n",
+               nau8821->jack_eject_debounce);
+       dev_dbg(dev, "dmic-clk-threshold:       %d\n",
+               nau8821->dmic_clk_threshold);
+}
+
+static int nau8821_read_device_properties(struct device *dev,
+       struct nau8821 *nau8821)
+{
+       int ret;
+
+       nau8821->jkdet_enable = device_property_read_bool(dev,
+               "nuvoton,jkdet-enable");
+       nau8821->jkdet_pull_enable = device_property_read_bool(dev,
+               "nuvoton,jkdet-pull-enable");
+       nau8821->jkdet_pull_up = device_property_read_bool(dev,
+               "nuvoton,jkdet-pull-up");
+       ret = device_property_read_u32(dev, "nuvoton,jkdet-polarity",
+               &nau8821->jkdet_polarity);
+       if (ret)
+               nau8821->jkdet_polarity = 1;
+       ret = device_property_read_u32(dev, "nuvoton,micbias-voltage",
+               &nau8821->micbias_voltage);
+       if (ret)
+               nau8821->micbias_voltage = 6;
+       ret = device_property_read_u32(dev, "nuvoton,vref-impedance",
+               &nau8821->vref_impedance);
+       if (ret)
+               nau8821->vref_impedance = 2;
+       ret = device_property_read_u32(dev, "nuvoton,jack-insert-debounce",
+               &nau8821->jack_insert_debounce);
+       if (ret)
+               nau8821->jack_insert_debounce = 7;
+       ret = device_property_read_u32(dev, "nuvoton,jack-eject-debounce",
+               &nau8821->jack_eject_debounce);
+       if (ret)
+               nau8821->jack_eject_debounce = 0;
+       ret = device_property_read_u32(dev, "nuvoton,dmic-clk-threshold",
+               &nau8821->dmic_clk_threshold);
+       if (ret)
+               nau8821->dmic_clk_threshold = 3072000;
+
+       return 0;
+}
+
+static void nau8821_init_regs(struct nau8821 *nau8821)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       /* Enable Bias/Vmid */
+       regmap_update_bits(regmap, NAU8821_R66_BIAS_ADJ,
+               NAU8821_BIAS_VMID, NAU8821_BIAS_VMID);
+       regmap_update_bits(regmap, NAU8821_R76_BOOST,
+               NAU8821_GLOBAL_BIAS_EN, NAU8821_GLOBAL_BIAS_EN);
+       /* VMID Tieoff setting and enable TESTDAC.
+        * This sets the analog DAC inputs to a '0' input signal to avoid
+        * any glitches due to power up transients in both the analog and
+        * digital DAC circuit.
+        */
+       regmap_update_bits(regmap, NAU8821_R66_BIAS_ADJ,
+               NAU8821_BIAS_VMID_SEL_MASK | NAU8821_BIAS_TESTDAC_EN,
+               (nau8821->vref_impedance << NAU8821_BIAS_VMID_SEL_SFT) |
+               NAU8821_BIAS_TESTDAC_EN);
+       /* Disable short Frame Sync detection logic */
+       regmap_update_bits(regmap, NAU8821_R1E_LEFT_TIME_SLOT,
+               NAU8821_DIS_FS_SHORT_DET, NAU8821_DIS_FS_SHORT_DET);
+       /* Disable Boost Driver, Automatic Short circuit protection enable */
+       regmap_update_bits(regmap, NAU8821_R76_BOOST,
+               NAU8821_PRECHARGE_DIS | NAU8821_HP_BOOST_DIS |
+               NAU8821_HP_BOOST_G_DIS | NAU8821_SHORT_SHUTDOWN_EN,
+               NAU8821_PRECHARGE_DIS | NAU8821_HP_BOOST_DIS |
+               NAU8821_HP_BOOST_G_DIS | NAU8821_SHORT_SHUTDOWN_EN);
+       /* Class G timer 64ms */
+       regmap_update_bits(regmap, NAU8821_R4B_CLASSG_CTRL,
+               NAU8821_CLASSG_TIMER_MASK,
+               0x20 << NAU8821_CLASSG_TIMER_SFT);
+       /* Class AB bias current to 2x, DAC Capacitor enable MSB/LSB */
+       regmap_update_bits(regmap, NAU8821_R6A_ANALOG_CONTROL_2,
+               NAU8821_HP_NON_CLASSG_CURRENT_2xADJ |
+               NAU8821_DAC_CAPACITOR_MSB | NAU8821_DAC_CAPACITOR_LSB,
+               NAU8821_HP_NON_CLASSG_CURRENT_2xADJ |
+               NAU8821_DAC_CAPACITOR_MSB | NAU8821_DAC_CAPACITOR_LSB);
+       /* Disable DACR/L power */
+       regmap_update_bits(regmap, NAU8821_R80_CHARGE_PUMP,
+               NAU8821_POWER_DOWN_DACR | NAU8821_POWER_DOWN_DACL, 0);
+       /* DAC clock delay 2ns, VREF */
+       regmap_update_bits(regmap, NAU8821_R73_RDAC,
+               NAU8821_DAC_CLK_DELAY_MASK | NAU8821_DAC_VREF_MASK,
+               (0x2 << NAU8821_DAC_CLK_DELAY_SFT) |
+               (0x3 << NAU8821_DAC_VREF_SFT));
+
+       regmap_update_bits(regmap, NAU8821_R74_MIC_BIAS,
+               NAU8821_MICBIAS_VOLTAGE_MASK, nau8821->micbias_voltage);
+       /* Default oversampling/decimations settings are unusable
+        * (audible hiss). Set it to something better.
+        */
+       regmap_update_bits(regmap, NAU8821_R2B_ADC_RATE,
+               NAU8821_ADC_SYNC_DOWN_MASK, NAU8821_ADC_SYNC_DOWN_64);
+       regmap_update_bits(regmap, NAU8821_R2C_DAC_CTRL1,
+               NAU8821_DAC_OVERSAMPLE_MASK, NAU8821_DAC_OVERSAMPLE_64);
+}
+
+static int nau8821_setup_irq(struct nau8821 *nau8821)
+{
+       struct regmap *regmap = nau8821->regmap;
+
+       /* Jack detection */
+       regmap_update_bits(regmap, NAU8821_R1A_GPIO12_CTRL,
+               NAU8821_JKDET_OUTPUT_EN,
+               nau8821->jkdet_enable ? 0 : NAU8821_JKDET_OUTPUT_EN);
+       regmap_update_bits(regmap, NAU8821_R1A_GPIO12_CTRL,
+               NAU8821_JKDET_PULL_EN,
+               nau8821->jkdet_pull_enable ? 0 : NAU8821_JKDET_PULL_EN);
+       regmap_update_bits(regmap, NAU8821_R1A_GPIO12_CTRL,
+               NAU8821_JKDET_PULL_UP,
+               nau8821->jkdet_pull_up ? NAU8821_JKDET_PULL_UP : 0);
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_JACK_POLARITY,
+               /* jkdet_polarity - 1  is for active-low */
+               nau8821->jkdet_polarity ? 0 : NAU8821_JACK_POLARITY);
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_JACK_INSERT_DEBOUNCE_MASK,
+               nau8821->jack_insert_debounce <<
+               NAU8821_JACK_INSERT_DEBOUNCE_SFT);
+       regmap_update_bits(regmap, NAU8821_R0D_JACK_DET_CTRL,
+               NAU8821_JACK_EJECT_DEBOUNCE_MASK,
+               nau8821->jack_eject_debounce <<
+               NAU8821_JACK_EJECT_DEBOUNCE_SFT);
+       /* Pull up IRQ pin */
+       regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK,
+               NAU8821_IRQ_PIN_PULL_UP | NAU8821_IRQ_PIN_PULL_EN |
+               NAU8821_IRQ_OUTPUT_EN, NAU8821_IRQ_PIN_PULL_UP |
+               NAU8821_IRQ_PIN_PULL_EN | NAU8821_IRQ_OUTPUT_EN);
+       /* Disable interruption before codec initiation done */
+       /* Mask unneeded IRQs: 1 - disable, 0 - enable */
+       regmap_update_bits(regmap, NAU8821_R0F_INTERRUPT_MASK, 0x3f5, 0x3f5);
+
+       return 0;
+}
+
+static int nau8821_i2c_probe(struct i2c_client *i2c,
+       const struct i2c_device_id *id)
+{
+       struct device *dev = &i2c->dev;
+       struct nau8821 *nau8821 = dev_get_platdata(&i2c->dev);
+       int ret, value;
+
+       if (!nau8821) {
+               nau8821 = devm_kzalloc(dev, sizeof(*nau8821), GFP_KERNEL);
+               if (!nau8821)
+                       return -ENOMEM;
+               nau8821_read_device_properties(dev, nau8821);
+       }
+       i2c_set_clientdata(i2c, nau8821);
+
+       nau8821->regmap = devm_regmap_init_i2c(i2c, &nau8821_regmap_config);
+       if (IS_ERR(nau8821->regmap))
+               return PTR_ERR(nau8821->regmap);
+
+       nau8821->dev = dev;
+       nau8821->irq = i2c->irq;
+       nau8821_print_device_properties(nau8821);
+
+       nau8821_reset_chip(nau8821->regmap);
+       ret = regmap_read(nau8821->regmap, NAU8821_R58_I2C_DEVICE_ID, &value);
+       if (ret) {
+               dev_err(dev, "Failed to read device id (%d)\n", ret);
+               return ret;
+       }
+       nau8821_init_regs(nau8821);
+
+       if (i2c->irq)
+               nau8821_setup_irq(nau8821);
+
+       ret = devm_snd_soc_register_component(&i2c->dev,
+               &nau8821_component_driver, &nau8821_dai, 1);
+
+       return ret;
+}
+
+static int nau8821_i2c_remove(struct i2c_client *i2c_client)
+{
+       struct nau8821 *nau8821 = i2c_get_clientdata(i2c_client);
+
+       devm_free_irq(nau8821->dev, nau8821->irq, nau8821);
+
+       return 0;
+}
+
+static const struct i2c_device_id nau8821_i2c_ids[] = {
+       { "nau8821", 0 },
+       { }
+};
+MODULE_DEVICE_TABLE(i2c, nau8821_i2c_ids);
+
+#ifdef CONFIG_OF
+static const struct of_device_id nau8821_of_ids[] = {
+       { .compatible = "nuvoton,nau8821", },
+       {}
+};
+MODULE_DEVICE_TABLE(of, nau8821_of_ids);
+#endif
+
+#ifdef CONFIG_ACPI
+static const struct acpi_device_id nau8821_acpi_match[] = {
+       { "NVTN2020", 0 },
+       {},
+};
+MODULE_DEVICE_TABLE(acpi, nau8821_acpi_match);
+#endif
+
+static struct i2c_driver nau8821_driver = {
+       .driver = {
+               .name = "nau8821",
+               .of_match_table = of_match_ptr(nau8821_of_ids),
+               .acpi_match_table = ACPI_PTR(nau8821_acpi_match),
+       },
+       .probe = nau8821_i2c_probe,
+       .remove = nau8821_i2c_remove,
+       .id_table = nau8821_i2c_ids,
+};
+module_i2c_driver(nau8821_driver);
+
+MODULE_DESCRIPTION("ASoC nau8821 driver");
+MODULE_AUTHOR("John Hsu <kchsu0@nuvoton.com>");
+MODULE_AUTHOR("Seven Lee <wtli@nuvoton.com>");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/codecs/nau8821.h b/sound/soc/codecs/nau8821.h
new file mode 100644 (file)
index 0000000..a92edfe
--- /dev/null
@@ -0,0 +1,533 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * NAU88L21 ALSA SoC audio driver
+ *
+ * Copyright 2021 Nuvoton Technology Corp.
+ * Author: John Hsu <kchsu0@nuvoton.com>
+ * Co-author: Seven Lee <wtli@nuvoton.com>
+ */
+
+#ifndef __NAU8821_H__
+#define __NAU8821_H__
+
+#define NAU8821_R00_RESET                      0x00
+#define NAU8821_R01_ENA_CTRL                   0x01
+#define NAU8821_R03_CLK_DIVIDER                        0x03
+#define NAU8821_R04_FLL1                       0x04
+#define NAU8821_R05_FLL2                       0x05
+#define NAU8821_R06_FLL3                       0x06
+#define NAU8821_R07_FLL4                       0x07
+#define NAU8821_R08_FLL5                       0x08
+#define NAU8821_R09_FLL6                       0x09
+#define NAU8821_R0A_FLL7                       0x0a
+#define NAU8821_R0B_FLL8                       0x0b
+#define NAU8821_R0D_JACK_DET_CTRL              0x0d
+#define NAU8821_R0F_INTERRUPT_MASK             0x0f
+#define NAU8821_R10_IRQ_STATUS                 0x10
+#define NAU8821_R11_INT_CLR_KEY_STATUS          0x11
+#define NAU8821_R12_INTERRUPT_DIS_CTRL          0x12
+#define NAU8821_R13_DMIC_CTRL                   0x13
+#define NAU8821_R1A_GPIO12_CTRL                 0x1a
+#define NAU8821_R1B_TDM_CTRL                   0x1b
+#define NAU8821_R1C_I2S_PCM_CTRL1              0x1c
+#define NAU8821_R1D_I2S_PCM_CTRL2              0x1d
+#define NAU8821_R1E_LEFT_TIME_SLOT             0x1e
+#define NAU8821_R1F_RIGHT_TIME_SLOT            0x1f
+#define NAU8821_R21_BIQ0_COF1                  0x21
+#define NAU8821_R22_BIQ0_COF2                  0x22
+#define NAU8821_R23_BIQ0_COF3                  0x23
+#define NAU8821_R24_BIQ0_COF4                  0x24
+#define NAU8821_R25_BIQ0_COF5                  0x25
+#define NAU8821_R26_BIQ0_COF6                  0x26
+#define NAU8821_R27_BIQ0_COF7                  0x27
+#define NAU8821_R28_BIQ0_COF8                  0x28
+#define NAU8821_R29_BIQ0_COF9                  0x29
+#define NAU8821_R2A_BIQ0_COF10                 0x2a
+#define NAU8821_R2B_ADC_RATE                   0x2b
+#define NAU8821_R2C_DAC_CTRL1                  0x2c
+#define NAU8821_R2D_DAC_CTRL2                  0x2d
+#define NAU8821_R2F_DAC_DGAIN_CTRL             0x2f
+#define NAU8821_R30_ADC_DGAIN_CTRL             0x30
+#define NAU8821_R31_MUTE_CTRL                  0x31
+#define NAU8821_R32_HSVOL_CTRL                 0x32
+#define NAU8821_R34_DACR_CTRL                  0x34
+#define NAU8821_R35_ADC_DGAIN_CTRL1            0x35
+#define NAU8821_R36_ADC_DRC_KNEE_IP12          0x36
+#define NAU8821_R37_ADC_DRC_KNEE_IP34          0x37
+#define NAU8821_R38_ADC_DRC_SLOPES             0x38
+#define NAU8821_R39_ADC_DRC_ATKDCY             0x39
+#define NAU8821_R3A_DAC_DRC_KNEE_IP12          0x3a
+#define NAU8821_R3B_DAC_DRC_KNEE_IP34          0x3b
+#define NAU8821_R3C_DAC_DRC_SLOPES             0x3c
+#define NAU8821_R3D_DAC_DRC_ATKDCY             0x3d
+#define NAU8821_R41_BIQ1_COF1                  0x41
+#define NAU8821_R42_BIQ1_COF2                  0x42
+#define NAU8821_R43_BIQ1_COF3                  0x43
+#define NAU8821_R44_BIQ1_COF4                  0x44
+#define NAU8821_R45_BIQ1_COF5                  0x45
+#define NAU8821_R46_BIQ1_COF6                  0x46
+#define NAU8821_R47_BIQ1_COF7                  0x47
+#define NAU8821_R48_BIQ1_COF8                  0x48
+#define NAU8821_R49_BIQ1_COF9                  0x49
+#define NAU8821_R4A_BIQ1_COF10                 0x4a
+#define NAU8821_R4B_CLASSG_CTRL                        0x4b
+#define NAU8821_R4C_IMM_MODE_CTRL              0x4c
+#define NAU8821_R4D_IMM_RMS_L                  0x4d
+#define NAU8821_R4E_FUSE_CTRL2                 0x4e
+#define NAU8821_R4F_FUSE_CTRL3                 0x4f
+#define NAU8821_R51_FUSE_CTRL1                 0x51
+#define NAU8821_R53_OTPDOUT_1                  0x53
+#define NAU8821_R54_OTPDOUT_2                  0x54
+#define NAU8821_R55_MISC_CTRL                  0x55
+#define NAU8821_R58_I2C_DEVICE_ID              0x58
+#define NAU8821_R59_SARDOUT_RAM_STATUS         0x59
+#define NAU8821_R5A_SOFTWARE_RST               0x5a
+#define NAU8821_R66_BIAS_ADJ                   0x66
+#define NAU8821_R68_TRIM_SETTINGS              0x68
+#define NAU8821_R69_ANALOG_CONTROL_1           0x69
+#define NAU8821_R6A_ANALOG_CONTROL_2           0x6a
+#define NAU8821_R6B_PGA_MUTE                   0x6b
+#define NAU8821_R71_ANALOG_ADC_1               0x71
+#define NAU8821_R72_ANALOG_ADC_2               0x72
+#define NAU8821_R73_RDAC                       0x73
+#define NAU8821_R74_MIC_BIAS                   0x74
+#define NAU8821_R76_BOOST                      0x76
+#define NAU8821_R77_FEPGA                      0x77
+#define NAU8821_R7E_PGA_GAIN                   0x7e
+#define NAU8821_R7F_POWER_UP_CONTROL           0x7f
+#define NAU8821_R80_CHARGE_PUMP                        0x80
+#define NAU8821_R81_CHARGE_PUMP_INPUT_READ     0x81
+#define NAU8821_R82_GENERAL_STATUS             0x82
+#define NAU8821_REG_MAX                         NAU8821_R82_GENERAL_STATUS
+/* 16-bit control register address, and 16-bits control register data */
+#define NAU8821_REG_ADDR_LEN                   16
+#define NAU8821_REG_DATA_LEN                   16
+
+/* ENA_CTRL (0x01) */
+#define NAU8821_CLK_DAC_INV_SFT                14
+#define NAU8821_CLK_DAC_INV            (0x1 << NAU8821_CLK_DAC_INV)
+#define NAU8821_EN_DACR_SFT            11
+#define NAU8821_EN_DACR                        (0x1 << NAU8821_EN_DACR_SFT)
+#define NAU8821_EN_DACL_SFT            10
+#define NAU8821_EN_DACL                        (0x1 << NAU8821_EN_DACL_SFT)
+#define NAU8821_EN_ADCR_SFT            9
+#define NAU8821_EN_ADCR                        (0x1 << NAU8821_EN_ADCR_SFT)
+#define NAU8821_EN_ADCL_SFT            8
+#define NAU8821_EN_ADCL                        (0x1 << NAU8821_EN_ADCL_SFT)
+#define NAU8821_EN_ADC_CLK_SFT         7
+#define NAU8821_EN_ADC_CLK             (0x1 << NAU8821_EN_ADC_CLK_SFT)
+#define NAU8821_EN_DAC_CLK_SFT         6
+#define NAU8821_EN_DAC_CLK             (0x1 << NAU8821_EN_DAC_CLK_SFT)
+#define NAU8821_EN_I2S_CLK_SFT         4
+#define NAU8821_EN_I2S_CLK             (0x1 << NAU8821_EN_I2S_CLK_SFT)
+#define NAU8821_EN_DRC_CLK_SFT         0
+#define NAU8821_EN_DRC_CLK             (0x1 << NAU8821_EN_DRC_CLK_SFT)
+
+/* CLK_DIVIDER (0x03) */
+#define NAU8821_CLK_SRC_SFT            15
+#define NAU8821_CLK_SRC_MASK           (0x1 << NAU8821_CLK_SRC_SFT)
+#define NAU8821_CLK_SRC_VCO            (0x1 << NAU8821_CLK_SRC_SFT)
+#define NAU8821_CLK_SRC_MCLK           (0x0 << NAU8821_CLK_SRC_SFT)
+#define NAU8821_CLK_CODEC_SRC_SFT      13
+#define NAU8821_CLK_CODEC_SRC_MASK     (0x1 << NAU8821_CLK_CODEC_SRC_SFT)
+#define NAU8821_CLK_CODEC_SRC_VCO      (0x1 << NAU8821_CLK_CODEC_SRC_SFT)
+#define NAU8821_CLK_CODEC_SRC_MCLK     (0x0 << NAU8821_CLK_CODEC_SRC_SFT)
+#define NAU8821_CLK_ADC_SRC_SFT                6
+#define NAU8821_CLK_ADC_SRC_MASK       (0x3 << NAU8821_CLK_ADC_SRC_SFT)
+#define NAU8821_CLK_DAC_SRC_SFT                4
+#define NAU8821_CLK_DAC_SRC_MASK       (0x3 << NAU8821_CLK_DAC_SRC_SFT)
+#define NAU8821_CLK_MCLK_SRC_MASK      0xf
+
+/* FLL1 (0x04) */
+#define NAU8821_ICTRL_LATCH_SFT                10
+#define NAU8821_ICTRL_LATCH_MASK       (0x7 << NAU8821_ICTRL_LATCH_SFT)
+#define NAU8821_FLL_RATIO_MASK         0x7f
+
+/* FLL3 (0x06) */
+#define NAU8821_GAIN_ERR_SFT           12
+#define NAU8821_GAIN_ERR_MASK          (0xf << NAU8821_GAIN_ERR_SFT)
+#define NAU8821_FLL_CLK_SRC_SFT                10
+#define NAU8821_FLL_CLK_SRC_MASK       (0x3 << NAU8821_FLL_CLK_SRC_SFT)
+#define NAU8821_FLL_CLK_SRC_FS         (0x3 << NAU8821_FLL_CLK_SRC_SFT)
+#define NAU8821_FLL_CLK_SRC_BLK                (0x2 << NAU8821_FLL_CLK_SRC_SFT)
+#define NAU8821_FLL_CLK_SRC_MCLK       (0x0 << NAU8821_FLL_CLK_SRC_SFT)
+#define NAU8821_FLL_INTEGER_MASK       0x3ff
+
+/* FLL4 (0x07) */
+#define NAU8821_HIGHBW_EN_SFT          15
+#define NAU8821_HIGHBW_EN              (0x1 << NAU8821_HIGHBW_EN_SFT)
+#define NAU8821_FLL_REF_DIV_SFT                10
+#define NAU8821_FLL_REF_DIV_MASK       (0x3 << NAU8821_FLL_REF_DIV_SFT)
+
+/* FLL5 (0x08) */
+#define NAU8821_FLL_PDB_DAC_EN         (0x1 << 15)
+#define NAU8821_FLL_LOOP_FTR_EN                (0x1 << 14)
+#define NAU8821_FLL_CLK_SW_SFT         13
+#define NAU8821_FLL_CLK_SW_MASK                (0x1 << NAU8821_FLL_CLK_SW_SFT)
+#define NAU8821_FLL_CLK_SW_N2          (0x1 << NAU8821_FLL_CLK_SW_SFT)
+#define NAU8821_FLL_CLK_SW_REF         (0x0 << NAU8821_FLL_CLK_SW_SFT)
+#define NAU8821_FLL_FTR_SW_SFT         12
+#define NAU8821_FLL_FTR_SW_MASK                (0x1 << NAU8821_FLL_FTR_SW_SFT)
+#define NAU8821_FLL_FTR_SW_ACCU                (0x1 << NAU8821_FLL_FTR_SW_SFT)
+#define NAU8821_FLL_FTR_SW_FILTER      (0x0 << NAU8821_FLL_FTR_SW_SFT)
+
+/* FLL6 (0x09) */
+#define NAU8821_DCO_EN          (0x1 << 15)
+#define NAU8821_SDM_EN         (0x1 << 14)
+#define NAU8821_CUTOFF500      (0x1 << 13)
+
+/* FLL7 (0x0a) */
+#define NAU8821_FLL_FRACH_MASK 0xff
+
+/* FLL8 (0x0b) */
+#define NAU8821_FLL_FRACL_MASK 0xffff
+
+/* JACK_DET_CTRL (0x0d) */
+/* 0 - open, 1 - short to GND */
+#define NAU8821_SPKR_DWN1R_SFT                 15
+#define NAU8821_SPKR_DWN1R                     (0x1 << NAU8821_SPKR_DWN1R_SFT)
+#define NAU8821_SPKR_DWN1L_SFT                 14
+#define NAU8821_SPKR_DWN1L                     (0x1 << NAU8821_SPKR_DWN1L_SFT)
+#define NAU8821_JACK_DET_RESTART               (0x1 << 9)
+#define NAU8821_JACK_DET_DB_BYPASS             (0x1 << 8)
+#define NAU8821_JACK_INSERT_DEBOUNCE_SFT       5
+#define NAU8821_JACK_INSERT_DEBOUNCE_MASK      (0x7 << NAU8821_JACK_INSERT_DEBOUNCE_SFT)
+#define NAU8821_JACK_EJECT_DEBOUNCE_SFT                2
+#define NAU8821_JACK_EJECT_DEBOUNCE_MASK       (0x7 << NAU8821_JACK_EJECT_DEBOUNCE_SFT)
+#define NAU8821_JACK_POLARITY                  (0x1 << 1) /* 0 - active low, 1 - active high */
+
+/* INTERRUPT_MASK (0x0f) */
+#define NAU8821_IRQ_PIN_PULL_UP                (0x1 << 14)
+#define NAU8821_IRQ_PIN_PULL_EN                (0x1 << 13)
+#define NAU8821_IRQ_OUTPUT_EN          (0x1 << 11)
+#define NAU8821_IRQ_RMS_EN             (0x1 << 8)
+#define NAU8821_IRQ_KEY_RELEASE_EN     (0x1 << 7)
+#define NAU8821_IRQ_KEY_PRESS_EN       (0x1 << 6)
+#define NAU8821_IRQ_MIC_DET_EN         (0x1 << 4)
+#define NAU8821_IRQ_EJECT_EN           (0x1 << 2)
+#define NAU8821_IRQ_INSERT_EN          0x1
+
+/* IRQ_STATUS (0x10) */
+#define NAU8821_SHORT_CIRCUIT_IRQ      (0x1 << 9)
+#define NAU8821_IMPEDANCE_MEAS_IRQ     (0x1 << 8)
+#define NAU8821_KEY_IRQ_SFT            6
+#define NAU8821_KEY_IRQ_MASK           (0x3 << NAU8821_KEY_IRQ_SFT)
+#define NAU8821_KEY_RELEASE_IRQ                (0x2 << NAU8821_KEY_IRQ_SFT)
+#define NAU8821_KEY_SHORT_PRESS_IRQ    (0x1 << NAU8821_KEY_IRQ_SFT)
+#define NAU8821_MIC_DETECT_IRQ         (0x1 << 4)
+#define NAU8821_JACK_EJECT_IRQ_MASK    (0x3 << 2)
+#define NAU8821_JACK_EJECT_DETECTED    (0x1 << 2)
+#define NAU8821_JACK_INSERT_IRQ_MASK   0x3
+#define NAU8821_JACK_INSERT_DETECTED   0x1
+
+/* INTERRUPT_DIS_CTRL (0x12) */
+#define NAU8821_IRQ_KEY_RELEASE_DIS    (0x1 << 7)
+#define NAU8821_IRQ_KEY_PRESS_DIS      (0x1 << 6)
+#define NAU8821_IRQ_MIC_DIS            (0x1 << 4)
+#define NAU8821_IRQ_EJECT_DIS          (0x1 << 2)
+#define NAU8821_IRQ_INSERT_DIS         0x1
+
+/* DMIC_CTRL (0x13) */
+#define NAU8821_DMIC_DS_SFT    7
+#define NAU8821_DMIC_DS_MASK   (0x1 << NAU8821_DMIC_DS_SFT)
+#define NAU8821_DMIC_DS_HIGH   (0x1 << NAU8821_DMIC_DS_SFT)
+#define NAU8821_DMIC_DS_LOW    (0x0 << NAU8821_DMIC_DS_SFT)
+#define NAU8821_DMIC_SRC_SFT   1
+#define NAU8821_DMIC_SRC_MASK  (0x3 << NAU8821_DMIC_SRC_SFT)
+#define NAU8821_CLK_DMIC_SRC   (0x2 << NAU8821_DMIC_SRC_SFT)
+#define NAU8821_DMIC_EN_SFT    0
+
+/* GPIO12_CTRL (0x1a) */
+#define NAU8821_JKDET_PULL_UP  (0x1 << 11) /* 0 - pull down, 1 - pull up */
+#define NAU8821_JKDET_PULL_EN  (0x1 << 9) /* 0 - enable pull, 1 - disable */
+#define NAU8821_JKDET_OUTPUT_EN        (0x1 << 8) /* 0 - enable input, 1 - enable output */
+
+/* TDM_CTRL (0x1b) */
+#define NAU8821_TDM_EN_SFT     15
+#define NAU8821_TDM_EN         (0x1 << NAU8821_TDM_EN_SFT)
+#define NAU8821_ADCPHS_SFT     13
+#define NAU8821_DACL_CH_SFT    7
+#define NAU8821_DACL_CH_MASK   (0x7 << NAU8821_DACL_CH_SFT)
+#define NAU8821_DACR_CH_SFT    4
+#define NAU8821_DACR_CH_MASK   (0x7 << NAU8821_DACR_CH_SFT)
+#define NAU8821_ADCL_CH_SFT    2
+#define NAU8821_ADCL_CH_MASK   (0x3 << NAU8821_ADCL_CH_SFT)
+#define NAU8821_ADCR_CH_SFT    0
+#define NAU8821_ADCR_CH_MASK   0x3
+
+/* I2S_PCM_CTRL1 (0x1c) */
+#define NAU8821_I2S_BP_SFT             7
+#define NAU8821_I2S_BP_MASK            (0x1 << NAU8821_I2S_BP_SFT)
+#define NAU8821_I2S_BP_INV             (0x1 << NAU8821_I2S_BP_SFT)
+#define NAU8821_I2S_PCMB_SFT           6
+#define NAU8821_I2S_PCMB_MASK          (0x1 << NAU8821_I2S_PCMB_SFT)
+#define NAU8821_I2S_PCMB_EN            (0x1 << NAU8821_I2S_PCMB_SFT)
+#define NAU8821_I2S_DL_SFT              2
+#define NAU8821_I2S_DL_MASK            (0x3 << NAU8821_I2S_DL_SFT)
+#define NAU8821_I2S_DL_32              (0x3 << NAU8821_I2S_DL_SFT)
+#define NAU8821_I2S_DL_24              (0x2 << NAU8821_I2S_DL_SFT)
+#define NAU8821_I2S_DL_20              (0x1 << NAU8821_I2S_DL_SFT)
+#define NAU8821_I2S_DL_16              (0x0 << NAU8821_I2S_DL_SFT)
+#define NAU8821_I2S_DF_MASK            0x3
+#define NAU8821_I2S_DF_PCM_AB          0x3
+#define NAU8821_I2S_DF_I2S             0x2
+#define NAU8821_I2S_DF_LEFT            0x1
+#define NAU8821_I2S_DF_RIGTH           0x0
+
+/* I2S_PCM_CTRL2 (0x1d) */
+#define NAU8821_I2S_TRISTATE_SFT       15
+#define NAU8821_I2S_TRISTATE           (0x1 << NAU8821_I2S_TRISTATE_SFT)
+#define NAU8821_I2S_LRC_DIV_SFT                12
+#define NAU8821_I2S_LRC_DIV_MASK       (0x3 << NAU8821_I2S_LRC_DIV_SFT)
+#define NAU8821_I2S_MS_SFT             3
+#define NAU8821_I2S_MS_MASK            (0x1 << NAU8821_I2S_MS_SFT)
+#define NAU8821_I2S_MS_MASTER          (0x1 << NAU8821_I2S_MS_SFT)
+#define NAU8821_I2S_MS_SLAVE           (0x0 << NAU8821_I2S_MS_SFT)
+#define NAU8821_I2S_BLK_DIV_MASK       0x7
+
+/* LEFT_TIME_SLOT (0x1e) */
+#define NAU8821_TSLOT_L_OFFSET_MASK    0x3ff
+#define NAU8821_DIS_FS_SHORT_DET       (0x1 << 13)
+
+/* RIGHT_TIME_SLOT (0x1f) */
+#define NAU8821_TSLOT_R_OFFSET_MASK    0x3ff
+
+/* BIQ0_COF10 (0x2a) */
+#define NAU8821_BIQ0_ADC_EN_SFT         3
+#define NAU8821_BIQ0_ADC_EN_EN          (0x1 << NAU8821_BIQ0_ADC_EN_SFT)
+
+/* ADC_RATE (0x2b) */
+#define NAU8821_ADC_SYNC_DOWN_SFT      0
+#define NAU8821_ADC_SYNC_DOWN_MASK     0x3
+#define NAU8821_ADC_SYNC_DOWN_256      0x3
+#define NAU8821_ADC_SYNC_DOWN_128      0x2
+#define NAU8821_ADC_SYNC_DOWN_64       0x1
+#define NAU8821_ADC_SYNC_DOWN_32       0x0
+#define NAU8821_ADC_L_SRC_SFT          15
+#define NAU8821_ADC_L_SRC_EN           (0x1 << NAU8821_ADC_L_SRC_SFT)
+#define NAU8821_ADC_R_SRC_SFT          14
+#define NAU8821_ADC_R_SRC_EN           (0x1 << NAU8821_ADC_R_SRC_SFT)
+
+/* DAC_CTRL1 (0x2c) */
+#define NAU8821_DAC_OVERSAMPLE_SFT     0
+#define NAU8821_DAC_OVERSAMPLE_MASK    0x7
+#define NAU8821_DAC_OVERSAMPLE_32      0x4
+#define NAU8821_DAC_OVERSAMPLE_128     0x2
+#define NAU8821_DAC_OVERSAMPLE_256     0x1
+#define NAU8821_DAC_OVERSAMPLE_64      0x0
+
+/* DAC_DGAIN_CTRL (0x2f) */
+#define NAU8821_DAC1_TO_DAC0_ST_SFT    8
+#define NAU8821_DAC1_TO_DAC0_ST_MASK   (0xff << NAU8821_DAC1_TO_DAC0_ST_SFT)
+#define NAU8821_DAC0_TO_DAC1_ST_SFT    0
+#define NAU8821_DAC0_TO_DAC1_ST_MASK   0xff
+
+/* MUTE_CTRL (0x31) */
+#define NAU8821_DAC_ZC_EN      (0x1 << 12)
+#define NAU8821_DAC_SOFT_MUTE  (0x1 << 9)
+#define NAU8821_ADC_ZC_EN      (0x1 << 2)
+#define NAU8821_ADC_SOFT_MUTE  (0x1 << 1)
+
+/* HSVOL_CTRL (0x32) */
+#define NAU8821_HP_MUTE                (0x1 << 15)
+#define NAU8821_HP_MUTE_AUTO   (0x1 << 14)
+#define NAU8821_HPL_MUTE       (0x1 << 13)
+#define NAU8821_HPR_MUTE       (0x1 << 12)
+#define NAU8821_HPL_VOL_SFT    4
+#define NAU8821_HPL_VOL_MASK   (0x3 << NAU8821_HPL_VOL_SFT)
+#define NAU8821_HPR_VOL_SFT    0
+#define NAU8821_HPR_VOL_MASK   (0x3 << NAU8821_HPR_VOL_SFT)
+
+/* DACR_CTRL (0x34) */
+#define NAU8821_DACR_CH_VOL_SFT                8
+#define NAU8821_DACR_CH_VOL_MASK       (0xff << NAU8821_DACR_CH_VOL_SFT)
+#define NAU8821_DACL_CH_VOL_SFT                0
+#define NAU8821_DACL_CH_VOL_MASK       0xff
+
+/* ADC_DGAIN_CTRL1 (0x35) */
+#define NAU8821_ADCR_CH_VOL_SFT                8
+#define NAU8821_ADCR_CH_VOL_MASK       (0xff << NAU8821_ADCR_CH_VOL_SFT)
+#define NAU8821_ADCL_CH_VOL_SFT                0
+#define NAU8821_ADCL_CH_VOL_MASK       0xff
+
+/* BIQ1_COF10 (0x4a) */
+#define NAU8821_BIQ1_DAC_EN_SFT                3
+#define NAU8821_BIQ1_DAC_EN_EN          (0x1 << NAU8821_BIQ1_DAC_EN_SFT)
+
+/* CLASSG_CTRL (0x4b) */
+#define NAU8821_CLASSG_TIMER_SFT       8
+#define NAU8821_CLASSG_TIMER_MASK      (0x3f << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_64MS      (0x20 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_32MS      (0x10 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_16MS      (0x8 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_8MS       (0x4 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_2MS       (0x2 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_TIMER_1MS       (0x1 << NAU8821_CLASSG_TIMER_SFT)
+#define NAU8821_CLASSG_RDAC_EN_SFT     2
+#define NAU8821_CLASSG_RDAC_EN         (0x1 << NAU8821_CLASSG_RDAC_EN_SFT)
+#define NAU8821_CLASSG_LDAC_EN_SFT     1
+#define NAU8821_CLASSG_LDAC_EN         (0x1 << NAU8821_CLASSG_LDAC_EN_SFT)
+#define NAU8821_CLASSG_EN_SFT          0
+#define NAU8821_CLASSG_EN              0x1
+
+/* IMM_MODE_CTRL (0x4c) */
+#define NAU8821_IMM_THD_SFT            8
+#define NAU8821_IMM_THD_MASK           (0x3f << NAU8821_IMM_THD_SFT)
+#define NAU8821_IMM_GEN_VOL_SFT                6
+#define NAU8821_IMM_GEN_VOL_MASK       (0x3 << NAU8821_IMM_GEN_VOL_SFT)
+#define NAU8821_IMM_CYC_SFT            4
+#define NAU8821_IMM_CYC_MASK           (0x3 << NAU8821_IMM_CYC_SFT)
+#define NAU8821_IMM_EN                 (0x1 << 3)
+#define NAU8821_IMM_DAC_SRC_MASK       0x3
+
+/* I2C_DEVICE_ID (0x58) */
+#define NAU8821_KEYDET                 (0x1 << 7)
+#define NAU8821_MICDET                 (0x1 << 6)
+#define NAU8821_SOFTWARE_ID_MASK       0x3
+
+/* BIAS_ADJ (0x66) */
+#define NAU8821_BIAS_HP_IMP            (0x1 << 15)
+#define NAU8821_BIAS_TESTDAC_SFT       8
+#define NAU8821_BIAS_TESTDAC_EN                (0x3 << NAU8821_BIAS_TESTDAC_SFT)
+#define NAU8821_BIAS_TESTDACR_EN       (0x2 << NAU8821_BIAS_TESTDAC_SFT)
+#define NAU8821_BIAS_TESTDACL_EN       (0x1 << NAU8821_BIAS_TESTDAC_SFT)
+#define NAU8821_BIAS_VMID              (0x1 << 6)
+#define NAU8821_BIAS_VMID_SEL_SFT      4
+#define NAU8821_BIAS_VMID_SEL_MASK     (0x3 << NAU8821_BIAS_VMID_SEL_SFT)
+
+/* ANALOG_CONTROL_1 (0x69) */
+#define NAU8821_JD_POL_SFT             2
+#define NAU8821_JD_POL_MASK            (0x1 << NAU8821_JD_POL_SFT)
+#define NAU8821_JD_POL_INV             (0x1 << NAU8821_JD_POL_SFT)
+#define NAU8821_JD_OUT_POL_SFT         1
+#define NAU8821_JD_OUT_POL_MASK                (0x1 << NAU8821_JD_OUT_POL_SFT)
+#define NAU8821_JD_OUT_POL_INV         (0x1 << NAU8821_JD_OUT_POL_SFT)
+#define NAU8821_JD_EN_SFT              0
+#define NAU8821_JD_EN                  0x1
+
+/* ANALOG_CONTROL_2 (0x6a) */
+#define NAU8821_HP_NON_CLASSG_CURRENT_2xADJ    (0x1 << 12)
+#define NAU8821_DAC_CAPACITOR_MSB              (0x1 << 1)
+#define NAU8821_DAC_CAPACITOR_LSB              0x1
+
+/* ANALOG_ADC_1 (0x71) */
+#define NAU8821_MICDET_EN_SFT          0
+#define NAU8821_MICDET_MASK            0x1
+#define NAU8821_MICDET_DIS             0x1
+#define NAU8821_MICDET_EN              0x0
+
+/* ANALOG_ADC_2 (0x72) */
+#define NAU8821_ADC_VREFSEL_SFT                8
+#define NAU8821_ADC_VREFSEL_MASK       (0x3 << NAU8821_ADC_VREFSEL_SFT)
+#define NAU8821_POWERUP_ADCL_SFT       6
+#define NAU8821_POWERUP_ADCL           (0x1 << NAU8821_POWERUP_ADCL_SFT)
+#define NAU8821_POWERUP_ADCR_SFT       4
+#define NAU8821_POWERUP_ADCR           (0x1 << NAU8821_POWERUP_ADCR_SFT)
+
+/* RDAC (0x73) */
+#define NAU8821_DACR_EN_SFT            13
+#define NAU8821_DACR_EN                        (0x3 << NAU8821_DACR_EN_SFT)
+#define NAU8821_DACL_EN_SFT            12
+#define NAU8821_DACL_EN                        (0x3 << NAU8821_DACL_EN_SFT)
+#define NAU8821_DACR_CLK_EN_SFT                9
+#define NAU8821_DACR_CLK_EN            (0x3 << NAU8821_DACR_CLK_EN_SFT)
+#define NAU8821_DACL_CLK_EN_SFT                8
+#define NAU8821_DACL_CLK_EN            (0x3 << NAU8821_DACL_CLK_EN_SFT)
+#define NAU8821_DAC_CLK_DELAY_SFT      4
+#define NAU8821_DAC_CLK_DELAY_MASK     (0x7 << NAU8821_DAC_CLK_DELAY_SFT)
+#define NAU8821_DAC_VREF_SFT           2
+#define NAU8821_DAC_VREF_MASK          (0x3 << NAU8821_DAC_VREF_SFT)
+
+/* MIC_BIAS (0x74) */
+#define NAU8821_MICBIAS_JKR2           (0x1 << 12)
+#define NAU8821_MICBIAS_POWERUP_SFT    8
+#define NAU8821_MICBIAS_VOLTAGE_SFT    0
+#define NAU8821_MICBIAS_VOLTAGE_MASK   0x7
+
+/* BOOST (0x76) */
+#define NAU8821_PRECHARGE_DIS          (0x1 << 13)
+#define NAU8821_GLOBAL_BIAS_EN         (0x1 << 12)
+#define NAU8821_HP_BOOST_DIS_SFT       9
+#define NAU8821_HP_BOOST_DIS           (0x1 << NAU8821_HP_BOOST_DIS_SFT)
+#define NAU8821_HP_BOOST_G_DIS         (0x1 << 8)
+#define NAU8821_SHORT_SHUTDOWN_EN      (0x1 << 6)
+
+/* FEPGA (0x77) */
+#define NAU8821_FEPGA_MODEL_SFT                4
+#define NAU8821_FEPGA_MODEL_MASK       (0xf << NAU8821_FEPGA_MODEL_SFT)
+#define NAU8821_FEPGA_MODER_SFT                0
+#define NAU8821_FEPGA_MODER_MASK       0xf
+
+/* PGA_GAIN (0x7e) */
+#define NAU8821_PGA_GAIN_L_SFT         8
+#define NAU8821_PGA_GAIN_L_MASK                (0x3f << NAU8821_PGA_GAIN_L_SFT)
+#define NAU8821_PGA_GAIN_R_SFT         0
+#define NAU8821_PGA_GAIN_R_MASK                0x3f
+
+/* POWER_UP_CONTROL (0x7f) */
+#define NAU8821_PUP_PGA_L_SFT          15
+#define NAU8821_PUP_PGA_L              (0x1 << NAU8821_PUP_PGA_L_SFT)
+#define NAU8821_PUP_PGA_R_SFT          14
+#define NAU8821_PUP_PGA_R              (0x1 << NAU8821_PUP_PGA_R_SFT)
+#define NAU8821_PUP_INTEG_R_SFT                5
+#define NAU8821_PUP_INTEG_R            (0x1 << NAU8821_PUP_INTEG_R_SFT)
+#define NAU8821_PUP_INTEG_L_SFT                4
+#define NAU8821_PUP_INTEG_L            (0x1 << NAU8821_PUP_INTEG_L_SFT)
+#define NAU8821_PUP_DRV_INSTG_R_SFT    3
+#define NAU8821_PUP_DRV_INSTG_R                (0x1 << NAU8821_PUP_DRV_INSTG_R_SFT)
+#define NAU8821_PUP_DRV_INSTG_L_SFT    2
+#define NAU8821_PUP_DRV_INSTG_L                (0x1 << NAU8821_PUP_DRV_INSTG_L_SFT)
+#define NAU8821_PUP_MAIN_DRV_R_SFT     1
+#define NAU8821_PUP_MAIN_DRV_R         (0x1 << NAU8821_PUP_MAIN_DRV_R_SFT)
+#define NAU8821_PUP_MAIN_DRV_L_SFT     0
+#define NAU8821_PUP_MAIN_DRV_L         0x1
+
+/* CHARGE_PUMP (0x80) */
+#define NAU8821_JAMNODCLOW             (0x1 << 10)
+#define NAU8821_POWER_DOWN_DACR_SFT    9
+#define NAU8821_POWER_DOWN_DACR                (0x1 << NAU8821_POWER_DOWN_DACR_SFT)
+#define NAU8821_POWER_DOWN_DACL_SFT    8
+#define NAU8821_POWER_DOWN_DACL                (0x1 << NAU8821_POWER_DOWN_DACL_SFT)
+#define NAU8821_CHANRGE_PUMP_EN_SFT    5
+#define NAU8821_CHANRGE_PUMP_EN                (0x1 << NAU8821_CHANRGE_PUMP_EN_SFT)
+
+/* GENERAL_STATUS (0x82) */
+#define NAU8821_GPIO2_IN_SFT   1
+#define NAU8821_GPIO2_IN       (0x1 << NAU8821_GPIO2_IN_SFT)
+
+#define NUVOTON_CODEC_DAI "nau8821-hifi"
+
+/* System Clock Source */
+enum {
+       NAU8821_CLK_DIS,
+       NAU8821_CLK_MCLK,
+       NAU8821_CLK_INTERNAL,
+       NAU8821_CLK_FLL_MCLK,
+       NAU8821_CLK_FLL_BLK,
+       NAU8821_CLK_FLL_FS,
+};
+
+struct nau8821 {
+       struct device *dev;
+       struct regmap *regmap;
+       struct snd_soc_dapm_context *dapm;
+       struct snd_soc_jack *jack;
+       struct work_struct jdet_work;
+       int irq;
+       int clk_id;
+       int micbias_voltage;
+       int vref_impedance;
+       bool jkdet_enable;
+       bool jkdet_pull_enable;
+       bool jkdet_pull_up;
+       int jkdet_polarity;
+       int jack_insert_debounce;
+       int jack_eject_debounce;
+       int fs;
+       int dmic_clk_threshold;
+};
+
+int nau8821_enable_jack_detect(struct snd_soc_component *component,
+       struct snd_soc_jack *jack);
+
+#endif  /* __NAU8821_H__ */
index f946ef6..d0dd154 100644 (file)
@@ -8,6 +8,7 @@
 
 #include <linux/module.h>
 #include <linux/delay.h>
+#include <linux/dmi.h>
 #include <linux/init.h>
 #include <linux/i2c.h>
 #include <linux/regmap.h>
 
 #include "nau8824.h"
 
+#define NAU8824_JD_ACTIVE_HIGH                 BIT(0)
+#define NAU8824_MONO_SPEAKER                   BIT(1)
+
+static int nau8824_quirk;
+static int quirk_override = -1;
+module_param_named(quirk, quirk_override, uint, 0444);
+MODULE_PARM_DESC(quirk, "Board-specific quirk override");
 
 static int nau8824_config_sysclk(struct nau8824 *nau8824,
        int clk_id, unsigned int freq);
@@ -1845,6 +1853,63 @@ static int nau8824_read_device_properties(struct device *dev,
        return 0;
 }
 
+/* Please keep this list alphabetically sorted */
+static const struct dmi_system_id nau8824_quirk_table[] = {
+       {
+               /* Cyberbook T116 rugged tablet */
+               .matches = {
+                       DMI_EXACT_MATCH(DMI_BOARD_VENDOR, "Default string"),
+                       DMI_EXACT_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
+                       DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "20170531"),
+               },
+               .driver_data = (void *)(NAU8824_JD_ACTIVE_HIGH |
+                                       NAU8824_MONO_SPEAKER),
+       },
+       {
+               /* CUBE iwork8 Air */
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "cube"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "i1-TF"),
+                       DMI_MATCH(DMI_BOARD_NAME, "Cherry Trail CR"),
+               },
+               .driver_data = (void *)(NAU8824_MONO_SPEAKER),
+       },
+       {
+               /* Pipo W2S */
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "PIPO"),
+                       DMI_MATCH(DMI_PRODUCT_NAME, "W2S"),
+               },
+               .driver_data = (void *)(NAU8824_MONO_SPEAKER),
+       },
+       {}
+};
+
+static void nau8824_check_quirks(void)
+{
+       const struct dmi_system_id *dmi_id;
+
+       if (quirk_override != -1) {
+               nau8824_quirk = quirk_override;
+               return;
+       }
+
+       dmi_id = dmi_first_match(nau8824_quirk_table);
+       if (dmi_id)
+               nau8824_quirk = (unsigned long)dmi_id->driver_data;
+}
+
+const char *nau8824_components(void)
+{
+       nau8824_check_quirks();
+
+       if (nau8824_quirk & NAU8824_MONO_SPEAKER)
+               return "cfg-spk:1";
+       else
+               return "cfg-spk:2";
+}
+EXPORT_SYMBOL_GPL(nau8824_components);
+
 static int nau8824_i2c_probe(struct i2c_client *i2c,
        const struct i2c_device_id *id)
 {
@@ -1869,6 +1934,11 @@ static int nau8824_i2c_probe(struct i2c_client *i2c,
        nau8824->irq = i2c->irq;
        sema_init(&nau8824->jd_sem, 1);
 
+       nau8824_check_quirks();
+
+       if (nau8824_quirk & NAU8824_JD_ACTIVE_HIGH)
+               nau8824->jkdet_polarity = 0;
+
        nau8824_print_device_properties(nau8824);
 
        ret = regmap_read(nau8824->regmap, NAU8824_REG_I2C_DEVICE_ID, &value);
index 1d7bdd8..de4bae8 100644 (file)
 /* JACK_DET_CTRL (0x0D) */
 #define NAU8824_JACK_EJECT_DT_SFT      2
 #define NAU8824_JACK_EJECT_DT_MASK (0x3 << NAU8824_JACK_EJECT_DT_SFT)
-#define NAU8824_JACK_LOGIC             0x1
+#define NAU8824_JACK_LOGIC             (0x1 << 1)
 
 
 /* INTERRUPT_SETTING_1 (0x0F) */
@@ -470,6 +470,7 @@ struct nau8824_osr_attr {
 
 int nau8824_enable_jack_detect(struct snd_soc_component *component,
        struct snd_soc_jack *jack);
+const char *nau8824_components(void);
 
 #endif                         /* _NAU8824_H */
 
index 67de0e4..7734bc3 100644 (file)
@@ -47,6 +47,7 @@
 
 static int nau8825_configure_sysclk(struct nau8825 *nau8825,
                int clk_id, unsigned int freq);
+static bool nau8825_is_jack_inserted(struct regmap *regmap);
 
 struct nau8825_fll {
        int mclk_src;
@@ -981,6 +982,31 @@ static int nau8825_output_dac_event(struct snd_soc_dapm_widget *w,
        return 0;
 }
 
+static int system_clock_control(struct snd_soc_dapm_widget *w,
+                               struct snd_kcontrol *k, int  event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct nau8825 *nau8825 = snd_soc_component_get_drvdata(component);
+       struct regmap *regmap = nau8825->regmap;
+
+       if (SND_SOC_DAPM_EVENT_OFF(event)) {
+               dev_dbg(nau8825->dev, "system clock control : POWER OFF\n");
+               /* Set clock source to disable or internal clock before the
+                * playback or capture end. Codec needs clock for Jack
+                * detection and button press if jack inserted; otherwise,
+                * the clock should be closed.
+                */
+               if (nau8825_is_jack_inserted(regmap)) {
+                       nau8825_configure_sysclk(nau8825,
+                                                NAU8825_CLK_INTERNAL, 0);
+               } else {
+                       nau8825_configure_sysclk(nau8825, NAU8825_CLK_DIS, 0);
+               }
+       }
+
+       return 0;
+}
+
 static int nau8825_biq_coeff_get(struct snd_kcontrol *kcontrol,
                                     struct snd_ctl_elem_value *ucontrol)
 {
@@ -1094,6 +1120,9 @@ static const struct snd_kcontrol_new nau8825_dacr_mux =
 static const struct snd_soc_dapm_widget nau8825_dapm_widgets[] = {
        SND_SOC_DAPM_AIF_OUT("AIFTX", "Capture", 0, NAU8825_REG_I2S_PCM_CTRL2,
                15, 1),
+       SND_SOC_DAPM_AIF_IN("AIFRX", "Playback", 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_SUPPLY("System Clock", SND_SOC_NOPM, 0, 0,
+                           system_clock_control, SND_SOC_DAPM_POST_PMD),
 
        SND_SOC_DAPM_INPUT("MIC"),
        SND_SOC_DAPM_MICBIAS("MICBIAS", NAU8825_REG_MIC_BIAS, 8, 0),
@@ -1182,9 +1211,11 @@ static const struct snd_soc_dapm_route nau8825_dapm_routes[] = {
        {"ADC", NULL, "ADC Clock"},
        {"ADC", NULL, "ADC Power"},
        {"AIFTX", NULL, "ADC"},
+       {"AIFTX", NULL, "System Clock"},
 
-       {"DDACL", NULL, "Playback"},
-       {"DDACR", NULL, "Playback"},
+       {"AIFRX", NULL, "System Clock"},
+       {"DDACL", NULL, "AIFRX"},
+       {"DDACR", NULL, "AIFRX"},
        {"DDACL", NULL, "DDAC Clock"},
        {"DDACR", NULL, "DDAC Clock"},
        {"DACL Mux", "DACL", "DDACL"},
@@ -1434,6 +1465,12 @@ int nau8825_enable_jack_detect(struct snd_soc_component *component,
 
        nau8825->jack = jack;
 
+       if (!nau8825->jack) {
+               regmap_update_bits(regmap, NAU8825_REG_HSD_CTRL,
+                                  NAU8825_HSD_AUTO_MODE | NAU8825_SPKR_DWN1R |
+                                  NAU8825_SPKR_DWN1L, 0);
+               return 0;
+       }
        /* Ground HP Outputs[1:0], needed for headset auto detection
         * Enable Automatic Mic/Gnd switching reading on insert interrupt[6]
         */
@@ -2416,6 +2453,12 @@ static int __maybe_unused nau8825_resume(struct snd_soc_component *component)
        return 0;
 }
 
+static int nau8825_set_jack(struct snd_soc_component *component,
+                           struct snd_soc_jack *jack, void *data)
+{
+       return nau8825_enable_jack_detect(component, jack);
+}
+
 static const struct snd_soc_component_driver nau8825_component_driver = {
        .probe                  = nau8825_component_probe,
        .remove                 = nau8825_component_remove,
@@ -2430,6 +2473,7 @@ static const struct snd_soc_component_driver nau8825_component_driver = {
        .num_dapm_widgets       = ARRAY_SIZE(nau8825_dapm_widgets),
        .dapm_routes            = nau8825_dapm_routes,
        .num_dapm_routes        = ARRAY_SIZE(nau8825_dapm_routes),
+       .set_jack               = nau8825_set_jack,
        .suspend_bias_off       = 1,
        .idle_bias_on           = 1,
        .use_pmdown_time        = 1,
index b8cfc25..f39f98b 100644 (file)
@@ -17,7 +17,7 @@ static struct snd_soc_dai_driver pcm5102a_dai = {
        .playback = {
                .channels_min = 2,
                .channels_max = 2,
-               .rates = SNDRV_PCM_RATE_8000_192000,
+               .rates = SNDRV_PCM_RATE_8000_384000,
                .formats = SNDRV_PCM_FMTBIT_S16_LE |
                           SNDRV_PCM_FMTBIT_S24_LE |
                           SNDRV_PCM_FMTBIT_S32_LE
index faff2b5..297af7f 100644 (file)
@@ -1311,6 +1311,14 @@ static int rt1011_r0_load_info(struct snd_kcontrol *kcontrol,
        .put = rt1011_r0_load_mode_put \
 }
 
+static const char * const rt1011_i2s_ref_texts[] = {
+       "Left Channel", "Right Channel"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt1011_i2s_ref_enum,
+                           RT1011_TDM1_SET_1, 7,
+                           rt1011_i2s_ref_texts);
+
 static const struct snd_kcontrol_new rt1011_snd_controls[] = {
        /* I2S Data In Selection */
        SOC_ENUM("DIN Source", rt1011_din_source_enum),
@@ -1349,6 +1357,8 @@ static const struct snd_kcontrol_new rt1011_snd_controls[] = {
        /* R0 temperature */
        SOC_SINGLE("R0 Temperature", RT1011_STP_INITIAL_RESISTANCE_TEMP,
                2, 255, 0),
+       /* I2S Reference */
+       SOC_ENUM("I2S Reference", rt1011_i2s_ref_enum),
 };
 
 static int rt1011_is_sys_clk_from_pll(struct snd_soc_dapm_widget *source,
index c0c5952..6a27dfa 100644 (file)
@@ -864,7 +864,7 @@ static int rt1015_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 7561d20..9845cdd 100644 (file)
@@ -490,7 +490,7 @@ static int rt1016_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out * 4, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 8c0b002..80b7ca0 100644 (file)
@@ -359,7 +359,7 @@ static int rt1019_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 7a00945..a9c4735 100644 (file)
@@ -841,7 +841,7 @@ static int rt1305_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index b4e5546..c555b77 100644 (file)
@@ -664,7 +664,7 @@ static int rt1308_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 4b1ad50..577680d 100644 (file)
@@ -936,7 +936,7 @@ static int rt5514_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index fd0d3a0..8e64144 100644 (file)
@@ -1133,7 +1133,7 @@ static int rt5616_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index cd1db5c..d01fe73 100644 (file)
@@ -1909,7 +1909,7 @@ static int rt5640_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 9408ee6..197c560 100644 (file)
@@ -2969,7 +2969,7 @@ static int rt5645_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index fc0c83b..f302c25 100644 (file)
@@ -1487,7 +1487,7 @@ static int rt5651_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
@@ -2261,11 +2261,8 @@ static int rt5651_i2c_probe(struct i2c_client *i2c,
 
        ret = devm_request_irq(&i2c->dev, rt5651->irq, rt5651_irq,
                               IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING
-                              | IRQF_ONESHOT, "rt5651", rt5651);
-       if (ret == 0) {
-               /* Gets re-enabled by rt5651_set_jack() */
-               disable_irq(rt5651->irq);
-       } else {
+                              | IRQF_ONESHOT | IRQF_NO_AUTOEN, "rt5651", rt5651);
+       if (ret) {
                dev_warn(&i2c->dev, "Failed to reguest IRQ %d: %d\n",
                         rt5651->irq, ret);
                rt5651->irq = -ENXIO;
index 4a50b16..e1503c2 100644 (file)
@@ -3509,7 +3509,7 @@ static int rt5659_set_component_pll(struct snd_soc_component *component, int pll
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 33ff915..3b50fb2 100644 (file)
@@ -1046,7 +1046,7 @@ static int rt5660_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index be9fc58..0389b2b 100644 (file)
@@ -2941,7 +2941,7 @@ static int rt5663_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index e59323f..33e8898 100644 (file)
@@ -4374,7 +4374,7 @@ static int rt5665_set_component_pll(struct snd_soc_component *component, int pll
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index 6ab1a8b..fb09715 100644 (file)
@@ -2171,7 +2171,7 @@ static int rt5668_set_component_pll(struct snd_soc_component *component,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index ecbaf12..ce76847 100644 (file)
@@ -2577,7 +2577,7 @@ static int rt5670_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index f655228..4a8c267 100644 (file)
@@ -4557,7 +4557,7 @@ static int rt5677_set_dai_pll(struct snd_soc_dai *dai, int pll_id, int source,
 
        ret = rt5677_pll_calc(freq_in, freq_out, &pll_code);
        if (ret < 0) {
-               dev_err(component->dev, "Unsupport input clock %d\n", freq_in);
+               dev_err(component->dev, "Unsupported input clock %d\n", freq_in);
                return ret;
        }
 
index b9d5d7a..983347b 100644 (file)
@@ -139,6 +139,8 @@ static int rt5682_i2c_probe(struct i2c_client *i2c,
 
        i2c_set_clientdata(i2c, rt5682);
 
+       rt5682->i2c_dev = &i2c->dev;
+
        rt5682->pdata = i2s_default_platform_data;
 
        if (pdata)
@@ -276,6 +278,21 @@ static int rt5682_i2c_probe(struct i2c_client *i2c,
                        dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret);
        }
 
+#ifdef CONFIG_COMMON_CLK
+       /* Check if MCLK provided */
+       rt5682->mclk = devm_clk_get_optional(&i2c->dev, "mclk");
+       if (IS_ERR(rt5682->mclk))
+               return PTR_ERR(rt5682->mclk);
+
+       /* Register CCF DAI clock control */
+       ret = rt5682_register_dai_clks(rt5682);
+       if (ret)
+               return ret;
+
+       /* Initial setup for CCF */
+       rt5682->lrck[RT5682_AIF1] = 48000;
+#endif
+
        return devm_snd_soc_register_component(&i2c->dev,
                                               &rt5682_soc_component_dev,
                                               rt5682_dai, ARRAY_SIZE(rt5682_dai));
index 4a64cab..78b4cb5 100644 (file)
@@ -46,6 +46,8 @@ static const struct reg_sequence patch_list[] = {
        {RT5682_SAR_IL_CMD_1, 0x22b7},
        {RT5682_SAR_IL_CMD_3, 0x0365},
        {RT5682_SAR_IL_CMD_6, 0x0110},
+       {RT5682_CHARGE_PUMP_1, 0x0210},
+       {RT5682_HP_LOGIC_CTRL_2, 0x0007},
 };
 
 void rt5682_apply_patch_list(struct rt5682_priv *rt5682, struct device *dev)
@@ -1515,21 +1517,29 @@ static int rt5682_hp_event(struct snd_soc_dapm_widget *w,
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
-               snd_soc_component_write(component,
-                       RT5682_HP_LOGIC_CTRL_2, 0x0012);
-               snd_soc_component_write(component,
-                       RT5682_HP_CTRL_2, 0x6000);
+               snd_soc_component_update_bits(component, RT5682_HP_CTRL_2,
+                       RT5682_HP_C2_DAC_AMP_MUTE, 0);
+               snd_soc_component_update_bits(component, RT5682_HP_LOGIC_CTRL_2,
+                       RT5682_HP_LC2_SIG_SOUR2_MASK, RT5682_HP_LC2_SIG_SOUR2_REG);
                snd_soc_component_update_bits(component,
                        RT5682_DEPOP_1, 0x60, 0x60);
                snd_soc_component_update_bits(component,
                        RT5682_DAC_ADC_DIG_VOL1, 0x00c0, 0x0080);
+               snd_soc_component_update_bits(component, RT5682_HP_CTRL_2,
+                       RT5682_HP_C2_DAC_L_EN | RT5682_HP_C2_DAC_R_EN,
+                       RT5682_HP_C2_DAC_L_EN | RT5682_HP_C2_DAC_R_EN);
+               usleep_range(5000, 10000);
+               snd_soc_component_update_bits(component, RT5682_CHARGE_PUMP_1,
+                       RT5682_CP_SW_SIZE_MASK, RT5682_CP_SW_SIZE_L);
                break;
 
        case SND_SOC_DAPM_POST_PMD:
+               snd_soc_component_update_bits(component, RT5682_HP_CTRL_2,
+                       RT5682_HP_C2_DAC_L_EN | RT5682_HP_C2_DAC_R_EN, 0);
+               snd_soc_component_update_bits(component, RT5682_CHARGE_PUMP_1,
+                       RT5682_CP_SW_SIZE_MASK, RT5682_CP_SW_SIZE_M);
                snd_soc_component_update_bits(component,
                        RT5682_DEPOP_1, 0x60, 0x0);
-               snd_soc_component_write(component,
-                       RT5682_HP_CTRL_2, 0x0000);
                snd_soc_component_update_bits(component,
                        RT5682_DAC_ADC_DIG_VOL1, 0x00c0, 0x0000);
                break;
@@ -1637,6 +1647,23 @@ static SOC_VALUE_ENUM_SINGLE_DECL(rt5682_adcdat_pin_enum,
 static const struct snd_kcontrol_new rt5682_adcdat_pin_ctrl =
        SOC_DAPM_ENUM("ADCDAT", rt5682_adcdat_pin_enum);
 
+static const unsigned int rt5682_hpo_sig_out_values[] = {
+       2,
+       7,
+};
+
+static const char * const rt5682_hpo_sig_out_mode[] = {
+       "Legacy",
+       "OneBit",
+};
+
+static SOC_VALUE_ENUM_SINGLE_DECL(rt5682_hpo_sig_out_enum,
+       RT5682_HP_LOGIC_CTRL_2, 0, RT5682_HP_LC2_SIG_SOUR1_MASK,
+       rt5682_hpo_sig_out_mode, rt5682_hpo_sig_out_values);
+
+static const struct snd_kcontrol_new rt5682_hpo_sig_demux =
+       SOC_DAPM_ENUM("HPO Signal Demux", rt5682_hpo_sig_out_enum);
+
 static const struct snd_soc_dapm_widget rt5682_dapm_widgets[] = {
        SND_SOC_DAPM_SUPPLY("LDO2", RT5682_PWR_ANLG_3, RT5682_PWR_LDO2_BIT,
                0, NULL, 0),
@@ -1820,6 +1847,10 @@ static const struct snd_soc_dapm_widget rt5682_dapm_widgets[] = {
        SND_SOC_DAPM_SWITCH("HPOR Playback", SND_SOC_NOPM, 0, 0,
                &hpor_switch),
 
+       SND_SOC_DAPM_OUT_DRV("HPO Legacy", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_OUT_DRV("HPO OneBit", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_DEMUX("HPO Signal Demux", SND_SOC_NOPM, 0, 0, &rt5682_hpo_sig_demux),
+
        /* CLK DET */
        SND_SOC_DAPM_SUPPLY("CLKDET SYS", RT5682_CLK_DET,
                RT5682_SYS_CLK_DET_SFT, 0, NULL, 0),
@@ -1987,10 +2018,19 @@ static const struct snd_soc_dapm_route rt5682_dapm_routes[] = {
        {"HP Amp", NULL, "Charge Pump"},
        {"HP Amp", NULL, "CLKDET SYS"},
        {"HP Amp", NULL, "Vref1"},
-       {"HPOL Playback", "Switch", "HP Amp"},
-       {"HPOR Playback", "Switch", "HP Amp"},
+
+       {"HPO Signal Demux", NULL, "HP Amp"},
+
+       {"HPO Legacy", "Legacy", "HPO Signal Demux"},
+       {"HPO OneBit", "OneBit", "HPO Signal Demux"},
+
+       {"HPOL Playback", "Switch", "HPO Legacy"},
+       {"HPOR Playback", "Switch", "HPO Legacy"},
+
        {"HPOL", NULL, "HPOL Playback"},
        {"HPOR", NULL, "HPOR Playback"},
+       {"HPOL", NULL, "HPO OneBit"},
+       {"HPOR", NULL, "HPO OneBit"},
 };
 
 static int rt5682_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
@@ -2327,7 +2367,7 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
                pll2_fout1 = 3840000;
                ret = rl6231_pll_calc(freq_in, pll2_fout1, &pll2f_code);
                if (ret < 0) {
-                       dev_err(component->dev, "Unsupport input clock %d\n",
+                       dev_err(component->dev, "Unsupported input clock %d\n",
                                freq_in);
                        return ret;
                }
@@ -2339,7 +2379,7 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
 
                ret = rl6231_pll_calc(pll2_fout1, freq_out, &pll2b_code);
                if (ret < 0) {
-                       dev_err(component->dev, "Unsupport input clock %d\n",
+                       dev_err(component->dev, "Unsupported input clock %d\n",
                                pll2_fout1);
                        return ret;
                }
@@ -2390,7 +2430,7 @@ static int rt5682_set_component_pll(struct snd_soc_component *component,
 
                ret = rl6231_pll_calc(freq_in, freq_out, &pll_code);
                if (ret < 0) {
-                       dev_err(component->dev, "Unsupport input clock %d\n",
+                       dev_err(component->dev, "Unsupported input clock %d\n",
                                freq_in);
                        return ret;
                }
@@ -2510,7 +2550,7 @@ static int rt5682_set_bias_level(struct snd_soc_component *component,
 static bool rt5682_clk_check(struct rt5682_priv *rt5682)
 {
        if (!rt5682->master[RT5682_AIF1]) {
-               dev_dbg(rt5682->component->dev, "sysclk/dai not set correctly\n");
+               dev_dbg(rt5682->i2c_dev, "sysclk/dai not set correctly\n");
                return false;
        }
        return true;
@@ -2521,13 +2561,15 @@ static int rt5682_wclk_prepare(struct clk_hw *hw)
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_WCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
-       struct snd_soc_dapm_context *dapm =
-                       snd_soc_component_get_dapm(component);
+       struct snd_soc_component *component;
+       struct snd_soc_dapm_context *dapm;
 
        if (!rt5682_clk_check(rt5682))
                return -EINVAL;
 
+       component = rt5682->component;
+       dapm = snd_soc_component_get_dapm(component);
+
        snd_soc_dapm_mutex_lock(dapm);
 
        snd_soc_dapm_force_enable_pin_unlocked(dapm, "MICBIAS");
@@ -2557,13 +2599,15 @@ static void rt5682_wclk_unprepare(struct clk_hw *hw)
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_WCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
-       struct snd_soc_dapm_context *dapm =
-                       snd_soc_component_get_dapm(component);
+       struct snd_soc_component *component;
+       struct snd_soc_dapm_context *dapm;
 
        if (!rt5682_clk_check(rt5682))
                return;
 
+       component = rt5682->component;
+       dapm = snd_soc_component_get_dapm(component);
+
        snd_soc_dapm_mutex_lock(dapm);
 
        snd_soc_dapm_disable_pin_unlocked(dapm, "MICBIAS");
@@ -2587,7 +2631,6 @@ static unsigned long rt5682_wclk_recalc_rate(struct clk_hw *hw,
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_WCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
        const char * const clk_name = clk_hw_get_name(hw);
 
        if (!rt5682_clk_check(rt5682))
@@ -2597,7 +2640,7 @@ static unsigned long rt5682_wclk_recalc_rate(struct clk_hw *hw,
         */
        if (rt5682->lrck[RT5682_AIF1] != CLK_48 &&
            rt5682->lrck[RT5682_AIF1] != CLK_44) {
-               dev_warn(component->dev, "%s: clk %s only support %d or %d Hz output\n",
+               dev_warn(rt5682->i2c_dev, "%s: clk %s only support %d or %d Hz output\n",
                        __func__, clk_name, CLK_44, CLK_48);
                return 0;
        }
@@ -2611,7 +2654,6 @@ static long rt5682_wclk_round_rate(struct clk_hw *hw, unsigned long rate,
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_WCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
        const char * const clk_name = clk_hw_get_name(hw);
 
        if (!rt5682_clk_check(rt5682))
@@ -2621,7 +2663,7 @@ static long rt5682_wclk_round_rate(struct clk_hw *hw, unsigned long rate,
         * It will force to 48kHz if not both.
         */
        if (rate != CLK_48 && rate != CLK_44) {
-               dev_warn(component->dev, "%s: clk %s only support %d or %d Hz output\n",
+               dev_warn(rt5682->i2c_dev, "%s: clk %s only support %d or %d Hz output\n",
                        __func__, clk_name, CLK_44, CLK_48);
                rate = CLK_48;
        }
@@ -2635,7 +2677,7 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate,
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_WCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
+       struct snd_soc_component *component;
        struct clk_hw *parent_hw;
        const char * const clk_name = clk_hw_get_name(hw);
        int pre_div;
@@ -2644,6 +2686,8 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate,
        if (!rt5682_clk_check(rt5682))
                return -EINVAL;
 
+       component = rt5682->component;
+
        /*
         * Whether the wclk's parent clk (mclk) exists or not, please ensure
         * it is fixed or set to 48MHz before setting wclk rate. It's a
@@ -2653,12 +2697,12 @@ static int rt5682_wclk_set_rate(struct clk_hw *hw, unsigned long rate,
         */
        parent_hw = clk_hw_get_parent(hw);
        if (!parent_hw)
-               dev_warn(component->dev,
+               dev_warn(rt5682->i2c_dev,
                        "Parent mclk of wclk not acquired in driver. Please ensure mclk was provided as %d Hz.\n",
                        CLK_PLL2_FIN);
 
        if (parent_rate != CLK_PLL2_FIN)
-               dev_warn(component->dev, "clk %s only support %d Hz input\n",
+               dev_warn(rt5682->i2c_dev, "clk %s only support %d Hz input\n",
                        clk_name, CLK_PLL2_FIN);
 
        /*
@@ -2690,10 +2734,9 @@ static unsigned long rt5682_bclk_recalc_rate(struct clk_hw *hw,
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_BCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
        unsigned int bclks_per_wclk;
 
-       bclks_per_wclk = snd_soc_component_read(component, RT5682_TDM_TCON_CTRL);
+       regmap_read(rt5682->regmap, RT5682_TDM_TCON_CTRL, &bclks_per_wclk);
 
        switch (bclks_per_wclk & RT5682_TDM_BCLK_MS1_MASK) {
        case RT5682_TDM_BCLK_MS1_256:
@@ -2754,20 +2797,22 @@ static int rt5682_bclk_set_rate(struct clk_hw *hw, unsigned long rate,
        struct rt5682_priv *rt5682 =
                container_of(hw, struct rt5682_priv,
                             dai_clks_hw[RT5682_DAI_BCLK_IDX]);
-       struct snd_soc_component *component = rt5682->component;
+       struct snd_soc_component *component;
        struct snd_soc_dai *dai;
        unsigned long factor;
 
        if (!rt5682_clk_check(rt5682))
                return -EINVAL;
 
+       component = rt5682->component;
+
        factor = rt5682_bclk_get_factor(rate, parent_rate);
 
        for_each_component_dais(component, dai)
                if (dai->id == RT5682_AIF1)
                        break;
        if (!dai) {
-               dev_err(component->dev, "dai %d not found in component\n",
+               dev_err(rt5682->i2c_dev, "dai %d not found in component\n",
                        RT5682_AIF1);
                return -ENODEV;
        }
@@ -2790,10 +2835,9 @@ static const struct clk_ops rt5682_dai_clk_ops[RT5682_DAI_NUM_CLKS] = {
        },
 };
 
-static int rt5682_register_dai_clks(struct snd_soc_component *component)
+int rt5682_register_dai_clks(struct rt5682_priv *rt5682)
 {
-       struct device *dev = component->dev;
-       struct rt5682_priv *rt5682 = snd_soc_component_get_drvdata(component);
+       struct device *dev = rt5682->i2c_dev;
        struct rt5682_platform_data *pdata = &rt5682->pdata;
        struct clk_hw *dai_clk_hw;
        int i, ret;
@@ -2851,6 +2895,7 @@ static int rt5682_register_dai_clks(struct snd_soc_component *component)
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(rt5682_register_dai_clks);
 #endif /* CONFIG_COMMON_CLK */
 
 static int rt5682_probe(struct snd_soc_component *component)
@@ -2860,9 +2905,6 @@ static int rt5682_probe(struct snd_soc_component *component)
        unsigned long time;
        struct snd_soc_dapm_context *dapm = &component->dapm;
 
-#ifdef CONFIG_COMMON_CLK
-       int ret;
-#endif
        rt5682->component = component;
 
        if (rt5682->is_sdw) {
@@ -2874,26 +2916,6 @@ static int rt5682_probe(struct snd_soc_component *component)
                        dev_err(&slave->dev, "Initialization not complete, timed out\n");
                        return -ETIMEDOUT;
                }
-       } else {
-#ifdef CONFIG_COMMON_CLK
-               /* Check if MCLK provided */
-               rt5682->mclk = devm_clk_get(component->dev, "mclk");
-               if (IS_ERR(rt5682->mclk)) {
-                       if (PTR_ERR(rt5682->mclk) != -ENOENT) {
-                               ret = PTR_ERR(rt5682->mclk);
-                               return ret;
-                       }
-                       rt5682->mclk = NULL;
-               }
-
-               /* Register CCF DAI clock control */
-               ret = rt5682_register_dai_clks(component);
-               if (ret)
-                       return ret;
-
-               /* Initial setup for CCF */
-               rt5682->lrck[RT5682_AIF1] = CLK_48;
-#endif
        }
 
        snd_soc_dapm_disable_pin(dapm, "MICBIAS");
index b592210..d93829c 100644 (file)
 #define RT5682_R_VOL_MASK                      (0x3f)
 #define RT5682_R_VOL_SFT                       0
 
+/* Headphone Amp Control 2 (0x0003) */
+#define RT5682_HP_C2_DAC_AMP_MUTE_SFT          15
+#define RT5682_HP_C2_DAC_AMP_MUTE              (0x1 << 15)
+#define RT5682_HP_C2_DAC_L_EN_SFT              14
+#define RT5682_HP_C2_DAC_L_EN                  (0x1 << 14)
+#define RT5682_HP_C2_DAC_R_EN_SFT              13
+#define RT5682_HP_C2_DAC_R_EN                  (0x1 << 13)
+
 /*Headphone Amp L/R Analog Gain and Digital NG2 Gain Control (0x0005 0x0006)*/
 #define RT5682_G_HP                            (0xf << 8)
 #define RT5682_G_HP_SFT                                8
 #define RT5682_HPA_CP_BIAS_6UA                 (0x3 << 2)
 
 /* Charge Pump Internal Register1 (0x0125) */
+#define RT5682_CP_SW_SIZE_MASK                 (0x7 << 8)
+#define RT5682_CP_SW_SIZE_L                    (0x4 << 8)
+#define RT5682_CP_SW_SIZE_M                    (0x2 << 8)
+#define RT5682_CP_SW_SIZE_S                    (0x1 << 8)
 #define RT5682_CP_CLK_HP_MASK                  (0x3 << 4)
 #define RT5682_CP_CLK_HP_100KHZ                        (0x0 << 4)
 #define RT5682_CP_CLK_HP_200KHZ                        (0x1 << 4)
 #define RT5682_DEB_STO_DAC_MASK                        (0x7 << 4)
 #define RT5682_DEB_80_MS                       (0x0 << 4)
 
+/* HP Behavior Logic Control 2 (0x01db) */
+#define RT5682_HP_LC2_SIG_SOUR2_MASK           (0x1 << 4)
+#define RT5682_HP_LC2_SIG_SOUR2_REG            (0x1 << 4)
+#define RT5682_HP_LC2_SIG_SOUR2_DC_CAL         (0x0 << 4)
+#define RT5682_HP_LC2_SIG_SOUR1_MASK           (0x7)
+#define RT5682_HP_LC2_SIG_SOUR1_1BIT           (0x7)
+#define RT5682_HP_LC2_SIG_SOUR1_LEGA           (0x2)
+
 /* SAR ADC Inline Command Control 1 (0x0210) */
 #define RT5682_SAR_BUTT_DET_MASK               (0x1 << 15)
 #define RT5682_SAR_BUTT_DET_EN                 (0x1 << 15)
@@ -1408,6 +1428,7 @@ enum {
 
 struct rt5682_priv {
        struct snd_soc_component *component;
+       struct device *i2c_dev;
        struct rt5682_platform_data pdata;
        struct regmap *regmap;
        struct regmap *sdw_regmap;
@@ -1462,6 +1483,8 @@ void rt5682_calibrate(struct rt5682_priv *rt5682);
 void rt5682_reset(struct rt5682_priv *rt5682);
 int rt5682_parse_dt(struct rt5682_priv *rt5682, struct device *dev);
 
+int rt5682_register_dai_clks(struct rt5682_priv *rt5682);
+
 #define RT5682_REG_NUM 318
 extern const struct reg_default rt5682_reg[RT5682_REG_NUM];
 
diff --git a/sound/soc/codecs/rt5682s.c b/sound/soc/codecs/rt5682s.c
new file mode 100644 (file)
index 0000000..470957f
--- /dev/null
@@ -0,0 +1,3197 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// rt5682s.c  --  RT5682I-VS ALSA SoC audio component driver
+//
+// Copyright 2021 Realtek Semiconductor Corp.
+// Author: Derek Fang <derek.fang@realtek.com>
+//
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/init.h>
+#include <linux/delay.h>
+#include <linux/pm.h>
+#include <linux/pm_runtime.h>
+#include <linux/i2c.h>
+#include <linux/platform_device.h>
+#include <linux/spi/spi.h>
+#include <linux/acpi.h>
+#include <linux/gpio.h>
+#include <linux/of_gpio.h>
+#include <linux/mutex.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/jack.h>
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/initval.h>
+#include <sound/tlv.h>
+#include <sound/rt5682s.h>
+
+#include "rt5682s.h"
+
+#define DEVICE_ID 0x6749
+
+static const struct rt5682s_platform_data i2s_default_platform_data = {
+       .dmic1_data_pin = RT5682S_DMIC1_DATA_GPIO2,
+       .dmic1_clk_pin = RT5682S_DMIC1_CLK_GPIO3,
+       .jd_src = RT5682S_JD1,
+       .dai_clk_names[RT5682S_DAI_WCLK_IDX] = "rt5682-dai-wclk",
+       .dai_clk_names[RT5682S_DAI_BCLK_IDX] = "rt5682-dai-bclk",
+};
+
+static const char *rt5682s_supply_names[RT5682S_NUM_SUPPLIES] = {
+       "AVDD",
+       "MICVDD",
+};
+
+static const struct reg_sequence patch_list[] = {
+       {RT5682S_I2C_CTRL,                      0x0007},
+       {RT5682S_DIG_IN_CTRL_1,                 0x0000},
+       {RT5682S_CHOP_DAC_2,                    0x2020},
+       {RT5682S_VREF_REC_OP_FB_CAP_CTRL_2,     0x0101},
+       {RT5682S_VREF_REC_OP_FB_CAP_CTRL_1,     0x80c0},
+       {RT5682S_HP_CALIB_CTRL_9,               0x0002},
+       {RT5682S_DEPOP_1,                       0x0000},
+       {RT5682S_HP_CHARGE_PUMP_2,              0x3c15},
+       {RT5682S_DAC1_DIG_VOL,                  0xfefe},
+       {RT5682S_SAR_IL_CMD_2,                  0xac00},
+       {RT5682S_SAR_IL_CMD_3,                  0x024c},
+       {RT5682S_CBJ_CTRL_6,                    0x0804},
+};
+
+static void rt5682s_apply_patch_list(struct rt5682s_priv *rt5682s,
+               struct device *dev)
+{
+       int ret;
+
+       ret = regmap_multi_reg_write(rt5682s->regmap, patch_list, ARRAY_SIZE(patch_list));
+       if (ret)
+               dev_warn(dev, "Failed to apply regmap patch: %d\n", ret);
+}
+
+static const struct reg_default rt5682s_reg[] = {
+       {0x0002, 0x8080},
+       {0x0003, 0x0001},
+       {0x0005, 0x0000},
+       {0x0006, 0x0000},
+       {0x0008, 0x8007},
+       {0x000b, 0x0000},
+       {0x000f, 0x4000},
+       {0x0010, 0x4040},
+       {0x0011, 0x0000},
+       {0x0012, 0x0000},
+       {0x0013, 0x1200},
+       {0x0014, 0x200a},
+       {0x0015, 0x0404},
+       {0x0016, 0x0404},
+       {0x0017, 0x05a4},
+       {0x0019, 0xffff},
+       {0x001c, 0x2f2f},
+       {0x001f, 0x0000},
+       {0x0022, 0x5757},
+       {0x0023, 0x0039},
+       {0x0024, 0x000b},
+       {0x0026, 0xc0c4},
+       {0x0029, 0x8080},
+       {0x002a, 0xa0a0},
+       {0x002b, 0x0300},
+       {0x0030, 0x0000},
+       {0x003c, 0x08c0},
+       {0x0044, 0x1818},
+       {0x004b, 0x00c0},
+       {0x004c, 0x0000},
+       {0x004d, 0x0000},
+       {0x0061, 0x00c0},
+       {0x0062, 0x008a},
+       {0x0063, 0x0800},
+       {0x0064, 0x0000},
+       {0x0065, 0x0000},
+       {0x0066, 0x0030},
+       {0x0067, 0x000c},
+       {0x0068, 0x0000},
+       {0x0069, 0x0000},
+       {0x006a, 0x0000},
+       {0x006b, 0x0000},
+       {0x006c, 0x0000},
+       {0x006d, 0x2200},
+       {0x006e, 0x0810},
+       {0x006f, 0xe4de},
+       {0x0070, 0x3320},
+       {0x0071, 0x0000},
+       {0x0073, 0x0000},
+       {0x0074, 0x0000},
+       {0x0075, 0x0002},
+       {0x0076, 0x0001},
+       {0x0079, 0x0000},
+       {0x007a, 0x0000},
+       {0x007b, 0x0000},
+       {0x007c, 0x0100},
+       {0x007e, 0x0000},
+       {0x007f, 0x0000},
+       {0x0080, 0x0000},
+       {0x0083, 0x0000},
+       {0x0084, 0x0000},
+       {0x0085, 0x0000},
+       {0x0086, 0x0005},
+       {0x0087, 0x0000},
+       {0x0088, 0x0000},
+       {0x008c, 0x0003},
+       {0x008e, 0x0060},
+       {0x008f, 0x4da1},
+       {0x0091, 0x1c15},
+       {0x0092, 0x0425},
+       {0x0093, 0x0000},
+       {0x0094, 0x0080},
+       {0x0095, 0x008f},
+       {0x0096, 0x0000},
+       {0x0097, 0x0000},
+       {0x0098, 0x0000},
+       {0x0099, 0x0000},
+       {0x009a, 0x0000},
+       {0x009b, 0x0000},
+       {0x009c, 0x0000},
+       {0x009d, 0x0000},
+       {0x009e, 0x0000},
+       {0x009f, 0x0009},
+       {0x00a0, 0x0000},
+       {0x00a3, 0x0002},
+       {0x00a4, 0x0001},
+       {0x00b6, 0x0000},
+       {0x00b7, 0x0000},
+       {0x00b8, 0x0000},
+       {0x00b9, 0x0002},
+       {0x00be, 0x0000},
+       {0x00c0, 0x0160},
+       {0x00c1, 0x82a0},
+       {0x00c2, 0x0000},
+       {0x00d0, 0x0000},
+       {0x00d2, 0x3300},
+       {0x00d3, 0x2200},
+       {0x00d4, 0x0000},
+       {0x00d9, 0x0000},
+       {0x00da, 0x0000},
+       {0x00db, 0x0000},
+       {0x00dc, 0x00c0},
+       {0x00dd, 0x2220},
+       {0x00de, 0x3131},
+       {0x00df, 0x3131},
+       {0x00e0, 0x3131},
+       {0x00e2, 0x0000},
+       {0x00e3, 0x4000},
+       {0x00e4, 0x0aa0},
+       {0x00e5, 0x3131},
+       {0x00e6, 0x3131},
+       {0x00e7, 0x3131},
+       {0x00e8, 0x3131},
+       {0x00ea, 0xb320},
+       {0x00eb, 0x0000},
+       {0x00f0, 0x0000},
+       {0x00f6, 0x0000},
+       {0x00fa, 0x0000},
+       {0x00fb, 0x0000},
+       {0x00fc, 0x0000},
+       {0x00fd, 0x0000},
+       {0x00fe, 0x10ec},
+       {0x00ff, 0x6749},
+       {0x0100, 0xa000},
+       {0x010b, 0x0066},
+       {0x010c, 0x6666},
+       {0x010d, 0x2202},
+       {0x010e, 0x6666},
+       {0x010f, 0xa800},
+       {0x0110, 0x0006},
+       {0x0111, 0x0460},
+       {0x0112, 0x2000},
+       {0x0113, 0x0200},
+       {0x0117, 0x8000},
+       {0x0118, 0x0303},
+       {0x0125, 0x0020},
+       {0x0132, 0x5026},
+       {0x0136, 0x8000},
+       {0x0139, 0x0005},
+       {0x013a, 0x3030},
+       {0x013b, 0xa000},
+       {0x013c, 0x4110},
+       {0x013f, 0x0000},
+       {0x0145, 0x0022},
+       {0x0146, 0x0000},
+       {0x0147, 0x0000},
+       {0x0148, 0x0000},
+       {0x0156, 0x0022},
+       {0x0157, 0x0303},
+       {0x0158, 0x2222},
+       {0x0159, 0x0000},
+       {0x0160, 0x4ec0},
+       {0x0161, 0x0080},
+       {0x0162, 0x0200},
+       {0x0163, 0x0800},
+       {0x0164, 0x0000},
+       {0x0165, 0x0000},
+       {0x0166, 0x0000},
+       {0x0167, 0x000f},
+       {0x0168, 0x000f},
+       {0x0169, 0x0001},
+       {0x0190, 0x4131},
+       {0x0194, 0x0000},
+       {0x0195, 0x0000},
+       {0x0197, 0x0022},
+       {0x0198, 0x0000},
+       {0x0199, 0x0000},
+       {0x01ac, 0x0000},
+       {0x01ad, 0x0000},
+       {0x01ae, 0x0000},
+       {0x01af, 0x2000},
+       {0x01b0, 0x0000},
+       {0x01b1, 0x0000},
+       {0x01b2, 0x0000},
+       {0x01b3, 0x0017},
+       {0x01b4, 0x004b},
+       {0x01b5, 0x0000},
+       {0x01b6, 0x03e8},
+       {0x01b7, 0x0000},
+       {0x01b8, 0x0000},
+       {0x01b9, 0x0400},
+       {0x01ba, 0xb5b6},
+       {0x01bb, 0x9124},
+       {0x01bc, 0x4924},
+       {0x01bd, 0x0009},
+       {0x01be, 0x0018},
+       {0x01bf, 0x002a},
+       {0x01c0, 0x004c},
+       {0x01c1, 0x0097},
+       {0x01c2, 0x01c3},
+       {0x01c3, 0x03e9},
+       {0x01c4, 0x1389},
+       {0x01c5, 0xc351},
+       {0x01c6, 0x02a0},
+       {0x01c7, 0x0b0f},
+       {0x01c8, 0x402f},
+       {0x01c9, 0x0702},
+       {0x01ca, 0x0000},
+       {0x01cb, 0x0000},
+       {0x01cc, 0x5757},
+       {0x01cd, 0x5757},
+       {0x01ce, 0x5757},
+       {0x01cf, 0x5757},
+       {0x01d0, 0x5757},
+       {0x01d1, 0x5757},
+       {0x01d2, 0x5757},
+       {0x01d3, 0x5757},
+       {0x01d4, 0x5757},
+       {0x01d5, 0x5757},
+       {0x01d6, 0x0000},
+       {0x01d7, 0x0000},
+       {0x01d8, 0x0162},
+       {0x01d9, 0x0007},
+       {0x01da, 0x0000},
+       {0x01db, 0x0004},
+       {0x01dc, 0x0000},
+       {0x01de, 0x7c00},
+       {0x01df, 0x0020},
+       {0x01e0, 0x04c1},
+       {0x01e1, 0x0000},
+       {0x01e2, 0x0000},
+       {0x01e3, 0x0000},
+       {0x01e4, 0x0000},
+       {0x01e5, 0x0000},
+       {0x01e6, 0x0001},
+       {0x01e7, 0x0000},
+       {0x01e8, 0x0000},
+       {0x01eb, 0x0000},
+       {0x01ec, 0x0000},
+       {0x01ed, 0x0000},
+       {0x01ee, 0x0000},
+       {0x01ef, 0x0000},
+       {0x01f0, 0x0000},
+       {0x01f1, 0x0000},
+       {0x01f2, 0x0000},
+       {0x01f3, 0x0000},
+       {0x01f4, 0x0000},
+       {0x0210, 0x6297},
+       {0x0211, 0xa004},
+       {0x0212, 0x0365},
+       {0x0213, 0xf7ff},
+       {0x0214, 0xf24c},
+       {0x0215, 0x0102},
+       {0x0216, 0x00a3},
+       {0x0217, 0x0048},
+       {0x0218, 0xa2c0},
+       {0x0219, 0x0400},
+       {0x021a, 0x00c8},
+       {0x021b, 0x00c0},
+       {0x021c, 0x0000},
+       {0x021d, 0x024c},
+       {0x02fa, 0x0000},
+       {0x02fb, 0x0000},
+       {0x02fc, 0x0000},
+       {0x03fe, 0x0000},
+       {0x03ff, 0x0000},
+       {0x0500, 0x0000},
+       {0x0600, 0x0000},
+       {0x0610, 0x6666},
+       {0x0611, 0xa9aa},
+       {0x0620, 0x6666},
+       {0x0621, 0xa9aa},
+       {0x0630, 0x6666},
+       {0x0631, 0xa9aa},
+       {0x0640, 0x6666},
+       {0x0641, 0xa9aa},
+       {0x07fa, 0x0000},
+       {0x08fa, 0x0000},
+       {0x08fb, 0x0000},
+       {0x0d00, 0x0000},
+       {0x1100, 0x0000},
+       {0x1101, 0x0000},
+       {0x1102, 0x0000},
+       {0x1103, 0x0000},
+       {0x1104, 0x0000},
+       {0x1105, 0x0000},
+       {0x1106, 0x0000},
+       {0x1107, 0x0000},
+       {0x1108, 0x0000},
+       {0x1109, 0x0000},
+       {0x110a, 0x0000},
+       {0x110b, 0x0000},
+       {0x110c, 0x0000},
+       {0x1111, 0x0000},
+       {0x1112, 0x0000},
+       {0x1113, 0x0000},
+       {0x1114, 0x0000},
+       {0x1115, 0x0000},
+       {0x1116, 0x0000},
+       {0x1117, 0x0000},
+       {0x1118, 0x0000},
+       {0x1119, 0x0000},
+       {0x111a, 0x0000},
+       {0x111b, 0x0000},
+       {0x111c, 0x0000},
+       {0x1401, 0x0404},
+       {0x1402, 0x0007},
+       {0x1403, 0x0365},
+       {0x1404, 0x0210},
+       {0x1405, 0x0365},
+       {0x1406, 0x0210},
+       {0x1407, 0x0000},
+       {0x1408, 0x0000},
+       {0x1409, 0x0000},
+       {0x140a, 0x0000},
+       {0x140b, 0x0000},
+       {0x140c, 0x0000},
+       {0x140d, 0x0000},
+       {0x140e, 0x0000},
+       {0x140f, 0x0000},
+       {0x1410, 0x0000},
+       {0x1411, 0x0000},
+       {0x1801, 0x0004},
+       {0x1802, 0x0000},
+       {0x1803, 0x0000},
+       {0x1804, 0x0000},
+       {0x1805, 0x00ff},
+       {0x2c00, 0x0000},
+       {0x3400, 0x0200},
+       {0x3404, 0x0000},
+       {0x3405, 0x0000},
+       {0x3406, 0x0000},
+       {0x3407, 0x0000},
+       {0x3408, 0x0000},
+       {0x3409, 0x0000},
+       {0x340a, 0x0000},
+       {0x340b, 0x0000},
+       {0x340c, 0x0000},
+       {0x340d, 0x0000},
+       {0x340e, 0x0000},
+       {0x340f, 0x0000},
+       {0x3410, 0x0000},
+       {0x3411, 0x0000},
+       {0x3412, 0x0000},
+       {0x3413, 0x0000},
+       {0x3414, 0x0000},
+       {0x3415, 0x0000},
+       {0x3424, 0x0000},
+       {0x3425, 0x0000},
+       {0x3426, 0x0000},
+       {0x3427, 0x0000},
+       {0x3428, 0x0000},
+       {0x3429, 0x0000},
+       {0x342a, 0x0000},
+       {0x342b, 0x0000},
+       {0x342c, 0x0000},
+       {0x342d, 0x0000},
+       {0x342e, 0x0000},
+       {0x342f, 0x0000},
+       {0x3430, 0x0000},
+       {0x3431, 0x0000},
+       {0x3432, 0x0000},
+       {0x3433, 0x0000},
+       {0x3434, 0x0000},
+       {0x3435, 0x0000},
+       {0x3440, 0x6319},
+       {0x3441, 0x3771},
+       {0x3500, 0x0002},
+       {0x3501, 0x5728},
+       {0x3b00, 0x3010},
+       {0x3b01, 0x3300},
+       {0x3b02, 0x2200},
+       {0x3b03, 0x0100},
+};
+
+static bool rt5682s_volatile_register(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case RT5682S_RESET:
+       case RT5682S_CBJ_CTRL_2:
+       case RT5682S_I2S1_F_DIV_CTRL_2:
+       case RT5682S_I2S2_F_DIV_CTRL_2:
+       case RT5682S_INT_ST_1:
+       case RT5682S_GPIO_ST:
+       case RT5682S_IL_CMD_1:
+       case RT5682S_4BTN_IL_CMD_1:
+       case RT5682S_AJD1_CTRL:
+       case RT5682S_VERSION_ID...RT5682S_DEVICE_ID:
+       case RT5682S_STO_NG2_CTRL_1:
+       case RT5682S_STO_NG2_CTRL_5...RT5682S_STO_NG2_CTRL_7:
+       case RT5682S_STO1_DAC_SIL_DET:
+       case RT5682S_HP_IMP_SENS_CTRL_1...RT5682S_HP_IMP_SENS_CTRL_4:
+       case RT5682S_HP_IMP_SENS_CTRL_13:
+       case RT5682S_HP_IMP_SENS_CTRL_14:
+       case RT5682S_HP_IMP_SENS_CTRL_43...RT5682S_HP_IMP_SENS_CTRL_46:
+       case RT5682S_HP_CALIB_CTRL_1:
+       case RT5682S_HP_CALIB_CTRL_10:
+       case RT5682S_HP_CALIB_ST_1...RT5682S_HP_CALIB_ST_11:
+       case RT5682S_SAR_IL_CMD_2...RT5682S_SAR_IL_CMD_5:
+       case RT5682S_SAR_IL_CMD_10:
+       case RT5682S_SAR_IL_CMD_11:
+       case RT5682S_VERSION_ID_HIDE:
+       case RT5682S_VERSION_ID_CUS:
+       case RT5682S_I2C_TRANS_CTRL:
+       case RT5682S_DMIC_FLOAT_DET:
+       case RT5682S_HA_CMP_OP_1:
+       case RT5682S_NEW_CBJ_DET_CTL_10...RT5682S_NEW_CBJ_DET_CTL_16:
+       case RT5682S_CLK_SW_TEST_1:
+       case RT5682S_CLK_SW_TEST_2:
+       case RT5682S_EFUSE_READ_1...RT5682S_EFUSE_READ_18:
+       case RT5682S_PILOT_DIG_CTL_1:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool rt5682s_readable_register(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case RT5682S_RESET:
+       case RT5682S_VERSION_ID:
+       case RT5682S_VENDOR_ID:
+       case RT5682S_DEVICE_ID:
+       case RT5682S_HP_CTRL_1:
+       case RT5682S_HP_CTRL_2:
+       case RT5682S_HPL_GAIN:
+       case RT5682S_HPR_GAIN:
+       case RT5682S_I2C_CTRL:
+       case RT5682S_CBJ_BST_CTRL:
+       case RT5682S_CBJ_DET_CTRL:
+       case RT5682S_CBJ_CTRL_1...RT5682S_CBJ_CTRL_8:
+       case RT5682S_DAC1_DIG_VOL:
+       case RT5682S_STO1_ADC_DIG_VOL:
+       case RT5682S_STO1_ADC_BOOST:
+       case RT5682S_HP_IMP_GAIN_1:
+       case RT5682S_HP_IMP_GAIN_2:
+       case RT5682S_SIDETONE_CTRL:
+       case RT5682S_STO1_ADC_MIXER:
+       case RT5682S_AD_DA_MIXER:
+       case RT5682S_STO1_DAC_MIXER:
+       case RT5682S_A_DAC1_MUX:
+       case RT5682S_DIG_INF2_DATA:
+       case RT5682S_REC_MIXER:
+       case RT5682S_CAL_REC:
+       case RT5682S_HP_ANA_OST_CTRL_1...RT5682S_HP_ANA_OST_CTRL_3:
+       case RT5682S_PWR_DIG_1...RT5682S_PWR_MIXER:
+       case RT5682S_MB_CTRL:
+       case RT5682S_CLK_GATE_TCON_1...RT5682S_CLK_GATE_TCON_3:
+       case RT5682S_CLK_DET...RT5682S_LPF_AD_DMIC:
+       case RT5682S_I2S1_SDP:
+       case RT5682S_I2S2_SDP:
+       case RT5682S_ADDA_CLK_1:
+       case RT5682S_ADDA_CLK_2:
+       case RT5682S_I2S1_F_DIV_CTRL_1:
+       case RT5682S_I2S1_F_DIV_CTRL_2:
+       case RT5682S_TDM_CTRL:
+       case RT5682S_TDM_ADDA_CTRL_1:
+       case RT5682S_TDM_ADDA_CTRL_2:
+       case RT5682S_DATA_SEL_CTRL_1:
+       case RT5682S_TDM_TCON_CTRL_1:
+       case RT5682S_TDM_TCON_CTRL_2:
+       case RT5682S_GLB_CLK:
+       case RT5682S_PLL_TRACK_1...RT5682S_PLL_TRACK_6:
+       case RT5682S_PLL_TRACK_11:
+       case RT5682S_DEPOP_1:
+       case RT5682S_HP_CHARGE_PUMP_1:
+       case RT5682S_HP_CHARGE_PUMP_2:
+       case RT5682S_HP_CHARGE_PUMP_3:
+       case RT5682S_MICBIAS_1...RT5682S_MICBIAS_3:
+       case RT5682S_PLL_TRACK_12...RT5682S_PLL_CTRL_7:
+       case RT5682S_RC_CLK_CTRL:
+       case RT5682S_I2S2_M_CLK_CTRL_1:
+       case RT5682S_I2S2_F_DIV_CTRL_1:
+       case RT5682S_I2S2_F_DIV_CTRL_2:
+       case RT5682S_IRQ_CTRL_1...RT5682S_IRQ_CTRL_4:
+       case RT5682S_INT_ST_1:
+       case RT5682S_GPIO_CTRL_1:
+       case RT5682S_GPIO_CTRL_2:
+       case RT5682S_GPIO_ST:
+       case RT5682S_HP_AMP_DET_CTRL_1:
+       case RT5682S_MID_HP_AMP_DET:
+       case RT5682S_LOW_HP_AMP_DET:
+       case RT5682S_DELAY_BUF_CTRL:
+       case RT5682S_SV_ZCD_1:
+       case RT5682S_SV_ZCD_2:
+       case RT5682S_IL_CMD_1...RT5682S_IL_CMD_6:
+       case RT5682S_4BTN_IL_CMD_1...RT5682S_4BTN_IL_CMD_7:
+       case RT5682S_ADC_STO1_HP_CTRL_1:
+       case RT5682S_ADC_STO1_HP_CTRL_2:
+       case RT5682S_AJD1_CTRL:
+       case RT5682S_JD_CTRL_1:
+       case RT5682S_DUMMY_1...RT5682S_DUMMY_3:
+       case RT5682S_DAC_ADC_DIG_VOL1:
+       case RT5682S_BIAS_CUR_CTRL_2...RT5682S_BIAS_CUR_CTRL_10:
+       case RT5682S_VREF_REC_OP_FB_CAP_CTRL_1:
+       case RT5682S_VREF_REC_OP_FB_CAP_CTRL_2:
+       case RT5682S_CHARGE_PUMP_1:
+       case RT5682S_DIG_IN_CTRL_1:
+       case RT5682S_PAD_DRIVING_CTRL:
+       case RT5682S_CHOP_DAC_1:
+       case RT5682S_CHOP_DAC_2:
+       case RT5682S_CHOP_ADC:
+       case RT5682S_CALIB_ADC_CTRL:
+       case RT5682S_VOL_TEST:
+       case RT5682S_SPKVDD_DET_ST:
+       case RT5682S_TEST_MODE_CTRL_1...RT5682S_TEST_MODE_CTRL_4:
+       case RT5682S_PLL_INTERNAL_1...RT5682S_PLL_INTERNAL_4:
+       case RT5682S_STO_NG2_CTRL_1...RT5682S_STO_NG2_CTRL_10:
+       case RT5682S_STO1_DAC_SIL_DET:
+       case RT5682S_SIL_PSV_CTRL1:
+       case RT5682S_SIL_PSV_CTRL2:
+       case RT5682S_SIL_PSV_CTRL3:
+       case RT5682S_SIL_PSV_CTRL4:
+       case RT5682S_SIL_PSV_CTRL5:
+       case RT5682S_HP_IMP_SENS_CTRL_1...RT5682S_HP_IMP_SENS_CTRL_46:
+       case RT5682S_HP_LOGIC_CTRL_1...RT5682S_HP_LOGIC_CTRL_3:
+       case RT5682S_HP_CALIB_CTRL_1...RT5682S_HP_CALIB_CTRL_11:
+       case RT5682S_HP_CALIB_ST_1...RT5682S_HP_CALIB_ST_11:
+       case RT5682S_SAR_IL_CMD_1...RT5682S_SAR_IL_CMD_14:
+       case RT5682S_DUMMY_4...RT5682S_DUMMY_6:
+       case RT5682S_VERSION_ID_HIDE:
+       case RT5682S_VERSION_ID_CUS:
+       case RT5682S_SCAN_CTL:
+       case RT5682S_HP_AMP_DET:
+       case RT5682S_BIAS_CUR_CTRL_11:
+       case RT5682S_BIAS_CUR_CTRL_12:
+       case RT5682S_BIAS_CUR_CTRL_13:
+       case RT5682S_BIAS_CUR_CTRL_14:
+       case RT5682S_BIAS_CUR_CTRL_15:
+       case RT5682S_BIAS_CUR_CTRL_16:
+       case RT5682S_BIAS_CUR_CTRL_17:
+       case RT5682S_BIAS_CUR_CTRL_18:
+       case RT5682S_I2C_TRANS_CTRL:
+       case RT5682S_DUMMY_7:
+       case RT5682S_DUMMY_8:
+       case RT5682S_DMIC_FLOAT_DET:
+       case RT5682S_HA_CMP_OP_1...RT5682S_HA_CMP_OP_13:
+       case RT5682S_HA_CMP_OP_14...RT5682S_HA_CMP_OP_25:
+       case RT5682S_NEW_CBJ_DET_CTL_1...RT5682S_NEW_CBJ_DET_CTL_16:
+       case RT5682S_DA_FILTER_1...RT5682S_DA_FILTER_5:
+       case RT5682S_CLK_SW_TEST_1:
+       case RT5682S_CLK_SW_TEST_2:
+       case RT5682S_CLK_SW_TEST_3...RT5682S_CLK_SW_TEST_14:
+       case RT5682S_EFUSE_MANU_WRITE_1...RT5682S_EFUSE_MANU_WRITE_6:
+       case RT5682S_EFUSE_READ_1...RT5682S_EFUSE_READ_18:
+       case RT5682S_EFUSE_TIMING_CTL_1:
+       case RT5682S_EFUSE_TIMING_CTL_2:
+       case RT5682S_PILOT_DIG_CTL_1:
+       case RT5682S_PILOT_DIG_CTL_2:
+       case RT5682S_HP_AMP_DET_CTL_1...RT5682S_HP_AMP_DET_CTL_4:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static void rt5682s_reset(struct rt5682s_priv *rt5682s)
+{
+       regmap_write(rt5682s->regmap, RT5682S_RESET, 0);
+}
+
+static int rt5682s_button_detect(struct snd_soc_component *component)
+{
+       int btn_type, val;
+
+       val = snd_soc_component_read(component, RT5682S_4BTN_IL_CMD_1);
+       btn_type = val & 0xfff0;
+       snd_soc_component_write(component, RT5682S_4BTN_IL_CMD_1, val);
+       dev_dbg(component->dev, "%s btn_type=%x\n", __func__, btn_type);
+       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_2,
+               RT5682S_SAR_ADC_PSV_MASK, RT5682S_SAR_ADC_PSV_ENTRY);
+
+       return btn_type;
+}
+
+enum {
+       SAR_PWR_OFF,
+       SAR_PWR_NORMAL,
+       SAR_PWR_SAVING,
+};
+
+static void rt5682s_sar_power_mode(struct snd_soc_component *component,
+                               int mode, int jd_step)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       mutex_lock(&rt5682s->sar_mutex);
+
+       switch (mode) {
+       case SAR_PWR_SAVING:
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_3,
+                       RT5682S_CBJ_IN_BUF_MASK, RT5682S_CBJ_IN_BUF_DIS);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_MB1_PATH_MASK | RT5682S_MB2_PATH_MASK,
+                       RT5682S_CTRL_MB1_REG | RT5682S_CTRL_MB2_REG);
+               snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                       RT5682S_SAR_BUTDET_MASK | RT5682S_SAR_BUTDET_POW_MASK |
+                       RT5682S_SAR_SEL_MB1_2_CTL_MASK, RT5682S_SAR_BUTDET_DIS |
+                       RT5682S_SAR_BUTDET_POW_SAV | RT5682S_SAR_SEL_MB1_2_MANU);
+               usleep_range(5000, 5500);
+               snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                       RT5682S_SAR_BUTDET_MASK, RT5682S_SAR_BUTDET_EN);
+               usleep_range(5000, 5500);
+               snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_2,
+                       RT5682S_SAR_ADC_PSV_MASK, RT5682S_SAR_ADC_PSV_ENTRY);
+               break;
+       case SAR_PWR_NORMAL:
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_3,
+                       RT5682S_CBJ_IN_BUF_MASK, RT5682S_CBJ_IN_BUF_EN);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_MB1_PATH_MASK | RT5682S_MB2_PATH_MASK,
+                       RT5682S_CTRL_MB1_FSM | RT5682S_CTRL_MB2_FSM);
+               if (!jd_step) {
+                       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                               RT5682S_SAR_SEL_MB1_2_CTL_MASK, RT5682S_SAR_SEL_MB1_2_AUTO);
+                       usleep_range(5000, 5500);
+                       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                               RT5682S_SAR_BUTDET_MASK | RT5682S_SAR_BUTDET_POW_MASK,
+                               RT5682S_SAR_BUTDET_EN | RT5682S_SAR_BUTDET_POW_NORM);
+               }
+               break;
+       case SAR_PWR_OFF:
+               snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                       RT5682S_SAR_BUTDET_MASK | RT5682S_SAR_BUTDET_POW_MASK |
+                       RT5682S_SAR_SEL_MB1_2_CTL_MASK, RT5682S_SAR_BUTDET_DIS |
+                       RT5682S_SAR_BUTDET_POW_SAV | RT5682S_SAR_SEL_MB1_2_MANU);
+               break;
+       default:
+               dev_err(component->dev, "Invalid SAR Power mode: %d\n", mode);
+               break;
+       }
+
+       mutex_unlock(&rt5682s->sar_mutex);
+}
+
+static void rt5682s_enable_push_button_irq(struct snd_soc_component *component)
+{
+       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_13,
+               RT5682S_SAR_SOUR_MASK, RT5682S_SAR_SOUR_BTN);
+       snd_soc_component_write(component, RT5682S_IL_CMD_1, 0x0040);
+       snd_soc_component_update_bits(component, RT5682S_4BTN_IL_CMD_2,
+               RT5682S_4BTN_IL_MASK | RT5682S_4BTN_IL_RST_MASK,
+               RT5682S_4BTN_IL_EN | RT5682S_4BTN_IL_NOR);
+       snd_soc_component_update_bits(component, RT5682S_IRQ_CTRL_3,
+               RT5682S_IL_IRQ_MASK, RT5682S_IL_IRQ_EN);
+}
+
+static void rt5682s_disable_push_button_irq(struct snd_soc_component *component)
+{
+       snd_soc_component_update_bits(component, RT5682S_IRQ_CTRL_3,
+               RT5682S_IL_IRQ_MASK, RT5682S_IL_IRQ_DIS);
+       snd_soc_component_update_bits(component, RT5682S_4BTN_IL_CMD_2,
+               RT5682S_4BTN_IL_MASK, RT5682S_4BTN_IL_DIS);
+       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_13,
+               RT5682S_SAR_SOUR_MASK, RT5682S_SAR_SOUR_TYPE);
+}
+
+/**
+ * rt5682s_headset_detect - Detect headset.
+ * @component: SoC audio component device.
+ * @jack_insert: Jack insert or not.
+ *
+ * Detect whether is headset or not when jack inserted.
+ *
+ * Returns detect status.
+ */
+static int rt5682s_headset_detect(struct snd_soc_component *component, int jack_insert)
+{
+       unsigned int val, count;
+       int jack_type = 0;
+
+       if (jack_insert) {
+               rt5682s_disable_push_button_irq(component);
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+                       RT5682S_PWR_VREF1 | RT5682S_PWR_VREF2 | RT5682S_PWR_MB,
+                       RT5682S_PWR_VREF1 | RT5682S_PWR_VREF2 | RT5682S_PWR_MB);
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+                       RT5682S_PWR_FV1 | RT5682S_PWR_FV2, 0);
+               usleep_range(15000, 20000);
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+                       RT5682S_PWR_FV1 | RT5682S_PWR_FV2,
+                       RT5682S_PWR_FV1 | RT5682S_PWR_FV2);
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_3,
+                       RT5682S_PWR_CBJ, RT5682S_PWR_CBJ);
+               snd_soc_component_write(component, RT5682S_SAR_IL_CMD_3, 0x0365);
+               snd_soc_component_update_bits(component, RT5682S_HP_CHARGE_PUMP_2,
+                       RT5682S_OSW_L_MASK | RT5682S_OSW_R_MASK,
+                       RT5682S_OSW_L_DIS | RT5682S_OSW_R_DIS);
+               snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_13,
+                       RT5682S_SAR_SOUR_MASK, RT5682S_SAR_SOUR_TYPE);
+               rt5682s_sar_power_mode(component, SAR_PWR_NORMAL, 1);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_TRIG_JD_MASK, RT5682S_TRIG_JD_LOW);
+               usleep_range(45000, 50000);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_TRIG_JD_MASK, RT5682S_TRIG_JD_HIGH);
+
+               count = 0;
+               do {
+                       usleep_range(10000, 15000);
+                       val = snd_soc_component_read(component, RT5682S_CBJ_CTRL_2)
+                               & RT5682S_JACK_TYPE_MASK;
+                       count++;
+               } while (val == 0 && count < 50);
+
+               dev_dbg(component->dev, "%s, val=%d, count=%d\n", __func__, val, count);
+
+               switch (val) {
+               case 0x1:
+               case 0x2:
+                       jack_type = SND_JACK_HEADSET;
+                       snd_soc_component_write(component, RT5682S_SAR_IL_CMD_3, 0x024c);
+                       snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                               RT5682S_FAST_OFF_MASK, RT5682S_FAST_OFF_EN);
+                       snd_soc_component_update_bits(component, RT5682S_SAR_IL_CMD_1,
+                               RT5682S_SAR_SEL_MB1_2_MASK, val << RT5682S_SAR_SEL_MB1_2_SFT);
+                       if (!snd_soc_dapm_get_pin_status(&component->dapm, "SAR"))
+                               rt5682s_sar_power_mode(component, SAR_PWR_SAVING, 1);
+                       rt5682s_enable_push_button_irq(component);
+                       break;
+               default:
+                       jack_type = SND_JACK_HEADPHONE;
+                       break;
+               }
+               snd_soc_component_update_bits(component, RT5682S_HP_CHARGE_PUMP_2,
+                       RT5682S_OSW_L_MASK | RT5682S_OSW_R_MASK,
+                       RT5682S_OSW_L_EN | RT5682S_OSW_R_EN);
+               usleep_range(35000, 40000);
+       } else {
+               rt5682s_sar_power_mode(component, SAR_PWR_OFF, 1);
+               rt5682s_disable_push_button_irq(component);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_TRIG_JD_MASK, RT5682S_TRIG_JD_LOW);
+
+               if (!snd_soc_dapm_get_pin_status(&component->dapm, "MICBIAS"))
+                       snd_soc_component_update_bits(component,
+                               RT5682S_PWR_ANLG_1, RT5682S_PWR_MB, 0);
+               if (!snd_soc_dapm_get_pin_status(&component->dapm, "Vref2"))
+                       snd_soc_component_update_bits(component,
+                               RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2, 0);
+
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_3,
+                       RT5682S_PWR_CBJ, 0);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_1,
+                       RT5682S_FAST_OFF_MASK, RT5682S_FAST_OFF_DIS);
+               snd_soc_component_update_bits(component, RT5682S_CBJ_CTRL_3,
+                       RT5682S_CBJ_IN_BUF_MASK, RT5682S_CBJ_IN_BUF_DIS);
+               jack_type = 0;
+       }
+
+       dev_dbg(component->dev, "jack_type = %d\n", jack_type);
+
+       return jack_type;
+}
+
+static void rt5682s_jack_detect_handler(struct work_struct *work)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(work, struct rt5682s_priv, jack_detect_work.work);
+       int val, btn_type;
+
+       while (!rt5682s->component)
+               usleep_range(10000, 15000);
+
+       while (!rt5682s->component->card->instantiated)
+               usleep_range(10000, 15000);
+
+       mutex_lock(&rt5682s->jdet_mutex);
+       mutex_lock(&rt5682s->calibrate_mutex);
+
+       val = snd_soc_component_read(rt5682s->component, RT5682S_AJD1_CTRL)
+               & RT5682S_JDH_RS_MASK;
+       if (!val) {
+               /* jack in */
+               if (rt5682s->jack_type == 0) {
+                       /* jack was out, report jack type */
+                       rt5682s->jack_type = rt5682s_headset_detect(rt5682s->component, 1);
+                       rt5682s->irq_work_delay_time = 0;
+               } else if ((rt5682s->jack_type & SND_JACK_HEADSET) == SND_JACK_HEADSET) {
+                       /* jack is already in, report button event */
+                       rt5682s->jack_type = SND_JACK_HEADSET;
+                       btn_type = rt5682s_button_detect(rt5682s->component);
+                       /**
+                        * rt5682s can report three kinds of button behavior,
+                        * one click, double click and hold. However,
+                        * currently we will report button pressed/released
+                        * event. So all the three button behaviors are
+                        * treated as button pressed.
+                        */
+                       switch (btn_type) {
+                       case 0x8000:
+                       case 0x4000:
+                       case 0x2000:
+                               rt5682s->jack_type |= SND_JACK_BTN_0;
+                               break;
+                       case 0x1000:
+                       case 0x0800:
+                       case 0x0400:
+                               rt5682s->jack_type |= SND_JACK_BTN_1;
+                               break;
+                       case 0x0200:
+                       case 0x0100:
+                       case 0x0080:
+                               rt5682s->jack_type |= SND_JACK_BTN_2;
+                               break;
+                       case 0x0040:
+                       case 0x0020:
+                       case 0x0010:
+                               rt5682s->jack_type |= SND_JACK_BTN_3;
+                               break;
+                       case 0x0000: /* unpressed */
+                               break;
+                       default:
+                               dev_err(rt5682s->component->dev,
+                                       "Unexpected button code 0x%04x\n", btn_type);
+                               break;
+                       }
+               }
+       } else {
+               /* jack out */
+               rt5682s->jack_type = rt5682s_headset_detect(rt5682s->component, 0);
+               rt5682s->irq_work_delay_time = 50;
+       }
+
+       snd_soc_jack_report(rt5682s->hs_jack, rt5682s->jack_type,
+               SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+               SND_JACK_BTN_2 | SND_JACK_BTN_3);
+
+       if (rt5682s->jack_type & (SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+               SND_JACK_BTN_2 | SND_JACK_BTN_3))
+               schedule_delayed_work(&rt5682s->jd_check_work, 0);
+       else
+               cancel_delayed_work_sync(&rt5682s->jd_check_work);
+
+       mutex_unlock(&rt5682s->calibrate_mutex);
+       mutex_unlock(&rt5682s->jdet_mutex);
+}
+
+static void rt5682s_jd_check_handler(struct work_struct *work)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(work, struct rt5682s_priv, jd_check_work.work);
+
+       if (snd_soc_component_read(rt5682s->component, RT5682S_AJD1_CTRL)
+               & RT5682S_JDH_RS_MASK) {
+               /* jack out */
+               rt5682s->jack_type = rt5682s_headset_detect(rt5682s->component, 0);
+
+               snd_soc_jack_report(rt5682s->hs_jack, rt5682s->jack_type,
+                       SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+                       SND_JACK_BTN_2 | SND_JACK_BTN_3);
+       } else {
+               schedule_delayed_work(&rt5682s->jd_check_work, 500);
+       }
+}
+
+static irqreturn_t rt5682s_irq(int irq, void *data)
+{
+       struct rt5682s_priv *rt5682s = data;
+
+       mod_delayed_work(system_power_efficient_wq, &rt5682s->jack_detect_work,
+               msecs_to_jiffies(rt5682s->irq_work_delay_time));
+
+       return IRQ_HANDLED;
+}
+
+static int rt5682s_set_jack_detect(struct snd_soc_component *component,
+               struct snd_soc_jack *hs_jack, void *data)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       int btndet_delay = 16;
+
+       rt5682s->hs_jack = hs_jack;
+
+       if (!hs_jack) {
+               regmap_update_bits(rt5682s->regmap, RT5682S_IRQ_CTRL_2,
+                       RT5682S_JD1_EN_MASK, RT5682S_JD1_DIS);
+               regmap_update_bits(rt5682s->regmap, RT5682S_RC_CLK_CTRL,
+                       RT5682S_POW_JDH, 0);
+               cancel_delayed_work_sync(&rt5682s->jack_detect_work);
+
+               return 0;
+       }
+
+       switch (rt5682s->pdata.jd_src) {
+       case RT5682S_JD1:
+               regmap_update_bits(rt5682s->regmap, RT5682S_CBJ_CTRL_5,
+                       RT5682S_JD_FAST_OFF_SRC_MASK, RT5682S_JD_FAST_OFF_SRC_JDH);
+               regmap_update_bits(rt5682s->regmap, RT5682S_CBJ_CTRL_2,
+                       RT5682S_EXT_JD_SRC, RT5682S_EXT_JD_SRC_MANUAL);
+               regmap_update_bits(rt5682s->regmap, RT5682S_CBJ_CTRL_1,
+                       RT5682S_EMB_JD_MASK | RT5682S_DET_TYPE |
+                       RT5682S_POL_FAST_OFF_MASK | RT5682S_MIC_CAP_MASK,
+                       RT5682S_EMB_JD_EN | RT5682S_DET_TYPE |
+                       RT5682S_POL_FAST_OFF_HIGH | RT5682S_MIC_CAP_HS);
+               regmap_update_bits(rt5682s->regmap, RT5682S_SAR_IL_CMD_1,
+                       RT5682S_SAR_POW_MASK, RT5682S_SAR_POW_EN);
+               regmap_update_bits(rt5682s->regmap, RT5682S_GPIO_CTRL_1,
+                       RT5682S_GP1_PIN_MASK, RT5682S_GP1_PIN_IRQ);
+               regmap_update_bits(rt5682s->regmap, RT5682S_PWR_ANLG_3,
+                       RT5682S_PWR_BGLDO, RT5682S_PWR_BGLDO);
+               regmap_update_bits(rt5682s->regmap, RT5682S_PWR_ANLG_2,
+                       RT5682S_PWR_JD_MASK, RT5682S_PWR_JD_ENABLE);
+               regmap_update_bits(rt5682s->regmap, RT5682S_RC_CLK_CTRL,
+                       RT5682S_POW_IRQ | RT5682S_POW_JDH, RT5682S_POW_IRQ | RT5682S_POW_JDH);
+               regmap_update_bits(rt5682s->regmap, RT5682S_IRQ_CTRL_2,
+                       RT5682S_JD1_EN_MASK | RT5682S_JD1_POL_MASK,
+                       RT5682S_JD1_EN | RT5682S_JD1_POL_NOR);
+               regmap_update_bits(rt5682s->regmap, RT5682S_4BTN_IL_CMD_4,
+                       RT5682S_4BTN_IL_HOLD_WIN_MASK | RT5682S_4BTN_IL_CLICK_WIN_MASK,
+                       (btndet_delay << RT5682S_4BTN_IL_HOLD_WIN_SFT | btndet_delay));
+               regmap_update_bits(rt5682s->regmap, RT5682S_4BTN_IL_CMD_5,
+                       RT5682S_4BTN_IL_HOLD_WIN_MASK | RT5682S_4BTN_IL_CLICK_WIN_MASK,
+                       (btndet_delay << RT5682S_4BTN_IL_HOLD_WIN_SFT | btndet_delay));
+               regmap_update_bits(rt5682s->regmap, RT5682S_4BTN_IL_CMD_6,
+                       RT5682S_4BTN_IL_HOLD_WIN_MASK | RT5682S_4BTN_IL_CLICK_WIN_MASK,
+                       (btndet_delay << RT5682S_4BTN_IL_HOLD_WIN_SFT | btndet_delay));
+               regmap_update_bits(rt5682s->regmap, RT5682S_4BTN_IL_CMD_7,
+                       RT5682S_4BTN_IL_HOLD_WIN_MASK | RT5682S_4BTN_IL_CLICK_WIN_MASK,
+                       (btndet_delay << RT5682S_4BTN_IL_HOLD_WIN_SFT | btndet_delay));
+
+               mod_delayed_work(system_power_efficient_wq,
+                       &rt5682s->jack_detect_work, msecs_to_jiffies(250));
+               break;
+
+       case RT5682S_JD_NULL:
+               regmap_update_bits(rt5682s->regmap, RT5682S_IRQ_CTRL_2,
+                       RT5682S_JD1_EN_MASK, RT5682S_JD1_DIS);
+               regmap_update_bits(rt5682s->regmap, RT5682S_RC_CLK_CTRL,
+                       RT5682S_POW_JDH, 0);
+               break;
+
+       default:
+               dev_warn(component->dev, "Wrong JD source\n");
+               break;
+       }
+
+       return 0;
+}
+
+static const DECLARE_TLV_DB_SCALE(dac_vol_tlv, -9562, 75, 0);
+static const DECLARE_TLV_DB_SCALE(adc_vol_tlv, -1725, 75, 0);
+static const DECLARE_TLV_DB_SCALE(adc_bst_tlv, 0, 1200, 0);
+static const DECLARE_TLV_DB_SCALE(cbj_bst_tlv, -1200, 150, 0);
+
+static const struct snd_kcontrol_new rt5682s_snd_controls[] = {
+       /* DAC Digital Volume */
+       SOC_DOUBLE_TLV("DAC1 Playback Volume", RT5682S_DAC1_DIG_VOL,
+               RT5682S_L_VOL_SFT + 1, RT5682S_R_VOL_SFT + 1, 127, 0, dac_vol_tlv),
+
+       /* CBJ Boost Volume */
+       SOC_SINGLE_TLV("CBJ Boost Volume", RT5682S_REC_MIXER,
+               RT5682S_BST_CBJ_SFT, 35, 0,  cbj_bst_tlv),
+
+       /* ADC Digital Volume Control */
+       SOC_DOUBLE("STO1 ADC Capture Switch", RT5682S_STO1_ADC_DIG_VOL,
+               RT5682S_L_MUTE_SFT, RT5682S_R_MUTE_SFT, 1, 1),
+       SOC_DOUBLE_TLV("STO1 ADC Capture Volume", RT5682S_STO1_ADC_DIG_VOL,
+               RT5682S_L_VOL_SFT + 1, RT5682S_R_VOL_SFT + 1, 63, 0, adc_vol_tlv),
+
+       /* ADC Boost Volume Control */
+       SOC_DOUBLE_TLV("STO1 ADC Boost Gain Volume", RT5682S_STO1_ADC_BOOST,
+               RT5682S_STO1_ADC_L_BST_SFT, RT5682S_STO1_ADC_R_BST_SFT, 3, 0, adc_bst_tlv),
+};
+
+/**
+ * rt5682s_sel_asrc_clk_src - select ASRC clock source for a set of filters
+ * @component: SoC audio component device.
+ * @filter_mask: mask of filters.
+ * @clk_src: clock source
+ *
+ * The ASRC function is for asynchronous MCLK and LRCK. Also, since RT5682S can
+ * only support standard 32fs or 64fs i2s format, ASRC should be enabled to
+ * support special i2s clock format such as Intel's 100fs(100 * sampling rate).
+ * ASRC function will track i2s clock and generate a corresponding system clock
+ * for codec. This function provides an API to select the clock source for a
+ * set of filters specified by the mask. And the component driver will turn on
+ * ASRC for these filters if ASRC is selected as their clock source.
+ */
+int rt5682s_sel_asrc_clk_src(struct snd_soc_component *component,
+               unsigned int filter_mask, unsigned int clk_src)
+{
+       switch (clk_src) {
+       case RT5682S_CLK_SEL_SYS:
+       case RT5682S_CLK_SEL_I2S1_ASRC:
+       case RT5682S_CLK_SEL_I2S2_ASRC:
+               break;
+
+       default:
+               return -EINVAL;
+       }
+
+       if (filter_mask & RT5682S_DA_STEREO1_FILTER) {
+               snd_soc_component_update_bits(component, RT5682S_PLL_TRACK_2,
+                       RT5682S_FILTER_CLK_SEL_MASK, clk_src << RT5682S_FILTER_CLK_SEL_SFT);
+       }
+
+       if (filter_mask & RT5682S_AD_STEREO1_FILTER) {
+               snd_soc_component_update_bits(component, RT5682S_PLL_TRACK_3,
+                       RT5682S_FILTER_CLK_SEL_MASK, clk_src << RT5682S_FILTER_CLK_SEL_SFT);
+       }
+
+       snd_soc_component_update_bits(component, RT5682S_PLL_TRACK_11,
+               RT5682S_ASRCIN_AUTO_CLKOUT_MASK, RT5682S_ASRCIN_AUTO_CLKOUT_EN);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(rt5682s_sel_asrc_clk_src);
+
+static int rt5682s_div_sel(struct rt5682s_priv *rt5682s,
+               int target, const int div[], int size)
+{
+       int i;
+
+       if (rt5682s->sysclk < target) {
+               dev_err(rt5682s->component->dev,
+                       "sysclk rate %d is too low\n", rt5682s->sysclk);
+               return 0;
+       }
+
+       for (i = 0; i < size - 1; i++) {
+               dev_dbg(rt5682s->component->dev, "div[%d]=%d\n", i, div[i]);
+               if (target * div[i] == rt5682s->sysclk)
+                       return i;
+               if (target * div[i + 1] > rt5682s->sysclk) {
+                       dev_dbg(rt5682s->component->dev,
+                               "can't find div for sysclk %d\n", rt5682s->sysclk);
+                       return i;
+               }
+       }
+
+       if (target * div[i] < rt5682s->sysclk)
+               dev_err(rt5682s->component->dev,
+                       "sysclk rate %d is too high\n", rt5682s->sysclk);
+
+       return size - 1;
+}
+
+static int get_clk_info(int sclk, int rate)
+{
+       int i;
+       static const int pd[] = {1, 2, 3, 4, 6, 8, 12, 16, 24, 32, 48};
+
+       if (sclk <= 0 || rate <= 0)
+               return -EINVAL;
+
+       rate = rate << 8;
+       for (i = 0; i < ARRAY_SIZE(pd); i++)
+               if (sclk == rate * pd[i])
+                       return i;
+
+       return -EINVAL;
+}
+
+/**
+ * set_dmic_clk - Set parameter of dmic.
+ *
+ * @w: DAPM widget.
+ * @kcontrol: The kcontrol of this widget.
+ * @event: Event id.
+ *
+ * Choose dmic clock between 1MHz and 3MHz.
+ * It is better for clock to approximate 3MHz.
+ */
+static int set_dmic_clk(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       int idx, dmic_clk_rate = 3072000;
+       static const int div[] = {2, 4, 6, 8, 12, 16, 24, 32, 48, 64, 96, 128};
+
+       if (rt5682s->pdata.dmic_clk_rate)
+               dmic_clk_rate = rt5682s->pdata.dmic_clk_rate;
+
+       idx = rt5682s_div_sel(rt5682s, dmic_clk_rate, div, ARRAY_SIZE(div));
+
+       snd_soc_component_update_bits(component, RT5682S_DMIC_CTRL_1,
+               RT5682S_DMIC_CLK_MASK, idx << RT5682S_DMIC_CLK_SFT);
+
+       return 0;
+}
+
+static int set_filter_clk(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       int ref, val, reg, idx;
+       static const int div_f[] = {1, 2, 3, 4, 6, 8, 12, 16, 24, 32, 48};
+       static const int div_o[] = {1, 2, 4, 6, 8, 12, 16, 24, 32, 48};
+
+       val = snd_soc_component_read(component, RT5682S_GPIO_CTRL_1)
+                       & RT5682S_GP4_PIN_MASK;
+
+       if (w->shift == RT5682S_PWR_ADC_S1F_BIT && val == RT5682S_GP4_PIN_ADCDAT2)
+               ref = 256 * rt5682s->lrck[RT5682S_AIF2];
+       else
+               ref = 256 * rt5682s->lrck[RT5682S_AIF1];
+
+       idx = rt5682s_div_sel(rt5682s, ref, div_f, ARRAY_SIZE(div_f));
+
+       if (w->shift == RT5682S_PWR_ADC_S1F_BIT)
+               reg = RT5682S_PLL_TRACK_3;
+       else
+               reg = RT5682S_PLL_TRACK_2;
+
+       snd_soc_component_update_bits(component, reg,
+               RT5682S_FILTER_CLK_DIV_MASK, idx << RT5682S_FILTER_CLK_DIV_SFT);
+
+       /* select over sample rate */
+       for (idx = 0; idx < ARRAY_SIZE(div_o); idx++) {
+               if (rt5682s->sysclk <= 12288000 * div_o[idx])
+                       break;
+       }
+
+       snd_soc_component_update_bits(component, RT5682S_ADDA_CLK_1,
+               RT5682S_ADC_OSR_MASK | RT5682S_DAC_OSR_MASK,
+               (idx << RT5682S_ADC_OSR_SFT) | (idx << RT5682S_DAC_OSR_SFT));
+
+       return 0;
+}
+
+static int set_dmic_power(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       unsigned int delay = 50, val;
+
+       if (rt5682s->pdata.dmic_delay)
+               delay = rt5682s->pdata.dmic_delay;
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               val = (snd_soc_component_read(component, RT5682S_GLB_CLK)
+                       & RT5682S_SCLK_SRC_MASK) >> RT5682S_SCLK_SRC_SFT;
+               if (val == RT5682S_CLK_SRC_PLL1 || val == RT5682S_CLK_SRC_PLL2)
+                       snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+                               RT5682S_PWR_VREF2 | RT5682S_PWR_MB,
+                               RT5682S_PWR_VREF2 | RT5682S_PWR_MB);
+
+               /*Add delay to avoid pop noise*/
+               msleep(delay);
+               break;
+
+       case SND_SOC_DAPM_POST_PMD:
+               if (!rt5682s->jack_type) {
+                       if (!snd_soc_dapm_get_pin_status(w->dapm, "MICBIAS"))
+                               snd_soc_component_update_bits(component,
+                                       RT5682S_PWR_ANLG_1, RT5682S_PWR_MB, 0);
+                       if (!snd_soc_dapm_get_pin_status(w->dapm, "Vref2"))
+                               snd_soc_component_update_bits(component,
+                                       RT5682S_PWR_ANLG_1, RT5682S_PWR_VREF2, 0);
+               }
+               break;
+       }
+
+       return 0;
+}
+
+static int set_i2s_clk(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       int pre_div, id;
+       unsigned int reg, mask, sft;
+
+       if (event != SND_SOC_DAPM_PRE_PMU)
+               return 0;
+
+       if (w->shift == RT5682S_PWR_I2S2_BIT) {
+               id = RT5682S_AIF2;
+               reg = RT5682S_I2S2_M_CLK_CTRL_1;
+               mask = RT5682S_I2S2_M_D_MASK;
+               sft = RT5682S_I2S2_M_D_SFT;
+       } else {
+               id = RT5682S_AIF1;
+               reg = RT5682S_ADDA_CLK_1;
+               mask = RT5682S_I2S_M_D_MASK;
+               sft = RT5682S_I2S_M_D_SFT;
+       }
+
+       if (!rt5682s->master[id])
+               return 0;
+
+       pre_div = get_clk_info(rt5682s->sysclk, rt5682s->lrck[id]);
+       if (pre_div < 0) {
+               dev_err(component->dev, "get pre_div failed\n");
+               return -EINVAL;
+       }
+
+       dev_dbg(component->dev, "lrck is %dHz and pre_div is %d for iis %d master\n",
+               rt5682s->lrck[id], pre_div, id);
+       snd_soc_component_update_bits(component, reg, mask, pre_div << sft);
+
+       return 0;
+}
+
+static int is_sys_clk_from_plla(struct snd_soc_dapm_widget *w,
+               struct snd_soc_dapm_widget *sink)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       if ((rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL1) ||
+           (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2 && rt5682s->pll_comb == USE_PLLAB))
+               return 1;
+
+       return 0;
+}
+
+static int is_sys_clk_from_pllb(struct snd_soc_dapm_widget *w,
+               struct snd_soc_dapm_widget *sink)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       if (rt5682s->sysclk_src == RT5682S_CLK_SRC_PLL2)
+               return 1;
+
+       return 0;
+}
+
+static int is_using_asrc(struct snd_soc_dapm_widget *w,
+               struct snd_soc_dapm_widget *sink)
+{
+       unsigned int reg, sft, val;
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+
+       switch (w->shift) {
+       case RT5682S_ADC_STO1_ASRC_SFT:
+               reg = RT5682S_PLL_TRACK_3;
+               sft = RT5682S_FILTER_CLK_SEL_SFT;
+               break;
+       case RT5682S_DAC_STO1_ASRC_SFT:
+               reg = RT5682S_PLL_TRACK_2;
+               sft = RT5682S_FILTER_CLK_SEL_SFT;
+               break;
+       default:
+               return 0;
+       }
+
+       val = (snd_soc_component_read(component, reg) >> sft) & 0xf;
+       switch (val) {
+       case RT5682S_CLK_SEL_I2S1_ASRC:
+       case RT5682S_CLK_SEL_I2S2_ASRC:
+               return 1;
+       default:
+               return 0;
+       }
+}
+
+static int rt5682s_hp_amp_event(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               snd_soc_component_update_bits(component, RT5682S_DEPOP_1,
+                       RT5682S_OUT_HP_L_EN | RT5682S_OUT_HP_R_EN,
+                       RT5682S_OUT_HP_L_EN | RT5682S_OUT_HP_R_EN);
+               usleep_range(15000, 20000);
+               snd_soc_component_update_bits(component, RT5682S_DEPOP_1,
+                       RT5682S_LDO_PUMP_EN | RT5682S_PUMP_EN |
+                       RT5682S_CAPLESS_L_EN | RT5682S_CAPLESS_R_EN,
+                       RT5682S_LDO_PUMP_EN | RT5682S_PUMP_EN |
+                       RT5682S_CAPLESS_L_EN | RT5682S_CAPLESS_R_EN);
+               snd_soc_component_write(component, RT5682S_BIAS_CUR_CTRL_11, 0x6666);
+               snd_soc_component_write(component, RT5682S_BIAS_CUR_CTRL_12, 0xa82a);
+
+               mutex_lock(&rt5682s->jdet_mutex);
+
+               snd_soc_component_update_bits(component, RT5682S_HP_CTRL_2,
+                       RT5682S_HPO_L_PATH_MASK | RT5682S_HPO_R_PATH_MASK |
+                       RT5682S_HPO_SEL_IP_EN_SW, RT5682S_HPO_L_PATH_EN |
+                       RT5682S_HPO_R_PATH_EN | RT5682S_HPO_IP_EN_GATING);
+               usleep_range(5000, 10000);
+               snd_soc_component_update_bits(component, RT5682S_HP_AMP_DET_CTL_1,
+                       RT5682S_CP_SW_SIZE_MASK, RT5682S_CP_SW_SIZE_L | RT5682S_CP_SW_SIZE_S);
+
+               mutex_unlock(&rt5682s->jdet_mutex);
+               break;
+
+       case SND_SOC_DAPM_POST_PMD:
+               snd_soc_component_update_bits(component, RT5682S_HP_CTRL_2,
+                       RT5682S_HPO_L_PATH_MASK | RT5682S_HPO_R_PATH_MASK |
+                       RT5682S_HPO_SEL_IP_EN_SW, 0);
+               snd_soc_component_update_bits(component, RT5682S_HP_AMP_DET_CTL_1,
+                       RT5682S_CP_SW_SIZE_MASK, RT5682S_CP_SW_SIZE_M);
+               snd_soc_component_update_bits(component, RT5682S_DEPOP_1,
+                       RT5682S_LDO_PUMP_EN | RT5682S_PUMP_EN |
+                       RT5682S_CAPLESS_L_EN | RT5682S_CAPLESS_R_EN, 0);
+               snd_soc_component_update_bits(component, RT5682S_DEPOP_1,
+                       RT5682S_OUT_HP_L_EN | RT5682S_OUT_HP_R_EN, 0);
+               break;
+       }
+
+       return 0;
+}
+
+static int sar_power_event(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       if ((rt5682s->jack_type & SND_JACK_HEADSET) != SND_JACK_HEADSET)
+               return 0;
+
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               rt5682s_sar_power_mode(component, SAR_PWR_NORMAL, 0);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               rt5682s_sar_power_mode(component, SAR_PWR_SAVING, 0);
+               break;
+       }
+
+       return 0;
+}
+
+/* Interface data select */
+static const char * const rt5682s_data_select[] = {
+       "L/R", "R/L", "L/L", "R/R"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_if2_adc_enum, RT5682S_DIG_INF2_DATA,
+       RT5682S_IF2_ADC_SEL_SFT, rt5682s_data_select);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_if1_01_adc_enum, RT5682S_TDM_ADDA_CTRL_1,
+       RT5682S_IF1_ADC1_SEL_SFT, rt5682s_data_select);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_if1_23_adc_enum, RT5682S_TDM_ADDA_CTRL_1,
+       RT5682S_IF1_ADC2_SEL_SFT, rt5682s_data_select);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_if1_45_adc_enum, RT5682S_TDM_ADDA_CTRL_1,
+       RT5682S_IF1_ADC3_SEL_SFT, rt5682s_data_select);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_if1_67_adc_enum, RT5682S_TDM_ADDA_CTRL_1,
+       RT5682S_IF1_ADC4_SEL_SFT, rt5682s_data_select);
+
+static const struct snd_kcontrol_new rt5682s_if2_adc_swap_mux =
+       SOC_DAPM_ENUM("IF2 ADC Swap Mux", rt5682s_if2_adc_enum);
+
+static const struct snd_kcontrol_new rt5682s_if1_01_adc_swap_mux =
+       SOC_DAPM_ENUM("IF1 01 ADC Swap Mux", rt5682s_if1_01_adc_enum);
+
+static const struct snd_kcontrol_new rt5682s_if1_23_adc_swap_mux =
+       SOC_DAPM_ENUM("IF1 23 ADC Swap Mux", rt5682s_if1_23_adc_enum);
+
+static const struct snd_kcontrol_new rt5682s_if1_45_adc_swap_mux =
+       SOC_DAPM_ENUM("IF1 45 ADC Swap Mux", rt5682s_if1_45_adc_enum);
+
+static const struct snd_kcontrol_new rt5682s_if1_67_adc_swap_mux =
+       SOC_DAPM_ENUM("IF1 67 ADC Swap Mux", rt5682s_if1_67_adc_enum);
+
+/* Digital Mixer */
+static const struct snd_kcontrol_new rt5682s_sto1_adc_l_mix[] = {
+       SOC_DAPM_SINGLE("ADC1 Switch", RT5682S_STO1_ADC_MIXER,
+                       RT5682S_M_STO1_ADC_L1_SFT, 1, 1),
+       SOC_DAPM_SINGLE("ADC2 Switch", RT5682S_STO1_ADC_MIXER,
+                       RT5682S_M_STO1_ADC_L2_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_sto1_adc_r_mix[] = {
+       SOC_DAPM_SINGLE("ADC1 Switch", RT5682S_STO1_ADC_MIXER,
+                       RT5682S_M_STO1_ADC_R1_SFT, 1, 1),
+       SOC_DAPM_SINGLE("ADC2 Switch", RT5682S_STO1_ADC_MIXER,
+                       RT5682S_M_STO1_ADC_R2_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_dac_l_mix[] = {
+       SOC_DAPM_SINGLE("Stereo ADC Switch", RT5682S_AD_DA_MIXER,
+                       RT5682S_M_ADCMIX_L_SFT, 1, 1),
+       SOC_DAPM_SINGLE("DAC1 Switch", RT5682S_AD_DA_MIXER,
+                       RT5682S_M_DAC1_L_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_dac_r_mix[] = {
+       SOC_DAPM_SINGLE("Stereo ADC Switch", RT5682S_AD_DA_MIXER,
+                       RT5682S_M_ADCMIX_R_SFT, 1, 1),
+       SOC_DAPM_SINGLE("DAC1 Switch", RT5682S_AD_DA_MIXER,
+                       RT5682S_M_DAC1_R_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_sto1_dac_l_mix[] = {
+       SOC_DAPM_SINGLE("DAC L1 Switch", RT5682S_STO1_DAC_MIXER,
+                       RT5682S_M_DAC_L1_STO_L_SFT, 1, 1),
+       SOC_DAPM_SINGLE("DAC R1 Switch", RT5682S_STO1_DAC_MIXER,
+                       RT5682S_M_DAC_R1_STO_L_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_sto1_dac_r_mix[] = {
+       SOC_DAPM_SINGLE("DAC L1 Switch", RT5682S_STO1_DAC_MIXER,
+                       RT5682S_M_DAC_L1_STO_R_SFT, 1, 1),
+       SOC_DAPM_SINGLE("DAC R1 Switch", RT5682S_STO1_DAC_MIXER,
+                       RT5682S_M_DAC_R1_STO_R_SFT, 1, 1),
+};
+
+/* Analog Input Mixer */
+static const struct snd_kcontrol_new rt5682s_rec1_l_mix[] = {
+       SOC_DAPM_SINGLE("CBJ Switch", RT5682S_REC_MIXER,
+                       RT5682S_M_CBJ_RM1_L_SFT, 1, 1),
+};
+
+static const struct snd_kcontrol_new rt5682s_rec1_r_mix[] = {
+       SOC_DAPM_SINGLE("CBJ Switch", RT5682S_REC_MIXER,
+                       RT5682S_M_CBJ_RM1_R_SFT, 1, 1),
+};
+
+/* STO1 ADC1 Source */
+/* MX-26 [13] [5] */
+static const char * const rt5682s_sto1_adc1_src[] = {
+       "DAC MIX", "ADC"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adc1l_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADC1L_SRC_SFT, rt5682s_sto1_adc1_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adc1l_mux =
+       SOC_DAPM_ENUM("Stereo1 ADC1L Source", rt5682s_sto1_adc1l_enum);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adc1r_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADC1R_SRC_SFT, rt5682s_sto1_adc1_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adc1r_mux =
+       SOC_DAPM_ENUM("Stereo1 ADC1L Source", rt5682s_sto1_adc1r_enum);
+
+/* STO1 ADC Source */
+/* MX-26 [11:10] [3:2] */
+static const char * const rt5682s_sto1_adc_src[] = {
+       "ADC1 L", "ADC1 R"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adcl_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADCL_SRC_SFT, rt5682s_sto1_adc_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adcl_mux =
+       SOC_DAPM_ENUM("Stereo1 ADCL Source", rt5682s_sto1_adcl_enum);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adcr_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADCR_SRC_SFT, rt5682s_sto1_adc_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adcr_mux =
+       SOC_DAPM_ENUM("Stereo1 ADCR Source", rt5682s_sto1_adcr_enum);
+
+/* STO1 ADC2 Source */
+/* MX-26 [12] [4] */
+static const char * const rt5682s_sto1_adc2_src[] = {
+       "DAC MIX", "DMIC"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adc2l_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADC2L_SRC_SFT, rt5682s_sto1_adc2_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adc2l_mux =
+       SOC_DAPM_ENUM("Stereo1 ADC2L Source", rt5682s_sto1_adc2l_enum);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_sto1_adc2r_enum, RT5682S_STO1_ADC_MIXER,
+       RT5682S_STO1_ADC2R_SRC_SFT, rt5682s_sto1_adc2_src);
+
+static const struct snd_kcontrol_new rt5682s_sto1_adc2r_mux =
+       SOC_DAPM_ENUM("Stereo1 ADC2R Source", rt5682s_sto1_adc2r_enum);
+
+/* MX-79 [6:4] I2S1 ADC data location */
+static const unsigned int rt5682s_if1_adc_slot_values[] = {
+       0, 2, 4, 6,
+};
+
+static const char * const rt5682s_if1_adc_slot_src[] = {
+       "Slot 0", "Slot 2", "Slot 4", "Slot 6"
+};
+
+static SOC_VALUE_ENUM_SINGLE_DECL(rt5682s_if1_adc_slot_enum,
+       RT5682S_TDM_CTRL, RT5682S_TDM_ADC_LCA_SFT, RT5682S_TDM_ADC_LCA_MASK,
+       rt5682s_if1_adc_slot_src, rt5682s_if1_adc_slot_values);
+
+static const struct snd_kcontrol_new rt5682s_if1_adc_slot_mux =
+       SOC_DAPM_ENUM("IF1 ADC Slot location", rt5682s_if1_adc_slot_enum);
+
+/* Analog DAC L1 Source, Analog DAC R1 Source*/
+/* MX-2B [4], MX-2B [0]*/
+static const char * const rt5682s_alg_dac1_src[] = {
+       "Stereo1 DAC Mixer", "DAC1"
+};
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_alg_dac_l1_enum, RT5682S_A_DAC1_MUX,
+       RT5682S_A_DACL1_SFT, rt5682s_alg_dac1_src);
+
+static const struct snd_kcontrol_new rt5682s_alg_dac_l1_mux =
+       SOC_DAPM_ENUM("Analog DAC L1 Source", rt5682s_alg_dac_l1_enum);
+
+static SOC_ENUM_SINGLE_DECL(rt5682s_alg_dac_r1_enum, RT5682S_A_DAC1_MUX,
+       RT5682S_A_DACR1_SFT, rt5682s_alg_dac1_src);
+
+static const struct snd_kcontrol_new rt5682s_alg_dac_r1_mux =
+       SOC_DAPM_ENUM("Analog DAC R1 Source", rt5682s_alg_dac_r1_enum);
+
+static const unsigned int rt5682s_adcdat_pin_values[] = {
+       1, 3,
+};
+
+static const char * const rt5682s_adcdat_pin_select[] = {
+       "ADCDAT1", "ADCDAT2",
+};
+
+static SOC_VALUE_ENUM_SINGLE_DECL(rt5682s_adcdat_pin_enum,
+       RT5682S_GPIO_CTRL_1, RT5682S_GP4_PIN_SFT, RT5682S_GP4_PIN_MASK,
+       rt5682s_adcdat_pin_select, rt5682s_adcdat_pin_values);
+
+static const struct snd_kcontrol_new rt5682s_adcdat_pin_ctrl =
+       SOC_DAPM_ENUM("ADCDAT", rt5682s_adcdat_pin_enum);
+
+static const struct snd_soc_dapm_widget rt5682s_dapm_widgets[] = {
+       SND_SOC_DAPM_SUPPLY("LDO MB1", RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_LDO_MB1_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("LDO MB2", RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_LDO_MB2_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("LDO", RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_LDO_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("Vref2", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("MICBIAS", SND_SOC_NOPM, 0, 0, NULL, 0),
+
+       /* PLL Powers */
+       SND_SOC_DAPM_SUPPLY_S("PLLA_LDO", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_LDO_PLLA_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLB_LDO", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_LDO_PLLB_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLA_BIAS", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_BIAS_PLLA_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLB_BIAS", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_BIAS_PLLB_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLA", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_PLLA_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLB", 0, RT5682S_PWR_ANLG_3,
+               RT5682S_PWR_PLLB_BIT, 0, set_filter_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_SUPPLY_S("PLLA_RST", 1, RT5682S_PWR_ANLG_3,
+               RT5682S_RSTB_PLLA_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("PLLB_RST", 1, RT5682S_PWR_ANLG_3,
+               RT5682S_RSTB_PLLB_BIT, 0, NULL, 0),
+
+       /* ASRC */
+       SND_SOC_DAPM_SUPPLY_S("DAC STO1 ASRC", 1, RT5682S_PLL_TRACK_1,
+               RT5682S_DAC_STO1_ASRC_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("ADC STO1 ASRC", 1, RT5682S_PLL_TRACK_1,
+               RT5682S_ADC_STO1_ASRC_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("AD ASRC", 1, RT5682S_PLL_TRACK_1,
+               RT5682S_AD_ASRC_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("DA ASRC", 1, RT5682S_PLL_TRACK_1,
+               RT5682S_DA_ASRC_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY_S("DMIC ASRC", 1, RT5682S_PLL_TRACK_1,
+               RT5682S_DMIC_ASRC_SFT, 0, NULL, 0),
+
+       /* Input Side */
+       SND_SOC_DAPM_SUPPLY("MICBIAS1", RT5682S_PWR_ANLG_2,
+               RT5682S_PWR_MB1_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("MICBIAS2", RT5682S_PWR_ANLG_2,
+               RT5682S_PWR_MB2_BIT, 0, NULL, 0),
+
+       /* Input Lines */
+       SND_SOC_DAPM_INPUT("DMIC L1"),
+       SND_SOC_DAPM_INPUT("DMIC R1"),
+
+       SND_SOC_DAPM_INPUT("IN1P"),
+
+       SND_SOC_DAPM_SUPPLY("DMIC CLK", SND_SOC_NOPM, 0, 0,
+               set_dmic_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_SUPPLY("DMIC1 Power", RT5682S_DMIC_CTRL_1, RT5682S_DMIC_1_EN_SFT, 0,
+               set_dmic_power, SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
+
+       /* Boost */
+       SND_SOC_DAPM_PGA("BST1 CBJ", SND_SOC_NOPM, 0, 0, NULL, 0),
+
+       /* REC Mixer */
+       SND_SOC_DAPM_MIXER("RECMIX1L", SND_SOC_NOPM, 0, 0, rt5682s_rec1_l_mix,
+               ARRAY_SIZE(rt5682s_rec1_l_mix)),
+       SND_SOC_DAPM_MIXER("RECMIX1R", SND_SOC_NOPM, 0, 0, rt5682s_rec1_r_mix,
+               ARRAY_SIZE(rt5682s_rec1_r_mix)),
+       SND_SOC_DAPM_SUPPLY("RECMIX1L Power", RT5682S_CAL_REC,
+               RT5682S_PWR_RM1_L_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("RECMIX1R Power", RT5682S_CAL_REC,
+               RT5682S_PWR_RM1_R_BIT, 0, NULL, 0),
+
+       /* ADCs */
+       SND_SOC_DAPM_ADC("ADC1 L", NULL, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_ADC("ADC1 R", NULL, SND_SOC_NOPM, 0, 0),
+
+       SND_SOC_DAPM_SUPPLY("ADC1 L Power", RT5682S_PWR_DIG_1,
+               RT5682S_PWR_ADC_L1_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("ADC1 R Power", RT5682S_PWR_DIG_1,
+               RT5682S_PWR_ADC_R1_BIT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("ADC1 clock", RT5682S_CHOP_ADC,
+               RT5682S_CKGEN_ADC1_SFT, 0, NULL, 0),
+
+       /* ADC Mux */
+       SND_SOC_DAPM_MUX("Stereo1 ADC L1 Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adc1l_mux),
+       SND_SOC_DAPM_MUX("Stereo1 ADC R1 Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adc1r_mux),
+       SND_SOC_DAPM_MUX("Stereo1 ADC L2 Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adc2l_mux),
+       SND_SOC_DAPM_MUX("Stereo1 ADC R2 Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adc2r_mux),
+       SND_SOC_DAPM_MUX("Stereo1 ADC L Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adcl_mux),
+       SND_SOC_DAPM_MUX("Stereo1 ADC R Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_sto1_adcr_mux),
+       SND_SOC_DAPM_MUX("IF1_ADC Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if1_adc_slot_mux),
+
+       /* ADC Mixer */
+       SND_SOC_DAPM_SUPPLY("ADC Stereo1 Filter", RT5682S_PWR_DIG_2,
+               RT5682S_PWR_ADC_S1F_BIT, 0, set_filter_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_MIXER("Stereo1 ADC MIXL", RT5682S_STO1_ADC_DIG_VOL,
+               RT5682S_L_MUTE_SFT, 1, rt5682s_sto1_adc_l_mix,
+               ARRAY_SIZE(rt5682s_sto1_adc_l_mix)),
+       SND_SOC_DAPM_MIXER("Stereo1 ADC MIXR", RT5682S_STO1_ADC_DIG_VOL,
+               RT5682S_R_MUTE_SFT, 1, rt5682s_sto1_adc_r_mix,
+               ARRAY_SIZE(rt5682s_sto1_adc_r_mix)),
+
+       /* ADC PGA */
+       SND_SOC_DAPM_PGA("Stereo1 ADC MIX", SND_SOC_NOPM, 0, 0, NULL, 0),
+
+       /* Digital Interface */
+       SND_SOC_DAPM_SUPPLY("I2S1", RT5682S_PWR_DIG_1, RT5682S_PWR_I2S1_BIT,
+               0, set_i2s_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_SUPPLY("I2S2", RT5682S_PWR_DIG_1, RT5682S_PWR_I2S2_BIT,
+               0, set_i2s_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_PGA("IF1 DAC1 L", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_PGA("IF1 DAC1 R", SND_SOC_NOPM, 0, 0, NULL, 0),
+
+       /* Digital Interface Select */
+       SND_SOC_DAPM_MUX("IF1 01 ADC Swap Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if1_01_adc_swap_mux),
+       SND_SOC_DAPM_MUX("IF1 23 ADC Swap Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if1_23_adc_swap_mux),
+       SND_SOC_DAPM_MUX("IF1 45 ADC Swap Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if1_45_adc_swap_mux),
+       SND_SOC_DAPM_MUX("IF1 67 ADC Swap Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if1_67_adc_swap_mux),
+       SND_SOC_DAPM_MUX("IF2 ADC Swap Mux", SND_SOC_NOPM, 0, 0,
+               &rt5682s_if2_adc_swap_mux),
+
+       SND_SOC_DAPM_MUX("ADCDAT Mux", SND_SOC_NOPM, 0, 0, &rt5682s_adcdat_pin_ctrl),
+
+       /* Audio Interface */
+       SND_SOC_DAPM_AIF_OUT("AIF1TX", "AIF1 Capture", 0, RT5682S_I2S1_SDP,
+               RT5682S_SEL_ADCDAT_SFT, 1),
+       SND_SOC_DAPM_AIF_OUT("AIF2TX", "AIF2 Capture", 0, RT5682S_I2S2_SDP,
+               RT5682S_I2S2_PIN_CFG_SFT, 1),
+       SND_SOC_DAPM_AIF_IN("AIF1RX", "AIF1 Playback", 0, SND_SOC_NOPM, 0, 0),
+
+       /* Output Side */
+       /* DAC mixer before sound effect  */
+       SND_SOC_DAPM_MIXER("DAC1 MIXL", SND_SOC_NOPM, 0, 0,
+               rt5682s_dac_l_mix, ARRAY_SIZE(rt5682s_dac_l_mix)),
+       SND_SOC_DAPM_MIXER("DAC1 MIXR", SND_SOC_NOPM, 0, 0,
+               rt5682s_dac_r_mix, ARRAY_SIZE(rt5682s_dac_r_mix)),
+
+       /* DAC channel Mux */
+       SND_SOC_DAPM_MUX("DAC L1 Source", SND_SOC_NOPM, 0, 0, &rt5682s_alg_dac_l1_mux),
+       SND_SOC_DAPM_MUX("DAC R1 Source", SND_SOC_NOPM, 0, 0, &rt5682s_alg_dac_r1_mux),
+
+       /* DAC Mixer */
+       SND_SOC_DAPM_SUPPLY("DAC Stereo1 Filter", RT5682S_PWR_DIG_2,
+               RT5682S_PWR_DAC_S1F_BIT, 0, set_filter_clk, SND_SOC_DAPM_PRE_PMU),
+       SND_SOC_DAPM_MIXER("Stereo1 DAC MIXL", SND_SOC_NOPM, 0, 0,
+               rt5682s_sto1_dac_l_mix, ARRAY_SIZE(rt5682s_sto1_dac_l_mix)),
+       SND_SOC_DAPM_MIXER("Stereo1 DAC MIXR", SND_SOC_NOPM, 0, 0,
+               rt5682s_sto1_dac_r_mix, ARRAY_SIZE(rt5682s_sto1_dac_r_mix)),
+
+       /* DACs */
+       SND_SOC_DAPM_DAC("DAC L1", NULL, RT5682S_PWR_DIG_1, RT5682S_PWR_DAC_L1_BIT, 0),
+       SND_SOC_DAPM_DAC("DAC R1", NULL, RT5682S_PWR_DIG_1, RT5682S_PWR_DAC_R1_BIT, 0),
+
+       /* HPO */
+       SND_SOC_DAPM_PGA_S("HP Amp", 1, SND_SOC_NOPM, 0, 0, rt5682s_hp_amp_event,
+               SND_SOC_DAPM_POST_PMD | SND_SOC_DAPM_POST_PMU),
+
+       /* CLK DET */
+       SND_SOC_DAPM_SUPPLY("CLKDET SYS", RT5682S_CLK_DET,
+               RT5682S_SYS_CLK_DET_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("CLKDET PLL1", RT5682S_CLK_DET,
+               RT5682S_PLL1_CLK_DET_SFT, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("MCLK0 DET PWR", RT5682S_PWR_ANLG_2,
+               RT5682S_PWR_MCLK0_WD_BIT, 0, NULL, 0),
+
+       /* SAR */
+       SND_SOC_DAPM_SUPPLY("SAR", SND_SOC_NOPM, 0, 0, sar_power_event,
+               SND_SOC_DAPM_PRE_PMU | SND_SOC_DAPM_POST_PMD),
+
+       /* Output Lines */
+       SND_SOC_DAPM_OUTPUT("HPOL"),
+       SND_SOC_DAPM_OUTPUT("HPOR"),
+};
+
+static const struct snd_soc_dapm_route rt5682s_dapm_routes[] = {
+       /*PLL*/
+       {"ADC Stereo1 Filter", NULL, "PLLA", is_sys_clk_from_plla},
+       {"ADC Stereo1 Filter", NULL, "PLLB", is_sys_clk_from_pllb},
+       {"DAC Stereo1 Filter", NULL, "PLLA", is_sys_clk_from_plla},
+       {"DAC Stereo1 Filter", NULL, "PLLB", is_sys_clk_from_pllb},
+       {"PLLA", NULL, "PLLA_LDO"},
+       {"PLLA", NULL, "PLLA_BIAS"},
+       {"PLLA", NULL, "PLLA_RST"},
+       {"PLLB", NULL, "PLLB_LDO"},
+       {"PLLB", NULL, "PLLB_BIAS"},
+       {"PLLB", NULL, "PLLB_RST"},
+
+       /*ASRC*/
+       {"ADC Stereo1 Filter", NULL, "ADC STO1 ASRC", is_using_asrc},
+       {"DAC Stereo1 Filter", NULL, "DAC STO1 ASRC", is_using_asrc},
+       {"ADC STO1 ASRC", NULL, "AD ASRC"},
+       {"ADC STO1 ASRC", NULL, "DA ASRC"},
+       {"DAC STO1 ASRC", NULL, "AD ASRC"},
+       {"DAC STO1 ASRC", NULL, "DA ASRC"},
+
+       {"CLKDET SYS", NULL, "MCLK0 DET PWR"},
+
+       {"BST1 CBJ", NULL, "IN1P"},
+       {"BST1 CBJ", NULL, "SAR"},
+
+       {"RECMIX1L", "CBJ Switch", "BST1 CBJ"},
+       {"RECMIX1L", NULL, "RECMIX1L Power"},
+       {"RECMIX1R", "CBJ Switch", "BST1 CBJ"},
+       {"RECMIX1R", NULL, "RECMIX1R Power"},
+
+       {"ADC1 L", NULL, "RECMIX1L"},
+       {"ADC1 L", NULL, "ADC1 L Power"},
+       {"ADC1 L", NULL, "ADC1 clock"},
+       {"ADC1 R", NULL, "RECMIX1R"},
+       {"ADC1 R", NULL, "ADC1 R Power"},
+       {"ADC1 R", NULL, "ADC1 clock"},
+
+       {"DMIC L1", NULL, "DMIC CLK"},
+       {"DMIC L1", NULL, "DMIC1 Power"},
+       {"DMIC R1", NULL, "DMIC CLK"},
+       {"DMIC R1", NULL, "DMIC1 Power"},
+       {"DMIC CLK", NULL, "DMIC ASRC"},
+
+       {"Stereo1 ADC L Mux", "ADC1 L", "ADC1 L"},
+       {"Stereo1 ADC L Mux", "ADC1 R", "ADC1 R"},
+       {"Stereo1 ADC R Mux", "ADC1 L", "ADC1 L"},
+       {"Stereo1 ADC R Mux", "ADC1 R", "ADC1 R"},
+
+       {"Stereo1 ADC L1 Mux", "ADC", "Stereo1 ADC L Mux"},
+       {"Stereo1 ADC L1 Mux", "DAC MIX", "Stereo1 DAC MIXL"},
+       {"Stereo1 ADC L2 Mux", "DMIC", "DMIC L1"},
+       {"Stereo1 ADC L2 Mux", "DAC MIX", "Stereo1 DAC MIXL"},
+
+       {"Stereo1 ADC R1 Mux", "ADC", "Stereo1 ADC R Mux"},
+       {"Stereo1 ADC R1 Mux", "DAC MIX", "Stereo1 DAC MIXR"},
+       {"Stereo1 ADC R2 Mux", "DMIC", "DMIC R1"},
+       {"Stereo1 ADC R2 Mux", "DAC MIX", "Stereo1 DAC MIXR"},
+
+       {"Stereo1 ADC MIXL", "ADC1 Switch", "Stereo1 ADC L1 Mux"},
+       {"Stereo1 ADC MIXL", "ADC2 Switch", "Stereo1 ADC L2 Mux"},
+       {"Stereo1 ADC MIXL", NULL, "ADC Stereo1 Filter"},
+
+       {"Stereo1 ADC MIXR", "ADC1 Switch", "Stereo1 ADC R1 Mux"},
+       {"Stereo1 ADC MIXR", "ADC2 Switch", "Stereo1 ADC R2 Mux"},
+       {"Stereo1 ADC MIXR", NULL, "ADC Stereo1 Filter"},
+
+       {"Stereo1 ADC MIX", NULL, "Stereo1 ADC MIXL"},
+       {"Stereo1 ADC MIX", NULL, "Stereo1 ADC MIXR"},
+
+       {"IF1 01 ADC Swap Mux", "L/R", "Stereo1 ADC MIX"},
+       {"IF1 01 ADC Swap Mux", "L/L", "Stereo1 ADC MIX"},
+       {"IF1 01 ADC Swap Mux", "R/L", "Stereo1 ADC MIX"},
+       {"IF1 01 ADC Swap Mux", "R/R", "Stereo1 ADC MIX"},
+       {"IF1 23 ADC Swap Mux", "L/R", "Stereo1 ADC MIX"},
+       {"IF1 23 ADC Swap Mux", "R/L", "Stereo1 ADC MIX"},
+       {"IF1 23 ADC Swap Mux", "L/L", "Stereo1 ADC MIX"},
+       {"IF1 23 ADC Swap Mux", "R/R", "Stereo1 ADC MIX"},
+       {"IF1 45 ADC Swap Mux", "L/R", "Stereo1 ADC MIX"},
+       {"IF1 45 ADC Swap Mux", "R/L", "Stereo1 ADC MIX"},
+       {"IF1 45 ADC Swap Mux", "L/L", "Stereo1 ADC MIX"},
+       {"IF1 45 ADC Swap Mux", "R/R", "Stereo1 ADC MIX"},
+       {"IF1 67 ADC Swap Mux", "L/R", "Stereo1 ADC MIX"},
+       {"IF1 67 ADC Swap Mux", "R/L", "Stereo1 ADC MIX"},
+       {"IF1 67 ADC Swap Mux", "L/L", "Stereo1 ADC MIX"},
+       {"IF1 67 ADC Swap Mux", "R/R", "Stereo1 ADC MIX"},
+
+       {"IF1_ADC Mux", "Slot 0", "IF1 01 ADC Swap Mux"},
+       {"IF1_ADC Mux", "Slot 2", "IF1 23 ADC Swap Mux"},
+       {"IF1_ADC Mux", "Slot 4", "IF1 45 ADC Swap Mux"},
+       {"IF1_ADC Mux", "Slot 6", "IF1 67 ADC Swap Mux"},
+       {"ADCDAT Mux", "ADCDAT1", "IF1_ADC Mux"},
+       {"AIF1TX", NULL, "I2S1"},
+       {"AIF1TX", NULL, "ADCDAT Mux"},
+       {"IF2 ADC Swap Mux", "L/R", "Stereo1 ADC MIX"},
+       {"IF2 ADC Swap Mux", "R/L", "Stereo1 ADC MIX"},
+       {"IF2 ADC Swap Mux", "L/L", "Stereo1 ADC MIX"},
+       {"IF2 ADC Swap Mux", "R/R", "Stereo1 ADC MIX"},
+       {"ADCDAT Mux", "ADCDAT2", "IF2 ADC Swap Mux"},
+       {"AIF2TX", NULL, "ADCDAT Mux"},
+
+       {"IF1 DAC1 L", NULL, "AIF1RX"},
+       {"IF1 DAC1 L", NULL, "I2S1"},
+       {"IF1 DAC1 L", NULL, "DAC Stereo1 Filter"},
+       {"IF1 DAC1 R", NULL, "AIF1RX"},
+       {"IF1 DAC1 R", NULL, "I2S1"},
+       {"IF1 DAC1 R", NULL, "DAC Stereo1 Filter"},
+
+       {"DAC1 MIXL", "Stereo ADC Switch", "Stereo1 ADC MIXL"},
+       {"DAC1 MIXL", "DAC1 Switch", "IF1 DAC1 L"},
+       {"DAC1 MIXR", "Stereo ADC Switch", "Stereo1 ADC MIXR"},
+       {"DAC1 MIXR", "DAC1 Switch", "IF1 DAC1 R"},
+
+       {"Stereo1 DAC MIXL", "DAC L1 Switch", "DAC1 MIXL"},
+       {"Stereo1 DAC MIXL", "DAC R1 Switch", "DAC1 MIXR"},
+
+       {"Stereo1 DAC MIXR", "DAC R1 Switch", "DAC1 MIXR"},
+       {"Stereo1 DAC MIXR", "DAC L1 Switch", "DAC1 MIXL"},
+
+       {"DAC L1 Source", "DAC1", "DAC1 MIXL"},
+       {"DAC L1 Source", "Stereo1 DAC Mixer", "Stereo1 DAC MIXL"},
+       {"DAC R1 Source", "DAC1", "DAC1 MIXR"},
+       {"DAC R1 Source", "Stereo1 DAC Mixer", "Stereo1 DAC MIXR"},
+
+       {"DAC L1", NULL, "DAC L1 Source"},
+       {"DAC R1", NULL, "DAC R1 Source"},
+
+       {"HP Amp", NULL, "DAC L1"},
+       {"HP Amp", NULL, "DAC R1"},
+       {"HP Amp", NULL, "CLKDET SYS"},
+       {"HP Amp", NULL, "SAR"},
+
+       {"HPOL", NULL, "HP Amp"},
+       {"HPOR", NULL, "HP Amp"},
+};
+
+static int rt5682s_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask,
+               unsigned int rx_mask, int slots, int slot_width)
+{
+       struct snd_soc_component *component = dai->component;
+       unsigned int cl, val = 0;
+
+       if (tx_mask || rx_mask)
+               snd_soc_component_update_bits(component,
+                       RT5682S_TDM_ADDA_CTRL_2, RT5682S_TDM_EN, RT5682S_TDM_EN);
+       else
+               snd_soc_component_update_bits(component,
+                       RT5682S_TDM_ADDA_CTRL_2, RT5682S_TDM_EN, 0);
+
+       switch (slots) {
+       case 4:
+               val |= RT5682S_TDM_TX_CH_4;
+               val |= RT5682S_TDM_RX_CH_4;
+               break;
+       case 6:
+               val |= RT5682S_TDM_TX_CH_6;
+               val |= RT5682S_TDM_RX_CH_6;
+               break;
+       case 8:
+               val |= RT5682S_TDM_TX_CH_8;
+               val |= RT5682S_TDM_RX_CH_8;
+               break;
+       case 2:
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(component, RT5682S_TDM_CTRL,
+               RT5682S_TDM_TX_CH_MASK | RT5682S_TDM_RX_CH_MASK, val);
+
+       switch (slot_width) {
+       case 8:
+               if (tx_mask || rx_mask)
+                       return -EINVAL;
+               cl = RT5682S_I2S1_TX_CHL_8 | RT5682S_I2S1_RX_CHL_8;
+               break;
+       case 16:
+               val = RT5682S_TDM_CL_16;
+               cl = RT5682S_I2S1_TX_CHL_16 | RT5682S_I2S1_RX_CHL_16;
+               break;
+       case 20:
+               val = RT5682S_TDM_CL_20;
+               cl = RT5682S_I2S1_TX_CHL_20 | RT5682S_I2S1_RX_CHL_20;
+               break;
+       case 24:
+               val = RT5682S_TDM_CL_24;
+               cl = RT5682S_I2S1_TX_CHL_24 | RT5682S_I2S1_RX_CHL_24;
+               break;
+       case 32:
+               val = RT5682S_TDM_CL_32;
+               cl = RT5682S_I2S1_TX_CHL_32 | RT5682S_I2S1_RX_CHL_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+               RT5682S_TDM_CL_MASK, val);
+       snd_soc_component_update_bits(component, RT5682S_I2S1_SDP,
+               RT5682S_I2S1_TX_CHL_MASK | RT5682S_I2S1_RX_CHL_MASK, cl);
+
+       return 0;
+}
+
+static int rt5682s_hw_params(struct snd_pcm_substream *substream,
+               struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
+{
+       struct snd_soc_component *component = dai->component;
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       unsigned int len_1 = 0, len_2 = 0;
+       int frame_size;
+
+       rt5682s->lrck[dai->id] = params_rate(params);
+
+       frame_size = snd_soc_params_to_frame_size(params);
+       if (frame_size < 0) {
+               dev_err(component->dev, "Unsupported frame size: %d\n", frame_size);
+               return -EINVAL;
+       }
+
+       switch (params_width(params)) {
+       case 16:
+               break;
+       case 20:
+               len_1 |= RT5682S_I2S1_DL_20;
+               len_2 |= RT5682S_I2S2_DL_20;
+               break;
+       case 24:
+               len_1 |= RT5682S_I2S1_DL_24;
+               len_2 |= RT5682S_I2S2_DL_24;
+               break;
+       case 32:
+               len_1 |= RT5682S_I2S1_DL_32;
+               len_2 |= RT5682S_I2S2_DL_24;
+               break;
+       case 8:
+               len_1 |= RT5682S_I2S2_DL_8;
+               len_2 |= RT5682S_I2S2_DL_8;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (dai->id) {
+       case RT5682S_AIF1:
+               snd_soc_component_update_bits(component, RT5682S_I2S1_SDP,
+                       RT5682S_I2S1_DL_MASK, len_1);
+               if (params_channels(params) == 1) /* mono mode */
+                       snd_soc_component_update_bits(component, RT5682S_I2S1_SDP,
+                               RT5682S_I2S1_MONO_MASK, RT5682S_I2S1_MONO_EN);
+               else
+                       snd_soc_component_update_bits(component, RT5682S_I2S1_SDP,
+                               RT5682S_I2S1_MONO_MASK, RT5682S_I2S1_MONO_DIS);
+               break;
+       case RT5682S_AIF2:
+               snd_soc_component_update_bits(component, RT5682S_I2S2_SDP,
+                       RT5682S_I2S2_DL_MASK, len_2);
+               if (params_channels(params) == 1) /* mono mode */
+                       snd_soc_component_update_bits(component, RT5682S_I2S2_SDP,
+                               RT5682S_I2S2_MONO_MASK, RT5682S_I2S2_MONO_EN);
+               else
+                       snd_soc_component_update_bits(component, RT5682S_I2S2_SDP,
+                               RT5682S_I2S2_MONO_MASK, RT5682S_I2S2_MONO_DIS);
+               break;
+       default:
+               dev_err(component->dev, "Invalid dai->id: %d\n", dai->id);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int rt5682s_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+       struct snd_soc_component *component = dai->component;
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       unsigned int reg_val = 0, tdm_ctrl = 0;
+
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
+       case SND_SOC_DAIFMT_CBM_CFM:
+               rt5682s->master[dai->id] = 1;
+               break;
+       case SND_SOC_DAIFMT_CBS_CFS:
+               rt5682s->master[dai->id] = 0;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+       case SND_SOC_DAIFMT_NB_NF:
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               reg_val |= RT5682S_I2S_BP_INV;
+               tdm_ctrl |= RT5682S_TDM_S_BP_INV;
+               break;
+       case SND_SOC_DAIFMT_NB_IF:
+               if (dai->id == RT5682S_AIF1)
+                       tdm_ctrl |= RT5682S_TDM_S_LP_INV | RT5682S_TDM_M_BP_INV;
+               else
+                       return -EINVAL;
+               break;
+       case SND_SOC_DAIFMT_IB_IF:
+               if (dai->id == RT5682S_AIF1)
+                       tdm_ctrl |= RT5682S_TDM_S_BP_INV | RT5682S_TDM_S_LP_INV |
+                               RT5682S_TDM_M_BP_INV | RT5682S_TDM_M_LP_INV;
+               else
+                       return -EINVAL;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_I2S:
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               reg_val |= RT5682S_I2S_DF_LEFT;
+               tdm_ctrl |= RT5682S_TDM_DF_LEFT;
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               reg_val |= RT5682S_I2S_DF_PCM_A;
+               tdm_ctrl |= RT5682S_TDM_DF_PCM_A;
+               break;
+       case SND_SOC_DAIFMT_DSP_B:
+               reg_val |= RT5682S_I2S_DF_PCM_B;
+               tdm_ctrl |= RT5682S_TDM_DF_PCM_B;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (dai->id) {
+       case RT5682S_AIF1:
+               snd_soc_component_update_bits(component, RT5682S_I2S1_SDP,
+                       RT5682S_I2S_DF_MASK, reg_val);
+               snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+                       RT5682S_TDM_MS_MASK | RT5682S_TDM_S_BP_MASK |
+                       RT5682S_TDM_DF_MASK | RT5682S_TDM_M_BP_MASK |
+                       RT5682S_TDM_M_LP_MASK | RT5682S_TDM_S_LP_MASK,
+                       tdm_ctrl | rt5682s->master[dai->id]);
+               break;
+       case RT5682S_AIF2:
+               if (rt5682s->master[dai->id] == 0)
+                       reg_val |= RT5682S_I2S2_MS_S;
+               snd_soc_component_update_bits(component, RT5682S_I2S2_SDP,
+                       RT5682S_I2S2_MS_MASK | RT5682S_I2S_BP_MASK |
+                       RT5682S_I2S_DF_MASK, reg_val);
+               break;
+       default:
+               dev_err(component->dev, "Invalid dai->id: %d\n", dai->id);
+               return -EINVAL;
+       }
+       return 0;
+}
+
+static int rt5682s_set_component_sysclk(struct snd_soc_component *component,
+               int clk_id, int source, unsigned int freq, int dir)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       unsigned int src = 0;
+
+       if (freq == rt5682s->sysclk && clk_id == rt5682s->sysclk_src)
+               return 0;
+
+       switch (clk_id) {
+       case RT5682S_SCLK_S_MCLK:
+               src = RT5682S_CLK_SRC_MCLK;
+               break;
+       case RT5682S_SCLK_S_PLL1:
+               src = RT5682S_CLK_SRC_PLL1;
+               break;
+       case RT5682S_SCLK_S_PLL2:
+               src = RT5682S_CLK_SRC_PLL2;
+               break;
+       case RT5682S_SCLK_S_RCCLK:
+               src = RT5682S_CLK_SRC_RCCLK;
+               break;
+       default:
+               dev_err(component->dev, "Invalid clock id (%d)\n", clk_id);
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(component, RT5682S_GLB_CLK,
+               RT5682S_SCLK_SRC_MASK, src << RT5682S_SCLK_SRC_SFT);
+       snd_soc_component_update_bits(component, RT5682S_ADDA_CLK_1,
+               RT5682S_I2S_M_CLK_SRC_MASK, src << RT5682S_I2S_M_CLK_SRC_SFT);
+       snd_soc_component_update_bits(component, RT5682S_I2S2_M_CLK_CTRL_1,
+               RT5682S_I2S2_M_CLK_SRC_MASK, src << RT5682S_I2S2_M_CLK_SRC_SFT);
+
+       rt5682s->sysclk = freq;
+       rt5682s->sysclk_src = clk_id;
+
+       dev_dbg(component->dev, "Sysclk is %dHz and clock id is %d\n",
+               freq, clk_id);
+
+       return 0;
+}
+
+static const struct pll_calc_map plla_table[] = {
+       {2048000, 24576000, 0, 46, 2, true, false, false, false},
+       {256000, 24576000, 0, 382, 2, true, false, false, false},
+       {512000, 24576000, 0, 190, 2, true, false, false, false},
+       {4096000, 24576000, 0, 22, 2, true, false, false, false},
+       {1024000, 24576000, 0, 94, 2, true, false, false, false},
+       {11289600, 22579200, 1, 22, 2, false, false, false, false},
+       {1411200, 22579200, 0, 62, 2, true, false, false, false},
+       {2822400, 22579200, 0, 30, 2, true, false, false, false},
+       {12288000, 24576000, 1, 22, 2, false, false, false, false},
+       {1536000, 24576000, 0, 62, 2, true, false, false, false},
+       {3072000, 24576000, 0, 30, 2, true, false, false, false},
+       {24576000, 49152000, 4, 22, 0, false, false, false, false},
+       {3072000, 49152000, 0, 30, 0, true, false, false, false},
+       {6144000, 49152000, 0, 30, 0, false, false, false, false},
+       {49152000, 98304000, 10, 22, 0, false, true, false, false},
+       {6144000, 98304000, 0, 30, 0, false, true, false, false},
+       {12288000, 98304000, 1, 22, 0, false, true, false, false},
+       {48000000, 3840000, 10, 22, 23, false, false, false, false},
+       {24000000, 3840000, 4, 22, 23, false, false, false, false},
+       {19200000, 3840000, 3, 23, 23, false, false, false, false},
+       {38400000, 3840000, 8, 23, 23, false, false, false, false},
+};
+
+static const struct pll_calc_map pllb_table[] = {
+       {48000000, 24576000, 8, 6, 3, false, false, false, false},
+       {48000000, 22579200, 23, 12, 3, false, false, false, true},
+       {24000000, 24576000, 3, 6, 3, false, false, false, false},
+       {24000000, 22579200, 23, 26, 3, false, false, false, true},
+       {19200000, 24576000, 2, 6, 3, false, false, false, false},
+       {19200000, 22579200, 3, 5, 3, false, false, false, true},
+       {38400000, 24576000, 6, 6, 3, false, false, false, false},
+       {38400000, 22579200, 8, 5, 3, false, false, false, true},
+       {3840000, 49152000, 0, 6, 0, true, false, false, false},
+};
+
+static int find_pll_inter_combination(unsigned int f_in, unsigned int f_out,
+               struct pll_calc_map *a, struct pll_calc_map *b)
+{
+       int i, j;
+
+       /* Look at PLLA table */
+       for (i = 0; i < ARRAY_SIZE(plla_table); i++) {
+               if (plla_table[i].freq_in == f_in && plla_table[i].freq_out == f_out) {
+                       memcpy(a, plla_table + i, sizeof(*a));
+                       return USE_PLLA;
+               }
+       }
+
+       /* Look at PLLB table */
+       for (i = 0; i < ARRAY_SIZE(pllb_table); i++) {
+               if (pllb_table[i].freq_in == f_in && pllb_table[i].freq_out == f_out) {
+                       memcpy(b, pllb_table + i, sizeof(*b));
+                       return USE_PLLB;
+               }
+       }
+
+       /* Find a combination of PLLA & PLLB */
+       for (i = ARRAY_SIZE(plla_table) - 1; i >= 0; i--) {
+               if (plla_table[i].freq_in == f_in && plla_table[i].freq_out == 3840000) {
+                       for (j = ARRAY_SIZE(pllb_table) - 1; j >= 0; j--) {
+                               if (pllb_table[j].freq_in == 3840000 &&
+                                       pllb_table[j].freq_out == f_out) {
+                                       memcpy(a, plla_table + i, sizeof(*a));
+                                       memcpy(b, pllb_table + j, sizeof(*b));
+                                       return USE_PLLAB;
+                               }
+                       }
+               }
+       }
+
+       return -EINVAL;
+}
+
+static int rt5682s_set_component_pll(struct snd_soc_component *component,
+               int pll_id, int source, unsigned int freq_in,
+               unsigned int freq_out)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       struct pll_calc_map a_map, b_map;
+
+       if (source == rt5682s->pll_src[pll_id] && freq_in == rt5682s->pll_in[pll_id] &&
+           freq_out == rt5682s->pll_out[pll_id])
+               return 0;
+
+       if (!freq_in || !freq_out) {
+               dev_dbg(component->dev, "PLL disabled\n");
+               rt5682s->pll_in[pll_id] = 0;
+               rt5682s->pll_out[pll_id] = 0;
+               snd_soc_component_update_bits(component, RT5682S_GLB_CLK,
+                       RT5682S_SCLK_SRC_MASK, RT5682S_CLK_SRC_MCLK << RT5682S_SCLK_SRC_SFT);
+               return 0;
+       }
+
+       switch (source) {
+       case RT5682S_PLL_S_MCLK:
+               snd_soc_component_update_bits(component, RT5682S_GLB_CLK,
+                       RT5682S_PLL_SRC_MASK, RT5682S_PLL_SRC_MCLK);
+               break;
+       case RT5682S_PLL_S_BCLK1:
+               snd_soc_component_update_bits(component, RT5682S_GLB_CLK,
+                       RT5682S_PLL_SRC_MASK, RT5682S_PLL_SRC_BCLK1);
+               break;
+       default:
+               dev_err(component->dev, "Unknown PLL Source %d\n", source);
+               return -EINVAL;
+       }
+
+       rt5682s->pll_comb = find_pll_inter_combination(freq_in, freq_out,
+                                                       &a_map, &b_map);
+
+       if ((pll_id == RT5682S_PLL1 && rt5682s->pll_comb == USE_PLLA) ||
+           (pll_id == RT5682S_PLL2 && (rt5682s->pll_comb == USE_PLLB ||
+                                       rt5682s->pll_comb == USE_PLLAB))) {
+               dev_dbg(component->dev,
+                       "Supported freq conversion for PLL%d:(%d->%d): %d\n",
+                       pll_id + 1, freq_in, freq_out, rt5682s->pll_comb);
+       } else {
+               dev_err(component->dev,
+                       "Unsupported freq conversion for PLL%d:(%d->%d): %d\n",
+                       pll_id + 1, freq_in, freq_out, rt5682s->pll_comb);
+               return -EINVAL;
+       }
+
+       if (rt5682s->pll_comb == USE_PLLA || rt5682s->pll_comb == USE_PLLAB) {
+               dev_dbg(component->dev,
+                       "PLLA: fin=%d fout=%d m_bp=%d k_bp=%d m=%d n=%d k=%d\n",
+                       a_map.freq_in, a_map.freq_out, a_map.m_bp, a_map.k_bp,
+                       (a_map.m_bp ? 0 : a_map.m), a_map.n, (a_map.k_bp ? 0 : a_map.k));
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_1,
+                       RT5682S_PLLA_N_MASK, a_map.n);
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_2,
+                       RT5682S_PLLA_M_MASK | RT5682S_PLLA_K_MASK,
+                       a_map.m << RT5682S_PLLA_M_SFT | a_map.k);
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_6,
+                       RT5682S_PLLA_M_BP_MASK | RT5682S_PLLA_K_BP_MASK,
+                       a_map.m_bp << RT5682S_PLLA_M_BP_SFT |
+                       a_map.k_bp << RT5682S_PLLA_K_BP_SFT);
+       }
+
+       if (rt5682s->pll_comb == USE_PLLB || rt5682s->pll_comb == USE_PLLAB) {
+               dev_dbg(component->dev,
+                       "PLLB: fin=%d fout=%d m_bp=%d k_bp=%d m=%d n=%d k=%d byp_ps=%d sel_ps=%d\n",
+                       b_map.freq_in, b_map.freq_out, b_map.m_bp, b_map.k_bp,
+                       (b_map.m_bp ? 0 : b_map.m), b_map.n, (b_map.k_bp ? 0 : b_map.k),
+                       b_map.byp_ps, b_map.sel_ps);
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_3,
+                       RT5682S_PLLB_N_MASK, b_map.n);
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_4,
+                       RT5682S_PLLB_M_MASK | RT5682S_PLLB_K_MASK,
+                       b_map.m << RT5682S_PLLB_M_SFT | b_map.k);
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_6,
+                       RT5682S_PLLB_SEL_PS_MASK | RT5682S_PLLB_BYP_PS_MASK |
+                       RT5682S_PLLB_M_BP_MASK | RT5682S_PLLB_K_BP_MASK,
+                       b_map.sel_ps << RT5682S_PLLB_SEL_PS_SFT |
+                       b_map.byp_ps << RT5682S_PLLB_BYP_PS_SFT |
+                       b_map.m_bp << RT5682S_PLLB_M_BP_SFT |
+                       b_map.k_bp << RT5682S_PLLB_K_BP_SFT);
+       }
+
+       if (rt5682s->pll_comb == USE_PLLB)
+               snd_soc_component_update_bits(component, RT5682S_PLL_CTRL_7,
+                       RT5682S_PLLB_SRC_MASK, RT5682S_PLLB_SRC_DFIN);
+
+       rt5682s->pll_in[pll_id] = freq_in;
+       rt5682s->pll_out[pll_id] = freq_out;
+       rt5682s->pll_src[pll_id] = source;
+
+       return 0;
+}
+
+static int rt5682s_set_bclk1_ratio(struct snd_soc_dai *dai,
+               unsigned int ratio)
+{
+       struct snd_soc_component *component = dai->component;
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       rt5682s->bclk[dai->id] = ratio;
+
+       switch (ratio) {
+       case 256:
+               snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+                       RT5682S_TDM_BCLK_MS1_MASK, RT5682S_TDM_BCLK_MS1_256);
+               break;
+       case 128:
+               snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+                       RT5682S_TDM_BCLK_MS1_MASK, RT5682S_TDM_BCLK_MS1_128);
+               break;
+       case 64:
+               snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+                       RT5682S_TDM_BCLK_MS1_MASK, RT5682S_TDM_BCLK_MS1_64);
+               break;
+       case 32:
+               snd_soc_component_update_bits(component, RT5682S_TDM_TCON_CTRL_1,
+                       RT5682S_TDM_BCLK_MS1_MASK, RT5682S_TDM_BCLK_MS1_32);
+               break;
+       default:
+               dev_err(dai->dev, "Invalid bclk1 ratio %d\n", ratio);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int rt5682s_set_bclk2_ratio(struct snd_soc_dai *dai, unsigned int ratio)
+{
+       struct snd_soc_component *component = dai->component;
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       rt5682s->bclk[dai->id] = ratio;
+
+       switch (ratio) {
+       case 64:
+               snd_soc_component_update_bits(component, RT5682S_ADDA_CLK_2,
+                       RT5682S_I2S2_BCLK_MS2_MASK, RT5682S_I2S2_BCLK_MS2_64);
+               break;
+       case 32:
+               snd_soc_component_update_bits(component, RT5682S_ADDA_CLK_2,
+                       RT5682S_I2S2_BCLK_MS2_MASK, RT5682S_I2S2_BCLK_MS2_32);
+               break;
+       default:
+               dev_err(dai->dev, "Invalid bclk2 ratio %d\n", ratio);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int rt5682s_set_bias_level(struct snd_soc_component *component,
+               enum snd_soc_bias_level level)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       switch (level) {
+       case SND_SOC_BIAS_PREPARE:
+               regmap_update_bits(rt5682s->regmap, RT5682S_PWR_DIG_1,
+                       RT5682S_PWR_LDO, RT5682S_PWR_LDO);
+               break;
+       case SND_SOC_BIAS_STANDBY:
+               regmap_update_bits(rt5682s->regmap, RT5682S_PWR_DIG_1,
+                       RT5682S_DIG_GATE_CTRL, RT5682S_DIG_GATE_CTRL);
+               break;
+       case SND_SOC_BIAS_OFF:
+               regmap_update_bits(rt5682s->regmap, RT5682S_PWR_DIG_1,
+                       RT5682S_DIG_GATE_CTRL | RT5682S_PWR_LDO, 0);
+               break;
+       case SND_SOC_BIAS_ON:
+               break;
+       }
+
+       return 0;
+}
+
+#ifdef CONFIG_COMMON_CLK
+#define CLK_PLL2_FIN 48000000
+#define CLK_48 48000
+#define CLK_44 44100
+
+static bool rt5682s_clk_check(struct rt5682s_priv *rt5682s)
+{
+       if (!rt5682s->master[RT5682S_AIF1]) {
+               dev_dbg(rt5682s->component->dev, "dai clk fmt not set correctly\n");
+               return false;
+       }
+       return true;
+}
+
+static int rt5682s_wclk_prepare(struct clk_hw *hw)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
+
+       if (!rt5682s_clk_check(rt5682s))
+               return -EINVAL;
+
+       snd_soc_dapm_mutex_lock(dapm);
+
+       snd_soc_dapm_force_enable_pin_unlocked(dapm, "MICBIAS");
+       snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+               RT5682S_PWR_MB, RT5682S_PWR_MB);
+
+       snd_soc_dapm_force_enable_pin_unlocked(dapm, "Vref2");
+       snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+               RT5682S_PWR_VREF2 | RT5682S_PWR_FV2, RT5682S_PWR_VREF2);
+       usleep_range(15000, 20000);
+       snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+               RT5682S_PWR_FV2, RT5682S_PWR_FV2);
+
+       snd_soc_dapm_force_enable_pin_unlocked(dapm, "I2S1");
+       /* Only need to power PLLB due to the rate set restriction */
+       snd_soc_dapm_force_enable_pin_unlocked(dapm, "PLLB");
+       snd_soc_dapm_sync_unlocked(dapm);
+
+       snd_soc_dapm_mutex_unlock(dapm);
+
+       return 0;
+}
+
+static void rt5682s_wclk_unprepare(struct clk_hw *hw)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
+
+       if (!rt5682s_clk_check(rt5682s))
+               return;
+
+       snd_soc_dapm_mutex_lock(dapm);
+
+       snd_soc_dapm_disable_pin_unlocked(dapm, "MICBIAS");
+       snd_soc_dapm_disable_pin_unlocked(dapm, "Vref2");
+       if (!rt5682s->jack_type)
+               snd_soc_component_update_bits(component, RT5682S_PWR_ANLG_1,
+                       RT5682S_PWR_VREF2 | RT5682S_PWR_FV2 | RT5682S_PWR_MB, 0);
+
+       snd_soc_dapm_disable_pin_unlocked(dapm, "I2S1");
+       snd_soc_dapm_disable_pin_unlocked(dapm, "PLLB");
+       snd_soc_dapm_sync_unlocked(dapm);
+
+       snd_soc_dapm_mutex_unlock(dapm);
+}
+
+static unsigned long rt5682s_wclk_recalc_rate(struct clk_hw *hw,
+                                            unsigned long parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       const char * const clk_name = clk_hw_get_name(hw);
+
+       if (!rt5682s_clk_check(rt5682s))
+               return 0;
+       /*
+        * Only accept to set wclk rate to 44.1k or 48kHz.
+        */
+       if (rt5682s->lrck[RT5682S_AIF1] != CLK_48 &&
+           rt5682s->lrck[RT5682S_AIF1] != CLK_44) {
+               dev_warn(component->dev, "%s: clk %s only support %d or %d Hz output\n",
+                       __func__, clk_name, CLK_44, CLK_48);
+               return 0;
+       }
+
+       return rt5682s->lrck[RT5682S_AIF1];
+}
+
+static long rt5682s_wclk_round_rate(struct clk_hw *hw, unsigned long rate,
+                                  unsigned long *parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       const char * const clk_name = clk_hw_get_name(hw);
+
+       if (!rt5682s_clk_check(rt5682s))
+               return -EINVAL;
+       /*
+        * Only accept to set wclk rate to 44.1k or 48kHz.
+        * It will force to 48kHz if not both.
+        */
+       if (rate != CLK_48 && rate != CLK_44) {
+               dev_warn(component->dev, "%s: clk %s only support %d or %d Hz output\n",
+                       __func__, clk_name, CLK_44, CLK_48);
+               rate = CLK_48;
+       }
+
+       return rate;
+}
+
+static int rt5682s_wclk_set_rate(struct clk_hw *hw, unsigned long rate,
+                               unsigned long parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_WCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       struct clk *parent_clk;
+       const char * const clk_name = clk_hw_get_name(hw);
+       unsigned int clk_pll2_fout;
+
+       if (!rt5682s_clk_check(rt5682s))
+               return -EINVAL;
+
+       /*
+        * Whether the wclk's parent clk (mclk) exists or not, please ensure
+        * it is fixed or set to 48MHz before setting wclk rate. It's a
+        * temporary limitation. Only accept 48MHz clk as the clk provider.
+        *
+        * It will set the codec anyway by assuming mclk is 48MHz.
+        */
+       parent_clk = clk_get_parent(hw->clk);
+       if (!parent_clk)
+               dev_warn(component->dev,
+                       "Parent mclk of wclk not acquired in driver. Please ensure mclk was provided as %d Hz.\n",
+                       CLK_PLL2_FIN);
+
+       if (parent_rate != CLK_PLL2_FIN)
+               dev_warn(component->dev, "clk %s only support %d Hz input\n",
+                       clk_name, CLK_PLL2_FIN);
+
+       /*
+        * To achieve the rate conversion from 48MHz to 44.1k or 48kHz,
+        * PLL2 is needed.
+        */
+       clk_pll2_fout = rate * 512;
+       rt5682s_set_component_pll(component, RT5682S_PLL2, RT5682S_PLL_S_MCLK,
+               CLK_PLL2_FIN, clk_pll2_fout);
+
+       rt5682s_set_component_sysclk(component, RT5682S_SCLK_S_PLL2, 0,
+               clk_pll2_fout, SND_SOC_CLOCK_IN);
+
+       rt5682s->lrck[RT5682S_AIF1] = rate;
+
+       return 0;
+}
+
+static unsigned long rt5682s_bclk_recalc_rate(struct clk_hw *hw,
+                                            unsigned long parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_BCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       unsigned int bclks_per_wclk;
+
+       bclks_per_wclk = snd_soc_component_read(component, RT5682S_TDM_TCON_CTRL_1);
+
+       switch (bclks_per_wclk & RT5682S_TDM_BCLK_MS1_MASK) {
+       case RT5682S_TDM_BCLK_MS1_256:
+               return parent_rate * 256;
+       case RT5682S_TDM_BCLK_MS1_128:
+               return parent_rate * 128;
+       case RT5682S_TDM_BCLK_MS1_64:
+               return parent_rate * 64;
+       case RT5682S_TDM_BCLK_MS1_32:
+               return parent_rate * 32;
+       default:
+               return 0;
+       }
+}
+
+static unsigned long rt5682s_bclk_get_factor(unsigned long rate,
+                                           unsigned long parent_rate)
+{
+       unsigned long factor;
+
+       factor = rate / parent_rate;
+       if (factor < 64)
+               return 32;
+       else if (factor < 128)
+               return 64;
+       else if (factor < 256)
+               return 128;
+       else
+               return 256;
+}
+
+static long rt5682s_bclk_round_rate(struct clk_hw *hw, unsigned long rate,
+                                  unsigned long *parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_BCLK_IDX]);
+       unsigned long factor;
+
+       if (!*parent_rate || !rt5682s_clk_check(rt5682s))
+               return -EINVAL;
+
+       /*
+        * BCLK rates are set as a multiplier of WCLK in HW.
+        * We don't allow changing the parent WCLK. We just do
+        * some rounding down based on the parent WCLK rate
+        * and find the appropriate multiplier of BCLK to
+        * get the rounded down BCLK value.
+        */
+       factor = rt5682s_bclk_get_factor(rate, *parent_rate);
+
+       return *parent_rate * factor;
+}
+
+static int rt5682s_bclk_set_rate(struct clk_hw *hw, unsigned long rate,
+                               unsigned long parent_rate)
+{
+       struct rt5682s_priv *rt5682s =
+               container_of(hw, struct rt5682s_priv, dai_clks_hw[RT5682S_DAI_BCLK_IDX]);
+       struct snd_soc_component *component = rt5682s->component;
+       struct snd_soc_dai *dai;
+       unsigned long factor;
+
+       if (!rt5682s_clk_check(rt5682s))
+               return -EINVAL;
+
+       factor = rt5682s_bclk_get_factor(rate, parent_rate);
+
+       for_each_component_dais(component, dai)
+               if (dai->id == RT5682S_AIF1)
+                       break;
+       if (!dai) {
+               dev_err(component->dev, "dai %d not found in component\n",
+                       RT5682S_AIF1);
+               return -ENODEV;
+       }
+
+       return rt5682s_set_bclk1_ratio(dai, factor);
+}
+
+static const struct clk_ops rt5682s_dai_clk_ops[RT5682S_DAI_NUM_CLKS] = {
+       [RT5682S_DAI_WCLK_IDX] = {
+               .prepare = rt5682s_wclk_prepare,
+               .unprepare = rt5682s_wclk_unprepare,
+               .recalc_rate = rt5682s_wclk_recalc_rate,
+               .round_rate = rt5682s_wclk_round_rate,
+               .set_rate = rt5682s_wclk_set_rate,
+       },
+       [RT5682S_DAI_BCLK_IDX] = {
+               .recalc_rate = rt5682s_bclk_recalc_rate,
+               .round_rate = rt5682s_bclk_round_rate,
+               .set_rate = rt5682s_bclk_set_rate,
+       },
+};
+
+static int rt5682s_register_dai_clks(struct snd_soc_component *component)
+{
+       struct device *dev = component->dev;
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       struct rt5682s_platform_data *pdata = &rt5682s->pdata;
+       struct clk_hw *dai_clk_hw;
+       int i, ret;
+
+       for (i = 0; i < RT5682S_DAI_NUM_CLKS; ++i) {
+               struct clk_init_data init = { };
+
+               dai_clk_hw = &rt5682s->dai_clks_hw[i];
+
+               switch (i) {
+               case RT5682S_DAI_WCLK_IDX:
+                       /* Make MCLK the parent of WCLK */
+                       if (rt5682s->mclk) {
+                               init.parent_data = &(struct clk_parent_data){
+                                       .fw_name = "mclk",
+                               };
+                               init.num_parents = 1;
+                       }
+                       break;
+               case RT5682S_DAI_BCLK_IDX:
+                       /* Make WCLK the parent of BCLK */
+                       init.parent_hws = &(const struct clk_hw *){
+                               &rt5682s->dai_clks_hw[RT5682S_DAI_WCLK_IDX]
+                       };
+                       init.num_parents = 1;
+                       break;
+               default:
+                       dev_err(dev, "Invalid clock index\n");
+                       return -EINVAL;
+               }
+
+               init.name = pdata->dai_clk_names[i];
+               init.ops = &rt5682s_dai_clk_ops[i];
+               init.flags = CLK_GET_RATE_NOCACHE | CLK_SET_RATE_GATE;
+               dai_clk_hw->init = &init;
+
+               ret = devm_clk_hw_register(dev, dai_clk_hw);
+               if (ret) {
+                       dev_warn(dev, "Failed to register %s: %d\n", init.name, ret);
+                       return ret;
+               }
+
+               if (dev->of_node) {
+                       devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, dai_clk_hw);
+               } else {
+                       ret = devm_clk_hw_register_clkdev(dev, dai_clk_hw,
+                                                         init.name, dev_name(dev));
+                       if (ret)
+                               return ret;
+               }
+       }
+
+       return 0;
+}
+
+static int rt5682s_dai_probe_clks(struct snd_soc_component *component)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       int ret;
+
+       /* Check if MCLK provided */
+       rt5682s->mclk = devm_clk_get(component->dev, "mclk");
+       if (IS_ERR(rt5682s->mclk)) {
+               if (PTR_ERR(rt5682s->mclk) != -ENOENT) {
+                       ret = PTR_ERR(rt5682s->mclk);
+                       return ret;
+               }
+               rt5682s->mclk = NULL;
+       }
+
+       /* Register CCF DAI clock control */
+       ret = rt5682s_register_dai_clks(component);
+       if (ret)
+               return ret;
+
+       /* Initial setup for CCF */
+       rt5682s->lrck[RT5682S_AIF1] = CLK_48;
+
+       return 0;
+}
+#else
+static inline int rt5682s_dai_probe_clks(struct snd_soc_component *component)
+{
+       return 0;
+}
+#endif /* CONFIG_COMMON_CLK */
+
+static int rt5682s_probe(struct snd_soc_component *component)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+       struct snd_soc_dapm_context *dapm = &component->dapm;
+       int ret;
+
+       rt5682s->component = component;
+
+       ret = rt5682s_dai_probe_clks(component);
+       if (ret)
+               return ret;
+
+       snd_soc_dapm_disable_pin(dapm, "MICBIAS");
+       snd_soc_dapm_disable_pin(dapm, "Vref2");
+       snd_soc_dapm_sync(dapm);
+       return 0;
+}
+
+static void rt5682s_remove(struct snd_soc_component *component)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       rt5682s_reset(rt5682s);
+}
+
+#ifdef CONFIG_PM
+static int rt5682s_suspend(struct snd_soc_component *component)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       cancel_delayed_work_sync(&rt5682s->jack_detect_work);
+       cancel_delayed_work_sync(&rt5682s->jd_check_work);
+
+       if (rt5682s->hs_jack && rt5682s->jack_type == SND_JACK_HEADSET)
+               snd_soc_component_update_bits(component, RT5682S_4BTN_IL_CMD_2,
+                       RT5682S_4BTN_IL_MASK, RT5682S_4BTN_IL_DIS);
+
+       regcache_cache_only(rt5682s->regmap, true);
+       regcache_mark_dirty(rt5682s->regmap);
+
+       return 0;
+}
+
+static int rt5682s_resume(struct snd_soc_component *component)
+{
+       struct rt5682s_priv *rt5682s = snd_soc_component_get_drvdata(component);
+
+       regcache_cache_only(rt5682s->regmap, false);
+       regcache_sync(rt5682s->regmap);
+
+       if (rt5682s->hs_jack) {
+               rt5682s->jack_type = 0;
+               rt5682s_sar_power_mode(component, SAR_PWR_NORMAL, 0);
+               mod_delayed_work(system_power_efficient_wq,
+                       &rt5682s->jack_detect_work, msecs_to_jiffies(0));
+       }
+
+       return 0;
+}
+#else
+#define rt5682s_suspend NULL
+#define rt5682s_resume NULL
+#endif
+
+static const struct snd_soc_dai_ops rt5682s_aif1_dai_ops = {
+       .hw_params = rt5682s_hw_params,
+       .set_fmt = rt5682s_set_dai_fmt,
+       .set_tdm_slot = rt5682s_set_tdm_slot,
+       .set_bclk_ratio = rt5682s_set_bclk1_ratio,
+};
+
+static const struct snd_soc_dai_ops rt5682s_aif2_dai_ops = {
+       .hw_params = rt5682s_hw_params,
+       .set_fmt = rt5682s_set_dai_fmt,
+       .set_bclk_ratio = rt5682s_set_bclk2_ratio,
+};
+
+static const struct snd_soc_component_driver rt5682s_soc_component_dev = {
+       .probe = rt5682s_probe,
+       .remove = rt5682s_remove,
+       .suspend = rt5682s_suspend,
+       .resume = rt5682s_resume,
+       .set_bias_level = rt5682s_set_bias_level,
+       .controls = rt5682s_snd_controls,
+       .num_controls = ARRAY_SIZE(rt5682s_snd_controls),
+       .dapm_widgets = rt5682s_dapm_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(rt5682s_dapm_widgets),
+       .dapm_routes = rt5682s_dapm_routes,
+       .num_dapm_routes = ARRAY_SIZE(rt5682s_dapm_routes),
+       .set_sysclk = rt5682s_set_component_sysclk,
+       .set_pll = rt5682s_set_component_pll,
+       .set_jack = rt5682s_set_jack_detect,
+       .use_pmdown_time        = 1,
+       .endianness             = 1,
+       .non_legacy_dai_naming  = 1,
+};
+
+static int rt5682s_parse_dt(struct rt5682s_priv *rt5682s, struct device *dev)
+{
+       device_property_read_u32(dev, "realtek,dmic1-data-pin",
+               &rt5682s->pdata.dmic1_data_pin);
+       device_property_read_u32(dev, "realtek,dmic1-clk-pin",
+               &rt5682s->pdata.dmic1_clk_pin);
+       device_property_read_u32(dev, "realtek,jd-src",
+               &rt5682s->pdata.jd_src);
+       device_property_read_u32(dev, "realtek,dmic-clk-rate-hz",
+               &rt5682s->pdata.dmic_clk_rate);
+       device_property_read_u32(dev, "realtek,dmic-delay-ms",
+               &rt5682s->pdata.dmic_delay);
+
+       rt5682s->pdata.ldo1_en = of_get_named_gpio(dev->of_node,
+               "realtek,ldo1-en-gpios", 0);
+
+       if (device_property_read_string_array(dev, "clock-output-names",
+                                             rt5682s->pdata.dai_clk_names,
+                                             RT5682S_DAI_NUM_CLKS) < 0)
+               dev_warn(dev, "Using default DAI clk names: %s, %s\n",
+                        rt5682s->pdata.dai_clk_names[RT5682S_DAI_WCLK_IDX],
+                        rt5682s->pdata.dai_clk_names[RT5682S_DAI_BCLK_IDX]);
+
+       rt5682s->pdata.dmic_clk_driving_high = device_property_read_bool(dev,
+               "realtek,dmic-clk-driving-high");
+
+       return 0;
+}
+
+static void rt5682s_calibrate(struct rt5682s_priv *rt5682s)
+{
+       unsigned int count, value;
+
+       mutex_lock(&rt5682s->calibrate_mutex);
+
+       regmap_write(rt5682s->regmap, RT5682S_PWR_ANLG_1, 0xaa80);
+       usleep_range(15000, 20000);
+       regmap_write(rt5682s->regmap, RT5682S_PWR_ANLG_1, 0xfa80);
+       regmap_write(rt5682s->regmap, RT5682S_PWR_DIG_1, 0x01c0);
+       regmap_write(rt5682s->regmap, RT5682S_MICBIAS_2, 0x0380);
+       regmap_write(rt5682s->regmap, RT5682S_GLB_CLK, 0x8000);
+       regmap_write(rt5682s->regmap, RT5682S_ADDA_CLK_1, 0x1001);
+       regmap_write(rt5682s->regmap, RT5682S_CHOP_DAC_2, 0x3030);
+       regmap_write(rt5682s->regmap, RT5682S_CHOP_ADC, 0xb000);
+       regmap_write(rt5682s->regmap, RT5682S_STO1_ADC_MIXER, 0x686c);
+       regmap_write(rt5682s->regmap, RT5682S_CAL_REC, 0x5151);
+       regmap_write(rt5682s->regmap, RT5682S_HP_CALIB_CTRL_2, 0x0321);
+       regmap_write(rt5682s->regmap, RT5682S_HP_LOGIC_CTRL_2, 0x0004);
+       regmap_write(rt5682s->regmap, RT5682S_HP_CALIB_CTRL_1, 0x7c00);
+       regmap_write(rt5682s->regmap, RT5682S_HP_CALIB_CTRL_1, 0xfc00);
+
+       for (count = 0; count < 60; count++) {
+               regmap_read(rt5682s->regmap, RT5682S_HP_CALIB_ST_1, &value);
+               if (!(value & 0x8000))
+                       break;
+
+               usleep_range(10000, 10005);
+       }
+
+       if (count >= 60)
+               dev_err(rt5682s->component->dev, "HP Calibration Failure\n");
+
+       /* restore settings */
+       regmap_write(rt5682s->regmap, RT5682S_MICBIAS_2, 0x0180);
+       regmap_write(rt5682s->regmap, RT5682S_CAL_REC, 0x5858);
+       regmap_write(rt5682s->regmap, RT5682S_STO1_ADC_MIXER, 0xc0c4);
+       regmap_write(rt5682s->regmap, RT5682S_HP_CALIB_CTRL_2, 0x0320);
+       regmap_write(rt5682s->regmap, RT5682S_PWR_DIG_1, 0x00c0);
+       regmap_write(rt5682s->regmap, RT5682S_PWR_ANLG_1, 0x0800);
+       regmap_write(rt5682s->regmap, RT5682S_GLB_CLK, 0x0000);
+
+       mutex_unlock(&rt5682s->calibrate_mutex);
+}
+
+static const struct regmap_config rt5682s_regmap = {
+       .reg_bits = 16,
+       .val_bits = 16,
+       .max_register = RT5682S_MAX_REG,
+       .volatile_reg = rt5682s_volatile_register,
+       .readable_reg = rt5682s_readable_register,
+       .cache_type = REGCACHE_RBTREE,
+       .reg_defaults = rt5682s_reg,
+       .num_reg_defaults = ARRAY_SIZE(rt5682s_reg),
+       .use_single_read = true,
+       .use_single_write = true,
+};
+
+static struct snd_soc_dai_driver rt5682s_dai[] = {
+       {
+               .name = "rt5682s-aif1",
+               .id = RT5682S_AIF1,
+               .playback = {
+                       .stream_name = "AIF1 Playback",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = RT5682S_STEREO_RATES,
+                       .formats = RT5682S_FORMATS,
+               },
+               .capture = {
+                       .stream_name = "AIF1 Capture",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = RT5682S_STEREO_RATES,
+                       .formats = RT5682S_FORMATS,
+               },
+               .ops = &rt5682s_aif1_dai_ops,
+       },
+       {
+               .name = "rt5682s-aif2",
+               .id = RT5682S_AIF2,
+               .capture = {
+                       .stream_name = "AIF2 Capture",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = RT5682S_STEREO_RATES,
+                       .formats = RT5682S_FORMATS,
+               },
+               .ops = &rt5682s_aif2_dai_ops,
+       },
+};
+
+static void rt5682s_i2c_disable_regulators(void *data)
+{
+       struct rt5682s_priv *rt5682s = data;
+
+       regulator_bulk_disable(ARRAY_SIZE(rt5682s->supplies), rt5682s->supplies);
+}
+
+static int rt5682s_i2c_probe(struct i2c_client *i2c,
+               const struct i2c_device_id *id)
+{
+       struct rt5682s_platform_data *pdata = dev_get_platdata(&i2c->dev);
+       struct rt5682s_priv *rt5682s;
+       int i, ret;
+       unsigned int val;
+
+       rt5682s = devm_kzalloc(&i2c->dev, sizeof(struct rt5682s_priv), GFP_KERNEL);
+       if (!rt5682s)
+               return -ENOMEM;
+
+       i2c_set_clientdata(i2c, rt5682s);
+
+       rt5682s->pdata = i2s_default_platform_data;
+
+       if (pdata)
+               rt5682s->pdata = *pdata;
+       else
+               rt5682s_parse_dt(rt5682s, &i2c->dev);
+
+       rt5682s->regmap = devm_regmap_init_i2c(i2c, &rt5682s_regmap);
+       if (IS_ERR(rt5682s->regmap)) {
+               ret = PTR_ERR(rt5682s->regmap);
+               dev_err(&i2c->dev, "Failed to allocate register map: %d\n", ret);
+               return ret;
+       }
+
+       for (i = 0; i < ARRAY_SIZE(rt5682s->supplies); i++)
+               rt5682s->supplies[i].supply = rt5682s_supply_names[i];
+
+       ret = devm_regulator_bulk_get(&i2c->dev,
+                       ARRAY_SIZE(rt5682s->supplies), rt5682s->supplies);
+       if (ret) {
+               dev_err(&i2c->dev, "Failed to request supplies: %d\n", ret);
+               return ret;
+       }
+
+       ret = devm_add_action_or_reset(&i2c->dev, rt5682s_i2c_disable_regulators, rt5682s);
+       if (ret)
+               return ret;
+
+       ret = regulator_bulk_enable(ARRAY_SIZE(rt5682s->supplies), rt5682s->supplies);
+       if (ret) {
+               dev_err(&i2c->dev, "Failed to enable supplies: %d\n", ret);
+               return ret;
+       }
+
+       if (gpio_is_valid(rt5682s->pdata.ldo1_en)) {
+               if (devm_gpio_request_one(&i2c->dev, rt5682s->pdata.ldo1_en,
+                                         GPIOF_OUT_INIT_HIGH, "rt5682s"))
+                       dev_err(&i2c->dev, "Fail gpio_request gpio_ldo\n");
+       }
+
+       /* Sleep for 50 ms minimum */
+       usleep_range(50000, 55000);
+
+       regmap_read(rt5682s->regmap, RT5682S_DEVICE_ID, &val);
+       if (val != DEVICE_ID) {
+               dev_err(&i2c->dev, "Device with ID register %x is not rt5682s\n", val);
+               return -ENODEV;
+       }
+
+       rt5682s_reset(rt5682s);
+       rt5682s_apply_patch_list(rt5682s, &i2c->dev);
+
+       regmap_update_bits(rt5682s->regmap, RT5682S_PWR_DIG_2,
+               RT5682S_DLDO_I_LIMIT_MASK, RT5682S_DLDO_I_LIMIT_DIS);
+       usleep_range(20000, 25000);
+
+       mutex_init(&rt5682s->calibrate_mutex);
+       mutex_init(&rt5682s->sar_mutex);
+       mutex_init(&rt5682s->jdet_mutex);
+       rt5682s_calibrate(rt5682s);
+
+       regmap_update_bits(rt5682s->regmap, RT5682S_MICBIAS_2,
+               RT5682S_PWR_CLK25M_MASK | RT5682S_PWR_CLK1M_MASK,
+               RT5682S_PWR_CLK25M_PD | RT5682S_PWR_CLK1M_PU);
+       regmap_update_bits(rt5682s->regmap, RT5682S_PWR_ANLG_1,
+               RT5682S_PWR_BG, RT5682S_PWR_BG);
+       regmap_update_bits(rt5682s->regmap, RT5682S_HP_LOGIC_CTRL_2,
+               RT5682S_HP_SIG_SRC_MASK, RT5682S_HP_SIG_SRC_1BIT_CTL);
+       regmap_update_bits(rt5682s->regmap, RT5682S_HP_CHARGE_PUMP_2,
+               RT5682S_PM_HP_MASK, RT5682S_PM_HP_HV);
+       regmap_update_bits(rt5682s->regmap, RT5682S_HP_AMP_DET_CTL_1,
+               RT5682S_CP_SW_SIZE_MASK, RT5682S_CP_SW_SIZE_M);
+
+       /* DMIC data pin */
+       switch (rt5682s->pdata.dmic1_data_pin) {
+       case RT5682S_DMIC1_DATA_NULL:
+               break;
+       case RT5682S_DMIC1_DATA_GPIO2: /* share with LRCK2 */
+               regmap_update_bits(rt5682s->regmap, RT5682S_DMIC_CTRL_1,
+                       RT5682S_DMIC_1_DP_MASK, RT5682S_DMIC_1_DP_GPIO2);
+               regmap_update_bits(rt5682s->regmap, RT5682S_GPIO_CTRL_1,
+                       RT5682S_GP2_PIN_MASK, RT5682S_GP2_PIN_DMIC_SDA);
+               break;
+       case RT5682S_DMIC1_DATA_GPIO5: /* share with DACDAT1 */
+               regmap_update_bits(rt5682s->regmap, RT5682S_DMIC_CTRL_1,
+                       RT5682S_DMIC_1_DP_MASK, RT5682S_DMIC_1_DP_GPIO5);
+               regmap_update_bits(rt5682s->regmap, RT5682S_GPIO_CTRL_1,
+                       RT5682S_GP5_PIN_MASK, RT5682S_GP5_PIN_DMIC_SDA);
+               break;
+       default:
+               dev_warn(&i2c->dev, "invalid DMIC_DAT pin\n");
+               break;
+       }
+
+       /* DMIC clk pin */
+       switch (rt5682s->pdata.dmic1_clk_pin) {
+       case RT5682S_DMIC1_CLK_NULL:
+               break;
+       case RT5682S_DMIC1_CLK_GPIO1: /* share with IRQ */
+               regmap_update_bits(rt5682s->regmap, RT5682S_GPIO_CTRL_1,
+                       RT5682S_GP1_PIN_MASK, RT5682S_GP1_PIN_DMIC_CLK);
+               break;
+       case RT5682S_DMIC1_CLK_GPIO3: /* share with BCLK2 */
+               regmap_update_bits(rt5682s->regmap, RT5682S_GPIO_CTRL_1,
+                       RT5682S_GP3_PIN_MASK, RT5682S_GP3_PIN_DMIC_CLK);
+               if (rt5682s->pdata.dmic_clk_driving_high)
+                       regmap_update_bits(rt5682s->regmap, RT5682S_PAD_DRIVING_CTRL,
+                               RT5682S_PAD_DRV_GP3_MASK, RT5682S_PAD_DRV_GP3_HIGH);
+               break;
+       default:
+               dev_warn(&i2c->dev, "invalid DMIC_CLK pin\n");
+               break;
+       }
+
+       INIT_DELAYED_WORK(&rt5682s->jack_detect_work, rt5682s_jack_detect_handler);
+       INIT_DELAYED_WORK(&rt5682s->jd_check_work, rt5682s_jd_check_handler);
+
+       if (i2c->irq) {
+               ret = devm_request_threaded_irq(&i2c->dev, i2c->irq, NULL, rt5682s_irq,
+                       IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+                       "rt5682s", rt5682s);
+               if (ret)
+                       dev_err(&i2c->dev, "Failed to reguest IRQ: %d\n", ret);
+       }
+
+       return devm_snd_soc_register_component(&i2c->dev, &rt5682s_soc_component_dev,
+                       rt5682s_dai, ARRAY_SIZE(rt5682s_dai));
+}
+
+static void rt5682s_i2c_shutdown(struct i2c_client *client)
+{
+       struct rt5682s_priv *rt5682s = i2c_get_clientdata(client);
+
+       disable_irq(client->irq);
+       cancel_delayed_work_sync(&rt5682s->jack_detect_work);
+       cancel_delayed_work_sync(&rt5682s->jd_check_work);
+
+       rt5682s_reset(rt5682s);
+}
+
+static int rt5682s_i2c_remove(struct i2c_client *client)
+{
+       rt5682s_i2c_shutdown(client);
+
+       return 0;
+}
+
+static const struct of_device_id rt5682s_of_match[] = {
+       {.compatible = "realtek,rt5682s"},
+       {},
+};
+MODULE_DEVICE_TABLE(of, rt5682s_of_match);
+
+static const struct acpi_device_id rt5682s_acpi_match[] = {
+       {"RTL5682", 0,},
+       {},
+};
+MODULE_DEVICE_TABLE(acpi, rt5682s_acpi_match);
+
+static const struct i2c_device_id rt5682s_i2c_id[] = {
+       {"rt5682s", 0},
+       {}
+};
+MODULE_DEVICE_TABLE(i2c, rt5682s_i2c_id);
+
+static struct i2c_driver rt5682s_i2c_driver = {
+       .driver = {
+               .name = "rt5682s",
+               .of_match_table = rt5682s_of_match,
+               .acpi_match_table = rt5682s_acpi_match,
+               .probe_type = PROBE_PREFER_ASYNCHRONOUS,
+       },
+       .probe = rt5682s_i2c_probe,
+       .remove = rt5682s_i2c_remove,
+       .shutdown = rt5682s_i2c_shutdown,
+       .id_table = rt5682s_i2c_id,
+};
+module_i2c_driver(rt5682s_i2c_driver);
+
+MODULE_DESCRIPTION("ASoC RT5682I-VS driver");
+MODULE_AUTHOR("Derek Fang <derek.fang@realtek.com>");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/codecs/rt5682s.h b/sound/soc/codecs/rt5682s.h
new file mode 100644 (file)
index 0000000..1bf2ef7
--- /dev/null
@@ -0,0 +1,1474 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * rt5682s.h  --  RT5682I-VS ALSA SoC audio driver
+ *
+ * Copyright 2021 Realtek Microelectronics
+ * Author: Derek Fang <derek.fang@realtek.com>
+ */
+
+#ifndef __RT5682S_H__
+#define __RT5682S_H__
+
+#include <sound/rt5682s.h>
+#include <linux/regulator/consumer.h>
+#include <linux/clk.h>
+#include <linux/clkdev.h>
+#include <linux/clk-provider.h>
+
+
+/* Info */
+#define RT5682S_RESET                          0x0000
+#define RT5682S_VERSION_ID                     0x00fd
+#define RT5682S_VENDOR_ID                      0x00fe
+#define RT5682S_DEVICE_ID                      0x00ff
+/*  I/O - Output */
+#define RT5682S_HP_CTRL_1                      0x0002
+#define RT5682S_HP_CTRL_2                      0x0003
+#define RT5682S_HPL_GAIN                       0x0005
+#define RT5682S_HPR_GAIN                       0x0006
+
+#define RT5682S_I2C_CTRL                       0x0008
+
+/* I/O - Input */
+#define RT5682S_CBJ_BST_CTRL                   0x000b
+#define RT5682S_CBJ_DET_CTRL                   0x000f
+#define RT5682S_CBJ_CTRL_1                     0x0010
+#define RT5682S_CBJ_CTRL_2                     0x0011
+#define RT5682S_CBJ_CTRL_3                     0x0012
+#define RT5682S_CBJ_CTRL_4                     0x0013
+#define RT5682S_CBJ_CTRL_5                     0x0014
+#define RT5682S_CBJ_CTRL_6                     0x0015
+#define RT5682S_CBJ_CTRL_7                     0x0016
+#define RT5682S_CBJ_CTRL_8                     0x0017
+/* I/O - ADC/DAC/DMIC */
+#define RT5682S_DAC1_DIG_VOL                   0x0019
+#define RT5682S_STO1_ADC_DIG_VOL               0x001c
+#define RT5682S_STO1_ADC_BOOST                 0x001f
+#define RT5682S_HP_IMP_GAIN_1                  0x0022
+#define RT5682S_HP_IMP_GAIN_2                  0x0023
+/* Mixer - D-D */
+#define RT5682S_SIDETONE_CTRL                  0x0024
+#define RT5682S_STO1_ADC_MIXER                 0x0026
+#define RT5682S_AD_DA_MIXER                    0x0029
+#define RT5682S_STO1_DAC_MIXER                 0x002a
+#define RT5682S_A_DAC1_MUX                     0x002b
+#define RT5682S_DIG_INF2_DATA                  0x0030
+/* Mixer - ADC */
+#define RT5682S_REC_MIXER                      0x003c
+#define RT5682S_CAL_REC                                0x0044
+/* HP Analog Offset Control */
+#define RT5682S_HP_ANA_OST_CTRL_1              0x004b
+#define RT5682S_HP_ANA_OST_CTRL_2              0x004c
+#define RT5682S_HP_ANA_OST_CTRL_3              0x004d
+/* Power */
+#define RT5682S_PWR_DIG_1                      0x0061
+#define RT5682S_PWR_DIG_2                      0x0062
+#define RT5682S_PWR_ANLG_1                     0x0063
+#define RT5682S_PWR_ANLG_2                     0x0064
+#define RT5682S_PWR_ANLG_3                     0x0065
+#define RT5682S_PWR_MIXER                      0x0066
+
+#define RT5682S_MB_CTRL                                0x0067
+#define RT5682S_CLK_GATE_TCON_1                        0x0068
+#define RT5682S_CLK_GATE_TCON_2                        0x0069
+#define RT5682S_CLK_GATE_TCON_3                        0x006a
+/* Clock Detect */
+#define RT5682S_CLK_DET                                0x006b
+/* Filter Auto Reset */
+#define RT5682S_RESET_LPF_CTRL                 0x006c
+#define RT5682S_RESET_HPF_CTRL                 0x006d
+/* DMIC */
+#define RT5682S_DMIC_CTRL_1                    0x006e
+#define RT5682S_LPF_AD_DMIC                    0x006f
+/* Format - ADC/DAC */
+#define RT5682S_I2S1_SDP                       0x0070
+#define RT5682S_I2S2_SDP                       0x0071
+#define RT5682S_ADDA_CLK_1                     0x0073
+#define RT5682S_ADDA_CLK_2                     0x0074
+#define RT5682S_I2S1_F_DIV_CTRL_1              0x0075
+#define RT5682S_I2S1_F_DIV_CTRL_2              0x0076
+/* Format - TDM Control */
+#define RT5682S_TDM_CTRL                       0x0079
+#define RT5682S_TDM_ADDA_CTRL_1                        0x007a
+#define RT5682S_TDM_ADDA_CTRL_2                        0x007b
+#define RT5682S_DATA_SEL_CTRL_1                        0x007c
+#define RT5682S_TDM_TCON_CTRL_1                        0x007e
+#define RT5682S_TDM_TCON_CTRL_2                        0x007f
+/* Function - Analog */
+#define RT5682S_GLB_CLK                                0x0080
+#define RT5682S_PLL_TRACK_1                    0x0083
+#define RT5682S_PLL_TRACK_2                    0x0084
+#define RT5682S_PLL_TRACK_3                    0x0085
+#define RT5682S_PLL_TRACK_4                    0x0086
+#define RT5682S_PLL_TRACK_5                    0x0087
+#define RT5682S_PLL_TRACK_6                    0x0088
+#define RT5682S_PLL_TRACK_11                   0x008c
+#define RT5682S_DEPOP_1                                0x008e
+#define RT5682S_HP_CHARGE_PUMP_1               0x008f
+#define RT5682S_HP_CHARGE_PUMP_2               0x0091
+#define RT5682S_HP_CHARGE_PUMP_3               0x0092
+#define RT5682S_MICBIAS_1                      0x0093
+#define RT5682S_MICBIAS_2                      0x0094
+#define RT5682S_MICBIAS_3                      0x0095
+
+#define RT5682S_PLL_TRACK_12                   0x0096
+#define RT5682S_PLL_TRACK_14                   0x0097
+#define RT5682S_PLL_CTRL_1                     0x0098
+#define RT5682S_PLL_CTRL_2                     0x0099
+#define RT5682S_PLL_CTRL_3                     0x009a
+#define RT5682S_PLL_CTRL_4                     0x009b
+#define RT5682S_PLL_CTRL_5                     0x009c
+#define RT5682S_PLL_CTRL_6                     0x009d
+#define RT5682S_PLL_CTRL_7                     0x009e
+
+#define RT5682S_RC_CLK_CTRL                    0x009f
+#define RT5682S_I2S2_M_CLK_CTRL_1              0x00a0
+#define RT5682S_I2S2_F_DIV_CTRL_1              0x00a3
+#define RT5682S_I2S2_F_DIV_CTRL_2              0x00a4
+
+#define RT5682S_IRQ_CTRL_1                     0x00b6
+#define RT5682S_IRQ_CTRL_2                     0x00b7
+#define RT5682S_IRQ_CTRL_3                     0x00b8
+#define RT5682S_IRQ_CTRL_4                     0x00b9
+#define RT5682S_INT_ST_1                       0x00be
+#define RT5682S_GPIO_CTRL_1                    0x00c0
+#define RT5682S_GPIO_CTRL_2                    0x00c1
+#define RT5682S_GPIO_ST                                0x00c2
+#define RT5682S_HP_AMP_DET_CTRL_1              0x00d0
+#define RT5682S_MID_HP_AMP_DET                 0x00d2
+#define RT5682S_LOW_HP_AMP_DET                 0x00d3
+#define RT5682S_DELAY_BUF_CTRL                 0x00d4
+#define RT5682S_SV_ZCD_1                       0x00d9
+#define RT5682S_SV_ZCD_2                       0x00da
+#define RT5682S_IL_CMD_1                       0x00db
+#define RT5682S_IL_CMD_2                       0x00dc
+#define RT5682S_IL_CMD_3                       0x00dd
+#define RT5682S_IL_CMD_4                       0x00de
+#define RT5682S_IL_CMD_5                       0x00df
+#define RT5682S_IL_CMD_6                       0x00e0
+#define RT5682S_4BTN_IL_CMD_1                  0x00e2
+#define RT5682S_4BTN_IL_CMD_2                  0x00e3
+#define RT5682S_4BTN_IL_CMD_3                  0x00e4
+#define RT5682S_4BTN_IL_CMD_4                  0x00e5
+#define RT5682S_4BTN_IL_CMD_5                  0x00e6
+#define RT5682S_4BTN_IL_CMD_6                  0x00e7
+#define RT5682S_4BTN_IL_CMD_7                  0x00e8
+
+#define RT5682S_ADC_STO1_HP_CTRL_1             0x00ea
+#define RT5682S_ADC_STO1_HP_CTRL_2             0x00eb
+#define RT5682S_AJD1_CTRL                      0x00f0
+#define RT5682S_JD_CTRL_1                      0x00f6
+/* General Control */
+#define RT5682S_DUMMY_1                                0x00fa
+#define RT5682S_DUMMY_2                                0x00fb
+#define RT5682S_DUMMY_3                                0x00fc
+
+#define RT5682S_DAC_ADC_DIG_VOL1               0x0100
+#define RT5682S_BIAS_CUR_CTRL_2                        0x010b
+#define RT5682S_BIAS_CUR_CTRL_3                        0x010c
+#define RT5682S_BIAS_CUR_CTRL_4                        0x010d
+#define RT5682S_BIAS_CUR_CTRL_5                        0x010e
+#define RT5682S_BIAS_CUR_CTRL_6                        0x010f
+#define RT5682S_BIAS_CUR_CTRL_7                        0x0110
+#define RT5682S_BIAS_CUR_CTRL_8                        0x0111
+#define RT5682S_BIAS_CUR_CTRL_9                        0x0112
+#define RT5682S_BIAS_CUR_CTRL_10               0x0113
+#define RT5682S_VREF_REC_OP_FB_CAP_CTRL_1      0x0117
+#define RT5682S_VREF_REC_OP_FB_CAP_CTRL_2      0x0118
+#define RT5682S_CHARGE_PUMP_1                  0x0125
+#define RT5682S_DIG_IN_CTRL_1                  0x0132
+#define RT5682S_PAD_DRIVING_CTRL               0x0136
+#define RT5682S_CHOP_DAC_1                     0x0139
+#define RT5682S_CHOP_DAC_2                     0x013a
+#define RT5682S_CHOP_ADC                       0x013b
+#define RT5682S_CALIB_ADC_CTRL                 0x013c
+#define RT5682S_VOL_TEST                       0x013f
+#define RT5682S_SPKVDD_DET_ST                  0x0142
+#define RT5682S_TEST_MODE_CTRL_1               0x0145
+#define RT5682S_TEST_MODE_CTRL_2               0x0146
+#define RT5682S_TEST_MODE_CTRL_3               0x0147
+#define RT5682S_TEST_MODE_CTRL_4               0x0148
+#define RT5682S_PLL_INTERNAL_1                 0x0156
+#define RT5682S_PLL_INTERNAL_2                 0x0157
+#define RT5682S_PLL_INTERNAL_3                 0x0158
+#define RT5682S_PLL_INTERNAL_4                 0x0159
+#define RT5682S_STO_NG2_CTRL_1                 0x0160
+#define RT5682S_STO_NG2_CTRL_2                 0x0161
+#define RT5682S_STO_NG2_CTRL_3                 0x0162
+#define RT5682S_STO_NG2_CTRL_4                 0x0163
+#define RT5682S_STO_NG2_CTRL_5                 0x0164
+#define RT5682S_STO_NG2_CTRL_6                 0x0165
+#define RT5682S_STO_NG2_CTRL_7                 0x0166
+#define RT5682S_STO_NG2_CTRL_8                 0x0167
+#define RT5682S_STO_NG2_CTRL_9                 0x0168
+#define RT5682S_STO_NG2_CTRL_10                        0x0169
+#define RT5682S_STO1_DAC_SIL_DET               0x0190
+#define RT5682S_SIL_PSV_CTRL1                  0x0194
+#define RT5682S_SIL_PSV_CTRL2                  0x0195
+#define RT5682S_SIL_PSV_CTRL3                  0x0197
+#define RT5682S_SIL_PSV_CTRL4                  0x0198
+#define RT5682S_SIL_PSV_CTRL5                  0x0199
+#define RT5682S_HP_IMP_SENS_CTRL_1             0x01ac
+#define RT5682S_HP_IMP_SENS_CTRL_2             0x01ad
+#define RT5682S_HP_IMP_SENS_CTRL_3             0x01ae
+#define RT5682S_HP_IMP_SENS_CTRL_4             0x01af
+#define RT5682S_HP_IMP_SENS_CTRL_5             0x01b0
+#define RT5682S_HP_IMP_SENS_CTRL_6             0x01b1
+#define RT5682S_HP_IMP_SENS_CTRL_7             0x01b2
+#define RT5682S_HP_IMP_SENS_CTRL_8             0x01b3
+#define RT5682S_HP_IMP_SENS_CTRL_9             0x01b4
+#define RT5682S_HP_IMP_SENS_CTRL_10            0x01b5
+#define RT5682S_HP_IMP_SENS_CTRL_11            0x01b6
+#define RT5682S_HP_IMP_SENS_CTRL_12            0x01b7
+#define RT5682S_HP_IMP_SENS_CTRL_13            0x01b8
+#define RT5682S_HP_IMP_SENS_CTRL_14            0x01b9
+#define RT5682S_HP_IMP_SENS_CTRL_15            0x01ba
+#define RT5682S_HP_IMP_SENS_CTRL_16            0x01bb
+#define RT5682S_HP_IMP_SENS_CTRL_17            0x01bc
+#define RT5682S_HP_IMP_SENS_CTRL_18            0x01bd
+#define RT5682S_HP_IMP_SENS_CTRL_19            0x01be
+#define RT5682S_HP_IMP_SENS_CTRL_20            0x01bf
+#define RT5682S_HP_IMP_SENS_CTRL_21            0x01c0
+#define RT5682S_HP_IMP_SENS_CTRL_22            0x01c1
+#define RT5682S_HP_IMP_SENS_CTRL_23            0x01c2
+#define RT5682S_HP_IMP_SENS_CTRL_24            0x01c3
+#define RT5682S_HP_IMP_SENS_CTRL_25            0x01c4
+#define RT5682S_HP_IMP_SENS_CTRL_26            0x01c5
+#define RT5682S_HP_IMP_SENS_CTRL_27            0x01c6
+#define RT5682S_HP_IMP_SENS_CTRL_28            0x01c7
+#define RT5682S_HP_IMP_SENS_CTRL_29            0x01c8
+#define RT5682S_HP_IMP_SENS_CTRL_30            0x01c9
+#define RT5682S_HP_IMP_SENS_CTRL_31            0x01ca
+#define RT5682S_HP_IMP_SENS_CTRL_32            0x01cb
+#define RT5682S_HP_IMP_SENS_CTRL_33            0x01cc
+#define RT5682S_HP_IMP_SENS_CTRL_34            0x01cd
+#define RT5682S_HP_IMP_SENS_CTRL_35            0x01ce
+#define RT5682S_HP_IMP_SENS_CTRL_36            0x01cf
+#define RT5682S_HP_IMP_SENS_CTRL_37            0x01d0
+#define RT5682S_HP_IMP_SENS_CTRL_38            0x01d1
+#define RT5682S_HP_IMP_SENS_CTRL_39            0x01d2
+#define RT5682S_HP_IMP_SENS_CTRL_40            0x01d3
+#define RT5682S_HP_IMP_SENS_CTRL_41            0x01d4
+#define RT5682S_HP_IMP_SENS_CTRL_42            0x01d5
+#define RT5682S_HP_IMP_SENS_CTRL_43            0x01d6
+#define RT5682S_HP_IMP_SENS_CTRL_44            0x01d7
+#define RT5682S_HP_IMP_SENS_CTRL_45            0x01d8
+#define RT5682S_HP_IMP_SENS_CTRL_46            0x01d9
+#define RT5682S_HP_LOGIC_CTRL_1                        0x01da
+#define RT5682S_HP_LOGIC_CTRL_2                        0x01db
+#define RT5682S_HP_LOGIC_CTRL_3                        0x01dc
+#define RT5682S_HP_CALIB_CTRL_1                        0x01de
+#define RT5682S_HP_CALIB_CTRL_2                        0x01df
+#define RT5682S_HP_CALIB_CTRL_3                        0x01e0
+#define RT5682S_HP_CALIB_CTRL_4                        0x01e1
+#define RT5682S_HP_CALIB_CTRL_5                        0x01e2
+#define RT5682S_HP_CALIB_CTRL_6                        0x01e3
+#define RT5682S_HP_CALIB_CTRL_7                        0x01e4
+#define RT5682S_HP_CALIB_CTRL_8                        0x01e5
+#define RT5682S_HP_CALIB_CTRL_9                        0x01e6
+#define RT5682S_HP_CALIB_CTRL_10               0x01e7
+#define RT5682S_HP_CALIB_CTRL_11               0x01e8
+#define RT5682S_HP_CALIB_ST_1                  0x01ea
+#define RT5682S_HP_CALIB_ST_2                  0x01eb
+#define RT5682S_HP_CALIB_ST_3                  0x01ec
+#define RT5682S_HP_CALIB_ST_4                  0x01ed
+#define RT5682S_HP_CALIB_ST_5                  0x01ee
+#define RT5682S_HP_CALIB_ST_6                  0x01ef
+#define RT5682S_HP_CALIB_ST_7                  0x01f0
+#define RT5682S_HP_CALIB_ST_8                  0x01f1
+#define RT5682S_HP_CALIB_ST_9                  0x01f2
+#define RT5682S_HP_CALIB_ST_10                 0x01f3
+#define RT5682S_HP_CALIB_ST_11                 0x01f4
+#define RT5682S_SAR_IL_CMD_1                   0x0210
+#define RT5682S_SAR_IL_CMD_2                   0x0211
+#define RT5682S_SAR_IL_CMD_3                   0x0212
+#define RT5682S_SAR_IL_CMD_4                   0x0213
+#define RT5682S_SAR_IL_CMD_5                   0x0214
+#define RT5682S_SAR_IL_CMD_6                   0x0215
+#define RT5682S_SAR_IL_CMD_7                   0x0216
+#define RT5682S_SAR_IL_CMD_8                   0x0217
+#define RT5682S_SAR_IL_CMD_9                   0x0218
+#define RT5682S_SAR_IL_CMD_10                  0x0219
+#define RT5682S_SAR_IL_CMD_11                  0x021a
+#define RT5682S_SAR_IL_CMD_12                  0x021b
+#define RT5682S_SAR_IL_CMD_13                  0x021c
+#define RT5682S_SAR_IL_CMD_14                  0x021d
+#define RT5682S_DUMMY_4                                0x02fa
+#define RT5682S_DUMMY_5                                0x02fb
+#define RT5682S_DUMMY_6                                0x02fc
+#define RT5682S_VERSION_ID_HIDE                        0x03fe
+#define RT5682S_VERSION_ID_CUS                 0x03ff
+#define RT5682S_SCAN_CTL                       0x0500
+#define RT5682S_HP_AMP_DET                     0x0600
+#define RT5682S_BIAS_CUR_CTRL_11               0x0610
+#define RT5682S_BIAS_CUR_CTRL_12               0x0611
+#define RT5682S_BIAS_CUR_CTRL_13               0x0620
+#define RT5682S_BIAS_CUR_CTRL_14               0x0621
+#define RT5682S_BIAS_CUR_CTRL_15               0x0630
+#define RT5682S_BIAS_CUR_CTRL_16               0x0631
+#define RT5682S_BIAS_CUR_CTRL_17               0x0640
+#define RT5682S_BIAS_CUR_CTRL_18               0x0641
+#define RT5682S_I2C_TRANS_CTRL                 0x07fa
+#define RT5682S_DUMMY_7                                0x08fa
+#define RT5682S_DUMMY_8                                0x08fb
+#define RT5682S_DMIC_FLOAT_DET                 0x0d00
+#define RT5682S_HA_CMP_OP_1                    0x1100
+#define RT5682S_HA_CMP_OP_2                    0x1101
+#define RT5682S_HA_CMP_OP_3                    0x1102
+#define RT5682S_HA_CMP_OP_4                    0x1103
+#define RT5682S_HA_CMP_OP_5                    0x1104
+#define RT5682S_HA_CMP_OP_6                    0x1105
+#define RT5682S_HA_CMP_OP_7                    0x1106
+#define RT5682S_HA_CMP_OP_8                    0x1107
+#define RT5682S_HA_CMP_OP_9                    0x1108
+#define RT5682S_HA_CMP_OP_10                   0x1109
+#define RT5682S_HA_CMP_OP_11                   0x110a
+#define RT5682S_HA_CMP_OP_12                   0x110b
+#define RT5682S_HA_CMP_OP_13                   0x110c
+#define RT5682S_HA_CMP_OP_14                   0x1111
+#define RT5682S_HA_CMP_OP_15                   0x1112
+#define RT5682S_HA_CMP_OP_16                   0x1113
+#define RT5682S_HA_CMP_OP_17                   0x1114
+#define RT5682S_HA_CMP_OP_18                   0x1115
+#define RT5682S_HA_CMP_OP_19                   0x1116
+#define RT5682S_HA_CMP_OP_20                   0x1117
+#define RT5682S_HA_CMP_OP_21                   0x1118
+#define RT5682S_HA_CMP_OP_22                   0x1119
+#define RT5682S_HA_CMP_OP_23                   0x111a
+#define RT5682S_HA_CMP_OP_24                   0x111b
+#define RT5682S_HA_CMP_OP_25                   0x111c
+#define RT5682S_NEW_CBJ_DET_CTL_1              0x1401
+#define RT5682S_NEW_CBJ_DET_CTL_2              0x1402
+#define RT5682S_NEW_CBJ_DET_CTL_3              0x1403
+#define RT5682S_NEW_CBJ_DET_CTL_4              0x1404
+#define RT5682S_NEW_CBJ_DET_CTL_5              0x1406
+#define RT5682S_NEW_CBJ_DET_CTL_6              0x1407
+#define RT5682S_NEW_CBJ_DET_CTL_7              0x1408
+#define RT5682S_NEW_CBJ_DET_CTL_8              0x1409
+#define RT5682S_NEW_CBJ_DET_CTL_9              0x140a
+#define RT5682S_NEW_CBJ_DET_CTL_10             0x140b
+#define RT5682S_NEW_CBJ_DET_CTL_11             0x140c
+#define RT5682S_NEW_CBJ_DET_CTL_12             0x140d
+#define RT5682S_NEW_CBJ_DET_CTL_13             0x140e
+#define RT5682S_NEW_CBJ_DET_CTL_14             0x140f
+#define RT5682S_NEW_CBJ_DET_CTL_15             0x1410
+#define RT5682S_NEW_CBJ_DET_CTL_16             0x1411
+#define RT5682S_DA_FILTER_1                    0x1801
+#define RT5682S_DA_FILTER_2                    0x1802
+#define RT5682S_DA_FILTER_3                    0x1803
+#define RT5682S_DA_FILTER_4                    0x1804
+#define RT5682S_DA_FILTER_5                    0x1805
+#define RT5682S_CLK_SW_TEST_1                  0x2c00
+#define RT5682S_CLK_SW_TEST_2                  0x3400
+#define RT5682S_CLK_SW_TEST_3                  0x3404
+#define RT5682S_CLK_SW_TEST_4                  0x3405
+#define RT5682S_CLK_SW_TEST_5                  0x3406
+#define RT5682S_CLK_SW_TEST_6                  0x3407
+#define RT5682S_CLK_SW_TEST_7                  0x3408
+#define RT5682S_CLK_SW_TEST_8                  0x3409
+#define RT5682S_CLK_SW_TEST_9                  0x340a
+#define RT5682S_CLK_SW_TEST_10                 0x340b
+#define RT5682S_CLK_SW_TEST_11                 0x340c
+#define RT5682S_CLK_SW_TEST_12                 0x340d
+#define RT5682S_CLK_SW_TEST_13                 0x340e
+#define RT5682S_CLK_SW_TEST_14                 0x340f
+#define RT5682S_EFUSE_MANU_WRITE_1             0x3410
+#define RT5682S_EFUSE_MANU_WRITE_2             0x3411
+#define RT5682S_EFUSE_MANU_WRITE_3             0x3412
+#define RT5682S_EFUSE_MANU_WRITE_4             0x3413
+#define RT5682S_EFUSE_MANU_WRITE_5             0x3414
+#define RT5682S_EFUSE_MANU_WRITE_6             0x3415
+#define RT5682S_EFUSE_READ_1                   0x3424
+#define RT5682S_EFUSE_READ_2                   0x3425
+#define RT5682S_EFUSE_READ_3                   0x3426
+#define RT5682S_EFUSE_READ_4                   0x3427
+#define RT5682S_EFUSE_READ_5                   0x3428
+#define RT5682S_EFUSE_READ_6                   0x3429
+#define RT5682S_EFUSE_READ_7                   0x342a
+#define RT5682S_EFUSE_READ_8                   0x342b
+#define RT5682S_EFUSE_READ_9                   0x342c
+#define RT5682S_EFUSE_READ_10                  0x342d
+#define RT5682S_EFUSE_READ_11                  0x342e
+#define RT5682S_EFUSE_READ_12                  0x342f
+#define RT5682S_EFUSE_READ_13                  0x3430
+#define RT5682S_EFUSE_READ_14                  0x3431
+#define RT5682S_EFUSE_READ_15                  0x3432
+#define RT5682S_EFUSE_READ_16                  0x3433
+#define RT5682S_EFUSE_READ_17                  0x3434
+#define RT5682S_EFUSE_READ_18                  0x3435
+#define RT5682S_EFUSE_TIMING_CTL_1             0x3440
+#define RT5682S_EFUSE_TIMING_CTL_2             0x3441
+#define RT5682S_PILOT_DIG_CTL_1                        0x3500
+#define RT5682S_PILOT_DIG_CTL_2                        0x3501
+#define RT5682S_HP_AMP_DET_CTL_1               0x3b00
+#define RT5682S_HP_AMP_DET_CTL_2               0x3b01
+#define RT5682S_HP_AMP_DET_CTL_3               0x3b02
+#define RT5682S_HP_AMP_DET_CTL_4               0x3b03
+
+#define RT5682S_MAX_REG                                (RT5682S_HP_AMP_DET_CTL_4)
+
+/* global definition */
+#define RT5682S_L_MUTE                         (0x1 << 15)
+#define RT5682S_L_MUTE_SFT                     15
+#define RT5682S_R_MUTE                         (0x1 << 7)
+#define RT5682S_R_MUTE_SFT                     7
+#define RT5682S_L_VOL_SFT                      8
+#define RT5682S_R_VOL_SFT                      0
+#define RT5682S_CLK_SRC_MCLK                   (0x0)
+#define RT5682S_CLK_SRC_PLL1                   (0x1)
+#define RT5682S_CLK_SRC_PLL2                   (0x2)
+#define RT5682S_CLK_SRC_RCCLK                  (0x4) /* 25M */
+
+
+/* Headphone Amp Control 2 (0x0003) */
+#define RT5682S_HPO_L_PATH_MASK                        (0x1 << 14)
+#define RT5682S_HPO_L_PATH_EN                  (0x1 << 14)
+#define RT5682S_HPO_L_PATH_DIS                 (0x0 << 14)
+#define RT5682S_HPO_R_PATH_MASK                        (0x1 << 13)
+#define RT5682S_HPO_R_PATH_EN                  (0x1 << 13)
+#define RT5682S_HPO_R_PATH_DIS                 (0x0 << 13)
+#define RT5682S_HPO_SEL_IP_EN_SW               (0x1)
+#define RT5682S_HPO_IP_EN_GATING               (0x1)
+#define RT5682S_HPO_IP_NO_GATING               (0x0)
+
+/*Headphone Amp L/R Analog Gain and Digital NG2 Gain Control (0x0005 0x0006)*/
+#define RT5682S_G_HP                           (0xf << 8)
+#define RT5682S_G_HP_SFT                       8
+#define RT5682S_G_STO_DA_DMIX                  (0xf)
+#define RT5682S_G_STO_DA_SFT                   0
+
+/* Embeeded Jack and Type Detection Control 2 (0x0010) */
+#define RT5682S_EMB_JD_MASK                    (0x1 << 15)
+#define RT5682S_EMB_JD_EN                      (0x1 << 15)
+#define RT5682S_EMB_JD_EN_SFT                  15
+#define RT5682S_EMB_JD_RST                     (0x1 << 14)
+#define RT5682S_JD_MODE                                (0x1 << 13)
+#define RT5682S_JD_MODE_SFT                    13
+#define RT5682S_DET_TYPE                       (0x1 << 12)
+#define RT5682S_DET_TYPE_SFT                   12
+#define RT5682S_POLA_EXT_JD_MASK               (0x1 << 11)
+#define RT5682S_POLA_EXT_JD_LOW                        (0x1 << 11)
+#define RT5682S_POLA_EXT_JD_HIGH               (0x0 << 11)
+#define RT5682S_SEL_FAST_OFF_MASK              (0x3 << 9)
+#define RT5682S_SEL_FAST_OFF_SFT               9
+#define RT5682S_POL_FAST_OFF_MASK              (0x1 << 8)
+#define RT5682S_POL_FAST_OFF_HIGH              (0x1 << 8)
+#define RT5682S_POL_FAST_OFF_LOW               (0x0 << 8)
+#define RT5682S_FAST_OFF_MASK                  (0x1 << 7)
+#define RT5682S_FAST_OFF_EN                    (0x1 << 7)
+#define RT5682S_FAST_OFF_DIS                   (0x0 << 7)
+#define RT5682S_VREF_POW_MASK                  (0x1 << 6)
+#define RT5682S_VREF_POW_FSM                   (0x0 << 6)
+#define RT5682S_VREF_POW_REG                   (0x1 << 6)
+#define RT5682S_MB1_PATH_BIT                   5
+#define RT5682S_MB1_PATH_MASK                  (0x1 << 5)
+#define RT5682S_CTRL_MB1_REG                   (0x1 << 5)
+#define RT5682S_CTRL_MB1_FSM                   (0x0 << 5)
+#define RT5682S_MB2_PATH_BIT                   4
+#define RT5682S_MB2_PATH_MASK                  (0x1 << 4)
+#define RT5682S_CTRL_MB2_REG                   (0x1 << 4)
+#define RT5682S_CTRL_MB2_FSM                   (0x0 << 4)
+#define RT5682S_TRIG_JD_MASK                   (0x1 << 3)
+#define RT5682S_TRIG_JD_HIGH                   (0x1 << 3)
+#define RT5682S_TRIG_JD_LOW                    (0x0 << 3)
+#define RT5682S_MIC_CAP_MASK                   (0x1 << 1)
+#define RT5682S_MIC_CAP_HS                     (0x1 << 1)
+#define RT5682S_MIC_CAP_HP                     (0x0 << 1)
+#define RT5682S_MIC_CAP_SRC_MASK               (0x1)
+#define RT5682S_MIC_CAP_SRC_REG                        (0x1)
+#define RT5682S_MIC_CAP_SRC_ANA                        (0x0)
+
+/* Embeeded Jack and Type Detection Control 3 (0x0011) */
+#define RT5682S_SEL_CBJ_TYPE_SLOW              (0x1 << 15)
+#define RT5682S_SEL_CBJ_TYPE_NORM              (0x0 << 15)
+#define RT5682S_SEL_CBJ_TYPE_MASK              (0x1 << 15)
+#define RT5682S_POW_BG_MB1_MASK                        (0x1 << 13)
+#define RT5682S_POW_BG_MB1_REG                 (0x1 << 13)
+#define RT5682S_POW_BG_MB1_FSM                 (0x0 << 13)
+#define RT5682S_POW_BG_MB2_MASK                        (0x1 << 12)
+#define RT5682S_POW_BG_MB2_REG                 (0x1 << 12)
+#define RT5682S_POW_BG_MB2_FSM                 (0x0 << 12)
+#define RT5682S_EXT_JD_SRC                     (0x7 << 4)
+#define RT5682S_EXT_JD_SRC_SFT                 4
+#define RT5682S_EXT_JD_SRC_GPIO_JD1            (0x0 << 4)
+#define RT5682S_EXT_JD_SRC_GPIO_JD2            (0x1 << 4)
+#define RT5682S_EXT_JD_SRC_JDH                 (0x2 << 4)
+#define RT5682S_EXT_JD_SRC_JDL                 (0x3 << 4)
+#define RT5682S_EXT_JD_SRC_MANUAL              (0x4 << 4)
+#define RT5682S_JACK_TYPE_MASK                 (0x3)
+
+/* Combo Jack and Type Detection Control 4 (0x0012) */
+#define RT5682S_CBJ_IN_BUF_MASK                        (0x1 << 7)
+#define RT5682S_CBJ_IN_BUF_EN                  (0x1 << 7)
+#define RT5682S_CBJ_IN_BUF_DIS                 (0x0 << 7)
+#define RT5682S_CBJ_IN_BUF_BIT                 7
+
+/* Combo Jack and Type Detection Control 5 (0x0013) */
+#define RT5682S_SEL_SHT_MID_TON_MASK           (0x3 << 12)
+#define RT5682S_SEL_SHT_MID_TON_2              (0x0 << 12)
+#define RT5682S_SEL_SHT_MID_TON_3              (0x1 << 12)
+#define RT5682S_CBJ_JD_TEST_MASK               (0x1 << 6)
+#define RT5682S_CBJ_JD_TEST_NORM               (0x0 << 6)
+#define RT5682S_CBJ_JD_TEST_MODE               (0x1 << 6)
+
+/* Combo Jack and Type Detection Control 6 (0x0014) */
+#define RT5682S_JD_FAST_OFF_SRC_MASK           (0x7 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_JDH            (0x6 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO6          (0x5 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO5          (0x4 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO4          (0x3 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO3          (0x2 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO2          (0x1 << 8)
+#define RT5682S_JD_FAST_OFF_SRC_GPIO1          (0x0 << 8)
+
+/* DAC1 Digital Volume (0x0019) */
+#define RT5682S_DAC_L1_VOL_MASK                        (0xff << 8)
+#define RT5682S_DAC_L1_VOL_SFT                 8
+#define RT5682S_DAC_R1_VOL_MASK                        (0xff)
+#define RT5682S_DAC_R1_VOL_SFT                 0
+
+/* ADC Digital Volume Control (0x001c) */
+#define RT5682S_ADC_L_VOL_MASK                 (0x7f << 8)
+#define RT5682S_ADC_L_VOL_SFT                  8
+#define RT5682S_ADC_R_VOL_MASK                 (0x7f)
+#define RT5682S_ADC_R_VOL_SFT                  0
+
+/* Stereo1 ADC Boost Gain Control (0x001f) */
+#define RT5682S_STO1_ADC_L_BST_MASK            (0x3 << 14)
+#define RT5682S_STO1_ADC_L_BST_SFT             14
+#define RT5682S_STO1_ADC_R_BST_MASK            (0x3 << 12)
+#define RT5682S_STO1_ADC_R_BST_SFT             12
+
+/* Sidetone Control (0x0024) */
+#define RT5682S_ST_SRC_SEL                     (0x1 << 8)
+#define RT5682S_ST_SRC_SFT                     8
+#define RT5682S_ST_EN_MASK                     (0x1 << 6)
+#define RT5682S_ST_DIS                         (0x0 << 6)
+#define RT5682S_ST_EN                          (0x1 << 6)
+#define RT5682S_ST_EN_SFT                      6
+
+/* Stereo1 ADC Mixer Control (0x0026) */
+#define RT5682S_M_STO1_ADC_L1                  (0x1 << 15)
+#define RT5682S_M_STO1_ADC_L1_SFT              15
+#define RT5682S_M_STO1_ADC_L2                  (0x1 << 14)
+#define RT5682S_M_STO1_ADC_L2_SFT              14
+#define RT5682S_STO1_ADC1L_SRC_MASK            (0x1 << 13)
+#define RT5682S_STO1_ADC1L_SRC_SFT             13
+#define RT5682S_STO1_ADC1_SRC_ADC              (0x1 << 13)
+#define RT5682S_STO1_ADC1_SRC_DACMIX           (0x0 << 13)
+#define RT5682S_STO1_ADC2L_SRC_MASK            (0x1 << 12)
+#define RT5682S_STO1_ADC2L_SRC_SFT             12
+#define RT5682S_STO1_ADCL_SRC_MASK             (0x3 << 10)
+#define RT5682S_STO1_ADCL_SRC_SFT              10
+#define RT5682S_M_STO1_ADC_R1                  (0x1 << 7)
+#define RT5682S_M_STO1_ADC_R1_SFT              7
+#define RT5682S_M_STO1_ADC_R2                  (0x1 << 6)
+#define RT5682S_M_STO1_ADC_R2_SFT              6
+#define RT5682S_STO1_ADC1R_SRC_MASK            (0x1 << 5)
+#define RT5682S_STO1_ADC1R_SRC_SFT             5
+#define RT5682S_STO1_ADC2R_SRC_MASK            (0x1 << 4)
+#define RT5682S_STO1_ADC2R_SRC_SFT             4
+#define RT5682S_STO1_ADCR_SRC_MASK             (0x3 << 2)
+#define RT5682S_STO1_ADCR_SRC_SFT              2
+
+/* ADC Mixer to DAC Mixer Control (0x0029) */
+#define RT5682S_M_ADCMIX_L                     (0x1 << 15)
+#define RT5682S_M_ADCMIX_L_SFT                 15
+#define RT5682S_M_DAC1_L                       (0x1 << 14)
+#define RT5682S_M_DAC1_L_SFT                   14
+#define RT5682S_M_ADCMIX_R                     (0x1 << 7)
+#define RT5682S_M_ADCMIX_R_SFT                 7
+#define RT5682S_M_DAC1_R                       (0x1 << 6)
+#define RT5682S_M_DAC1_R_SFT                   6
+
+/* Stereo1 DAC Mixer Control (0x002a) */
+#define RT5682S_M_DAC_L1_STO_L                 (0x1 << 15)
+#define RT5682S_M_DAC_L1_STO_L_SFT             15
+#define RT5682S_G_DAC_L1_STO_L_MASK            (0x1 << 14)
+#define RT5682S_G_DAC_L1_STO_L_SFT             14
+#define RT5682S_M_DAC_R1_STO_L                 (0x1 << 13)
+#define RT5682S_M_DAC_R1_STO_L_SFT             13
+#define RT5682S_G_DAC_R1_STO_L_MASK            (0x1 << 12)
+#define RT5682S_G_DAC_R1_STO_L_SFT             12
+#define RT5682S_M_DAC_L1_STO_R                 (0x1 << 7)
+#define RT5682S_M_DAC_L1_STO_R_SFT             7
+#define RT5682S_G_DAC_L1_STO_R_MASK            (0x1 << 6)
+#define RT5682S_G_DAC_L1_STO_R_SFT             6
+#define RT5682S_M_DAC_R1_STO_R                 (0x1 << 5)
+#define RT5682S_M_DAC_R1_STO_R_SFT             5
+#define RT5682S_G_DAC_R1_STO_R_MASK            (0x1 << 4)
+#define RT5682S_G_DAC_R1_STO_R_SFT             4
+
+/* Analog DAC1 Input Source Control (0x002b) */
+#define RT5682S_M_ST_STO_L                     (0x1 << 9)
+#define RT5682S_M_ST_STO_L_SFT                 9
+#define RT5682S_M_ST_STO_R                     (0x1 << 8)
+#define RT5682S_M_ST_STO_R_SFT                 8
+#define RT5682S_DAC_L1_SRC_MASK                        (0x1 << 4)
+#define RT5682S_A_DACL1_SFT                    4
+#define RT5682S_DAC_R1_SRC_MASK                        (0x1)
+#define RT5682S_A_DACR1_SFT                    0
+
+/* Digital Interface Data Control (0x0030) */
+#define RT5682S_IF2_DAC_SEL_MASK               (0x3 << 2)
+#define RT5682S_IF2_DAC_SEL_SFT                        2
+#define RT5682S_IF2_ADC_SEL_MASK               (0x3 << 0)
+#define RT5682S_IF2_ADC_SEL_SFT                        0
+
+/* REC Left/Right Mixer Control 2 (0x003c) */
+#define RT5682S_BST_CBJ_MASK                   (0x3f << 8)
+#define RT5682S_BST_CBJ_SFT                    8
+#define RT5682S_M_CBJ_RM1_L                    (0x1 << 7)
+#define RT5682S_M_CBJ_RM1_L_SFT                        7
+#define RT5682S_M_CBJ_RM1_R                    (0x1 << 6)
+#define RT5682S_M_CBJ_RM1_R_SFT                        6
+
+/* REC Left/Right Mixer Calibration Control(0x0044) */
+#define RT5682S_PWR_RM1_R_BIT                  8
+#define RT5682S_PWR_RM1_L_BIT                  0
+
+/* Power Management for Digital 1 (0x0061) */
+#define RT5682S_PWR_I2S1                       (0x1 << 15)
+#define RT5682S_PWR_I2S1_BIT                   15
+#define RT5682S_PWR_I2S2                       (0x1 << 14)
+#define RT5682S_PWR_I2S2_BIT                   14
+#define RT5682S_PRE_CHR_DAC_L1                 (0x1 << 13)
+#define RT5682S_PRE_CHR_DAC_L1_BIT             13
+#define RT5682S_PRE_CHR_DAC_R1                 (0x1 << 12)
+#define RT5682S_PRE_CHR_DAC_R1_BIT             12
+#define RT5682S_PWR_DAC_L1                     (0x1 << 11)
+#define RT5682S_PWR_DAC_L1_BIT                 11
+#define RT5682S_PWR_DAC_R1                     (0x1 << 10)
+#define RT5682S_PWR_DAC_R1_BIT                 10
+#define RT5682S_PWR_LDO                                (0x1 << 8)
+#define RT5682S_PWR_LDO_BIT                    8
+#define RT5682S_PWR_D2S_L                      (0x1 << 7)
+#define RT5682S_PWR_D2S_L_BIT                  7
+#define RT5682S_PWR_D2S_R                      (0x1 << 6)
+#define RT5682S_PWR_D2S_R_BIT                  6
+#define RT5682S_PWR_ADC_L1                     (0x1 << 4)
+#define RT5682S_PWR_ADC_L1_BIT                 4
+#define RT5682S_PWR_ADC_R1                     (0x1 << 3)
+#define RT5682S_PWR_ADC_R1_BIT                 3
+#define RT5682S_EFUSE_SW_EN                    (0x1 << 2)
+#define RT5682S_EFUSE_SW_DIS                   (0x0 << 2)
+#define RT5682S_PWR_EFUSE                      (0x1 << 1)
+#define RT5682S_PWR_EFUSE_BIT                  1
+#define RT5682S_DIG_GATE_CTRL                  (0x1 << 0)
+#define RT5682S_DIG_GATE_CTRL_SFT              0
+
+/* Power Management for Digital 2 (0x0062) */
+#define RT5682S_PWR_ADC_S1F                    (0x1 << 15)
+#define RT5682S_PWR_ADC_S1F_BIT                        15
+#define RT5682S_PWR_DAC_S1F                    (0x1 << 10)
+#define RT5682S_PWR_DAC_S1F_BIT                        10
+#define RT5682S_DLDO_I_LIMIT_MASK              (0x1 << 7)
+#define RT5682S_DLDO_I_LIMIT_EN                        (0x1 << 7)
+#define RT5682S_DLDO_I_LIMIT_DIS               (0x0 << 7)
+#define RT5682S_DLDO_I_BIAS_SEL_4              (0x1 << 6)
+#define RT5682S_DLDO_I_BIAS_SEL_0              (0x0 << 6)
+#define RT5682S_DLDO_REG_TEST_1                        (0x1 << 5)
+#define RT5682S_DLDO_REG_TEST_0                        (0x0 << 5)
+#define RT5682S_DLDO_SRC_REG                   (0x1 << 4)
+#define RT5682S_DLDO_SRC_EFUSE                 (0x0 << 4)
+
+/* Power Management for Analog 1 (0x0063) */
+#define RT5682S_PWR_VREF1                      (0x1 << 15)
+#define RT5682S_PWR_VREF1_BIT                  15
+#define RT5682S_PWR_FV1                                (0x1 << 14)
+#define RT5682S_PWR_FV1_BIT                    14
+#define RT5682S_PWR_VREF2                      (0x1 << 13)
+#define RT5682S_PWR_VREF2_BIT                  13
+#define RT5682S_PWR_FV2                                (0x1 << 12)
+#define RT5682S_PWR_FV2_BIT                    12
+#define RT5682S_LDO1_DBG_MASK                  (0x3 << 10)
+#define RT5682S_PWR_MB                         (0x1 << 9)
+#define RT5682S_PWR_MB_BIT                     9
+#define RT5682S_PWR_BG                         (0x1 << 7)
+#define RT5682S_PWR_BG_BIT                     7
+#define RT5682S_LDO1_BYPASS_MASK               (0x1 << 6)
+#define RT5682S_LDO1_BYPASS                    (0x1 << 6)
+#define RT5682S_LDO1_NOT_BYPASS                        (0x0 << 6)
+
+/* Power Management for Analog 2 (0x0064) */
+#define RT5682S_PWR_MCLK0_WD                   (0x1 << 15)
+#define RT5682S_PWR_MCLK0_WD_BIT               15
+#define RT5682S_PWR_MCLK1_WD                   (0x1 << 14)
+#define RT5682S_PWR_MCLK1_WD_BIT               14
+#define RT5682S_RST_MCLK0                      (0x1 << 13)
+#define RT5682S_RST_MCLK0_BIT                  13
+#define RT5682S_RST_MCLK1                      (0x1 << 12)
+#define RT5682S_RST_MCLK1_BIT                  12
+#define RT5682S_PWR_MB1                                (0x1 << 11)
+#define RT5682S_PWR_MB1_PWR_DOWN               (0x0 << 11)
+#define RT5682S_PWR_MB1_BIT                    11
+#define RT5682S_PWR_MB2                                (0x1 << 10)
+#define RT5682S_PWR_MB2_PWR_DOWN               (0x0 << 10)
+#define RT5682S_PWR_MB2_BIT                    10
+#define RT5682S_PWR_JD_MASK                    (0x1 << 0)
+#define RT5682S_PWR_JD_ENABLE                  (0x1 << 0)
+#define RT5682S_PWR_JD_DISABLE                 (0x0 << 0)
+
+/* Power Management for Analog 3 (0x0065) */
+#define RT5682S_PWR_LDO_PLLA                   (0x1 << 15)
+#define RT5682S_PWR_LDO_PLLA_BIT               15
+#define RT5682S_PWR_LDO_PLLB                   (0x1 << 14)
+#define RT5682S_PWR_LDO_PLLB_BIT               14
+#define RT5682S_PWR_BIAS_PLLA                  (0x1 << 13)
+#define RT5682S_PWR_BIAS_PLLA_BIT              13
+#define RT5682S_PWR_BIAS_PLLB                  (0x1 << 12)
+#define RT5682S_PWR_BIAS_PLLB_BIT              12
+#define RT5682S_PWR_CBJ                                (0x1 << 9)
+#define RT5682S_PWR_CBJ_BIT                    9
+#define RT5682S_RSTB_PLLB                      (0x1 << 7)
+#define RT5682S_RSTB_PLLB_BIT                  7
+#define RT5682S_RSTB_PLLA                      (0x1 << 6)
+#define RT5682S_RSTB_PLLA_BIT                  6
+#define RT5682S_PWR_PLLB                       (0x1 << 5)
+#define RT5682S_PWR_PLLB_BIT                   5
+#define RT5682S_PWR_PLLA                       (0x1 << 4)
+#define RT5682S_PWR_PLLA_BIT                   4
+#define RT5682S_PWR_LDO_MB2                    (0x1 << 2)
+#define RT5682S_PWR_LDO_MB2_BIT                        2
+#define RT5682S_PWR_LDO_MB1                    (0x1 << 1)
+#define RT5682S_PWR_LDO_MB1_BIT                        1
+#define RT5682S_PWR_BGLDO                      (0x1 << 0)
+#define RT5682S_PWR_BGLDO_BIT                  0
+
+/* Power Management for Mixer (0x0066) */
+#define RT5682S_PWR_CLK_COMP_8FS               (0x1 << 15)
+#define RT5682S_PWR_CLK_COMP_8FS_BIT           15
+#define RT5682S_DBG_BGLDO_MASK                 (0x3 << 12)
+#define RT5682S_DBG_BGLDO_SFT                  12
+#define RT5682S_DBG_BGLDO_MB1_MASK             (0x3 << 10)
+#define RT5682S_DBG_BGLDO_MB1_SFT              10
+#define RT5682S_DBG_BGLDO_MB2_MASK             (0x3 << 8)
+#define RT5682S_DBG_BGLDO_MB2_SFT              8
+#define RT5682S_DLDO_BGLDO_MASK                        (0x3 << 6)
+#define RT5682S_DLDO_BGLDO_MB2_SFT             6
+#define RT5682S_PWR_STO1_DAC_L                 (0x1 << 5)
+#define RT5682S_PWR_STO1_DAC_L_BIT             5
+#define RT5682S_PWR_STO1_DAC_R                 (0x1 << 4)
+#define RT5682S_PWR_STO1_DAC_R_BIT             4
+#define RT5682S_DVO_BGLDO_MB1_MASK             (0x3 << 2)
+#define RT5682S_DVO_BGLDO_MB1_SFT              2
+#define RT5682S_DVO_BGLDO_MB2_MASK             (0x3 << 0)
+
+/* MCLK and System Clock Detection Control (0x006b) */
+#define RT5682S_SYS_CLK_DET                    (0x1 << 15)
+#define RT5682S_SYS_CLK_DET_SFT                        15
+#define RT5682S_PLL1_CLK_DET                   (0x1 << 14)
+#define RT5682S_PLL1_CLK_DET_SFT               14
+
+/* Digital Microphone Control 1 (0x006e) */
+#define RT5682S_DMIC_1_EN_MASK                 (0x1 << 15)
+#define RT5682S_DMIC_1_EN_SFT                  15
+#define RT5682S_DMIC_1_DIS                     (0x0 << 15)
+#define RT5682S_DMIC_1_EN                      (0x1 << 15)
+#define RT5682S_FIFO_CLK_DIV_MASK              (0x7 << 12)
+#define RT5682S_FIFO_CLK_DIV_2                 (0x1 << 12)
+#define RT5682S_DMIC_1_DP_MASK                 (0x3 << 4)
+#define RT5682S_DMIC_1_DP_SFT                  4
+#define RT5682S_DMIC_1_DP_GPIO2                        (0x0 << 4)
+#define RT5682S_DMIC_1_DP_GPIO5                        (0x1 << 4)
+#define RT5682S_DMIC_CLK_MASK                  (0xf << 0)
+#define RT5682S_DMIC_CLK_SFT                   0
+
+/* I2S1 Audio Serial Data Port Control (0x0070) */
+#define RT5682S_SEL_ADCDAT_MASK                        (0x1 << 15)
+#define RT5682S_SEL_ADCDAT_OUT                 (0x0 << 15)
+#define RT5682S_SEL_ADCDAT_IN                  (0x1 << 15)
+#define RT5682S_SEL_ADCDAT_SFT                 15
+#define RT5682S_I2S1_TX_CHL_MASK               (0x7 << 12)
+#define RT5682S_I2S1_TX_CHL_SFT                        12
+#define RT5682S_I2S1_TX_CHL_16                 (0x0 << 12)
+#define RT5682S_I2S1_TX_CHL_20                 (0x1 << 12)
+#define RT5682S_I2S1_TX_CHL_24                 (0x2 << 12)
+#define RT5682S_I2S1_TX_CHL_32                 (0x3 << 12)
+#define RT5682S_I2S1_TX_CHL_8                  (0x4 << 12)
+#define RT5682S_I2S1_RX_CHL_MASK               (0x7 << 8)
+#define RT5682S_I2S1_RX_CHL_SFT                        8
+#define RT5682S_I2S1_RX_CHL_16                 (0x0 << 8)
+#define RT5682S_I2S1_RX_CHL_20                 (0x1 << 8)
+#define RT5682S_I2S1_RX_CHL_24                 (0x2 << 8)
+#define RT5682S_I2S1_RX_CHL_32                 (0x3 << 8)
+#define RT5682S_I2S1_RX_CHL_8                  (0x4 << 8)
+#define RT5682S_I2S1_MONO_MASK                 (0x1 << 7)
+#define RT5682S_I2S1_MONO_EN                   (0x1 << 7)
+#define RT5682S_I2S1_MONO_DIS                  (0x0 << 7)
+#define RT5682S_I2S1_DL_MASK                   (0x7 << 4)
+#define RT5682S_I2S1_DL_SFT                    4
+#define RT5682S_I2S1_DL_16                     (0x0 << 4)
+#define RT5682S_I2S1_DL_20                     (0x1 << 4)
+#define RT5682S_I2S1_DL_24                     (0x2 << 4)
+#define RT5682S_I2S1_DL_32                     (0x3 << 4)
+#define RT5682S_I2S1_DL_8                      (0x4 << 4)
+
+/* I2S1/2 Audio Serial Data Port Control (0x0071) */
+#define RT5682S_I2S2_MS_MASK                   (0x1 << 15)
+#define RT5682S_I2S2_MS_SFT                    15
+#define RT5682S_I2S2_MS_M                      (0x0 << 15)
+#define RT5682S_I2S2_MS_S                      (0x1 << 15)
+#define RT5682S_I2S2_PIN_CFG_MASK              (0x1 << 14)
+#define RT5682S_I2S2_PIN_CFG_SFT               14
+#define RT5682S_I2S2_OUT_MASK                  (0x1 << 9)
+#define RT5682S_I2S2_OUT_SFT                   9
+#define RT5682S_I2S2_OUT_UM                    (0x0 << 9)
+#define RT5682S_I2S2_OUT_M                     (0x1 << 9)
+#define RT5682S_I2S_BP_MASK                    (0x1 << 8)
+#define RT5682S_I2S_BP_SFT                     8
+#define RT5682S_I2S_BP_NOR                     (0x0 << 8)
+#define RT5682S_I2S_BP_INV                     (0x1 << 8)
+#define RT5682S_I2S2_MONO_MASK                 (0x1 << 7)
+#define RT5682S_I2S2_MONO_EN                   (0x1 << 7)
+#define RT5682S_I2S2_MONO_DIS                  (0x0 << 7)
+#define RT5682S_I2S2_DL_MASK                   (0x7 << 4)
+#define RT5682S_I2S2_DL_SFT                    4
+#define RT5682S_I2S2_DL_8                      (0x0 << 4)
+#define RT5682S_I2S2_DL_16                     (0x1 << 4)
+#define RT5682S_I2S2_DL_20                     (0x2 << 4)
+#define RT5682S_I2S2_DL_24                     (0x3 << 4)
+#define RT5682S_I2S2_DL_32                     (0x4 << 4)
+#define RT5682S_I2S_DF_MASK                    (0x7)
+#define RT5682S_I2S_DF_SFT                     0
+#define RT5682S_I2S_DF_I2S                     (0x0)
+#define RT5682S_I2S_DF_LEFT                    (0x1)
+#define RT5682S_I2S_DF_PCM_A                   (0x2)
+#define RT5682S_I2S_DF_PCM_B                   (0x3)
+#define RT5682S_I2S_DF_PCM_A_N                 (0x6)
+#define RT5682S_I2S_DF_PCM_B_N                 (0x7)
+
+/* ADC/DAC Clock Control 1 (0x0073) */
+#define RT5682S_ADC_OSR_MASK                   (0xf << 12)
+#define RT5682S_ADC_OSR_SFT                    12
+#define RT5682S_ADC_OSR_D_1                    (0x0 << 12)
+#define RT5682S_ADC_OSR_D_2                    (0x1 << 12)
+#define RT5682S_ADC_OSR_D_4                    (0x2 << 12)
+#define RT5682S_ADC_OSR_D_6                    (0x3 << 12)
+#define RT5682S_ADC_OSR_D_8                    (0x4 << 12)
+#define RT5682S_ADC_OSR_D_12                   (0x5 << 12)
+#define RT5682S_ADC_OSR_D_16                   (0x6 << 12)
+#define RT5682S_ADC_OSR_D_24                   (0x7 << 12)
+#define RT5682S_ADC_OSR_D_32                   (0x8 << 12)
+#define RT5682S_ADC_OSR_D_48                   (0x9 << 12)
+#define RT5682S_I2S_M_D_MASK                   (0xf << 8)
+#define RT5682S_I2S_M_D_SFT                    8
+#define RT5682S_I2S_M_D_1                      (0x0 << 8)
+#define RT5682S_I2S_M_D_2                      (0x1 << 8)
+#define RT5682S_I2S_M_D_3                      (0x2 << 8)
+#define RT5682S_I2S_M_D_4                      (0x3 << 8)
+#define RT5682S_I2S_M_D_6                      (0x4 << 8)
+#define RT5682S_I2S_M_D_8                      (0x5 << 8)
+#define RT5682S_I2S_M_D_12                     (0x6 << 8)
+#define RT5682S_I2S_M_D_16                     (0x7 << 8)
+#define RT5682S_I2S_M_D_24                     (0x8 << 8)
+#define RT5682S_I2S_M_D_32                     (0x9 << 8)
+#define RT5682S_I2S_M_D_48                     (0x10 << 8)
+#define RT5682S_I2S_M_CLK_SRC_MASK             (0x7 << 4)
+#define RT5682S_I2S_M_CLK_SRC_SFT              4
+#define RT5682S_DAC_OSR_MASK                   (0xf << 0)
+#define RT5682S_DAC_OSR_SFT                    0
+#define RT5682S_DAC_OSR_D_1                    (0x0 << 0)
+#define RT5682S_DAC_OSR_D_2                    (0x1 << 0)
+#define RT5682S_DAC_OSR_D_4                    (0x2 << 0)
+#define RT5682S_DAC_OSR_D_6                    (0x3 << 0)
+#define RT5682S_DAC_OSR_D_8                    (0x4 << 0)
+#define RT5682S_DAC_OSR_D_12                   (0x5 << 0)
+#define RT5682S_DAC_OSR_D_16                   (0x6 << 0)
+#define RT5682S_DAC_OSR_D_24                   (0x7 << 0)
+#define RT5682S_DAC_OSR_D_32                   (0x8 << 0)
+#define RT5682S_DAC_OSR_D_48                   (0x9 << 0)
+
+/* ADC/DAC Clock Control 2 (0x0074) */
+#define RT5682S_I2S2_BCLK_MS2_MASK             (0x1 << 11)
+#define RT5682S_I2S2_BCLK_MS2_SFT              11
+#define RT5682S_I2S2_BCLK_MS2_32               (0x0 << 11)
+#define RT5682S_I2S2_BCLK_MS2_64               (0x1 << 11)
+
+
+/* TDM control 1 (0x0079) */
+#define RT5682S_TDM_TX_CH_MASK                 (0x3 << 12)
+#define RT5682S_TDM_TX_CH_2                    (0x0 << 12)
+#define RT5682S_TDM_TX_CH_4                    (0x1 << 12)
+#define RT5682S_TDM_TX_CH_6                    (0x2 << 12)
+#define RT5682S_TDM_TX_CH_8                    (0x3 << 12)
+#define RT5682S_TDM_RX_CH_MASK                 (0x3 << 8)
+#define RT5682S_TDM_RX_CH_2                    (0x0 << 8)
+#define RT5682S_TDM_RX_CH_4                    (0x1 << 8)
+#define RT5682S_TDM_RX_CH_6                    (0x2 << 8)
+#define RT5682S_TDM_RX_CH_8                    (0x3 << 8)
+#define RT5682S_TDM_ADC_LCA_MASK               (0x7 << 4)
+#define RT5682S_TDM_ADC_LCA_SFT                        4
+#define RT5682S_TDM_ADC_DL_SFT                 0
+
+/* TDM control 2 (0x007a) */
+#define RT5682S_IF1_ADC1_SEL_SFT               14
+#define RT5682S_IF1_ADC2_SEL_SFT               12
+#define RT5682S_IF1_ADC3_SEL_SFT               10
+#define RT5682S_IF1_ADC4_SEL_SFT               8
+#define RT5682S_TDM_ADC_SEL_SFT                        3
+
+/* TDM control 3 (0x007b) */
+#define RT5682S_TDM_EN                         (0x1 << 7)
+
+/* TDM/I2S control (0x007e) */
+#define RT5682S_TDM_S_BP_MASK                  (0x1 << 15)
+#define RT5682S_TDM_S_BP_SFT                   15
+#define RT5682S_TDM_S_BP_NOR                   (0x0 << 15)
+#define RT5682S_TDM_S_BP_INV                   (0x1 << 15)
+#define RT5682S_TDM_S_LP_MASK                  (0x1 << 14)
+#define RT5682S_TDM_S_LP_SFT                   14
+#define RT5682S_TDM_S_LP_NOR                   (0x0 << 14)
+#define RT5682S_TDM_S_LP_INV                   (0x1 << 14)
+#define RT5682S_TDM_DF_MASK                    (0x7 << 11)
+#define RT5682S_TDM_DF_SFT                     11
+#define RT5682S_TDM_DF_I2S                     (0x0 << 11)
+#define RT5682S_TDM_DF_LEFT                    (0x1 << 11)
+#define RT5682S_TDM_DF_PCM_A                   (0x2 << 11)
+#define RT5682S_TDM_DF_PCM_B                   (0x3 << 11)
+#define RT5682S_TDM_DF_PCM_A_N                 (0x6 << 11)
+#define RT5682S_TDM_DF_PCM_B_N                 (0x7 << 11)
+#define RT5682S_TDM_BCLK_MS1_MASK              (0x3 << 8)
+#define RT5682S_TDM_BCLK_MS1_SFT               8
+#define RT5682S_TDM_BCLK_MS1_32                        (0x0 << 8)
+#define RT5682S_TDM_BCLK_MS1_64                        (0x1 << 8)
+#define RT5682S_TDM_BCLK_MS1_128               (0x2 << 8)
+#define RT5682S_TDM_BCLK_MS1_256               (0x3 << 8)
+#define RT5682S_TDM_BCLK_MS1_16                        (0x4 << 8)
+#define RT5682S_TDM_CL_MASK                    (0x3 << 4)
+#define RT5682S_TDM_CL_16                      (0x0 << 4)
+#define RT5682S_TDM_CL_20                      (0x1 << 4)
+#define RT5682S_TDM_CL_24                      (0x2 << 4)
+#define RT5682S_TDM_CL_32                      (0x3 << 4)
+#define RT5682S_TDM_M_BP_MASK                  (0x1 << 2)
+#define RT5682S_TDM_M_BP_SFT                   2
+#define RT5682S_TDM_M_BP_NOR                   (0x0 << 2)
+#define RT5682S_TDM_M_BP_INV                   (0x1 << 2)
+#define RT5682S_TDM_M_LP_MASK                  (0x1 << 1)
+#define RT5682S_TDM_M_LP_SFT                   1
+#define RT5682S_TDM_M_LP_NOR                   (0x0 << 1)
+#define RT5682S_TDM_M_LP_INV                   (0x1 << 1)
+#define RT5682S_TDM_MS_MASK                    (0x1 << 0)
+#define RT5682S_TDM_MS_SFT                     0
+#define RT5682S_TDM_MS_S                       (0x0 << 0)
+#define RT5682S_TDM_MS_M                       (0x1 << 0)
+
+/* Global Clock Control (0x0080) */
+#define RT5682S_SCLK_SRC_MASK                  (0x7 << 13)
+#define RT5682S_SCLK_SRC_SFT                   13
+#define RT5682S_PLL_SRC_MASK                   (0x3 << 8)
+#define RT5682S_PLL_SRC_SFT                    8
+#define RT5682S_PLL_SRC_MCLK                   (0x0 << 8)
+#define RT5682S_PLL_SRC_BCLK1                  (0x1 << 8)
+#define RT5682S_PLL_SRC_RC                     (0x3 << 8)
+
+/* PLL tracking mode 1 (0x0083) */
+#define RT5682S_DA_ASRC_MASK                   (0x1 << 13)
+#define RT5682S_DA_ASRC_SFT                    13
+#define RT5682S_DAC_STO1_ASRC_MASK             (0x1 << 12)
+#define RT5682S_DAC_STO1_ASRC_SFT              12
+#define RT5682S_AD_ASRC_MASK                   (0x1 << 8)
+#define RT5682S_AD_ASRC_SFT                    8
+#define RT5682S_AD_ASRC_SEL_MASK               (0x1 << 4)
+#define RT5682S_AD_ASRC_SEL_SFT                        4
+#define RT5682S_DMIC_ASRC_MASK                 (0x1 << 3)
+#define RT5682S_DMIC_ASRC_SFT                  3
+#define RT5682S_ADC_STO1_ASRC_MASK             (0x1 << 2)
+#define RT5682S_ADC_STO1_ASRC_SFT              2
+#define RT5682S_DA_ASRC_SEL_MASK               (0x1 << 0)
+#define RT5682S_DA_ASRC_SEL_SFT                        0
+
+/* PLL tracking mode 2 3 (0x0084)(0x0085)*/
+#define RT5682S_FILTER_CLK_SEL_MASK            (0x7 << 12)
+#define RT5682S_FILTER_CLK_SEL_SFT             12
+#define RT5682S_FILTER_CLK_DIV_MASK            (0xf << 8)
+#define RT5682S_FILTER_CLK_DIV_SFT             8
+
+/* ASRC Control 4 (0x0086) */
+#define RT5682S_ASRCIN_FTK_N1_MASK             (0x3 << 14)
+#define RT5682S_ASRCIN_FTK_N1_SFT              14
+#define RT5682S_ASRCIN_FTK_N2_MASK             (0x3 << 12)
+#define RT5682S_ASRCIN_FTK_N2_SFT              12
+#define RT5682S_ASRCIN_FTK_M1_MASK             (0x7 << 8)
+#define RT5682S_ASRCIN_FTK_M1_SFT              8
+#define RT5682S_ASRCIN_FTK_M2_MASK             (0x7 << 4)
+#define RT5682S_ASRCIN_FTK_M2_SFT              4
+
+/* ASRC Control 11 (0x008c) */
+#define RT5682S_ASRCIN_AUTO_CLKOUT_MASK                (0x1 << 5)
+#define RT5682S_ASRCIN_AUTO_CLKOUT_EN          (0x1 << 5)
+#define RT5682S_ASRCIN_AUTO_CLKOUT_DIS         (0x0 << 5)
+#define RT5682S_ASRCIN_AUTO_RST_MASK           (0x1 << 4)
+#define RT5682S_ASRCIN_AUTO_RST_EN             (0x1 << 4)
+#define RT5682S_ASRCIN_AUTO_RST_DIS            (0x0 << 4)
+#define RT5682S_SEL_LRCK_DET_MASK              (0x3)
+#define RT5682S_SEL_LRCK_DET_DIV8              (0x3)
+#define RT5682S_SEL_LRCK_DET_DIV4              (0x2)
+#define RT5682S_SEL_LRCK_DET_DIV2              (0x1)
+#define RT5682S_SEL_LRCK_DET_DIV1              (0x0)
+
+/* Depop Mode Control 1 (0x008e) */
+#define RT5682S_OUT_HP_L_EN                    (0x1 << 6)
+#define RT5682S_OUT_HP_R_EN                    (0x1 << 5)
+#define RT5682S_LDO_PUMP_EN                    (0x1 << 4)
+#define RT5682S_LDO_PUMP_EN_SFT                        4
+#define RT5682S_PUMP_EN                                (0x1 << 3)
+#define RT5682S_PUMP_EN_SFT                    3
+#define RT5682S_CAPLESS_L_EN                   (0x1 << 1)
+#define RT5682S_CAPLESS_L_EN_SFT               1
+#define RT5682S_CAPLESS_R_EN                   (0x1 << 0)
+#define RT5682S_CAPLESS_R_EN_SFT               0
+
+/* Depop Mode Control 2 (0x8f) */
+#define RT5682S_RAMP_MASK                      (0x1 << 12)
+#define RT5682S_RAMP_SFT                       12
+#define RT5682S_RAMP_DIS                       (0x0 << 12)
+#define RT5682S_RAMP_EN                                (0x1 << 12)
+#define RT5682S_BPS_MASK                       (0x1 << 11)
+#define RT5682S_BPS_SFT                                11
+#define RT5682S_BPS_DIS                                (0x0 << 11)
+#define RT5682S_BPS_EN                         (0x1 << 11)
+#define RT5682S_FAST_UPDN_MASK                 (0x1 << 10)
+#define RT5682S_FAST_UPDN_SFT                  10
+#define RT5682S_FAST_UPDN_DIS                  (0x0 << 10)
+#define RT5682S_FAST_UPDN_EN                   (0x1 << 10)
+#define RT5682S_VLO_MASK                       (0x1 << 7)
+#define RT5682S_VLO_SFT                                7
+#define RT5682S_VLO_3V                         (0x0 << 7)
+#define RT5682S_VLO_33V                                (0x1 << 7)
+
+/* HPOUT charge pump 1 (0x0091) */
+#define RT5682S_OSW_L_MASK                     (0x1 << 11)
+#define RT5682S_OSW_L_SFT                      11
+#define RT5682S_OSW_L_DIS                      (0x0 << 11)
+#define RT5682S_OSW_L_EN                       (0x1 << 11)
+#define RT5682S_OSW_R_MASK                     (0x1 << 10)
+#define RT5682S_OSW_R_SFT                      10
+#define RT5682S_OSW_R_DIS                      (0x0 << 10)
+#define RT5682S_OSW_R_EN                       (0x1 << 10)
+#define RT5682S_PM_HP_MASK                     (0x3 << 8)
+#define RT5682S_PM_HP_SFT                      8
+#define RT5682S_PM_HP_LV                       (0x0 << 8)
+#define RT5682S_PM_HP_MV                       (0x1 << 8)
+#define RT5682S_PM_HP_HV                       (0x2 << 8)
+
+/* Micbias Control1 (0x93) */
+#define RT5682S_MIC1_OV_MASK                   (0x3 << 14)
+#define RT5682S_MIC1_OV_SFT                    14
+#define RT5682S_MIC1_OV_2V7                    (0x0 << 14)
+#define RT5682S_MIC1_OV_2V4                    (0x1 << 14)
+#define RT5682S_MIC1_OV_2V25                   (0x3 << 14)
+#define RT5682S_MIC1_OV_1V8                    (0x4 << 14)
+#define RT5682S_MIC2_OV_MASK                   (0x3 << 8)
+#define RT5682S_MIC2_OV_SFT                    8
+#define RT5682S_MIC2_OV_2V7                    (0x0 << 8)
+#define RT5682S_MIC2_OV_2V4                    (0x1 << 8)
+#define RT5682S_MIC2_OV_2V25                   (0x3 << 8)
+#define RT5682S_MIC2_OV_1V8                    (0x4 << 8)
+
+/* Micbias Control2 (0x0094) */
+#define RT5682S_PWR_CLK25M_MASK                        (0x1 << 9)
+#define RT5682S_PWR_CLK25M_SFT                 9
+#define RT5682S_PWR_CLK25M_PD                  (0x0 << 9)
+#define RT5682S_PWR_CLK25M_PU                  (0x1 << 9)
+#define RT5682S_PWR_CLK1M_MASK                 (0x1 << 8)
+#define RT5682S_PWR_CLK1M_SFT                  8
+#define RT5682S_PWR_CLK1M_PD                   (0x0 << 8)
+#define RT5682S_PWR_CLK1M_PU                   (0x1 << 8)
+
+/* PLL M/N/K Code Control 1 (0x0098) */
+#define RT5682S_PLLA_N_MASK                    (0x1ff << 0)
+
+/* PLL M/N/K Code Control 2 (0x0099) */
+#define RT5682S_PLLA_M_MASK                    (0x1f << 8)
+#define RT5682S_PLLA_M_SFT                     8
+#define RT5682S_PLLA_K_MASK                    (0x1f << 0)
+
+/* PLL M/N/K Code Control 3 (0x009a) */
+#define RT5682S_PLLB_N_MASK                    (0x3ff << 0)
+
+/* PLL M/N/K Code Control 4 (0x009b) */
+#define RT5682S_PLLB_M_MASK                    (0x1f << 8)
+#define RT5682S_PLLB_M_SFT                     8
+#define RT5682S_PLLB_K_MASK                    (0x1f << 0)
+
+/* PLL M/N/K Code Control 6 (0x009d) */
+#define RT5682S_PLLB_SEL_PS_MASK               (0x1 << 13)
+#define RT5682S_PLLB_SEL_PS_SFT                        13
+#define RT5682S_PLLB_BYP_PS_MASK               (0x1 << 12)
+#define RT5682S_PLLB_BYP_PS_SFT                        12
+#define RT5682S_PLLB_M_BP_MASK                 (0x1 << 11)
+#define RT5682S_PLLB_M_BP_SFT                  11
+#define RT5682S_PLLB_K_BP_MASK                 (0x1 << 10)
+#define RT5682S_PLLB_K_BP_SFT                  10
+#define RT5682S_PLLA_M_BP_MASK                 (0x1 << 7)
+#define RT5682S_PLLA_M_BP_SFT                  7
+#define RT5682S_PLLA_K_BP_MASK                 (0x1 << 6)
+#define RT5682S_PLLA_K_BP_SFT                  6
+
+/* PLL M/N/K Code Control 7 (0x009e) */
+#define RT5682S_PLLB_SRC_MASK                  (0x1)
+#define RT5682S_PLLB_SRC_DFIN                  (0x1)
+#define RT5682S_PLLB_SRC_PLLA                  (0x0)
+
+/* RC Clock Control (0x009f) */
+#define RT5682S_POW_IRQ                                (0x1 << 15)
+#define RT5682S_POW_JDH                                (0x1 << 14)
+
+/* I2S2 Master Mode Clock Control 1 (0x00a0) */
+#define RT5682S_I2S2_M_CLK_SRC_MASK            (0x7 << 4)
+#define RT5682S_I2S2_M_CLK_SRC_SFT             4
+#define RT5682S_I2S2_M_D_MASK                  (0xf << 0)
+#define RT5682S_I2S2_M_D_1                     (0x0)
+#define RT5682S_I2S2_M_D_2                     (0x1)
+#define RT5682S_I2S2_M_D_3                     (0x2)
+#define RT5682S_I2S2_M_D_4                     (0x3)
+#define RT5682S_I2S2_M_D_6                     (0x4)
+#define RT5682S_I2S2_M_D_8                     (0x5)
+#define RT5682S_I2S2_M_D_12                    (0x6)
+#define RT5682S_I2S2_M_D_16                    (0x7)
+#define RT5682S_I2S2_M_D_24                    (0x8)
+#define RT5682S_I2S2_M_D_32                    (0x9)
+#define RT5682S_I2S2_M_D_48                    (0xa)
+#define RT5682S_I2S2_M_D_SFT                   0
+
+/* IRQ Control 1 (0x00b6) */
+#define RT5682S_JD1_PULSE_EN_MASK              (0x1 << 10)
+#define RT5682S_JD1_PULSE_EN_SFT               10
+#define RT5682S_JD1_PULSE_DIS                  (0x0 << 10)
+#define RT5682S_JD1_PULSE_EN                   (0x1 << 10)
+
+/* IRQ Control 2 (0x00b7) */
+#define RT5682S_JD1_EN_MASK                    (0x1 << 15)
+#define RT5682S_JD1_EN_SFT                     15
+#define RT5682S_JD1_DIS                                (0x0 << 15)
+#define RT5682S_JD1_EN                         (0x1 << 15)
+#define RT5682S_JD1_POL_MASK                   (0x1 << 13)
+#define RT5682S_JD1_POL_NOR                    (0x0 << 13)
+#define RT5682S_JD1_POL_INV                    (0x1 << 13)
+#define RT5682S_JD1_IRQ_MASK                   (0x1 << 10)
+#define RT5682S_JD1_IRQ_LEV                    (0x0 << 10)
+#define RT5682S_JD1_IRQ_PUL                    (0x1 << 10)
+
+/* IRQ Control 3 (0x00b8) */
+#define RT5682S_IL_IRQ_MASK                    (0x1 << 7)
+#define RT5682S_IL_IRQ_DIS                     (0x0 << 7)
+#define RT5682S_IL_IRQ_EN                      (0x1 << 7)
+#define RT5682S_IL_IRQ_TYPE_MASK               (0x1 << 4)
+#define RT5682S_IL_IRQ_LEV                     (0x0 << 4)
+#define RT5682S_IL_IRQ_PUL                     (0x1 << 4)
+
+/* GPIO Control 1 (0x00c0) */
+#define RT5682S_GP1_PIN_MASK                   (0x3 << 14)
+#define RT5682S_GP1_PIN_SFT                    14
+#define RT5682S_GP1_PIN_GPIO1                  (0x0 << 14)
+#define RT5682S_GP1_PIN_IRQ                    (0x1 << 14)
+#define RT5682S_GP1_PIN_DMIC_CLK               (0x2 << 14)
+#define RT5682S_GP2_PIN_MASK                   (0x3 << 12)
+#define RT5682S_GP2_PIN_SFT                    12
+#define RT5682S_GP2_PIN_GPIO2                  (0x0 << 12)
+#define RT5682S_GP2_PIN_LRCK2                  (0x1 << 12)
+#define RT5682S_GP2_PIN_DMIC_SDA               (0x2 << 12)
+#define RT5682S_GP3_PIN_MASK                   (0x3 << 10)
+#define RT5682S_GP3_PIN_SFT                    10
+#define RT5682S_GP3_PIN_GPIO3                  (0x0 << 10)
+#define RT5682S_GP3_PIN_BCLK2                  (0x1 << 10)
+#define RT5682S_GP3_PIN_DMIC_CLK               (0x2 << 10)
+#define RT5682S_GP4_PIN_MASK                   (0x3 << 8)
+#define RT5682S_GP4_PIN_SFT                    8
+#define RT5682S_GP4_PIN_GPIO4                  (0x0 << 8)
+#define RT5682S_GP4_PIN_ADCDAT1                        (0x1 << 8)
+#define RT5682S_GP4_PIN_DMIC_CLK               (0x2 << 8)
+#define RT5682S_GP4_PIN_ADCDAT2                        (0x3 << 8)
+#define RT5682S_GP5_PIN_MASK                   (0x3 << 6)
+#define RT5682S_GP5_PIN_SFT                    6
+#define RT5682S_GP5_PIN_GPIO5                  (0x0 << 6)
+#define RT5682S_GP5_PIN_DACDAT1                        (0x1 << 6)
+#define RT5682S_GP5_PIN_DMIC_SDA               (0x2 << 6)
+#define RT5682S_GP6_PIN_MASK                   (0x1 << 5)
+#define RT5682S_GP6_PIN_SFT                    5
+#define RT5682S_GP6_PIN_GPIO6                  (0x0 << 5)
+#define RT5682S_GP6_PIN_LRCK1                  (0x1 << 5)
+
+/* GPIO Control 2 (0x00c1)*/
+#define RT5682S_GP1_PF_MASK                    (0x1 << 15)
+#define RT5682S_GP1_PF_IN                      (0x0 << 15)
+#define RT5682S_GP1_PF_OUT                     (0x1 << 15)
+#define RT5682S_GP1_OUT_MASK                   (0x1 << 14)
+#define RT5682S_GP1_OUT_L                      (0x0 << 14)
+#define RT5682S_GP1_OUT_H                      (0x1 << 14)
+#define RT5682S_GP2_PF_MASK                    (0x1 << 13)
+#define RT5682S_GP2_PF_IN                      (0x0 << 13)
+#define RT5682S_GP2_PF_OUT                     (0x1 << 13)
+#define RT5682S_GP2_OUT_MASK                   (0x1 << 12)
+#define RT5682S_GP2_OUT_L                      (0x0 << 12)
+#define RT5682S_GP2_OUT_H                      (0x1 << 12)
+#define RT5682S_GP3_PF_MASK                    (0x1 << 11)
+#define RT5682S_GP3_PF_IN                      (0x0 << 11)
+#define RT5682S_GP3_PF_OUT                     (0x1 << 11)
+#define RT5682S_GP3_OUT_MASK                   (0x1 << 10)
+#define RT5682S_GP3_OUT_L                      (0x0 << 10)
+#define RT5682S_GP3_OUT_H                      (0x1 << 10)
+#define RT5682S_GP4_PF_MASK                    (0x1 << 9)
+#define RT5682S_GP4_PF_IN                      (0x0 << 9)
+#define RT5682S_GP4_PF_OUT                     (0x1 << 9)
+#define RT5682S_GP4_OUT_MASK                   (0x1 << 8)
+#define RT5682S_GP4_OUT_L                      (0x0 << 8)
+#define RT5682S_GP4_OUT_H                      (0x1 << 8)
+#define RT5682S_GP5_PF_MASK                    (0x1 << 7)
+#define RT5682S_GP5_PF_IN                      (0x0 << 7)
+#define RT5682S_GP5_PF_OUT                     (0x1 << 7)
+#define RT5682S_GP5_OUT_MASK                   (0x1 << 6)
+#define RT5682S_GP5_OUT_L                      (0x0 << 6)
+#define RT5682S_GP5_OUT_H                      (0x1 << 6)
+#define RT5682S_GP6_PF_MASK                    (0x1 << 5)
+#define RT5682S_GP6_PF_IN                      (0x0 << 5)
+#define RT5682S_GP6_PF_OUT                     (0x1 << 5)
+#define RT5682S_GP6_OUT_MASK                   (0x1 << 4)
+#define RT5682S_GP6_OUT_L                      (0x0 << 4)
+#define RT5682S_GP6_OUT_H                      (0x1 << 4)
+
+/* GPIO Status (0x00c2) */
+#define RT5682S_GP6_ST                         (0x1 << 6)
+#define RT5682S_GP5_ST                         (0x1 << 5)
+#define RT5682S_GP4_ST                         (0x1 << 4)
+#define RT5682S_GP3_ST                         (0x1 << 3)
+#define RT5682S_GP2_ST                         (0x1 << 2)
+#define RT5682S_GP1_ST                         (0x1 << 1)
+
+/* Soft volume and zero cross control 1 (0x00d9) */
+#define RT5682S_ZCD_MASK                       (0x1 << 10)
+#define RT5682S_ZCD_SFT                                10
+#define RT5682S_ZCD_PD                         (0x0 << 10)
+#define RT5682S_ZCD_PU                         (0x1 << 10)
+
+/* 4 Button Inline Command Control 2 (0x00e3) */
+#define RT5682S_4BTN_IL_MASK                   (0x1 << 15)
+#define RT5682S_4BTN_IL_EN                     (0x1 << 15)
+#define RT5682S_4BTN_IL_DIS                    (0x0 << 15)
+#define RT5682S_4BTN_IL_RST_MASK               (0x1 << 14)
+#define RT5682S_4BTN_IL_NOR                    (0x1 << 14)
+#define RT5682S_4BTN_IL_RST                    (0x0 << 14)
+
+/* 4 Button Inline Command Control 3~6 (0x00e5~0x00e8) */
+#define RT5682S_4BTN_IL_HOLD_WIN_MASK          (0x7f << 8)
+#define RT5682S_4BTN_IL_HOLD_WIN_SFT           8
+#define RT5682S_4BTN_IL_CLICK_WIN_MASK         (0x7f)
+#define RT5682S_4BTN_IL_CLICK_WIN_SFT          0
+
+/* Analog JD Control (0x00f0) */
+#define RT5682S_JDH_RS_MASK                    (0x1 << 4)
+#define RT5682S_JDH_NO_PLUG                    (0x1 << 4)
+#define RT5682S_JDH_PLUG                       (0x0 << 4)
+
+/* Charge Pump Internal Register1 (0x0125) */
+#define RT5682S_CP_CLK_HP_MASK                 (0x3 << 4)
+#define RT5682S_CP_CLK_HP_100KHZ               (0x0 << 4)
+#define RT5682S_CP_CLK_HP_200KHZ               (0x1 << 4)
+#define RT5682S_CP_CLK_HP_300KHZ               (0x2 << 4)
+#define RT5682S_CP_CLK_HP_600KHZ               (0x3 << 4)
+
+/* Pad Driving Control (0x0136) */
+#define RT5682S_PAD_DRV_GP1_MASK               (0x1 << 14)
+#define RT5682S_PAD_DRV_GP1_HIGH               (0x1 << 14)
+#define RT5682S_PAD_DRV_GP1_LOW                        (0x0 << 14)
+#define RT5682S_PAD_DRV_GP2_MASK               (0x1 << 12)
+#define RT5682S_PAD_DRV_GP2_HIGH               (0x1 << 12)
+#define RT5682S_PAD_DRV_GP2_LOW                        (0x0 << 12)
+#define RT5682S_PAD_DRV_GP3_MASK               (0x1 << 10)
+#define RT5682S_PAD_DRV_GP3_HIGH               (0x1 << 10)
+#define RT5682S_PAD_DRV_GP3_LOW                        (0x0 << 10)
+#define RT5682S_PAD_DRV_GP4_MASK               (0x1 << 8)
+#define RT5682S_PAD_DRV_GP4_HIGH               (0x1 << 8)
+#define RT5682S_PAD_DRV_GP4_LOW                        (0x0 << 8)
+#define RT5682S_PAD_DRV_GP5_MASK               (0x1 << 6)
+#define RT5682S_PAD_DRV_GP5_HIGH               (0x1 << 6)
+#define RT5682S_PAD_DRV_GP5_LOW                        (0x0 << 6)
+#define RT5682S_PAD_DRV_GP6_MASK               (0x1 << 4)
+#define RT5682S_PAD_DRV_GP6_HIGH               (0x1 << 4)
+#define RT5682S_PAD_DRV_GP6_LOW                        (0x0 << 4)
+
+/* Chopper and Clock control for DAC (0x013a)*/
+#define RT5682S_CKXEN_DAC1_MASK                        (0x1 << 13)
+#define RT5682S_CKXEN_DAC1_SFT                 13
+#define RT5682S_CKGEN_DAC1_MASK                        (0x1 << 12)
+#define RT5682S_CKGEN_DAC1_SFT                 12
+
+/* Chopper and Clock control for ADC (0x013b)*/
+#define RT5682S_CKXEN_ADC1_MASK                        (0x1 << 13)
+#define RT5682S_CKXEN_ADC1_SFT                 13
+#define RT5682S_CKGEN_ADC1_MASK                        (0x1 << 12)
+#define RT5682S_CKGEN_ADC1_SFT                 12
+
+/* Volume test (0x013f)*/
+#define RT5682S_SEL_CLK_VOL_MASK               (0x1 << 15)
+#define RT5682S_SEL_CLK_VOL_EN                 (0x1 << 15)
+#define RT5682S_SEL_CLK_VOL_DIS                        (0x0 << 15)
+
+/* Test Mode Control 1 (0x0145) */
+#define RT5682S_AD2DA_LB_MASK                  (0x1 << 10)
+#define RT5682S_AD2DA_LB_SFT                   10
+
+/* Stereo Noise Gate Control 1 (0x0160) */
+#define RT5682S_NG2_EN_MASK                    (0x1 << 15)
+#define RT5682S_NG2_EN                         (0x1 << 15)
+#define RT5682S_NG2_DIS                                (0x0 << 15)
+
+/* Stereo1 DAC Silence Detection Control (0x0190) */
+#define RT5682S_DEB_STO_DAC_MASK               (0x7 << 4)
+#define RT5682S_DEB_80_MS                      (0x0 << 4)
+
+/* HP Behavior Logic Control 2 (0x01db) */
+#define RT5682S_HP_SIG_SRC_MASK                        (0x3)
+#define RT5682S_HP_SIG_SRC_1BIT_CTL            (0x3)
+#define RT5682S_HP_SIG_SRC_REG                 (0x2)
+#define RT5682S_HP_SIG_SRC_IMPE_REG            (0x1)
+#define RT5682S_HP_SIG_SRC_DC_CALI             (0x0)
+
+/* SAR ADC Inline Command Control 1 (0x0210) */
+#define RT5682S_SAR_BUTDET_MASK                        (0x1 << 15)
+#define RT5682S_SAR_BUTDET_EN                  (0x1 << 15)
+#define RT5682S_SAR_BUTDET_DIS                 (0x0 << 15)
+#define RT5682S_SAR_BUTDET_POW_MASK            (0x1 << 14)
+#define RT5682S_SAR_BUTDET_POW_SAV             (0x1 << 14)
+#define RT5682S_SAR_BUTDET_POW_NORM            (0x0 << 14)
+#define RT5682S_SAR_BUTDET_RST_MASK            (0x1 << 13)
+#define RT5682S_SAR_BUTDET_RST_NORM            (0x1 << 13)
+#define RT5682S_SAR_BUTDET_RST                 (0x0 << 13)
+#define RT5682S_SAR_POW_MASK                   (0x1 << 12)
+#define RT5682S_SAR_POW_EN                     (0x1 << 12)
+#define RT5682S_SAR_POW_DIS                    (0x0 << 12)
+#define RT5682S_SAR_RST_MASK                   (0x1 << 11)
+#define RT5682S_SAR_RST_NORMAL                 (0x1 << 11)
+#define RT5682S_SAR_RST                                (0x0 << 11)
+#define RT5682S_SAR_BYPASS_MASK                        (0x1 << 10)
+#define RT5682S_SAR_BYPASS_EN                  (0x1 << 10)
+#define RT5682S_SAR_BYPASS_DIS                 (0x0 << 10)
+#define RT5682S_SAR_SEL_MB1_2_MASK             (0x3 << 8)
+#define RT5682S_SAR_SEL_MB1_2_SFT              8
+#define RT5682S_SAR_SEL_MODE_MASK              (0x1 << 7)
+#define RT5682S_SAR_SEL_MODE_CMP               (0x1 << 7)
+#define RT5682S_SAR_SEL_MODE_ADC               (0x0 << 7)
+#define RT5682S_SAR_SEL_MB1_2_CTL_MASK         (0x1 << 5)
+#define RT5682S_SAR_SEL_MB1_2_AUTO             (0x1 << 5)
+#define RT5682S_SAR_SEL_MB1_2_MANU             (0x0 << 5)
+#define RT5682S_SAR_SEL_SIGNAL_MASK            (0x1 << 4)
+#define RT5682S_SAR_SEL_SIGNAL_AUTO            (0x1 << 4)
+#define RT5682S_SAR_SEL_SIGNAL_MANU            (0x0 << 4)
+
+/* SAR ADC Inline Command Control 2 (0x0211) */
+#define RT5682S_SAR_ADC_PSV_MASK               (0x1 << 4)
+#define RT5682S_SAR_ADC_PSV_ENTRY              (0x1 << 4)
+
+
+/* SAR ADC Inline Command Control 13 (0x021c) */
+#define RT5682S_SAR_SOUR_MASK                  (0x3f)
+#define RT5682S_SAR_SOUR_BTN                   (0x3f)
+#define RT5682S_SAR_SOUR_TYPE                  (0x0)
+
+/* Headphone Amp Detection Control 1 (0x3b00) */
+#define RT5682S_CP_SW_SIZE_MASK                        (0x7 << 4)
+#define RT5682S_CP_SW_SIZE_L                   (0x4 << 4)
+#define RT5682S_CP_SW_SIZE_M                   (0x2 << 4)
+#define RT5682S_CP_SW_SIZE_S                   (0x1 << 4)
+
+#define RT5682S_STEREO_RATES SNDRV_PCM_RATE_8000_192000
+#define RT5682S_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE | \
+               SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S8)
+
+/* System Clock Source */
+enum {
+       RT5682S_SCLK_S_MCLK,
+       RT5682S_SCLK_S_PLL1,
+       RT5682S_SCLK_S_PLL2,
+       RT5682S_SCLK_S_RCCLK,
+};
+
+/* PLL Source */
+enum {
+       RT5682S_PLL_S_MCLK,
+       RT5682S_PLL_S_BCLK1,
+       RT5682S_PLL_S_BCLK2,
+       RT5682S_PLL_S_RCCLK,
+};
+
+enum {
+       RT5682S_PLL1,
+       RT5682S_PLL2,
+       RT5682S_PLLS,
+};
+
+enum {
+       RT5682S_AIF1,
+       RT5682S_AIF2,
+       RT5682S_AIFS
+};
+
+/* filter mask */
+enum {
+       RT5682S_DA_STEREO1_FILTER = 0x1,
+       RT5682S_AD_STEREO1_FILTER = (0x1 << 1),
+};
+
+enum {
+       RT5682S_CLK_SEL_SYS,
+       RT5682S_CLK_SEL_I2S1_ASRC,
+       RT5682S_CLK_SEL_I2S2_ASRC,
+};
+
+enum {
+       USE_PLLA,
+       USE_PLLB,
+       USE_PLLAB,
+};
+
+struct pll_calc_map {
+       unsigned int freq_in;
+       unsigned int freq_out;
+       int m;
+       int n;
+       int k;
+       bool m_bp;
+       bool k_bp;
+       bool byp_ps;
+       bool sel_ps;
+};
+
+#define RT5682S_NUM_SUPPLIES 2
+
+struct rt5682s_priv {
+       struct snd_soc_component *component;
+       struct rt5682s_platform_data pdata;
+       struct regmap *regmap;
+       struct snd_soc_jack *hs_jack;
+       struct regulator_bulk_data supplies[RT5682S_NUM_SUPPLIES];
+       struct delayed_work jack_detect_work;
+       struct delayed_work jd_check_work;
+       struct mutex calibrate_mutex;
+       struct mutex sar_mutex;
+       struct mutex jdet_mutex;
+
+#ifdef CONFIG_COMMON_CLK
+       struct clk_hw dai_clks_hw[RT5682S_DAI_NUM_CLKS];
+       struct clk *mclk;
+#endif
+
+       int sysclk;
+       int sysclk_src;
+       int lrck[RT5682S_AIFS];
+       int bclk[RT5682S_AIFS];
+       int master[RT5682S_AIFS];
+
+       int pll_src[RT5682S_PLLS];
+       int pll_in[RT5682S_PLLS];
+       int pll_out[RT5682S_PLLS];
+       int pll_comb;
+
+       int jack_type;
+       int irq_work_delay_time;
+};
+
+int rt5682s_sel_asrc_clk_src(struct snd_soc_component *component,
+               unsigned int filter_mask, unsigned int clk_src);
+
+#endif /* __RT5682S_H__ */
diff --git a/sound/soc/codecs/rt9120.c b/sound/soc/codecs/rt9120.c
new file mode 100644 (file)
index 0000000..f957498
--- /dev/null
@@ -0,0 +1,495 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <linux/bits.h>
+#include <linux/delay.h>
+#include <linux/gpio/consumer.h>
+#include <linux/i2c.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/regmap.h>
+#include <linux/regulator/consumer.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/tlv.h>
+
+#define RT9120_REG_DEVID       0x00
+#define RT9120_REG_I2SFMT      0x02
+#define RT9120_REG_I2SWL       0x03
+#define RT9120_REG_SDIOSEL     0x04
+#define RT9120_REG_SYSCTL      0x05
+#define RT9120_REG_SPKGAIN     0x07
+#define RT9120_REG_VOLRAMP     0x0A
+#define RT9120_REG_ERRRPT      0x10
+#define RT9120_REG_MSVOL       0x20
+#define RT9120_REG_SWRESET     0x40
+#define RT9120_REG_INTERNAL0   0x65
+#define RT9120_REG_INTERNAL1   0x69
+#define RT9120_REG_UVPOPT      0x6C
+
+#define RT9120_VID_MASK                GENMASK(15, 8)
+#define RT9120_SWRST_MASK      BIT(7)
+#define RT9120_MUTE_MASK       GENMASK(5, 4)
+#define RT9120_I2SFMT_MASK     GENMASK(4, 2)
+#define RT9120_I2SFMT_SHIFT    2
+#define RT9120_CFG_FMT_I2S     0
+#define RT9120_CFG_FMT_LEFTJ   1
+#define RT9120_CFG_FMT_RIGHTJ  2
+#define RT9120_CFG_FMT_DSPA    3
+#define RT9120_CFG_FMT_DSPB    7
+#define RT9120_AUDBIT_MASK     GENMASK(1, 0)
+#define RT9120_CFG_AUDBIT_16   0
+#define RT9120_CFG_AUDBIT_20   1
+#define RT9120_CFG_AUDBIT_24   2
+#define RT9120_AUDWL_MASK      GENMASK(5, 0)
+#define RT9120_CFG_WORDLEN_16  16
+#define RT9120_CFG_WORDLEN_24  24
+#define RT9120_CFG_WORDLEN_32  32
+#define RT9120_DVDD_UVSEL_MASK GENMASK(5, 4)
+
+#define RT9120_VENDOR_ID       0x4200
+#define RT9120_RESET_WAITMS    20
+#define RT9120_CHIPON_WAITMS   20
+#define RT9120_AMPON_WAITMS    50
+#define RT9120_AMPOFF_WAITMS   100
+#define RT9120_LVAPP_THRESUV   2000000
+
+/* 8000 to 192000 supported , only 176400 not support */
+#define RT9120_RATES_MASK      (SNDRV_PCM_RATE_8000_192000 &\
+                                ~SNDRV_PCM_RATE_176400)
+#define RT9120_FMTS_MASK       (SNDRV_PCM_FMTBIT_S16_LE |\
+                                SNDRV_PCM_FMTBIT_S24_LE |\
+                                SNDRV_PCM_FMTBIT_S32_LE)
+
+struct rt9120_data {
+       struct device *dev;
+       struct regmap *regmap;
+};
+
+/* 11bit [min,max,step] = [-103.9375dB, 24dB, 0.0625dB] */
+static const DECLARE_TLV_DB_SCALE(digital_tlv, -1039375, 625, 1);
+
+/* {6, 8, 10, 12, 13, 14, 15, 16}dB */
+static const DECLARE_TLV_DB_RANGE(classd_tlv,
+       0, 3, TLV_DB_SCALE_ITEM(600, 200, 0),
+       4, 7, TLV_DB_SCALE_ITEM(1300, 100, 0)
+);
+
+static const char * const sdo_select_text[] = {
+       "None", "INTF", "Final", "RMS Detect"
+};
+
+static const struct soc_enum sdo_select_enum =
+       SOC_ENUM_SINGLE(RT9120_REG_SDIOSEL, 4, ARRAY_SIZE(sdo_select_text),
+                       sdo_select_text);
+
+static const struct snd_kcontrol_new rt9120_snd_controls[] = {
+       SOC_SINGLE_TLV("MS Volume", RT9120_REG_MSVOL, 0, 2047, 1, digital_tlv),
+       SOC_SINGLE_TLV("SPK Gain Volume", RT9120_REG_SPKGAIN, 0, 7, 0, classd_tlv),
+       SOC_SINGLE("PBTL Switch", RT9120_REG_SYSCTL, 3, 1, 0),
+       SOC_ENUM("SDO Select", sdo_select_enum),
+};
+
+static int internal_power_event(struct snd_soc_dapm_widget *w,
+                               struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *comp = snd_soc_dapm_to_component(w->dapm);
+
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               snd_soc_component_write(comp, RT9120_REG_ERRRPT, 0);
+               break;
+       case SND_SOC_DAPM_POST_PMU:
+               msleep(RT9120_AMPON_WAITMS);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               msleep(RT9120_AMPOFF_WAITMS);
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_dapm_widget rt9120_dapm_widgets[] = {
+       SND_SOC_DAPM_MIXER("DMIX", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_DAC("LDAC", NULL, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_DAC("RDAC", NULL, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_SUPPLY("PWND", RT9120_REG_SYSCTL, 6, 1,
+                           internal_power_event, SND_SOC_DAPM_PRE_PMU |
+                           SND_SOC_DAPM_POST_PMU | SND_SOC_DAPM_POST_PMD),
+       SND_SOC_DAPM_PGA("SPKL PA", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_PGA("SPKR PA", SND_SOC_NOPM, 0, 0, NULL, 0),
+       SND_SOC_DAPM_OUTPUT("SPKL"),
+       SND_SOC_DAPM_OUTPUT("SPKR"),
+};
+
+static const struct snd_soc_dapm_route rt9120_dapm_routes[] = {
+       { "DMIX", NULL, "AIF Playback" },
+       /* SPKL */
+       { "LDAC", NULL, "PWND" },
+       { "LDAC", NULL, "DMIX" },
+       { "SPKL PA", NULL, "LDAC" },
+       { "SPKL", NULL, "SPKL PA" },
+       /* SPKR */
+       { "RDAC", NULL, "PWND" },
+       { "RDAC", NULL, "DMIX" },
+       { "SPKR PA", NULL, "RDAC" },
+       { "SPKR", NULL, "SPKR PA" },
+       /* Cap */
+       { "AIF Capture", NULL, "LDAC" },
+       { "AIF Capture", NULL, "RDAC" },
+};
+
+static int rt9120_codec_probe(struct snd_soc_component *comp)
+{
+       struct rt9120_data *data = snd_soc_component_get_drvdata(comp);
+
+       snd_soc_component_init_regmap(comp, data->regmap);
+
+       /* Internal setting */
+       snd_soc_component_write(comp, RT9120_REG_INTERNAL1, 0x03);
+       snd_soc_component_write(comp, RT9120_REG_INTERNAL0, 0x69);
+       return 0;
+}
+
+static const struct snd_soc_component_driver rt9120_component_driver = {
+       .probe = rt9120_codec_probe,
+       .controls = rt9120_snd_controls,
+       .num_controls = ARRAY_SIZE(rt9120_snd_controls),
+       .dapm_widgets = rt9120_dapm_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(rt9120_dapm_widgets),
+       .dapm_routes = rt9120_dapm_routes,
+       .num_dapm_routes = ARRAY_SIZE(rt9120_dapm_routes),
+};
+
+static int rt9120_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+       struct snd_soc_component *comp = dai->component;
+       unsigned int format;
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_I2S:
+               format = RT9120_CFG_FMT_I2S;
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               format = RT9120_CFG_FMT_LEFTJ;
+               break;
+       case SND_SOC_DAIFMT_RIGHT_J:
+               format = RT9120_CFG_FMT_RIGHTJ;
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               format = RT9120_CFG_FMT_DSPA;
+               break;
+       case SND_SOC_DAIFMT_DSP_B:
+               format = RT9120_CFG_FMT_DSPB;
+               break;
+       default:
+               dev_err(dai->dev, "Unknown dai format\n");
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(comp, RT9120_REG_I2SFMT,
+                                     RT9120_I2SFMT_MASK,
+                                     format << RT9120_I2SFMT_SHIFT);
+       return 0;
+}
+
+static int rt9120_hw_params(struct snd_pcm_substream *substream,
+                           struct snd_pcm_hw_params *param,
+                           struct snd_soc_dai *dai)
+{
+       struct snd_soc_component *comp = dai->component;
+       unsigned int param_width, param_slot_width;
+       int width;
+
+       switch (width = params_width(param)) {
+       case 16:
+               param_width = RT9120_CFG_AUDBIT_16;
+               break;
+       case 20:
+               param_width = RT9120_CFG_AUDBIT_20;
+               break;
+       case 24:
+       case 32:
+               param_width = RT9120_CFG_AUDBIT_24;
+               break;
+       default:
+               dev_err(dai->dev, "Unsupported data width [%d]\n", width);
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(comp, RT9120_REG_I2SFMT,
+                                     RT9120_AUDBIT_MASK, param_width);
+
+       switch (width = params_physical_width(param)) {
+       case 16:
+               param_slot_width = RT9120_CFG_WORDLEN_16;
+               break;
+       case 24:
+               param_slot_width = RT9120_CFG_WORDLEN_24;
+               break;
+       case 32:
+               param_slot_width = RT9120_CFG_WORDLEN_32;
+               break;
+       default:
+               dev_err(dai->dev, "Unsupported slot width [%d]\n", width);
+               return -EINVAL;
+       }
+
+       snd_soc_component_update_bits(comp, RT9120_REG_I2SWL,
+                                     RT9120_AUDWL_MASK, param_slot_width);
+       return 0;
+}
+
+static const struct snd_soc_dai_ops rt9120_dai_ops = {
+       .set_fmt = rt9120_set_fmt,
+       .hw_params = rt9120_hw_params,
+};
+
+static struct snd_soc_dai_driver rt9120_dai = {
+       .name = "rt9120_aif",
+       .playback = {
+               .stream_name = "AIF Playback",
+               .rates = RT9120_RATES_MASK,
+               .formats = RT9120_FMTS_MASK,
+               .rate_max = 192000,
+               .rate_min = 8000,
+               .channels_min = 1,
+               .channels_max = 2,
+       },
+       .capture = {
+               .stream_name = "AIF Capture",
+               .rates = RT9120_RATES_MASK,
+               .formats = RT9120_FMTS_MASK,
+               .rate_max = 192000,
+               .rate_min = 8000,
+               .channels_min = 1,
+               .channels_max = 2,
+       },
+       .ops = &rt9120_dai_ops,
+       .symmetric_rate = 1,
+       .symmetric_sample_bits = 1,
+};
+
+static const struct regmap_range rt9120_rd_yes_ranges[] = {
+       regmap_reg_range(0x00, 0x0C),
+       regmap_reg_range(0x10, 0x15),
+       regmap_reg_range(0x20, 0x27),
+       regmap_reg_range(0x30, 0x38),
+       regmap_reg_range(0x3A, 0x40),
+       regmap_reg_range(0x65, 0x65),
+       regmap_reg_range(0x69, 0x69),
+       regmap_reg_range(0x6C, 0x6C)
+};
+
+static const struct regmap_access_table rt9120_rd_table = {
+       .yes_ranges = rt9120_rd_yes_ranges,
+       .n_yes_ranges = ARRAY_SIZE(rt9120_rd_yes_ranges),
+};
+
+static const struct regmap_range rt9120_wr_yes_ranges[] = {
+       regmap_reg_range(0x00, 0x00),
+       regmap_reg_range(0x02, 0x0A),
+       regmap_reg_range(0x10, 0x15),
+       regmap_reg_range(0x20, 0x27),
+       regmap_reg_range(0x30, 0x38),
+       regmap_reg_range(0x3A, 0x3D),
+       regmap_reg_range(0x40, 0x40),
+       regmap_reg_range(0x65, 0x65),
+       regmap_reg_range(0x69, 0x69),
+       regmap_reg_range(0x6C, 0x6C)
+};
+
+static const struct regmap_access_table rt9120_wr_table = {
+       .yes_ranges = rt9120_wr_yes_ranges,
+       .n_yes_ranges = ARRAY_SIZE(rt9120_wr_yes_ranges),
+};
+
+static int rt9120_get_reg_size(unsigned int reg)
+{
+       switch (reg) {
+       case 0x00:
+       case 0x09:
+       case 0x20 ... 0x27:
+               return 2;
+       case 0x30 ... 0x3D:
+               return 3;
+       case 0x3E ... 0x3F:
+               return 4;
+       default:
+               return 1;
+       }
+}
+
+static int rt9120_reg_read(void *context, unsigned int reg, unsigned int *val)
+{
+       struct rt9120_data *data = context;
+       struct i2c_client *i2c = to_i2c_client(data->dev);
+       int size = rt9120_get_reg_size(reg);
+       u8 raw[4] = {0};
+       int ret;
+
+       ret = i2c_smbus_read_i2c_block_data(i2c, reg, size, raw);
+       if (ret < 0)
+               return ret;
+       else if (ret != size)
+               return -EIO;
+
+       switch (size) {
+       case 4:
+               *val = be32_to_cpup((__be32 *)raw);
+               break;
+       case 3:
+               *val = raw[0] << 16 | raw[1] << 8 | raw[0];
+               break;
+       case 2:
+               *val = be16_to_cpup((__be16 *)raw);
+               break;
+       default:
+               *val = raw[0];
+       }
+
+       return 0;
+}
+
+static int rt9120_reg_write(void *context, unsigned int reg, unsigned int val)
+{
+       struct rt9120_data *data = context;
+       struct i2c_client *i2c = to_i2c_client(data->dev);
+       int size = rt9120_get_reg_size(reg);
+       __be32 be32_val;
+       u8 *rawp = (u8 *)&be32_val;
+       int offs = 4 - size;
+
+       be32_val = cpu_to_be32(val);
+       return i2c_smbus_write_i2c_block_data(i2c, reg, size, rawp + offs);
+}
+
+static const struct regmap_config rt9120_regmap_config = {
+       .reg_bits = 8,
+       .val_bits = 32,
+       .max_register = RT9120_REG_UVPOPT,
+
+       .reg_read = rt9120_reg_read,
+       .reg_write = rt9120_reg_write,
+
+       .wr_table = &rt9120_wr_table,
+       .rd_table = &rt9120_rd_table,
+};
+
+static int rt9120_check_vendor_info(struct rt9120_data *data)
+{
+       unsigned int devid;
+       int ret;
+
+       ret = regmap_read(data->regmap, RT9120_REG_DEVID, &devid);
+       if (ret)
+               return ret;
+
+       if ((devid & RT9120_VID_MASK) != RT9120_VENDOR_ID) {
+               dev_err(data->dev, "DEVID not correct [0x%04x]\n", devid);
+               return -ENODEV;
+       }
+
+       return 0;
+}
+
+static int rt9120_do_register_reset(struct rt9120_data *data)
+{
+       int ret;
+
+       ret = regmap_write(data->regmap, RT9120_REG_SWRESET,
+                          RT9120_SWRST_MASK);
+       if (ret)
+               return ret;
+
+       msleep(RT9120_RESET_WAITMS);
+       return 0;
+}
+
+static int rt9120_probe(struct i2c_client *i2c)
+{
+       struct rt9120_data *data;
+       struct gpio_desc *pwdnn_gpio;
+       struct regulator *dvdd_supply;
+       int dvdd_supply_volt, ret;
+
+       data = devm_kzalloc(&i2c->dev, sizeof(*data), GFP_KERNEL);
+       if (!data)
+               return -ENOMEM;
+
+       data->dev = &i2c->dev;
+       i2c_set_clientdata(i2c, data);
+
+       pwdnn_gpio = devm_gpiod_get_optional(&i2c->dev, "pwdnn",
+                                            GPIOD_OUT_HIGH);
+       if (IS_ERR(pwdnn_gpio)) {
+               dev_err(&i2c->dev, "Failed to initialize 'pwdnn' gpio\n");
+               return PTR_ERR(pwdnn_gpio);
+       } else if (pwdnn_gpio) {
+               dev_dbg(&i2c->dev, "'pwdnn' from low to high, wait chip on\n");
+               msleep(RT9120_CHIPON_WAITMS);
+       }
+
+       data->regmap = devm_regmap_init(&i2c->dev, NULL, data,
+                                       &rt9120_regmap_config);
+       if (IS_ERR(data->regmap)) {
+               ret = PTR_ERR(data->regmap);
+               dev_err(&i2c->dev, "Failed to init regmap [%d]\n", ret);
+               return ret;
+       }
+
+       ret = rt9120_check_vendor_info(data);
+       if (ret) {
+               dev_err(&i2c->dev, "Failed to check vendor info\n");
+               return ret;
+       }
+
+       ret = rt9120_do_register_reset(data);
+       if (ret) {
+               dev_err(&i2c->dev, "Failed to do register reset\n");
+               return ret;
+       }
+
+       dvdd_supply = devm_regulator_get(&i2c->dev, "dvdd");
+       if (IS_ERR(dvdd_supply)) {
+               dev_err(&i2c->dev, "No dvdd regulator found\n");
+               return PTR_ERR(dvdd_supply);
+       }
+
+       dvdd_supply_volt = regulator_get_voltage(dvdd_supply);
+       if (dvdd_supply_volt <= RT9120_LVAPP_THRESUV) {
+               dev_dbg(&i2c->dev, "dvdd low voltage design\n");
+               ret = regmap_update_bits(data->regmap, RT9120_REG_UVPOPT,
+                                        RT9120_DVDD_UVSEL_MASK, 0);
+               if (ret) {
+                       dev_err(&i2c->dev, "Failed to config dvdd uvsel\n");
+                       return ret;
+               }
+       }
+
+       return devm_snd_soc_register_component(&i2c->dev,
+                                              &rt9120_component_driver,
+                                              &rt9120_dai, 1);
+}
+
+static const struct of_device_id __maybe_unused rt9120_device_table[] = {
+       { .compatible = "richtek,rt9120", },
+       { }
+};
+MODULE_DEVICE_TABLE(of, rt9120_device_table);
+
+static struct i2c_driver rt9120_driver = {
+       .driver = {
+               .name = "rt9120",
+               .of_match_table = rt9120_device_table,
+       },
+       .probe_new = rt9120_probe,
+};
+module_i2c_driver(rt9120_driver);
+
+MODULE_AUTHOR("ChiYuan Huang <cy_huang@richtek.com>");
+MODULE_DESCRIPTION("RT9120 Audio Amplifier Driver");
+MODULE_LICENSE("GPL");
index 643b451..eb2a787 100644 (file)
@@ -19,6 +19,7 @@
 #define TFA989X_REVISIONNUMBER         0x03
 #define TFA989X_REVISIONNUMBER_REV_MSK GENMASK(7, 0)   /* device revision */
 #define TFA989X_I2SREG                 0x04
+#define TFA989X_I2SREG_RCV             2       /* receiver mode */
 #define TFA989X_I2SREG_CHSA            6       /* amplifier input select */
 #define TFA989X_I2SREG_CHSA_MSK                GENMASK(7, 6)
 #define TFA989X_I2SREG_I2SSR           12      /* sample rate */
@@ -53,6 +54,7 @@ struct tfa989x_rev {
 };
 
 struct tfa989x {
+       const struct tfa989x_rev *rev;
        struct regulator *vddd_supply;
 };
 
@@ -97,7 +99,25 @@ static const struct snd_soc_dapm_route tfa989x_dapm_routes[] = {
        {"Amp Input", "Right", "AIFINR"},
 };
 
+static const char * const mode_text[] = { "Speaker", "Receiver" };
+static SOC_ENUM_SINGLE_DECL(mode_enum, TFA989X_I2SREG, TFA989X_I2SREG_RCV, mode_text);
+static const struct snd_kcontrol_new tfa989x_mode_controls[] = {
+       SOC_ENUM("Mode", mode_enum),
+};
+
+static int tfa989x_probe(struct snd_soc_component *component)
+{
+       struct tfa989x *tfa989x = snd_soc_component_get_drvdata(component);
+
+       if (tfa989x->rev->rev == TFA9897_REVISION)
+               return snd_soc_add_component_controls(component, tfa989x_mode_controls,
+                                                     ARRAY_SIZE(tfa989x_mode_controls));
+
+       return 0;
+}
+
 static const struct snd_soc_component_driver tfa989x_component = {
+       .probe                  = tfa989x_probe,
        .dapm_widgets           = tfa989x_dapm_widgets,
        .num_dapm_widgets       = ARRAY_SIZE(tfa989x_dapm_widgets),
        .dapm_routes            = tfa989x_dapm_routes,
@@ -273,6 +293,7 @@ static int tfa989x_i2c_probe(struct i2c_client *i2c)
        if (!tfa989x)
                return -ENOMEM;
 
+       tfa989x->rev = rev;
        i2c_set_clientdata(i2c, tfa989x);
 
        tfa989x->vddd_supply = devm_regulator_get(dev, "vddd");
index 04ad383..ed70e3d 100644 (file)
@@ -44,7 +44,9 @@ static int aic32x4_i2c_probe(struct i2c_client *i2c,
 
 static int aic32x4_i2c_remove(struct i2c_client *i2c)
 {
-       return aic32x4_remove(&i2c->dev);
+       aic32x4_remove(&i2c->dev);
+
+       return 0;
 }
 
 static const struct i2c_device_id aic32x4_i2c_id[] = {
index e81c729..a8958cd 100644 (file)
@@ -48,7 +48,9 @@ static int aic32x4_spi_probe(struct spi_device *spi)
 
 static int aic32x4_spi_remove(struct spi_device *spi)
 {
-       return aic32x4_remove(&spi->dev);
+       aic32x4_remove(&spi->dev);
+
+       return 0;
 }
 
 static const struct spi_device_id aic32x4_spi_id[] = {
index d39c7d5..8f42fd7 100644 (file)
@@ -1418,13 +1418,11 @@ err_disable_regulators:
 }
 EXPORT_SYMBOL(aic32x4_probe);
 
-int aic32x4_remove(struct device *dev)
+void aic32x4_remove(struct device *dev)
 {
        struct aic32x4_priv *aic32x4 = dev_get_drvdata(dev);
 
        aic32x4_disable_regulators(aic32x4);
-
-       return 0;
 }
 EXPORT_SYMBOL(aic32x4_remove);
 
index e9fd2e5..4de5bd9 100644 (file)
@@ -18,7 +18,7 @@ enum aic32x4_type {
 
 extern const struct regmap_config aic32x4_regmap_config;
 int aic32x4_probe(struct device *dev, struct regmap *regmap);
-int aic32x4_remove(struct device *dev);
+void aic32x4_remove(struct device *dev);
 int aic32x4_register_clocks(struct device *dev, const char *mclk_name);
 
 /* tlv320aic32x4 register space (in decimal to match datasheet) */
index cd0558e..2f272bc 100644 (file)
@@ -32,7 +32,9 @@ static int aic3x_i2c_probe(struct i2c_client *i2c, const struct i2c_device_id *i
 
 static int aic3x_i2c_remove(struct i2c_client *i2c)
 {
-       return aic3x_remove(&i2c->dev);
+       aic3x_remove(&i2c->dev);
+
+       return 0;
 }
 
 static const struct i2c_device_id aic3x_i2c_id[] = {
index 8c7b6bb..494e844 100644 (file)
@@ -37,7 +37,9 @@ static int aic3x_spi_probe(struct spi_device *spi)
 
 static int aic3x_spi_remove(struct spi_device *spi)
 {
-       return aic3x_remove(&spi->dev);
+       aic3x_remove(&spi->dev);
+
+       return 0;
 }
 
 static const struct spi_device_id aic3x_spi_id[] = {
index 7731593..d53037b 100644 (file)
@@ -1870,7 +1870,7 @@ err:
 }
 EXPORT_SYMBOL(aic3x_probe);
 
-int aic3x_remove(struct device *dev)
+void aic3x_remove(struct device *dev)
 {
        struct aic3x_priv *aic3x = dev_get_drvdata(dev);
 
@@ -1881,7 +1881,6 @@ int aic3x_remove(struct device *dev)
                gpio_set_value(aic3x->gpio_reset, 0);
                gpio_free(aic3x->gpio_reset);
        }
-       return 0;
 }
 EXPORT_SYMBOL(aic3x_remove);
 
index 7e00639..14298f9 100644 (file)
@@ -14,7 +14,7 @@ struct regmap_config;
 
 extern const struct regmap_config aic3x_regmap;
 int aic3x_probe(struct device *dev, struct regmap *regmap, kernel_ulong_t driver_data);
-int aic3x_remove(struct device *dev);
+void aic3x_remove(struct device *dev);
 
 #define AIC3X_MODEL_3X 0
 #define AIC3X_MODEL_33 1
index d885ced..bc5d68c 100644 (file)
@@ -4859,7 +4859,7 @@ static int wcd9335_codec_probe(struct snd_soc_component *component)
 
        snd_soc_component_init_regmap(component, wcd->regmap);
        /* Class-H Init*/
-       wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, wcd->version);
+       wcd->clsh_ctrl = wcd_clsh_ctrl_alloc(component, WCD9335);
        if (IS_ERR(wcd->clsh_ctrl))
                return PTR_ERR(wcd->clsh_ctrl);
 
index c35673e..8863b53 100644 (file)
@@ -145,13 +145,13 @@ static const struct regmap_range_cfg wm2200_ranges[] = {
          .window_start = WM2200_DSP2_ZM_0, .window_len = 1024, },
 };
 
-static const struct wm_adsp_region wm2200_dsp1_regions[] = {
+static const struct cs_dsp_region wm2200_dsp1_regions[] = {
        { .type = WMFW_ADSP1_PM, .base = WM2200_DSP1_PM_BASE },
        { .type = WMFW_ADSP1_DM, .base = WM2200_DSP1_DM_BASE },
        { .type = WMFW_ADSP1_ZM, .base = WM2200_DSP1_ZM_BASE },
 };
 
-static const struct wm_adsp_region wm2200_dsp2_regions[] = {
+static const struct cs_dsp_region wm2200_dsp2_regions[] = {
        { .type = WMFW_ADSP1_PM, .base = WM2200_DSP2_PM_BASE },
        { .type = WMFW_ADSP1_DM, .base = WM2200_DSP2_DM_BASE },
        { .type = WMFW_ADSP1_ZM, .base = WM2200_DSP2_ZM_BASE },
@@ -2202,23 +2202,23 @@ static int wm2200_i2c_probe(struct i2c_client *i2c,
        }
 
        for (i = 0; i < 2; i++) {
-               wm2200->dsp[i].type = WMFW_ADSP1;
+               wm2200->dsp[i].cs_dsp.type = WMFW_ADSP1;
                wm2200->dsp[i].part = "wm2200";
-               wm2200->dsp[i].num = i + 1;
-               wm2200->dsp[i].dev = &i2c->dev;
-               wm2200->dsp[i].regmap = wm2200->regmap;
-               wm2200->dsp[i].sysclk_reg = WM2200_CLOCKING_3;
-               wm2200->dsp[i].sysclk_mask = WM2200_SYSCLK_FREQ_MASK;
-               wm2200->dsp[i].sysclk_shift =  WM2200_SYSCLK_FREQ_SHIFT;
+               wm2200->dsp[i].cs_dsp.num = i + 1;
+               wm2200->dsp[i].cs_dsp.dev = &i2c->dev;
+               wm2200->dsp[i].cs_dsp.regmap = wm2200->regmap;
+               wm2200->dsp[i].cs_dsp.sysclk_reg = WM2200_CLOCKING_3;
+               wm2200->dsp[i].cs_dsp.sysclk_mask = WM2200_SYSCLK_FREQ_MASK;
+               wm2200->dsp[i].cs_dsp.sysclk_shift =  WM2200_SYSCLK_FREQ_SHIFT;
        }
 
-       wm2200->dsp[0].base = WM2200_DSP1_CONTROL_1;
-       wm2200->dsp[0].mem = wm2200_dsp1_regions;
-       wm2200->dsp[0].num_mems = ARRAY_SIZE(wm2200_dsp1_regions);
+       wm2200->dsp[0].cs_dsp.base = WM2200_DSP1_CONTROL_1;
+       wm2200->dsp[0].cs_dsp.mem = wm2200_dsp1_regions;
+       wm2200->dsp[0].cs_dsp.num_mems = ARRAY_SIZE(wm2200_dsp1_regions);
 
-       wm2200->dsp[1].base = WM2200_DSP2_CONTROL_1;
-       wm2200->dsp[1].mem = wm2200_dsp2_regions;
-       wm2200->dsp[1].num_mems = ARRAY_SIZE(wm2200_dsp2_regions);
+       wm2200->dsp[1].cs_dsp.base = WM2200_DSP2_CONTROL_1;
+       wm2200->dsp[1].cs_dsp.mem = wm2200_dsp2_regions;
+       wm2200->dsp[1].cs_dsp.num_mems = ARRAY_SIZE(wm2200_dsp2_regions);
 
        for (i = 0; i < ARRAY_SIZE(wm2200->dsp); i++)
                wm_adsp1_init(&wm2200->dsp[i]);
index 6215986..da2f899 100644 (file)
@@ -44,7 +44,7 @@ static DECLARE_TLV_DB_SCALE(digital_tlv, -6400, 50, 0);
 static DECLARE_TLV_DB_SCALE(noise_tlv, -13200, 600, 0);
 static DECLARE_TLV_DB_SCALE(ng_tlv, -10200, 600, 0);
 
-static const struct wm_adsp_region wm5102_dsp1_regions[] = {
+static const struct cs_dsp_region wm5102_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x100000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x180000 },
        { .type = WMFW_ADSP2_XM, .base = 0x190000 },
@@ -2046,13 +2046,13 @@ static int wm5102_probe(struct platform_device *pdev)
        arizona_init_dvfs(&wm5102->core);
 
        wm5102->core.adsp[0].part = "wm5102";
-       wm5102->core.adsp[0].num = 1;
-       wm5102->core.adsp[0].type = WMFW_ADSP2;
-       wm5102->core.adsp[0].base = ARIZONA_DSP1_CONTROL_1;
-       wm5102->core.adsp[0].dev = arizona->dev;
-       wm5102->core.adsp[0].regmap = arizona->regmap;
-       wm5102->core.adsp[0].mem = wm5102_dsp1_regions;
-       wm5102->core.adsp[0].num_mems = ARRAY_SIZE(wm5102_dsp1_regions);
+       wm5102->core.adsp[0].cs_dsp.num = 1;
+       wm5102->core.adsp[0].cs_dsp.type = WMFW_ADSP2;
+       wm5102->core.adsp[0].cs_dsp.base = ARIZONA_DSP1_CONTROL_1;
+       wm5102->core.adsp[0].cs_dsp.dev = arizona->dev;
+       wm5102->core.adsp[0].cs_dsp.regmap = arizona->regmap;
+       wm5102->core.adsp[0].cs_dsp.mem = wm5102_dsp1_regions;
+       wm5102->core.adsp[0].cs_dsp.num_mems = ARRAY_SIZE(wm5102_dsp1_regions);
 
        ret = wm_adsp2_init(&wm5102->core.adsp[0]);
        if (ret != 0)
index 5c2d45d..4973ba1 100644 (file)
@@ -45,35 +45,35 @@ struct wm5110_priv {
        unsigned int in_pga_cache[6];
 };
 
-static const struct wm_adsp_region wm5110_dsp1_regions[] = {
+static const struct cs_dsp_region wm5110_dsp1_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x100000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x180000 },
        { .type = WMFW_ADSP2_XM, .base = 0x190000 },
        { .type = WMFW_ADSP2_YM, .base = 0x1a8000 },
 };
 
-static const struct wm_adsp_region wm5110_dsp2_regions[] = {
+static const struct cs_dsp_region wm5110_dsp2_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x200000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x280000 },
        { .type = WMFW_ADSP2_XM, .base = 0x290000 },
        { .type = WMFW_ADSP2_YM, .base = 0x2a8000 },
 };
 
-static const struct wm_adsp_region wm5110_dsp3_regions[] = {
+static const struct cs_dsp_region wm5110_dsp3_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x300000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x380000 },
        { .type = WMFW_ADSP2_XM, .base = 0x390000 },
        { .type = WMFW_ADSP2_YM, .base = 0x3a8000 },
 };
 
-static const struct wm_adsp_region wm5110_dsp4_regions[] = {
+static const struct cs_dsp_region wm5110_dsp4_regions[] = {
        { .type = WMFW_ADSP2_PM, .base = 0x400000 },
        { .type = WMFW_ADSP2_ZM, .base = 0x480000 },
        { .type = WMFW_ADSP2_XM, .base = 0x490000 },
        { .type = WMFW_ADSP2_YM, .base = 0x4a8000 },
 };
 
-static const struct wm_adsp_region *wm5110_dsp_regions[] = {
+static const struct cs_dsp_region *wm5110_dsp_regions[] = {
        wm5110_dsp1_regions,
        wm5110_dsp2_regions,
        wm5110_dsp3_regions,
@@ -2409,15 +2409,15 @@ static int wm5110_probe(struct platform_device *pdev)
 
        for (i = 0; i < WM5110_NUM_ADSP; i++) {
                wm5110->core.adsp[i].part = "wm5110";
-               wm5110->core.adsp[i].num = i + 1;
-               wm5110->core.adsp[i].type = WMFW_ADSP2;
-               wm5110->core.adsp[i].dev = arizona->dev;
-               wm5110->core.adsp[i].regmap = arizona->regmap;
+               wm5110->core.adsp[i].cs_dsp.num = i + 1;
+               wm5110->core.adsp[i].cs_dsp.type = WMFW_ADSP2;
+               wm5110->core.adsp[i].cs_dsp.dev = arizona->dev;
+               wm5110->core.adsp[i].cs_dsp.regmap = arizona->regmap;
 
-               wm5110->core.adsp[i].base = ARIZONA_DSP1_CONTROL_1
+               wm5110->core.adsp[i].cs_dsp.base = ARIZONA_DSP1_CONTROL_1
                        + (0x100 * i);
-               wm5110->core.adsp[i].mem = wm5110_dsp_regions[i];
-               wm5110->core.adsp[i].num_mems
+               wm5110->core.adsp[i].cs_dsp.mem = wm5110_dsp_regions[i];
+               wm5110->core.adsp[i].cs_dsp.num_mems
                        = ARRAY_SIZE(wm5110_dsp1_regions);
 
                ret = wm_adsp2_init(&wm5110->core.adsp[i]);
index dcee7b2..86b1f6e 100644 (file)
@@ -713,18 +713,12 @@ static int wm8731_spi_probe(struct spi_device *spi)
        return 0;
 }
 
-static int wm8731_spi_remove(struct spi_device *spi)
-{
-       return 0;
-}
-
 static struct spi_driver wm8731_spi_driver = {
        .driver = {
                .name   = "wm8731",
                .of_match_table = wm8731_of_match,
        },
        .probe          = wm8731_spi_probe,
-       .remove         = wm8731_spi_remove,
 };
 #endif /* CONFIG_SPI_MASTER */
 
index a9a6d76..bf3a441 100644 (file)
@@ -1252,17 +1252,11 @@ static int wm8900_spi_probe(struct spi_device *spi)
        return ret;
 }
 
-static int wm8900_spi_remove(struct spi_device *spi)
-{
-       return 0;
-}
-
 static struct spi_driver wm8900_spi_driver = {
        .driver = {
                .name   = "wm8900",
        },
        .probe          = wm8900_spi_probe,
-       .remove         = wm8900_spi_remove,
 };
 #endif /* CONFIG_SPI_MASTER */
 
index ba16bdf..a5584ba 100644 (file)
@@ -3538,9 +3538,8 @@ static int wm8962_set_pdata_from_of(struct i2c_client *i2c,
                                pdata->gpio_init[i] = 0x0;
                }
 
-       pdata->mclk = devm_clk_get(&i2c->dev, NULL);
-
-       return 0;
+       pdata->mclk = devm_clk_get_optional(&i2c->dev, NULL);
+       return PTR_ERR_OR_ZERO(pdata->mclk);
 }
 
 static int wm8962_i2c_probe(struct i2c_client *i2c,
@@ -3572,14 +3571,6 @@ static int wm8962_i2c_probe(struct i2c_client *i2c,
                        return ret;
        }
 
-       /* Mark the mclk pointer to NULL if no mclk assigned */
-       if (IS_ERR(wm8962->pdata.mclk)) {
-               /* But do not ignore the request for probe defer */
-               if (PTR_ERR(wm8962->pdata.mclk) == -EPROBE_DEFER)
-                       return -EPROBE_DEFER;
-               wm8962->pdata.mclk = NULL;
-       }
-
        for (i = 0; i < ARRAY_SIZE(wm8962->supplies); i++)
                wm8962->supplies[i].supply = wm8962_supply_names[i];
 
index f7c8009..d4f0d72 100644 (file)
@@ -19,7 +19,6 @@
 #include <linux/regmap.h>
 #include <linux/regulator/consumer.h>
 #include <linux/slab.h>
-#include <linux/vmalloc.h>
 #include <linux/workqueue.h>
 #include <linux/debugfs.h>
 #include <sound/core.h>
 #include "wm_adsp.h"
 
 #define adsp_crit(_dsp, fmt, ...) \
-       dev_crit(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+       dev_crit(_dsp->cs_dsp.dev, "%s: " fmt, _dsp->cs_dsp.name, ##__VA_ARGS__)
 #define adsp_err(_dsp, fmt, ...) \
-       dev_err(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+       dev_err(_dsp->cs_dsp.dev, "%s: " fmt, _dsp->cs_dsp.name, ##__VA_ARGS__)
 #define adsp_warn(_dsp, fmt, ...) \
-       dev_warn(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+       dev_warn(_dsp->cs_dsp.dev, "%s: " fmt, _dsp->cs_dsp.name, ##__VA_ARGS__)
 #define adsp_info(_dsp, fmt, ...) \
-       dev_info(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+       dev_info(_dsp->cs_dsp.dev, "%s: " fmt, _dsp->cs_dsp.name, ##__VA_ARGS__)
 #define adsp_dbg(_dsp, fmt, ...) \
-       dev_dbg(_dsp->dev, "%s: " fmt, _dsp->name, ##__VA_ARGS__)
+       dev_dbg(_dsp->cs_dsp.dev, "%s: " fmt, _dsp->cs_dsp.name, ##__VA_ARGS__)
 
 #define compr_err(_obj, fmt, ...) \
        adsp_err(_obj->dsp, "%s: " fmt, _obj->name ? _obj->name : "legacy", \
        adsp_dbg(_obj->dsp, "%s: " fmt, _obj->name ? _obj->name : "legacy", \
                 ##__VA_ARGS__)
 
-#define ADSP1_CONTROL_1                   0x00
-#define ADSP1_CONTROL_2                   0x02
-#define ADSP1_CONTROL_3                   0x03
-#define ADSP1_CONTROL_4                   0x04
-#define ADSP1_CONTROL_5                   0x06
-#define ADSP1_CONTROL_6                   0x07
-#define ADSP1_CONTROL_7                   0x08
-#define ADSP1_CONTROL_8                   0x09
-#define ADSP1_CONTROL_9                   0x0A
-#define ADSP1_CONTROL_10                  0x0B
-#define ADSP1_CONTROL_11                  0x0C
-#define ADSP1_CONTROL_12                  0x0D
-#define ADSP1_CONTROL_13                  0x0F
-#define ADSP1_CONTROL_14                  0x10
-#define ADSP1_CONTROL_15                  0x11
-#define ADSP1_CONTROL_16                  0x12
-#define ADSP1_CONTROL_17                  0x13
-#define ADSP1_CONTROL_18                  0x14
-#define ADSP1_CONTROL_19                  0x16
-#define ADSP1_CONTROL_20                  0x17
-#define ADSP1_CONTROL_21                  0x18
-#define ADSP1_CONTROL_22                  0x1A
-#define ADSP1_CONTROL_23                  0x1B
-#define ADSP1_CONTROL_24                  0x1C
-#define ADSP1_CONTROL_25                  0x1E
-#define ADSP1_CONTROL_26                  0x20
-#define ADSP1_CONTROL_27                  0x21
-#define ADSP1_CONTROL_28                  0x22
-#define ADSP1_CONTROL_29                  0x23
-#define ADSP1_CONTROL_30                  0x24
-#define ADSP1_CONTROL_31                  0x26
-
-/*
- * ADSP1 Control 19
- */
-#define ADSP1_WDMA_BUFFER_LENGTH_MASK     0x00FF  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
-#define ADSP1_WDMA_BUFFER_LENGTH_SHIFT         0  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
-#define ADSP1_WDMA_BUFFER_LENGTH_WIDTH         8  /* DSP1_WDMA_BUFFER_LENGTH - [7:0] */
-
-
-/*
- * ADSP1 Control 30
- */
-#define ADSP1_DBG_CLK_ENA                 0x0008  /* DSP1_DBG_CLK_ENA */
-#define ADSP1_DBG_CLK_ENA_MASK            0x0008  /* DSP1_DBG_CLK_ENA */
-#define ADSP1_DBG_CLK_ENA_SHIFT                3  /* DSP1_DBG_CLK_ENA */
-#define ADSP1_DBG_CLK_ENA_WIDTH                1  /* DSP1_DBG_CLK_ENA */
-#define ADSP1_SYS_ENA                     0x0004  /* DSP1_SYS_ENA */
-#define ADSP1_SYS_ENA_MASK                0x0004  /* DSP1_SYS_ENA */
-#define ADSP1_SYS_ENA_SHIFT                    2  /* DSP1_SYS_ENA */
-#define ADSP1_SYS_ENA_WIDTH                    1  /* DSP1_SYS_ENA */
-#define ADSP1_CORE_ENA                    0x0002  /* DSP1_CORE_ENA */
-#define ADSP1_CORE_ENA_MASK               0x0002  /* DSP1_CORE_ENA */
-#define ADSP1_CORE_ENA_SHIFT                   1  /* DSP1_CORE_ENA */
-#define ADSP1_CORE_ENA_WIDTH                   1  /* DSP1_CORE_ENA */
-#define ADSP1_START                       0x0001  /* DSP1_START */
-#define ADSP1_START_MASK                  0x0001  /* DSP1_START */
-#define ADSP1_START_SHIFT                      0  /* DSP1_START */
-#define ADSP1_START_WIDTH                      1  /* DSP1_START */
-
-/*
- * ADSP1 Control 31
- */
-#define ADSP1_CLK_SEL_MASK                0x0007  /* CLK_SEL_ENA */
-#define ADSP1_CLK_SEL_SHIFT                    0  /* CLK_SEL_ENA */
-#define ADSP1_CLK_SEL_WIDTH                    3  /* CLK_SEL_ENA */
-
-#define ADSP2_CONTROL                     0x0
-#define ADSP2_CLOCKING                    0x1
-#define ADSP2V2_CLOCKING                  0x2
-#define ADSP2_STATUS1                     0x4
-#define ADSP2_WDMA_CONFIG_1               0x30
-#define ADSP2_WDMA_CONFIG_2               0x31
-#define ADSP2V2_WDMA_CONFIG_2             0x32
-#define ADSP2_RDMA_CONFIG_1               0x34
-
-#define ADSP2_SCRATCH0                    0x40
-#define ADSP2_SCRATCH1                    0x41
-#define ADSP2_SCRATCH2                    0x42
-#define ADSP2_SCRATCH3                    0x43
-
-#define ADSP2V2_SCRATCH0_1                0x40
-#define ADSP2V2_SCRATCH2_3                0x42
-
-/*
- * ADSP2 Control
- */
-
-#define ADSP2_MEM_ENA                     0x0010  /* DSP1_MEM_ENA */
-#define ADSP2_MEM_ENA_MASK                0x0010  /* DSP1_MEM_ENA */
-#define ADSP2_MEM_ENA_SHIFT                    4  /* DSP1_MEM_ENA */
-#define ADSP2_MEM_ENA_WIDTH                    1  /* DSP1_MEM_ENA */
-#define ADSP2_SYS_ENA                     0x0004  /* DSP1_SYS_ENA */
-#define ADSP2_SYS_ENA_MASK                0x0004  /* DSP1_SYS_ENA */
-#define ADSP2_SYS_ENA_SHIFT                    2  /* DSP1_SYS_ENA */
-#define ADSP2_SYS_ENA_WIDTH                    1  /* DSP1_SYS_ENA */
-#define ADSP2_CORE_ENA                    0x0002  /* DSP1_CORE_ENA */
-#define ADSP2_CORE_ENA_MASK               0x0002  /* DSP1_CORE_ENA */
-#define ADSP2_CORE_ENA_SHIFT                   1  /* DSP1_CORE_ENA */
-#define ADSP2_CORE_ENA_WIDTH                   1  /* DSP1_CORE_ENA */
-#define ADSP2_START                       0x0001  /* DSP1_START */
-#define ADSP2_START_MASK                  0x0001  /* DSP1_START */
-#define ADSP2_START_SHIFT                      0  /* DSP1_START */
-#define ADSP2_START_WIDTH                      1  /* DSP1_START */
-
-/*
- * ADSP2 clocking
- */
-#define ADSP2_CLK_SEL_MASK                0x0007  /* CLK_SEL_ENA */
-#define ADSP2_CLK_SEL_SHIFT                    0  /* CLK_SEL_ENA */
-#define ADSP2_CLK_SEL_WIDTH                    3  /* CLK_SEL_ENA */
-
-/*
- * ADSP2V2 clocking
- */
-#define ADSP2V2_CLK_SEL_MASK             0x70000  /* CLK_SEL_ENA */
-#define ADSP2V2_CLK_SEL_SHIFT                 16  /* CLK_SEL_ENA */
-#define ADSP2V2_CLK_SEL_WIDTH                  3  /* CLK_SEL_ENA */
-
-#define ADSP2V2_RATE_MASK                 0x7800  /* DSP_RATE */
-#define ADSP2V2_RATE_SHIFT                    11  /* DSP_RATE */
-#define ADSP2V2_RATE_WIDTH                     4  /* DSP_RATE */
-
-/*
- * ADSP2 Status 1
- */
-#define ADSP2_RAM_RDY                     0x0001
-#define ADSP2_RAM_RDY_MASK                0x0001
-#define ADSP2_RAM_RDY_SHIFT                    0
-#define ADSP2_RAM_RDY_WIDTH                    1
-
-/*
- * ADSP2 Lock support
- */
-#define ADSP2_LOCK_CODE_0                    0x5555
-#define ADSP2_LOCK_CODE_1                    0xAAAA
-
-#define ADSP2_WATCHDOG                       0x0A
-#define ADSP2_BUS_ERR_ADDR                   0x52
-#define ADSP2_REGION_LOCK_STATUS             0x64
-#define ADSP2_LOCK_REGION_1_LOCK_REGION_0    0x66
-#define ADSP2_LOCK_REGION_3_LOCK_REGION_2    0x68
-#define ADSP2_LOCK_REGION_5_LOCK_REGION_4    0x6A
-#define ADSP2_LOCK_REGION_7_LOCK_REGION_6    0x6C
-#define ADSP2_LOCK_REGION_9_LOCK_REGION_8    0x6E
-#define ADSP2_LOCK_REGION_CTRL               0x7A
-#define ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR    0x7C
-
-#define ADSP2_REGION_LOCK_ERR_MASK           0x8000
-#define ADSP2_ADDR_ERR_MASK                  0x4000
-#define ADSP2_WDT_TIMEOUT_STS_MASK           0x2000
-#define ADSP2_CTRL_ERR_PAUSE_ENA             0x0002
-#define ADSP2_CTRL_ERR_EINT                  0x0001
-
-#define ADSP2_BUS_ERR_ADDR_MASK              0x00FFFFFF
-#define ADSP2_XMEM_ERR_ADDR_MASK             0x0000FFFF
-#define ADSP2_PMEM_ERR_ADDR_MASK             0x7FFF0000
-#define ADSP2_PMEM_ERR_ADDR_SHIFT            16
-#define ADSP2_WDT_ENA_MASK                   0xFFFFFFFD
-
-#define ADSP2_LOCK_REGION_SHIFT              16
-
 #define ADSP_MAX_STD_CTRL_SIZE               512
 
-#define WM_ADSP_ACKED_CTL_TIMEOUT_MS         100
-#define WM_ADSP_ACKED_CTL_N_QUICKPOLLS       10
-#define WM_ADSP_ACKED_CTL_MIN_VALUE          0
-#define WM_ADSP_ACKED_CTL_MAX_VALUE          0xFFFFFF
-
-/*
- * Event control messages
- */
-#define WM_ADSP_FW_EVENT_SHUTDOWN            0x000001
-
-/*
- * HALO system info
- */
-#define HALO_AHBM_WINDOW_DEBUG_0             0x02040
-#define HALO_AHBM_WINDOW_DEBUG_1             0x02044
-
-/*
- * HALO core
- */
-#define HALO_SCRATCH1                        0x005c0
-#define HALO_SCRATCH2                        0x005c8
-#define HALO_SCRATCH3                        0x005d0
-#define HALO_SCRATCH4                        0x005d8
-#define HALO_CCM_CORE_CONTROL                0x41000
-#define HALO_CORE_SOFT_RESET                 0x00010
-#define HALO_WDT_CONTROL                     0x47000
-
-/*
- * HALO MPU banks
- */
-#define HALO_MPU_XMEM_ACCESS_0               0x43000
-#define HALO_MPU_YMEM_ACCESS_0               0x43004
-#define HALO_MPU_WINDOW_ACCESS_0             0x43008
-#define HALO_MPU_XREG_ACCESS_0               0x4300C
-#define HALO_MPU_YREG_ACCESS_0               0x43014
-#define HALO_MPU_XMEM_ACCESS_1               0x43018
-#define HALO_MPU_YMEM_ACCESS_1               0x4301C
-#define HALO_MPU_WINDOW_ACCESS_1             0x43020
-#define HALO_MPU_XREG_ACCESS_1               0x43024
-#define HALO_MPU_YREG_ACCESS_1               0x4302C
-#define HALO_MPU_XMEM_ACCESS_2               0x43030
-#define HALO_MPU_YMEM_ACCESS_2               0x43034
-#define HALO_MPU_WINDOW_ACCESS_2             0x43038
-#define HALO_MPU_XREG_ACCESS_2               0x4303C
-#define HALO_MPU_YREG_ACCESS_2               0x43044
-#define HALO_MPU_XMEM_ACCESS_3               0x43048
-#define HALO_MPU_YMEM_ACCESS_3               0x4304C
-#define HALO_MPU_WINDOW_ACCESS_3             0x43050
-#define HALO_MPU_XREG_ACCESS_3               0x43054
-#define HALO_MPU_YREG_ACCESS_3               0x4305C
-#define HALO_MPU_XM_VIO_ADDR                 0x43100
-#define HALO_MPU_XM_VIO_STATUS               0x43104
-#define HALO_MPU_YM_VIO_ADDR                 0x43108
-#define HALO_MPU_YM_VIO_STATUS               0x4310C
-#define HALO_MPU_PM_VIO_ADDR                 0x43110
-#define HALO_MPU_PM_VIO_STATUS               0x43114
-#define HALO_MPU_LOCK_CONFIG                 0x43140
-
-/*
- * HALO_AHBM_WINDOW_DEBUG_1
- */
-#define HALO_AHBM_CORE_ERR_ADDR_MASK         0x0fffff00
-#define HALO_AHBM_CORE_ERR_ADDR_SHIFT                 8
-#define HALO_AHBM_FLAGS_ERR_MASK             0x000000ff
-
-/*
- * HALO_CCM_CORE_CONTROL
- */
-#define HALO_CORE_RESET                     0x00000200
-#define HALO_CORE_EN                        0x00000001
-
-/*
- * HALO_CORE_SOFT_RESET
- */
-#define HALO_CORE_SOFT_RESET_MASK           0x00000001
-
-/*
- * HALO_WDT_CONTROL
- */
-#define HALO_WDT_EN_MASK                    0x00000001
-
-/*
- * HALO_MPU_?M_VIO_STATUS
- */
-#define HALO_MPU_VIO_STS_MASK               0x007e0000
-#define HALO_MPU_VIO_STS_SHIFT                      17
-#define HALO_MPU_VIO_ERR_WR_MASK            0x00008000
-#define HALO_MPU_VIO_ERR_SRC_MASK           0x00007fff
-#define HALO_MPU_VIO_ERR_SRC_SHIFT                   0
-
-static const struct wm_adsp_ops wm_adsp1_ops;
-static const struct wm_adsp_ops wm_adsp2_ops[];
-static const struct wm_adsp_ops wm_halo_ops;
-
-struct wm_adsp_buf {
-       struct list_head list;
-       void *buf;
-};
-
-static struct wm_adsp_buf *wm_adsp_buf_alloc(const void *src, size_t len,
-                                            struct list_head *list)
-{
-       struct wm_adsp_buf *buf = kzalloc(sizeof(*buf), GFP_KERNEL);
-
-       if (buf == NULL)
-               return NULL;
-
-       buf->buf = vmalloc(len);
-       if (!buf->buf) {
-               kfree(buf);
-               return NULL;
-       }
-       memcpy(buf->buf, src, len);
-
-       if (list)
-               list_add_tail(&buf->list, list);
-
-       return buf;
-}
-
-static void wm_adsp_buf_free(struct list_head *list)
-{
-       while (!list_empty(list)) {
-               struct wm_adsp_buf *buf = list_first_entry(list,
-                                                          struct wm_adsp_buf,
-                                                          list);
-               list_del(&buf->list);
-               vfree(buf->buf);
-               kfree(buf);
-       }
-}
+static const struct cs_dsp_client_ops wm_adsp1_client_ops;
+static const struct cs_dsp_client_ops wm_adsp2_client_ops;
 
 #define WM_ADSP_FW_MBC_VSS  0
 #define WM_ADSP_FW_HIFI     1
@@ -470,12 +178,10 @@ struct wm_adsp_compr {
        const char *name;
 };
 
-#define WM_ADSP_DATA_WORD_SIZE         3
-
 #define WM_ADSP_MIN_FRAGMENTS          1
 #define WM_ADSP_MAX_FRAGMENTS          256
-#define WM_ADSP_MIN_FRAGMENT_SIZE      (64 * WM_ADSP_DATA_WORD_SIZE)
-#define WM_ADSP_MAX_FRAGMENT_SIZE      (4096 * WM_ADSP_DATA_WORD_SIZE)
+#define WM_ADSP_MIN_FRAGMENT_SIZE      (64 * CS_DSP_DATA_WORD_SIZE)
+#define WM_ADSP_MAX_FRAGMENT_SIZE      (4096 * CS_DSP_DATA_WORD_SIZE)
 
 #define WM_ADSP_ALG_XM_STRUCT_MAGIC    0x49aec7
 
@@ -598,183 +304,11 @@ static const struct {
 
 struct wm_coeff_ctl {
        const char *name;
-       const char *fw_name;
-       /* Subname is needed to match with firmware */
-       const char *subname;
-       unsigned int subname_len;
-       struct wm_adsp_alg_region alg_region;
-       struct wm_adsp *dsp;
-       unsigned int enabled:1;
-       struct list_head list;
-       void *cache;
-       unsigned int offset;
-       size_t len;
-       unsigned int set:1;
+       struct cs_dsp_coeff_ctl *cs_ctl;
        struct soc_bytes_ext bytes_ext;
-       unsigned int flags;
-       snd_ctl_elem_type_t type;
-};
-
-static const char *wm_adsp_mem_region_name(unsigned int type)
-{
-       switch (type) {
-       case WMFW_ADSP1_PM:
-               return "PM";
-       case WMFW_HALO_PM_PACKED:
-               return "PM_PACKED";
-       case WMFW_ADSP1_DM:
-               return "DM";
-       case WMFW_ADSP2_XM:
-               return "XM";
-       case WMFW_HALO_XM_PACKED:
-               return "XM_PACKED";
-       case WMFW_ADSP2_YM:
-               return "YM";
-       case WMFW_HALO_YM_PACKED:
-               return "YM_PACKED";
-       case WMFW_ADSP1_ZM:
-               return "ZM";
-       default:
-               return NULL;
-       }
-}
-
-#ifdef CONFIG_DEBUG_FS
-static void wm_adsp_debugfs_save_wmfwname(struct wm_adsp *dsp, const char *s)
-{
-       char *tmp = kasprintf(GFP_KERNEL, "%s\n", s);
-
-       kfree(dsp->wmfw_file_name);
-       dsp->wmfw_file_name = tmp;
-}
-
-static void wm_adsp_debugfs_save_binname(struct wm_adsp *dsp, const char *s)
-{
-       char *tmp = kasprintf(GFP_KERNEL, "%s\n", s);
-
-       kfree(dsp->bin_file_name);
-       dsp->bin_file_name = tmp;
-}
-
-static void wm_adsp_debugfs_clear(struct wm_adsp *dsp)
-{
-       kfree(dsp->wmfw_file_name);
-       kfree(dsp->bin_file_name);
-       dsp->wmfw_file_name = NULL;
-       dsp->bin_file_name = NULL;
-}
-
-static ssize_t wm_adsp_debugfs_wmfw_read(struct file *file,
-                                        char __user *user_buf,
-                                        size_t count, loff_t *ppos)
-{
-       struct wm_adsp *dsp = file->private_data;
-       ssize_t ret;
-
-       mutex_lock(&dsp->pwr_lock);
-
-       if (!dsp->wmfw_file_name || !dsp->booted)
-               ret = 0;
-       else
-               ret = simple_read_from_buffer(user_buf, count, ppos,
-                                             dsp->wmfw_file_name,
-                                             strlen(dsp->wmfw_file_name));
-
-       mutex_unlock(&dsp->pwr_lock);
-       return ret;
-}
-
-static ssize_t wm_adsp_debugfs_bin_read(struct file *file,
-                                       char __user *user_buf,
-                                       size_t count, loff_t *ppos)
-{
-       struct wm_adsp *dsp = file->private_data;
-       ssize_t ret;
-
-       mutex_lock(&dsp->pwr_lock);
-
-       if (!dsp->bin_file_name || !dsp->booted)
-               ret = 0;
-       else
-               ret = simple_read_from_buffer(user_buf, count, ppos,
-                                             dsp->bin_file_name,
-                                             strlen(dsp->bin_file_name));
-
-       mutex_unlock(&dsp->pwr_lock);
-       return ret;
-}
-
-static const struct {
-       const char *name;
-       const struct file_operations fops;
-} wm_adsp_debugfs_fops[] = {
-       {
-               .name = "wmfw_file_name",
-               .fops = {
-                       .open = simple_open,
-                       .read = wm_adsp_debugfs_wmfw_read,
-               },
-       },
-       {
-               .name = "bin_file_name",
-               .fops = {
-                       .open = simple_open,
-                       .read = wm_adsp_debugfs_bin_read,
-               },
-       },
+       struct work_struct work;
 };
 
-static void wm_adsp2_init_debugfs(struct wm_adsp *dsp,
-                                 struct snd_soc_component *component)
-{
-       struct dentry *root = NULL;
-       int i;
-
-       root = debugfs_create_dir(dsp->name, component->debugfs_root);
-
-       debugfs_create_bool("booted", 0444, root, &dsp->booted);
-       debugfs_create_bool("running", 0444, root, &dsp->running);
-       debugfs_create_x32("fw_id", 0444, root, &dsp->fw_id);
-       debugfs_create_x32("fw_version", 0444, root, &dsp->fw_id_version);
-
-       for (i = 0; i < ARRAY_SIZE(wm_adsp_debugfs_fops); ++i)
-               debugfs_create_file(wm_adsp_debugfs_fops[i].name, 0444, root,
-                                   dsp, &wm_adsp_debugfs_fops[i].fops);
-
-       dsp->debugfs_root = root;
-}
-
-static void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp)
-{
-       wm_adsp_debugfs_clear(dsp);
-       debugfs_remove_recursive(dsp->debugfs_root);
-       dsp->debugfs_root = NULL;
-}
-#else
-static inline void wm_adsp2_init_debugfs(struct wm_adsp *dsp,
-                                        struct snd_soc_component *component)
-{
-}
-
-static inline void wm_adsp2_cleanup_debugfs(struct wm_adsp *dsp)
-{
-}
-
-static inline void wm_adsp_debugfs_save_wmfwname(struct wm_adsp *dsp,
-                                                const char *s)
-{
-}
-
-static inline void wm_adsp_debugfs_save_binname(struct wm_adsp *dsp,
-                                               const char *s)
-{
-}
-
-static inline void wm_adsp_debugfs_clear(struct wm_adsp *dsp)
-{
-}
-#endif
-
 int wm_adsp_fw_get(struct snd_kcontrol *kcontrol,
                   struct snd_ctl_elem_value *ucontrol)
 {
@@ -802,14 +336,14 @@ int wm_adsp_fw_put(struct snd_kcontrol *kcontrol,
        if (ucontrol->value.enumerated.item[0] >= WM_ADSP_NUM_FW)
                return -EINVAL;
 
-       mutex_lock(&dsp[e->shift_l].pwr_lock);
+       mutex_lock(&dsp[e->shift_l].cs_dsp.pwr_lock);
 
-       if (dsp[e->shift_l].booted || !list_empty(&dsp[e->shift_l].compr_list))
+       if (dsp[e->shift_l].cs_dsp.booted || !list_empty(&dsp[e->shift_l].compr_list))
                ret = -EBUSY;
        else
                dsp[e->shift_l].fw = ucontrol->value.enumerated.item[0];
 
-       mutex_unlock(&dsp[e->shift_l].pwr_lock);
+       mutex_unlock(&dsp[e->shift_l].cs_dsp.pwr_lock);
 
        return ret;
 }
@@ -826,270 +360,49 @@ const struct soc_enum wm_adsp_fw_enum[] = {
 };
 EXPORT_SYMBOL_GPL(wm_adsp_fw_enum);
 
-static const struct wm_adsp_region *wm_adsp_find_region(struct wm_adsp *dsp,
-                                                       int type)
-{
-       int i;
-
-       for (i = 0; i < dsp->num_mems; i++)
-               if (dsp->mem[i].type == type)
-                       return &dsp->mem[i];
-
-       return NULL;
-}
-
-static unsigned int wm_adsp_region_to_reg(struct wm_adsp_region const *mem,
-                                         unsigned int offset)
-{
-       switch (mem->type) {
-       case WMFW_ADSP1_PM:
-               return mem->base + (offset * 3);
-       case WMFW_ADSP1_DM:
-       case WMFW_ADSP2_XM:
-       case WMFW_ADSP2_YM:
-       case WMFW_ADSP1_ZM:
-               return mem->base + (offset * 2);
-       default:
-               WARN(1, "Unknown memory region type");
-               return offset;
-       }
-}
-
-static unsigned int wm_halo_region_to_reg(struct wm_adsp_region const *mem,
-                                         unsigned int offset)
-{
-       switch (mem->type) {
-       case WMFW_ADSP2_XM:
-       case WMFW_ADSP2_YM:
-               return mem->base + (offset * 4);
-       case WMFW_HALO_XM_PACKED:
-       case WMFW_HALO_YM_PACKED:
-               return (mem->base + (offset * 3)) & ~0x3;
-       case WMFW_HALO_PM_PACKED:
-               return mem->base + (offset * 5);
-       default:
-               WARN(1, "Unknown memory region type");
-               return offset;
-       }
-}
-
-static void wm_adsp_read_fw_status(struct wm_adsp *dsp,
-                                  int noffs, unsigned int *offs)
-{
-       unsigned int i;
-       int ret;
-
-       for (i = 0; i < noffs; ++i) {
-               ret = regmap_read(dsp->regmap, dsp->base + offs[i], &offs[i]);
-               if (ret) {
-                       adsp_err(dsp, "Failed to read SCRATCH%u: %d\n", i, ret);
-                       return;
-               }
-       }
-}
-
-static void wm_adsp2_show_fw_status(struct wm_adsp *dsp)
-{
-       unsigned int offs[] = {
-               ADSP2_SCRATCH0, ADSP2_SCRATCH1, ADSP2_SCRATCH2, ADSP2_SCRATCH3,
-       };
-
-       wm_adsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
-
-       adsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
-                offs[0], offs[1], offs[2], offs[3]);
-}
-
-static void wm_adsp2v2_show_fw_status(struct wm_adsp *dsp)
-{
-       unsigned int offs[] = { ADSP2V2_SCRATCH0_1, ADSP2V2_SCRATCH2_3 };
-
-       wm_adsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
-
-       adsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
-                offs[0] & 0xFFFF, offs[0] >> 16,
-                offs[1] & 0xFFFF, offs[1] >> 16);
-}
-
-static void wm_halo_show_fw_status(struct wm_adsp *dsp)
-{
-       unsigned int offs[] = {
-               HALO_SCRATCH1, HALO_SCRATCH2, HALO_SCRATCH3, HALO_SCRATCH4,
-       };
-
-       wm_adsp_read_fw_status(dsp, ARRAY_SIZE(offs), offs);
-
-       adsp_dbg(dsp, "FW SCRATCH 0:0x%x 1:0x%x 2:0x%x 3:0x%x\n",
-                offs[0], offs[1], offs[2], offs[3]);
-}
-
 static inline struct wm_coeff_ctl *bytes_ext_to_ctl(struct soc_bytes_ext *ext)
 {
        return container_of(ext, struct wm_coeff_ctl, bytes_ext);
 }
 
-static int wm_coeff_base_reg(struct wm_coeff_ctl *ctl, unsigned int *reg)
-{
-       const struct wm_adsp_alg_region *alg_region = &ctl->alg_region;
-       struct wm_adsp *dsp = ctl->dsp;
-       const struct wm_adsp_region *mem;
-
-       mem = wm_adsp_find_region(dsp, alg_region->type);
-       if (!mem) {
-               adsp_err(dsp, "No base for region %x\n",
-                        alg_region->type);
-               return -EINVAL;
-       }
-
-       *reg = dsp->ops->region_to_reg(mem, ctl->alg_region.base + ctl->offset);
-
-       return 0;
-}
-
 static int wm_coeff_info(struct snd_kcontrol *kctl,
                         struct snd_ctl_elem_info *uinfo)
 {
        struct soc_bytes_ext *bytes_ext =
                (struct soc_bytes_ext *)kctl->private_value;
        struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
 
-       switch (ctl->type) {
+       switch (cs_ctl->type) {
        case WMFW_CTL_TYPE_ACKED:
                uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
-               uinfo->value.integer.min = WM_ADSP_ACKED_CTL_MIN_VALUE;
-               uinfo->value.integer.max = WM_ADSP_ACKED_CTL_MAX_VALUE;
+               uinfo->value.integer.min = CS_DSP_ACKED_CTL_MIN_VALUE;
+               uinfo->value.integer.max = CS_DSP_ACKED_CTL_MAX_VALUE;
                uinfo->value.integer.step = 1;
                uinfo->count = 1;
                break;
        default:
                uinfo->type = SNDRV_CTL_ELEM_TYPE_BYTES;
-               uinfo->count = ctl->len;
+               uinfo->count = cs_ctl->len;
                break;
        }
 
        return 0;
 }
 
-static int wm_coeff_write_acked_control(struct wm_coeff_ctl *ctl,
-                                       unsigned int event_id)
-{
-       struct wm_adsp *dsp = ctl->dsp;
-       __be32 val = cpu_to_be32(event_id);
-       unsigned int reg;
-       int i, ret;
-
-       ret = wm_coeff_base_reg(ctl, &reg);
-       if (ret)
-               return ret;
-
-       adsp_dbg(dsp, "Sending 0x%x to acked control alg 0x%x %s:0x%x\n",
-                event_id, ctl->alg_region.alg,
-                wm_adsp_mem_region_name(ctl->alg_region.type), ctl->offset);
-
-       ret = regmap_raw_write(dsp->regmap, reg, &val, sizeof(val));
-       if (ret) {
-               adsp_err(dsp, "Failed to write %x: %d\n", reg, ret);
-               return ret;
-       }
-
-       /*
-        * Poll for ack, we initially poll at ~1ms intervals for firmwares
-        * that respond quickly, then go to ~10ms polls. A firmware is unlikely
-        * to ack instantly so we do the first 1ms delay before reading the
-        * control to avoid a pointless bus transaction
-        */
-       for (i = 0; i < WM_ADSP_ACKED_CTL_TIMEOUT_MS;) {
-               switch (i) {
-               case 0 ... WM_ADSP_ACKED_CTL_N_QUICKPOLLS - 1:
-                       usleep_range(1000, 2000);
-                       i++;
-                       break;
-               default:
-                       usleep_range(10000, 20000);
-                       i += 10;
-                       break;
-               }
-
-               ret = regmap_raw_read(dsp->regmap, reg, &val, sizeof(val));
-               if (ret) {
-                       adsp_err(dsp, "Failed to read %x: %d\n", reg, ret);
-                       return ret;
-               }
-
-               if (val == 0) {
-                       adsp_dbg(dsp, "Acked control ACKED at poll %u\n", i);
-                       return 0;
-               }
-       }
-
-       adsp_warn(dsp, "Acked control @0x%x alg:0x%x %s:0x%x timed out\n",
-                 reg, ctl->alg_region.alg,
-                 wm_adsp_mem_region_name(ctl->alg_region.type),
-                 ctl->offset);
-
-       return -ETIMEDOUT;
-}
-
-static int wm_coeff_write_ctrl_raw(struct wm_coeff_ctl *ctl,
-                                  const void *buf, size_t len)
-{
-       struct wm_adsp *dsp = ctl->dsp;
-       void *scratch;
-       int ret;
-       unsigned int reg;
-
-       ret = wm_coeff_base_reg(ctl, &reg);
-       if (ret)
-               return ret;
-
-       scratch = kmemdup(buf, len, GFP_KERNEL | GFP_DMA);
-       if (!scratch)
-               return -ENOMEM;
-
-       ret = regmap_raw_write(dsp->regmap, reg, scratch,
-                              len);
-       if (ret) {
-               adsp_err(dsp, "Failed to write %zu bytes to %x: %d\n",
-                        len, reg, ret);
-               kfree(scratch);
-               return ret;
-       }
-       adsp_dbg(dsp, "Wrote %zu bytes to %x\n", len, reg);
-
-       kfree(scratch);
-
-       return 0;
-}
-
-static int wm_coeff_write_ctrl(struct wm_coeff_ctl *ctl,
-                              const void *buf, size_t len)
-{
-       int ret = 0;
-
-       if (ctl->flags & WMFW_CTL_FLAG_VOLATILE)
-               ret = -EPERM;
-       else if (buf != ctl->cache)
-               memcpy(ctl->cache, buf, len);
-
-       ctl->set = 1;
-       if (ctl->enabled && ctl->dsp->running)
-               ret = wm_coeff_write_ctrl_raw(ctl, buf, len);
-
-       return ret;
-}
-
 static int wm_coeff_put(struct snd_kcontrol *kctl,
                        struct snd_ctl_elem_value *ucontrol)
 {
        struct soc_bytes_ext *bytes_ext =
                (struct soc_bytes_ext *)kctl->private_value;
        struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
        char *p = ucontrol->value.bytes.data;
        int ret = 0;
 
-       mutex_lock(&ctl->dsp->pwr_lock);
-       ret = wm_coeff_write_ctrl(ctl, p, ctl->len);
-       mutex_unlock(&ctl->dsp->pwr_lock);
+       mutex_lock(&cs_ctl->dsp->pwr_lock);
+       ret = cs_dsp_coeff_write_ctrl(cs_ctl, p, cs_ctl->len);
+       mutex_unlock(&cs_ctl->dsp->pwr_lock);
 
        return ret;
 }
@@ -1100,16 +413,17 @@ static int wm_coeff_tlv_put(struct snd_kcontrol *kctl,
        struct soc_bytes_ext *bytes_ext =
                (struct soc_bytes_ext *)kctl->private_value;
        struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
        int ret = 0;
 
-       mutex_lock(&ctl->dsp->pwr_lock);
+       mutex_lock(&cs_ctl->dsp->pwr_lock);
 
-       if (copy_from_user(ctl->cache, bytes, size))
+       if (copy_from_user(cs_ctl->cache, bytes, size))
                ret = -EFAULT;
        else
-               ret = wm_coeff_write_ctrl(ctl, ctl->cache, size);
+               ret = cs_dsp_coeff_write_ctrl(cs_ctl, cs_ctl->cache, size);
 
-       mutex_unlock(&ctl->dsp->pwr_lock);
+       mutex_unlock(&cs_ctl->dsp->pwr_lock);
 
        return ret;
 }
@@ -1120,87 +434,38 @@ static int wm_coeff_put_acked(struct snd_kcontrol *kctl,
        struct soc_bytes_ext *bytes_ext =
                (struct soc_bytes_ext *)kctl->private_value;
        struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
        unsigned int val = ucontrol->value.integer.value[0];
        int ret;
 
        if (val == 0)
                return 0;       /* 0 means no event */
 
-       mutex_lock(&ctl->dsp->pwr_lock);
+       mutex_lock(&cs_ctl->dsp->pwr_lock);
 
-       if (ctl->enabled && ctl->dsp->running)
-               ret = wm_coeff_write_acked_control(ctl, val);
+       if (cs_ctl->enabled)
+               ret = cs_dsp_coeff_write_acked_control(cs_ctl, val);
        else
                ret = -EPERM;
 
-       mutex_unlock(&ctl->dsp->pwr_lock);
+       mutex_unlock(&cs_ctl->dsp->pwr_lock);
 
        return ret;
 }
 
-static int wm_coeff_read_ctrl_raw(struct wm_coeff_ctl *ctl,
-                                 void *buf, size_t len)
+static int wm_coeff_get(struct snd_kcontrol *kctl,
+                       struct snd_ctl_elem_value *ucontrol)
 {
-       struct wm_adsp *dsp = ctl->dsp;
-       void *scratch;
+       struct soc_bytes_ext *bytes_ext =
+               (struct soc_bytes_ext *)kctl->private_value;
+       struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
+       char *p = ucontrol->value.bytes.data;
        int ret;
-       unsigned int reg;
 
-       ret = wm_coeff_base_reg(ctl, &reg);
-       if (ret)
-               return ret;
-
-       scratch = kmalloc(len, GFP_KERNEL | GFP_DMA);
-       if (!scratch)
-               return -ENOMEM;
-
-       ret = regmap_raw_read(dsp->regmap, reg, scratch, len);
-       if (ret) {
-               adsp_err(dsp, "Failed to read %zu bytes from %x: %d\n",
-                        len, reg, ret);
-               kfree(scratch);
-               return ret;
-       }
-       adsp_dbg(dsp, "Read %zu bytes from %x\n", len, reg);
-
-       memcpy(buf, scratch, len);
-       kfree(scratch);
-
-       return 0;
-}
-
-static int wm_coeff_read_ctrl(struct wm_coeff_ctl *ctl, void *buf, size_t len)
-{
-       int ret = 0;
-
-       if (ctl->flags & WMFW_CTL_FLAG_VOLATILE) {
-               if (ctl->enabled && ctl->dsp->running)
-                       return wm_coeff_read_ctrl_raw(ctl, buf, len);
-               else
-                       return -EPERM;
-       } else {
-               if (!ctl->flags && ctl->enabled && ctl->dsp->running)
-                       ret = wm_coeff_read_ctrl_raw(ctl, ctl->cache, ctl->len);
-
-               if (buf != ctl->cache)
-                       memcpy(buf, ctl->cache, len);
-       }
-
-       return ret;
-}
-
-static int wm_coeff_get(struct snd_kcontrol *kctl,
-                       struct snd_ctl_elem_value *ucontrol)
-{
-       struct soc_bytes_ext *bytes_ext =
-               (struct soc_bytes_ext *)kctl->private_value;
-       struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
-       char *p = ucontrol->value.bytes.data;
-       int ret;
-
-       mutex_lock(&ctl->dsp->pwr_lock);
-       ret = wm_coeff_read_ctrl(ctl, p, ctl->len);
-       mutex_unlock(&ctl->dsp->pwr_lock);
+       mutex_lock(&cs_ctl->dsp->pwr_lock);
+       ret = cs_dsp_coeff_read_ctrl(cs_ctl, p, cs_ctl->len);
+       mutex_unlock(&cs_ctl->dsp->pwr_lock);
 
        return ret;
 }
@@ -1211,16 +476,17 @@ static int wm_coeff_tlv_get(struct snd_kcontrol *kctl,
        struct soc_bytes_ext *bytes_ext =
                (struct soc_bytes_ext *)kctl->private_value;
        struct wm_coeff_ctl *ctl = bytes_ext_to_ctl(bytes_ext);
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
        int ret = 0;
 
-       mutex_lock(&ctl->dsp->pwr_lock);
+       mutex_lock(&cs_ctl->dsp->pwr_lock);
 
-       ret = wm_coeff_read_ctrl(ctl, ctl->cache, size);
+       ret = cs_dsp_coeff_read_ctrl(cs_ctl, cs_ctl->cache, size);
 
-       if (!ret && copy_to_user(bytes, ctl->cache, size))
+       if (!ret && copy_to_user(bytes, cs_ctl->cache, size))
                ret = -EFAULT;
 
-       mutex_unlock(&ctl->dsp->pwr_lock);
+       mutex_unlock(&cs_ctl->dsp->pwr_lock);
 
        return ret;
 }
@@ -1240,12 +506,6 @@ static int wm_coeff_get_acked(struct snd_kcontrol *kcontrol,
        return 0;
 }
 
-struct wmfw_ctl_work {
-       struct wm_adsp *dsp;
-       struct wm_coeff_ctl *ctl;
-       struct work_struct work;
-};
-
 static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len)
 {
        unsigned int out, rd, wr, vol;
@@ -1279,12 +539,10 @@ static unsigned int wmfw_convert_flags(unsigned int in, unsigned int len)
 
 static int wmfw_add_ctl(struct wm_adsp *dsp, struct wm_coeff_ctl *ctl)
 {
+       struct cs_dsp_coeff_ctl *cs_ctl = ctl->cs_ctl;
        struct snd_kcontrol_new *kcontrol;
        int ret;
 
-       if (!ctl || !ctl->name)
-               return -EINVAL;
-
        kcontrol = kzalloc(sizeof(*kcontrol), GFP_KERNEL);
        if (!kcontrol)
                return -ENOMEM;
@@ -1294,16 +552,16 @@ static int wmfw_add_ctl(struct wm_adsp *dsp, struct wm_coeff_ctl *ctl)
        kcontrol->iface = SNDRV_CTL_ELEM_IFACE_MIXER;
        kcontrol->tlv.c = snd_soc_bytes_tlv_callback;
        kcontrol->private_value = (unsigned long)&ctl->bytes_ext;
-       kcontrol->access = wmfw_convert_flags(ctl->flags, ctl->len);
+       kcontrol->access = wmfw_convert_flags(cs_ctl->flags, cs_ctl->len);
 
-       switch (ctl->type) {
+       switch (cs_ctl->type) {
        case WMFW_CTL_TYPE_ACKED:
                kcontrol->get = wm_coeff_get_acked;
                kcontrol->put = wm_coeff_put_acked;
                break;
        default:
                if (kcontrol->access & SNDRV_CTL_ELEM_ACCESS_TLV_CALLBACK) {
-                       ctl->bytes_ext.max = ctl->len;
+                       ctl->bytes_ext.max = cs_ctl->len;
                        ctl->bytes_ext.get = wm_coeff_tlv_get;
                        ctl->bytes_ext.put = wm_coeff_tlv_put;
                } else {
@@ -1326,128 +584,55 @@ err_kcontrol:
        return ret;
 }
 
-static int wm_coeff_init_control_caches(struct wm_adsp *dsp)
-{
-       struct wm_coeff_ctl *ctl;
-       int ret;
-
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (!ctl->enabled || ctl->set)
-                       continue;
-               if (ctl->flags & WMFW_CTL_FLAG_VOLATILE)
-                       continue;
-
-               /*
-                * For readable controls populate the cache from the DSP memory.
-                * For non-readable controls the cache was zero-filled when
-                * created so we don't need to do anything.
-                */
-               if (!ctl->flags || (ctl->flags & WMFW_CTL_FLAG_READABLE)) {
-                       ret = wm_coeff_read_ctrl_raw(ctl, ctl->cache, ctl->len);
-                       if (ret < 0)
-                               return ret;
-               }
-       }
-
-       return 0;
-}
-
-static int wm_coeff_sync_controls(struct wm_adsp *dsp)
-{
-       struct wm_coeff_ctl *ctl;
-       int ret;
-
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (!ctl->enabled)
-                       continue;
-               if (ctl->set && !(ctl->flags & WMFW_CTL_FLAG_VOLATILE)) {
-                       ret = wm_coeff_write_ctrl_raw(ctl, ctl->cache,
-                                                     ctl->len);
-                       if (ret < 0)
-                               return ret;
-               }
-       }
-
-       return 0;
-}
-
-static void wm_adsp_signal_event_controls(struct wm_adsp *dsp,
-                                         unsigned int event)
-{
-       struct wm_coeff_ctl *ctl;
-       int ret;
-
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (ctl->type != WMFW_CTL_TYPE_HOSTEVENT)
-                       continue;
-
-               if (!ctl->enabled)
-                       continue;
-
-               ret = wm_coeff_write_acked_control(ctl, event);
-               if (ret)
-                       adsp_warn(dsp,
-                                 "Failed to send 0x%x event to alg 0x%x (%d)\n",
-                                 event, ctl->alg_region.alg, ret);
-       }
-}
-
 static void wm_adsp_ctl_work(struct work_struct *work)
 {
-       struct wmfw_ctl_work *ctl_work = container_of(work,
-                                                     struct wmfw_ctl_work,
-                                                     work);
-
-       wmfw_add_ctl(ctl_work->dsp, ctl_work->ctl);
-       kfree(ctl_work);
-}
+       struct wm_coeff_ctl *ctl = container_of(work,
+                                               struct wm_coeff_ctl,
+                                               work);
+       struct wm_adsp *dsp = container_of(ctl->cs_ctl->dsp,
+                                          struct wm_adsp,
+                                          cs_dsp);
 
-static void wm_adsp_free_ctl_blk(struct wm_coeff_ctl *ctl)
-{
-       kfree(ctl->cache);
-       kfree(ctl->name);
-       kfree(ctl->subname);
-       kfree(ctl);
+       wmfw_add_ctl(dsp, ctl);
 }
 
-static int wm_adsp_create_control(struct wm_adsp *dsp,
-                                 const struct wm_adsp_alg_region *alg_region,
-                                 unsigned int offset, unsigned int len,
-                                 const char *subname, unsigned int subname_len,
-                                 unsigned int flags, snd_ctl_elem_type_t type)
+static int wm_adsp_control_add(struct cs_dsp_coeff_ctl *cs_ctl)
 {
+       struct wm_adsp *dsp = container_of(cs_ctl->dsp, struct wm_adsp, cs_dsp);
+       struct cs_dsp *cs_dsp = &dsp->cs_dsp;
        struct wm_coeff_ctl *ctl;
-       struct wmfw_ctl_work *ctl_work;
        char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
        const char *region_name;
        int ret;
 
-       region_name = wm_adsp_mem_region_name(alg_region->type);
+       if (cs_ctl->flags & WMFW_CTL_FLAG_SYS)
+               return 0;
+
+       region_name = cs_dsp_mem_region_name(cs_ctl->alg_region.type);
        if (!region_name) {
-               adsp_err(dsp, "Unknown region type: %d\n", alg_region->type);
+               adsp_err(dsp, "Unknown region type: %d\n", cs_ctl->alg_region.type);
                return -EINVAL;
        }
 
-       switch (dsp->fw_ver) {
+       switch (cs_dsp->fw_ver) {
        case 0:
        case 1:
                snprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "%s %s %x",
-                        dsp->name, region_name, alg_region->alg);
-               subname = NULL; /* don't append subname */
+                        cs_dsp->name, region_name, cs_ctl->alg_region.alg);
                break;
        case 2:
                ret = scnprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN,
-                               "%s%c %.12s %x", dsp->name, *region_name,
-                               wm_adsp_fw_text[dsp->fw], alg_region->alg);
+                               "%s%c %.12s %x", cs_dsp->name, *region_name,
+                               wm_adsp_fw_text[dsp->fw], cs_ctl->alg_region.alg);
                break;
        default:
                ret = scnprintf(name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN,
-                               "%s %.12s %x", dsp->name,
-                               wm_adsp_fw_text[dsp->fw], alg_region->alg);
+                               "%s %.12s %x", cs_dsp->name,
+                               wm_adsp_fw_text[dsp->fw], cs_ctl->alg_region.alg);
                break;
        }
 
-       if (subname) {
+       if (cs_ctl->subname) {
                int avail = SNDRV_CTL_ELEM_ID_NAME_MAXLEN - ret - 2;
                int skip = 0;
 
@@ -1455,1667 +640,247 @@ static int wm_adsp_create_control(struct wm_adsp *dsp,
                        avail -= strlen(dsp->component->name_prefix) + 1;
 
                /* Truncate the subname from the start if it is too long */
-               if (subname_len > avail)
-                       skip = subname_len - avail;
+               if (cs_ctl->subname_len > avail)
+                       skip = cs_ctl->subname_len - avail;
 
                snprintf(name + ret, SNDRV_CTL_ELEM_ID_NAME_MAXLEN - ret,
-                        " %.*s", subname_len - skip, subname + skip);
-       }
-
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (!strcmp(ctl->name, name)) {
-                       if (!ctl->enabled)
-                               ctl->enabled = 1;
-                       return 0;
-               }
+                        " %.*s", cs_ctl->subname_len - skip, cs_ctl->subname + skip);
        }
 
        ctl = kzalloc(sizeof(*ctl), GFP_KERNEL);
        if (!ctl)
                return -ENOMEM;
-       ctl->fw_name = wm_adsp_fw_text[dsp->fw];
-       ctl->alg_region = *alg_region;
+       ctl->cs_ctl = cs_ctl;
+
        ctl->name = kmemdup(name, strlen(name) + 1, GFP_KERNEL);
        if (!ctl->name) {
                ret = -ENOMEM;
                goto err_ctl;
        }
-       if (subname) {
-               ctl->subname_len = subname_len;
-               ctl->subname = kmemdup(subname,
-                                      strlen(subname) + 1, GFP_KERNEL);
-               if (!ctl->subname) {
-                       ret = -ENOMEM;
-                       goto err_ctl_name;
-               }
-       }
-       ctl->enabled = 1;
-       ctl->set = 0;
-       ctl->dsp = dsp;
-
-       ctl->flags = flags;
-       ctl->type = type;
-       ctl->offset = offset;
-       ctl->len = len;
-       ctl->cache = kzalloc(ctl->len, GFP_KERNEL);
-       if (!ctl->cache) {
-               ret = -ENOMEM;
-               goto err_ctl_subname;
-       }
-
-       list_add(&ctl->list, &dsp->ctl_list);
 
-       if (flags & WMFW_CTL_FLAG_SYS)
-               return 0;
-
-       ctl_work = kzalloc(sizeof(*ctl_work), GFP_KERNEL);
-       if (!ctl_work) {
-               ret = -ENOMEM;
-               goto err_list_del;
-       }
+       cs_ctl->priv = ctl;
 
-       ctl_work->dsp = dsp;
-       ctl_work->ctl = ctl;
-       INIT_WORK(&ctl_work->work, wm_adsp_ctl_work);
-       schedule_work(&ctl_work->work);
+       INIT_WORK(&ctl->work, wm_adsp_ctl_work);
+       schedule_work(&ctl->work);
 
        return 0;
 
-err_list_del:
-       list_del(&ctl->list);
-       kfree(ctl->cache);
-err_ctl_subname:
-       kfree(ctl->subname);
-err_ctl_name:
-       kfree(ctl->name);
 err_ctl:
        kfree(ctl);
 
        return ret;
 }
 
-struct wm_coeff_parsed_alg {
-       int id;
-       const u8 *name;
-       int name_len;
-       int ncoeff;
-};
-
-struct wm_coeff_parsed_coeff {
-       int offset;
-       int mem_type;
-       const u8 *name;
-       int name_len;
-       snd_ctl_elem_type_t ctl_type;
-       int flags;
-       int len;
-};
-
-static int wm_coeff_parse_string(int bytes, const u8 **pos, const u8 **str)
-{
-       int length;
-
-       switch (bytes) {
-       case 1:
-               length = **pos;
-               break;
-       case 2:
-               length = le16_to_cpu(*((__le16 *)*pos));
-               break;
-       default:
-               return 0;
-       }
-
-       if (str)
-               *str = *pos + bytes;
-
-       *pos += ((length + bytes) + 3) & ~0x03;
-
-       return length;
-}
-
-static int wm_coeff_parse_int(int bytes, const u8 **pos)
+static void wm_adsp_control_remove(struct cs_dsp_coeff_ctl *cs_ctl)
 {
-       int val = 0;
-
-       switch (bytes) {
-       case 2:
-               val = le16_to_cpu(*((__le16 *)*pos));
-               break;
-       case 4:
-               val = le32_to_cpu(*((__le32 *)*pos));
-               break;
-       default:
-               break;
-       }
+       struct wm_coeff_ctl *ctl = cs_ctl->priv;
 
-       *pos += bytes;
+       cancel_work_sync(&ctl->work);
 
-       return val;
+       kfree(ctl->name);
+       kfree(ctl);
 }
 
-static inline void wm_coeff_parse_alg(struct wm_adsp *dsp, const u8 **data,
-                                     struct wm_coeff_parsed_alg *blk)
+int wm_adsp_write_ctl(struct wm_adsp *dsp, const char *name, int type,
+                     unsigned int alg, void *buf, size_t len)
 {
-       const struct wmfw_adsp_alg_data *raw;
+       struct cs_dsp_coeff_ctl *cs_ctl;
+       struct wm_coeff_ctl *ctl;
+       struct snd_kcontrol *kcontrol;
+       char ctl_name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
+       int ret;
 
-       switch (dsp->fw_ver) {
-       case 0:
-       case 1:
-               raw = (const struct wmfw_adsp_alg_data *)*data;
-               *data = raw->data;
+       cs_ctl = cs_dsp_get_ctl(&dsp->cs_dsp, name, type, alg);
+       if (!cs_ctl)
+               return -EINVAL;
 
-               blk->id = le32_to_cpu(raw->id);
-               blk->name = raw->name;
-               blk->name_len = strlen(raw->name);
-               blk->ncoeff = le32_to_cpu(raw->ncoeff);
-               break;
-       default:
-               blk->id = wm_coeff_parse_int(sizeof(raw->id), data);
-               blk->name_len = wm_coeff_parse_string(sizeof(u8), data,
-                                                     &blk->name);
-               wm_coeff_parse_string(sizeof(u16), data, NULL);
-               blk->ncoeff = wm_coeff_parse_int(sizeof(raw->ncoeff), data);
-               break;
-       }
+       ctl = cs_ctl->priv;
 
-       adsp_dbg(dsp, "Algorithm ID: %#x\n", blk->id);
-       adsp_dbg(dsp, "Algorithm name: %.*s\n", blk->name_len, blk->name);
-       adsp_dbg(dsp, "# of coefficient descriptors: %#x\n", blk->ncoeff);
-}
+       if (len > cs_ctl->len)
+               return -EINVAL;
 
-static inline void wm_coeff_parse_coeff(struct wm_adsp *dsp, const u8 **data,
-                                       struct wm_coeff_parsed_coeff *blk)
-{
-       const struct wmfw_adsp_coeff_data *raw;
-       const u8 *tmp;
-       int length;
+       ret = cs_dsp_coeff_write_ctrl(cs_ctl, buf, len);
+       if (ret)
+               return ret;
 
-       switch (dsp->fw_ver) {
-       case 0:
-       case 1:
-               raw = (const struct wmfw_adsp_coeff_data *)*data;
-               *data = *data + sizeof(raw->hdr) + le32_to_cpu(raw->hdr.size);
-
-               blk->offset = le16_to_cpu(raw->hdr.offset);
-               blk->mem_type = le16_to_cpu(raw->hdr.type);
-               blk->name = raw->name;
-               blk->name_len = strlen(raw->name);
-               blk->ctl_type = (__force snd_ctl_elem_type_t)le16_to_cpu(raw->ctl_type);
-               blk->flags = le16_to_cpu(raw->flags);
-               blk->len = le32_to_cpu(raw->len);
-               break;
-       default:
-               tmp = *data;
-               blk->offset = wm_coeff_parse_int(sizeof(raw->hdr.offset), &tmp);
-               blk->mem_type = wm_coeff_parse_int(sizeof(raw->hdr.type), &tmp);
-               length = wm_coeff_parse_int(sizeof(raw->hdr.size), &tmp);
-               blk->name_len = wm_coeff_parse_string(sizeof(u8), &tmp,
-                                                     &blk->name);
-               wm_coeff_parse_string(sizeof(u8), &tmp, NULL);
-               wm_coeff_parse_string(sizeof(u16), &tmp, NULL);
-               blk->ctl_type =
-                       (__force snd_ctl_elem_type_t)wm_coeff_parse_int(sizeof(raw->ctl_type),
-                                                                       &tmp);
-               blk->flags = wm_coeff_parse_int(sizeof(raw->flags), &tmp);
-               blk->len = wm_coeff_parse_int(sizeof(raw->len), &tmp);
-
-               *data = *data + sizeof(raw->hdr) + length;
-               break;
-       }
+       if (cs_ctl->flags & WMFW_CTL_FLAG_SYS)
+               return 0;
 
-       adsp_dbg(dsp, "\tCoefficient type: %#x\n", blk->mem_type);
-       adsp_dbg(dsp, "\tCoefficient offset: %#x\n", blk->offset);
-       adsp_dbg(dsp, "\tCoefficient name: %.*s\n", blk->name_len, blk->name);
-       adsp_dbg(dsp, "\tCoefficient flags: %#x\n", blk->flags);
-       adsp_dbg(dsp, "\tALSA control type: %#x\n", blk->ctl_type);
-       adsp_dbg(dsp, "\tALSA control len: %#x\n", blk->len);
-}
+       if (dsp->component->name_prefix)
+               snprintf(ctl_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "%s %s",
+                        dsp->component->name_prefix, ctl->name);
+       else
+               snprintf(ctl_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "%s",
+                        ctl->name);
 
-static int wm_adsp_check_coeff_flags(struct wm_adsp *dsp,
-                               const struct wm_coeff_parsed_coeff *coeff_blk,
-                               unsigned int f_required,
-                               unsigned int f_illegal)
-{
-       if ((coeff_blk->flags & f_illegal) ||
-           ((coeff_blk->flags & f_required) != f_required)) {
-               adsp_err(dsp, "Illegal flags 0x%x for control type 0x%x\n",
-                        coeff_blk->flags, coeff_blk->ctl_type);
+       kcontrol = snd_soc_card_get_kcontrol(dsp->component->card, ctl_name);
+       if (!kcontrol) {
+               adsp_err(dsp, "Can't find kcontrol %s\n", ctl_name);
                return -EINVAL;
        }
 
-       return 0;
-}
-
-static int wm_adsp_parse_coeff(struct wm_adsp *dsp,
-                              const struct wmfw_region *region)
-{
-       struct wm_adsp_alg_region alg_region = {};
-       struct wm_coeff_parsed_alg alg_blk;
-       struct wm_coeff_parsed_coeff coeff_blk;
-       const u8 *data = region->data;
-       int i, ret;
-
-       wm_coeff_parse_alg(dsp, &data, &alg_blk);
-       for (i = 0; i < alg_blk.ncoeff; i++) {
-               wm_coeff_parse_coeff(dsp, &data, &coeff_blk);
-
-               switch (coeff_blk.ctl_type) {
-               case SNDRV_CTL_ELEM_TYPE_BYTES:
-                       break;
-               case WMFW_CTL_TYPE_ACKED:
-                       if (coeff_blk.flags & WMFW_CTL_FLAG_SYS)
-                               continue;       /* ignore */
-
-                       ret = wm_adsp_check_coeff_flags(dsp, &coeff_blk,
-                                               WMFW_CTL_FLAG_VOLATILE |
-                                               WMFW_CTL_FLAG_WRITEABLE |
-                                               WMFW_CTL_FLAG_READABLE,
-                                               0);
-                       if (ret)
-                               return -EINVAL;
-                       break;
-               case WMFW_CTL_TYPE_HOSTEVENT:
-                       ret = wm_adsp_check_coeff_flags(dsp, &coeff_blk,
-                                               WMFW_CTL_FLAG_SYS |
-                                               WMFW_CTL_FLAG_VOLATILE |
-                                               WMFW_CTL_FLAG_WRITEABLE |
-                                               WMFW_CTL_FLAG_READABLE,
-                                               0);
-                       if (ret)
-                               return -EINVAL;
-                       break;
-               case WMFW_CTL_TYPE_HOST_BUFFER:
-                       ret = wm_adsp_check_coeff_flags(dsp, &coeff_blk,
-                                               WMFW_CTL_FLAG_SYS |
-                                               WMFW_CTL_FLAG_VOLATILE |
-                                               WMFW_CTL_FLAG_READABLE,
-                                               0);
-                       if (ret)
-                               return -EINVAL;
-                       break;
-               default:
-                       adsp_err(dsp, "Unknown control type: %d\n",
-                                coeff_blk.ctl_type);
-                       return -EINVAL;
-               }
-
-               alg_region.type = coeff_blk.mem_type;
-               alg_region.alg = alg_blk.id;
-
-               ret = wm_adsp_create_control(dsp, &alg_region,
-                                            coeff_blk.offset,
-                                            coeff_blk.len,
-                                            coeff_blk.name,
-                                            coeff_blk.name_len,
-                                            coeff_blk.flags,
-                                            coeff_blk.ctl_type);
-               if (ret < 0)
-                       adsp_err(dsp, "Failed to create control: %.*s, %d\n",
-                                coeff_blk.name_len, coeff_blk.name, ret);
-       }
+       snd_ctl_notify(dsp->component->card->snd_card,
+                      SNDRV_CTL_EVENT_MASK_VALUE, &kcontrol->id);
 
        return 0;
 }
+EXPORT_SYMBOL_GPL(wm_adsp_write_ctl);
 
-static unsigned int wm_adsp1_parse_sizes(struct wm_adsp *dsp,
-                                        const char * const file,
-                                        unsigned int pos,
-                                        const struct firmware *firmware)
+int wm_adsp_read_ctl(struct wm_adsp *dsp, const char *name, int type,
+                    unsigned int alg, void *buf, size_t len)
 {
-       const struct wmfw_adsp1_sizes *adsp1_sizes;
+       struct cs_dsp_coeff_ctl *cs_ctl;
 
-       adsp1_sizes = (void *)&firmware->data[pos];
+       cs_ctl = cs_dsp_get_ctl(&dsp->cs_dsp, name, type, alg);
+       if (!cs_ctl)
+               return -EINVAL;
 
-       adsp_dbg(dsp, "%s: %d DM, %d PM, %d ZM\n", file,
-                le32_to_cpu(adsp1_sizes->dm), le32_to_cpu(adsp1_sizes->pm),
-                le32_to_cpu(adsp1_sizes->zm));
+       if (len > cs_ctl->len)
+               return -EINVAL;
 
-       return pos + sizeof(*adsp1_sizes);
+       return cs_dsp_coeff_read_ctrl(cs_ctl, buf, len);
 }
+EXPORT_SYMBOL_GPL(wm_adsp_read_ctl);
 
-static unsigned int wm_adsp2_parse_sizes(struct wm_adsp *dsp,
-                                        const char * const file,
-                                        unsigned int pos,
-                                        const struct firmware *firmware)
+static void wm_adsp_release_firmware_files(struct wm_adsp *dsp,
+                                          const struct firmware *wmfw_firmware,
+                                          char *wmfw_filename,
+                                          const struct firmware *coeff_firmware,
+                                          char *coeff_filename)
 {
-       const struct wmfw_adsp2_sizes *adsp2_sizes;
+       if (wmfw_firmware)
+               release_firmware(wmfw_firmware);
+       kfree(wmfw_filename);
 
-       adsp2_sizes = (void *)&firmware->data[pos];
-
-       adsp_dbg(dsp, "%s: %d XM, %d YM %d PM, %d ZM\n", file,
-                le32_to_cpu(adsp2_sizes->xm), le32_to_cpu(adsp2_sizes->ym),
-                le32_to_cpu(adsp2_sizes->pm), le32_to_cpu(adsp2_sizes->zm));
-
-       return pos + sizeof(*adsp2_sizes);
-}
-
-static bool wm_adsp_validate_version(struct wm_adsp *dsp, unsigned int version)
-{
-       switch (version) {
-       case 0:
-               adsp_warn(dsp, "Deprecated file format %d\n", version);
-               return true;
-       case 1:
-       case 2:
-               return true;
-       default:
-               return false;
-       }
+       if (coeff_firmware)
+               release_firmware(coeff_firmware);
+       kfree(coeff_filename);
 }
 
-static bool wm_halo_validate_version(struct wm_adsp *dsp, unsigned int version)
+static int wm_adsp_request_firmware_file(struct wm_adsp *dsp,
+                                        const struct firmware **firmware,
+                                        char **filename,
+                                        char *suffix)
 {
-       switch (version) {
-       case 3:
-               return true;
-       default:
-               return false;
-       }
-}
+       struct cs_dsp *cs_dsp = &dsp->cs_dsp;
+       int ret = 0;
 
-static int wm_adsp_load(struct wm_adsp *dsp)
-{
-       LIST_HEAD(buf_list);
-       const struct firmware *firmware;
-       struct regmap *regmap = dsp->regmap;
-       unsigned int pos = 0;
-       const struct wmfw_header *header;
-       const struct wmfw_adsp1_sizes *adsp1_sizes;
-       const struct wmfw_footer *footer;
-       const struct wmfw_region *region;
-       const struct wm_adsp_region *mem;
-       const char *region_name;
-       char *file, *text = NULL;
-       struct wm_adsp_buf *buf;
-       unsigned int reg;
-       int regions = 0;
-       int ret, offset, type;
-
-       file = kzalloc(PAGE_SIZE, GFP_KERNEL);
-       if (file == NULL)
+       *filename = kasprintf(GFP_KERNEL, "%s-%s-%s.%s", dsp->part, dsp->fwf_name,
+                             wm_adsp_fw[dsp->fw].file, suffix);
+       if (*filename == NULL)
                return -ENOMEM;
 
-       snprintf(file, PAGE_SIZE, "%s-%s-%s.wmfw", dsp->part, dsp->fwf_name,
-                wm_adsp_fw[dsp->fw].file);
-       file[PAGE_SIZE - 1] = '\0';
-
-       ret = request_firmware(&firmware, file, dsp->dev);
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to request '%s'\n", file);
-               goto out;
-       }
-       ret = -EINVAL;
-
-       pos = sizeof(*header) + sizeof(*adsp1_sizes) + sizeof(*footer);
-       if (pos >= firmware->size) {
-               adsp_err(dsp, "%s: file too short, %zu bytes\n",
-                        file, firmware->size);
-               goto out_fw;
-       }
-
-       header = (void *)&firmware->data[0];
-
-       if (memcmp(&header->magic[0], "WMFW", 4) != 0) {
-               adsp_err(dsp, "%s: invalid magic\n", file);
-               goto out_fw;
-       }
-
-       if (!dsp->ops->validate_version(dsp, header->ver)) {
-               adsp_err(dsp, "%s: unknown file format %d\n",
-                        file, header->ver);
-               goto out_fw;
-       }
-
-       adsp_info(dsp, "Firmware version: %d\n", header->ver);
-       dsp->fw_ver = header->ver;
-
-       if (header->core != dsp->type) {
-               adsp_err(dsp, "%s: invalid core %d != %d\n",
-                        file, header->core, dsp->type);
-               goto out_fw;
-       }
-
-       pos = sizeof(*header);
-       pos = dsp->ops->parse_sizes(dsp, file, pos, firmware);
-
-       footer = (void *)&firmware->data[pos];
-       pos += sizeof(*footer);
-
-       if (le32_to_cpu(header->len) != pos) {
-               adsp_err(dsp, "%s: unexpected header length %d\n",
-                        file, le32_to_cpu(header->len));
-               goto out_fw;
-       }
-
-       adsp_dbg(dsp, "%s: timestamp %llu\n", file,
-                le64_to_cpu(footer->timestamp));
-
-       while (pos < firmware->size &&
-              sizeof(*region) < firmware->size - pos) {
-               region = (void *)&(firmware->data[pos]);
-               region_name = "Unknown";
-               reg = 0;
-               text = NULL;
-               offset = le32_to_cpu(region->offset) & 0xffffff;
-               type = be32_to_cpu(region->type) & 0xff;
-
-               switch (type) {
-               case WMFW_NAME_TEXT:
-                       region_name = "Firmware name";
-                       text = kzalloc(le32_to_cpu(region->len) + 1,
-                                      GFP_KERNEL);
-                       break;
-               case WMFW_ALGORITHM_DATA:
-                       region_name = "Algorithm";
-                       ret = wm_adsp_parse_coeff(dsp, region);
-                       if (ret != 0)
-                               goto out_fw;
-                       break;
-               case WMFW_INFO_TEXT:
-                       region_name = "Information";
-                       text = kzalloc(le32_to_cpu(region->len) + 1,
-                                      GFP_KERNEL);
-                       break;
-               case WMFW_ABSOLUTE:
-                       region_name = "Absolute";
-                       reg = offset;
-                       break;
-               case WMFW_ADSP1_PM:
-               case WMFW_ADSP1_DM:
-               case WMFW_ADSP2_XM:
-               case WMFW_ADSP2_YM:
-               case WMFW_ADSP1_ZM:
-               case WMFW_HALO_PM_PACKED:
-               case WMFW_HALO_XM_PACKED:
-               case WMFW_HALO_YM_PACKED:
-                       mem = wm_adsp_find_region(dsp, type);
-                       if (!mem) {
-                               adsp_err(dsp, "No region of type: %x\n", type);
-                               ret = -EINVAL;
-                               goto out_fw;
-                       }
-
-                       region_name = wm_adsp_mem_region_name(type);
-                       reg = dsp->ops->region_to_reg(mem, offset);
-                       break;
-               default:
-                       adsp_warn(dsp,
-                                 "%s.%d: Unknown region type %x at %d(%x)\n",
-                                 file, regions, type, pos, pos);
-                       break;
-               }
-
-               adsp_dbg(dsp, "%s.%d: %d bytes at %d in %s\n", file,
-                        regions, le32_to_cpu(region->len), offset,
-                        region_name);
-
-               if (le32_to_cpu(region->len) >
-                   firmware->size - pos - sizeof(*region)) {
-                       adsp_err(dsp,
-                                "%s.%d: %s region len %d bytes exceeds file length %zu\n",
-                                file, regions, region_name,
-                                le32_to_cpu(region->len), firmware->size);
-                       ret = -EINVAL;
-                       goto out_fw;
-               }
-
-               if (text) {
-                       memcpy(text, region->data, le32_to_cpu(region->len));
-                       adsp_info(dsp, "%s: %s\n", file, text);
-                       kfree(text);
-                       text = NULL;
-               }
-
-               if (reg) {
-                       buf = wm_adsp_buf_alloc(region->data,
-                                               le32_to_cpu(region->len),
-                                               &buf_list);
-                       if (!buf) {
-                               adsp_err(dsp, "Out of memory\n");
-                               ret = -ENOMEM;
-                               goto out_fw;
-                       }
-
-                       ret = regmap_raw_write_async(regmap, reg, buf->buf,
-                                                    le32_to_cpu(region->len));
-                       if (ret != 0) {
-                               adsp_err(dsp,
-                                       "%s.%d: Failed to write %d bytes at %d in %s: %d\n",
-                                       file, regions,
-                                       le32_to_cpu(region->len), offset,
-                                       region_name, ret);
-                               goto out_fw;
-                       }
-               }
-
-               pos += le32_to_cpu(region->len) + sizeof(*region);
-               regions++;
-       }
-
-       ret = regmap_async_complete(regmap);
+       ret = request_firmware(firmware, *filename, cs_dsp->dev);
        if (ret != 0) {
-               adsp_err(dsp, "Failed to complete async write: %d\n", ret);
-               goto out_fw;
+               adsp_err(dsp, "Failed to request '%s'\n", *filename);
+               kfree(*filename);
+               *filename = NULL;
        }
 
-       if (pos > firmware->size)
-               adsp_warn(dsp, "%s.%d: %zu bytes at end of file\n",
-                         file, regions, pos - firmware->size);
-
-       wm_adsp_debugfs_save_wmfwname(dsp, file);
-
-out_fw:
-       regmap_async_complete(regmap);
-       wm_adsp_buf_free(&buf_list);
-       release_firmware(firmware);
-       kfree(text);
-out:
-       kfree(file);
-
        return ret;
 }
 
-/*
- * Find wm_coeff_ctl with input name as its subname
- * If not found, return NULL
- */
-static struct wm_coeff_ctl *wm_adsp_get_ctl(struct wm_adsp *dsp,
-                                            const char *name, int type,
-                                            unsigned int alg)
+static int wm_adsp_request_firmware_files(struct wm_adsp *dsp,
+                                         const struct firmware **wmfw_firmware,
+                                         char **wmfw_filename,
+                                         const struct firmware **coeff_firmware,
+                                         char **coeff_filename)
 {
-       struct wm_coeff_ctl *pos, *rslt = NULL;
-       const char *fw_txt = wm_adsp_fw_text[dsp->fw];
+       int ret = 0;
 
-       list_for_each_entry(pos, &dsp->ctl_list, list) {
-               if (!pos->subname)
-                       continue;
-               if (strncmp(pos->subname, name, pos->subname_len) == 0 &&
-                   pos->fw_name == fw_txt &&
-                   pos->alg_region.alg == alg &&
-                   pos->alg_region.type == type) {
-                       rslt = pos;
-                       break;
-               }
-       }
+       ret = wm_adsp_request_firmware_file(dsp, wmfw_firmware, wmfw_filename, "wmfw");
+       if (ret != 0)
+               return ret;
 
-       return rslt;
-}
-
-int wm_adsp_write_ctl(struct wm_adsp *dsp, const char *name, int type,
-                     unsigned int alg, void *buf, size_t len)
-{
-       struct wm_coeff_ctl *ctl;
-       struct snd_kcontrol *kcontrol;
-       char ctl_name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN];
-       int ret;
-
-       ctl = wm_adsp_get_ctl(dsp, name, type, alg);
-       if (!ctl)
-               return -EINVAL;
-
-       if (len > ctl->len)
-               return -EINVAL;
-
-       ret = wm_coeff_write_ctrl(ctl, buf, len);
-       if (ret)
-               return ret;
-
-       if (ctl->flags & WMFW_CTL_FLAG_SYS)
-               return 0;
-
-       if (dsp->component->name_prefix)
-               snprintf(ctl_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "%s %s",
-                        dsp->component->name_prefix, ctl->name);
-       else
-               snprintf(ctl_name, SNDRV_CTL_ELEM_ID_NAME_MAXLEN, "%s",
-                        ctl->name);
-
-       kcontrol = snd_soc_card_get_kcontrol(dsp->component->card, ctl_name);
-       if (!kcontrol) {
-               adsp_err(dsp, "Can't find kcontrol %s\n", ctl_name);
-               return -EINVAL;
-       }
-
-       snd_ctl_notify(dsp->component->card->snd_card,
-                      SNDRV_CTL_EVENT_MASK_VALUE, &kcontrol->id);
-
-       return 0;
-}
-EXPORT_SYMBOL_GPL(wm_adsp_write_ctl);
-
-int wm_adsp_read_ctl(struct wm_adsp *dsp, const char *name, int type,
-                    unsigned int alg, void *buf, size_t len)
-{
-       struct wm_coeff_ctl *ctl;
-
-       ctl = wm_adsp_get_ctl(dsp, name, type, alg);
-       if (!ctl)
-               return -EINVAL;
-
-       if (len > ctl->len)
-               return -EINVAL;
-
-       return wm_coeff_read_ctrl(ctl, buf, len);
-}
-EXPORT_SYMBOL_GPL(wm_adsp_read_ctl);
-
-static void wm_adsp_ctl_fixup_base(struct wm_adsp *dsp,
-                                 const struct wm_adsp_alg_region *alg_region)
-{
-       struct wm_coeff_ctl *ctl;
-
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (ctl->fw_name == wm_adsp_fw_text[dsp->fw] &&
-                   alg_region->alg == ctl->alg_region.alg &&
-                   alg_region->type == ctl->alg_region.type) {
-                       ctl->alg_region.base = alg_region->base;
-               }
-       }
-}
-
-static void *wm_adsp_read_algs(struct wm_adsp *dsp, size_t n_algs,
-                              const struct wm_adsp_region *mem,
-                              unsigned int pos, unsigned int len)
-{
-       void *alg;
-       unsigned int reg;
-       int ret;
-       __be32 val;
-
-       if (n_algs == 0) {
-               adsp_err(dsp, "No algorithms\n");
-               return ERR_PTR(-EINVAL);
-       }
-
-       if (n_algs > 1024) {
-               adsp_err(dsp, "Algorithm count %zx excessive\n", n_algs);
-               return ERR_PTR(-EINVAL);
-       }
-
-       /* Read the terminator first to validate the length */
-       reg = dsp->ops->region_to_reg(mem, pos + len);
-
-       ret = regmap_raw_read(dsp->regmap, reg, &val, sizeof(val));
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to read algorithm list end: %d\n",
-                       ret);
-               return ERR_PTR(ret);
-       }
-
-       if (be32_to_cpu(val) != 0xbedead)
-               adsp_warn(dsp, "Algorithm list end %x 0x%x != 0xbedead\n",
-                         reg, be32_to_cpu(val));
-
-       /* Convert length from DSP words to bytes */
-       len *= sizeof(u32);
-
-       alg = kzalloc(len, GFP_KERNEL | GFP_DMA);
-       if (!alg)
-               return ERR_PTR(-ENOMEM);
-
-       reg = dsp->ops->region_to_reg(mem, pos);
-
-       ret = regmap_raw_read(dsp->regmap, reg, alg, len);
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to read algorithm list: %d\n", ret);
-               kfree(alg);
-               return ERR_PTR(ret);
-       }
-
-       return alg;
-}
-
-static struct wm_adsp_alg_region *
-       wm_adsp_find_alg_region(struct wm_adsp *dsp, int type, unsigned int id)
-{
-       struct wm_adsp_alg_region *alg_region;
-
-       list_for_each_entry(alg_region, &dsp->alg_regions, list) {
-               if (id == alg_region->alg && type == alg_region->type)
-                       return alg_region;
-       }
-
-       return NULL;
-}
-
-static struct wm_adsp_alg_region *wm_adsp_create_region(struct wm_adsp *dsp,
-                                                       int type, __be32 id,
-                                                       __be32 base)
-{
-       struct wm_adsp_alg_region *alg_region;
-
-       alg_region = kzalloc(sizeof(*alg_region), GFP_KERNEL);
-       if (!alg_region)
-               return ERR_PTR(-ENOMEM);
-
-       alg_region->type = type;
-       alg_region->alg = be32_to_cpu(id);
-       alg_region->base = be32_to_cpu(base);
-
-       list_add_tail(&alg_region->list, &dsp->alg_regions);
-
-       if (dsp->fw_ver > 0)
-               wm_adsp_ctl_fixup_base(dsp, alg_region);
-
-       return alg_region;
-}
-
-static void wm_adsp_free_alg_regions(struct wm_adsp *dsp)
-{
-       struct wm_adsp_alg_region *alg_region;
-
-       while (!list_empty(&dsp->alg_regions)) {
-               alg_region = list_first_entry(&dsp->alg_regions,
-                                             struct wm_adsp_alg_region,
-                                             list);
-               list_del(&alg_region->list);
-               kfree(alg_region);
-       }
-}
-
-static void wmfw_parse_id_header(struct wm_adsp *dsp,
-                                struct wmfw_id_hdr *fw, int nalgs)
-{
-       dsp->fw_id = be32_to_cpu(fw->id);
-       dsp->fw_id_version = be32_to_cpu(fw->ver);
-
-       adsp_info(dsp, "Firmware: %x v%d.%d.%d, %d algorithms\n",
-                 dsp->fw_id, (dsp->fw_id_version & 0xff0000) >> 16,
-                 (dsp->fw_id_version & 0xff00) >> 8, dsp->fw_id_version & 0xff,
-                 nalgs);
-}
-
-static void wmfw_v3_parse_id_header(struct wm_adsp *dsp,
-                                   struct wmfw_v3_id_hdr *fw, int nalgs)
-{
-       dsp->fw_id = be32_to_cpu(fw->id);
-       dsp->fw_id_version = be32_to_cpu(fw->ver);
-       dsp->fw_vendor_id = be32_to_cpu(fw->vendor_id);
-
-       adsp_info(dsp, "Firmware: %x vendor: 0x%x v%d.%d.%d, %d algorithms\n",
-                 dsp->fw_id, dsp->fw_vendor_id,
-                 (dsp->fw_id_version & 0xff0000) >> 16,
-                 (dsp->fw_id_version & 0xff00) >> 8, dsp->fw_id_version & 0xff,
-                 nalgs);
-}
-
-static int wm_adsp_create_regions(struct wm_adsp *dsp, __be32 id, int nregions,
-                               const int *type, __be32 *base)
-{
-       struct wm_adsp_alg_region *alg_region;
-       int i;
-
-       for (i = 0; i < nregions; i++) {
-               alg_region = wm_adsp_create_region(dsp, type[i], id, base[i]);
-               if (IS_ERR(alg_region))
-                       return PTR_ERR(alg_region);
-       }
-
-       return 0;
-}
-
-static int wm_adsp1_setup_algs(struct wm_adsp *dsp)
-{
-       struct wmfw_adsp1_id_hdr adsp1_id;
-       struct wmfw_adsp1_alg_hdr *adsp1_alg;
-       struct wm_adsp_alg_region *alg_region;
-       const struct wm_adsp_region *mem;
-       unsigned int pos, len;
-       size_t n_algs;
-       int i, ret;
-
-       mem = wm_adsp_find_region(dsp, WMFW_ADSP1_DM);
-       if (WARN_ON(!mem))
-               return -EINVAL;
-
-       ret = regmap_raw_read(dsp->regmap, mem->base, &adsp1_id,
-                             sizeof(adsp1_id));
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to read algorithm info: %d\n",
-                        ret);
-               return ret;
-       }
-
-       n_algs = be32_to_cpu(adsp1_id.n_algs);
-
-       wmfw_parse_id_header(dsp, &adsp1_id.fw, n_algs);
-
-       alg_region = wm_adsp_create_region(dsp, WMFW_ADSP1_ZM,
-                                          adsp1_id.fw.id, adsp1_id.zm);
-       if (IS_ERR(alg_region))
-               return PTR_ERR(alg_region);
-
-       alg_region = wm_adsp_create_region(dsp, WMFW_ADSP1_DM,
-                                          adsp1_id.fw.id, adsp1_id.dm);
-       if (IS_ERR(alg_region))
-               return PTR_ERR(alg_region);
-
-       /* Calculate offset and length in DSP words */
-       pos = sizeof(adsp1_id) / sizeof(u32);
-       len = (sizeof(*adsp1_alg) * n_algs) / sizeof(u32);
-
-       adsp1_alg = wm_adsp_read_algs(dsp, n_algs, mem, pos, len);
-       if (IS_ERR(adsp1_alg))
-               return PTR_ERR(adsp1_alg);
-
-       for (i = 0; i < n_algs; i++) {
-               adsp_info(dsp, "%d: ID %x v%d.%d.%d DM@%x ZM@%x\n",
-                         i, be32_to_cpu(adsp1_alg[i].alg.id),
-                         (be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff0000) >> 16,
-                         (be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff00) >> 8,
-                         be32_to_cpu(adsp1_alg[i].alg.ver) & 0xff,
-                         be32_to_cpu(adsp1_alg[i].dm),
-                         be32_to_cpu(adsp1_alg[i].zm));
-
-               alg_region = wm_adsp_create_region(dsp, WMFW_ADSP1_DM,
-                                                  adsp1_alg[i].alg.id,
-                                                  adsp1_alg[i].dm);
-               if (IS_ERR(alg_region)) {
-                       ret = PTR_ERR(alg_region);
-                       goto out;
-               }
-               if (dsp->fw_ver == 0) {
-                       if (i + 1 < n_algs) {
-                               len = be32_to_cpu(adsp1_alg[i + 1].dm);
-                               len -= be32_to_cpu(adsp1_alg[i].dm);
-                               len *= 4;
-                               wm_adsp_create_control(dsp, alg_region, 0,
-                                                    len, NULL, 0, 0,
-                                                    SNDRV_CTL_ELEM_TYPE_BYTES);
-                       } else {
-                               adsp_warn(dsp, "Missing length info for region DM with ID %x\n",
-                                         be32_to_cpu(adsp1_alg[i].alg.id));
-                       }
-               }
-
-               alg_region = wm_adsp_create_region(dsp, WMFW_ADSP1_ZM,
-                                                  adsp1_alg[i].alg.id,
-                                                  adsp1_alg[i].zm);
-               if (IS_ERR(alg_region)) {
-                       ret = PTR_ERR(alg_region);
-                       goto out;
-               }
-               if (dsp->fw_ver == 0) {
-                       if (i + 1 < n_algs) {
-                               len = be32_to_cpu(adsp1_alg[i + 1].zm);
-                               len -= be32_to_cpu(adsp1_alg[i].zm);
-                               len *= 4;
-                               wm_adsp_create_control(dsp, alg_region, 0,
-                                                    len, NULL, 0, 0,
-                                                    SNDRV_CTL_ELEM_TYPE_BYTES);
-                       } else {
-                               adsp_warn(dsp, "Missing length info for region ZM with ID %x\n",
-                                         be32_to_cpu(adsp1_alg[i].alg.id));
-                       }
-               }
-       }
-
-out:
-       kfree(adsp1_alg);
-       return ret;
-}
-
-static int wm_adsp2_setup_algs(struct wm_adsp *dsp)
-{
-       struct wmfw_adsp2_id_hdr adsp2_id;
-       struct wmfw_adsp2_alg_hdr *adsp2_alg;
-       struct wm_adsp_alg_region *alg_region;
-       const struct wm_adsp_region *mem;
-       unsigned int pos, len;
-       size_t n_algs;
-       int i, ret;
-
-       mem = wm_adsp_find_region(dsp, WMFW_ADSP2_XM);
-       if (WARN_ON(!mem))
-               return -EINVAL;
-
-       ret = regmap_raw_read(dsp->regmap, mem->base, &adsp2_id,
-                             sizeof(adsp2_id));
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to read algorithm info: %d\n",
-                        ret);
-               return ret;
-       }
-
-       n_algs = be32_to_cpu(adsp2_id.n_algs);
-
-       wmfw_parse_id_header(dsp, &adsp2_id.fw, n_algs);
-
-       alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_XM,
-                                          adsp2_id.fw.id, adsp2_id.xm);
-       if (IS_ERR(alg_region))
-               return PTR_ERR(alg_region);
-
-       alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_YM,
-                                          adsp2_id.fw.id, adsp2_id.ym);
-       if (IS_ERR(alg_region))
-               return PTR_ERR(alg_region);
-
-       alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_ZM,
-                                          adsp2_id.fw.id, adsp2_id.zm);
-       if (IS_ERR(alg_region))
-               return PTR_ERR(alg_region);
-
-       /* Calculate offset and length in DSP words */
-       pos = sizeof(adsp2_id) / sizeof(u32);
-       len = (sizeof(*adsp2_alg) * n_algs) / sizeof(u32);
-
-       adsp2_alg = wm_adsp_read_algs(dsp, n_algs, mem, pos, len);
-       if (IS_ERR(adsp2_alg))
-               return PTR_ERR(adsp2_alg);
-
-       for (i = 0; i < n_algs; i++) {
-               adsp_info(dsp,
-                         "%d: ID %x v%d.%d.%d XM@%x YM@%x ZM@%x\n",
-                         i, be32_to_cpu(adsp2_alg[i].alg.id),
-                         (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff0000) >> 16,
-                         (be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff00) >> 8,
-                         be32_to_cpu(adsp2_alg[i].alg.ver) & 0xff,
-                         be32_to_cpu(adsp2_alg[i].xm),
-                         be32_to_cpu(adsp2_alg[i].ym),
-                         be32_to_cpu(adsp2_alg[i].zm));
-
-               alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_XM,
-                                                  adsp2_alg[i].alg.id,
-                                                  adsp2_alg[i].xm);
-               if (IS_ERR(alg_region)) {
-                       ret = PTR_ERR(alg_region);
-                       goto out;
-               }
-               if (dsp->fw_ver == 0) {
-                       if (i + 1 < n_algs) {
-                               len = be32_to_cpu(adsp2_alg[i + 1].xm);
-                               len -= be32_to_cpu(adsp2_alg[i].xm);
-                               len *= 4;
-                               wm_adsp_create_control(dsp, alg_region, 0,
-                                                    len, NULL, 0, 0,
-                                                    SNDRV_CTL_ELEM_TYPE_BYTES);
-                       } else {
-                               adsp_warn(dsp, "Missing length info for region XM with ID %x\n",
-                                         be32_to_cpu(adsp2_alg[i].alg.id));
-                       }
-               }
-
-               alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_YM,
-                                                  adsp2_alg[i].alg.id,
-                                                  adsp2_alg[i].ym);
-               if (IS_ERR(alg_region)) {
-                       ret = PTR_ERR(alg_region);
-                       goto out;
-               }
-               if (dsp->fw_ver == 0) {
-                       if (i + 1 < n_algs) {
-                               len = be32_to_cpu(adsp2_alg[i + 1].ym);
-                               len -= be32_to_cpu(adsp2_alg[i].ym);
-                               len *= 4;
-                               wm_adsp_create_control(dsp, alg_region, 0,
-                                                    len, NULL, 0, 0,
-                                                    SNDRV_CTL_ELEM_TYPE_BYTES);
-                       } else {
-                               adsp_warn(dsp, "Missing length info for region YM with ID %x\n",
-                                         be32_to_cpu(adsp2_alg[i].alg.id));
-                       }
-               }
-
-               alg_region = wm_adsp_create_region(dsp, WMFW_ADSP2_ZM,
-                                                  adsp2_alg[i].alg.id,
-                                                  adsp2_alg[i].zm);
-               if (IS_ERR(alg_region)) {
-                       ret = PTR_ERR(alg_region);
-                       goto out;
-               }
-               if (dsp->fw_ver == 0) {
-                       if (i + 1 < n_algs) {
-                               len = be32_to_cpu(adsp2_alg[i + 1].zm);
-                               len -= be32_to_cpu(adsp2_alg[i].zm);
-                               len *= 4;
-                               wm_adsp_create_control(dsp, alg_region, 0,
-                                                    len, NULL, 0, 0,
-                                                    SNDRV_CTL_ELEM_TYPE_BYTES);
-                       } else {
-                               adsp_warn(dsp, "Missing length info for region ZM with ID %x\n",
-                                         be32_to_cpu(adsp2_alg[i].alg.id));
-                       }
-               }
-       }
-
-out:
-       kfree(adsp2_alg);
-       return ret;
-}
-
-static int wm_halo_create_regions(struct wm_adsp *dsp, __be32 id,
-                                 __be32 xm_base, __be32 ym_base)
-{
-       static const int types[] = {
-               WMFW_ADSP2_XM, WMFW_HALO_XM_PACKED,
-               WMFW_ADSP2_YM, WMFW_HALO_YM_PACKED
-       };
-       __be32 bases[] = { xm_base, xm_base, ym_base, ym_base };
-
-       return wm_adsp_create_regions(dsp, id, ARRAY_SIZE(types), types, bases);
-}
-
-static int wm_halo_setup_algs(struct wm_adsp *dsp)
-{
-       struct wmfw_halo_id_hdr halo_id;
-       struct wmfw_halo_alg_hdr *halo_alg;
-       const struct wm_adsp_region *mem;
-       unsigned int pos, len;
-       size_t n_algs;
-       int i, ret;
-
-       mem = wm_adsp_find_region(dsp, WMFW_ADSP2_XM);
-       if (WARN_ON(!mem))
-               return -EINVAL;
-
-       ret = regmap_raw_read(dsp->regmap, mem->base, &halo_id,
-                             sizeof(halo_id));
-       if (ret != 0) {
-               adsp_err(dsp, "Failed to read algorithm info: %d\n",
-                        ret);
-               return ret;
-       }
-
-       n_algs = be32_to_cpu(halo_id.n_algs);
-
-       wmfw_v3_parse_id_header(dsp, &halo_id.fw, n_algs);
-
-       ret = wm_halo_create_regions(dsp, halo_id.fw.id,
-                                    halo_id.xm_base, halo_id.ym_base);
-       if (ret)
-               return ret;
-
-       /* Calculate offset and length in DSP words */
-       pos = sizeof(halo_id) / sizeof(u32);
-       len = (sizeof(*halo_alg) * n_algs) / sizeof(u32);
-
-       halo_alg = wm_adsp_read_algs(dsp, n_algs, mem, pos, len);
-       if (IS_ERR(halo_alg))
-               return PTR_ERR(halo_alg);
-
-       for (i = 0; i < n_algs; i++) {
-               adsp_info(dsp,
-                         "%d: ID %x v%d.%d.%d XM@%x YM@%x\n",
-                         i, be32_to_cpu(halo_alg[i].alg.id),
-                         (be32_to_cpu(halo_alg[i].alg.ver) & 0xff0000) >> 16,
-                         (be32_to_cpu(halo_alg[i].alg.ver) & 0xff00) >> 8,
-                         be32_to_cpu(halo_alg[i].alg.ver) & 0xff,
-                         be32_to_cpu(halo_alg[i].xm_base),
-                         be32_to_cpu(halo_alg[i].ym_base));
-
-               ret = wm_halo_create_regions(dsp, halo_alg[i].alg.id,
-                                            halo_alg[i].xm_base,
-                                            halo_alg[i].ym_base);
-               if (ret)
-                       goto out;
-       }
-
-out:
-       kfree(halo_alg);
-       return ret;
-}
-
-static int wm_adsp_load_coeff(struct wm_adsp *dsp)
-{
-       LIST_HEAD(buf_list);
-       struct regmap *regmap = dsp->regmap;
-       struct wmfw_coeff_hdr *hdr;
-       struct wmfw_coeff_item *blk;
-       const struct firmware *firmware;
-       const struct wm_adsp_region *mem;
-       struct wm_adsp_alg_region *alg_region;
-       const char *region_name;
-       int ret, pos, blocks, type, offset, reg;
-       char *file;
-       struct wm_adsp_buf *buf;
-
-       file = kzalloc(PAGE_SIZE, GFP_KERNEL);
-       if (file == NULL)
-               return -ENOMEM;
-
-       snprintf(file, PAGE_SIZE, "%s-%s-%s.bin", dsp->part, dsp->fwf_name,
-                wm_adsp_fw[dsp->fw].file);
-       file[PAGE_SIZE - 1] = '\0';
-
-       ret = request_firmware(&firmware, file, dsp->dev);
-       if (ret != 0) {
-               adsp_warn(dsp, "Failed to request '%s'\n", file);
-               ret = 0;
-               goto out;
-       }
-       ret = -EINVAL;
-
-       if (sizeof(*hdr) >= firmware->size) {
-               adsp_err(dsp, "%s: file too short, %zu bytes\n",
-                       file, firmware->size);
-               goto out_fw;
-       }
-
-       hdr = (void *)&firmware->data[0];
-       if (memcmp(hdr->magic, "WMDR", 4) != 0) {
-               adsp_err(dsp, "%s: invalid magic\n", file);
-               goto out_fw;
-       }
-
-       switch (be32_to_cpu(hdr->rev) & 0xff) {
-       case 1:
-               break;
-       default:
-               adsp_err(dsp, "%s: Unsupported coefficient file format %d\n",
-                        file, be32_to_cpu(hdr->rev) & 0xff);
-               ret = -EINVAL;
-               goto out_fw;
-       }
-
-       adsp_dbg(dsp, "%s: v%d.%d.%d\n", file,
-               (le32_to_cpu(hdr->ver) >> 16) & 0xff,
-               (le32_to_cpu(hdr->ver) >>  8) & 0xff,
-               le32_to_cpu(hdr->ver) & 0xff);
-
-       pos = le32_to_cpu(hdr->len);
-
-       blocks = 0;
-       while (pos < firmware->size &&
-              sizeof(*blk) < firmware->size - pos) {
-               blk = (void *)(&firmware->data[pos]);
-
-               type = le16_to_cpu(blk->type);
-               offset = le16_to_cpu(blk->offset);
-
-               adsp_dbg(dsp, "%s.%d: %x v%d.%d.%d\n",
-                        file, blocks, le32_to_cpu(blk->id),
-                        (le32_to_cpu(blk->ver) >> 16) & 0xff,
-                        (le32_to_cpu(blk->ver) >>  8) & 0xff,
-                        le32_to_cpu(blk->ver) & 0xff);
-               adsp_dbg(dsp, "%s.%d: %d bytes at 0x%x in %x\n",
-                        file, blocks, le32_to_cpu(blk->len), offset, type);
-
-               reg = 0;
-               region_name = "Unknown";
-               switch (type) {
-               case (WMFW_NAME_TEXT << 8):
-               case (WMFW_INFO_TEXT << 8):
-               case (WMFW_METADATA << 8):
-                       break;
-               case (WMFW_ABSOLUTE << 8):
-                       /*
-                        * Old files may use this for global
-                        * coefficients.
-                        */
-                       if (le32_to_cpu(blk->id) == dsp->fw_id &&
-                           offset == 0) {
-                               region_name = "global coefficients";
-                               mem = wm_adsp_find_region(dsp, type);
-                               if (!mem) {
-                                       adsp_err(dsp, "No ZM\n");
-                                       break;
-                               }
-                               reg = dsp->ops->region_to_reg(mem, 0);
-
-                       } else {
-                               region_name = "register";
-                               reg = offset;
-                       }
-                       break;
-
-               case WMFW_ADSP1_DM:
-               case WMFW_ADSP1_ZM:
-               case WMFW_ADSP2_XM:
-               case WMFW_ADSP2_YM:
-               case WMFW_HALO_XM_PACKED:
-               case WMFW_HALO_YM_PACKED:
-               case WMFW_HALO_PM_PACKED:
-                       adsp_dbg(dsp, "%s.%d: %d bytes in %x for %x\n",
-                                file, blocks, le32_to_cpu(blk->len),
-                                type, le32_to_cpu(blk->id));
-
-                       mem = wm_adsp_find_region(dsp, type);
-                       if (!mem) {
-                               adsp_err(dsp, "No base for region %x\n", type);
-                               break;
-                       }
-
-                       alg_region = wm_adsp_find_alg_region(dsp, type,
-                                               le32_to_cpu(blk->id));
-                       if (alg_region) {
-                               reg = alg_region->base;
-                               reg = dsp->ops->region_to_reg(mem, reg);
-                               reg += offset;
-                       } else {
-                               adsp_err(dsp, "No %x for algorithm %x\n",
-                                        type, le32_to_cpu(blk->id));
-                       }
-                       break;
-
-               default:
-                       adsp_err(dsp, "%s.%d: Unknown region type %x at %d\n",
-                                file, blocks, type, pos);
-                       break;
-               }
-
-               if (reg) {
-                       if (le32_to_cpu(blk->len) >
-                           firmware->size - pos - sizeof(*blk)) {
-                               adsp_err(dsp,
-                                        "%s.%d: %s region len %d bytes exceeds file length %zu\n",
-                                        file, blocks, region_name,
-                                        le32_to_cpu(blk->len),
-                                        firmware->size);
-                               ret = -EINVAL;
-                               goto out_fw;
-                       }
-
-                       buf = wm_adsp_buf_alloc(blk->data,
-                                               le32_to_cpu(blk->len),
-                                               &buf_list);
-                       if (!buf) {
-                               adsp_err(dsp, "Out of memory\n");
-                               ret = -ENOMEM;
-                               goto out_fw;
-                       }
-
-                       adsp_dbg(dsp, "%s.%d: Writing %d bytes at %x\n",
-                                file, blocks, le32_to_cpu(blk->len),
-                                reg);
-                       ret = regmap_raw_write_async(regmap, reg, buf->buf,
-                                                    le32_to_cpu(blk->len));
-                       if (ret != 0) {
-                               adsp_err(dsp,
-                                       "%s.%d: Failed to write to %x in %s: %d\n",
-                                       file, blocks, reg, region_name, ret);
-                       }
-               }
-
-               pos += (le32_to_cpu(blk->len) + sizeof(*blk) + 3) & ~0x03;
-               blocks++;
-       }
-
-       ret = regmap_async_complete(regmap);
-       if (ret != 0)
-               adsp_err(dsp, "Failed to complete async write: %d\n", ret);
-
-       if (pos > firmware->size)
-               adsp_warn(dsp, "%s.%d: %zu bytes at end of file\n",
-                         file, blocks, pos - firmware->size);
-
-       wm_adsp_debugfs_save_binname(dsp, file);
-
-out_fw:
-       regmap_async_complete(regmap);
-       release_firmware(firmware);
-       wm_adsp_buf_free(&buf_list);
-out:
-       kfree(file);
-       return ret;
-}
-
-static int wm_adsp_create_name(struct wm_adsp *dsp)
-{
-       char *p;
-
-       if (!dsp->name) {
-               dsp->name = devm_kasprintf(dsp->dev, GFP_KERNEL, "DSP%d",
-                                          dsp->num);
-               if (!dsp->name)
-                       return -ENOMEM;
-       }
-
-       if (!dsp->fwf_name) {
-               p = devm_kstrdup(dsp->dev, dsp->name, GFP_KERNEL);
-               if (!p)
-                       return -ENOMEM;
-
-               dsp->fwf_name = p;
-               for (; *p != 0; ++p)
-                       *p = tolower(*p);
-       }
-
-       return 0;
-}
-
-static int wm_adsp_common_init(struct wm_adsp *dsp)
-{
-       int ret;
-
-       ret = wm_adsp_create_name(dsp);
-       if (ret)
-               return ret;
-
-       INIT_LIST_HEAD(&dsp->alg_regions);
-       INIT_LIST_HEAD(&dsp->ctl_list);
-       INIT_LIST_HEAD(&dsp->compr_list);
-       INIT_LIST_HEAD(&dsp->buffer_list);
-
-       mutex_init(&dsp->pwr_lock);
-
-       return 0;
-}
-
-int wm_adsp1_init(struct wm_adsp *dsp)
-{
-       dsp->ops = &wm_adsp1_ops;
-
-       return wm_adsp_common_init(dsp);
-}
-EXPORT_SYMBOL_GPL(wm_adsp1_init);
-
-int wm_adsp1_event(struct snd_soc_dapm_widget *w,
-                  struct snd_kcontrol *kcontrol,
-                  int event)
-{
-       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
-       struct wm_adsp *dsps = snd_soc_component_get_drvdata(component);
-       struct wm_adsp *dsp = &dsps[w->shift];
-       struct wm_coeff_ctl *ctl;
-       int ret;
-       unsigned int val;
-
-       dsp->component = component;
-
-       mutex_lock(&dsp->pwr_lock);
-
-       switch (event) {
-       case SND_SOC_DAPM_POST_PMU:
-               regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
-                                  ADSP1_SYS_ENA, ADSP1_SYS_ENA);
-
-               /*
-                * For simplicity set the DSP clock rate to be the
-                * SYSCLK rate rather than making it configurable.
-                */
-               if (dsp->sysclk_reg) {
-                       ret = regmap_read(dsp->regmap, dsp->sysclk_reg, &val);
-                       if (ret != 0) {
-                               adsp_err(dsp, "Failed to read SYSCLK state: %d\n",
-                               ret);
-                               goto err_mutex;
-                       }
-
-                       val = (val & dsp->sysclk_mask) >> dsp->sysclk_shift;
-
-                       ret = regmap_update_bits(dsp->regmap,
-                                                dsp->base + ADSP1_CONTROL_31,
-                                                ADSP1_CLK_SEL_MASK, val);
-                       if (ret != 0) {
-                               adsp_err(dsp, "Failed to set clock rate: %d\n",
-                                        ret);
-                               goto err_mutex;
-                       }
-               }
-
-               ret = wm_adsp_load(dsp);
-               if (ret != 0)
-                       goto err_ena;
-
-               ret = wm_adsp1_setup_algs(dsp);
-               if (ret != 0)
-                       goto err_ena;
-
-               ret = wm_adsp_load_coeff(dsp);
-               if (ret != 0)
-                       goto err_ena;
-
-               /* Initialize caches for enabled and unset controls */
-               ret = wm_coeff_init_control_caches(dsp);
-               if (ret != 0)
-                       goto err_ena;
-
-               /* Sync set controls */
-               ret = wm_coeff_sync_controls(dsp);
-               if (ret != 0)
-                       goto err_ena;
-
-               dsp->booted = true;
-
-               /* Start the core running */
-               regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
-                                  ADSP1_CORE_ENA | ADSP1_START,
-                                  ADSP1_CORE_ENA | ADSP1_START);
-
-               dsp->running = true;
-               break;
-
-       case SND_SOC_DAPM_PRE_PMD:
-               dsp->running = false;
-               dsp->booted = false;
-
-               /* Halt the core */
-               regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
-                                  ADSP1_CORE_ENA | ADSP1_START, 0);
-
-               regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_19,
-                                  ADSP1_WDMA_BUFFER_LENGTH_MASK, 0);
-
-               regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
-                                  ADSP1_SYS_ENA, 0);
-
-               list_for_each_entry(ctl, &dsp->ctl_list, list)
-                       ctl->enabled = 0;
-
-
-               wm_adsp_free_alg_regions(dsp);
-               break;
-
-       default:
-               break;
-       }
-
-       mutex_unlock(&dsp->pwr_lock);
+       wm_adsp_request_firmware_file(dsp, coeff_firmware, coeff_filename, "bin");
 
        return 0;
-
-err_ena:
-       regmap_update_bits(dsp->regmap, dsp->base + ADSP1_CONTROL_30,
-                          ADSP1_SYS_ENA, 0);
-err_mutex:
-       mutex_unlock(&dsp->pwr_lock);
-
-       return ret;
-}
-EXPORT_SYMBOL_GPL(wm_adsp1_event);
-
-static int wm_adsp2v2_enable_core(struct wm_adsp *dsp)
-{
-       unsigned int val;
-       int ret, count;
-
-       /* Wait for the RAM to start, should be near instantaneous */
-       for (count = 0; count < 10; ++count) {
-               ret = regmap_read(dsp->regmap, dsp->base + ADSP2_STATUS1, &val);
-               if (ret != 0)
-                       return ret;
-
-               if (val & ADSP2_RAM_RDY)
-                       break;
-
-               usleep_range(250, 500);
-       }
-
-       if (!(val & ADSP2_RAM_RDY)) {
-               adsp_err(dsp, "Failed to start DSP RAM\n");
-               return -EBUSY;
-       }
-
-       adsp_dbg(dsp, "RAM ready after %d polls\n", count);
-
-       return 0;
-}
-
-static int wm_adsp2_enable_core(struct wm_adsp *dsp)
-{
-       int ret;
-
-       ret = regmap_update_bits_async(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                                      ADSP2_SYS_ENA, ADSP2_SYS_ENA);
-       if (ret != 0)
-               return ret;
-
-       return wm_adsp2v2_enable_core(dsp);
-}
-
-static int wm_adsp2_lock(struct wm_adsp *dsp, unsigned int lock_regions)
-{
-       struct regmap *regmap = dsp->regmap;
-       unsigned int code0, code1, lock_reg;
-
-       if (!(lock_regions & WM_ADSP2_REGION_ALL))
-               return 0;
-
-       lock_regions &= WM_ADSP2_REGION_ALL;
-       lock_reg = dsp->base + ADSP2_LOCK_REGION_1_LOCK_REGION_0;
-
-       while (lock_regions) {
-               code0 = code1 = 0;
-               if (lock_regions & BIT(0)) {
-                       code0 = ADSP2_LOCK_CODE_0;
-                       code1 = ADSP2_LOCK_CODE_1;
-               }
-               if (lock_regions & BIT(1)) {
-                       code0 |= ADSP2_LOCK_CODE_0 << ADSP2_LOCK_REGION_SHIFT;
-                       code1 |= ADSP2_LOCK_CODE_1 << ADSP2_LOCK_REGION_SHIFT;
-               }
-               regmap_write(regmap, lock_reg, code0);
-               regmap_write(regmap, lock_reg, code1);
-               lock_regions >>= 2;
-               lock_reg += 2;
-       }
-
-       return 0;
-}
-
-static int wm_adsp2_enable_memory(struct wm_adsp *dsp)
-{
-       return regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                                 ADSP2_MEM_ENA, ADSP2_MEM_ENA);
-}
-
-static void wm_adsp2_disable_memory(struct wm_adsp *dsp)
-{
-       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                          ADSP2_MEM_ENA, 0);
-}
-
-static void wm_adsp2_disable_core(struct wm_adsp *dsp)
-{
-       regmap_write(dsp->regmap, dsp->base + ADSP2_RDMA_CONFIG_1, 0);
-       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_1, 0);
-       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_2, 0);
-
-       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                          ADSP2_SYS_ENA, 0);
 }
 
-static void wm_adsp2v2_disable_core(struct wm_adsp *dsp)
+static int wm_adsp_common_init(struct wm_adsp *dsp)
 {
-       regmap_write(dsp->regmap, dsp->base + ADSP2_RDMA_CONFIG_1, 0);
-       regmap_write(dsp->regmap, dsp->base + ADSP2_WDMA_CONFIG_1, 0);
-       regmap_write(dsp->regmap, dsp->base + ADSP2V2_WDMA_CONFIG_2, 0);
-}
+       char *p;
 
-static void wm_adsp_boot_work(struct work_struct *work)
-{
-       struct wm_adsp *dsp = container_of(work,
-                                          struct wm_adsp,
-                                          boot_work);
-       int ret;
+       INIT_LIST_HEAD(&dsp->compr_list);
+       INIT_LIST_HEAD(&dsp->buffer_list);
 
-       mutex_lock(&dsp->pwr_lock);
+       if (!dsp->fwf_name) {
+               p = devm_kstrdup(dsp->cs_dsp.dev, dsp->cs_dsp.name, GFP_KERNEL);
+               if (!p)
+                       return -ENOMEM;
 
-       if (dsp->ops->enable_memory) {
-               ret = dsp->ops->enable_memory(dsp);
-               if (ret != 0)
-                       goto err_mutex;
+               dsp->fwf_name = p;
+               for (; *p != 0; ++p)
+                       *p = tolower(*p);
        }
 
-       if (dsp->ops->enable_core) {
-               ret = dsp->ops->enable_core(dsp);
-               if (ret != 0)
-                       goto err_mem;
-       }
+       return 0;
+}
 
-       ret = wm_adsp_load(dsp);
-       if (ret != 0)
-               goto err_ena;
+int wm_adsp1_init(struct wm_adsp *dsp)
+{
+       int ret;
 
-       ret = dsp->ops->setup_algs(dsp);
-       if (ret != 0)
-               goto err_ena;
+       dsp->cs_dsp.client_ops = &wm_adsp1_client_ops;
 
-       ret = wm_adsp_load_coeff(dsp);
-       if (ret != 0)
-               goto err_ena;
+       ret = cs_dsp_adsp1_init(&dsp->cs_dsp);
+       if (ret)
+               return ret;
 
-       /* Initialize caches for enabled and unset controls */
-       ret = wm_coeff_init_control_caches(dsp);
-       if (ret != 0)
-               goto err_ena;
+       return wm_adsp_common_init(dsp);
+}
+EXPORT_SYMBOL_GPL(wm_adsp1_init);
 
-       if (dsp->ops->disable_core)
-               dsp->ops->disable_core(dsp);
+int wm_adsp1_event(struct snd_soc_dapm_widget *w,
+                  struct snd_kcontrol *kcontrol,
+                  int event)
+{
+       struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
+       struct wm_adsp *dsps = snd_soc_component_get_drvdata(component);
+       struct wm_adsp *dsp = &dsps[w->shift];
+       int ret = 0;
+       char *wmfw_filename = NULL;
+       const struct firmware *wmfw_firmware = NULL;
+       char *coeff_filename = NULL;
+       const struct firmware *coeff_firmware = NULL;
 
-       dsp->booted = true;
+       dsp->component = component;
 
-       mutex_unlock(&dsp->pwr_lock);
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               ret = wm_adsp_request_firmware_files(dsp,
+                                                    &wmfw_firmware, &wmfw_filename,
+                                                    &coeff_firmware, &coeff_filename);
+               if (ret)
+                       break;
 
-       return;
+               ret = cs_dsp_adsp1_power_up(&dsp->cs_dsp,
+                                           wmfw_firmware, wmfw_filename,
+                                           coeff_firmware, coeff_filename,
+                                           wm_adsp_fw_text[dsp->fw]);
 
-err_ena:
-       if (dsp->ops->disable_core)
-               dsp->ops->disable_core(dsp);
-err_mem:
-       if (dsp->ops->disable_memory)
-               dsp->ops->disable_memory(dsp);
-err_mutex:
-       mutex_unlock(&dsp->pwr_lock);
-}
+               wm_adsp_release_firmware_files(dsp,
+                                              wmfw_firmware, wmfw_filename,
+                                              coeff_firmware, coeff_filename);
+               break;
+       case SND_SOC_DAPM_PRE_PMD:
+               cs_dsp_adsp1_power_down(&dsp->cs_dsp);
+               break;
+       default:
+               break;
+       }
 
-static int wm_halo_configure_mpu(struct wm_adsp *dsp, unsigned int lock_regions)
-{
-       struct reg_sequence config[] = {
-               { dsp->base + HALO_MPU_LOCK_CONFIG,     0x5555 },
-               { dsp->base + HALO_MPU_LOCK_CONFIG,     0xAAAA },
-               { dsp->base + HALO_MPU_XMEM_ACCESS_0,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_YMEM_ACCESS_0,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_WINDOW_ACCESS_0, lock_regions },
-               { dsp->base + HALO_MPU_XREG_ACCESS_0,   lock_regions },
-               { dsp->base + HALO_MPU_YREG_ACCESS_0,   lock_regions },
-               { dsp->base + HALO_MPU_XMEM_ACCESS_1,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_YMEM_ACCESS_1,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_WINDOW_ACCESS_1, lock_regions },
-               { dsp->base + HALO_MPU_XREG_ACCESS_1,   lock_regions },
-               { dsp->base + HALO_MPU_YREG_ACCESS_1,   lock_regions },
-               { dsp->base + HALO_MPU_XMEM_ACCESS_2,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_YMEM_ACCESS_2,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_WINDOW_ACCESS_2, lock_regions },
-               { dsp->base + HALO_MPU_XREG_ACCESS_2,   lock_regions },
-               { dsp->base + HALO_MPU_YREG_ACCESS_2,   lock_regions },
-               { dsp->base + HALO_MPU_XMEM_ACCESS_3,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_YMEM_ACCESS_3,   0xFFFFFFFF },
-               { dsp->base + HALO_MPU_WINDOW_ACCESS_3, lock_regions },
-               { dsp->base + HALO_MPU_XREG_ACCESS_3,   lock_regions },
-               { dsp->base + HALO_MPU_YREG_ACCESS_3,   lock_regions },
-               { dsp->base + HALO_MPU_LOCK_CONFIG,     0 },
-       };
-
-       return regmap_multi_reg_write(dsp->regmap, config, ARRAY_SIZE(config));
+       return ret;
 }
+EXPORT_SYMBOL_GPL(wm_adsp1_event);
 
 int wm_adsp2_set_dspclk(struct snd_soc_dapm_widget *w, unsigned int freq)
 {
        struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
        struct wm_adsp *dsps = snd_soc_component_get_drvdata(component);
        struct wm_adsp *dsp = &dsps[w->shift];
-       int ret;
 
-       ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CLOCKING,
-                                ADSP2_CLK_SEL_MASK,
-                                freq << ADSP2_CLK_SEL_SHIFT);
-       if (ret)
-               adsp_err(dsp, "Failed to set clock rate: %d\n", ret);
-
-       return ret;
+       return cs_dsp_set_dspclk(&dsp->cs_dsp, freq);
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_set_dspclk);
 
@@ -3145,7 +910,7 @@ int wm_adsp2_preloader_put(struct snd_kcontrol *kcontrol,
        struct wm_adsp *dsp = &dsps[mc->shift - 1];
        char preload[32];
 
-       snprintf(preload, ARRAY_SIZE(preload), "%s Preload", dsp->name);
+       snprintf(preload, ARRAY_SIZE(preload), "%s Preload", dsp->cs_dsp.name);
 
        dsp->preloaded = ucontrol->value.integer.value[0];
 
@@ -3162,16 +927,31 @@ int wm_adsp2_preloader_put(struct snd_kcontrol *kcontrol,
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_preloader_put);
 
-static void wm_adsp_stop_watchdog(struct wm_adsp *dsp)
+static void wm_adsp_boot_work(struct work_struct *work)
 {
-       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_WATCHDOG,
-                          ADSP2_WDT_ENA_MASK, 0);
-}
+       struct wm_adsp *dsp = container_of(work,
+                                          struct wm_adsp,
+                                          boot_work);
+       int ret = 0;
+       char *wmfw_filename = NULL;
+       const struct firmware *wmfw_firmware = NULL;
+       char *coeff_filename = NULL;
+       const struct firmware *coeff_firmware = NULL;
+
+       ret = wm_adsp_request_firmware_files(dsp,
+                                            &wmfw_firmware, &wmfw_filename,
+                                            &coeff_firmware, &coeff_filename);
+       if (ret)
+               return;
 
-static void wm_halo_stop_watchdog(struct wm_adsp *dsp)
-{
-       regmap_update_bits(dsp->regmap, dsp->base + HALO_WDT_CONTROL,
-                          HALO_WDT_EN_MASK, 0);
+       cs_dsp_power_up(&dsp->cs_dsp,
+                       wmfw_firmware, wmfw_filename,
+                       coeff_firmware, coeff_filename,
+                       wm_adsp_fw_text[dsp->fw]);
+
+       wm_adsp_release_firmware_files(dsp,
+                                      wmfw_firmware, wmfw_filename,
+                                      coeff_firmware, coeff_filename);
 }
 
 int wm_adsp_early_event(struct snd_soc_dapm_widget *w,
@@ -3180,33 +960,13 @@ int wm_adsp_early_event(struct snd_soc_dapm_widget *w,
        struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
        struct wm_adsp *dsps = snd_soc_component_get_drvdata(component);
        struct wm_adsp *dsp = &dsps[w->shift];
-       struct wm_coeff_ctl *ctl;
 
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
                queue_work(system_unbound_wq, &dsp->boot_work);
                break;
        case SND_SOC_DAPM_PRE_PMD:
-               mutex_lock(&dsp->pwr_lock);
-
-               wm_adsp_debugfs_clear(dsp);
-
-               dsp->fw_id = 0;
-               dsp->fw_id_version = 0;
-
-               dsp->booted = false;
-
-               if (dsp->ops->disable_memory)
-                       dsp->ops->disable_memory(dsp);
-
-               list_for_each_entry(ctl, &dsp->ctl_list, list)
-                       ctl->enabled = 0;
-
-               wm_adsp_free_alg_regions(dsp);
-
-               mutex_unlock(&dsp->pwr_lock);
-
-               adsp_dbg(dsp, "Shutdown complete\n");
+               cs_dsp_power_down(&dsp->cs_dsp);
                break;
        default:
                break;
@@ -3216,17 +976,24 @@ int wm_adsp_early_event(struct snd_soc_dapm_widget *w,
 }
 EXPORT_SYMBOL_GPL(wm_adsp_early_event);
 
-static int wm_adsp2_start_core(struct wm_adsp *dsp)
+static int wm_adsp_event_post_run(struct cs_dsp *cs_dsp)
 {
-       return regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                                ADSP2_CORE_ENA | ADSP2_START,
-                                ADSP2_CORE_ENA | ADSP2_START);
+       struct wm_adsp *dsp = container_of(cs_dsp, struct wm_adsp, cs_dsp);
+
+       if (wm_adsp_fw[dsp->fw].num_caps != 0)
+               return wm_adsp_buffer_init(dsp);
+
+       return 0;
 }
 
-static void wm_adsp2_stop_core(struct wm_adsp *dsp)
+static void wm_adsp_event_post_stop(struct cs_dsp *cs_dsp)
 {
-       regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                          ADSP2_CORE_ENA | ADSP2_START, 0);
+       struct wm_adsp *dsp = container_of(cs_dsp, struct wm_adsp, cs_dsp);
+
+       if (wm_adsp_fw[dsp->fw].num_caps != 0)
+               wm_adsp_buffer_free(dsp);
+
+       dsp->fatal_error = false;
 }
 
 int wm_adsp_event(struct snd_soc_dapm_widget *w,
@@ -3235,127 +1002,32 @@ int wm_adsp_event(struct snd_soc_dapm_widget *w,
        struct snd_soc_component *component = snd_soc_dapm_to_component(w->dapm);
        struct wm_adsp *dsps = snd_soc_component_get_drvdata(component);
        struct wm_adsp *dsp = &dsps[w->shift];
-       int ret;
+       int ret = 0;
 
        switch (event) {
        case SND_SOC_DAPM_POST_PMU:
                flush_work(&dsp->boot_work);
-
-               mutex_lock(&dsp->pwr_lock);
-
-               if (!dsp->booted) {
-                       ret = -EIO;
-                       goto err;
-               }
-
-               if (dsp->ops->enable_core) {
-                       ret = dsp->ops->enable_core(dsp);
-                       if (ret != 0)
-                               goto err;
-               }
-
-               /* Sync set controls */
-               ret = wm_coeff_sync_controls(dsp);
-               if (ret != 0)
-                       goto err;
-
-               if (dsp->ops->lock_memory) {
-                       ret = dsp->ops->lock_memory(dsp, dsp->lock_regions);
-                       if (ret != 0) {
-                               adsp_err(dsp, "Error configuring MPU: %d\n",
-                                        ret);
-                               goto err;
-                       }
-               }
-
-               if (dsp->ops->start_core) {
-                       ret = dsp->ops->start_core(dsp);
-                       if (ret != 0)
-                               goto err;
-               }
-
-               if (wm_adsp_fw[dsp->fw].num_caps != 0) {
-                       ret = wm_adsp_buffer_init(dsp);
-                       if (ret < 0)
-                               goto err;
-               }
-
-               dsp->running = true;
-
-               mutex_unlock(&dsp->pwr_lock);
+               ret = cs_dsp_run(&dsp->cs_dsp);
                break;
-
        case SND_SOC_DAPM_PRE_PMD:
-               /* Tell the firmware to cleanup */
-               wm_adsp_signal_event_controls(dsp, WM_ADSP_FW_EVENT_SHUTDOWN);
-
-               if (dsp->ops->stop_watchdog)
-                       dsp->ops->stop_watchdog(dsp);
-
-               /* Log firmware state, it can be useful for analysis */
-               if (dsp->ops->show_fw_status)
-                       dsp->ops->show_fw_status(dsp);
-
-               mutex_lock(&dsp->pwr_lock);
-
-               dsp->running = false;
-
-               if (dsp->ops->stop_core)
-                       dsp->ops->stop_core(dsp);
-               if (dsp->ops->disable_core)
-                       dsp->ops->disable_core(dsp);
-
-               if (wm_adsp_fw[dsp->fw].num_caps != 0)
-                       wm_adsp_buffer_free(dsp);
-
-               dsp->fatal_error = false;
-
-               mutex_unlock(&dsp->pwr_lock);
-
-               adsp_dbg(dsp, "Execution stopped\n");
+               cs_dsp_stop(&dsp->cs_dsp);
                break;
-
        default:
                break;
        }
 
-       return 0;
-err:
-       if (dsp->ops->stop_core)
-               dsp->ops->stop_core(dsp);
-       if (dsp->ops->disable_core)
-               dsp->ops->disable_core(dsp);
-       mutex_unlock(&dsp->pwr_lock);
        return ret;
 }
 EXPORT_SYMBOL_GPL(wm_adsp_event);
 
-static int wm_halo_start_core(struct wm_adsp *dsp)
-{
-       return regmap_update_bits(dsp->regmap,
-                                 dsp->base + HALO_CCM_CORE_CONTROL,
-                                 HALO_CORE_RESET | HALO_CORE_EN,
-                                 HALO_CORE_RESET | HALO_CORE_EN);
-}
-
-static void wm_halo_stop_core(struct wm_adsp *dsp)
-{
-       regmap_update_bits(dsp->regmap, dsp->base + HALO_CCM_CORE_CONTROL,
-                          HALO_CORE_EN, 0);
-
-       /* reset halo core with CORE_SOFT_RESET */
-       regmap_update_bits(dsp->regmap, dsp->base + HALO_CORE_SOFT_RESET,
-                          HALO_CORE_SOFT_RESET_MASK, 1);
-}
-
 int wm_adsp2_component_probe(struct wm_adsp *dsp, struct snd_soc_component *component)
 {
        char preload[32];
 
-       snprintf(preload, ARRAY_SIZE(preload), "%s Preload", dsp->name);
+       snprintf(preload, ARRAY_SIZE(preload), "%s Preload", dsp->cs_dsp.name);
        snd_soc_component_disable_pin(component, preload);
 
-       wm_adsp2_init_debugfs(dsp, component);
+       cs_dsp_init_debugfs(&dsp->cs_dsp, component->debugfs_root);
 
        dsp->component = component;
 
@@ -3365,7 +1037,7 @@ EXPORT_SYMBOL_GPL(wm_adsp2_component_probe);
 
 int wm_adsp2_component_remove(struct wm_adsp *dsp, struct snd_soc_component *component)
 {
-       wm_adsp2_cleanup_debugfs(dsp);
+       cs_dsp_cleanup_debugfs(&dsp->cs_dsp);
 
        return 0;
 }
@@ -3375,37 +1047,16 @@ int wm_adsp2_init(struct wm_adsp *dsp)
 {
        int ret;
 
-       ret = wm_adsp_common_init(dsp);
-       if (ret)
-               return ret;
-
-       switch (dsp->rev) {
-       case 0:
-               /*
-                * Disable the DSP memory by default when in reset for a small
-                * power saving.
-                */
-               ret = regmap_update_bits(dsp->regmap, dsp->base + ADSP2_CONTROL,
-                                        ADSP2_MEM_ENA, 0);
-               if (ret) {
-                       adsp_err(dsp,
-                                "Failed to clear memory retention: %d\n", ret);
-                       return ret;
-               }
+       INIT_WORK(&dsp->boot_work, wm_adsp_boot_work);
 
-               dsp->ops = &wm_adsp2_ops[0];
-               break;
-       case 1:
-               dsp->ops = &wm_adsp2_ops[1];
-               break;
-       default:
-               dsp->ops = &wm_adsp2_ops[2];
-               break;
-       }
+       dsp->sys_config_size = sizeof(struct wm_adsp_system_config_xm_hdr);
+       dsp->cs_dsp.client_ops = &wm_adsp2_client_ops;
 
-       INIT_WORK(&dsp->boot_work, wm_adsp_boot_work);
+       ret = cs_dsp_adsp2_init(&dsp->cs_dsp);
+       if (ret)
+               return ret;
 
-       return 0;
+       return wm_adsp_common_init(dsp);
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_init);
 
@@ -3413,28 +1064,22 @@ int wm_halo_init(struct wm_adsp *dsp)
 {
        int ret;
 
-       ret = wm_adsp_common_init(dsp);
-       if (ret)
-               return ret;
+       INIT_WORK(&dsp->boot_work, wm_adsp_boot_work);
 
-       dsp->ops = &wm_halo_ops;
+       dsp->sys_config_size = sizeof(struct wm_halo_system_config_xm_hdr);
+       dsp->cs_dsp.client_ops = &wm_adsp2_client_ops;
 
-       INIT_WORK(&dsp->boot_work, wm_adsp_boot_work);
+       ret = cs_dsp_halo_init(&dsp->cs_dsp);
+       if (ret)
+               return ret;
 
-       return 0;
+       return wm_adsp_common_init(dsp);
 }
 EXPORT_SYMBOL_GPL(wm_halo_init);
 
 void wm_adsp2_remove(struct wm_adsp *dsp)
 {
-       struct wm_coeff_ctl *ctl;
-
-       while (!list_empty(&dsp->ctl_list)) {
-               ctl = list_first_entry(&dsp->ctl_list, struct wm_coeff_ctl,
-                                       list);
-               list_del(&ctl->list);
-               wm_adsp_free_ctl_blk(ctl);
-       }
+       cs_dsp_remove(&dsp->cs_dsp);
 }
 EXPORT_SYMBOL_GPL(wm_adsp2_remove);
 
@@ -3487,7 +1132,7 @@ int wm_adsp_compr_open(struct wm_adsp *dsp, struct snd_compr_stream *stream)
        struct snd_soc_pcm_runtime *rtd = stream->private_data;
        int ret = 0;
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        if (wm_adsp_fw[dsp->fw].num_caps == 0) {
                adsp_err(dsp, "%s: Firmware does not support compressed API\n",
@@ -3527,7 +1172,7 @@ int wm_adsp_compr_open(struct wm_adsp *dsp, struct snd_compr_stream *stream)
        stream->runtime->private_data = compr;
 
 out:
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return ret;
 }
@@ -3539,7 +1184,7 @@ int wm_adsp_compr_free(struct snd_soc_component *component,
        struct wm_adsp_compr *compr = stream->runtime->private_data;
        struct wm_adsp *dsp = compr->dsp;
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        wm_adsp_compr_detach(compr);
        list_del(&compr->list);
@@ -3547,7 +1192,7 @@ int wm_adsp_compr_free(struct snd_soc_component *component,
        kfree(compr->raw_buf);
        kfree(compr);
 
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return 0;
 }
@@ -3566,7 +1211,7 @@ static int wm_adsp_compr_check_params(struct snd_compr_stream *stream,
            params->buffer.fragment_size > WM_ADSP_MAX_FRAGMENT_SIZE ||
            params->buffer.fragments < WM_ADSP_MIN_FRAGMENTS ||
            params->buffer.fragments > WM_ADSP_MAX_FRAGMENTS ||
-           params->buffer.fragment_size % WM_ADSP_DATA_WORD_SIZE) {
+           params->buffer.fragment_size % CS_DSP_DATA_WORD_SIZE) {
                compr_err(compr, "Invalid buffer fragsize=%d fragments=%d\n",
                          params->buffer.fragment_size,
                          params->buffer.fragments);
@@ -3605,7 +1250,7 @@ static int wm_adsp_compr_check_params(struct snd_compr_stream *stream,
 
 static inline unsigned int wm_adsp_compr_frag_words(struct wm_adsp_compr *compr)
 {
-       return compr->size.fragment_size / WM_ADSP_DATA_WORD_SIZE;
+       return compr->size.fragment_size / CS_DSP_DATA_WORD_SIZE;
 }
 
 int wm_adsp_compr_set_params(struct snd_soc_component *component,
@@ -3661,88 +1306,19 @@ int wm_adsp_compr_get_caps(struct snd_soc_component *component,
 }
 EXPORT_SYMBOL_GPL(wm_adsp_compr_get_caps);
 
-static int wm_adsp_read_raw_data_block(struct wm_adsp *dsp, int mem_type,
-                                      unsigned int mem_addr,
-                                      unsigned int num_words, __be32 *data)
-{
-       struct wm_adsp_region const *mem = wm_adsp_find_region(dsp, mem_type);
-       unsigned int reg;
-       int ret;
-
-       if (!mem)
-               return -EINVAL;
-
-       reg = dsp->ops->region_to_reg(mem, mem_addr);
-
-       ret = regmap_raw_read(dsp->regmap, reg, data,
-                             sizeof(*data) * num_words);
-       if (ret < 0)
-               return ret;
-
-       return 0;
-}
-
-static inline int wm_adsp_read_data_word(struct wm_adsp *dsp, int mem_type,
-                                        unsigned int mem_addr, u32 *data)
-{
-       __be32 raw;
-       int ret;
-
-       ret = wm_adsp_read_raw_data_block(dsp, mem_type, mem_addr, 1, &raw);
-       if (ret < 0)
-               return ret;
-
-       *data = be32_to_cpu(raw) & 0x00ffffffu;
-
-       return 0;
-}
-
-static int wm_adsp_write_data_word(struct wm_adsp *dsp, int mem_type,
-                                  unsigned int mem_addr, u32 data)
-{
-       struct wm_adsp_region const *mem = wm_adsp_find_region(dsp, mem_type);
-       __be32 val = cpu_to_be32(data & 0x00ffffffu);
-       unsigned int reg;
-
-       if (!mem)
-               return -EINVAL;
-
-       reg = dsp->ops->region_to_reg(mem, mem_addr);
-
-       return regmap_raw_write(dsp->regmap, reg, &val, sizeof(val));
-}
-
 static inline int wm_adsp_buffer_read(struct wm_adsp_compr_buf *buf,
                                      unsigned int field_offset, u32 *data)
 {
-       return wm_adsp_read_data_word(buf->dsp, buf->host_buf_mem_type,
-                                     buf->host_buf_ptr + field_offset, data);
+       return cs_dsp_read_data_word(&buf->dsp->cs_dsp, buf->host_buf_mem_type,
+                                    buf->host_buf_ptr + field_offset, data);
 }
 
 static inline int wm_adsp_buffer_write(struct wm_adsp_compr_buf *buf,
                                       unsigned int field_offset, u32 data)
 {
-       return wm_adsp_write_data_word(buf->dsp, buf->host_buf_mem_type,
-                                      buf->host_buf_ptr + field_offset, data);
-}
-
-static void wm_adsp_remove_padding(u32 *buf, int nwords)
-{
-       const __be32 *pack_in = (__be32 *)buf;
-       u8 *pack_out = (u8 *)buf;
-       int i;
-
-       /*
-        * DSP words from the register map have pad bytes and the data bytes
-        * are in swapped order. This swaps back to the original little-endian
-        * order and strips the pad bytes.
-        */
-       for (i = 0; i < nwords; i++) {
-               u32 word = be32_to_cpu(*pack_in++);
-               *pack_out++ = (u8)word;
-               *pack_out++ = (u8)(word >> 8);
-               *pack_out++ = (u8)(word >> 16);
-       }
+       return cs_dsp_write_data_word(&buf->dsp->cs_dsp, buf->host_buf_mem_type,
+                                     buf->host_buf_ptr + field_offset,
+                                     data);
 }
 
 static int wm_adsp_buffer_populate(struct wm_adsp_compr_buf *buf)
@@ -3810,12 +1386,12 @@ static struct wm_adsp_compr_buf *wm_adsp_buffer_alloc(struct wm_adsp *dsp)
 
 static int wm_adsp_buffer_parse_legacy(struct wm_adsp *dsp)
 {
-       struct wm_adsp_alg_region *alg_region;
+       struct cs_dsp_alg_region *alg_region;
        struct wm_adsp_compr_buf *buf;
        u32 xmalg, addr, magic;
        int i, ret;
 
-       alg_region = wm_adsp_find_alg_region(dsp, WMFW_ADSP2_XM, dsp->fw_id);
+       alg_region = cs_dsp_find_alg_region(&dsp->cs_dsp, WMFW_ADSP2_XM, dsp->cs_dsp.fw_id);
        if (!alg_region) {
                adsp_err(dsp, "No algorithm region found\n");
                return -EINVAL;
@@ -3825,10 +1401,10 @@ static int wm_adsp_buffer_parse_legacy(struct wm_adsp *dsp)
        if (!buf)
                return -ENOMEM;
 
-       xmalg = dsp->ops->sys_config_size / sizeof(__be32);
+       xmalg = dsp->sys_config_size / sizeof(__be32);
 
        addr = alg_region->base + xmalg + ALG_XM_FIELD(magic);
-       ret = wm_adsp_read_data_word(dsp, WMFW_ADSP2_XM, addr, &magic);
+       ret = cs_dsp_read_data_word(&dsp->cs_dsp, WMFW_ADSP2_XM, addr, &magic);
        if (ret < 0)
                return ret;
 
@@ -3837,8 +1413,8 @@ static int wm_adsp_buffer_parse_legacy(struct wm_adsp *dsp)
 
        addr = alg_region->base + xmalg + ALG_XM_FIELD(host_buf_ptr);
        for (i = 0; i < 5; ++i) {
-               ret = wm_adsp_read_data_word(dsp, WMFW_ADSP2_XM, addr,
-                                            &buf->host_buf_ptr);
+               ret = cs_dsp_read_data_word(&dsp->cs_dsp, WMFW_ADSP2_XM, addr,
+                                           &buf->host_buf_ptr);
                if (ret < 0)
                        return ret;
 
@@ -3862,40 +1438,36 @@ static int wm_adsp_buffer_parse_legacy(struct wm_adsp *dsp)
        return 0;
 }
 
-static int wm_adsp_buffer_parse_coeff(struct wm_coeff_ctl *ctl)
+static int wm_adsp_buffer_parse_coeff(struct cs_dsp_coeff_ctl *cs_ctl)
 {
        struct wm_adsp_host_buf_coeff_v1 coeff_v1;
        struct wm_adsp_compr_buf *buf;
-       unsigned int reg, version;
-       __be32 bufp;
+       struct wm_adsp *dsp = container_of(cs_ctl->dsp, struct wm_adsp, cs_dsp);
+       unsigned int version;
        int ret, i;
 
-       ret = wm_coeff_base_reg(ctl, &reg);
-       if (ret)
-               return ret;
-
        for (i = 0; i < 5; ++i) {
-               ret = regmap_raw_read(ctl->dsp->regmap, reg, &bufp, sizeof(bufp));
+               ret = cs_dsp_coeff_read_ctrl(cs_ctl, &coeff_v1, sizeof(coeff_v1));
                if (ret < 0)
                        return ret;
 
-               if (bufp)
+               if (coeff_v1.host_buf_ptr)
                        break;
 
                usleep_range(1000, 2000);
        }
 
-       if (!bufp) {
-               adsp_err(ctl->dsp, "Failed to acquire host buffer\n");
+       if (!coeff_v1.host_buf_ptr) {
+               adsp_err(dsp, "Failed to acquire host buffer\n");
                return -EIO;
        }
 
-       buf = wm_adsp_buffer_alloc(ctl->dsp);
+       buf = wm_adsp_buffer_alloc(dsp);
        if (!buf)
                return -ENOMEM;
 
-       buf->host_buf_mem_type = ctl->alg_region.type;
-       buf->host_buf_ptr = be32_to_cpu(bufp);
+       buf->host_buf_mem_type = cs_ctl->alg_region.type;
+       buf->host_buf_ptr = be32_to_cpu(coeff_v1.host_buf_ptr);
 
        ret = wm_adsp_buffer_populate(buf);
        if (ret < 0)
@@ -3905,29 +1477,24 @@ static int wm_adsp_buffer_parse_coeff(struct wm_coeff_ctl *ctl)
         * v0 host_buffer coefficients didn't have versioning, so if the
         * control is one word, assume version 0.
         */
-       if (ctl->len == 4) {
+       if (cs_ctl->len == 4) {
                compr_dbg(buf, "host_buf_ptr=%x\n", buf->host_buf_ptr);
                return 0;
        }
 
-       ret = regmap_raw_read(ctl->dsp->regmap, reg, &coeff_v1,
-                             sizeof(coeff_v1));
-       if (ret < 0)
-               return ret;
-
        version = be32_to_cpu(coeff_v1.versions) & HOST_BUF_COEFF_COMPAT_VER_MASK;
        version >>= HOST_BUF_COEFF_COMPAT_VER_SHIFT;
 
        if (version > HOST_BUF_COEFF_SUPPORTED_COMPAT_VER) {
-               adsp_err(ctl->dsp,
+               adsp_err(dsp,
                         "Host buffer coeff ver %u > supported version %u\n",
                         version, HOST_BUF_COEFF_SUPPORTED_COMPAT_VER);
                return -EINVAL;
        }
 
-       wm_adsp_remove_padding((u32 *)&coeff_v1.name, ARRAY_SIZE(coeff_v1.name));
+       cs_dsp_remove_padding((u32 *)&coeff_v1.name, ARRAY_SIZE(coeff_v1.name));
 
-       buf->name = kasprintf(GFP_KERNEL, "%s-dsp-%s", ctl->dsp->part,
+       buf->name = kasprintf(GFP_KERNEL, "%s-dsp-%s", dsp->part,
                              (char *)&coeff_v1.name);
 
        compr_dbg(buf, "host_buf_ptr=%x coeff version %u\n",
@@ -3938,17 +1505,17 @@ static int wm_adsp_buffer_parse_coeff(struct wm_coeff_ctl *ctl)
 
 static int wm_adsp_buffer_init(struct wm_adsp *dsp)
 {
-       struct wm_coeff_ctl *ctl;
+       struct cs_dsp_coeff_ctl *cs_ctl;
        int ret;
 
-       list_for_each_entry(ctl, &dsp->ctl_list, list) {
-               if (ctl->type != WMFW_CTL_TYPE_HOST_BUFFER)
+       list_for_each_entry(cs_ctl, &dsp->cs_dsp.ctl_list, list) {
+               if (cs_ctl->type != WMFW_CTL_TYPE_HOST_BUFFER)
                        continue;
 
-               if (!ctl->enabled)
+               if (!cs_ctl->enabled)
                        continue;
 
-               ret = wm_adsp_buffer_parse_coeff(ctl);
+               ret = wm_adsp_buffer_parse_coeff(cs_ctl);
                if (ret < 0) {
                        adsp_err(dsp, "Failed to parse coeff: %d\n", ret);
                        goto error;
@@ -4016,7 +1583,7 @@ int wm_adsp_compr_trigger(struct snd_soc_component *component,
 
        compr_dbg(compr, "Trigger: %d\n", cmd);
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        switch (cmd) {
        case SNDRV_PCM_TRIGGER_START:
@@ -4052,7 +1619,7 @@ int wm_adsp_compr_trigger(struct snd_soc_component *component,
                break;
        }
 
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return ret;
 }
@@ -4101,7 +1668,7 @@ static int wm_adsp_buffer_update_avail(struct wm_adsp_compr_buf *buf)
                avail += wm_adsp_buffer_size(buf);
 
        compr_dbg(buf, "readindex=0x%x, writeindex=0x%x, avail=%d\n",
-                 buf->read_index, write_index, avail * WM_ADSP_DATA_WORD_SIZE);
+                 buf->read_index, write_index, avail * CS_DSP_DATA_WORD_SIZE);
 
        buf->avail = avail;
 
@@ -4114,7 +1681,7 @@ int wm_adsp_compr_handle_irq(struct wm_adsp *dsp)
        struct wm_adsp_compr *compr;
        int ret = 0;
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        if (list_empty(&dsp->buffer_list)) {
                ret = -ENODEV;
@@ -4152,7 +1719,7 @@ out_notify:
        }
 
 out:
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return ret;
 }
@@ -4182,7 +1749,7 @@ int wm_adsp_compr_pointer(struct snd_soc_component *component,
 
        compr_dbg(compr, "Pointer request\n");
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        buf = compr->buf;
 
@@ -4222,11 +1789,11 @@ int wm_adsp_compr_pointer(struct snd_soc_component *component,
        }
 
        tstamp->copied_total = compr->copied_total;
-       tstamp->copied_total += buf->avail * WM_ADSP_DATA_WORD_SIZE;
+       tstamp->copied_total += buf->avail * CS_DSP_DATA_WORD_SIZE;
        tstamp->sampling_rate = compr->sample_rate;
 
 out:
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return ret;
 }
@@ -4264,12 +1831,12 @@ static int wm_adsp_buffer_capture_block(struct wm_adsp_compr *compr, int target)
                return 0;
 
        /* Read data from DSP */
-       ret = wm_adsp_read_raw_data_block(buf->dsp, mem_type, adsp_addr,
-                                         nwords, (__be32 *)compr->raw_buf);
+       ret = cs_dsp_read_raw_data_block(&buf->dsp->cs_dsp, mem_type, adsp_addr,
+                                        nwords, (__be32 *)compr->raw_buf);
        if (ret < 0)
                return ret;
 
-       wm_adsp_remove_padding(compr->raw_buf, nwords);
+       cs_dsp_remove_padding(compr->raw_buf, nwords);
 
        /* update read index to account for words read */
        buf->read_index += nwords;
@@ -4301,7 +1868,7 @@ static int wm_adsp_compr_read(struct wm_adsp_compr *compr,
                return -EIO;
        }
 
-       count /= WM_ADSP_DATA_WORD_SIZE;
+       count /= CS_DSP_DATA_WORD_SIZE;
 
        do {
                nwords = wm_adsp_buffer_capture_block(compr, count);
@@ -4311,7 +1878,7 @@ static int wm_adsp_compr_read(struct wm_adsp_compr *compr,
                        return nwords;
                }
 
-               nbytes = nwords * WM_ADSP_DATA_WORD_SIZE;
+               nbytes = nwords * CS_DSP_DATA_WORD_SIZE;
 
                compr_dbg(compr, "Read %d bytes\n", nbytes);
 
@@ -4338,21 +1905,22 @@ int wm_adsp_compr_copy(struct snd_soc_component *component,
        struct wm_adsp *dsp = compr->dsp;
        int ret;
 
-       mutex_lock(&dsp->pwr_lock);
+       mutex_lock(&dsp->cs_dsp.pwr_lock);
 
        if (stream->direction == SND_COMPRESS_CAPTURE)
                ret = wm_adsp_compr_read(compr, buf, count);
        else
                ret = -ENOTSUPP;
 
-       mutex_unlock(&dsp->pwr_lock);
+       mutex_unlock(&dsp->cs_dsp.pwr_lock);
 
        return ret;
 }
 EXPORT_SYMBOL_GPL(wm_adsp_compr_copy);
 
-static void wm_adsp_fatal_error(struct wm_adsp *dsp)
+static void wm_adsp_fatal_error(struct cs_dsp *cs_dsp)
 {
+       struct wm_adsp *dsp = container_of(cs_dsp, struct wm_adsp, cs_dsp);
        struct wm_adsp_compr *compr;
 
        dsp->fatal_error = true;
@@ -4366,64 +1934,8 @@ static void wm_adsp_fatal_error(struct wm_adsp *dsp)
 irqreturn_t wm_adsp2_bus_error(int irq, void *data)
 {
        struct wm_adsp *dsp = (struct wm_adsp *)data;
-       unsigned int val;
-       struct regmap *regmap = dsp->regmap;
-       int ret = 0;
-
-       mutex_lock(&dsp->pwr_lock);
-
-       ret = regmap_read(regmap, dsp->base + ADSP2_LOCK_REGION_CTRL, &val);
-       if (ret) {
-               adsp_err(dsp,
-                       "Failed to read Region Lock Ctrl register: %d\n", ret);
-               goto error;
-       }
-
-       if (val & ADSP2_WDT_TIMEOUT_STS_MASK) {
-               adsp_err(dsp, "watchdog timeout error\n");
-               dsp->ops->stop_watchdog(dsp);
-               wm_adsp_fatal_error(dsp);
-       }
-
-       if (val & (ADSP2_ADDR_ERR_MASK | ADSP2_REGION_LOCK_ERR_MASK)) {
-               if (val & ADSP2_ADDR_ERR_MASK)
-                       adsp_err(dsp, "bus error: address error\n");
-               else
-                       adsp_err(dsp, "bus error: region lock error\n");
-
-               ret = regmap_read(regmap, dsp->base + ADSP2_BUS_ERR_ADDR, &val);
-               if (ret) {
-                       adsp_err(dsp,
-                                "Failed to read Bus Err Addr register: %d\n",
-                                ret);
-                       goto error;
-               }
 
-               adsp_err(dsp, "bus error address = 0x%x\n",
-                        val & ADSP2_BUS_ERR_ADDR_MASK);
-
-               ret = regmap_read(regmap,
-                                 dsp->base + ADSP2_PMEM_ERR_ADDR_XMEM_ERR_ADDR,
-                                 &val);
-               if (ret) {
-                       adsp_err(dsp,
-                                "Failed to read Pmem Xmem Err Addr register: %d\n",
-                                ret);
-                       goto error;
-               }
-
-               adsp_err(dsp, "xmem error address = 0x%x\n",
-                        val & ADSP2_XMEM_ERR_ADDR_MASK);
-               adsp_err(dsp, "pmem error address = 0x%x\n",
-                        (val & ADSP2_PMEM_ERR_ADDR_MASK) >>
-                        ADSP2_PMEM_ERR_ADDR_SHIFT);
-       }
-
-       regmap_update_bits(regmap, dsp->base + ADSP2_LOCK_REGION_CTRL,
-                          ADSP2_CTRL_ERR_EINT, ADSP2_CTRL_ERR_EINT);
-
-error:
-       mutex_unlock(&dsp->pwr_lock);
+       cs_dsp_adsp2_bus_error(&dsp->cs_dsp);
 
        return IRQ_HANDLED;
 }
@@ -4432,55 +1944,8 @@ EXPORT_SYMBOL_GPL(wm_adsp2_bus_error);
 irqreturn_t wm_halo_bus_error(int irq, void *data)
 {
        struct wm_adsp *dsp = (struct wm_adsp *)data;
-       struct regmap *regmap = dsp->regmap;
-       unsigned int fault[6];
-       struct reg_sequence clear[] = {
-               { dsp->base + HALO_MPU_XM_VIO_STATUS,     0x0 },
-               { dsp->base + HALO_MPU_YM_VIO_STATUS,     0x0 },
-               { dsp->base + HALO_MPU_PM_VIO_STATUS,     0x0 },
-       };
-       int ret;
-
-       mutex_lock(&dsp->pwr_lock);
-
-       ret = regmap_read(regmap, dsp->base_sysinfo + HALO_AHBM_WINDOW_DEBUG_1,
-                         fault);
-       if (ret) {
-               adsp_warn(dsp, "Failed to read AHB DEBUG_1: %d\n", ret);
-               goto exit_unlock;
-       }
-
-       adsp_warn(dsp, "AHB: STATUS: 0x%x ADDR: 0x%x\n",
-                 *fault & HALO_AHBM_FLAGS_ERR_MASK,
-                 (*fault & HALO_AHBM_CORE_ERR_ADDR_MASK) >>
-                 HALO_AHBM_CORE_ERR_ADDR_SHIFT);
-
-       ret = regmap_read(regmap, dsp->base_sysinfo + HALO_AHBM_WINDOW_DEBUG_0,
-                         fault);
-       if (ret) {
-               adsp_warn(dsp, "Failed to read AHB DEBUG_0: %d\n", ret);
-               goto exit_unlock;
-       }
 
-       adsp_warn(dsp, "AHB: SYS_ADDR: 0x%x\n", *fault);
-
-       ret = regmap_bulk_read(regmap, dsp->base + HALO_MPU_XM_VIO_ADDR,
-                              fault, ARRAY_SIZE(fault));
-       if (ret) {
-               adsp_warn(dsp, "Failed to read MPU fault info: %d\n", ret);
-               goto exit_unlock;
-       }
-
-       adsp_warn(dsp, "XM: STATUS:0x%x ADDR:0x%x\n", fault[1], fault[0]);
-       adsp_warn(dsp, "YM: STATUS:0x%x ADDR:0x%x\n", fault[3], fault[2]);
-       adsp_warn(dsp, "PM: STATUS:0x%x ADDR:0x%x\n", fault[5], fault[4]);
-
-       ret = regmap_multi_reg_write(dsp->regmap, clear, ARRAY_SIZE(clear));
-       if (ret)
-               adsp_warn(dsp, "Failed to clear MPU status: %d\n", ret);
-
-exit_unlock:
-       mutex_unlock(&dsp->pwr_lock);
+       cs_dsp_halo_bus_error(&dsp->cs_dsp);
 
        return IRQ_HANDLED;
 }
@@ -4490,99 +1955,23 @@ irqreturn_t wm_halo_wdt_expire(int irq, void *data)
 {
        struct wm_adsp *dsp = data;
 
-       mutex_lock(&dsp->pwr_lock);
-
-       adsp_warn(dsp, "WDT Expiry Fault\n");
-       dsp->ops->stop_watchdog(dsp);
-       wm_adsp_fatal_error(dsp);
-
-       mutex_unlock(&dsp->pwr_lock);
+       cs_dsp_halo_wdt_expire(&dsp->cs_dsp);
 
        return IRQ_HANDLED;
 }
 EXPORT_SYMBOL_GPL(wm_halo_wdt_expire);
 
-static const struct wm_adsp_ops wm_adsp1_ops = {
-       .validate_version = wm_adsp_validate_version,
-       .parse_sizes = wm_adsp1_parse_sizes,
-       .region_to_reg = wm_adsp_region_to_reg,
-};
-
-static const struct wm_adsp_ops wm_adsp2_ops[] = {
-       {
-               .sys_config_size = sizeof(struct wm_adsp_system_config_xm_hdr),
-               .parse_sizes = wm_adsp2_parse_sizes,
-               .validate_version = wm_adsp_validate_version,
-               .setup_algs = wm_adsp2_setup_algs,
-               .region_to_reg = wm_adsp_region_to_reg,
-
-               .show_fw_status = wm_adsp2_show_fw_status,
-
-               .enable_memory = wm_adsp2_enable_memory,
-               .disable_memory = wm_adsp2_disable_memory,
-
-               .enable_core = wm_adsp2_enable_core,
-               .disable_core = wm_adsp2_disable_core,
-
-               .start_core = wm_adsp2_start_core,
-               .stop_core = wm_adsp2_stop_core,
-
-       },
-       {
-               .sys_config_size = sizeof(struct wm_adsp_system_config_xm_hdr),
-               .parse_sizes = wm_adsp2_parse_sizes,
-               .validate_version = wm_adsp_validate_version,
-               .setup_algs = wm_adsp2_setup_algs,
-               .region_to_reg = wm_adsp_region_to_reg,
-
-               .show_fw_status = wm_adsp2v2_show_fw_status,
-
-               .enable_memory = wm_adsp2_enable_memory,
-               .disable_memory = wm_adsp2_disable_memory,
-               .lock_memory = wm_adsp2_lock,
-
-               .enable_core = wm_adsp2v2_enable_core,
-               .disable_core = wm_adsp2v2_disable_core,
-
-               .start_core = wm_adsp2_start_core,
-               .stop_core = wm_adsp2_stop_core,
-       },
-       {
-               .sys_config_size = sizeof(struct wm_adsp_system_config_xm_hdr),
-               .parse_sizes = wm_adsp2_parse_sizes,
-               .validate_version = wm_adsp_validate_version,
-               .setup_algs = wm_adsp2_setup_algs,
-               .region_to_reg = wm_adsp_region_to_reg,
-
-               .show_fw_status = wm_adsp2v2_show_fw_status,
-               .stop_watchdog = wm_adsp_stop_watchdog,
-
-               .enable_memory = wm_adsp2_enable_memory,
-               .disable_memory = wm_adsp2_disable_memory,
-               .lock_memory = wm_adsp2_lock,
-
-               .enable_core = wm_adsp2v2_enable_core,
-               .disable_core = wm_adsp2v2_disable_core,
-
-               .start_core = wm_adsp2_start_core,
-               .stop_core = wm_adsp2_stop_core,
-       },
+static const struct cs_dsp_client_ops wm_adsp1_client_ops = {
+       .control_add = wm_adsp_control_add,
+       .control_remove = wm_adsp_control_remove,
 };
 
-static const struct wm_adsp_ops wm_halo_ops = {
-       .sys_config_size = sizeof(struct wm_halo_system_config_xm_hdr),
-       .parse_sizes = wm_adsp2_parse_sizes,
-       .validate_version = wm_halo_validate_version,
-       .setup_algs = wm_halo_setup_algs,
-       .region_to_reg = wm_halo_region_to_reg,
-
-       .show_fw_status = wm_halo_show_fw_status,
-       .stop_watchdog = wm_halo_stop_watchdog,
-
-       .lock_memory = wm_halo_configure_mpu,
-
-       .start_core = wm_halo_start_core,
-       .stop_core = wm_halo_stop_core,
+static const struct cs_dsp_client_ops wm_adsp2_client_ops = {
+       .control_add = wm_adsp_control_add,
+       .control_remove = wm_adsp_control_remove,
+       .post_run = wm_adsp_event_post_run,
+       .post_stop = wm_adsp_event_post_stop,
+       .watchdog_expired = wm_adsp_fatal_error,
 };
 
 MODULE_LICENSE("GPL v2");
index f22131d..0e2f113 100644 (file)
 #ifndef __WM_ADSP_H
 #define __WM_ADSP_H
 
+#include <linux/firmware/cirrus/cs_dsp.h>
+#include <linux/firmware/cirrus/wmfw.h>
+
 #include <sound/soc.h>
 #include <sound/soc-dapm.h>
 #include <sound/compress_driver.h>
 
-#include "wmfw.h"
-
 /* Return values for wm_adsp_compr_handle_irq */
 #define WM_ADSP_COMPR_OK                 0
 #define WM_ADSP_COMPR_VOICE_TRIGGER      1
 
-#define WM_ADSP2_REGION_0 BIT(0)
-#define WM_ADSP2_REGION_1 BIT(1)
-#define WM_ADSP2_REGION_2 BIT(2)
-#define WM_ADSP2_REGION_3 BIT(3)
-#define WM_ADSP2_REGION_4 BIT(4)
-#define WM_ADSP2_REGION_5 BIT(5)
-#define WM_ADSP2_REGION_6 BIT(6)
-#define WM_ADSP2_REGION_7 BIT(7)
-#define WM_ADSP2_REGION_8 BIT(8)
-#define WM_ADSP2_REGION_9 BIT(9)
-#define WM_ADSP2_REGION_1_9 (WM_ADSP2_REGION_1 | \
-               WM_ADSP2_REGION_2 | WM_ADSP2_REGION_3 | \
-               WM_ADSP2_REGION_4 | WM_ADSP2_REGION_5 | \
-               WM_ADSP2_REGION_6 | WM_ADSP2_REGION_7 | \
-               WM_ADSP2_REGION_8 | WM_ADSP2_REGION_9)
-#define WM_ADSP2_REGION_ALL (WM_ADSP2_REGION_0 | WM_ADSP2_REGION_1_9)
-
-struct wm_adsp_region {
-       int type;
-       unsigned int base;
-};
-
-struct wm_adsp_alg_region {
-       struct list_head list;
-       unsigned int alg;
-       int type;
-       unsigned int base;
-};
-
 struct wm_adsp_compr;
 struct wm_adsp_compr_buf;
-struct wm_adsp_ops;
 
 struct wm_adsp {
+       struct cs_dsp cs_dsp;
        const char *part;
-       const char *name;
        const char *fwf_name;
-       int rev;
-       int num;
-       int type;
-       struct device *dev;
-       struct regmap *regmap;
        struct snd_soc_component *component;
 
-       const struct wm_adsp_ops *ops;
-
-       unsigned int base;
-       unsigned int base_sysinfo;
-       unsigned int sysclk_reg;
-       unsigned int sysclk_mask;
-       unsigned int sysclk_shift;
-
-       struct list_head alg_regions;
-
-       unsigned int fw_id;
-       unsigned int fw_id_version;
-       unsigned int fw_vendor_id;
-
-       const struct wm_adsp_region *mem;
-       int num_mems;
+       unsigned int sys_config_size;
 
        int fw;
-       int fw_ver;
+
+       struct work_struct boot_work;
 
        bool preloaded;
-       bool booted;
-       bool running;
        bool fatal_error;
 
-       struct list_head ctl_list;
-
-       struct work_struct boot_work;
-
        struct list_head compr_list;
        struct list_head buffer_list;
-
-       struct mutex pwr_lock;
-
-       unsigned int lock_regions;
-
-#ifdef CONFIG_DEBUG_FS
-       struct dentry *debugfs_root;
-       char *wmfw_file_name;
-       char *bin_file_name;
-#endif
-
-};
-
-struct wm_adsp_ops {
-       unsigned int sys_config_size;
-
-       bool (*validate_version)(struct wm_adsp *dsp, unsigned int version);
-       unsigned int (*parse_sizes)(struct wm_adsp *dsp,
-                                   const char * const file,
-                                   unsigned int pos,
-                                   const struct firmware *firmware);
-       int (*setup_algs)(struct wm_adsp *dsp);
-       unsigned int (*region_to_reg)(struct wm_adsp_region const *mem,
-                                     unsigned int offset);
-
-       void (*show_fw_status)(struct wm_adsp *dsp);
-       void (*stop_watchdog)(struct wm_adsp *dsp);
-
-       int (*enable_memory)(struct wm_adsp *dsp);
-       void (*disable_memory)(struct wm_adsp *dsp);
-       int (*lock_memory)(struct wm_adsp *dsp, unsigned int lock_regions);
-
-       int (*enable_core)(struct wm_adsp *dsp);
-       void (*disable_core)(struct wm_adsp *dsp);
-
-       int (*start_core)(struct wm_adsp *dsp);
-       void (*stop_core)(struct wm_adsp *dsp);
 };
 
 #define WM_ADSP1(wname, num) \
diff --git a/sound/soc/codecs/wmfw.h b/sound/soc/codecs/wmfw.h
deleted file mode 100644 (file)
index f3d5160..0000000
+++ /dev/null
@@ -1,200 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * wmfw.h - Wolfson firmware format information
- *
- * Copyright 2012 Wolfson Microelectronics plc
- *
- * Author: Mark Brown <broonie@opensource.wolfsonmicro.com>
- */
-
-#ifndef __WMFW_H
-#define __WMFW_H
-
-#include <linux/types.h>
-
-#define WMFW_MAX_ALG_NAME         256
-#define WMFW_MAX_ALG_DESCR_NAME   256
-
-#define WMFW_MAX_COEFF_NAME       256
-#define WMFW_MAX_COEFF_DESCR_NAME 256
-
-#define WMFW_CTL_FLAG_SYS         0x8000
-#define WMFW_CTL_FLAG_VOLATILE    0x0004
-#define WMFW_CTL_FLAG_WRITEABLE   0x0002
-#define WMFW_CTL_FLAG_READABLE    0x0001
-
-/* Non-ALSA coefficient types start at 0x1000 */
-#define WMFW_CTL_TYPE_ACKED       ((__force snd_ctl_elem_type_t)0x1000) /* acked control */
-#define WMFW_CTL_TYPE_HOSTEVENT   ((__force snd_ctl_elem_type_t)0x1001) /* event control */
-#define WMFW_CTL_TYPE_HOST_BUFFER ((__force snd_ctl_elem_type_t)0x1002) /* host buffer pointer */
-
-struct wmfw_header {
-       char magic[4];
-       __le32 len;
-       __le16 rev;
-       u8 core;
-       u8 ver;
-} __packed;
-
-struct wmfw_footer {
-       __le64 timestamp;
-       __le32 checksum;
-} __packed;
-
-struct wmfw_adsp1_sizes {
-       __le32 dm;
-       __le32 pm;
-       __le32 zm;
-} __packed;
-
-struct wmfw_adsp2_sizes {
-       __le32 xm;
-       __le32 ym;
-       __le32 pm;
-       __le32 zm;
-} __packed;
-
-struct wmfw_region {
-       union {
-               __be32 type;
-               __le32 offset;
-       };
-       __le32 len;
-       u8 data[];
-} __packed;
-
-struct wmfw_id_hdr {
-       __be32 core_id;
-       __be32 core_rev;
-       __be32 id;
-       __be32 ver;
-} __packed;
-
-struct wmfw_v3_id_hdr {
-       __be32 core_id;
-       __be32 block_rev;
-       __be32 vendor_id;
-       __be32 id;
-       __be32 ver;
-} __packed;
-
-struct wmfw_adsp1_id_hdr {
-       struct wmfw_id_hdr fw;
-       __be32 zm;
-       __be32 dm;
-       __be32 n_algs;
-} __packed;
-
-struct wmfw_adsp2_id_hdr {
-       struct wmfw_id_hdr fw;
-       __be32 zm;
-       __be32 xm;
-       __be32 ym;
-       __be32 n_algs;
-} __packed;
-
-struct wmfw_halo_id_hdr {
-       struct wmfw_v3_id_hdr fw;
-       __be32 xm_base;
-       __be32 xm_size;
-       __be32 ym_base;
-       __be32 ym_size;
-       __be32 n_algs;
-} __packed;
-
-struct wmfw_alg_hdr {
-       __be32 id;
-       __be32 ver;
-} __packed;
-
-struct wmfw_adsp1_alg_hdr {
-       struct wmfw_alg_hdr alg;
-       __be32 zm;
-       __be32 dm;
-} __packed;
-
-struct wmfw_adsp2_alg_hdr {
-       struct wmfw_alg_hdr alg;
-       __be32 zm;
-       __be32 xm;
-       __be32 ym;
-} __packed;
-
-struct wmfw_halo_alg_hdr {
-       struct wmfw_alg_hdr alg;
-       __be32 xm_base;
-       __be32 xm_size;
-       __be32 ym_base;
-       __be32 ym_size;
-} __packed;
-
-struct wmfw_adsp_alg_data {
-       __le32 id;
-       u8 name[WMFW_MAX_ALG_NAME];
-       u8 descr[WMFW_MAX_ALG_DESCR_NAME];
-       __le32 ncoeff;
-       u8 data[];
-} __packed;
-
-struct wmfw_adsp_coeff_data {
-       struct {
-               __le16 offset;
-               __le16 type;
-               __le32 size;
-       } hdr;
-       u8 name[WMFW_MAX_COEFF_NAME];
-       u8 descr[WMFW_MAX_COEFF_DESCR_NAME];
-       __le16 ctl_type;
-       __le16 flags;
-       __le32 len;
-       u8 data[];
-} __packed;
-
-struct wmfw_coeff_hdr {
-       u8 magic[4];
-       __le32 len;
-       union {
-               __be32 rev;
-               __le32 ver;
-       };
-       union {
-               __be32 core;
-               __le32 core_ver;
-       };
-       u8 data[];
-} __packed;
-
-struct wmfw_coeff_item {
-       __le16 offset;
-       __le16 type;
-       __le32 id;
-       __le32 ver;
-       __le32 sr;
-       __le32 len;
-       u8 data[];
-} __packed;
-
-#define WMFW_ADSP1 1
-#define WMFW_ADSP2 2
-#define WMFW_HALO 4
-
-#define WMFW_ABSOLUTE         0xf0
-#define WMFW_ALGORITHM_DATA   0xf2
-#define WMFW_METADATA         0xfc
-#define WMFW_NAME_TEXT        0xfe
-#define WMFW_INFO_TEXT        0xff
-
-#define WMFW_ADSP1_PM 2
-#define WMFW_ADSP1_DM 3
-#define WMFW_ADSP1_ZM 4
-
-#define WMFW_ADSP2_PM 2
-#define WMFW_ADSP2_ZM 4
-#define WMFW_ADSP2_XM 5
-#define WMFW_ADSP2_YM 6
-
-#define WMFW_HALO_PM_PACKED 0x10
-#define WMFW_HALO_XM_PACKED 0x11
-#define WMFW_HALO_YM_PACKED 0x12
-
-#endif
index d21a723..d20ec15 100644 (file)
@@ -250,8 +250,8 @@ static int zl38_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                return -EINVAL;
        }
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                /* always 32 bits per frame (= 16 bits/channel, 2 channels) */
                err = regmap_update_bits(priv->regmap, REG_TDMA_CFG_CLK,
                                         CFG_CLK_MASTER | CFG_CLK_PCLK_MASK,
index 33ce257..5cb5892 100644 (file)
@@ -356,25 +356,25 @@ static int dw_i2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
        struct dw_i2s_dev *dev = snd_soc_dai_get_drvdata(cpu_dai);
        int ret = 0;
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                if (dev->capability & DW_I2S_SLAVE)
                        ret = 0;
                else
                        ret = -EINVAL;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                if (dev->capability & DW_I2S_MASTER)
                        ret = 0;
                else
                        ret = -EINVAL;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
-       case SND_SOC_DAIFMT_CBS_CFM:
+       case SND_SOC_DAIFMT_CBP_CFC:
+       case SND_SOC_DAIFMT_CBC_CFP:
                ret = -EINVAL;
                break;
        default:
-               dev_dbg(dev->dev, "dwc : Invalid master/slave format\n");
+               dev_dbg(dev->dev, "dwc : Invalid clock provider format\n");
                ret = -EINVAL;
                break;
        }
index e13271e..8b61582 100644 (file)
@@ -70,7 +70,7 @@ static struct snd_soc_dai_link eukrea_tlv320_dai = {
        .name           = "tlv320aic23",
        .stream_name    = "TLV320AIC23",
        .dai_fmt        = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                         SND_SOC_DAIFMT_CBM_CFM,
+                         SND_SOC_DAIFMT_CBP_CFP,
        .ops            = &eukrea_tlv320_snd_ops,
        SND_SOC_DAILINK_REG(hifi),
 };
index 06107ae..6e6494f 100644 (file)
@@ -356,8 +356,8 @@ static int fsl_asoc_card_audmux_init(struct device_node *np,
         * If only 4 wires are needed, just set SSI into
         * synchronous mode and enable 4 PADs in IOMUX.
         */
-       switch (priv->dai_fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
+       switch (priv->dai_fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
                int_ptcr = IMX_AUDMUX_V2_PTCR_RFSEL(8 | ext_port) |
                           IMX_AUDMUX_V2_PTCR_RCSEL(8 | ext_port) |
                           IMX_AUDMUX_V2_PTCR_TFSEL(ext_port) |
@@ -367,7 +367,7 @@ static int fsl_asoc_card_audmux_init(struct device_node *np,
                           IMX_AUDMUX_V2_PTCR_TFSDIR |
                           IMX_AUDMUX_V2_PTCR_TCLKDIR;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFC:
                int_ptcr = IMX_AUDMUX_V2_PTCR_RCSEL(8 | ext_port) |
                           IMX_AUDMUX_V2_PTCR_TCSEL(ext_port) |
                           IMX_AUDMUX_V2_PTCR_RCLKDIR |
@@ -377,7 +377,7 @@ static int fsl_asoc_card_audmux_init(struct device_node *np,
                           IMX_AUDMUX_V2_PTCR_RFSDIR |
                           IMX_AUDMUX_V2_PTCR_TFSDIR;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
+       case SND_SOC_DAIFMT_CBC_CFP:
                int_ptcr = IMX_AUDMUX_V2_PTCR_RFSEL(8 | ext_port) |
                           IMX_AUDMUX_V2_PTCR_TFSEL(ext_port) |
                           IMX_AUDMUX_V2_PTCR_RFSDIR |
@@ -387,7 +387,7 @@ static int fsl_asoc_card_audmux_init(struct device_node *np,
                           IMX_AUDMUX_V2_PTCR_RCLKDIR |
                           IMX_AUDMUX_V2_PTCR_TCLKDIR;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                ext_ptcr = IMX_AUDMUX_V2_PTCR_RFSEL(8 | int_port) |
                           IMX_AUDMUX_V2_PTCR_RCSEL(8 | int_port) |
                           IMX_AUDMUX_V2_PTCR_TFSEL(int_port) |
@@ -533,8 +533,8 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
        struct device_node *cpu_np, *codec_np, *asrc_np;
        struct device_node *np = pdev->dev.of_node;
        struct platform_device *asrc_pdev = NULL;
-       struct device_node *bitclkmaster = NULL;
-       struct device_node *framemaster = NULL;
+       struct device_node *bitclkprovider = NULL;
+       struct device_node *frameprovider = NULL;
        struct platform_device *cpu_pdev;
        struct fsl_asoc_card_priv *priv;
        struct device *codec_dev = NULL;
@@ -617,29 +617,29 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
                priv->cpu_priv.sysclk_dir[TX] = SND_SOC_CLOCK_OUT;
                priv->cpu_priv.sysclk_dir[RX] = SND_SOC_CLOCK_OUT;
                priv->cpu_priv.slot_width = 32;
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBC_CFC;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-cs427x")) {
                codec_dai_name = "cs4271-hifi";
                priv->codec_priv.mclk_id = CS427x_SYSCLK_MCLK;
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-sgtl5000")) {
                codec_dai_name = "sgtl5000";
                priv->codec_priv.mclk_id = SGTL5000_SYSCLK;
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-tlv320aic32x4")) {
                codec_dai_name = "tlv320aic32x4-hifi";
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-wm8962")) {
                codec_dai_name = "wm8962";
                priv->codec_priv.mclk_id = WM8962_SYSCLK_MCLK;
                priv->codec_priv.fll_id = WM8962_SYSCLK_FLL;
                priv->codec_priv.pll_id = WM8962_FLL;
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-wm8960")) {
                codec_dai_name = "wm8960-hifi";
                priv->codec_priv.fll_id = WM8960_SYSCLK_AUTO;
                priv->codec_priv.pll_id = WM8960_SYSCLK_AUTO;
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
        } else if (of_device_is_compatible(np, "fsl,imx-audio-ac97")) {
                codec_dai_name = "ac97-hifi";
                priv->dai_fmt = SND_SOC_DAIFMT_AC97;
@@ -648,7 +648,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
        } else if (of_device_is_compatible(np, "fsl,imx-audio-mqs")) {
                codec_dai_name = "fsl-mqs-dai";
                priv->dai_fmt = SND_SOC_DAIFMT_LEFT_J |
-                               SND_SOC_DAIFMT_CBS_CFS |
+                               SND_SOC_DAIFMT_CBC_CFC |
                                SND_SOC_DAIFMT_NB_NF;
                priv->dai_link[1].dpcm_capture = 0;
                priv->dai_link[2].dpcm_capture = 0;
@@ -656,7 +656,7 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
                priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_tx);
        } else if (of_device_is_compatible(np, "fsl,imx-audio-wm8524")) {
                codec_dai_name = "wm8524-hifi";
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBC_CFC;
                priv->dai_link[1].dpcm_capture = 0;
                priv->dai_link[2].dpcm_capture = 0;
                priv->cpu_priv.slot_width = 32;
@@ -664,12 +664,12 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
                priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_tx);
        } else if (of_device_is_compatible(np, "fsl,imx-audio-si476x")) {
                codec_dai_name = "si476x-codec";
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBS_CFS;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBC_CFC;
                priv->card.dapm_routes = audio_map_rx;
                priv->card.num_dapm_routes = ARRAY_SIZE(audio_map_rx);
        } else if (of_device_is_compatible(np, "fsl,imx-audio-wm8958")) {
                codec_dai_name = "wm8994-aif1";
-               priv->dai_fmt |= SND_SOC_DAIFMT_CBM_CFM;
+               priv->dai_fmt |= SND_SOC_DAIFMT_CBP_CFP;
                priv->codec_priv.mclk_id = WM8994_FLL_SRC_MCLK1;
                priv->codec_priv.fll_id = WM8994_SYSCLK_FLL1;
                priv->codec_priv.pll_id = WM8994_FLL1;
@@ -683,29 +683,29 @@ static int fsl_asoc_card_probe(struct platform_device *pdev)
        }
 
        /* Format info from DT is optional. */
-       snd_soc_daifmt_parse_clock_provider_as_phandle(np, NULL, &bitclkmaster, &framemaster);
-       if (bitclkmaster || framemaster) {
+       snd_soc_daifmt_parse_clock_provider_as_phandle(np, NULL, &bitclkprovider, &frameprovider);
+       if (bitclkprovider || frameprovider) {
                unsigned int daifmt = snd_soc_daifmt_parse_format(np, NULL);
 
-               if (codec_np == bitclkmaster)
-                       daifmt |= (codec_np == framemaster) ?
-                               SND_SOC_DAIFMT_CBM_CFM : SND_SOC_DAIFMT_CBM_CFS;
+               if (codec_np == bitclkprovider)
+                       daifmt |= (codec_np == frameprovider) ?
+                               SND_SOC_DAIFMT_CBP_CFP : SND_SOC_DAIFMT_CBP_CFC;
                else
-                       daifmt |= (codec_np == framemaster) ?
-                               SND_SOC_DAIFMT_CBS_CFM : SND_SOC_DAIFMT_CBS_CFS;
+                       daifmt |= (codec_np == frameprovider) ?
+                               SND_SOC_DAIFMT_CBC_CFP : SND_SOC_DAIFMT_CBC_CFC;
 
                /* Override dai_fmt with value from DT */
                priv->dai_fmt = daifmt;
        }
 
        /* Change direction according to format */
-       if (priv->dai_fmt & SND_SOC_DAIFMT_CBM_CFM) {
+       if (priv->dai_fmt & SND_SOC_DAIFMT_CBP_CFP) {
                priv->cpu_priv.sysclk_dir[TX] = SND_SOC_CLOCK_IN;
                priv->cpu_priv.sysclk_dir[RX] = SND_SOC_CLOCK_IN;
        }
 
-       of_node_put(bitclkmaster);
-       of_node_put(framemaster);
+       of_node_put(bitclkprovider);
+       of_node_put(frameprovider);
 
        if (!fsl_asoc_card_is_ac97(priv) && !codec_dev) {
                dev_dbg(&pdev->dev, "failed to find codec device\n");
index f931288..6dbb8c9 100644 (file)
@@ -257,10 +257,10 @@ static int fsl_audmix_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                return -EINVAL;
        }
 
-       /* For playback the AUDMIX is slave, and for record is master */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
-       case SND_SOC_DAIFMT_CBS_CFS:
+       /* For playback the AUDMIX is consumer, and for record is provider */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index bda66b3..3a9e2df 100644 (file)
@@ -52,7 +52,7 @@ struct fsl_esai_soc_data {
  * @sck_rate: clock rate of desired SCKx clock
  * @hck_dir: the direction of HCKx pads
  * @sck_div: if using PSR/PM dividers for SCKx clock
- * @slave_mode: if fully using DAI slave mode
+ * @consumer_mode: if fully using DAI clock consumer mode
  * @synchronous: if using tx/rx synchronous mode
  * @name: driver name
  */
@@ -78,7 +78,7 @@ struct fsl_esai {
        u32 sck_rate[2];
        bool hck_dir[2];
        bool sck_div[2];
-       bool slave_mode;
+       bool consumer_mode;
        bool synchronous;
        char name[32];
 };
@@ -366,8 +366,8 @@ static int fsl_esai_set_bclk(struct snd_soc_dai *dai, bool tx, u32 freq)
        u32 sub, ratio = hck_rate / freq;
        int ret;
 
-       /* Don't apply for fully slave mode or unchanged bclk */
-       if (esai_priv->slave_mode || esai_priv->sck_rate[tx] == freq)
+       /* Don't apply for fully consumer mode or unchanged bclk */
+       if (esai_priv->consumer_mode || esai_priv->sck_rate[tx] == freq)
                return 0;
 
        if (ratio * freq > hck_rate)
@@ -476,20 +476,20 @@ static int fsl_esai_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                return -EINVAL;
        }
 
-       esai_priv->slave_mode = false;
+       esai_priv->consumer_mode = false;
 
-       /* DAI clock master masks */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBM_CFM:
-               esai_priv->slave_mode = true;
+       /* DAI clock provider masks */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               esai_priv->consumer_mode = true;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
+       case SND_SOC_DAIFMT_CBC_CFP:
                xccr |= ESAI_xCCR_xCKD;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFC:
                xccr |= ESAI_xCCR_xFSD;
                break;
-       case SND_SOC_DAIFMT_CBS_CFS:
+       case SND_SOC_DAIFMT_CBC_CFC:
                xccr |= ESAI_xCCR_xFSD | ESAI_xCCR_xCKD;
                break;
        default:
@@ -1016,8 +1016,8 @@ static int fsl_esai_probe(struct platform_device *pdev)
        /* Set a default slot number */
        esai_priv->slots = 2;
 
-       /* Set a default master/slave state */
-       esai_priv->slave_mode = true;
+       /* Set a default clock provider state */
+       esai_priv->consumer_mode = true;
 
        /* Determine the FIFO depth */
        iprop = of_get_property(np, "fsl,fifo-depth", NULL);
index 69aeb0e..27b4536 100644 (file)
@@ -102,8 +102,8 @@ static int fsl_mqs_set_dai_fmt(struct snd_soc_dai *dai, unsigned int fmt)
                return -EINVAL;
        }
 
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                break;
        default:
                return -EINVAL;
index d60f4da..8508bc7 100644 (file)
@@ -138,11 +138,43 @@ static const struct snd_soc_component_driver fsl_component = {
        .name           = "fsl-rpmsg",
 };
 
+static const struct fsl_rpmsg_soc_data imx7ulp_data = {
+       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                SNDRV_PCM_RATE_48000,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+};
+
+static const struct fsl_rpmsg_soc_data imx8mm_data = {
+       .rates = SNDRV_PCM_RATE_KNOT,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE | SNDRV_PCM_FMTBIT_DSD_U8 |
+                  SNDRV_PCM_FMTBIT_DSD_U16_LE | SNDRV_PCM_FMTBIT_DSD_U32_LE,
+};
+
+static const struct fsl_rpmsg_soc_data imx8mn_data = {
+       .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
+                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |
+                SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_176400 |
+                SNDRV_PCM_RATE_192000,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+};
+
+static const struct fsl_rpmsg_soc_data imx8mp_data = {
+       .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
+                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |
+                SNDRV_PCM_RATE_96000 | SNDRV_PCM_RATE_176400 |
+                SNDRV_PCM_RATE_192000,
+       .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE |
+                  SNDRV_PCM_FMTBIT_S32_LE,
+};
+
 static const struct of_device_id fsl_rpmsg_ids[] = {
-       { .compatible = "fsl,imx7ulp-rpmsg-audio"},
-       { .compatible = "fsl,imx8mm-rpmsg-audio"},
-       { .compatible = "fsl,imx8mn-rpmsg-audio"},
-       { .compatible = "fsl,imx8mp-rpmsg-audio"},
+       { .compatible = "fsl,imx7ulp-rpmsg-audio", .data = &imx7ulp_data},
+       { .compatible = "fsl,imx8mm-rpmsg-audio", .data = &imx8mm_data},
+       { .compatible = "fsl,imx8mn-rpmsg-audio", .data = &imx8mn_data},
+       { .compatible = "fsl,imx8mp-rpmsg-audio", .data = &imx8mp_data},
+       { .compatible = "fsl,imx8ulp-rpmsg-audio", .data = &imx7ulp_data},
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, fsl_rpmsg_ids);
@@ -157,6 +189,13 @@ static int fsl_rpmsg_probe(struct platform_device *pdev)
        if (!rpmsg)
                return -ENOMEM;
 
+       rpmsg->soc_data = of_device_get_match_data(&pdev->dev);
+
+       fsl_rpmsg_dai.playback.rates = rpmsg->soc_data->rates;
+       fsl_rpmsg_dai.capture.rates = rpmsg->soc_data->rates;
+       fsl_rpmsg_dai.playback.formats = rpmsg->soc_data->formats;
+       fsl_rpmsg_dai.capture.formats = rpmsg->soc_data->formats;
+
        if (of_property_read_bool(np, "fsl,enable-lpa")) {
                rpmsg->enable_lpa = 1;
                rpmsg->buffer_size = LPA_LARGE_BUFFER_SIZE;
index 4f5b49e..b04086f 100644 (file)
@@ -6,6 +6,16 @@
 #ifndef __FSL_RPMSG_H
 #define __FSL_RPMSG_H
 
+/*
+ * struct fsl_rpmsg_soc_data
+ * @rates: supported rates
+ * @formats: supported formats
+ */
+struct fsl_rpmsg_soc_data {
+       int rates;
+       u64 formats;
+};
+
 /*
  * struct fsl_rpmsg - rpmsg private data
  *
@@ -15,6 +25,7 @@
  * @pll8k: parent clock for multiple of 8kHz frequency
  * @pll11k: parent clock for multiple of 11kHz frequency
  * @card_pdev: Platform_device pointer to register a sound card
+ * @soc_data: soc specific data
  * @mclk_streams: Active streams that are using baudclk
  * @force_lpa: force enable low power audio routine if condition satisfy
  * @enable_lpa: enable low power audio routine according to dts setting
@@ -27,6 +38,7 @@ struct fsl_rpmsg {
        struct clk *pll8k;
        struct clk *pll11k;
        struct platform_device *card_pdev;
+       const struct fsl_rpmsg_soc_data *soc_data;
        unsigned int mclk_streams;
        int force_lpa;
        int enable_lpa;
index 38f6362..10544fa 100644 (file)
@@ -297,23 +297,23 @@ static int fsl_sai_set_dai_fmt_tr(struct snd_soc_dai *cpu_dai,
                return -EINVAL;
        }
 
-       /* DAI clock master masks */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       /* DAI clock provider masks */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                val_cr2 |= FSL_SAI_CR2_BCD_MSTR;
                val_cr4 |= FSL_SAI_CR4_FSD_MSTR;
-               sai->is_slave_mode = false;
+               sai->is_consumer_mode = false;
                break;
-       case SND_SOC_DAIFMT_CBM_CFM:
-               sai->is_slave_mode = true;
+       case SND_SOC_DAIFMT_CBP_CFP:
+               sai->is_consumer_mode = true;
                break;
-       case SND_SOC_DAIFMT_CBS_CFM:
+       case SND_SOC_DAIFMT_CBC_CFP:
                val_cr2 |= FSL_SAI_CR2_BCD_MSTR;
-               sai->is_slave_mode = false;
+               sai->is_consumer_mode = false;
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFC:
                val_cr4 |= FSL_SAI_CR4_FSD_MSTR;
-               sai->is_slave_mode = true;
+               sai->is_consumer_mode = true;
                break;
        default:
                return -EINVAL;
@@ -356,8 +356,8 @@ static int fsl_sai_set_bclk(struct snd_soc_dai *dai, bool tx, u32 freq)
        u32 id;
        int ret = 0;
 
-       /* Don't apply to slave mode */
-       if (sai->is_slave_mode)
+       /* Don't apply to consumer mode */
+       if (sai->is_consumer_mode)
                return 0;
 
        /*
@@ -462,7 +462,7 @@ static int fsl_sai_hw_params(struct snd_pcm_substream *substream,
 
        pins = DIV_ROUND_UP(channels, slots);
 
-       if (!sai->is_slave_mode) {
+       if (!sai->is_consumer_mode) {
                if (sai->bclk_ratio)
                        ret = fsl_sai_set_bclk(cpu_dai, tx,
                                               sai->bclk_ratio *
@@ -502,12 +502,12 @@ static int fsl_sai_hw_params(struct snd_pcm_substream *substream,
                val_cr4 |= FSL_SAI_CR4_CHMOD;
 
        /*
-        * For SAI master mode, when Tx(Rx) sync with Rx(Tx) clock, Rx(Tx) will
+        * For SAI provider mode, when Tx(Rx) sync with Rx(Tx) clock, Rx(Tx) will
         * generate bclk and frame clock for Tx(Rx), we should set RCR4(TCR4),
         * RCR5(TCR5) for playback(capture), or there will be sync error.
         */
 
-       if (!sai->is_slave_mode && fsl_sai_dir_is_synced(sai, adir)) {
+       if (!sai->is_consumer_mode && fsl_sai_dir_is_synced(sai, adir)) {
                regmap_update_bits(sai->regmap, FSL_SAI_xCR4(!tx, ofs),
                                   FSL_SAI_CR4_SYWD_MASK | FSL_SAI_CR4_FRSZ_MASK |
                                   FSL_SAI_CR4_CHMOD_MASK,
@@ -543,7 +543,7 @@ static int fsl_sai_hw_free(struct snd_pcm_substream *substream,
        regmap_update_bits(sai->regmap, FSL_SAI_xCR3(tx, ofs),
                           FSL_SAI_CR3_TRCE_MASK, 0);
 
-       if (!sai->is_slave_mode &&
+       if (!sai->is_consumer_mode &&
                        sai->mclk_streams & BIT(substream->stream)) {
                clk_disable_unprepare(sai->mclk_clk[sai->mclk_id[tx]]);
                sai->mclk_streams &= ~BIT(substream->stream);
@@ -577,7 +577,7 @@ static void fsl_sai_config_disable(struct fsl_sai *sai, int dir)
         * This is a hardware bug, and will be fix in the
         * next sai version.
         */
-       if (!sai->is_slave_mode) {
+       if (!sai->is_consumer_mode) {
                /* Software Reset */
                regmap_write(sai->regmap, FSL_SAI_xCSR(tx, ofs), FSL_SAI_CSR_SR);
                /* Clear SR bit to finish the reset */
index bc60030..9aaf231 100644 (file)
@@ -259,7 +259,7 @@ struct fsl_sai {
        struct clk *bus_clk;
        struct clk *mclk_clk[FSL_SAI_MCLK_MAX];
 
-       bool is_slave_mode;
+       bool is_consumer_mode;
        bool is_lsb_first;
        bool is_dsp_mode;
        bool synchronous[2];
index 1c53719..d178b47 100644 (file)
@@ -111,6 +111,7 @@ struct spdif_mixer_control {
  * @dma_params_tx: DMA parameters for transmit channel
  * @dma_params_rx: DMA parameters for receive channel
  * @regcache_srpc: regcache for SRPC
+ * @bypass: status of bypass input to output
  */
 struct fsl_spdif_priv {
        const struct fsl_spdif_soc_data *soc;
@@ -133,6 +134,7 @@ struct fsl_spdif_priv {
        struct snd_dmaengine_dai_dma_data dma_params_rx;
        /* regcache for SRPC */
        u32 regcache_srpc;
+       bool bypass;
 };
 
 static struct fsl_spdif_soc_data fsl_spdif_vf610 = {
@@ -186,6 +188,16 @@ static struct fsl_spdif_soc_data fsl_spdif_imx8mm = {
        .tx_formats = FSL_SPDIF_FORMATS_PLAYBACK,
 };
 
+static struct fsl_spdif_soc_data fsl_spdif_imx8ulp = {
+       .imx = true,
+       .shared_root_clock = true,
+       .raw_capture_mode = false,
+       .interrupts = 1,
+       .tx_burst = 2,          /* Applied for EDMA */
+       .rx_burst = 2,          /* Applied for EDMA */
+       .tx_formats = SNDRV_PCM_FMTBIT_S24_LE,  /* Applied for EDMA */
+};
+
 /* Check if clk is a root clock that does not share clock source with others */
 static inline bool fsl_spdif_can_set_clk_rate(struct fsl_spdif_priv *spdif, int clk)
 {
@@ -895,6 +907,69 @@ static int fsl_spdif_rx_rcm_put(struct snd_kcontrol *kcontrol,
        return 0;
 }
 
+static int fsl_spdif_bypass_get(struct snd_kcontrol *kcontrol,
+                               struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dai *dai = snd_kcontrol_chip(kcontrol);
+       struct fsl_spdif_priv *priv = snd_soc_dai_get_drvdata(dai);
+
+       ucontrol->value.integer.value[0] = priv->bypass ? 1 : 0;
+
+       return 0;
+}
+
+static int fsl_spdif_bypass_put(struct snd_kcontrol *kcontrol,
+                               struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dai *dai = snd_kcontrol_chip(kcontrol);
+       struct fsl_spdif_priv *priv = snd_soc_dai_get_drvdata(dai);
+       struct snd_soc_card *card = dai->component->card;
+       bool set = (ucontrol->value.integer.value[0] != 0);
+       struct regmap *regmap = priv->regmap;
+       struct snd_soc_pcm_runtime *rtd;
+       u32 scr, mask;
+       int stream;
+
+       rtd = snd_soc_get_pcm_runtime(card, card->dai_link);
+
+       if (priv->bypass == set)
+               return 0; /* nothing to do */
+
+       if (snd_soc_dai_active(dai)) {
+               dev_err(dai->dev, "Cannot change BYPASS mode while stream is running.\n");
+               return -EBUSY;
+       }
+
+       pm_runtime_get_sync(dai->dev);
+
+       if (set) {
+               /* Disable interrupts */
+               regmap_update_bits(regmap, REG_SPDIF_SIE, 0xffffff, 0);
+
+               /* Configure BYPASS mode */
+               scr = SCR_TXSEL_RX | SCR_RXFIFO_OFF;
+               mask = SCR_RXFIFO_FSEL_MASK | SCR_RXFIFO_AUTOSYNC_MASK |
+                       SCR_RXFIFO_CTL_MASK | SCR_RXFIFO_OFF_MASK | SCR_TXSEL_MASK;
+               /* Power up SPDIF module */
+               mask |= SCR_LOW_POWER;
+       } else {
+               /* Power down SPDIF module, disable TX */
+               scr = SCR_LOW_POWER | SCR_TXSEL_OFF;
+               mask = SCR_LOW_POWER | SCR_TXSEL_MASK;
+       }
+
+       regmap_update_bits(regmap, REG_SPDIF_SCR, mask, scr);
+
+       /* Disable playback & capture if BYPASS mode is enabled, enable otherwise */
+       for_each_pcm_streams(stream)
+               rtd->pcm->streams[stream].substream_count = (set ? 0 : 1);
+
+       priv->bypass = set;
+       pm_runtime_put_sync(dai->dev);
+
+       return 0;
+}
+
 /* DPLL lock information */
 static int fsl_spdif_rxrate_info(struct snd_kcontrol *kcontrol,
                                struct snd_ctl_elem_info *uinfo)
@@ -1065,6 +1140,15 @@ static struct snd_kcontrol_new fsl_spdif_ctrls[] = {
                .info = fsl_spdif_rxrate_info,
                .get = fsl_spdif_rxrate_get,
        },
+       /* RX bypass controller */
+       {
+               .iface = SNDRV_CTL_ELEM_IFACE_PCM,
+               .name = "Bypass Mode",
+               .access = SNDRV_CTL_ELEM_ACCESS_READWRITE,
+               .info = snd_ctl_boolean_mono_info,
+               .get = fsl_spdif_bypass_get,
+               .put = fsl_spdif_bypass_put,
+       },
        /* User bit sync mode set/get controller */
        {
                .iface = SNDRV_CTL_ELEM_IFACE_PCM,
@@ -1560,6 +1644,7 @@ static const struct of_device_id fsl_spdif_dt_ids[] = {
        { .compatible = "fsl,imx6sx-spdif", .data = &fsl_spdif_imx6sx, },
        { .compatible = "fsl,imx8qm-spdif", .data = &fsl_spdif_imx8qm, },
        { .compatible = "fsl,imx8mm-spdif", .data = &fsl_spdif_imx8mm, },
+       { .compatible = "fsl,imx8ulp-spdif", .data = &fsl_spdif_imx8ulp, },
        {}
 };
 MODULE_DEVICE_TABLE(of, fsl_spdif_dt_ids);
index ecbc1c3..1169d11 100644 (file)
@@ -350,16 +350,16 @@ static bool fsl_ssi_is_ac97(struct fsl_ssi *ssi)
                SND_SOC_DAIFMT_AC97;
 }
 
-static bool fsl_ssi_is_i2s_master(struct fsl_ssi *ssi)
+static bool fsl_ssi_is_i2s_clock_provider(struct fsl_ssi *ssi)
 {
-       return (ssi->dai_fmt & SND_SOC_DAIFMT_MASTER_MASK) ==
-               SND_SOC_DAIFMT_CBS_CFS;
+       return (ssi->dai_fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) ==
+               SND_SOC_DAIFMT_CBC_CFC;
 }
 
-static bool fsl_ssi_is_i2s_cbm_cfs(struct fsl_ssi *ssi)
+static bool fsl_ssi_is_i2s_cbp_cfc(struct fsl_ssi *ssi)
 {
-       return (ssi->dai_fmt & SND_SOC_DAIFMT_MASTER_MASK) ==
-               SND_SOC_DAIFMT_CBM_CFS;
+       return (ssi->dai_fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) ==
+               SND_SOC_DAIFMT_CBP_CFC;
 }
 
 /**
@@ -808,7 +808,7 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
        u32 wl = SSI_SxCCR_WL(sample_size);
        int ret;
 
-       if (fsl_ssi_is_i2s_master(ssi)) {
+       if (fsl_ssi_is_i2s_clock_provider(ssi)) {
                ret = fsl_ssi_set_bclk(substream, dai, hw_params);
                if (ret)
                        return ret;
@@ -841,7 +841,7 @@ static int fsl_ssi_hw_params(struct snd_pcm_substream *substream,
                u8 i2s_net = ssi->i2s_net;
 
                /* Normal + Network mode to send 16-bit data in 32-bit frames */
-               if (fsl_ssi_is_i2s_cbm_cfs(ssi) && sample_size == 16)
+               if (fsl_ssi_is_i2s_cbp_cfc(ssi) && sample_size == 16)
                        i2s_net = SSI_SCR_I2S_MODE_NORMAL | SSI_SCR_NET;
 
                /* Use Normal mode to send mono data at 1st slot of 2 slots */
@@ -865,7 +865,7 @@ static int fsl_ssi_hw_free(struct snd_pcm_substream *substream,
        struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
        struct fsl_ssi *ssi = snd_soc_dai_get_drvdata(asoc_rtd_to_cpu(rtd, 0));
 
-       if (fsl_ssi_is_i2s_master(ssi) &&
+       if (fsl_ssi_is_i2s_clock_provider(ssi) &&
            ssi->baudclk_streams & BIT(substream->stream)) {
                clk_disable_unprepare(ssi->baudclk);
                ssi->baudclk_streams &= ~BIT(substream->stream);
@@ -891,18 +891,18 @@ static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt)
        ssi->i2s_net = SSI_SCR_NET;
        switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
        case SND_SOC_DAIFMT_I2S:
-               switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-               case SND_SOC_DAIFMT_CBS_CFS:
+               switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+               case SND_SOC_DAIFMT_CBC_CFC:
                        if (IS_ERR(ssi->baudclk)) {
                                dev_err(ssi->dev,
                                        "missing baudclk for master mode\n");
                                return -EINVAL;
                        }
                        fallthrough;
-               case SND_SOC_DAIFMT_CBM_CFS:
+               case SND_SOC_DAIFMT_CBP_CFC:
                        ssi->i2s_net |= SSI_SCR_I2S_MODE_MASTER;
                        break;
-               case SND_SOC_DAIFMT_CBM_CFM:
+               case SND_SOC_DAIFMT_CBP_CFP:
                        ssi->i2s_net |= SSI_SCR_I2S_MODE_SLAVE;
                        break;
                default:
@@ -962,17 +962,17 @@ static int _fsl_ssi_set_dai_fmt(struct fsl_ssi *ssi, unsigned int fmt)
                return -EINVAL;
        }
 
-       /* DAI clock master masks */
-       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
-       case SND_SOC_DAIFMT_CBS_CFS:
+       /* DAI clock provider masks */
+       switch (fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
                /* Output bit and frame sync clocks */
                strcr |= SSI_STCR_TFDIR | SSI_STCR_TXDIR;
                scr |= SSI_SCR_SYS_CLK_EN;
                break;
-       case SND_SOC_DAIFMT_CBM_CFM:
+       case SND_SOC_DAIFMT_CBP_CFP:
                /* Input bit or frame sync clocks */
                break;
-       case SND_SOC_DAIFMT_CBM_CFS:
+       case SND_SOC_DAIFMT_CBP_CFC:
                /* Input bit clock but output frame sync clock */
                strcr |= SSI_STCR_TFDIR;
                break;
@@ -1341,7 +1341,7 @@ static int fsl_ssi_imx_probe(struct platform_device *pdev,
                }
        }
 
-       /* Do not error out for slave cases that live without a baud clock */
+       /* Do not error out for consumer cases that live without a baud clock */
        ssi->baudclk = devm_clk_get(dev, "baud");
        if (IS_ERR(ssi->baudclk))
                dev_dbg(dev, "failed to get baud clock: %ld\n",
index a364e24..502fe1b 100644 (file)
@@ -80,8 +80,8 @@ static int imx_audmix_fe_hw_params(struct snd_pcm_substream *substream,
        u32 channels = params_channels(params);
        int ret, dir;
 
-       /* For playback the AUDMIX is slave, and for record is master */
-       fmt |= tx ? SND_SOC_DAIFMT_CBS_CFS : SND_SOC_DAIFMT_CBM_CFM;
+       /* For playback the AUDMIX is consumer, and for record is provider */
+       fmt |= tx ? SND_SOC_DAIFMT_CBC_CFC : SND_SOC_DAIFMT_CBP_CFP;
        dir  = tx ? SND_SOC_CLOCK_OUT : SND_SOC_CLOCK_IN;
 
        /* set DAI configuration */
@@ -121,8 +121,8 @@ static int imx_audmix_be_hw_params(struct snd_pcm_substream *substream,
        if (!tx)
                return 0;
 
-       /* For playback the AUDMIX is slave */
-       fmt |= SND_SOC_DAIFMT_CBM_CFM;
+       /* For playback the AUDMIX is consumer */
+       fmt |= SND_SOC_DAIFMT_CBP_CFP;
 
        /* set AUDMIX DAI configuration */
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0), fmt);
@@ -132,12 +132,12 @@ static int imx_audmix_be_hw_params(struct snd_pcm_substream *substream,
        return ret;
 }
 
-static struct snd_soc_ops imx_audmix_fe_ops = {
+static const struct snd_soc_ops imx_audmix_fe_ops = {
        .startup = imx_audmix_fe_startup,
        .hw_params = imx_audmix_fe_hw_params,
 };
 
-static struct snd_soc_ops imx_audmix_be_ops = {
+static const struct snd_soc_ops imx_audmix_be_ops = {
        .hw_params = imx_audmix_be_hw_params,
 };
 
index 58fd063..6f06afd 100644 (file)
@@ -442,12 +442,12 @@ static int imx_aif_startup(struct snd_pcm_substream *substream)
        return ret;
 }
 
-static struct snd_soc_ops imx_aif_ops = {
+static const struct snd_soc_ops imx_aif_ops = {
        .hw_params = imx_aif_hw_params,
        .startup = imx_aif_startup,
 };
 
-static struct snd_soc_ops imx_aif_ops_be = {
+static const struct snd_soc_ops imx_aif_ops_be = {
        .hw_params = imx_aif_hw_params,
 };
 
@@ -652,7 +652,7 @@ static int imx_card_parse_of(struct imx_card_data *data)
                                               NULL, &link->dai_fmt);
                if (ret)
                        link->dai_fmt = SND_SOC_DAIFMT_NB_NF |
-                                       SND_SOC_DAIFMT_CBS_CFS |
+                                       SND_SOC_DAIFMT_CBC_CFC |
                                        SND_SOC_DAIFMT_I2S;
 
                /* Get tdm slot */
index 1981dcd..09c674e 100644 (file)
@@ -174,7 +174,7 @@ static int imx_es8328_probe(struct platform_device *pdev)
        data->dai.platforms->of_node = ssi_np;
        data->dai.init = &imx_es8328_dai_init;
        data->dai.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                           SND_SOC_DAIFMT_CBM_CFM;
+                           SND_SOC_DAIFMT_CBP_CFP;
 
        data->card.dev = dev;
        data->card.dapm_widgets = imx_es8328_dapm_widgets;
index 34a0dce..f10359a 100644 (file)
@@ -59,7 +59,7 @@ static int imx_hdmi_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops imx_hdmi_ops = {
+static const struct snd_soc_ops imx_hdmi_ops = {
        .hw_params = imx_hdmi_hw_params,
 };
 
@@ -171,7 +171,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
                data->dai.codecs->name = "hdmi-audio-codec.1";
                data->dai.dai_fmt = data->dai_fmt |
                                    SND_SOC_DAIFMT_NB_NF |
-                                   SND_SOC_DAIFMT_CBS_CFS;
+                                   SND_SOC_DAIFMT_CBC_CFC;
        }
 
        if (hdmi_in) {
@@ -181,7 +181,7 @@ static int imx_hdmi_probe(struct platform_device *pdev)
                data->dai.codecs->name = "hdmi-audio-codec.2";
                data->dai.dai_fmt = data->dai_fmt |
                                    SND_SOC_DAIFMT_NB_NF |
-                                   SND_SOC_DAIFMT_CBM_CFM;
+                                   SND_SOC_DAIFMT_CBP_CFP;
        }
 
        data->card.dapm_widgets = imx_hdmi_widgets;
index f96fe4f..2e11731 100644 (file)
@@ -64,7 +64,7 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
        data->dai.stream_name = "rpmsg hifi";
        data->dai.dai_fmt = SND_SOC_DAIFMT_I2S |
                            SND_SOC_DAIFMT_NB_NF |
-                           SND_SOC_DAIFMT_CBS_CFS;
+                           SND_SOC_DAIFMT_CBC_CFC;
 
        /* Optional codec node */
        ret = of_parse_phandle_with_fixed_args(np, "audio-codec", 0, 0, &args);
index f45cb4b..2f1acd0 100644 (file)
@@ -153,7 +153,7 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
        data->dai.platforms->of_node = ssi_np;
        data->dai.init = &imx_sgtl5000_dai_init;
        data->dai.dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                           SND_SOC_DAIFMT_CBM_CFM;
+                           SND_SOC_DAIFMT_CBP_CFP;
 
        data->card.dev = &pdev->dev;
        ret = snd_soc_of_parse_card_name(&data->card, "model");
index 58b9ca3..e71a992 100644 (file)
@@ -264,7 +264,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
 
        if (strcasecmp(sprop, "i2s-slave") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBP_CFP;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
 
@@ -282,37 +282,37 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
                machine_data->clk_frequency = be32_to_cpup(iprop);
        } else if (strcasecmp(sprop, "i2s-master") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBC_CFC;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "lj-slave") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBP_CFP;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "lj-master") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBC_CFC;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "rj-slave") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBP_CFP;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "rj-master") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBC_CFC;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "ac97-slave") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBP_CFP;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_OUT;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "ac97-master") == 0) {
                machine_data->dai_format =
-                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBC_CFC;
                machine_data->codec_clk_direction = SND_SOC_CLOCK_IN;
                machine_data->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else {
index 317c767..b457429 100644 (file)
@@ -275,7 +275,7 @@ static int p1022_ds_probe(struct platform_device *pdev)
 
        if (strcasecmp(sprop, "i2s-slave") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBP_CFP;
                mdata->codec_clk_direction = SND_SOC_CLOCK_OUT;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_IN;
 
@@ -293,37 +293,37 @@ static int p1022_ds_probe(struct platform_device *pdev)
                mdata->clk_frequency = be32_to_cpup(iprop);
        } else if (strcasecmp(sprop, "i2s-master") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBC_CFC;
                mdata->codec_clk_direction = SND_SOC_CLOCK_IN;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "lj-slave") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBP_CFP;
                mdata->codec_clk_direction = SND_SOC_CLOCK_OUT;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "lj-master") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_LEFT_J | SND_SOC_DAIFMT_CBC_CFC;
                mdata->codec_clk_direction = SND_SOC_CLOCK_IN;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "rj-slave") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBP_CFP;
                mdata->codec_clk_direction = SND_SOC_CLOCK_OUT;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "rj-master") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_RIGHT_J | SND_SOC_DAIFMT_CBC_CFC;
                mdata->codec_clk_direction = SND_SOC_CLOCK_IN;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else if (strcasecmp(sprop, "ac97-slave") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBM_CFM;
+                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBP_CFP;
                mdata->codec_clk_direction = SND_SOC_CLOCK_OUT;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_IN;
        } else if (strcasecmp(sprop, "ac97-master") == 0) {
                mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBS_CFS;
+                       SND_SOC_DAIFMT_AC97 | SND_SOC_DAIFMT_CBC_CFC;
                mdata->codec_clk_direction = SND_SOC_CLOCK_IN;
                mdata->cpu_clk_direction = SND_SOC_CLOCK_OUT;
        } else {
index 714515b..b395ada 100644 (file)
@@ -265,7 +265,7 @@ static int p1022_rdk_probe(struct platform_device *pdev)
         * only one way to configure the SSI.
         */
        mdata->dai_format = SND_SOC_DAIFMT_NB_NF |
-               SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBM_CFM;
+               SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_CBP_CFP;
        mdata->codec_clk_direction = SND_SOC_CLOCK_OUT;
        mdata->cpu_clk_direction = SND_SOC_CLOCK_IN;
 
index 4cafcf0..b6df4e2 100644 (file)
@@ -17,3 +17,23 @@ config SND_AUDIO_GRAPH_CARD
          This option enables generic simple sound card support
          with OF-graph DT bindings.
          It also support DPCM of multi CPU single Codec ststem.
+
+config SND_AUDIO_GRAPH_CARD2
+       tristate "ASoC Audio Graph sound card2 support"
+       depends on OF
+       select SND_SIMPLE_CARD_UTILS
+       help
+         This option enables generic simple sound card2 support
+         with OF-graph DT bindings.
+
+config SND_AUDIO_GRAPH_CARD2_CUSTOM_SAMPLE
+       tristate "ASoC Audio Graph Card2 base custom sample support"
+       depends on SND_AUDIO_GRAPH_CARD2
+       help
+         This option enables Audio Graph Card2 base custom sample
+
+config SND_TEST_COMPONENT
+       tristate "ASoC Test component sound support"
+       depends on OF
+       help
+         This option enables test component sound driver support.
index 21c29e5..0848621 100644 (file)
@@ -2,7 +2,13 @@
 snd-soc-simple-card-utils-objs := simple-card-utils.o
 snd-soc-simple-card-objs       := simple-card.o
 snd-soc-audio-graph-card-objs  := audio-graph-card.o
+snd-soc-audio-graph-card2-objs := audio-graph-card2.o
+snd-soc-audio-graph-card2-custom-sample-objs := audio-graph-card2-custom-sample.o
+snd-soc-test-component-objs    := test-component.o
 
 obj-$(CONFIG_SND_SIMPLE_CARD_UTILS)    += snd-soc-simple-card-utils.o
 obj-$(CONFIG_SND_SIMPLE_CARD)          += snd-soc-simple-card.o
 obj-$(CONFIG_SND_AUDIO_GRAPH_CARD)     += snd-soc-audio-graph-card.o
+obj-$(CONFIG_SND_AUDIO_GRAPH_CARD2)    += snd-soc-audio-graph-card2.o
+obj-$(CONFIG_SND_AUDIO_GRAPH_CARD2_CUSTOM_SAMPLE) += snd-soc-audio-graph-card2-custom-sample.o
+obj-$(CONFIG_SND_TEST_COMPONENT)       += snd-soc-test-component.o
index 546f6fd..7eb0272 100644 (file)
@@ -310,8 +310,10 @@ static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv,
                 * For example: FE <-> BE1 <-> BE2 <-> ... <-> BEn where
                 * there are 'n' BE components in the path.
                 */
-               if (card->component_chaining && !soc_component_is_pcm(cpus))
+               if (card->component_chaining && !soc_component_is_pcm(cpus)) {
                        dai_link->no_pcm = 1;
+                       dai_link->be_hw_params_fixup = asoc_simple_be_hw_params_fixup;
+               }
 
                asoc_simple_canonicalize_cpu(cpus, is_single_links);
                asoc_simple_canonicalize_platform(platforms, cpus);
diff --git a/sound/soc/generic/audio-graph-card2-custom-sample.c b/sound/soc/generic/audio-graph-card2-custom-sample.c
new file mode 100644 (file)
index 0000000..4a2c743
--- /dev/null
@@ -0,0 +1,183 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// audio-graph-card2-custom-sample.c
+//
+// Copyright (C) 2020 Renesas Electronics Corp.
+// Copyright (C) 2020 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+//
+#include <linux/module.h>
+#include <linux/of_gpio.h>
+#include <linux/platform_device.h>
+#include <sound/graph_card.h>
+
+/*
+ * Custom driver can have own priv
+ * which includes asoc_simple_priv.
+ */
+struct custom_priv {
+       struct asoc_simple_priv simple_priv;
+
+       /* custom driver's own params */
+       int custom_params;
+};
+
+/* You can get custom_priv from simple_priv */
+#define simple_to_custom(simple) container_of((simple), struct custom_priv, simple_priv)
+
+static int custom_card_probe(struct snd_soc_card *card)
+{
+       struct asoc_simple_priv *simple_priv = snd_soc_card_get_drvdata(card);
+       struct custom_priv *custom_priv = simple_to_custom(simple_priv);
+       struct device *dev = simple_priv_to_dev(simple_priv);
+
+       dev_info(dev, "custom probe\n");
+
+       custom_priv->custom_params = 1;
+
+       /* you can use generic probe function */
+       return asoc_graph_card_probe(card);
+}
+
+static int custom_hook_pre(struct asoc_simple_priv *priv)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+
+       /* You can custom before parsing */
+       dev_info(dev, "hook : %s\n", __func__);
+
+       return 0;
+}
+
+static int custom_hook_post(struct asoc_simple_priv *priv)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+       struct snd_soc_card *card;
+
+       /* You can custom after parsing */
+       dev_info(dev, "hook : %s\n", __func__);
+
+       /* overwrite .probe sample */
+       card = simple_priv_to_card(priv);
+       card->probe = custom_card_probe;
+
+       return 0;
+}
+
+static int custom_normal(struct asoc_simple_priv *priv,
+                        struct device_node *lnk,
+                        struct link_info *li)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+
+       /*
+        * You can custom Normal parsing
+        * before/affter audio_graph2_link_normal()
+        */
+       dev_info(dev, "hook : %s\n", __func__);
+
+       return audio_graph2_link_normal(priv, lnk, li);
+}
+
+static int custom_dpcm(struct asoc_simple_priv *priv,
+                      struct device_node *lnk,
+                      struct link_info *li)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+
+       /*
+        * You can custom DPCM parsing
+        * before/affter audio_graph2_link_dpcm()
+        */
+       dev_info(dev, "hook : %s\n", __func__);
+
+       return audio_graph2_link_dpcm(priv, lnk, li);
+}
+
+static int custom_c2c(struct asoc_simple_priv *priv,
+                     struct device_node *lnk,
+                     struct link_info *li)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+
+       /*
+        * You can custom Codec2Codec parsing
+        * before/affter audio_graph2_link_c2c()
+        */
+       dev_info(dev, "hook : %s\n", __func__);
+
+       return audio_graph2_link_c2c(priv, lnk, li);
+}
+
+/*
+ * audio-graph-card2 has many hooks for your customizing.
+ */
+static struct graph2_custom_hooks custom_hooks = {
+       .hook_pre       = custom_hook_pre,
+       .hook_post      = custom_hook_post,
+       .custom_normal  = custom_normal,
+       .custom_dpcm    = custom_dpcm,
+       .custom_c2c     = custom_c2c,
+};
+
+static int custom_startup(struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct asoc_simple_priv *priv = snd_soc_card_get_drvdata(rtd->card);
+       struct device *dev = simple_priv_to_dev(priv);
+
+       dev_info(dev, "custom startup\n");
+
+       return asoc_simple_startup(substream);
+}
+
+/* You can use custom ops */
+static const struct snd_soc_ops custom_ops = {
+       .startup        = custom_startup,
+       .shutdown       = asoc_simple_shutdown,
+       .hw_params      = asoc_simple_hw_params,
+};
+
+static int custom_probe(struct platform_device *pdev)
+{
+       struct custom_priv *custom_priv;
+       struct asoc_simple_priv *simple_priv;
+       struct device *dev = &pdev->dev;
+       int ret;
+
+       custom_priv = devm_kzalloc(dev, sizeof(*custom_priv), GFP_KERNEL);
+       if (!custom_priv)
+               return -ENOMEM;
+
+       simple_priv             = &custom_priv->simple_priv;
+       simple_priv->ops        = &custom_ops; /* customize dai_link ops */
+
+       /* use audio-graph-card2 parsing with own custom hooks */
+       ret = audio_graph2_parse_of(simple_priv, dev, &custom_hooks);
+       if (ret < 0)
+               return ret;
+
+       /* customize more if needed */
+
+       return 0;
+}
+
+static const struct of_device_id custom_of_match[] = {
+       { .compatible = "audio-graph-card2-custom-sample", },
+       {},
+};
+MODULE_DEVICE_TABLE(of, custom_of_match);
+
+static struct platform_driver custom_card = {
+       .driver = {
+               .name = "audio-graph-card2-custom-sample",
+               .of_match_table = custom_of_match,
+       },
+       .probe  = custom_probe,
+       .remove = asoc_simple_remove,
+};
+module_platform_driver(custom_card);
+
+MODULE_ALIAS("platform:asoc-audio-graph-card2-custom-sample");
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("ASoC Audio Graph Card2 Custom Sample");
+MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
diff --git a/sound/soc/generic/audio-graph-card2-custom-sample.dtsi b/sound/soc/generic/audio-graph-card2-custom-sample.dtsi
new file mode 100644 (file)
index 0000000..8eee7b8
--- /dev/null
@@ -0,0 +1,227 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * audio-graph-card2-custom-sample.dtsi
+ *
+ * Copyright (C) 2020 Renesas Electronics Corp.
+ * Copyright (C) 2020 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+ *
+ * This sample indicates how to use audio-graph-card2 and its
+ * custom driver. "audio-graph-card2-custom-sample" is the custome driver
+ * which is using audio-graph-card2.
+ *
+ * You can easily use this sample by adding below line on your DT file,
+ * and add new CONFIG to your .config.
+ *
+ *     #include "../../../../../sound/soc/generic/audio-graph-card2-custom-sample.dtsi"
+ *
+ *     CONFIG_SND_AUDIO_GRAPH_CARD2
+ *     CONFIG_SND_AUDIO_GRAPH_CARD2_CUSTOM_SAMPLE
+ *     CONFIG_SND_TEST_COMPONENT
+ */
+/ {
+       /*
+        * @ : used at links
+        *
+        * [Normal]
+        *      cpu0 <-@-----------------> codec0
+        *
+        * [Multi-CPU/Codec]
+        *              +-+             +-+
+        *      cpu1 <--| |<-@--------->| |-> codec1
+        *      cpu2 <--| |             | |-> codec2
+        *              +-+             +-+
+        *
+        * [DPCM]
+        *      FE              BE
+        *                ****
+        *      cpu3 <-@--*  *--@-> codec3
+        *      cpu4 <-@--*  *
+        *                ****
+        *
+        * [DPCM-Multi]
+        *
+        * --NOTE--
+        * Multi-FE is not supported by ASoC.
+        *
+        *      FE              BE
+        *                ****      +-+
+        *      cpu5 <-@--*  *--@-> | | -> codec4
+        *      cpu6 <-@--*  *      | | -> codec5
+        *                ****      +-+
+        *
+        * [Codec2Codec]
+        *                         +-@-> codec6
+        *                         |
+        *                         +---> codec7
+        *
+        * [Codec2Codec-Multi]
+        *
+        * --NOTE--
+        * Multi connect N:M is not supported by ASoC.
+        *
+        *                              +-+
+        *                         +-@->| |-> codec8
+        *                         |    | |-> codec9
+        *                         |    +-+
+        *                         |    +-+
+        *                         +--->| |-> codec10
+        *                              | |-> codec11
+        *                              +-+
+        */
+       audio-graph-card2-custom-sample {
+               /*
+                * You can use audio-graph-card2 directly by using
+                *
+                * compatible = "audio-graph-card2";
+                */
+               compatible = "audio-graph-card2-custom-sample";
+
+                       /* for [DPCM]              */
+                       /* BE                   FE */
+               routing = "TC DAI3 Playback",   "DAI3 Playback",
+                         "TC DAI3 Playback",   "DAI4 Playback",
+                         "DAI3 Capture",       "TC DAI3 Capture",
+                         "DAI4 Capture",       "TC DAI3 Capture",
+                       /* for [DPCM-Multi]        */
+                       /* BE                   FE */
+                         "TC DAI4 Playback",   "DAI5 Playback",
+                         "TC DAI5 Playback",   "DAI5 Playback",
+                         "TC DAI4 Playback",   "DAI6 Playback",
+                         "TC DAI5 Playback",   "DAI6 Playback",
+                         "DAI5 Capture",       "TC DAI4 Capture",
+                         "DAI5 Capture",       "TC DAI5 Capture",
+                         "DAI6 Capture",       "TC DAI4 Capture",
+                         "DAI6 Capture",       "TC DAI5 Capture",
+                       /* for [Codec2Codec] */
+                         "TC OUT",             "TC DAI7 Playback",
+                         "TC DAI6 Capture",    "TC IN",
+                       /* for [Codec2Codec-Multi] */
+                         "TC OUT",             "TC DAI10 Playback",
+                         "TC DAI8 Capture",    "TC IN",
+                         "TC OUT",             "TC DAI11 Playback",
+                         "TC DAI9 Capture",    "TC IN";
+
+               links = <&cpu0                  /* normal: cpu side only */
+                        &mcpu0                 /* multi:  cpu side only */
+                        &fe00 &fe01 &be0       /* dpcm:   both FE / BE  */
+                        &fe10 &fe11 &be1       /* dpcm-m: both FE / BE  */
+                        &c2c                   /* c2c:    cpu side only */
+                        &c2c_m                 /* c2c:    cpu side only */
+               >;
+
+               multi {
+                       ports@0 {
+                       mcpu0:  port@0 { mcpu0_ep: endpoint { remote-endpoint = <&mcodec0_ep>; }; };
+                               port@1 { mcpu1_ep: endpoint { remote-endpoint = <&cpu1_ep>;    }; };
+                               port@2 { mcpu2_ep: endpoint { remote-endpoint = <&cpu2_ep>;    }; };
+                       };
+                       ports@1 {
+                               port@0 { mcodec0_ep: endpoint { remote-endpoint = <&mcpu0_ep>;  }; };
+                               port@1 { mcodec1_ep: endpoint { remote-endpoint = <&codec1_ep>; }; };
+                               port@2 { mcodec2_ep: endpoint { remote-endpoint = <&codec2_ep>; }; };
+                       };
+                       ports@2 {
+                               port@0 { mbe_ep:  endpoint { remote-endpoint = <&be10_ep>;  }; };
+                               port@1 { mbe1_ep: endpoint { remote-endpoint = <&codec4_ep>; }; };
+                               port@2 { mbe2_ep: endpoint { remote-endpoint = <&codec5_ep>; }; };
+                       };
+                       ports@3 {
+                               port@0 { mc2c0_ep:  endpoint { remote-endpoint = <&c2cmf_ep>;  }; };
+                               port@1 { mc2c00_ep: endpoint { remote-endpoint = <&codec8_ep>; }; };
+                               port@2 { mc2c01_ep: endpoint { remote-endpoint = <&codec9_ep>; }; };
+                       };
+                       ports@4 {
+                               port@0 { mc2c1_ep:  endpoint { remote-endpoint = <&c2cmb_ep>;  }; };
+                               port@1 { mc2c10_ep: endpoint { remote-endpoint = <&codec10_ep>; }; };
+                               port@2 { mc2c11_ep: endpoint { remote-endpoint = <&codec11_ep>; }; };
+                       };
+               };
+
+               dpcm {
+                       /* FE */
+                       ports@0 {
+                       fe00:   port@0 { fe00_ep: endpoint { remote-endpoint = <&cpu3_ep>; }; };
+                       fe01:   port@1 { fe01_ep: endpoint { remote-endpoint = <&cpu4_ep>; }; };
+                       fe10:   port@2 { fe10_ep: endpoint { remote-endpoint = <&cpu5_ep>; }; };
+                       fe11:   port@3 { fe11_ep: endpoint { remote-endpoint = <&cpu6_ep>; }; };
+                       };
+                       /* BE */
+                       ports@1 {
+                       be0:    port@0 { be00_ep: endpoint { remote-endpoint = <&codec3_ep>; }; };
+                       be1:    port@1 { be10_ep: endpoint { remote-endpoint = <&mbe_ep>; }; };
+                       };
+               };
+
+               codec2codec {
+                       ports@0 {
+                               rate = <48000>;
+                       c2c:    port@0 { c2cf_ep: endpoint { remote-endpoint = <&codec6_ep>; }; };
+                               port@1 { c2cb_ep: endpoint { remote-endpoint = <&codec7_ep>; }; };
+                       };
+                       ports@1 {
+                               rate = <48000>;
+                       c2c_m:  port@0 { c2cmf_ep: endpoint { remote-endpoint = <&mc2c0_ep>; }; };
+                               port@1 { c2cmb_ep: endpoint { remote-endpoint = <&mc2c1_ep>; }; };
+                       };
+               };
+       };
+
+       test_cpu {
+               /*
+                * update compatible to indicate more detail behaviour
+                * if you want. see test-compatible for more detail.
+                *
+                * ex)
+                *      - compatible = "test-cpu";
+                *      + compatible = "test-cpu-verbose";
+                */
+               compatible = "test-cpu";
+               ports {
+                       bitclock-master;
+                       frame-master;
+                       cpu0: port@0 { cpu0_ep: endpoint { remote-endpoint = <&codec0_ep>; }; };
+                             port@1 { cpu1_ep: endpoint { remote-endpoint = <&mcpu1_ep>; }; };
+                             port@2 { cpu2_ep: endpoint { remote-endpoint = <&mcpu2_ep>; }; };
+                             port@3 { cpu3_ep: endpoint { remote-endpoint = <&fe00_ep>; }; };
+                             port@4 { cpu4_ep: endpoint { remote-endpoint = <&fe01_ep>; }; };
+                             port@5 { cpu5_ep: endpoint { remote-endpoint = <&fe10_ep>; }; };
+                             port@6 { cpu6_ep: endpoint { remote-endpoint = <&fe11_ep>; }; };
+               };
+       };
+
+       test_codec {
+               /*
+                * update compatible to indicate more detail behaviour
+                * if you want. see test-compatible for more detail.
+                *
+                * ex)
+                *      - compatible = "test-codec";
+                *      + compatible = "test-codec-verbose";
+                */
+               compatible = "test-codec";
+               ports {
+                       /*
+                        * prefix can be added to *component*,
+                        * see audio-graph-card2::routing
+                        */
+                       prefix = "TC";
+
+                       port@0  { codec0_ep:  endpoint { remote-endpoint = <&cpu0_ep>; }; };
+                       port@1  { codec1_ep:  endpoint { remote-endpoint = <&mcodec1_ep>; }; };
+                       port@2  { codec2_ep:  endpoint { remote-endpoint = <&mcodec2_ep>; }; };
+                       port@3  { codec3_ep:  endpoint { remote-endpoint = <&be00_ep>; }; };
+                       port@4  { codec4_ep:  endpoint { remote-endpoint = <&mbe1_ep>; }; };
+                       port@5  { codec5_ep:  endpoint { remote-endpoint = <&mbe2_ep>; }; };
+                       port@6  { bitclock-master;
+                                 frame-master;
+                                 codec6_ep:  endpoint { remote-endpoint = <&c2cf_ep>; }; };
+                       port@7  { codec7_ep:  endpoint { remote-endpoint = <&c2cb_ep>; }; };
+                       port@8  { bitclock-master;
+                                 frame-master;
+                                 codec8_ep:  endpoint { remote-endpoint = <&mc2c00_ep>; }; };
+                       port@9  { codec9_ep:  endpoint { remote-endpoint = <&mc2c01_ep>; }; };
+                       port@10 { codec10_ep: endpoint { remote-endpoint = <&mc2c10_ep>; }; };
+                       port@11 { codec11_ep: endpoint { remote-endpoint = <&mc2c11_ep>; }; };
+               };
+       };
+};
diff --git a/sound/soc/generic/audio-graph-card2.c b/sound/soc/generic/audio-graph-card2.c
new file mode 100644 (file)
index 0000000..b6049bc
--- /dev/null
@@ -0,0 +1,1281 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// ASoC Audio Graph Card2 support
+//
+// Copyright (C) 2020 Renesas Electronics Corp.
+// Copyright (C) 2020 Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+//
+// based on ${LINUX}/sound/soc/generic/audio-graph-card.c
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/of_gpio.h>
+#include <linux/of_graph.h>
+#include <linux/platform_device.h>
+#include <linux/string.h>
+#include <sound/graph_card.h>
+
+/************************************
+       daifmt
+ ************************************
+       ports {
+               format = "left_j";
+               port@0 {
+                       bitclock-master;
+                       sample0: endpoint@0 {
+                               frame-master;
+                       };
+                       sample1: endpoint@1 {
+                               format = "i2s";
+                       };
+               };
+               ...
+       };
+
+ You can set daifmt at ports/port/endpoint.
+ It uses *latest* format, and *share* master settings.
+ In above case,
+       sample0: left_j, bitclock-master, frame-master
+       sample1: i2s,    bitclock-master
+
+ If there was no settings, *Codec* will be
+ bitclock/frame provider as default.
+ see
+       graph_parse_daifmt().
+
+ ************************************
+       Normal Audio-Graph
+ ************************************
+
+ CPU <---> Codec
+
+ sound {
+       compatible = "audio-graph-card2";
+       links = <&cpu>;
+ };
+
+ CPU {
+       cpu: port {
+               bitclock-master;
+               frame-master;
+               cpu_ep: endpoint { remote-endpoint = <&codec_ep>; }; };
+ };
+
+ Codec {
+       port {  codec_ep: endpoint { remote-endpoint = <&cpu_ep>; }; };
+ };
+
+ ************************************
+       Multi-CPU/Codec
+ ************************************
+
+It has connection part (= X) and list part (= y).
+links indicates connection part of CPU side (= A).
+
+           +-+   (A)        +-+
+ CPU1 --(y) | | <-(X)--(X)-> | | (y)-- Codec1
+ CPU2 --(y) | |                     | | (y)-- Codec2
+           +-+              +-+
+
+       sound {
+               compatible = "audio-graph-card2";
+
+(A)            links = <&mcpu>;
+
+               multi {
+                       ports@0 {
+(X) (A)                        mcpu:   port@0 { mcpu0_ep: endpoint { remote-endpoint = <&mcodec0_ep>; }; };
+(y)                            port@1 { mcpu1_ep: endpoint { remote-endpoint = <&cpu1_ep>; }; };
+(y)                            port@1 { mcpu2_ep: endpoint { remote-endpoint = <&cpu2_ep>; }; };
+                       };
+                       ports@1 {
+(X)                            port@0 { mcodec0_ep: endpoint { remote-endpoint = <&mcpu0_ep>; }; };
+(y)                            port@0 { mcodec1_ep: endpoint { remote-endpoint = <&codec1_ep>; }; };
+(y)                            port@1 { mcodec2_ep: endpoint { remote-endpoint = <&codec2_ep>; }; };
+                       };
+               };
+       };
+
+ CPU {
+       ports {
+               bitclock-master;
+               frame-master;
+               port@0 { cpu1_ep: endpoint { remote-endpoint = <&mcpu1_ep>; }; };
+               port@1 { cpu2_ep: endpoint { remote-endpoint = <&mcpu2_ep>; }; };
+       };
+ };
+
+ Codec {
+       ports {
+               port@0 { codec1_ep: endpoint { remote-endpoint = <&mcodec1_ep>; }; };
+               port@1 { codec2_ep: endpoint { remote-endpoint = <&mcodec2_ep>; }; };
+       };
+ };
+
+ ************************************
+       DPCM
+ ************************************
+
+               DSP
+          ************
+ PCM0 <--> * fe0  be0 * <--> DAI0: Codec Headset
+ PCM1 <--> * fe1  be1 * <--> DAI1: Codec Speakers
+ PCM2 <--> * fe2  be2 * <--> DAI2: MODEM
+ PCM3 <--> * fe3  be3 * <--> DAI3: BT
+          *      be4 * <--> DAI4: DMIC
+          *      be5 * <--> DAI5: FM
+          ************
+
+ sound {
+       compatible = "audio-graph-card2";
+
+       // indicate routing
+       routing = "xxx Playback", "xxx Playback",
+                 "xxx Playback", "xxx Playback",
+                 "xxx Playback", "xxx Playback";
+
+       // indicate all Front-End, Back-End
+       links = <&fe0, &fe1, ...,
+                &be0, &be1, ...>;
+
+       dpcm {
+               // Front-End
+               ports@0 {
+                       fe0: port@0 { fe0_ep: endpoint { remote-endpoint = <&pcm0_ep>; }; };
+                       fe1: port@1 { fe1_ep: endpoint { remote-endpoint = <&pcm1_ep>; }; };
+                       ...
+               };
+               // Back-End
+               ports@1 {
+                       be0: port@0 { be0_ep: endpoint { remote-endpoint = <&dai0_ep>; }; };
+                       be1: port@1 { be1_ep: endpoint { remote-endpoint = <&dai1_ep>; }; };
+                       ...
+               };
+       };
+ };
+
+ CPU {
+       ports {
+               bitclock-master;
+               frame-master;
+               port@0 { pcm0_ep: endpoint { remote-endpoint = <&fe0_ep>; }; };
+               port@1 { pcm1_ep: endpoint { remote-endpoint = <&fe1_ep>; }; };
+               ...
+       };
+ };
+
+ Codec {
+       ports {
+               port@0 { dai0_ep: endpoint { remote-endpoint = <&be0_ep>; }; };
+               port@1 { dai1_ep: endpoint { remote-endpoint = <&be1_ep>; }; };
+               ...
+       };
+ };
+
+ ************************************
+       Codec to Codec
+ ************************************
+
+ +--+
+ |  |<-- Codec0 <- IN
+ |  |--> Codec1 -> OUT
+ +--+
+
+ sound {
+       compatible = "audio-graph-card2";
+
+       routing = "OUT" ,"DAI1 Playback",
+                 "DAI0 Capture", "IN";
+
+       links = <&c2c>;
+
+       codec2codec {
+               ports {
+                       rate = <48000>;
+               c2c:    port@0 { c2cf_ep: endpoint { remote-endpoint = <&codec0_ep>; }; };
+                       port@1 { c2cb_ep: endpoint { remote-endpoint = <&codec1_ep>; }; };
+       };
+ };
+
+ Codec {
+       ports {
+               port@0 {
+                       bitclock-master;
+                       frame-master;
+                        codec0_ep: endpoint { remote-endpoint = <&c2cf_ep>; }; };
+               port@1 { codec1_ep: endpoint { remote-endpoint = <&c2cb_ep>; }; };
+       };
+ };
+
+*/
+
+enum graph_type {
+       GRAPH_NORMAL,
+       GRAPH_DPCM,
+       GRAPH_C2C,
+
+       GRAPH_MULTI,    /* don't use ! Use this only in __graph_get_type() */
+};
+
+#define GRAPH_NODENAME_MULTI   "multi"
+#define GRAPH_NODENAME_DPCM    "dpcm"
+#define GRAPH_NODENAME_C2C     "codec2codec"
+
+#define port_to_endpoint(port) of_get_child_by_name(port, "endpoint")
+
+static enum graph_type __graph_get_type(struct device_node *lnk)
+{
+       struct device_node *np;
+
+       /*
+        * target {
+        *      ports {
+        * =>           lnk:    port@0 { ... };
+        *                      port@1 { ... };
+        *      };
+        * };
+        */
+       np = of_get_parent(lnk);
+       if (of_node_name_eq(np, "ports"))
+               np = of_get_parent(np);
+
+       if (of_node_name_eq(np, GRAPH_NODENAME_MULTI))
+               return GRAPH_MULTI;
+
+       if (of_node_name_eq(np, GRAPH_NODENAME_DPCM))
+               return GRAPH_DPCM;
+
+       if (of_node_name_eq(np, GRAPH_NODENAME_C2C))
+               return GRAPH_C2C;
+
+       return GRAPH_NORMAL;
+}
+
+static enum graph_type graph_get_type(struct asoc_simple_priv *priv,
+                                     struct device_node *lnk)
+{
+       enum graph_type type = __graph_get_type(lnk);
+
+       /* GRAPH_MULTI here means GRAPH_NORMAL */
+       if (type == GRAPH_MULTI)
+               type = GRAPH_NORMAL;
+
+#ifdef DEBUG
+       {
+               struct device *dev = simple_priv_to_dev(priv);
+               const char *str = "Normal";
+
+               switch (type) {
+               case GRAPH_DPCM:
+                       if (asoc_graph_is_ports0(lnk))
+                               str = "DPCM Front-End";
+                       else
+                               str = "DPCM Back-End";
+                       break;
+               case GRAPH_C2C:
+                       str = "Codec2Codec";
+                       break;
+               default:
+                       break;
+               }
+
+               dev_dbg(dev, "%pOF (%s)", lnk, str);
+       }
+#endif
+       return type;
+}
+
+static int graph_lnk_is_multi(struct device_node *lnk)
+{
+       return __graph_get_type(lnk) == GRAPH_MULTI;
+}
+
+static struct device_node *graph_get_next_multi_ep(struct device_node **port)
+{
+       struct device_node *ports = of_get_parent(*port);
+       struct device_node *ep = NULL;
+       struct device_node *rep = NULL;
+
+       /*
+        * multi {
+        *      ports {
+        * =>   lnk:    port@0 { ... };
+        *              port@1 { ep { ... = rep0 } };
+        *              port@2 { ep { ... = rep1 } };
+        *              ...
+        *      };
+        * };
+        *
+        * xxx {
+        *      port@0 { rep0 };
+        *      port@1 { rep1 };
+        * };
+        */
+       do {
+               *port = of_get_next_child(ports, *port);
+               if (!*port)
+                       break;
+       } while (!of_node_name_eq(*port, "port"));
+
+       if (*port) {
+               ep  = port_to_endpoint(*port);
+               rep = of_graph_get_remote_endpoint(ep);
+       }
+
+       of_node_put(ep);
+       of_node_put(ports);
+
+       return rep;
+}
+
+static const struct snd_soc_ops graph_ops = {
+       .startup        = asoc_simple_startup,
+       .shutdown       = asoc_simple_shutdown,
+       .hw_params      = asoc_simple_hw_params,
+};
+
+static int graph_get_dai_id(struct device_node *ep)
+{
+       struct device_node *node;
+       struct device_node *endpoint;
+       struct of_endpoint info;
+       int i, id;
+       const u32 *reg;
+       int ret;
+
+       /* use driver specified DAI ID if exist */
+       ret = snd_soc_get_dai_id(ep);
+       if (ret != -ENOTSUPP)
+               return ret;
+
+       /* use endpoint/port reg if exist */
+       ret = of_graph_parse_endpoint(ep, &info);
+       if (ret == 0) {
+               /*
+                * Because it will count port/endpoint if it doesn't have "reg".
+                * But, we can't judge whether it has "no reg", or "reg = <0>"
+                * only of_graph_parse_endpoint().
+                * We need to check "reg" property
+                */
+               if (of_get_property(ep,   "reg", NULL))
+                       return info.id;
+
+               node = of_get_parent(ep);
+               reg = of_get_property(node, "reg", NULL);
+               of_node_put(node);
+               if (reg)
+                       return info.port;
+       }
+       node = of_graph_get_port_parent(ep);
+
+       /*
+        * Non HDMI sound case, counting port/endpoint on its DT
+        * is enough. Let's count it.
+        */
+       i = 0;
+       id = -1;
+       for_each_endpoint_of_node(node, endpoint) {
+               if (endpoint == ep)
+                       id = i;
+               i++;
+       }
+
+       of_node_put(node);
+
+       if (id < 0)
+               return -ENODEV;
+
+       return id;
+}
+
+static int asoc_simple_parse_dai(struct device_node *ep,
+                                struct snd_soc_dai_link_component *dlc,
+                                int *is_single_link)
+{
+       struct device_node *node;
+       struct of_phandle_args args;
+       int ret;
+
+       if (!ep)
+               return 0;
+
+       node = of_graph_get_port_parent(ep);
+
+       /* Get dai->name */
+       args.np         = node;
+       args.args[0]    = graph_get_dai_id(ep);
+       args.args_count = (of_graph_get_endpoint_count(node) > 1);
+
+       /*
+        * FIXME
+        *
+        * Here, dlc->dai_name is pointer to CPU/Codec DAI name.
+        * If user unbinded CPU or Codec driver, but not for Sound Card,
+        * dlc->dai_name is keeping unbinded CPU or Codec
+        * driver's pointer.
+        *
+        * If user re-bind CPU or Codec driver again, ALSA SoC will try
+        * to rebind Card via snd_soc_try_rebind_card(), but because of
+        * above reason, it might can't bind Sound Card.
+        * Because Sound Card is pointing to released dai_name pointer.
+        *
+        * To avoid this rebind Card issue,
+        * 1) It needs to alloc memory to keep dai_name eventhough
+        *    CPU or Codec driver was unbinded, or
+        * 2) user need to rebind Sound Card everytime
+        *    if he unbinded CPU or Codec.
+        */
+       ret = snd_soc_get_dai_name(&args, &dlc->dai_name);
+       if (ret < 0)
+               return ret;
+
+       dlc->of_node = node;
+
+       if (is_single_link)
+               *is_single_link = of_graph_get_endpoint_count(node) == 1;
+
+       return 0;
+}
+
+static void graph_parse_convert(struct device_node *ep,
+                               struct simple_dai_props *props)
+{
+       struct device_node *port = of_get_parent(ep);
+       struct device_node *ports = of_get_parent(port);
+       struct asoc_simple_data *adata = &props->adata;
+
+       if (of_node_name_eq(ports, "ports"))
+               asoc_simple_parse_convert(ports, NULL, adata);
+       asoc_simple_parse_convert(port, NULL, adata);
+       asoc_simple_parse_convert(ep,   NULL, adata);
+
+       of_node_put(port);
+       of_node_put(ports);
+}
+
+static void graph_parse_mclk_fs(struct device_node *ep,
+                               struct simple_dai_props *props)
+{
+       struct device_node *port        = of_get_parent(ep);
+       struct device_node *ports       = of_get_parent(port);
+
+       if (of_node_name_eq(ports, "ports"))
+               of_property_read_u32(ports, "mclk-fs", &props->mclk_fs);
+       of_property_read_u32(port,      "mclk-fs", &props->mclk_fs);
+       of_property_read_u32(ep,        "mclk-fs", &props->mclk_fs);
+
+       of_node_put(port);
+       of_node_put(ports);
+}
+
+static int __graph_parse_node(struct asoc_simple_priv *priv,
+                             enum graph_type gtype,
+                             struct device_node *ep,
+                             struct link_info *li,
+                             int is_cpu, int idx)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+       struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link);
+       struct simple_dai_props *dai_props = simple_priv_to_props(priv, li->link);
+       struct snd_soc_dai_link_component *dlc;
+       struct asoc_simple_dai *dai;
+       int ret, is_single_links = 0;
+
+       if (is_cpu) {
+               dlc = asoc_link_to_cpu(dai_link, idx);
+               dai = simple_props_to_dai_cpu(dai_props, idx);
+       } else {
+               dlc = asoc_link_to_codec(dai_link, idx);
+               dai = simple_props_to_dai_codec(dai_props, idx);
+       }
+
+       graph_parse_mclk_fs(ep, dai_props);
+
+       ret = asoc_simple_parse_dai(ep, dlc, &is_single_links);
+       if (ret < 0)
+               return ret;
+
+       ret = asoc_simple_parse_tdm(ep, dai);
+       if (ret < 0)
+               return ret;
+
+       ret = asoc_simple_parse_clk(dev, ep, dai, dlc);
+       if (ret < 0)
+               return ret;
+
+       /*
+        * set DAI Name
+        */
+       if (!dai_link->name) {
+               struct snd_soc_dai_link_component *cpus = dlc;
+               struct snd_soc_dai_link_component *codecs = asoc_link_to_codec(dai_link, idx);
+               char *cpu_multi   = "";
+               char *codec_multi = "";
+
+               if (dai_link->num_cpus > 1)
+                       cpu_multi = "_multi";
+               if (dai_link->num_codecs > 1)
+                       codec_multi = "_multi";
+
+               switch (gtype) {
+               case GRAPH_NORMAL:
+                       /* run is_cpu only. see audio_graph2_link_normal() */
+                       if (is_cpu)
+                               asoc_simple_set_dailink_name(dev, dai_link, "%s%s-%s%s",
+                                                              cpus->dai_name,   cpu_multi,
+                                                            codecs->dai_name, codec_multi);
+                       break;
+               case GRAPH_DPCM:
+                       if (is_cpu)
+                               asoc_simple_set_dailink_name(dev, dai_link, "fe.%pOFP.%s%s",
+                                               cpus->of_node, cpus->dai_name, cpu_multi);
+                       else
+                               asoc_simple_set_dailink_name(dev, dai_link, "be.%pOFP.%s%s",
+                                               codecs->of_node, codecs->dai_name, codec_multi);
+                       break;
+               case GRAPH_C2C:
+                       /* run is_cpu only. see audio_graph2_link_c2c() */
+                       if (is_cpu)
+                               asoc_simple_set_dailink_name(dev, dai_link, "c2c.%s%s-%s%s",
+                                                            cpus->dai_name,   cpu_multi,
+                                                            codecs->dai_name, codec_multi);
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       /*
+        * Check "prefix" from top node
+        * if DPCM-BE case
+        */
+       if (!is_cpu && gtype == GRAPH_DPCM) {
+               struct snd_soc_dai_link_component *codecs = asoc_link_to_codec(dai_link, idx);
+               struct snd_soc_codec_conf *cconf = simple_props_to_codec_conf(dai_props, idx);
+               struct device_node *rport  = of_get_parent(ep);
+               struct device_node *rports = of_get_parent(rport);
+
+               if (of_node_name_eq(rports, "ports"))
+                       snd_soc_of_parse_node_prefix(rports, cconf, codecs->of_node, "prefix");
+               snd_soc_of_parse_node_prefix(rport,  cconf, codecs->of_node, "prefix");
+
+               of_node_put(rport);
+               of_node_put(rports);
+       }
+
+       if (is_cpu) {
+               struct snd_soc_dai_link_component *cpus = dlc;
+               struct snd_soc_dai_link_component *platforms = asoc_link_to_platform(dai_link, idx);
+
+               asoc_simple_canonicalize_cpu(cpus, is_single_links);
+               asoc_simple_canonicalize_platform(platforms, cpus);
+       }
+
+       return 0;
+}
+
+static int graph_parse_node(struct asoc_simple_priv *priv,
+                           enum graph_type gtype,
+                           struct device_node *port,
+                           struct link_info *li, int is_cpu)
+{
+       struct device_node *ep;
+       int ret = 0;
+
+       if (graph_lnk_is_multi(port)) {
+               int idx;
+
+               of_node_get(port);
+
+               for (idx = 0;; idx++) {
+                       ep = graph_get_next_multi_ep(&port);
+                       if (!ep)
+                               break;
+
+                       ret = __graph_parse_node(priv, gtype, ep,
+                                                li, is_cpu, idx);
+                       of_node_put(ep);
+                       if (ret < 0)
+                               break;
+               }
+       } else {
+               /* Single CPU / Codec */
+               ep = port_to_endpoint(port);
+               ret = __graph_parse_node(priv, gtype, ep, li, is_cpu, 0);
+               of_node_put(ep);
+       }
+
+       return ret;
+}
+
+static void graph_parse_daifmt(struct device_node *node,
+                              unsigned int *daifmt, unsigned int *bit_frame)
+{
+       unsigned int fmt;
+
+       /*
+        * see also above "daifmt" explanation
+        * and samples.
+        */
+
+       /*
+        *      ports {
+        * (A)
+        *              port {
+        * (B)
+        *                      endpoint {
+        * (C)
+        *                      };
+        *              };
+        *      };
+        * };
+        */
+
+       /*
+        * clock_provider:
+        *
+        * It can be judged it is provider
+        * if (A) or (B) or (C) has bitclock-master / frame-master flag.
+        *
+        * use "or"
+        */
+       *bit_frame |= snd_soc_daifmt_parse_clock_provider_as_bitmap(node, NULL);
+
+#define update_daifmt(name)                                    \
+       if (!(*daifmt & SND_SOC_DAIFMT_##name##_MASK) &&        \
+                (fmt & SND_SOC_DAIFMT_##name##_MASK))          \
+               *daifmt |= fmt & SND_SOC_DAIFMT_##name##_MASK
+
+       /*
+        * format
+        *
+        * This function is called by (C) -> (B) -> (A) order.
+        * Set if applicable part was not yet set.
+        */
+       fmt = snd_soc_daifmt_parse_format(node, NULL);
+       update_daifmt(FORMAT);
+       update_daifmt(CLOCK);
+       update_daifmt(INV);
+}
+
+static void graph_link_init(struct asoc_simple_priv *priv,
+                           struct device_node *port,
+                           struct link_info *li,
+                           int is_cpu_node)
+{
+       struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link);
+       struct device_node *ep;
+       struct device_node *ports;
+       unsigned int daifmt = 0, daiclk = 0;
+       unsigned int bit_frame = 0;
+
+       if (graph_lnk_is_multi(port)) {
+               of_node_get(port);
+               ep = graph_get_next_multi_ep(&port);
+               port = of_get_parent(ep);
+       } else {
+               ep = port_to_endpoint(port);
+       }
+
+       ports = of_get_parent(port);
+
+       /*
+        *      ports {
+        * (A)
+        *              port {
+        * (B)
+        *                      endpoint {
+        * (C)
+        *                      };
+        *              };
+        *      };
+        * };
+        */
+       graph_parse_daifmt(ep,    &daifmt, &bit_frame);         /* (C) */
+       graph_parse_daifmt(port,  &daifmt, &bit_frame);         /* (B) */
+       if (of_node_name_eq(ports, "ports"))
+               graph_parse_daifmt(ports, &daifmt, &bit_frame); /* (A) */
+
+       /*
+        * convert bit_frame
+        * We need to flip clock_provider if it was CPU node,
+        * because it is Codec base.
+        */
+       daiclk = snd_soc_daifmt_clock_provider_from_bitmap(bit_frame);
+       if (is_cpu_node)
+               daiclk = snd_soc_daifmt_clock_provider_fliped(daiclk);
+
+       dai_link->dai_fmt       = daifmt | daiclk;
+       dai_link->init          = asoc_simple_dai_init;
+       dai_link->ops           = &graph_ops;
+       if (priv->ops)
+               dai_link->ops   = priv->ops;
+}
+
+int audio_graph2_link_normal(struct asoc_simple_priv *priv,
+                            struct device_node *lnk,
+                            struct link_info *li)
+{
+       struct device_node *cpu_port = lnk;
+       struct device_node *cpu_ep = port_to_endpoint(cpu_port);
+       struct device_node *codec_port = of_graph_get_remote_port(cpu_ep);
+       int ret;
+
+       /*
+        * call Codec first.
+        * see
+        *      __graph_parse_node() :: DAI Naming
+        */
+       ret = graph_parse_node(priv, GRAPH_NORMAL, codec_port, li, 0);
+       if (ret < 0)
+               goto err;
+
+       /*
+        * call CPU, and set DAI Name
+        */
+       ret = graph_parse_node(priv, GRAPH_NORMAL, cpu_port, li, 1);
+       if (ret < 0)
+               goto err;
+
+       graph_link_init(priv, cpu_port, li, 1);
+err:
+       of_node_put(codec_port);
+       of_node_put(cpu_ep);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(audio_graph2_link_normal);
+
+int audio_graph2_link_dpcm(struct asoc_simple_priv *priv,
+                          struct device_node *lnk,
+                          struct link_info *li)
+{
+       struct device_node *ep = port_to_endpoint(lnk);
+       struct device_node *rep = of_graph_get_remote_endpoint(ep);
+       struct device_node *rport = of_graph_get_remote_port(ep);
+       struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link);
+       struct simple_dai_props *dai_props = simple_priv_to_props(priv, li->link);
+       int is_cpu = asoc_graph_is_ports0(lnk);
+       int ret;
+
+       if (is_cpu) {
+               /*
+                * dpcm {
+                *      // Front-End
+                *      ports@0 {
+                * =>           lnk: port@0 { ep: { ... = rep }; };
+                *               ...
+                *      };
+                *      // Back-End
+                *      ports@0 {
+                *               ...
+                *      };
+                * };
+                *
+                * CPU {
+                *      rports: ports {
+                *              rport: port@0 { rep: { ... = ep } };
+                *      }
+                * }
+                */
+               /*
+                * setup CPU here, Codec is already set as dummy.
+                * see
+                *      asoc_simple_init_priv()
+                */
+               dai_link->dynamic               = 1;
+               dai_link->dpcm_merged_format    = 1;
+
+               ret = graph_parse_node(priv, GRAPH_DPCM, rport, li, 1);
+               if (ret)
+                       goto err;
+       } else {
+               /*
+                * dpcm {
+                *      // Front-End
+                *      ports@0 {
+                *               ...
+                *      };
+                *      // Back-End
+                *      ports@0 {
+                * =>           lnk: port@0 { ep: { ... = rep; }; };
+                *               ...
+                *      };
+                * };
+                *
+                * Codec {
+                *      rports: ports {
+                *              rport: port@0 { rep: { ... = ep; }; };
+                *      }
+                * }
+                */
+               /*
+                * setup Codec here, CPU is already set as dummy.
+                * see
+                *      asoc_simple_init_priv()
+                */
+
+               /* BE settings */
+               dai_link->no_pcm                = 1;
+               dai_link->be_hw_params_fixup    = asoc_simple_be_hw_params_fixup;
+
+               ret = graph_parse_node(priv, GRAPH_DPCM, rport, li, 0);
+               if (ret < 0)
+                       goto err;
+       }
+
+       graph_parse_convert(rep, dai_props);
+
+       snd_soc_dai_link_set_capabilities(dai_link);
+
+       graph_link_init(priv, rport, li, is_cpu);
+err:
+       of_node_put(ep);
+       of_node_put(rep);
+       of_node_put(rport);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(audio_graph2_link_dpcm);
+
+int audio_graph2_link_c2c(struct asoc_simple_priv *priv,
+                         struct device_node *lnk,
+                         struct link_info *li)
+{
+       struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link);
+       struct simple_dai_props *dai_props = simple_priv_to_props(priv, li->link);
+       struct snd_soc_pcm_stream *c2c_conf = dai_props->c2c_conf;
+       struct device_node *port0, *port1, *ports;
+       struct device_node *codec0_port, *codec1_port;
+       struct device_node *ep0, *ep1;
+       u32 val;
+       int ret = -EINVAL;
+
+       /*
+        * codec2codec {
+        *      ports {
+        *              rate = <48000>;
+        * =>   lnk:    port@0 { c2c0_ep: { ... = codec0_ep; }; };
+        *              port@1 { c2c1_ep: { ... = codec1_ep; }; };
+        *      };
+        * };
+        *
+        * Codec {
+        *      ports {
+        *              port@0 { codec0_ep: ... }; };
+        *              port@1 { codec1_ep: ... }; };
+        *      };
+        * };
+        */
+       of_node_get(lnk);
+       port0 = lnk;
+       ports = of_get_parent(port0);
+       port1 = of_get_next_child(ports, lnk);
+
+       if (!of_get_property(ports, "rate", &val)) {
+               struct device *dev = simple_priv_to_dev(priv);
+
+               dev_err(dev, "Codec2Codec needs rate settings\n");
+               goto err1;
+       }
+
+       c2c_conf->formats       = SNDRV_PCM_FMTBIT_S32_LE; /* update ME */
+       c2c_conf->rate_min      =
+       c2c_conf->rate_max      = val;
+       c2c_conf->channels_min  =
+       c2c_conf->channels_max  = 2; /* update ME */
+       dai_link->params        = c2c_conf;
+
+       ep0 = port_to_endpoint(port0);
+       ep1 = port_to_endpoint(port1);
+
+       codec0_port = of_graph_get_remote_port(ep0);
+       codec1_port = of_graph_get_remote_port(ep1);
+
+       /*
+        * call Codec first.
+        * see
+        *      __graph_parse_node() :: DAI Naming
+        */
+       ret = graph_parse_node(priv, GRAPH_C2C, codec1_port, li, 0);
+       if (ret < 0)
+               goto err2;
+
+       /*
+        * call CPU, and set DAI Name
+        */
+       ret = graph_parse_node(priv, GRAPH_C2C, codec0_port, li, 1);
+       if (ret < 0)
+               goto err2;
+
+       graph_link_init(priv, codec0_port, li, 1);
+err2:
+       of_node_put(ep0);
+       of_node_put(ep1);
+       of_node_put(codec0_port);
+       of_node_put(codec1_port);
+err1:
+       of_node_put(ports);
+       of_node_put(port0);
+       of_node_put(port1);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(audio_graph2_link_c2c);
+
+static int graph_link(struct asoc_simple_priv *priv,
+                     struct graph2_custom_hooks *hooks,
+                     enum graph_type gtype,
+                     struct device_node *lnk,
+                     struct link_info *li)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+       GRAPH2_CUSTOM func = NULL;
+       int ret = -EINVAL;
+
+       switch (gtype) {
+       case GRAPH_NORMAL:
+               if (hooks && hooks->custom_normal)
+                       func = hooks->custom_normal;
+               else
+                       func = audio_graph2_link_normal;
+               break;
+       case GRAPH_DPCM:
+               if (hooks && hooks->custom_dpcm)
+                       func = hooks->custom_dpcm;
+               else
+                       func = audio_graph2_link_dpcm;
+               break;
+       case GRAPH_C2C:
+               if (hooks && hooks->custom_c2c)
+                       func = hooks->custom_c2c;
+               else
+                       func = audio_graph2_link_c2c;
+               break;
+       default:
+               break;
+       }
+
+       if (!func) {
+               dev_err(dev, "non supported gtype (%d)\n", gtype);
+               goto err;
+       }
+
+       ret = func(priv, lnk, li);
+       if (ret < 0)
+               goto err;
+
+       li->link++;
+err:
+       return ret;
+}
+
+static int graph_counter(struct device_node *lnk)
+{
+       /*
+        * Multi CPU / Codec
+        *
+        * multi {
+        *      ports {
+        * =>           lnk:    port@0 { ... };
+        *                      port@1 { ... };
+        *                      port@2 { ... };
+        *                      ...
+        *      };
+        * };
+        *
+        * ignore first lnk part
+        */
+       if (graph_lnk_is_multi(lnk))
+               return of_graph_get_endpoint_count(of_get_parent(lnk)) - 1;
+       /*
+        * Single CPU / Codec
+        */
+       else
+               return 1;
+}
+
+static int graph_count_normal(struct asoc_simple_priv *priv,
+                             struct device_node *lnk,
+                             struct link_info *li)
+{
+       struct device_node *cpu_port = lnk;
+       struct device_node *cpu_ep = port_to_endpoint(cpu_port);
+       struct device_node *codec_port = of_graph_get_remote_port(cpu_ep);
+
+       /*
+        *      CPU {
+        * =>           lnk: port { endpoint { .. }; };
+        *      };
+        */
+       li->num[li->link].cpus          =
+       li->num[li->link].platforms     = graph_counter(cpu_port);
+       li->num[li->link].codecs        = graph_counter(codec_port);
+
+       of_node_put(cpu_ep);
+       of_node_put(codec_port);
+
+       return 0;
+}
+
+static int graph_count_dpcm(struct asoc_simple_priv *priv,
+                           struct device_node *lnk,
+                           struct link_info *li)
+{
+       struct device_node *ep = port_to_endpoint(lnk);
+       struct device_node *rport = of_graph_get_remote_port(ep);
+
+       /*
+        * dpcm {
+        *      // Front-End
+        *      ports@0 {
+        * =>           lnk: port@0 { endpoint { ... }; };
+        *               ...
+        *      };
+        *      // Back-End
+        *      ports@1 {
+        * =>           lnk: port@0 { endpoint { ... }; };
+        *               ...
+        *      };
+        * };
+        */
+
+       if (asoc_graph_is_ports0(lnk)) {
+               li->num[li->link].cpus          = graph_counter(rport); /* FE */
+               li->num[li->link].platforms     = graph_counter(rport);
+       } else {
+               li->num[li->link].codecs        = graph_counter(rport); /* BE */
+       }
+
+       of_node_put(ep);
+       of_node_put(rport);
+
+       return 0;
+}
+
+static int graph_count_c2c(struct asoc_simple_priv *priv,
+                          struct device_node *lnk,
+                          struct link_info *li)
+{
+       struct device_node *ports = of_get_parent(lnk);
+       struct device_node *port0 = lnk;
+       struct device_node *port1 = of_get_next_child(ports, lnk);
+       struct device_node *ep0 = port_to_endpoint(port0);
+       struct device_node *ep1 = port_to_endpoint(port1);
+       struct device_node *codec0 = of_graph_get_remote_port(ep0);
+       struct device_node *codec1 = of_graph_get_remote_port(ep1);
+
+       of_node_get(lnk);
+
+       /*
+        * codec2codec {
+        *      ports {
+        * =>   lnk:    port@0 { endpoint { ... }; };
+        *              port@1 { endpoint { ... }; };
+        *      };
+        * };
+        */
+       li->num[li->link].cpus          =
+       li->num[li->link].platforms     = graph_counter(codec0);
+       li->num[li->link].codecs        = graph_counter(codec1);
+       li->num[li->link].c2c           = 1;
+
+       of_node_put(ports);
+       of_node_put(port1);
+       of_node_put(ep0);
+       of_node_put(ep1);
+       of_node_put(codec0);
+       of_node_put(codec1);
+
+       return 0;
+}
+
+static int graph_count(struct asoc_simple_priv *priv,
+                      struct graph2_custom_hooks *hooks,
+                      enum graph_type gtype,
+                      struct device_node *lnk,
+                      struct link_info *li)
+{
+       struct device *dev = simple_priv_to_dev(priv);
+       GRAPH2_CUSTOM func = NULL;
+       int ret = -EINVAL;
+
+       if (li->link >= SNDRV_MAX_LINKS) {
+               dev_err(dev, "too many links\n");
+               return ret;
+       }
+
+       switch (gtype) {
+       case GRAPH_NORMAL:
+               func = graph_count_normal;
+               break;
+       case GRAPH_DPCM:
+               func = graph_count_dpcm;
+               break;
+       case GRAPH_C2C:
+               func = graph_count_c2c;
+               break;
+       default:
+               break;
+       }
+
+       if (!func) {
+               dev_err(dev, "non supported gtype (%d)\n", gtype);
+               goto err;
+       }
+
+       ret = func(priv, lnk, li);
+       if (ret < 0)
+               goto err;
+
+       li->link++;
+err:
+       return ret;
+}
+
+static int graph_for_each_link(struct asoc_simple_priv *priv,
+                              struct graph2_custom_hooks *hooks,
+                              struct link_info *li,
+                              int (*func)(struct asoc_simple_priv *priv,
+                                          struct graph2_custom_hooks *hooks,
+                                          enum graph_type gtype,
+                                          struct device_node *lnk,
+                                          struct link_info *li))
+{
+       struct of_phandle_iterator it;
+       struct device *dev = simple_priv_to_dev(priv);
+       struct device_node *node = dev->of_node;
+       struct device_node *lnk;
+       enum graph_type gtype;
+       int rc, ret;
+
+       /* loop for all listed CPU port */
+       of_for_each_phandle(&it, rc, node, "links", NULL, 0) {
+               lnk = it.node;
+
+               gtype = graph_get_type(priv, lnk);
+
+               ret = func(priv, hooks, gtype, lnk, li);
+               if (ret < 0)
+                       return ret;
+       }
+
+       return 0;
+}
+
+int audio_graph2_parse_of(struct asoc_simple_priv *priv, struct device *dev,
+                         struct graph2_custom_hooks *hooks)
+{
+       struct snd_soc_card *card = simple_priv_to_card(priv);
+       struct link_info *li;
+       int ret;
+
+       dev_warn(dev, "Audio Graph Card2 is still under Experimental stage\n");
+
+       li = devm_kzalloc(dev, sizeof(*li), GFP_KERNEL);
+       if (!li)
+               return -ENOMEM;
+
+       card->probe     = asoc_graph_card_probe;
+       card->owner     = THIS_MODULE;
+       card->dev       = dev;
+
+       if ((hooks) && (hooks)->hook_pre) {
+               ret = (hooks)->hook_pre(priv);
+               if (ret < 0)
+                       goto err;
+       }
+
+       ret = graph_for_each_link(priv, hooks, li, graph_count);
+       if (!li->link)
+               ret = -EINVAL;
+       if (ret < 0)
+               goto err;
+
+       ret = asoc_simple_init_priv(priv, li);
+       if (ret < 0)
+               goto err;
+
+       priv->pa_gpio = devm_gpiod_get_optional(dev, "pa", GPIOD_OUT_LOW);
+       if (IS_ERR(priv->pa_gpio)) {
+               ret = PTR_ERR(priv->pa_gpio);
+               dev_err(dev, "failed to get amplifier gpio: %d\n", ret);
+               goto err;
+       }
+
+       ret = asoc_simple_parse_widgets(card, NULL);
+       if (ret < 0)
+               goto err;
+
+       ret = asoc_simple_parse_routing(card, NULL);
+       if (ret < 0)
+               goto err;
+
+       memset(li, 0, sizeof(*li));
+       ret = graph_for_each_link(priv, hooks, li, graph_link);
+       if (ret < 0)
+               goto err;
+
+       ret = asoc_simple_parse_card_name(card, NULL);
+       if (ret < 0)
+               goto err;
+
+       snd_soc_card_set_drvdata(card, priv);
+
+       if ((hooks) && (hooks)->hook_post) {
+               ret = (hooks)->hook_post(priv);
+               if (ret < 0)
+                       goto err;
+       }
+
+       asoc_simple_debug_info(priv);
+
+       ret = devm_snd_soc_register_card(dev, card);
+err:
+       devm_kfree(dev, li);
+
+       if ((ret < 0) && (ret != -EPROBE_DEFER))
+               dev_err(dev, "parse error %d\n", ret);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(audio_graph2_parse_of);
+
+static int graph_probe(struct platform_device *pdev)
+{
+       struct asoc_simple_priv *priv;
+       struct device *dev = &pdev->dev;
+
+       /* Allocate the private data and the DAI link array */
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       return audio_graph2_parse_of(priv, dev, NULL);
+}
+
+static const struct of_device_id graph_of_match[] = {
+       { .compatible = "audio-graph-card2", },
+       {},
+};
+MODULE_DEVICE_TABLE(of, graph_of_match);
+
+static struct platform_driver graph_card = {
+       .driver = {
+               .name = "asoc-audio-graph-card2",
+               .pm = &snd_soc_pm_ops,
+               .of_match_table = graph_of_match,
+       },
+       .probe  = graph_probe,
+       .remove = asoc_simple_remove,
+};
+module_platform_driver(graph_card);
+
+MODULE_ALIAS("platform:asoc-audio-graph-card2");
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("ASoC Audio Graph Card2");
+MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
index 10c63b7..850e968 100644 (file)
@@ -355,9 +355,9 @@ static int asoc_simple_init_dai_link_params(struct snd_soc_pcm_runtime *rtd,
        struct snd_pcm_hardware hw;
        int i, ret, stream;
 
-       /* Only codecs should have non_legacy_dai_naming set. */
+       /* Only Codecs */
        for_each_rtd_components(rtd, i, component) {
-               if (!component->driver->non_legacy_dai_naming)
+               if (!snd_soc_component_is_codec(component))
                        return 0;
        }
 
@@ -619,7 +619,8 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
        struct asoc_simple_dai *dais;
        struct snd_soc_dai_link_component *dlcs;
        struct snd_soc_codec_conf *cconf = NULL;
-       int i, dai_num = 0, dlc_num = 0, cnf_num = 0;
+       struct snd_soc_pcm_stream *c2c_conf = NULL;
+       int i, dai_num = 0, dlc_num = 0, cnf_num = 0, c2c_num = 0;
 
        dai_props = devm_kcalloc(dev, li->link, sizeof(*dai_props), GFP_KERNEL);
        dai_link  = devm_kcalloc(dev, li->link, sizeof(*dai_link),  GFP_KERNEL);
@@ -638,6 +639,8 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
 
                if (!li->num[i].cpus)
                        cnf_num += li->num[i].codecs;
+
+               c2c_num += li->num[i].c2c;
        }
 
        dais = devm_kcalloc(dev, dai_num, sizeof(*dais), GFP_KERNEL);
@@ -651,6 +654,12 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
                        return -ENOMEM;
        }
 
+       if (c2c_num) {
+               c2c_conf = devm_kcalloc(dev, c2c_num, sizeof(*c2c_conf), GFP_KERNEL);
+               if (!c2c_conf)
+                       return -ENOMEM;
+       }
+
        dev_dbg(dev, "link %d, dais %d, ccnf %d\n",
                li->link, dai_num, cnf_num);
 
@@ -664,6 +673,7 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
        priv->dais              = dais;
        priv->dlcs              = dlcs;
        priv->codec_conf        = cconf;
+       priv->c2c_conf          = c2c_conf;
 
        card->dai_link          = priv->dai_link;
        card->num_links         = li->link;
@@ -681,6 +691,12 @@ int asoc_simple_init_priv(struct asoc_simple_priv *priv,
 
                        dlcs += li->num[i].cpus;
                        dais += li->num[i].cpus;
+
+                       if (li->num[i].c2c) {
+                               /* Codec2Codec */
+                               dai_props[i].c2c_conf = c2c_conf;
+                               c2c_conf += li->num[i].c2c;
+                       }
                } else {
                        /* DPCM Be's CPU = dummy */
                        dai_props[i].cpus       =
@@ -759,6 +775,34 @@ int asoc_graph_card_probe(struct snd_soc_card *card)
 }
 EXPORT_SYMBOL_GPL(asoc_graph_card_probe);
 
+int asoc_graph_is_ports0(struct device_node *np)
+{
+       struct device_node *port, *ports, *ports0, *top;
+       int ret;
+
+       /* np is "endpoint" or "port" */
+       if (of_node_name_eq(np, "endpoint")) {
+               port = of_get_parent(np);
+       } else {
+               port = np;
+               of_node_get(port);
+       }
+
+       ports   = of_get_parent(port);
+       top     = of_get_parent(ports);
+       ports0  = of_get_child_by_name(top, "ports");
+
+       ret = ports0 == ports;
+
+       of_node_put(port);
+       of_node_put(ports);
+       of_node_put(ports0);
+       of_node_put(top);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(asoc_graph_is_ports0);
+
 /* Module information */
 MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
 MODULE_DESCRIPTION("ALSA SoC Simple Card Utils");
diff --git a/sound/soc/generic/test-component.c b/sound/soc/generic/test-component.c
new file mode 100644 (file)
index 0000000..85385a7
--- /dev/null
@@ -0,0 +1,659 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// test-component.c  --  Test Audio Component driver
+//
+// Copyright (C) 2020 Renesas Electronics Corporation
+// Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+
+#include <linux/slab.h>
+#include <linux/of_device.h>
+#include <linux/of_graph.h>
+#include <linux/module.h>
+#include <linux/workqueue.h>
+#include <sound/pcm.h>
+#include <sound/soc.h>
+
+#define TEST_NAME_LEN 32
+struct test_dai_name {
+       char name[TEST_NAME_LEN];
+       char name_playback[TEST_NAME_LEN];
+       char name_capture[TEST_NAME_LEN];
+};
+
+struct test_priv {
+       struct device *dev;
+       struct snd_pcm_substream *substream;
+       struct delayed_work dwork;
+       struct snd_soc_component_driver *component_driver;
+       struct snd_soc_dai_driver *dai_driver;
+       struct test_dai_name *name;
+};
+
+struct test_adata {
+       u32 is_cpu:1;
+       u32 cmp_v:1;
+       u32 dai_v:1;
+};
+
+#define mile_stone(d)          dev_info((d)->dev, "%s() : %s", __func__, (d)->driver->name)
+#define mile_stone_x(dev)      dev_info(dev, "%s()", __func__)
+
+static int test_dai_set_sysclk(struct snd_soc_dai *dai,
+                              int clk_id, unsigned int freq, int dir)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_set_pll(struct snd_soc_dai *dai, int pll_id, int source,
+                           unsigned int freq_in, unsigned int freq_out)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_set_clkdiv(struct snd_soc_dai *dai, int div_id, int div)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+       unsigned int format = fmt & SND_SOC_DAIFMT_FORMAT_MASK;
+       unsigned int clock  = fmt & SND_SOC_DAIFMT_CLOCK_MASK;
+       unsigned int inv    = fmt & SND_SOC_DAIFMT_INV_MASK;
+       unsigned int master = fmt & SND_SOC_DAIFMT_MASTER_MASK;
+       char *str;
+
+       dev_info(dai->dev, "name   : %s", dai->name);
+
+       str = "unknown";
+       switch (format) {
+       case SND_SOC_DAIFMT_I2S:
+               str = "i2s";
+               break;
+       case SND_SOC_DAIFMT_RIGHT_J:
+               str = "right_j";
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               str = "left_j";
+               break;
+       case SND_SOC_DAIFMT_DSP_A:
+               str = "dsp_a";
+               break;
+       case SND_SOC_DAIFMT_DSP_B:
+               str = "dsp_b";
+               break;
+       case SND_SOC_DAIFMT_AC97:
+               str = "ac97";
+               break;
+       case SND_SOC_DAIFMT_PDM:
+               str = "pdm";
+               break;
+       }
+       dev_info(dai->dev, "format : %s", str);
+
+       if (clock == SND_SOC_DAIFMT_CONT)
+               str = "continuous";
+       else
+               str = "gated";
+       dev_info(dai->dev, "clock  : %s", str);
+
+       str = "unknown";
+       switch (master) {
+       case SND_SOC_DAIFMT_CBP_CFP:
+               str = "clk provider, frame provider";
+               break;
+       case SND_SOC_DAIFMT_CBC_CFP:
+               str = "clk consumer, frame provider";
+               break;
+       case SND_SOC_DAIFMT_CBP_CFC:
+               str = "clk provider, frame consumer";
+               break;
+       case SND_SOC_DAIFMT_CBC_CFC:
+               str = "clk consumer, frame consumer";
+               break;
+       }
+       dev_info(dai->dev, "clock  : codec is %s", str);
+
+       str = "unknown";
+       switch (inv) {
+       case SND_SOC_DAIFMT_NB_NF:
+               str = "normal bit, normal frame";
+               break;
+       case SND_SOC_DAIFMT_NB_IF:
+               str = "normal bit, invert frame";
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               str = "invert bit, normal frame";
+               break;
+       case SND_SOC_DAIFMT_IB_IF:
+               str = "invert bit, invert frame";
+               break;
+       }
+       dev_info(dai->dev, "signal : %s", str);
+
+       return 0;
+}
+
+static int test_dai_mute_stream(struct snd_soc_dai *dai, int mute, int stream)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static void test_dai_shutdown(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+}
+
+static int test_dai_hw_params(struct snd_pcm_substream *substream,
+                             struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_hw_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_trigger(struct snd_pcm_substream *substream, int cmd, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static int test_dai_bespoke_trigger(struct snd_pcm_substream *substream,
+                                   int cmd, struct snd_soc_dai *dai)
+{
+       mile_stone(dai);
+
+       return 0;
+}
+
+static u64 test_dai_formats =
+       /*
+        * Select below from Sound Card, not auto
+        *      SND_SOC_POSSIBLE_DAIFMT_CBP_CFP
+        *      SND_SOC_POSSIBLE_DAIFMT_CBC_CFP
+        *      SND_SOC_POSSIBLE_DAIFMT_CBP_CFC
+        *      SND_SOC_POSSIBLE_DAIFMT_CBC_CFC
+        */
+       SND_SOC_POSSIBLE_DAIFMT_I2S     |
+       SND_SOC_POSSIBLE_DAIFMT_RIGHT_J |
+       SND_SOC_POSSIBLE_DAIFMT_LEFT_J  |
+       SND_SOC_POSSIBLE_DAIFMT_DSP_A   |
+       SND_SOC_POSSIBLE_DAIFMT_DSP_B   |
+       SND_SOC_POSSIBLE_DAIFMT_AC97    |
+       SND_SOC_POSSIBLE_DAIFMT_PDM     |
+       SND_SOC_POSSIBLE_DAIFMT_NB_NF   |
+       SND_SOC_POSSIBLE_DAIFMT_NB_IF   |
+       SND_SOC_POSSIBLE_DAIFMT_IB_NF   |
+       SND_SOC_POSSIBLE_DAIFMT_IB_IF;
+
+static const struct snd_soc_dai_ops test_ops = {
+       .set_fmt                = test_dai_set_fmt,
+       .startup                = test_dai_startup,
+       .shutdown               = test_dai_shutdown,
+       .auto_selectable_formats        = &test_dai_formats,
+       .num_auto_selectable_formats    = 1,
+};
+
+static const struct snd_soc_dai_ops test_verbose_ops = {
+       .set_sysclk             = test_dai_set_sysclk,
+       .set_pll                = test_dai_set_pll,
+       .set_clkdiv             = test_dai_set_clkdiv,
+       .set_fmt                = test_dai_set_fmt,
+       .mute_stream            = test_dai_mute_stream,
+       .startup                = test_dai_startup,
+       .shutdown               = test_dai_shutdown,
+       .hw_params              = test_dai_hw_params,
+       .hw_free                = test_dai_hw_free,
+       .trigger                = test_dai_trigger,
+       .bespoke_trigger        = test_dai_bespoke_trigger,
+       .auto_selectable_formats        = &test_dai_formats,
+       .num_auto_selectable_formats    = 1,
+};
+
+#define STUB_RATES     SNDRV_PCM_RATE_8000_384000
+#define STUB_FORMATS   (SNDRV_PCM_FMTBIT_S8            | \
+                        SNDRV_PCM_FMTBIT_U8            | \
+                        SNDRV_PCM_FMTBIT_S16_LE        | \
+                        SNDRV_PCM_FMTBIT_U16_LE        | \
+                        SNDRV_PCM_FMTBIT_S24_LE        | \
+                        SNDRV_PCM_FMTBIT_S24_3LE       | \
+                        SNDRV_PCM_FMTBIT_U24_LE        | \
+                        SNDRV_PCM_FMTBIT_S32_LE        | \
+                        SNDRV_PCM_FMTBIT_U32_LE)
+
+static int test_component_probe(struct snd_soc_component *component)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static void test_component_remove(struct snd_soc_component *component)
+{
+       mile_stone(component);
+}
+
+static int test_component_suspend(struct snd_soc_component *component)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_resume(struct snd_soc_component *component)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+#define PREALLOC_BUFFER                (32 * 1024)
+static int test_component_pcm_construct(struct snd_soc_component *component,
+                                       struct snd_soc_pcm_runtime *rtd)
+{
+       mile_stone(component);
+
+       snd_pcm_set_managed_buffer_all(
+               rtd->pcm,
+               SNDRV_DMA_TYPE_DEV,
+               rtd->card->snd_card->dev,
+               PREALLOC_BUFFER, PREALLOC_BUFFER);
+
+       return 0;
+}
+
+static void test_component_pcm_destruct(struct snd_soc_component *component,
+                                       struct snd_pcm *pcm)
+{
+       mile_stone(component);
+}
+
+static int test_component_set_sysclk(struct snd_soc_component *component,
+                                    int clk_id, int source, unsigned int freq, int dir)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_set_pll(struct snd_soc_component *component, int pll_id,
+                                 int source, unsigned int freq_in, unsigned int freq_out)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_set_jack(struct snd_soc_component *component,
+                                  struct snd_soc_jack *jack,  void *data)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static void test_component_seq_notifier(struct snd_soc_component *component,
+                                       enum snd_soc_dapm_type type, int subseq)
+{
+       mile_stone(component);
+}
+
+static int test_component_stream_event(struct snd_soc_component *component, int event)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_set_bias_level(struct snd_soc_component *component,
+                                        enum snd_soc_bias_level level)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static const struct snd_pcm_hardware test_component_hardware = {
+       /* Random values to keep userspace happy when checking constraints */
+       .info                   = SNDRV_PCM_INFO_INTERLEAVED    |
+                                 SNDRV_PCM_INFO_MMAP           |
+                                 SNDRV_PCM_INFO_MMAP_VALID,
+       .buffer_bytes_max       = 32 * 1024,
+       .period_bytes_min       = 32,
+       .period_bytes_max       = 8192,
+       .periods_min            = 1,
+       .periods_max            = 128,
+       .fifo_size              = 256,
+};
+
+static int test_component_open(struct snd_soc_component *component,
+                              struct snd_pcm_substream *substream)
+{
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+
+       mile_stone(component);
+
+       /* BE's dont need dummy params */
+       if (!rtd->dai_link->no_pcm)
+               snd_soc_set_runtime_hwparams(substream, &test_component_hardware);
+
+       return 0;
+}
+
+static int test_component_close(struct snd_soc_component *component,
+                               struct snd_pcm_substream *substream)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_ioctl(struct snd_soc_component *component,
+                               struct snd_pcm_substream *substream,
+                               unsigned int cmd, void *arg)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_hw_params(struct snd_soc_component *component,
+                                   struct snd_pcm_substream *substream,
+                                   struct snd_pcm_hw_params *params)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_hw_free(struct snd_soc_component *component,
+                                 struct snd_pcm_substream *substream)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_prepare(struct snd_soc_component *component,
+                                 struct snd_pcm_substream *substream)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static void test_component_timer_stop(struct test_priv *priv)
+{
+       cancel_delayed_work(&priv->dwork);
+}
+
+static void test_component_timer_start(struct test_priv *priv)
+{
+       schedule_delayed_work(&priv->dwork, msecs_to_jiffies(10));
+}
+
+static void test_component_dwork(struct work_struct *work)
+{
+       struct test_priv *priv = container_of(work, struct test_priv, dwork.work);
+
+       if (priv->substream)
+               snd_pcm_period_elapsed(priv->substream);
+
+       test_component_timer_start(priv);
+}
+
+static int test_component_trigger(struct snd_soc_component *component,
+                                 struct snd_pcm_substream *substream, int cmd)
+{
+       struct test_priv *priv = dev_get_drvdata(component->dev);
+
+       mile_stone(component);
+
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+               test_component_timer_start(priv);
+               priv->substream = substream; /* set substream later */
+               break;
+       case SNDRV_PCM_TRIGGER_STOP:
+               priv->substream = NULL;
+               test_component_timer_stop(priv);
+       }
+
+       return 0;
+}
+
+static int test_component_sync_stop(struct snd_soc_component *component,
+                                   struct snd_pcm_substream *substream)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static snd_pcm_uframes_t test_component_pointer(struct snd_soc_component *component,
+                                               struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       static int pointer;
+
+       if (!runtime)
+               return 0;
+
+       pointer += 10;
+       if (pointer > PREALLOC_BUFFER)
+               pointer = 0;
+
+       /* mile_stone(component); */
+
+       return bytes_to_frames(runtime, pointer);
+}
+
+static int test_component_get_time_info(struct snd_soc_component *component,
+                                       struct snd_pcm_substream *substream,
+                                       struct timespec64 *system_ts,
+                                       struct timespec64 *audio_ts,
+                                       struct snd_pcm_audio_tstamp_config *audio_tstamp_config,
+                                       struct snd_pcm_audio_tstamp_report *audio_tstamp_report)
+{
+       mile_stone(component);
+
+       return 0;
+}
+
+static int test_component_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
+                                            struct snd_pcm_hw_params *params)
+{
+       mile_stone_x(rtd->dev);
+
+       return 0;
+}
+
+/* CPU */
+static const struct test_adata test_cpu                = { .is_cpu = 1, .cmp_v = 0, .dai_v = 0, };
+static const struct test_adata test_cpu_vv     = { .is_cpu = 1, .cmp_v = 1, .dai_v = 1, };
+static const struct test_adata test_cpu_nv     = { .is_cpu = 1, .cmp_v = 0, .dai_v = 1, };
+static const struct test_adata test_cpu_vn     = { .is_cpu = 1, .cmp_v = 1, .dai_v = 0, };
+/* Codec */
+static const struct test_adata test_codec      = { .is_cpu = 0, .cmp_v = 0, .dai_v = 0, };
+static const struct test_adata test_codec_vv   = { .is_cpu = 0, .cmp_v = 1, .dai_v = 1, };
+static const struct test_adata test_codec_nv   = { .is_cpu = 0, .cmp_v = 0, .dai_v = 1, };
+static const struct test_adata test_codec_vn   = { .is_cpu = 0, .cmp_v = 1, .dai_v = 0, };
+
+static const struct of_device_id test_of_match[] = {
+       { .compatible = "test-cpu",                     .data = (void *)&test_cpu,    },
+       { .compatible = "test-cpu-verbose",             .data = (void *)&test_cpu_vv, },
+       { .compatible = "test-cpu-verbose-dai",         .data = (void *)&test_cpu_nv, },
+       { .compatible = "test-cpu-verbose-component",   .data = (void *)&test_cpu_vn, },
+       { .compatible = "test-codec",                   .data = (void *)&test_codec,    },
+       { .compatible = "test-codec-verbose",           .data = (void *)&test_codec_vv, },
+       { .compatible = "test-codec-verbose-dai",       .data = (void *)&test_codec_nv, },
+       { .compatible = "test-codec-verbose-component", .data = (void *)&test_codec_vn, },
+       {},
+};
+MODULE_DEVICE_TABLE(of, test_of_match);
+
+static const struct snd_soc_dapm_widget widgets[] = {
+       /*
+        * FIXME
+        *
+        * Just IN/OUT is OK for now,
+        * but need to be updated ?
+        */
+       SND_SOC_DAPM_INPUT("IN"),
+       SND_SOC_DAPM_OUTPUT("OUT"),
+};
+
+static int test_driver_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct device_node *node = dev->of_node;
+       struct device_node *ep;
+       const struct of_device_id *of_id = of_match_device(test_of_match, &pdev->dev);
+       const struct test_adata *adata = of_id->data;
+       struct snd_soc_component_driver *cdriv;
+       struct snd_soc_dai_driver *ddriv;
+       struct test_dai_name *dname;
+       struct test_priv *priv;
+       int num, ret, i;
+
+       num = of_graph_get_endpoint_count(node);
+       if (!num) {
+               dev_err(dev, "no port exits\n");
+               return -EINVAL;
+       }
+
+       priv    = devm_kzalloc(dev, sizeof(*priv),              GFP_KERNEL);
+       cdriv   = devm_kzalloc(dev, sizeof(*cdriv),             GFP_KERNEL);
+       ddriv   = devm_kzalloc(dev, sizeof(*ddriv) * num,       GFP_KERNEL);
+       dname   = devm_kzalloc(dev, sizeof(*dname) * num,       GFP_KERNEL);
+       if (!priv || !cdriv || !ddriv || !dname)
+               return -EINVAL;
+
+       priv->dev               = dev;
+       priv->component_driver  = cdriv;
+       priv->dai_driver        = ddriv;
+       priv->name              = dname;
+
+       INIT_DELAYED_WORK(&priv->dwork, test_component_dwork);
+       dev_set_drvdata(dev, priv);
+
+       if (adata->is_cpu) {
+               cdriv->name                     = "test_cpu";
+               cdriv->pcm_construct            = test_component_pcm_construct;
+               cdriv->pointer                  = test_component_pointer;
+               cdriv->trigger                  = test_component_trigger;
+       } else {
+               cdriv->name                     = "test_codec";
+               cdriv->idle_bias_on             = 1;
+               cdriv->endianness               = 1;
+               cdriv->non_legacy_dai_naming    = 1;
+       }
+
+       cdriv->open             = test_component_open;
+       cdriv->dapm_widgets     = widgets;
+       cdriv->num_dapm_widgets = ARRAY_SIZE(widgets);
+
+       if (adata->cmp_v) {
+               cdriv->probe                    = test_component_probe;
+               cdriv->remove                   = test_component_remove;
+               cdriv->suspend                  = test_component_suspend;
+               cdriv->resume                   = test_component_resume;
+               cdriv->set_sysclk               = test_component_set_sysclk;
+               cdriv->set_pll                  = test_component_set_pll;
+               cdriv->set_jack                 = test_component_set_jack;
+               cdriv->seq_notifier             = test_component_seq_notifier;
+               cdriv->stream_event             = test_component_stream_event;
+               cdriv->set_bias_level           = test_component_set_bias_level;
+               cdriv->close                    = test_component_close;
+               cdriv->ioctl                    = test_component_ioctl;
+               cdriv->hw_params                = test_component_hw_params;
+               cdriv->hw_free                  = test_component_hw_free;
+               cdriv->prepare                  = test_component_prepare;
+               cdriv->sync_stop                = test_component_sync_stop;
+               cdriv->get_time_info            = test_component_get_time_info;
+               cdriv->be_hw_params_fixup       = test_component_be_hw_params_fixup;
+
+               if (adata->is_cpu)
+                       cdriv->pcm_destruct     = test_component_pcm_destruct;
+       }
+
+       i = 0;
+       for_each_endpoint_of_node(node, ep) {
+               snprintf(dname[i].name, TEST_NAME_LEN, "%s.%d", node->name, i);
+               ddriv[i].name = dname[i].name;
+
+               snprintf(dname[i].name_playback, TEST_NAME_LEN, "DAI%d Playback", i);
+               ddriv[i].playback.stream_name   = dname[i].name_playback;
+               ddriv[i].playback.channels_min  = 1;
+               ddriv[i].playback.channels_max  = 384;
+               ddriv[i].playback.rates         = STUB_RATES;
+               ddriv[i].playback.formats       = STUB_FORMATS;
+
+               snprintf(dname[i].name_capture, TEST_NAME_LEN, "DAI%d Capture", i);
+               ddriv[i].capture.stream_name    = dname[i].name_capture;
+               ddriv[i].capture.channels_min   = 1;
+               ddriv[i].capture.channels_max   = 384;
+               ddriv[i].capture.rates          = STUB_RATES;
+               ddriv[i].capture.formats        = STUB_FORMATS;
+
+               if (adata->dai_v)
+                       ddriv[i].ops = &test_verbose_ops;
+               else
+                       ddriv[i].ops = &test_ops;
+
+               i++;
+       }
+
+       ret = devm_snd_soc_register_component(dev, cdriv, ddriv, num);
+       if (ret < 0)
+               return ret;
+
+       mile_stone_x(dev);
+
+       return 0;
+}
+
+static int test_driver_remove(struct platform_device *pdev)
+{
+       mile_stone_x(&pdev->dev);
+
+       return 0;
+}
+
+static struct platform_driver test_driver = {
+       .driver = {
+               .name = "test-component",
+               .of_match_table = test_of_match,
+       },
+       .probe  = test_driver_probe,
+       .remove = test_driver_remove,
+};
+module_platform_driver(test_driver);
+
+MODULE_ALIAS("platform:asoc-test-component");
+MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
+MODULE_DESCRIPTION("ASoC Test Component");
+MODULE_LICENSE("GPL v2");
index 61b71d6..2dd5ff7 100644 (file)
@@ -371,7 +371,7 @@ config SND_SOC_INTEL_KBL_RT5663_RT5514_MAX98927_MACH
 
 config SND_SOC_INTEL_KBL_DA7219_MAX98357A_MACH
        tristate "KBL with DA7219 and MAX98357A in I2S Mode"
-       depends on I2C && ACPI
+       depends on I2C && ACPI && GPIOLIB
        depends on MFD_INTEL_LPSS || COMPILE_TEST
        select SND_SOC_INTEL_DA7219_MAX98357A_GENERIC
        help
@@ -427,6 +427,7 @@ config SND_SOC_INTEL_GLK_RT5682_MAX98357A_MACH
        depends on MFD_INTEL_LPSS || COMPILE_TEST
        depends on SND_HDA_CODEC_HDMI && SND_SOC_SOF_HDA_AUDIO_CODEC
        select SND_SOC_RT5682_I2C
+       select SND_SOC_RT5682S
        select SND_SOC_MAX98357A
        select SND_SOC_DMIC
        select SND_SOC_HDAC_HDMI
@@ -470,6 +471,7 @@ config SND_SOC_INTEL_SOF_RT5682_MACH
        select SND_SOC_RT1015
        select SND_SOC_RT1015P
        select SND_SOC_RT5682_I2C
+       select SND_SOC_RT5682S
        select SND_SOC_DMIC
        select SND_SOC_HDAC_HDMI
        select SND_SOC_INTEL_HDA_DSP_COMMON
@@ -511,6 +513,20 @@ config SND_SOC_INTEL_SOF_PCM512x_MACH
          Say Y or m if you have such a device.
          If unsure select "N".
 
+config SND_SOC_INTEL_SOF_ES8336_MACH
+       tristate "SOF with ES8336 codec in I2S mode"
+       depends on I2C && ACPI && GPIOLIB
+       depends on MFD_INTEL_LPSS || COMPILE_TEST
+       depends on SND_HDA_CODEC_HDMI && SND_SOC_SOF_HDA_AUDIO_CODEC
+       select SND_SOC_ES8316
+       select SND_SOC_DMIC
+       select SND_SOC_INTEL_HDA_DSP_COMMON
+       help
+          This adds support for ASoC machine driver for SOF platforms
+          with es8336 codec.
+          Say Y if you have such a device.
+          If unsure select "N".
+
 endif ## SND_SOC_SOF_HDA_LINK || SND_SOC_SOF_BAYTRAIL
 
 if (SND_SOC_SOF_COMETLAKE && SND_SOC_SOF_HDA_LINK)
index ed21b82..9ee8ed8 100644 (file)
@@ -21,6 +21,7 @@ snd-soc-sst-byt-cht-es8316-objs := bytcht_es8316.o
 snd-soc-sst-byt-cht-nocodec-objs := bytcht_nocodec.o
 snd-soc-sof_rt5682-objs := sof_rt5682.o sof_realtek_common.o
 snd-soc-sof_cs42l42-objs := sof_cs42l42.o
+snd-soc-sof_es8336-objs := sof_es8336.o
 snd-soc-cml_rt1011_rt5682-objs := cml_rt1011_rt5682.o
 snd-soc-kbl_da7219_max98357a-objs := kbl_da7219_max98357a.o
 snd-soc-kbl_da7219_max98927-objs := kbl_da7219_max98927.o
@@ -42,6 +43,7 @@ snd-soc-sof-sdw-objs += sof_sdw.o                             \
                        sof_sdw_dmic.o sof_sdw_hdmi.o
 obj-$(CONFIG_SND_SOC_INTEL_SOF_RT5682_MACH) += snd-soc-sof_rt5682.o
 obj-$(CONFIG_SND_SOC_INTEL_SOF_CS42L42_MACH) += snd-soc-sof_cs42l42.o
+obj-$(CONFIG_SND_SOC_INTEL_SOF_ES8336_MACH) += snd-soc-sof_es8336.o
 obj-$(CONFIG_SND_SOC_INTEL_HASWELL_MACH) += snd-soc-sst-haswell.o
 obj-$(CONFIG_SND_SOC_INTEL_BXT_DA7219_MAX98357A_COMMON) += snd-soc-sst-bxt-da7219_max98357a.o
 obj-$(CONFIG_SND_SOC_INTEL_BXT_RT298_MACH) += snd-soc-sst-bxt-rt298.o
index c5122d3..6cba555 100644 (file)
@@ -251,7 +251,7 @@ static struct snd_soc_dai_link bdw_rt5650_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broadwell_ssp0_fixup,
                .ops = &bdw_rt5650_ops,
index e01b7a9..119c441 100644 (file)
@@ -351,7 +351,7 @@ static struct snd_soc_dai_link bdw_rt5677_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broadwell_ssp0_fixup,
                .ops = &bdw_rt5677_ops,
index 3c3aff9..618d064 100644 (file)
@@ -217,7 +217,7 @@ static struct snd_soc_dai_link broadwell_rt286_dais[] = {
                .no_pcm = 1,
                .init = broadwell_rt286_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broadwell_ssp0_fixup,
                .ops = &broadwell_rt286_ops,
index e67ddfb..b768d9b 100644 (file)
@@ -572,7 +572,7 @@ static struct snd_soc_dai_link broxton_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broxton_ssp_fixup,
                .dpcm_playback = 1,
@@ -585,7 +585,7 @@ static struct snd_soc_dai_link broxton_dais[] = {
                .no_pcm = 1,
                .init = broxton_da7219_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broxton_ssp_fixup,
                .dpcm_playback = 1,
index 47f6b15..920e575 100644 (file)
@@ -468,7 +468,7 @@ static struct snd_soc_dai_link broxton_rt298_dais[] = {
                .no_pcm = 1,
                .init = broxton_rt298_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_DSP_A | SND_SOC_DAIFMT_NB_NF |
-                                               SND_SOC_DAIFMT_CBS_CFS,
+                                               SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = broxton_ssp5_fixup,
                .ops = &broxton_rt298_ops,
index a9e51bb..0a73630 100644 (file)
@@ -126,7 +126,7 @@ static int byt_cht_cx2072x_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                SND_SOC_DAIFMT_I2S     |
                                SND_SOC_DAIFMT_NB_NF   |
-                               SND_SOC_DAIFMT_CBS_CFS);
+                               SND_SOC_DAIFMT_CBC_CFC);
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
                return ret;
@@ -195,7 +195,7 @@ static struct snd_soc_dai_link byt_cht_cx2072x_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                             | SND_SOC_DAIFMT_CBS_CFS,
+                                             | SND_SOC_DAIFMT_CBC_CFC,
                .init = byt_cht_cx2072x_init,
                .be_hw_params_fixup = byt_cht_cx2072x_fixup,
                .dpcm_playback = 1,
index a28773f..fae1e7e 100644 (file)
@@ -81,7 +81,7 @@ static int codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS);
+                                 SND_SOC_DAIFMT_CBC_CFC);
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
                return ret;
@@ -195,7 +195,7 @@ static struct snd_soc_dai_link dailink[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = codec_fixup,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
index 4d313d0..9d86fea 100644 (file)
@@ -265,7 +265,7 @@ static int byt_cht_es8316_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                SND_SOC_DAIFMT_I2S     |
                                SND_SOC_DAIFMT_NB_NF   |
-                               SND_SOC_DAIFMT_CBS_CFS
+                               SND_SOC_DAIFMT_CBC_CFC
                );
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
@@ -336,7 +336,7 @@ static struct snd_soc_dai_link byt_cht_es8316_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = byt_cht_es8316_codec_fixup,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
index 9b48fe7..67b3c4e 100644 (file)
@@ -61,7 +61,7 @@ static int codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS);
+                                 SND_SOC_DAIFMT_CBC_CFC);
 
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
@@ -141,7 +141,7 @@ static struct snd_soc_dai_link dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = codec_fixup,
                .ignore_suspend = 1,
                .dpcm_playback = 1,
index a6e8372..a0c5f0e 100644 (file)
@@ -269,13 +269,10 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
                return -EIO;
 
        if (SND_SOC_DAPM_EVENT_ON(event)) {
-               if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) {
-                       ret = clk_prepare_enable(priv->mclk);
-                       if (ret < 0) {
-                               dev_err(card->dev,
-                                       "could not configure MCLK state\n");
-                               return ret;
-                       }
+               ret = clk_prepare_enable(priv->mclk);
+               if (ret < 0) {
+                       dev_err(card->dev, "could not configure MCLK state\n");
+                       return ret;
                }
                ret = byt_rt5640_prepare_and_enable_pll1(codec_dai, 48000);
        } else {
@@ -287,10 +284,8 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
                ret = snd_soc_dai_set_sysclk(codec_dai, RT5640_SCLK_S_RCCLK,
                                             48000 * 512,
                                             SND_SOC_CLOCK_IN);
-               if (!ret) {
-                       if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN)
-                               clk_disable_unprepare(priv->mclk);
-               }
+               if (!ret)
+                       clk_disable_unprepare(priv->mclk);
        }
 
        if (ret < 0) {
@@ -1217,30 +1212,25 @@ static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime)
                        return ret;
        }
 
-       if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) {
-               /*
-                * The firmware might enable the clock at
-                * boot (this information may or may not
-                * be reflected in the enable clock register).
-                * To change the rate we must disable the clock
-                * first to cover these cases. Due to common
-                * clock framework restrictions that do not allow
-                * to disable a clock that has not been enabled,
-                * we need to enable the clock first.
-                */
-               ret = clk_prepare_enable(priv->mclk);
-               if (!ret)
-                       clk_disable_unprepare(priv->mclk);
-
-               if (byt_rt5640_quirk & BYT_RT5640_MCLK_25MHZ)
-                       ret = clk_set_rate(priv->mclk, 25000000);
-               else
-                       ret = clk_set_rate(priv->mclk, 19200000);
+       /*
+        * The firmware might enable the clock at boot (this information
+        * may or may not be reflected in the enable clock register).
+        * To change the rate we must disable the clock first to cover
+        * these cases. Due to common clock framework restrictions that
+        * do not allow to disable a clock that has not been enabled,
+        * we need to enable the clock first.
+        */
+       ret = clk_prepare_enable(priv->mclk);
+       if (!ret)
+               clk_disable_unprepare(priv->mclk);
 
-               if (ret) {
-                       dev_err(card->dev, "unable to set MCLK rate\n");
-                       return ret;
-               }
+       if (byt_rt5640_quirk & BYT_RT5640_MCLK_25MHZ)
+               ret = clk_set_rate(priv->mclk, 25000000);
+       else
+               ret = clk_set_rate(priv->mclk, 19200000);
+       if (ret) {
+               dev_err(card->dev, "unable to set MCLK rate\n");
+               return ret;
        }
 
        if (BYT_RT5640_JDSRC(byt_rt5640_quirk)) {
@@ -1336,7 +1326,7 @@ static int byt_rt5640_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS);
+                                 SND_SOC_DAIFMT_CBC_CFC);
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
                return ret;
@@ -1411,7 +1401,7 @@ static struct snd_soc_dai_link byt_rt5640_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = byt_rt5640_codec_fixup,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
@@ -1495,12 +1485,12 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
        static const char * const map_name[] = { "dmic1", "dmic2", "in1", "in3", "none" };
+       struct snd_soc_acpi_mach *mach = dev_get_platdata(dev);
        __maybe_unused const char *spk_type;
        const struct dmi_system_id *dmi_id;
        const char *headset2_string = "";
        const char *lineout_string = "";
        struct byt_rt5640_private *priv;
-       struct snd_soc_acpi_mach *mach;
        const char *platform_name;
        struct acpi_device *adev;
        struct device *codec_dev;
@@ -1511,13 +1501,12 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        int aif;
 
        is_bytcr = false;
-       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
        /* register the soc card */
-       byt_rt5640_card.dev = &pdev->dev;
-       mach = byt_rt5640_card.dev->platform_data;
+       byt_rt5640_card.dev = dev;
        snd_soc_card_set_drvdata(&byt_rt5640_card, priv);
 
        /* fix index of codec dai */
@@ -1537,7 +1526,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
                put_device(&adev->dev);
                byt_rt5640_dais[dai_index].codecs->name = byt_rt5640_codec_name;
        } else {
-               dev_err(&pdev->dev, "Error cannot find '%s' dev\n", mach->id);
+               dev_err(dev, "Error cannot find '%s' dev\n", mach->id);
                return -ENXIO;
        }
 
@@ -1580,13 +1569,13 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
                                                               &pkg_ctx);
                if (pkg_found) {
                        if (chan_package.aif_value == 1) {
-                               dev_info(&pdev->dev, "BIOS Routing: AIF1 connected\n");
+                               dev_info(dev, "BIOS Routing: AIF1 connected\n");
                                byt_rt5640_quirk |= BYT_RT5640_SSP0_AIF1;
                        } else  if (chan_package.aif_value == 2) {
-                               dev_info(&pdev->dev, "BIOS Routing: AIF2 connected\n");
+                               dev_info(dev, "BIOS Routing: AIF2 connected\n");
                                byt_rt5640_quirk |= BYT_RT5640_SSP0_AIF2;
                        } else {
-                               dev_info(&pdev->dev, "BIOS Routing isn't valid, ignored\n");
+                               dev_info(dev, "BIOS Routing isn't valid, ignored\n");
                                pkg_found = false;
                        }
                }
@@ -1610,7 +1599,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        if (dmi_id)
                byt_rt5640_quirk = (unsigned long)dmi_id->driver_data;
        if (quirk_override != -1) {
-               dev_info(&pdev->dev, "Overriding quirk 0x%lx => 0x%x\n",
+               dev_info(dev, "Overriding quirk 0x%lx => 0x%x\n",
                         byt_rt5640_quirk, quirk_override);
                byt_rt5640_quirk = quirk_override;
        }
@@ -1624,12 +1613,12 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
                acpi_dev_add_driver_gpios(ACPI_COMPANION(priv->codec_dev),
                                          byt_rt5640_hp_elitepad_1000g2_gpios);
 
-               priv->hsmic_detect = devm_fwnode_gpiod_get(&pdev->dev, codec_dev->fwnode,
+               priv->hsmic_detect = devm_fwnode_gpiod_get(dev, codec_dev->fwnode,
                                                           "headset-mic-detect", GPIOD_IN,
                                                           "headset-mic-detect");
                if (IS_ERR(priv->hsmic_detect)) {
-                       ret_val = PTR_ERR(priv->hsmic_detect);
-                       dev_err_probe(&pdev->dev, ret_val, "getting hsmic-detect GPIO\n");
+                       ret_val = dev_err_probe(dev, PTR_ERR(priv->hsmic_detect),
+                                               "getting hsmic-detect GPIO\n");
                        goto err_device;
                }
        }
@@ -1639,7 +1628,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        if (ret_val)
                goto err_remove_gpios;
 
-       log_quirks(&pdev->dev);
+       log_quirks(dev);
 
        if ((byt_rt5640_quirk & BYT_RT5640_SSP2_AIF2) ||
            (byt_rt5640_quirk & BYT_RT5640_SSP0_AIF2)) {
@@ -1654,23 +1643,18 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
                byt_rt5640_dais[dai_index].cpus->dai_name = "ssp0-port";
 
        if (byt_rt5640_quirk & BYT_RT5640_MCLK_EN) {
-               priv->mclk = devm_clk_get(&pdev->dev, "pmc_plt_clk_3");
+               priv->mclk = devm_clk_get_optional(dev, "pmc_plt_clk_3");
                if (IS_ERR(priv->mclk)) {
-                       ret_val = PTR_ERR(priv->mclk);
-
-                       dev_err(&pdev->dev,
-                               "Failed to get MCLK from pmc_plt_clk_3: %d\n",
-                               ret_val);
-
-                       /*
-                        * Fall back to bit clock usage for -ENOENT (clock not
-                        * available likely due to missing dependencies), bail
-                        * for all other errors, including -EPROBE_DEFER
-                        */
-                       if (ret_val != -ENOENT)
-                               goto err;
-                       byt_rt5640_quirk &= ~BYT_RT5640_MCLK_EN;
+                       ret_val = dev_err_probe(dev, PTR_ERR(priv->mclk),
+                                               "Failed to get MCLK from pmc_plt_clk_3\n");
+                       goto err;
                }
+               /*
+                * Fall back to bit clock usage when clock is not
+                * available likely due to missing dependencies.
+                */
+               if (!priv->mclk)
+                       byt_rt5640_quirk &= ~BYT_RT5640_MCLK_EN;
        }
 
        if (byt_rt5640_quirk & BYT_RT5640_NO_SPEAKERS) {
@@ -1714,7 +1698,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        if (ret_val)
                goto err;
 
-       sof_parent = snd_soc_acpi_sof_parent(&pdev->dev);
+       sof_parent = snd_soc_acpi_sof_parent(dev);
 
        /* set card and driver name */
        if (sof_parent) {
@@ -1729,11 +1713,9 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev)
        if (sof_parent)
                dev->driver->pm = &snd_soc_pm_ops;
 
-       ret_val = devm_snd_soc_register_card(&pdev->dev, &byt_rt5640_card);
-
+       ret_val = devm_snd_soc_register_card(dev, &byt_rt5640_card);
        if (ret_val) {
-               dev_err(&pdev->dev, "devm_snd_soc_register_card failed %d\n",
-                       ret_val);
+               dev_err(dev, "devm_snd_soc_register_card failed %d\n", ret_val);
                goto err;
        }
        platform_set_drvdata(pdev, &byt_rt5640_card);
index e94c912..5e9c53d 100644 (file)
@@ -188,13 +188,10 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
        }
 
        if (SND_SOC_DAPM_EVENT_ON(event)) {
-               if (byt_rt5651_quirk & BYT_RT5651_MCLK_EN) {
-                       ret = clk_prepare_enable(priv->mclk);
-                       if (ret < 0) {
-                               dev_err(card->dev,
-                                       "could not configure MCLK state");
-                               return ret;
-                       }
+               ret = clk_prepare_enable(priv->mclk);
+               if (ret < 0) {
+                       dev_err(card->dev, "could not configure MCLK state");
+                       return ret;
                }
                ret = byt_rt5651_prepare_and_enable_pll1(codec_dai, 48000, 50);
        } else {
@@ -207,8 +204,7 @@ static int platform_clock_control(struct snd_soc_dapm_widget *w,
                                             48000 * 512,
                                             SND_SOC_CLOCK_IN);
                if (!ret)
-                       if (byt_rt5651_quirk & BYT_RT5651_MCLK_EN)
-                               clk_disable_unprepare(priv->mclk);
+                       clk_disable_unprepare(priv->mclk);
        }
 
        if (ret < 0) {
@@ -629,29 +625,25 @@ static int byt_rt5651_init(struct snd_soc_pcm_runtime *runtime)
                return ret;
        }
 
-       if (byt_rt5651_quirk & BYT_RT5651_MCLK_EN) {
-               /*
-                * The firmware might enable the clock at
-                * boot (this information may or may not
-                * be reflected in the enable clock register).
-                * To change the rate we must disable the clock
-                * first to cover these cases. Due to common
-                * clock framework restrictions that do not allow
-                * to disable a clock that has not been enabled,
-                * we need to enable the clock first.
-                */
-               ret = clk_prepare_enable(priv->mclk);
-               if (!ret)
-                       clk_disable_unprepare(priv->mclk);
+       /*
+        * The firmware might enable the clock at boot (this information
+        * may or may not be reflected in the enable clock register).
+        * To change the rate we must disable the clock first to cover
+        * these cases. Due to common clock framework restrictions that
+        * do not allow to disable a clock that has not been enabled,
+        * we need to enable the clock first.
+        */
+       ret = clk_prepare_enable(priv->mclk);
+       if (!ret)
+               clk_disable_unprepare(priv->mclk);
 
-               if (byt_rt5651_quirk & BYT_RT5651_MCLK_25MHZ)
-                       ret = clk_set_rate(priv->mclk, 25000000);
-               else
-                       ret = clk_set_rate(priv->mclk, 19200000);
+       if (byt_rt5651_quirk & BYT_RT5651_MCLK_25MHZ)
+               ret = clk_set_rate(priv->mclk, 25000000);
+       else
+               ret = clk_set_rate(priv->mclk, 19200000);
 
-               if (ret)
-                       dev_err(card->dev, "unable to set MCLK rate\n");
-       }
+       if (ret)
+               dev_err(card->dev, "unable to set MCLK rate\n");
 
        report = 0;
        if (BYT_RT5651_JDSRC(byt_rt5651_quirk))
@@ -713,7 +705,7 @@ static int byt_rt5651_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS
+                                 SND_SOC_DAIFMT_CBC_CFC
                                  );
 
        if (ret < 0) {
@@ -798,7 +790,7 @@ static struct snd_soc_dai_link byt_rt5651_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = byt_rt5651_codec_fixup,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
@@ -894,9 +886,10 @@ struct acpi_chan_package {   /* ACPICA seems to require 64 bit integers */
 
 static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 {
+       struct device *dev = &pdev->dev;
        static const char * const mic_name[] = { "dmic", "in1", "in2", "in12" };
+       struct snd_soc_acpi_mach *mach = dev_get_platdata(dev);
        struct byt_rt5651_private *priv;
-       struct snd_soc_acpi_mach *mach;
        const char *platform_name;
        struct acpi_device *adev;
        struct device *codec_dev;
@@ -906,14 +899,12 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
        int dai_index = 0;
        int i;
 
-       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
        if (!priv)
                return -ENOMEM;
 
        /* register the soc card */
-       byt_rt5651_card.dev = &pdev->dev;
-
-       mach = byt_rt5651_card.dev->platform_data;
+       byt_rt5651_card.dev = dev;
        snd_soc_card_set_drvdata(&byt_rt5651_card, priv);
 
        /* fix index of codec dai */
@@ -933,7 +924,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                put_device(&adev->dev);
                byt_rt5651_dais[dai_index].codecs->name = byt_rt5651_codec_name;
        } else {
-               dev_err(&pdev->dev, "Error cannot find '%s' dev\n", mach->id);
+               dev_err(dev, "Error cannot find '%s' dev\n", mach->id);
                return -ENXIO;
        }
 
@@ -981,13 +972,13 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                                                               &pkg_ctx);
                if (pkg_found) {
                        if (chan_package.aif_value == 1) {
-                               dev_info(&pdev->dev, "BIOS Routing: AIF1 connected\n");
+                               dev_info(dev, "BIOS Routing: AIF1 connected\n");
                                byt_rt5651_quirk |= BYT_RT5651_SSP0_AIF1;
                        } else  if (chan_package.aif_value == 2) {
-                               dev_info(&pdev->dev, "BIOS Routing: AIF2 connected\n");
+                               dev_info(dev, "BIOS Routing: AIF2 connected\n");
                                byt_rt5651_quirk |= BYT_RT5651_SSP0_AIF2;
                        } else {
-                               dev_info(&pdev->dev, "BIOS Routing isn't valid, ignored\n");
+                               dev_info(dev, "BIOS Routing isn't valid, ignored\n");
                                pkg_found = false;
                        }
                }
@@ -1002,7 +993,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
        dmi_check_system(byt_rt5651_quirk_table);
 
        if (quirk_override != -1) {
-               dev_info(&pdev->dev, "Overriding quirk 0x%lx => 0x%x\n",
+               dev_info(dev, "Overriding quirk 0x%lx => 0x%x\n",
                         byt_rt5651_quirk, quirk_override);
                byt_rt5651_quirk = quirk_override;
        }
@@ -1018,8 +1009,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 
        if (byt_rt5651_gpios) {
                devm_acpi_dev_add_driver_gpios(codec_dev, byt_rt5651_gpios);
-               priv->ext_amp_gpio = devm_fwnode_gpiod_get(&pdev->dev,
-                                                          codec_dev->fwnode,
+               priv->ext_amp_gpio = devm_fwnode_gpiod_get(dev, codec_dev->fwnode,
                                                           "ext-amp-enable",
                                                           GPIOD_OUT_LOW,
                                                           "speaker-amp");
@@ -1030,15 +1020,13 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                                priv->ext_amp_gpio = NULL;
                                break;
                        default:
-                               dev_err(&pdev->dev, "Failed to get ext-amp-enable GPIO: %d\n",
-                                       ret_val);
+                               dev_err(dev, "Failed to get ext-amp-enable GPIO: %d\n", ret_val);
                                fallthrough;
                        case -EPROBE_DEFER:
                                goto err;
                        }
                }
-               priv->hp_detect = devm_fwnode_gpiod_get(&pdev->dev,
-                                                       codec_dev->fwnode,
+               priv->hp_detect = devm_fwnode_gpiod_get(dev, codec_dev->fwnode,
                                                        "hp-detect",
                                                        GPIOD_IN,
                                                        "hp-detect");
@@ -1049,8 +1037,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                                priv->hp_detect = NULL;
                                break;
                        default:
-                               dev_err(&pdev->dev, "Failed to get hp-detect GPIO: %d\n",
-                                       ret_val);
+                               dev_err(dev, "Failed to get hp-detect GPIO: %d\n", ret_val);
                                fallthrough;
                        case -EPROBE_DEFER:
                                goto err;
@@ -1058,7 +1045,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                }
        }
 
-       log_quirks(&pdev->dev);
+       log_quirks(dev);
 
        if ((byt_rt5651_quirk & BYT_RT5651_SSP2_AIF2) ||
            (byt_rt5651_quirk & BYT_RT5651_SSP0_AIF2))
@@ -1069,21 +1056,18 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
                byt_rt5651_dais[dai_index].cpus->dai_name = "ssp0-port";
 
        if (byt_rt5651_quirk & BYT_RT5651_MCLK_EN) {
-               priv->mclk = devm_clk_get(&pdev->dev, "pmc_plt_clk_3");
+               priv->mclk = devm_clk_get_optional(dev, "pmc_plt_clk_3");
                if (IS_ERR(priv->mclk)) {
-                       ret_val = PTR_ERR(priv->mclk);
-                       dev_err(&pdev->dev,
-                               "Failed to get MCLK from pmc_plt_clk_3: %d\n",
-                               ret_val);
-                       /*
-                        * Fall back to bit clock usage for -ENOENT (clock not
-                        * available likely due to missing dependencies), bail
-                        * for all other errors, including -EPROBE_DEFER
-                        */
-                       if (ret_val != -ENOENT)
-                               goto err;
-                       byt_rt5651_quirk &= ~BYT_RT5651_MCLK_EN;
+                       ret_val = dev_err_probe(dev, PTR_ERR(priv->mclk),
+                                               "Failed to get MCLK from pmc_plt_clk_3\n");
+                       goto err;
                }
+               /*
+                * Fall back to bit clock usage when clock is not
+                * available likely due to missing dependencies.
+                */
+               if (!priv->mclk)
+                       byt_rt5651_quirk &= ~BYT_RT5651_MCLK_EN;
        }
 
        snprintf(byt_rt5651_components, sizeof(byt_rt5651_components),
@@ -1112,7 +1096,7 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
        if (ret_val)
                goto err;
 
-       sof_parent = snd_soc_acpi_sof_parent(&pdev->dev);
+       sof_parent = snd_soc_acpi_sof_parent(dev);
 
        /* set card and driver name */
        if (sof_parent) {
@@ -1125,13 +1109,11 @@ static int snd_byt_rt5651_mc_probe(struct platform_device *pdev)
 
        /* set pm ops */
        if (sof_parent)
-               pdev->dev.driver->pm = &snd_soc_pm_ops;
-
-       ret_val = devm_snd_soc_register_card(&pdev->dev, &byt_rt5651_card);
+               dev->driver->pm = &snd_soc_pm_ops;
 
+       ret_val = devm_snd_soc_register_card(dev, &byt_rt5651_card);
        if (ret_val) {
-               dev_err(&pdev->dev, "devm_snd_soc_register_card failed %d\n",
-                       ret_val);
+               dev_err(dev, "devm_snd_soc_register_card failed %d\n", ret_val);
                goto err;
        }
        platform_set_drvdata(pdev, &byt_rt5651_card);
index 580d5fd..504ef4c 100644 (file)
@@ -265,7 +265,7 @@ static int byt_wm5102_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS);
+                                 SND_SOC_DAIFMT_CBC_CFC);
        if (ret) {
                dev_err(rtd->dev, "Error setting format to I2S: %d\n", ret);
                return ret;
@@ -349,7 +349,7 @@ static struct snd_soc_dai_link byt_wm5102_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                               | SND_SOC_DAIFMT_CBS_CFS,
+                                               | SND_SOC_DAIFMT_CBC_CFC,
                .be_hw_params_fixup = byt_wm5102_codec_fixup,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
index 1318823..1bc2143 100644 (file)
@@ -264,7 +264,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        }
 
        fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                               | SND_SOC_DAIFMT_CBS_CFS;
+                               | SND_SOC_DAIFMT_CBC_CFC;
 
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0), fmt);
        if (ret < 0) {
@@ -372,7 +372,7 @@ static struct snd_soc_dai_link cht_dailink[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF
-                                       | SND_SOC_DAIFMT_CBS_CFS,
+                                       | SND_SOC_DAIFMT_CBC_CFC,
                .init = cht_codec_init,
                .be_hw_params_fixup = cht_codec_fixup,
                .dpcm_playback = 1,
index da5a5cb..bad32d2 100644 (file)
@@ -214,7 +214,7 @@ static struct snd_soc_dai_link cht_dailink[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B | SND_SOC_DAIFMT_IB_NF
-                       | SND_SOC_DAIFMT_CBS_CFS,
+                       | SND_SOC_DAIFMT_CBC_CFC,
                .init = cht_codec_init,
                .be_hw_params_fixup = cht_codec_fixup,
                .dpcm_playback = 1,
@@ -278,6 +278,8 @@ static int snd_cht_mc_probe(struct platform_device *pdev)
                snd_soc_card_cht.driver_name = DRIVER_NAME;
        }
 
+       snd_soc_card_cht.components = nau8824_components();
+
        /* set pm ops */
        if (sof_parent)
                pdev->dev.driver->pm = &snd_soc_pm_ops;
index 804dbc7..e182012 100644 (file)
@@ -362,7 +362,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
                ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                        SND_SOC_DAIFMT_I2S     |
                                        SND_SOC_DAIFMT_NB_NF   |
-                                       SND_SOC_DAIFMT_CBS_CFS
+                                       SND_SOC_DAIFMT_CBC_CFC
                        );
                if (ret < 0) {
                        dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
@@ -372,7 +372,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
                ret = snd_soc_dai_set_fmt(asoc_rtd_to_codec(rtd, 0),
                                        SND_SOC_DAIFMT_I2S     |
                                        SND_SOC_DAIFMT_NB_NF   |
-                                       SND_SOC_DAIFMT_CBS_CFS
+                                       SND_SOC_DAIFMT_CBC_CFC
                        );
                if (ret < 0) {
                        dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
@@ -396,7 +396,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
                ret = snd_soc_dai_set_fmt(asoc_rtd_to_codec(rtd, 0),
                                        SND_SOC_DAIFMT_DSP_B |
                                        SND_SOC_DAIFMT_IB_NF |
-                                       SND_SOC_DAIFMT_CBS_CFS);
+                                       SND_SOC_DAIFMT_CBC_CFC);
                if (ret < 0) {
                        dev_err(rtd->dev, "can't set format to TDM %d\n", ret);
                        return ret;
index 9509b6e..26eb8ad 100644 (file)
@@ -300,7 +300,7 @@ static int cht_codec_fixup(struct snd_soc_pcm_runtime *rtd,
        ret = snd_soc_dai_set_fmt(asoc_rtd_to_cpu(rtd, 0),
                                  SND_SOC_DAIFMT_I2S     |
                                  SND_SOC_DAIFMT_NB_NF   |
-                                 SND_SOC_DAIFMT_CBS_CFS);
+                                 SND_SOC_DAIFMT_CBC_CFC);
        if (ret < 0) {
                dev_err(rtd->dev, "can't set format to I2S, err %d\n", ret);
                return ret;
index 71fe26a..bad3829 100644 (file)
 #include <sound/soc.h>
 #include <sound/soc-acpi.h>
 #include "../../codecs/rt5682.h"
+#include "../../codecs/rt5682s.h"
 #include "../../codecs/hdac_hdmi.h"
 #include "hda_dsp_common.h"
 
 /* The platform clock outputs 19.2Mhz clock to codec as I2S MCLK */
 #define GLK_PLAT_CLK_FREQ 19200000
 #define RT5682_PLL_FREQ (48000 * 512)
-#define GLK_REALTEK_CODEC_DAI "rt5682-aif1"
+#define RT5682_DAI_NAME "rt5682-aif1"
+#define RT5682S_DAI_NAME "rt5682s-aif1"
 #define GLK_MAXIM_CODEC_DAI "HiFi"
+#define RT5682_DEV0_NAME "i2c-10EC5682:00"
+#define RT5682S_DEV0_NAME "i2c-RTL5682:00"
 #define MAXIM_DEV0_NAME "MX98357A:00"
 #define DUAL_CHANNEL 2
 #define QUAD_CHANNEL 4
@@ -43,6 +47,7 @@ struct glk_card_private {
        struct snd_soc_jack geminilake_headset;
        struct list_head hdmi_pcm_list;
        bool common_hdmi_codec_drv;
+       int is_rt5682s;
 };
 
 enum {
@@ -139,9 +144,19 @@ static int geminilake_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
        struct snd_soc_component *component = asoc_rtd_to_codec(rtd, 0)->component;
        struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
        struct snd_soc_jack *jack;
-       int ret;
+       int pll_id, pll_source, clk_id, ret;
+
+       if (ctx->is_rt5682s) {
+               pll_id = RT5682S_PLL2;
+               pll_source = RT5682S_PLL_S_MCLK;
+               clk_id = RT5682S_SCLK_S_PLL2;
+       } else {
+               pll_id = RT5682_PLL1;
+               pll_source = RT5682_PLL1_S_MCLK;
+               clk_id = RT5682_SCLK_S_PLL1;
+       }
 
-       ret = snd_soc_dai_set_pll(codec_dai, 0, RT5682_PLL1_S_MCLK,
+       ret = snd_soc_dai_set_pll(codec_dai, pll_id, pll_source,
                                        GLK_PLAT_CLK_FREQ, RT5682_PLL_FREQ);
        if (ret < 0) {
                dev_err(rtd->dev, "can't set codec pll: %d\n", ret);
@@ -149,7 +164,7 @@ static int geminilake_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
        }
 
        /* Configure sysclk for codec */
-       ret = snd_soc_dai_set_sysclk(codec_dai, RT5682_SCLK_S_PLL1,
+       ret = snd_soc_dai_set_sysclk(codec_dai, clk_id,
                                        RT5682_PLL_FREQ, SND_SOC_CLOCK_IN);
        if (ret < 0)
                dev_err(rtd->dev, "snd_soc_dai_set_sysclk err = %d\n", ret);
@@ -344,9 +359,12 @@ SND_SOC_DAILINK_DEF(ssp1_codec,
 
 SND_SOC_DAILINK_DEF(ssp2_pin,
        DAILINK_COMP_ARRAY(COMP_CPU("SSP2 Pin")));
-SND_SOC_DAILINK_DEF(ssp2_codec,
-       DAILINK_COMP_ARRAY(COMP_CODEC("i2c-10EC5682:00",
-                                     GLK_REALTEK_CODEC_DAI)));
+SND_SOC_DAILINK_DEF(ssp2_codec_5682,
+       DAILINK_COMP_ARRAY(COMP_CODEC(RT5682_DEV0_NAME,
+                                     RT5682_DAI_NAME)));
+SND_SOC_DAILINK_DEF(ssp2_codec_5682s,
+       DAILINK_COMP_ARRAY(COMP_CODEC(RT5682S_DEV0_NAME,
+                                     RT5682S_DAI_NAME)));
 
 SND_SOC_DAILINK_DEF(dmic_pin,
        DAILINK_COMP_ARRAY(COMP_CPU("DMIC01 Pin")));
@@ -473,7 +491,7 @@ static struct snd_soc_dai_link geminilake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = geminilake_ssp_fixup,
                .dpcm_playback = 1,
@@ -486,13 +504,13 @@ static struct snd_soc_dai_link geminilake_dais[] = {
                .no_pcm = 1,
                .init = geminilake_rt5682_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = geminilake_ssp_fixup,
                .ops = &geminilake_rt5682_ops,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
-               SND_SOC_DAILINK_REG(ssp2_pin, ssp2_codec, platform),
+               SND_SOC_DAILINK_REG(ssp2_pin, ssp2_codec_5682, platform),
        },
        {
                .name = "dmic01",
@@ -592,12 +610,28 @@ static int geminilake_audio_probe(struct platform_device *pdev)
        struct snd_soc_acpi_mach *mach;
        const char *platform_name;
        struct snd_soc_card *card;
-       int ret;
+       int ret, i;
 
        ctx = devm_kzalloc(&pdev->dev, sizeof(*ctx), GFP_KERNEL);
        if (!ctx)
                return -ENOMEM;
 
+       /* Detect the headset codec variant */
+       if (acpi_dev_present("RTL5682", NULL, -1)) {
+               /* ALC5682I-VS is detected */
+               ctx->is_rt5682s = 1;
+
+               for (i = 0; i < glk_audio_card_rt5682_m98357a.num_links; i++) {
+                       if (strcmp(geminilake_dais[i].name, "SSP2-Codec"))
+                               continue;
+
+                       /* update the dai link to use rt5682s codec */
+                       geminilake_dais[i].codecs = ssp2_codec_5682s;
+                       geminilake_dais[i].num_codecs = ARRAY_SIZE(ssp2_codec_5682s);
+                       break;
+               }
+       }
+
        INIT_LIST_HEAD(&ctx->hdmi_pcm_list);
 
        card = &glk_audio_card_rt5682_m98357a;
index c763bfe..36e136a 100644 (file)
@@ -145,7 +145,7 @@ static struct snd_soc_dai_link haswell_rt5640_dais[] = {
                .id = 0,
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = haswell_ssp0_fixup,
                .ops = &haswell_rt5640_ops,
index 14b625e..a4bdf63 100644 (file)
@@ -518,7 +518,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .dpcm_playback = 1,
@@ -531,7 +531,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .init = kabylake_da7219_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .dpcm_playback = 1,
index 2b43459..620a9fb 100644 (file)
@@ -764,7 +764,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
                .ignore_pmdown_time = 1,
@@ -779,7 +779,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .init = kabylake_da7219_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .dpcm_playback = 1,
@@ -907,7 +907,7 @@ static struct snd_soc_dai_link kabylake_max98_927_373_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .dpcm_playback = 1,
                .dpcm_capture = 1,
                .ignore_pmdown_time = 1,
index 289ca39..1cb56ec 100644 (file)
@@ -436,7 +436,7 @@ static struct snd_soc_dai_link kabylake_rt5660_dais[] = {
                .exit = kabylake_rt5660_codec_exit,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                SND_SOC_DAIFMT_NB_NF |
-               SND_SOC_DAIFMT_CBS_CFS,
+               SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp0_fixup,
                .ops = &kabylake_rt5660_ops,
index a3e040a..f24e0ce 100644 (file)
@@ -767,7 +767,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .dpcm_playback = 1,
@@ -781,7 +781,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .init = kabylake_rt5663_max98927_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .ops = &kabylake_rt5663_ops,
@@ -879,7 +879,7 @@ static struct snd_soc_dai_link kabylake_5663_dais[] = {
                .no_pcm = 1,
                .init = kabylake_rt5663_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .ops = &kabylake_rt5663_ops,
index dd38fda..6874e98 100644 (file)
@@ -639,7 +639,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_B |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .dpcm_playback = 1,
@@ -653,7 +653,7 @@ static struct snd_soc_dai_link kabylake_dais[] = {
                .no_pcm = 1,
                .init = kabylake_rt5663_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = kabylake_ssp_fixup,
                .ops = &kabylake_rt5663_ops,
index e3a1f04..7297eb0 100644 (file)
@@ -539,7 +539,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = skylake_ssp_fixup,
                .dpcm_playback = 1,
@@ -552,7 +552,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
                .no_pcm = 1,
                .init = skylake_nau8825_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = skylake_ssp_fixup,
                .ops = &skylake_nau8825_ops,
index adf5992..68efde1 100644 (file)
@@ -578,7 +578,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
                .no_pcm = 1,
                .dai_fmt = SND_SOC_DAIFMT_DSP_A |
                        SND_SOC_DAIFMT_IB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .init = skylake_ssm4567_codec_init,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = skylake_ssp_fixup,
@@ -593,7 +593,7 @@ static struct snd_soc_dai_link skylake_dais[] = {
                .no_pcm = 1,
                .init = skylake_nau8825_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S | SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = skylake_ssp_fixup,
                .ops = &skylake_nau8825_ops,
index 75dab54..eca4a78 100644 (file)
@@ -434,7 +434,7 @@ static struct snd_soc_dai_link skylake_rt286_dais[] = {
                .init = skylake_rt286_codec_init,
                .dai_fmt = SND_SOC_DAIFMT_I2S |
                        SND_SOC_DAIFMT_NB_NF |
-                       SND_SOC_DAIFMT_CBS_CFS,
+                       SND_SOC_DAIFMT_CBC_CFC,
                .ignore_pmdown_time = 1,
                .be_hw_params_fixup = skylake_ssp0_fixup,
                .ops = &skylake_rt286_ops,
diff --git a/sound/soc/intel/boards/sof_es8336.c b/sound/soc/intel/boards/sof_es8336.c
new file mode 100644 (file)
index 0000000..20d577e
--- /dev/null
@@ -0,0 +1,569 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// Copyright(c) 2021 Intel Corporation.
+
+/*
+ * Intel SOF Machine Driver with es8336 Codec
+ */
+
+#include <linux/device.h>
+#include <linux/dmi.h>
+#include <linux/gpio/consumer.h>
+#include <linux/gpio/machine.h>
+#include <linux/i2c.h>
+#include <linux/input.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <sound/jack.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+#include <sound/soc-acpi.h>
+#include "hda_dsp_common.h"
+
+#define SOF_ES8336_SSP_CODEC(quirk)            ((quirk) & GENMASK(3, 0))
+#define SOF_ES8336_SSP_CODEC_MASK              (GENMASK(3, 0))
+
+#define SOF_ES8336_TGL_GPIO_QUIRK              BIT(4)
+#define SOF_ES8336_ENABLE_DMIC                 BIT(5)
+
+static unsigned long quirk;
+
+static int quirk_override = -1;
+module_param_named(quirk, quirk_override, int, 0444);
+MODULE_PARM_DESC(quirk, "Board-specific quirk override");
+
+struct sof_es8336_private {
+       struct device *codec_dev;
+       struct gpio_desc *gpio_pa;
+       struct snd_soc_jack jack;
+       struct list_head hdmi_pcm_list;
+       bool speaker_en;
+};
+
+struct sof_hdmi_pcm {
+       struct list_head head;
+       struct snd_soc_dai *codec_dai;
+       int device;
+};
+
+static const struct acpi_gpio_params pa_enable_gpio = { 0, 0, true };
+static const struct acpi_gpio_mapping acpi_es8336_gpios[] = {
+       { "pa-enable-gpios", &pa_enable_gpio, 1 },
+       { }
+};
+
+static const struct acpi_gpio_params quirk_pa_enable_gpio = { 1, 0, true };
+static const struct acpi_gpio_mapping quirk_acpi_es8336_gpios[] = {
+       { "pa-enable-gpios", &quirk_pa_enable_gpio, 1 },
+       { }
+};
+
+static const struct acpi_gpio_mapping *gpio_mapping = acpi_es8336_gpios;
+
+static void log_quirks(struct device *dev)
+{
+       dev_info(dev, "quirk SSP%ld",  SOF_ES8336_SSP_CODEC(quirk));
+}
+
+static int sof_es8316_speaker_power_event(struct snd_soc_dapm_widget *w,
+                                         struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_card *card = w->dapm->card;
+       struct sof_es8336_private *priv = snd_soc_card_get_drvdata(card);
+
+       if (SND_SOC_DAPM_EVENT_ON(event))
+               priv->speaker_en = false;
+       else
+               priv->speaker_en = true;
+
+       gpiod_set_value_cansleep(priv->gpio_pa, priv->speaker_en);
+
+       return 0;
+}
+
+static const struct snd_soc_dapm_widget sof_es8316_widgets[] = {
+       SND_SOC_DAPM_SPK("Speaker", NULL),
+       SND_SOC_DAPM_HP("Headphone", NULL),
+       SND_SOC_DAPM_MIC("Headset Mic", NULL),
+       SND_SOC_DAPM_MIC("Internal Mic", NULL),
+
+       SND_SOC_DAPM_SUPPLY("Speaker Power", SND_SOC_NOPM, 0, 0,
+                           sof_es8316_speaker_power_event,
+                           SND_SOC_DAPM_PRE_PMD | SND_SOC_DAPM_POST_PMU),
+};
+
+static const struct snd_soc_dapm_widget dmic_widgets[] = {
+       SND_SOC_DAPM_MIC("SoC DMIC", NULL),
+};
+
+static const struct snd_soc_dapm_route sof_es8316_audio_map[] = {
+       {"Headphone", NULL, "HPOL"},
+       {"Headphone", NULL, "HPOR"},
+
+       /*
+        * There is no separate speaker output instead the speakers are muxed to
+        * the HP outputs. The mux is controlled by the "Speaker Power" supply.
+        */
+       {"Speaker", NULL, "HPOL"},
+       {"Speaker", NULL, "HPOR"},
+       {"Speaker", NULL, "Speaker Power"},
+};
+
+static const struct snd_soc_dapm_route sof_es8316_intmic_in1_map[] = {
+       {"MIC1", NULL, "Internal Mic"},
+       {"MIC2", NULL, "Headset Mic"},
+};
+
+static const struct snd_soc_dapm_route dmic_map[] = {
+       /* digital mics */
+       {"DMic", NULL, "SoC DMIC"},
+};
+
+static const struct snd_kcontrol_new sof_es8316_controls[] = {
+       SOC_DAPM_PIN_SWITCH("Speaker"),
+       SOC_DAPM_PIN_SWITCH("Headphone"),
+       SOC_DAPM_PIN_SWITCH("Headset Mic"),
+       SOC_DAPM_PIN_SWITCH("Internal Mic"),
+};
+
+static struct snd_soc_jack_pin sof_es8316_jack_pins[] = {
+       {
+               .pin    = "Headphone",
+               .mask   = SND_JACK_HEADPHONE,
+       },
+       {
+               .pin    = "Headset Mic",
+               .mask   = SND_JACK_MICROPHONE,
+       },
+};
+
+static int dmic_init(struct snd_soc_pcm_runtime *runtime)
+{
+       struct snd_soc_card *card = runtime->card;
+       int ret;
+
+       ret = snd_soc_dapm_new_controls(&card->dapm, dmic_widgets,
+                                       ARRAY_SIZE(dmic_widgets));
+       if (ret) {
+               dev_err(card->dev, "DMic widget addition failed: %d\n", ret);
+               return ret;
+       }
+
+       ret = snd_soc_dapm_add_routes(&card->dapm, dmic_map,
+                                     ARRAY_SIZE(dmic_map));
+       if (ret)
+               dev_err(card->dev, "DMic map addition failed: %d\n", ret);
+
+       return ret;
+}
+
+static int sof_hdmi_init(struct snd_soc_pcm_runtime *runtime)
+{
+       struct sof_es8336_private *priv = snd_soc_card_get_drvdata(runtime->card);
+       struct snd_soc_dai *dai = asoc_rtd_to_codec(runtime, 0);
+       struct sof_hdmi_pcm *pcm;
+
+       pcm = devm_kzalloc(runtime->card->dev, sizeof(*pcm), GFP_KERNEL);
+       if (!pcm)
+               return -ENOMEM;
+
+       /* dai_link id is 1:1 mapped to the PCM device */
+       pcm->device = runtime->dai_link->id;
+       pcm->codec_dai = dai;
+
+       list_add_tail(&pcm->head, &priv->hdmi_pcm_list);
+
+       return 0;
+}
+
+static int sof_es8316_init(struct snd_soc_pcm_runtime *runtime)
+{
+       struct snd_soc_component *codec = asoc_rtd_to_codec(runtime, 0)->component;
+       struct snd_soc_card *card = runtime->card;
+       struct sof_es8336_private *priv = snd_soc_card_get_drvdata(card);
+       const struct snd_soc_dapm_route *custom_map;
+       int num_routes;
+       int ret;
+
+       card->dapm.idle_bias_off = true;
+
+       custom_map = sof_es8316_intmic_in1_map;
+       num_routes = ARRAY_SIZE(sof_es8316_intmic_in1_map);
+
+       ret = snd_soc_dapm_add_routes(&card->dapm, custom_map, num_routes);
+       if (ret)
+               return ret;
+
+       ret = snd_soc_card_jack_new(card, "Headset",
+                                   SND_JACK_HEADSET | SND_JACK_BTN_0,
+                                   &priv->jack, sof_es8316_jack_pins,
+                                   ARRAY_SIZE(sof_es8316_jack_pins));
+       if (ret) {
+               dev_err(card->dev, "jack creation failed %d\n", ret);
+               return ret;
+       }
+
+       snd_jack_set_key(priv->jack.jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
+
+       snd_soc_component_set_jack(codec, &priv->jack, NULL);
+
+       return 0;
+}
+
+static void sof_es8316_exit(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_component *component = asoc_rtd_to_codec(rtd, 0)->component;
+
+       snd_soc_component_set_jack(component, NULL, NULL);
+}
+
+static int sof_es8336_quirk_cb(const struct dmi_system_id *id)
+{
+       quirk = (unsigned long)id->driver_data;
+
+       if (quirk & SOF_ES8336_TGL_GPIO_QUIRK)
+               gpio_mapping = quirk_acpi_es8336_gpios;
+
+       return 1;
+}
+
+static const struct dmi_system_id sof_es8336_quirk_table[] = {
+       {
+               .callback = sof_es8336_quirk_cb,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "CHUWI Innovation And Technology"),
+                       DMI_MATCH(DMI_BOARD_NAME, "Hi10 X"),
+               },
+               .driver_data = (void *)SOF_ES8336_SSP_CODEC(2)
+       },
+       {
+               .callback = sof_es8336_quirk_cb,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "IP3 tech"),
+                       DMI_MATCH(DMI_BOARD_NAME, "WN1"),
+               },
+               .driver_data = (void *)(SOF_ES8336_SSP_CODEC(0) |
+                                       SOF_ES8336_TGL_GPIO_QUIRK |
+                                       SOF_ES8336_ENABLE_DMIC)
+       },
+       {}
+};
+
+static int sof_es8336_hw_params(struct snd_pcm_substream *substream,
+                               struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       const int sysclk = 19200000;
+       int ret;
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, 1, sysclk, SND_SOC_CLOCK_OUT);
+       if (ret < 0) {
+               dev_err(rtd->dev, "%s, Failed to set ES8336 SYSCLK: %d\n",
+                       __func__, ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+/* machine stream operations */
+static struct snd_soc_ops sof_es8336_ops = {
+       .hw_params = sof_es8336_hw_params,
+};
+
+static struct snd_soc_dai_link_component platform_component[] = {
+       {
+               /* name might be overridden during probe */
+               .name = "0000:00:1f.3"
+       }
+};
+
+SND_SOC_DAILINK_DEF(ssp1_codec,
+       DAILINK_COMP_ARRAY(COMP_CODEC("i2c-ESSX8336:00", "ES8316 HiFi")));
+
+static struct snd_soc_dai_link_component dmic_component[] = {
+       {
+               .name = "dmic-codec",
+               .dai_name = "dmic-hifi",
+       }
+};
+
+static int sof_es8336_late_probe(struct snd_soc_card *card)
+{
+       struct sof_es8336_private *priv = snd_soc_card_get_drvdata(card);
+       struct sof_hdmi_pcm *pcm;
+
+       if (list_empty(&priv->hdmi_pcm_list))
+               return -ENOENT;
+
+       pcm = list_first_entry(&priv->hdmi_pcm_list, struct sof_hdmi_pcm, head);
+
+       return hda_dsp_hdmi_build_controls(card, pcm->codec_dai->component);
+}
+
+/* SoC card */
+static struct snd_soc_card sof_es8336_card = {
+       .name = "essx8336", /* sof- prefix added automatically */
+       .owner = THIS_MODULE,
+       .dapm_widgets = sof_es8316_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(sof_es8316_widgets),
+       .dapm_routes = sof_es8316_audio_map,
+       .num_dapm_routes = ARRAY_SIZE(sof_es8316_audio_map),
+       .controls = sof_es8316_controls,
+       .num_controls = ARRAY_SIZE(sof_es8316_controls),
+       .fully_routed = true,
+       .late_probe = sof_es8336_late_probe,
+       .num_links = 1,
+};
+
+static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
+                                                         int ssp_codec,
+                                                         int dmic_be_num,
+                                                         int hdmi_num)
+{
+       struct snd_soc_dai_link_component *cpus;
+       struct snd_soc_dai_link *links;
+       struct snd_soc_dai_link_component *idisp_components;
+       int hdmi_id_offset = 0;
+       int id = 0;
+       int i;
+
+       links = devm_kcalloc(dev, sof_es8336_card.num_links,
+                            sizeof(struct snd_soc_dai_link), GFP_KERNEL);
+       cpus = devm_kcalloc(dev, sof_es8336_card.num_links,
+                           sizeof(struct snd_soc_dai_link_component), GFP_KERNEL);
+       if (!links || !cpus)
+               goto devm_err;
+
+       /* codec SSP */
+       links[id].name = devm_kasprintf(dev, GFP_KERNEL,
+                                       "SSP%d-Codec", ssp_codec);
+       if (!links[id].name)
+               goto devm_err;
+
+       links[id].id = id;
+       links[id].codecs = ssp1_codec;
+       links[id].num_codecs = ARRAY_SIZE(ssp1_codec);
+       links[id].platforms = platform_component;
+       links[id].num_platforms = ARRAY_SIZE(platform_component);
+       links[id].init = sof_es8316_init;
+       links[id].exit = sof_es8316_exit;
+       links[id].ops = &sof_es8336_ops;
+       links[id].nonatomic = true;
+       links[id].dpcm_playback = 1;
+       links[id].dpcm_capture = 1;
+       links[id].no_pcm = 1;
+       links[id].cpus = &cpus[id];
+       links[id].num_cpus = 1;
+
+       links[id].cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
+                                                 "SSP%d Pin",
+                                                 ssp_codec);
+       if (!links[id].cpus->dai_name)
+               goto devm_err;
+
+       id++;
+
+       /* dmic */
+       if (dmic_be_num > 0) {
+               /* at least we have dmic01 */
+               links[id].name = "dmic01";
+               links[id].cpus = &cpus[id];
+               links[id].cpus->dai_name = "DMIC01 Pin";
+               links[id].init = dmic_init;
+               if (dmic_be_num > 1) {
+                       /* set up 2 BE links at most */
+                       links[id + 1].name = "dmic16k";
+                       links[id + 1].cpus = &cpus[id + 1];
+                       links[id + 1].cpus->dai_name = "DMIC16k Pin";
+                       dmic_be_num = 2;
+               }
+       } else {
+               /* HDMI dai link starts at 3 according to current topology settings */
+               hdmi_id_offset = 2;
+       }
+
+       for (i = 0; i < dmic_be_num; i++) {
+               links[id].id = id;
+               links[id].num_cpus = 1;
+               links[id].codecs = dmic_component;
+               links[id].num_codecs = ARRAY_SIZE(dmic_component);
+               links[id].platforms = platform_component;
+               links[id].num_platforms = ARRAY_SIZE(platform_component);
+               links[id].ignore_suspend = 1;
+               links[id].dpcm_capture = 1;
+               links[id].no_pcm = 1;
+
+               id++;
+       }
+
+       /* HDMI */
+       if (hdmi_num > 0) {
+               idisp_components = devm_kzalloc(dev,
+                                               sizeof(struct snd_soc_dai_link_component) *
+                                               hdmi_num, GFP_KERNEL);
+               if (!idisp_components)
+                       goto devm_err;
+       }
+
+       for (i = 1; i <= hdmi_num; i++) {
+               links[id].name = devm_kasprintf(dev, GFP_KERNEL,
+                                               "iDisp%d", i);
+               if (!links[id].name)
+                       goto devm_err;
+
+               links[id].id = id + hdmi_id_offset;
+               links[id].cpus = &cpus[id];
+               links[id].num_cpus = 1;
+               links[id].cpus->dai_name = devm_kasprintf(dev, GFP_KERNEL,
+                                                         "iDisp%d Pin", i);
+               if (!links[id].cpus->dai_name)
+                       goto devm_err;
+
+               idisp_components[i - 1].name = "ehdaudio0D2";
+               idisp_components[i - 1].dai_name = devm_kasprintf(dev,
+                                                                 GFP_KERNEL,
+                                                                 "intel-hdmi-hifi%d",
+                                                                 i);
+               if (!idisp_components[i - 1].dai_name)
+                       goto devm_err;
+
+               links[id].codecs = &idisp_components[i - 1];
+               links[id].num_codecs = 1;
+               links[id].platforms = platform_component;
+               links[id].num_platforms = ARRAY_SIZE(platform_component);
+               links[id].init = sof_hdmi_init;
+               links[id].dpcm_playback = 1;
+               links[id].no_pcm = 1;
+
+               id++;
+       }
+
+       return links;
+
+devm_err:
+       return NULL;
+}
+
+ /* i2c-<HID>:00 with HID being 8 chars */
+static char codec_name[SND_ACPI_I2C_ID_LEN];
+
+static int sof_es8336_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct snd_soc_card *card;
+       struct snd_soc_acpi_mach *mach = pdev->dev.platform_data;
+       struct sof_es8336_private *priv;
+       struct acpi_device *adev;
+       struct snd_soc_dai_link *dai_links;
+       struct device *codec_dev;
+       int dmic_be_num = 0;
+       int hdmi_num = 3;
+       int ret;
+
+       priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       card = &sof_es8336_card;
+       card->dev = dev;
+
+       if (!dmi_check_system(sof_es8336_quirk_table))
+               quirk = SOF_ES8336_SSP_CODEC(2);
+
+       if (quirk & SOF_ES8336_ENABLE_DMIC)
+               dmic_be_num = 2;
+
+       if (quirk_override != -1) {
+               dev_info(dev, "Overriding quirk 0x%lx => 0x%x\n",
+                        quirk, quirk_override);
+               quirk = quirk_override;
+       }
+       log_quirks(dev);
+
+       sof_es8336_card.num_links += dmic_be_num + hdmi_num;
+       dai_links = sof_card_dai_links_create(dev,
+                                             SOF_ES8336_SSP_CODEC(quirk),
+                                             dmic_be_num, hdmi_num);
+       if (!dai_links)
+               return -ENOMEM;
+
+       sof_es8336_card.dai_link = dai_links;
+
+       /* fixup codec name based on HID */
+       adev = acpi_dev_get_first_match_dev(mach->id, NULL, -1);
+       if (adev) {
+               snprintf(codec_name, sizeof(codec_name),
+                        "i2c-%s", acpi_dev_name(adev));
+               put_device(&adev->dev);
+               dai_links[0].codecs->name = codec_name;
+       }
+
+       ret = snd_soc_fixup_dai_links_platform_name(&sof_es8336_card,
+                                                   mach->mach_params.platform);
+       if (ret)
+               return ret;
+
+       /* get speaker enable GPIO */
+       codec_dev = bus_find_device_by_name(&i2c_bus_type, NULL, codec_name);
+       if (!codec_dev)
+               return -EPROBE_DEFER;
+
+       ret = devm_acpi_dev_add_driver_gpios(codec_dev, gpio_mapping);
+       if (ret)
+               dev_warn(codec_dev, "unable to add GPIO mapping table\n");
+
+       priv->gpio_pa = gpiod_get(codec_dev, "pa-enable", GPIOD_OUT_LOW);
+       if (IS_ERR(priv->gpio_pa)) {
+               ret = PTR_ERR(priv->gpio_pa);
+               dev_err(codec_dev, "%s, could not get pa-enable: %d\n",
+                       __func__, ret);
+               goto err;
+       }
+
+       priv->codec_dev = codec_dev;
+       INIT_LIST_HEAD(&priv->hdmi_pcm_list);
+
+       snd_soc_card_set_drvdata(card, priv);
+
+       ret = devm_snd_soc_register_card(dev, card);
+       if (ret) {
+               gpiod_put(priv->gpio_pa);
+               dev_err(dev, "snd_soc_register_card failed: %d\n", ret);
+               goto err;
+       }
+       platform_set_drvdata(pdev, &sof_es8336_card);
+       return 0;
+
+err:
+       put_device(codec_dev);
+       return ret;
+}
+
+static int sof_es8336_remove(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = platform_get_drvdata(pdev);
+       struct sof_es8336_private *priv = snd_soc_card_get_drvdata(card);
+
+       gpiod_put(priv->gpio_pa);
+       put_device(priv->codec_dev);
+
+       return 0;
+}
+
+static struct platform_driver sof_es8336_driver = {
+       .driver = {
+               .name = "sof-essx8336",
+               .pm = &snd_soc_pm_ops,
+       },
+       .probe = sof_es8336_probe,
+       .remove = sof_es8336_remove,
+};
+module_platform_driver(sof_es8336_driver);
+
+MODULE_DESCRIPTION("ASoC Intel(R) SOF + ES8336 Machine driver");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:sof-essx8336");
+MODULE_IMPORT_NS(SND_SOC_INTEL_HDA_DSP_COMMON);
index f096bd6..c41f386 100644 (file)
 #include <sound/soc.h>
 #include <sound/sof.h>
 #include <sound/rt5682.h>
+#include <sound/rt5682s.h>
 #include <sound/soc-acpi.h>
 #include "../../codecs/rt1015.h"
 #include "../../codecs/rt5682.h"
+#include "../../codecs/rt5682s.h"
 #include "../../codecs/hdac_hdmi.h"
 #include "../common/soc-intel-quirks.h"
 #include "hda_dsp_common.h"
@@ -56,6 +58,7 @@
 #define SOF_BT_OFFLOAD_SSP(quirk)      \
        (((quirk) << SOF_BT_OFFLOAD_SSP_SHIFT) & SOF_BT_OFFLOAD_SSP_MASK)
 #define SOF_SSP_BT_OFFLOAD_PRESENT             BIT(22)
+#define SOF_RT5682S_HEADPHONE_CODEC_PRESENT    BIT(23)
 
 /* Default: MCLK on, MCLK 19.2M, SSP0  */
 static unsigned long sof_rt5682_quirk = SOF_RT5682_MCLK_EN |
@@ -208,9 +211,16 @@ static int sof_rt5682_codec_init(struct snd_soc_pcm_runtime *rtd)
        /* need to enable ASRC function for 24MHz mclk rate */
        if ((sof_rt5682_quirk & SOF_RT5682_MCLK_EN) &&
            (sof_rt5682_quirk & SOF_RT5682_MCLK_24MHZ)) {
-               rt5682_sel_asrc_clk_src(component, RT5682_DA_STEREO1_FILTER |
-                                       RT5682_AD_STEREO1_FILTER,
-                                       RT5682_CLK_SEL_I2S1_ASRC);
+               if (sof_rt5682_quirk & SOF_RT5682S_HEADPHONE_CODEC_PRESENT)
+                       rt5682s_sel_asrc_clk_src(component,
+                                                RT5682S_DA_STEREO1_FILTER |
+                                                RT5682S_AD_STEREO1_FILTER,
+                                                RT5682S_CLK_SEL_I2S1_ASRC);
+               else
+                       rt5682_sel_asrc_clk_src(component,
+                                               RT5682_DA_STEREO1_FILTER |
+                                               RT5682_AD_STEREO1_FILTER,
+                                               RT5682_CLK_SEL_I2S1_ASRC);
        }
 
        if (sof_rt5682_quirk & SOF_RT5682_MCLK_BYTCHT_EN) {
@@ -277,7 +287,7 @@ static int sof_rt5682_hw_params(struct snd_pcm_substream *substream,
        struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
        struct sof_card_private *ctx = snd_soc_card_get_drvdata(rtd->card);
        struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
-       int clk_id, clk_freq, pll_out, ret;
+       int pll_id, pll_source, pll_in, pll_out, clk_id, ret;
 
        if (sof_rt5682_quirk & SOF_RT5682_MCLK_EN) {
                if (sof_rt5682_quirk & SOF_RT5682_MCLK_BYTCHT_EN) {
@@ -289,35 +299,52 @@ static int sof_rt5682_hw_params(struct snd_pcm_substream *substream,
                        }
                }
 
-               clk_id = RT5682_PLL1_S_MCLK;
+               if (sof_rt5682_quirk & SOF_RT5682S_HEADPHONE_CODEC_PRESENT)
+                       pll_source = RT5682S_PLL_S_MCLK;
+               else
+                       pll_source = RT5682_PLL1_S_MCLK;
 
                /* get the tplg configured mclk. */
-               clk_freq = sof_dai_get_mclk(rtd);
+               pll_in = sof_dai_get_mclk(rtd);
 
                /* mclk from the quirk is the first choice */
                if (sof_rt5682_quirk & SOF_RT5682_MCLK_24MHZ) {
-                       if (clk_freq != 24000000)
+                       if (pll_in != 24000000)
                                dev_warn(rtd->dev, "configure wrong mclk in tplg, please use 24MHz.\n");
-                       clk_freq = 24000000;
-               } else if (clk_freq == 0) {
+                       pll_in = 24000000;
+               } else if (pll_in == 0) {
                        /* use default mclk if not specified correct in topology */
-                       clk_freq = 19200000;
-               } else if (clk_freq < 0) {
-                       return clk_freq;
+                       pll_in = 19200000;
+               } else if (pll_in < 0) {
+                       return pll_in;
                }
        } else {
-               clk_id = RT5682_PLL1_S_BCLK1;
-               clk_freq = params_rate(params) * 50;
+               if (sof_rt5682_quirk & SOF_RT5682S_HEADPHONE_CODEC_PRESENT)
+                       pll_source = RT5682S_PLL_S_BCLK1;
+               else
+                       pll_source = RT5682_PLL1_S_BCLK1;
+
+               pll_in = params_rate(params) * 50;
+       }
+
+       if (sof_rt5682_quirk & SOF_RT5682S_HEADPHONE_CODEC_PRESENT) {
+               pll_id = RT5682S_PLL2;
+               clk_id = RT5682S_SCLK_S_PLL2;
+       } else {
+               pll_id = RT5682_PLL1;
+               clk_id = RT5682_SCLK_S_PLL1;
        }
 
        pll_out = params_rate(params) * 512;
 
-       ret = snd_soc_dai_set_pll(codec_dai, 0, clk_id, clk_freq, pll_out);
+       /* Configure pll for codec */
+       ret = snd_soc_dai_set_pll(codec_dai, pll_id, pll_source, pll_in,
+                                 pll_out);
        if (ret < 0)
                dev_err(rtd->dev, "snd_soc_dai_set_pll err = %d\n", ret);
 
        /* Configure sysclk for codec */
-       ret = snd_soc_dai_set_sysclk(codec_dai, RT5682_SCLK_S_PLL1,
+       ret = snd_soc_dai_set_sysclk(codec_dai, clk_id,
                                     pll_out, SND_SOC_CLOCK_IN);
        if (ret < 0)
                dev_err(rtd->dev, "snd_soc_dai_set_sysclk err = %d\n", ret);
@@ -560,6 +587,13 @@ static struct snd_soc_dai_link_component rt5682_component[] = {
        }
 };
 
+static struct snd_soc_dai_link_component rt5682s_component[] = {
+       {
+               .name = "i2c-RTL5682:00",
+               .dai_name = "rt5682s-aif1",
+       }
+};
+
 static struct snd_soc_dai_link_component dmic_component[] = {
        {
                .name = "dmic-codec",
@@ -610,8 +644,13 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev,
                goto devm_err;
 
        links[id].id = id;
-       links[id].codecs = rt5682_component;
-       links[id].num_codecs = ARRAY_SIZE(rt5682_component);
+       if (sof_rt5682_quirk & SOF_RT5682S_HEADPHONE_CODEC_PRESENT) {
+               links[id].codecs = rt5682s_component;
+               links[id].num_codecs = ARRAY_SIZE(rt5682s_component);
+       } else {
+               links[id].codecs = rt5682_component;
+               links[id].num_codecs = ARRAY_SIZE(rt5682_component);
+       }
        links[id].platforms = platform_component;
        links[id].num_platforms = ARRAY_SIZE(platform_component);
        links[id].init = sof_rt5682_codec_init;
@@ -825,6 +864,10 @@ static int sof_audio_probe(struct platform_device *pdev)
        if ((sof_rt5682_quirk & SOF_SPEAKER_AMP_PRESENT) && !mach->quirk_data)
                sof_rt5682_quirk &= ~SOF_SPEAKER_AMP_PRESENT;
 
+       /* Detect the headset codec variant */
+       if (acpi_dev_present("RTL5682", NULL, -1))
+               sof_rt5682_quirk |= SOF_RT5682S_HEADPHONE_CODEC_PRESENT;
+
        if (soc_intel_is_byt() || soc_intel_is_cht()) {
                is_legacy_cpu = 1;
                dmic_be_num = 0;
@@ -920,7 +963,7 @@ static const struct platform_device_id board_ids[] = {
                .name = "sof_rt5682",
        },
        {
-               .name = "tgl_mx98357a_rt5682",
+               .name = "tgl_mx98357_rt5682",
                .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
                                        SOF_RT5682_SSP_CODEC(0) |
                                        SOF_SPEAKER_AMP_PRESENT |
@@ -950,7 +993,7 @@ static const struct platform_device_id board_ids[] = {
                                        SOF_SSP_BT_OFFLOAD_PRESENT),
        },
        {
-               .name = "jsl_rt5682_mx98360a",
+               .name = "jsl_rt5682_mx98360",
                .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
                                        SOF_RT5682_MCLK_24MHZ |
                                        SOF_RT5682_SSP_CODEC(0) |
@@ -1000,13 +1043,24 @@ static const struct platform_device_id board_ids[] = {
                                        SOF_SSP_BT_OFFLOAD_PRESENT),
        },
        {
-               .name = "adl_mx98357a_rt5682",
+               .name = "adl_mx98357_rt5682",
                .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
                                        SOF_RT5682_SSP_CODEC(0) |
                                        SOF_SPEAKER_AMP_PRESENT |
                                        SOF_RT5682_SSP_AMP(2) |
                                        SOF_RT5682_NUM_HDMIDEV(4)),
        },
+       {
+               .name = "adl_mx98360_rt5682",
+               .driver_data = (kernel_ulong_t)(SOF_RT5682_MCLK_EN |
+                                       SOF_RT5682_SSP_CODEC(0) |
+                                       SOF_SPEAKER_AMP_PRESENT |
+                                       SOF_MAX98360A_SPEAKER_AMP_PRESENT |
+                                       SOF_RT5682_SSP_AMP(1) |
+                                       SOF_RT5682_NUM_HDMIDEV(4) |
+                                       SOF_BT_OFFLOAD_SSP(2) |
+                                       SOF_SSP_BT_OFFLOAD_PRESENT),
+       },
        { }
 };
 MODULE_DEVICE_TABLE(platform, board_ids);
index 6b06248..f104962 100644 (file)
@@ -213,6 +213,16 @@ static const struct dmi_system_id sof_sdw_quirk_table[] = {
                                        SOF_RT715_DAI_ID_FIX |
                                        SOF_SDW_FOUR_SPK),
        },
+       {
+               .callback = sof_sdw_quirk_cb,
+               .matches = {
+                       DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc"),
+                       DMI_EXACT_MATCH(DMI_PRODUCT_SKU, "0A45")
+               },
+               .driver_data = (void *)(SOF_SDW_TGL_HDMI |
+                                       RT711_JD2 |
+                                       SOF_RT715_DAI_ID_FIX),
+       },
        /* AlderLake devices */
        {
                .callback = sof_sdw_quirk_cb,
index a0f6a69..06f5034 100644 (file)
@@ -280,9 +280,19 @@ static const struct snd_soc_acpi_codecs adl_max98357a_amp = {
        .codecs = {"MX98357A"}
 };
 
+static const struct snd_soc_acpi_codecs adl_max98360a_amp = {
+       .num_codecs = 1,
+       .codecs = {"MX98360A"}
+};
+
+static const struct snd_soc_acpi_codecs adl_rt5682_rt5682s_hp = {
+       .num_codecs = 2,
+       .codecs = {"10EC5682", "RTL5682"},
+};
+
 struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_machines[] = {
        {
-               .id = "10EC5682",
+               .comp_ids = &adl_rt5682_rt5682s_hp,
                .drv_name = "adl_mx98373_rt5682",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &adl_max98373_amp,
@@ -290,13 +300,21 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_adl_machines[] = {
                .sof_tplg_filename = "sof-adl-max98373-rt5682.tplg",
        },
        {
-               .id = "10EC5682",
-               .drv_name = "adl_mx98357a_rt5682",
+               .comp_ids = &adl_rt5682_rt5682s_hp,
+               .drv_name = "adl_mx98357_rt5682",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &adl_max98357a_amp,
                .sof_fw_filename = "sof-adl.ri",
                .sof_tplg_filename = "sof-adl-max98357a-rt5682.tplg",
        },
+       {
+               .comp_ids = &adl_rt5682_rt5682s_hp,
+               .drv_name = "adl_mx98360_rt5682",
+               .machine_quirk = snd_soc_acpi_codec_list,
+               .quirk_data = &adl_max98360a_amp,
+               .sof_fw_filename = "sof-adl.ri",
+               .sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg",
+       },
        {},
 };
 EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_adl_machines);
index 576407b..342d340 100644 (file)
@@ -41,7 +41,7 @@ static struct snd_soc_acpi_mach *apl_quirk(void *arg)
        return mach;
 }
 
-static struct snd_soc_acpi_codecs bxt_codecs = {
+static const struct snd_soc_acpi_codecs bxt_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98357A"}
 };
@@ -82,6 +82,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_bxt_machines[] = {
                .sof_fw_filename = "sof-apl.ri",
                .sof_tplg_filename = "sof-apl-tdf8532.tplg",
        },
+       {
+               .id = "ESSX8336",
+               .drv_name = "sof-essx8336",
+               .sof_fw_filename = "sof-apl.ri",
+               .sof_tplg_filename = "sof-apl-es8336.tplg",
+       },
        {},
 };
 EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_bxt_machines);
index 510a5f3..1420009 100644 (file)
@@ -120,9 +120,29 @@ static struct snd_soc_acpi_mach *byt_quirk(void *arg)
        }
 }
 
+static const struct snd_soc_acpi_codecs rt5640_comp_ids = {
+       .num_codecs = 3,
+       .codecs = { "10EC5640", "10EC5642", "INTCCFFD"},
+};
+
+static const struct snd_soc_acpi_codecs wm5102_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "WM510204", "WM510205"},
+};
+
+static const struct snd_soc_acpi_codecs da7213_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "DGLS7212", "DGLS7213"},
+};
+
+static const struct snd_soc_acpi_codecs rt5645_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "10EC5645", "10EC5648"},
+};
+
 struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
        {
-               .id = "10EC5640",
+               .comp_ids = &rt5640_comp_ids,
                .drv_name = "bytcr_rt5640",
                .fw_filename = "intel/fw_sst_0f28.bin",
                .board = "bytcr_rt5640",
@@ -130,22 +150,6 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
                .sof_fw_filename = "sof-byt.ri",
                .sof_tplg_filename = "sof-byt-rt5640.tplg",
        },
-       {
-               .id = "10EC5642",
-               .drv_name = "bytcr_rt5640",
-               .fw_filename = "intel/fw_sst_0f28.bin",
-               .board = "bytcr_rt5640",
-               .sof_fw_filename = "sof-byt.ri",
-               .sof_tplg_filename = "sof-byt-rt5640.tplg",
-       },
-       {
-               .id = "INTCCFFD",
-               .drv_name = "bytcr_rt5640",
-               .fw_filename = "intel/fw_sst_0f28.bin",
-               .board = "bytcr_rt5640",
-               .sof_fw_filename = "sof-byt.ri",
-               .sof_tplg_filename = "sof-byt-rt5640.tplg",
-       },
        {
                .id = "10EC5651",
                .drv_name = "bytcr_rt5651",
@@ -155,7 +159,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
                .sof_tplg_filename = "sof-byt-rt5651.tplg",
        },
        {
-               .id = "WM510204",
+               .comp_ids = &wm5102_comp_ids,
                .drv_name = "bytcr_wm5102",
                .fw_filename = "intel/fw_sst_0f28.bin",
                .board = "bytcr_wm5102",
@@ -163,23 +167,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
                .sof_tplg_filename = "sof-byt-wm5102.tplg",
        },
        {
-               .id = "WM510205",
-               .drv_name = "bytcr_wm5102",
-               .fw_filename = "intel/fw_sst_0f28.bin",
-               .board = "bytcr_wm5102",
-               .sof_fw_filename = "sof-byt.ri",
-               .sof_tplg_filename = "sof-byt-wm5102.tplg",
-       },
-       {
-               .id = "DLGS7212",
-               .drv_name = "bytcht_da7213",
-               .fw_filename = "intel/fw_sst_0f28.bin",
-               .board = "bytcht_da7213",
-               .sof_fw_filename = "sof-byt.ri",
-               .sof_tplg_filename = "sof-byt-da7213.tplg",
-       },
-       {
-               .id = "DLGS7213",
+               .comp_ids = &da7213_comp_ids,
                .drv_name = "bytcht_da7213",
                .fw_filename = "intel/fw_sst_0f28.bin",
                .board = "bytcht_da7213",
@@ -202,15 +190,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_baytrail_machines[] = {
        },
        /* some Baytrail platforms rely on RT5645, use CHT machine driver */
        {
-               .id = "10EC5645",
-               .drv_name = "cht-bsw-rt5645",
-               .fw_filename = "intel/fw_sst_0f28.bin",
-               .board = "cht-bsw",
-               .sof_fw_filename = "sof-byt.ri",
-               .sof_tplg_filename = "sof-byt-rt5645.tplg",
-       },
-       {
-               .id = "10EC5648",
+               .comp_ids = &rt5645_comp_ids,
                .drv_name = "cht-bsw-rt5645",
                .fw_filename = "intel/fw_sst_0f28.bin",
                .board = "cht-bsw",
index 2274242..c60a5e8 100644 (file)
@@ -51,18 +51,31 @@ static struct snd_soc_acpi_mach *cht_quirk(void *arg)
                return mach;
 }
 
+static const struct snd_soc_acpi_codecs rt5640_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "10EC5640", "10EC3276" },
+};
+
+static const struct snd_soc_acpi_codecs rt5670_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "10EC5670", "10EC5672" },
+};
+
+static const struct snd_soc_acpi_codecs rt5645_comp_ids = {
+       .num_codecs = 3,
+       .codecs = { "10EC5645", "10EC5650", "10EC3270" },
+};
+
+static const struct snd_soc_acpi_codecs da7213_comp_ids = {
+       .num_codecs = 2,
+       .codecs = { "DGLS7212", "DGLS7213"},
+
+};
+
 /* Cherryview-based platforms: CherryTrail and Braswell */
 struct snd_soc_acpi_mach  snd_soc_acpi_intel_cherrytrail_machines[] = {
        {
-               .id = "10EC5670",
-               .drv_name = "cht-bsw-rt5672",
-               .fw_filename = "intel/fw_sst_22a8.bin",
-               .board = "cht-bsw",
-               .sof_fw_filename = "sof-cht.ri",
-               .sof_tplg_filename = "sof-cht-rt5670.tplg",
-       },
-       {
-               .id = "10EC5672",
+               .comp_ids = &rt5670_comp_ids,
                .drv_name = "cht-bsw-rt5672",
                .fw_filename = "intel/fw_sst_22a8.bin",
                .board = "cht-bsw",
@@ -70,23 +83,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_cherrytrail_machines[] = {
                .sof_tplg_filename = "sof-cht-rt5670.tplg",
        },
        {
-               .id = "10EC5645",
-               .drv_name = "cht-bsw-rt5645",
-               .fw_filename = "intel/fw_sst_22a8.bin",
-               .board = "cht-bsw",
-               .sof_fw_filename = "sof-cht.ri",
-               .sof_tplg_filename = "sof-cht-rt5645.tplg",
-       },
-       {
-               .id = "10EC5650",
-               .drv_name = "cht-bsw-rt5645",
-               .fw_filename = "intel/fw_sst_22a8.bin",
-               .board = "cht-bsw",
-               .sof_fw_filename = "sof-cht.ri",
-               .sof_tplg_filename = "sof-cht-rt5645.tplg",
-       },
-       {
-               .id = "10EC3270",
+               .comp_ids = &rt5645_comp_ids,
                .drv_name = "cht-bsw-rt5645",
                .fw_filename = "intel/fw_sst_22a8.bin",
                .board = "cht-bsw",
@@ -110,15 +107,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_cherrytrail_machines[] = {
                .sof_tplg_filename = "sof-cht-nau8824.tplg",
        },
        {
-               .id = "DLGS7212",
-               .drv_name = "bytcht_da7213",
-               .fw_filename = "intel/fw_sst_22a8.bin",
-               .board = "bytcht_da7213",
-               .sof_fw_filename = "sof-cht.ri",
-               .sof_tplg_filename = "sof-cht-da7213.tplg",
-       },
-       {
-               .id = "DLGS7213",
+               .comp_ids = &da7213_comp_ids,
                .drv_name = "bytcht_da7213",
                .fw_filename = "intel/fw_sst_22a8.bin",
                .board = "bytcht_da7213",
@@ -135,7 +124,7 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_cherrytrail_machines[] = {
        },
        /* some CHT-T platforms rely on RT5640, use Baytrail machine driver */
        {
-               .id = "10EC5640",
+               .comp_ids = &rt5640_comp_ids,
                .drv_name = "bytcr_rt5640",
                .fw_filename = "intel/fw_sst_22a8.bin",
                .board = "bytcr_rt5640",
@@ -143,14 +132,6 @@ struct snd_soc_acpi_mach  snd_soc_acpi_intel_cherrytrail_machines[] = {
                .sof_fw_filename = "sof-cht.ri",
                .sof_tplg_filename = "sof-cht-rt5640.tplg",
        },
-       {
-               .id = "10EC3276",
-               .drv_name = "bytcr_rt5640",
-               .fw_filename = "intel/fw_sst_22a8.bin",
-               .board = "bytcr_rt5640",
-               .sof_fw_filename = "sof-cht.ri",
-               .sof_tplg_filename = "sof-cht-rt5640.tplg",
-       },
        {
                .id = "10EC5682",
                .drv_name = "sof_rt5682",
index b591c6f..b4eb0c9 100644 (file)
@@ -9,22 +9,22 @@
 #include <sound/soc-acpi.h>
 #include <sound/soc-acpi-intel-match.h>
 
-static struct snd_soc_acpi_codecs rt1011_spk_codecs = {
+static const struct snd_soc_acpi_codecs rt1011_spk_codecs = {
        .num_codecs = 1,
        .codecs = {"10EC1011"}
 };
 
-static struct snd_soc_acpi_codecs rt1015_spk_codecs = {
+static const struct snd_soc_acpi_codecs rt1015_spk_codecs = {
        .num_codecs = 1,
        .codecs = {"10EC1015"}
 };
 
-static struct snd_soc_acpi_codecs max98357a_spk_codecs = {
+static const struct snd_soc_acpi_codecs max98357a_spk_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98357A"}
 };
 
-static struct snd_soc_acpi_codecs max98390_spk_codecs = {
+static const struct snd_soc_acpi_codecs max98390_spk_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98390"}
 };
index da1e151..8492b7e 100644 (file)
@@ -9,7 +9,7 @@
 #include <sound/soc-acpi.h>
 #include <sound/soc-acpi-intel-match.h>
 
-static struct snd_soc_acpi_codecs glk_codecs = {
+static const struct snd_soc_acpi_codecs glk_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98357A"}
 };
@@ -40,6 +40,14 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
                .sof_fw_filename = "sof-glk.ri",
                .sof_tplg_filename = "sof-glk-rt5682.tplg",
        },
+       {
+               .id = "RTL5682",
+               .drv_name = "glk_rt5682_max98357a",
+               .machine_quirk = snd_soc_acpi_codec_list,
+               .quirk_data = &glk_codecs,
+               .sof_fw_filename = "sof-glk.ri",
+               .sof_tplg_filename = "sof-glk-rt5682.tplg",
+       },
        {
                .id = "10134242",
                .drv_name = "glk_cs4242_mx98357a",
@@ -49,7 +57,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_glk_machines[] = {
                .sof_fw_filename = "sof-glk.ri",
                .sof_tplg_filename = "sof-glk-cs42l42.tplg",
        },
-
+       {
+               .id = "ESSX8336",
+               .drv_name = "sof-essx8336",
+               .sof_fw_filename = "sof-glk.ri",
+               .sof_tplg_filename = "sof-glk-es8336.tplg",
+       },
        {},
 };
 EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_glk_machines);
index 69ff728..278ec19 100644 (file)
@@ -9,26 +9,31 @@
 #include <sound/soc-acpi.h>
 #include <sound/soc-acpi-intel-match.h>
 
-static struct snd_soc_acpi_codecs jsl_7219_98373_codecs = {
+static const struct snd_soc_acpi_codecs jsl_7219_98373_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98373"}
 };
 
-static struct snd_soc_acpi_codecs rt1015_spk = {
+static const struct snd_soc_acpi_codecs rt1015_spk = {
        .num_codecs = 1,
        .codecs = {"10EC1015"}
 };
 
-static struct snd_soc_acpi_codecs rt1015p_spk = {
+static const struct snd_soc_acpi_codecs rt1015p_spk = {
        .num_codecs = 1,
        .codecs = {"RTL1015"}
 };
 
-static struct snd_soc_acpi_codecs mx98360a_spk = {
+static const struct snd_soc_acpi_codecs mx98360a_spk = {
        .num_codecs = 1,
        .codecs = {"MX98360A"}
 };
 
+static const struct snd_soc_acpi_codecs rt5682_rt5682s_hp = {
+       .num_codecs = 2,
+       .codecs = {"10EC5682", "RTL5682"},
+};
+
 /*
  * When adding new entry to the snd_soc_acpi_intel_jsl_machines array,
  * use .quirk_data member to distinguish different machine driver,
@@ -50,7 +55,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
                .sof_tplg_filename = "sof-jsl-da7219-mx98360a.tplg",
        },
        {
-               .id = "10EC5682",
+               .comp_ids = &rt5682_rt5682s_hp,
                .drv_name = "jsl_rt5682_rt1015",
                .sof_fw_filename = "sof-jsl.ri",
                .machine_quirk = snd_soc_acpi_codec_list,
@@ -58,7 +63,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
                .sof_tplg_filename = "sof-jsl-rt5682-rt1015.tplg",
        },
        {
-               .id = "10EC5682",
+               .comp_ids = &rt5682_rt5682s_hp,
                .drv_name = "jsl_rt5682_rt1015p",
                .sof_fw_filename = "sof-jsl.ri",
                .machine_quirk = snd_soc_acpi_codec_list,
@@ -66,8 +71,8 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
                .sof_tplg_filename = "sof-jsl-rt5682-rt1015.tplg",
        },
        {
-               .id = "10EC5682",
-               .drv_name = "jsl_rt5682_mx98360a",
+               .comp_ids = &rt5682_rt5682s_hp,
+               .drv_name = "jsl_rt5682_mx98360",
                .sof_fw_filename = "sof-jsl.ri",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &mx98360a_spk,
@@ -81,6 +86,12 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_jsl_machines[] = {
                .quirk_data = &mx98360a_spk,
                .sof_tplg_filename = "sof-jsl-cs42l42-mx98360a.tplg",
        },
+       {
+               .id = "ESSX8336",
+               .drv_name = "sof-essx8336",
+               .sof_fw_filename = "sof-jsl.ri",
+               .sof_tplg_filename = "sof-jsl-es8336.tplg",
+       },
        {},
 };
 EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_jsl_machines);
index 741bf2f..4e817f5 100644 (file)
 
 static struct skl_machine_pdata skl_dmic_data;
 
-static struct snd_soc_acpi_codecs kbl_codecs = {
+static const struct snd_soc_acpi_codecs kbl_codecs = {
        .num_codecs = 1,
        .codecs = {"10508825"}
 };
 
-static struct snd_soc_acpi_codecs kbl_poppy_codecs = {
+static const struct snd_soc_acpi_codecs kbl_poppy_codecs = {
        .num_codecs = 1,
        .codecs = {"10EC5663"}
 };
 
-static struct snd_soc_acpi_codecs kbl_5663_5514_codecs = {
+static const struct snd_soc_acpi_codecs kbl_5663_5514_codecs = {
        .num_codecs = 2,
        .codecs = {"10EC5663", "10EC5514"}
 };
 
-static struct snd_soc_acpi_codecs kbl_7219_98357_codecs = {
+static const struct snd_soc_acpi_codecs kbl_7219_98357_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98357A"}
 };
 
-static struct snd_soc_acpi_codecs kbl_7219_98927_codecs = {
+static const struct snd_soc_acpi_codecs kbl_7219_98927_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98927"}
 };
 
-static struct snd_soc_acpi_codecs kbl_7219_98373_codecs = {
+static const struct snd_soc_acpi_codecs kbl_7219_98373_codecs = {
        .num_codecs = 1,
        .codecs = {"MX98373"}
 };
index 961df8d..75302e9 100644 (file)
@@ -12,7 +12,7 @@
 
 static struct skl_machine_pdata skl_dmic_data;
 
-static struct snd_soc_acpi_codecs skl_codecs = {
+static const struct snd_soc_acpi_codecs skl_codecs = {
        .num_codecs = 1,
        .codecs = {"10508825"}
 };
index 785d5f5..da31bb3 100644 (file)
@@ -156,6 +156,15 @@ static const struct snd_soc_acpi_adr_device rt711_sdca_0_adr[] = {
        }
 };
 
+static const struct snd_soc_acpi_adr_device rt1316_1_single_adr[] = {
+       {
+               .adr = 0x000131025D131601ull,
+               .num_endpoints = 1,
+               .endpoints = &single_endpoint,
+               .name_prefix = "rt1316-1"
+       }
+};
+
 static const struct snd_soc_acpi_adr_device rt1316_1_group1_adr[] = {
        {
                .adr = 0x000131025D131601ull, /* unique ID is set for some reason */
@@ -320,6 +329,25 @@ static const struct snd_soc_acpi_link_adr tgl_3_in_1_sdca[] = {
        {}
 };
 
+static const struct snd_soc_acpi_link_adr tgl_3_in_1_sdca_mono[] = {
+       {
+               .mask = BIT(0),
+               .num_adr = ARRAY_SIZE(rt711_sdca_0_adr),
+               .adr_d = rt711_sdca_0_adr,
+       },
+       {
+               .mask = BIT(1),
+               .num_adr = ARRAY_SIZE(rt1316_1_single_adr),
+               .adr_d = rt1316_1_single_adr,
+       },
+       {
+               .mask = BIT(3),
+               .num_adr = ARRAY_SIZE(rt714_3_adr),
+               .adr_d = rt714_3_adr,
+       },
+       {}
+};
+
 static const struct snd_soc_acpi_codecs tgl_max98373_amp = {
        .num_codecs = 1,
        .codecs = {"MX98373"}
@@ -330,17 +358,22 @@ static const struct snd_soc_acpi_codecs tgl_rt1011_amp = {
        .codecs = {"10EC1011"}
 };
 
+static const struct snd_soc_acpi_codecs tgl_rt5682_rt5682s_hp = {
+       .num_codecs = 2,
+       .codecs = {"10EC5682", "RTL5682"},
+};
+
 struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[] = {
        {
-               .id = "10EC5682",
-               .drv_name = "tgl_mx98357a_rt5682",
+               .comp_ids = &tgl_rt5682_rt5682s_hp,
+               .drv_name = "tgl_mx98357_rt5682",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &tgl_codecs,
                .sof_fw_filename = "sof-tgl.ri",
                .sof_tplg_filename = "sof-tgl-max98357a-rt5682.tplg",
        },
        {
-               .id = "10EC5682",
+               .comp_ids = &tgl_rt5682_rt5682s_hp,
                .drv_name = "tgl_mx98373_rt5682",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &tgl_max98373_amp,
@@ -348,13 +381,19 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_machines[] = {
                .sof_tplg_filename = "sof-tgl-max98373-rt5682.tplg",
        },
        {
-               .id = "10EC5682",
+               .comp_ids = &tgl_rt5682_rt5682s_hp,
                .drv_name = "tgl_rt1011_rt5682",
                .machine_quirk = snd_soc_acpi_codec_list,
                .quirk_data = &tgl_rt1011_amp,
                .sof_fw_filename = "sof-tgl.ri",
                .sof_tplg_filename = "sof-tgl-rt1011-rt5682.tplg",
        },
+       {
+               .id = "ESSX8336",
+               .drv_name = "sof-essx8336",
+               .sof_fw_filename = "sof-tgl.ri",
+               .sof_tplg_filename = "sof-tgl-es8336.tplg",
+       },
        {},
 };
 EXPORT_SYMBOL_GPL(snd_soc_acpi_intel_tgl_machines);
@@ -412,6 +451,19 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_tgl_sdw_machines[] = {
                .drv_name = "sof_sdw",
                .sof_tplg_filename = "sof-tgl-rt711-rt1316-rt714.tplg",
        },
+       {
+               /*
+                * link_mask should be 0xB, but all links are enabled by BIOS.
+                * This entry will be selected if there is no rt1316 amplifier exposed
+                * on link2 since it will fail to match the above entry.
+                */
+
+               .link_mask = 0xF, /* 4 active links required */
+               .links = tgl_3_in_1_sdca_mono,
+               .drv_name = "sof_sdw",
+               .sof_tplg_filename = "sof-tgl-rt711-l0-rt1316-l1-mono-rt714-l3.tplg",
+       },
+
        {
                .link_mask = 0x3, /* rt711 on link 0 and 1 rt1308 on link 1 */
                .links = tgl_hp,
index b036852..89e4231 100644 (file)
@@ -3637,7 +3637,7 @@ static int skl_manifest_load(struct snd_soc_component *cmpnt, int index,
        return 0;
 }
 
-static void skl_tplg_complete(struct snd_soc_component *component)
+static int skl_tplg_complete(struct snd_soc_component *component)
 {
        struct snd_soc_dobj *dobj;
        struct snd_soc_acpi_mach *mach;
@@ -3646,7 +3646,7 @@ static void skl_tplg_complete(struct snd_soc_component *component)
 
        val = kmalloc(sizeof(*val), GFP_KERNEL);
        if (!val)
-               return;
+               return -ENOMEM;
 
        mach = dev_get_platdata(component->card->dev);
        list_for_each_entry(dobj, &component->dobj_list, list) {
@@ -3671,7 +3671,9 @@ static void skl_tplg_complete(struct snd_soc_component *component)
                        }
                }
        }
+
        kfree(val);
+       return 0;
 }
 
 static struct snd_soc_tplg_ops skl_tplg_ops  = {
index 81ad2dc..3b1ddea 100644 (file)
@@ -120,7 +120,7 @@ config SND_SOC_MT8183
 
 config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A
        tristate "ASoC Audio driver for MT8183 with MT6358 TS3A227E MAX98357A RT1015 codec"
-       depends on I2C
+       depends on I2C && GPIOLIB
        depends on SND_SOC_MT8183
        select SND_SOC_MT6358
        select SND_SOC_MAX98357A
@@ -138,7 +138,7 @@ config SND_SOC_MT8183_MT6358_TS3A227E_MAX98357A
 
 config SND_SOC_MT8183_DA7219_MAX98357A
        tristate "ASoC Audio driver for MT8183 with DA7219 MAX98357A RT1015 codec"
-       depends on SND_SOC_MT8183 && I2C
+       depends on SND_SOC_MT8183 && I2C && GPIOLIB
        select SND_SOC_MT6358
        select SND_SOC_MAX98357A
        select SND_SOC_RT1015
@@ -173,7 +173,7 @@ config SND_SOC_MT8192
 
 config SND_SOC_MT8192_MT6359_RT1015_RT5682
        tristate "ASoC Audio driver for MT8192 with MT6359 RT1015 RT5682 codec"
-       depends on I2C
+       depends on I2C && GPIOLIB
        depends on SND_SOC_MT8192 && MTK_PMIC_WRAP
        select SND_SOC_MT6359
        select SND_SOC_RT1015
@@ -200,7 +200,7 @@ config SND_SOC_MT8195
 
 config SND_SOC_MT8195_MT6359_RT1019_RT5682
        tristate "ASoC Audio driver for MT8195 with MT6359 RT1019 RT5682 codec"
-       depends on I2C
+       depends on I2C && GPIOLIB
        depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
        select SND_SOC_MT6359
        select SND_SOC_RT1015P
@@ -212,3 +212,18 @@ config SND_SOC_MT8195_MT6359_RT1019_RT5682
          with the MT6359 RT1019 RT5682 audio codec.
          Select Y if you have such device.
          If unsure select "N".
+
+config SND_SOC_MT8195_MT6359_RT1011_RT5682
+       tristate "ASoC Audio driver for MT8195 with MT6359 RT1011 RT5682 codec"
+       depends on I2C
+       depends on SND_SOC_MT8195 && MTK_PMIC_WRAP
+       select SND_SOC_MT6359
+       select SND_SOC_RT1011
+       select SND_SOC_RT5682_I2C
+       select SND_SOC_DMIC
+       select SND_SOC_HDMI_CODEC
+       help
+         This adds ASoC driver for Mediatek MT8195 boards
+         with the MT6359 RT1011 RT5682 audio codec.
+         Select Y if you have such device.
+         If unsure select "N".
index e95c7c0..395be97 100644 (file)
@@ -288,7 +288,6 @@ const struct snd_soc_dai_ops mtk_afe_fe_ops = {
 };
 EXPORT_SYMBOL_GPL(mtk_afe_fe_ops);
 
-static DEFINE_MUTEX(irqs_lock);
 int mtk_dynamic_irq_acquire(struct mtk_base_afe *afe)
 {
        int i;
@@ -351,7 +350,7 @@ int mtk_afe_resume(struct snd_soc_component *component)
        struct mtk_base_afe *afe = snd_soc_component_get_drvdata(component);
        struct device *dev = afe->dev;
        struct regmap *regmap = afe->regmap;
-       int i = 0;
+       int i;
 
        if (pm_runtime_status_suspended(dev) || !afe->suspended)
                return 0;
index 44a8d5c..d9fd6eb 100644 (file)
@@ -146,7 +146,7 @@ static int mt2701_cs42448_be_ops_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops mt2701_cs42448_be_ops = {
+static const struct snd_soc_ops mt2701_cs42448_be_ops = {
        .hw_params = mt2701_cs42448_be_ops_hw_params
 };
 
index 414e422..f56de1b 100644 (file)
@@ -40,7 +40,7 @@ static int mt2701_wm8960_be_ops_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops mt2701_wm8960_be_ops = {
+static const struct snd_soc_ops mt2701_wm8960_be_ops = {
        .hw_params = mt2701_wm8960_be_ops_hw_params
 };
 
index 94dcbd3..aeb1af8 100644 (file)
@@ -335,7 +335,7 @@ static void mt8183_mt6358_tdm_shutdown(struct snd_pcm_substream *substream)
                        __func__, ret);
 }
 
-static struct snd_soc_ops mt8183_mt6358_tdm_ops = {
+static const struct snd_soc_ops mt8183_mt6358_tdm_ops = {
        .startup = mt8183_mt6358_tdm_startup,
        .shutdown = mt8183_mt6358_tdm_shutdown,
 };
index 44775f4..e5f0df5 100644 (file)
@@ -13,3 +13,4 @@ obj-$(CONFIG_SND_SOC_MT8195) += snd-soc-mt8195-afe.o
 
 # machine driver
 obj-$(CONFIG_SND_SOC_MT8195_MT6359_RT1019_RT5682) += mt8195-mt6359-rt1019-rt5682.o
+obj-$(CONFIG_SND_SOC_MT8195_MT6359_RT1011_RT5682) += mt8195-mt6359-rt1011-rt5682.o
index 6635c3f..2bb05a8 100644 (file)
@@ -2232,7 +2232,7 @@ static const struct mtk_base_memif_data memif_data[MT8195_AFE_MEMIF_NUM] = {
        },
 };
 
-static const struct mtk_base_irq_data irq_data[MT8195_AFE_IRQ_NUM] = {
+static const struct mtk_base_irq_data irq_data_array[MT8195_AFE_IRQ_NUM] = {
        [MT8195_AFE_IRQ_1] = {
                .id = MT8195_AFE_IRQ_1,
                .irq_cnt_reg = -1,
@@ -3057,7 +3057,6 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
 {
        struct mtk_base_afe *afe;
        struct mt8195_afe_private *afe_priv;
-       struct resource *res;
        struct device *dev = &pdev->dev;
        int i, irq_id, ret;
        struct snd_soc_component *component;
@@ -3078,8 +3077,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
        afe_priv = afe->platform_priv;
        afe->dev = &pdev->dev;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       afe->base_addr = devm_ioremap_resource(&pdev->dev, res);
+       afe->base_addr = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(afe->base_addr))
                return PTR_ERR(afe->base_addr);
 
@@ -3102,7 +3100,7 @@ static int mt8195_afe_pcm_dev_probe(struct platform_device *pdev)
                return -ENOMEM;
 
        for (i = 0; i < afe->irqs_size; i++)
-               afe->irqs[i].irq_data = &irq_data[i];
+               afe->irqs[i].irq_data = &irq_data_array[i];
 
        /* init memif */
        afe->memif_size = MT8195_AFE_MEMIF_NUM;
@@ -3266,9 +3264,7 @@ static struct platform_driver mt8195_afe_pcm_driver = {
        .driver = {
                   .name = "mt8195-audio",
                   .of_match_table = mt8195_afe_pcm_dt_match,
-#ifdef CONFIG_PM
                   .pm = &mt8195_afe_pm_ops,
-#endif
        },
        .probe = mt8195_afe_pcm_dev_probe,
        .remove = mt8195_afe_pcm_dev_remove,
index 740aa6d..e0670e0 100644 (file)
@@ -59,93 +59,93 @@ struct afe_gate {
 
 static const struct afe_gate aud_clks[CLK_AUD_NR_CLK] = {
        /* AUD0 */
-       GATE_AUD0(CLK_AUD_AFE, "aud_afe", "a1sys_hp_sel", 2),
-       GATE_AUD0(CLK_AUD_LRCK_CNT, "aud_lrck_cnt", "a1sys_hp_sel", 4),
-       GATE_AUD0(CLK_AUD_SPDIFIN_TUNER_APLL, "aud_spdifin_tuner_apll", "apll4_sel", 10),
-       GATE_AUD0(CLK_AUD_SPDIFIN_TUNER_DBG, "aud_spdifin_tuner_dbg", "apll4_sel", 11),
-       GATE_AUD0(CLK_AUD_UL_TML, "aud_ul_tml", "a1sys_hp_sel", 18),
-       GATE_AUD0(CLK_AUD_APLL1_TUNER, "aud_apll1_tuner", "apll1_sel", 19),
-       GATE_AUD0(CLK_AUD_APLL2_TUNER, "aud_apll2_tuner", "apll2_sel", 20),
-       GATE_AUD0(CLK_AUD_TOP0_SPDF, "aud_top0_spdf", "aud_iec_sel", 21),
-       GATE_AUD0(CLK_AUD_APLL, "aud_apll", "apll1_sel", 23),
-       GATE_AUD0(CLK_AUD_APLL2, "aud_apll2", "apll2_sel", 24),
-       GATE_AUD0(CLK_AUD_DAC, "aud_dac", "a1sys_hp_sel", 25),
-       GATE_AUD0(CLK_AUD_DAC_PREDIS, "aud_dac_predis", "a1sys_hp_sel", 26),
-       GATE_AUD0(CLK_AUD_TML, "aud_tml", "a1sys_hp_sel", 27),
-       GATE_AUD0(CLK_AUD_ADC, "aud_adc", "a1sys_hp_sel", 28),
-       GATE_AUD0(CLK_AUD_DAC_HIRES, "aud_dac_hires", "audio_h_sel", 31),
+       GATE_AUD0(CLK_AUD_AFE, "aud_afe", "top_a1sys_hp", 2),
+       GATE_AUD0(CLK_AUD_LRCK_CNT, "aud_lrck_cnt", "top_a1sys_hp", 4),
+       GATE_AUD0(CLK_AUD_SPDIFIN_TUNER_APLL, "aud_spdifin_tuner_apll", "top_apll4", 10),
+       GATE_AUD0(CLK_AUD_SPDIFIN_TUNER_DBG, "aud_spdifin_tuner_dbg", "top_apll4", 11),
+       GATE_AUD0(CLK_AUD_UL_TML, "aud_ul_tml", "top_a1sys_hp", 18),
+       GATE_AUD0(CLK_AUD_APLL1_TUNER, "aud_apll1_tuner", "top_apll1", 19),
+       GATE_AUD0(CLK_AUD_APLL2_TUNER, "aud_apll2_tuner", "top_apll2", 20),
+       GATE_AUD0(CLK_AUD_TOP0_SPDF, "aud_top0_spdf", "top_aud_iec_clk", 21),
+       GATE_AUD0(CLK_AUD_APLL, "aud_apll", "top_apll1", 23),
+       GATE_AUD0(CLK_AUD_APLL2, "aud_apll2", "top_apll2", 24),
+       GATE_AUD0(CLK_AUD_DAC, "aud_dac", "top_a1sys_hp", 25),
+       GATE_AUD0(CLK_AUD_DAC_PREDIS, "aud_dac_predis", "top_a1sys_hp", 26),
+       GATE_AUD0(CLK_AUD_TML, "aud_tml", "top_a1sys_hp", 27),
+       GATE_AUD0(CLK_AUD_ADC, "aud_adc", "top_a1sys_hp", 28),
+       GATE_AUD0(CLK_AUD_DAC_HIRES, "aud_dac_hires", "top_audio_h", 31),
 
        /* AUD1 */
-       GATE_AUD1(CLK_AUD_A1SYS_HP, "aud_a1sys_hp", "a1sys_hp_sel", 2),
-       GATE_AUD1(CLK_AUD_AFE_DMIC1, "aud_afe_dmic1", "a1sys_hp_sel", 10),
-       GATE_AUD1(CLK_AUD_AFE_DMIC2, "aud_afe_dmic2", "a1sys_hp_sel", 11),
-       GATE_AUD1(CLK_AUD_AFE_DMIC3, "aud_afe_dmic3", "a1sys_hp_sel", 12),
-       GATE_AUD1(CLK_AUD_AFE_DMIC4, "aud_afe_dmic4", "a1sys_hp_sel", 13),
-       GATE_AUD1(CLK_AUD_AFE_26M_DMIC_TM, "aud_afe_26m_dmic_tm", "a1sys_hp_sel", 14),
-       GATE_AUD1(CLK_AUD_UL_TML_HIRES, "aud_ul_tml_hires", "audio_h_sel", 16),
-       GATE_AUD1(CLK_AUD_ADC_HIRES, "aud_adc_hires", "audio_h_sel", 17),
-       GATE_AUD1(CLK_AUD_ADDA6_ADC, "aud_adda6_adc", "a1sys_hp_sel", 18),
-       GATE_AUD1(CLK_AUD_ADDA6_ADC_HIRES, "aud_adda6_adc_hires", "audio_h_sel", 19),
+       GATE_AUD1(CLK_AUD_A1SYS_HP, "aud_a1sys_hp", "top_a1sys_hp", 2),
+       GATE_AUD1(CLK_AUD_AFE_DMIC1, "aud_afe_dmic1", "top_a1sys_hp", 10),
+       GATE_AUD1(CLK_AUD_AFE_DMIC2, "aud_afe_dmic2", "top_a1sys_hp", 11),
+       GATE_AUD1(CLK_AUD_AFE_DMIC3, "aud_afe_dmic3", "top_a1sys_hp", 12),
+       GATE_AUD1(CLK_AUD_AFE_DMIC4, "aud_afe_dmic4", "top_a1sys_hp", 13),
+       GATE_AUD1(CLK_AUD_AFE_26M_DMIC_TM, "aud_afe_26m_dmic_tm", "top_a1sys_hp", 14),
+       GATE_AUD1(CLK_AUD_UL_TML_HIRES, "aud_ul_tml_hires", "top_audio_h", 16),
+       GATE_AUD1(CLK_AUD_ADC_HIRES, "aud_adc_hires", "top_audio_h", 17),
+       GATE_AUD1(CLK_AUD_ADDA6_ADC, "aud_adda6_adc", "top_a1sys_hp", 18),
+       GATE_AUD1(CLK_AUD_ADDA6_ADC_HIRES, "aud_adda6_adc_hires", "top_audio_h", 19),
 
        /* AUD3 */
-       GATE_AUD3(CLK_AUD_LINEIN_TUNER, "aud_linein_tuner", "apll5_sel", 5),
-       GATE_AUD3(CLK_AUD_EARC_TUNER, "aud_earc_tuner", "apll3_sel", 7),
+       GATE_AUD3(CLK_AUD_LINEIN_TUNER, "aud_linein_tuner", "top_apll5", 5),
+       GATE_AUD3(CLK_AUD_EARC_TUNER, "aud_earc_tuner", "top_apll3", 7),
 
        /* AUD4 */
-       GATE_AUD4(CLK_AUD_I2SIN, "aud_i2sin", "a1sys_hp_sel", 0),
-       GATE_AUD4(CLK_AUD_TDM_IN, "aud_tdm_in", "a1sys_hp_sel", 1),
-       GATE_AUD4(CLK_AUD_I2S_OUT, "aud_i2s_out", "a1sys_hp_sel", 6),
-       GATE_AUD4(CLK_AUD_TDM_OUT, "aud_tdm_out", "a1sys_hp_sel", 7),
-       GATE_AUD4(CLK_AUD_HDMI_OUT, "aud_hdmi_out", "a1sys_hp_sel", 8),
-       GATE_AUD4(CLK_AUD_ASRC11, "aud_asrc11", "a1sys_hp_sel", 16),
-       GATE_AUD4(CLK_AUD_ASRC12, "aud_asrc12", "a1sys_hp_sel", 17),
+       GATE_AUD4(CLK_AUD_I2SIN, "aud_i2sin", "top_a1sys_hp", 0),
+       GATE_AUD4(CLK_AUD_TDM_IN, "aud_tdm_in", "top_a1sys_hp", 1),
+       GATE_AUD4(CLK_AUD_I2S_OUT, "aud_i2s_out", "top_a1sys_hp", 6),
+       GATE_AUD4(CLK_AUD_TDM_OUT, "aud_tdm_out", "top_a1sys_hp", 7),
+       GATE_AUD4(CLK_AUD_HDMI_OUT, "aud_hdmi_out", "top_a1sys_hp", 8),
+       GATE_AUD4(CLK_AUD_ASRC11, "aud_asrc11", "top_a1sys_hp", 16),
+       GATE_AUD4(CLK_AUD_ASRC12, "aud_asrc12", "top_a1sys_hp", 17),
        GATE_AUD4(CLK_AUD_MULTI_IN, "aud_multi_in", "mphone_slave_b", 19),
-       GATE_AUD4(CLK_AUD_INTDIR, "aud_intdir", "intdir_sel", 20),
-       GATE_AUD4(CLK_AUD_A1SYS, "aud_a1sys", "a1sys_hp_sel", 21),
-       GATE_AUD4(CLK_AUD_A2SYS, "aud_a2sys", "a2sys_sel", 22),
-       GATE_AUD4(CLK_AUD_PCMIF, "aud_pcmif", "a1sys_hp_sel", 24),
-       GATE_AUD4(CLK_AUD_A3SYS, "aud_a3sys", "a3sys_sel", 30),
-       GATE_AUD4(CLK_AUD_A4SYS, "aud_a4sys", "a4sys_sel", 31),
+       GATE_AUD4(CLK_AUD_INTDIR, "aud_intdir", "top_intdir", 20),
+       GATE_AUD4(CLK_AUD_A1SYS, "aud_a1sys", "top_a1sys_hp", 21),
+       GATE_AUD4(CLK_AUD_A2SYS, "aud_a2sys", "top_a2sys_hf", 22),
+       GATE_AUD4(CLK_AUD_PCMIF, "aud_pcmif", "top_a1sys_hp", 24),
+       GATE_AUD4(CLK_AUD_A3SYS, "aud_a3sys", "top_a3sys_hf", 30),
+       GATE_AUD4(CLK_AUD_A4SYS, "aud_a4sys", "top_a4sys_hf", 31),
 
        /* AUD5 */
-       GATE_AUD5(CLK_AUD_MEMIF_UL1, "aud_memif_ul1", "a1sys_hp_sel", 0),
-       GATE_AUD5(CLK_AUD_MEMIF_UL2, "aud_memif_ul2", "a1sys_hp_sel", 1),
-       GATE_AUD5(CLK_AUD_MEMIF_UL3, "aud_memif_ul3", "a1sys_hp_sel", 2),
-       GATE_AUD5(CLK_AUD_MEMIF_UL4, "aud_memif_ul4", "a1sys_hp_sel", 3),
-       GATE_AUD5(CLK_AUD_MEMIF_UL5, "aud_memif_ul5", "a1sys_hp_sel", 4),
-       GATE_AUD5(CLK_AUD_MEMIF_UL6, "aud_memif_ul6", "a1sys_hp_sel", 5),
-       GATE_AUD5(CLK_AUD_MEMIF_UL8, "aud_memif_ul8", "a1sys_hp_sel", 7),
-       GATE_AUD5(CLK_AUD_MEMIF_UL9, "aud_memif_ul9", "a1sys_hp_sel", 8),
-       GATE_AUD5(CLK_AUD_MEMIF_UL10, "aud_memif_ul10", "a1sys_hp_sel", 9),
-       GATE_AUD5(CLK_AUD_MEMIF_DL2, "aud_memif_dl2", "a1sys_hp_sel", 18),
-       GATE_AUD5(CLK_AUD_MEMIF_DL3, "aud_memif_dl3", "a1sys_hp_sel", 19),
-       GATE_AUD5(CLK_AUD_MEMIF_DL6, "aud_memif_dl6", "a1sys_hp_sel", 22),
-       GATE_AUD5(CLK_AUD_MEMIF_DL7, "aud_memif_dl7", "a1sys_hp_sel", 23),
-       GATE_AUD5(CLK_AUD_MEMIF_DL8, "aud_memif_dl8", "a1sys_hp_sel", 24),
-       GATE_AUD5(CLK_AUD_MEMIF_DL10, "aud_memif_dl10", "a1sys_hp_sel", 26),
-       GATE_AUD5(CLK_AUD_MEMIF_DL11, "aud_memif_dl11", "a1sys_hp_sel", 27),
+       GATE_AUD5(CLK_AUD_MEMIF_UL1, "aud_memif_ul1", "top_a1sys_hp", 0),
+       GATE_AUD5(CLK_AUD_MEMIF_UL2, "aud_memif_ul2", "top_a1sys_hp", 1),
+       GATE_AUD5(CLK_AUD_MEMIF_UL3, "aud_memif_ul3", "top_a1sys_hp", 2),
+       GATE_AUD5(CLK_AUD_MEMIF_UL4, "aud_memif_ul4", "top_a1sys_hp", 3),
+       GATE_AUD5(CLK_AUD_MEMIF_UL5, "aud_memif_ul5", "top_a1sys_hp", 4),
+       GATE_AUD5(CLK_AUD_MEMIF_UL6, "aud_memif_ul6", "top_a1sys_hp", 5),
+       GATE_AUD5(CLK_AUD_MEMIF_UL8, "aud_memif_ul8", "top_a1sys_hp", 7),
+       GATE_AUD5(CLK_AUD_MEMIF_UL9, "aud_memif_ul9", "top_a1sys_hp", 8),
+       GATE_AUD5(CLK_AUD_MEMIF_UL10, "aud_memif_ul10", "top_a1sys_hp", 9),
+       GATE_AUD5(CLK_AUD_MEMIF_DL2, "aud_memif_dl2", "top_a1sys_hp", 18),
+       GATE_AUD5(CLK_AUD_MEMIF_DL3, "aud_memif_dl3", "top_a1sys_hp", 19),
+       GATE_AUD5(CLK_AUD_MEMIF_DL6, "aud_memif_dl6", "top_a1sys_hp", 22),
+       GATE_AUD5(CLK_AUD_MEMIF_DL7, "aud_memif_dl7", "top_a1sys_hp", 23),
+       GATE_AUD5(CLK_AUD_MEMIF_DL8, "aud_memif_dl8", "top_a1sys_hp", 24),
+       GATE_AUD5(CLK_AUD_MEMIF_DL10, "aud_memif_dl10", "top_a1sys_hp", 26),
+       GATE_AUD5(CLK_AUD_MEMIF_DL11, "aud_memif_dl11", "top_a1sys_hp", 27),
 
        /* AUD6 */
-       GATE_AUD6(CLK_AUD_GASRC0, "aud_gasrc0", "asm_h_sel", 0),
-       GATE_AUD6(CLK_AUD_GASRC1, "aud_gasrc1", "asm_h_sel", 1),
-       GATE_AUD6(CLK_AUD_GASRC2, "aud_gasrc2", "asm_h_sel", 2),
-       GATE_AUD6(CLK_AUD_GASRC3, "aud_gasrc3", "asm_h_sel", 3),
-       GATE_AUD6(CLK_AUD_GASRC4, "aud_gasrc4", "asm_h_sel", 4),
-       GATE_AUD6(CLK_AUD_GASRC5, "aud_gasrc5", "asm_h_sel", 5),
-       GATE_AUD6(CLK_AUD_GASRC6, "aud_gasrc6", "asm_h_sel", 6),
-       GATE_AUD6(CLK_AUD_GASRC7, "aud_gasrc7", "asm_h_sel", 7),
-       GATE_AUD6(CLK_AUD_GASRC8, "aud_gasrc8", "asm_h_sel", 8),
-       GATE_AUD6(CLK_AUD_GASRC9, "aud_gasrc9", "asm_h_sel", 9),
-       GATE_AUD6(CLK_AUD_GASRC10, "aud_gasrc10", "asm_h_sel", 10),
-       GATE_AUD6(CLK_AUD_GASRC11, "aud_gasrc11", "asm_h_sel", 11),
-       GATE_AUD6(CLK_AUD_GASRC12, "aud_gasrc12", "asm_h_sel", 12),
-       GATE_AUD6(CLK_AUD_GASRC13, "aud_gasrc13", "asm_h_sel", 13),
-       GATE_AUD6(CLK_AUD_GASRC14, "aud_gasrc14", "asm_h_sel", 14),
-       GATE_AUD6(CLK_AUD_GASRC15, "aud_gasrc15", "asm_h_sel", 15),
-       GATE_AUD6(CLK_AUD_GASRC16, "aud_gasrc16", "asm_h_sel", 16),
-       GATE_AUD6(CLK_AUD_GASRC17, "aud_gasrc17", "asm_h_sel", 17),
-       GATE_AUD6(CLK_AUD_GASRC18, "aud_gasrc18", "asm_h_sel", 18),
-       GATE_AUD6(CLK_AUD_GASRC19, "aud_gasrc19", "asm_h_sel", 19),
+       GATE_AUD6(CLK_AUD_GASRC0, "aud_gasrc0", "top_asm_h", 0),
+       GATE_AUD6(CLK_AUD_GASRC1, "aud_gasrc1", "top_asm_h", 1),
+       GATE_AUD6(CLK_AUD_GASRC2, "aud_gasrc2", "top_asm_h", 2),
+       GATE_AUD6(CLK_AUD_GASRC3, "aud_gasrc3", "top_asm_h", 3),
+       GATE_AUD6(CLK_AUD_GASRC4, "aud_gasrc4", "top_asm_h", 4),
+       GATE_AUD6(CLK_AUD_GASRC5, "aud_gasrc5", "top_asm_h", 5),
+       GATE_AUD6(CLK_AUD_GASRC6, "aud_gasrc6", "top_asm_h", 6),
+       GATE_AUD6(CLK_AUD_GASRC7, "aud_gasrc7", "top_asm_h", 7),
+       GATE_AUD6(CLK_AUD_GASRC8, "aud_gasrc8", "top_asm_h", 8),
+       GATE_AUD6(CLK_AUD_GASRC9, "aud_gasrc9", "top_asm_h", 9),
+       GATE_AUD6(CLK_AUD_GASRC10, "aud_gasrc10", "top_asm_h", 10),
+       GATE_AUD6(CLK_AUD_GASRC11, "aud_gasrc11", "top_asm_h", 11),
+       GATE_AUD6(CLK_AUD_GASRC12, "aud_gasrc12", "top_asm_h", 12),
+       GATE_AUD6(CLK_AUD_GASRC13, "aud_gasrc13", "top_asm_h", 13),
+       GATE_AUD6(CLK_AUD_GASRC14, "aud_gasrc14", "top_asm_h", 14),
+       GATE_AUD6(CLK_AUD_GASRC15, "aud_gasrc15", "top_asm_h", 15),
+       GATE_AUD6(CLK_AUD_GASRC16, "aud_gasrc16", "top_asm_h", 16),
+       GATE_AUD6(CLK_AUD_GASRC17, "aud_gasrc17", "top_asm_h", 17),
+       GATE_AUD6(CLK_AUD_GASRC18, "aud_gasrc18", "top_asm_h", 18),
+       GATE_AUD6(CLK_AUD_GASRC19, "aud_gasrc19", "top_asm_h", 19),
 };
 
 int mt8195_audsys_clk_register(struct mtk_base_afe *afe)
index 878dec0..f04bd17 100644 (file)
@@ -788,9 +788,11 @@ static int init_adda_priv_data(struct mtk_base_afe *afe)
 {
        struct mt8195_afe_private *afe_priv = afe->platform_priv;
        struct mtk_dai_adda_priv *adda_priv;
-       int adda_dai_list[] = { MT8195_AFE_IO_DL_SRC,
-                               MT8195_AFE_IO_UL_SRC1,
-                               MT8195_AFE_IO_UL_SRC2};
+       static const int adda_dai_list[] = {
+               MT8195_AFE_IO_DL_SRC,
+               MT8195_AFE_IO_UL_SRC1,
+               MT8195_AFE_IO_UL_SRC2
+       };
        int i;
 
        for (i = 0; i < ARRAY_SIZE(adda_dai_list); i++) {
index 7378e42..c02c10d 100644 (file)
@@ -1316,7 +1316,7 @@ static int mt8195_afe_disable_etdm(struct mtk_base_afe *afe, int dai_id)
        }
 out:
        spin_unlock_irqrestore(&afe_priv->afe_ctrl_lock, flags);
-       return 0;
+       return ret;
 }
 
 static int etdm_cowork_slv_sel(int id, int slave_mode)
@@ -2094,7 +2094,7 @@ static int mtk_dai_etdm_set_sysclk(struct snd_soc_dai *dai,
 {
        struct mtk_base_afe *afe = snd_soc_dai_get_drvdata(dai);
        struct mt8195_afe_private *afe_priv = afe->platform_priv;
-       struct mtk_dai_etdm_priv *etdm_data = afe_priv->dai_priv[dai->id];
+       struct mtk_dai_etdm_priv *etdm_data;
        int dai_id;
 
        dev_dbg(dai->dev, "%s id %d freq %u, dir %d\n",
diff --git a/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1011-rt5682.c b/sound/soc/mediatek/mt8195/mt8195-mt6359-rt1011-rt5682.c
new file mode 100644 (file)
index 0000000..e103102
--- /dev/null
@@ -0,0 +1,1155 @@
+// SPDX-License-Identifier: GPL-2.0
+//
+// mt8195-mt6359-rt1011-rt5682.c  --
+//     MT8195-MT6359-RT1011-RT5682 ALSA SoC machine driver
+//
+// Copyright (c) 2021 MediaTek Inc.
+// Author: Trevor Wu <trevor.wu@mediatek.com>
+//
+
+#include <linux/input.h>
+#include <linux/module.h>
+#include <linux/pm_runtime.h>
+#include <sound/jack.h>
+#include <sound/pcm_params.h>
+#include <sound/rt5682.h>
+#include <sound/soc.h>
+#include "../../codecs/mt6359.h"
+#include "../../codecs/rt1011.h"
+#include "../../codecs/rt5682.h"
+#include "../common/mtk-afe-platform-driver.h"
+#include "mt8195-afe-common.h"
+
+#define RT1011_CODEC_DAI       "rt1011-aif"
+#define RT1011_DEV0_NAME       "rt1011.2-0038"
+#define RT1011_DEV1_NAME       "rt1011.2-0039"
+
+#define RT5682_CODEC_DAI       "rt5682-aif1"
+#define RT5682_DEV0_NAME       "rt5682.2-001a"
+
+struct mt8195_mt6359_rt1011_rt5682_priv {
+       struct device_node *platform_node;
+       struct device_node *hdmi_node;
+       struct device_node *dp_node;
+       struct snd_soc_jack headset_jack;
+       struct snd_soc_jack dp_jack;
+       struct snd_soc_jack hdmi_jack;
+};
+
+static const struct snd_soc_dapm_widget
+mt8195_mt6359_rt1011_rt5682_widgets[] = {
+       SND_SOC_DAPM_SPK("Left Speaker", NULL),
+       SND_SOC_DAPM_SPK("Right Speaker", NULL),
+       SND_SOC_DAPM_HP("Headphone Jack", NULL),
+       SND_SOC_DAPM_MIC("Headset Mic", NULL),
+};
+
+static const struct snd_soc_dapm_route mt8195_mt6359_rt1011_rt5682_routes[] = {
+       /* speaker */
+       { "Left Speaker", NULL, "Left SPO" },
+       { "Right Speaker", NULL, "Right SPO" },
+       /* headset */
+       { "Headphone Jack", NULL, "HPOL" },
+       { "Headphone Jack", NULL, "HPOR" },
+       { "IN1P", NULL, "Headset Mic" },
+};
+
+static const struct snd_kcontrol_new mt8195_mt6359_rt1011_rt5682_controls[] = {
+       SOC_DAPM_PIN_SWITCH("Left Speaker"),
+       SOC_DAPM_PIN_SWITCH("Right Speaker"),
+       SOC_DAPM_PIN_SWITCH("Headphone Jack"),
+       SOC_DAPM_PIN_SWITCH("Headset Mic"),
+};
+
+static int mt8195_rt5682_etdm_hw_params(struct snd_pcm_substream *substream,
+                                       struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_card *card = rtd->card;
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       unsigned int rate = params_rate(params);
+       int bitwidth;
+       int ret;
+
+       bitwidth = snd_pcm_format_width(params_format(params));
+       if (bitwidth < 0) {
+               dev_err(card->dev, "invalid bit width: %d\n", bitwidth);
+               return bitwidth;
+       }
+
+       ret = snd_soc_dai_set_tdm_slot(codec_dai, 0x00, 0x0, 0x2, bitwidth);
+       if (ret) {
+               dev_err(card->dev, "failed to set tdm slot\n");
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_pll(codec_dai, RT5682_PLL1, RT5682_PLL1_S_BCLK1,
+                                 rate * 64, rate * 512);
+       if (ret) {
+               dev_err(card->dev, "failed to set pll\n");
+               return ret;
+       }
+
+       ret = snd_soc_dai_set_sysclk(codec_dai, RT5682_SCLK_S_PLL1,
+                                    rate * 512, SND_SOC_CLOCK_IN);
+       if (ret) {
+               dev_err(card->dev, "failed to set sysclk\n");
+               return ret;
+       }
+
+       return snd_soc_dai_set_sysclk(cpu_dai, 0, rate * 128,
+                                     SND_SOC_CLOCK_OUT);
+}
+
+static const struct snd_soc_ops mt8195_rt5682_etdm_ops = {
+       .hw_params = mt8195_rt5682_etdm_hw_params,
+};
+
+static int mt8195_rt1011_etdm_hw_params(struct snd_pcm_substream *substream,
+                                       struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_soc_dai *codec_dai;
+       struct snd_soc_card *card = rtd->card;
+       int srate, i, ret = 0;
+
+       srate = params_rate(params);
+
+       for_each_rtd_codec_dais(rtd, i, codec_dai) {
+               ret = snd_soc_dai_set_pll(codec_dai, 0, RT1011_PLL1_S_BCLK,
+                                         64 * srate, 256 * srate);
+               if (ret < 0) {
+                       dev_err(card->dev, "codec_dai clock not set\n");
+                       return ret;
+               }
+
+               ret = snd_soc_dai_set_sysclk(codec_dai,
+                                            RT1011_FS_SYS_PRE_S_PLL1,
+                                            256 * srate, SND_SOC_CLOCK_IN);
+               if (ret < 0) {
+                       dev_err(card->dev, "codec_dai clock not set\n");
+                       return ret;
+               }
+       }
+       return ret;
+}
+
+static const struct snd_soc_ops mt8195_rt1011_etdm_ops = {
+       .hw_params = mt8195_rt1011_etdm_hw_params,
+};
+
+#define CKSYS_AUD_TOP_CFG 0x032c
+#define CKSYS_AUD_TOP_MON 0x0330
+
+static int mt8195_mt6359_mtkaif_calibration(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_component *cmpnt_afe =
+               snd_soc_rtdcom_lookup(rtd, AFE_PCM_NAME);
+       struct snd_soc_component *cmpnt_codec =
+               asoc_rtd_to_codec(rtd, 0)->component;
+       struct mtk_base_afe *afe = snd_soc_component_get_drvdata(cmpnt_afe);
+       struct mt8195_afe_private *afe_priv = afe->platform_priv;
+       struct mtkaif_param *param = &afe_priv->mtkaif_params;
+       int chosen_phase_1, chosen_phase_2, chosen_phase_3;
+       int prev_cycle_1, prev_cycle_2, prev_cycle_3;
+       int test_done_1, test_done_2, test_done_3;
+       int cycle_1, cycle_2, cycle_3;
+       int mtkaif_chosen_phase[MT8195_MTKAIF_MISO_NUM];
+       int mtkaif_phase_cycle[MT8195_MTKAIF_MISO_NUM];
+       int mtkaif_calibration_num_phase;
+       bool mtkaif_calibration_ok;
+       unsigned int monitor;
+       int counter;
+       int phase;
+       int i;
+
+       dev_dbg(afe->dev, "%s(), start\n", __func__);
+
+       param->mtkaif_calibration_ok = false;
+       for (i = 0; i < MT8195_MTKAIF_MISO_NUM; i++) {
+               param->mtkaif_chosen_phase[i] = -1;
+               param->mtkaif_phase_cycle[i] = 0;
+               mtkaif_chosen_phase[i] = -1;
+               mtkaif_phase_cycle[i] = 0;
+       }
+
+       if (IS_ERR(afe_priv->topckgen)) {
+               dev_info(afe->dev, "%s() Cannot find topckgen controller\n",
+                        __func__);
+               return 0;
+       }
+
+       pm_runtime_get_sync(afe->dev);
+       mt6359_mtkaif_calibration_enable(cmpnt_codec);
+
+       /* set test type to synchronizer pulse */
+       regmap_update_bits(afe_priv->topckgen,
+                          CKSYS_AUD_TOP_CFG, 0xffff, 0x4);
+       mtkaif_calibration_num_phase = 42;      /* mt6359: 0 ~ 42 */
+       mtkaif_calibration_ok = true;
+
+       for (phase = 0;
+            phase <= mtkaif_calibration_num_phase && mtkaif_calibration_ok;
+            phase++) {
+               mt6359_set_mtkaif_calibration_phase(cmpnt_codec,
+                                                   phase, phase, phase);
+
+               regmap_update_bits(afe_priv->topckgen,
+                                  CKSYS_AUD_TOP_CFG, 0x1, 0x1);
+
+               test_done_1 = 0;
+               test_done_2 = 0;
+               test_done_3 = 0;
+               cycle_1 = -1;
+               cycle_2 = -1;
+               cycle_3 = -1;
+               counter = 0;
+               while (!(test_done_1 & test_done_2 & test_done_3)) {
+                       regmap_read(afe_priv->topckgen,
+                                   CKSYS_AUD_TOP_MON, &monitor);
+                       test_done_1 = (monitor >> 28) & 0x1;
+                       test_done_2 = (monitor >> 29) & 0x1;
+                       test_done_3 = (monitor >> 30) & 0x1;
+                       if (test_done_1 == 1)
+                               cycle_1 = monitor & 0xf;
+
+                       if (test_done_2 == 1)
+                               cycle_2 = (monitor >> 4) & 0xf;
+
+                       if (test_done_3 == 1)
+                               cycle_3 = (monitor >> 8) & 0xf;
+
+                       /* handle if never test done */
+                       if (++counter > 10000) {
+                               dev_info(afe->dev, "%s(), test fail, cycle_1 %d, cycle_2 %d, cycle_3 %d, monitor 0x%x\n",
+                                        __func__,
+                                        cycle_1, cycle_2, cycle_3, monitor);
+                               mtkaif_calibration_ok = false;
+                               break;
+                       }
+               }
+
+               if (phase == 0) {
+                       prev_cycle_1 = cycle_1;
+                       prev_cycle_2 = cycle_2;
+                       prev_cycle_3 = cycle_3;
+               }
+
+               if (cycle_1 != prev_cycle_1 &&
+                   mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0] < 0) {
+                       mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0] = phase - 1;
+                       mtkaif_phase_cycle[MT8195_MTKAIF_MISO_0] = prev_cycle_1;
+               }
+
+               if (cycle_2 != prev_cycle_2 &&
+                   mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1] < 0) {
+                       mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1] = phase - 1;
+                       mtkaif_phase_cycle[MT8195_MTKAIF_MISO_1] = prev_cycle_2;
+               }
+
+               if (cycle_3 != prev_cycle_3 &&
+                   mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2] < 0) {
+                       mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2] = phase - 1;
+                       mtkaif_phase_cycle[MT8195_MTKAIF_MISO_2] = prev_cycle_3;
+               }
+
+               regmap_update_bits(afe_priv->topckgen,
+                                  CKSYS_AUD_TOP_CFG, 0x1, 0x0);
+
+               if (mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0] >= 0 &&
+                   mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1] >= 0 &&
+                   mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2] >= 0)
+                       break;
+       }
+
+       if (mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0] < 0) {
+               mtkaif_calibration_ok = false;
+               chosen_phase_1 = 0;
+       } else {
+               chosen_phase_1 = mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0];
+       }
+
+       if (mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1] < 0) {
+               mtkaif_calibration_ok = false;
+               chosen_phase_2 = 0;
+       } else {
+               chosen_phase_2 = mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1];
+       }
+
+       if (mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2] < 0) {
+               mtkaif_calibration_ok = false;
+               chosen_phase_3 = 0;
+       } else {
+               chosen_phase_3 = mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2];
+       }
+
+       mt6359_set_mtkaif_calibration_phase(cmpnt_codec,
+                                           chosen_phase_1,
+                                           chosen_phase_2,
+                                           chosen_phase_3);
+
+       mt6359_mtkaif_calibration_disable(cmpnt_codec);
+       pm_runtime_put(afe->dev);
+
+       param->mtkaif_calibration_ok = mtkaif_calibration_ok;
+       param->mtkaif_chosen_phase[MT8195_MTKAIF_MISO_0] = chosen_phase_1;
+       param->mtkaif_chosen_phase[MT8195_MTKAIF_MISO_1] = chosen_phase_2;
+       param->mtkaif_chosen_phase[MT8195_MTKAIF_MISO_2] = chosen_phase_3;
+       for (i = 0; i < MT8195_MTKAIF_MISO_NUM; i++)
+               param->mtkaif_phase_cycle[i] = mtkaif_phase_cycle[i];
+
+       dev_info(afe->dev, "%s(), end, calibration ok %d\n",
+                __func__, param->mtkaif_calibration_ok);
+
+       return 0;
+}
+
+static int mt8195_mt6359_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_component *cmpnt_codec =
+               asoc_rtd_to_codec(rtd, 0)->component;
+
+       /* set mtkaif protocol */
+       mt6359_set_mtkaif_protocol(cmpnt_codec,
+                                  MT6359_MTKAIF_PROTOCOL_2_CLK_P2);
+
+       /* mtkaif calibration */
+       mt8195_mt6359_mtkaif_calibration(rtd);
+
+       return 0;
+}
+
+static int mt8195_rt5682_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct snd_soc_component *cmpnt_codec =
+               asoc_rtd_to_codec(rtd, 0)->component;
+       struct mt8195_mt6359_rt1011_rt5682_priv *priv =
+               snd_soc_card_get_drvdata(rtd->card);
+       struct snd_soc_jack *jack = &priv->headset_jack;
+       int ret;
+
+       ret = snd_soc_card_jack_new(rtd->card, "Headset Jack",
+                                   SND_JACK_HEADSET | SND_JACK_BTN_0 |
+                                   SND_JACK_BTN_1 | SND_JACK_BTN_2 |
+                                   SND_JACK_BTN_3,
+                                   jack, NULL, 0);
+       if (ret) {
+               dev_err(rtd->dev, "Headset Jack creation failed: %d\n", ret);
+               return ret;
+       }
+
+       snd_jack_set_key(jack->jack, SND_JACK_BTN_0, KEY_PLAYPAUSE);
+       snd_jack_set_key(jack->jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
+       snd_jack_set_key(jack->jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
+       snd_jack_set_key(jack->jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
+
+       ret = snd_soc_component_set_jack(cmpnt_codec, jack, NULL);
+       if (ret) {
+               dev_err(rtd->dev, "Headset Jack set failed: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+};
+
+static int mt8195_etdm_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
+                                      struct snd_pcm_hw_params *params)
+{
+       /* fix BE i2s format to 32bit, clean param mask first */
+       snd_mask_reset_range(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT),
+                            0, (__force unsigned int)SNDRV_PCM_FORMAT_LAST);
+
+       params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
+
+       return 0;
+}
+
+static int mt8195_hdmitx_dptx_startup(struct snd_pcm_substream *substream)
+{
+       static const unsigned int rates[] = {
+               48000
+       };
+       static const unsigned int channels[] = {
+               2, 4, 6, 8
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_rates = {
+               .count = ARRAY_SIZE(rates),
+               .list  = rates,
+               .mask = 0,
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_channels = {
+               .count = ARRAY_SIZE(channels),
+               .list  = channels,
+               .mask = 0,
+       };
+
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       int ret;
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_RATE,
+                                        &constraints_rates);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list rate failed\n");
+               return ret;
+       }
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_CHANNELS,
+                                        &constraints_channels);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list channel failed\n");
+               return ret;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_ops mt8195_hdmitx_dptx_playback_ops = {
+       .startup = mt8195_hdmitx_dptx_startup,
+};
+
+static int mt8195_dptx_hw_params(struct snd_pcm_substream *substream,
+                                struct snd_pcm_hw_params *params)
+{
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
+
+       return snd_soc_dai_set_sysclk(cpu_dai, 0, params_rate(params) * 256,
+                                     SND_SOC_CLOCK_OUT);
+}
+
+static struct snd_soc_ops mt8195_dptx_ops = {
+       .hw_params = mt8195_dptx_hw_params,
+};
+
+static int mt8195_dptx_codec_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct mt8195_mt6359_rt1011_rt5682_priv *priv =
+               snd_soc_card_get_drvdata(rtd->card);
+       struct snd_soc_component *cmpnt_codec =
+               asoc_rtd_to_codec(rtd, 0)->component;
+       int ret;
+
+       ret = snd_soc_card_jack_new(rtd->card, "DP Jack", SND_JACK_LINEOUT,
+                                   &priv->dp_jack, NULL, 0);
+       if (ret)
+               return ret;
+
+       return snd_soc_component_set_jack(cmpnt_codec, &priv->dp_jack, NULL);
+}
+
+static int mt8195_hdmi_codec_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct mt8195_mt6359_rt1011_rt5682_priv *priv =
+               snd_soc_card_get_drvdata(rtd->card);
+       struct snd_soc_component *cmpnt_codec =
+               asoc_rtd_to_codec(rtd, 0)->component;
+       int ret;
+
+       ret = snd_soc_card_jack_new(rtd->card, "HDMI Jack", SND_JACK_LINEOUT,
+                                   &priv->hdmi_jack, NULL, 0);
+       if (ret)
+               return ret;
+
+       return snd_soc_component_set_jack(cmpnt_codec, &priv->hdmi_jack, NULL);
+}
+
+static int mt8195_dptx_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
+                                      struct snd_pcm_hw_params *params)
+
+{
+       /* fix BE i2s format to 32bit, clean param mask first */
+       snd_mask_reset_range(hw_param_mask(params, SNDRV_PCM_HW_PARAM_FORMAT),
+                            0, (__force unsigned int)SNDRV_PCM_FORMAT_LAST);
+
+       params_set_format(params, SNDRV_PCM_FORMAT_S24_LE);
+
+       return 0;
+}
+
+static int mt8195_playback_startup(struct snd_pcm_substream *substream)
+{
+       static const unsigned int rates[] = {
+               48000
+       };
+       static const unsigned int channels[] = {
+               2
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_rates = {
+               .count = ARRAY_SIZE(rates),
+               .list  = rates,
+               .mask = 0,
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_channels = {
+               .count = ARRAY_SIZE(channels),
+               .list  = channels,
+               .mask = 0,
+       };
+
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       int ret;
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_RATE,
+                                        &constraints_rates);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list rate failed\n");
+               return ret;
+       }
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_CHANNELS,
+                                        &constraints_channels);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list channel failed\n");
+               return ret;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_ops mt8195_playback_ops = {
+       .startup = mt8195_playback_startup,
+};
+
+static int mt8195_capture_startup(struct snd_pcm_substream *substream)
+{
+       static const unsigned int rates[] = {
+               48000
+       };
+       static const unsigned int channels[] = {
+               1, 2
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_rates = {
+               .count = ARRAY_SIZE(rates),
+               .list  = rates,
+               .mask = 0,
+       };
+       static const struct snd_pcm_hw_constraint_list constraints_channels = {
+               .count = ARRAY_SIZE(channels),
+               .list  = channels,
+               .mask = 0,
+       };
+
+       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       int ret;
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_RATE,
+                                        &constraints_rates);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list rate failed\n");
+               return ret;
+       }
+
+       ret = snd_pcm_hw_constraint_list(runtime, 0,
+                                        SNDRV_PCM_HW_PARAM_CHANNELS,
+                                        &constraints_channels);
+       if (ret < 0) {
+               dev_err(rtd->dev, "hw_constraint_list channel failed\n");
+               return ret;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_ops mt8195_capture_ops = {
+       .startup = mt8195_capture_startup,
+};
+
+enum {
+       DAI_LINK_DL2_FE,
+       DAI_LINK_DL3_FE,
+       DAI_LINK_DL6_FE,
+       DAI_LINK_DL7_FE,
+       DAI_LINK_DL8_FE,
+       DAI_LINK_DL10_FE,
+       DAI_LINK_DL11_FE,
+       DAI_LINK_UL1_FE,
+       DAI_LINK_UL2_FE,
+       DAI_LINK_UL3_FE,
+       DAI_LINK_UL4_FE,
+       DAI_LINK_UL5_FE,
+       DAI_LINK_UL6_FE,
+       DAI_LINK_UL8_FE,
+       DAI_LINK_UL9_FE,
+       DAI_LINK_UL10_FE,
+       DAI_LINK_DL_SRC_BE,
+       DAI_LINK_DPTX_BE,
+       DAI_LINK_ETDM1_IN_BE,
+       DAI_LINK_ETDM2_IN_BE,
+       DAI_LINK_ETDM1_OUT_BE,
+       DAI_LINK_ETDM2_OUT_BE,
+       DAI_LINK_ETDM3_OUT_BE,
+       DAI_LINK_PCM1_BE,
+       DAI_LINK_UL_SRC1_BE,
+       DAI_LINK_UL_SRC2_BE,
+};
+
+/* FE */
+SND_SOC_DAILINK_DEFS(DL2_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL2")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL3_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL3")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL6_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL6")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL7_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL7")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL8_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL8")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL10_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL10")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DL11_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL11")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL1_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL1")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL2_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL2")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL3_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL3")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL4_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL4")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL5_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL5")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL6_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL6")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL8_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL8")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL9_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL9")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL10_FE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL10")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+/* BE */
+SND_SOC_DAILINK_DEFS(DL_SRC_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DL_SRC")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC("mt6359-sound",
+                                                  "mt6359-snd-codec-aif1")),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(DPTX_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("DPTX")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(ETDM1_IN_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("ETDM1_IN")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(ETDM2_IN_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("ETDM2_IN")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC(RT5682_DEV0_NAME,
+                                                  RT5682_CODEC_DAI)),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(ETDM1_OUT_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("ETDM1_OUT")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC(RT5682_DEV0_NAME,
+                                                  RT5682_CODEC_DAI)),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(ETDM2_OUT_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("ETDM2_OUT")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC(RT1011_DEV0_NAME,
+                                                  RT1011_CODEC_DAI),
+                                       COMP_CODEC(RT1011_DEV1_NAME,
+                                                  RT1011_CODEC_DAI)),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(ETDM3_OUT_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("ETDM3_OUT")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(PCM1_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("PCM1")),
+                    DAILINK_COMP_ARRAY(COMP_DUMMY()),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL_SRC1_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL_SRC1")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC("mt6359-sound",
+                                                  "mt6359-snd-codec-aif1"),
+                                       COMP_CODEC("dmic-codec",
+                                                  "dmic-hifi")),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+SND_SOC_DAILINK_DEFS(UL_SRC2_BE,
+                    DAILINK_COMP_ARRAY(COMP_CPU("UL_SRC2")),
+                    DAILINK_COMP_ARRAY(COMP_CODEC("mt6359-sound",
+                                                  "mt6359-snd-codec-aif2")),
+                    DAILINK_COMP_ARRAY(COMP_EMPTY()));
+
+static struct snd_soc_dai_link mt8195_mt6359_rt1011_rt5682_dai_links[] = {
+       /* FE */
+       [DAI_LINK_DL2_FE] = {
+               .name = "DL2_FE",
+               .stream_name = "DL2 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_playback_ops,
+               SND_SOC_DAILINK_REG(DL2_FE),
+       },
+       [DAI_LINK_DL3_FE] = {
+               .name = "DL3_FE",
+               .stream_name = "DL3 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_playback_ops,
+               SND_SOC_DAILINK_REG(DL3_FE),
+       },
+       [DAI_LINK_DL6_FE] = {
+               .name = "DL6_FE",
+               .stream_name = "DL6 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_playback_ops,
+               SND_SOC_DAILINK_REG(DL6_FE),
+       },
+       [DAI_LINK_DL7_FE] = {
+               .name = "DL7_FE",
+               .stream_name = "DL7 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_PRE,
+                       SND_SOC_DPCM_TRIGGER_PRE,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               SND_SOC_DAILINK_REG(DL7_FE),
+       },
+       [DAI_LINK_DL8_FE] = {
+               .name = "DL8_FE",
+               .stream_name = "DL8 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_playback_ops,
+               SND_SOC_DAILINK_REG(DL8_FE),
+       },
+       [DAI_LINK_DL10_FE] = {
+               .name = "DL10_FE",
+               .stream_name = "DL10 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_hdmitx_dptx_playback_ops,
+               SND_SOC_DAILINK_REG(DL10_FE),
+       },
+       [DAI_LINK_DL11_FE] = {
+               .name = "DL11_FE",
+               .stream_name = "DL11 Playback",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_playback_ops,
+               SND_SOC_DAILINK_REG(DL11_FE),
+       },
+       [DAI_LINK_UL1_FE] = {
+               .name = "UL1_FE",
+               .stream_name = "UL1 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_PRE,
+                       SND_SOC_DPCM_TRIGGER_PRE,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(UL1_FE),
+       },
+       [DAI_LINK_UL2_FE] = {
+               .name = "UL2_FE",
+               .stream_name = "UL2 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL2_FE),
+       },
+       [DAI_LINK_UL3_FE] = {
+               .name = "UL3_FE",
+               .stream_name = "UL3 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL3_FE),
+       },
+       [DAI_LINK_UL4_FE] = {
+               .name = "UL4_FE",
+               .stream_name = "UL4 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL4_FE),
+       },
+       [DAI_LINK_UL5_FE] = {
+               .name = "UL5_FE",
+               .stream_name = "UL5 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL5_FE),
+       },
+       [DAI_LINK_UL6_FE] = {
+               .name = "UL6_FE",
+               .stream_name = "UL6 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_PRE,
+                       SND_SOC_DPCM_TRIGGER_PRE,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(UL6_FE),
+       },
+       [DAI_LINK_UL8_FE] = {
+               .name = "UL8_FE",
+               .stream_name = "UL8 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL8_FE),
+       },
+       [DAI_LINK_UL9_FE] = {
+               .name = "UL9_FE",
+               .stream_name = "UL9 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL9_FE),
+       },
+       [DAI_LINK_UL10_FE] = {
+               .name = "UL10_FE",
+               .stream_name = "UL10 Capture",
+               .trigger = {
+                       SND_SOC_DPCM_TRIGGER_POST,
+                       SND_SOC_DPCM_TRIGGER_POST,
+               },
+               .dynamic = 1,
+               .dpcm_capture = 1,
+               .ops = &mt8195_capture_ops,
+               SND_SOC_DAILINK_REG(UL10_FE),
+       },
+       /* BE */
+       [DAI_LINK_DL_SRC_BE] = {
+               .name = "DL_SRC_BE",
+               .init = mt8195_mt6359_init,
+               .no_pcm = 1,
+               .dpcm_playback = 1,
+               SND_SOC_DAILINK_REG(DL_SRC_BE),
+       },
+       [DAI_LINK_DPTX_BE] = {
+               .name = "DPTX_BE",
+               .no_pcm = 1,
+               .dpcm_playback = 1,
+               .ops = &mt8195_dptx_ops,
+               .be_hw_params_fixup = mt8195_dptx_hw_params_fixup,
+               SND_SOC_DAILINK_REG(DPTX_BE),
+       },
+       [DAI_LINK_ETDM1_IN_BE] = {
+               .name = "ETDM1_IN_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(ETDM1_IN_BE),
+       },
+       [DAI_LINK_ETDM2_IN_BE] = {
+               .name = "ETDM2_IN_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_capture = 1,
+               .init = mt8195_rt5682_init,
+               .ops = &mt8195_rt5682_etdm_ops,
+               .be_hw_params_fixup = mt8195_etdm_hw_params_fixup,
+               SND_SOC_DAILINK_REG(ETDM2_IN_BE),
+       },
+       [DAI_LINK_ETDM1_OUT_BE] = {
+               .name = "ETDM1_OUT_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_playback = 1,
+               .ops = &mt8195_rt5682_etdm_ops,
+               .be_hw_params_fixup = mt8195_etdm_hw_params_fixup,
+               SND_SOC_DAILINK_REG(ETDM1_OUT_BE),
+       },
+       [DAI_LINK_ETDM2_OUT_BE] = {
+               .name = "ETDM2_OUT_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_playback = 1,
+               .ops = &mt8195_rt1011_etdm_ops,
+               .be_hw_params_fixup = mt8195_etdm_hw_params_fixup,
+               SND_SOC_DAILINK_REG(ETDM2_OUT_BE),
+       },
+       [DAI_LINK_ETDM3_OUT_BE] = {
+               .name = "ETDM3_OUT_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_playback = 1,
+               SND_SOC_DAILINK_REG(ETDM3_OUT_BE),
+       },
+       [DAI_LINK_PCM1_BE] = {
+               .name = "PCM1_BE",
+               .no_pcm = 1,
+               .dai_fmt = SND_SOC_DAIFMT_I2S |
+                       SND_SOC_DAIFMT_NB_NF |
+                       SND_SOC_DAIFMT_CBS_CFS,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(PCM1_BE),
+       },
+       [DAI_LINK_UL_SRC1_BE] = {
+               .name = "UL_SRC1_BE",
+               .no_pcm = 1,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(UL_SRC1_BE),
+       },
+       [DAI_LINK_UL_SRC2_BE] = {
+               .name = "UL_SRC2_BE",
+               .no_pcm = 1,
+               .dpcm_capture = 1,
+               SND_SOC_DAILINK_REG(UL_SRC2_BE),
+       },
+};
+
+static struct snd_soc_codec_conf rt1011_amp_conf[] = {
+       {
+               .dlc = COMP_CODEC_CONF(RT1011_DEV0_NAME),
+               .name_prefix = "Left",
+       },
+       {
+               .dlc = COMP_CODEC_CONF(RT1011_DEV1_NAME),
+               .name_prefix = "Right",
+       },
+};
+
+static struct snd_soc_card mt8195_mt6359_rt1011_rt5682_soc_card = {
+       .name = "mt8195_r1011_5682",
+       .owner = THIS_MODULE,
+       .dai_link = mt8195_mt6359_rt1011_rt5682_dai_links,
+       .num_links = ARRAY_SIZE(mt8195_mt6359_rt1011_rt5682_dai_links),
+       .controls = mt8195_mt6359_rt1011_rt5682_controls,
+       .num_controls = ARRAY_SIZE(mt8195_mt6359_rt1011_rt5682_controls),
+       .dapm_widgets = mt8195_mt6359_rt1011_rt5682_widgets,
+       .num_dapm_widgets = ARRAY_SIZE(mt8195_mt6359_rt1011_rt5682_widgets),
+       .dapm_routes = mt8195_mt6359_rt1011_rt5682_routes,
+       .num_dapm_routes = ARRAY_SIZE(mt8195_mt6359_rt1011_rt5682_routes),
+       .codec_conf = rt1011_amp_conf,
+       .num_configs = ARRAY_SIZE(rt1011_amp_conf),
+};
+
+static int mt8195_mt6359_rt1011_rt5682_dev_probe(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = &mt8195_mt6359_rt1011_rt5682_soc_card;
+       struct snd_soc_dai_link *dai_link;
+       struct mt8195_mt6359_rt1011_rt5682_priv *priv;
+       int ret, i;
+
+       card->dev = &pdev->dev;
+
+       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->platform_node = of_parse_phandle(pdev->dev.of_node,
+                                              "mediatek,platform", 0);
+       if (!priv->platform_node) {
+               dev_dbg(&pdev->dev, "Property 'platform' missing or invalid\n");
+               return -EINVAL;
+       }
+
+       for_each_card_prelinks(card, i, dai_link) {
+               if (!dai_link->platforms->name)
+                       dai_link->platforms->of_node = priv->platform_node;
+
+               if (strcmp(dai_link->name, "DPTX_BE") == 0) {
+                       priv->dp_node =
+                               of_parse_phandle(pdev->dev.of_node,
+                                                "mediatek,dptx-codec", 0);
+
+                       if (!priv->dp_node) {
+                               dev_dbg(&pdev->dev, "No property 'dptx-codec'\n");
+                       } else {
+                               dai_link->codecs->of_node = priv->dp_node;
+                               dai_link->codecs->name = NULL;
+                               dai_link->codecs->dai_name = "i2s-hifi";
+                               dai_link->init = mt8195_dptx_codec_init;
+                       }
+               }
+
+               if (strcmp(dai_link->name, "ETDM3_OUT_BE") == 0) {
+                       priv->hdmi_node =
+                               of_parse_phandle(pdev->dev.of_node,
+                                                "mediatek,hdmi-codec", 0);
+                       if (!priv->hdmi_node) {
+                               dev_dbg(&pdev->dev, "No property 'hdmi-codec'\n");
+                       } else {
+                               dai_link->codecs->of_node = priv->hdmi_node;
+                               dai_link->codecs->name = NULL;
+                               dai_link->codecs->dai_name = "i2s-hifi";
+                               dai_link->init = mt8195_hdmi_codec_init;
+                       }
+               }
+       }
+
+       snd_soc_card_set_drvdata(card, priv);
+
+       ret = devm_snd_soc_register_card(&pdev->dev, card);
+       if (ret) {
+               dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
+                       __func__, ret);
+               of_node_put(priv->hdmi_node);
+               of_node_put(priv->dp_node);
+               of_node_put(priv->platform_node);
+       }
+
+       return ret;
+}
+
+static int mt8195_mt6359_rt1011_rt5682_dev_remove(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = platform_get_drvdata(pdev);
+       struct mt8195_mt6359_rt1011_rt5682_priv *priv =
+               snd_soc_card_get_drvdata(card);
+
+       of_node_put(priv->hdmi_node);
+       of_node_put(priv->dp_node);
+       of_node_put(priv->platform_node);
+
+       return 0;
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id mt8195_mt6359_rt1011_rt5682_dt_match[] = {
+       {.compatible = "mediatek,mt8195_mt6359_rt1011_rt5682",},
+       {}
+};
+#endif
+
+static const struct dev_pm_ops mt8195_mt6359_rt1011_rt5682_pm_ops = {
+       .poweroff = snd_soc_poweroff,
+       .restore = snd_soc_resume,
+};
+
+static struct platform_driver mt8195_mt6359_rt1011_rt5682_driver = {
+       .driver = {
+               .name = "mt8195_mt6359_rt1011_rt5682",
+#ifdef CONFIG_OF
+               .of_match_table = mt8195_mt6359_rt1011_rt5682_dt_match,
+#endif
+               .pm = &mt8195_mt6359_rt1011_rt5682_pm_ops,
+       },
+       .probe = mt8195_mt6359_rt1011_rt5682_dev_probe,
+       .remove = mt8195_mt6359_rt1011_rt5682_dev_remove,
+};
+
+module_platform_driver(mt8195_mt6359_rt1011_rt5682_driver);
+
+/* Module information */
+MODULE_DESCRIPTION("MT8195-MT6359-RT1011-RT5682 ALSA SoC machine driver");
+MODULE_AUTHOR("Trevor Wu <trevor.wu@mediatek.com>");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("mt8195_mt6359_rt1011_rt5682 soc card");
index de09f67..95abaad 100644 (file)
@@ -26,6 +26,9 @@
 #define RT5682_DEV0_NAME       "rt5682.2-001a"
 
 struct mt8195_mt6359_rt1019_rt5682_priv {
+       struct device_node *platform_node;
+       struct device_node *hdmi_node;
+       struct device_node *dp_node;
        struct snd_soc_jack headset_jack;
        struct snd_soc_jack dp_jack;
        struct snd_soc_jack hdmi_jack;
@@ -994,31 +997,36 @@ static struct snd_soc_card mt8195_mt6359_rt1019_rt5682_soc_card = {
 static int mt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev)
 {
        struct snd_soc_card *card = &mt8195_mt6359_rt1019_rt5682_soc_card;
-       struct device_node *platform_node;
        struct snd_soc_dai_link *dai_link;
-       struct mt8195_mt6359_rt1019_rt5682_priv *priv = NULL;
+       struct mt8195_mt6359_rt1019_rt5682_priv *priv;
        int ret, i;
 
        card->dev = &pdev->dev;
 
-       platform_node = of_parse_phandle(pdev->dev.of_node,
-                                        "mediatek,platform", 0);
-       if (!platform_node) {
+       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
+       if (!priv)
+               return -ENOMEM;
+
+       priv->platform_node = of_parse_phandle(pdev->dev.of_node,
+                                              "mediatek,platform", 0);
+       if (!priv->platform_node) {
                dev_dbg(&pdev->dev, "Property 'platform' missing or invalid\n");
                return -EINVAL;
        }
 
        for_each_card_prelinks(card, i, dai_link) {
                if (!dai_link->platforms->name)
-                       dai_link->platforms->of_node = platform_node;
+                       dai_link->platforms->of_node = priv->platform_node;
 
                if (strcmp(dai_link->name, "DPTX_BE") == 0) {
-                       dai_link->codecs->of_node =
+                       priv->dp_node =
                                of_parse_phandle(pdev->dev.of_node,
                                                 "mediatek,dptx-codec", 0);
-                       if (!dai_link->codecs->of_node) {
+
+                       if (!priv->dp_node) {
                                dev_dbg(&pdev->dev, "No property 'dptx-codec'\n");
                        } else {
+                               dai_link->codecs->of_node = priv->dp_node;
                                dai_link->codecs->name = NULL;
                                dai_link->codecs->dai_name = "i2s-hifi";
                                dai_link->init = mt8195_dptx_codec_init;
@@ -1026,12 +1034,13 @@ static int mt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev)
                }
 
                if (strcmp(dai_link->name, "ETDM3_OUT_BE") == 0) {
-                       dai_link->codecs->of_node =
+                       priv->hdmi_node =
                                of_parse_phandle(pdev->dev.of_node,
                                                 "mediatek,hdmi-codec", 0);
-                       if (!dai_link->codecs->of_node) {
+                       if (!priv->hdmi_node) {
                                dev_dbg(&pdev->dev, "No property 'hdmi-codec'\n");
                        } else {
+                               dai_link->codecs->of_node = priv->hdmi_node;
                                dai_link->codecs->name = NULL;
                                dai_link->codecs->dai_name = "i2s-hifi";
                                dai_link->init = mt8195_hdmi_codec_init;
@@ -1039,19 +1048,33 @@ static int mt8195_mt6359_rt1019_rt5682_dev_probe(struct platform_device *pdev)
                }
        }
 
-       priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
-       if (!priv)
-               return -ENOMEM;
-
        snd_soc_card_set_drvdata(card, priv);
 
        ret = devm_snd_soc_register_card(&pdev->dev, card);
-       if (ret)
+       if (ret) {
                dev_err(&pdev->dev, "%s snd_soc_register_card fail %d\n",
                        __func__, ret);
+               of_node_put(priv->hdmi_node);
+               of_node_put(priv->dp_node);
+               of_node_put(priv->platform_node);
+       }
+
        return ret;
 }
 
+static int mt8195_mt6359_rt1019_rt5682_dev_remove(struct platform_device *pdev)
+{
+       struct snd_soc_card *card = platform_get_drvdata(pdev);
+       struct mt8195_mt6359_rt1019_rt5682_priv *priv =
+               snd_soc_card_get_drvdata(card);
+
+       of_node_put(priv->hdmi_node);
+       of_node_put(priv->dp_node);
+       of_node_put(priv->platform_node);
+
+       return 0;
+}
+
 #ifdef CONFIG_OF
 static const struct of_device_id mt8195_mt6359_rt1019_rt5682_dt_match[] = {
        {.compatible = "mediatek,mt8195_mt6359_rt1019_rt5682",},
@@ -1073,6 +1096,7 @@ static struct platform_driver mt8195_mt6359_rt1019_rt5682_driver = {
                .pm = &mt8195_mt6359_rt1019_rt5682_pm_ops,
        },
        .probe = mt8195_mt6359_rt1019_rt5682_dev_probe,
+       .remove = mt8195_mt6359_rt1019_rt5682_dev_remove,
 };
 
 module_platform_driver(mt8195_mt6359_rt1019_rt5682_driver);
index de85091..97da60d 100644 (file)
@@ -113,7 +113,7 @@ static int aiu_encoder_spdif_hw_params(struct snd_pcm_substream *substream,
                val |= AIU_958_MISC_MODE_32BITS;
                break;
        default:
-               dev_err(dai->dev, "Unsupport physical width\n");
+               dev_err(dai->dev, "Unsupported physical width\n");
                return -EINVAL;
        }
 
index 2b77010..cbbaa55 100644 (file)
@@ -320,6 +320,7 @@ static int axg_card_add_link(struct snd_soc_card *card, struct device_node *np,
 
        dai_link->cpus = cpu;
        dai_link->num_cpus = 1;
+       dai_link->nonatomic = true;
 
        ret = meson_card_parse_dai(card, np, &dai_link->cpus->of_node,
                                   &dai_link->cpus->dai_name);
index 87cac44..db07777 100644 (file)
@@ -351,13 +351,29 @@ static int axg_tdm_iface_hw_free(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static int axg_tdm_iface_prepare(struct snd_pcm_substream *substream,
+static int axg_tdm_iface_trigger(struct snd_pcm_substream *substream,
+                                int cmd,
                                 struct snd_soc_dai *dai)
 {
-       struct axg_tdm_stream *ts = snd_soc_dai_get_dma_data(dai, substream);
+       struct axg_tdm_stream *ts =
+               snd_soc_dai_get_dma_data(dai, substream);
+
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+               axg_tdm_stream_start(ts);
+               break;
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+       case SNDRV_PCM_TRIGGER_STOP:
+               axg_tdm_stream_stop(ts);
+               break;
+       default:
+               return -EINVAL;
+       }
 
-       /* Force all attached formatters to update */
-       return axg_tdm_stream_reset(ts);
+       return 0;
 }
 
 static int axg_tdm_iface_remove_dai(struct snd_soc_dai *dai)
@@ -397,8 +413,8 @@ static const struct snd_soc_dai_ops axg_tdm_iface_ops = {
        .set_fmt        = axg_tdm_iface_set_fmt,
        .startup        = axg_tdm_iface_startup,
        .hw_params      = axg_tdm_iface_hw_params,
-       .prepare        = axg_tdm_iface_prepare,
        .hw_free        = axg_tdm_iface_hw_free,
+       .trigger        = axg_tdm_iface_trigger,
 };
 
 /* TDM Backend DAIs */
index 415cc00..29b0174 100644 (file)
@@ -302,6 +302,7 @@ int meson_card_probe(struct platform_device *pdev)
 
        priv->card.owner = THIS_MODULE;
        priv->card.dev = dev;
+       priv->card.driver_name = dev->driver->name;
        priv->match_data = data;
 
        ret = snd_soc_of_parse_card_name(&priv->card, "model");
index d07270d..2870cfa 100644 (file)
@@ -113,9 +113,6 @@ int meson_codec_glue_output_startup(struct snd_pcm_substream *substream,
        /* Replace link params with the input params */
        rtd->dai_link->params = &in_data->params;
 
-       if (!in_data->fmt)
-               return 0;
-
        return snd_soc_runtime_set_dai_fmt(rtd, in_data->fmt);
 }
 EXPORT_SYMBOL_GPL(meson_codec_glue_output_startup);
index cc7c1de..b217384 100644 (file)
@@ -38,6 +38,7 @@ config SND_SOC_LPASS_SC7180
 
 config SND_SOC_STORM
        tristate "ASoC I2S support for Storm boards"
+       depends on GPIOLIB
        select SND_SOC_LPASS_IPQ806X
        select SND_SOC_MAX98357A
        help
@@ -84,6 +85,25 @@ config SND_SOC_QDSP6_ASM_DAI
        select SND_SOC_COMPRESS
        tristate
 
+config SND_SOC_QDSP6_APM_DAI
+       tristate
+       select SND_SOC_COMPRESS
+
+config SND_SOC_QDSP6_APM_LPASS_DAI
+       tristate
+
+config SND_SOC_QDSP6_APM
+       tristate
+       select SND_SOC_QDSP6_APM_DAI
+       select SND_SOC_QDSP6_APM_LPASS_DAI
+
+config SND_SOC_QDSP6_PRM_LPASS_CLOCKS
+       tristate
+
+config SND_SOC_QDSP6_PRM
+       tristate
+       select SND_SOC_QDSP6_PRM_LPASS_CLOCKS
+
 config SND_SOC_QDSP6
        tristate "SoC ALSA audio driver for QDSP6"
        depends on QCOM_APR
@@ -97,6 +117,9 @@ config SND_SOC_QDSP6
        select SND_SOC_QDSP6_ROUTING
        select SND_SOC_QDSP6_ASM
        select SND_SOC_QDSP6_ASM_DAI
+       select SND_SOC_TOPOLOGY
+       select SND_SOC_QDSP6_APM
+       select SND_SOC_QDSP6_PRM
        help
         To add support for MSM QDSP6 Soc Audio.
         This will enable sound soc platform specific
@@ -141,7 +164,7 @@ config SND_SOC_SM8250
 
 config SND_SOC_SC7180
        tristate "SoC Machine driver for SC7180 boards"
-       depends on I2C
+       depends on I2C && GPIOLIB
        select SND_SOC_QCOM_COMMON
        select SND_SOC_LPASS_SC7180
        select SND_SOC_MAX98357A
index 1a69bae..c7b7d08 100644 (file)
@@ -60,7 +60,7 @@ end:
        return ret;
 }
 
-static struct snd_soc_ops apq8096_ops = {
+static const struct snd_soc_ops apq8096_ops = {
        .hw_params = msm_snd_hw_params,
 };
 
index 09af007..2e1c618 100644 (file)
@@ -44,7 +44,7 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
                return ret;
 
        /* Populate links */
-       num_links = of_get_child_count(dev->of_node);
+       num_links = of_get_available_child_count(dev->of_node);
 
        /* Allocate the DAI link array */
        card->dai_link = devm_kcalloc(dev, num_links, sizeof(*link), GFP_KERNEL);
@@ -54,7 +54,7 @@ int qcom_snd_parse_of(struct snd_soc_card *card)
        card->num_links = num_links;
        link = card->dai_link;
 
-       for_each_child_of_node(dev->of_node, np) {
+       for_each_available_child_of_node(dev->of_node, np) {
                dlc = devm_kzalloc(dev, 2 * sizeof(*dlc), GFP_KERNEL);
                if (!dlc) {
                        ret = -ENOMEM;
index 3c1dd9f..3963bf2 100644 (file)
@@ -1,5 +1,8 @@
 # SPDX-License-Identifier: GPL-2.0-only
-obj-$(CONFIG_SND_SOC_QDSP6_COMMON) += q6dsp-common.o
+snd-q6dsp-common-objs := q6dsp-common.o q6dsp-lpass-ports.o q6dsp-lpass-clocks.o
+snd-q6apm-objs := q6apm.o audioreach.o topology.o
+
+obj-$(CONFIG_SND_SOC_QDSP6_COMMON) += snd-q6dsp-common.o
 obj-$(CONFIG_SND_SOC_QDSP6_CORE) += q6core.o
 obj-$(CONFIG_SND_SOC_QDSP6_AFE) += q6afe.o
 obj-$(CONFIG_SND_SOC_QDSP6_AFE_DAI) += q6afe-dai.o
@@ -8,3 +11,9 @@ obj-$(CONFIG_SND_SOC_QDSP6_ADM) += q6adm.o
 obj-$(CONFIG_SND_SOC_QDSP6_ROUTING) += q6routing.o
 obj-$(CONFIG_SND_SOC_QDSP6_ASM) += q6asm.o
 obj-$(CONFIG_SND_SOC_QDSP6_ASM_DAI) += q6asm-dai.o
+
+obj-$(CONFIG_SND_SOC_QDSP6_APM) += snd-q6apm.o
+obj-$(CONFIG_SND_SOC_QDSP6_APM_DAI) += q6apm-dai.o
+obj-$(CONFIG_SND_SOC_QDSP6_APM_LPASS_DAI) += q6apm-lpass-dais.o
+obj-$(CONFIG_SND_SOC_QDSP6_PRM) += q6prm.o
+obj-$(CONFIG_SND_SOC_QDSP6_PRM_LPASS_CLOCKS) += q6prm-clocks.o
diff --git a/sound/soc/qcom/qdsp6/audioreach.c b/sound/soc/qcom/qdsp6/audioreach.c
new file mode 100644 (file)
index 0000000..98c0efa
--- /dev/null
@@ -0,0 +1,1130 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020, Linaro Limited
+
+#include <linux/kernel.h>
+#include <linux/slab.h>
+#include <linux/soc/qcom/apr.h>
+#include <sound/soc.h>
+#include <sound/soc-dai.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <dt-bindings/soc/qcom,gpr.h>
+#include "q6apm.h"
+#include "audioreach.h"
+
+/* SubGraph Config */
+struct apm_sub_graph_data {
+       struct apm_sub_graph_cfg sub_graph_cfg;
+       struct apm_prop_data perf_data;
+       struct apm_sg_prop_id_perf_mode perf;
+       struct apm_prop_data dir_data;
+       struct apm_sg_prop_id_direction dir;
+       struct apm_prop_data sid_data;
+       struct apm_sg_prop_id_scenario_id sid;
+
+} __packed;
+
+#define APM_SUB_GRAPH_CFG_NPROP        3
+
+struct apm_sub_graph_params  {
+       struct apm_module_param_data param_data;
+       uint32_t num_sub_graphs;
+       struct apm_sub_graph_data sg_cfg[];
+} __packed;
+
+#define APM_SUB_GRAPH_PSIZE(p, n) ALIGN(struct_size(p, sg_cfg, n), 8)
+
+/* container config */
+struct apm_container_obj  {
+       struct apm_container_cfg container_cfg;
+       /* Capability ID list */
+       struct apm_prop_data cap_data;
+       uint32_t num_capability_id;
+       uint32_t capability_id;
+
+       /* Container graph Position */
+       struct apm_prop_data pos_data;
+       struct apm_cont_prop_id_graph_pos pos;
+
+       /* Container Stack size */
+       struct apm_prop_data stack_data;
+       struct apm_cont_prop_id_stack_size stack;
+
+       /* Container proc domain id */
+       struct apm_prop_data domain_data;
+       struct apm_cont_prop_id_domain domain;
+} __packed;
+
+struct apm_container_params  {
+       struct apm_module_param_data param_data;
+       uint32_t num_containers;
+       struct apm_container_obj cont_obj[];
+} __packed;
+
+#define APM_CONTAINER_PSIZE(p, n) ALIGN(struct_size(p, cont_obj, n), 8)
+
+/* Module List config */
+struct apm_mod_list_obj {
+       /* Modules list cfg */
+       uint32_t sub_graph_id;
+       uint32_t container_id;
+       uint32_t num_modules;
+       struct apm_module_obj mod_cfg[];
+} __packed;
+
+#define APM_MOD_LIST_OBJ_PSIZE(p, n) struct_size(p, mod_cfg, n)
+
+struct apm_module_list_params {
+       struct apm_module_param_data param_data;
+       uint32_t num_modules_list;
+       /* Module list config array */
+       struct apm_mod_list_obj mod_list_obj[];
+} __packed;
+
+
+/* Module Properties */
+struct apm_mod_prop_obj {
+       u32 instance_id;
+       u32 num_props;
+       struct apm_prop_data prop_data_1;
+       struct apm_module_prop_id_port_info prop_id_port;
+} __packed;
+
+struct apm_prop_list_params {
+       struct apm_module_param_data param_data;
+       u32 num_modules_prop_cfg;
+       struct apm_mod_prop_obj mod_prop_obj[];
+
+} __packed;
+
+#define APM_MOD_PROP_PSIZE(p, n) ALIGN(struct_size(p, mod_prop_obj, n), 8)
+
+/* Module Connections */
+struct apm_mod_conn_list_params {
+       struct apm_module_param_data param_data;
+       u32 num_connections;
+       struct apm_module_conn_obj conn_obj[];
+
+} __packed;
+
+#define APM_MOD_CONN_PSIZE(p, n) ALIGN(struct_size(p, conn_obj, n), 8)
+
+struct apm_graph_open_params {
+       struct apm_cmd_header *cmd_header;
+       struct apm_sub_graph_params *sg_data;
+       struct apm_container_params *cont_data;
+       struct apm_module_list_params *mod_list_data;
+       struct apm_prop_list_params *mod_prop_data;
+       struct apm_mod_conn_list_params *mod_conn_list_data;
+} __packed;
+
+struct apm_pcm_module_media_fmt_cmd {
+       struct apm_module_param_data param_data;
+       struct param_id_pcm_output_format_cfg header;
+       struct payload_pcm_output_format_cfg media_cfg;
+} __packed;
+
+struct apm_rd_shmem_module_config_cmd {
+       struct apm_module_param_data param_data;
+       struct param_id_rd_sh_mem_cfg cfg;
+} __packed;
+
+struct apm_sh_module_media_fmt_cmd {
+       struct media_format header;
+       struct payload_media_fmt_pcm cfg;
+} __packed;
+
+#define APM_SHMEM_FMT_CFG_PSIZE(ch) ALIGN( \
+                               sizeof(struct apm_sh_module_media_fmt_cmd) + \
+                               ch * sizeof(uint8_t), 8)
+
+/* num of channels as argument */
+#define APM_PCM_MODULE_FMT_CMD_PSIZE(ch) ALIGN( \
+                               sizeof(struct apm_pcm_module_media_fmt_cmd) + \
+                               ch * sizeof(uint8_t), 8)
+
+#define APM_PCM_OUT_FMT_CFG_PSIZE(p, n) ALIGN(struct_size(p, channel_mapping, n), 4)
+
+struct apm_i2s_module_intf_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_i2s_intf_cfg cfg;
+} __packed;
+
+#define APM_I2S_INTF_CFG_PSIZE ALIGN(sizeof(struct apm_i2s_module_intf_cfg), 8)
+
+struct apm_module_hw_ep_mf_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_hw_ep_mf mf;
+} __packed;
+
+#define APM_HW_EP_CFG_PSIZE ALIGN(sizeof(struct apm_module_hw_ep_mf_cfg), 8)
+
+struct apm_module_frame_size_factor_cfg {
+       struct apm_module_param_data param_data;
+       uint32_t frame_size_factor;
+} __packed;
+
+#define APM_FS_CFG_PSIZE ALIGN(sizeof(struct apm_module_frame_size_factor_cfg), 8)
+
+struct apm_module_hw_ep_power_mode_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_hw_ep_power_mode_cfg power_mode;
+} __packed;
+
+#define APM_HW_EP_PMODE_CFG_PSIZE ALIGN(sizeof(struct apm_module_hw_ep_power_mode_cfg),        8)
+
+struct apm_module_hw_ep_dma_data_align_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_hw_ep_dma_data_align align;
+} __packed;
+
+#define APM_HW_EP_DALIGN_CFG_PSIZE ALIGN(sizeof(struct apm_module_hw_ep_dma_data_align_cfg), 8)
+
+struct apm_gain_module_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_gain_cfg gain_cfg;
+} __packed;
+
+#define APM_GAIN_CFG_PSIZE ALIGN(sizeof(struct apm_gain_module_cfg), 8)
+
+struct apm_codec_dma_module_intf_cfg {
+       struct apm_module_param_data param_data;
+       struct param_id_codec_dma_intf_cfg cfg;
+} __packed;
+
+#define APM_CDMA_INTF_CFG_PSIZE ALIGN(sizeof(struct apm_codec_dma_module_intf_cfg), 8)
+
+static void *__audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
+                                   uint32_t src_port, uint32_t dest_port, bool has_cmd_hdr)
+{
+       struct gpr_pkt *pkt;
+       void *p;
+       int pkt_size = GPR_HDR_SIZE + payload_size;
+
+       if (has_cmd_hdr)
+               pkt_size += APM_CMD_HDR_SIZE;
+
+       p = kzalloc(pkt_size, GFP_KERNEL);
+       if (!p)
+               return ERR_PTR(-ENOMEM);
+
+       pkt = p;
+       pkt->hdr.version = GPR_PKT_VER;
+       pkt->hdr.hdr_size = GPR_PKT_HEADER_WORD_SIZE;
+       pkt->hdr.pkt_size = pkt_size;
+       pkt->hdr.dest_port = dest_port;
+       pkt->hdr.src_port = src_port;
+
+       pkt->hdr.dest_domain = GPR_DOMAIN_ID_ADSP;
+       pkt->hdr.src_domain = GPR_DOMAIN_ID_APPS;
+       pkt->hdr.token = token;
+       pkt->hdr.opcode = opcode;
+
+       if (has_cmd_hdr) {
+               struct apm_cmd_header *cmd_header;
+
+               p = p + GPR_HDR_SIZE;
+               cmd_header = p;
+               cmd_header->payload_size = payload_size;
+       }
+
+       return pkt;
+}
+
+void *audioreach_alloc_pkt(int payload_size, uint32_t opcode, uint32_t token,
+                          uint32_t src_port, uint32_t dest_port)
+{
+       return __audioreach_alloc_pkt(payload_size, opcode, token, src_port, dest_port, false);
+}
+EXPORT_SYMBOL_GPL(audioreach_alloc_pkt);
+
+void *audioreach_alloc_apm_pkt(int pkt_size, uint32_t opcode, uint32_t token, uint32_t src_port)
+{
+       return __audioreach_alloc_pkt(pkt_size, opcode, token, src_port, APM_MODULE_INSTANCE_ID,
+                                     false);
+}
+EXPORT_SYMBOL_GPL(audioreach_alloc_apm_pkt);
+
+void *audioreach_alloc_cmd_pkt(int payload_size, uint32_t opcode, uint32_t token,
+                              uint32_t src_port, uint32_t dest_port)
+{
+       return __audioreach_alloc_pkt(payload_size, opcode, token, src_port, dest_port, true);
+}
+EXPORT_SYMBOL_GPL(audioreach_alloc_cmd_pkt);
+
+void *audioreach_alloc_apm_cmd_pkt(int pkt_size, uint32_t opcode, uint32_t token)
+{
+       return __audioreach_alloc_pkt(pkt_size, opcode, token, GPR_APM_MODULE_IID,
+                                      APM_MODULE_INSTANCE_ID, true);
+}
+EXPORT_SYMBOL_GPL(audioreach_alloc_apm_cmd_pkt);
+
+static void apm_populate_container_config(struct apm_container_obj *cfg,
+                                         struct audioreach_container *cont)
+{
+
+       /* Container Config */
+       cfg->container_cfg.container_id = cont->container_id;
+       cfg->container_cfg.num_prop = 4;
+
+       /* Capability list */
+       cfg->cap_data.prop_id = APM_CONTAINER_PROP_ID_CAPABILITY_LIST;
+       cfg->cap_data.prop_size = APM_CONTAINER_PROP_ID_CAPABILITY_SIZE;
+       cfg->num_capability_id = 1;
+       cfg->capability_id = cont->capability_id;
+
+       /* Graph Position */
+       cfg->pos_data.prop_id = APM_CONTAINER_PROP_ID_GRAPH_POS;
+       cfg->pos_data.prop_size = sizeof(struct apm_cont_prop_id_graph_pos);
+       cfg->pos.graph_pos = cont->graph_pos;
+
+       /* Stack size */
+       cfg->stack_data.prop_id = APM_CONTAINER_PROP_ID_STACK_SIZE;
+       cfg->stack_data.prop_size = sizeof(struct apm_cont_prop_id_stack_size);
+       cfg->stack.stack_size = cont->stack_size;
+
+       /* Proc domain */
+       cfg->domain_data.prop_id = APM_CONTAINER_PROP_ID_PROC_DOMAIN;
+       cfg->domain_data.prop_size = sizeof(struct apm_cont_prop_id_domain);
+       cfg->domain.proc_domain = cont->proc_domain;
+}
+
+static void apm_populate_sub_graph_config(struct apm_sub_graph_data *cfg,
+                                         struct audioreach_sub_graph *sg)
+{
+       cfg->sub_graph_cfg.sub_graph_id = sg->sub_graph_id;
+       cfg->sub_graph_cfg.num_sub_graph_prop = APM_SUB_GRAPH_CFG_NPROP;
+
+       /* Perf Mode */
+       cfg->perf_data.prop_id = APM_SUB_GRAPH_PROP_ID_PERF_MODE;
+       cfg->perf_data.prop_size = APM_SG_PROP_ID_PERF_MODE_SIZE;
+       cfg->perf.perf_mode = sg->perf_mode;
+
+       /* Direction */
+       cfg->dir_data.prop_id = APM_SUB_GRAPH_PROP_ID_DIRECTION;
+       cfg->dir_data.prop_size = APM_SG_PROP_ID_DIR_SIZE;
+       cfg->dir.direction = sg->direction;
+
+       /* Scenario ID */
+       cfg->sid_data.prop_id = APM_SUB_GRAPH_PROP_ID_SCENARIO_ID;
+       cfg->sid_data.prop_size = APM_SG_PROP_ID_SID_SIZE;
+       cfg->sid.scenario_id = sg->scenario_id;
+}
+
+static void apm_populate_connection_obj(struct apm_module_conn_obj *obj,
+                                       struct audioreach_module *module)
+{
+       obj->src_mod_inst_id = module->src_mod_inst_id;
+       obj->src_mod_op_port_id = module->src_mod_op_port_id;
+       obj->dst_mod_inst_id = module->instance_id;
+       obj->dst_mod_ip_port_id = module->in_port;
+}
+
+static void apm_populate_module_prop_obj(struct apm_mod_prop_obj *obj,
+                                        struct audioreach_module *module)
+{
+
+       obj->instance_id = module->instance_id;
+       obj->num_props = 1;
+       obj->prop_data_1.prop_id = APM_MODULE_PROP_ID_PORT_INFO;
+       obj->prop_data_1.prop_size = APM_MODULE_PROP_ID_PORT_INFO_SZ;
+       obj->prop_id_port.max_ip_port = module->max_ip_port;
+       obj->prop_id_port.max_op_port = module->max_op_port;
+}
+
+struct audioreach_module *audioreach_get_container_last_module(
+                                                       struct audioreach_container *container)
+{
+       struct audioreach_module *module;
+
+       list_for_each_entry(module, &container->modules_list, node) {
+               if (module->dst_mod_inst_id == 0)
+                       return module;
+       }
+
+       return NULL;
+}
+EXPORT_SYMBOL_GPL(audioreach_get_container_last_module);
+
+static bool is_module_in_container(struct audioreach_container *container, int module_iid)
+{
+       struct audioreach_module *module;
+
+       list_for_each_entry(module, &container->modules_list, node) {
+               if (module->instance_id == module_iid)
+                       return true;
+       }
+
+       return false;
+}
+
+struct audioreach_module *audioreach_get_container_first_module(
+                                                       struct audioreach_container *container)
+{
+       struct audioreach_module *module;
+
+       /* get the first module from both connected or un-connected containers */
+       list_for_each_entry(module, &container->modules_list, node) {
+               if (module->src_mod_inst_id == 0 ||
+                   !is_module_in_container(container, module->src_mod_inst_id))
+                       return module;
+       }
+       return NULL;
+}
+EXPORT_SYMBOL_GPL(audioreach_get_container_first_module);
+
+struct audioreach_module *audioreach_get_container_next_module(
+                                               struct audioreach_container *container,
+                                               struct audioreach_module *module)
+{
+       int nmodule_iid = module->dst_mod_inst_id;
+       struct audioreach_module *nmodule;
+
+       list_for_each_entry(nmodule, &container->modules_list, node) {
+               if (nmodule->instance_id == nmodule_iid)
+                       return nmodule;
+       }
+
+       return NULL;
+}
+EXPORT_SYMBOL_GPL(audioreach_get_container_next_module);
+
+static void apm_populate_module_list_obj(struct apm_mod_list_obj *obj,
+                                        struct audioreach_container *container,
+                                        int sub_graph_id)
+{
+       struct audioreach_module *module;
+       int i;
+
+       obj->sub_graph_id = sub_graph_id;
+       obj->container_id = container->container_id;
+       obj->num_modules = container->num_modules;
+       i = 0;
+       list_for_each_container_module(module, container) {
+               obj->mod_cfg[i].module_id = module->module_id;
+               obj->mod_cfg[i].instance_id = module->instance_id;
+               i++;
+       }
+}
+
+static void audioreach_populate_graph(struct apm_graph_open_params *open,
+                                     struct list_head *sg_list,
+                                     int num_sub_graphs)
+{
+       struct apm_mod_conn_list_params *mc_data = open->mod_conn_list_data;
+       struct apm_module_list_params *ml_data = open->mod_list_data;
+       struct apm_prop_list_params *mp_data = open->mod_prop_data;
+       struct apm_container_params *c_data = open->cont_data;
+       struct apm_sub_graph_params *sg_data = open->sg_data;
+       int ncontainer = 0, nmodule = 0, nconn = 0;
+       struct apm_mod_prop_obj *module_prop_obj;
+       struct audioreach_container *container;
+       struct apm_module_conn_obj *conn_obj;
+       struct audioreach_module *module;
+       struct audioreach_sub_graph *sg;
+       struct apm_container_obj *cobj;
+       struct apm_mod_list_obj *mlobj;
+       int i = 0;
+
+       mlobj = &ml_data->mod_list_obj[0];
+
+       list_for_each_entry(sg, sg_list, node) {
+               struct apm_sub_graph_data *sg_cfg = &sg_data->sg_cfg[i++];
+
+               apm_populate_sub_graph_config(sg_cfg, sg);
+
+               list_for_each_entry(container, &sg->container_list, node) {
+                       cobj = &c_data->cont_obj[ncontainer];
+
+                       apm_populate_container_config(cobj, container);
+                       apm_populate_module_list_obj(mlobj, container, sg->sub_graph_id);
+
+                       list_for_each_container_module(module, container) {
+                               uint32_t src_mod_inst_id;
+
+                               src_mod_inst_id = module->src_mod_inst_id;
+
+                               module_prop_obj = &mp_data->mod_prop_obj[nmodule];
+                               apm_populate_module_prop_obj(module_prop_obj, module);
+
+                               if (src_mod_inst_id) {
+                                       conn_obj = &mc_data->conn_obj[nconn];
+                                       apm_populate_connection_obj(conn_obj, module);
+                                       nconn++;
+                               }
+
+                               nmodule++;
+                       }
+                       mlobj = (void *) mlobj + APM_MOD_LIST_OBJ_PSIZE(mlobj, container->num_modules);
+
+                       ncontainer++;
+               }
+       }
+}
+
+void *audioreach_alloc_graph_pkt(struct q6apm *apm, struct list_head *sg_list, int graph_id)
+{
+       int payload_size, sg_sz, cont_sz, ml_sz, mp_sz, mc_sz;
+       struct apm_module_param_data  *param_data;
+       struct apm_container_params *cont_params;
+       struct audioreach_container *container;
+       struct apm_sub_graph_params *sg_params;
+       struct apm_mod_conn_list_params *mcon;
+       struct apm_graph_open_params params;
+       struct apm_prop_list_params *mprop;
+       struct audioreach_module *module;
+       struct audioreach_sub_graph *sgs;
+       struct apm_mod_list_obj *mlobj;
+       int num_modules_per_list;
+       int num_connections = 0;
+       int num_containers = 0;
+       int num_sub_graphs = 0;
+       int num_modules = 0;
+       int num_modules_list;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       list_for_each_entry(sgs, sg_list, node) {
+               num_sub_graphs++;
+               list_for_each_entry(container, &sgs->container_list, node) {
+                       num_containers++;
+                       num_modules += container->num_modules;
+                       list_for_each_container_module(module, container) {
+                               if (module->src_mod_inst_id)
+                                       num_connections++;
+                       }
+               }
+       }
+
+       num_modules_list = num_containers;
+       num_modules_per_list = num_modules/num_containers;
+       sg_sz = APM_SUB_GRAPH_PSIZE(sg_params, num_sub_graphs);
+       cont_sz = APM_CONTAINER_PSIZE(cont_params, num_containers);
+       ml_sz = ALIGN(sizeof(struct apm_module_list_params) +
+               num_modules_list * APM_MOD_LIST_OBJ_PSIZE(mlobj,  num_modules_per_list), 8);
+       mp_sz = APM_MOD_PROP_PSIZE(mprop, num_modules);
+       mc_sz = APM_MOD_CONN_PSIZE(mcon, num_connections);
+
+       payload_size = sg_sz + cont_sz + ml_sz + mp_sz + mc_sz;
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_GRAPH_OPEN, 0);
+       if (IS_ERR(pkt))
+               return pkt;
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       /* SubGraph */
+       params.sg_data = p;
+       param_data = &params.sg_data->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_SUB_GRAPH_CONFIG;
+       param_data->param_size = sg_sz - APM_MODULE_PARAM_DATA_SIZE;
+       params.sg_data->num_sub_graphs = num_sub_graphs;
+       p += sg_sz;
+
+       /* Container */
+       params.cont_data = p;
+       param_data = &params.cont_data->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_CONTAINER_CONFIG;
+       param_data->param_size = cont_sz - APM_MODULE_PARAM_DATA_SIZE;
+       params.cont_data->num_containers = num_containers;
+       p += cont_sz;
+
+       /* Module List*/
+       params.mod_list_data = p;
+       param_data = &params.mod_list_data->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_MODULE_LIST;
+       param_data->param_size = ml_sz - APM_MODULE_PARAM_DATA_SIZE;
+       params.mod_list_data->num_modules_list = num_sub_graphs;
+       p += ml_sz;
+
+       /* Module Properties */
+       params.mod_prop_data = p;
+       param_data = &params.mod_prop_data->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_MODULE_PROP;
+       param_data->param_size = mp_sz - APM_MODULE_PARAM_DATA_SIZE;
+       params.mod_prop_data->num_modules_prop_cfg = num_modules;
+       p += mp_sz;
+
+       /* Module Connections */
+       params.mod_conn_list_data = p;
+       param_data = &params.mod_conn_list_data->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_MODULE_CONN;
+       param_data->param_size = mc_sz - APM_MODULE_PARAM_DATA_SIZE;
+       params.mod_conn_list_data->num_connections = num_connections;
+       p += mc_sz;
+
+       audioreach_populate_graph(&params, sg_list, num_sub_graphs);
+
+       return pkt;
+}
+EXPORT_SYMBOL_GPL(audioreach_alloc_graph_pkt);
+
+int audioreach_send_cmd_sync(struct device *dev, gpr_device_t *gdev,
+                            struct gpr_ibasic_rsp_result_t *result, struct mutex *cmd_lock,
+                            gpr_port_t *port, wait_queue_head_t *cmd_wait,
+                            struct gpr_pkt *pkt, uint32_t rsp_opcode)
+{
+
+       struct gpr_hdr *hdr = &pkt->hdr;
+       int rc;
+
+       mutex_lock(cmd_lock);
+       result->opcode = 0;
+       result->status = 0;
+
+       if (port)
+               rc = gpr_send_port_pkt(port, pkt);
+       else if (gdev)
+               rc = gpr_send_pkt(gdev, pkt);
+       else
+               rc = -EINVAL;
+
+       if (rc < 0)
+               goto err;
+
+       if (rsp_opcode)
+               rc = wait_event_timeout(*cmd_wait, (result->opcode == hdr->opcode) ||
+                                       (result->opcode == rsp_opcode), 5 * HZ);
+       else
+               rc = wait_event_timeout(*cmd_wait, (result->opcode == hdr->opcode), 5 * HZ);
+
+       if (!rc) {
+               dev_err(dev, "CMD timeout for [%x] opcode\n", hdr->opcode);
+               rc = -ETIMEDOUT;
+       } else if (result->status > 0) {
+               dev_err(dev, "DSP returned error[%x] %x\n", hdr->opcode, result->status);
+               rc = -EINVAL;
+       } else {
+               /* DSP successfully finished the command */
+               rc = 0;
+       }
+
+err:
+       mutex_unlock(cmd_lock);
+       return rc;
+}
+EXPORT_SYMBOL_GPL(audioreach_send_cmd_sync);
+
+int audioreach_graph_send_cmd_sync(struct q6apm_graph *graph, struct gpr_pkt *pkt,
+                                  uint32_t rsp_opcode)
+{
+
+       return audioreach_send_cmd_sync(graph->dev, NULL,  &graph->result, &graph->lock,
+                                       graph->port, &graph->cmd_wait, pkt, rsp_opcode);
+}
+EXPORT_SYMBOL_GPL(audioreach_graph_send_cmd_sync);
+
+/* LPASS Codec DMA port Module Media Format Setup */
+static int audioreach_codec_dma_set_media_format(struct q6apm_graph *graph,
+                                                struct audioreach_module *module,
+                                                struct audioreach_module_config *cfg)
+{
+       struct apm_codec_dma_module_intf_cfg *intf_cfg;
+       struct apm_module_frame_size_factor_cfg *fs_cfg;
+       struct apm_module_hw_ep_power_mode_cfg *pm_cfg;
+       struct apm_module_param_data *param_data;
+       struct apm_module_hw_ep_mf_cfg *hw_cfg;
+       int ic_sz, ep_sz, fs_sz, pm_sz, dl_sz;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       ic_sz = APM_CDMA_INTF_CFG_PSIZE;
+       ep_sz = APM_HW_EP_CFG_PSIZE;
+       fs_sz = APM_FS_CFG_PSIZE;
+       pm_sz = APM_HW_EP_PMODE_CFG_PSIZE;
+       dl_sz = 0;
+
+       payload_size = ic_sz + ep_sz + fs_sz + pm_sz + dl_sz;
+
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       hw_cfg = p;
+       param_data = &hw_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_HW_EP_MF_CFG;
+       param_data->param_size = ep_sz - APM_MODULE_PARAM_DATA_SIZE;
+
+       hw_cfg->mf.sample_rate = cfg->sample_rate;
+       hw_cfg->mf.bit_width = cfg->bit_width;
+       hw_cfg->mf.num_channels = cfg->num_channels;
+       hw_cfg->mf.data_format = module->data_format;
+       p += ep_sz;
+
+       fs_cfg = p;
+       param_data = &fs_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_HW_EP_FRAME_SIZE_FACTOR;
+       param_data->param_size = fs_sz - APM_MODULE_PARAM_DATA_SIZE;
+       fs_cfg->frame_size_factor = 1;
+       p += fs_sz;
+
+       intf_cfg = p;
+       param_data = &intf_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_CODEC_DMA_INTF_CFG;
+       param_data->param_size = ic_sz - APM_MODULE_PARAM_DATA_SIZE;
+
+       intf_cfg->cfg.lpaif_type = module->hw_interface_type;
+       intf_cfg->cfg.intf_index = module->hw_interface_idx;
+       intf_cfg->cfg.active_channels_mask = (1 << cfg->num_channels) - 1;
+       p += ic_sz;
+
+       pm_cfg = p;
+       param_data = &pm_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_HW_EP_POWER_MODE_CFG;
+       param_data->param_size = pm_sz - APM_MODULE_PARAM_DATA_SIZE;
+       pm_cfg->power_mode.power_mode = 0;
+
+       rc = q6apm_send_cmd_sync(graph->apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+static int audioreach_i2s_set_media_format(struct q6apm_graph *graph,
+                                          struct audioreach_module *module,
+                                          struct audioreach_module_config *cfg)
+{
+       struct apm_module_frame_size_factor_cfg *fs_cfg;
+       struct apm_module_param_data *param_data;
+       struct apm_i2s_module_intf_cfg *intf_cfg;
+       struct apm_module_hw_ep_mf_cfg *hw_cfg;
+       int ic_sz, ep_sz, fs_sz;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       ic_sz = APM_I2S_INTF_CFG_PSIZE;
+       ep_sz = APM_HW_EP_CFG_PSIZE;
+       fs_sz = APM_FS_CFG_PSIZE;
+
+       payload_size = ic_sz + ep_sz + fs_sz;
+
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+       intf_cfg = p;
+
+       param_data = &intf_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_I2S_INTF_CFG;
+       param_data->param_size = ic_sz - APM_MODULE_PARAM_DATA_SIZE;
+
+       intf_cfg->cfg.intf_idx = module->hw_interface_idx;
+       intf_cfg->cfg.sd_line_idx = module->sd_line_idx;
+
+       switch (cfg->fmt & SND_SOC_DAIFMT_CLOCK_PROVIDER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+               intf_cfg->cfg.ws_src = CONFIG_I2S_WS_SRC_INTERNAL;
+               break;
+       case SND_SOC_DAIFMT_CBP_CFP:
+               /* CPU is slave */
+               intf_cfg->cfg.ws_src = CONFIG_I2S_WS_SRC_EXTERNAL;
+               break;
+       default:
+               break;
+       }
+
+       p += ic_sz;
+       hw_cfg = p;
+       param_data = &hw_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_HW_EP_MF_CFG;
+       param_data->param_size = ep_sz - APM_MODULE_PARAM_DATA_SIZE;
+
+       hw_cfg->mf.sample_rate = cfg->sample_rate;
+       hw_cfg->mf.bit_width = cfg->bit_width;
+       hw_cfg->mf.num_channels = cfg->num_channels;
+       hw_cfg->mf.data_format = module->data_format;
+
+       p += ep_sz;
+       fs_cfg = p;
+       param_data = &fs_cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_HW_EP_FRAME_SIZE_FACTOR;
+       param_data->param_size = fs_sz - APM_MODULE_PARAM_DATA_SIZE;
+       fs_cfg->frame_size_factor = 1;
+
+       rc = q6apm_send_cmd_sync(graph->apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+static int audioreach_logging_set_media_format(struct q6apm_graph *graph,
+                                              struct audioreach_module *module)
+{
+       struct apm_module_param_data *param_data;
+       struct data_logging_config *cfg;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       payload_size = sizeof(*cfg) + APM_MODULE_PARAM_DATA_SIZE;
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = p;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_DATA_LOGGING_CONFIG;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+
+       p = p + APM_MODULE_PARAM_DATA_SIZE;
+       cfg = p;
+       cfg->log_code = module->log_code;
+       cfg->log_tap_point_id = module->log_tap_point_id;
+       cfg->mode = module->log_mode;
+
+       rc = q6apm_send_cmd_sync(graph->apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+static int audioreach_pcm_set_media_format(struct q6apm_graph *graph,
+                                          struct audioreach_module *module,
+                                          struct audioreach_module_config *mcfg)
+{
+       struct payload_pcm_output_format_cfg *media_cfg;
+       uint32_t num_channels = mcfg->num_channels;
+       struct apm_pcm_module_media_fmt_cmd *cfg;
+       struct apm_module_param_data *param_data;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+
+       if (num_channels > 2) {
+               dev_err(graph->dev, "Error: Invalid channels (%d)!\n", num_channels);
+               return -EINVAL;
+       }
+
+       payload_size = APM_PCM_MODULE_FMT_CMD_PSIZE(num_channels);
+
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       cfg = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = &cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_PCM_OUTPUT_FORMAT_CFG;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+
+       cfg->header.data_format = DATA_FORMAT_FIXED_POINT;
+       cfg->header.fmt_id = MEDIA_FMT_ID_PCM;
+       cfg->header.payload_size = APM_PCM_OUT_FMT_CFG_PSIZE(media_cfg, num_channels);
+
+       media_cfg = &cfg->media_cfg;
+       media_cfg->alignment = PCM_LSB_ALIGNED;
+       media_cfg->bit_width = mcfg->bit_width;
+       media_cfg->endianness = PCM_LITTLE_ENDIAN;
+       media_cfg->interleaved = module->interleave_type;
+       media_cfg->num_channels = mcfg->num_channels;
+       media_cfg->q_factor = mcfg->bit_width - 1;
+       media_cfg->bits_per_sample = mcfg->bit_width;
+
+       if (num_channels == 1) {
+               media_cfg->channel_mapping[0] = PCM_CHANNEL_L;
+       } else if (num_channels == 2) {
+               media_cfg->channel_mapping[0] = PCM_CHANNEL_L;
+               media_cfg->channel_mapping[1] = PCM_CHANNEL_R;
+
+       }
+
+       rc = q6apm_send_cmd_sync(graph->apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+static int audioreach_shmem_set_media_format(struct q6apm_graph *graph,
+                                            struct audioreach_module *module,
+                                            struct audioreach_module_config *mcfg)
+{
+       uint32_t num_channels = mcfg->num_channels;
+       struct apm_module_param_data *param_data;
+       struct payload_media_fmt_pcm *cfg;
+       struct media_format *header;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       if (num_channels > 2) {
+               dev_err(graph->dev, "Error: Invalid channels (%d)!\n", num_channels);
+               return -EINVAL;
+       }
+
+       payload_size = APM_SHMEM_FMT_CFG_PSIZE(num_channels) + APM_MODULE_PARAM_DATA_SIZE;
+
+       pkt = audioreach_alloc_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0,
+                                    graph->port->id, module->instance_id);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = p;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_MEDIA_FORMAT;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+       p = p + APM_MODULE_PARAM_DATA_SIZE;
+
+       header = p;
+       header->data_format = DATA_FORMAT_FIXED_POINT;
+       header->fmt_id = MEDIA_FMT_ID_PCM;
+       header->payload_size = payload_size - sizeof(*header);
+
+       p = p + sizeof(*header);
+       cfg = p;
+       cfg->sample_rate = mcfg->sample_rate;
+       cfg->bit_width = mcfg->bit_width;
+       cfg->alignment = PCM_LSB_ALIGNED;
+       cfg->bits_per_sample = mcfg->bit_width;
+       cfg->q_factor = mcfg->bit_width - 1;
+       cfg->endianness = PCM_LITTLE_ENDIAN;
+       cfg->num_channels = mcfg->num_channels;
+
+       if (mcfg->num_channels == 1) {
+               cfg->channel_mapping[0] =  PCM_CHANNEL_L;
+       } else if (num_channels == 2) {
+               cfg->channel_mapping[0] =  PCM_CHANNEL_L;
+               cfg->channel_mapping[1] =  PCM_CHANNEL_R;
+       }
+
+       rc = audioreach_graph_send_cmd_sync(graph, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+int audioreach_gain_set_vol_ctrl(struct q6apm *apm, struct audioreach_module *module, int vol)
+{
+       struct param_id_vol_ctrl_master_gain *cfg;
+       struct apm_module_param_data *param_data;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+       void *p;
+
+       payload_size = sizeof(*cfg) + APM_MODULE_PARAM_DATA_SIZE;
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = p;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_VOL_CTRL_MASTER_GAIN;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+
+       p = p + APM_MODULE_PARAM_DATA_SIZE;
+       cfg = p;
+       cfg->master_gain =  vol;
+       rc = q6apm_send_cmd_sync(apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(audioreach_gain_set_vol_ctrl);
+
+static int audioreach_gain_set(struct q6apm_graph *graph, struct audioreach_module *module)
+{
+       struct apm_module_param_data *param_data;
+       struct apm_gain_module_cfg *cfg;
+       int rc, payload_size;
+       struct gpr_pkt *pkt;
+
+       payload_size = APM_GAIN_CFG_PSIZE;
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, APM_CMD_SET_CFG, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       cfg = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = &cfg->param_data;
+       param_data->module_instance_id = module->instance_id;
+       param_data->error_code = 0;
+       param_data->param_id = APM_PARAM_ID_GAIN;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+
+       cfg->gain_cfg.gain = module->gain;
+
+       rc = q6apm_send_cmd_sync(graph->apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+int audioreach_set_media_format(struct q6apm_graph *graph, struct audioreach_module *module,
+                               struct audioreach_module_config *cfg)
+{
+       int rc;
+
+       switch (module->module_id) {
+       case MODULE_ID_DATA_LOGGING:
+               rc = audioreach_logging_set_media_format(graph, module);
+               break;
+       case MODULE_ID_PCM_DEC:
+       case MODULE_ID_PCM_ENC:
+       case MODULE_ID_PCM_CNV:
+               rc = audioreach_pcm_set_media_format(graph, module, cfg);
+               break;
+       case MODULE_ID_I2S_SOURCE:
+       case MODULE_ID_I2S_SINK:
+               rc = audioreach_i2s_set_media_format(graph, module, cfg);
+               break;
+       case MODULE_ID_WR_SHARED_MEM_EP:
+               rc = audioreach_shmem_set_media_format(graph, module, cfg);
+               break;
+       case MODULE_ID_GAIN:
+               rc = audioreach_gain_set(graph, module);
+               break;
+       case MODULE_ID_CODEC_DMA_SINK:
+       case MODULE_ID_CODEC_DMA_SOURCE:
+               rc = audioreach_codec_dma_set_media_format(graph, module, cfg);
+               break;
+       default:
+               rc = 0;
+       }
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(audioreach_set_media_format);
+
+void audioreach_graph_free_buf(struct q6apm_graph *graph)
+{
+       struct audioreach_graph_data *port;
+
+       mutex_lock(&graph->lock);
+       port = &graph->rx_data;
+       port->num_periods = 0;
+       kfree(port->buf);
+       port->buf = NULL;
+
+       port = &graph->tx_data;
+       port->num_periods = 0;
+       kfree(port->buf);
+       port->buf = NULL;
+       mutex_unlock(&graph->lock);
+}
+EXPORT_SYMBOL_GPL(audioreach_graph_free_buf);
+
+int audioreach_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, size_t period_sz,
+                                 unsigned int periods, bool is_contiguous)
+{
+       struct apm_shared_map_region_payload *mregions;
+       struct apm_cmd_shared_mem_map_regions *cmd;
+       uint32_t num_regions, buf_sz, payload_size;
+       struct audioreach_graph_data *data;
+       struct gpr_pkt *pkt;
+       void *p;
+       int rc, i;
+
+       if (dir == SNDRV_PCM_STREAM_PLAYBACK)
+               data = &graph->rx_data;
+       else
+               data = &graph->tx_data;
+
+       if (is_contiguous) {
+               num_regions = 1;
+               buf_sz = period_sz * periods;
+       } else {
+               buf_sz = period_sz;
+               num_regions = periods;
+       }
+
+       /* DSP expects size should be aligned to 4K */
+       buf_sz = ALIGN(buf_sz, 4096);
+
+       payload_size = sizeof(*cmd) + (sizeof(*mregions) * num_regions);
+
+       pkt = audioreach_alloc_apm_pkt(payload_size, APM_CMD_SHARED_MEM_MAP_REGIONS, dir,
+                                    graph->port->id);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       p = (void *)pkt + GPR_HDR_SIZE;
+       cmd = p;
+       cmd->mem_pool_id = APM_MEMORY_MAP_SHMEM8_4K_POOL;
+       cmd->num_regions = num_regions;
+
+       cmd->property_flag = 0x0;
+
+       mregions = p + sizeof(*cmd);
+
+       mutex_lock(&graph->lock);
+
+       for (i = 0; i < num_regions; i++) {
+               struct audio_buffer *ab;
+
+               ab = &data->buf[i];
+               mregions->shm_addr_lsw = lower_32_bits(ab->phys);
+               mregions->shm_addr_msw = upper_32_bits(ab->phys);
+               mregions->mem_size_bytes = buf_sz;
+               ++mregions;
+       }
+       mutex_unlock(&graph->lock);
+
+       rc = audioreach_graph_send_cmd_sync(graph, pkt, APM_CMD_RSP_SHARED_MEM_MAP_REGIONS);
+
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(audioreach_map_memory_regions);
+
+int audioreach_shared_memory_send_eos(struct q6apm_graph *graph)
+{
+       struct data_cmd_wr_sh_mem_ep_eos *eos;
+       struct gpr_pkt *pkt;
+       int rc = 0, iid;
+
+       iid = q6apm_graph_get_rx_shmem_module_iid(graph);
+       pkt = audioreach_alloc_cmd_pkt(sizeof(*eos), DATA_CMD_WR_SH_MEM_EP_EOS, 0,
+                                      graph->port->id, iid);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       eos = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       eos->policy = WR_SH_MEM_EP_EOS_POLICY_LAST;
+
+       rc = gpr_send_port_pkt(graph->port, pkt);
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(audioreach_shared_memory_send_eos);
diff --git a/sound/soc/qcom/qdsp6/audioreach.h b/sound/soc/qcom/qdsp6/audioreach.h
new file mode 100644 (file)
index 0000000..4f693a2
--- /dev/null
@@ -0,0 +1,726 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __AUDIOREACH_H__
+#define __AUDIOREACH_H__
+#include <linux/types.h>
+#include <linux/soc/qcom/apr.h>
+#include <sound/soc.h>
+struct q6apm;
+struct q6apm_graph;
+
+/* Module IDs */
+#define MODULE_ID_WR_SHARED_MEM_EP     0x07001000
+#define MODULE_ID_RD_SHARED_MEM_EP     0x07001001
+#define MODULE_ID_GAIN                 0x07001002
+#define MODULE_ID_PCM_CNV              0x07001003
+#define MODULE_ID_PCM_ENC              0x07001004
+#define MODULE_ID_PCM_DEC              0x07001005
+#define MODULE_ID_CODEC_DMA_SINK       0x07001023
+#define MODULE_ID_CODEC_DMA_SOURCE     0x07001024
+#define MODULE_ID_I2S_SINK             0x0700100A
+#define MODULE_ID_I2S_SOURCE           0x0700100B
+#define MODULE_ID_DATA_LOGGING         0x0700101A
+
+#define APM_CMD_GET_SPF_STATE          0x01001021
+#define APM_CMD_RSP_GET_SPF_STATE      0x02001007
+
+#define APM_MODULE_INSTANCE_ID         0x00000001
+#define PRM_MODULE_INSTANCE_ID         0x00000002
+#define AMDB_MODULE_INSTANCE_ID                0x00000003
+#define VCPM_MODULE_INSTANCE_ID                0x00000004
+#define AR_MODULE_INSTANCE_ID_START    0x00006000
+#define AR_MODULE_INSTANCE_ID_END      0x00007000
+#define AR_MODULE_DYNAMIC_INSTANCE_ID_START    0x00007000
+#define AR_MODULE_DYNAMIC_INSTANCE_ID_END      0x00008000
+#define AR_CONT_INSTANCE_ID_START      0x00005000
+#define AR_CONT_INSTANCE_ID_END                0x00006000
+#define AR_SG_INSTANCE_ID_START                0x00004000
+
+#define APM_CMD_GRAPH_OPEN                     0x01001000
+#define APM_CMD_GRAPH_PREPARE                  0x01001001
+#define APM_CMD_GRAPH_START                    0x01001002
+#define APM_CMD_GRAPH_STOP                     0x01001003
+#define APM_CMD_GRAPH_CLOSE                    0x01001004
+#define APM_CMD_GRAPH_FLUSH                    0x01001005
+#define APM_CMD_SET_CFG                                0x01001006
+#define APM_CMD_GET_CFG                                0x01001007
+#define APM_CMD_SHARED_MEM_MAP_REGIONS         0x0100100C
+#define APM_CMD_SHARED_MEM_UNMAP_REGIONS       0x0100100D
+#define APM_CMD_RSP_SHARED_MEM_MAP_REGIONS     0x02001001
+#define APM_CMD_RSP_GET_CFG                    0x02001000
+#define APM_CMD_CLOSE_ALL                      0x01001013
+#define APM_CMD_REGISTER_SHARED_CFG            0x0100100A
+
+#define APM_MEMORY_MAP_SHMEM8_4K_POOL          3
+
+struct apm_cmd_shared_mem_map_regions {
+       uint16_t mem_pool_id;
+       uint16_t num_regions;
+       uint32_t property_flag;
+} __packed;
+
+struct apm_shared_map_region_payload {
+       uint32_t shm_addr_lsw;
+       uint32_t shm_addr_msw;
+       uint32_t mem_size_bytes;
+} __packed;
+
+struct apm_cmd_shared_mem_unmap_regions {
+       uint32_t mem_map_handle;
+} __packed;
+
+struct apm_cmd_rsp_shared_mem_map_regions {
+       uint32_t mem_map_handle;
+} __packed;
+
+/* APM module */
+#define APM_PARAM_ID_SUB_GRAPH_LIST            0x08001005
+
+#define APM_PARAM_ID_MODULE_LIST               0x08001002
+
+struct apm_param_id_modules_list {
+       uint32_t num_modules_list;
+} __packed;
+
+#define APM_PARAM_ID_MODULE_PROP               0x08001003
+
+struct apm_param_id_module_prop {
+       uint32_t num_modules_prop_cfg;
+} __packed;
+
+struct apm_module_prop_cfg {
+       uint32_t instance_id;
+       uint32_t num_props;
+} __packed;
+
+#define APM_PARAM_ID_MODULE_CONN               0x08001004
+
+struct apm_param_id_module_conn {
+       uint32_t num_connections;
+} __packed;
+
+struct apm_module_conn_obj {
+       uint32_t src_mod_inst_id;
+       uint32_t src_mod_op_port_id;
+       uint32_t dst_mod_inst_id;
+       uint32_t dst_mod_ip_port_id;
+} __packed;
+
+#define APM_PARAM_ID_GAIN                      0x08001006
+
+struct param_id_gain_cfg {
+       uint16_t gain;
+       uint16_t reserved;
+} __packed;
+
+#define PARAM_ID_PCM_OUTPUT_FORMAT_CFG         0x08001008
+
+struct param_id_pcm_output_format_cfg {
+       uint32_t data_format;
+       uint32_t fmt_id;
+       uint32_t payload_size;
+} __packed;
+
+struct payload_pcm_output_format_cfg {
+       uint16_t bit_width;
+       uint16_t alignment;
+       uint16_t bits_per_sample;
+       uint16_t q_factor;
+       uint16_t endianness;
+       uint16_t interleaved;
+       uint16_t reserved;
+       uint16_t num_channels;
+       uint8_t channel_mapping[];
+} __packed;
+
+#define PARAM_ID_ENC_BITRATE                   0x08001052
+
+struct param_id_enc_bitrate_param {
+       uint32_t bitrate;
+} __packed;
+
+#define DATA_FORMAT_FIXED_POINT                1
+#define PCM_LSB_ALIGNED                        1
+#define PCM_MSB_ALIGNED                        2
+#define PCM_LITTLE_ENDIAN              1
+#define PCM_BIT_ENDIAN                 2
+
+#define MEDIA_FMT_ID_PCM       0x09001000
+#define PCM_CHANNEL_L          1
+#define PCM_CHANNEL_R          2
+#define SAMPLE_RATE_48K                48000
+#define BIT_WIDTH_16           16
+
+#define APM_PARAM_ID_PROP_PORT_INFO            0x08001015
+
+struct apm_modules_prop_info {
+       uint32_t max_ip_port;
+       uint32_t max_op_port;
+} __packed;
+
+/* Shared memory module */
+#define DATA_CMD_WR_SH_MEM_EP_DATA_BUFFER      0x04001000
+#define WR_SH_MEM_EP_TIMESTAMP_VALID_FLAG      BIT(31)
+#define WR_SH_MEM_EP_LAST_BUFFER_FLAG          BIT(30)
+#define WR_SH_MEM_EP_TS_CONTINUE_FLAG          BIT(29)
+#define WR_SH_MEM_EP_EOF_FLAG                  BIT(4)
+
+struct apm_data_cmd_wr_sh_mem_ep_data_buffer {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t buf_size;
+       uint32_t timestamp_lsw;
+       uint32_t timestamp_msw;
+       uint32_t flags;
+} __packed;
+
+#define DATA_CMD_WR_SH_MEM_EP_DATA_BUFFER_V2   0x0400100A
+
+struct apm_data_cmd_wr_sh_mem_ep_data_buffer_v2 {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t buf_size;
+       uint32_t timestamp_lsw;
+       uint32_t timestamp_msw;
+       uint32_t flags;
+       uint32_t md_addr_lsw;
+       uint32_t md_addr_msw;
+       uint32_t md_map_handle;
+       uint32_t md_buf_size;
+} __packed;
+
+#define DATA_CMD_RSP_WR_SH_MEM_EP_DATA_BUFFER_DONE     0x05001000
+
+struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t status;
+
+} __packed;
+
+#define DATA_CMD_RSP_WR_SH_MEM_EP_DATA_BUFFER_DONE_V2  0x05001004
+
+struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done_v2 {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t status;
+       uint32_t md_buf_addr_lsw;
+       uint32_t md_buf_addr_msw;
+       uint32_t md_mem_map_handle;
+       uint32_t md_status;
+} __packed;
+
+#define PARAM_ID_MEDIA_FORMAT                          0x0800100C
+#define DATA_CMD_WR_SH_MEM_EP_MEDIA_FORMAT             0x04001001
+
+struct apm_media_format {
+       uint32_t data_format;
+       uint32_t fmt_id;
+       uint32_t payload_size;
+} __packed;
+
+#define DATA_CMD_WR_SH_MEM_EP_EOS                      0x04001002
+#define WR_SH_MEM_EP_EOS_POLICY_LAST   1
+#define WR_SH_MEM_EP_EOS_POLICY_EACH   2
+
+struct data_cmd_wr_sh_mem_ep_eos {
+       uint32_t policy;
+
+} __packed;
+
+#define DATA_CMD_RD_SH_MEM_EP_DATA_BUFFER              0x04001003
+
+struct data_cmd_rd_sh_mem_ep_data_buffer {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t buf_size;
+} __packed;
+
+#define DATA_CMD_RSP_RD_SH_MEM_EP_DATA_BUFFER          0x05001002
+
+struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done {
+       uint32_t status;
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t data_size;
+       uint32_t offset;
+       uint32_t timestamp_lsw;
+       uint32_t timestamp_msw;
+       uint32_t flags;
+       uint32_t num_frames;
+} __packed;
+
+#define DATA_CMD_RD_SH_MEM_EP_DATA_BUFFER_V2           0x0400100B
+
+struct data_cmd_rd_sh_mem_ep_data_buffer_v2 {
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t buf_size;
+       uint32_t md_buf_addr_lsw;
+       uint32_t md_buf_addr_msw;
+       uint32_t md_mem_map_handle;
+       uint32_t md_buf_size;
+} __packed;
+
+#define DATA_CMD_RSP_RD_SH_MEM_EP_DATA_BUFFER_V2       0x05001005
+
+struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done_v2 {
+       uint32_t status;
+       uint32_t buf_addr_lsw;
+       uint32_t buf_addr_msw;
+       uint32_t mem_map_handle;
+       uint32_t data_size;
+       uint32_t offset;
+       uint32_t timestamp_lsw;
+       uint32_t timestamp_msw;
+       uint32_t flags;
+       uint32_t num_frames;
+       uint32_t md_status;
+       uint32_t md_buf_addr_lsw;
+       uint32_t md_buf_addr_msw;
+       uint32_t md_mem_map_handle;
+       uint32_t md_size;
+} __packed;
+
+#define PARAM_ID_RD_SH_MEM_CFG                         0x08001007
+
+struct param_id_rd_sh_mem_cfg {
+       uint32_t num_frames_per_buffer;
+       uint32_t metadata_control_flags;
+
+} __packed;
+
+#define DATA_CMD_WR_SH_MEM_EP_EOS_RENDERED             0x05001001
+
+struct data_cmd_wr_sh_mem_ep_eos_rendered {
+       uint32_t module_instance_id;
+       uint32_t render_status;
+} __packed;
+
+#define MODULE_ID_WR_SHARED_MEM_EP                     0x07001000
+
+struct apm_cmd_header {
+       uint32_t payload_address_lsw;
+       uint32_t payload_address_msw;
+       uint32_t mem_map_handle;
+       uint32_t payload_size;
+} __packed;
+
+#define APM_CMD_HDR_SIZE sizeof(struct apm_cmd_header)
+
+struct apm_module_param_data  {
+       uint32_t module_instance_id;
+       uint32_t param_id;
+       uint32_t param_size;
+       uint32_t error_code;
+} __packed;
+
+#define APM_MODULE_PARAM_DATA_SIZE     sizeof(struct apm_module_param_data)
+
+struct apm_module_param_shared_data  {
+       uint32_t param_id;
+       uint32_t param_size;
+} __packed;
+
+struct apm_prop_data {
+       uint32_t prop_id;
+       uint32_t prop_size;
+} __packed;
+
+/* Sub-Graph Properties */
+#define APM_PARAM_ID_SUB_GRAPH_CONFIG  0x08001001
+
+struct apm_param_id_sub_graph_cfg {
+       uint32_t num_sub_graphs;
+} __packed;
+
+struct apm_sub_graph_cfg {
+       uint32_t sub_graph_id;
+       uint32_t num_sub_graph_prop;
+} __packed;
+
+#define APM_SUB_GRAPH_PROP_ID_PERF_MODE                0x0800100E
+
+struct apm_sg_prop_id_perf_mode {
+       uint32_t perf_mode;
+} __packed;
+
+#define APM_SG_PROP_ID_PERF_MODE_SIZE  4
+
+#define APM_SUB_GRAPH_PROP_ID_DIRECTION        0x0800100F
+
+struct apm_sg_prop_id_direction {
+       uint32_t direction;
+} __packed;
+
+#define APM_SG_PROP_ID_DIR_SIZE                4
+
+#define APM_SUB_GRAPH_PROP_ID_SCENARIO_ID      0x08001010
+#define APM_SUB_GRAPH_SID_AUDIO_PLAYBACK       0x1
+#define APM_SUB_GRAPH_SID_AUDIO_RECORD         0x2
+#define APM_SUB_GRAPH_SID_AUDIO_VOICE_CALL     0x3
+
+struct apm_sg_prop_id_scenario_id {
+       uint32_t scenario_id;
+} __packed;
+
+#define APM_SG_PROP_ID_SID_SIZE                        4
+/* container api */
+#define APM_PARAM_ID_CONTAINER_CONFIG          0x08001000
+
+struct apm_param_id_container_cfg {
+       uint32_t num_containers;
+} __packed;
+
+struct apm_container_cfg {
+       uint32_t container_id;
+       uint32_t num_prop;
+} __packed;
+
+struct apm_cont_capability  {
+       uint32_t capability_id;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_CAPABILITY_LIST  0x08001011
+#define APM_CONTAINER_PROP_ID_CAPABILITY_SIZE  8
+
+#define APM_PROP_ID_INVALID                    0x0
+#define APM_CONTAINER_CAP_ID_PP                        0x1
+#define APM_CONTAINER_CAP_ID_PP                        0x1
+
+struct apm_cont_prop_id_cap_list  {
+       uint32_t num_capability_id;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_GRAPH_POS                0x08001012
+
+struct apm_cont_prop_id_graph_pos  {
+       uint32_t graph_pos;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_STACK_SIZE       0x08001013
+
+struct apm_cont_prop_id_stack_size  {
+       uint32_t stack_size;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_PROC_DOMAIN      0x08001014
+
+struct apm_cont_prop_id_domain  {
+       uint32_t proc_domain;
+} __packed;
+
+#define CONFIG_I2S_WS_SRC_EXTERNAL             0x0
+#define CONFIG_I2S_WS_SRC_INTERNAL             0x1
+
+#define PARAM_ID_I2S_INTF_CFG                  0x08001019
+struct param_id_i2s_intf_cfg {
+       uint32_t lpaif_type;
+       uint32_t intf_idx;
+       uint16_t sd_line_idx;
+       uint16_t ws_src;
+} __packed;
+
+#define I2S_INTF_TYPE_PRIMARY          0
+#define I2S_INTF_TYPE_SECOINDARY       1
+#define I2S_INTF_TYPE_TERTINARY                2
+#define I2S_INTF_TYPE_QUATERNARY       3
+#define I2S_INTF_TYPE_QUINARY          4
+#define I2S_SD0                                1
+#define I2S_SD1                                2
+#define I2S_SD2                                3
+#define I2S_SD3                                4
+
+#define PORT_ID_I2S_INPUT              2
+#define PORT_ID_I2S_OUPUT              1
+#define I2S_STACK_SIZE                 2048
+
+#define PARAM_ID_HW_EP_MF_CFG                  0x08001017
+struct param_id_hw_ep_mf {
+       uint32_t sample_rate;
+       uint16_t bit_width;
+       uint16_t num_channels;
+       uint32_t data_format;
+} __packed;
+
+#define PARAM_ID_HW_EP_FRAME_SIZE_FACTOR       0x08001018
+
+struct param_id_fram_size_factor {
+       uint32_t frame_size_factor;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_PARENT_CONTAINER_ID      0x080010CB
+
+struct apm_cont_prop_id_parent_container  {
+       uint32_t parent_container_id;
+} __packed;
+
+#define APM_CONTAINER_PROP_ID_HEAP_ID                  0x08001174
+#define APM_CONT_HEAP_DEFAULT                          0x1
+#define APM_CONT_HEAP_LOW_POWER                                0x2
+
+struct apm_cont_prop_id_headp_id  {
+       uint32_t heap_id;
+} __packed;
+
+struct apm_modules_list {
+       uint32_t sub_graph_id;
+       uint32_t container_id;
+       uint32_t num_modules;
+} __packed;
+
+struct apm_module_obj {
+       uint32_t module_id;
+       uint32_t instance_id;
+} __packed;
+
+#define APM_MODULE_PROP_ID_PORT_INFO           0x08001015
+#define APM_MODULE_PROP_ID_PORT_INFO_SZ                8
+struct apm_module_prop_id_port_info {
+       uint32_t max_ip_port;
+       uint32_t max_op_port;
+} __packed;
+
+#define DATA_LOGGING_MAX_INPUT_PORTS           0x1
+#define DATA_LOGGING_MAX_OUTPUT_PORTS          0x1
+#define DATA_LOGGING_STACK_SIZE                        2048
+#define PARAM_ID_DATA_LOGGING_CONFIG           0x08001031
+
+struct data_logging_config {
+       uint32_t log_code;
+       uint32_t log_tap_point_id;
+       uint32_t mode;
+} __packed;
+
+#define PARAM_ID_MFC_OUTPUT_MEDIA_FORMAT       0x08001024
+
+struct param_id_mfc_media_format {
+       uint32_t sample_rate;
+       uint16_t bit_width;
+       uint16_t num_channels;
+       uint16_t channel_mapping[];
+} __packed;
+
+struct media_format {
+       uint32_t data_format;
+       uint32_t fmt_id;
+       uint32_t payload_size;
+} __packed;
+
+struct payload_media_fmt_pcm {
+       uint32_t sample_rate;
+       uint16_t bit_width;
+       uint16_t alignment;
+       uint16_t bits_per_sample;
+       uint16_t q_factor;
+       uint16_t endianness;
+       uint16_t num_channels;
+       uint8_t channel_mapping[];
+} __packed;
+
+#define PARAM_ID_CODEC_DMA_INTF_CFG            0x08001063
+
+struct param_id_codec_dma_intf_cfg {
+       /* 1 - RXTX
+        * 2 - WSA
+        * 3 - VA
+        * 4 - AXI
+        */
+       uint32_t lpaif_type;
+       /*
+        *  RX0 | TX0 = 1
+        *  RX1 | TX1 = 2
+        *  RX2 | TX2 = 3... so on
+        */
+       uint32_t intf_index;
+       uint32_t active_channels_mask;
+} __packed;
+
+struct audio_hw_clk_cfg {
+       uint32_t clock_id;
+       uint32_t clock_freq;
+       uint32_t clock_attri;
+       uint32_t clock_root;
+} __packed;
+
+#define PARAM_ID_HW_EP_POWER_MODE_CFG  0x8001176
+#define AR_HW_EP_POWER_MODE_0  0 /* default */
+#define AR_HW_EP_POWER_MODE_1  1 /* XO Shutdown allowed */
+#define AR_HW_EP_POWER_MODE_2  2 /* XO Shutdown not allowed */
+
+struct param_id_hw_ep_power_mode_cfg {
+       uint32_t power_mode;
+} __packed;
+
+#define PARAM_ID_HW_EP_DMA_DATA_ALIGN  0x08001233
+#define AR_HW_EP_DMA_DATA_ALIGN_MSB    0
+#define AR_HW_EP_DMA_DATA_ALIGN_LSB    1
+#define AR_PCM_MAX_NUM_CHANNEL         8
+
+struct param_id_hw_ep_dma_data_align {
+       uint32_t dma_data_align;
+} __packed;
+
+#define PARAM_ID_VOL_CTRL_MASTER_GAIN  0x08001035
+#define VOL_CTRL_DEFAULT_GAIN          0x2000
+
+struct param_id_vol_ctrl_master_gain {
+       uint16_t master_gain;
+       uint16_t reserved;
+} __packed;
+
+
+/* Graph */
+struct audioreach_connection {
+       /* Connections */
+       uint32_t src_mod_inst_id;
+       uint32_t src_mod_op_port_id;
+       uint32_t dst_mod_inst_id;
+       uint32_t dst_mod_ip_port_id;
+       struct list_head node;
+};
+
+struct audioreach_graph_info {
+       int id;
+       uint32_t num_sub_graphs;
+       struct list_head sg_list;
+       struct list_head connection_list;
+};
+
+struct audioreach_sub_graph {
+       uint32_t sub_graph_id;
+       uint32_t perf_mode;
+       uint32_t direction;
+       uint32_t scenario_id;
+       struct list_head node;
+
+       struct audioreach_graph_info *info;
+       uint32_t num_containers;
+       struct list_head container_list;
+};
+
+struct audioreach_container {
+       uint32_t container_id;
+       uint32_t capability_id;
+       uint32_t graph_pos;
+       uint32_t stack_size;
+       uint32_t proc_domain;
+       struct list_head node;
+
+       uint32_t num_modules;
+       struct list_head modules_list;
+       struct audioreach_sub_graph *sub_graph;
+};
+
+struct audioreach_module {
+       uint32_t module_id;
+       uint32_t instance_id;
+
+       uint32_t max_ip_port;
+       uint32_t max_op_port;
+
+       uint32_t in_port;
+       uint32_t out_port;
+
+       /* Connections */
+       uint32_t src_mod_inst_id;
+       uint32_t src_mod_op_port_id;
+       uint32_t dst_mod_inst_id;
+       uint32_t dst_mod_ip_port_id;
+
+       /* Format specifics */
+       uint32_t ch_fmt;
+       uint32_t rate;
+       uint32_t bit_depth;
+
+       /* I2S module */
+       uint32_t hw_interface_idx;
+       uint32_t sd_line_idx;
+       uint32_t ws_src;
+       uint32_t frame_size_factor;
+       uint32_t data_format;
+       uint32_t hw_interface_type;
+
+       /* PCM module specific */
+       uint32_t interleave_type;
+
+       /* GAIN/Vol Control Module */
+       uint16_t gain;
+
+       /* Logging */
+       uint32_t log_code;
+       uint32_t log_tap_point_id;
+       uint32_t log_mode;
+
+       /* bookkeeping */
+       struct list_head node;
+       struct audioreach_container *container;
+       struct snd_soc_dapm_widget *widget;
+};
+
+struct audioreach_module_config {
+       int     direction;
+       u32     sample_rate;
+       u16     bit_width;
+       u16     bits_per_sample;
+
+       u16     data_format;
+       u16     num_channels;
+       u16     active_channels_mask;
+       u32     sd_line_mask;
+       int     fmt;
+       u8 channel_map[AR_PCM_MAX_NUM_CHANNEL];
+};
+
+/* Packet Allocation routines */
+void *audioreach_alloc_apm_cmd_pkt(int pkt_size, uint32_t opcode, uint32_t
+                                   token);
+void *audioreach_alloc_cmd_pkt(int payload_size, uint32_t opcode,
+                              uint32_t token, uint32_t src_port,
+                              uint32_t dest_port);
+void *audioreach_alloc_apm_pkt(int pkt_size, uint32_t opcode, uint32_t token,
+                               uint32_t src_port);
+void *audioreach_alloc_pkt(int payload_size, uint32_t opcode,
+                          uint32_t token, uint32_t src_port,
+                          uint32_t dest_port);
+void *audioreach_alloc_graph_pkt(struct q6apm *apm,
+                                struct list_head *sg_list,
+                                 int graph_id);
+/* Topology specific */
+int audioreach_tplg_init(struct snd_soc_component *component);
+
+/* Module specific */
+void audioreach_graph_free_buf(struct q6apm_graph *graph);
+int audioreach_map_memory_regions(struct q6apm_graph *graph,
+                                 unsigned int dir, size_t period_sz,
+                                 unsigned int periods,
+                                 bool is_contiguous);
+int audioreach_send_cmd_sync(struct device *dev, gpr_device_t *gdev, struct gpr_ibasic_rsp_result_t *result,
+                            struct mutex *cmd_lock, gpr_port_t *port, wait_queue_head_t *cmd_wait,
+                            struct gpr_pkt *pkt, uint32_t rsp_opcode);
+int audioreach_graph_send_cmd_sync(struct q6apm_graph *graph, struct gpr_pkt *pkt,
+                                  uint32_t rsp_opcode);
+int audioreach_set_media_format(struct q6apm_graph *graph,
+                               struct audioreach_module *module,
+                               struct audioreach_module_config *cfg);
+int audioreach_shared_memory_send_eos(struct q6apm_graph *graph);
+int audioreach_gain_set_vol_ctrl(struct q6apm *apm,
+                                struct audioreach_module *module, int vol);
+struct audioreach_module *audioreach_get_container_last_module(
+                               struct audioreach_container *container);
+struct audioreach_module *audioreach_get_container_first_module(
+                               struct audioreach_container *container);
+struct audioreach_module *audioreach_get_container_next_module(
+                               struct audioreach_container *container,
+                               struct audioreach_module *module);
+#define list_for_each_container_module(mod, cont) \
+       for (mod = audioreach_get_container_first_module(cont); mod != NULL; \
+            mod = audioreach_get_container_next_module(cont, mod))
+#endif /* __AUDIOREACH_H__ */
index 9431656..1ccab64 100644 (file)
 #include <linux/module.h>
 #include <linux/device.h>
 #include <linux/platform_device.h>
-#include <linux/of.h>
-#include <linux/slab.h>
+#include "q6dsp-lpass-clocks.h"
 #include "q6afe.h"
 
 #define Q6AFE_CLK(id) {                                        \
                .clk_id = id,                           \
-               .afe_clk_id     = Q6AFE_##id,           \
+               .q6dsp_clk_id   = Q6AFE_##id,           \
                .name = #id,                            \
                .rate = 19200000,                       \
        }
 
-#define Q6AFE_VOTE_CLK(id, blkid, n) {                 \
-               .clk_id = id,                           \
-               .afe_clk_id = blkid,                    \
-               .name = n,                              \
-       }
-
-struct q6afe_clk_init {
-       int clk_id;
-       int afe_clk_id;
-       char *name;
-       int rate;
-};
-
-struct q6afe_clk {
-       struct device *dev;
-       int afe_clk_id;
-       int attributes;
-       int rate;
-       uint32_t handle;
-       struct clk_hw hw;
-};
-
-#define to_q6afe_clk(_hw) container_of(_hw, struct q6afe_clk, hw)
-
-struct q6afe_cc {
-       struct device *dev;
-       struct q6afe_clk *clks[Q6AFE_MAX_CLK_ID];
-};
-
-static int clk_q6afe_prepare(struct clk_hw *hw)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       return q6afe_set_lpass_clock(clk->dev, clk->afe_clk_id, clk->attributes,
-                                    Q6AFE_LPASS_CLK_ROOT_DEFAULT, clk->rate);
-}
-
-static void clk_q6afe_unprepare(struct clk_hw *hw)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       q6afe_set_lpass_clock(clk->dev, clk->afe_clk_id, clk->attributes,
-                             Q6AFE_LPASS_CLK_ROOT_DEFAULT, 0);
-}
-
-static int clk_q6afe_set_rate(struct clk_hw *hw, unsigned long rate,
-                             unsigned long parent_rate)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       clk->rate = rate;
-
-       return 0;
-}
-
-static unsigned long clk_q6afe_recalc_rate(struct clk_hw *hw,
-                                          unsigned long parent_rate)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       return clk->rate;
-}
-
-static long clk_q6afe_round_rate(struct clk_hw *hw, unsigned long rate,
-                                unsigned long *parent_rate)
-{
-       return rate;
-}
-
-static const struct clk_ops clk_q6afe_ops = {
-       .prepare        = clk_q6afe_prepare,
-       .unprepare      = clk_q6afe_unprepare,
-       .set_rate       = clk_q6afe_set_rate,
-       .round_rate     = clk_q6afe_round_rate,
-       .recalc_rate    = clk_q6afe_recalc_rate,
-};
-
-static int clk_vote_q6afe_block(struct clk_hw *hw)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       return q6afe_vote_lpass_core_hw(clk->dev, clk->afe_clk_id,
-                                       clk_hw_get_name(&clk->hw), &clk->handle);
-}
 
-static void clk_unvote_q6afe_block(struct clk_hw *hw)
-{
-       struct q6afe_clk *clk = to_q6afe_clk(hw);
-
-       q6afe_unvote_lpass_core_hw(clk->dev, clk->afe_clk_id, clk->handle);
-}
-
-static const struct clk_ops clk_vote_q6afe_ops = {
-       .prepare        = clk_vote_q6afe_block,
-       .unprepare      = clk_unvote_q6afe_block,
-};
-
-static const struct q6afe_clk_init q6afe_clks[] = {
+static const struct q6dsp_clk_init q6afe_clks[] = {
        Q6AFE_CLK(LPASS_CLK_ID_PRI_MI2S_IBIT),
        Q6AFE_CLK(LPASS_CLK_ID_PRI_MI2S_EBIT),
        Q6AFE_CLK(LPASS_CLK_ID_SEC_MI2S_IBIT),
@@ -176,88 +79,28 @@ static const struct q6afe_clk_init q6afe_clks[] = {
        Q6AFE_CLK(LPASS_CLK_ID_RX_CORE_MCLK),
        Q6AFE_CLK(LPASS_CLK_ID_RX_CORE_NPL_MCLK),
        Q6AFE_CLK(LPASS_CLK_ID_VA_CORE_2X_MCLK),
-       Q6AFE_VOTE_CLK(LPASS_HW_AVTIMER_VOTE,
+       Q6DSP_VOTE_CLK(LPASS_HW_AVTIMER_VOTE,
                       Q6AFE_LPASS_CORE_AVTIMER_BLOCK,
                       "LPASS_AVTIMER_MACRO"),
-       Q6AFE_VOTE_CLK(LPASS_HW_MACRO_VOTE,
+       Q6DSP_VOTE_CLK(LPASS_HW_MACRO_VOTE,
                       Q6AFE_LPASS_CORE_HW_MACRO_BLOCK,
                       "LPASS_HW_MACRO"),
-       Q6AFE_VOTE_CLK(LPASS_HW_DCODEC_VOTE,
+       Q6DSP_VOTE_CLK(LPASS_HW_DCODEC_VOTE,
                       Q6AFE_LPASS_CORE_HW_DCODEC_BLOCK,
                       "LPASS_HW_DCODEC"),
 };
 
-static struct clk_hw *q6afe_of_clk_hw_get(struct of_phandle_args *clkspec,
-                                         void *data)
-{
-       struct q6afe_cc *cc = data;
-       unsigned int idx = clkspec->args[0];
-       unsigned int attr = clkspec->args[1];
-
-       if (idx >= Q6AFE_MAX_CLK_ID || attr > LPASS_CLK_ATTRIBUTE_COUPLE_DIVISOR) {
-               dev_err(cc->dev, "Invalid clk specifier (%d, %d)\n", idx, attr);
-               return ERR_PTR(-EINVAL);
-       }
-
-       if (cc->clks[idx]) {
-               cc->clks[idx]->attributes = attr;
-               return &cc->clks[idx]->hw;
-       }
-
-       return ERR_PTR(-ENOENT);
-}
-
-static int q6afe_clock_dev_probe(struct platform_device *pdev)
-{
-       struct q6afe_cc *cc;
-       struct device *dev = &pdev->dev;
-       int i, ret;
-
-       cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
-       if (!cc)
-               return -ENOMEM;
-
-       cc->dev = dev;
-       for (i = 0; i < ARRAY_SIZE(q6afe_clks); i++) {
-               unsigned int id = q6afe_clks[i].clk_id;
-               struct clk_init_data init = {
-                       .name =  q6afe_clks[i].name,
-               };
-               struct q6afe_clk *clk;
-
-               clk = devm_kzalloc(dev, sizeof(*clk), GFP_KERNEL);
-               if (!clk)
-                       return -ENOMEM;
-
-               clk->dev = dev;
-               clk->afe_clk_id = q6afe_clks[i].afe_clk_id;
-               clk->rate = q6afe_clks[i].rate;
-               clk->hw.init = &init;
-
-               if (clk->rate)
-                       init.ops = &clk_q6afe_ops;
-               else
-                       init.ops = &clk_vote_q6afe_ops;
-
-               cc->clks[id] = clk;
-
-               ret = devm_clk_hw_register(dev, &clk->hw);
-               if (ret)
-                       return ret;
-       }
-
-       ret = devm_of_clk_add_hw_provider(dev, q6afe_of_clk_hw_get, cc);
-       if (ret)
-               return ret;
-
-       dev_set_drvdata(dev, cc);
-
-       return 0;
-}
+static const struct q6dsp_clk_desc q6dsp_clk_q6afe __maybe_unused = {
+       .clks = q6afe_clks,
+       .num_clks = ARRAY_SIZE(q6afe_clks),
+       .lpass_set_clk = q6afe_set_lpass_clock,
+       .lpass_vote_clk = q6afe_vote_lpass_core_hw,
+       .lpass_unvote_clk = q6afe_unvote_lpass_core_hw,
+};
 
 #ifdef CONFIG_OF
 static const struct of_device_id q6afe_clock_device_id[] = {
-       { .compatible = "qcom,q6afe-clocks" },
+       { .compatible = "qcom,q6afe-clocks", .data = &q6dsp_clk_q6afe },
        {},
 };
 MODULE_DEVICE_TABLE(of, q6afe_clock_device_id);
@@ -268,7 +111,7 @@ static struct platform_driver q6afe_clock_platform_driver = {
                .name = "q6afe-clock",
                .of_match_table = of_match_ptr(q6afe_clock_device_id),
        },
-       .probe = q6afe_clock_dev_probe,
+       .probe = q6dsp_clock_dev_probe,
 };
 module_platform_driver(q6afe_clock_platform_driver);
 
index ac8f732..8bb7452 100644 (file)
 #include <sound/pcm.h>
 #include <sound/soc.h>
 #include <sound/pcm_params.h>
+#include "q6dsp-lpass-ports.h"
 #include "q6afe.h"
 
-#define Q6AFE_TDM_PB_DAI(pre, num, did) {                              \
-               .playback = {                                           \
-                       .stream_name = pre" TDM"#num" Playback",        \
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
-                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
-                               SNDRV_PCM_RATE_176400,                  \
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
-                                  SNDRV_PCM_FMTBIT_S24_LE |            \
-                                  SNDRV_PCM_FMTBIT_S32_LE,             \
-                       .channels_min = 1,                              \
-                       .channels_max = 8,                              \
-                       .rate_min = 8000,                               \
-                       .rate_max = 176400,                             \
-               },                                                      \
-               .name = #did,                                           \
-               .ops = &q6tdm_ops,                                      \
-               .id = did,                                              \
-               .probe = msm_dai_q6_dai_probe,                          \
-               .remove = msm_dai_q6_dai_remove,                        \
-       }
-
-#define Q6AFE_TDM_CAP_DAI(pre, num, did) {                             \
-               .capture = {                                            \
-                       .stream_name = pre" TDM"#num" Capture",         \
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
-                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
-                               SNDRV_PCM_RATE_176400,                  \
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
-                                  SNDRV_PCM_FMTBIT_S24_LE |            \
-                                  SNDRV_PCM_FMTBIT_S32_LE,             \
-                       .channels_min = 1,                              \
-                       .channels_max = 8,                              \
-                       .rate_min = 8000,                               \
-                       .rate_max = 176400,                             \
-               },                                                      \
-               .name = #did,                                           \
-               .ops = &q6tdm_ops,                                      \
-               .id = did,                                              \
-               .probe = msm_dai_q6_dai_probe,                          \
-               .remove = msm_dai_q6_dai_remove,                        \
-       }
-
-#define Q6AFE_CDC_DMA_RX_DAI(did) {                            \
-               .playback = {                                           \
-                       .stream_name = #did" Playback", \
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
-                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
-                               SNDRV_PCM_RATE_176400,                  \
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
-                                  SNDRV_PCM_FMTBIT_S24_LE |            \
-                                  SNDRV_PCM_FMTBIT_S32_LE,             \
-                       .channels_min = 1,                              \
-                       .channels_max = 8,                              \
-                       .rate_min = 8000,                               \
-                       .rate_max = 176400,                             \
-               },                                                      \
-               .name = #did,                                           \
-               .ops = &q6dma_ops,                                      \
-               .id = did,                                              \
-               .probe = msm_dai_q6_dai_probe,                          \
-               .remove = msm_dai_q6_dai_remove,                        \
-       }
-
-#define Q6AFE_CDC_DMA_TX_DAI(did) {                            \
-               .capture = {                                            \
-                       .stream_name = #did" Capture",          \
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
-                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
-                               SNDRV_PCM_RATE_176400,                  \
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
-                                  SNDRV_PCM_FMTBIT_S24_LE |            \
-                                  SNDRV_PCM_FMTBIT_S32_LE,             \
-                       .channels_min = 1,                              \
-                       .channels_max = 8,                              \
-                       .rate_min = 8000,                               \
-                       .rate_max = 176400,                             \
-               },                                                      \
-               .name = #did,                                           \
-               .ops = &q6dma_ops,                                      \
-               .id = did,                                              \
-               .probe = msm_dai_q6_dai_probe,                          \
-               .remove = msm_dai_q6_dai_remove,                        \
-       }
 
 struct q6afe_dai_priv_data {
        uint32_t sd_line_mask;
@@ -784,591 +702,6 @@ static int msm_dai_q6_dai_remove(struct snd_soc_dai *dai)
        return 0;
 }
 
-static struct snd_soc_dai_driver q6afe_dais[] = {
-       {
-               .playback = {
-                       .stream_name = "HDMI Playback",
-                       .rates = SNDRV_PCM_RATE_48000 |
-                                SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 2,
-                       .channels_max = 8,
-                       .rate_max =     192000,
-                       .rate_min =     48000,
-               },
-               .ops = &q6hdmi_ops,
-               .id = HDMI_RX,
-               .name = "HDMI",
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .name = "SLIMBUS_0_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_0_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .playback = {
-                       .stream_name = "Slimbus Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .name = "SLIMBUS_0_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_0_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus1 Playback",
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
-                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 2,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .name = "SLIMBUS_1_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_1_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .name = "SLIMBUS_1_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_1_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus1 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus2 Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .name = "SLIMBUS_2_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_2_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-
-       }, {
-               .name = "SLIMBUS_2_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_2_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus2 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus3 Playback",
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
-                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 2,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .name = "SLIMBUS_3_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_3_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-
-       }, {
-               .name = "SLIMBUS_3_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_3_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus3 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus4 Playback",
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
-                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 2,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .name = "SLIMBUS_4_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_4_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-
-       }, {
-               .name = "SLIMBUS_4_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_4_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus4 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus5 Playback",
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
-                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 2,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .name = "SLIMBUS_5_RX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_5_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-
-       }, {
-               .name = "SLIMBUS_5_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_5_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus5 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Slimbus6 Playback",
-                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
-                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 2,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-               .ops = &q6slim_ops,
-               .name = "SLIMBUS_6_RX",
-               .id = SLIMBUS_6_RX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-
-       }, {
-               .name = "SLIMBUS_6_TX",
-               .ops = &q6slim_ops,
-               .id = SLIMBUS_6_TX,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-               .capture = {
-                       .stream_name = "Slimbus6 Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min = 8000,
-                       .rate_max = 192000,
-               },
-       }, {
-               .playback = {
-                       .stream_name = "Primary MI2S Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = PRIMARY_MI2S_RX,
-               .name = "PRI_MI2S_RX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .capture = {
-                       .stream_name = "Primary MI2S Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = PRIMARY_MI2S_TX,
-               .name = "PRI_MI2S_TX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .playback = {
-                       .stream_name = "Secondary MI2S Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .name = "SEC_MI2S_RX",
-               .id = SECONDARY_MI2S_RX,
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .capture = {
-                       .stream_name = "Secondary MI2S Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = SECONDARY_MI2S_TX,
-               .name = "SEC_MI2S_TX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .playback = {
-                       .stream_name = "Tertiary MI2S Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .name = "TERT_MI2S_RX",
-               .id = TERTIARY_MI2S_RX,
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .capture = {
-                       .stream_name = "Tertiary MI2S Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = TERTIARY_MI2S_TX,
-               .name = "TERT_MI2S_TX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .playback = {
-                       .stream_name = "Quaternary MI2S Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .name = "QUAT_MI2S_RX",
-               .id = QUATERNARY_MI2S_RX,
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .capture = {
-                       .stream_name = "Quaternary MI2S Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = QUATERNARY_MI2S_TX,
-               .name = "QUAT_MI2S_TX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .playback = {
-                       .stream_name = "Quinary MI2S Playback",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                       SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
-                       SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     192000,
-               },
-               .id = QUINARY_MI2S_RX,
-               .name = "QUIN_MI2S_RX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       }, {
-               .capture = {
-                       .stream_name = "Quinary MI2S Capture",
-                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
-                                SNDRV_PCM_RATE_16000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
-                       .channels_min = 1,
-                       .channels_max = 8,
-                       .rate_min =     8000,
-                       .rate_max =     48000,
-               },
-               .id = QUINARY_MI2S_TX,
-               .name = "QUIN_MI2S_TX",
-               .ops = &q6i2s_ops,
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       },
-       Q6AFE_TDM_PB_DAI("Primary", 0, PRIMARY_TDM_RX_0),
-       Q6AFE_TDM_PB_DAI("Primary", 1, PRIMARY_TDM_RX_1),
-       Q6AFE_TDM_PB_DAI("Primary", 2, PRIMARY_TDM_RX_2),
-       Q6AFE_TDM_PB_DAI("Primary", 3, PRIMARY_TDM_RX_3),
-       Q6AFE_TDM_PB_DAI("Primary", 4, PRIMARY_TDM_RX_4),
-       Q6AFE_TDM_PB_DAI("Primary", 5, PRIMARY_TDM_RX_5),
-       Q6AFE_TDM_PB_DAI("Primary", 6, PRIMARY_TDM_RX_6),
-       Q6AFE_TDM_PB_DAI("Primary", 7, PRIMARY_TDM_RX_7),
-       Q6AFE_TDM_CAP_DAI("Primary", 0, PRIMARY_TDM_TX_0),
-       Q6AFE_TDM_CAP_DAI("Primary", 1, PRIMARY_TDM_TX_1),
-       Q6AFE_TDM_CAP_DAI("Primary", 2, PRIMARY_TDM_TX_2),
-       Q6AFE_TDM_CAP_DAI("Primary", 3, PRIMARY_TDM_TX_3),
-       Q6AFE_TDM_CAP_DAI("Primary", 4, PRIMARY_TDM_TX_4),
-       Q6AFE_TDM_CAP_DAI("Primary", 5, PRIMARY_TDM_TX_5),
-       Q6AFE_TDM_CAP_DAI("Primary", 6, PRIMARY_TDM_TX_6),
-       Q6AFE_TDM_CAP_DAI("Primary", 7, PRIMARY_TDM_TX_7),
-       Q6AFE_TDM_PB_DAI("Secondary", 0, SECONDARY_TDM_RX_0),
-       Q6AFE_TDM_PB_DAI("Secondary", 1, SECONDARY_TDM_RX_1),
-       Q6AFE_TDM_PB_DAI("Secondary", 2, SECONDARY_TDM_RX_2),
-       Q6AFE_TDM_PB_DAI("Secondary", 3, SECONDARY_TDM_RX_3),
-       Q6AFE_TDM_PB_DAI("Secondary", 4, SECONDARY_TDM_RX_4),
-       Q6AFE_TDM_PB_DAI("Secondary", 5, SECONDARY_TDM_RX_5),
-       Q6AFE_TDM_PB_DAI("Secondary", 6, SECONDARY_TDM_RX_6),
-       Q6AFE_TDM_PB_DAI("Secondary", 7, SECONDARY_TDM_RX_7),
-       Q6AFE_TDM_CAP_DAI("Secondary", 0, SECONDARY_TDM_TX_0),
-       Q6AFE_TDM_CAP_DAI("Secondary", 1, SECONDARY_TDM_TX_1),
-       Q6AFE_TDM_CAP_DAI("Secondary", 2, SECONDARY_TDM_TX_2),
-       Q6AFE_TDM_CAP_DAI("Secondary", 3, SECONDARY_TDM_TX_3),
-       Q6AFE_TDM_CAP_DAI("Secondary", 4, SECONDARY_TDM_TX_4),
-       Q6AFE_TDM_CAP_DAI("Secondary", 5, SECONDARY_TDM_TX_5),
-       Q6AFE_TDM_CAP_DAI("Secondary", 6, SECONDARY_TDM_TX_6),
-       Q6AFE_TDM_CAP_DAI("Secondary", 7, SECONDARY_TDM_TX_7),
-       Q6AFE_TDM_PB_DAI("Tertiary", 0, TERTIARY_TDM_RX_0),
-       Q6AFE_TDM_PB_DAI("Tertiary", 1, TERTIARY_TDM_RX_1),
-       Q6AFE_TDM_PB_DAI("Tertiary", 2, TERTIARY_TDM_RX_2),
-       Q6AFE_TDM_PB_DAI("Tertiary", 3, TERTIARY_TDM_RX_3),
-       Q6AFE_TDM_PB_DAI("Tertiary", 4, TERTIARY_TDM_RX_4),
-       Q6AFE_TDM_PB_DAI("Tertiary", 5, TERTIARY_TDM_RX_5),
-       Q6AFE_TDM_PB_DAI("Tertiary", 6, TERTIARY_TDM_RX_6),
-       Q6AFE_TDM_PB_DAI("Tertiary", 7, TERTIARY_TDM_RX_7),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 0, TERTIARY_TDM_TX_0),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 1, TERTIARY_TDM_TX_1),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 2, TERTIARY_TDM_TX_2),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 3, TERTIARY_TDM_TX_3),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 4, TERTIARY_TDM_TX_4),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 5, TERTIARY_TDM_TX_5),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 6, TERTIARY_TDM_TX_6),
-       Q6AFE_TDM_CAP_DAI("Tertiary", 7, TERTIARY_TDM_TX_7),
-       Q6AFE_TDM_PB_DAI("Quaternary", 0, QUATERNARY_TDM_RX_0),
-       Q6AFE_TDM_PB_DAI("Quaternary", 1, QUATERNARY_TDM_RX_1),
-       Q6AFE_TDM_PB_DAI("Quaternary", 2, QUATERNARY_TDM_RX_2),
-       Q6AFE_TDM_PB_DAI("Quaternary", 3, QUATERNARY_TDM_RX_3),
-       Q6AFE_TDM_PB_DAI("Quaternary", 4, QUATERNARY_TDM_RX_4),
-       Q6AFE_TDM_PB_DAI("Quaternary", 5, QUATERNARY_TDM_RX_5),
-       Q6AFE_TDM_PB_DAI("Quaternary", 6, QUATERNARY_TDM_RX_6),
-       Q6AFE_TDM_PB_DAI("Quaternary", 7, QUATERNARY_TDM_RX_7),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 0, QUATERNARY_TDM_TX_0),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 1, QUATERNARY_TDM_TX_1),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 2, QUATERNARY_TDM_TX_2),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 3, QUATERNARY_TDM_TX_3),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 4, QUATERNARY_TDM_TX_4),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 5, QUATERNARY_TDM_TX_5),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 6, QUATERNARY_TDM_TX_6),
-       Q6AFE_TDM_CAP_DAI("Quaternary", 7, QUATERNARY_TDM_TX_7),
-       Q6AFE_TDM_PB_DAI("Quinary", 0, QUINARY_TDM_RX_0),
-       Q6AFE_TDM_PB_DAI("Quinary", 1, QUINARY_TDM_RX_1),
-       Q6AFE_TDM_PB_DAI("Quinary", 2, QUINARY_TDM_RX_2),
-       Q6AFE_TDM_PB_DAI("Quinary", 3, QUINARY_TDM_RX_3),
-       Q6AFE_TDM_PB_DAI("Quinary", 4, QUINARY_TDM_RX_4),
-       Q6AFE_TDM_PB_DAI("Quinary", 5, QUINARY_TDM_RX_5),
-       Q6AFE_TDM_PB_DAI("Quinary", 6, QUINARY_TDM_RX_6),
-       Q6AFE_TDM_PB_DAI("Quinary", 7, QUINARY_TDM_RX_7),
-       Q6AFE_TDM_CAP_DAI("Quinary", 0, QUINARY_TDM_TX_0),
-       Q6AFE_TDM_CAP_DAI("Quinary", 1, QUINARY_TDM_TX_1),
-       Q6AFE_TDM_CAP_DAI("Quinary", 2, QUINARY_TDM_TX_2),
-       Q6AFE_TDM_CAP_DAI("Quinary", 3, QUINARY_TDM_TX_3),
-       Q6AFE_TDM_CAP_DAI("Quinary", 4, QUINARY_TDM_TX_4),
-       Q6AFE_TDM_CAP_DAI("Quinary", 5, QUINARY_TDM_TX_5),
-       Q6AFE_TDM_CAP_DAI("Quinary", 6, QUINARY_TDM_TX_6),
-       Q6AFE_TDM_CAP_DAI("Quinary", 7, QUINARY_TDM_TX_7),
-       {
-               .playback = {
-                       .stream_name = "Display Port Playback",
-                       .rates = SNDRV_PCM_RATE_48000 |
-                                SNDRV_PCM_RATE_96000 |
-                                SNDRV_PCM_RATE_192000,
-                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
-                                  SNDRV_PCM_FMTBIT_S24_LE,
-                       .channels_min = 2,
-                       .channels_max = 8,
-                       .rate_max =     192000,
-                       .rate_min =     48000,
-               },
-               .ops = &q6hdmi_ops,
-               .id = DISPLAY_PORT_RX,
-               .name = "DISPLAY_PORT",
-               .probe = msm_dai_q6_dai_probe,
-               .remove = msm_dai_q6_dai_remove,
-       },
-       Q6AFE_CDC_DMA_RX_DAI(WSA_CODEC_DMA_RX_0),
-       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_0),
-       Q6AFE_CDC_DMA_RX_DAI(WSA_CODEC_DMA_RX_1),
-       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_1),
-       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_2),
-       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_0),
-       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_1),
-       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_2),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_0),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_0),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_1),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_1),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_2),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_2),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_3),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_3),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_4),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_4),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_5),
-       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_5),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_6),
-       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_7),
-};
-
-static int q6afe_of_xlate_dai_name(struct snd_soc_component *component,
-                                  const struct of_phandle_args *args,
-                                  const char **dai_name)
-{
-       int id = args->args[0];
-       int ret = -EINVAL;
-       int i;
-
-       for (i = 0; i  < ARRAY_SIZE(q6afe_dais); i++) {
-               if (q6afe_dais[i].id == id) {
-                       *dai_name = q6afe_dais[i].name;
-                       ret = 0;
-                       break;
-               }
-       }
-
-       return ret;
-}
-
 static const struct snd_soc_dapm_widget q6afe_dai_widgets[] = {
        SND_SOC_DAPM_AIF_IN("HDMI_RX", NULL, 0, SND_SOC_NOPM, 0, 0),
        SND_SOC_DAPM_AIF_IN("SLIMBUS_0_RX", NULL, 0, SND_SOC_NOPM, 0, 0),
@@ -1627,7 +960,7 @@ static const struct snd_soc_component_driver q6afe_dai_component = {
        .num_dapm_widgets = ARRAY_SIZE(q6afe_dai_widgets),
        .dapm_routes = q6afe_dapm_routes,
        .num_dapm_routes = ARRAY_SIZE(q6afe_dapm_routes),
-       .of_xlate_dai_name = q6afe_of_xlate_dai_name,
+       .of_xlate_dai_name = q6dsp_audio_ports_of_xlate_dai_name,
 
 };
 
@@ -1715,19 +1048,29 @@ static void of_q6afe_parse_dai_data(struct device *dev,
 
 static int q6afe_dai_dev_probe(struct platform_device *pdev)
 {
+       struct q6dsp_audio_port_dai_driver_config cfg;
+       struct snd_soc_dai_driver *dais;
        struct q6afe_dai_data *dai_data;
        struct device *dev = &pdev->dev;
+       int num_dais;
 
        dai_data = devm_kzalloc(dev, sizeof(*dai_data), GFP_KERNEL);
        if (!dai_data)
                return -ENOMEM;
 
        dev_set_drvdata(dev, dai_data);
-
        of_q6afe_parse_dai_data(dev, dai_data);
 
-       return devm_snd_soc_register_component(dev, &q6afe_dai_component,
-                                         q6afe_dais, ARRAY_SIZE(q6afe_dais));
+       cfg.probe = msm_dai_q6_dai_probe;
+       cfg.remove = msm_dai_q6_dai_remove;
+       cfg.q6hdmi_ops = &q6hdmi_ops;
+       cfg.q6slim_ops = &q6slim_ops;
+       cfg.q6i2s_ops = &q6i2s_ops;
+       cfg.q6tdm_ops = &q6tdm_ops;
+       cfg.q6dma_ops = &q6dma_ops;
+       dais = q6dsp_audio_ports_set_config(dev, &cfg, &num_dais);
+
+       return devm_snd_soc_register_component(dev, &q6afe_dai_component, dais, num_dais);
 }
 
 #ifdef CONFIG_OF
@@ -1747,5 +1090,5 @@ static struct platform_driver q6afe_dai_platform_driver = {
 };
 module_platform_driver(q6afe_dai_platform_driver);
 
-MODULE_DESCRIPTION("Q6 Audio Fronend dai driver");
+MODULE_DESCRIPTION("Q6 Audio Frontend dai driver");
 MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/qcom/qdsp6/q6apm-dai.c b/sound/soc/qcom/qdsp6/q6apm-dai.c
new file mode 100644 (file)
index 0000000..eb1c3ae
--- /dev/null
@@ -0,0 +1,416 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2021, Linaro Limited
+
+#include <linux/init.h>
+#include <linux/err.h>
+#include <linux/module.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/pcm.h>
+#include <asm/dma.h>
+#include <linux/dma-mapping.h>
+#include <linux/of_device.h>
+#include <sound/pcm_params.h>
+#include "q6apm.h"
+
+#define DRV_NAME "q6apm-dai"
+
+#define PLAYBACK_MIN_NUM_PERIODS       2
+#define PLAYBACK_MAX_NUM_PERIODS       8
+#define PLAYBACK_MAX_PERIOD_SIZE       65536
+#define PLAYBACK_MIN_PERIOD_SIZE       128
+#define CAPTURE_MIN_NUM_PERIODS                2
+#define CAPTURE_MAX_NUM_PERIODS                8
+#define CAPTURE_MAX_PERIOD_SIZE                4096
+#define CAPTURE_MIN_PERIOD_SIZE                320
+#define BUFFER_BYTES_MAX (PLAYBACK_MAX_NUM_PERIODS * PLAYBACK_MAX_PERIOD_SIZE)
+#define BUFFER_BYTES_MIN (PLAYBACK_MIN_NUM_PERIODS * PLAYBACK_MIN_PERIOD_SIZE)
+#define SID_MASK_DEFAULT       0xF
+
+enum stream_state {
+       Q6APM_STREAM_IDLE = 0,
+       Q6APM_STREAM_STOPPED,
+       Q6APM_STREAM_RUNNING,
+};
+
+struct q6apm_dai_rtd {
+       struct snd_pcm_substream *substream;
+       struct snd_compr_stream *cstream;
+       struct snd_compr_params codec_param;
+       struct snd_dma_buffer dma_buffer;
+       phys_addr_t phys;
+       unsigned int pcm_size;
+       unsigned int pcm_count;
+       unsigned int pos;       /* Buffer position */
+       unsigned int periods;
+       unsigned int bytes_sent;
+       unsigned int bytes_received;
+       unsigned int copied_total;
+       uint16_t bits_per_sample;
+       uint16_t source; /* Encoding source bit mask */
+       uint16_t session_id;
+       enum stream_state state;
+       struct q6apm_graph *graph;
+};
+
+struct q6apm_dai_data {
+       long long sid;
+};
+
+static struct snd_pcm_hardware q6apm_dai_hardware_capture = {
+       .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                                SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_INTERLEAVED |
+                                SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
+       .formats =              (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+       .rates =                SNDRV_PCM_RATE_8000_48000,
+       .rate_min =             8000,
+       .rate_max =             48000,
+       .channels_min =         2,
+       .channels_max =         4,
+       .buffer_bytes_max =     CAPTURE_MAX_NUM_PERIODS * CAPTURE_MAX_PERIOD_SIZE,
+       .period_bytes_min =     CAPTURE_MIN_PERIOD_SIZE,
+       .period_bytes_max =     CAPTURE_MAX_PERIOD_SIZE,
+       .periods_min =          CAPTURE_MIN_NUM_PERIODS,
+       .periods_max =          CAPTURE_MAX_NUM_PERIODS,
+       .fifo_size =            0,
+};
+
+static struct snd_pcm_hardware q6apm_dai_hardware_playback = {
+       .info =                 (SNDRV_PCM_INFO_MMAP | SNDRV_PCM_INFO_BLOCK_TRANSFER |
+                                SNDRV_PCM_INFO_MMAP_VALID | SNDRV_PCM_INFO_INTERLEAVED |
+                                SNDRV_PCM_INFO_PAUSE | SNDRV_PCM_INFO_RESUME),
+       .formats =              (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S24_LE),
+       .rates =                SNDRV_PCM_RATE_8000_192000,
+       .rate_min =             8000,
+       .rate_max =             192000,
+       .channels_min =         2,
+       .channels_max =         8,
+       .buffer_bytes_max =     (PLAYBACK_MAX_NUM_PERIODS * PLAYBACK_MAX_PERIOD_SIZE),
+       .period_bytes_min =     PLAYBACK_MIN_PERIOD_SIZE,
+       .period_bytes_max =     PLAYBACK_MAX_PERIOD_SIZE,
+       .periods_min =          PLAYBACK_MIN_NUM_PERIODS,
+       .periods_max =          PLAYBACK_MAX_NUM_PERIODS,
+       .fifo_size =            0,
+};
+
+static void event_handler(uint32_t opcode, uint32_t token, uint32_t *payload, void *priv)
+{
+       struct q6apm_dai_rtd *prtd = priv;
+       struct snd_pcm_substream *substream = prtd->substream;
+
+       switch (opcode) {
+       case APM_CLIENT_EVENT_CMD_EOS_DONE:
+               prtd->state = Q6APM_STREAM_STOPPED;
+               break;
+       case APM_CLIENT_EVENT_DATA_WRITE_DONE:
+               prtd->pos += prtd->pcm_count;
+               snd_pcm_period_elapsed(substream);
+               if (prtd->state == Q6APM_STREAM_RUNNING)
+                       q6apm_write_async(prtd->graph, prtd->pcm_count, 0, 0, 0);
+
+               break;
+       case APM_CLIENT_EVENT_DATA_READ_DONE:
+               prtd->pos += prtd->pcm_count;
+               snd_pcm_period_elapsed(substream);
+               if (prtd->state == Q6APM_STREAM_RUNNING)
+                       q6apm_read(prtd->graph);
+
+               break;
+       default:
+               break;
+       }
+}
+
+static int q6apm_dai_prepare(struct snd_soc_component *component,
+                            struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct q6apm_dai_rtd *prtd = runtime->private_data;
+       struct audioreach_module_config cfg;
+       struct device *dev = component->dev;
+       struct q6apm_dai_data *pdata;
+       int ret;
+
+       pdata = snd_soc_component_get_drvdata(component);
+       if (!pdata)
+               return -EINVAL;
+
+       if (!prtd || !prtd->graph) {
+               dev_err(dev, "%s: private data null or audio client freed\n", __func__);
+               return -EINVAL;
+       }
+
+       cfg.direction = substream->stream;
+       cfg.sample_rate = runtime->rate;
+       cfg.num_channels = runtime->channels;
+       cfg.bit_width = prtd->bits_per_sample;
+
+       prtd->pcm_count = snd_pcm_lib_period_bytes(substream);
+       prtd->pos = 0;
+       /* rate and channels are sent to audio driver */
+       ret = q6apm_graph_media_format_shmem(prtd->graph, &cfg);
+       if (ret < 0) {
+               dev_err(dev, "%s: q6apm_open_write failed\n", __func__);
+               return ret;
+       }
+
+       ret = q6apm_graph_media_format_pcm(prtd->graph, &cfg);
+       if (ret < 0)
+               dev_err(dev, "%s: CMD Format block failed\n", __func__);
+
+       ret = q6apm_map_memory_regions(prtd->graph, substream->stream, prtd->phys,
+                                      (prtd->pcm_size / prtd->periods), prtd->periods);
+
+       if (ret < 0) {
+               dev_err(dev, "Audio Start: Buffer Allocation failed rc = %d\n", ret);
+               return -ENOMEM;
+       }
+
+       ret = q6apm_graph_prepare(prtd->graph);
+       if (ret) {
+               dev_err(dev, "Failed to prepare Graph %d\n", ret);
+               return ret;
+       }
+
+       ret = q6apm_graph_start(prtd->graph);
+       if (ret) {
+               dev_err(dev, "Failed to Start Graph %d\n", ret);
+               return ret;
+       }
+
+       if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
+               int i;
+               /* Queue the buffers for Capture ONLY after graph is started */
+               for (i = 0; i < runtime->periods; i++)
+                       q6apm_read(prtd->graph);
+
+       }
+
+       /* Now that graph as been prepared and started update the internal state accordingly */
+       prtd->state = Q6APM_STREAM_RUNNING;
+
+       return 0;
+}
+
+static int q6apm_dai_trigger(struct snd_soc_component *component,
+                            struct snd_pcm_substream *substream, int cmd)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct q6apm_dai_rtd *prtd = runtime->private_data;
+       int ret = 0;
+
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+                /* start writing buffers for playback only as we already queued capture buffers */
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+                       ret = q6apm_write_async(prtd->graph, prtd->pcm_count, 0, 0, 0);
+               break;
+       case SNDRV_PCM_TRIGGER_STOP:
+               /* TODO support be handled via SoftPause Module */
+               prtd->state = Q6APM_STREAM_STOPPED;
+               break;
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               break;
+       default:
+               ret = -EINVAL;
+               break;
+       }
+
+       return ret;
+}
+
+static int q6apm_dai_open(struct snd_soc_component *component,
+                         struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct snd_soc_pcm_runtime *soc_prtd = substream->private_data;
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(soc_prtd, 0);
+       struct device *dev = component->dev;
+       struct q6apm_dai_data *pdata;
+       struct q6apm_dai_rtd *prtd;
+       int graph_id, ret;
+
+       graph_id = cpu_dai->driver->id;
+
+       pdata = snd_soc_component_get_drvdata(component);
+       if (!pdata) {
+               dev_err(dev, "Drv data not found ..\n");
+               return -EINVAL;
+       }
+
+       prtd = kzalloc(sizeof(*prtd), GFP_KERNEL);
+       if (prtd == NULL)
+               return -ENOMEM;
+
+       prtd->substream = substream;
+       prtd->graph = q6apm_graph_open(dev, (q6apm_cb)event_handler, prtd, graph_id);
+       if (IS_ERR(prtd->graph)) {
+               dev_err(dev, "%s: Could not allocate memory\n", __func__);
+               ret = PTR_ERR(prtd->graph);
+               goto err;
+       }
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               runtime->hw = q6apm_dai_hardware_playback;
+       else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+               runtime->hw = q6apm_dai_hardware_capture;
+
+       /* Ensure that buffer size is a multiple of period size */
+       ret = snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS);
+       if (ret < 0) {
+               dev_err(dev, "snd_pcm_hw_constraint_integer failed\n");
+               goto err;
+       }
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_BUFFER_BYTES,
+                                                  BUFFER_BYTES_MIN, BUFFER_BYTES_MAX);
+               if (ret < 0) {
+                       dev_err(dev, "constraint for buffer bytes min max ret = %d\n", ret);
+                       goto err;
+               }
+       }
+
+       ret = snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, 32);
+       if (ret < 0) {
+               dev_err(dev, "constraint for period bytes step ret = %d\n", ret);
+               goto err;
+       }
+
+       ret = snd_pcm_hw_constraint_step(runtime, 0, SNDRV_PCM_HW_PARAM_BUFFER_BYTES, 32);
+       if (ret < 0) {
+               dev_err(dev, "constraint for buffer bytes step ret = %d\n", ret);
+               goto err;
+       }
+
+       runtime->private_data = prtd;
+       runtime->dma_bytes = BUFFER_BYTES_MAX;
+       if (pdata->sid < 0)
+               prtd->phys = substream->dma_buffer.addr;
+       else
+               prtd->phys = substream->dma_buffer.addr | (pdata->sid << 32);
+
+       return 0;
+err:
+       kfree(prtd);
+
+       return ret;
+}
+
+static int q6apm_dai_close(struct snd_soc_component *component,
+                          struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct q6apm_dai_rtd *prtd = runtime->private_data;
+
+       q6apm_graph_stop(prtd->graph);
+       q6apm_unmap_memory_regions(prtd->graph, substream->stream);
+       q6apm_graph_close(prtd->graph);
+       prtd->graph = NULL;
+       kfree(prtd);
+       runtime->private_data = NULL;
+
+       return 0;
+}
+
+static snd_pcm_uframes_t q6apm_dai_pointer(struct snd_soc_component *component,
+                                          struct snd_pcm_substream *substream)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct q6apm_dai_rtd *prtd = runtime->private_data;
+
+       if (prtd->pos == prtd->pcm_size)
+               prtd->pos = 0;
+
+       return bytes_to_frames(runtime, prtd->pos);
+}
+
+static int q6apm_dai_hw_params(struct snd_soc_component *component,
+                              struct snd_pcm_substream *substream,
+                              struct snd_pcm_hw_params *params)
+{
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       struct q6apm_dai_rtd *prtd = runtime->private_data;
+
+       prtd->pcm_size = params_buffer_bytes(params);
+       prtd->periods = params_periods(params);
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               prtd->bits_per_sample = 16;
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               prtd->bits_per_sample = 24;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int q6apm_dai_pcm_new(struct snd_soc_component *component, struct snd_soc_pcm_runtime *rtd)
+{
+       int size = BUFFER_BYTES_MAX;
+
+       return snd_pcm_set_fixed_buffer_all(rtd->pcm, SNDRV_DMA_TYPE_DEV, component->dev, size);
+}
+
+static const struct snd_soc_component_driver q6apm_fe_dai_component = {
+       .name           = DRV_NAME,
+       .open           = q6apm_dai_open,
+       .close          = q6apm_dai_close,
+       .prepare        = q6apm_dai_prepare,
+       .pcm_construct  = q6apm_dai_pcm_new,
+       .hw_params      = q6apm_dai_hw_params,
+       .pointer        = q6apm_dai_pointer,
+       .trigger        = q6apm_dai_trigger,
+};
+
+static int q6apm_dai_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct device_node *node = dev->of_node;
+       struct q6apm_dai_data *pdata;
+       struct of_phandle_args args;
+       int rc;
+
+       pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
+       if (!pdata)
+               return -ENOMEM;
+
+       rc = of_parse_phandle_with_fixed_args(node, "iommus", 1, 0, &args);
+       if (rc < 0)
+               pdata->sid = -1;
+       else
+               pdata->sid = args.args[0] & SID_MASK_DEFAULT;
+
+       dev_set_drvdata(dev, pdata);
+
+       return devm_snd_soc_register_component(dev, &q6apm_fe_dai_component, NULL, 0);
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id q6apm_dai_device_id[] = {
+       { .compatible = "qcom,q6apm-dais" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, q6apm_dai_device_id);
+#endif
+
+static struct platform_driver q6apm_dai_platform_driver = {
+       .driver = {
+               .name = "q6apm-dai",
+               .of_match_table = of_match_ptr(q6apm_dai_device_id),
+       },
+       .probe = q6apm_dai_probe,
+};
+module_platform_driver(q6apm_dai_platform_driver);
+
+MODULE_DESCRIPTION("Q6APM dai driver");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c
new file mode 100644 (file)
index 0000000..ce9e564
--- /dev/null
@@ -0,0 +1,260 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2021, Linaro Limited
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/module.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <linux/slab.h>
+#include <sound/pcm.h>
+#include <sound/soc.h>
+#include <sound/pcm_params.h>
+#include "q6dsp-lpass-ports.h"
+#include "audioreach.h"
+#include "q6apm.h"
+
+#define AUDIOREACH_BE_PCM_BASE 16
+
+struct q6apm_lpass_dai_data {
+       struct q6apm_graph *graph[APM_PORT_MAX];
+       bool is_port_started[APM_PORT_MAX];
+       struct audioreach_module_config module_config[APM_PORT_MAX];
+};
+
+static int q6dma_set_channel_map(struct snd_soc_dai *dai,
+                                unsigned int tx_num, unsigned int *tx_ch_mask,
+                                unsigned int rx_num, unsigned int *rx_ch_mask)
+{
+
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       struct audioreach_module_config *cfg = &dai_data->module_config[dai->id];
+       int ch_mask;
+
+       switch (dai->id) {
+       case WSA_CODEC_DMA_TX_0:
+       case WSA_CODEC_DMA_TX_1:
+       case WSA_CODEC_DMA_TX_2:
+       case VA_CODEC_DMA_TX_0:
+       case VA_CODEC_DMA_TX_1:
+       case VA_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_0:
+       case TX_CODEC_DMA_TX_1:
+       case TX_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_3:
+       case TX_CODEC_DMA_TX_4:
+       case TX_CODEC_DMA_TX_5:
+               if (!tx_ch_mask) {
+                       dev_err(dai->dev, "tx slot not found\n");
+                       return -EINVAL;
+               }
+
+               if (tx_num > AR_PCM_MAX_NUM_CHANNEL) {
+                       dev_err(dai->dev, "invalid tx num %d\n",
+                               tx_num);
+                       return -EINVAL;
+               }
+               ch_mask = *tx_ch_mask;
+
+               break;
+       case WSA_CODEC_DMA_RX_0:
+       case WSA_CODEC_DMA_RX_1:
+       case RX_CODEC_DMA_RX_0:
+       case RX_CODEC_DMA_RX_1:
+       case RX_CODEC_DMA_RX_2:
+       case RX_CODEC_DMA_RX_3:
+       case RX_CODEC_DMA_RX_4:
+       case RX_CODEC_DMA_RX_5:
+       case RX_CODEC_DMA_RX_6:
+       case RX_CODEC_DMA_RX_7:
+               /* rx */
+               if (!rx_ch_mask) {
+                       dev_err(dai->dev, "rx slot not found\n");
+                       return -EINVAL;
+               }
+               if (rx_num > APM_PORT_MAX_AUDIO_CHAN_CNT) {
+                       dev_err(dai->dev, "invalid rx num %d\n",
+                               rx_num);
+                       return -EINVAL;
+               }
+               ch_mask = *rx_ch_mask;
+
+               break;
+       default:
+               dev_err(dai->dev, "%s: invalid dai id 0x%x\n",
+                       __func__, dai->id);
+               return -EINVAL;
+       }
+
+       cfg->active_channels_mask = ch_mask;
+
+       return 0;
+}
+
+static int q6dma_hw_params(struct snd_pcm_substream *substream,
+                          struct snd_pcm_hw_params *params, struct snd_soc_dai *dai)
+{
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       struct audioreach_module_config *cfg = &dai_data->module_config[dai->id];
+
+       cfg->bit_width = params_width(params);
+       cfg->sample_rate = params_rate(params);
+       cfg->num_channels = params_channels(params);
+
+       return 0;
+}
+
+static void q6apm_lpass_dai_shutdown(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       int rc;
+
+       if (!dai_data->is_port_started[dai->id])
+               return;
+       rc = q6apm_graph_stop(dai_data->graph[dai->id]);
+       if (rc < 0)
+               dev_err(dai->dev, "fail to close APM port (%d)\n", rc);
+
+       q6apm_graph_close(dai_data->graph[dai->id]);
+       dai_data->is_port_started[dai->id] = false;
+}
+
+static int q6apm_lpass_dai_prepare(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       struct audioreach_module_config *cfg = &dai_data->module_config[dai->id];
+       struct q6apm_graph *graph;
+       int graph_id = dai->id;
+       int rc;
+
+       /**
+        * It is recommend to load DSP with source graph first and then sink
+        * graph, so sequence for playback and capture will be different
+        */
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               graph = q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id);
+               if (IS_ERR(graph)) {
+                       dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id);
+                       rc = PTR_ERR(graph);
+                       return rc;
+               }
+               dai_data->graph[graph_id] = graph;
+       }
+
+       cfg->direction = substream->stream;
+       rc = q6apm_graph_media_format_pcm(dai_data->graph[dai->id], cfg);
+
+       if (rc) {
+               dev_err(dai->dev, "Failed to set media format %d\n", rc);
+               return rc;
+       }
+
+       rc = q6apm_graph_prepare(dai_data->graph[dai->id]);
+       if (rc) {
+               dev_err(dai->dev, "Failed to prepare Graph %d\n", rc);
+               return rc;
+       }
+
+       rc = q6apm_graph_start(dai_data->graph[dai->id]);
+       if (rc < 0) {
+               dev_err(dai->dev, "fail to start APM port %x\n", dai->id);
+               return rc;
+       }
+       dai_data->is_port_started[dai->id] = true;
+
+       return 0;
+}
+
+static int q6apm_lpass_dai_startup(struct snd_pcm_substream *substream, struct snd_soc_dai *dai)
+{
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       struct q6apm_graph *graph;
+       int graph_id = dai->id;
+
+       if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
+               graph = q6apm_graph_open(dai->dev, NULL, dai->dev, graph_id);
+               if (IS_ERR(graph)) {
+                       dev_err(dai->dev, "Failed to open graph (%d)\n", graph_id);
+                       return PTR_ERR(graph);
+               }
+               dai_data->graph[graph_id] = graph;
+       }
+
+       return 0;
+}
+
+static int q6i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+{
+       struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev);
+       struct audioreach_module_config *cfg = &dai_data->module_config[dai->id];
+
+       cfg->fmt = fmt;
+
+       return 0;
+}
+
+static const struct snd_soc_dai_ops q6dma_ops = {
+       .prepare        = q6apm_lpass_dai_prepare,
+       .startup        = q6apm_lpass_dai_startup,
+       .shutdown       = q6apm_lpass_dai_shutdown,
+       .set_channel_map  = q6dma_set_channel_map,
+       .hw_params        = q6dma_hw_params,
+};
+
+static const struct snd_soc_dai_ops q6i2s_ops = {
+       .prepare        = q6apm_lpass_dai_prepare,
+       .startup        = q6apm_lpass_dai_startup,
+       .shutdown       = q6apm_lpass_dai_shutdown,
+       .set_channel_map  = q6dma_set_channel_map,
+       .hw_params        = q6dma_hw_params,
+       .set_fmt        = q6i2s_set_fmt,
+};
+
+static const struct snd_soc_component_driver q6apm_lpass_dai_component = {
+       .name = "q6apm-be-dai-component",
+       .of_xlate_dai_name = q6dsp_audio_ports_of_xlate_dai_name,
+       .be_pcm_base = AUDIOREACH_BE_PCM_BASE,
+       .use_dai_pcm_id = true,
+};
+
+static int q6apm_lpass_dai_dev_probe(struct platform_device *pdev)
+{
+       struct q6dsp_audio_port_dai_driver_config cfg;
+       struct q6apm_lpass_dai_data *dai_data;
+       struct snd_soc_dai_driver *dais;
+       struct device *dev = &pdev->dev;
+       int num_dais;
+
+       dai_data = devm_kzalloc(dev, sizeof(*dai_data), GFP_KERNEL);
+       if (!dai_data)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, dai_data);
+
+       memset(&cfg, 0, sizeof(cfg));
+       cfg.q6i2s_ops = &q6i2s_ops;
+       cfg.q6dma_ops = &q6dma_ops;
+       dais = q6dsp_audio_ports_set_config(dev, &cfg, &num_dais);
+
+       return devm_snd_soc_register_component(dev, &q6apm_lpass_dai_component, dais, num_dais);
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id q6apm_lpass_dai_device_id[] = {
+       { .compatible = "qcom,q6apm-lpass-dais" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, q6apm_lpass_dai_device_id);
+#endif
+
+static struct platform_driver q6apm_lpass_dai_platform_driver = {
+       .driver = {
+               .name = "q6apm-lpass-dais",
+               .of_match_table = of_match_ptr(q6apm_lpass_dai_device_id),
+       },
+       .probe = q6apm_lpass_dai_dev_probe,
+};
+module_platform_driver(q6apm_lpass_dai_platform_driver);
+
+MODULE_DESCRIPTION("AUDIOREACH APM LPASS dai driver");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6apm.c b/sound/soc/qcom/qdsp6/q6apm.c
new file mode 100644 (file)
index 0000000..13598ef
--- /dev/null
@@ -0,0 +1,822 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020, Linaro Limited
+
+#include <dt-bindings/soc/qcom,gpr.h>
+#include <linux/delay.h>
+#include <linux/jiffies.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_platform.h>
+#include <linux/sched.h>
+#include <linux/slab.h>
+#include <linux/soc/qcom/apr.h>
+#include <linux/wait.h>
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/pcm.h>
+#include "audioreach.h"
+#include "q6apm.h"
+
+/* Graph Management */
+struct apm_graph_mgmt_cmd {
+       struct apm_module_param_data param_data;
+       uint32_t num_sub_graphs;
+       uint32_t sub_graph_id_list[];
+} __packed;
+
+#define APM_GRAPH_MGMT_PSIZE(p, n) ALIGN(struct_size(p, sub_graph_id_list, n), 8)
+
+int q6apm_send_cmd_sync(struct q6apm *apm, struct gpr_pkt *pkt, uint32_t rsp_opcode)
+{
+       gpr_device_t *gdev = apm->gdev;
+
+       return audioreach_send_cmd_sync(&gdev->dev, gdev, &apm->result, &apm->lock,
+                                       NULL, &apm->wait, pkt, rsp_opcode);
+}
+
+static struct audioreach_graph *q6apm_get_audioreach_graph(struct q6apm *apm, uint32_t graph_id)
+{
+       struct audioreach_graph_info *info;
+       struct audioreach_graph *graph;
+       int id;
+
+       mutex_lock(&apm->lock);
+       graph = idr_find(&apm->graph_idr, graph_id);
+       mutex_unlock(&apm->lock);
+
+       if (graph) {
+               kref_get(&graph->refcount);
+               return graph;
+       }
+
+       info = idr_find(&apm->graph_info_idr, graph_id);
+
+       if (!info)
+               return ERR_PTR(-ENODEV);
+
+       graph = kzalloc(sizeof(*graph), GFP_KERNEL);
+       if (!graph)
+               return ERR_PTR(-ENOMEM);
+
+       graph->apm = apm;
+       graph->info = info;
+       graph->id = graph_id;
+
+       graph->graph = audioreach_alloc_graph_pkt(apm, &info->sg_list, graph_id);
+       if (IS_ERR(graph->graph)) {
+               void *err = graph->graph;
+
+               kfree(graph);
+               return ERR_CAST(err);
+       }
+
+       mutex_lock(&apm->lock);
+       id = idr_alloc(&apm->graph_idr, graph, graph_id, graph_id + 1, GFP_KERNEL);
+       if (id < 0) {
+               dev_err(apm->dev, "Unable to allocate graph id (%d)\n", graph_id);
+               kfree(graph);
+               mutex_unlock(&apm->lock);
+               return ERR_PTR(id);
+       }
+       mutex_unlock(&apm->lock);
+
+       kref_init(&graph->refcount);
+
+       q6apm_send_cmd_sync(apm, graph->graph, 0);
+
+       return graph;
+}
+
+static int audioreach_graph_mgmt_cmd(struct audioreach_graph *graph, uint32_t opcode)
+{
+       struct audioreach_graph_info *info = graph->info;
+       int num_sub_graphs = info->num_sub_graphs;
+       struct apm_module_param_data *param_data;
+       struct apm_graph_mgmt_cmd *mgmt_cmd;
+       struct audioreach_sub_graph *sg;
+       struct q6apm *apm = graph->apm;
+       int i = 0, rc, payload_size;
+       struct gpr_pkt *pkt;
+
+       payload_size = APM_GRAPH_MGMT_PSIZE(mgmt_cmd, num_sub_graphs);
+
+       pkt = audioreach_alloc_apm_cmd_pkt(payload_size, opcode, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       mgmt_cmd = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       mgmt_cmd->num_sub_graphs = num_sub_graphs;
+
+       param_data = &mgmt_cmd->param_data;
+       param_data->module_instance_id = APM_MODULE_INSTANCE_ID;
+       param_data->param_id = APM_PARAM_ID_SUB_GRAPH_LIST;
+       param_data->param_size = payload_size - APM_MODULE_PARAM_DATA_SIZE;
+
+       list_for_each_entry(sg, &info->sg_list, node)
+               mgmt_cmd->sub_graph_id_list[i++] = sg->sub_graph_id;
+
+       rc = q6apm_send_cmd_sync(apm, pkt, 0);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+static void q6apm_put_audioreach_graph(struct kref *ref)
+{
+       struct audioreach_graph *graph;
+       struct q6apm *apm;
+
+       graph = container_of(ref, struct audioreach_graph, refcount);
+       apm = graph->apm;
+
+       audioreach_graph_mgmt_cmd(graph, APM_CMD_GRAPH_CLOSE);
+
+       mutex_lock(&apm->lock);
+       graph = idr_remove(&apm->graph_idr, graph->id);
+       mutex_unlock(&apm->lock);
+
+       kfree(graph->graph);
+       kfree(graph);
+}
+
+static int q6apm_get_apm_state(struct q6apm *apm)
+{
+       struct gpr_pkt *pkt;
+
+       pkt = audioreach_alloc_apm_cmd_pkt(0, APM_CMD_GET_SPF_STATE, 0);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       q6apm_send_cmd_sync(apm, pkt, APM_CMD_RSP_GET_SPF_STATE);
+
+       kfree(pkt);
+
+       return apm->state;
+}
+
+static struct audioreach_module *__q6apm_find_module_by_mid(struct q6apm *apm,
+                                                   struct audioreach_graph_info *info,
+                                                   uint32_t mid)
+{
+       struct audioreach_container *container;
+       struct audioreach_sub_graph *sgs;
+       struct audioreach_module *module;
+
+       list_for_each_entry(sgs, &info->sg_list, node) {
+               list_for_each_entry(container, &sgs->container_list, node) {
+                       list_for_each_entry(module, &container->modules_list, node) {
+                               if (mid == module->module_id)
+                                       return module;
+                       }
+               }
+       }
+
+       return NULL;
+}
+
+static struct audioreach_module *q6apm_graph_get_last_module(struct q6apm *apm, u32 sgid)
+{
+       struct audioreach_container *container;
+       struct audioreach_module *module;
+       struct audioreach_sub_graph *sg;
+
+       mutex_lock(&apm->lock);
+       sg = idr_find(&apm->sub_graphs_idr, sgid);
+       mutex_unlock(&apm->lock);
+       if (!sg)
+               return NULL;
+
+       container = list_last_entry(&sg->container_list, struct audioreach_container, node);
+       module = audioreach_get_container_last_module(container);
+
+       return module;
+}
+
+static struct audioreach_module *q6apm_graph_get_first_module(struct q6apm *apm, u32 sgid)
+{
+       struct audioreach_container *container;
+       struct audioreach_module *module;
+       struct audioreach_sub_graph *sg;
+
+       mutex_lock(&apm->lock);
+       sg = idr_find(&apm->sub_graphs_idr, sgid);
+       mutex_unlock(&apm->lock);
+       if (!sg)
+               return NULL;
+
+       container = list_first_entry(&sg->container_list, struct audioreach_container, node);
+       module = audioreach_get_container_first_module(container);
+
+       return module;
+}
+
+bool q6apm_is_sub_graphs_connected(struct q6apm *apm, u32 src_sgid, u32 dst_sgid)
+{
+       struct audioreach_module *module;
+       u32 iid;
+
+       module = q6apm_graph_get_last_module(apm, src_sgid);
+       if (!module)
+               return false;
+
+       iid = module->instance_id;
+       module = q6apm_graph_get_first_module(apm, dst_sgid);
+       if (!module)
+               return false;
+
+       if (module->src_mod_inst_id == iid)
+               return true;
+
+       return false;
+}
+
+int q6apm_connect_sub_graphs(struct q6apm *apm, u32 src_sgid, u32 dst_sgid, bool connect)
+{
+       struct audioreach_module *module;
+       u32 iid;
+
+       if (connect) {
+               module = q6apm_graph_get_last_module(apm, src_sgid);
+               if (!module)
+                       return -ENODEV;
+
+               iid = module->instance_id;
+       } else {
+               iid = 0;
+       }
+
+       module = q6apm_graph_get_first_module(apm, dst_sgid);
+       if (!module)
+               return -ENODEV;
+
+       /* set src module in dst subgraph first module */
+       module->src_mod_inst_id = iid;
+
+       return 0;
+}
+
+int q6apm_graph_media_format_shmem(struct q6apm_graph *graph,
+                                  struct audioreach_module_config *cfg)
+{
+       struct audioreach_module *module;
+
+       if (cfg->direction == SNDRV_PCM_STREAM_CAPTURE)
+               module = q6apm_find_module_by_mid(graph, MODULE_ID_RD_SHARED_MEM_EP);
+       else
+               module = q6apm_find_module_by_mid(graph, MODULE_ID_WR_SHARED_MEM_EP);
+
+       if (!module)
+               return -ENODEV;
+
+       audioreach_set_media_format(graph, module, cfg);
+
+       return 0;
+
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_media_format_shmem);
+
+int q6apm_map_memory_regions(struct q6apm_graph *graph, unsigned int dir, phys_addr_t phys,
+                            size_t period_sz, unsigned int periods)
+{
+       struct audioreach_graph_data *data;
+       struct audio_buffer *buf;
+       int cnt;
+       int rc;
+
+       if (dir == SNDRV_PCM_STREAM_PLAYBACK)
+               data = &graph->rx_data;
+       else
+               data = &graph->tx_data;
+
+       mutex_lock(&graph->lock);
+
+       if (data->buf) {
+               mutex_unlock(&graph->lock);
+               return 0;
+       }
+
+       buf = kzalloc(((sizeof(struct audio_buffer)) * periods), GFP_KERNEL);
+       if (!buf) {
+               mutex_unlock(&graph->lock);
+               return -ENOMEM;
+       }
+
+       if (dir == SNDRV_PCM_STREAM_PLAYBACK)
+               data = &graph->rx_data;
+       else
+               data = &graph->tx_data;
+
+       data->buf = buf;
+
+       buf[0].phys = phys;
+       buf[0].size = period_sz;
+
+       for (cnt = 1; cnt < periods; cnt++) {
+               if (period_sz > 0) {
+                       buf[cnt].phys = buf[0].phys + (cnt * period_sz);
+                       buf[cnt].size = period_sz;
+               }
+       }
+       data->num_periods = periods;
+
+       mutex_unlock(&graph->lock);
+
+       rc = audioreach_map_memory_regions(graph, dir, period_sz, periods, 1);
+       if (rc < 0) {
+               dev_err(graph->dev, "Memory_map_regions failed\n");
+               audioreach_graph_free_buf(graph);
+       }
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(q6apm_map_memory_regions);
+
+int q6apm_unmap_memory_regions(struct q6apm_graph *graph, unsigned int dir)
+{
+       struct apm_cmd_shared_mem_unmap_regions *cmd;
+       struct audioreach_graph_data *data;
+       struct gpr_pkt *pkt;
+       int rc;
+
+       if (dir == SNDRV_PCM_STREAM_PLAYBACK)
+               data = &graph->rx_data;
+       else
+               data = &graph->tx_data;
+
+       if (!data->mem_map_handle)
+               return 0;
+
+       pkt = audioreach_alloc_apm_pkt(sizeof(*cmd), APM_CMD_SHARED_MEM_UNMAP_REGIONS, dir,
+                                    graph->port->id);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       cmd = (void *)pkt + GPR_HDR_SIZE;
+       cmd->mem_map_handle = data->mem_map_handle;
+
+       rc = audioreach_graph_send_cmd_sync(graph, pkt, APM_CMD_SHARED_MEM_UNMAP_REGIONS);
+       kfree(pkt);
+
+       audioreach_graph_free_buf(graph);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(q6apm_unmap_memory_regions);
+
+int q6apm_graph_media_format_pcm(struct q6apm_graph *graph, struct audioreach_module_config *cfg)
+{
+       struct audioreach_graph_info *info = graph->info;
+       struct audioreach_sub_graph *sgs;
+       struct audioreach_container *container;
+       struct audioreach_module *module;
+
+       list_for_each_entry(sgs, &info->sg_list, node) {
+               list_for_each_entry(container, &sgs->container_list, node) {
+                       list_for_each_entry(module, &container->modules_list, node) {
+                               if ((module->module_id == MODULE_ID_WR_SHARED_MEM_EP) ||
+                                       (module->module_id == MODULE_ID_RD_SHARED_MEM_EP))
+                                       continue;
+
+                               audioreach_set_media_format(graph, module, cfg);
+                       }
+               }
+       }
+
+       return 0;
+
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_media_format_pcm);
+
+static int q6apm_graph_get_tx_shmem_module_iid(struct q6apm_graph *graph)
+{
+       struct audioreach_module *module;
+
+       module = q6apm_find_module_by_mid(graph, MODULE_ID_RD_SHARED_MEM_EP);
+       if (!module)
+               return -ENODEV;
+
+       return module->instance_id;
+
+}
+
+int q6apm_graph_get_rx_shmem_module_iid(struct q6apm_graph *graph)
+{
+       struct audioreach_module *module;
+
+       module = q6apm_find_module_by_mid(graph, MODULE_ID_WR_SHARED_MEM_EP);
+       if (!module)
+               return -ENODEV;
+
+       return module->instance_id;
+
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_get_rx_shmem_module_iid);
+
+int q6apm_write_async(struct q6apm_graph *graph, uint32_t len, uint32_t msw_ts,
+                     uint32_t lsw_ts, uint32_t wflags)
+{
+       struct apm_data_cmd_wr_sh_mem_ep_data_buffer_v2 *write_buffer;
+       struct audio_buffer *ab;
+       struct gpr_pkt *pkt;
+       int rc, iid;
+
+       iid = q6apm_graph_get_rx_shmem_module_iid(graph);
+       pkt = audioreach_alloc_pkt(sizeof(*write_buffer), DATA_CMD_WR_SH_MEM_EP_DATA_BUFFER_V2,
+                                  graph->rx_data.dsp_buf | (len << APM_WRITE_TOKEN_LEN_SHIFT),
+                                  graph->port->id, iid);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       write_buffer = (void *)pkt + GPR_HDR_SIZE;
+
+       mutex_lock(&graph->lock);
+       ab = &graph->rx_data.buf[graph->rx_data.dsp_buf];
+
+       write_buffer->buf_addr_lsw = lower_32_bits(ab->phys);
+       write_buffer->buf_addr_msw = upper_32_bits(ab->phys);
+       write_buffer->buf_size = len;
+       write_buffer->timestamp_lsw = lsw_ts;
+       write_buffer->timestamp_msw = msw_ts;
+       write_buffer->mem_map_handle = graph->rx_data.mem_map_handle;
+       write_buffer->flags = wflags;
+
+       graph->rx_data.dsp_buf++;
+
+       if (graph->rx_data.dsp_buf >= graph->rx_data.num_periods)
+               graph->rx_data.dsp_buf = 0;
+
+       mutex_unlock(&graph->lock);
+
+       rc = gpr_send_port_pkt(graph->port, pkt);
+
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(q6apm_write_async);
+
+int q6apm_read(struct q6apm_graph *graph)
+{
+       struct data_cmd_rd_sh_mem_ep_data_buffer_v2 *read_buffer;
+       struct audioreach_graph_data *port;
+       struct audio_buffer *ab;
+       struct gpr_pkt *pkt;
+       int rc, iid;
+
+       iid = q6apm_graph_get_tx_shmem_module_iid(graph);
+       pkt = audioreach_alloc_pkt(sizeof(*read_buffer), DATA_CMD_RD_SH_MEM_EP_DATA_BUFFER_V2,
+                                  graph->tx_data.dsp_buf, graph->port->id, iid);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       read_buffer = (void *)pkt + GPR_HDR_SIZE;
+
+       mutex_lock(&graph->lock);
+       port = &graph->tx_data;
+       ab = &port->buf[port->dsp_buf];
+
+       read_buffer->buf_addr_lsw = lower_32_bits(ab->phys);
+       read_buffer->buf_addr_msw = upper_32_bits(ab->phys);
+       read_buffer->mem_map_handle = port->mem_map_handle;
+       read_buffer->buf_size = ab->size;
+
+       port->dsp_buf++;
+
+       if (port->dsp_buf >= port->num_periods)
+               port->dsp_buf = 0;
+
+       mutex_unlock(&graph->lock);
+
+       rc = gpr_send_port_pkt(graph->port, pkt);
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(q6apm_read);
+
+static int graph_callback(struct gpr_resp_pkt *data, void *priv, int op)
+{
+       struct data_cmd_rsp_rd_sh_mem_ep_data_buffer_done_v2 *rd_done;
+       struct data_cmd_rsp_wr_sh_mem_ep_data_buffer_done_v2 *done;
+       struct apm_cmd_rsp_shared_mem_map_regions *rsp;
+       struct gpr_ibasic_rsp_result_t *result;
+       struct q6apm_graph *graph = priv;
+       struct gpr_hdr *hdr = &data->hdr;
+       struct device *dev = graph->dev;
+       uint32_t client_event;
+       phys_addr_t phys;
+       int token;
+
+       result = data->payload;
+
+       switch (hdr->opcode) {
+       case DATA_CMD_RSP_WR_SH_MEM_EP_DATA_BUFFER_DONE_V2:
+               client_event = APM_CLIENT_EVENT_DATA_WRITE_DONE;
+               mutex_lock(&graph->lock);
+               token = hdr->token & APM_WRITE_TOKEN_MASK;
+
+               done = data->payload;
+               phys = graph->rx_data.buf[token].phys;
+               mutex_unlock(&graph->lock);
+
+               if (lower_32_bits(phys) == done->buf_addr_lsw &&
+                   upper_32_bits(phys) == done->buf_addr_msw) {
+                       graph->result.opcode = hdr->opcode;
+                       graph->result.status = done->status;
+                       if (graph->cb)
+                               graph->cb(client_event, hdr->token, data->payload, graph->priv);
+               } else {
+                       dev_err(dev, "WR BUFF Unexpected addr %08x-%08x\n", done->buf_addr_lsw,
+                               done->buf_addr_msw);
+               }
+
+               break;
+       case APM_CMD_RSP_SHARED_MEM_MAP_REGIONS:
+               graph->result.opcode = hdr->opcode;
+               graph->result.status = 0;
+               rsp = data->payload;
+
+               if (hdr->token == SNDRV_PCM_STREAM_PLAYBACK)
+                       graph->rx_data.mem_map_handle = rsp->mem_map_handle;
+               else
+                       graph->tx_data.mem_map_handle = rsp->mem_map_handle;
+
+               wake_up(&graph->cmd_wait);
+               break;
+       case DATA_CMD_RSP_RD_SH_MEM_EP_DATA_BUFFER_V2:
+               client_event = APM_CLIENT_EVENT_DATA_READ_DONE;
+               mutex_lock(&graph->lock);
+               rd_done = data->payload;
+               phys = graph->tx_data.buf[hdr->token].phys;
+               mutex_unlock(&graph->lock);
+
+               if (upper_32_bits(phys) == rd_done->buf_addr_msw &&
+                   lower_32_bits(phys) == rd_done->buf_addr_lsw) {
+                       graph->result.opcode = hdr->opcode;
+                       graph->result.status = rd_done->status;
+                       if (graph->cb)
+                               graph->cb(client_event, hdr->token, data->payload, graph->priv);
+               } else {
+                       dev_err(dev, "RD BUFF Unexpected addr %08x-%08x\n", rd_done->buf_addr_lsw,
+                               rd_done->buf_addr_msw);
+               }
+               break;
+       case DATA_CMD_WR_SH_MEM_EP_EOS_RENDERED:
+               break;
+       case GPR_BASIC_RSP_RESULT:
+               switch (result->opcode) {
+               case APM_CMD_SHARED_MEM_UNMAP_REGIONS:
+                       graph->result.opcode = result->opcode;
+                       graph->result.status = 0;
+                       if (hdr->token == SNDRV_PCM_STREAM_PLAYBACK)
+                               graph->rx_data.mem_map_handle = 0;
+                       else
+                               graph->tx_data.mem_map_handle = 0;
+
+                       wake_up(&graph->cmd_wait);
+                       break;
+               case APM_CMD_SHARED_MEM_MAP_REGIONS:
+               case DATA_CMD_WR_SH_MEM_EP_MEDIA_FORMAT:
+               case APM_CMD_SET_CFG:
+                       graph->result.opcode = result->opcode;
+                       graph->result.status = result->status;
+                       if (result->status)
+                               dev_err(dev, "Error (%d) Processing 0x%08x cmd\n",
+                                       result->status, result->opcode);
+                       wake_up(&graph->cmd_wait);
+                       break;
+               default:
+                       break;
+               }
+               break;
+       default:
+               break;
+       }
+       return 0;
+}
+
+struct q6apm_graph *q6apm_graph_open(struct device *dev, q6apm_cb cb,
+                                    void *priv, int graph_id)
+{
+       struct q6apm *apm = dev_get_drvdata(dev->parent);
+       struct audioreach_graph *ar_graph;
+       struct q6apm_graph *graph;
+       int ret;
+
+       ar_graph = q6apm_get_audioreach_graph(apm, graph_id);
+       if (IS_ERR(ar_graph)) {
+               dev_err(dev, "No graph found with id %d\n", graph_id);
+               return ERR_CAST(ar_graph);
+       }
+
+       graph = kzalloc(sizeof(*graph), GFP_KERNEL);
+       if (!graph) {
+               ret = -ENOMEM;
+               goto err;
+       }
+
+       graph->apm = apm;
+       graph->priv = priv;
+       graph->cb = cb;
+       graph->info = ar_graph->info;
+       graph->ar_graph = ar_graph;
+       graph->id = ar_graph->id;
+       graph->dev = dev;
+
+       mutex_init(&graph->lock);
+       init_waitqueue_head(&graph->cmd_wait);
+
+       graph->port = gpr_alloc_port(apm->gdev, dev, graph_callback, graph);
+       if (!graph->port) {
+               kfree(graph);
+               ret = -ENOMEM;
+               goto err;
+       }
+
+       return graph;
+err:
+       kref_put(&ar_graph->refcount, q6apm_put_audioreach_graph);
+       return ERR_PTR(ret);
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_open);
+
+int q6apm_graph_close(struct q6apm_graph *graph)
+{
+       struct audioreach_graph *ar_graph = graph->ar_graph;
+
+       gpr_free_port(graph->port);
+       kref_put(&ar_graph->refcount, q6apm_put_audioreach_graph);
+       kfree(graph);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_close);
+
+int q6apm_graph_prepare(struct q6apm_graph *graph)
+{
+       return audioreach_graph_mgmt_cmd(graph->ar_graph, APM_CMD_GRAPH_PREPARE);
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_prepare);
+
+int q6apm_graph_start(struct q6apm_graph *graph)
+{
+       struct audioreach_graph *ar_graph = graph->ar_graph;
+       int ret = 0;
+
+       if (ar_graph->start_count == 0)
+               ret = audioreach_graph_mgmt_cmd(ar_graph, APM_CMD_GRAPH_START);
+
+       ar_graph->start_count++;
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_start);
+
+int q6apm_graph_stop(struct q6apm_graph *graph)
+{
+       struct audioreach_graph *ar_graph = graph->ar_graph;
+
+       if (--ar_graph->start_count > 0)
+               return 0;
+
+       return audioreach_graph_mgmt_cmd(ar_graph, APM_CMD_GRAPH_STOP);
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_stop);
+
+int q6apm_graph_flush(struct q6apm_graph *graph)
+{
+       return audioreach_graph_mgmt_cmd(graph->ar_graph, APM_CMD_GRAPH_FLUSH);
+}
+EXPORT_SYMBOL_GPL(q6apm_graph_flush);
+
+static int q6apm_audio_probe(struct snd_soc_component *component)
+{
+       return audioreach_tplg_init(component);
+}
+
+static void q6apm_audio_remove(struct snd_soc_component *component)
+{
+       /* remove topology */
+       snd_soc_tplg_component_remove(component);
+}
+
+#define APM_AUDIO_DRV_NAME "q6apm-audio"
+
+static const struct snd_soc_component_driver q6apm_audio_component = {
+       .name           = APM_AUDIO_DRV_NAME,
+       .probe          = q6apm_audio_probe,
+       .remove         = q6apm_audio_remove,
+};
+
+static int apm_probe(gpr_device_t *gdev)
+{
+       struct device *dev = &gdev->dev;
+       struct q6apm *apm;
+       int ret;
+
+       apm = devm_kzalloc(dev, sizeof(*apm), GFP_KERNEL);
+       if (!apm)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, apm);
+
+       mutex_init(&apm->lock);
+       apm->dev = dev;
+       apm->gdev = gdev;
+       init_waitqueue_head(&apm->wait);
+
+       idr_init(&apm->graph_idr);
+       idr_init(&apm->graph_info_idr);
+       idr_init(&apm->sub_graphs_idr);
+       idr_init(&apm->containers_idr);
+
+       idr_init(&apm->modules_idr);
+
+       q6apm_get_apm_state(apm);
+
+       ret = devm_snd_soc_register_component(dev, &q6apm_audio_component, NULL, 0);
+       if (ret < 0) {
+               dev_err(dev, "failed to get register q6apm: %d\n", ret);
+               return ret;
+       }
+
+       return of_platform_populate(dev->of_node, NULL, NULL, dev);
+}
+
+struct audioreach_module *q6apm_find_module_by_mid(struct q6apm_graph *graph, uint32_t mid)
+{
+       struct audioreach_graph_info *info = graph->info;
+       struct q6apm *apm = graph->apm;
+
+       return __q6apm_find_module_by_mid(apm, info, mid);
+
+}
+
+static int apm_callback(struct gpr_resp_pkt *data, void *priv, int op)
+{
+       gpr_device_t *gdev = priv;
+       struct q6apm *apm = dev_get_drvdata(&gdev->dev);
+       struct device *dev = &gdev->dev;
+       struct gpr_ibasic_rsp_result_t *result;
+       struct gpr_hdr *hdr = &data->hdr;
+
+       result = data->payload;
+
+       switch (hdr->opcode) {
+       case APM_CMD_RSP_GET_SPF_STATE:
+               apm->result.opcode = hdr->opcode;
+               apm->result.status = 0;
+               /* First word of result it state */
+               apm->state = result->opcode;
+               wake_up(&apm->wait);
+               break;
+       case GPR_BASIC_RSP_RESULT:
+               switch (result->opcode) {
+               case APM_CMD_GRAPH_START:
+               case APM_CMD_GRAPH_OPEN:
+               case APM_CMD_GRAPH_PREPARE:
+               case APM_CMD_GRAPH_CLOSE:
+               case APM_CMD_GRAPH_FLUSH:
+               case APM_CMD_GRAPH_STOP:
+               case APM_CMD_SET_CFG:
+                       apm->result.opcode = result->opcode;
+                       apm->result.status = result->status;
+                       if (result->status)
+                               dev_err(dev, "Error (%d) Processing 0x%08x cmd\n", result->status,
+                                       result->opcode);
+                       wake_up(&apm->wait);
+                       break;
+               default:
+                       break;
+               }
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id apm_device_id[]  = {
+       { .compatible = "qcom,q6apm" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, apm_device_id);
+#endif
+
+static gpr_driver_t apm_driver = {
+       .probe = apm_probe,
+       .gpr_callback = apm_callback,
+       .driver = {
+               .name = "qcom-apm",
+               .of_match_table = of_match_ptr(apm_device_id),
+       },
+};
+
+module_gpr_driver(apm_driver);
+MODULE_DESCRIPTION("Audio Process Manager");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6apm.h b/sound/soc/qcom/qdsp6/q6apm.h
new file mode 100644 (file)
index 0000000..54eadad
--- /dev/null
@@ -0,0 +1,152 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __Q6APM_H__
+#define __Q6APM_H__
+#include <linux/types.h>
+#include <linux/slab.h>
+#include <linux/wait.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/sched.h>
+#include <linux/of.h>
+#include <linux/delay.h>
+#include <sound/soc.h>
+#include <linux/of_platform.h>
+#include <linux/jiffies.h>
+#include <linux/soc/qcom/apr.h>
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+#include "audioreach.h"
+
+#define APM_PORT_MAX           127
+#define APM_PORT_MAX_AUDIO_CHAN_CNT 8
+#define PCM_CHANNEL_NULL 0
+#define PCM_CHANNEL_FL    1    /* Front left channel. */
+#define PCM_CHANNEL_FR    2    /* Front right channel. */
+#define PCM_CHANNEL_FC    3    /* Front center channel. */
+#define PCM_CHANNEL_LS   4     /* Left surround channel. */
+#define PCM_CHANNEL_RS   5     /* Right surround channel. */
+#define PCM_CHANNEL_LFE  6     /* Low frequency effect channel. */
+#define PCM_CHANNEL_CS   7     /* Center surround channel; Rear center ch */
+#define PCM_CHANNEL_LB   8     /* Left back channel; Rear left channel. */
+#define PCM_CHANNEL_RB   9     /* Right back channel; Rear right channel. */
+#define PCM_CHANNELS   10      /* Top surround channel. */
+
+#define APM_TIMESTAMP_FLAG     0x80000000
+#define FORMAT_LINEAR_PCM      0x0000
+/* APM client callback events */
+#define APM_CMD_EOS                            0x0003
+#define APM_CLIENT_EVENT_CMD_EOS_DONE          0x1003
+#define APM_CMD_CLOSE                          0x0004
+#define APM_CLIENT_EVENT_CMD_CLOSE_DONE                0x1004
+#define APM_CLIENT_EVENT_CMD_RUN_DONE          0x1008
+#define APM_CLIENT_EVENT_DATA_WRITE_DONE       0x1009
+#define APM_CLIENT_EVENT_DATA_READ_DONE                0x100a
+#define APM_WRITE_TOKEN_MASK                   GENMASK(15, 0)
+#define APM_WRITE_TOKEN_LEN_MASK               GENMASK(31, 16)
+#define APM_WRITE_TOKEN_LEN_SHIFT              16
+
+#define APM_MAX_SESSIONS                       8
+
+struct q6apm {
+       struct device *dev;
+       gpr_port_t *port;
+       gpr_device_t *gdev;
+       /* For Graph OPEN/START/STOP/CLOSE operations */
+       wait_queue_head_t wait;
+       struct gpr_ibasic_rsp_result_t result;
+
+       struct mutex cmd_lock;
+       struct mutex lock;
+       uint32_t state;
+
+       struct idr graph_idr;
+       struct idr graph_info_idr;
+       struct idr sub_graphs_idr;
+       struct idr containers_idr;
+       struct idr modules_idr;
+};
+
+struct audio_buffer {
+       phys_addr_t phys;
+       uint32_t size;          /* size of buffer */
+};
+
+struct audioreach_graph_data {
+       struct audio_buffer *buf;
+       uint32_t num_periods;
+       uint32_t dsp_buf;
+       uint32_t mem_map_handle;
+};
+
+struct audioreach_graph {
+       struct audioreach_graph_info *info;
+       uint32_t id;
+       int state;
+       int start_count;
+       /* Cached Graph data */
+       void *graph;
+       struct kref refcount;
+       struct q6apm *apm;
+};
+
+typedef void (*q6apm_cb) (uint32_t opcode, uint32_t token,
+                         void *payload, void *priv);
+struct q6apm_graph {
+       void *priv;
+       q6apm_cb cb;
+       uint32_t id;
+       struct device *dev;
+       struct q6apm *apm;
+       gpr_port_t *port;
+       struct audioreach_graph_data rx_data;
+       struct audioreach_graph_data tx_data;
+       struct gpr_ibasic_rsp_result_t result;
+       wait_queue_head_t cmd_wait;
+       struct mutex lock;
+       struct audioreach_graph *ar_graph;
+       struct audioreach_graph_info *info;
+};
+
+/* Graph Operations */
+struct q6apm_graph *q6apm_graph_open(struct device *dev, q6apm_cb cb,
+                                    void *priv, int graph_id);
+int q6apm_graph_close(struct q6apm_graph *graph);
+int q6apm_graph_prepare(struct q6apm_graph *graph);
+int q6apm_graph_start(struct q6apm_graph *graph);
+int q6apm_graph_stop(struct q6apm_graph *graph);
+int q6apm_graph_flush(struct q6apm_graph *graph);
+
+/* Media Format */
+int q6apm_graph_media_format_pcm(struct q6apm_graph *graph,
+                                struct audioreach_module_config *cfg);
+
+int q6apm_graph_media_format_shmem(struct q6apm_graph *graph,
+                                  struct audioreach_module_config *cfg);
+
+/* read/write related */
+int q6apm_send_eos_nowait(struct q6apm_graph *graph);
+int q6apm_read(struct q6apm_graph *graph);
+int q6apm_write_async(struct q6apm_graph *graph, uint32_t len, uint32_t msw_ts,
+                     uint32_t lsw_ts, uint32_t wflags);
+
+/* Memory Map related */
+int q6apm_map_memory_regions(struct q6apm_graph *graph,
+                            unsigned int dir, phys_addr_t phys,
+                            size_t period_sz, unsigned int periods);
+int q6apm_unmap_memory_regions(struct q6apm_graph *graph,
+                              unsigned int dir);
+/* Helpers */
+int q6apm_send_cmd_sync(struct q6apm *apm, struct gpr_pkt *pkt,
+                       uint32_t rsp_opcode);
+
+/* Callback for graph specific */
+struct audioreach_module *q6apm_find_module_by_mid(struct q6apm_graph *graph,
+                                                   uint32_t mid);
+
+void q6apm_set_fe_dai_ops(struct snd_soc_dai_driver *dai_drv);
+int q6apm_connect_sub_graphs(struct q6apm *apm, u32 src_sgid, u32 dst_sgid,
+                            bool connect);
+bool q6apm_is_sub_graphs_connected(struct q6apm *apm, u32 src_sgid,
+                                  u32 dst_sgid);
+int q6apm_graph_get_rx_shmem_module_iid(struct q6apm_graph *graph);
+
+#endif /* __APM_GRAPH_ */
diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.c
new file mode 100644 (file)
index 0000000..4613867
--- /dev/null
@@ -0,0 +1,186 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020, Linaro Limited
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/clk-provider.h>
+#include <linux/module.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/slab.h>
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+#include "q6dsp-lpass-clocks.h"
+
+#define Q6DSP_MAX_CLK_ID                       104
+#define Q6DSP_LPASS_CLK_ROOT_DEFAULT           0
+
+
+struct q6dsp_clk {
+       struct device *dev;
+       int q6dsp_clk_id;
+       int attributes;
+       int rate;
+       uint32_t handle;
+       struct clk_hw hw;
+};
+
+#define to_q6dsp_clk(_hw) container_of(_hw, struct q6dsp_clk, hw)
+
+struct q6dsp_cc {
+       struct device *dev;
+       struct q6dsp_clk *clks[Q6DSP_MAX_CLK_ID];
+       const struct q6dsp_clk_desc *desc;
+};
+
+static int clk_q6dsp_prepare(struct clk_hw *hw)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+       struct q6dsp_cc *cc = dev_get_drvdata(clk->dev);
+
+       return cc->desc->lpass_set_clk(clk->dev, clk->q6dsp_clk_id, clk->attributes,
+                                    Q6DSP_LPASS_CLK_ROOT_DEFAULT, clk->rate);
+}
+
+static void clk_q6dsp_unprepare(struct clk_hw *hw)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+       struct q6dsp_cc *cc = dev_get_drvdata(clk->dev);
+
+       cc->desc->lpass_set_clk(clk->dev, clk->q6dsp_clk_id, clk->attributes,
+                             Q6DSP_LPASS_CLK_ROOT_DEFAULT, 0);
+}
+
+static int clk_q6dsp_set_rate(struct clk_hw *hw, unsigned long rate,
+                             unsigned long parent_rate)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+
+       clk->rate = rate;
+
+       return 0;
+}
+
+static unsigned long clk_q6dsp_recalc_rate(struct clk_hw *hw,
+                                          unsigned long parent_rate)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+
+       return clk->rate;
+}
+
+static long clk_q6dsp_round_rate(struct clk_hw *hw, unsigned long rate,
+                                unsigned long *parent_rate)
+{
+       return rate;
+}
+
+static const struct clk_ops clk_q6dsp_ops = {
+       .prepare        = clk_q6dsp_prepare,
+       .unprepare      = clk_q6dsp_unprepare,
+       .set_rate       = clk_q6dsp_set_rate,
+       .round_rate     = clk_q6dsp_round_rate,
+       .recalc_rate    = clk_q6dsp_recalc_rate,
+};
+
+static int clk_vote_q6dsp_block(struct clk_hw *hw)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+       struct q6dsp_cc *cc = dev_get_drvdata(clk->dev);
+
+       return cc->desc->lpass_vote_clk(clk->dev, clk->q6dsp_clk_id,
+                                 clk_hw_get_name(&clk->hw), &clk->handle);
+}
+
+static void clk_unvote_q6dsp_block(struct clk_hw *hw)
+{
+       struct q6dsp_clk *clk = to_q6dsp_clk(hw);
+       struct q6dsp_cc *cc = dev_get_drvdata(clk->dev);
+
+       cc->desc->lpass_unvote_clk(clk->dev, clk->q6dsp_clk_id, clk->handle);
+}
+
+static const struct clk_ops clk_vote_q6dsp_ops = {
+       .prepare        = clk_vote_q6dsp_block,
+       .unprepare      = clk_unvote_q6dsp_block,
+};
+
+
+static struct clk_hw *q6dsp_of_clk_hw_get(struct of_phandle_args *clkspec,
+                                         void *data)
+{
+       struct q6dsp_cc *cc = data;
+       unsigned int idx = clkspec->args[0];
+       unsigned int attr = clkspec->args[1];
+
+       if (idx >= Q6DSP_MAX_CLK_ID || attr > LPASS_CLK_ATTRIBUTE_COUPLE_DIVISOR) {
+               dev_err(cc->dev, "Invalid clk specifier (%d, %d)\n", idx, attr);
+               return ERR_PTR(-EINVAL);
+       }
+
+       if (cc->clks[idx]) {
+               cc->clks[idx]->attributes = attr;
+               return &cc->clks[idx]->hw;
+       }
+
+       return ERR_PTR(-ENOENT);
+}
+
+int q6dsp_clock_dev_probe(struct platform_device *pdev)
+{
+       struct q6dsp_cc *cc;
+       struct device *dev = &pdev->dev;
+       const struct q6dsp_clk_init *q6dsp_clks;
+       const struct q6dsp_clk_desc *desc;
+       int i, ret;
+
+       cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
+       if (!cc)
+               return -ENOMEM;
+
+       desc = of_device_get_match_data(&pdev->dev);
+       if (!desc)
+               return -EINVAL;
+
+       cc->desc = desc;
+       cc->dev = dev;
+       q6dsp_clks = desc->clks;
+
+       for (i = 0; i < desc->num_clks; i++) {
+               unsigned int id = q6dsp_clks[i].clk_id;
+               struct clk_init_data init = {
+                       .name =  q6dsp_clks[i].name,
+               };
+               struct q6dsp_clk *clk;
+
+               clk = devm_kzalloc(dev, sizeof(*clk), GFP_KERNEL);
+               if (!clk)
+                       return -ENOMEM;
+
+               clk->dev = dev;
+               clk->q6dsp_clk_id = q6dsp_clks[i].q6dsp_clk_id;
+               clk->rate = q6dsp_clks[i].rate;
+               clk->hw.init = &init;
+
+               if (clk->rate)
+                       init.ops = &clk_q6dsp_ops;
+               else
+                       init.ops = &clk_vote_q6dsp_ops;
+
+               cc->clks[id] = clk;
+
+               ret = devm_clk_hw_register(dev, &clk->hw);
+               if (ret)
+                       return ret;
+       }
+
+       ret = devm_of_clk_add_hw_provider(dev, q6dsp_of_clk_hw_get, cc);
+       if (ret)
+               return ret;
+
+       dev_set_drvdata(dev, cc);
+
+       return 0;
+}
+EXPORT_SYMBOL_GPL(q6dsp_clock_dev_probe);
diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.h b/sound/soc/qcom/qdsp6/q6dsp-lpass-clocks.h
new file mode 100644 (file)
index 0000000..3770d81
--- /dev/null
@@ -0,0 +1,30 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __Q6DSP_AUDIO_CLOCKS_H__
+#define __Q6DSP_AUDIO_CLOCKS_H__
+
+struct q6dsp_clk_init {
+       int clk_id;
+       int q6dsp_clk_id;
+       char *name;
+       int rate;
+};
+
+#define Q6DSP_VOTE_CLK(id, blkid, n) {                 \
+               .clk_id = id,                           \
+               .q6dsp_clk_id = blkid,                  \
+               .name = n,                              \
+       }
+
+struct q6dsp_clk_desc {
+       const struct q6dsp_clk_init *clks;
+       size_t num_clks;
+       int (*lpass_set_clk)(struct device *dev, int clk_id, int attr,
+                             int root_clk, unsigned int freq);
+       int (*lpass_vote_clk)(struct device *dev, uint32_t hid, const char *n, uint32_t *h);
+       int (*lpass_unvote_clk)(struct device *dev, uint32_t hid, uint32_t h);
+};
+
+int q6dsp_clock_dev_probe(struct platform_device *pdev);
+
+#endif  /* __Q6DSP_AUDIO_CLOCKS_H__ */
diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.c
new file mode 100644 (file)
index 0000000..f67c16f
--- /dev/null
@@ -0,0 +1,627 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020, Linaro Limited
+
+#include <sound/pcm.h>
+#include <sound/soc.h>
+#include <sound/pcm_params.h>
+#include <dt-bindings/sound/qcom,q6afe.h>
+#include "q6dsp-lpass-ports.h"
+
+#define Q6AFE_TDM_PB_DAI(pre, num, did) {                              \
+               .playback = {                                           \
+                       .stream_name = pre" TDM"#num" Playback",        \
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
+                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
+                               SNDRV_PCM_RATE_176400,                  \
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
+                                  SNDRV_PCM_FMTBIT_S24_LE |            \
+                                  SNDRV_PCM_FMTBIT_S32_LE,             \
+                       .channels_min = 1,                              \
+                       .channels_max = 8,                              \
+                       .rate_min = 8000,                               \
+                       .rate_max = 176400,                             \
+               },                                                      \
+               .name = #did,                                           \
+               .id = did,                                              \
+       }
+
+#define Q6AFE_TDM_CAP_DAI(pre, num, did) {                             \
+               .capture = {                                            \
+                       .stream_name = pre" TDM"#num" Capture",         \
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
+                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
+                               SNDRV_PCM_RATE_176400,                  \
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
+                                  SNDRV_PCM_FMTBIT_S24_LE |            \
+                                  SNDRV_PCM_FMTBIT_S32_LE,             \
+                       .channels_min = 1,                              \
+                       .channels_max = 8,                              \
+                       .rate_min = 8000,                               \
+                       .rate_max = 176400,                             \
+               },                                                      \
+               .name = #did,                                           \
+               .id = did,                                              \
+       }
+
+#define Q6AFE_CDC_DMA_RX_DAI(did) {                            \
+               .playback = {                                           \
+                       .stream_name = #did" Playback", \
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
+                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
+                               SNDRV_PCM_RATE_176400,                  \
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
+                                  SNDRV_PCM_FMTBIT_S24_LE |            \
+                                  SNDRV_PCM_FMTBIT_S32_LE,             \
+                       .channels_min = 1,                              \
+                       .channels_max = 8,                              \
+                       .rate_min = 8000,                               \
+                       .rate_max = 176400,                             \
+               },                                                      \
+               .name = #did,                                           \
+               .id = did,                                              \
+       }
+
+#define Q6AFE_CDC_DMA_TX_DAI(did) {                            \
+               .capture = {                                            \
+                       .stream_name = #did" Capture",          \
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |\
+                               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_48000 |\
+                               SNDRV_PCM_RATE_176400,                  \
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |            \
+                                  SNDRV_PCM_FMTBIT_S24_LE |            \
+                                  SNDRV_PCM_FMTBIT_S32_LE,             \
+                       .channels_min = 1,                              \
+                       .channels_max = 8,                              \
+                       .rate_min = 8000,                               \
+                       .rate_max = 176400,                             \
+               },                                                      \
+               .name = #did,                                           \
+               .id = did,                                              \
+       }
+
+
+static struct snd_soc_dai_driver q6dsp_audio_fe_dais[] = {
+       {
+               .playback = {
+                       .stream_name = "HDMI Playback",
+                       .rates = SNDRV_PCM_RATE_48000 |
+                                SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 2,
+                       .channels_max = 8,
+                       .rate_max =     192000,
+                       .rate_min =     48000,
+               },
+               .id = HDMI_RX,
+               .name = "HDMI",
+       }, {
+               .name = "SLIMBUS_0_RX",
+               .id = SLIMBUS_0_RX,
+               .playback = {
+                       .stream_name = "Slimbus Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .name = "SLIMBUS_0_TX",
+               .id = SLIMBUS_0_TX,
+               .capture = {
+                       .stream_name = "Slimbus Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus1 Playback",
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_1_RX",
+               .id = SLIMBUS_1_RX,
+       }, {
+               .name = "SLIMBUS_1_TX",
+               .id = SLIMBUS_1_TX,
+               .capture = {
+                       .stream_name = "Slimbus1 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus2 Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_2_RX",
+               .id = SLIMBUS_2_RX,
+
+       }, {
+               .name = "SLIMBUS_2_TX",
+               .id = SLIMBUS_2_TX,
+               .capture = {
+                       .stream_name = "Slimbus2 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus3 Playback",
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_3_RX",
+               .id = SLIMBUS_3_RX,
+
+       }, {
+               .name = "SLIMBUS_3_TX",
+               .id = SLIMBUS_3_TX,
+               .capture = {
+                       .stream_name = "Slimbus3 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus4 Playback",
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_4_RX",
+               .id = SLIMBUS_4_RX,
+
+       }, {
+               .name = "SLIMBUS_4_TX",
+               .id = SLIMBUS_4_TX,
+               .capture = {
+                       .stream_name = "Slimbus4 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus5 Playback",
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_5_RX",
+               .id = SLIMBUS_5_RX,
+
+       }, {
+               .name = "SLIMBUS_5_TX",
+               .id = SLIMBUS_5_TX,
+               .capture = {
+                       .stream_name = "Slimbus5 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Slimbus6 Playback",
+                       .rates = SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_16000 |
+                                SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+               .name = "SLIMBUS_6_RX",
+               .id = SLIMBUS_6_RX,
+
+       }, {
+               .name = "SLIMBUS_6_TX",
+               .id = SLIMBUS_6_TX,
+               .capture = {
+                       .stream_name = "Slimbus6 Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min = 8000,
+                       .rate_max = 192000,
+               },
+       }, {
+               .playback = {
+                       .stream_name = "Primary MI2S Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = PRIMARY_MI2S_RX,
+               .name = "PRI_MI2S_RX",
+       }, {
+               .capture = {
+                       .stream_name = "Primary MI2S Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = PRIMARY_MI2S_TX,
+               .name = "PRI_MI2S_TX",
+       }, {
+               .playback = {
+                       .stream_name = "Secondary MI2S Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .name = "SEC_MI2S_RX",
+               .id = SECONDARY_MI2S_RX,
+       }, {
+               .capture = {
+                       .stream_name = "Secondary MI2S Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = SECONDARY_MI2S_TX,
+               .name = "SEC_MI2S_TX",
+       }, {
+               .playback = {
+                       .stream_name = "Tertiary MI2S Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .name = "TERT_MI2S_RX",
+               .id = TERTIARY_MI2S_RX,
+       }, {
+               .capture = {
+                       .stream_name = "Tertiary MI2S Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = TERTIARY_MI2S_TX,
+               .name = "TERT_MI2S_TX",
+       }, {
+               .playback = {
+                       .stream_name = "Quaternary MI2S Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .name = "QUAT_MI2S_RX",
+               .id = QUATERNARY_MI2S_RX,
+       }, {
+               .capture = {
+                       .stream_name = "Quaternary MI2S Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = QUATERNARY_MI2S_TX,
+               .name = "QUAT_MI2S_TX",
+       }, {
+               .playback = {
+                       .stream_name = "Quinary MI2S Playback",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                       SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_96000 |
+                       SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     192000,
+               },
+               .id = QUINARY_MI2S_RX,
+               .name = "QUIN_MI2S_RX",
+       }, {
+               .capture = {
+                       .stream_name = "Quinary MI2S Capture",
+                       .rates = SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_8000 |
+                                SNDRV_PCM_RATE_16000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE,
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rate_min =     8000,
+                       .rate_max =     48000,
+               },
+               .id = QUINARY_MI2S_TX,
+               .name = "QUIN_MI2S_TX",
+       },
+       Q6AFE_TDM_PB_DAI("Primary", 0, PRIMARY_TDM_RX_0),
+       Q6AFE_TDM_PB_DAI("Primary", 1, PRIMARY_TDM_RX_1),
+       Q6AFE_TDM_PB_DAI("Primary", 2, PRIMARY_TDM_RX_2),
+       Q6AFE_TDM_PB_DAI("Primary", 3, PRIMARY_TDM_RX_3),
+       Q6AFE_TDM_PB_DAI("Primary", 4, PRIMARY_TDM_RX_4),
+       Q6AFE_TDM_PB_DAI("Primary", 5, PRIMARY_TDM_RX_5),
+       Q6AFE_TDM_PB_DAI("Primary", 6, PRIMARY_TDM_RX_6),
+       Q6AFE_TDM_PB_DAI("Primary", 7, PRIMARY_TDM_RX_7),
+       Q6AFE_TDM_CAP_DAI("Primary", 0, PRIMARY_TDM_TX_0),
+       Q6AFE_TDM_CAP_DAI("Primary", 1, PRIMARY_TDM_TX_1),
+       Q6AFE_TDM_CAP_DAI("Primary", 2, PRIMARY_TDM_TX_2),
+       Q6AFE_TDM_CAP_DAI("Primary", 3, PRIMARY_TDM_TX_3),
+       Q6AFE_TDM_CAP_DAI("Primary", 4, PRIMARY_TDM_TX_4),
+       Q6AFE_TDM_CAP_DAI("Primary", 5, PRIMARY_TDM_TX_5),
+       Q6AFE_TDM_CAP_DAI("Primary", 6, PRIMARY_TDM_TX_6),
+       Q6AFE_TDM_CAP_DAI("Primary", 7, PRIMARY_TDM_TX_7),
+       Q6AFE_TDM_PB_DAI("Secondary", 0, SECONDARY_TDM_RX_0),
+       Q6AFE_TDM_PB_DAI("Secondary", 1, SECONDARY_TDM_RX_1),
+       Q6AFE_TDM_PB_DAI("Secondary", 2, SECONDARY_TDM_RX_2),
+       Q6AFE_TDM_PB_DAI("Secondary", 3, SECONDARY_TDM_RX_3),
+       Q6AFE_TDM_PB_DAI("Secondary", 4, SECONDARY_TDM_RX_4),
+       Q6AFE_TDM_PB_DAI("Secondary", 5, SECONDARY_TDM_RX_5),
+       Q6AFE_TDM_PB_DAI("Secondary", 6, SECONDARY_TDM_RX_6),
+       Q6AFE_TDM_PB_DAI("Secondary", 7, SECONDARY_TDM_RX_7),
+       Q6AFE_TDM_CAP_DAI("Secondary", 0, SECONDARY_TDM_TX_0),
+       Q6AFE_TDM_CAP_DAI("Secondary", 1, SECONDARY_TDM_TX_1),
+       Q6AFE_TDM_CAP_DAI("Secondary", 2, SECONDARY_TDM_TX_2),
+       Q6AFE_TDM_CAP_DAI("Secondary", 3, SECONDARY_TDM_TX_3),
+       Q6AFE_TDM_CAP_DAI("Secondary", 4, SECONDARY_TDM_TX_4),
+       Q6AFE_TDM_CAP_DAI("Secondary", 5, SECONDARY_TDM_TX_5),
+       Q6AFE_TDM_CAP_DAI("Secondary", 6, SECONDARY_TDM_TX_6),
+       Q6AFE_TDM_CAP_DAI("Secondary", 7, SECONDARY_TDM_TX_7),
+       Q6AFE_TDM_PB_DAI("Tertiary", 0, TERTIARY_TDM_RX_0),
+       Q6AFE_TDM_PB_DAI("Tertiary", 1, TERTIARY_TDM_RX_1),
+       Q6AFE_TDM_PB_DAI("Tertiary", 2, TERTIARY_TDM_RX_2),
+       Q6AFE_TDM_PB_DAI("Tertiary", 3, TERTIARY_TDM_RX_3),
+       Q6AFE_TDM_PB_DAI("Tertiary", 4, TERTIARY_TDM_RX_4),
+       Q6AFE_TDM_PB_DAI("Tertiary", 5, TERTIARY_TDM_RX_5),
+       Q6AFE_TDM_PB_DAI("Tertiary", 6, TERTIARY_TDM_RX_6),
+       Q6AFE_TDM_PB_DAI("Tertiary", 7, TERTIARY_TDM_RX_7),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 0, TERTIARY_TDM_TX_0),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 1, TERTIARY_TDM_TX_1),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 2, TERTIARY_TDM_TX_2),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 3, TERTIARY_TDM_TX_3),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 4, TERTIARY_TDM_TX_4),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 5, TERTIARY_TDM_TX_5),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 6, TERTIARY_TDM_TX_6),
+       Q6AFE_TDM_CAP_DAI("Tertiary", 7, TERTIARY_TDM_TX_7),
+       Q6AFE_TDM_PB_DAI("Quaternary", 0, QUATERNARY_TDM_RX_0),
+       Q6AFE_TDM_PB_DAI("Quaternary", 1, QUATERNARY_TDM_RX_1),
+       Q6AFE_TDM_PB_DAI("Quaternary", 2, QUATERNARY_TDM_RX_2),
+       Q6AFE_TDM_PB_DAI("Quaternary", 3, QUATERNARY_TDM_RX_3),
+       Q6AFE_TDM_PB_DAI("Quaternary", 4, QUATERNARY_TDM_RX_4),
+       Q6AFE_TDM_PB_DAI("Quaternary", 5, QUATERNARY_TDM_RX_5),
+       Q6AFE_TDM_PB_DAI("Quaternary", 6, QUATERNARY_TDM_RX_6),
+       Q6AFE_TDM_PB_DAI("Quaternary", 7, QUATERNARY_TDM_RX_7),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 0, QUATERNARY_TDM_TX_0),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 1, QUATERNARY_TDM_TX_1),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 2, QUATERNARY_TDM_TX_2),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 3, QUATERNARY_TDM_TX_3),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 4, QUATERNARY_TDM_TX_4),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 5, QUATERNARY_TDM_TX_5),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 6, QUATERNARY_TDM_TX_6),
+       Q6AFE_TDM_CAP_DAI("Quaternary", 7, QUATERNARY_TDM_TX_7),
+       Q6AFE_TDM_PB_DAI("Quinary", 0, QUINARY_TDM_RX_0),
+       Q6AFE_TDM_PB_DAI("Quinary", 1, QUINARY_TDM_RX_1),
+       Q6AFE_TDM_PB_DAI("Quinary", 2, QUINARY_TDM_RX_2),
+       Q6AFE_TDM_PB_DAI("Quinary", 3, QUINARY_TDM_RX_3),
+       Q6AFE_TDM_PB_DAI("Quinary", 4, QUINARY_TDM_RX_4),
+       Q6AFE_TDM_PB_DAI("Quinary", 5, QUINARY_TDM_RX_5),
+       Q6AFE_TDM_PB_DAI("Quinary", 6, QUINARY_TDM_RX_6),
+       Q6AFE_TDM_PB_DAI("Quinary", 7, QUINARY_TDM_RX_7),
+       Q6AFE_TDM_CAP_DAI("Quinary", 0, QUINARY_TDM_TX_0),
+       Q6AFE_TDM_CAP_DAI("Quinary", 1, QUINARY_TDM_TX_1),
+       Q6AFE_TDM_CAP_DAI("Quinary", 2, QUINARY_TDM_TX_2),
+       Q6AFE_TDM_CAP_DAI("Quinary", 3, QUINARY_TDM_TX_3),
+       Q6AFE_TDM_CAP_DAI("Quinary", 4, QUINARY_TDM_TX_4),
+       Q6AFE_TDM_CAP_DAI("Quinary", 5, QUINARY_TDM_TX_5),
+       Q6AFE_TDM_CAP_DAI("Quinary", 6, QUINARY_TDM_TX_6),
+       Q6AFE_TDM_CAP_DAI("Quinary", 7, QUINARY_TDM_TX_7),
+       {
+               .playback = {
+                       .stream_name = "Display Port Playback",
+                       .rates = SNDRV_PCM_RATE_48000 |
+                                SNDRV_PCM_RATE_96000 |
+                                SNDRV_PCM_RATE_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S16_LE |
+                                  SNDRV_PCM_FMTBIT_S24_LE,
+                       .channels_min = 2,
+                       .channels_max = 8,
+                       .rate_max =     192000,
+                       .rate_min =     48000,
+               },
+               .id = DISPLAY_PORT_RX,
+               .name = "DISPLAY_PORT",
+       },
+       Q6AFE_CDC_DMA_RX_DAI(WSA_CODEC_DMA_RX_0),
+       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_0),
+       Q6AFE_CDC_DMA_RX_DAI(WSA_CODEC_DMA_RX_1),
+       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_1),
+       Q6AFE_CDC_DMA_TX_DAI(WSA_CODEC_DMA_TX_2),
+       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_0),
+       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_1),
+       Q6AFE_CDC_DMA_TX_DAI(VA_CODEC_DMA_TX_2),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_0),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_0),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_1),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_1),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_2),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_2),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_3),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_3),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_4),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_4),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_5),
+       Q6AFE_CDC_DMA_TX_DAI(TX_CODEC_DMA_TX_5),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_6),
+       Q6AFE_CDC_DMA_RX_DAI(RX_CODEC_DMA_RX_7),
+};
+
+int q6dsp_audio_ports_of_xlate_dai_name(struct snd_soc_component *component,
+                                       const struct of_phandle_args *args,
+                                       const char **dai_name)
+{
+       int id = args->args[0];
+       int ret = -EINVAL;
+       int i;
+
+       for (i = 0; i  < ARRAY_SIZE(q6dsp_audio_fe_dais); i++) {
+               if (q6dsp_audio_fe_dais[i].id == id) {
+                       *dai_name = q6dsp_audio_fe_dais[i].name;
+                       ret = 0;
+                       break;
+               }
+       }
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(q6dsp_audio_ports_of_xlate_dai_name);
+
+struct snd_soc_dai_driver *q6dsp_audio_ports_set_config(struct device *dev,
+                               struct q6dsp_audio_port_dai_driver_config *cfg,
+                               int *num_dais)
+{
+       int i;
+
+       for (i = 0; i  < ARRAY_SIZE(q6dsp_audio_fe_dais); i++) {
+               q6dsp_audio_fe_dais[i].probe = cfg->probe;
+               q6dsp_audio_fe_dais[i].remove = cfg->remove;
+
+               switch (q6dsp_audio_fe_dais[i].id) {
+               case HDMI_RX:
+               case DISPLAY_PORT_RX:
+                       q6dsp_audio_fe_dais[i].ops = cfg->q6hdmi_ops;
+                       break;
+               case SLIMBUS_0_RX ... SLIMBUS_6_TX:
+                       q6dsp_audio_fe_dais[i].ops = cfg->q6slim_ops;
+                       break;
+               case QUINARY_MI2S_RX ... QUINARY_MI2S_TX:
+               case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX:
+                       q6dsp_audio_fe_dais[i].ops = cfg->q6i2s_ops;
+                       break;
+               case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7:
+                       q6dsp_audio_fe_dais[i].ops = cfg->q6tdm_ops;
+                       break;
+               case WSA_CODEC_DMA_RX_0 ... RX_CODEC_DMA_RX_7:
+                       q6dsp_audio_fe_dais[i].ops = cfg->q6dma_ops;
+                       break;
+               default:
+                       break;
+               }
+       }
+
+       *num_dais = ARRAY_SIZE(q6dsp_audio_fe_dais);
+       return q6dsp_audio_fe_dais;
+}
+EXPORT_SYMBOL_GPL(q6dsp_audio_ports_set_config);
diff --git a/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h b/sound/soc/qcom/qdsp6/q6dsp-lpass-ports.h
new file mode 100644 (file)
index 0000000..7f052c8
--- /dev/null
@@ -0,0 +1,22 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __Q6DSP_AUDIO_PORTS_H__
+#define __Q6DSP_AUDIO_PORTS_H__
+
+struct q6dsp_audio_port_dai_driver_config {
+       int (*probe)(struct snd_soc_dai *dai);
+       int (*remove)(struct snd_soc_dai *dai);
+       const struct snd_soc_dai_ops *q6hdmi_ops;
+       const struct snd_soc_dai_ops *q6slim_ops;
+       const struct snd_soc_dai_ops *q6i2s_ops;
+       const struct snd_soc_dai_ops *q6tdm_ops;
+       const struct snd_soc_dai_ops *q6dma_ops;
+};
+
+struct snd_soc_dai_driver *q6dsp_audio_ports_set_config(struct device *dev,
+                                       struct q6dsp_audio_port_dai_driver_config *cfg,
+                                       int *num_dais);
+int q6dsp_audio_ports_of_xlate_dai_name(struct snd_soc_component *component,
+                                       const struct of_phandle_args *args,
+                                       const char **dai_name);
+#endif /* __Q6DSP_AUDIO_PORTS_H__ */
diff --git a/sound/soc/qcom/qdsp6/q6prm-clocks.c b/sound/soc/qcom/qdsp6/q6prm-clocks.c
new file mode 100644 (file)
index 0000000..a26cda5
--- /dev/null
@@ -0,0 +1,85 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2021, Linaro Limited
+
+#include <linux/err.h>
+#include <linux/init.h>
+#include <linux/clk-provider.h>
+#include <linux/module.h>
+#include <linux/device.h>
+#include <linux/platform_device.h>
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+#include "q6dsp-lpass-clocks.h"
+#include "q6prm.h"
+
+#define Q6PRM_CLK(id) {                                        \
+               .clk_id = id,                           \
+               .q6dsp_clk_id   = Q6PRM_##id,           \
+               .name = #id,                            \
+               .rate = 19200000,                       \
+       }
+
+static const struct q6dsp_clk_init q6prm_clks[] = {
+       Q6PRM_CLK(LPASS_CLK_ID_PRI_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_PRI_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SEC_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SEC_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_TER_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_TER_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_QUAD_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_QUAD_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SPEAKER_I2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SPEAKER_I2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SPEAKER_I2S_OSR),
+       Q6PRM_CLK(LPASS_CLK_ID_QUI_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_QUI_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SEN_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_SEN_MI2S_EBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT0_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT1_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT2_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT3_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT4_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT5_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_INT6_MI2S_IBIT),
+       Q6PRM_CLK(LPASS_CLK_ID_QUI_MI2S_OSR),
+       Q6PRM_CLK(LPASS_CLK_ID_WSA_CORE_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_WSA_CORE_NPL_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_VA_CORE_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_TX_CORE_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_TX_CORE_NPL_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_RX_CORE_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_RX_CORE_NPL_MCLK),
+       Q6PRM_CLK(LPASS_CLK_ID_VA_CORE_2X_MCLK),
+       Q6DSP_VOTE_CLK(LPASS_HW_MACRO_VOTE, Q6PRM_HW_CORE_ID_LPASS,
+                      "LPASS_HW_MACRO"),
+       Q6DSP_VOTE_CLK(LPASS_HW_DCODEC_VOTE, Q6PRM_HW_CORE_ID_DCODEC,
+                      "LPASS_HW_DCODEC"),
+};
+
+static const struct q6dsp_clk_desc q6dsp_clk_q6prm __maybe_unused = {
+       .clks = q6prm_clks,
+       .num_clks = ARRAY_SIZE(q6prm_clks),
+       .lpass_set_clk = q6prm_set_lpass_clock,
+       .lpass_vote_clk = q6prm_vote_lpass_core_hw,
+       .lpass_unvote_clk = q6prm_unvote_lpass_core_hw,
+};
+
+#ifdef CONFIG_OF
+static const struct of_device_id q6prm_clock_device_id[] = {
+       { .compatible = "qcom,q6prm-lpass-clocks", .data = &q6dsp_clk_q6prm },
+       {},
+};
+MODULE_DEVICE_TABLE(of, q6prm_clock_device_id);
+#endif
+
+static struct platform_driver q6prm_clock_platform_driver = {
+       .driver = {
+               .name = "q6prm-lpass-clock",
+               .of_match_table = of_match_ptr(q6prm_clock_device_id),
+       },
+       .probe = q6dsp_clock_dev_probe,
+};
+module_platform_driver(q6prm_clock_platform_driver);
+
+MODULE_DESCRIPTION("Q6 Proxy Resource Manager LPASS clock driver");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6prm.c b/sound/soc/qcom/qdsp6/q6prm.c
new file mode 100644 (file)
index 0000000..82c40f2
--- /dev/null
@@ -0,0 +1,202 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2021, Linaro Limited
+
+#include <linux/slab.h>
+#include <linux/wait.h>
+#include <linux/kernel.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/delay.h>
+#include <linux/of_platform.h>
+#include <linux/jiffies.h>
+#include <linux/soc/qcom/apr.h>
+#include <dt-bindings/soc/qcom,gpr.h>
+#include <dt-bindings/sound/qcom,q6dsp-lpass-ports.h>
+#include "q6prm.h"
+#include "audioreach.h"
+
+struct q6prm {
+       struct device *dev;
+       gpr_device_t *gdev;
+       wait_queue_head_t wait;
+       struct gpr_ibasic_rsp_result_t result;
+       struct mutex lock;
+};
+
+#define PRM_CMD_REQUEST_HW_RSC         0x0100100F
+#define PRM_CMD_RSP_REQUEST_HW_RSC     0x02001002
+#define PRM_CMD_RELEASE_HW_RSC         0x01001010
+#define PRM_CMD_RSP_RELEASE_HW_RSC     0x02001003
+#define PARAM_ID_RSC_HW_CORE           0x08001032
+#define PARAM_ID_RSC_LPASS_CORE                0x0800102B
+#define PARAM_ID_RSC_AUDIO_HW_CLK      0x0800102C
+
+struct prm_cmd_request_hw_core {
+       struct apm_module_param_data param_data;
+       uint32_t hw_clk_id;
+} __packed;
+
+struct prm_cmd_request_rsc {
+       struct apm_module_param_data param_data;
+       uint32_t num_clk_id;
+       struct audio_hw_clk_cfg clock_id;
+} __packed;
+
+static int q6prm_send_cmd_sync(struct q6prm *prm, struct gpr_pkt *pkt, uint32_t rsp_opcode)
+{
+       return audioreach_send_cmd_sync(prm->dev, prm->gdev, &prm->result, &prm->lock,
+                                       NULL, &prm->wait, pkt, rsp_opcode);
+}
+
+static int q6prm_set_hw_core_req(struct device *dev, uint32_t hw_block_id, bool enable)
+{
+       struct q6prm *prm = dev_get_drvdata(dev->parent);
+       struct apm_module_param_data *param_data;
+       struct prm_cmd_request_hw_core *req;
+       gpr_device_t *gdev = prm->gdev;
+       uint32_t opcode, rsp_opcode;
+       struct gpr_pkt *pkt;
+       int rc;
+
+       if (enable) {
+               opcode = PRM_CMD_REQUEST_HW_RSC;
+               rsp_opcode = PRM_CMD_RSP_REQUEST_HW_RSC;
+       } else {
+               opcode = PRM_CMD_RELEASE_HW_RSC;
+               rsp_opcode = PRM_CMD_RSP_RELEASE_HW_RSC;
+       }
+
+       pkt = audioreach_alloc_cmd_pkt(sizeof(*req), opcode, 0, gdev->svc.id, GPR_PRM_MODULE_IID);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       req = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = &req->param_data;
+
+       param_data->module_instance_id = GPR_PRM_MODULE_IID;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_RSC_HW_CORE;
+       param_data->param_size = sizeof(*req) - APM_MODULE_PARAM_DATA_SIZE;
+
+       req->hw_clk_id = hw_block_id;
+
+       rc = q6prm_send_cmd_sync(prm, pkt, rsp_opcode);
+
+       kfree(pkt);
+
+       return rc;
+}
+
+int q6prm_vote_lpass_core_hw(struct device *dev, uint32_t hw_block_id,
+                            const char *client_name, uint32_t *client_handle)
+{
+       return q6prm_set_hw_core_req(dev, hw_block_id, true);
+
+}
+EXPORT_SYMBOL_GPL(q6prm_vote_lpass_core_hw);
+
+int q6prm_unvote_lpass_core_hw(struct device *dev, uint32_t hw_block_id, uint32_t client_handle)
+{
+       return q6prm_set_hw_core_req(dev, hw_block_id, false);
+}
+EXPORT_SYMBOL_GPL(q6prm_unvote_lpass_core_hw);
+
+int q6prm_set_lpass_clock(struct device *dev, int clk_id, int clk_attr, int clk_root,
+                         unsigned int freq)
+{
+       struct q6prm *prm = dev_get_drvdata(dev->parent);
+       struct apm_module_param_data *param_data;
+       struct prm_cmd_request_rsc *req;
+       gpr_device_t *gdev = prm->gdev;
+       struct gpr_pkt *pkt;
+       int rc;
+
+       pkt = audioreach_alloc_cmd_pkt(sizeof(*req), PRM_CMD_REQUEST_HW_RSC, 0, gdev->svc.id,
+                                      GPR_PRM_MODULE_IID);
+       if (IS_ERR(pkt))
+               return PTR_ERR(pkt);
+
+       req = (void *)pkt + GPR_HDR_SIZE + APM_CMD_HDR_SIZE;
+
+       param_data = &req->param_data;
+
+       param_data->module_instance_id = GPR_PRM_MODULE_IID;
+       param_data->error_code = 0;
+       param_data->param_id = PARAM_ID_RSC_AUDIO_HW_CLK;
+       param_data->param_size = sizeof(*req) - APM_MODULE_PARAM_DATA_SIZE;
+
+       req->num_clk_id = 1;
+       req->clock_id.clock_id = clk_id;
+       req->clock_id.clock_freq = freq;
+       req->clock_id.clock_attri = clk_attr;
+       req->clock_id.clock_root = clk_root;
+
+       rc = q6prm_send_cmd_sync(prm, pkt, PRM_CMD_RSP_REQUEST_HW_RSC);
+
+       kfree(pkt);
+
+       return rc;
+}
+EXPORT_SYMBOL_GPL(q6prm_set_lpass_clock);
+
+static int prm_callback(struct gpr_resp_pkt *data, void *priv, int op)
+{
+       gpr_device_t *gdev = priv;
+       struct q6prm *prm = dev_get_drvdata(&gdev->dev);
+       struct gpr_ibasic_rsp_result_t *result;
+       struct gpr_hdr *hdr = &data->hdr;
+
+       switch (hdr->opcode) {
+       case PRM_CMD_RSP_REQUEST_HW_RSC:
+       case PRM_CMD_RSP_RELEASE_HW_RSC:
+               result = data->payload;
+               prm->result.opcode = hdr->opcode;
+               prm->result.status = result->status;
+               wake_up(&prm->wait);
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
+static int prm_probe(gpr_device_t *gdev)
+{
+       struct device *dev = &gdev->dev;
+       struct q6prm *cc;
+
+       cc = devm_kzalloc(dev, sizeof(*cc), GFP_KERNEL);
+       if (!cc)
+               return -ENOMEM;
+
+       cc->dev = dev;
+       cc->gdev = gdev;
+       mutex_init(&cc->lock);
+       init_waitqueue_head(&cc->wait);
+       dev_set_drvdata(dev, cc);
+
+       return devm_of_platform_populate(dev);
+}
+
+#ifdef CONFIG_OF
+static const struct of_device_id prm_device_id[]  = {
+       { .compatible = "qcom,q6prm" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, prm_device_id);
+#endif
+
+static gpr_driver_t prm_driver = {
+       .probe = prm_probe,
+       .gpr_callback = prm_callback,
+       .driver = {
+               .name = "qcom-prm",
+               .of_match_table = of_match_ptr(prm_device_id),
+       },
+};
+
+module_gpr_driver(prm_driver);
+MODULE_DESCRIPTION("Audio Process Manager");
+MODULE_LICENSE("GPL");
diff --git a/sound/soc/qcom/qdsp6/q6prm.h b/sound/soc/qcom/qdsp6/q6prm.h
new file mode 100644 (file)
index 0000000..fea4d19
--- /dev/null
@@ -0,0 +1,78 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+
+#ifndef __Q6PRM_H__
+#define __Q6PRM_H__
+
+/* Clock ID for Primary I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_PRI_MI2S_IBIT                          0x100
+/* Clock ID for Primary I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_PRI_MI2S_EBIT                          0x101
+/* Clock ID for Secondary I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_SEC_MI2S_IBIT                          0x102
+/* Clock ID for Secondary I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_SEC_MI2S_EBIT                          0x103
+/* Clock ID for Tertiary I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_TER_MI2S_IBIT                          0x104
+/* Clock ID for Tertiary I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_TER_MI2S_EBIT                          0x105
+/* Clock ID for Quartnery I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_QUAD_MI2S_IBIT                         0x106
+/* Clock ID for Quartnery I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_QUAD_MI2S_EBIT                         0x107
+/* Clock ID for Speaker I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_SPEAKER_I2S_IBIT                       0x108
+/* Clock ID for Speaker I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_SPEAKER_I2S_EBIT                       0x109
+/* Clock ID for Speaker I2S OSR */
+#define Q6PRM_LPASS_CLK_ID_SPEAKER_I2S_OSR                        0x10A
+
+/* Clock ID for QUINARY  I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_QUI_MI2S_IBIT                       0x10B
+/* Clock ID for QUINARY  I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_QUI_MI2S_EBIT                       0x10C
+/* Clock ID for SENARY  I2S IBIT */
+#define Q6PRM_LPASS_CLK_ID_SEN_MI2S_IBIT                       0x10D
+/* Clock ID for SENARY  I2S EBIT */
+#define Q6PRM_LPASS_CLK_ID_SEN_MI2S_EBIT                       0x10E
+/* Clock ID for INT0 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT0_MI2S_IBIT                       0x10F
+/* Clock ID for INT1 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT1_MI2S_IBIT                       0x110
+/* Clock ID for INT2 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT2_MI2S_IBIT                       0x111
+/* Clock ID for INT3 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT3_MI2S_IBIT                       0x112
+/* Clock ID for INT4 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT4_MI2S_IBIT                       0x113
+/* Clock ID for INT5 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT5_MI2S_IBIT                       0x114
+/* Clock ID for INT6 I2S IBIT  */
+#define Q6PRM_LPASS_CLK_ID_INT6_MI2S_IBIT                       0x115
+
+/* Clock ID for QUINARY MI2S OSR CLK  */
+#define Q6PRM_LPASS_CLK_ID_QUI_MI2S_OSR                         0x116
+
+#define Q6PRM_LPASS_CLK_ID_WSA_CORE_MCLK                       0x305
+#define Q6PRM_LPASS_CLK_ID_WSA_CORE_NPL_MCLK                   0x306
+
+#define Q6PRM_LPASS_CLK_ID_VA_CORE_MCLK                                0x307
+#define Q6PRM_LPASS_CLK_ID_VA_CORE_2X_MCLK                     0x308
+
+#define Q6PRM_LPASS_CLK_ID_TX_CORE_MCLK                                0x30c
+#define Q6PRM_LPASS_CLK_ID_TX_CORE_NPL_MCLK                    0x30d
+
+#define Q6PRM_LPASS_CLK_ID_RX_CORE_MCLK                                0x30e
+#define Q6PRM_LPASS_CLK_ID_RX_CORE_NPL_MCLK                    0x30f
+
+#define Q6PRM_LPASS_CLK_SRC_INTERNAL   1
+#define Q6PRM_LPASS_CLK_ROOT_DEFAULT   0
+#define Q6PRM_HW_CORE_ID_LPASS         1
+#define Q6PRM_HW_CORE_ID_DCODEC                2
+
+int q6prm_set_lpass_clock(struct device *dev, int clk_id, int clk_attr,
+                         int clk_root, unsigned int freq);
+int q6prm_vote_lpass_core_hw(struct device *dev, uint32_t hw_block_id,
+                            const char *client_name, uint32_t *client_handle);
+int q6prm_unvote_lpass_core_hw(struct device *dev, uint32_t hw_block_id,
+                              uint32_t client_handle);
+#endif /* __Q6PRM_H__ */
diff --git a/sound/soc/qcom/qdsp6/topology.c b/sound/soc/qcom/qdsp6/topology.c
new file mode 100644 (file)
index 0000000..bd649c2
--- /dev/null
@@ -0,0 +1,1113 @@
+// SPDX-License-Identifier: GPL-2.0
+// Copyright (c) 2020, Linaro Limited
+
+#include <sound/soc.h>
+#include <sound/soc-dapm.h>
+#include <sound/pcm.h>
+#include <sound/control.h>
+#include <sound/asound.h>
+#include <linux/firmware.h>
+#include <sound/soc-topology.h>
+#include <sound/soc-dpcm.h>
+#include <uapi/sound/snd_ar_tokens.h>
+#include <linux/kernel.h>
+#include <linux/wait.h>
+#include "q6apm.h"
+#include "audioreach.h"
+
+struct snd_ar_control {
+       u32 sgid; /* Sub Graph ID */
+       struct snd_soc_component *scomp;
+};
+
+static struct audioreach_graph_info *audioreach_tplg_alloc_graph_info(struct q6apm *apm,
+                                                                     uint32_t graph_id,
+                                                                     bool *found)
+{
+       struct audioreach_graph_info *info;
+       int ret;
+
+       mutex_lock(&apm->lock);
+       info = idr_find(&apm->graph_info_idr, graph_id);
+       mutex_unlock(&apm->lock);
+
+       if (info) {
+               *found = true;
+               return info;
+       }
+
+       *found = false;
+       info = kzalloc(sizeof(*info), GFP_KERNEL);
+       if (!info)
+               return ERR_PTR(-ENOMEM);
+
+       INIT_LIST_HEAD(&info->sg_list);
+
+       mutex_lock(&apm->lock);
+       ret = idr_alloc(&apm->graph_info_idr, info, graph_id, graph_id + 1, GFP_KERNEL);
+       mutex_unlock(&apm->lock);
+
+       if (ret < 0) {
+               dev_err(apm->dev, "Failed to allocate Graph ID (%x)\n", graph_id);
+               kfree(info);
+               return ERR_PTR(ret);
+       }
+
+       info->id = ret;
+
+       return info;
+}
+
+static void audioreach_tplg_add_sub_graph(struct audioreach_sub_graph *sg,
+                                         struct audioreach_graph_info *info)
+{
+       list_add_tail(&sg->node, &info->sg_list);
+       sg->info = info;
+       info->num_sub_graphs++;
+}
+
+static struct audioreach_sub_graph *audioreach_tplg_alloc_sub_graph(struct q6apm *apm,
+                                                                   uint32_t sub_graph_id,
+                                                                   bool *found)
+{
+       struct audioreach_sub_graph *sg;
+       int ret;
+
+       if (!sub_graph_id)
+               return ERR_PTR(-EINVAL);
+
+       /* Find if there is already a matching sub-graph */
+       mutex_lock(&apm->lock);
+       sg = idr_find(&apm->sub_graphs_idr, sub_graph_id);
+       mutex_unlock(&apm->lock);
+
+       if (sg) {
+               *found = true;
+               return sg;
+       }
+
+       *found = false;
+       sg = kzalloc(sizeof(*sg), GFP_KERNEL);
+       if (!sg)
+               return ERR_PTR(-ENOMEM);
+
+       INIT_LIST_HEAD(&sg->container_list);
+
+       mutex_lock(&apm->lock);
+       ret = idr_alloc(&apm->sub_graphs_idr, sg, sub_graph_id, sub_graph_id + 1, GFP_KERNEL);
+       mutex_unlock(&apm->lock);
+
+       if (ret < 0) {
+               dev_err(apm->dev, "Failed to allocate Sub-Graph Instance ID (%x)\n", sub_graph_id);
+               kfree(sg);
+               return ERR_PTR(ret);
+       }
+
+       sg->sub_graph_id = ret;
+
+       return sg;
+}
+
+static struct audioreach_container *audioreach_tplg_alloc_container(struct q6apm *apm,
+                                                           struct audioreach_sub_graph *sg,
+                                                           uint32_t container_id,
+                                                           bool *found)
+{
+       struct audioreach_container *cont;
+       int ret;
+
+       if (!container_id)
+               return ERR_PTR(-EINVAL);
+
+       mutex_lock(&apm->lock);
+       cont = idr_find(&apm->containers_idr, container_id);
+       mutex_unlock(&apm->lock);
+
+       if (cont) {
+               *found = true;
+               return cont;
+       }
+       *found = false;
+
+       cont = kzalloc(sizeof(*cont), GFP_KERNEL);
+       if (!cont)
+               return ERR_PTR(-ENOMEM);
+
+       INIT_LIST_HEAD(&cont->modules_list);
+
+       mutex_lock(&apm->lock);
+       ret = idr_alloc(&apm->containers_idr, cont, container_id, container_id + 1, GFP_KERNEL);
+       mutex_unlock(&apm->lock);
+
+       if (ret < 0) {
+               dev_err(apm->dev, "Failed to allocate Container Instance ID (%x)\n", container_id);
+               kfree(cont);
+               return ERR_PTR(ret);
+       }
+
+       cont->container_id = ret;
+       cont->sub_graph = sg;
+       /* add to container list */
+       list_add_tail(&cont->node, &sg->container_list);
+       sg->num_containers++;
+
+       return cont;
+}
+
+static struct audioreach_module *audioreach_tplg_alloc_module(struct q6apm *apm,
+                                                             struct audioreach_container *cont,
+                                                             struct snd_soc_dapm_widget *w,
+                                                             uint32_t module_id, bool *found)
+{
+       struct audioreach_module *mod;
+       int ret;
+
+       mutex_lock(&apm->lock);
+       mod = idr_find(&apm->modules_idr, module_id);
+       mutex_unlock(&apm->lock);
+
+       if (mod) {
+               *found = true;
+               return mod;
+       }
+       *found = false;
+       mod = kzalloc(sizeof(*mod), GFP_KERNEL);
+       if (!mod)
+               return ERR_PTR(-ENOMEM);
+
+       mutex_lock(&apm->lock);
+       if (!module_id) { /* alloc module id dynamically */
+               ret = idr_alloc_cyclic(&apm->modules_idr, mod,
+                                      AR_MODULE_DYNAMIC_INSTANCE_ID_START,
+                                      AR_MODULE_DYNAMIC_INSTANCE_ID_END, GFP_KERNEL);
+       } else {
+               ret = idr_alloc(&apm->modules_idr, mod, module_id, module_id + 1, GFP_KERNEL);
+       }
+       mutex_unlock(&apm->lock);
+
+       if (ret < 0) {
+               dev_err(apm->dev, "Failed to allocate Module Instance ID (%x)\n", module_id);
+               kfree(mod);
+               return ERR_PTR(ret);
+       }
+
+       mod->instance_id = ret;
+       /* add to module list */
+       list_add_tail(&mod->node, &cont->modules_list);
+       mod->container = cont;
+       mod->widget = w;
+       cont->num_modules++;
+
+       return mod;
+}
+
+static struct snd_soc_tplg_vendor_array *audioreach_get_sg_array(
+                                                       struct snd_soc_tplg_private *private)
+{
+       struct snd_soc_tplg_vendor_array *sg_array = NULL;
+       bool found = false;
+       int sz;
+
+       for (sz = 0; !found && (sz < le32_to_cpu(private->size)); ) {
+               struct snd_soc_tplg_vendor_value_elem *sg_elem;
+               int tkn_count = 0;
+
+               sg_array = (struct snd_soc_tplg_vendor_array *)((u8 *)private->array + sz);
+               sg_elem = sg_array->value;
+               sz = sz + le32_to_cpu(sg_array->size);
+               while (!found && tkn_count <= (le32_to_cpu(sg_array->num_elems) - 1)) {
+                       switch (le32_to_cpu(sg_elem->token)) {
+                       case AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:
+                               found = true;
+                               break;
+                       default:
+                               break;
+                       }
+                       tkn_count++;
+                       sg_elem++;
+               }
+       }
+
+       if (found)
+               return sg_array;
+
+       return NULL;
+}
+
+static struct snd_soc_tplg_vendor_array *audioreach_get_cont_array(
+                                                       struct snd_soc_tplg_private *private)
+{
+       struct snd_soc_tplg_vendor_array *cont_array = NULL;
+       bool found = false;
+       int sz;
+
+       for (sz = 0; !found && (sz < le32_to_cpu(private->size)); ) {
+               struct snd_soc_tplg_vendor_value_elem *cont_elem;
+               int tkn_count = 0;
+
+               cont_array = (struct snd_soc_tplg_vendor_array *)((u8 *)private->array + sz);
+               cont_elem = cont_array->value;
+               sz = sz + le32_to_cpu(cont_array->size);
+               while (!found && tkn_count <= (le32_to_cpu(cont_array->num_elems) - 1)) {
+                       switch (le32_to_cpu(cont_elem->token)) {
+                       case AR_TKN_U32_CONTAINER_INSTANCE_ID:
+                               found = true;
+                               break;
+                       default:
+                               break;
+                       }
+                       tkn_count++;
+                       cont_elem++;
+               }
+       }
+
+       if (found)
+               return cont_array;
+
+       return NULL;
+}
+
+static struct snd_soc_tplg_vendor_array *audioreach_get_module_array(
+                                                            struct snd_soc_tplg_private *private)
+{
+       struct snd_soc_tplg_vendor_array *mod_array = NULL;
+       bool found = false;
+       int sz = 0;
+
+       for (sz = 0; !found && (sz < le32_to_cpu(private->size)); ) {
+               struct snd_soc_tplg_vendor_value_elem *mod_elem;
+               int tkn_count = 0;
+
+               mod_array = (struct snd_soc_tplg_vendor_array *)((u8 *)private->array + sz);
+               mod_elem = mod_array->value;
+               sz = sz + le32_to_cpu(mod_array->size);
+               while (!found && tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+                       switch (le32_to_cpu(mod_elem->token)) {
+                       case AR_TKN_U32_MODULE_INSTANCE_ID:
+                               found = true;
+                               break;
+                       default:
+                               break;
+                       }
+                       tkn_count++;
+                       mod_elem++;
+               }
+       }
+
+       if (found)
+               return mod_array;
+
+       return NULL;
+}
+
+static struct audioreach_sub_graph *audioreach_parse_sg_tokens(struct q6apm *apm,
+                                                      struct snd_soc_tplg_private *private)
+{
+       struct snd_soc_tplg_vendor_value_elem *sg_elem;
+       struct snd_soc_tplg_vendor_array *sg_array;
+       struct audioreach_graph_info *info = NULL;
+       int graph_id, sub_graph_id, tkn_count = 0;
+       struct audioreach_sub_graph *sg;
+       bool found;
+
+       sg_array = audioreach_get_sg_array(private);
+       sg_elem = sg_array->value;
+
+       while (tkn_count <= (le32_to_cpu(sg_array->num_elems) - 1)) {
+               switch (le32_to_cpu(sg_elem->token)) {
+               case AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:
+                       sub_graph_id = le32_to_cpu(sg_elem->value);
+                       sg = audioreach_tplg_alloc_sub_graph(apm, sub_graph_id, &found);
+                       if (IS_ERR(sg)) {
+                               return sg;
+                       } else if (found) {
+                               /* Already parsed data for this sub-graph */
+                               return sg;
+                       }
+                       break;
+               case AR_TKN_DAI_INDEX:
+                       /* Sub graph is associated with predefined graph */
+                       graph_id = le32_to_cpu(sg_elem->value);
+                       info = audioreach_tplg_alloc_graph_info(apm, graph_id, &found);
+                       if (IS_ERR(info))
+                               return ERR_CAST(info);
+                       break;
+               case AR_TKN_U32_SUB_GRAPH_PERF_MODE:
+                       sg->perf_mode = le32_to_cpu(sg_elem->value);
+                       break;
+               case AR_TKN_U32_SUB_GRAPH_DIRECTION:
+                       sg->direction = le32_to_cpu(sg_elem->value);
+                       break;
+               case AR_TKN_U32_SUB_GRAPH_SCENARIO_ID:
+                       sg->scenario_id = le32_to_cpu(sg_elem->value);
+                       break;
+               default:
+                       dev_err(apm->dev, "Not a valid token %d for graph\n", sg_elem->token);
+                       break;
+
+               }
+               tkn_count++;
+               sg_elem++;
+       }
+
+       /* Sub graph is associated with predefined graph */
+       if (info)
+               audioreach_tplg_add_sub_graph(sg, info);
+
+       return sg;
+}
+
+static struct audioreach_container *audioreach_parse_cont_tokens(struct q6apm *apm,
+                                                        struct audioreach_sub_graph *sg,
+                                                        struct snd_soc_tplg_private *private)
+{
+       struct snd_soc_tplg_vendor_value_elem *cont_elem;
+       struct snd_soc_tplg_vendor_array *cont_array;
+       struct audioreach_container *cont;
+       int container_id, tkn_count = 0;
+       bool found = false;
+
+       cont_array = audioreach_get_cont_array(private);
+       cont_elem = cont_array->value;
+
+       while (tkn_count <= (le32_to_cpu(cont_array->num_elems) - 1)) {
+               switch (le32_to_cpu(cont_elem->token)) {
+               case AR_TKN_U32_CONTAINER_INSTANCE_ID:
+                       container_id = le32_to_cpu(cont_elem->value);
+                       cont = audioreach_tplg_alloc_container(apm, sg, container_id, &found);
+                       if (IS_ERR(cont) || found)/* Error or Already parsed container data */
+                               return cont;
+                       break;
+               case AR_TKN_U32_CONTAINER_CAPABILITY_ID:
+                       cont->capability_id = le32_to_cpu(cont_elem->value);
+                       break;
+               case AR_TKN_U32_CONTAINER_STACK_SIZE:
+                       cont->stack_size = le32_to_cpu(cont_elem->value);
+                       break;
+               case AR_TKN_U32_CONTAINER_GRAPH_POS:
+                       cont->graph_pos = le32_to_cpu(cont_elem->value);
+                       break;
+               case AR_TKN_U32_CONTAINER_PROC_DOMAIN:
+                       cont->proc_domain = le32_to_cpu(cont_elem->value);
+                       break;
+               default:
+                       dev_err(apm->dev, "Not a valid token %d for graph\n", cont_elem->token);
+                       break;
+
+               }
+               tkn_count++;
+               cont_elem++;
+       }
+
+       return cont;
+}
+
+static struct audioreach_module *audioreach_parse_common_tokens(struct q6apm *apm,
+                                                       struct audioreach_container *cont,
+                                                       struct snd_soc_tplg_private *private,
+                                                       struct snd_soc_dapm_widget *w)
+{
+       uint32_t max_ip_port = 0, max_op_port = 0, in_port = 0, out_port = 0;
+       uint32_t src_mod_inst_id = 0, src_mod_op_port_id = 0;
+       uint32_t dst_mod_inst_id = 0, dst_mod_ip_port_id = 0;
+       int module_id = 0, instance_id = 0, tkn_count = 0;
+       struct snd_soc_tplg_vendor_value_elem *mod_elem;
+       struct snd_soc_tplg_vendor_array *mod_array;
+       struct audioreach_module *mod = NULL;
+       bool found;
+
+       mod_array = audioreach_get_module_array(private);
+       mod_elem = mod_array->value;
+
+       while (tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+               switch (le32_to_cpu(mod_elem->token)) {
+               /* common module info */
+               case AR_TKN_U32_MODULE_ID:
+                       module_id = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_INSTANCE_ID:
+                       instance_id = le32_to_cpu(mod_elem->value);
+                       mod = audioreach_tplg_alloc_module(apm, cont, w,
+                                                          instance_id, &found);
+                       if (IS_ERR(mod)) {
+                               return mod;
+                       } else if (found) {
+                               dev_err(apm->dev, "Duplicate Module Instance ID 0x%08x found\n",
+                                       instance_id);
+                               return ERR_PTR(-EINVAL);
+                       }
+
+                       break;
+               case AR_TKN_U32_MODULE_MAX_IP_PORTS:
+                       max_ip_port = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_MAX_OP_PORTS:
+                       max_op_port = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_IN_PORTS:
+                       in_port = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_OUT_PORTS:
+                       out_port = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_SRC_OP_PORT_ID:
+                       src_mod_op_port_id = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_SRC_INSTANCE_ID:
+                       src_mod_inst_id = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_DST_INSTANCE_ID:
+                       dst_mod_inst_id = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_DST_IN_PORT_ID:
+                       dst_mod_ip_port_id = le32_to_cpu(mod_elem->value);
+                       break;
+               default:
+                       break;
+
+               }
+               tkn_count++;
+               mod_elem++;
+       }
+
+       if (mod) {
+               mod->module_id = module_id;
+               mod->max_ip_port = max_ip_port;
+               mod->max_op_port = max_op_port;
+               mod->in_port = in_port;
+               mod->out_port = out_port;
+               mod->src_mod_inst_id = src_mod_inst_id;
+               mod->src_mod_op_port_id = src_mod_op_port_id;
+               mod->dst_mod_inst_id = dst_mod_inst_id;
+               mod->dst_mod_ip_port_id = dst_mod_ip_port_id;
+       }
+
+       return mod;
+}
+
+static int audioreach_widget_load_module_common(struct snd_soc_component *component,
+                                               int index, struct snd_soc_dapm_widget *w,
+                                               struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       struct q6apm *apm = dev_get_drvdata(component->dev);
+       struct audioreach_container *cont;
+       struct audioreach_sub_graph *sg;
+       struct audioreach_module *mod;
+       struct snd_soc_dobj *dobj;
+
+       sg = audioreach_parse_sg_tokens(apm, &tplg_w->priv);
+       if (IS_ERR(sg))
+               return PTR_ERR(sg);
+
+       cont = audioreach_parse_cont_tokens(apm, sg, &tplg_w->priv);
+       if (IS_ERR(cont))
+               return PTR_ERR(cont);
+
+       mod = audioreach_parse_common_tokens(apm, cont, &tplg_w->priv, w);
+       if (IS_ERR(mod))
+               return PTR_ERR(mod);
+
+       dobj = &w->dobj;
+       dobj->private = mod;
+
+       return 0;
+}
+
+static int audioreach_widget_load_enc_dec_cnv(struct snd_soc_component *component,
+                                             int index, struct snd_soc_dapm_widget *w,
+                                             struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       struct snd_soc_tplg_vendor_value_elem *mod_elem;
+       struct snd_soc_tplg_vendor_array *mod_array;
+       struct audioreach_module *mod;
+       struct snd_soc_dobj *dobj;
+       int tkn_count = 0;
+       int ret;
+
+       ret = audioreach_widget_load_module_common(component, index, w, tplg_w);
+       if (ret)
+               return ret;
+
+       dobj = &w->dobj;
+       mod = dobj->private;
+       mod_array = audioreach_get_module_array(&tplg_w->priv);
+       mod_elem = mod_array->value;
+
+       while (tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+               switch (le32_to_cpu(mod_elem->token)) {
+               case AR_TKN_U32_MODULE_FMT_INTERLEAVE:
+                       mod->interleave_type = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_FMT_SAMPLE_RATE:
+                       mod->rate = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_FMT_BIT_DEPTH:
+                       mod->bit_depth = le32_to_cpu(mod_elem->value);
+                       break;
+               default:
+                       break;
+               }
+               tkn_count++;
+               mod_elem++;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_log_module_load(struct audioreach_module *mod,
+                                            struct snd_soc_tplg_vendor_array *mod_array)
+{
+       struct snd_soc_tplg_vendor_value_elem *mod_elem;
+       int tkn_count = 0;
+
+       mod_elem = mod_array->value;
+
+       while (tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+               switch (le32_to_cpu(mod_elem->token)) {
+
+               case AR_TKN_U32_MODULE_LOG_CODE:
+                       mod->log_code = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_LOG_TAP_POINT_ID:
+                       mod->log_tap_point_id = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_LOG_MODE:
+                       mod->log_mode = le32_to_cpu(mod_elem->value);
+                       break;
+               default:
+                       break;
+               }
+               tkn_count++;
+               mod_elem++;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_dma_module_load(struct audioreach_module *mod,
+                                            struct snd_soc_tplg_vendor_array *mod_array)
+{
+       struct snd_soc_tplg_vendor_value_elem *mod_elem;
+       int tkn_count = 0;
+
+       mod_elem = mod_array->value;
+
+       while (tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+               switch (le32_to_cpu(mod_elem->token)) {
+               case AR_TKN_U32_MODULE_HW_IF_IDX:
+                       mod->hw_interface_idx = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_FMT_DATA:
+                       mod->data_format = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_HW_IF_TYPE:
+                       mod->hw_interface_type = le32_to_cpu(mod_elem->value);
+                       break;
+               default:
+                       break;
+               }
+               tkn_count++;
+               mod_elem++;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_i2s_module_load(struct audioreach_module *mod,
+                                            struct snd_soc_tplg_vendor_array *mod_array)
+{
+       struct snd_soc_tplg_vendor_value_elem *mod_elem;
+       int tkn_count = 0;
+
+       mod_elem = mod_array->value;
+
+       while (tkn_count <= (le32_to_cpu(mod_array->num_elems) - 1)) {
+               switch (le32_to_cpu(mod_elem->token)) {
+               case AR_TKN_U32_MODULE_HW_IF_IDX:
+                       mod->hw_interface_idx = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_FMT_DATA:
+                       mod->data_format = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_HW_IF_TYPE:
+                       mod->hw_interface_type = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_SD_LINE_IDX:
+                       mod->sd_line_idx = le32_to_cpu(mod_elem->value);
+                       break;
+               case AR_TKN_U32_MODULE_WS_SRC:
+                       mod->ws_src = le32_to_cpu(mod_elem->value);
+                       break;
+               default:
+                       break;
+               }
+               tkn_count++;
+               mod_elem++;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_load_buffer(struct snd_soc_component *component,
+                                        int index, struct snd_soc_dapm_widget *w,
+                                        struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       struct snd_soc_tplg_vendor_array *mod_array;
+       struct audioreach_module *mod;
+       struct snd_soc_dobj *dobj;
+       int ret;
+
+       ret = audioreach_widget_load_module_common(component, index, w, tplg_w);
+       if (ret)
+               return ret;
+
+       dobj = &w->dobj;
+       mod = dobj->private;
+
+       mod_array = audioreach_get_module_array(&tplg_w->priv);
+
+       switch (mod->module_id) {
+       case MODULE_ID_CODEC_DMA_SINK:
+       case MODULE_ID_CODEC_DMA_SOURCE:
+               audioreach_widget_dma_module_load(mod, mod_array);
+               break;
+       case MODULE_ID_DATA_LOGGING:
+               audioreach_widget_log_module_load(mod, mod_array);
+               break;
+       case MODULE_ID_I2S_SINK:
+       case MODULE_ID_I2S_SOURCE:
+               audioreach_widget_i2s_module_load(mod, mod_array);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_load_mixer(struct snd_soc_component *component,
+                                       int index, struct snd_soc_dapm_widget *w,
+                                       struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       struct snd_soc_tplg_vendor_value_elem *w_elem;
+       struct snd_soc_tplg_vendor_array *w_array;
+       struct snd_ar_control *scontrol;
+       struct snd_soc_dobj *dobj;
+       int tkn_count = 0;
+
+       w_array = &tplg_w->priv.array[0];
+
+       scontrol = kzalloc(sizeof(*scontrol), GFP_KERNEL);
+       if (!scontrol)
+               return -ENOMEM;
+
+       scontrol->scomp = component;
+       dobj = &w->dobj;
+       dobj->private = scontrol;
+
+       w_elem = w_array->value;
+       while (tkn_count <= (le32_to_cpu(w_array->num_elems) - 1)) {
+               switch (le32_to_cpu(w_elem->token)) {
+               case AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:
+                       scontrol->sgid = le32_to_cpu(w_elem->value);
+                       break;
+               default: /* ignore other tokens */
+                       break;
+               }
+               tkn_count++;
+               w_elem++;
+       }
+
+       return 0;
+}
+
+static int audioreach_pga_event(struct snd_soc_dapm_widget *w,
+                               struct snd_kcontrol *kcontrol, int event)
+
+{
+       struct snd_soc_dapm_context *dapm = w->dapm;
+       struct snd_soc_component *c = snd_soc_dapm_to_component(dapm);
+       struct audioreach_module *mod = w->dobj.private;
+       struct q6apm *apm = dev_get_drvdata(c->dev);
+
+       switch (event) {
+       case SND_SOC_DAPM_POST_PMU:
+               /* apply gain after power up of widget */
+               audioreach_gain_set_vol_ctrl(apm, mod, mod->gain);
+               break;
+       default:
+               break;
+       }
+
+       return 0;
+}
+
+static const struct snd_soc_tplg_widget_events audioreach_widget_ops[] = {
+       { AR_PGA_DAPM_EVENT, audioreach_pga_event },
+};
+
+static int audioreach_widget_load_pga(struct snd_soc_component *component,
+                                     int index, struct snd_soc_dapm_widget *w,
+                                     struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       struct audioreach_module *mod;
+       struct snd_soc_dobj *dobj;
+       int ret;
+
+       ret = audioreach_widget_load_module_common(component, index, w, tplg_w);
+       if (ret)
+               return ret;
+
+       dobj = &w->dobj;
+       mod = dobj->private;
+       mod->gain = VOL_CTRL_DEFAULT_GAIN;
+
+       ret = snd_soc_tplg_widget_bind_event(w, audioreach_widget_ops,
+                                            ARRAY_SIZE(audioreach_widget_ops),
+                                            le16_to_cpu(tplg_w->event_type));
+       if (ret) {
+               dev_err(component->dev, "matching event handlers NOT found for %d\n",
+                       le16_to_cpu(tplg_w->event_type));
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_ready(struct snd_soc_component *component,
+                                  int index, struct snd_soc_dapm_widget *w,
+                                  struct snd_soc_tplg_dapm_widget *tplg_w)
+{
+       switch (w->id) {
+       case snd_soc_dapm_aif_in:
+       case snd_soc_dapm_aif_out:
+               audioreach_widget_load_buffer(component, index, w, tplg_w);
+               break;
+       case snd_soc_dapm_decoder:
+       case snd_soc_dapm_encoder:
+       case snd_soc_dapm_src:
+               audioreach_widget_load_enc_dec_cnv(component, index, w, tplg_w);
+               break;
+       case snd_soc_dapm_buffer:
+               audioreach_widget_load_buffer(component, index, w, tplg_w);
+               break;
+       case snd_soc_dapm_mixer:
+               return audioreach_widget_load_mixer(component, index, w, tplg_w);
+       case snd_soc_dapm_pga:
+               return audioreach_widget_load_pga(component, index, w, tplg_w);
+       case snd_soc_dapm_dai_link:
+       case snd_soc_dapm_scheduler:
+       case snd_soc_dapm_out_drv:
+       default:
+               dev_err(component->dev, "Widget type (0x%x) not yet supported\n", w->id);
+               break;
+       }
+
+       return 0;
+}
+
+static int audioreach_widget_unload(struct snd_soc_component *scomp,
+                                   struct snd_soc_dobj *dobj)
+{
+       struct snd_soc_dapm_widget *w = container_of(dobj, struct snd_soc_dapm_widget, dobj);
+       struct q6apm *apm = dev_get_drvdata(scomp->dev);
+       struct audioreach_container *cont;
+       struct audioreach_module *mod;
+
+       mod = dobj->private;
+       cont = mod->container;
+
+       if (w->id == snd_soc_dapm_mixer) {
+               /* virtual widget */
+               kfree(dobj->private);
+               return 0;
+       }
+
+       mutex_lock(&apm->lock);
+       idr_remove(&apm->modules_idr, mod->instance_id);
+       cont->num_modules--;
+
+       list_del(&mod->node);
+       kfree(mod);
+       /* Graph Info has N sub-graphs, sub-graph has N containers, Container has N Modules */
+       if (list_empty(&cont->modules_list)) { /* if no modules in the container then remove it */
+               struct audioreach_sub_graph *sg = cont->sub_graph;
+
+               idr_remove(&apm->containers_idr, cont->container_id);
+               list_del(&cont->node);
+               sg->num_containers--;
+               kfree(cont);
+               /* check if there are no more containers in the sub graph and remove it */
+               if (list_empty(&sg->container_list)) {
+                       struct audioreach_graph_info *info = sg->info;
+
+                       idr_remove(&apm->sub_graphs_idr, sg->sub_graph_id);
+                       list_del(&sg->node);
+                       info->num_sub_graphs--;
+                       kfree(sg);
+                       /* Check if there are no more sub-graphs left then remove graph info */
+                       if (list_empty(&info->sg_list)) {
+                               idr_remove(&apm->graph_info_idr, info->id);
+                               kfree(info);
+                       }
+               }
+       }
+
+       mutex_unlock(&apm->lock);
+
+       return 0;
+}
+
+static struct audioreach_module *audioreach_find_widget(struct snd_soc_component *comp,
+                                                       const char *name)
+{
+       struct q6apm *apm = dev_get_drvdata(comp->dev);
+       struct audioreach_module *module;
+       int id;
+
+       idr_for_each_entry(&apm->modules_idr, module, id) {
+               if (!strcmp(name, module->widget->name))
+                       return module;
+       }
+
+       return NULL;
+}
+
+static int audioreach_route_load(struct snd_soc_component *scomp, int index,
+                                struct snd_soc_dapm_route *route)
+{
+       struct audioreach_module *src, *sink;
+
+       src = audioreach_find_widget(scomp, route->source);
+       sink = audioreach_find_widget(scomp, route->sink);
+
+       if (src && sink) {
+               src->dst_mod_inst_id = sink->instance_id;
+               sink->src_mod_inst_id = src->instance_id;
+       }
+
+       return 0;
+}
+
+static int audioreach_route_unload(struct snd_soc_component *scomp,
+                                  struct snd_soc_dobj *dobj)
+{
+       return 0;
+}
+
+static int audioreach_tplg_complete(struct snd_soc_component *component)
+{
+       /* TBD */
+       return 0;
+}
+
+/* DAI link - used for any driver specific init */
+static int audioreach_link_load(struct snd_soc_component *component, int index,
+                               struct snd_soc_dai_link *link,
+                               struct snd_soc_tplg_link_config *cfg)
+{
+       link->nonatomic = true;
+       link->dynamic = true;
+       link->platforms->name = NULL;
+       link->platforms->of_node = of_get_compatible_child(component->dev->of_node,
+                                                          "qcom,q6apm-dais");
+       return 0;
+}
+
+static int audioreach_get_audio_mixer(struct snd_kcontrol *kcontrol,
+                                     struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kcontrol);
+       struct snd_soc_dapm_widget *dw = snd_soc_dapm_kcontrol_widget(kcontrol);
+       struct snd_soc_component *c = snd_soc_dapm_to_component(dapm);
+       struct snd_ar_control *dapm_scontrol = dw->dobj.private;
+       struct snd_ar_control *scontrol = mc->dobj.private;
+       struct q6apm *data = dev_get_drvdata(c->dev);
+       bool connected;
+
+       connected = q6apm_is_sub_graphs_connected(data, scontrol->sgid, dapm_scontrol->sgid);
+       if (connected)
+               ucontrol->value.integer.value[0] = 1;
+       else
+               ucontrol->value.integer.value[0] = 0;
+
+       return 0;
+}
+
+static int audioreach_put_audio_mixer(struct snd_kcontrol *kcontrol,
+                                     struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc = (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_dapm_context *dapm = snd_soc_dapm_kcontrol_dapm(kcontrol);
+       struct snd_soc_dapm_widget *dw = snd_soc_dapm_kcontrol_widget(kcontrol);
+       struct snd_soc_component *c = snd_soc_dapm_to_component(dapm);
+       struct snd_ar_control *dapm_scontrol = dw->dobj.private;
+       struct snd_ar_control *scontrol = mc->dobj.private;
+       struct q6apm *data = dev_get_drvdata(c->dev);
+
+       if (ucontrol->value.integer.value[0]) {
+               q6apm_connect_sub_graphs(data, scontrol->sgid, dapm_scontrol->sgid, true);
+               snd_soc_dapm_mixer_update_power(dapm, kcontrol, 1, NULL);
+       } else {
+               q6apm_connect_sub_graphs(data, scontrol->sgid, dapm_scontrol->sgid, false);
+               snd_soc_dapm_mixer_update_power(dapm, kcontrol, 0, NULL);
+       }
+       return 0;
+}
+
+static int audioreach_get_vol_ctrl_audio_mixer(struct snd_kcontrol *kcontrol,
+                                              struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dapm_widget *dw = snd_soc_dapm_kcontrol_widget(kcontrol);
+       struct audioreach_module *mod = dw->dobj.private;
+
+       ucontrol->value.integer.value[0] = mod->gain;
+
+       return 0;
+}
+
+static int audioreach_put_vol_ctrl_audio_mixer(struct snd_kcontrol *kcontrol,
+                                              struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dapm_widget *dw = snd_soc_dapm_kcontrol_widget(kcontrol);
+       struct audioreach_module *mod = dw->dobj.private;
+
+       mod->gain = ucontrol->value.integer.value[0];
+
+       return 1;
+}
+
+static int audioreach_control_load_mix(struct snd_soc_component *scomp,
+                                      struct snd_ar_control *scontrol,
+                                      struct snd_kcontrol_new *kc,
+                                      struct snd_soc_tplg_ctl_hdr *hdr)
+{
+       struct snd_soc_tplg_vendor_value_elem *c_elem;
+       struct snd_soc_tplg_vendor_array *c_array;
+       struct snd_soc_tplg_mixer_control *mc;
+       int tkn_count = 0;
+
+       mc = container_of(hdr, struct snd_soc_tplg_mixer_control, hdr);
+       c_array = (struct snd_soc_tplg_vendor_array *)mc->priv.data;
+
+       c_elem = c_array->value;
+
+       while (tkn_count <= (le32_to_cpu(c_array->num_elems) - 1)) {
+               switch (le32_to_cpu(c_elem->token)) {
+               case AR_TKN_U32_SUB_GRAPH_INSTANCE_ID:
+                       scontrol->sgid = le32_to_cpu(c_elem->value);
+                       break;
+               default:
+                       /* Ignore other tokens */
+                       break;
+               }
+               c_elem++;
+               tkn_count++;
+       }
+
+       return 0;
+}
+
+static int audioreach_control_load(struct snd_soc_component *scomp, int index,
+                                  struct snd_kcontrol_new *kc,
+                                  struct snd_soc_tplg_ctl_hdr *hdr)
+{
+       struct snd_ar_control *scontrol;
+       struct soc_mixer_control *sm;
+       struct snd_soc_dobj *dobj;
+       int ret = 0;
+
+       scontrol = kzalloc(sizeof(*scontrol), GFP_KERNEL);
+       if (!scontrol)
+               return -ENOMEM;
+
+       scontrol->scomp = scomp;
+
+       switch (le32_to_cpu(hdr->ops.get)) {
+       case SND_SOC_AR_TPLG_FE_BE_GRAPH_CTL_MIX:
+               sm = (struct soc_mixer_control *)kc->private_value;
+               dobj = &sm->dobj;
+               ret = audioreach_control_load_mix(scomp, scontrol, kc, hdr);
+               break;
+       case SND_SOC_AR_TPLG_VOL_CTL:
+               sm = (struct soc_mixer_control *)kc->private_value;
+               dobj = &sm->dobj;
+               break;
+       default:
+               dev_warn(scomp->dev, "control type not supported %d:%d:%d\n",
+                        hdr->ops.get, hdr->ops.put, hdr->ops.info);
+               kfree(scontrol);
+               return -EINVAL;
+       }
+
+       dobj->private = scontrol;
+       return ret;
+}
+
+static int audioreach_control_unload(struct snd_soc_component *scomp,
+                                    struct snd_soc_dobj *dobj)
+{
+       struct snd_ar_control *scontrol = dobj->private;
+
+       kfree(scontrol);
+
+       return 0;
+}
+
+static const struct snd_soc_tplg_kcontrol_ops audioreach_io_ops[] = {
+       {SND_SOC_AR_TPLG_FE_BE_GRAPH_CTL_MIX, audioreach_get_audio_mixer,
+               audioreach_put_audio_mixer, snd_soc_info_volsw},
+       {SND_SOC_AR_TPLG_VOL_CTL, audioreach_get_vol_ctrl_audio_mixer,
+               audioreach_put_vol_ctrl_audio_mixer, snd_soc_info_volsw},
+};
+
+static struct snd_soc_tplg_ops audioreach_tplg_ops  = {
+       .io_ops = audioreach_io_ops,
+       .io_ops_count = ARRAY_SIZE(audioreach_io_ops),
+
+       .control_load   = audioreach_control_load,
+       .control_unload = audioreach_control_unload,
+
+       .widget_ready = audioreach_widget_ready,
+       .widget_unload = audioreach_widget_unload,
+
+       .complete = audioreach_tplg_complete,
+       .link_load = audioreach_link_load,
+
+       .dapm_route_load        = audioreach_route_load,
+       .dapm_route_unload      = audioreach_route_unload,
+};
+
+int audioreach_tplg_init(struct snd_soc_component *component)
+{
+       struct snd_soc_card *card = component->card;
+       struct device *dev = component->dev;
+       const struct firmware *fw;
+       char *tplg_fw_name;
+       int ret;
+
+       /* Inline with Qualcomm UCM configs and linux-firmware path */
+       tplg_fw_name = kasprintf(GFP_KERNEL, "qcom/%s/%s-tplg.bin", card->driver_name, card->name);
+       if (!tplg_fw_name)
+               return -ENOMEM;
+
+       ret = request_firmware(&fw, tplg_fw_name, dev);
+       if (ret < 0) {
+               dev_err(dev, "tplg firmware loading %s failed %d \n", tplg_fw_name, ret);
+               goto err;
+       }
+
+       ret = snd_soc_tplg_component_load(component, &audioreach_tplg_ops, fw);
+       if (ret < 0) {
+               dev_err(dev, "tplg component load failed%d\n", ret);
+               ret = -EINVAL;
+       }
+
+       release_firmware(fw);
+err:
+       kfree(tplg_fw_name);
+
+       return ret;
+}
+EXPORT_SYMBOL_GPL(audioreach_tplg_init);
index fe8fd73..b2ca257 100644 (file)
@@ -8,6 +8,8 @@
 #include <sound/soc-dapm.h>
 #include <sound/pcm.h>
 #include <linux/soundwire/sdw.h>
+#include <sound/jack.h>
+#include <linux/input-event-codes.h>
 #include "qdsp6/q6afe.h"
 #include "common.h"
 
@@ -18,8 +20,66 @@ struct sm8250_snd_data {
        bool stream_prepared[AFE_PORT_MAX];
        struct snd_soc_card *card;
        struct sdw_stream_runtime *sruntime[AFE_PORT_MAX];
+       struct snd_soc_jack jack;
+       bool jack_setup;
 };
 
+static int sm8250_snd_init(struct snd_soc_pcm_runtime *rtd)
+{
+       struct sm8250_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
+       struct snd_soc_dai *cpu_dai = asoc_rtd_to_cpu(rtd, 0);
+       struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
+       struct snd_soc_card *card = rtd->card;
+       int rval, i;
+
+       if (!data->jack_setup) {
+               struct snd_jack *jack;
+
+               rval = snd_soc_card_jack_new(card, "Headset Jack",
+                                            SND_JACK_HEADSET | SND_JACK_LINEOUT |
+                                            SND_JACK_MECHANICAL |
+                                            SND_JACK_BTN_0 | SND_JACK_BTN_1 |
+                                            SND_JACK_BTN_2 | SND_JACK_BTN_3 |
+                                            SND_JACK_BTN_4 | SND_JACK_BTN_5,
+                                            &data->jack, NULL, 0);
+
+               if (rval < 0) {
+                       dev_err(card->dev, "Unable to add Headphone Jack\n");
+                       return rval;
+               }
+
+               jack = data->jack.jack;
+
+               snd_jack_set_key(jack, SND_JACK_BTN_0, KEY_MEDIA);
+               snd_jack_set_key(jack, SND_JACK_BTN_1, KEY_VOICECOMMAND);
+               snd_jack_set_key(jack, SND_JACK_BTN_2, KEY_VOLUMEUP);
+               snd_jack_set_key(jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);
+               data->jack_setup = true;
+       }
+
+       switch (cpu_dai->id) {
+       case TX_CODEC_DMA_TX_0:
+       case TX_CODEC_DMA_TX_1:
+       case TX_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_3:
+               for_each_rtd_codec_dais(rtd, i, codec_dai) {
+                       rval = snd_soc_component_set_jack(codec_dai->component,
+                                                         &data->jack, NULL);
+                       if (rval != 0 && rval != -ENOTSUPP) {
+                               dev_warn(card->dev, "Failed to set jack: %d\n", rval);
+                               return rval;
+                       }
+               }
+
+               break;
+       default:
+               break;
+       }
+
+
+       return 0;
+}
+
 static int sm8250_be_hw_params_fixup(struct snd_soc_pcm_runtime *rtd,
                                     struct snd_pcm_hw_params *params)
 {
@@ -69,6 +129,12 @@ static int sm8250_snd_hw_params(struct snd_pcm_substream *substream,
 
        switch (cpu_dai->id) {
        case WSA_CODEC_DMA_RX_0:
+       case RX_CODEC_DMA_RX_0:
+       case RX_CODEC_DMA_RX_1:
+       case TX_CODEC_DMA_TX_0:
+       case TX_CODEC_DMA_TX_1:
+       case TX_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_3:
                for_each_rtd_codec_dais(rtd, i, codec_dai) {
                        sruntime = snd_soc_dai_get_sdw_stream(codec_dai,
                                                      substream->stream);
@@ -129,6 +195,12 @@ static int sm8250_snd_prepare(struct snd_pcm_substream *substream)
        switch (cpu_dai->id) {
        case WSA_CODEC_DMA_RX_0:
        case WSA_CODEC_DMA_RX_1:
+       case RX_CODEC_DMA_RX_0:
+       case RX_CODEC_DMA_RX_1:
+       case TX_CODEC_DMA_TX_0:
+       case TX_CODEC_DMA_TX_1:
+       case TX_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_3:
                return sm8250_snd_wsa_dma_prepare(substream);
        default:
                break;
@@ -147,6 +219,12 @@ static int sm8250_snd_hw_free(struct snd_pcm_substream *substream)
        switch (cpu_dai->id) {
        case WSA_CODEC_DMA_RX_0:
        case WSA_CODEC_DMA_RX_1:
+       case RX_CODEC_DMA_RX_0:
+       case RX_CODEC_DMA_RX_1:
+       case TX_CODEC_DMA_TX_0:
+       case TX_CODEC_DMA_TX_1:
+       case TX_CODEC_DMA_TX_2:
+       case TX_CODEC_DMA_TX_3:
                if (sruntime && data->stream_prepared[cpu_dai->id]) {
                        sdw_disable_stream(sruntime);
                        sdw_deprepare_stream(sruntime);
@@ -174,6 +252,7 @@ static void sm8250_add_be_ops(struct snd_soc_card *card)
 
        for_each_card_prelinks(card, i, link) {
                if (link->no_pcm == 1) {
+                       link->init = sm8250_snd_init;
                        link->be_hw_params_fixup = sm8250_be_hw_params_fixup;
                        link->ops = &sm8250_be_ops;
                }
index 053097b..42f76bc 100644 (file)
@@ -16,6 +16,17 @@ config SND_SOC_ROCKCHIP_I2S
          Rockchip I2S device. The device supports upto maximum of
          8 channels each for play and record.
 
+config SND_SOC_ROCKCHIP_I2S_TDM
+       tristate "Rockchip I2S/TDM Device Driver"
+       depends on HAVE_CLK && SND_SOC_ROCKCHIP
+       select SND_SOC_GENERIC_DMAENGINE_PCM
+       help
+         Say Y or M if you want to add support for the I2S/TDM driver for
+         Rockchip I2S/TDM devices, found in Rockchip SoCs. These devices
+         interface between the AHB bus and the I2S bus, and support up to a
+         maximum of 8 channels each for playback and recording.
+
+
 config SND_SOC_ROCKCHIP_PDM
        tristate "Rockchip PDM Controller Driver"
        depends on HAVE_CLK && SND_SOC_ROCKCHIP
index 65e814d..30c57c0 100644 (file)
@@ -1,13 +1,14 @@
 # SPDX-License-Identifier: GPL-2.0
 # ROCKCHIP Platform Support
 snd-soc-rockchip-i2s-objs := rockchip_i2s.o
-snd-soc-rockchip-pcm-objs := rockchip_pcm.o
+snd-soc-rockchip-i2s-tdm-objs := rockchip_i2s_tdm.o
 snd-soc-rockchip-pdm-objs := rockchip_pdm.o
 snd-soc-rockchip-spdif-objs := rockchip_spdif.o
 
-obj-$(CONFIG_SND_SOC_ROCKCHIP_I2S) += snd-soc-rockchip-i2s.o snd-soc-rockchip-pcm.o
+obj-$(CONFIG_SND_SOC_ROCKCHIP_I2S) += snd-soc-rockchip-i2s.o
 obj-$(CONFIG_SND_SOC_ROCKCHIP_PDM) += snd-soc-rockchip-pdm.o
 obj-$(CONFIG_SND_SOC_ROCKCHIP_SPDIF) += snd-soc-rockchip-spdif.o
+obj-$(CONFIG_SND_SOC_ROCKCHIP_I2S_TDM) += snd-soc-rockchip-i2s-tdm.o
 
 snd-soc-rockchip-max98090-objs := rockchip_max98090.o
 snd-soc-rockchip-rt5645-objs := rockchip_rt5645.o
index 7e89f5b..a6d7656 100644 (file)
@@ -20,7 +20,6 @@
 #include <sound/dmaengine_pcm.h>
 
 #include "rockchip_i2s.h"
-#include "rockchip_pcm.h"
 
 #define DRV_NAME "rockchip-i2s"
 
@@ -756,7 +755,7 @@ static int rockchip_i2s_probe(struct platform_device *pdev)
                goto err_suspend;
        }
 
-       ret = rockchip_pcm_platform_register(&pdev->dev);
+       ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
        if (ret) {
                dev_err(&pdev->dev, "Could not register PCM\n");
                goto err_suspend;
diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c
new file mode 100644 (file)
index 0000000..17b9b28
--- /dev/null
@@ -0,0 +1,1762 @@
+// SPDX-License-Identifier: GPL-2.0-only
+// ALSA SoC Audio Layer - Rockchip I2S/TDM Controller driver
+
+// Copyright (c) 2018 Rockchip Electronics Co. Ltd.
+// Author: Sugar Zhang <sugar.zhang@rock-chips.com>
+// Author: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
+
+#include <linux/clk.h>
+#include <linux/clk-provider.h>
+#include <linux/delay.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of_address.h>
+#include <linux/of_device.h>
+#include <linux/of_gpio.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <linux/reset.h>
+#include <linux/spinlock.h>
+#include <sound/dmaengine_pcm.h>
+#include <sound/pcm_params.h>
+
+#include "rockchip_i2s_tdm.h"
+
+#define DRV_NAME "rockchip-i2s-tdm"
+
+#define DEFAULT_MCLK_FS                                256
+#define CH_GRP_MAX                             4  /* The max channel 8 / 2 */
+#define MULTIPLEX_CH_MAX                       10
+#define CLK_PPM_MIN                            -1000
+#define CLK_PPM_MAX                            1000
+
+#define TRCM_TXRX 0
+#define TRCM_TX 1
+#define TRCM_RX 2
+
+struct txrx_config {
+       u32 addr;
+       u32 reg;
+       u32 txonly;
+       u32 rxonly;
+};
+
+struct rk_i2s_soc_data {
+       u32 softrst_offset;
+       u32 grf_reg_offset;
+       u32 grf_shift;
+       int config_count;
+       const struct txrx_config *configs;
+       int (*init)(struct device *dev, u32 addr);
+};
+
+struct rk_i2s_tdm_dev {
+       struct device *dev;
+       struct clk *hclk;
+       struct clk *mclk_tx;
+       struct clk *mclk_rx;
+       /* The mclk_tx_src is parent of mclk_tx */
+       struct clk *mclk_tx_src;
+       /* The mclk_rx_src is parent of mclk_rx */
+       struct clk *mclk_rx_src;
+       /*
+        * The mclk_root0 and mclk_root1 are root parent and supplies for
+        * the different FS.
+        *
+        * e.g:
+        * mclk_root0 is VPLL0, used for FS=48000Hz
+        * mclk_root1 is VPLL1, used for FS=44100Hz
+        */
+       struct clk *mclk_root0;
+       struct clk *mclk_root1;
+       struct regmap *regmap;
+       struct regmap *grf;
+       struct snd_dmaengine_dai_dma_data capture_dma_data;
+       struct snd_dmaengine_dai_dma_data playback_dma_data;
+       struct reset_control *tx_reset;
+       struct reset_control *rx_reset;
+       struct rk_i2s_soc_data *soc_data;
+       bool is_master_mode;
+       bool io_multiplex;
+       bool mclk_calibrate;
+       bool tdm_mode;
+       unsigned int mclk_rx_freq;
+       unsigned int mclk_tx_freq;
+       unsigned int mclk_root0_freq;
+       unsigned int mclk_root1_freq;
+       unsigned int mclk_root0_initial_freq;
+       unsigned int mclk_root1_initial_freq;
+       unsigned int frame_width;
+       unsigned int clk_trcm;
+       unsigned int i2s_sdis[CH_GRP_MAX];
+       unsigned int i2s_sdos[CH_GRP_MAX];
+       int clk_ppm;
+       int refcount;
+       spinlock_t lock; /* xfer lock */
+       bool has_playback;
+       bool has_capture;
+};
+
+static int to_ch_num(unsigned int val)
+{
+       switch (val) {
+       case I2S_CHN_4:
+               return 4;
+       case I2S_CHN_6:
+               return 6;
+       case I2S_CHN_8:
+               return 8;
+       default:
+               return 2;
+       }
+}
+
+static void i2s_tdm_disable_unprepare_mclk(struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       clk_disable_unprepare(i2s_tdm->mclk_tx);
+       clk_disable_unprepare(i2s_tdm->mclk_rx);
+       if (i2s_tdm->mclk_calibrate) {
+               clk_disable_unprepare(i2s_tdm->mclk_tx_src);
+               clk_disable_unprepare(i2s_tdm->mclk_rx_src);
+               clk_disable_unprepare(i2s_tdm->mclk_root0);
+               clk_disable_unprepare(i2s_tdm->mclk_root1);
+       }
+}
+
+/**
+ * i2s_tdm_prepare_enable_mclk - prepare to enable all mclks, disable them on
+ *                              failure.
+ * @i2s_tdm: rk_i2s_tdm_dev struct
+ *
+ * This function attempts to enable all mclk clocks, but cleans up after
+ * itself on failure. Guarantees to balance its calls.
+ *
+ * Returns success (0) or negative errno.
+ */
+static int i2s_tdm_prepare_enable_mclk(struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       int ret = 0;
+
+       ret = clk_prepare_enable(i2s_tdm->mclk_tx);
+       if (ret)
+               goto err_mclk_tx;
+       ret = clk_prepare_enable(i2s_tdm->mclk_rx);
+       if (ret)
+               goto err_mclk_rx;
+       if (i2s_tdm->mclk_calibrate) {
+               ret = clk_prepare_enable(i2s_tdm->mclk_tx_src);
+               if (ret)
+                       goto err_mclk_rx;
+               ret = clk_prepare_enable(i2s_tdm->mclk_rx_src);
+               if (ret)
+                       goto err_mclk_rx_src;
+               ret = clk_prepare_enable(i2s_tdm->mclk_root0);
+               if (ret)
+                       goto err_mclk_root0;
+               ret = clk_prepare_enable(i2s_tdm->mclk_root1);
+               if (ret)
+                       goto err_mclk_root1;
+       }
+
+       return 0;
+
+err_mclk_root1:
+       clk_disable_unprepare(i2s_tdm->mclk_root0);
+err_mclk_root0:
+       clk_disable_unprepare(i2s_tdm->mclk_rx_src);
+err_mclk_rx_src:
+       clk_disable_unprepare(i2s_tdm->mclk_tx_src);
+err_mclk_rx:
+       clk_disable_unprepare(i2s_tdm->mclk_tx);
+err_mclk_tx:
+       return ret;
+}
+
+static int __maybe_unused i2s_tdm_runtime_suspend(struct device *dev)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
+
+       regcache_cache_only(i2s_tdm->regmap, true);
+       i2s_tdm_disable_unprepare_mclk(i2s_tdm);
+
+       clk_disable_unprepare(i2s_tdm->hclk);
+
+       return 0;
+}
+
+static int __maybe_unused i2s_tdm_runtime_resume(struct device *dev)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
+       int ret;
+
+       ret = clk_prepare_enable(i2s_tdm->hclk);
+       if (ret)
+               goto err_hclk;
+
+       ret = i2s_tdm_prepare_enable_mclk(i2s_tdm);
+       if (ret)
+               goto err_mclk;
+
+       regcache_cache_only(i2s_tdm->regmap, false);
+       regcache_mark_dirty(i2s_tdm->regmap);
+
+       ret = regcache_sync(i2s_tdm->regmap);
+       if (ret)
+               goto err_regcache;
+
+       return 0;
+
+err_regcache:
+       i2s_tdm_disable_unprepare_mclk(i2s_tdm);
+err_mclk:
+       clk_disable_unprepare(i2s_tdm->hclk);
+err_hclk:
+       return ret;
+}
+
+static inline struct rk_i2s_tdm_dev *to_info(struct snd_soc_dai *dai)
+{
+       return snd_soc_dai_get_drvdata(dai);
+}
+
+/*
+ * Makes sure that both tx and rx are reset at the same time to sync lrck
+ * when clk_trcm > 0.
+ */
+static void rockchip_snd_xfer_sync_reset(struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       /* This is technically race-y.
+        *
+        * In an ideal world, we could atomically assert both resets at the
+        * same time, through an atomic bulk reset API. This API however does
+        * not exist, so what the downstream vendor code used to do was
+        * implement half a reset controller here and require the CRU to be
+        * passed to the driver as a device tree node. Violating abstractions
+        * like that is bad, especially when it influences something like the
+        * bindings which are supposed to describe the hardware, not whatever
+        * workarounds the driver needs, so it was dropped.
+        *
+        * In practice, asserting the resets one by one appears to work just
+        * fine for playback. During duplex (playback + capture) operation,
+        * this might become an issue, but that should be solved by the
+        * implementation of the aforementioned API, not by shoving a reset
+        * controller into an audio driver.
+        */
+
+       reset_control_assert(i2s_tdm->tx_reset);
+       reset_control_assert(i2s_tdm->rx_reset);
+       udelay(10);
+       reset_control_deassert(i2s_tdm->tx_reset);
+       reset_control_deassert(i2s_tdm->rx_reset);
+       udelay(10);
+}
+
+static void rockchip_snd_reset(struct reset_control *rc)
+{
+       reset_control_assert(rc);
+       udelay(10);
+       reset_control_deassert(rc);
+       udelay(10);
+}
+
+static void rockchip_snd_xfer_clear(struct rk_i2s_tdm_dev *i2s_tdm,
+                                   unsigned int clr)
+{
+       unsigned int xfer_mask = 0;
+       unsigned int xfer_val = 0;
+       unsigned int val;
+       int retry = 10;
+       bool tx = clr & I2S_CLR_TXC;
+       bool rx = clr & I2S_CLR_RXC;
+
+       if (!(rx || tx))
+               return;
+
+       if (tx) {
+               xfer_mask = I2S_XFER_TXS_START;
+               xfer_val = I2S_XFER_TXS_STOP;
+       }
+       if (rx) {
+               xfer_mask |= I2S_XFER_RXS_START;
+               xfer_val |= I2S_XFER_RXS_STOP;
+       }
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_XFER, xfer_mask, xfer_val);
+       udelay(150);
+       regmap_update_bits(i2s_tdm->regmap, I2S_CLR, clr, clr);
+
+       regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
+       /* Wait on the clear operation to finish */
+       while (val) {
+               udelay(15);
+               regmap_read(i2s_tdm->regmap, I2S_CLR, &val);
+               retry--;
+               if (!retry) {
+                       dev_warn(i2s_tdm->dev, "clear failed, reset %s%s\n",
+                                tx ? "tx" : "", rx ? "rx" : "");
+                       if (rx && tx)
+                               rockchip_snd_xfer_sync_reset(i2s_tdm);
+                       else if (tx)
+                               rockchip_snd_reset(i2s_tdm->tx_reset);
+                       else if (rx)
+                               rockchip_snd_reset(i2s_tdm->rx_reset);
+                       break;
+               }
+       }
+}
+
+static inline void rockchip_enable_tde(struct regmap *regmap)
+{
+       regmap_update_bits(regmap, I2S_DMACR, I2S_DMACR_TDE_ENABLE,
+                          I2S_DMACR_TDE_ENABLE);
+}
+
+static inline void rockchip_disable_tde(struct regmap *regmap)
+{
+       regmap_update_bits(regmap, I2S_DMACR, I2S_DMACR_TDE_ENABLE,
+                          I2S_DMACR_TDE_DISABLE);
+}
+
+static inline void rockchip_enable_rde(struct regmap *regmap)
+{
+       regmap_update_bits(regmap, I2S_DMACR, I2S_DMACR_RDE_ENABLE,
+                          I2S_DMACR_RDE_ENABLE);
+}
+
+static inline void rockchip_disable_rde(struct regmap *regmap)
+{
+       regmap_update_bits(regmap, I2S_DMACR, I2S_DMACR_RDE_ENABLE,
+                          I2S_DMACR_RDE_DISABLE);
+}
+
+/* only used when clk_trcm > 0 */
+static void rockchip_snd_txrxctrl(struct snd_pcm_substream *substream,
+                                 struct snd_soc_dai *dai, int on)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(dai);
+       unsigned long flags;
+
+       spin_lock_irqsave(&i2s_tdm->lock, flags);
+       if (on) {
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+                       rockchip_enable_tde(i2s_tdm->regmap);
+               else
+                       rockchip_enable_rde(i2s_tdm->regmap);
+
+               if (++i2s_tdm->refcount == 1) {
+                       rockchip_snd_xfer_sync_reset(i2s_tdm);
+                       regmap_update_bits(i2s_tdm->regmap, I2S_XFER,
+                                          I2S_XFER_TXS_START |
+                                          I2S_XFER_RXS_START,
+                                          I2S_XFER_TXS_START |
+                                          I2S_XFER_RXS_START);
+               }
+       } else {
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+                       rockchip_disable_tde(i2s_tdm->regmap);
+               else
+                       rockchip_disable_rde(i2s_tdm->regmap);
+
+               if (--i2s_tdm->refcount == 0) {
+                       rockchip_snd_xfer_clear(i2s_tdm,
+                                               I2S_CLR_TXC | I2S_CLR_RXC);
+               }
+       }
+       spin_unlock_irqrestore(&i2s_tdm->lock, flags);
+}
+
+static void rockchip_snd_txctrl(struct rk_i2s_tdm_dev *i2s_tdm, int on)
+{
+       if (on) {
+               rockchip_enable_tde(i2s_tdm->regmap);
+
+               regmap_update_bits(i2s_tdm->regmap, I2S_XFER,
+                                  I2S_XFER_TXS_START,
+                                  I2S_XFER_TXS_START);
+       } else {
+               rockchip_disable_tde(i2s_tdm->regmap);
+
+               rockchip_snd_xfer_clear(i2s_tdm, I2S_CLR_TXC);
+       }
+}
+
+static void rockchip_snd_rxctrl(struct rk_i2s_tdm_dev *i2s_tdm, int on)
+{
+       if (on) {
+               rockchip_enable_rde(i2s_tdm->regmap);
+
+               regmap_update_bits(i2s_tdm->regmap, I2S_XFER,
+                                  I2S_XFER_RXS_START,
+                                  I2S_XFER_RXS_START);
+       } else {
+               rockchip_disable_rde(i2s_tdm->regmap);
+
+               rockchip_snd_xfer_clear(i2s_tdm, I2S_CLR_RXC);
+       }
+}
+
+static int rockchip_i2s_tdm_set_fmt(struct snd_soc_dai *cpu_dai,
+                                   unsigned int fmt)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(cpu_dai);
+       unsigned int mask, val, tdm_val, txcr_val, rxcr_val;
+       int ret;
+       bool is_tdm = i2s_tdm->tdm_mode;
+
+       ret = pm_runtime_get_sync(cpu_dai->dev);
+       if (ret < 0 && ret != -EACCES) {
+               pm_runtime_put_noidle(cpu_dai->dev);
+               return ret;
+       }
+
+       mask = I2S_CKR_MSS_MASK;
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
+       case SND_SOC_DAIFMT_CBC_CFC:
+               val = I2S_CKR_MSS_MASTER;
+               i2s_tdm->is_master_mode = true;
+               break;
+       case SND_SOC_DAIFMT_CBP_CFP:
+               val = I2S_CKR_MSS_SLAVE;
+               i2s_tdm->is_master_mode = false;
+               break;
+       default:
+               ret = -EINVAL;
+               goto err_pm_put;
+       }
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_CKR, mask, val);
+
+       mask = I2S_CKR_CKP_MASK | I2S_CKR_TLP_MASK | I2S_CKR_RLP_MASK;
+       switch (fmt & SND_SOC_DAIFMT_INV_MASK) {
+       case SND_SOC_DAIFMT_NB_NF:
+               val = I2S_CKR_CKP_NORMAL |
+                     I2S_CKR_TLP_NORMAL |
+                     I2S_CKR_RLP_NORMAL;
+               break;
+       case SND_SOC_DAIFMT_NB_IF:
+               val = I2S_CKR_CKP_NORMAL |
+                     I2S_CKR_TLP_INVERTED |
+                     I2S_CKR_RLP_INVERTED;
+               break;
+       case SND_SOC_DAIFMT_IB_NF:
+               val = I2S_CKR_CKP_INVERTED |
+                     I2S_CKR_TLP_NORMAL |
+                     I2S_CKR_RLP_NORMAL;
+               break;
+       case SND_SOC_DAIFMT_IB_IF:
+               val = I2S_CKR_CKP_INVERTED |
+                     I2S_CKR_TLP_INVERTED |
+                     I2S_CKR_RLP_INVERTED;
+               break;
+       default:
+               ret = -EINVAL;
+               goto err_pm_put;
+       }
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_CKR, mask, val);
+
+       switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+       case SND_SOC_DAIFMT_RIGHT_J:
+               txcr_val = I2S_TXCR_IBM_RSJM;
+               rxcr_val = I2S_RXCR_IBM_RSJM;
+               break;
+       case SND_SOC_DAIFMT_LEFT_J:
+               txcr_val = I2S_TXCR_IBM_LSJM;
+               rxcr_val = I2S_RXCR_IBM_LSJM;
+               break;
+       case SND_SOC_DAIFMT_I2S:
+               txcr_val = I2S_TXCR_IBM_NORMAL;
+               rxcr_val = I2S_RXCR_IBM_NORMAL;
+               break;
+       case SND_SOC_DAIFMT_DSP_A: /* PCM no delay mode */
+               txcr_val = I2S_TXCR_TFS_PCM;
+               rxcr_val = I2S_RXCR_TFS_PCM;
+               break;
+       case SND_SOC_DAIFMT_DSP_B: /* PCM delay 1 mode */
+               txcr_val = I2S_TXCR_TFS_PCM | I2S_TXCR_PBM_MODE(1);
+               rxcr_val = I2S_RXCR_TFS_PCM | I2S_RXCR_PBM_MODE(1);
+               break;
+       default:
+               ret = -EINVAL;
+               goto err_pm_put;
+       }
+
+       mask = I2S_TXCR_IBM_MASK | I2S_TXCR_TFS_MASK | I2S_TXCR_PBM_MASK;
+       regmap_update_bits(i2s_tdm->regmap, I2S_TXCR, mask, txcr_val);
+
+       mask = I2S_RXCR_IBM_MASK | I2S_RXCR_TFS_MASK | I2S_RXCR_PBM_MASK;
+       regmap_update_bits(i2s_tdm->regmap, I2S_RXCR, mask, rxcr_val);
+
+       if (is_tdm) {
+               switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
+               case SND_SOC_DAIFMT_RIGHT_J:
+                       val = I2S_TXCR_TFS_TDM_I2S;
+                       tdm_val = TDM_SHIFT_CTRL(2);
+                       break;
+               case SND_SOC_DAIFMT_LEFT_J:
+                       val = I2S_TXCR_TFS_TDM_I2S;
+                       tdm_val = TDM_SHIFT_CTRL(1);
+                       break;
+               case SND_SOC_DAIFMT_I2S:
+                       val = I2S_TXCR_TFS_TDM_I2S;
+                       tdm_val = TDM_SHIFT_CTRL(0);
+                       break;
+               case SND_SOC_DAIFMT_DSP_A:
+                       val = I2S_TXCR_TFS_TDM_PCM;
+                       tdm_val = TDM_SHIFT_CTRL(0);
+                       break;
+               case SND_SOC_DAIFMT_DSP_B:
+                       val = I2S_TXCR_TFS_TDM_PCM;
+                       tdm_val = TDM_SHIFT_CTRL(2);
+                       break;
+               default:
+                       ret = -EINVAL;
+                       goto err_pm_put;
+               }
+
+               tdm_val |= TDM_FSYNC_WIDTH_SEL1(1);
+               tdm_val |= TDM_FSYNC_WIDTH_HALF_FRAME;
+
+               mask = I2S_TXCR_TFS_MASK;
+               regmap_update_bits(i2s_tdm->regmap, I2S_TXCR, mask, val);
+               regmap_update_bits(i2s_tdm->regmap, I2S_RXCR, mask, val);
+
+               mask = TDM_FSYNC_WIDTH_SEL1_MSK | TDM_FSYNC_WIDTH_SEL0_MSK |
+                      TDM_SHIFT_CTRL_MSK;
+               regmap_update_bits(i2s_tdm->regmap, I2S_TDM_TXCR,
+                                  mask, tdm_val);
+               regmap_update_bits(i2s_tdm->regmap, I2S_TDM_RXCR,
+                                  mask, tdm_val);
+       }
+
+err_pm_put:
+       pm_runtime_put(cpu_dai->dev);
+
+       return ret;
+}
+
+static void rockchip_i2s_tdm_xfer_pause(struct snd_pcm_substream *substream,
+                                       struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       int stream;
+
+       stream = SNDRV_PCM_STREAM_LAST - substream->stream;
+       if (stream == SNDRV_PCM_STREAM_PLAYBACK)
+               rockchip_disable_tde(i2s_tdm->regmap);
+       else
+               rockchip_disable_rde(i2s_tdm->regmap);
+
+       rockchip_snd_xfer_clear(i2s_tdm, I2S_CLR_TXC | I2S_CLR_RXC);
+}
+
+static void rockchip_i2s_tdm_xfer_resume(struct snd_pcm_substream *substream,
+                                        struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       int stream;
+
+       stream = SNDRV_PCM_STREAM_LAST - substream->stream;
+       if (stream == SNDRV_PCM_STREAM_PLAYBACK)
+               rockchip_enable_tde(i2s_tdm->regmap);
+       else
+               rockchip_enable_rde(i2s_tdm->regmap);
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_XFER,
+                          I2S_XFER_TXS_START |
+                          I2S_XFER_RXS_START,
+                          I2S_XFER_TXS_START |
+                          I2S_XFER_RXS_START);
+}
+
+static int rockchip_i2s_tdm_clk_set_rate(struct rk_i2s_tdm_dev *i2s_tdm,
+                                        struct clk *clk, unsigned long rate,
+                                        int ppm)
+{
+       unsigned long rate_target;
+       int delta, ret;
+
+       if (ppm == i2s_tdm->clk_ppm)
+               return 0;
+
+       if (ppm < 0)
+               delta = -1;
+       else
+               delta = 1;
+
+       delta *= (int)div64_u64((u64)rate * (u64)abs(ppm) + 500000,
+                               1000000);
+
+       rate_target = rate + delta;
+
+       if (!rate_target)
+               return -EINVAL;
+
+       ret = clk_set_rate(clk, rate_target);
+       if (ret)
+               return ret;
+
+       i2s_tdm->clk_ppm = ppm;
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_calibrate_mclk(struct rk_i2s_tdm_dev *i2s_tdm,
+                                          struct snd_pcm_substream *substream,
+                                          unsigned int lrck_freq)
+{
+       struct clk *mclk_root;
+       struct clk *mclk_parent;
+       unsigned int mclk_root_freq;
+       unsigned int mclk_root_initial_freq;
+       unsigned int mclk_parent_freq;
+       unsigned int div, delta;
+       u64 ppm;
+       int ret;
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               mclk_parent = i2s_tdm->mclk_tx_src;
+       else
+               mclk_parent = i2s_tdm->mclk_rx_src;
+
+       switch (lrck_freq) {
+       case 8000:
+       case 16000:
+       case 24000:
+       case 32000:
+       case 48000:
+       case 64000:
+       case 96000:
+       case 192000:
+               mclk_root = i2s_tdm->mclk_root0;
+               mclk_root_freq = i2s_tdm->mclk_root0_freq;
+               mclk_root_initial_freq = i2s_tdm->mclk_root0_initial_freq;
+               mclk_parent_freq = DEFAULT_MCLK_FS * 192000;
+               break;
+       case 11025:
+       case 22050:
+       case 44100:
+       case 88200:
+       case 176400:
+               mclk_root = i2s_tdm->mclk_root1;
+               mclk_root_freq = i2s_tdm->mclk_root1_freq;
+               mclk_root_initial_freq = i2s_tdm->mclk_root1_initial_freq;
+               mclk_parent_freq = DEFAULT_MCLK_FS * 176400;
+               break;
+       default:
+               dev_err(i2s_tdm->dev, "Invalid LRCK frequency: %u Hz\n",
+                       lrck_freq);
+               return -EINVAL;
+       }
+
+       ret = clk_set_parent(mclk_parent, mclk_root);
+       if (ret)
+               return ret;
+
+       ret = rockchip_i2s_tdm_clk_set_rate(i2s_tdm, mclk_root,
+                                           mclk_root_freq, 0);
+       if (ret)
+               return ret;
+
+       delta = abs(mclk_root_freq % mclk_parent_freq - mclk_parent_freq);
+       ppm = div64_u64((uint64_t)delta * 1000000, (uint64_t)mclk_root_freq);
+
+       if (ppm) {
+               div = DIV_ROUND_CLOSEST(mclk_root_initial_freq, mclk_parent_freq);
+               if (!div)
+                       return -EINVAL;
+
+               mclk_root_freq = mclk_parent_freq * round_up(div, 2);
+
+               ret = clk_set_rate(mclk_root, mclk_root_freq);
+               if (ret)
+                       return ret;
+
+               i2s_tdm->mclk_root0_freq = clk_get_rate(i2s_tdm->mclk_root0);
+               i2s_tdm->mclk_root1_freq = clk_get_rate(i2s_tdm->mclk_root1);
+       }
+
+       return clk_set_rate(mclk_parent, mclk_parent_freq);
+}
+
+static int rockchip_i2s_tdm_set_mclk(struct rk_i2s_tdm_dev *i2s_tdm,
+                                    struct snd_pcm_substream *substream,
+                                    struct clk **mclk)
+{
+       unsigned int mclk_freq;
+       int ret;
+
+       if (i2s_tdm->clk_trcm) {
+               if (i2s_tdm->mclk_tx_freq != i2s_tdm->mclk_rx_freq) {
+                       dev_err(i2s_tdm->dev,
+                               "clk_trcm, tx: %d and rx: %d should be the same\n",
+                               i2s_tdm->mclk_tx_freq,
+                               i2s_tdm->mclk_rx_freq);
+                       return -EINVAL;
+               }
+
+               ret = clk_set_rate(i2s_tdm->mclk_tx, i2s_tdm->mclk_tx_freq);
+               if (ret)
+                       return ret;
+
+               ret = clk_set_rate(i2s_tdm->mclk_rx, i2s_tdm->mclk_rx_freq);
+               if (ret)
+                       return ret;
+
+               /* mclk_rx is also ok. */
+               *mclk = i2s_tdm->mclk_tx;
+       } else {
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+                       *mclk = i2s_tdm->mclk_tx;
+                       mclk_freq = i2s_tdm->mclk_tx_freq;
+               } else {
+                       *mclk = i2s_tdm->mclk_rx;
+                       mclk_freq = i2s_tdm->mclk_rx_freq;
+               }
+
+               ret = clk_set_rate(*mclk, mclk_freq);
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int rockchip_i2s_ch_to_io(unsigned int ch, bool substream_capture)
+{
+       if (substream_capture) {
+               switch (ch) {
+               case I2S_CHN_4:
+                       return I2S_IO_6CH_OUT_4CH_IN;
+               case I2S_CHN_6:
+                       return I2S_IO_4CH_OUT_6CH_IN;
+               case I2S_CHN_8:
+                       return I2S_IO_2CH_OUT_8CH_IN;
+               default:
+                       return I2S_IO_8CH_OUT_2CH_IN;
+               }
+       } else {
+               switch (ch) {
+               case I2S_CHN_4:
+                       return I2S_IO_4CH_OUT_6CH_IN;
+               case I2S_CHN_6:
+                       return I2S_IO_6CH_OUT_4CH_IN;
+               case I2S_CHN_8:
+                       return I2S_IO_8CH_OUT_2CH_IN;
+               default:
+                       return I2S_IO_2CH_OUT_8CH_IN;
+               }
+       }
+}
+
+static int rockchip_i2s_io_multiplex(struct snd_pcm_substream *substream,
+                                    struct snd_soc_dai *dai)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(dai);
+       int usable_chs = MULTIPLEX_CH_MAX;
+       unsigned int val = 0;
+
+       if (!i2s_tdm->io_multiplex)
+               return 0;
+
+       if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) {
+               struct snd_pcm_str *playback_str =
+                       &substream->pcm->streams[SNDRV_PCM_STREAM_PLAYBACK];
+
+               if (playback_str->substream_opened) {
+                       regmap_read(i2s_tdm->regmap, I2S_TXCR, &val);
+                       val &= I2S_TXCR_CSR_MASK;
+                       usable_chs = MULTIPLEX_CH_MAX - to_ch_num(val);
+               }
+
+               regmap_read(i2s_tdm->regmap, I2S_RXCR, &val);
+               val &= I2S_RXCR_CSR_MASK;
+
+               if (to_ch_num(val) > usable_chs) {
+                       dev_err(i2s_tdm->dev,
+                               "Capture channels (%d) > usable channels (%d)\n",
+                               to_ch_num(val), usable_chs);
+                       return -EINVAL;
+               }
+
+               rockchip_i2s_ch_to_io(val, true);
+       } else {
+               struct snd_pcm_str *capture_str =
+                       &substream->pcm->streams[SNDRV_PCM_STREAM_CAPTURE];
+
+               if (capture_str->substream_opened) {
+                       regmap_read(i2s_tdm->regmap, I2S_RXCR, &val);
+                       val &= I2S_RXCR_CSR_MASK;
+                       usable_chs = MULTIPLEX_CH_MAX - to_ch_num(val);
+               }
+
+               regmap_read(i2s_tdm->regmap, I2S_TXCR, &val);
+               val &= I2S_TXCR_CSR_MASK;
+
+               if (to_ch_num(val) > usable_chs) {
+                       dev_err(i2s_tdm->dev,
+                               "Playback channels (%d) > usable channels (%d)\n",
+                               to_ch_num(val), usable_chs);
+                       return -EINVAL;
+               }
+       }
+
+       val <<= i2s_tdm->soc_data->grf_shift;
+       val |= (I2S_IO_DIRECTION_MASK << i2s_tdm->soc_data->grf_shift) << 16;
+       regmap_write(i2s_tdm->grf, i2s_tdm->soc_data->grf_reg_offset, val);
+
+       return 0;
+}
+
+static int rockchip_i2s_trcm_mode(struct snd_pcm_substream *substream,
+                                 struct snd_soc_dai *dai,
+                                 unsigned int div_bclk,
+                                 unsigned int div_lrck,
+                                 unsigned int fmt)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(dai);
+       unsigned long flags;
+
+       if (!i2s_tdm->clk_trcm)
+               return 0;
+
+       spin_lock_irqsave(&i2s_tdm->lock, flags);
+       if (i2s_tdm->refcount)
+               rockchip_i2s_tdm_xfer_pause(substream, i2s_tdm);
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_CLKDIV,
+                          I2S_CLKDIV_TXM_MASK | I2S_CLKDIV_RXM_MASK,
+                          I2S_CLKDIV_TXM(div_bclk) | I2S_CLKDIV_RXM(div_bclk));
+       regmap_update_bits(i2s_tdm->regmap, I2S_CKR,
+                          I2S_CKR_TSD_MASK | I2S_CKR_RSD_MASK,
+                          I2S_CKR_TSD(div_lrck) | I2S_CKR_RSD(div_lrck));
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               regmap_update_bits(i2s_tdm->regmap, I2S_TXCR,
+                                  I2S_TXCR_VDW_MASK | I2S_TXCR_CSR_MASK,
+                                  fmt);
+       else
+               regmap_update_bits(i2s_tdm->regmap, I2S_RXCR,
+                                  I2S_RXCR_VDW_MASK | I2S_RXCR_CSR_MASK,
+                                  fmt);
+
+       if (i2s_tdm->refcount)
+               rockchip_i2s_tdm_xfer_resume(substream, i2s_tdm);
+       spin_unlock_irqrestore(&i2s_tdm->lock, flags);
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_hw_params(struct snd_pcm_substream *substream,
+                                     struct snd_pcm_hw_params *params,
+                                     struct snd_soc_dai *dai)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(dai);
+       struct clk *mclk;
+       int ret = 0;
+       unsigned int val = 0;
+       unsigned int mclk_rate, bclk_rate, div_bclk = 4, div_lrck = 64;
+
+       if (i2s_tdm->is_master_mode) {
+               if (i2s_tdm->mclk_calibrate)
+                       rockchip_i2s_tdm_calibrate_mclk(i2s_tdm, substream,
+                                                       params_rate(params));
+
+               ret = rockchip_i2s_tdm_set_mclk(i2s_tdm, substream, &mclk);
+               if (ret)
+                       return ret;
+
+               mclk_rate = clk_get_rate(mclk);
+               bclk_rate = i2s_tdm->frame_width * params_rate(params);
+               if (!bclk_rate)
+                       return -EINVAL;
+
+               div_bclk = DIV_ROUND_CLOSEST(mclk_rate, bclk_rate);
+               div_lrck = bclk_rate / params_rate(params);
+       }
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S8:
+               val |= I2S_TXCR_VDW(8);
+               break;
+       case SNDRV_PCM_FORMAT_S16_LE:
+               val |= I2S_TXCR_VDW(16);
+               break;
+       case SNDRV_PCM_FORMAT_S20_3LE:
+               val |= I2S_TXCR_VDW(20);
+               break;
+       case SNDRV_PCM_FORMAT_S24_LE:
+               val |= I2S_TXCR_VDW(24);
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               val |= I2S_TXCR_VDW(32);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       switch (params_channels(params)) {
+       case 8:
+               val |= I2S_CHN_8;
+               break;
+       case 6:
+               val |= I2S_CHN_6;
+               break;
+       case 4:
+               val |= I2S_CHN_4;
+               break;
+       case 2:
+               val |= I2S_CHN_2;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       if (i2s_tdm->clk_trcm) {
+               rockchip_i2s_trcm_mode(substream, dai, div_bclk, div_lrck, val);
+       } else if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               regmap_update_bits(i2s_tdm->regmap, I2S_CLKDIV,
+                                  I2S_CLKDIV_TXM_MASK,
+                                  I2S_CLKDIV_TXM(div_bclk));
+               regmap_update_bits(i2s_tdm->regmap, I2S_CKR,
+                                  I2S_CKR_TSD_MASK,
+                                  I2S_CKR_TSD(div_lrck));
+               regmap_update_bits(i2s_tdm->regmap, I2S_TXCR,
+                                  I2S_TXCR_VDW_MASK | I2S_TXCR_CSR_MASK,
+                                  val);
+       } else {
+               regmap_update_bits(i2s_tdm->regmap, I2S_CLKDIV,
+                                  I2S_CLKDIV_RXM_MASK,
+                                  I2S_CLKDIV_RXM(div_bclk));
+               regmap_update_bits(i2s_tdm->regmap, I2S_CKR,
+                                  I2S_CKR_RSD_MASK,
+                                  I2S_CKR_RSD(div_lrck));
+               regmap_update_bits(i2s_tdm->regmap, I2S_RXCR,
+                                  I2S_RXCR_VDW_MASK | I2S_RXCR_CSR_MASK,
+                                  val);
+       }
+
+       return rockchip_i2s_io_multiplex(substream, dai);
+}
+
+static int rockchip_i2s_tdm_trigger(struct snd_pcm_substream *substream,
+                                   int cmd, struct snd_soc_dai *dai)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(dai);
+
+       switch (cmd) {
+       case SNDRV_PCM_TRIGGER_START:
+       case SNDRV_PCM_TRIGGER_RESUME:
+       case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
+               if (i2s_tdm->clk_trcm)
+                       rockchip_snd_txrxctrl(substream, dai, 1);
+               else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+                       rockchip_snd_rxctrl(i2s_tdm, 1);
+               else
+                       rockchip_snd_txctrl(i2s_tdm, 1);
+               break;
+       case SNDRV_PCM_TRIGGER_SUSPEND:
+       case SNDRV_PCM_TRIGGER_STOP:
+       case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
+               if (i2s_tdm->clk_trcm)
+                       rockchip_snd_txrxctrl(substream, dai, 0);
+               else if (substream->stream == SNDRV_PCM_STREAM_CAPTURE)
+                       rockchip_snd_rxctrl(i2s_tdm, 0);
+               else
+                       rockchip_snd_txctrl(i2s_tdm, 0);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_set_sysclk(struct snd_soc_dai *cpu_dai, int stream,
+                                      unsigned int freq, int dir)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = to_info(cpu_dai);
+
+       /* Put set mclk rate into rockchip_i2s_tdm_set_mclk() */
+       if (i2s_tdm->clk_trcm) {
+               i2s_tdm->mclk_tx_freq = freq;
+               i2s_tdm->mclk_rx_freq = freq;
+       } else {
+               if (stream == SNDRV_PCM_STREAM_PLAYBACK)
+                       i2s_tdm->mclk_tx_freq = freq;
+               else
+                       i2s_tdm->mclk_rx_freq = freq;
+       }
+
+       dev_dbg(i2s_tdm->dev, "The target mclk_%s freq is: %d\n",
+               stream ? "rx" : "tx", freq);
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_clk_compensation_info(struct snd_kcontrol *kcontrol,
+                                                 struct snd_ctl_elem_info *uinfo)
+{
+       uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
+       uinfo->count = 1;
+       uinfo->value.integer.min = CLK_PPM_MIN;
+       uinfo->value.integer.max = CLK_PPM_MAX;
+       uinfo->value.integer.step = 1;
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_clk_compensation_get(struct snd_kcontrol *kcontrol,
+                                                struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dai *dai = snd_kcontrol_chip(kcontrol);
+       struct rk_i2s_tdm_dev *i2s_tdm = snd_soc_dai_get_drvdata(dai);
+
+       ucontrol->value.integer.value[0] = i2s_tdm->clk_ppm;
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_clk_compensation_put(struct snd_kcontrol *kcontrol,
+                                                struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_dai *dai = snd_kcontrol_chip(kcontrol);
+       struct rk_i2s_tdm_dev *i2s_tdm = snd_soc_dai_get_drvdata(dai);
+       int ret = 0, ppm = 0;
+       int changed = 0;
+       unsigned long old_rate;
+
+       if (ucontrol->value.integer.value[0] < CLK_PPM_MIN ||
+           ucontrol->value.integer.value[0] > CLK_PPM_MAX)
+               return -EINVAL;
+
+       ppm = ucontrol->value.integer.value[0];
+
+       old_rate = clk_get_rate(i2s_tdm->mclk_root0);
+       ret = rockchip_i2s_tdm_clk_set_rate(i2s_tdm, i2s_tdm->mclk_root0,
+                                           i2s_tdm->mclk_root0_freq, ppm);
+       if (ret)
+               return ret;
+       if (old_rate != clk_get_rate(i2s_tdm->mclk_root0))
+               changed = 1;
+
+       if (clk_is_match(i2s_tdm->mclk_root0, i2s_tdm->mclk_root1))
+               return changed;
+
+       old_rate = clk_get_rate(i2s_tdm->mclk_root1);
+       ret = rockchip_i2s_tdm_clk_set_rate(i2s_tdm, i2s_tdm->mclk_root1,
+                                           i2s_tdm->mclk_root1_freq, ppm);
+       if (ret)
+               return ret;
+       if (old_rate != clk_get_rate(i2s_tdm->mclk_root1))
+               changed = 1;
+
+       return changed;
+}
+
+static struct snd_kcontrol_new rockchip_i2s_tdm_compensation_control = {
+       .iface = SNDRV_CTL_ELEM_IFACE_PCM,
+       .name = "PCM Clock Compensation in PPM",
+       .info = rockchip_i2s_tdm_clk_compensation_info,
+       .get = rockchip_i2s_tdm_clk_compensation_get,
+       .put = rockchip_i2s_tdm_clk_compensation_put,
+};
+
+static int rockchip_i2s_tdm_dai_probe(struct snd_soc_dai *dai)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = snd_soc_dai_get_drvdata(dai);
+
+       if (i2s_tdm->has_capture)
+               dai->capture_dma_data = &i2s_tdm->capture_dma_data;
+       if (i2s_tdm->has_playback)
+               dai->playback_dma_data = &i2s_tdm->playback_dma_data;
+
+       if (i2s_tdm->mclk_calibrate)
+               snd_soc_add_dai_controls(dai, &rockchip_i2s_tdm_compensation_control, 1);
+
+       return 0;
+}
+
+static int rockchip_dai_tdm_slot(struct snd_soc_dai *dai,
+                                unsigned int tx_mask, unsigned int rx_mask,
+                                int slots, int slot_width)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = snd_soc_dai_get_drvdata(dai);
+       unsigned int mask, val;
+
+       i2s_tdm->tdm_mode = true;
+       i2s_tdm->frame_width = slots * slot_width;
+       mask = TDM_SLOT_BIT_WIDTH_MSK | TDM_FRAME_WIDTH_MSK;
+       val = TDM_SLOT_BIT_WIDTH(slot_width) |
+             TDM_FRAME_WIDTH(slots * slot_width);
+       regmap_update_bits(i2s_tdm->regmap, I2S_TDM_TXCR,
+                          mask, val);
+       regmap_update_bits(i2s_tdm->regmap, I2S_TDM_RXCR,
+                          mask, val);
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_set_bclk_ratio(struct snd_soc_dai *dai,
+                                          unsigned int ratio)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = snd_soc_dai_get_drvdata(dai);
+
+       if (ratio < 32 || ratio > 512 || ratio % 2 == 1)
+               return -EINVAL;
+
+       i2s_tdm->frame_width = ratio;
+
+       return 0;
+}
+
+static const struct snd_soc_dai_ops rockchip_i2s_tdm_dai_ops = {
+       .hw_params = rockchip_i2s_tdm_hw_params,
+       .set_bclk_ratio = rockchip_i2s_tdm_set_bclk_ratio,
+       .set_sysclk = rockchip_i2s_tdm_set_sysclk,
+       .set_fmt = rockchip_i2s_tdm_set_fmt,
+       .set_tdm_slot = rockchip_dai_tdm_slot,
+       .trigger = rockchip_i2s_tdm_trigger,
+};
+
+static const struct snd_soc_component_driver rockchip_i2s_tdm_component = {
+       .name = DRV_NAME,
+};
+
+static bool rockchip_i2s_tdm_wr_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case I2S_TXCR:
+       case I2S_RXCR:
+       case I2S_CKR:
+       case I2S_DMACR:
+       case I2S_INTCR:
+       case I2S_XFER:
+       case I2S_CLR:
+       case I2S_TXDR:
+       case I2S_TDM_TXCR:
+       case I2S_TDM_RXCR:
+       case I2S_CLKDIV:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool rockchip_i2s_tdm_rd_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case I2S_TXCR:
+       case I2S_RXCR:
+       case I2S_CKR:
+       case I2S_DMACR:
+       case I2S_INTCR:
+       case I2S_XFER:
+       case I2S_CLR:
+       case I2S_TXDR:
+       case I2S_RXDR:
+       case I2S_TXFIFOLR:
+       case I2S_INTSR:
+       case I2S_RXFIFOLR:
+       case I2S_TDM_TXCR:
+       case I2S_TDM_RXCR:
+       case I2S_CLKDIV:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool rockchip_i2s_tdm_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case I2S_TXFIFOLR:
+       case I2S_INTSR:
+       case I2S_CLR:
+       case I2S_TXDR:
+       case I2S_RXDR:
+       case I2S_RXFIFOLR:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool rockchip_i2s_tdm_precious_reg(struct device *dev, unsigned int reg)
+{
+       if (reg == I2S_RXDR)
+               return true;
+       return false;
+}
+
+static const struct reg_default rockchip_i2s_tdm_reg_defaults[] = {
+       {0x00, 0x7200000f},
+       {0x04, 0x01c8000f},
+       {0x08, 0x00001f1f},
+       {0x10, 0x001f0000},
+       {0x14, 0x01f00000},
+       {0x30, 0x00003eff},
+       {0x34, 0x00003eff},
+       {0x38, 0x00000707},
+};
+
+static const struct regmap_config rockchip_i2s_tdm_regmap_config = {
+       .reg_bits = 32,
+       .reg_stride = 4,
+       .val_bits = 32,
+       .max_register = I2S_CLKDIV,
+       .reg_defaults = rockchip_i2s_tdm_reg_defaults,
+       .num_reg_defaults = ARRAY_SIZE(rockchip_i2s_tdm_reg_defaults),
+       .writeable_reg = rockchip_i2s_tdm_wr_reg,
+       .readable_reg = rockchip_i2s_tdm_rd_reg,
+       .volatile_reg = rockchip_i2s_tdm_volatile_reg,
+       .precious_reg = rockchip_i2s_tdm_precious_reg,
+       .cache_type = REGCACHE_FLAT,
+};
+
+static int common_soc_init(struct device *dev, u32 addr)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
+       const struct txrx_config *configs = i2s_tdm->soc_data->configs;
+       u32 reg = 0, val = 0, trcm = i2s_tdm->clk_trcm;
+       int i;
+
+       if (trcm == TRCM_TXRX)
+               return 0;
+
+       for (i = 0; i < i2s_tdm->soc_data->config_count; i++) {
+               if (addr != configs[i].addr)
+                       continue;
+               reg = configs[i].reg;
+               if (trcm == TRCM_TX)
+                       val = configs[i].txonly;
+               else
+                       val = configs[i].rxonly;
+
+               if (reg)
+                       regmap_write(i2s_tdm->grf, reg, val);
+       }
+
+       return 0;
+}
+
+static const struct txrx_config px30_txrx_config[] = {
+       { 0xff060000, 0x184, PX30_I2S0_CLK_TXONLY, PX30_I2S0_CLK_RXONLY },
+};
+
+static const struct txrx_config rk1808_txrx_config[] = {
+       { 0xff7e0000, 0x190, RK1808_I2S0_CLK_TXONLY, RK1808_I2S0_CLK_RXONLY },
+};
+
+static const struct txrx_config rk3308_txrx_config[] = {
+       { 0xff300000, 0x308, RK3308_I2S0_CLK_TXONLY, RK3308_I2S0_CLK_RXONLY },
+       { 0xff310000, 0x308, RK3308_I2S1_CLK_TXONLY, RK3308_I2S1_CLK_RXONLY },
+};
+
+static const struct txrx_config rk3568_txrx_config[] = {
+       { 0xfe410000, 0x504, RK3568_I2S1_CLK_TXONLY, RK3568_I2S1_CLK_RXONLY },
+       { 0xfe410000, 0x508, RK3568_I2S1_MCLK_TX_OE, RK3568_I2S1_MCLK_RX_OE },
+       { 0xfe420000, 0x508, RK3568_I2S2_MCLK_OE, RK3568_I2S2_MCLK_OE },
+       { 0xfe430000, 0x504, RK3568_I2S3_CLK_TXONLY, RK3568_I2S3_CLK_RXONLY },
+       { 0xfe430000, 0x508, RK3568_I2S3_MCLK_TXONLY, RK3568_I2S3_MCLK_RXONLY },
+       { 0xfe430000, 0x508, RK3568_I2S3_MCLK_OE, RK3568_I2S3_MCLK_OE },
+};
+
+static const struct txrx_config rv1126_txrx_config[] = {
+       { 0xff800000, 0x10260, RV1126_I2S0_CLK_TXONLY, RV1126_I2S0_CLK_RXONLY },
+};
+
+static struct rk_i2s_soc_data px30_i2s_soc_data = {
+       .softrst_offset = 0x0300,
+       .configs = px30_txrx_config,
+       .config_count = ARRAY_SIZE(px30_txrx_config),
+       .init = common_soc_init,
+};
+
+static struct rk_i2s_soc_data rk1808_i2s_soc_data = {
+       .softrst_offset = 0x0300,
+       .configs = rk1808_txrx_config,
+       .config_count = ARRAY_SIZE(rk1808_txrx_config),
+       .init = common_soc_init,
+};
+
+static struct rk_i2s_soc_data rk3308_i2s_soc_data = {
+       .softrst_offset = 0x0400,
+       .grf_reg_offset = 0x0308,
+       .grf_shift = 5,
+       .configs = rk3308_txrx_config,
+       .config_count = ARRAY_SIZE(rk3308_txrx_config),
+       .init = common_soc_init,
+};
+
+static struct rk_i2s_soc_data rk3568_i2s_soc_data = {
+       .softrst_offset = 0x0400,
+       .configs = rk3568_txrx_config,
+       .config_count = ARRAY_SIZE(rk3568_txrx_config),
+       .init = common_soc_init,
+};
+
+static struct rk_i2s_soc_data rv1126_i2s_soc_data = {
+       .softrst_offset = 0x0300,
+       .configs = rv1126_txrx_config,
+       .config_count = ARRAY_SIZE(rv1126_txrx_config),
+       .init = common_soc_init,
+};
+
+static const struct of_device_id rockchip_i2s_tdm_match[] = {
+       { .compatible = "rockchip,px30-i2s-tdm", .data = &px30_i2s_soc_data },
+       { .compatible = "rockchip,rk1808-i2s-tdm", .data = &rk1808_i2s_soc_data },
+       { .compatible = "rockchip,rk3308-i2s-tdm", .data = &rk3308_i2s_soc_data },
+       { .compatible = "rockchip,rk3568-i2s-tdm", .data = &rk3568_i2s_soc_data },
+       { .compatible = "rockchip,rv1126-i2s-tdm", .data = &rv1126_i2s_soc_data },
+       {},
+};
+
+static struct snd_soc_dai_driver i2s_tdm_dai = {
+       .probe = rockchip_i2s_tdm_dai_probe,
+       .playback = {
+               .stream_name  = "Playback",
+       },
+       .capture = {
+               .stream_name  = "Capture",
+       },
+       .ops = &rockchip_i2s_tdm_dai_ops,
+};
+
+static void rockchip_i2s_tdm_init_dai(struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       struct property *dma_names;
+       const char *dma_name;
+       u64 formats = (SNDRV_PCM_FMTBIT_S8 | SNDRV_PCM_FMTBIT_S16_LE |
+                      SNDRV_PCM_FMTBIT_S20_3LE | SNDRV_PCM_FMTBIT_S24_LE |
+                      SNDRV_PCM_FMTBIT_S32_LE);
+       struct device_node *node = i2s_tdm->dev->of_node;
+
+       of_property_for_each_string(node, "dma-names", dma_names, dma_name) {
+               if (!strcmp(dma_name, "tx"))
+                       i2s_tdm->has_playback = true;
+               if (!strcmp(dma_name, "rx"))
+                       i2s_tdm->has_capture = true;
+       }
+
+       if (i2s_tdm->has_playback) {
+               i2s_tdm_dai.playback.channels_min = 2;
+               i2s_tdm_dai.playback.channels_max = 8;
+               i2s_tdm_dai.playback.rates = SNDRV_PCM_RATE_8000_192000;
+               i2s_tdm_dai.playback.formats = formats;
+       }
+
+       if (i2s_tdm->has_capture) {
+               i2s_tdm_dai.capture.channels_min = 2;
+               i2s_tdm_dai.capture.channels_max = 8;
+               i2s_tdm_dai.capture.rates = SNDRV_PCM_RATE_8000_192000;
+               i2s_tdm_dai.capture.formats = formats;
+       }
+}
+
+static int rockchip_i2s_tdm_path_check(struct rk_i2s_tdm_dev *i2s_tdm,
+                                      int num,
+                                      bool is_rx_path)
+{
+       unsigned int *i2s_data;
+       int i, j;
+
+       if (is_rx_path)
+               i2s_data = i2s_tdm->i2s_sdis;
+       else
+               i2s_data = i2s_tdm->i2s_sdos;
+
+       for (i = 0; i < num; i++) {
+               if (i2s_data[i] > CH_GRP_MAX - 1) {
+                       dev_err(i2s_tdm->dev,
+                               "%s path i2s_data[%d]: %d is too high, max is: %d\n",
+                               is_rx_path ? "RX" : "TX",
+                               i, i2s_data[i], CH_GRP_MAX);
+                       return -EINVAL;
+               }
+
+               for (j = 0; j < num; j++) {
+                       if (i == j)
+                               continue;
+
+                       if (i2s_data[i] == i2s_data[j]) {
+                               dev_err(i2s_tdm->dev,
+                                       "%s path invalid routed i2s_data: [%d]%d == [%d]%d\n",
+                                       is_rx_path ? "RX" : "TX",
+                                       i, i2s_data[i],
+                                       j, i2s_data[j]);
+                               return -EINVAL;
+                       }
+               }
+       }
+
+       return 0;
+}
+
+static void rockchip_i2s_tdm_tx_path_config(struct rk_i2s_tdm_dev *i2s_tdm,
+                                           int num)
+{
+       int idx;
+
+       for (idx = 0; idx < num; idx++) {
+               regmap_update_bits(i2s_tdm->regmap, I2S_TXCR,
+                                  I2S_TXCR_PATH_MASK(idx),
+                                  I2S_TXCR_PATH(idx, i2s_tdm->i2s_sdos[idx]));
+       }
+}
+
+static void rockchip_i2s_tdm_rx_path_config(struct rk_i2s_tdm_dev *i2s_tdm,
+                                           int num)
+{
+       int idx;
+
+       for (idx = 0; idx < num; idx++) {
+               regmap_update_bits(i2s_tdm->regmap, I2S_RXCR,
+                                  I2S_RXCR_PATH_MASK(idx),
+                                  I2S_RXCR_PATH(idx, i2s_tdm->i2s_sdis[idx]));
+       }
+}
+
+static void rockchip_i2s_tdm_path_config(struct rk_i2s_tdm_dev *i2s_tdm,
+                                        int num, bool is_rx_path)
+{
+       if (is_rx_path)
+               rockchip_i2s_tdm_rx_path_config(i2s_tdm, num);
+       else
+               rockchip_i2s_tdm_tx_path_config(i2s_tdm, num);
+}
+
+static int rockchip_i2s_tdm_get_calibrate_mclks(struct rk_i2s_tdm_dev *i2s_tdm)
+{
+       int num_mclks = 0;
+
+       i2s_tdm->mclk_tx_src = devm_clk_get(i2s_tdm->dev, "mclk_tx_src");
+       if (!IS_ERR(i2s_tdm->mclk_tx_src))
+               num_mclks++;
+
+       i2s_tdm->mclk_rx_src = devm_clk_get(i2s_tdm->dev, "mclk_rx_src");
+       if (!IS_ERR(i2s_tdm->mclk_rx_src))
+               num_mclks++;
+
+       i2s_tdm->mclk_root0 = devm_clk_get(i2s_tdm->dev, "mclk_root0");
+       if (!IS_ERR(i2s_tdm->mclk_root0))
+               num_mclks++;
+
+       i2s_tdm->mclk_root1 = devm_clk_get(i2s_tdm->dev, "mclk_root1");
+       if (!IS_ERR(i2s_tdm->mclk_root1))
+               num_mclks++;
+
+       if (num_mclks < 4 && num_mclks != 0)
+               return -ENOENT;
+
+       if (num_mclks == 4)
+               i2s_tdm->mclk_calibrate = 1;
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_path_prepare(struct rk_i2s_tdm_dev *i2s_tdm,
+                                        struct device_node *np,
+                                        bool is_rx_path)
+{
+       char *i2s_tx_path_prop = "rockchip,i2s-tx-route";
+       char *i2s_rx_path_prop = "rockchip,i2s-rx-route";
+       char *i2s_path_prop;
+       unsigned int *i2s_data;
+       int num, ret = 0;
+
+       if (is_rx_path) {
+               i2s_path_prop = i2s_rx_path_prop;
+               i2s_data = i2s_tdm->i2s_sdis;
+       } else {
+               i2s_path_prop = i2s_tx_path_prop;
+               i2s_data = i2s_tdm->i2s_sdos;
+       }
+
+       num = of_count_phandle_with_args(np, i2s_path_prop, NULL);
+       if (num < 0) {
+               if (num != -ENOENT) {
+                       dev_err(i2s_tdm->dev,
+                               "Failed to read '%s' num: %d\n",
+                               i2s_path_prop, num);
+                       ret = num;
+               }
+               return ret;
+       } else if (num != CH_GRP_MAX) {
+               dev_err(i2s_tdm->dev,
+                       "The num: %d should be: %d\n", num, CH_GRP_MAX);
+               return -EINVAL;
+       }
+
+       ret = of_property_read_u32_array(np, i2s_path_prop,
+                                        i2s_data, num);
+       if (ret < 0) {
+               dev_err(i2s_tdm->dev,
+                       "Failed to read '%s': %d\n",
+                       i2s_path_prop, ret);
+               return ret;
+       }
+
+       ret = rockchip_i2s_tdm_path_check(i2s_tdm, num, is_rx_path);
+       if (ret < 0) {
+               dev_err(i2s_tdm->dev,
+                       "Failed to check i2s data bus: %d\n", ret);
+               return ret;
+       }
+
+       rockchip_i2s_tdm_path_config(i2s_tdm, num, is_rx_path);
+
+       return 0;
+}
+
+static int rockchip_i2s_tdm_tx_path_prepare(struct rk_i2s_tdm_dev *i2s_tdm,
+                                           struct device_node *np)
+{
+       return rockchip_i2s_tdm_path_prepare(i2s_tdm, np, 0);
+}
+
+static int rockchip_i2s_tdm_rx_path_prepare(struct rk_i2s_tdm_dev *i2s_tdm,
+                                           struct device_node *np)
+{
+       return rockchip_i2s_tdm_path_prepare(i2s_tdm, np, 1);
+}
+
+static int rockchip_i2s_tdm_probe(struct platform_device *pdev)
+{
+       struct device_node *node = pdev->dev.of_node;
+       const struct of_device_id *of_id;
+       struct rk_i2s_tdm_dev *i2s_tdm;
+       struct resource *res;
+       void __iomem *regs;
+       int ret;
+
+       i2s_tdm = devm_kzalloc(&pdev->dev, sizeof(*i2s_tdm), GFP_KERNEL);
+       if (!i2s_tdm)
+               return -ENOMEM;
+
+       i2s_tdm->dev = &pdev->dev;
+
+       of_id = of_match_device(rockchip_i2s_tdm_match, &pdev->dev);
+       if (!of_id || !of_id->data)
+               return -EINVAL;
+
+       spin_lock_init(&i2s_tdm->lock);
+       i2s_tdm->soc_data = (struct rk_i2s_soc_data *)of_id->data;
+
+       rockchip_i2s_tdm_init_dai(i2s_tdm);
+
+       i2s_tdm->frame_width = 64;
+
+       i2s_tdm->clk_trcm = TRCM_TXRX;
+       if (of_property_read_bool(node, "rockchip,trcm-sync-tx-only"))
+               i2s_tdm->clk_trcm = TRCM_TX;
+       if (of_property_read_bool(node, "rockchip,trcm-sync-rx-only")) {
+               if (i2s_tdm->clk_trcm) {
+                       dev_err(i2s_tdm->dev, "invalid trcm-sync configuration\n");
+                       return -EINVAL;
+               }
+               i2s_tdm->clk_trcm = TRCM_RX;
+       }
+       if (i2s_tdm->clk_trcm != TRCM_TXRX)
+               i2s_tdm_dai.symmetric_rate = 1;
+
+       i2s_tdm->grf = syscon_regmap_lookup_by_phandle(node, "rockchip,grf");
+       if (IS_ERR(i2s_tdm->grf))
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->grf),
+                                    "Error in rockchip,grf\n");
+
+       i2s_tdm->tx_reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
+                                                                     "tx-m");
+       if (IS_ERR(i2s_tdm->tx_reset)) {
+               ret = PTR_ERR(i2s_tdm->tx_reset);
+               return dev_err_probe(i2s_tdm->dev, ret,
+                                    "Error in tx-m reset control\n");
+       }
+
+       i2s_tdm->rx_reset = devm_reset_control_get_optional_exclusive(&pdev->dev,
+                                                                     "rx-m");
+       if (IS_ERR(i2s_tdm->rx_reset)) {
+               ret = PTR_ERR(i2s_tdm->rx_reset);
+               return dev_err_probe(i2s_tdm->dev, ret,
+                                    "Error in rx-m reset control\n");
+       }
+
+       i2s_tdm->hclk = devm_clk_get(&pdev->dev, "hclk");
+       if (IS_ERR(i2s_tdm->hclk)) {
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->hclk),
+                                    "Failed to get clock hclk\n");
+       }
+
+       i2s_tdm->mclk_tx = devm_clk_get(&pdev->dev, "mclk_tx");
+       if (IS_ERR(i2s_tdm->mclk_tx)) {
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->mclk_tx),
+                                    "Failed to get clock mclk_tx\n");
+       }
+
+       i2s_tdm->mclk_rx = devm_clk_get(&pdev->dev, "mclk_rx");
+       if (IS_ERR(i2s_tdm->mclk_rx)) {
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->mclk_rx),
+                                    "Failed to get clock mclk_rx\n");
+       }
+
+       i2s_tdm->io_multiplex =
+               of_property_read_bool(node, "rockchip,io-multiplex");
+
+       ret = rockchip_i2s_tdm_get_calibrate_mclks(i2s_tdm);
+       if (ret)
+               return dev_err_probe(i2s_tdm->dev, ret,
+                                    "mclk-calibrate clocks missing");
+
+       regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
+       if (IS_ERR(regs)) {
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(regs),
+                                    "Failed to get resource IORESOURCE_MEM\n");
+       }
+
+       i2s_tdm->regmap = devm_regmap_init_mmio(&pdev->dev, regs,
+                                               &rockchip_i2s_tdm_regmap_config);
+       if (IS_ERR(i2s_tdm->regmap)) {
+               return dev_err_probe(i2s_tdm->dev, PTR_ERR(i2s_tdm->regmap),
+                                    "Failed to initialise regmap\n");
+       }
+
+       if (i2s_tdm->has_playback) {
+               i2s_tdm->playback_dma_data.addr = res->start + I2S_TXDR;
+               i2s_tdm->playback_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+               i2s_tdm->playback_dma_data.maxburst = 8;
+       }
+
+       if (i2s_tdm->has_capture) {
+               i2s_tdm->capture_dma_data.addr = res->start + I2S_RXDR;
+               i2s_tdm->capture_dma_data.addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES;
+               i2s_tdm->capture_dma_data.maxburst = 8;
+       }
+
+       ret = rockchip_i2s_tdm_tx_path_prepare(i2s_tdm, node);
+       if (ret < 0) {
+               dev_err(&pdev->dev, "I2S TX path prepare failed: %d\n", ret);
+               return ret;
+       }
+
+       ret = rockchip_i2s_tdm_rx_path_prepare(i2s_tdm, node);
+       if (ret < 0) {
+               dev_err(&pdev->dev, "I2S RX path prepare failed: %d\n", ret);
+               return ret;
+       }
+
+       dev_set_drvdata(&pdev->dev, i2s_tdm);
+
+       ret = clk_prepare_enable(i2s_tdm->hclk);
+       if (ret) {
+               return dev_err_probe(i2s_tdm->dev, ret,
+                                    "Failed to enable clock hclk\n");
+       }
+
+       ret = i2s_tdm_prepare_enable_mclk(i2s_tdm);
+       if (ret) {
+               ret = dev_err_probe(i2s_tdm->dev, ret,
+                                   "Failed to enable one or more mclks\n");
+               goto err_disable_hclk;
+       }
+
+       if (i2s_tdm->mclk_calibrate) {
+               i2s_tdm->mclk_root0_initial_freq = clk_get_rate(i2s_tdm->mclk_root0);
+               i2s_tdm->mclk_root1_initial_freq = clk_get_rate(i2s_tdm->mclk_root1);
+               i2s_tdm->mclk_root0_freq = i2s_tdm->mclk_root0_initial_freq;
+               i2s_tdm->mclk_root1_freq = i2s_tdm->mclk_root1_initial_freq;
+       }
+
+       pm_runtime_enable(&pdev->dev);
+
+       regmap_update_bits(i2s_tdm->regmap, I2S_DMACR, I2S_DMACR_TDL_MASK,
+                          I2S_DMACR_TDL(16));
+       regmap_update_bits(i2s_tdm->regmap, I2S_DMACR, I2S_DMACR_RDL_MASK,
+                          I2S_DMACR_RDL(16));
+       regmap_update_bits(i2s_tdm->regmap, I2S_CKR, I2S_CKR_TRCM_MASK,
+                          i2s_tdm->clk_trcm << I2S_CKR_TRCM_SHIFT);
+
+       if (i2s_tdm->soc_data && i2s_tdm->soc_data->init)
+               i2s_tdm->soc_data->init(&pdev->dev, res->start);
+
+       ret = devm_snd_soc_register_component(&pdev->dev,
+                                             &rockchip_i2s_tdm_component,
+                                             &i2s_tdm_dai, 1);
+
+       if (ret) {
+               dev_err(&pdev->dev, "Could not register DAI\n");
+               goto err_suspend;
+       }
+
+       ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
+       if (ret) {
+               dev_err(&pdev->dev, "Could not register PCM\n");
+               goto err_suspend;
+       }
+
+       return 0;
+
+err_suspend:
+       if (!pm_runtime_status_suspended(&pdev->dev))
+               i2s_tdm_runtime_suspend(&pdev->dev);
+       pm_runtime_disable(&pdev->dev);
+
+err_disable_hclk:
+       clk_disable_unprepare(i2s_tdm->hclk);
+
+       return ret;
+}
+
+static int rockchip_i2s_tdm_remove(struct platform_device *pdev)
+{
+       if (!pm_runtime_status_suspended(&pdev->dev))
+               i2s_tdm_runtime_suspend(&pdev->dev);
+
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static int __maybe_unused rockchip_i2s_tdm_suspend(struct device *dev)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
+
+       regcache_mark_dirty(i2s_tdm->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused rockchip_i2s_tdm_resume(struct device *dev)
+{
+       struct rk_i2s_tdm_dev *i2s_tdm = dev_get_drvdata(dev);
+       int ret;
+
+       ret = pm_runtime_get_sync(dev);
+       if (ret < 0)
+               return ret;
+       ret = regcache_sync(i2s_tdm->regmap);
+       pm_runtime_put(dev);
+
+       return ret;
+}
+
+static const struct dev_pm_ops rockchip_i2s_tdm_pm_ops = {
+       SET_RUNTIME_PM_OPS(i2s_tdm_runtime_suspend, i2s_tdm_runtime_resume,
+                          NULL)
+       SET_SYSTEM_SLEEP_PM_OPS(rockchip_i2s_tdm_suspend,
+                               rockchip_i2s_tdm_resume)
+};
+
+static struct platform_driver rockchip_i2s_tdm_driver = {
+       .probe = rockchip_i2s_tdm_probe,
+       .remove = rockchip_i2s_tdm_remove,
+       .driver = {
+               .name = DRV_NAME,
+               .of_match_table = of_match_ptr(rockchip_i2s_tdm_match),
+               .pm = &rockchip_i2s_tdm_pm_ops,
+       },
+};
+module_platform_driver(rockchip_i2s_tdm_driver);
+
+MODULE_DESCRIPTION("ROCKCHIP I2S/TDM ASoC Interface");
+MODULE_AUTHOR("Sugar Zhang <sugar.zhang@rock-chips.com>");
+MODULE_LICENSE("GPL v2");
+MODULE_ALIAS("platform:" DRV_NAME);
+MODULE_DEVICE_TABLE(of, rockchip_i2s_tdm_match);
diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.h b/sound/soc/rockchip/rockchip_i2s_tdm.h
new file mode 100644 (file)
index 0000000..0aa1c6d
--- /dev/null
@@ -0,0 +1,398 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * ALSA SoC Audio Layer - Rockchip I2S/TDM Controller driver
+ *
+ * Copyright (c) 2018 Rockchip Electronics Co. Ltd.
+ * Author: Sugar Zhang <sugar.zhang@rock-chips.com>
+ *
+ */
+
+#ifndef _ROCKCHIP_I2S_TDM_H
+#define _ROCKCHIP_I2S_TDM_H
+
+/*
+ * TXCR
+ * transmit operation control register
+ */
+#define I2S_TXCR_PATH_SHIFT(x) (23 + (x) * 2)
+#define I2S_TXCR_PATH_MASK(x)  (0x3 << I2S_TXCR_PATH_SHIFT(x))
+#define I2S_TXCR_PATH(x, v)    ((v) << I2S_TXCR_PATH_SHIFT(x))
+#define I2S_TXCR_RCNT_SHIFT    17
+#define I2S_TXCR_RCNT_MASK     (0x3f << I2S_TXCR_RCNT_SHIFT)
+#define I2S_TXCR_CSR_SHIFT     15
+#define I2S_TXCR_CSR(x)                ((x) << I2S_TXCR_CSR_SHIFT)
+#define I2S_TXCR_CSR_MASK      (3 << I2S_TXCR_CSR_SHIFT)
+#define I2S_TXCR_HWT           BIT(14)
+#define I2S_TXCR_SJM_SHIFT     12
+#define I2S_TXCR_SJM_R         (0 << I2S_TXCR_SJM_SHIFT)
+#define I2S_TXCR_SJM_L         (1 << I2S_TXCR_SJM_SHIFT)
+#define I2S_TXCR_FBM_SHIFT     11
+#define I2S_TXCR_FBM_MSB       (0 << I2S_TXCR_FBM_SHIFT)
+#define I2S_TXCR_FBM_LSB       (1 << I2S_TXCR_FBM_SHIFT)
+#define I2S_TXCR_IBM_SHIFT     9
+#define I2S_TXCR_IBM_NORMAL    (0 << I2S_TXCR_IBM_SHIFT)
+#define I2S_TXCR_IBM_LSJM      (1 << I2S_TXCR_IBM_SHIFT)
+#define I2S_TXCR_IBM_RSJM      (2 << I2S_TXCR_IBM_SHIFT)
+#define I2S_TXCR_IBM_MASK      (3 << I2S_TXCR_IBM_SHIFT)
+#define I2S_TXCR_PBM_SHIFT     7
+#define I2S_TXCR_PBM_MODE(x)   ((x) << I2S_TXCR_PBM_SHIFT)
+#define I2S_TXCR_PBM_MASK      (3 << I2S_TXCR_PBM_SHIFT)
+#define I2S_TXCR_TFS_SHIFT     5
+#define I2S_TXCR_TFS_I2S       (0 << I2S_TXCR_TFS_SHIFT)
+#define I2S_TXCR_TFS_PCM       (1 << I2S_TXCR_TFS_SHIFT)
+#define I2S_TXCR_TFS_TDM_PCM   (2 << I2S_TXCR_TFS_SHIFT)
+#define I2S_TXCR_TFS_TDM_I2S   (3 << I2S_TXCR_TFS_SHIFT)
+#define I2S_TXCR_TFS_MASK      (3 << I2S_TXCR_TFS_SHIFT)
+#define I2S_TXCR_VDW_SHIFT     0
+#define I2S_TXCR_VDW(x)                (((x) - 1) << I2S_TXCR_VDW_SHIFT)
+#define I2S_TXCR_VDW_MASK      (0x1f << I2S_TXCR_VDW_SHIFT)
+
+/*
+ * RXCR
+ * receive operation control register
+ */
+#define I2S_RXCR_PATH_SHIFT(x) (17 + (x) * 2)
+#define I2S_RXCR_PATH_MASK(x)  (0x3 << I2S_RXCR_PATH_SHIFT(x))
+#define I2S_RXCR_PATH(x, v)    ((v) << I2S_RXCR_PATH_SHIFT(x))
+#define I2S_RXCR_CSR_SHIFT     15
+#define I2S_RXCR_CSR(x)                ((x) << I2S_RXCR_CSR_SHIFT)
+#define I2S_RXCR_CSR_MASK      (3 << I2S_RXCR_CSR_SHIFT)
+#define I2S_RXCR_HWT           BIT(14)
+#define I2S_RXCR_SJM_SHIFT     12
+#define I2S_RXCR_SJM_R         (0 << I2S_RXCR_SJM_SHIFT)
+#define I2S_RXCR_SJM_L         (1 << I2S_RXCR_SJM_SHIFT)
+#define I2S_RXCR_FBM_SHIFT     11
+#define I2S_RXCR_FBM_MSB       (0 << I2S_RXCR_FBM_SHIFT)
+#define I2S_RXCR_FBM_LSB       (1 << I2S_RXCR_FBM_SHIFT)
+#define I2S_RXCR_IBM_SHIFT     9
+#define I2S_RXCR_IBM_NORMAL    (0 << I2S_RXCR_IBM_SHIFT)
+#define I2S_RXCR_IBM_LSJM      (1 << I2S_RXCR_IBM_SHIFT)
+#define I2S_RXCR_IBM_RSJM      (2 << I2S_RXCR_IBM_SHIFT)
+#define I2S_RXCR_IBM_MASK      (3 << I2S_RXCR_IBM_SHIFT)
+#define I2S_RXCR_PBM_SHIFT     7
+#define I2S_RXCR_PBM_MODE(x)   ((x) << I2S_RXCR_PBM_SHIFT)
+#define I2S_RXCR_PBM_MASK      (3 << I2S_RXCR_PBM_SHIFT)
+#define I2S_RXCR_TFS_SHIFT     5
+#define I2S_RXCR_TFS_I2S       (0 << I2S_RXCR_TFS_SHIFT)
+#define I2S_RXCR_TFS_PCM       (1 << I2S_RXCR_TFS_SHIFT)
+#define I2S_RXCR_TFS_TDM_PCM   (2 << I2S_RXCR_TFS_SHIFT)
+#define I2S_RXCR_TFS_TDM_I2S   (3 << I2S_RXCR_TFS_SHIFT)
+#define I2S_RXCR_TFS_MASK      (3 << I2S_RXCR_TFS_SHIFT)
+#define I2S_RXCR_VDW_SHIFT     0
+#define I2S_RXCR_VDW(x)                (((x) - 1) << I2S_RXCR_VDW_SHIFT)
+#define I2S_RXCR_VDW_MASK      (0x1f << I2S_RXCR_VDW_SHIFT)
+
+/*
+ * CKR
+ * clock generation register
+ */
+#define I2S_CKR_TRCM_SHIFT     28
+#define I2S_CKR_TRCM(x)        ((x) << I2S_CKR_TRCM_SHIFT)
+#define I2S_CKR_TRCM_TXRX      (0 << I2S_CKR_TRCM_SHIFT)
+#define I2S_CKR_TRCM_TXONLY    (1 << I2S_CKR_TRCM_SHIFT)
+#define I2S_CKR_TRCM_RXONLY    (2 << I2S_CKR_TRCM_SHIFT)
+#define I2S_CKR_TRCM_MASK      (3 << I2S_CKR_TRCM_SHIFT)
+#define I2S_CKR_MSS_SHIFT      27
+#define I2S_CKR_MSS_MASTER     (0 << I2S_CKR_MSS_SHIFT)
+#define I2S_CKR_MSS_SLAVE      (1 << I2S_CKR_MSS_SHIFT)
+#define I2S_CKR_MSS_MASK       (1 << I2S_CKR_MSS_SHIFT)
+#define I2S_CKR_CKP_SHIFT      26
+#define I2S_CKR_CKP_NORMAL     (0 << I2S_CKR_CKP_SHIFT)
+#define I2S_CKR_CKP_INVERTED   (1 << I2S_CKR_CKP_SHIFT)
+#define I2S_CKR_CKP_MASK       (1 << I2S_CKR_CKP_SHIFT)
+#define I2S_CKR_RLP_SHIFT      25
+#define I2S_CKR_RLP_NORMAL     (0 << I2S_CKR_RLP_SHIFT)
+#define I2S_CKR_RLP_INVERTED   (1 << I2S_CKR_RLP_SHIFT)
+#define I2S_CKR_RLP_MASK       (1 << I2S_CKR_RLP_SHIFT)
+#define I2S_CKR_TLP_SHIFT      24
+#define I2S_CKR_TLP_NORMAL     (0 << I2S_CKR_TLP_SHIFT)
+#define I2S_CKR_TLP_INVERTED   (1 << I2S_CKR_TLP_SHIFT)
+#define I2S_CKR_TLP_MASK       (1 << I2S_CKR_TLP_SHIFT)
+#define I2S_CKR_MDIV_SHIFT     16
+#define I2S_CKR_MDIV(x)                (((x) - 1) << I2S_CKR_MDIV_SHIFT)
+#define I2S_CKR_MDIV_MASK      (0xff << I2S_CKR_MDIV_SHIFT)
+#define I2S_CKR_RSD_SHIFT      8
+#define I2S_CKR_RSD(x)         (((x) - 1) << I2S_CKR_RSD_SHIFT)
+#define I2S_CKR_RSD_MASK       (0xff << I2S_CKR_RSD_SHIFT)
+#define I2S_CKR_TSD_SHIFT      0
+#define I2S_CKR_TSD(x)         (((x) - 1) << I2S_CKR_TSD_SHIFT)
+#define I2S_CKR_TSD_MASK       (0xff << I2S_CKR_TSD_SHIFT)
+
+/*
+ * FIFOLR
+ * FIFO level register
+ */
+#define I2S_FIFOLR_RFL_SHIFT   24
+#define I2S_FIFOLR_RFL_MASK    (0x3f << I2S_FIFOLR_RFL_SHIFT)
+#define I2S_FIFOLR_TFL3_SHIFT  18
+#define I2S_FIFOLR_TFL3_MASK   (0x3f << I2S_FIFOLR_TFL3_SHIFT)
+#define I2S_FIFOLR_TFL2_SHIFT  12
+#define I2S_FIFOLR_TFL2_MASK   (0x3f << I2S_FIFOLR_TFL2_SHIFT)
+#define I2S_FIFOLR_TFL1_SHIFT  6
+#define I2S_FIFOLR_TFL1_MASK   (0x3f << I2S_FIFOLR_TFL1_SHIFT)
+#define I2S_FIFOLR_TFL0_SHIFT  0
+#define I2S_FIFOLR_TFL0_MASK   (0x3f << I2S_FIFOLR_TFL0_SHIFT)
+
+/*
+ * DMACR
+ * DMA control register
+ */
+#define I2S_DMACR_RDE_SHIFT    24
+#define I2S_DMACR_RDE_DISABLE  (0 << I2S_DMACR_RDE_SHIFT)
+#define I2S_DMACR_RDE_ENABLE   (1 << I2S_DMACR_RDE_SHIFT)
+#define I2S_DMACR_RDL_SHIFT    16
+#define I2S_DMACR_RDL(x)       (((x) - 1) << I2S_DMACR_RDL_SHIFT)
+#define I2S_DMACR_RDL_MASK     (0x1f << I2S_DMACR_RDL_SHIFT)
+#define I2S_DMACR_TDE_SHIFT    8
+#define I2S_DMACR_TDE_DISABLE  (0 << I2S_DMACR_TDE_SHIFT)
+#define I2S_DMACR_TDE_ENABLE   (1 << I2S_DMACR_TDE_SHIFT)
+#define I2S_DMACR_TDL_SHIFT    0
+#define I2S_DMACR_TDL(x)       ((x) << I2S_DMACR_TDL_SHIFT)
+#define I2S_DMACR_TDL_MASK     (0x1f << I2S_DMACR_TDL_SHIFT)
+
+/*
+ * INTCR
+ * interrupt control register
+ */
+#define I2S_INTCR_RFT_SHIFT    20
+#define I2S_INTCR_RFT(x)       (((x) - 1) << I2S_INTCR_RFT_SHIFT)
+#define I2S_INTCR_RXOIC                BIT(18)
+#define I2S_INTCR_RXOIE_SHIFT  17
+#define I2S_INTCR_RXOIE_DISABLE        (0 << I2S_INTCR_RXOIE_SHIFT)
+#define I2S_INTCR_RXOIE_ENABLE (1 << I2S_INTCR_RXOIE_SHIFT)
+#define I2S_INTCR_RXFIE_SHIFT  16
+#define I2S_INTCR_RXFIE_DISABLE        (0 << I2S_INTCR_RXFIE_SHIFT)
+#define I2S_INTCR_RXFIE_ENABLE (1 << I2S_INTCR_RXFIE_SHIFT)
+#define I2S_INTCR_TFT_SHIFT    4
+#define I2S_INTCR_TFT(x)       (((x) - 1) << I2S_INTCR_TFT_SHIFT)
+#define I2S_INTCR_TFT_MASK     (0x1f << I2S_INTCR_TFT_SHIFT)
+#define I2S_INTCR_TXUIC                BIT(2)
+#define I2S_INTCR_TXUIE_SHIFT  1
+#define I2S_INTCR_TXUIE_DISABLE        (0 << I2S_INTCR_TXUIE_SHIFT)
+#define I2S_INTCR_TXUIE_ENABLE (1 << I2S_INTCR_TXUIE_SHIFT)
+
+/*
+ * INTSR
+ * interrupt status register
+ */
+#define I2S_INTSR_TXEIE_SHIFT  0
+#define I2S_INTSR_TXEIE_DISABLE        (0 << I2S_INTSR_TXEIE_SHIFT)
+#define I2S_INTSR_TXEIE_ENABLE (1 << I2S_INTSR_TXEIE_SHIFT)
+#define I2S_INTSR_RXOI_SHIFT   17
+#define I2S_INTSR_RXOI_INA     (0 << I2S_INTSR_RXOI_SHIFT)
+#define I2S_INTSR_RXOI_ACT     (1 << I2S_INTSR_RXOI_SHIFT)
+#define I2S_INTSR_RXFI_SHIFT   16
+#define I2S_INTSR_RXFI_INA     (0 << I2S_INTSR_RXFI_SHIFT)
+#define I2S_INTSR_RXFI_ACT     (1 << I2S_INTSR_RXFI_SHIFT)
+#define I2S_INTSR_TXUI_SHIFT   1
+#define I2S_INTSR_TXUI_INA     (0 << I2S_INTSR_TXUI_SHIFT)
+#define I2S_INTSR_TXUI_ACT     (1 << I2S_INTSR_TXUI_SHIFT)
+#define I2S_INTSR_TXEI_SHIFT   0
+#define I2S_INTSR_TXEI_INA     (0 << I2S_INTSR_TXEI_SHIFT)
+#define I2S_INTSR_TXEI_ACT     (1 << I2S_INTSR_TXEI_SHIFT)
+
+/*
+ * XFER
+ * Transfer start register
+ */
+#define I2S_XFER_RXS_SHIFT     1
+#define I2S_XFER_RXS_STOP      (0 << I2S_XFER_RXS_SHIFT)
+#define I2S_XFER_RXS_START     (1 << I2S_XFER_RXS_SHIFT)
+#define I2S_XFER_TXS_SHIFT     0
+#define I2S_XFER_TXS_STOP      (0 << I2S_XFER_TXS_SHIFT)
+#define I2S_XFER_TXS_START     (1 << I2S_XFER_TXS_SHIFT)
+
+/*
+ * CLR
+ * clear SCLK domain logic register
+ */
+#define I2S_CLR_RXC    BIT(1)
+#define I2S_CLR_TXC    BIT(0)
+
+/*
+ * TXDR
+ * Transimt FIFO data register, write only.
+ */
+#define I2S_TXDR_MASK  (0xff)
+
+/*
+ * RXDR
+ * Receive FIFO data register, write only.
+ */
+#define I2S_RXDR_MASK  (0xff)
+
+/*
+ * TDM_CTRL
+ * TDM ctrl register
+ */
+#define TDM_FSYNC_WIDTH_SEL1_MSK       GENMASK(20, 18)
+#define TDM_FSYNC_WIDTH_SEL1(x)                (((x) - 1) << 18)
+#define TDM_FSYNC_WIDTH_SEL0_MSK       BIT(17)
+#define TDM_FSYNC_WIDTH_HALF_FRAME     0
+#define TDM_FSYNC_WIDTH_ONE_FRAME      BIT(17)
+#define TDM_SHIFT_CTRL_MSK             GENMASK(16, 14)
+#define TDM_SHIFT_CTRL(x)              ((x) << 14)
+#define TDM_SLOT_BIT_WIDTH_MSK         GENMASK(13, 9)
+#define TDM_SLOT_BIT_WIDTH(x)          (((x) - 1) << 9)
+#define TDM_FRAME_WIDTH_MSK            GENMASK(8, 0)
+#define TDM_FRAME_WIDTH(x)             (((x) - 1) << 0)
+
+/*
+ * CLKDIV
+ * Mclk div register
+ */
+#define I2S_CLKDIV_TXM_SHIFT   0
+#define I2S_CLKDIV_TXM(x)              (((x) - 1) << I2S_CLKDIV_TXM_SHIFT)
+#define I2S_CLKDIV_TXM_MASK    (0xff << I2S_CLKDIV_TXM_SHIFT)
+#define I2S_CLKDIV_RXM_SHIFT   8
+#define I2S_CLKDIV_RXM(x)              (((x) - 1) << I2S_CLKDIV_RXM_SHIFT)
+#define I2S_CLKDIV_RXM_MASK    (0xff << I2S_CLKDIV_RXM_SHIFT)
+
+/* Clock divider id */
+enum {
+       ROCKCHIP_DIV_MCLK = 0,
+       ROCKCHIP_DIV_BCLK,
+};
+
+/* channel select */
+#define I2S_CSR_SHIFT  15
+#define I2S_CHN_2      (0 << I2S_CSR_SHIFT)
+#define I2S_CHN_4      (1 << I2S_CSR_SHIFT)
+#define I2S_CHN_6      (2 << I2S_CSR_SHIFT)
+#define I2S_CHN_8      (3 << I2S_CSR_SHIFT)
+
+/* io direction cfg register */
+#define I2S_IO_DIRECTION_MASK  (7)
+#define I2S_IO_8CH_OUT_2CH_IN  (7)
+#define I2S_IO_6CH_OUT_4CH_IN  (3)
+#define I2S_IO_4CH_OUT_6CH_IN  (1)
+#define I2S_IO_2CH_OUT_8CH_IN  (0)
+
+/* I2S REGS */
+#define I2S_TXCR       (0x0000)
+#define I2S_RXCR       (0x0004)
+#define I2S_CKR                (0x0008)
+#define I2S_TXFIFOLR   (0x000c)
+#define I2S_DMACR      (0x0010)
+#define I2S_INTCR      (0x0014)
+#define I2S_INTSR      (0x0018)
+#define I2S_XFER       (0x001c)
+#define I2S_CLR                (0x0020)
+#define I2S_TXDR       (0x0024)
+#define I2S_RXDR       (0x0028)
+#define I2S_RXFIFOLR   (0x002c)
+#define I2S_TDM_TXCR   (0x0030)
+#define I2S_TDM_RXCR   (0x0034)
+#define I2S_CLKDIV     (0x0038)
+
+#define HIWORD_UPDATE(v, h, l) (((v) << (l)) | (GENMASK((h), (l)) << 16))
+
+/* PX30 GRF CONFIGS */
+#define PX30_I2S0_CLK_IN_SRC_FROM_TX           HIWORD_UPDATE(1, 13, 12)
+#define PX30_I2S0_CLK_IN_SRC_FROM_RX           HIWORD_UPDATE(2, 13, 12)
+#define PX30_I2S0_MCLK_OUT_SRC_FROM_TX         HIWORD_UPDATE(1, 5, 5)
+#define PX30_I2S0_MCLK_OUT_SRC_FROM_RX         HIWORD_UPDATE(0, 5, 5)
+
+#define PX30_I2S0_CLK_TXONLY \
+       (PX30_I2S0_MCLK_OUT_SRC_FROM_TX | PX30_I2S0_CLK_IN_SRC_FROM_TX)
+
+#define PX30_I2S0_CLK_RXONLY \
+       (PX30_I2S0_MCLK_OUT_SRC_FROM_RX | PX30_I2S0_CLK_IN_SRC_FROM_RX)
+
+/* RK1808 GRF CONFIGS */
+#define RK1808_I2S0_MCLK_OUT_SRC_FROM_RX       HIWORD_UPDATE(1, 2, 2)
+#define RK1808_I2S0_MCLK_OUT_SRC_FROM_TX       HIWORD_UPDATE(0, 2, 2)
+#define RK1808_I2S0_CLK_IN_SRC_FROM_TX         HIWORD_UPDATE(1, 1, 0)
+#define RK1808_I2S0_CLK_IN_SRC_FROM_RX         HIWORD_UPDATE(2, 1, 0)
+
+#define RK1808_I2S0_CLK_TXONLY \
+       (RK1808_I2S0_MCLK_OUT_SRC_FROM_TX | RK1808_I2S0_CLK_IN_SRC_FROM_TX)
+
+#define RK1808_I2S0_CLK_RXONLY \
+       (RK1808_I2S0_MCLK_OUT_SRC_FROM_RX | RK1808_I2S0_CLK_IN_SRC_FROM_RX)
+
+/* RK3308 GRF CONFIGS */
+#define RK3308_I2S0_8CH_MCLK_OUT_SRC_FROM_RX   HIWORD_UPDATE(1, 10, 10)
+#define RK3308_I2S0_8CH_MCLK_OUT_SRC_FROM_TX   HIWORD_UPDATE(0, 10, 10)
+#define RK3308_I2S0_8CH_CLK_IN_RX_SRC_FROM_TX  HIWORD_UPDATE(1, 9, 9)
+#define RK3308_I2S0_8CH_CLK_IN_RX_SRC_FROM_RX  HIWORD_UPDATE(0, 9, 9)
+#define RK3308_I2S0_8CH_CLK_IN_TX_SRC_FROM_RX  HIWORD_UPDATE(1, 8, 8)
+#define RK3308_I2S0_8CH_CLK_IN_TX_SRC_FROM_TX  HIWORD_UPDATE(0, 8, 8)
+#define RK3308_I2S1_8CH_MCLK_OUT_SRC_FROM_RX   HIWORD_UPDATE(1, 2, 2)
+#define RK3308_I2S1_8CH_MCLK_OUT_SRC_FROM_TX   HIWORD_UPDATE(0, 2, 2)
+#define RK3308_I2S1_8CH_CLK_IN_RX_SRC_FROM_TX  HIWORD_UPDATE(1, 1, 1)
+#define RK3308_I2S1_8CH_CLK_IN_RX_SRC_FROM_RX  HIWORD_UPDATE(0, 1, 1)
+#define RK3308_I2S1_8CH_CLK_IN_TX_SRC_FROM_RX  HIWORD_UPDATE(1, 0, 0)
+#define RK3308_I2S1_8CH_CLK_IN_TX_SRC_FROM_TX  HIWORD_UPDATE(0, 0, 0)
+
+#define RK3308_I2S0_CLK_TXONLY \
+       (RK3308_I2S0_8CH_MCLK_OUT_SRC_FROM_TX | \
+       RK3308_I2S0_8CH_CLK_IN_RX_SRC_FROM_TX | \
+       RK3308_I2S0_8CH_CLK_IN_TX_SRC_FROM_TX)
+
+#define RK3308_I2S0_CLK_RXONLY \
+       (RK3308_I2S0_8CH_MCLK_OUT_SRC_FROM_RX | \
+       RK3308_I2S0_8CH_CLK_IN_RX_SRC_FROM_RX | \
+       RK3308_I2S0_8CH_CLK_IN_TX_SRC_FROM_RX)
+
+#define RK3308_I2S1_CLK_TXONLY \
+       (RK3308_I2S1_8CH_MCLK_OUT_SRC_FROM_TX | \
+       RK3308_I2S1_8CH_CLK_IN_RX_SRC_FROM_TX | \
+       RK3308_I2S1_8CH_CLK_IN_TX_SRC_FROM_TX)
+
+#define RK3308_I2S1_CLK_RXONLY \
+       (RK3308_I2S1_8CH_MCLK_OUT_SRC_FROM_RX | \
+       RK3308_I2S1_8CH_CLK_IN_RX_SRC_FROM_RX | \
+       RK3308_I2S1_8CH_CLK_IN_TX_SRC_FROM_RX)
+
+/* RK3568 GRF CONFIGS */
+#define RK3568_I2S1_MCLK_OUT_SRC_FROM_TX       HIWORD_UPDATE(1, 5, 5)
+#define RK3568_I2S1_MCLK_OUT_SRC_FROM_RX       HIWORD_UPDATE(0, 5, 5)
+
+#define RK3568_I2S1_CLK_TXONLY \
+       RK3568_I2S1_MCLK_OUT_SRC_FROM_TX
+
+#define RK3568_I2S1_CLK_RXONLY \
+       RK3568_I2S1_MCLK_OUT_SRC_FROM_RX
+
+#define RK3568_I2S3_MCLK_OUT_SRC_FROM_TX       HIWORD_UPDATE(1, 15, 15)
+#define RK3568_I2S3_MCLK_OUT_SRC_FROM_RX       HIWORD_UPDATE(0, 15, 15)
+#define RK3568_I2S3_SCLK_SRC_FROM_TX           HIWORD_UPDATE(1, 7, 7)
+#define RK3568_I2S3_SCLK_SRC_FROM_RX           HIWORD_UPDATE(0, 7, 7)
+#define RK3568_I2S3_LRCK_SRC_FROM_TX           HIWORD_UPDATE(1, 6, 6)
+#define RK3568_I2S3_LRCK_SRC_FROM_RX           HIWORD_UPDATE(0, 6, 6)
+
+#define RK3568_I2S3_MCLK_TXONLY \
+       RK3568_I2S3_MCLK_OUT_SRC_FROM_TX
+
+#define RK3568_I2S3_CLK_TXONLY \
+       (RK3568_I2S3_SCLK_SRC_FROM_TX | \
+       RK3568_I2S3_LRCK_SRC_FROM_TX)
+
+#define RK3568_I2S3_MCLK_RXONLY \
+       RK3568_I2S3_MCLK_OUT_SRC_FROM_RX
+
+#define RK3568_I2S3_CLK_RXONLY \
+       (RK3568_I2S3_SCLK_SRC_FROM_RX | \
+       RK3568_I2S3_LRCK_SRC_FROM_RX)
+
+#define RK3568_I2S3_MCLK_IE                    HIWORD_UPDATE(0, 3, 3)
+#define RK3568_I2S3_MCLK_OE                    HIWORD_UPDATE(1, 3, 3)
+#define RK3568_I2S2_MCLK_IE                    HIWORD_UPDATE(0, 2, 2)
+#define RK3568_I2S2_MCLK_OE                    HIWORD_UPDATE(1, 2, 2)
+#define RK3568_I2S1_MCLK_TX_IE                 HIWORD_UPDATE(0, 1, 1)
+#define RK3568_I2S1_MCLK_TX_OE                 HIWORD_UPDATE(1, 1, 1)
+#define RK3568_I2S1_MCLK_RX_IE                 HIWORD_UPDATE(0, 0, 0)
+#define RK3568_I2S1_MCLK_RX_OE                 HIWORD_UPDATE(1, 0, 0)
+
+/* RV1126 GRF CONFIGS */
+#define RV1126_I2S0_MCLK_OUT_SRC_FROM_TX       HIWORD_UPDATE(0, 9, 9)
+#define RV1126_I2S0_MCLK_OUT_SRC_FROM_RX       HIWORD_UPDATE(1, 9, 9)
+
+#define RV1126_I2S0_CLK_TXONLY \
+       RV1126_I2S0_MCLK_OUT_SRC_FROM_TX
+
+#define RV1126_I2S0_CLK_RXONLY \
+       RV1126_I2S0_MCLK_OUT_SRC_FROM_RX
+
+#endif /* _ROCKCHIP_I2S_TDM_H */
diff --git a/sound/soc/rockchip/rockchip_pcm.c b/sound/soc/rockchip/rockchip_pcm.c
deleted file mode 100644 (file)
index 02254e4..0000000
+++ /dev/null
@@ -1,44 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0-only
-/*
- * Copyright (c) 2018 Rockchip Electronics Co. Ltd.
- */
-
-#include <linux/device.h>
-#include <linux/init.h>
-#include <linux/module.h>
-
-#include <sound/core.h>
-#include <sound/pcm.h>
-#include <sound/soc.h>
-#include <sound/dmaengine_pcm.h>
-
-#include "rockchip_pcm.h"
-
-static const struct snd_pcm_hardware snd_rockchip_hardware = {
-       .info                   = SNDRV_PCM_INFO_MMAP |
-                                 SNDRV_PCM_INFO_MMAP_VALID |
-                                 SNDRV_PCM_INFO_PAUSE |
-                                 SNDRV_PCM_INFO_RESUME |
-                                 SNDRV_PCM_INFO_INTERLEAVED,
-       .period_bytes_min       = 32,
-       .period_bytes_max       = 8192,
-       .periods_min            = 1,
-       .periods_max            = 52,
-       .buffer_bytes_max       = 64 * 1024,
-       .fifo_size              = 32,
-};
-
-static const struct snd_dmaengine_pcm_config rk_dmaengine_pcm_config = {
-       .pcm_hardware = &snd_rockchip_hardware,
-       .prepare_slave_config = snd_dmaengine_pcm_prepare_slave_config,
-       .prealloc_buffer_size = 32 * 1024,
-};
-
-int rockchip_pcm_platform_register(struct device *dev)
-{
-       return devm_snd_dmaengine_pcm_register(dev, &rk_dmaengine_pcm_config,
-               SND_DMAENGINE_PCM_FLAG_COMPAT);
-}
-EXPORT_SYMBOL_GPL(rockchip_pcm_platform_register);
-
-MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/rockchip/rockchip_pcm.h b/sound/soc/rockchip/rockchip_pcm.h
deleted file mode 100644 (file)
index 7f00e2c..0000000
+++ /dev/null
@@ -1,11 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Copyright (c) 2018 Rockchip Electronics Co. Ltd.
- */
-
-#ifndef _ROCKCHIP_PCM_H
-#define _ROCKCHIP_PCM_H
-
-int rockchip_pcm_platform_register(struct device *dev);
-
-#endif
index 38bd603..64d9891 100644 (file)
 
 #define PDM_DMA_BURST_SIZE     (8) /* size * width: 8*4 = 32 bytes */
 #define PDM_SIGNOFF_CLK_RATE   (100000000)
+#define PDM_PATH_MAX           (4)
 
 enum rk_pdm_version {
        RK_PDM_RK3229,
        RK_PDM_RK3308,
+       RK_PDM_RV1126,
 };
 
 struct rk_pdm_dev {
@@ -121,6 +123,55 @@ static unsigned int get_pdm_ds_ratio(unsigned int sr)
        return ratio;
 }
 
+static unsigned int get_pdm_cic_ratio(unsigned int clk)
+{
+       switch (clk) {
+       case 4096000:
+       case 5644800:
+       case 6144000:
+               return 0;
+       case 2048000:
+       case 2822400:
+       case 3072000:
+               return 1;
+       case 1024000:
+       case 1411200:
+       case 1536000:
+               return 2;
+       default:
+               return 1;
+       }
+}
+
+static unsigned int samplerate_to_bit(unsigned int samplerate)
+{
+       switch (samplerate) {
+       case 8000:
+       case 11025:
+       case 12000:
+               return 0;
+       case 16000:
+       case 22050:
+       case 24000:
+               return 1;
+       case 32000:
+               return 2;
+       case 44100:
+       case 48000:
+               return 3;
+       case 64000:
+       case 88200:
+       case 96000:
+               return 4;
+       case 128000:
+       case 176400:
+       case 192000:
+               return 5;
+       default:
+               return 1;
+       }
+}
+
 static inline struct rk_pdm_dev *to_info(struct snd_soc_dai *dai)
 {
        return snd_soc_dai_get_drvdata(dai);
@@ -166,7 +217,8 @@ static int rockchip_pdm_hw_params(struct snd_pcm_substream *substream,
        if (ret)
                return -EINVAL;
 
-       if (pdm->version == RK_PDM_RK3308) {
+       if (pdm->version == RK_PDM_RK3308 ||
+           pdm->version == RK_PDM_RV1126) {
                rational_best_approximation(clk_out, clk_src,
                                            GENMASK(16 - 1, 0),
                                            GENMASK(16 - 1, 0),
@@ -194,8 +246,18 @@ static int rockchip_pdm_hw_params(struct snd_pcm_substream *substream,
                                   PDM_CLK_FD_RATIO_MSK,
                                   val);
        }
-       val = get_pdm_ds_ratio(samplerate);
-       regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, PDM_DS_RATIO_MSK, val);
+
+       if (pdm->version == RK_PDM_RV1126) {
+               val = get_pdm_cic_ratio(clk_out);
+               regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, PDM_CIC_RATIO_MSK, val);
+               val = samplerate_to_bit(samplerate);
+               regmap_update_bits(pdm->regmap, PDM_CTRL0,
+                                  PDM_SAMPLERATE_MSK, PDM_SAMPLERATE(val));
+       } else {
+               val = get_pdm_ds_ratio(samplerate);
+               regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, PDM_DS_RATIO_MSK, val);
+       }
+
        regmap_update_bits(pdm->regmap, PDM_HPF_CTRL,
                           PDM_HPF_CF_MSK, PDM_HPF_60HZ);
        regmap_update_bits(pdm->regmap, PDM_HPF_CTRL,
@@ -441,9 +503,10 @@ static bool rockchip_pdm_precious_reg(struct device *dev, unsigned int reg)
 }
 
 static const struct reg_default rockchip_pdm_reg_defaults[] = {
-       {0x04, 0x78000017},
-       {0x08, 0x0bb8ea60},
-       {0x18, 0x0000001f},
+       { PDM_CTRL0, 0x78000017 },
+       { PDM_CTRL1, 0x0bb8ea60 },
+       { PDM_CLK_CTRL, 0x0000e401 },
+       { PDM_DMA_CTRL, 0x0000001f },
 };
 
 static const struct regmap_config rockchip_pdm_regmap_config = {
@@ -469,12 +532,44 @@ static const struct of_device_id rockchip_pdm_match[] __maybe_unused = {
          .data = (void *)RK_PDM_RK3308 },
        { .compatible = "rockchip,rk3308-pdm",
          .data = (void *)RK_PDM_RK3308 },
+       { .compatible = "rockchip,rk3568-pdm",
+         .data = (void *)RK_PDM_RV1126 },
+       { .compatible = "rockchip,rv1126-pdm",
+         .data = (void *)RK_PDM_RV1126 },
        {},
 };
 MODULE_DEVICE_TABLE(of, rockchip_pdm_match);
 
+static int rockchip_pdm_path_parse(struct rk_pdm_dev *pdm, struct device_node *node)
+{
+       unsigned int path[PDM_PATH_MAX];
+       int cnt = 0, ret = 0, i = 0, val = 0, msk = 0;
+
+       cnt = of_count_phandle_with_args(node, "rockchip,path-map",
+                                        NULL);
+       if (cnt != PDM_PATH_MAX)
+               return cnt;
+
+       ret = of_property_read_u32_array(node, "rockchip,path-map",
+                                        path, cnt);
+       if (ret)
+               return ret;
+
+       for (i = 0; i < cnt; i++) {
+               if (path[i] >= PDM_PATH_MAX)
+                       return -EINVAL;
+               msk |= PDM_PATH_MASK(i);
+               val |= PDM_PATH(i, path[i]);
+       }
+
+       regmap_update_bits(pdm->regmap, PDM_CLK_CTRL, msk, val);
+
+       return 0;
+}
+
 static int rockchip_pdm_probe(struct platform_device *pdev)
 {
+       struct device_node *node = pdev->dev.of_node;
        const struct of_device_id *match;
        struct rk_pdm_dev *pdm;
        struct resource *res;
@@ -540,6 +635,11 @@ static int rockchip_pdm_probe(struct platform_device *pdev)
        }
 
        rockchip_pdm_rxctrl(pdm, 0);
+
+       ret = rockchip_pdm_path_parse(pdm, node);
+       if (ret != 0 && ret != -ENOENT)
+               goto err_suspend;
+
        ret = devm_snd_dmaengine_pcm_register(&pdev->dev, NULL, 0);
        if (ret) {
                dev_err(&pdev->dev, "could not register pcm: %d\n", ret);
index 8e5bbaf..cab9772 100644 (file)
@@ -41,6 +41,8 @@
 #define PDM_PATH1_EN           BIT(28)
 #define PDM_PATH0_EN           BIT(27)
 #define PDM_HWT_EN             BIT(26)
+#define PDM_SAMPLERATE_MSK     GENMASK(7, 5)
+#define PDM_SAMPLERATE(x)      ((x) << 5)
 #define PDM_VDW_MSK            (0x1f << 0)
 #define PDM_VDW(X)             ((X - 1) << 0)
 
@@ -51,6 +53,9 @@
 #define PDM_FD_DENOMINATOR_MSK GENMASK(15, 0)
 
 /* PDM CLK CTRL */
+#define PDM_PATH_SHIFT(x)      (8 + (x) * 2)
+#define PDM_PATH_MASK(x)       (0x3 << PDM_PATH_SHIFT(x))
+#define PDM_PATH(x, v)         ((v) << PDM_PATH_SHIFT(x))
 #define PDM_CLK_FD_RATIO_MSK   BIT(6)
 #define PDM_CLK_FD_RATIO_40    (0X0 << 6)
 #define PDM_CLK_FD_RATIO_35    BIT(6)
@@ -66,6 +71,7 @@
 #define PDM_CLK_1280FS         (0x2 << 0)
 #define PDM_CLK_2560FS         (0x3 << 0)
 #define PDM_CLK_5120FS         (0x4 << 0)
+#define PDM_CIC_RATIO_MSK      (0x3 << 0)
 
 /* PDM HPF CTRL */
 #define PDM_HPF_LE             BIT(3)
index e948118..de66cc4 100644 (file)
@@ -397,6 +397,8 @@ static int s3c2412_i2s_trigger(struct snd_pcm_substream *substream, int cmd,
                /* clear again, just in case */
                writel(0x0, i2s->regs + S3C2412_IISFIC);
 
+               fallthrough;
+
        case SNDRV_PCM_TRIGGER_RESUME:
        case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
                if (!i2s->master) {
index 978bd04..6a8fe0d 100644 (file)
@@ -1225,6 +1225,7 @@ int rsnd_node_count(struct rsnd_priv *priv, struct device_node *node, char *name
                if (i < 0) {
                        dev_err(dev, "strange node numbering (%s)",
                                of_node_full_name(node));
+                       of_node_put(np);
                        return 0;
                }
                i++;
index 395229b..2ae99b4 100644 (file)
@@ -8,14 +8,34 @@
 #include <linux/module.h>
 #include <sound/soc-acpi.h>
 
+static bool snd_soc_acpi_id_present(struct snd_soc_acpi_mach *machine)
+{
+       const struct snd_soc_acpi_codecs *comp_ids = machine->comp_ids;
+       int i;
+
+       if (machine->id[0]) {
+               if (acpi_dev_present(machine->id, NULL, -1))
+                       return true;
+       }
+
+       if (comp_ids) {
+               for (i = 0; i < comp_ids->num_codecs; i++) {
+                       if (acpi_dev_present(comp_ids->codecs[i], NULL, -1))
+                               return true;
+               }
+       }
+
+       return false;
+}
+
 struct snd_soc_acpi_mach *
 snd_soc_acpi_find_machine(struct snd_soc_acpi_mach *machines)
 {
        struct snd_soc_acpi_mach *mach;
        struct snd_soc_acpi_mach *mach_alt;
 
-       for (mach = machines; mach->id[0]; mach++) {
-               if (acpi_dev_present(mach->id, NULL, -1)) {
+       for (mach = machines; mach->id[0] || mach->comp_ids; mach++) {
+               if (snd_soc_acpi_id_present(mach)) {
                        if (mach->machine_quirk) {
                                mach_alt = mach->machine_quirk(mach);
                                if (!mach_alt)
index 8e8d917..c76ff9c 100644 (file)
 #include <sound/soc.h>
 #include <linux/bitops.h>
 
-#define soc_component_ret(dai, ret) _soc_component_ret(dai, __func__, ret)
+#define soc_component_ret(dai, ret) _soc_component_ret(dai, __func__, ret, -1)
+#define soc_component_ret_reg_rw(dai, ret, reg) _soc_component_ret(dai, __func__, ret, reg)
 static inline int _soc_component_ret(struct snd_soc_component *component,
-                                    const char *func, int ret)
+                                    const char *func, int ret, int reg)
 {
        /* Positive/Zero values are not errors */
        if (ret >= 0)
@@ -27,9 +28,14 @@ static inline int _soc_component_ret(struct snd_soc_component *component,
        case -ENOTSUPP:
                break;
        default:
-               dev_err(component->dev,
-                       "ASoC: error at %s on %s: %d\n",
-                       func, component->name, ret);
+               if (reg == -1)
+                       dev_err(component->dev,
+                               "ASoC: error at %s on %s: %d\n",
+                               func, component->name, ret);
+               else
+                       dev_err(component->dev,
+                               "ASoC: error at %s on %s for register: [0x%08x] %d\n",
+                               func, component->name, reg, ret);
        }
 
        return ret;
@@ -251,8 +257,7 @@ int snd_soc_component_set_jack(struct snd_soc_component *component,
 EXPORT_SYMBOL_GPL(snd_soc_component_set_jack);
 
 int snd_soc_component_module_get(struct snd_soc_component *component,
-                                struct snd_pcm_substream *substream,
-                                int upon_open)
+                                void *mark, int upon_open)
 {
        int ret = 0;
 
@@ -260,25 +265,24 @@ int snd_soc_component_module_get(struct snd_soc_component *component,
            !try_module_get(component->dev->driver->owner))
                ret = -ENODEV;
 
-       /* mark substream if succeeded */
+       /* mark module if succeeded */
        if (ret == 0)
-               soc_component_mark_push(component, substream, module);
+               soc_component_mark_push(component, mark, module);
 
        return soc_component_ret(component, ret);
 }
 
 void snd_soc_component_module_put(struct snd_soc_component *component,
-                                 struct snd_pcm_substream *substream,
-                                 int upon_open, int rollback)
+                                 void *mark, int upon_open, int rollback)
 {
-       if (rollback && !soc_component_mark_match(component, substream, module))
+       if (rollback && !soc_component_mark_match(component, mark, module))
                return;
 
        if (component->driver->module_get_upon_open == !!upon_open)
                module_put(component->dev->driver->owner);
 
-       /* remove marked substream */
-       soc_component_mark_pop(component, substream, module);
+       /* remove the mark from module */
+       soc_component_mark_pop(component, mark, module);
 }
 
 int snd_soc_component_open(struct snd_soc_component *component,
@@ -425,43 +429,36 @@ EXPORT_SYMBOL_GPL(snd_soc_component_exit_regmap);
 
 #endif
 
-int snd_soc_component_compr_open(struct snd_compr_stream *cstream)
+int snd_soc_component_compr_open(struct snd_soc_component *component,
+                                struct snd_compr_stream *cstream)
 {
-       struct snd_soc_pcm_runtime *rtd = cstream->private_data;
-       struct snd_soc_component *component;
-       int i, ret;
+       int ret = 0;
 
-       for_each_rtd_components(rtd, i, component) {
-               if (component->driver->compress_ops &&
-                   component->driver->compress_ops->open) {
-                       ret = component->driver->compress_ops->open(component, cstream);
-                       if (ret < 0)
-                               return soc_component_ret(component, ret);
-               }
+       if (component->driver->compress_ops &&
+           component->driver->compress_ops->open)
+               ret = component->driver->compress_ops->open(component, cstream);
+
+       /* mark substream if succeeded */
+       if (ret == 0)
                soc_component_mark_push(component, cstream, compr_open);
-       }
 
-       return 0;
+       return soc_component_ret(component, ret);
 }
 EXPORT_SYMBOL_GPL(snd_soc_component_compr_open);
 
-void snd_soc_component_compr_free(struct snd_compr_stream *cstream,
+void snd_soc_component_compr_free(struct snd_soc_component *component,
+                                 struct snd_compr_stream *cstream,
                                  int rollback)
 {
-       struct snd_soc_pcm_runtime *rtd = cstream->private_data;
-       struct snd_soc_component *component;
-       int i;
-
-       for_each_rtd_components(rtd, i, component) {
-               if (rollback && !soc_component_mark_match(component, cstream, compr_open))
-                       continue;
+       if (rollback && !soc_component_mark_match(component, cstream, compr_open))
+               return;
 
-               if (component->driver->compress_ops &&
-                   component->driver->compress_ops->free)
-                       component->driver->compress_ops->free(component, cstream);
+       if (component->driver->compress_ops &&
+           component->driver->compress_ops->free)
+               component->driver->compress_ops->free(component, cstream);
 
-               soc_component_mark_pop(component, cstream, compr_open);
-       }
+       /* remove marked substream */
+       soc_component_mark_pop(component, cstream, compr_open);
 }
 EXPORT_SYMBOL_GPL(snd_soc_component_compr_free);
 
@@ -696,7 +693,7 @@ static unsigned int soc_component_read_no_lock(
                ret = -EIO;
 
        if (ret < 0)
-               return soc_component_ret(component, ret);
+               return soc_component_ret_reg_rw(component, ret, reg);
 
        return val;
 }
@@ -732,7 +729,7 @@ static int soc_component_write_no_lock(
        else if (component->driver->write)
                ret = component->driver->write(component, reg, val);
 
-       return soc_component_ret(component, ret);
+       return soc_component_ret_reg_rw(component, ret, reg);
 }
 
 /**
@@ -774,7 +771,7 @@ static int snd_soc_component_update_bits_legacy(
 
        mutex_unlock(&component->io_mutex);
 
-       return soc_component_ret(component, ret);
+       return soc_component_ret_reg_rw(component, ret, reg);
 }
 
 /**
@@ -802,7 +799,7 @@ int snd_soc_component_update_bits(struct snd_soc_component *component,
                                                           mask, val, &change);
 
        if (ret < 0)
-               return soc_component_ret(component, ret);
+               return soc_component_ret_reg_rw(component, ret, reg);
        return change;
 }
 EXPORT_SYMBOL_GPL(snd_soc_component_update_bits);
@@ -838,7 +835,7 @@ int snd_soc_component_update_bits_async(struct snd_soc_component *component,
                                                           mask, val, &change);
 
        if (ret < 0)
-               return soc_component_ret(component, ret);
+               return soc_component_ret_reg_rw(component, ret, reg);
        return change;
 }
 EXPORT_SYMBOL_GPL(snd_soc_component_update_bits_async);
index 3606080..8e2494a 100644 (file)
 #include <sound/soc-link.h>
 #include <linux/pm_runtime.h>
 
+static int snd_soc_compr_components_open(struct snd_compr_stream *cstream)
+{
+       struct snd_soc_pcm_runtime *rtd = cstream->private_data;
+       struct snd_soc_component *component;
+       int ret = 0;
+       int i;
+
+       for_each_rtd_components(rtd, i, component) {
+               ret = snd_soc_component_module_get_when_open(component, cstream);
+               if (ret < 0)
+                       break;
+
+               ret = snd_soc_component_compr_open(component, cstream);
+               if (ret < 0)
+                       break;
+       }
+
+       return ret;
+}
+
+static void snd_soc_compr_components_free(struct snd_compr_stream *cstream,
+                                         int rollback)
+{
+       struct snd_soc_pcm_runtime *rtd = cstream->private_data;
+       struct snd_soc_component *component;
+       int i;
+
+       for_each_rtd_components(rtd, i, component) {
+               snd_soc_component_compr_free(component, cstream, rollback);
+               snd_soc_component_module_put_when_close(component, cstream, rollback);
+       }
+}
+
 static int soc_compr_clean(struct snd_compr_stream *cstream, int rollback)
 {
        struct snd_soc_pcm_runtime *rtd = cstream->private_data;
@@ -44,7 +77,7 @@ static int soc_compr_clean(struct snd_compr_stream *cstream, int rollback)
 
        snd_soc_link_compr_shutdown(cstream, rollback);
 
-       snd_soc_component_compr_free(cstream, rollback);
+       snd_soc_compr_components_free(cstream, rollback);
 
        snd_soc_dai_compr_shutdown(cpu_dai, cstream, rollback);
 
@@ -80,7 +113,7 @@ static int soc_compr_open(struct snd_compr_stream *cstream)
        if (ret < 0)
                goto err;
 
-       ret = snd_soc_component_compr_open(cstream);
+       ret = snd_soc_compr_components_open(cstream);
        if (ret < 0)
                goto err;
 
@@ -137,7 +170,7 @@ static int soc_compr_open_fe(struct snd_compr_stream *cstream)
        if (ret < 0)
                goto out;
 
-       ret = snd_soc_component_compr_open(cstream);
+       ret = snd_soc_compr_components_open(cstream);
        if (ret < 0)
                goto open_err;
 
@@ -160,7 +193,7 @@ static int soc_compr_open_fe(struct snd_compr_stream *cstream)
        return 0;
 
 machine_err:
-       snd_soc_component_compr_free(cstream, 1);
+       snd_soc_compr_components_free(cstream, 1);
 open_err:
        snd_soc_dai_compr_shutdown(cpu_dai, cstream, 1);
 out:
@@ -205,7 +238,7 @@ static int soc_compr_free_fe(struct snd_compr_stream *cstream)
 
        snd_soc_link_compr_shutdown(cstream, 0);
 
-       snd_soc_component_compr_free(cstream, 0);
+       snd_soc_compr_components_free(cstream, 0);
 
        snd_soc_dai_compr_shutdown(cpu_dai, cstream, 0);
 
index 80ca260..dcf6be4 100644 (file)
@@ -229,31 +229,12 @@ static void snd_soc_debugfs_exit(void)
 
 #else
 
-static inline void soc_init_component_debugfs(
-       struct snd_soc_component *component)
-{
-}
-
-static inline void soc_cleanup_component_debugfs(
-       struct snd_soc_component *component)
-{
-}
-
-static inline void soc_init_card_debugfs(struct snd_soc_card *card)
-{
-}
-
-static inline void soc_cleanup_card_debugfs(struct snd_soc_card *card)
-{
-}
-
-static inline void snd_soc_debugfs_init(void)
-{
-}
-
-static inline void snd_soc_debugfs_exit(void)
-{
-}
+static inline void soc_init_component_debugfs(struct snd_soc_component *component) { }
+static inline void soc_cleanup_component_debugfs(struct snd_soc_component *component) { }
+static inline void soc_init_card_debugfs(struct snd_soc_card *card) { }
+static inline void soc_cleanup_card_debugfs(struct snd_soc_card *card) { }
+static inline void snd_soc_debugfs_init(void) { }
+static inline void snd_soc_debugfs_exit(void) { }
 
 #endif
 
@@ -739,9 +720,7 @@ static void soc_resume_init(struct snd_soc_card *card)
 #else
 #define snd_soc_suspend NULL
 #define snd_soc_resume NULL
-static inline void soc_resume_init(struct snd_soc_card *card)
-{
-}
+static inline void soc_resume_init(struct snd_soc_card *card) { }
 #endif
 
 static struct device_node
@@ -1239,6 +1218,9 @@ int snd_soc_runtime_set_dai_fmt(struct snd_soc_pcm_runtime *rtd,
        unsigned int i;
        int ret;
 
+       if (!dai_fmt)
+               return 0;
+
        for_each_rtd_codec_dais(rtd, i, codec_dai) {
                ret = snd_soc_dai_set_fmt(codec_dai, dai_fmt);
                if (ret != 0 && ret != -ENOTSUPP)
@@ -1247,14 +1229,13 @@ int snd_soc_runtime_set_dai_fmt(struct snd_soc_pcm_runtime *rtd,
 
        /*
         * Flip the polarity for the "CPU" end of a CODEC<->CODEC link
-        * the component which has non_legacy_dai_naming is Codec
         */
        inv_dai_fmt = snd_soc_daifmt_clock_provider_fliped(dai_fmt);
 
        for_each_rtd_cpu_dais(rtd, i, cpu_dai) {
                unsigned int fmt = dai_fmt;
 
-               if (cpu_dai->component->driver->non_legacy_dai_naming)
+               if (snd_soc_component_is_codec(cpu_dai->component))
                        fmt = inv_dai_fmt;
 
                ret = snd_soc_dai_set_fmt(cpu_dai, fmt);
@@ -1283,11 +1264,9 @@ static int soc_init_pcm_runtime(struct snd_soc_card *card,
                return ret;
 
        snd_soc_runtime_get_dai_fmt(rtd);
-       if (dai_link->dai_fmt) {
-               ret = snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt);
-               if (ret)
-                       return ret;
-       }
+       ret = snd_soc_runtime_set_dai_fmt(rtd, dai_link->dai_fmt);
+       if (ret)
+               return ret;
 
        /* add DPCM sysfs entries */
        soc_dpcm_debugfs_add(rtd);
@@ -1363,9 +1342,6 @@ static void soc_remove_component(struct snd_soc_component *component,
        if (probed)
                snd_soc_component_remove(component);
 
-       /* For framework level robustness */
-       snd_soc_component_set_jack(component, NULL, NULL);
-
        list_del_init(&component->card_list);
        snd_soc_dapm_free(snd_soc_component_get_dapm(component));
        soc_cleanup_component_debugfs(component);
@@ -2521,7 +2497,7 @@ static int snd_soc_register_dais(struct snd_soc_component *component,
 
        for (i = 0; i < count; i++) {
                dai = snd_soc_register_dai(component, dai_drv + i, count == 1 &&
-                                 !component->driver->non_legacy_dai_naming);
+                                          !snd_soc_component_is_codec(component));
                if (dai == NULL) {
                        ret = -ENOMEM;
                        goto err;
index 59d0764..2892b0a 100644 (file)
@@ -1331,11 +1331,13 @@ int snd_soc_dapm_dai_get_connected_widgets(struct snd_soc_dai *dai, int stream,
 
        return paths;
 }
+EXPORT_SYMBOL_GPL(snd_soc_dapm_dai_get_connected_widgets);
 
 void snd_soc_dapm_dai_free_widgets(struct snd_soc_dapm_widget_list **list)
 {
        dapm_widget_list_free(list);
 }
+EXPORT_SYMBOL_GPL(snd_soc_dapm_dai_free_widgets);
 
 /*
  * Handler for regulator supply widget.
index 4aa48c7..c54c8ca 100644 (file)
 
 #include <sound/dmaengine_pcm.h>
 
+static unsigned int prealloc_buffer_size_kbytes = 512;
+module_param(prealloc_buffer_size_kbytes, uint, 0444);
+MODULE_PARM_DESC(prealloc_buffer_size_kbytes, "Preallocate DMA buffer size (KB).");
+
 /*
  * The platforms dmaengine driver does not support reporting the amount of
  * bytes that are still left to transfer.
@@ -237,7 +241,7 @@ static int dmaengine_pcm_new(struct snd_soc_component *component,
                prealloc_buffer_size = config->prealloc_buffer_size;
                max_buffer_size = config->pcm_hardware->buffer_bytes_max;
        } else {
-               prealloc_buffer_size = 512 * 1024;
+               prealloc_buffer_size = prealloc_buffer_size_kbytes * 1024;
                max_buffer_size = SIZE_MAX;
        }
 
index 48f71bb..4d41ad3 100644 (file)
@@ -879,12 +879,10 @@ static int soc_pcm_hw_clean(struct snd_pcm_substream *substream, int rollback)
 
        /* clear the corresponding DAIs parameters when going to be inactive */
        for_each_rtd_dais(rtd, i, dai) {
-               int active = snd_soc_dai_stream_active(dai, substream->stream);
-
                if (snd_soc_dai_active(dai) == 1)
                        soc_pcm_set_dai_params(dai, NULL);
 
-               if (active == 1)
+               if (snd_soc_dai_stream_active(dai, substream->stream) == 1)
                        snd_soc_dai_digital_mute(dai, 1, substream->stream);
        }
 
@@ -898,12 +896,9 @@ static int soc_pcm_hw_clean(struct snd_pcm_substream *substream, int rollback)
        snd_soc_pcm_component_hw_free(substream, rollback);
 
        /* now free hw params for the DAIs  */
-       for_each_rtd_dais(rtd, i, dai) {
-               if (!snd_soc_dai_stream_valid(dai, substream->stream))
-                       continue;
-
-               snd_soc_dai_hw_free(dai, substream, rollback);
-       }
+       for_each_rtd_dais(rtd, i, dai)
+               if (snd_soc_dai_stream_valid(dai, substream->stream))
+                       snd_soc_dai_hw_free(dai, substream, rollback);
 
        mutex_unlock(&rtd->card->pcm_mutex);
        return 0;
@@ -1262,8 +1257,7 @@ static int widget_in_list(struct snd_soc_dapm_widget_list *list,
        return 0;
 }
 
-static bool dpcm_end_walk_at_be(struct snd_soc_dapm_widget *widget,
-               enum snd_soc_dapm_direction dir)
+bool dpcm_end_walk_at_be(struct snd_soc_dapm_widget *widget, enum snd_soc_dapm_direction dir)
 {
        struct snd_soc_card *card = widget->dapm->card;
        struct snd_soc_pcm_runtime *rtd;
@@ -1281,6 +1275,7 @@ static bool dpcm_end_walk_at_be(struct snd_soc_dapm_widget *widget,
 
        return false;
 }
+EXPORT_SYMBOL_GPL(dpcm_end_walk_at_be);
 
 int dpcm_path_get(struct snd_soc_pcm_runtime *fe,
        int stream, struct snd_soc_dapm_widget_list **list)
@@ -1395,6 +1390,16 @@ static int dpcm_add_paths(struct snd_soc_pcm_runtime *fe, int stream,
                if (!fe->dpcm[stream].runtime && !fe->fe_compr)
                        continue;
 
+               /*
+                * Filter for systems with 'component_chaining' enabled.
+                * This helps to avoid unnecessary re-configuration of an
+                * already active BE on such systems.
+                */
+               if (fe->card->component_chaining &&
+                   (be->dpcm[stream].state != SND_SOC_DPCM_STATE_NEW) &&
+                   (be->dpcm[stream].state != SND_SOC_DPCM_STATE_CLOSE))
+                       continue;
+
                /* newly connected FE and BE */
                err = dpcm_be_connect(fe, be, stream);
                if (err < 0) {
index f6e5ac3..557e22c 100644 (file)
@@ -78,7 +78,7 @@ struct soc_tplg {
 };
 
 static int soc_tplg_process_headers(struct soc_tplg *tplg);
-static void soc_tplg_complete(struct soc_tplg *tplg);
+static int soc_tplg_complete(struct soc_tplg *tplg);
 
 /* check we dont overflow the data for this control chunk */
 static int soc_tplg_check_elem_count(struct soc_tplg *tplg, size_t elem_size,
@@ -312,10 +312,12 @@ static int soc_tplg_dai_link_load(struct soc_tplg *tplg,
 }
 
 /* tell the component driver that all firmware has been loaded in this request */
-static void soc_tplg_complete(struct soc_tplg *tplg)
+static int soc_tplg_complete(struct soc_tplg *tplg)
 {
        if (tplg->ops && tplg->ops->complete)
-               tplg->ops->complete(tplg->comp);
+               return tplg->ops->complete(tplg->comp);
+
+       return 0;
 }
 
 /* add a dynamic kcontrol */
@@ -349,7 +351,7 @@ static int soc_tplg_add_kcontrol(struct soc_tplg *tplg,
        struct snd_soc_component *comp = tplg->comp;
 
        return soc_tplg_add_dcontrol(comp->card->snd_card,
-                               comp->dev, k, comp->name_prefix, comp, kcontrol);
+                               tplg->dev, k, comp->name_prefix, comp, kcontrol);
 }
 
 /* remove a mixer kcontrol */
@@ -1473,10 +1475,6 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
                goto widget;
        }
 
-       control_hdr = (struct snd_soc_tplg_ctl_hdr *)tplg->pos;
-       dev_dbg(tplg->dev, "ASoC: template %s has %d controls of type %x\n",
-               w->name, w->num_kcontrols, control_hdr->type);
-
        template.num_kcontrols = le32_to_cpu(w->num_kcontrols);
        kc = devm_kcalloc(tplg->dev, le32_to_cpu(w->num_kcontrols), sizeof(*kc), GFP_KERNEL);
        if (!kc)
@@ -1487,7 +1485,7 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
        if (!kcontrol_type)
                goto err;
 
-       for (i = 0; i < w->num_kcontrols; i++) {
+       for (i = 0; i < le32_to_cpu(w->num_kcontrols); i++) {
                control_hdr = (struct snd_soc_tplg_ctl_hdr *)tplg->pos;
                switch (le32_to_cpu(control_hdr->ops.info)) {
                case SND_SOC_TPLG_CTL_VOLSW:
@@ -1536,6 +1534,8 @@ static int soc_tplg_dapm_widget_create(struct soc_tplg *tplg,
        }
 
        template.kcontrol_news = kc;
+       dev_dbg(tplg->dev, "ASoC: template %s with %d/%d/%d (mixer/enum/bytes) control\n",
+               w->name, mixer_count, enum_count, bytes_count);
 
 widget:
        ret = soc_tplg_widget_load(tplg, &template, w);
@@ -1591,11 +1591,28 @@ static int soc_tplg_dapm_widget_elems_load(struct soc_tplg *tplg,
                struct snd_soc_tplg_dapm_widget *widget = (struct snd_soc_tplg_dapm_widget *) tplg->pos;
                int ret;
 
+               /*
+                * check if widget itself fits within topology file
+                * use sizeof instead of widget->size, as we can't be sure
+                * it is set properly yet (file may end before it is present)
+                */
+               if (soc_tplg_get_offset(tplg) + sizeof(*widget) >= tplg->fw->size) {
+                       dev_err(tplg->dev, "ASoC: invalid widget data size\n");
+                       return -EINVAL;
+               }
+
+               /* check if widget has proper size */
                if (le32_to_cpu(widget->size) != sizeof(*widget)) {
                        dev_err(tplg->dev, "ASoC: invalid widget size\n");
                        return -EINVAL;
                }
 
+               /* check if widget private data fits within topology file */
+               if (soc_tplg_get_offset(tplg) + le32_to_cpu(widget->priv.size) >= tplg->fw->size) {
+                       dev_err(tplg->dev, "ASoC: invalid widget private data size\n");
+                       return -EINVAL;
+               }
+
                ret = soc_tplg_dapm_widget_create(tplg, widget);
                if (ret < 0) {
                        dev_err(tplg->dev, "ASoC: failed to load widget %s\n",
@@ -2438,6 +2455,7 @@ static int soc_tplg_manifest_load(struct soc_tplg *tplg,
                _manifest = manifest;
        } else {
                abi_match = false;
+
                ret = manifest_new_ver(tplg, manifest, &_manifest);
                if (ret < 0)
                        return ret;
@@ -2468,6 +2486,14 @@ static int soc_valid_header(struct soc_tplg *tplg,
                return -EINVAL;
        }
 
+       if (soc_tplg_get_hdr_offset(tplg) + hdr->payload_size >= tplg->fw->size) {
+               dev_err(tplg->dev,
+                       "ASoC: invalid header of type %d at offset %ld payload_size %d\n",
+                       le32_to_cpu(hdr->type), soc_tplg_get_hdr_offset(tplg),
+                       hdr->payload_size);
+               return -EINVAL;
+       }
+
        /* big endian firmware objects not supported atm */
        if (le32_to_cpu(hdr->magic) == SOC_TPLG_MAGIC_BIG_ENDIAN) {
                dev_err(tplg->dev,
@@ -2627,7 +2653,7 @@ static int soc_tplg_load(struct soc_tplg *tplg)
 
        ret = soc_tplg_process_headers(tplg);
        if (ret == 0)
-               soc_tplg_complete(tplg);
+               return soc_tplg_complete(tplg);
 
        return ret;
 }
@@ -2642,17 +2668,17 @@ int snd_soc_tplg_component_load(struct snd_soc_component *comp,
        /*
         * check if we have sane parameters:
         * comp - needs to exist to keep and reference data while parsing
-        * comp->dev - used for resource management and prints
         * comp->card - used for setting card related parameters
+        * comp->card->dev - used for resource management and prints
         * fw - we need it, as it is the very thing we parse
         */
-       if (!comp || !comp->dev || !comp->card || !fw)
+       if (!comp || !comp->card || !comp->card->dev || !fw)
                return -EINVAL;
 
        /* setup parsing context */
        memset(&tplg, 0, sizeof(tplg));
        tplg.fw = fw;
-       tplg.dev = comp->dev;
+       tplg.dev = comp->card->dev;
        tplg.comp = comp;
        if (ops) {
                tplg.ops = ops;
index 299b5d6..a4efe7e 100644 (file)
@@ -63,10 +63,23 @@ static const struct snd_pcm_hardware dummy_dma_hardware = {
        .periods_max            = 128,
 };
 
+
+static const struct snd_soc_component_driver dummy_platform;
+
 static int dummy_dma_open(struct snd_soc_component *component,
                          struct snd_pcm_substream *substream)
 {
        struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
+       int i;
+
+       /*
+        * If there are other components associated with rtd, we shouldn't
+        * override their hwparams
+        */
+       for_each_rtd_components(rtd, i, component) {
+               if (component->driver == &dummy_platform)
+                       return 0;
+       }
 
        /* BE's dont need dummy params */
        if (!rtd->dai_link->no_pcm)
index cd65949..6bb4db8 100644 (file)
@@ -1,5 +1,5 @@
 # SPDX-License-Identifier: GPL-2.0-only
-config SND_SOC_SOF_TOPLEVEL
+menuconfig SND_SOC_SOF_TOPLEVEL
        bool "Sound Open Firmware Support"
        help
          This adds support for Sound Open Firmware (SOF). SOF is free and
@@ -46,6 +46,10 @@ config SND_SOC_SOF_OF
          required to enable i.MX8 devices.
          Say Y if you need this option. If unsure select "N".
 
+config SND_SOC_SOF_COMPRESS
+       tristate
+       select SND_SOC_COMPRESS
+
 config SND_SOC_SOF_DEBUG_PROBES
        bool "SOF enable data probing"
        select SND_SOC_COMPRESS
index 606d813..06e5f49 100644 (file)
@@ -1,8 +1,10 @@
 # SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
 
 snd-sof-objs := core.o ops.o loader.o ipc.o pcm.o pm.o debug.o topology.o\
-               control.o trace.o utils.o sof-audio.o
-snd-sof-$(CONFIG_SND_SOC_SOF_DEBUG_PROBES) += probe.o compress.o
+               control.o trace.o utils.o sof-audio.o stream-ipc.o
+
+snd-sof-$(CONFIG_SND_SOC_SOF_DEBUG_PROBES) += sof-probes.o
+snd-sof-$(CONFIG_SND_SOC_SOF_COMPRESS) += compress.o
 
 snd-sof-pci-objs := sof-pci-dev.o
 snd-sof-acpi-objs := sof-acpi-dev.o
index 57d5bf0..01ca85f 100644 (file)
 // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
 //
-// This file is provided under a dual BSD/GPLv2 license.  When using or
-// redistributing this file, you may do so under either license.
-//
-// Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
-//
-// Author: Cezary Rojewski <cezary.rojewski@intel.com>
+// Copyright 2021 NXP
 //
+// Author: Daniel Baluta <daniel.baluta@nxp.com>
 
 #include <sound/soc.h>
-#include "compress.h"
-#include "ops.h"
-#include "probe.h"
-
-const struct snd_compress_ops sof_probe_compressed_ops = {
-       .copy           = sof_probe_compr_copy,
-};
-EXPORT_SYMBOL(sof_probe_compressed_ops);
-
-int sof_probe_compr_open(struct snd_compr_stream *cstream,
-               struct snd_soc_dai *dai)
-{
-       struct snd_sof_dev *sdev =
-                               snd_soc_component_get_drvdata(dai->component);
-       int ret;
-
-       ret = snd_sof_probe_compr_assign(sdev, cstream, dai);
-       if (ret < 0) {
-               dev_err(dai->dev, "Failed to assign probe stream: %d\n", ret);
-               return ret;
-       }
+#include <sound/sof.h>
+#include <sound/compress_driver.h>
+#include "sof-audio.h"
+#include "sof-priv.h"
 
-       sdev->extractor_stream_tag = ret;
-       return 0;
-}
-EXPORT_SYMBOL(sof_probe_compr_open);
-
-int sof_probe_compr_free(struct snd_compr_stream *cstream,
-               struct snd_soc_dai *dai)
+static void snd_sof_compr_fragment_elapsed_work(struct work_struct *work)
 {
-       struct snd_sof_dev *sdev =
-                               snd_soc_component_get_drvdata(dai->component);
-       struct sof_probe_point_desc *desc;
-       size_t num_desc;
-       int i, ret;
-
-       /* disconnect all probe points */
-       ret = sof_ipc_probe_points_info(sdev, &desc, &num_desc);
-       if (ret < 0) {
-               dev_err(dai->dev, "Failed to get probe points: %d\n", ret);
-               goto exit;
-       }
-
-       for (i = 0; i < num_desc; i++)
-               sof_ipc_probe_points_remove(sdev, &desc[i].buffer_id, 1);
-       kfree(desc);
-
-exit:
-       ret = sof_ipc_probe_deinit(sdev);
-       if (ret < 0)
-               dev_err(dai->dev, "Failed to deinit probe: %d\n", ret);
-
-       sdev->extractor_stream_tag = SOF_PROBE_INVALID_NODE_ID;
-       snd_compr_free_pages(cstream);
+       struct snd_sof_pcm_stream *sps =
+               container_of(work, struct snd_sof_pcm_stream,
+                            period_elapsed_work);
 
-       return snd_sof_probe_compr_free(sdev, cstream, dai);
+       snd_compr_fragment_elapsed(sps->cstream);
 }
-EXPORT_SYMBOL(sof_probe_compr_free);
 
-int sof_probe_compr_set_params(struct snd_compr_stream *cstream,
-               struct snd_compr_params *params, struct snd_soc_dai *dai)
+void snd_sof_compr_init_elapsed_work(struct work_struct *work)
 {
-       struct snd_compr_runtime *rtd = cstream->runtime;
-       struct snd_sof_dev *sdev =
-                               snd_soc_component_get_drvdata(dai->component);
-       int ret;
-
-       cstream->dma_buffer.dev.type = SNDRV_DMA_TYPE_DEV_SG;
-       cstream->dma_buffer.dev.dev = sdev->dev;
-       ret = snd_compr_malloc_pages(cstream, rtd->buffer_size);
-       if (ret < 0)
-               return ret;
-
-       ret = snd_sof_probe_compr_set_params(sdev, cstream, params, dai);
-       if (ret < 0)
-               return ret;
-
-       ret = sof_ipc_probe_init(sdev, sdev->extractor_stream_tag,
-                                rtd->dma_bytes);
-       if (ret < 0) {
-               dev_err(dai->dev, "Failed to init probe: %d\n", ret);
-               return ret;
-       }
-
-       return 0;
-}
-EXPORT_SYMBOL(sof_probe_compr_set_params);
-
-int sof_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
-               struct snd_soc_dai *dai)
-{
-       struct snd_sof_dev *sdev =
-                               snd_soc_component_get_drvdata(dai->component);
-
-       return snd_sof_probe_compr_trigger(sdev, cstream, cmd, dai);
-}
-EXPORT_SYMBOL(sof_probe_compr_trigger);
-
-int sof_probe_compr_pointer(struct snd_compr_stream *cstream,
-               struct snd_compr_tstamp *tstamp, struct snd_soc_dai *dai)
-{
-       struct snd_sof_dev *sdev =
-                               snd_soc_component_get_drvdata(dai->component);
-
-       return snd_sof_probe_compr_pointer(sdev, cstream, tstamp, dai);
+       INIT_WORK(work, snd_sof_compr_fragment_elapsed_work);
 }
-EXPORT_SYMBOL(sof_probe_compr_pointer);
 
-int sof_probe_compr_copy(struct snd_soc_component *component,
-                        struct snd_compr_stream *cstream,
-                        char __user *buf, size_t count)
+/*
+ * sof compr fragment elapse, this could be called in irq thread context
+ */
+void snd_sof_compr_fragment_elapsed(struct snd_compr_stream *cstream)
 {
-       struct snd_compr_runtime *rtd = cstream->runtime;
-       unsigned int offset, n;
-       void *ptr;
-       int ret;
+       struct snd_soc_component *component;
+       struct snd_soc_pcm_runtime *rtd;
+       struct snd_sof_pcm *spcm;
 
-       if (count > rtd->buffer_size)
-               count = rtd->buffer_size;
+       if (!cstream)
+               return;
 
-       div_u64_rem(rtd->total_bytes_transferred, rtd->buffer_size, &offset);
-       ptr = rtd->dma_area + offset;
-       n = rtd->buffer_size - offset;
+       rtd = cstream->private_data;
+       component = snd_soc_rtdcom_lookup(rtd, SOF_AUDIO_PCM_DRV_NAME);
 
-       if (count < n) {
-               ret = copy_to_user(buf, ptr, count);
-       } else {
-               ret = copy_to_user(buf, ptr, n);
-               ret += copy_to_user(buf + n, rtd->dma_area, count - n);
+       spcm = snd_sof_find_spcm_dai(component, rtd);
+       if (!spcm) {
+               dev_err(component->dev,
+                       "fragment elapsed called for unknown stream!\n");
+               return;
        }
 
-       if (ret)
-               return count - ret;
-       return count;
+       /* use the same workqueue-based solution as for PCM, cf. snd_sof_pcm_elapsed */
+       schedule_work(&spcm->stream[cstream->direction].period_elapsed_work);
 }
-EXPORT_SYMBOL(sof_probe_compr_copy);
diff --git a/sound/soc/sof/compress.h b/sound/soc/sof/compress.h
deleted file mode 100644 (file)
index 4448c79..0000000
+++ /dev/null
@@ -1,32 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
-/*
- * This file is provided under a dual BSD/GPLv2 license.  When using or
- * redistributing this file, you may do so under either license.
- *
- * Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
- *
- * Author: Cezary Rojewski <cezary.rojewski@intel.com>
- */
-
-#ifndef __SOF_COMPRESS_H
-#define __SOF_COMPRESS_H
-
-#include <sound/compress_driver.h>
-
-extern const struct snd_compress_ops sof_probe_compressed_ops;
-
-int sof_probe_compr_open(struct snd_compr_stream *cstream,
-               struct snd_soc_dai *dai);
-int sof_probe_compr_free(struct snd_compr_stream *cstream,
-               struct snd_soc_dai *dai);
-int sof_probe_compr_set_params(struct snd_compr_stream *cstream,
-               struct snd_compr_params *params, struct snd_soc_dai *dai);
-int sof_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
-               struct snd_soc_dai *dai);
-int sof_probe_compr_pointer(struct snd_compr_stream *cstream,
-               struct snd_compr_tstamp *tstamp, struct snd_soc_dai *dai);
-int sof_probe_compr_copy(struct snd_soc_component *component,
-                        struct snd_compr_stream *cstream,
-                        char __user *buf, size_t count);
-
-#endif
index a5dd728..58bb89a 100644 (file)
@@ -65,6 +65,40 @@ static inline u32 ipc_to_mixer(u32 value, u32 *volume_map, int size)
        return i - 1;
 }
 
+static void snd_sof_refresh_control(struct snd_sof_control *scontrol)
+{
+       struct sof_ipc_ctrl_data *cdata = scontrol->control_data;
+       struct snd_soc_component *scomp = scontrol->scomp;
+       enum sof_ipc_ctrl_type ctrl_type;
+       int ret;
+
+       if (!scontrol->comp_data_dirty)
+               return;
+
+       if (!pm_runtime_active(scomp->dev))
+               return;
+
+       if (scontrol->cmd == SOF_CTRL_CMD_BINARY)
+               ctrl_type = SOF_IPC_COMP_GET_DATA;
+       else
+               ctrl_type = SOF_IPC_COMP_GET_VALUE;
+
+       /* set the ABI header values */
+       cdata->data->magic = SOF_ABI_MAGIC;
+       cdata->data->abi = SOF_ABI_VERSION;
+
+       /* refresh the component data from DSP */
+       scontrol->comp_data_dirty = false;
+       ret = snd_sof_ipc_set_get_comp_data(scontrol, ctrl_type,
+                                           SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                           scontrol->cmd, false);
+       if (ret < 0) {
+               dev_err(scomp->dev, "error: failed to get control data: %d\n", ret);
+               /* Set the flag to re-try next time to get the data */
+               scontrol->comp_data_dirty = true;
+       }
+}
+
 int snd_sof_volume_get(struct snd_kcontrol *kcontrol,
                       struct snd_ctl_elem_value *ucontrol)
 {
@@ -74,6 +108,8 @@ int snd_sof_volume_get(struct snd_kcontrol *kcontrol,
        struct sof_ipc_ctrl_data *cdata = scontrol->control_data;
        unsigned int i, channels = scontrol->num_channels;
 
+       snd_sof_refresh_control(scontrol);
+
        /* read back each channel */
        for (i = 0; i < channels; i++)
                ucontrol->value.integer.value[i] =
@@ -108,7 +144,7 @@ int snd_sof_volume_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_VOLUME,
                                              true);
        return change;
@@ -145,6 +181,8 @@ int snd_sof_switch_get(struct snd_kcontrol *kcontrol,
        struct sof_ipc_ctrl_data *cdata = scontrol->control_data;
        unsigned int i, channels = scontrol->num_channels;
 
+       snd_sof_refresh_control(scontrol);
+
        /* read back each channel */
        for (i = 0; i < channels; i++)
                ucontrol->value.integer.value[i] = cdata->chanv[i].value;
@@ -179,7 +217,7 @@ int snd_sof_switch_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_SWITCH,
                                              true);
 
@@ -195,6 +233,8 @@ int snd_sof_enum_get(struct snd_kcontrol *kcontrol,
        struct sof_ipc_ctrl_data *cdata = scontrol->control_data;
        unsigned int i, channels = scontrol->num_channels;
 
+       snd_sof_refresh_control(scontrol);
+
        /* read back each channel */
        for (i = 0; i < channels; i++)
                ucontrol->value.enumerated.item[i] = cdata->chanv[i].value;
@@ -226,7 +266,7 @@ int snd_sof_enum_put(struct snd_kcontrol *kcontrol,
        if (pm_runtime_active(scomp->dev))
                snd_sof_ipc_set_get_comp_data(scontrol,
                                              SOF_IPC_COMP_SET_VALUE,
-                                             SOF_CTRL_TYPE_VALUE_CHAN_GET,
+                                             SOF_CTRL_TYPE_VALUE_CHAN_SET,
                                              SOF_CTRL_CMD_ENUM,
                                              true);
 
@@ -244,6 +284,8 @@ int snd_sof_bytes_get(struct snd_kcontrol *kcontrol,
        struct sof_abi_hdr *data = cdata->data;
        size_t size;
 
+       snd_sof_refresh_control(scontrol);
+
        if (be->max > sizeof(ucontrol->value.bytes.data)) {
                dev_err_ratelimited(scomp->dev,
                                    "error: data max %d exceeds ucontrol data array size\n",
@@ -475,6 +517,8 @@ int snd_sof_bytes_ext_get(struct snd_kcontrol *kcontrol,
                (struct snd_ctl_tlv __user *)binary_data;
        size_t data_size;
 
+       snd_sof_refresh_control(scontrol);
+
        /*
         * Decrement the limit by ext bytes header size to
         * ensure the user space buffer is not exceeded.
@@ -511,3 +555,145 @@ int snd_sof_bytes_ext_get(struct snd_kcontrol *kcontrol,
 
        return 0;
 }
+
+static void snd_sof_update_control(struct snd_sof_control *scontrol,
+                                  struct sof_ipc_ctrl_data *cdata)
+{
+       struct snd_soc_component *scomp = scontrol->scomp;
+       struct sof_ipc_ctrl_data *local_cdata;
+       int i;
+
+       local_cdata = scontrol->control_data;
+
+       if (cdata->cmd == SOF_CTRL_CMD_BINARY) {
+               if (cdata->num_elems != local_cdata->data->size) {
+                       dev_err(scomp->dev,
+                               "error: cdata binary size mismatch %u - %u\n",
+                               cdata->num_elems, local_cdata->data->size);
+                       return;
+               }
+
+               /* copy the new binary data */
+               memcpy(local_cdata->data, cdata->data, cdata->num_elems);
+       } else if (cdata->num_elems != scontrol->num_channels) {
+               dev_err(scomp->dev,
+                       "error: cdata channel count mismatch %u - %d\n",
+                       cdata->num_elems, scontrol->num_channels);
+       } else {
+               /* copy the new values */
+               for (i = 0; i < cdata->num_elems; i++)
+                       local_cdata->chanv[i].value = cdata->chanv[i].value;
+       }
+}
+
+void snd_sof_control_notify(struct snd_sof_dev *sdev,
+                           struct sof_ipc_ctrl_data *cdata)
+{
+       struct snd_soc_dapm_widget *widget;
+       struct snd_sof_control *scontrol;
+       struct snd_sof_widget *swidget;
+       struct snd_kcontrol *kc = NULL;
+       struct soc_mixer_control *sm;
+       struct soc_bytes_ext *be;
+       size_t expected_size;
+       struct soc_enum *se;
+       bool found = false;
+       int i, type;
+
+       /* Find the swidget first */
+       list_for_each_entry(swidget, &sdev->widget_list, list) {
+               if (swidget->comp_id == cdata->comp_id) {
+                       found = true;
+                       break;
+               }
+       }
+
+       if (!found)
+               return;
+
+       /* Translate SOF cmd to TPLG type */
+       switch (cdata->cmd) {
+       case SOF_CTRL_CMD_VOLUME:
+       case SOF_CTRL_CMD_SWITCH:
+               type = SND_SOC_TPLG_TYPE_MIXER;
+               break;
+       case SOF_CTRL_CMD_BINARY:
+               type = SND_SOC_TPLG_TYPE_BYTES;
+               break;
+       case SOF_CTRL_CMD_ENUM:
+               type = SND_SOC_TPLG_TYPE_ENUM;
+               break;
+       default:
+               dev_err(sdev->dev, "error: unknown cmd %u\n", cdata->cmd);
+               return;
+       }
+
+       widget = swidget->widget;
+       for (i = 0; i < widget->num_kcontrols; i++) {
+               /* skip non matching types or non matching indexes within type */
+               if (widget->dobj.widget.kcontrol_type[i] == type &&
+                   widget->kcontrol_news[i].index == cdata->index) {
+                       kc = widget->kcontrols[i];
+                       break;
+               }
+       }
+
+       if (!kc)
+               return;
+
+       switch (cdata->cmd) {
+       case SOF_CTRL_CMD_VOLUME:
+       case SOF_CTRL_CMD_SWITCH:
+               sm = (struct soc_mixer_control *)kc->private_value;
+               scontrol = sm->dobj.private;
+               break;
+       case SOF_CTRL_CMD_BINARY:
+               be = (struct soc_bytes_ext *)kc->private_value;
+               scontrol = be->dobj.private;
+               break;
+       case SOF_CTRL_CMD_ENUM:
+               se = (struct soc_enum *)kc->private_value;
+               scontrol = se->dobj.private;
+               break;
+       default:
+               return;
+       }
+
+       expected_size = sizeof(struct sof_ipc_ctrl_data);
+       switch (cdata->type) {
+       case SOF_CTRL_TYPE_VALUE_CHAN_GET:
+       case SOF_CTRL_TYPE_VALUE_CHAN_SET:
+               expected_size += cdata->num_elems *
+                                sizeof(struct sof_ipc_ctrl_value_chan);
+               break;
+       case SOF_CTRL_TYPE_VALUE_COMP_GET:
+       case SOF_CTRL_TYPE_VALUE_COMP_SET:
+               expected_size += cdata->num_elems *
+                                sizeof(struct sof_ipc_ctrl_value_comp);
+               break;
+       case SOF_CTRL_TYPE_DATA_GET:
+       case SOF_CTRL_TYPE_DATA_SET:
+               expected_size += cdata->num_elems + sizeof(struct sof_abi_hdr);
+               break;
+       default:
+               return;
+       }
+
+       if (cdata->rhdr.hdr.size != expected_size) {
+               dev_err(sdev->dev, "error: component notification size mismatch\n");
+               return;
+       }
+
+       if (cdata->num_elems)
+               /*
+                * The message includes the updated value/data, update the
+                * control's local cache using the received notification
+                */
+               snd_sof_update_control(scontrol, cdata);
+       else
+               /* Mark the scontrol that the value/data is changed in SOF */
+               scontrol->comp_data_dirty = true;
+
+       snd_ctl_notify_one(swidget->scomp->card->snd_card,
+                          SNDRV_CTL_EVENT_MASK_VALUE, kc, 0);
+}
index 59d0d7b..2c3de29 100644 (file)
 #include "sof-priv.h"
 #include "ops.h"
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
-#include "probe.h"
+#include "sof-probes.h"
 #endif
 
 /* see SOF_DBG_ flags */
-int sof_core_debug;
+int sof_core_debug =  IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_ENABLE_FIRMWARE_TRACE);
 module_param_named(sof_debug, sof_core_debug, int, 0444);
 MODULE_PARM_DESC(sof_debug, "SOF core debug options (0x0 all off)");
 
@@ -67,7 +67,7 @@ void snd_sof_get_status(struct snd_sof_dev *sdev, u32 panic_code,
 
        /* is firmware dead ? */
        if ((panic_code & SOF_IPC_PANIC_MAGIC_MASK) != SOF_IPC_PANIC_MAGIC) {
-               dev_err(sdev->dev, "error: unexpected fault 0x%8.8x trace 0x%8.8x\n",
+               dev_err(sdev->dev, "unexpected fault %#010x trace %#010x\n",
                        panic_code, tracep_code);
                return; /* no fault ? */
        }
@@ -76,20 +76,20 @@ void snd_sof_get_status(struct snd_sof_dev *sdev, u32 panic_code,
 
        for (i = 0; i < ARRAY_SIZE(panic_msg); i++) {
                if (panic_msg[i].id == code) {
-                       dev_err(sdev->dev, "error: %s\n", panic_msg[i].msg);
-                       dev_err(sdev->dev, "error: trace point %8.8x\n",
-                               tracep_code);
+                       dev_err(sdev->dev, "reason: %s (%#x)\n", panic_msg[i].msg,
+                               code & SOF_IPC_PANIC_CODE_MASK);
+                       dev_err(sdev->dev, "trace point: %#010x\n", tracep_code);
                        goto out;
                }
        }
 
        /* unknown error */
-       dev_err(sdev->dev, "error: unknown reason %8.8x\n", panic_code);
-       dev_err(sdev->dev, "error: trace point %8.8x\n", tracep_code);
+       dev_err(sdev->dev, "unknown panic code: %#x\n", code & SOF_IPC_PANIC_CODE_MASK);
+       dev_err(sdev->dev, "trace point: %#010x\n", tracep_code);
 
 out:
-       dev_err(sdev->dev, "error: panic at %s:%d\n",
-               panic_info->filename, panic_info->linenum);
+       dev_err(sdev->dev, "panic at %s:%d\n", panic_info->filename,
+               panic_info->linenum);
        sof_oops(sdev, oops);
        sof_stack(sdev, oops, stack, stack_words);
 }
@@ -147,7 +147,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev)
                return ret;
        }
 
-       sdev->fw_state = SOF_FW_BOOT_PREPARE;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_PREPARE);
 
        /* check machine info */
        ret = sof_machine_check(sdev);
@@ -189,7 +189,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev)
                goto fw_load_err;
        }
 
-       sdev->fw_state = SOF_FW_BOOT_IN_PROGRESS;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_IN_PROGRESS);
 
        /*
         * Boot the firmware. The FW boot status will be modified
@@ -202,8 +202,7 @@ static int sof_probe_continue(struct snd_sof_dev *sdev)
                goto fw_run_err;
        }
 
-       if (IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_ENABLE_FIRMWARE_TRACE) ||
-           (sof_core_debug & SOF_DBG_ENABLE_TRACE)) {
+       if (sof_core_debug & SOF_DBG_ENABLE_TRACE) {
                sdev->dtrace_is_supported = true;
 
                /* init DMA trace */
@@ -266,7 +265,7 @@ dsp_err:
        snd_sof_remove(sdev);
 
        /* all resources freed, update state to match */
-       sdev->fw_state = SOF_FW_BOOT_NOT_STARTED;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_NOT_STARTED);
        sdev->first_boot = true;
 
        return ret;
@@ -301,7 +300,7 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data)
 
        sdev->pdata = plat_data;
        sdev->first_boot = true;
-       sdev->fw_state = SOF_FW_BOOT_NOT_STARTED;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_NOT_STARTED);
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
        sdev->extractor_stream_tag = SOF_PROBE_INVALID_NODE_ID;
 #endif
@@ -326,9 +325,6 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data)
        spin_lock_init(&sdev->hw_lock);
        mutex_init(&sdev->power_state_access);
 
-       if (IS_ENABLED(CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE))
-               INIT_WORK(&sdev->probe_work, sof_probe_work);
-
        /* set default timeouts if none provided */
        if (plat_data->desc->ipc_timeout == 0)
                sdev->ipc_timeout = TIMEOUT_DEFAULT_IPC_MS;
@@ -340,6 +336,7 @@ int snd_sof_device_probe(struct device *dev, struct snd_sof_pdata *plat_data)
                sdev->boot_timeout = plat_data->desc->boot_timeout;
 
        if (IS_ENABLED(CONFIG_SND_SOC_SOF_PROBE_WORK_QUEUE)) {
+               INIT_WORK(&sdev->probe_work, sof_probe_work);
                schedule_work(&sdev->probe_work);
                return 0;
        }
index a51a928..dc1df5f 100644 (file)
@@ -20,7 +20,7 @@
 #include "ops.h"
 
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
-#include "probe.h"
+#include "sof-probes.h"
 
 /**
  * strsplit_u32 - Split string into sequence of u32 tokens
@@ -546,10 +546,10 @@ static const struct file_operations sof_dfs_fops = {
 };
 
 /* create FS entry for debug files that can expose DSP memories, registers */
-int snd_sof_debugfs_io_item(struct snd_sof_dev *sdev,
-                           void __iomem *base, size_t size,
-                           const char *name,
-                           enum sof_debugfs_access_type access_type)
+static int snd_sof_debugfs_io_item(struct snd_sof_dev *sdev,
+                                  void __iomem *base, size_t size,
+                                  const char *name,
+                                  enum sof_debugfs_access_type access_type)
 {
        struct snd_sof_dfsentry *dfse;
 
@@ -586,7 +586,21 @@ int snd_sof_debugfs_io_item(struct snd_sof_dev *sdev,
 
        return 0;
 }
-EXPORT_SYMBOL_GPL(snd_sof_debugfs_io_item);
+
+int snd_sof_debugfs_add_region_item_iomem(struct snd_sof_dev *sdev,
+                                         enum snd_sof_fw_blk_type blk_type, u32 offset,
+                                         size_t size, const char *name,
+                                         enum sof_debugfs_access_type access_type)
+{
+       int bar = snd_sof_dsp_get_bar_index(sdev, blk_type);
+
+       if (bar < 0)
+               return bar;
+
+       return snd_sof_debugfs_io_item(sdev, sdev->bar[bar] + offset, size, name,
+                                      access_type);
+}
+EXPORT_SYMBOL_GPL(snd_sof_debugfs_add_region_item_iomem);
 
 /* create FS entry for debug files to expose kernel memory */
 int snd_sof_debugfs_buf_item(struct snd_sof_dev *sdev,
@@ -808,18 +822,75 @@ void snd_sof_free_debug(struct snd_sof_dev *sdev)
 }
 EXPORT_SYMBOL_GPL(snd_sof_free_debug);
 
+static const struct soc_fw_state_info {
+       enum snd_sof_fw_state state;
+       const char *name;
+} fw_state_dbg[] = {
+       {SOF_FW_BOOT_NOT_STARTED, "SOF_FW_BOOT_NOT_STARTED"},
+       {SOF_FW_BOOT_PREPARE, "SOF_FW_BOOT_PREPARE"},
+       {SOF_FW_BOOT_IN_PROGRESS, "SOF_FW_BOOT_IN_PROGRESS"},
+       {SOF_FW_BOOT_FAILED, "SOF_FW_BOOT_FAILED"},
+       {SOF_FW_BOOT_READY_FAILED, "SOF_FW_BOOT_READY_FAILED"},
+       {SOF_FW_BOOT_COMPLETE, "SOF_FW_BOOT_COMPLETE"},
+};
+
+static void snd_sof_dbg_print_fw_state(struct snd_sof_dev *sdev)
+{
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(fw_state_dbg); i++) {
+               if (sdev->fw_state == fw_state_dbg[i].state) {
+                       dev_err(sdev->dev, "fw_state: %s (%d)\n", fw_state_dbg[i].name, i);
+                       return;
+               }
+       }
+
+       dev_err(sdev->dev, "fw_state: UNKNOWN (%d)\n", sdev->fw_state);
+}
+
+void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags)
+{
+       bool print_all = !!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS);
+
+       if (flags & SOF_DBG_DUMP_OPTIONAL && !print_all)
+               return;
+
+       if (sof_ops(sdev)->dbg_dump && !sdev->dbg_dump_printed) {
+               dev_err(sdev->dev, "------------[ DSP dump start ]------------\n");
+               snd_sof_dbg_print_fw_state(sdev);
+               sof_ops(sdev)->dbg_dump(sdev, flags);
+               dev_err(sdev->dev, "------------[ DSP dump end ]------------\n");
+               if (!print_all)
+                       sdev->dbg_dump_printed = true;
+       }
+}
+EXPORT_SYMBOL(snd_sof_dsp_dbg_dump);
+
+static void snd_sof_ipc_dump(struct snd_sof_dev *sdev)
+{
+       if (sof_ops(sdev)->ipc_dump  && !sdev->ipc_dump_printed) {
+               dev_err(sdev->dev, "------------[ IPC dump start ]------------\n");
+               sof_ops(sdev)->ipc_dump(sdev);
+               dev_err(sdev->dev, "------------[ IPC dump end ]------------\n");
+               if (!(sof_core_debug & SOF_DBG_PRINT_ALL_DUMPS))
+                       sdev->ipc_dump_printed = true;
+       }
+}
+
 void snd_sof_handle_fw_exception(struct snd_sof_dev *sdev)
 {
        if (IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_RETAIN_DSP_CONTEXT) ||
            (sof_core_debug & SOF_DBG_RETAIN_CTX)) {
                /* should we prevent DSP entering D3 ? */
-               dev_info(sdev->dev, "info: preventing DSP entering D3 state to preserve context\n");
+               if (!sdev->ipc_dump_printed)
+                       dev_info(sdev->dev,
+                                "preventing DSP entering D3 state to preserve context\n");
                pm_runtime_get_noresume(sdev->dev);
        }
 
        /* dump vital information to the logs */
-       snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
        snd_sof_ipc_dump(sdev);
+       snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
        snd_sof_trace_notify_for_error(sdev);
 }
 EXPORT_SYMBOL(snd_sof_handle_fw_exception);
index 49d605c..34cf228 100644 (file)
@@ -38,6 +38,7 @@ config SND_SOC_SOF_IMX8
        tristate
        select SND_SOC_SOF_IMX_COMMON
        select SND_SOC_SOF_XTENSA
+       select SND_SOC_SOF_COMPRESS
        help
          This option is not user-selectable but automagically handled by
          'select' statements at a higher level.
@@ -54,6 +55,7 @@ config SND_SOC_SOF_IMX8M
        tristate
        select SND_SOC_SOF_IMX_COMMON
        select SND_SOC_SOF_XTENSA
+       select SND_SOC_SOF_COMPRESS
        help
          This option is not user-selectable but automagically handled by
          'select' statements at a higher level.
diff --git a/sound/soc/sof/imx/imx-ops.h b/sound/soc/sof/imx/imx-ops.h
new file mode 100644 (file)
index 0000000..24235ef
--- /dev/null
@@ -0,0 +1,10 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
+
+#ifndef __IMX_OPS_H__
+#define __IMX_OPS_H__
+
+extern struct snd_sof_dsp_ops sof_imx8_ops;
+extern struct snd_sof_dsp_ops sof_imx8x_ops;
+extern struct snd_sof_dsp_ops sof_imx8m_ops;
+
+#endif
index 7e9723a..dd59a74 100644 (file)
@@ -22,6 +22,7 @@
 #include <dt-bindings/firmware/imx/rsrc.h>
 #include "../ops.h"
 #include "imx-common.h"
+#include "imx-ops.h"
 
 /* DSP memories */
 #define IRAM_OFFSET            0x10000
@@ -375,20 +376,6 @@ static int imx8_get_bar_index(struct snd_sof_dev *sdev, u32 type)
        }
 }
 
-static void imx8_ipc_msg_data(struct snd_sof_dev *sdev,
-                             struct snd_pcm_substream *substream,
-                             void *p, size_t sz)
-{
-       sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
-}
-
-static int imx8_ipc_pcm_params(struct snd_sof_dev *sdev,
-                              struct snd_pcm_substream *substream,
-                              const struct sof_ipc_pcm_params_reply *reply)
-{
-       return 0;
-}
-
 static struct snd_soc_dai_driver imx8_dai[] = {
 {
        .name = "esai0",
@@ -426,8 +413,9 @@ struct snd_sof_dsp_ops sof_imx8_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
-       /* Module IO */
-       .read64 = sof_io_read64,
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
 
        /* ipc */
        .send_msg       = imx8_send_msg,
@@ -435,8 +423,8 @@ struct snd_sof_dsp_ops sof_imx8_ops = {
        .get_mailbox_offset     = imx8_get_mailbox_offset,
        .get_window_offset      = imx8_get_window_offset,
 
-       .ipc_msg_data   = imx8_ipc_msg_data,
-       .ipc_pcm_params = imx8_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -446,9 +434,14 @@ struct snd_sof_dsp_ops sof_imx8_ops = {
 
        /* Debug information */
        .dbg_dump = imx8_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
+
+       /* stream callbacks */
+       .pcm_open = sof_stream_pcm_open,
+       .pcm_close = sof_stream_pcm_close,
 
        /* Firmware ops */
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 
        /* DAI drivers */
        .drv = imx8_dai,
@@ -475,8 +468,9 @@ struct snd_sof_dsp_ops sof_imx8x_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
-       /* Module IO */
-       .read64 = sof_io_read64,
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
 
        /* ipc */
        .send_msg       = imx8_send_msg,
@@ -484,8 +478,8 @@ struct snd_sof_dsp_ops sof_imx8x_ops = {
        .get_mailbox_offset     = imx8_get_mailbox_offset,
        .get_window_offset      = imx8_get_window_offset,
 
-       .ipc_msg_data   = imx8_ipc_msg_data,
-       .ipc_pcm_params = imx8_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -495,9 +489,14 @@ struct snd_sof_dsp_ops sof_imx8x_ops = {
 
        /* Debug information */
        .dbg_dump = imx8_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
+
+       /* stream callbacks */
+       .pcm_open = sof_stream_pcm_open,
+       .pcm_close = sof_stream_pcm_close,
 
        /* Firmware ops */
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 
        /* DAI drivers */
        .drv = imx8_dai,
index 892e148..e461898 100644 (file)
@@ -18,6 +18,7 @@
 
 #include "../ops.h"
 #include "imx-common.h"
+#include "imx-ops.h"
 
 #define MBOX_OFFSET    0x800000
 #define MBOX_SIZE      0x1000
@@ -238,21 +239,18 @@ static int imx8m_get_bar_index(struct snd_sof_dev *sdev, u32 type)
        }
 }
 
-static void imx8m_ipc_msg_data(struct snd_sof_dev *sdev,
-                              struct snd_pcm_substream *substream,
-                              void *p, size_t sz)
-{
-       sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
-}
-
-static int imx8m_ipc_pcm_params(struct snd_sof_dev *sdev,
-                               struct snd_pcm_substream *substream,
-                               const struct sof_ipc_pcm_params_reply *reply)
-{
-       return 0;
-}
-
 static struct snd_soc_dai_driver imx8m_dai[] = {
+{
+       .name = "sai1",
+       .playback = {
+               .channels_min = 1,
+               .channels_max = 32,
+       },
+       .capture = {
+               .channels_min = 1,
+               .channels_max = 32,
+       },
+},
 {
        .name = "sai3",
        .playback = {
@@ -278,8 +276,9 @@ struct snd_sof_dsp_ops sof_imx8m_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
-       /* Module IO */
-       .read64 = sof_io_read64,
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
 
        /* ipc */
        .send_msg       = imx8m_send_msg,
@@ -287,8 +286,8 @@ struct snd_sof_dsp_ops sof_imx8m_ops = {
        .get_mailbox_offset     = imx8m_get_mailbox_offset,
        .get_window_offset      = imx8m_get_window_offset,
 
-       .ipc_msg_data   = imx8m_ipc_msg_data,
-       .ipc_pcm_params = imx8m_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -298,9 +297,13 @@ struct snd_sof_dsp_ops sof_imx8m_ops = {
 
        /* Debug information */
        .dbg_dump = imx8_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
+       /* stream callbacks */
+       .pcm_open       = sof_stream_pcm_open,
+       .pcm_close      = sof_stream_pcm_close,
        /* Firmware ops */
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 
        /* DAI drivers */
        .drv = imx8m_dai,
index feae487..1f473d4 100644 (file)
@@ -3,13 +3,11 @@
 snd-sof-acpi-intel-byt-objs := byt.o
 snd-sof-acpi-intel-bdw-objs := bdw.o
 
-snd-sof-intel-ipc-objs := intel-ipc.o
-
 snd-sof-intel-hda-common-objs := hda.o hda-loader.o hda-stream.o hda-trace.o \
                                 hda-dsp.o hda-ipc.o hda-ctrl.o hda-pcm.o \
                                 hda-dai.o hda-bus.o \
                                 apl.o cnl.o tgl.o icl.o
-snd-sof-intel-hda-common-$(CONFIG_SND_SOC_SOF_HDA_PROBES) += hda-compress.o
+snd-sof-intel-hda-common-$(CONFIG_SND_SOC_SOF_HDA_PROBES) += hda-probes.o
 
 snd-sof-intel-hda-objs := hda-codec.o
 
@@ -18,7 +16,6 @@ snd-sof-intel-atom-objs := atom.o
 obj-$(CONFIG_SND_SOC_SOF_INTEL_ATOM_HIFI_EP) += snd-sof-intel-atom.o
 obj-$(CONFIG_SND_SOC_SOF_BAYTRAIL) += snd-sof-acpi-intel-byt.o
 obj-$(CONFIG_SND_SOC_SOF_BROADWELL) += snd-sof-acpi-intel-bdw.o
-obj-$(CONFIG_SND_SOC_SOF_INTEL_HIFI_EP_IPC) += snd-sof-intel-ipc.o
 obj-$(CONFIG_SND_SOC_SOF_HDA_COMMON) += snd-sof-intel-hda-common.o
 obj-$(CONFIG_SND_SOC_SOF_HDA) += snd-sof-intel-hda.o
 
index c7ed2b3..917f78c 100644 (file)
@@ -42,6 +42,10 @@ const struct snd_sof_dsp_ops sof_apl_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_thread     = hda_dsp_ipc_irq_thread,
 
@@ -65,6 +69,7 @@ const struct snd_sof_dsp_ops sof_apl_ops = {
        .debug_map_count        = ARRAY_SIZE(apl_dsp_debugfs),
        .dbg_dump       = hda_dsp_dump,
        .ipc_dump       = hda_ipc_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
        .pcm_open       = hda_dsp_pcm_open,
@@ -125,7 +130,7 @@ const struct snd_sof_dsp_ops sof_apl_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 EXPORT_SYMBOL_NS(sof_apl_ops, SND_SOC_SOF_INTEL_HDA_COMMON);
 
index d8804ef..74c630b 100644 (file)
@@ -283,11 +283,8 @@ int atom_run(struct snd_sof_dev *sdev)
                        break;
                msleep(100);
        }
-       if (tries < 0) {
-               dev_err(sdev->dev, "error:  unable to run DSP firmware\n");
-               atom_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
+       if (tries < 0)
                return -ENODEV;
-       }
 
        /* return init core mask */
        return 1;
index 89a6c1f..2c09a52 100644 (file)
@@ -535,8 +535,8 @@ static int bdw_probe(struct snd_sof_dev *sdev)
                return ret;
        }
 
-       /* set default mailbox */
-       snd_sof_dsp_mailbox_init(sdev, MBOX_OFFSET, MBOX_SIZE, 0, 0);
+       /* set default mailbox offset for FW ready message */
+       sdev->dsp_box.offset = MBOX_OFFSET;
 
        return ret;
 }
@@ -616,14 +616,18 @@ static const struct snd_sof_dsp_ops sof_bdw_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* ipc */
        .send_msg       = bdw_send_msg,
        .fw_ready       = sof_fw_ready,
        .get_mailbox_offset = bdw_get_mailbox_offset,
        .get_window_offset = bdw_get_window_offset,
 
-       .ipc_msg_data   = intel_ipc_msg_data,
-       .ipc_pcm_params = intel_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* machine driver */
        .machine_select = bdw_machine_select,
@@ -635,10 +639,11 @@ static const struct snd_sof_dsp_ops sof_bdw_ops = {
        .debug_map  = bdw_debugfs,
        .debug_map_count    = ARRAY_SIZE(bdw_debugfs),
        .dbg_dump   = bdw_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
-       .pcm_open       = intel_pcm_open,
-       .pcm_close      = intel_pcm_close,
+       .pcm_open       = sof_stream_pcm_open,
+       .pcm_close      = sof_stream_pcm_close,
 
        /* Module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -657,7 +662,7 @@ static const struct snd_sof_dsp_ops sof_bdw_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_BATCH,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 
 static const struct sof_intel_dsp_desc bdw_chip_info = {
index 8edaf6f..e2fa08f 100644 (file)
@@ -226,6 +226,10 @@ static const struct snd_sof_dsp_ops sof_byt_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_handler    = atom_irq_handler,
        .irq_thread     = atom_irq_thread,
@@ -236,8 +240,8 @@ static const struct snd_sof_dsp_ops sof_byt_ops = {
        .get_mailbox_offset = atom_get_mailbox_offset,
        .get_window_offset = atom_get_window_offset,
 
-       .ipc_msg_data   = intel_ipc_msg_data,
-       .ipc_pcm_params = intel_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* machine driver */
        .machine_select = atom_machine_select,
@@ -249,10 +253,11 @@ static const struct snd_sof_dsp_ops sof_byt_ops = {
        .debug_map      = byt_debugfs,
        .debug_map_count        = ARRAY_SIZE(byt_debugfs),
        .dbg_dump       = atom_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
-       .pcm_open       = intel_pcm_open,
-       .pcm_close      = intel_pcm_close,
+       .pcm_open       = sof_stream_pcm_open,
+       .pcm_close      = sof_stream_pcm_close,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -275,7 +280,7 @@ static const struct snd_sof_dsp_ops sof_byt_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_BATCH,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 
 static const struct sof_intel_dsp_desc byt_chip_info = {
@@ -303,6 +308,10 @@ static const struct snd_sof_dsp_ops sof_cht_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_handler    = atom_irq_handler,
        .irq_thread     = atom_irq_thread,
@@ -313,8 +322,8 @@ static const struct snd_sof_dsp_ops sof_cht_ops = {
        .get_mailbox_offset = atom_get_mailbox_offset,
        .get_window_offset = atom_get_window_offset,
 
-       .ipc_msg_data   = intel_ipc_msg_data,
-       .ipc_pcm_params = intel_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* machine driver */
        .machine_select = atom_machine_select,
@@ -326,10 +335,11 @@ static const struct snd_sof_dsp_ops sof_cht_ops = {
        .debug_map      = cht_debugfs,
        .debug_map_count        = ARRAY_SIZE(cht_debugfs),
        .dbg_dump       = atom_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
-       .pcm_open       = intel_pcm_open,
-       .pcm_close      = intel_pcm_close,
+       .pcm_open       = sof_stream_pcm_open,
+       .pcm_close      = sof_stream_pcm_close,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -353,7 +363,7 @@ static const struct snd_sof_dsp_ops sof_cht_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_BATCH,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 
 static const struct sof_intel_dsp_desc cht_chip_info = {
index e115e12..3957e2b 100644 (file)
@@ -247,6 +247,10 @@ const struct snd_sof_dsp_ops sof_cnl_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_thread     = cnl_ipc_irq_thread,
 
@@ -270,6 +274,7 @@ const struct snd_sof_dsp_ops sof_cnl_ops = {
        .debug_map_count        = ARRAY_SIZE(cnl_dsp_debugfs),
        .dbg_dump       = hda_dsp_dump,
        .ipc_dump       = cnl_ipc_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
        .pcm_open       = hda_dsp_pcm_open,
@@ -330,7 +335,7 @@ const struct snd_sof_dsp_ops sof_cnl_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 EXPORT_SYMBOL_NS(sof_cnl_ops, SND_SOC_SOF_INTEL_HDA_COMMON);
 
diff --git a/sound/soc/sof/intel/hda-compress.c b/sound/soc/sof/intel/hda-compress.c
deleted file mode 100644 (file)
index fe2f3f7..0000000
+++ /dev/null
@@ -1,114 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
-//
-// This file is provided under a dual BSD/GPLv2 license.  When using or
-// redistributing this file, you may do so under either license.
-//
-// Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
-//
-// Author: Cezary Rojewski <cezary.rojewski@intel.com>
-//
-
-#include <sound/hdaudio_ext.h>
-#include <sound/soc.h>
-#include "../sof-priv.h"
-#include "hda.h"
-
-static inline struct hdac_ext_stream *
-hda_compr_get_stream(struct snd_compr_stream *cstream)
-{
-       return cstream->runtime->private_data;
-}
-
-int hda_probe_compr_assign(struct snd_sof_dev *sdev,
-                          struct snd_compr_stream *cstream,
-                          struct snd_soc_dai *dai)
-{
-       struct hdac_ext_stream *stream;
-
-       stream = hda_dsp_stream_get(sdev, cstream->direction, 0);
-       if (!stream)
-               return -EBUSY;
-
-       hdac_stream(stream)->curr_pos = 0;
-       hdac_stream(stream)->cstream = cstream;
-       cstream->runtime->private_data = stream;
-
-       return hdac_stream(stream)->stream_tag;
-}
-
-int hda_probe_compr_free(struct snd_sof_dev *sdev,
-                        struct snd_compr_stream *cstream,
-                        struct snd_soc_dai *dai)
-{
-       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
-       int ret;
-
-       ret = hda_dsp_stream_put(sdev, cstream->direction,
-                                hdac_stream(stream)->stream_tag);
-       if (ret < 0) {
-               dev_dbg(sdev->dev, "stream put failed: %d\n", ret);
-               return ret;
-       }
-
-       hdac_stream(stream)->cstream = NULL;
-       cstream->runtime->private_data = NULL;
-
-       return 0;
-}
-
-int hda_probe_compr_set_params(struct snd_sof_dev *sdev,
-                              struct snd_compr_stream *cstream,
-                              struct snd_compr_params *params,
-                              struct snd_soc_dai *dai)
-{
-       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
-       struct hdac_stream *hstream = hdac_stream(stream);
-       struct snd_dma_buffer *dmab;
-       u32 bits, rate;
-       int bps, ret;
-
-       dmab = cstream->runtime->dma_buffer_p;
-       /* compr params do not store bit depth, default to S32_LE */
-       bps = snd_pcm_format_physical_width(SNDRV_PCM_FORMAT_S32_LE);
-       if (bps < 0)
-               return bps;
-       bits = hda_dsp_get_bits(sdev, bps);
-       rate = hda_dsp_get_mult_div(sdev, params->codec.sample_rate);
-
-       hstream->format_val = rate | bits | (params->codec.ch_out - 1);
-       hstream->bufsize = cstream->runtime->buffer_size;
-       hstream->period_bytes = cstream->runtime->fragment_size;
-       hstream->no_period_wakeup = 0;
-
-       ret = hda_dsp_stream_hw_params(sdev, stream, dmab, NULL);
-       if (ret < 0) {
-               dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
-               return ret;
-       }
-
-       return 0;
-}
-
-int hda_probe_compr_trigger(struct snd_sof_dev *sdev,
-                           struct snd_compr_stream *cstream, int cmd,
-                           struct snd_soc_dai *dai)
-{
-       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
-
-       return hda_dsp_stream_trigger(sdev, stream, cmd);
-}
-
-int hda_probe_compr_pointer(struct snd_sof_dev *sdev,
-                           struct snd_compr_stream *cstream,
-                           struct snd_compr_tstamp *tstamp,
-                           struct snd_soc_dai *dai)
-{
-       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
-       struct snd_soc_pcm_stream *pstream;
-
-       pstream = &dai->driver->capture;
-       tstamp->copied_total = hdac_stream(stream)->curr_pos;
-       tstamp->sampling_rate = snd_pcm_rate_bit_to_rate(pstream->rates);
-
-       return 0;
-}
index 6704dbc..7657938 100644 (file)
 
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA)
 
+#if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
+#include "../sof-probes.h"
+#endif
+
 struct hda_pipe_params {
        u8 host_dma_id;
        u8 link_dma_id;
@@ -152,49 +156,68 @@ static int hda_link_dma_params(struct hdac_ext_stream *stream,
        return 0;
 }
 
-/* Send DAI_CONFIG IPC to the DAI that matches the dai_name and direction */
-static int hda_link_config_ipc(struct sof_intel_hda_stream *hda_stream,
-                              const char *dai_name, int channel, int dir)
+/* Update config for the DAI widget */
+static struct sof_ipc_dai_config *hda_dai_update_config(struct snd_soc_dapm_widget *w,
+                                                       int channel)
 {
+       struct snd_sof_widget *swidget = w->dobj.private;
        struct sof_ipc_dai_config *config;
        struct snd_sof_dai *sof_dai;
-       struct sof_ipc_reply reply;
-       int ret = 0;
 
-       list_for_each_entry(sof_dai, &hda_stream->sdev->dai_list, list) {
-               if (!sof_dai->cpu_dai_name)
-                       continue;
+       if (!swidget)
+               return NULL;
 
-               if (!strcmp(dai_name, sof_dai->cpu_dai_name) &&
-                   dir == sof_dai->comp_dai.direction) {
-                       config = sof_dai->dai_config;
+       sof_dai = swidget->private;
 
-                       if (!config) {
-                               dev_err(hda_stream->sdev->dev,
-                                       "error: no config for DAI %s\n",
-                                       sof_dai->name);
-                               return -EINVAL;
-                       }
+       if (!sof_dai || !sof_dai->dai_config) {
+               dev_err(swidget->scomp->dev, "error: No config for DAI %s\n", w->name);
+               return NULL;
+       }
 
-                       /* update config with stream tag */
-                       config->hda.link_dma_ch = channel;
+       config = &sof_dai->dai_config[sof_dai->current_config];
 
-                       /* send IPC */
-                       ret = sof_ipc_tx_message(hda_stream->sdev->ipc,
-                                                config->hdr.cmd,
-                                                config,
-                                                config->hdr.size,
-                                                &reply, sizeof(reply));
+       /* update config with stream tag */
+       config->hda.link_dma_ch = channel;
 
-                       if (ret < 0)
-                               dev_err(hda_stream->sdev->dev,
-                                       "error: failed to set dai config for %s\n",
-                                       sof_dai->name);
-                       return ret;
-               }
+       return config;
+}
+
+static int hda_link_config_ipc(struct sof_intel_hda_stream *hda_stream,
+                              struct snd_soc_dapm_widget *w, int channel)
+{
+       struct snd_sof_dev *sdev = hda_stream->sdev;
+       struct sof_ipc_dai_config *config;
+       struct sof_ipc_reply reply;
+
+       config = hda_dai_update_config(w, channel);
+       if (!config) {
+               dev_err(sdev->dev, "error: no config for DAI %s\n", w->name);
+               return -ENOENT;
        }
 
-       return -EINVAL;
+       /* send DAI_CONFIG IPC */
+       return sof_ipc_tx_message(sdev->ipc, config->hdr.cmd, config, config->hdr.size,
+                                 &reply, sizeof(reply));
+}
+
+static int hda_link_dai_widget_update(struct sof_intel_hda_stream *hda_stream,
+                                     struct snd_soc_dapm_widget *w,
+                                     int channel, bool widget_setup)
+{
+       struct snd_sof_dev *sdev = hda_stream->sdev;
+       struct sof_ipc_dai_config *config;
+
+       config = hda_dai_update_config(w, channel);
+       if (!config) {
+               dev_err(sdev->dev, "error: no config for DAI %s\n", w->name);
+               return -ENOENT;
+       }
+
+       /* set up/free DAI widget and send DAI_CONFIG IPC */
+       if (widget_setup)
+               return hda_ctrl_dai_widget_setup(w);
+
+       return hda_ctrl_dai_widget_free(w);
 }
 
 static int hda_link_hw_params(struct snd_pcm_substream *substream,
@@ -208,6 +231,7 @@ static int hda_link_hw_params(struct snd_pcm_substream *substream,
        struct snd_soc_dai *codec_dai = asoc_rtd_to_codec(rtd, 0);
        struct sof_intel_hda_stream *hda_stream;
        struct hda_pipe_params p_params = {0};
+       struct snd_soc_dapm_widget *w;
        struct hdac_ext_link *link;
        int stream_tag;
        int ret;
@@ -226,9 +250,13 @@ static int hda_link_hw_params(struct snd_pcm_substream *substream,
 
        hda_stream = hstream_to_sof_hda_stream(link_dev);
 
-       /* update the DSP with the new tag */
-       ret = hda_link_config_ipc(hda_stream, dai->name, stream_tag - 1,
-                                 substream->stream);
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               w = dai->playback_widget;
+       else
+               w = dai->capture_widget;
+
+       /* set up the DAI widget and send the DAI_CONFIG with the new tag */
+       ret = hda_link_dai_widget_update(hda_stream, w, stream_tag - 1, true);
        if (ret < 0)
                return ret;
 
@@ -284,6 +312,7 @@ static int hda_link_pcm_trigger(struct snd_pcm_substream *substream,
                                snd_soc_dai_get_dma_data(dai, substream);
        struct sof_intel_hda_stream *hda_stream;
        struct snd_soc_pcm_runtime *rtd;
+       struct snd_soc_dapm_widget *w;
        struct hdac_ext_link *link;
        struct hdac_stream *hstream;
        struct hdac_bus *bus;
@@ -318,12 +347,16 @@ static int hda_link_pcm_trigger(struct snd_pcm_substream *substream,
                break;
        case SNDRV_PCM_TRIGGER_SUSPEND:
        case SNDRV_PCM_TRIGGER_STOP:
+               if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+                       w = dai->playback_widget;
+               else
+                       w = dai->capture_widget;
+
                /*
                 * clear link DMA channel. It will be assigned when
                 * hw_params is set up again after resume.
                 */
-               ret = hda_link_config_ipc(hda_stream, dai->name,
-                                         DMA_CHAN_INVALID, substream->stream);
+               ret = hda_link_config_ipc(hda_stream, w, DMA_CHAN_INVALID);
                if (ret < 0)
                        return ret;
 
@@ -354,6 +387,7 @@ static int hda_link_hw_free(struct snd_pcm_substream *substream,
        struct hdac_stream *hstream;
        struct snd_soc_pcm_runtime *rtd;
        struct hdac_ext_stream *link_dev;
+       struct snd_soc_dapm_widget *w;
        int ret;
 
        hstream = substream->runtime->private_data;
@@ -369,9 +403,13 @@ static int hda_link_hw_free(struct snd_pcm_substream *substream,
 
        hda_stream = hstream_to_sof_hda_stream(link_dev);
 
-       /* free the link DMA channel in the FW */
-       ret = hda_link_config_ipc(hda_stream, dai->name, DMA_CHAN_INVALID,
-                                 substream->stream);
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               w = dai->playback_widget;
+       else
+               w = dai->capture_widget;
+
+       /* free the link DMA channel in the FW and the DAI widget */
+       ret = hda_link_dai_widget_update(hda_stream, w, DMA_CHAN_INVALID, false);
        if (ret < 0)
                return ret;
 
@@ -401,61 +439,131 @@ static const struct snd_soc_dai_ops hda_link_dai_ops = {
        .prepare = hda_link_pcm_prepare,
 };
 
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_PROBES)
-#include "../compress.h"
-
-static struct snd_soc_cdai_ops sof_probe_compr_ops = {
-       .startup        = sof_probe_compr_open,
-       .shutdown       = sof_probe_compr_free,
-       .set_params     = sof_probe_compr_set_params,
-       .trigger        = sof_probe_compr_trigger,
-       .pointer        = sof_probe_compr_pointer,
+#endif
+
+/* only one flag used so far to harden hw_params/hw_free/trigger/prepare */
+struct ssp_dai_dma_data {
+       bool setup;
 };
 
-#endif
-#endif
+static int ssp_dai_setup_or_free(struct snd_pcm_substream *substream, struct snd_soc_dai *dai,
+                                bool setup)
+{
+       struct snd_soc_component *component;
+       struct snd_sof_widget *swidget;
+       struct snd_soc_dapm_widget *w;
+       struct sof_ipc_fw_version *v;
+       struct snd_sof_dev *sdev;
+
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               w = dai->playback_widget;
+       else
+               w = dai->capture_widget;
+
+       swidget = w->dobj.private;
+       component = swidget->scomp;
+       sdev = snd_soc_component_get_drvdata(component);
+       v = &sdev->fw_ready.version;
+
+       /* DAI_CONFIG IPC during hw_params is not supported in older firmware */
+       if (v->abi_version < SOF_ABI_VER(3, 18, 0))
+               return 0;
+
+       if (setup)
+               return hda_ctrl_dai_widget_setup(w);
+
+       return hda_ctrl_dai_widget_free(w);
+}
+
+static int ssp_dai_startup(struct snd_pcm_substream *substream,
+                          struct snd_soc_dai *dai)
+{
+       struct ssp_dai_dma_data *dma_data;
+
+       dma_data = kzalloc(sizeof(*dma_data), GFP_KERNEL);
+       if (!dma_data)
+               return -ENOMEM;
+
+       snd_soc_dai_set_dma_data(dai, substream, dma_data);
+
+       return 0;
+}
+
+static int ssp_dai_setup(struct snd_pcm_substream *substream,
+                        struct snd_soc_dai *dai,
+                        bool setup)
+{
+       struct ssp_dai_dma_data *dma_data;
+       int ret = 0;
+
+       dma_data = snd_soc_dai_get_dma_data(dai, substream);
+       if (!dma_data) {
+               dev_err(dai->dev, "%s: failed to get dma_data\n", __func__);
+               return -EIO;
+       }
+
+       if (dma_data->setup != setup) {
+               ret = ssp_dai_setup_or_free(substream, dai, setup);
+               if (!ret)
+                       dma_data->setup = setup;
+       }
+       return ret;
+}
 
 static int ssp_dai_hw_params(struct snd_pcm_substream *substream,
                             struct snd_pcm_hw_params *params,
                             struct snd_soc_dai *dai)
 {
-       struct snd_soc_pcm_runtime *rtd = asoc_substream_to_rtd(substream);
-       struct snd_soc_component *component = snd_soc_rtdcom_lookup(rtd, SOF_AUDIO_PCM_DRV_NAME);
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(component);
-       struct sof_ipc_fw_version *v = &sdev->fw_ready.version;
-       struct sof_ipc_dai_config *config;
-       struct snd_sof_dai *sof_dai;
-       struct sof_ipc_reply reply;
-       int ret;
+       /* params are ignored for now */
+       return ssp_dai_setup(substream, dai, true);
+}
 
-       /* DAI_CONFIG IPC during hw_params is not supported in older firmware */
-       if (v->abi_version < SOF_ABI_VER(3, 18, 0))
+static int ssp_dai_prepare(struct snd_pcm_substream *substream,
+                          struct snd_soc_dai *dai)
+{
+       /*
+        * the SSP will only be reconfigured during resume operations and
+        * not in case of xruns
+        */
+       return ssp_dai_setup(substream, dai, true);
+}
+
+static int ssp_dai_trigger(struct snd_pcm_substream *substream,
+                          int cmd, struct snd_soc_dai *dai)
+{
+       if (cmd != SNDRV_PCM_TRIGGER_SUSPEND)
                return 0;
 
-       list_for_each_entry(sof_dai, &sdev->dai_list, list) {
-               if (!sof_dai->cpu_dai_name || !sof_dai->dai_config)
-                       continue;
+       return ssp_dai_setup(substream, dai, false);
+}
 
-               if (!strcmp(dai->name, sof_dai->cpu_dai_name) &&
-                   substream->stream == sof_dai->comp_dai.direction) {
-                       config = &sof_dai->dai_config[sof_dai->current_config];
+static int ssp_dai_hw_free(struct snd_pcm_substream *substream,
+                          struct snd_soc_dai *dai)
+{
+       return ssp_dai_setup(substream, dai, false);
+}
 
-                       /* send IPC */
-                       ret = sof_ipc_tx_message(sdev->ipc, config->hdr.cmd, config,
-                                                config->hdr.size, &reply, sizeof(reply));
+static void ssp_dai_shutdown(struct snd_pcm_substream *substream,
+                            struct snd_soc_dai *dai)
+{
+       struct ssp_dai_dma_data *dma_data;
 
-                       if (ret < 0)
-                               dev_err(sdev->dev, "error: failed to set DAI config for %s\n",
-                                       sof_dai->name);
-                       return ret;
-               }
+       dma_data = snd_soc_dai_get_dma_data(dai, substream);
+       if (!dma_data) {
+               dev_err(dai->dev, "%s: failed to get dma_data\n", __func__);
+               return;
        }
-
-       return 0;
+       snd_soc_dai_set_dma_data(dai, substream, NULL);
+       kfree(dma_data);
 }
 
 static const struct snd_soc_dai_ops ssp_dai_ops = {
+       .startup = ssp_dai_startup,
        .hw_params = ssp_dai_hw_params,
+       .prepare = ssp_dai_prepare,
+       .trigger = ssp_dai_trigger,
+       .hw_free = ssp_dai_hw_free,
+       .shutdown = ssp_dai_shutdown,
 };
 
 /*
index 623cf29..058baca 100644 (file)
@@ -34,7 +34,7 @@ MODULE_PARM_DESC(enable_trace_D0I3_S0,
  * DSP Core control.
  */
 
-int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
+static int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        u32 adspcs;
        u32 reset;
@@ -73,7 +73,7 @@ int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev, unsigned int core_mask)
        return ret;
 }
 
-int hda_dsp_core_reset_leave(struct snd_sof_dev *sdev, unsigned int core_mask)
+static int hda_dsp_core_reset_leave(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        unsigned int crst;
        u32 adspcs;
@@ -113,7 +113,7 @@ int hda_dsp_core_reset_leave(struct snd_sof_dev *sdev, unsigned int core_mask)
        return ret;
 }
 
-int hda_dsp_core_stall_reset(struct snd_sof_dev *sdev, unsigned int core_mask)
+static int hda_dsp_core_stall_reset(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        /* stall core */
        snd_sof_dsp_update_bits_unlocked(sdev, HDA_DSP_BAR,
@@ -125,6 +125,31 @@ int hda_dsp_core_stall_reset(struct snd_sof_dev *sdev, unsigned int core_mask)
        return hda_dsp_core_reset_enter(sdev, core_mask);
 }
 
+static bool hda_dsp_core_is_enabled(struct snd_sof_dev *sdev, unsigned int core_mask)
+{
+       int val;
+       bool is_enable;
+
+       val = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_REG_ADSPCS);
+
+#define MASK_IS_EQUAL(v, m, field) ({  \
+       u32 _m = field(m);              \
+       ((v) & _m) == _m;               \
+})
+
+       is_enable = MASK_IS_EQUAL(val, core_mask, HDA_DSP_ADSPCS_CPA_MASK) &&
+               MASK_IS_EQUAL(val, core_mask, HDA_DSP_ADSPCS_SPA_MASK) &&
+               !(val & HDA_DSP_ADSPCS_CRST_MASK(core_mask)) &&
+               !(val & HDA_DSP_ADSPCS_CSTALL_MASK(core_mask));
+
+#undef MASK_IS_EQUAL
+
+       dev_dbg(sdev->dev, "DSP core(s) enabled? %d : core_mask %x\n",
+               is_enable, core_mask);
+
+       return is_enable;
+}
+
 int hda_dsp_core_run(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        int ret;
@@ -156,7 +181,7 @@ int hda_dsp_core_run(struct snd_sof_dev *sdev, unsigned int core_mask)
  * Power Management.
  */
 
-int hda_dsp_core_power_up(struct snd_sof_dev *sdev, unsigned int core_mask)
+static int hda_dsp_core_power_up(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        unsigned int cpa;
        u32 adspcs;
@@ -195,7 +220,7 @@ int hda_dsp_core_power_up(struct snd_sof_dev *sdev, unsigned int core_mask)
        return ret;
 }
 
-int hda_dsp_core_power_down(struct snd_sof_dev *sdev, unsigned int core_mask)
+static int hda_dsp_core_power_down(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        u32 adspcs;
        int ret;
@@ -218,32 +243,6 @@ int hda_dsp_core_power_down(struct snd_sof_dev *sdev, unsigned int core_mask)
        return ret;
 }
 
-bool hda_dsp_core_is_enabled(struct snd_sof_dev *sdev,
-                            unsigned int core_mask)
-{
-       int val;
-       bool is_enable;
-
-       val = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_REG_ADSPCS);
-
-#define MASK_IS_EQUAL(v, m, field) ({  \
-       u32 _m = field(m);              \
-       ((v) & _m) == _m;               \
-})
-
-       is_enable = MASK_IS_EQUAL(val, core_mask, HDA_DSP_ADSPCS_CPA_MASK) &&
-               MASK_IS_EQUAL(val, core_mask, HDA_DSP_ADSPCS_SPA_MASK) &&
-               !(val & HDA_DSP_ADSPCS_CRST_MASK(core_mask)) &&
-               !(val & HDA_DSP_ADSPCS_CSTALL_MASK(core_mask));
-
-#undef MASK_IS_EQUAL
-
-       dev_dbg(sdev->dev, "DSP core(s) enabled? %d : core_mask %x\n",
-               is_enable, core_mask);
-
-       return is_enable;
-}
-
 int hda_dsp_enable_core(struct snd_sof_dev *sdev, unsigned int core_mask)
 {
        struct sof_intel_hda_dev *hda = sdev->pdata->hw_pdata;
index acfeca4..11f20a5 100644 (file)
@@ -253,9 +253,9 @@ int hda_dsp_ipc_get_window_offset(struct snd_sof_dev *sdev, u32 id)
        return SRAM_WINDOW_OFFSET(id);
 }
 
-void hda_ipc_msg_data(struct snd_sof_dev *sdev,
-                     struct snd_pcm_substream *substream,
-                     void *p, size_t sz)
+int hda_ipc_msg_data(struct snd_sof_dev *sdev,
+                    struct snd_pcm_substream *substream,
+                    void *p, size_t sz)
 {
        if (!substream || !sdev->stream_box.size) {
                sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
@@ -268,10 +268,13 @@ void hda_ipc_msg_data(struct snd_sof_dev *sdev,
                                          hda_stream.hstream);
 
                /* The stream might already be closed */
-               if (hstream)
-                       sof_mailbox_read(sdev, hda_stream->stream.posn_offset,
-                                        p, sz);
+               if (!hstream)
+                       return -ESTRPIPE;
+
+               sof_mailbox_read(sdev, hda_stream->stream.posn_offset, p, sz);
        }
+
+       return 0;
 }
 
 int hda_ipc_pcm_params(struct snd_sof_dev *sdev,
index 6f4771b..abad6d0 100644 (file)
@@ -177,13 +177,13 @@ static int cl_dsp_init(struct snd_sof_dev *sdev, int stream_tag)
                        __func__);
 
 err:
-       flags = SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX;
+       flags = SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_OPTIONAL;
 
-       /* force error log level after max boot attempts */
+       /* after max boot attempts make sure that the dump is printed */
        if (hda->boot_iteration == HDA_FW_BOOT_ATTEMPTS)
-               flags |= SOF_DBG_DUMP_FORCE_ERR_LEVEL;
+               flags &= ~SOF_DBG_DUMP_OPTIONAL;
 
-       hda_dsp_dump(sdev, flags);
+       snd_sof_dsp_dbg_dump(sdev, flags);
        snd_sof_dsp_core_power_down(sdev, chip->host_managed_cores_mask);
 
        return ret;
@@ -414,8 +414,7 @@ int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev)
        if (!ret) {
                dev_dbg(sdev->dev, "Firmware download successful, booting...\n");
        } else {
-               hda_dsp_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX |
-                            SOF_DBG_DUMP_FORCE_ERR_LEVEL);
+               snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_MBOX);
                dev_err(sdev->dev, "error: load fw failed ret: %d\n", ret);
        }
 
diff --git a/sound/soc/sof/intel/hda-probes.c b/sound/soc/sof/intel/hda-probes.c
new file mode 100644 (file)
index 0000000..fe2f3f7
--- /dev/null
@@ -0,0 +1,114 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license.  When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
+//
+// Author: Cezary Rojewski <cezary.rojewski@intel.com>
+//
+
+#include <sound/hdaudio_ext.h>
+#include <sound/soc.h>
+#include "../sof-priv.h"
+#include "hda.h"
+
+static inline struct hdac_ext_stream *
+hda_compr_get_stream(struct snd_compr_stream *cstream)
+{
+       return cstream->runtime->private_data;
+}
+
+int hda_probe_compr_assign(struct snd_sof_dev *sdev,
+                          struct snd_compr_stream *cstream,
+                          struct snd_soc_dai *dai)
+{
+       struct hdac_ext_stream *stream;
+
+       stream = hda_dsp_stream_get(sdev, cstream->direction, 0);
+       if (!stream)
+               return -EBUSY;
+
+       hdac_stream(stream)->curr_pos = 0;
+       hdac_stream(stream)->cstream = cstream;
+       cstream->runtime->private_data = stream;
+
+       return hdac_stream(stream)->stream_tag;
+}
+
+int hda_probe_compr_free(struct snd_sof_dev *sdev,
+                        struct snd_compr_stream *cstream,
+                        struct snd_soc_dai *dai)
+{
+       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
+       int ret;
+
+       ret = hda_dsp_stream_put(sdev, cstream->direction,
+                                hdac_stream(stream)->stream_tag);
+       if (ret < 0) {
+               dev_dbg(sdev->dev, "stream put failed: %d\n", ret);
+               return ret;
+       }
+
+       hdac_stream(stream)->cstream = NULL;
+       cstream->runtime->private_data = NULL;
+
+       return 0;
+}
+
+int hda_probe_compr_set_params(struct snd_sof_dev *sdev,
+                              struct snd_compr_stream *cstream,
+                              struct snd_compr_params *params,
+                              struct snd_soc_dai *dai)
+{
+       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
+       struct hdac_stream *hstream = hdac_stream(stream);
+       struct snd_dma_buffer *dmab;
+       u32 bits, rate;
+       int bps, ret;
+
+       dmab = cstream->runtime->dma_buffer_p;
+       /* compr params do not store bit depth, default to S32_LE */
+       bps = snd_pcm_format_physical_width(SNDRV_PCM_FORMAT_S32_LE);
+       if (bps < 0)
+               return bps;
+       bits = hda_dsp_get_bits(sdev, bps);
+       rate = hda_dsp_get_mult_div(sdev, params->codec.sample_rate);
+
+       hstream->format_val = rate | bits | (params->codec.ch_out - 1);
+       hstream->bufsize = cstream->runtime->buffer_size;
+       hstream->period_bytes = cstream->runtime->fragment_size;
+       hstream->no_period_wakeup = 0;
+
+       ret = hda_dsp_stream_hw_params(sdev, stream, dmab, NULL);
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: hdac prepare failed: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+int hda_probe_compr_trigger(struct snd_sof_dev *sdev,
+                           struct snd_compr_stream *cstream, int cmd,
+                           struct snd_soc_dai *dai)
+{
+       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
+
+       return hda_dsp_stream_trigger(sdev, stream, cmd);
+}
+
+int hda_probe_compr_pointer(struct snd_sof_dev *sdev,
+                           struct snd_compr_stream *cstream,
+                           struct snd_compr_tstamp *tstamp,
+                           struct snd_soc_dai *dai)
+{
+       struct hdac_ext_stream *stream = hda_compr_get_stream(cstream);
+       struct snd_soc_pcm_stream *pstream;
+
+       pstream = &dai->driver->capture;
+       tstamp->copied_total = hdac_stream(stream)->curr_pos;
+       tstamp->sampling_rate = snd_pcm_rate_bit_to_rate(pstream->rates);
+
+       return 0;
+}
index 63c3674..1d845c2 100644 (file)
 
 #define HDA_LTRP_GB_VALUE_US   95
 
+static inline const char *hda_hstream_direction_str(struct hdac_stream *hstream)
+{
+       if (hstream->direction == SNDRV_PCM_STREAM_PLAYBACK)
+               return "Playback";
+       else
+               return "Capture";
+}
+
+static char *hda_hstream_dbg_get_stream_info_str(struct hdac_stream *hstream)
+{
+       struct snd_soc_pcm_runtime *rtd;
+
+       if (hstream->substream)
+               rtd = asoc_substream_to_rtd(hstream->substream);
+       else if (hstream->cstream)
+               rtd = hstream->cstream->private_data;
+       else
+               /* Non audio DMA user, like dma-trace */
+               return kasprintf(GFP_KERNEL, "-- (%s, stream_tag: %u)",
+                                hda_hstream_direction_str(hstream),
+                                hstream->stream_tag);
+
+       return kasprintf(GFP_KERNEL, "dai_link \"%s\" (%s, stream_tag: %u)",
+                        rtd->dai_link->name, hda_hstream_direction_str(hstream),
+                        hstream->stream_tag);
+}
+
 /*
  * set up one of BDL entries for a stream
  */
@@ -89,13 +116,13 @@ int hda_dsp_stream_setup_bdl(struct snd_sof_dev *sdev,
        int remain, ioc;
 
        period_bytes = stream->period_bytes;
-       dev_dbg(sdev->dev, "period_bytes:0x%x\n", period_bytes);
+       dev_dbg(sdev->dev, "%s: period_bytes:0x%x\n", __func__, period_bytes);
        if (!period_bytes)
                period_bytes = stream->bufsize;
 
        periods = stream->bufsize / period_bytes;
 
-       dev_dbg(sdev->dev, "periods:%d\n", periods);
+       dev_dbg(sdev->dev, "%s: periods:%d\n", __func__, periods);
 
        remain = stream->bufsize % period_bytes;
        if (remain)
@@ -244,7 +271,8 @@ int hda_dsp_stream_put(struct snd_sof_dev *sdev, int direction, int stream_tag)
                                        HDA_VS_INTEL_EM2_L1SEN, HDA_VS_INTEL_EM2_L1SEN);
 
        if (!found) {
-               dev_dbg(sdev->dev, "stream_tag %d not opened!\n", stream_tag);
+               dev_dbg(sdev->dev, "%s: stream_tag %d not opened!\n",
+                       __func__, stream_tag);
                return -ENODEV;
        }
 
@@ -257,7 +285,7 @@ int hda_dsp_stream_trigger(struct snd_sof_dev *sdev,
        struct hdac_stream *hstream = &stream->hstream;
        int sd_offset = SOF_STREAM_SD_OFFSET(hstream);
        u32 dma_start = SOF_HDA_SD_CTL_DMA_START;
-       int ret;
+       int ret = 0;
        u32 run;
 
        /* cmd must be for audio stream */
@@ -283,14 +311,9 @@ int hda_dsp_stream_trigger(struct snd_sof_dev *sdev,
                                        HDA_DSP_REG_POLL_INTERVAL_US,
                                        HDA_DSP_STREAM_RUN_TIMEOUT);
 
-               if (ret < 0) {
-                       dev_err(sdev->dev,
-                               "error: %s: cmd %d: timeout on STREAM_SD_OFFSET read\n",
-                               __func__, cmd);
-                       return ret;
-               }
+               if (ret >= 0)
+                       hstream->running = true;
 
-               hstream->running = true;
                break;
        case SNDRV_PCM_TRIGGER_SUSPEND:
        case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
@@ -306,27 +329,32 @@ int hda_dsp_stream_trigger(struct snd_sof_dev *sdev,
                                                HDA_DSP_REG_POLL_INTERVAL_US,
                                                HDA_DSP_STREAM_RUN_TIMEOUT);
 
-               if (ret < 0) {
-                       dev_err(sdev->dev,
-                               "error: %s: cmd %d: timeout on STREAM_SD_OFFSET read\n",
-                               __func__, cmd);
-                       return ret;
-               }
+               if (ret >= 0) {
+                       snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR,
+                                         sd_offset + SOF_HDA_ADSP_REG_CL_SD_STS,
+                                         SOF_HDA_CL_DMA_SD_INT_MASK);
 
-               snd_sof_dsp_write(sdev, HDA_DSP_HDA_BAR, sd_offset +
-                                 SOF_HDA_ADSP_REG_CL_SD_STS,
-                                 SOF_HDA_CL_DMA_SD_INT_MASK);
-
-               hstream->running = false;
-               snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR, SOF_HDA_INTCTL,
-                                       1 << hstream->index, 0x0);
+                       hstream->running = false;
+                       snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,
+                                               SOF_HDA_INTCTL,
+                                               1 << hstream->index, 0x0);
+               }
                break;
        default:
                dev_err(sdev->dev, "error: unknown command: %d\n", cmd);
                return -EINVAL;
        }
 
-       return 0;
+       if (ret < 0) {
+               char *stream_name = hda_hstream_dbg_get_stream_info_str(hstream);
+
+               dev_err(sdev->dev,
+                       "%s: cmd %d on %s: timeout on STREAM_SD_OFFSET read\n",
+                       __func__, cmd, stream_name ? stream_name : "unknown stream");
+               kfree(stream_name);
+       }
+
+       return ret;
 }
 
 /* minimal recommended programming for ICCMAX stream */
@@ -440,9 +468,12 @@ int hda_dsp_stream_hw_params(struct snd_sof_dev *sdev,
                                            HDA_DSP_STREAM_RUN_TIMEOUT);
 
        if (ret < 0) {
+               char *stream_name = hda_hstream_dbg_get_stream_info_str(hstream);
+
                dev_err(sdev->dev,
-                       "error: %s: timeout on STREAM_SD_OFFSET read1\n",
-                       __func__);
+                       "%s: on %s: timeout on STREAM_SD_OFFSET read1\n",
+                       __func__, stream_name ? stream_name : "unknown stream");
+               kfree(stream_name);
                return ret;
        }
 
@@ -506,9 +537,12 @@ int hda_dsp_stream_hw_params(struct snd_sof_dev *sdev,
                                            HDA_DSP_STREAM_RUN_TIMEOUT);
 
        if (ret < 0) {
+               char *stream_name = hda_hstream_dbg_get_stream_info_str(hstream);
+
                dev_err(sdev->dev,
-                       "error: %s: timeout on STREAM_SD_OFFSET read2\n",
-                       __func__);
+                       "%s: on %s: timeout on STREAM_SD_OFFSET read1\n",
+                       __func__, stream_name ? stream_name : "unknown stream");
+               kfree(stream_name);
                return ret;
        }
 
index f60e2c5..883d78d 100644 (file)
 #define EXCEPT_MAX_HDR_SIZE    0x400
 #define HDA_EXT_ROM_STATUS_SIZE 8
 
+int hda_ctrl_dai_widget_setup(struct snd_soc_dapm_widget *w)
+{
+       struct snd_sof_widget *swidget = w->dobj.private;
+       struct snd_soc_component *component = swidget->scomp;
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(component);
+       struct sof_ipc_dai_config *config;
+       struct snd_sof_dai *sof_dai;
+       struct sof_ipc_reply reply;
+       int ret;
+
+       sof_dai = swidget->private;
+
+       if (!sof_dai || !sof_dai->dai_config) {
+               dev_err(sdev->dev, "No config for DAI %s\n", w->name);
+               return -EINVAL;
+       }
+
+       config = &sof_dai->dai_config[sof_dai->current_config];
+
+       /*
+        * For static pipelines, the DAI widget would already be set up and calling
+        * sof_widget_setup() simply returns without doing anything.
+        * For dynamic pipelines, the DAI widget will be set up now.
+        */
+       ret = sof_widget_setup(sdev, swidget);
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed setting up DAI widget %s\n", w->name);
+               return ret;
+       }
+
+       /* set HW_PARAMS flag */
+       config->flags = FIELD_PREP(SOF_DAI_CONFIG_FLAGS_MASK, SOF_DAI_CONFIG_FLAGS_HW_PARAMS);
+
+       /* send DAI_CONFIG IPC */
+       ret = sof_ipc_tx_message(sdev->ipc, config->hdr.cmd, config, config->hdr.size,
+                                &reply, sizeof(reply));
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed setting DAI config for %s\n", w->name);
+               return ret;
+       }
+
+       sof_dai->configured = true;
+
+       return 0;
+}
+
+int hda_ctrl_dai_widget_free(struct snd_soc_dapm_widget *w)
+{
+       struct snd_sof_widget *swidget = w->dobj.private;
+       struct snd_soc_component *component = swidget->scomp;
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(component);
+       struct sof_ipc_dai_config *config;
+       struct snd_sof_dai *sof_dai;
+       struct sof_ipc_reply reply;
+       int ret;
+
+       sof_dai = swidget->private;
+
+       if (!sof_dai || !sof_dai->dai_config) {
+               dev_err(sdev->dev, "error: No config to free DAI %s\n", w->name);
+               return -EINVAL;
+       }
+
+       /* nothing to do if hw_free() is called without restarting the stream after resume. */
+       if (!sof_dai->configured)
+               return 0;
+
+       config = &sof_dai->dai_config[sof_dai->current_config];
+
+       /* set HW_FREE flag */
+       config->flags = FIELD_PREP(SOF_DAI_CONFIG_FLAGS_MASK, SOF_DAI_CONFIG_FLAGS_HW_FREE);
+
+       ret = sof_ipc_tx_message(sdev->ipc, config->hdr.cmd, config, config->hdr.size,
+                                &reply, sizeof(reply));
+       if (ret < 0)
+               dev_err(sdev->dev, "error: failed resetting DAI config for %s\n", w->name);
+
+       /*
+        * Reset the configured_flag and free the widget even if the IPC fails to keep
+        * the widget use_count balanced
+        */
+       sof_dai->configured = false;
+
+       return sof_widget_free(sdev, swidget);
+}
+
 static const struct sof_intel_dsp_desc
        *get_chip_info(struct snd_sof_pdata *pdata)
 {
@@ -64,67 +150,70 @@ static int sdw_clock_stop_quirks = SDW_INTEL_CLK_STOP_BUS_RESET;
 module_param(sdw_clock_stop_quirks, int, 0444);
 MODULE_PARM_DESC(sdw_clock_stop_quirks, "SOF SoundWire clock stop quirks");
 
+static int sdw_dai_config_ipc(struct snd_sof_dev *sdev,
+                             struct snd_soc_dapm_widget *w,
+                             int link_id, int alh_stream_id, int dai_id, bool setup)
+{
+       struct snd_sof_widget *swidget = w->dobj.private;
+       struct sof_ipc_dai_config *config;
+       struct snd_sof_dai *sof_dai;
+
+       if (!swidget) {
+               dev_err(sdev->dev, "error: No private data for widget %s\n", w->name);
+               return -EINVAL;
+       }
+
+       sof_dai = swidget->private;
+
+       if (!sof_dai || !sof_dai->dai_config) {
+               dev_err(sdev->dev, "error: No config for DAI %s\n", w->name);
+               return -EINVAL;
+       }
+
+       config = &sof_dai->dai_config[sof_dai->current_config];
+
+       /* update config with link and stream ID */
+       config->dai_index = (link_id << 8) | dai_id;
+       config->alh.stream_id = alh_stream_id;
+
+       if (setup)
+               return hda_ctrl_dai_widget_setup(w);
+
+       return hda_ctrl_dai_widget_free(w);
+}
+
 static int sdw_params_stream(struct device *dev,
                             struct sdw_intel_stream_params_data *params_data)
 {
+       struct snd_pcm_substream *substream = params_data->substream;
        struct snd_sof_dev *sdev = dev_get_drvdata(dev);
        struct snd_soc_dai *d = params_data->dai;
-       struct sof_ipc_dai_config config;
-       struct sof_ipc_reply reply;
-       int link_id = params_data->link_id;
-       int alh_stream_id = params_data->alh_stream_id;
-       int ret;
-       u32 size = sizeof(config);
-
-       memset(&config, 0, size);
-       config.hdr.size = size;
-       config.hdr.cmd = SOF_IPC_GLB_DAI_MSG | SOF_IPC_DAI_CONFIG;
-       config.type = SOF_DAI_INTEL_ALH;
-       config.dai_index = (link_id << 8) | (d->id);
-       config.alh.stream_id = alh_stream_id;
-
-       /* send message to DSP */
-       ret = sof_ipc_tx_message(sdev->ipc,
-                                config.hdr.cmd, &config, size, &reply,
-                                sizeof(reply));
-       if (ret < 0) {
-               dev_err(sdev->dev,
-                       "error: failed to set DAI hw_params for link %d dai->id %d ALH %d\n",
-                       link_id, d->id, alh_stream_id);
-       }
+       struct snd_soc_dapm_widget *w;
 
-       return ret;
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               w = d->playback_widget;
+       else
+               w = d->capture_widget;
+
+       return sdw_dai_config_ipc(sdev, w, params_data->link_id, params_data->alh_stream_id,
+                                 d->id, true);
 }
 
 static int sdw_free_stream(struct device *dev,
                           struct sdw_intel_stream_free_data *free_data)
 {
+       struct snd_pcm_substream *substream = free_data->substream;
        struct snd_sof_dev *sdev = dev_get_drvdata(dev);
        struct snd_soc_dai *d = free_data->dai;
-       struct sof_ipc_dai_config config;
-       struct sof_ipc_reply reply;
-       int link_id = free_data->link_id;
-       int ret;
-       u32 size = sizeof(config);
-
-       memset(&config, 0, size);
-       config.hdr.size = size;
-       config.hdr.cmd = SOF_IPC_GLB_DAI_MSG | SOF_IPC_DAI_CONFIG;
-       config.type = SOF_DAI_INTEL_ALH;
-       config.dai_index = (link_id << 8) | d->id;
-       config.alh.stream_id = 0xFFFF; /* invalid value on purpose */
-
-       /* send message to DSP */
-       ret = sof_ipc_tx_message(sdev->ipc,
-                                config.hdr.cmd, &config, size, &reply,
-                                sizeof(reply));
-       if (ret < 0) {
-               dev_err(sdev->dev,
-                       "error: failed to free stream for link %d dai->id %d\n",
-                       link_id, d->id);
-       }
+       struct snd_soc_dapm_widget *w;
 
-       return ret;
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
+               w = d->playback_widget;
+       else
+               w = d->capture_widget;
+
+       /* send invalid stream_id */
+       return sdw_dai_config_ipc(sdev, w, free_data->link_id, 0xFFFF, d->id, false);
 }
 
 static const struct sdw_intel_ops sdw_callback = {
@@ -294,7 +383,38 @@ void hda_sdw_process_wakeen(struct snd_sof_dev *sdev)
        sdw_intel_process_wakeen_event(hdev->sdw);
 }
 
-#endif
+#else /* IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE) */
+static inline int hda_sdw_acpi_scan(struct snd_sof_dev *sdev)
+{
+       return 0;
+}
+
+static inline int hda_sdw_probe(struct snd_sof_dev *sdev)
+{
+       return 0;
+}
+
+static inline int hda_sdw_exit(struct snd_sof_dev *sdev)
+{
+       return 0;
+}
+
+static inline bool hda_dsp_check_sdw_irq(struct snd_sof_dev *sdev)
+{
+       return false;
+}
+
+static inline irqreturn_t hda_dsp_sdw_thread(int irq, void *context)
+{
+       return IRQ_HANDLED;
+}
+
+static inline bool hda_sdw_check_wakeen_irq(struct snd_sof_dev *sdev)
+{
+       return false;
+}
+
+#endif /* IS_ENABLED(CONFIG_SND_SOC_SOF_INTEL_SOUNDWIRE) */
 
 /*
  * Debug
@@ -412,8 +532,7 @@ static void hda_dsp_dump_ext_rom_status(struct snd_sof_dev *sdev, u32 flags)
                len += snprintf(msg + len, sizeof(msg) - len, " 0x%x", value);
        }
 
-       sof_dev_dbg_or_err(sdev->dev, flags & SOF_DBG_DUMP_FORCE_ERR_LEVEL,
-                          "extended rom status: %s", msg);
+       dev_err(sdev->dev, "extended rom status: %s", msg);
 
 }
 
@@ -426,8 +545,7 @@ void hda_dsp_dump(struct snd_sof_dev *sdev, u32 flags)
        /* print ROM/FW status */
        hda_dsp_get_status(sdev);
 
-       /* print panic info if FW boot is complete. Otherwise, print the extended ROM status */
-       if (sdev->fw_state == SOF_FW_BOOT_COMPLETE) {
+       if (flags & SOF_DBG_DUMP_REGS) {
                u32 status = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_SRAM_REG_FW_STATUS);
                u32 panic = snd_sof_dsp_read(sdev, HDA_DSP_BAR, HDA_DSP_SRAM_REG_FW_TRACEP);
 
@@ -456,12 +574,9 @@ void hda_ipc_irq_dump(struct snd_sof_dev *sdev)
        ppsts = snd_sof_dsp_read(sdev, HDA_DSP_PP_BAR, SOF_HDA_REG_PP_PPSTS);
        rirbsts = snd_hdac_chip_readb(bus, RIRBSTS);
 
-       dev_err(sdev->dev,
-               "error: hda irq intsts 0x%8.8x intlctl 0x%8.8x rirb %2.2x\n",
+       dev_err(sdev->dev, "hda irq intsts 0x%8.8x intlctl 0x%8.8x rirb %2.2x\n",
                intsts, intctl, rirbsts);
-       dev_err(sdev->dev,
-               "error: dsp irq ppsts 0x%8.8x adspis 0x%8.8x\n",
-               ppsts, adspis);
+       dev_err(sdev->dev, "dsp irq ppsts 0x%8.8x adspis 0x%8.8x\n", ppsts, adspis);
 }
 
 void hda_ipc_dump(struct snd_sof_dev *sdev)
@@ -479,8 +594,7 @@ void hda_ipc_dump(struct snd_sof_dev *sdev)
 
        /* dump the IPC regs */
        /* TODO: parse the raw msg */
-       dev_err(sdev->dev,
-               "error: host status 0x%8.8x dsp status 0x%8.8x mask 0x%8.8x\n",
+       dev_err(sdev->dev, "host status 0x%8.8x dsp status 0x%8.8x mask 0x%8.8x\n",
                hipcie, hipct, hipcctl);
 }
 
index 4fdfb10..1195018 100644 (file)
@@ -492,17 +492,8 @@ struct sof_intel_hda_stream {
  */
 int hda_dsp_probe(struct snd_sof_dev *sdev);
 int hda_dsp_remove(struct snd_sof_dev *sdev);
-int hda_dsp_core_reset_enter(struct snd_sof_dev *sdev,
-                            unsigned int core_mask);
-int hda_dsp_core_reset_leave(struct snd_sof_dev *sdev,
-                            unsigned int core_mask);
-int hda_dsp_core_stall_reset(struct snd_sof_dev *sdev, unsigned int core_mask);
 int hda_dsp_core_run(struct snd_sof_dev *sdev, unsigned int core_mask);
-int hda_dsp_core_power_up(struct snd_sof_dev *sdev, unsigned int core_mask);
 int hda_dsp_enable_core(struct snd_sof_dev *sdev, unsigned int core_mask);
-int hda_dsp_core_power_down(struct snd_sof_dev *sdev, unsigned int core_mask);
-bool hda_dsp_core_is_enabled(struct snd_sof_dev *sdev,
-                            unsigned int core_mask);
 int hda_dsp_core_reset_power_down(struct snd_sof_dev *sdev,
                                  unsigned int core_mask);
 void hda_dsp_ipc_int_enable(struct snd_sof_dev *sdev);
@@ -572,9 +563,9 @@ int hda_dsp_stream_spib_config(struct snd_sof_dev *sdev,
                               struct hdac_ext_stream *stream,
                               int enable, u32 size);
 
-void hda_ipc_msg_data(struct snd_sof_dev *sdev,
-                     struct snd_pcm_substream *substream,
-                     void *p, size_t sz);
+int hda_ipc_msg_data(struct snd_sof_dev *sdev,
+                    struct snd_pcm_substream *substream,
+                    void *p, size_t sz);
 int hda_ipc_pcm_params(struct snd_sof_dev *sdev,
                       struct snd_pcm_substream *substream,
                       const struct sof_ipc_pcm_params_reply *reply);
@@ -619,8 +610,6 @@ int hda_dsp_ipc_cmd_done(struct snd_sof_dev *sdev, int dir);
  */
 int hda_dsp_cl_boot_firmware(struct snd_sof_dev *sdev);
 int hda_dsp_cl_boot_firmware_iccmax(struct snd_sof_dev *sdev);
-int hda_dsp_cl_boot_firmware_iccmax_icl(struct snd_sof_dev *sdev);
-int hda_dsp_cl_boot_firmware_skl(struct snd_sof_dev *sdev);
 
 /* pre and post fw run ops */
 int hda_dsp_pre_fw_run(struct snd_sof_dev *sdev);
@@ -695,45 +684,15 @@ bool hda_common_check_sdw_irq(struct snd_sof_dev *sdev);
 
 #else
 
-static inline int hda_sdw_acpi_scan(struct snd_sof_dev *sdev)
-{
-       return 0;
-}
-
-static inline int hda_sdw_probe(struct snd_sof_dev *sdev)
-{
-       return 0;
-}
-
 static inline int hda_sdw_startup(struct snd_sof_dev *sdev)
 {
        return 0;
 }
 
-static inline int hda_sdw_exit(struct snd_sof_dev *sdev)
-{
-       return 0;
-}
-
 static inline void hda_sdw_int_enable(struct snd_sof_dev *sdev, bool enable)
 {
 }
 
-static inline bool hda_dsp_check_sdw_irq(struct snd_sof_dev *sdev)
-{
-       return false;
-}
-
-static inline irqreturn_t hda_dsp_sdw_thread(int irq, void *context)
-{
-       return IRQ_HANDLED;
-}
-
-static inline bool hda_sdw_check_wakeen_irq(struct snd_sof_dev *sdev)
-{
-       return false;
-}
-
 static inline void hda_sdw_process_wakeen(struct snd_sof_dev *sdev)
 {
 }
@@ -774,4 +733,9 @@ void hda_set_mach_params(const struct snd_soc_acpi_mach *mach,
 /* PCI driver selection and probe */
 int hda_pci_intel_probe(struct pci_dev *pci, const struct pci_device_id *pci_id);
 
+struct snd_sof_dai;
+struct sof_ipc_dai_config;
+int hda_ctrl_dai_widget_setup(struct snd_soc_dapm_widget *w);
+int hda_ctrl_dai_widget_free(struct snd_soc_dapm_widget *w);
+
 #endif
index ee095b8..0b2cc33 100644 (file)
@@ -41,6 +41,10 @@ const struct snd_sof_dsp_ops sof_icl_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_thread     = cnl_ipc_irq_thread,
 
@@ -64,6 +68,7 @@ const struct snd_sof_dsp_ops sof_icl_ops = {
        .debug_map_count        = ARRAY_SIZE(icl_dsp_debugfs),
        .dbg_dump       = hda_dsp_dump,
        .ipc_dump       = cnl_ipc_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
        .pcm_open       = hda_dsp_pcm_open,
@@ -125,7 +130,7 @@ const struct snd_sof_dsp_ops sof_icl_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 EXPORT_SYMBOL_NS(sof_icl_ops, SND_SOC_SOF_INTEL_HDA_COMMON);
 
diff --git a/sound/soc/sof/intel/intel-ipc.c b/sound/soc/sof/intel/intel-ipc.c
deleted file mode 100644 (file)
index de66f8a..0000000
+++ /dev/null
@@ -1,99 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
-//
-// This file is provided under a dual BSD/GPLv2 license.  When using or
-// redistributing this file, you may do so under either license.
-//
-// Copyright(c) 2019 Intel Corporation. All rights reserved.
-//
-// Authors: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
-
-/* Intel-specific SOF IPC code */
-
-#include <linux/device.h>
-#include <linux/export.h>
-#include <linux/module.h>
-#include <linux/types.h>
-
-#include <sound/pcm.h>
-#include <sound/sof/stream.h>
-
-#include "../ops.h"
-#include "../sof-priv.h"
-
-struct intel_stream {
-       size_t posn_offset;
-};
-
-/* Mailbox-based Intel IPC implementation */
-void intel_ipc_msg_data(struct snd_sof_dev *sdev,
-                       struct snd_pcm_substream *substream,
-                       void *p, size_t sz)
-{
-       if (!substream || !sdev->stream_box.size) {
-               sof_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
-       } else {
-               struct intel_stream *stream = substream->runtime->private_data;
-
-               /* The stream might already be closed */
-               if (stream)
-                       sof_mailbox_read(sdev, stream->posn_offset, p, sz);
-       }
-}
-EXPORT_SYMBOL_NS(intel_ipc_msg_data, SND_SOC_SOF_INTEL_HIFI_EP_IPC);
-
-int intel_ipc_pcm_params(struct snd_sof_dev *sdev,
-                        struct snd_pcm_substream *substream,
-                        const struct sof_ipc_pcm_params_reply *reply)
-{
-       struct intel_stream *stream = substream->runtime->private_data;
-       size_t posn_offset = reply->posn_offset;
-
-       /* check if offset is overflow or it is not aligned */
-       if (posn_offset > sdev->stream_box.size ||
-           posn_offset % sizeof(struct sof_ipc_stream_posn) != 0)
-               return -EINVAL;
-
-       stream->posn_offset = sdev->stream_box.offset + posn_offset;
-
-       dev_dbg(sdev->dev, "pcm: stream dir %d, posn mailbox offset is %zu",
-               substream->stream, stream->posn_offset);
-
-       return 0;
-}
-EXPORT_SYMBOL_NS(intel_ipc_pcm_params, SND_SOC_SOF_INTEL_HIFI_EP_IPC);
-
-int intel_pcm_open(struct snd_sof_dev *sdev,
-                  struct snd_pcm_substream *substream)
-{
-       struct intel_stream *stream = kmalloc(sizeof(*stream), GFP_KERNEL);
-
-       if (!stream)
-               return -ENOMEM;
-
-       /* binding pcm substream to hda stream */
-       substream->runtime->private_data = stream;
-
-       /* align to DMA minimum transfer size */
-       snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, 4);
-
-       /* avoid circular buffer wrap in middle of period */
-       snd_pcm_hw_constraint_integer(substream->runtime,
-                                     SNDRV_PCM_HW_PARAM_PERIODS);
-
-       return 0;
-}
-EXPORT_SYMBOL_NS(intel_pcm_open, SND_SOC_SOF_INTEL_HIFI_EP_IPC);
-
-int intel_pcm_close(struct snd_sof_dev *sdev,
-                   struct snd_pcm_substream *substream)
-{
-       struct intel_stream *stream = substream->runtime->private_data;
-
-       substream->runtime->private_data = NULL;
-       kfree(stream);
-
-       return 0;
-}
-EXPORT_SYMBOL_NS(intel_pcm_close, SND_SOC_SOF_INTEL_HIFI_EP_IPC);
-
-MODULE_LICENSE("Dual BSD/GPL");
index f89e746..a023b3c 100644 (file)
@@ -26,7 +26,6 @@ static const struct sof_dev_desc bxt_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &apl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -42,7 +41,6 @@ static const struct sof_dev_desc glk_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &apl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
index f23257a..40cf1cd 100644 (file)
@@ -27,7 +27,6 @@ static const struct sof_dev_desc cnl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &cnl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -44,7 +43,6 @@ static const struct sof_dev_desc cfl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &cnl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -61,7 +59,6 @@ static const struct sof_dev_desc cml_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &cnl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
index 2f60c28..39c8412 100644 (file)
@@ -27,7 +27,6 @@ static const struct sof_dev_desc icl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &icl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -43,7 +42,6 @@ static const struct sof_dev_desc jsl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &jsl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
index d04ce84..f2ea34d 100644 (file)
@@ -27,7 +27,6 @@ static const struct sof_dev_desc tgl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &tgl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -44,7 +43,6 @@ static const struct sof_dev_desc tglh_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &tglh_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -60,7 +58,6 @@ static const struct sof_dev_desc ehl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &ehl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -77,7 +74,6 @@ static const struct sof_dev_desc adls_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &adls_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
@@ -94,7 +90,6 @@ static const struct sof_dev_desc adl_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = -1,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &tgl_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
index 4bded66..18eb41b 100644 (file)
@@ -142,6 +142,10 @@ const struct snd_sof_dsp_ops sof_tng_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_handler    = atom_irq_handler,
        .irq_thread     = atom_irq_thread,
@@ -152,8 +156,8 @@ const struct snd_sof_dsp_ops sof_tng_ops = {
        .get_mailbox_offset = atom_get_mailbox_offset,
        .get_window_offset = atom_get_window_offset,
 
-       .ipc_msg_data   = intel_ipc_msg_data,
-       .ipc_pcm_params = intel_ipc_pcm_params,
+       .ipc_msg_data   = sof_ipc_msg_data,
+       .ipc_pcm_params = sof_ipc_pcm_params,
 
        /* machine driver */
        .machine_select = atom_machine_select,
@@ -165,10 +169,11 @@ const struct snd_sof_dsp_ops sof_tng_ops = {
        .debug_map      = tng_debugfs,
        .debug_map_count        = ARRAY_SIZE(tng_debugfs),
        .dbg_dump       = atom_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
-       .pcm_open       = intel_pcm_open,
-       .pcm_close      = intel_pcm_close,
+       .pcm_open       = sof_stream_pcm_open,
+       .pcm_close      = sof_stream_pcm_close,
 
        /* module loading */
        .load_module    = snd_sof_parse_module_memcpy,
@@ -187,7 +192,7 @@ const struct snd_sof_dsp_ops sof_tng_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_BATCH,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 
 const struct sof_intel_dsp_desc tng_chip_info = {
@@ -201,7 +206,6 @@ static const struct sof_dev_desc tng_desc = {
        .resindex_pcicfg_base   = -1,
        .resindex_imr_base      = 0,
        .irqindex_host_ipc      = -1,
-       .resindex_dma_base      = -1,
        .chip_info = &tng_chip_info,
        .default_fw_path = "intel/sof",
        .default_tplg_path = "intel/sof-tplg",
index 199d41a..48da8e7 100644 (file)
@@ -37,6 +37,10 @@ const struct snd_sof_dsp_ops sof_tgl_ops = {
        .block_read     = sof_block_read,
        .block_write    = sof_block_write,
 
+       /* Mailbox IO */
+       .mailbox_read   = sof_mailbox_read,
+       .mailbox_write  = sof_mailbox_write,
+
        /* doorbell */
        .irq_thread     = cnl_ipc_irq_thread,
 
@@ -60,6 +64,7 @@ const struct snd_sof_dsp_ops sof_tgl_ops = {
        .debug_map_count        = ARRAY_SIZE(tgl_dsp_debugfs),
        .dbg_dump       = hda_dsp_dump,
        .ipc_dump       = cnl_ipc_dump,
+       .debugfs_add_region_item = snd_sof_debugfs_add_region_item_iomem,
 
        /* stream callbacks */
        .pcm_open       = hda_dsp_pcm_open,
@@ -120,7 +125,7 @@ const struct snd_sof_dsp_ops sof_tgl_ops = {
                        SNDRV_PCM_INFO_PAUSE |
                        SNDRV_PCM_INFO_NO_PERIOD_WAKEUP,
 
-       .arch_ops = &sof_xtensa_arch_ops,
+       .dsp_arch_ops = &sof_xtensa_arch_ops,
 };
 EXPORT_SYMBOL_NS(sof_tgl_ops, SND_SOC_SOF_INTEL_HDA_COMMON);
 
index c2d07b7..e6c53c6 100644 (file)
@@ -18,7 +18,7 @@
 #include "sof-audio.h"
 #include "ops.h"
 
-static void ipc_trace_message(struct snd_sof_dev *sdev, u32 msg_id);
+static void ipc_trace_message(struct snd_sof_dev *sdev, u32 msg_type);
 static void ipc_stream_message(struct snd_sof_dev *sdev, u32 msg_cmd);
 
 /*
@@ -192,6 +192,29 @@ static void ipc_log_header(struct device *dev, u8 *text, u32 cmd)
                        str2 = "unknown type"; break;
                }
                break;
+       case SOF_IPC_GLB_PROBE:
+               str = "GLB_PROBE";
+               switch (type) {
+               case SOF_IPC_PROBE_INIT:
+                       str2 = "INIT"; break;
+               case SOF_IPC_PROBE_DEINIT:
+                       str2 = "DEINIT"; break;
+               case SOF_IPC_PROBE_DMA_ADD:
+                       str2 = "DMA_ADD"; break;
+               case SOF_IPC_PROBE_DMA_INFO:
+                       str2 = "DMA_INFO"; break;
+               case SOF_IPC_PROBE_DMA_REMOVE:
+                       str2 = "DMA_REMOVE"; break;
+               case SOF_IPC_PROBE_POINT_ADD:
+                       str2 = "POINT_ADD"; break;
+               case SOF_IPC_PROBE_POINT_INFO:
+                       str2 = "POINT_INFO"; break;
+               case SOF_IPC_PROBE_POINT_REMOVE:
+                       str2 = "POINT_REMOVE"; break;
+               default:
+                       str2 = "unknown type"; break;
+               }
+               break;
        default:
                str = "unknown GLB command"; break;
        }
@@ -226,15 +249,17 @@ static int tx_wait_done(struct snd_sof_ipc *ipc, struct snd_sof_ipc_msg *msg,
                                 msecs_to_jiffies(sdev->ipc_timeout));
 
        if (ret == 0) {
-               dev_err(sdev->dev, "error: ipc timed out for 0x%x size %d\n",
-                       hdr->cmd, hdr->size);
+               dev_err(sdev->dev,
+                       "ipc tx timed out for %#x (msg/reply size: %d/%zu)\n",
+                       hdr->cmd, hdr->size, msg->reply_size);
                snd_sof_handle_fw_exception(ipc->sdev);
                ret = -ETIMEDOUT;
        } else {
                ret = msg->reply_error;
                if (ret < 0) {
-                       dev_err(sdev->dev, "error: ipc error for 0x%x size %zu\n",
-                               hdr->cmd, msg->reply_size);
+                       dev_err(sdev->dev,
+                               "ipc tx error for %#x (msg/reply size: %d/%zu): %d\n",
+                               hdr->cmd, hdr->size, msg->reply_size, ret);
                } else {
                        ipc_log_header(sdev->dev, "ipc tx succeeded", hdr->cmd);
                        if (msg->reply_size)
@@ -242,6 +267,12 @@ static int tx_wait_done(struct snd_sof_ipc *ipc, struct snd_sof_ipc_msg *msg,
                                memcpy(reply_data, msg->reply_data,
                                       msg->reply_size);
                }
+
+               /* re-enable dumps after successful IPC tx */
+               if (sdev->ipc_dump_printed) {
+                       sdev->dbg_dump_printed = false;
+                       sdev->ipc_dump_printed = false;
+               }
        }
 
        return ret;
@@ -286,7 +317,7 @@ static int sof_ipc_tx_message_unlocked(struct snd_sof_ipc *ipc, u32 header,
 
        spin_unlock_irq(&sdev->ipc_lock);
 
-       if (ret < 0) {
+       if (ret) {
                dev_err_ratelimited(sdev->dev,
                                    "error: ipc tx failed with error %d\n",
                                    ret);
@@ -296,10 +327,7 @@ static int sof_ipc_tx_message_unlocked(struct snd_sof_ipc *ipc, u32 header,
        ipc_log_header(sdev->dev, "ipc tx", msg->header);
 
        /* now wait for completion */
-       if (!ret)
-               ret = tx_wait_done(ipc, msg, reply_data);
-
-       return ret;
+       return tx_wait_done(ipc, msg, reply_data);
 }
 
 /* send IPC message from host to DSP */
@@ -369,15 +397,52 @@ void snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id)
 }
 EXPORT_SYMBOL(snd_sof_ipc_reply);
 
+static void ipc_comp_notification(struct snd_sof_dev *sdev,
+                                 struct sof_ipc_cmd_hdr *hdr)
+{
+       u32 msg_type = hdr->cmd & SOF_CMD_TYPE_MASK;
+       struct sof_ipc_ctrl_data *cdata;
+       int ret;
+
+       switch (msg_type) {
+       case SOF_IPC_COMP_GET_VALUE:
+       case SOF_IPC_COMP_GET_DATA:
+               cdata = kmalloc(hdr->size, GFP_KERNEL);
+               if (!cdata)
+                       return;
+
+               /* read back full message */
+               ret = snd_sof_ipc_msg_data(sdev, NULL, cdata, hdr->size);
+               if (ret < 0) {
+                       dev_err(sdev->dev,
+                               "error: failed to read component event: %d\n", ret);
+                       goto err;
+               }
+               break;
+       default:
+               dev_err(sdev->dev, "error: unhandled component message %#x\n", msg_type);
+               return;
+       }
+
+       snd_sof_control_notify(sdev, cdata);
+
+err:
+       kfree(cdata);
+}
+
 /* DSP firmware has sent host a message  */
 void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev)
 {
        struct sof_ipc_cmd_hdr hdr;
        u32 cmd, type;
-       int err = 0;
+       int err;
 
        /* read back header */
-       snd_sof_ipc_msg_data(sdev, NULL, &hdr, sizeof(hdr));
+       err = snd_sof_ipc_msg_data(sdev, NULL, &hdr, sizeof(hdr));
+       if (err < 0) {
+               dev_warn(sdev->dev, "failed to read IPC header: %d\n", err);
+               return;
+       }
        ipc_log_header(sdev->dev, "ipc rx", hdr.cmd);
 
        cmd = hdr.cmd & SOF_GLB_TYPE_MASK;
@@ -393,9 +458,9 @@ void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev)
                if (sdev->fw_state == SOF_FW_BOOT_IN_PROGRESS) {
                        err = sof_ops(sdev)->fw_ready(sdev, cmd);
                        if (err < 0)
-                               sdev->fw_state = SOF_FW_BOOT_READY_FAILED;
+                               sof_set_fw_state(sdev, SOF_FW_BOOT_READY_FAILED);
                        else
-                               sdev->fw_state = SOF_FW_BOOT_COMPLETE;
+                               sof_set_fw_state(sdev, SOF_FW_BOOT_COMPLETE);
 
                        /* wake up firmware loader */
                        wake_up(&sdev->boot_wait);
@@ -404,7 +469,9 @@ void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev)
        case SOF_IPC_GLB_COMPOUND:
        case SOF_IPC_GLB_TPLG_MSG:
        case SOF_IPC_GLB_PM_MSG:
+               break;
        case SOF_IPC_GLB_COMP_MSG:
+               ipc_comp_notification(sdev, &hdr);
                break;
        case SOF_IPC_GLB_STREAM_MSG:
                /* need to pass msg id into the function */
@@ -426,19 +493,22 @@ EXPORT_SYMBOL(snd_sof_ipc_msgs_rx);
  * IPC trace mechanism.
  */
 
-static void ipc_trace_message(struct snd_sof_dev *sdev, u32 msg_id)
+static void ipc_trace_message(struct snd_sof_dev *sdev, u32 msg_type)
 {
        struct sof_ipc_dma_trace_posn posn;
+       int ret;
 
-       switch (msg_id) {
+       switch (msg_type) {
        case SOF_IPC_TRACE_DMA_POSITION:
                /* read back full message */
-               snd_sof_ipc_msg_data(sdev, NULL, &posn, sizeof(posn));
-               snd_sof_trace_update_pos(sdev, &posn);
+               ret = snd_sof_ipc_msg_data(sdev, NULL, &posn, sizeof(posn));
+               if (ret < 0)
+                       dev_warn(sdev->dev, "failed to read trace position: %d\n", ret);
+               else
+                       snd_sof_trace_update_pos(sdev, &posn);
                break;
        default:
-               dev_err(sdev->dev, "error: unhandled trace message %x\n",
-                       msg_id);
+               dev_err(sdev->dev, "error: unhandled trace message %#x\n", msg_type);
                break;
        }
 }
@@ -453,7 +523,7 @@ static void ipc_period_elapsed(struct snd_sof_dev *sdev, u32 msg_id)
        struct snd_sof_pcm_stream *stream;
        struct sof_ipc_stream_posn posn;
        struct snd_sof_pcm *spcm;
-       int direction;
+       int direction, ret;
 
        spcm = snd_sof_find_spcm_comp(scomp, msg_id, &direction);
        if (!spcm) {
@@ -464,15 +534,21 @@ static void ipc_period_elapsed(struct snd_sof_dev *sdev, u32 msg_id)
        }
 
        stream = &spcm->stream[direction];
-       snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn));
+       ret = snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn));
+       if (ret < 0) {
+               dev_warn(sdev->dev, "failed to read stream position: %d\n", ret);
+               return;
+       }
 
        dev_vdbg(sdev->dev, "posn : host 0x%llx dai 0x%llx wall 0x%llx\n",
                 posn.host_posn, posn.dai_posn, posn.wallclock);
 
        memcpy(&stream->posn, &posn, sizeof(posn));
 
-       /* only inform ALSA for period_wakeup mode */
-       if (!stream->substream->runtime->no_period_wakeup)
+       if (spcm->pcm.compress)
+               snd_sof_compr_fragment_elapsed(stream->cstream);
+       else if (!stream->substream->runtime->no_period_wakeup)
+               /* only inform ALSA for period_wakeup mode */
                snd_sof_pcm_period_elapsed(stream->substream);
 }
 
@@ -483,7 +559,7 @@ static void ipc_xrun(struct snd_sof_dev *sdev, u32 msg_id)
        struct snd_sof_pcm_stream *stream;
        struct sof_ipc_stream_posn posn;
        struct snd_sof_pcm *spcm;
-       int direction;
+       int direction, ret;
 
        spcm = snd_sof_find_spcm_comp(scomp, msg_id, &direction);
        if (!spcm) {
@@ -493,7 +569,11 @@ static void ipc_xrun(struct snd_sof_dev *sdev, u32 msg_id)
        }
 
        stream = &spcm->stream[direction];
-       snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn));
+       ret = snd_sof_ipc_msg_data(sdev, stream->substream, &posn, sizeof(posn));
+       if (ret < 0) {
+               dev_warn(sdev->dev, "failed to read overrun position: %d\n", ret);
+               return;
+       }
 
        dev_dbg(sdev->dev,  "posn XRUN: host %llx comp %d size %d\n",
                posn.host_posn, posn.xrun_comp_id, posn.xrun_size);
@@ -520,7 +600,7 @@ static void ipc_stream_message(struct snd_sof_dev *sdev, u32 msg_cmd)
                ipc_xrun(sdev, msg_id);
                break;
        default:
-               dev_err(sdev->dev, "error: unhandled stream message %x\n",
+               dev_err(sdev->dev, "error: unhandled stream message %#x\n",
                        msg_id);
                break;
        }
@@ -672,24 +752,50 @@ int snd_sof_ipc_set_get_comp_data(struct snd_sof_control *scontrol,
        struct sof_ipc_fw_ready *ready = &sdev->fw_ready;
        struct sof_ipc_fw_version *v = &ready->version;
        struct sof_ipc_ctrl_data_params sparams;
+       struct snd_sof_widget *swidget;
+       bool widget_found = false;
        size_t send_bytes;
        int err;
 
+       list_for_each_entry(swidget, &sdev->widget_list, list) {
+               if (swidget->comp_id == scontrol->comp_id) {
+                       widget_found = true;
+                       break;
+               }
+       }
+
+       if (!widget_found) {
+               dev_err(sdev->dev, "error: can't find widget with id %d\n", scontrol->comp_id);
+               return -EINVAL;
+       }
+
+       /*
+        * Volatile controls should always be part of static pipelines and the widget use_count
+        * would always be > 0 in this case. For the others, just return the cached value if the
+        * widget is not set up.
+        */
+       if (!swidget->use_count)
+               return 0;
+
        /* read or write firmware volume */
        if (scontrol->readback_offset != 0) {
                /* write/read value header via mmaped region */
                send_bytes = sizeof(struct sof_ipc_ctrl_value_chan) *
                cdata->num_elems;
                if (send)
-                       snd_sof_dsp_block_write(sdev, sdev->mmio_bar,
-                                               scontrol->readback_offset,
-                                               cdata->chanv, send_bytes);
+                       err = snd_sof_dsp_block_write(sdev, SOF_FW_BLK_TYPE_IRAM,
+                                                     scontrol->readback_offset,
+                                                     cdata->chanv, send_bytes);
 
                else
-                       snd_sof_dsp_block_read(sdev, sdev->mmio_bar,
-                                              scontrol->readback_offset,
-                                              cdata->chanv, send_bytes);
-               return 0;
+                       err = snd_sof_dsp_block_read(sdev, SOF_FW_BLK_TYPE_IRAM,
+                                                    scontrol->readback_offset,
+                                                    cdata->chanv, send_bytes);
+
+               if (err)
+                       dev_err_once(sdev->dev, "error: %s TYPE_IRAM failed\n",
+                                    send ? "write to" :  "read from");
+               return err;
        }
 
        cdata->rhdr.hdr.cmd = SOF_IPC_GLB_COMP_MSG | ipc_cmd;
@@ -762,22 +868,6 @@ int snd_sof_ipc_set_get_comp_data(struct snd_sof_control *scontrol,
 }
 EXPORT_SYMBOL(snd_sof_ipc_set_get_comp_data);
 
-/*
- * IPC layer enumeration.
- */
-
-int snd_sof_dsp_mailbox_init(struct snd_sof_dev *sdev, u32 dspbox,
-                            size_t dspbox_size, u32 hostbox,
-                            size_t hostbox_size)
-{
-       sdev->dsp_box.offset = dspbox;
-       sdev->dsp_box.size = dspbox_size;
-       sdev->host_box.offset = hostbox;
-       sdev->host_box.size = hostbox_size;
-       return 0;
-}
-EXPORT_SYMBOL(snd_sof_dsp_mailbox_init);
-
 int snd_sof_ipc_valid(struct snd_sof_dev *sdev)
 {
        struct sof_ipc_fw_ready *ready = &sdev->fw_ready;
@@ -829,6 +919,22 @@ int snd_sof_ipc_valid(struct snd_sof_dev *sdev)
 }
 EXPORT_SYMBOL(snd_sof_ipc_valid);
 
+int sof_ipc_init_msg_memory(struct snd_sof_dev *sdev)
+{
+       struct snd_sof_ipc_msg *msg;
+
+       msg = &sdev->ipc->msg;
+       msg->msg_data = devm_kzalloc(sdev->dev, SOF_IPC_MSG_MAX_SIZE, GFP_KERNEL);
+       if (!msg->msg_data)
+               return -ENOMEM;
+
+       msg->reply_data = devm_kzalloc(sdev->dev, SOF_IPC_MSG_MAX_SIZE, GFP_KERNEL);
+       if (!msg->reply_data)
+               return -ENOMEM;
+
+       return 0;
+}
+
 struct snd_sof_ipc *snd_sof_ipc_init(struct snd_sof_dev *sdev)
 {
        struct snd_sof_ipc *ipc;
@@ -845,17 +951,6 @@ struct snd_sof_ipc *snd_sof_ipc_init(struct snd_sof_dev *sdev)
        /* indicate that we aren't sending a message ATM */
        msg->ipc_complete = true;
 
-       /* pre-allocate message data */
-       msg->msg_data = devm_kzalloc(sdev->dev, SOF_IPC_MSG_MAX_SIZE,
-                                    GFP_KERNEL);
-       if (!msg->msg_data)
-               return NULL;
-
-       msg->reply_data = devm_kzalloc(sdev->dev, SOF_IPC_MSG_MAX_SIZE,
-                                      GFP_KERNEL);
-       if (!msg->reply_data)
-               return NULL;
-
        init_waitqueue_head(&msg->waitq);
 
        return ipc;
index bb79c77..c046466 100644 (file)
@@ -13,6 +13,7 @@
 #include <linux/firmware.h>
 #include <sound/sof.h>
 #include <sound/sof/ext_manifest.h>
+#include "sof-priv.h"
 #include "ops.h"
 
 static int get_ext_windows(struct snd_sof_dev *sdev,
@@ -86,7 +87,7 @@ static int get_cc_info(struct snd_sof_dev *sdev,
 }
 
 /* parse the extended FW boot data structures from FW boot message */
-int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
+static int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 offset)
 {
        struct sof_ipc_ext_data_hdr *ext_hdr;
        void *ext_data;
@@ -97,15 +98,16 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
                return -ENOMEM;
 
        /* get first header */
-       snd_sof_dsp_block_read(sdev, bar, offset, ext_data,
+       snd_sof_dsp_block_read(sdev, SOF_FW_BLK_TYPE_SRAM, offset, ext_data,
                               sizeof(*ext_hdr));
        ext_hdr = ext_data;
 
        while (ext_hdr->hdr.cmd == SOF_IPC_FW_READY) {
                /* read in ext structure */
-               snd_sof_dsp_block_read(sdev, bar, offset + sizeof(*ext_hdr),
-                                  (void *)((u8 *)ext_data + sizeof(*ext_hdr)),
-                                  ext_hdr->hdr.size - sizeof(*ext_hdr));
+               snd_sof_dsp_block_read(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                      offset + sizeof(*ext_hdr),
+                                      (void *)((u8 *)ext_data + sizeof(*ext_hdr)),
+                                      ext_hdr->hdr.size - sizeof(*ext_hdr));
 
                dev_dbg(sdev->dev, "found ext header type %d size 0x%x\n",
                        ext_hdr->type, ext_hdr->hdr.size);
@@ -138,7 +140,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
 
                /* move to next header */
                offset += ext_hdr->hdr.size;
-               snd_sof_dsp_block_read(sdev, bar, offset, ext_data,
+               snd_sof_dsp_block_read(sdev, SOF_FW_BLK_TYPE_SRAM, offset, ext_data,
                                       sizeof(*ext_hdr));
                ext_hdr = ext_data;
        }
@@ -146,7 +148,6 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
        kfree(ext_data);
        return ret;
 }
-EXPORT_SYMBOL(snd_sof_fw_parse_ext_data);
 
 static int ext_man_get_fw_version(struct snd_sof_dev *sdev,
                                  const struct sof_ext_man_elem_header *hdr)
@@ -372,7 +373,6 @@ static void sof_get_windows(struct snd_sof_dev *sdev)
        u32 debug_size = 0;
        u32 debug_offset = 0;
        int window_offset;
-       int bar;
        int i;
 
        if (!sdev->info_window) {
@@ -380,12 +380,6 @@ static void sof_get_windows(struct snd_sof_dev *sdev)
                return;
        }
 
-       bar = snd_sof_dsp_get_bar_index(sdev, SOF_FW_BLK_TYPE_SRAM);
-       if (bar < 0) {
-               dev_err(sdev->dev, "error: have no bar mapping\n");
-               return;
-       }
-
        for (i = 0; i < sdev->info_window->num_windows; i++) {
                elem = &sdev->info_window->window[i];
 
@@ -400,64 +394,53 @@ static void sof_get_windows(struct snd_sof_dev *sdev)
                case SOF_IPC_REGION_UPBOX:
                        inbox_offset = window_offset + elem->offset;
                        inbox_size = elem->size;
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               inbox_offset,
-                                               elem->size, "inbox",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       inbox_offset,
+                                                       elem->size, "inbox",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_DOWNBOX:
                        outbox_offset = window_offset + elem->offset;
                        outbox_size = elem->size;
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               outbox_offset,
-                                               elem->size, "outbox",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       outbox_offset,
+                                                       elem->size, "outbox",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_TRACE:
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               window_offset +
-                                               elem->offset,
-                                               elem->size, "etrace",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       window_offset + elem->offset,
+                                                       elem->size, "etrace",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_DEBUG:
                        debug_offset = window_offset + elem->offset;
                        debug_size = elem->size;
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               window_offset +
-                                               elem->offset,
-                                               elem->size, "debug",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       window_offset + elem->offset,
+                                                       elem->size, "debug",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_STREAM:
                        stream_offset = window_offset + elem->offset;
                        stream_size = elem->size;
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               stream_offset,
-                                               elem->size, "stream",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       stream_offset,
+                                                       elem->size, "stream",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_REGS:
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               window_offset +
-                                               elem->offset,
-                                               elem->size, "regs",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       window_offset + elem->offset,
+                                                       elem->size, "regs",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                case SOF_IPC_REGION_EXCEPTION:
                        sdev->dsp_oops_offset = window_offset + elem->offset;
-                       snd_sof_debugfs_io_item(sdev,
-                                               sdev->bar[bar] +
-                                               window_offset +
-                                               elem->offset,
-                                               elem->size, "exception",
-                                               SOF_DEBUGFS_ACCESS_D0_ONLY);
+                       snd_sof_debugfs_add_region_item(sdev, SOF_FW_BLK_TYPE_SRAM,
+                                                       window_offset + elem->offset,
+                                                       elem->size, "exception",
+                                                       SOF_DEBUGFS_ACCESS_D0_ONLY);
                        break;
                default:
                        dev_err(sdev->dev, "error: get illegal window info\n");
@@ -470,8 +453,12 @@ static void sof_get_windows(struct snd_sof_dev *sdev)
                return;
        }
 
-       snd_sof_dsp_mailbox_init(sdev, inbox_offset, inbox_size,
-                                outbox_offset, outbox_size);
+       sdev->dsp_box.offset = inbox_offset;
+       sdev->dsp_box.size = inbox_size;
+
+       sdev->host_box.offset = outbox_offset;
+       sdev->host_box.size = outbox_size;
+
        sdev->stream_box.offset = stream_offset;
        sdev->stream_box.size = stream_size;
 
@@ -493,7 +480,6 @@ int sof_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
 {
        struct sof_ipc_fw_ready *fw_ready = &sdev->fw_ready;
        int offset;
-       int bar;
        int ret;
 
        /* mailbox must be on 4k boundary */
@@ -503,12 +489,6 @@ int sof_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
                return offset;
        }
 
-       bar = snd_sof_dsp_get_bar_index(sdev, SOF_FW_BLK_TYPE_SRAM);
-       if (bar < 0) {
-               dev_err(sdev->dev, "error: have no bar mapping\n");
-               return -EINVAL;
-       }
-
        dev_dbg(sdev->dev, "ipc: DSP is ready 0x%8.8x offset 0x%x\n",
                msg_id, offset);
 
@@ -516,8 +496,17 @@ int sof_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
        if (!sdev->first_boot)
                return 0;
 
-       /* copy data from the DSP FW ready offset */
-       snd_sof_dsp_block_read(sdev, bar, offset, fw_ready, sizeof(*fw_ready));
+       /*
+        * copy data from the DSP FW ready offset
+        * Subsequent error handling is not needed for BLK_TYPE_SRAM
+        */
+       ret = snd_sof_dsp_block_read(sdev, SOF_FW_BLK_TYPE_SRAM, offset, fw_ready,
+                                    sizeof(*fw_ready));
+       if (ret) {
+               dev_err(sdev->dev,
+                       "error: unable to read fw_ready, read from TYPE_SRAM failed\n");
+               return ret;
+       }
 
        /* make sure ABI version is compatible */
        ret = snd_sof_ipc_valid(sdev);
@@ -525,12 +514,11 @@ int sof_fw_ready(struct snd_sof_dev *sdev, u32 msg_id)
                return ret;
 
        /* now check for extended data */
-       snd_sof_fw_parse_ext_data(sdev, bar, offset +
-                                 sizeof(struct sof_ipc_fw_ready));
+       snd_sof_fw_parse_ext_data(sdev, offset + sizeof(struct sof_ipc_fw_ready));
 
        sof_get_windows(sdev);
 
-       return 0;
+       return sof_ipc_init_msg_memory(sdev);
 }
 EXPORT_SYMBOL(sof_fw_ready);
 
@@ -539,7 +527,7 @@ int snd_sof_parse_module_memcpy(struct snd_sof_dev *sdev,
                                struct snd_sof_mod_hdr *module)
 {
        struct snd_sof_blk_hdr *block;
-       int count, bar;
+       int count, ret;
        u32 offset;
        size_t remaining;
 
@@ -576,13 +564,6 @@ int snd_sof_parse_module_memcpy(struct snd_sof_dev *sdev,
                case SOF_FW_BLK_TYPE_DRAM:
                case SOF_FW_BLK_TYPE_SRAM:
                        offset = block->offset;
-                       bar = snd_sof_dsp_get_bar_index(sdev, block->type);
-                       if (bar < 0) {
-                               dev_err(sdev->dev,
-                                       "error: no BAR mapping for block type 0x%x\n",
-                                       block->type);
-                               return bar;
-                       }
                        break;
                default:
                        dev_err(sdev->dev, "error: bad type 0x%x for block 0x%x\n",
@@ -600,8 +581,13 @@ int snd_sof_parse_module_memcpy(struct snd_sof_dev *sdev,
                                block->size);
                        return -EINVAL;
                }
-               snd_sof_dsp_block_write(sdev, bar, offset,
-                                       block + 1, block->size);
+               ret = snd_sof_dsp_block_write(sdev, block->type, offset,
+                                             block + 1, block->size);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: write to block type 0x%x failed\n",
+                               block->type);
+                       return ret;
+               }
 
                if (remaining < block->size) {
                        dev_err(sdev->dev, "error: not enough data remaining\n");
@@ -800,22 +786,16 @@ error:
 }
 EXPORT_SYMBOL(snd_sof_load_firmware_memcpy);
 
-int snd_sof_load_firmware(struct snd_sof_dev *sdev)
-{
-       dev_dbg(sdev->dev, "loading firmware\n");
-
-       if (sof_ops(sdev)->load_firmware)
-               return sof_ops(sdev)->load_firmware(sdev);
-       return 0;
-}
-EXPORT_SYMBOL(snd_sof_load_firmware);
-
 int snd_sof_run_firmware(struct snd_sof_dev *sdev)
 {
        int ret;
 
        init_waitqueue_head(&sdev->boot_wait);
 
+       /* (re-)enable dsp dump */
+       sdev->dbg_dump_printed = false;
+       sdev->ipc_dump_printed = false;
+
        /* create read-only fw_version debugfs to store boot version info */
        if (sdev->first_boot) {
                ret = snd_sof_debugfs_buf_item(sdev, &sdev->fw_version,
@@ -840,7 +820,8 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev)
        /* boot the firmware on the DSP */
        ret = snd_sof_dsp_run(sdev);
        if (ret < 0) {
-               dev_err(sdev->dev, "error: failed to reset DSP\n");
+               dev_err(sdev->dev, "error: failed to start DSP\n");
+               snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_MBOX | SOF_DBG_DUMP_PCI);
                return ret;
        }
 
@@ -856,8 +837,8 @@ int snd_sof_run_firmware(struct snd_sof_dev *sdev)
        if (ret == 0) {
                dev_err(sdev->dev, "error: firmware boot failure\n");
                snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX |
-                       SOF_DBG_DUMP_TEXT | SOF_DBG_DUMP_PCI | SOF_DBG_DUMP_FORCE_ERR_LEVEL);
-               sdev->fw_state = SOF_FW_BOOT_FAILED;
+                                    SOF_DBG_DUMP_TEXT | SOF_DBG_DUMP_PCI);
+               sof_set_fw_state(sdev, SOF_FW_BOOT_FAILED);
                return -EIO;
        }
 
index 11ecebd..160b88a 100644 (file)
@@ -157,6 +157,9 @@ void snd_sof_dsp_panic(struct snd_sof_dev *sdev, u32 offset)
                dev_dbg(sdev->dev, "panic: dsp_oops_offset %zu offset %d\n",
                        sdev->dsp_oops_offset, offset);
 
+       /* We want to see the DSP panic! */
+       sdev->dbg_dump_printed = false;
+
        snd_sof_dsp_dbg_dump(sdev, SOF_DBG_DUMP_REGS | SOF_DBG_DUMP_MBOX);
        snd_sof_trace_notify_for_error(sdev);
 }
index 4a5d6e4..09bf38f 100644 (file)
@@ -241,16 +241,17 @@ snd_sof_dsp_set_power_state(struct snd_sof_dev *sdev,
 }
 
 /* debug */
-static inline void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags)
-{
-       if (sof_ops(sdev)->dbg_dump)
-               sof_ops(sdev)->dbg_dump(sdev, flags);
-}
+void snd_sof_dsp_dbg_dump(struct snd_sof_dev *sdev, u32 flags);
 
-static inline void snd_sof_ipc_dump(struct snd_sof_dev *sdev)
+static inline int snd_sof_debugfs_add_region_item(struct snd_sof_dev *sdev,
+               enum snd_sof_fw_blk_type blk_type, u32 offset, size_t size,
+               const char *name, enum sof_debugfs_access_type access_type)
 {
-       if (sof_ops(sdev)->ipc_dump)
-               sof_ops(sdev)->ipc_dump(sdev);
+       if (sof_ops(sdev) && sof_ops(sdev)->debugfs_add_region_item)
+               return sof_ops(sdev)->debugfs_add_region_item(sdev, blk_type, offset,
+                                                             size, name, access_type);
+
+       return 0;
 }
 
 /* register IO */
@@ -297,16 +298,33 @@ static inline u64 snd_sof_dsp_read64(struct snd_sof_dev *sdev, u32 bar,
 }
 
 /* block IO */
-static inline void snd_sof_dsp_block_read(struct snd_sof_dev *sdev, u32 bar,
-                                         u32 offset, void *dest, size_t bytes)
+static inline int snd_sof_dsp_block_read(struct snd_sof_dev *sdev,
+                                        enum snd_sof_fw_blk_type blk_type,
+                                        u32 offset, void *dest, size_t bytes)
+{
+       return sof_ops(sdev)->block_read(sdev, blk_type, offset, dest, bytes);
+}
+
+static inline int snd_sof_dsp_block_write(struct snd_sof_dev *sdev,
+                                         enum snd_sof_fw_blk_type blk_type,
+                                         u32 offset, void *src, size_t bytes)
+{
+       return sof_ops(sdev)->block_write(sdev, blk_type, offset, src, bytes);
+}
+
+/* mailbox IO */
+static inline void snd_sof_dsp_mailbox_read(struct snd_sof_dev *sdev,
+                                           u32 offset, void *dest, size_t bytes)
 {
-       sof_ops(sdev)->block_read(sdev, bar, offset, dest, bytes);
+       if (sof_ops(sdev)->mailbox_read)
+               sof_ops(sdev)->mailbox_read(sdev, offset, dest, bytes);
 }
 
-static inline void snd_sof_dsp_block_write(struct snd_sof_dev *sdev, u32 bar,
-                                          u32 offset, void *src, size_t bytes)
+static inline void snd_sof_dsp_mailbox_write(struct snd_sof_dev *sdev,
+                                            u32 offset, void *src, size_t bytes)
 {
-       sof_ops(sdev)->block_write(sdev, bar, offset, src, bytes);
+       if (sof_ops(sdev)->mailbox_write)
+               sof_ops(sdev)->mailbox_write(sdev, offset, src, bytes);
 }
 
 /* ipc */
@@ -400,12 +418,20 @@ snd_sof_pcm_platform_trigger(struct snd_sof_dev *sdev,
        return 0;
 }
 
+/* Firmware loading */
+static inline int snd_sof_load_firmware(struct snd_sof_dev *sdev)
+{
+       dev_dbg(sdev->dev, "loading firmware\n");
+
+       return sof_ops(sdev)->load_firmware(sdev);
+}
+
 /* host DSP message data */
-static inline void snd_sof_ipc_msg_data(struct snd_sof_dev *sdev,
-                                       struct snd_pcm_substream *substream,
-                                       void *p, size_t sz)
+static inline int snd_sof_ipc_msg_data(struct snd_sof_dev *sdev,
+                                      struct snd_pcm_substream *substream,
+                                      void *p, size_t sz)
 {
-       sof_ops(sdev)->ipc_msg_data(sdev, substream, p, sz);
+       return sof_ops(sdev)->ipc_msg_data(sdev, substream, p, sz);
 }
 
 /* host configure DSP HW parameters */
@@ -503,21 +529,6 @@ snd_sof_set_mach_params(const struct snd_soc_acpi_mach *mach,
                sof_ops(sdev)->set_mach_params(mach, sdev);
 }
 
-static inline const struct snd_sof_dsp_ops
-*sof_get_ops(const struct sof_dev_desc *d,
-            const struct sof_ops_table mach_ops[], int asize)
-{
-       int i;
-
-       for (i = 0; i < asize; i++) {
-               if (d == mach_ops[i].desc)
-                       return mach_ops[i].ops;
-       }
-
-       /* not found */
-       return NULL;
-}
-
 /**
  * snd_sof_dsp_register_poll_timeout - Periodically poll an address
  * until a condition is met or a timeout occurs
index 9893b18..fa0bfcd 100644 (file)
@@ -17,7 +17,7 @@
 #include "sof-audio.h"
 #include "ops.h"
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
-#include "compress.h"
+#include "sof-probes.h"
 #endif
 
 /* Create DMA buffer page table for DSP */
@@ -57,7 +57,7 @@ static int sof_pcm_dsp_params(struct snd_sof_pcm *spcm, struct snd_pcm_substream
 /*
  * sof pcm period elapse work
  */
-void snd_sof_pcm_period_elapsed_work(struct work_struct *work)
+static void snd_sof_pcm_period_elapsed_work(struct work_struct *work)
 {
        struct snd_sof_pcm_stream *sps =
                container_of(work, struct snd_sof_pcm_stream,
@@ -66,6 +66,11 @@ void snd_sof_pcm_period_elapsed_work(struct work_struct *work)
        snd_pcm_period_elapsed(sps->substream);
 }
 
+void snd_sof_pcm_init_elapsed_work(struct work_struct *work)
+{
+        INIT_WORK(work, snd_sof_pcm_period_elapsed_work);
+}
+
 /*
  * sof pcm period elapse, this could be called at irq thread context.
  */
@@ -116,6 +121,40 @@ static int sof_pcm_dsp_pcm_free(struct snd_pcm_substream *substream,
        return ret;
 }
 
+static int sof_pcm_setup_connected_widgets(struct snd_sof_dev *sdev,
+                                          struct snd_soc_pcm_runtime *rtd,
+                                          struct snd_sof_pcm *spcm, int dir)
+{
+       struct snd_soc_dai *dai;
+       int ret, j;
+
+       /* query DAPM for list of connected widgets and set them up */
+       for_each_rtd_cpu_dais(rtd, j, dai) {
+               struct snd_soc_dapm_widget_list *list;
+
+               ret = snd_soc_dapm_dai_get_connected_widgets(dai, dir, &list,
+                                                            dpcm_end_walk_at_be);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: dai %s has no valid %s path\n", dai->name,
+                               dir == SNDRV_PCM_STREAM_PLAYBACK ? "playback" : "capture");
+                       return ret;
+               }
+
+               spcm->stream[dir].list = list;
+
+               ret = sof_widget_list_setup(sdev, spcm, dir);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: failed widget list set up for pcm %d dir %d\n",
+                               spcm->pcm.pcm_id, dir);
+                       spcm->stream[dir].list = NULL;
+                       snd_soc_dapm_dai_free_widgets(&list);
+                       return ret;
+               }
+       }
+
+       return 0;
+}
+
 static int sof_pcm_hw_params(struct snd_soc_component *component,
                             struct snd_pcm_substream *substream,
                             struct snd_pcm_hw_params *params)
@@ -213,7 +252,14 @@ static int sof_pcm_hw_params(struct snd_soc_component *component,
 
        dev_dbg(component->dev, "stream_tag %d", pcm.params.stream_tag);
 
-       /* send IPC to the DSP */
+       /* if this is a repeated hw_params without hw_free, skip setting up widgets */
+       if (!spcm->stream[substream->stream].list) {
+               ret = sof_pcm_setup_connected_widgets(sdev, rtd, spcm, substream->stream);
+               if (ret < 0)
+                       return ret;
+       }
+
+       /* send hw_params IPC to the DSP */
        ret = sof_ipc_tx_message(sdev->ipc, pcm.hdr.cmd, &pcm, sizeof(pcm),
                                 &ipc_params_reply, sizeof(ipc_params_reply));
        if (ret < 0) {
@@ -259,6 +305,10 @@ static int sof_pcm_hw_free(struct snd_soc_component *component,
                        err = ret;
        }
 
+       ret = sof_widget_list_free(sdev, spcm, substream->stream);
+       if (ret < 0)
+               err = ret;
+
        cancel_work_sync(&spcm->stream[substream->stream].period_elapsed_work);
 
        ret = snd_sof_pcm_platform_hw_free(sdev, substream);
@@ -316,6 +366,7 @@ static int sof_pcm_trigger(struct snd_soc_component *component,
        struct sof_ipc_stream stream;
        struct sof_ipc_reply reply;
        bool reset_hw_params = false;
+       bool free_widget_list = false;
        bool ipc_first = false;
        int ret;
 
@@ -386,6 +437,7 @@ static int sof_pcm_trigger(struct snd_soc_component *component,
                        spcm->stream[substream->stream].suspend_ignored = true;
                        return 0;
                }
+               free_widget_list = true;
                fallthrough;
        case SNDRV_PCM_TRIGGER_STOP:
                stream.hdr.cmd |= SOF_IPC_STREAM_TRIG_STOP;
@@ -414,8 +466,15 @@ static int sof_pcm_trigger(struct snd_soc_component *component,
                snd_sof_pcm_platform_trigger(sdev, substream, cmd);
 
        /* free PCM if reset_hw_params is set and the STOP IPC is successful */
-       if (!ret && reset_hw_params)
+       if (!ret && reset_hw_params) {
                ret = sof_pcm_dsp_pcm_free(substream, sdev, spcm);
+               if (ret < 0)
+                       return ret;
+
+               /* free widget list only for SUSPEND trigger */
+               if (free_widget_list)
+                       ret = sof_widget_list_free(sdev, spcm, substream->stream);
+       }
 
        return ret;
 }
@@ -829,11 +888,7 @@ void snd_sof_new_platform_drv(struct snd_sof_dev *sdev)
        pd->trigger = sof_pcm_trigger;
        pd->pointer = sof_pcm_pointer;
 
-#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMPRESS)
-       pd->compress_ops = &sof_compressed_ops;
-#endif
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_DEBUG_PROBES)
-       /* override cops when probe support is enabled */
        pd->compress_ops = &sof_probe_compressed_ops;
 #endif
        pd->pcm_construct = sof_pcm_new;
index c83fb62..ac8ae6e 100644 (file)
@@ -122,7 +122,7 @@ static int sof_resume(struct device *dev, bool runtime_resume)
            old_state == SOF_DSP_PM_D0)
                return 0;
 
-       sdev->fw_state = SOF_FW_BOOT_PREPARE;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_PREPARE);
 
        /* load the firmware */
        ret = snd_sof_load_firmware(sdev);
@@ -133,7 +133,7 @@ static int sof_resume(struct device *dev, bool runtime_resume)
                return ret;
        }
 
-       sdev->fw_state = SOF_FW_BOOT_IN_PROGRESS;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_IN_PROGRESS);
 
        /*
         * Boot the firmware. The FW boot status will be modified
@@ -157,7 +157,7 @@ static int sof_resume(struct device *dev, bool runtime_resume)
        }
 
        /* restore pipelines */
-       ret = sof_restore_pipelines(sdev->dev);
+       ret = sof_set_up_pipelines(sdev, false);
        if (ret < 0) {
                dev_err(sdev->dev,
                        "error: failed to restore pipeline after resume %d\n",
@@ -191,7 +191,7 @@ static int sof_suspend(struct device *dev, bool runtime_suspend)
        if (sdev->fw_state != SOF_FW_BOOT_COMPLETE)
                goto suspend;
 
-       /* set restore_stream for all streams during system suspend */
+       /* prepare for streams to be resumed properly upon resume */
        if (!runtime_suspend) {
                ret = sof_set_hw_params_upon_resume(sdev->dev);
                if (ret < 0) {
@@ -208,6 +208,8 @@ static int sof_suspend(struct device *dev, bool runtime_suspend)
        if (target_state == SOF_DSP_PM_D0)
                goto suspend;
 
+       sof_tear_down_pipelines(sdev, false);
+
        /* release trace */
        snd_sof_release_trace(sdev);
 
@@ -255,7 +257,7 @@ suspend:
                return ret;
 
        /* reset FW state */
-       sdev->fw_state = SOF_FW_BOOT_NOT_STARTED;
+       sof_set_fw_state(sdev, SOF_FW_BOOT_NOT_STARTED);
        sdev->enabled_cores_mask = 0;
 
        return ret;
diff --git a/sound/soc/sof/probe.c b/sound/soc/sof/probe.c
deleted file mode 100644 (file)
index 14509f4..0000000
+++ /dev/null
@@ -1,290 +0,0 @@
-// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
-//
-// This file is provided under a dual BSD/GPLv2 license.  When using or
-// redistributing this file, you may do so under either license.
-//
-// Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
-//
-// Author: Cezary Rojewski <cezary.rojewski@intel.com>
-//
-
-#include "sof-priv.h"
-#include "probe.h"
-
-/**
- * sof_ipc_probe_init - initialize data probing
- * @sdev:              SOF sound device
- * @stream_tag:                Extractor stream tag
- * @buffer_size:       DMA buffer size to set for extractor
- *
- * Host chooses whether extraction is supported or not by providing
- * valid stream tag to DSP. Once specified, stream described by that
- * tag will be tied to DSP for extraction for the entire lifetime of
- * probe.
- *
- * Probing is initialized only once and each INIT request must be
- * matched by DEINIT call.
- */
-int sof_ipc_probe_init(struct snd_sof_dev *sdev,
-               u32 stream_tag, size_t buffer_size)
-{
-       struct sof_ipc_probe_dma_add_params *msg;
-       struct sof_ipc_reply reply;
-       size_t size = struct_size(msg, dma, 1);
-       int ret;
-
-       msg = kmalloc(size, GFP_KERNEL);
-       if (!msg)
-               return -ENOMEM;
-       msg->hdr.size = size;
-       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_INIT;
-       msg->num_elems = 1;
-       msg->dma[0].stream_tag = stream_tag;
-       msg->dma[0].dma_buffer_size = buffer_size;
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
-                       &reply, sizeof(reply));
-       kfree(msg);
-       return ret;
-}
-EXPORT_SYMBOL(sof_ipc_probe_init);
-
-/**
- * sof_ipc_probe_deinit - cleanup after data probing
- * @sdev:      SOF sound device
- *
- * Host sends DEINIT request to free previously initialized probe
- * on DSP side once it is no longer needed. DEINIT only when there
- * are no probes connected and with all injectors detached.
- */
-int sof_ipc_probe_deinit(struct snd_sof_dev *sdev)
-{
-       struct sof_ipc_cmd_hdr msg;
-       struct sof_ipc_reply reply;
-
-       msg.size = sizeof(msg);
-       msg.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_DEINIT;
-
-       return sof_ipc_tx_message(sdev->ipc, msg.cmd, &msg, msg.size,
-                       &reply, sizeof(reply));
-}
-EXPORT_SYMBOL(sof_ipc_probe_deinit);
-
-static int sof_ipc_probe_info(struct snd_sof_dev *sdev, unsigned int cmd,
-               void **params, size_t *num_params)
-{
-       struct sof_ipc_probe_info_params msg = {{{0}}};
-       struct sof_ipc_probe_info_params *reply;
-       size_t bytes;
-       int ret;
-
-       *params = NULL;
-       *num_params = 0;
-
-       reply = kzalloc(SOF_IPC_MSG_MAX_SIZE, GFP_KERNEL);
-       if (!reply)
-               return -ENOMEM;
-       msg.rhdr.hdr.size = sizeof(msg);
-       msg.rhdr.hdr.cmd = SOF_IPC_GLB_PROBE | cmd;
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg.rhdr.hdr.cmd, &msg,
-                       msg.rhdr.hdr.size, reply, SOF_IPC_MSG_MAX_SIZE);
-       if (ret < 0 || reply->rhdr.error < 0)
-               goto exit;
-
-       if (!reply->num_elems)
-               goto exit;
-
-       if (cmd == SOF_IPC_PROBE_DMA_INFO)
-               bytes = sizeof(reply->dma[0]);
-       else
-               bytes = sizeof(reply->desc[0]);
-       bytes *= reply->num_elems;
-       *params = kmemdup(&reply->dma[0], bytes, GFP_KERNEL);
-       if (!*params) {
-               ret = -ENOMEM;
-               goto exit;
-       }
-       *num_params = reply->num_elems;
-
-exit:
-       kfree(reply);
-       return ret;
-}
-
-/**
- * sof_ipc_probe_dma_info - retrieve list of active injection dmas
- * @sdev:      SOF sound device
- * @dma:       Returned list of active dmas
- * @num_dma:   Returned count of active dmas
- *
- * Host sends DMA_INFO request to obtain list of injection dmas it
- * can use to transfer data over with.
- *
- * Note that list contains only injection dmas as there is only one
- * extractor (dma) and it is always assigned on probing init.
- * DSP knows exactly where data from extraction probes is going to,
- * which is not the case for injection where multiple streams
- * could be engaged.
- */
-int sof_ipc_probe_dma_info(struct snd_sof_dev *sdev,
-               struct sof_probe_dma **dma, size_t *num_dma)
-{
-       return sof_ipc_probe_info(sdev, SOF_IPC_PROBE_DMA_INFO,
-                       (void **)dma, num_dma);
-}
-EXPORT_SYMBOL(sof_ipc_probe_dma_info);
-
-/**
- * sof_ipc_probe_dma_add - attach to specified dmas
- * @sdev:      SOF sound device
- * @dma:       List of streams (dmas) to attach to
- * @num_dma:   Number of elements in @dma
- *
- * Contrary to extraction, injection streams are never assigned
- * on init. Before attempting any data injection, host is responsible
- * for specifying streams which will be later used to transfer data
- * to connected probe points.
- */
-int sof_ipc_probe_dma_add(struct snd_sof_dev *sdev,
-               struct sof_probe_dma *dma, size_t num_dma)
-{
-       struct sof_ipc_probe_dma_add_params *msg;
-       struct sof_ipc_reply reply;
-       size_t size = struct_size(msg, dma, num_dma);
-       int ret;
-
-       msg = kmalloc(size, GFP_KERNEL);
-       if (!msg)
-               return -ENOMEM;
-       msg->hdr.size = size;
-       msg->num_elems = num_dma;
-       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_DMA_ADD;
-       memcpy(&msg->dma[0], dma, size - sizeof(*msg));
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
-                       &reply, sizeof(reply));
-       kfree(msg);
-       return ret;
-}
-EXPORT_SYMBOL(sof_ipc_probe_dma_add);
-
-/**
- * sof_ipc_probe_dma_remove - detach from specified dmas
- * @sdev:              SOF sound device
- * @stream_tag:                List of stream tags to detach from
- * @num_stream_tag:    Number of elements in @stream_tag
- *
- * Host sends DMA_REMOVE request to free previously attached stream
- * from being occupied for injection. Each detach operation should
- * match equivalent DMA_ADD. Detach only when all probes tied to
- * given stream have been disconnected.
- */
-int sof_ipc_probe_dma_remove(struct snd_sof_dev *sdev,
-               unsigned int *stream_tag, size_t num_stream_tag)
-{
-       struct sof_ipc_probe_dma_remove_params *msg;
-       struct sof_ipc_reply reply;
-       size_t size = struct_size(msg, stream_tag, num_stream_tag);
-       int ret;
-
-       msg = kmalloc(size, GFP_KERNEL);
-       if (!msg)
-               return -ENOMEM;
-       msg->hdr.size = size;
-       msg->num_elems = num_stream_tag;
-       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_DMA_REMOVE;
-       memcpy(&msg->stream_tag[0], stream_tag, size - sizeof(*msg));
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
-                       &reply, sizeof(reply));
-       kfree(msg);
-       return ret;
-}
-EXPORT_SYMBOL(sof_ipc_probe_dma_remove);
-
-/**
- * sof_ipc_probe_points_info - retrieve list of active probe points
- * @sdev:      SOF sound device
- * @desc:      Returned list of active probes
- * @num_desc:  Returned count of active probes
- *
- * Host sends PROBE_POINT_INFO request to obtain list of active probe
- * points, valid for disconnection when given probe is no longer
- * required.
- */
-int sof_ipc_probe_points_info(struct snd_sof_dev *sdev,
-               struct sof_probe_point_desc **desc, size_t *num_desc)
-{
-       return sof_ipc_probe_info(sdev, SOF_IPC_PROBE_POINT_INFO,
-                                (void **)desc, num_desc);
-}
-EXPORT_SYMBOL(sof_ipc_probe_points_info);
-
-/**
- * sof_ipc_probe_points_add - connect specified probes
- * @sdev:      SOF sound device
- * @desc:      List of probe points to connect
- * @num_desc:  Number of elements in @desc
- *
- * Dynamically connects to provided set of endpoints. Immediately
- * after connection is established, host must be prepared to
- * transfer data from or to target stream given the probing purpose.
- *
- * Each probe point should be removed using PROBE_POINT_REMOVE
- * request when no longer needed.
- */
-int sof_ipc_probe_points_add(struct snd_sof_dev *sdev,
-               struct sof_probe_point_desc *desc, size_t num_desc)
-{
-       struct sof_ipc_probe_point_add_params *msg;
-       struct sof_ipc_reply reply;
-       size_t size = struct_size(msg, desc, num_desc);
-       int ret;
-
-       msg = kmalloc(size, GFP_KERNEL);
-       if (!msg)
-               return -ENOMEM;
-       msg->hdr.size = size;
-       msg->num_elems = num_desc;
-       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_POINT_ADD;
-       memcpy(&msg->desc[0], desc, size - sizeof(*msg));
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
-                       &reply, sizeof(reply));
-       kfree(msg);
-       return ret;
-}
-EXPORT_SYMBOL(sof_ipc_probe_points_add);
-
-/**
- * sof_ipc_probe_points_remove - disconnect specified probes
- * @sdev:              SOF sound device
- * @buffer_id:         List of probe points to disconnect
- * @num_buffer_id:     Number of elements in @desc
- *
- * Removes previously connected probes from list of active probe
- * points and frees all resources on DSP side.
- */
-int sof_ipc_probe_points_remove(struct snd_sof_dev *sdev,
-               unsigned int *buffer_id, size_t num_buffer_id)
-{
-       struct sof_ipc_probe_point_remove_params *msg;
-       struct sof_ipc_reply reply;
-       size_t size = struct_size(msg, buffer_id, num_buffer_id);
-       int ret;
-
-       msg = kmalloc(size, GFP_KERNEL);
-       if (!msg)
-               return -ENOMEM;
-       msg->hdr.size = size;
-       msg->num_elems = num_buffer_id;
-       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_POINT_REMOVE;
-       memcpy(&msg->buffer_id[0], buffer_id, size - sizeof(*msg));
-
-       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
-                       &reply, sizeof(reply));
-       kfree(msg);
-       return ret;
-}
-EXPORT_SYMBOL(sof_ipc_probe_points_remove);
diff --git a/sound/soc/sof/probe.h b/sound/soc/sof/probe.h
deleted file mode 100644 (file)
index 5e159ab..0000000
+++ /dev/null
@@ -1,85 +0,0 @@
-/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
-/*
- * This file is provided under a dual BSD/GPLv2 license.  When using or
- * redistributing this file, you may do so under either license.
- *
- * Copyright(c) 2019-2020 Intel Corporation. All rights reserved.
- *
- * Author: Cezary Rojewski <cezary.rojewski@intel.com>
- */
-
-#ifndef __SOF_PROBE_H
-#define __SOF_PROBE_H
-
-#include <sound/sof/header.h>
-
-struct snd_sof_dev;
-
-#define SOF_PROBE_INVALID_NODE_ID UINT_MAX
-
-struct sof_probe_dma {
-       unsigned int stream_tag;
-       unsigned int dma_buffer_size;
-} __packed;
-
-enum sof_connection_purpose {
-       SOF_CONNECTION_PURPOSE_EXTRACT = 1,
-       SOF_CONNECTION_PURPOSE_INJECT,
-};
-
-struct sof_probe_point_desc {
-       unsigned int buffer_id;
-       unsigned int purpose;
-       unsigned int stream_tag;
-} __packed;
-
-struct sof_ipc_probe_dma_add_params {
-       struct sof_ipc_cmd_hdr hdr;
-       unsigned int num_elems;
-       struct sof_probe_dma dma[];
-} __packed;
-
-struct sof_ipc_probe_info_params {
-       struct sof_ipc_reply rhdr;
-       unsigned int num_elems;
-       union {
-               struct sof_probe_dma dma[0];
-               struct sof_probe_point_desc desc[0];
-       };
-} __packed;
-
-struct sof_ipc_probe_dma_remove_params {
-       struct sof_ipc_cmd_hdr hdr;
-       unsigned int num_elems;
-       unsigned int stream_tag[];
-} __packed;
-
-struct sof_ipc_probe_point_add_params {
-       struct sof_ipc_cmd_hdr hdr;
-       unsigned int num_elems;
-       struct sof_probe_point_desc desc[];
-} __packed;
-
-struct sof_ipc_probe_point_remove_params {
-       struct sof_ipc_cmd_hdr hdr;
-       unsigned int num_elems;
-       unsigned int buffer_id[];
-} __packed;
-
-int sof_ipc_probe_init(struct snd_sof_dev *sdev,
-               u32 stream_tag, size_t buffer_size);
-int sof_ipc_probe_deinit(struct snd_sof_dev *sdev);
-int sof_ipc_probe_dma_info(struct snd_sof_dev *sdev,
-               struct sof_probe_dma **dma, size_t *num_dma);
-int sof_ipc_probe_dma_add(struct snd_sof_dev *sdev,
-               struct sof_probe_dma *dma, size_t num_dma);
-int sof_ipc_probe_dma_remove(struct snd_sof_dev *sdev,
-               unsigned int *stream_tag, size_t num_stream_tag);
-int sof_ipc_probe_points_info(struct snd_sof_dev *sdev,
-               struct sof_probe_point_desc **desc, size_t *num_desc);
-int sof_ipc_probe_points_add(struct snd_sof_dev *sdev,
-               struct sof_probe_point_desc *desc, size_t num_desc);
-int sof_ipc_probe_points_remove(struct snd_sof_dev *sdev,
-               unsigned int *buffer_id, size_t num_buffer_id);
-
-#endif
index 989912f..7cbe757 100644 (file)
@@ -8,9 +8,493 @@
 // Author: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
 //
 
+#include <linux/bitfield.h>
 #include "sof-audio.h"
 #include "ops.h"
 
+static int sof_kcontrol_setup(struct snd_sof_dev *sdev, struct snd_sof_control *scontrol)
+{
+       int ipc_cmd, ctrl_type;
+       int ret;
+
+       /* reset readback offset for scontrol */
+       scontrol->readback_offset = 0;
+
+       /* notify DSP of kcontrol values */
+       switch (scontrol->cmd) {
+       case SOF_CTRL_CMD_VOLUME:
+       case SOF_CTRL_CMD_ENUM:
+       case SOF_CTRL_CMD_SWITCH:
+               ipc_cmd = SOF_IPC_COMP_SET_VALUE;
+               ctrl_type = SOF_CTRL_TYPE_VALUE_CHAN_SET;
+               break;
+       case SOF_CTRL_CMD_BINARY:
+               ipc_cmd = SOF_IPC_COMP_SET_DATA;
+               ctrl_type = SOF_CTRL_TYPE_DATA_SET;
+               break;
+       default:
+               return 0;
+       }
+
+       ret = snd_sof_ipc_set_get_comp_data(scontrol, ipc_cmd, ctrl_type, scontrol->cmd, true);
+       if (ret < 0)
+               dev_err(sdev->dev, "error: failed kcontrol value set for widget: %d\n",
+                       scontrol->comp_id);
+
+       return ret;
+}
+
+static int sof_dai_config_setup(struct snd_sof_dev *sdev, struct snd_sof_dai *dai)
+{
+       struct sof_ipc_dai_config *config;
+       struct sof_ipc_reply reply;
+       int ret;
+
+       config = &dai->dai_config[dai->current_config];
+       if (!config) {
+               dev_err(sdev->dev, "error: no config for DAI %s\n", dai->name);
+               return -EINVAL;
+       }
+
+       /* set NONE flag to clear all previous settings */
+       config->flags = FIELD_PREP(SOF_DAI_CONFIG_FLAGS_MASK, SOF_DAI_CONFIG_FLAGS_NONE);
+
+       ret = sof_ipc_tx_message(sdev->ipc, config->hdr.cmd, config, config->hdr.size,
+                                &reply, sizeof(reply));
+
+       if (ret < 0)
+               dev_err(sdev->dev, "error: failed to set dai config for %s\n", dai->name);
+
+       return ret;
+}
+
+static int sof_widget_kcontrol_setup(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget)
+{
+       struct snd_sof_control *scontrol;
+       int ret;
+
+       /* set up all controls for the widget */
+       list_for_each_entry(scontrol, &sdev->kcontrol_list, list)
+               if (scontrol->comp_id == swidget->comp_id) {
+                       ret = sof_kcontrol_setup(sdev, scontrol);
+                       if (ret < 0) {
+                               dev_err(sdev->dev, "error: fail to set up kcontrols for widget %s\n",
+                                       swidget->widget->name);
+                               return ret;
+                       }
+               }
+
+       return 0;
+}
+
+static void sof_reset_route_setup_status(struct snd_sof_dev *sdev, struct snd_sof_widget *widget)
+{
+       struct snd_sof_route *sroute;
+
+       list_for_each_entry(sroute, &sdev->route_list, list)
+               if (sroute->src_widget == widget || sroute->sink_widget == widget)
+                       sroute->setup = false;
+}
+
+int sof_widget_free(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget)
+{
+       struct sof_ipc_free ipc_free = {
+               .hdr = {
+                       .size = sizeof(ipc_free),
+                       .cmd = SOF_IPC_GLB_TPLG_MSG,
+               },
+               .id = swidget->comp_id,
+       };
+       struct sof_ipc_reply reply;
+       int ret;
+
+       if (!swidget->private)
+               return 0;
+
+       /* only free when use_count is 0 */
+       if (--swidget->use_count)
+               return 0;
+
+       switch (swidget->id) {
+       case snd_soc_dapm_scheduler:
+               ipc_free.hdr.cmd |= SOF_IPC_TPLG_PIPE_FREE;
+               break;
+       case snd_soc_dapm_buffer:
+               ipc_free.hdr.cmd |= SOF_IPC_TPLG_BUFFER_FREE;
+               break;
+       default:
+               ipc_free.hdr.cmd |= SOF_IPC_TPLG_COMP_FREE;
+               break;
+       }
+
+       ret = sof_ipc_tx_message(sdev->ipc, ipc_free.hdr.cmd, &ipc_free, sizeof(ipc_free),
+                                &reply, sizeof(reply));
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed to free widget %s\n", swidget->widget->name);
+               swidget->use_count++;
+               return ret;
+       }
+
+       /* reset route setup status for all routes that contain this widget */
+       sof_reset_route_setup_status(sdev, swidget);
+       swidget->complete = 0;
+       dev_dbg(sdev->dev, "widget %s freed\n", swidget->widget->name);
+
+       return 0;
+}
+EXPORT_SYMBOL(sof_widget_free);
+
+int sof_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget)
+{
+       struct sof_ipc_pipe_new *pipeline;
+       struct sof_ipc_comp_reply r;
+       struct sof_ipc_cmd_hdr *hdr;
+       struct sof_ipc_comp *comp;
+       struct snd_sof_dai *dai;
+       size_t ipc_size;
+       int ret;
+
+       /* skip if there is no private data */
+       if (!swidget->private)
+               return 0;
+
+       /* widget already set up */
+       if (++swidget->use_count > 1)
+               return 0;
+
+       ret = sof_pipeline_core_enable(sdev, swidget);
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed to enable target core: %d for widget %s\n",
+                       ret, swidget->widget->name);
+               goto use_count_dec;
+       }
+
+       switch (swidget->id) {
+       case snd_soc_dapm_dai_in:
+       case snd_soc_dapm_dai_out:
+               ipc_size = sizeof(struct sof_ipc_comp_dai) + sizeof(struct sof_ipc_comp_ext);
+               comp = kzalloc(ipc_size, GFP_KERNEL);
+               if (!comp)
+                       return -ENOMEM;
+
+               dai = swidget->private;
+               dai->configured = false;
+               memcpy(comp, &dai->comp_dai, sizeof(struct sof_ipc_comp_dai));
+
+               /* append extended data to the end of the component */
+               memcpy((u8 *)comp + sizeof(struct sof_ipc_comp_dai), &swidget->comp_ext,
+                      sizeof(swidget->comp_ext));
+
+               ret = sof_ipc_tx_message(sdev->ipc, comp->hdr.cmd, comp, ipc_size, &r, sizeof(r));
+               kfree(comp);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: failed to load widget %s\n",
+                               swidget->widget->name);
+                       goto use_count_dec;
+               }
+
+               ret = sof_dai_config_setup(sdev, dai);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: failed to load dai config for DAI %s\n",
+                               swidget->widget->name);
+                       sof_widget_free(sdev, swidget);
+                       return ret;
+               }
+               break;
+       case snd_soc_dapm_scheduler:
+               pipeline = swidget->private;
+               ret = sof_load_pipeline_ipc(sdev, pipeline, &r);
+               break;
+       default:
+               hdr = swidget->private;
+               ret = sof_ipc_tx_message(sdev->ipc, hdr->cmd, swidget->private, hdr->size,
+                                        &r, sizeof(r));
+               break;
+       }
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed to load widget %s\n", swidget->widget->name);
+               goto use_count_dec;
+       }
+
+       /* restore kcontrols for widget */
+       ret = sof_widget_kcontrol_setup(sdev, swidget);
+       if (ret < 0) {
+               dev_err(sdev->dev, "error: failed to restore kcontrols for widget %s\n",
+                       swidget->widget->name);
+               sof_widget_free(sdev, swidget);
+               return ret;
+       }
+
+       dev_dbg(sdev->dev, "widget %s setup complete\n", swidget->widget->name);
+
+       return 0;
+
+use_count_dec:
+       swidget->use_count--;
+       return ret;
+}
+EXPORT_SYMBOL(sof_widget_setup);
+
+static int sof_route_setup_ipc(struct snd_sof_dev *sdev, struct snd_sof_route *sroute)
+{
+       struct sof_ipc_pipe_comp_connect *connect;
+       struct sof_ipc_reply reply;
+       int ret;
+
+       /* skip if there's no private data */
+       if (!sroute->private)
+               return 0;
+
+       /* nothing to do if route is already set up */
+       if (sroute->setup)
+               return 0;
+
+       connect = sroute->private;
+
+       dev_dbg(sdev->dev, "setting up route %s -> %s\n",
+               sroute->src_widget->widget->name,
+               sroute->sink_widget->widget->name);
+
+       /* send ipc */
+       ret = sof_ipc_tx_message(sdev->ipc,
+                                connect->hdr.cmd,
+                                connect, sizeof(*connect),
+                                &reply, sizeof(reply));
+       if (ret < 0) {
+               dev_err(sdev->dev, "%s: route setup failed %d\n", __func__, ret);
+               return ret;
+       }
+
+       sroute->setup = true;
+
+       return 0;
+}
+
+static int sof_route_setup(struct snd_sof_dev *sdev, struct snd_soc_dapm_widget *wsource,
+                          struct snd_soc_dapm_widget *wsink)
+{
+       struct snd_sof_widget *src_widget = wsource->dobj.private;
+       struct snd_sof_widget *sink_widget = wsink->dobj.private;
+       struct snd_sof_route *sroute;
+       bool route_found = false;
+
+       /* ignore routes involving virtual widgets in topology */
+       switch (src_widget->id) {
+       case snd_soc_dapm_out_drv:
+       case snd_soc_dapm_output:
+       case snd_soc_dapm_input:
+               return 0;
+       default:
+               break;
+       }
+
+       switch (sink_widget->id) {
+       case snd_soc_dapm_out_drv:
+       case snd_soc_dapm_output:
+       case snd_soc_dapm_input:
+               return 0;
+       default:
+               break;
+       }
+
+       /* find route matching source and sink widgets */
+       list_for_each_entry(sroute, &sdev->route_list, list)
+               if (sroute->src_widget == src_widget && sroute->sink_widget == sink_widget) {
+                       route_found = true;
+                       break;
+               }
+
+       if (!route_found) {
+               dev_err(sdev->dev, "error: cannot find SOF route for source %s -> %s sink\n",
+                       wsource->name, wsink->name);
+               return -EINVAL;
+       }
+
+       return sof_route_setup_ipc(sdev, sroute);
+}
+
+static int sof_setup_pipeline_connections(struct snd_sof_dev *sdev,
+                                         struct snd_soc_dapm_widget_list *list, int dir)
+{
+       struct snd_soc_dapm_widget *widget;
+       struct snd_soc_dapm_path *p;
+       int ret;
+       int i;
+
+       /*
+        * Set up connections between widgets in the sink/source paths based on direction.
+        * Some non-SOF widgets exist in topology either for compatibility or for the
+        * purpose of connecting a pipeline from a host to a DAI in order to receive the DAPM
+        * events. But they are not handled by the firmware. So ignore them.
+        */
+       if (dir == SNDRV_PCM_STREAM_PLAYBACK) {
+               for_each_dapm_widgets(list, i, widget) {
+                       if (!widget->dobj.private)
+                               continue;
+
+                       snd_soc_dapm_widget_for_each_sink_path(widget, p)
+                               if (p->sink->dobj.private) {
+                                       ret = sof_route_setup(sdev, widget, p->sink);
+                                       if (ret < 0)
+                                               return ret;
+                               }
+               }
+       } else {
+               for_each_dapm_widgets(list, i, widget) {
+                       if (!widget->dobj.private)
+                               continue;
+
+                       snd_soc_dapm_widget_for_each_source_path(widget, p)
+                               if (p->source->dobj.private) {
+                                       ret = sof_route_setup(sdev, p->source, widget);
+                                       if (ret < 0)
+                                               return ret;
+                               }
+               }
+       }
+
+       return 0;
+}
+
+int sof_widget_list_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm, int dir)
+{
+       struct snd_soc_dapm_widget_list *list = spcm->stream[dir].list;
+       struct snd_soc_dapm_widget *widget;
+       int i, ret, num_widgets;
+
+       /* nothing to set up */
+       if (!list)
+               return 0;
+
+       /* set up widgets in the list */
+       for_each_dapm_widgets(list, num_widgets, widget) {
+               struct snd_sof_widget *swidget = widget->dobj.private;
+               struct snd_sof_widget *pipe_widget;
+
+               if (!swidget)
+                       continue;
+
+               /*
+                * The scheduler widget for a pipeline is not part of the connected DAPM
+                * widget list and it needs to be set up before the widgets in the pipeline
+                * are set up. The use_count for the scheduler widget is incremented for every
+                * widget in a given pipeline to ensure that it is freed only after the last
+                * widget in the pipeline is freed.
+                */
+               pipe_widget = swidget->pipe_widget;
+               if (!pipe_widget) {
+                       dev_err(sdev->dev, "error: no pipeline widget found for %s\n",
+                               swidget->widget->name);
+                       ret = -EINVAL;
+                       goto widget_free;
+               }
+
+               ret = sof_widget_setup(sdev, pipe_widget);
+               if (ret < 0)
+                       goto widget_free;
+
+               /* set up the widget */
+               ret = sof_widget_setup(sdev, swidget);
+               if (ret < 0) {
+                       sof_widget_free(sdev, pipe_widget);
+                       goto widget_free;
+               }
+       }
+
+       /*
+        * error in setting pipeline connections will result in route status being reset for
+        * routes that were successfully set up when the widgets are freed.
+        */
+       ret = sof_setup_pipeline_connections(sdev, list, dir);
+       if (ret < 0)
+               goto widget_free;
+
+       /* complete pipelines */
+       for_each_dapm_widgets(list, i, widget) {
+               struct snd_sof_widget *swidget = widget->dobj.private;
+               struct snd_sof_widget *pipe_widget;
+
+               if (!swidget)
+                       continue;
+
+               pipe_widget = swidget->pipe_widget;
+               if (!pipe_widget) {
+                       dev_err(sdev->dev, "error: no pipeline widget found for %s\n",
+                               swidget->widget->name);
+                       ret = -EINVAL;
+                       goto widget_free;
+               }
+
+               if (pipe_widget->complete)
+                       continue;
+
+               pipe_widget->complete = snd_sof_complete_pipeline(sdev, pipe_widget);
+               if (pipe_widget->complete < 0) {
+                       ret = pipe_widget->complete;
+                       goto widget_free;
+               }
+       }
+
+       return 0;
+
+widget_free:
+       /* free all widgets that have been set up successfully */
+       for_each_dapm_widgets(list, i, widget) {
+               struct snd_sof_widget *swidget = widget->dobj.private;
+
+               if (!swidget)
+                       continue;
+
+               if (!num_widgets--)
+                       break;
+
+               sof_widget_free(sdev, swidget);
+               sof_widget_free(sdev, swidget->pipe_widget);
+       }
+
+       return ret;
+}
+
+int sof_widget_list_free(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm, int dir)
+{
+       struct snd_soc_dapm_widget_list *list = spcm->stream[dir].list;
+       struct snd_soc_dapm_widget *widget;
+       int i, ret;
+       int ret1 = 0;
+
+       /* nothing to free */
+       if (!list)
+               return 0;
+
+       /*
+        * Free widgets in the list. This can fail but continue freeing other widgets to keep
+        * use_counts balanced.
+        */
+       for_each_dapm_widgets(list, i, widget) {
+               struct snd_sof_widget *swidget = widget->dobj.private;
+
+               if (!swidget)
+                       continue;
+
+               /*
+                * free widget and its pipe_widget. Either of these can fail, but free as many as
+                * possible before freeing the list and returning the error.
+                */
+               ret = sof_widget_free(sdev, swidget);
+               if (ret < 0)
+                       ret1 = ret;
+
+               ret = sof_widget_free(sdev, swidget->pipe_widget);
+               if (ret < 0)
+                       ret1 = ret;
+       }
+
+       snd_soc_dapm_dai_free_widgets(&list);
+       spcm->stream[dir].list = NULL;
+
+       return ret1;
+}
+
 /*
  * helper to determine if there are only D0i3 compatible
  * streams active
@@ -93,55 +577,6 @@ int sof_set_hw_params_upon_resume(struct device *dev)
        return snd_sof_dsp_hw_params_upon_resume(sdev);
 }
 
-static int sof_restore_kcontrols(struct device *dev)
-{
-       struct snd_sof_dev *sdev = dev_get_drvdata(dev);
-       struct snd_sof_control *scontrol;
-       int ipc_cmd, ctrl_type;
-       int ret = 0;
-
-       /* restore kcontrol values */
-       list_for_each_entry(scontrol, &sdev->kcontrol_list, list) {
-               /* reset readback offset for scontrol after resuming */
-               scontrol->readback_offset = 0;
-
-               /* notify DSP of kcontrol values */
-               switch (scontrol->cmd) {
-               case SOF_CTRL_CMD_VOLUME:
-               case SOF_CTRL_CMD_ENUM:
-               case SOF_CTRL_CMD_SWITCH:
-                       ipc_cmd = SOF_IPC_COMP_SET_VALUE;
-                       ctrl_type = SOF_CTRL_TYPE_VALUE_CHAN_SET;
-                       ret = snd_sof_ipc_set_get_comp_data(scontrol,
-                                                           ipc_cmd, ctrl_type,
-                                                           scontrol->cmd,
-                                                           true);
-                       break;
-               case SOF_CTRL_CMD_BINARY:
-                       ipc_cmd = SOF_IPC_COMP_SET_DATA;
-                       ctrl_type = SOF_CTRL_TYPE_DATA_SET;
-                       ret = snd_sof_ipc_set_get_comp_data(scontrol,
-                                                           ipc_cmd, ctrl_type,
-                                                           scontrol->cmd,
-                                                           true);
-                       break;
-
-               default:
-                       break;
-               }
-
-               if (ret < 0) {
-                       dev_err(dev,
-                               "error: failed kcontrol value set for widget: %d\n",
-                               scontrol->comp_id);
-
-                       return ret;
-               }
-       }
-
-       return 0;
-}
-
 const struct sof_ipc_pipe_new *snd_sof_pipeline_find(struct snd_sof_dev *sdev,
                                                     int pipeline_id)
 {
@@ -158,142 +593,53 @@ const struct sof_ipc_pipe_new *snd_sof_pipeline_find(struct snd_sof_dev *sdev,
        return NULL;
 }
 
-int sof_restore_pipelines(struct device *dev)
+int sof_set_up_pipelines(struct snd_sof_dev *sdev, bool verify)
 {
-       struct snd_sof_dev *sdev = dev_get_drvdata(dev);
        struct snd_sof_widget *swidget;
        struct snd_sof_route *sroute;
-       struct sof_ipc_pipe_new *pipeline;
-       struct snd_sof_dai *dai;
-       struct sof_ipc_cmd_hdr *hdr;
-       struct sof_ipc_comp *comp;
-       size_t ipc_size;
        int ret;
 
        /* restore pipeline components */
        list_for_each_entry_reverse(swidget, &sdev->widget_list, list) {
-               struct sof_ipc_comp_reply r;
-
-               /* skip if there is no private data */
-               if (!swidget->private)
+               /* only set up the widgets belonging to static pipelines */
+               if (!verify && swidget->dynamic_pipeline_widget)
                        continue;
 
-               ret = sof_pipeline_core_enable(sdev, swidget);
-               if (ret < 0) {
-                       dev_err(dev,
-                               "error: failed to enable target core: %d\n",
-                               ret);
-
-                       return ret;
-               }
+               /* update DAI config. The IPC will be sent in sof_widget_setup() */
+               if (WIDGET_IS_DAI(swidget->id)) {
+                       struct snd_sof_dai *dai = swidget->private;
+                       struct sof_ipc_dai_config *config;
 
-               switch (swidget->id) {
-               case snd_soc_dapm_dai_in:
-               case snd_soc_dapm_dai_out:
-                       ipc_size = sizeof(struct sof_ipc_comp_dai) +
-                                  sizeof(struct sof_ipc_comp_ext);
-                       comp = kzalloc(ipc_size, GFP_KERNEL);
-                       if (!comp)
-                               return -ENOMEM;
-
-                       dai = swidget->private;
-                       memcpy(comp, &dai->comp_dai,
-                              sizeof(struct sof_ipc_comp_dai));
-
-                       /* append extended data to the end of the component */
-                       memcpy((u8 *)comp + sizeof(struct sof_ipc_comp_dai),
-                              &swidget->comp_ext, sizeof(swidget->comp_ext));
-
-                       ret = sof_ipc_tx_message(sdev->ipc, comp->hdr.cmd,
-                                                comp, ipc_size,
-                                                &r, sizeof(r));
-                       kfree(comp);
-                       break;
-               case snd_soc_dapm_scheduler:
+                       if (!dai || !dai->dai_config)
+                               continue;
 
+                       config = dai->dai_config;
                        /*
-                        * During suspend, all DSP cores are powered off.
-                        * Therefore upon resume, create the pipeline comp
-                        * and power up the core that the pipeline is
-                        * scheduled on.
+                        * The link DMA channel would be invalidated for running
+                        * streams but not for streams that were in the PAUSED
+                        * state during suspend. So invalidate it here before setting
+                        * the dai config in the DSP.
                         */
-                       pipeline = swidget->private;
-                       ret = sof_load_pipeline_ipc(dev, pipeline, &r);
-                       break;
-               default:
-                       hdr = swidget->private;
-                       ret = sof_ipc_tx_message(sdev->ipc, hdr->cmd,
-                                                swidget->private, hdr->size,
-                                                &r, sizeof(r));
-                       break;
+                       if (config->type == SOF_DAI_INTEL_HDA)
+                               config->hda.link_dma_ch = DMA_CHAN_INVALID;
                }
-               if (ret < 0) {
-                       dev_err(dev,
-                               "error: failed to load widget type %d with ID: %d\n",
-                               swidget->widget->id, swidget->comp_id);
 
+               ret = sof_widget_setup(sdev, swidget);
+               if (ret < 0)
                        return ret;
-               }
        }
 
        /* restore pipeline connections */
-       list_for_each_entry_reverse(sroute, &sdev->route_list, list) {
-               struct sof_ipc_pipe_comp_connect *connect;
-               struct sof_ipc_reply reply;
+       list_for_each_entry(sroute, &sdev->route_list, list) {
 
-               /* skip if there's no private data */
-               if (!sroute->private)
+               /* only set up routes belonging to static pipelines */
+               if (!verify && (sroute->src_widget->dynamic_pipeline_widget ||
+                               sroute->sink_widget->dynamic_pipeline_widget))
                        continue;
 
-               connect = sroute->private;
-
-               /* send ipc */
-               ret = sof_ipc_tx_message(sdev->ipc,
-                                        connect->hdr.cmd,
-                                        connect, sizeof(*connect),
-                                        &reply, sizeof(reply));
+               ret = sof_route_setup_ipc(sdev, sroute);
                if (ret < 0) {
-                       dev_err(dev,
-                               "error: failed to load route sink %s control %s source %s\n",
-                               sroute->route->sink,
-                               sroute->route->control ? sroute->route->control
-                                       : "none",
-                               sroute->route->source);
-
-                       return ret;
-               }
-       }
-
-       /* restore dai links */
-       list_for_each_entry_reverse(dai, &sdev->dai_list, list) {
-               struct sof_ipc_reply reply;
-               struct sof_ipc_dai_config *config = &dai->dai_config[dai->current_config];
-
-               if (!config) {
-                       dev_err(dev, "error: no config for DAI %s\n",
-                               dai->name);
-                       continue;
-               }
-
-               /*
-                * The link DMA channel would be invalidated for running
-                * streams but not for streams that were in the PAUSED
-                * state during suspend. So invalidate it here before setting
-                * the dai config in the DSP.
-                */
-               if (config->type == SOF_DAI_INTEL_HDA)
-                       config->hda.link_dma_ch = DMA_CHAN_INVALID;
-
-               ret = sof_ipc_tx_message(sdev->ipc,
-                                        config->hdr.cmd, config,
-                                        config->hdr.size,
-                                        &reply, sizeof(reply));
-
-               if (ret < 0) {
-                       dev_err(dev,
-                               "error: failed to set dai config for %s\n",
-                               dai->name);
-
+                       dev_err(sdev->dev, "%s: restore pipeline connections failed\n", __func__);
                        return ret;
                }
        }
@@ -302,21 +648,52 @@ int sof_restore_pipelines(struct device *dev)
        list_for_each_entry(swidget, &sdev->widget_list, list) {
                switch (swidget->id) {
                case snd_soc_dapm_scheduler:
+                       /* only complete static pipelines */
+                       if (!verify && swidget->dynamic_pipeline_widget)
+                               continue;
+
                        swidget->complete =
-                               snd_sof_complete_pipeline(dev, swidget);
+                               snd_sof_complete_pipeline(sdev, swidget);
                        break;
                default:
                        break;
                }
        }
 
-       /* restore pipeline kcontrols */
-       ret = sof_restore_kcontrols(dev);
-       if (ret < 0)
-               dev_err(dev,
-                       "error: restoring kcontrols after resume\n");
+       return 0;
+}
 
-       return ret;
+/*
+ * This function doesn't free widgets during suspend. It only resets the set up status for all
+ * routes and use_count for all widgets.
+ */
+int sof_tear_down_pipelines(struct snd_sof_dev *sdev, bool verify)
+{
+       struct snd_sof_widget *swidget;
+       struct snd_sof_route *sroute;
+       int ret;
+
+       /*
+        * This function is called during suspend and for one-time topology verification during
+        * first boot. In both cases, there is no need to protect swidget->use_count and
+        * sroute->setup because during suspend all streams are suspended and during topology
+        * loading the sound card unavailable to open PCMs.
+        */
+       list_for_each_entry_reverse(swidget, &sdev->widget_list, list) {
+               if (!verify) {
+                       swidget->use_count = 0;
+                       continue;
+               }
+
+               ret = sof_widget_free(sdev, swidget);
+               if (ret < 0)
+                       return ret;
+       }
+
+       list_for_each_entry(sroute, &sdev->route_list, list)
+               sroute->setup = false;
+
+       return 0;
 }
 
 /*
index dc274e6..05e98e2 100644 (file)
 
 #define DMA_CHAN_INVALID       0xFFFFFFFF
 
+#define WIDGET_IS_DAI(id) ((id) == snd_soc_dapm_dai_in || (id) == snd_soc_dapm_dai_out)
+
 /* PCM stream, mapped to FW component  */
 struct snd_sof_pcm_stream {
        u32 comp_id;
        struct snd_dma_buffer page_table;
        struct sof_ipc_stream_posn posn;
        struct snd_pcm_substream *substream;
+       struct snd_compr_stream *cstream;
        struct work_struct period_elapsed_work;
+       struct snd_soc_dapm_widget_list *list; /* list of connected DAPM widgets */
        bool d0i3_compatible; /* DSP can be in D0I3 when this pcm is opened */
        /*
         * flag to indicate that the DSP pipelines should be kept
@@ -66,6 +70,7 @@ struct snd_sof_control {
        int min_volume_step; /* min volume step for volume_table */
        int max_volume_step; /* max volume step for volume_table */
        int num_channels;
+       unsigned int access;
        u32 readback_offset; /* offset to mmapped data if used */
        struct sof_ipc_ctrl_data *control_data;
        u32 size;       /* cdata size */
@@ -75,19 +80,36 @@ struct snd_sof_control {
        struct list_head list;  /* list in sdev control list */
 
        struct snd_sof_led_control led_ctl;
+
+       /* if true, the control's data needs to be updated from Firmware */
+       bool comp_data_dirty;
 };
 
+struct snd_sof_widget;
+
 /* ASoC SOF DAPM widget */
 struct snd_sof_widget {
        struct snd_soc_component *scomp;
        int comp_id;
        int pipeline_id;
        int complete;
+       int use_count; /* use_count will be protected by the PCM mutex held by the core */
        int core;
        int id;
 
+       /*
+        * Flag indicating if the widget should be set up dynamically when a PCM is opened.
+        * This flag is only set for the scheduler type widget in topology. During topology
+        * loading, this flag is propagated to all the widgets belonging to the same pipeline.
+        * When this flag is not set, a widget is set up at the time of topology loading
+        * and retained until the DSP enters D3. It will need to be set up again when resuming
+        * from D3.
+        */
+       bool dynamic_pipeline_widget;
+
        struct snd_soc_dapm_widget *widget;
        struct list_head list;  /* list in sdev widget list */
+       struct snd_sof_widget *pipe_widget;
 
        /* extended data for UUID components */
        struct sof_ipc_comp_ext comp_ext;
@@ -101,6 +123,9 @@ struct snd_sof_route {
 
        struct snd_soc_dapm_route *route;
        struct list_head list;  /* list in sdev route list */
+       struct snd_sof_widget *src_widget;
+       struct snd_sof_widget *sink_widget;
+       bool setup;
 
        void *private;
 };
@@ -109,11 +134,11 @@ struct snd_sof_route {
 struct snd_sof_dai {
        struct snd_soc_component *scomp;
        const char *name;
-       const char *cpu_dai_name;
 
        struct sof_ipc_comp_dai comp_dai;
        int number_configs;
        int current_config;
+       bool configured; /* DAI configured during BE hw_params */
        struct sof_ipc_dai_config *dai_config;
        struct list_head list;  /* list in sdev dai list */
 };
@@ -148,6 +173,8 @@ int snd_sof_bytes_ext_get(struct snd_kcontrol *kcontrol,
                          unsigned int size);
 int snd_sof_bytes_ext_volatile_get(struct snd_kcontrol *kcontrol, unsigned int __user *binary_data,
                                   unsigned int size);
+void snd_sof_control_notify(struct snd_sof_dev *sdev,
+                           struct sof_ipc_ctrl_data *cdata);
 
 /*
  * Topology.
@@ -155,10 +182,10 @@ int snd_sof_bytes_ext_volatile_get(struct snd_kcontrol *kcontrol, unsigned int _
  * be freed by snd_soc_unregister_component,
  */
 int snd_sof_load_topology(struct snd_soc_component *scomp, const char *file);
-int snd_sof_complete_pipeline(struct device *dev,
+int snd_sof_complete_pipeline(struct snd_sof_dev *sdev,
                              struct snd_sof_widget *swidget);
 
-int sof_load_pipeline_ipc(struct device *dev,
+int sof_load_pipeline_ipc(struct snd_sof_dev *sdev,
                          struct sof_ipc_pipe_new *pipeline,
                          struct sof_ipc_comp_reply *r);
 int sof_pipeline_core_enable(struct snd_sof_dev *sdev,
@@ -205,7 +232,15 @@ struct snd_sof_pcm *snd_sof_find_spcm_pcm_id(struct snd_soc_component *scomp,
 const struct sof_ipc_pipe_new *snd_sof_pipeline_find(struct snd_sof_dev *sdev,
                                                     int pipeline_id);
 void snd_sof_pcm_period_elapsed(struct snd_pcm_substream *substream);
-void snd_sof_pcm_period_elapsed_work(struct work_struct *work);
+void snd_sof_pcm_init_elapsed_work(struct work_struct *work);
+
+#if IS_ENABLED(CONFIG_SND_SOC_SOF_COMPRESS)
+void snd_sof_compr_fragment_elapsed(struct snd_compr_stream *cstream);
+void snd_sof_compr_init_elapsed_work(struct work_struct *work);
+#else
+static inline void snd_sof_compr_fragment_elapsed(struct snd_compr_stream *cstream) { }
+static inline void snd_sof_compr_init_elapsed_work(struct work_struct *work) { }
+#endif
 
 /*
  * Mixer IPC
@@ -220,7 +255,8 @@ int snd_sof_ipc_set_get_comp_data(struct snd_sof_control *scontrol,
 int sof_pcm_dai_link_fixup(struct snd_soc_pcm_runtime *rtd, struct snd_pcm_hw_params *params);
 
 /* PM */
-int sof_restore_pipelines(struct device *dev);
+int sof_set_up_pipelines(struct snd_sof_dev *sdev, bool verify);
+int sof_tear_down_pipelines(struct snd_sof_dev *sdev, bool verify);
 int sof_set_hw_params_upon_resume(struct device *dev);
 bool snd_sof_stream_suspend_ignored(struct snd_sof_dev *sdev);
 bool snd_sof_dsp_only_d0i3_compatible_stream_active(struct snd_sof_dev *sdev);
@@ -229,4 +265,10 @@ bool snd_sof_dsp_only_d0i3_compatible_stream_active(struct snd_sof_dev *sdev);
 int sof_machine_register(struct snd_sof_dev *sdev, void *pdata);
 void sof_machine_unregister(struct snd_sof_dev *sdev, void *pdata);
 
+int sof_widget_setup(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget);
+int sof_widget_free(struct snd_sof_dev *sdev, struct snd_sof_widget *swidget);
+
+/* PCM */
+int sof_widget_list_setup(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm, int dir);
+int sof_widget_list_free(struct snd_sof_dev *sdev, struct snd_sof_pcm *spcm, int dir);
 #endif
index d1a21ed..885430a 100644 (file)
@@ -7,14 +7,20 @@
 
 #include <linux/firmware.h>
 #include <linux/module.h>
+#include <linux/moduleparam.h>
 #include <linux/pm_runtime.h>
 #include <sound/sof.h>
 
 #include "ops.h"
+#include "imx/imx-ops.h"
 
-extern struct snd_sof_dsp_ops sof_imx8_ops;
-extern struct snd_sof_dsp_ops sof_imx8x_ops;
-extern struct snd_sof_dsp_ops sof_imx8m_ops;
+static char *fw_path;
+module_param(fw_path, charp, 0444);
+MODULE_PARM_DESC(fw_path, "alternate path for SOF firmware.");
+
+static char *tplg_path;
+module_param(tplg_path, charp, 0444);
+MODULE_PARM_DESC(tplg_path, "alternate path for SOF topology.");
 
 /* platform specific devices */
 #if IS_ENABLED(CONFIG_SND_SOC_SOF_IMX8)
@@ -90,9 +96,15 @@ static int sof_of_probe(struct platform_device *pdev)
        sof_pdata->dev = &pdev->dev;
        sof_pdata->fw_filename = desc->default_fw_filename;
 
-       /* TODO: read alternate fw and tplg filenames from DT */
-       sof_pdata->fw_filename_prefix = sof_pdata->desc->default_fw_path;
-       sof_pdata->tplg_filename_prefix = sof_pdata->desc->default_tplg_path;
+       if (fw_path)
+               sof_pdata->fw_filename_prefix = fw_path;
+       else
+               sof_pdata->fw_filename_prefix = sof_pdata->desc->default_fw_path;
+
+       if (tplg_path)
+               sof_pdata->tplg_filename_prefix = tplg_path;
+       else
+               sof_pdata->tplg_filename_prefix = sof_pdata->desc->default_tplg_path;
 
        /* set callback to be called on successful device probe to enable runtime_pm */
        sof_pdata->sof_probe_complete = sof_of_probe_complete;
index fd84231..ba341b1 100644 (file)
 /* debug flags */
 #define SOF_DBG_ENABLE_TRACE   BIT(0)
 #define SOF_DBG_RETAIN_CTX     BIT(1)  /* prevent DSP D3 on FW exception */
+#define SOF_DBG_VERIFY_TPLG    BIT(2) /* verify topology during load */
+#define SOF_DBG_DYNAMIC_PIPELINES_OVERRIDE     BIT(3) /* 0: use topology token
+                                                       * 1: override topology
+                                                       */
+#define SOF_DBG_DYNAMIC_PIPELINES_ENABLE       BIT(4) /* 0: use static pipelines
+                                                       * 1: use dynamic pipelines
+                                                       */
+#define SOF_DBG_DISABLE_MULTICORE              BIT(5) /* schedule all pipelines/widgets
+                                                       * on primary core
+                                                       */
+#define SOF_DBG_PRINT_ALL_DUMPS                BIT(6) /* Print all ipc and dsp dumps */
 
 #define SOF_DBG_DUMP_REGS              BIT(0)
 #define SOF_DBG_DUMP_MBOX              BIT(1)
 #define SOF_DBG_DUMP_TEXT              BIT(2)
 #define SOF_DBG_DUMP_PCI               BIT(3)
-#define SOF_DBG_DUMP_FORCE_ERR_LEVEL   BIT(4) /* used to dump dsp status with error log level */
-
+#define SOF_DBG_DUMP_OPTIONAL          BIT(4) /* only dump if SOF_DBG_PRINT_ALL_DUMPS is set */
 
 /* global debug state set by SOF_DBG_ flags */
 extern int sof_core_debug;
@@ -83,6 +93,16 @@ enum sof_system_suspend_state {
        SOF_SUSPEND_S3,
 };
 
+enum sof_dfsentry_type {
+       SOF_DFSENTRY_TYPE_IOMEM = 0,
+       SOF_DFSENTRY_TYPE_BUF,
+};
+
+enum sof_debugfs_access_type {
+       SOF_DEBUGFS_ACCESS_ALWAYS = 0,
+       SOF_DEBUGFS_ACCESS_D0_ONLY,
+};
+
 struct snd_sof_dev;
 struct snd_sof_ipc_msg;
 struct snd_sof_ipc;
@@ -127,12 +147,20 @@ struct snd_sof_dsp_ops {
                      void __iomem *addr); /* optional */
 
        /* memcpy IO */
-       void (*block_read)(struct snd_sof_dev *sof_dev, u32 bar,
-                          u32 offset, void *dest,
-                          size_t size); /* mandatory */
-       void (*block_write)(struct snd_sof_dev *sof_dev, u32 bar,
-                           u32 offset, void *src,
-                           size_t size); /* mandatory */
+       int (*block_read)(struct snd_sof_dev *sof_dev,
+                         enum snd_sof_fw_blk_type type, u32 offset,
+                         void *dest, size_t size); /* mandatory */
+       int (*block_write)(struct snd_sof_dev *sof_dev,
+                          enum snd_sof_fw_blk_type type, u32 offset,
+                          void *src, size_t size); /* mandatory */
+
+       /* Mailbox IO */
+       void (*mailbox_read)(struct snd_sof_dev *sof_dev,
+                            u32 offset, void *dest,
+                            size_t size); /* optional */
+       void (*mailbox_write)(struct snd_sof_dev *sof_dev,
+                             u32 offset, void *src,
+                             size_t size); /* optional */
 
        /* doorbell */
        irqreturn_t (*irq_handler)(int irq, void *context); /* optional */
@@ -200,9 +228,9 @@ struct snd_sof_dsp_ops {
 #endif
 
        /* host read DSP stream data */
-       void (*ipc_msg_data)(struct snd_sof_dev *sdev,
-                            struct snd_pcm_substream *substream,
-                            void *p, size_t sz); /* mandatory */
+       int (*ipc_msg_data)(struct snd_sof_dev *sdev,
+                           struct snd_pcm_substream *substream,
+                           void *p, size_t sz); /* mandatory */
 
        /* host configure DSP HW parameters */
        int (*ipc_pcm_params)(struct snd_sof_dev *sdev,
@@ -237,6 +265,10 @@ struct snd_sof_dsp_ops {
        void (*dbg_dump)(struct snd_sof_dev *sof_dev,
                         u32 flags); /* optional */
        void (*ipc_dump)(struct snd_sof_dev *sof_dev); /* optional */
+       int (*debugfs_add_region_item)(struct snd_sof_dev *sdev,
+                                      enum snd_sof_fw_blk_type blk_type, u32 offset,
+                                      size_t size, const char *name,
+                                      enum sof_debugfs_access_type access_type); /* optional */
 
        /* host DMA trace initialization */
        int (*trace_init)(struct snd_sof_dev *sdev,
@@ -268,33 +300,17 @@ struct snd_sof_dsp_ops {
        /* ALSA HW info flags, will be stored in snd_pcm_runtime.hw.info */
        u32 hw_info;
 
-       const struct sof_arch_ops *arch_ops;
+       const struct dsp_arch_ops *dsp_arch_ops;
 };
 
 /* DSP architecture specific callbacks for oops and stack dumps */
-struct sof_arch_ops {
+struct dsp_arch_ops {
        void (*dsp_oops)(struct snd_sof_dev *sdev, void *oops);
        void (*dsp_stack)(struct snd_sof_dev *sdev, void *oops,
                          u32 *stack, u32 stack_words);
 };
 
-#define sof_arch_ops(sdev) ((sdev)->pdata->desc->ops->arch_ops)
-
-/* DSP device HW descriptor mapping between bus ID and ops */
-struct sof_ops_table {
-       const struct sof_dev_desc *desc;
-       const struct snd_sof_dsp_ops *ops;
-};
-
-enum sof_dfsentry_type {
-       SOF_DFSENTRY_TYPE_IOMEM = 0,
-       SOF_DFSENTRY_TYPE_BUF,
-};
-
-enum sof_debugfs_access_type {
-       SOF_DEBUGFS_ACCESS_ALWAYS = 0,
-       SOF_DEBUGFS_ACCESS_D0_ONLY,
-};
+#define sof_dsp_arch_ops(sdev) ((sdev)->pdata->desc->ops->dsp_arch_ops)
 
 /* FS entry for debug files that can expose DSP memories, registers */
 struct snd_sof_dfsentry {
@@ -413,6 +429,8 @@ struct snd_sof_dev {
        /* debug */
        struct dentry *debugfs_root;
        struct list_head dfsentry_list;
+       bool dbg_dump_printed;
+       bool ipc_dump_printed;
 
        /* firmware loader */
        struct snd_dma_buffer dmab;
@@ -485,14 +503,12 @@ int snd_sof_create_page_table(struct device *dev,
 /*
  * Firmware loading.
  */
-int snd_sof_load_firmware(struct snd_sof_dev *sdev);
 int snd_sof_load_firmware_raw(struct snd_sof_dev *sdev);
 int snd_sof_load_firmware_memcpy(struct snd_sof_dev *sdev);
 int snd_sof_run_firmware(struct snd_sof_dev *sdev);
 int snd_sof_parse_module_memcpy(struct snd_sof_dev *sdev,
                                struct snd_sof_mod_hdr *module);
 void snd_sof_fw_unload(struct snd_sof_dev *sdev);
-int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset);
 
 /*
  * IPC low level APIs.
@@ -503,9 +519,6 @@ void snd_sof_ipc_reply(struct snd_sof_dev *sdev, u32 msg_id);
 void snd_sof_ipc_msgs_rx(struct snd_sof_dev *sdev);
 int snd_sof_ipc_stream_pcm_params(struct snd_sof_dev *sdev,
                                  struct sof_ipc_pcm_params *params);
-int snd_sof_dsp_mailbox_init(struct snd_sof_dev *sdev, u32 dspbox,
-                            size_t dspbox_size, u32 hostbox,
-                            size_t hostbox_size);
 int snd_sof_ipc_valid(struct snd_sof_dev *sdev);
 int sof_ipc_tx_message(struct snd_sof_ipc *ipc, u32 header,
                       void *msg_data, size_t msg_bytes, void *reply_data,
@@ -513,6 +526,7 @@ int sof_ipc_tx_message(struct snd_sof_ipc *ipc, u32 header,
 int sof_ipc_tx_message_no_pm(struct snd_sof_ipc *ipc, u32 header,
                             void *msg_data, size_t msg_bytes,
                             void *reply_data, size_t reply_bytes);
+int sof_ipc_init_msg_memory(struct snd_sof_dev *sdev);
 
 /*
  * Trace/debug
@@ -522,10 +536,6 @@ void snd_sof_release_trace(struct snd_sof_dev *sdev);
 void snd_sof_free_trace(struct snd_sof_dev *sdev);
 int snd_sof_dbg_init(struct snd_sof_dev *sdev);
 void snd_sof_free_debug(struct snd_sof_dev *sdev);
-int snd_sof_debugfs_io_item(struct snd_sof_dev *sdev,
-                           void __iomem *base, size_t size,
-                           const char *name,
-                           enum sof_debugfs_access_type access_type);
 int snd_sof_debugfs_buf_item(struct snd_sof_dev *sdev,
                             void *base, size_t size,
                             const char *name, mode_t mode);
@@ -539,11 +549,9 @@ void snd_sof_get_status(struct snd_sof_dev *sdev, u32 panic_code,
 int snd_sof_init_trace_ipc(struct snd_sof_dev *sdev);
 void snd_sof_handle_fw_exception(struct snd_sof_dev *sdev);
 int snd_sof_dbg_memory_info_init(struct snd_sof_dev *sdev);
-
-/*
- * Platform specific ops.
- */
-extern struct snd_compress_ops sof_compressed_ops;
+int snd_sof_debugfs_add_region_item_iomem(struct snd_sof_dev *sdev,
+               enum snd_sof_fw_blk_type blk_type, u32 offset, size_t size,
+               const char *name, enum sof_debugfs_access_type access_type);
 
 /*
  * DSP Architectures.
@@ -551,16 +559,29 @@ extern struct snd_compress_ops sof_compressed_ops;
 static inline void sof_stack(struct snd_sof_dev *sdev, void *oops, u32 *stack,
                             u32 stack_words)
 {
-               sof_arch_ops(sdev)->dsp_stack(sdev, oops, stack, stack_words);
+               sof_dsp_arch_ops(sdev)->dsp_stack(sdev, oops, stack, stack_words);
 }
 
 static inline void sof_oops(struct snd_sof_dev *sdev, void *oops)
 {
-       if (sof_arch_ops(sdev)->dsp_oops)
-               sof_arch_ops(sdev)->dsp_oops(sdev, oops);
+       if (sof_dsp_arch_ops(sdev)->dsp_oops)
+               sof_dsp_arch_ops(sdev)->dsp_oops(sdev, oops);
 }
 
-extern const struct sof_arch_ops sof_xtensa_arch_ops;
+extern const struct dsp_arch_ops sof_xtensa_arch_ops;
+
+/*
+ * Firmware state tracking
+ */
+static inline void sof_set_fw_state(struct snd_sof_dev *sdev,
+                                   enum snd_sof_fw_state new_state)
+{
+       if (sdev->fw_state == new_state)
+               return;
+
+       dev_dbg(sdev->dev, "fw_state change: %d -> %d\n", sdev->fw_state, new_state);
+       sdev->fw_state = new_state;
+}
 
 /*
  * Utilities
@@ -573,33 +594,24 @@ void sof_mailbox_write(struct snd_sof_dev *sdev, u32 offset,
                       void *message, size_t bytes);
 void sof_mailbox_read(struct snd_sof_dev *sdev, u32 offset,
                      void *message, size_t bytes);
-void sof_block_write(struct snd_sof_dev *sdev, u32 bar, u32 offset, void *src,
-                    size_t size);
-void sof_block_read(struct snd_sof_dev *sdev, u32 bar, u32 offset, void *dest,
-                   size_t size);
+int sof_block_write(struct snd_sof_dev *sdev, enum snd_sof_fw_blk_type blk_type,
+                   u32 offset, void *src, size_t size);
+int sof_block_read(struct snd_sof_dev *sdev, enum snd_sof_fw_blk_type blk_type,
+                  u32 offset, void *dest, size_t size);
 
 int sof_fw_ready(struct snd_sof_dev *sdev, u32 msg_id);
 
-void intel_ipc_msg_data(struct snd_sof_dev *sdev,
-                       struct snd_pcm_substream *substream,
-                       void *p, size_t sz);
-int intel_ipc_pcm_params(struct snd_sof_dev *sdev,
-                        struct snd_pcm_substream *substream,
-                        const struct sof_ipc_pcm_params_reply *reply);
+int sof_ipc_msg_data(struct snd_sof_dev *sdev,
+                    struct snd_pcm_substream *substream,
+                    void *p, size_t sz);
+int sof_ipc_pcm_params(struct snd_sof_dev *sdev,
+                      struct snd_pcm_substream *substream,
+                      const struct sof_ipc_pcm_params_reply *reply);
 
-int intel_pcm_open(struct snd_sof_dev *sdev,
-                  struct snd_pcm_substream *substream);
-int intel_pcm_close(struct snd_sof_dev *sdev,
-                   struct snd_pcm_substream *substream);
+int sof_stream_pcm_open(struct snd_sof_dev *sdev,
+                       struct snd_pcm_substream *substream);
+int sof_stream_pcm_close(struct snd_sof_dev *sdev,
+                        struct snd_pcm_substream *substream);
 
 int sof_machine_check(struct snd_sof_dev *sdev);
-
-#define sof_dev_dbg_or_err(dev, is_err, fmt, ...)                      \
-       do {                                                            \
-               if (is_err)                                             \
-                       dev_err(dev, "error: " fmt, __VA_ARGS__);       \
-               else                                                    \
-                       dev_dbg(dev, fmt, __VA_ARGS__);                 \
-       } while (0)
-
 #endif
diff --git a/sound/soc/sof/sof-probes.c b/sound/soc/sof/sof-probes.c
new file mode 100644 (file)
index 0000000..5586af9
--- /dev/null
@@ -0,0 +1,364 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license.  When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2019-2021 Intel Corporation. All rights reserved.
+// Author: Cezary Rojewski <cezary.rojewski@intel.com>
+//
+
+#include <sound/soc.h>
+#include "ops.h"
+#include "sof-priv.h"
+#include "sof-probes.h"
+
+struct sof_probe_dma {
+       unsigned int stream_tag;
+       unsigned int dma_buffer_size;
+} __packed;
+
+struct sof_ipc_probe_dma_add_params {
+       struct sof_ipc_cmd_hdr hdr;
+       unsigned int num_elems;
+       struct sof_probe_dma dma[];
+} __packed;
+
+struct sof_ipc_probe_info_params {
+       struct sof_ipc_reply rhdr;
+       unsigned int num_elems;
+       union {
+               struct sof_probe_dma dma[0];
+               struct sof_probe_point_desc desc[0];
+       };
+} __packed;
+
+struct sof_ipc_probe_point_add_params {
+       struct sof_ipc_cmd_hdr hdr;
+       unsigned int num_elems;
+       struct sof_probe_point_desc desc[];
+} __packed;
+
+struct sof_ipc_probe_point_remove_params {
+       struct sof_ipc_cmd_hdr hdr;
+       unsigned int num_elems;
+       unsigned int buffer_id[];
+} __packed;
+
+/**
+ * sof_ipc_probe_init - initialize data probing
+ * @sdev:              SOF sound device
+ * @stream_tag:                Extractor stream tag
+ * @buffer_size:       DMA buffer size to set for extractor
+ *
+ * Host chooses whether extraction is supported or not by providing
+ * valid stream tag to DSP. Once specified, stream described by that
+ * tag will be tied to DSP for extraction for the entire lifetime of
+ * probe.
+ *
+ * Probing is initialized only once and each INIT request must be
+ * matched by DEINIT call.
+ */
+static int sof_ipc_probe_init(struct snd_sof_dev *sdev, u32 stream_tag,
+                             size_t buffer_size)
+{
+       struct sof_ipc_probe_dma_add_params *msg;
+       struct sof_ipc_reply reply;
+       size_t size = struct_size(msg, dma, 1);
+       int ret;
+
+       msg = kmalloc(size, GFP_KERNEL);
+       if (!msg)
+               return -ENOMEM;
+       msg->hdr.size = size;
+       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_INIT;
+       msg->num_elems = 1;
+       msg->dma[0].stream_tag = stream_tag;
+       msg->dma[0].dma_buffer_size = buffer_size;
+
+       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
+                       &reply, sizeof(reply));
+       kfree(msg);
+       return ret;
+}
+
+/**
+ * sof_ipc_probe_deinit - cleanup after data probing
+ * @sdev:      SOF sound device
+ *
+ * Host sends DEINIT request to free previously initialized probe
+ * on DSP side once it is no longer needed. DEINIT only when there
+ * are no probes connected and with all injectors detached.
+ */
+static int sof_ipc_probe_deinit(struct snd_sof_dev *sdev)
+{
+       struct sof_ipc_cmd_hdr msg;
+       struct sof_ipc_reply reply;
+
+       msg.size = sizeof(msg);
+       msg.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_DEINIT;
+
+       return sof_ipc_tx_message(sdev->ipc, msg.cmd, &msg, msg.size,
+                       &reply, sizeof(reply));
+}
+
+static int sof_ipc_probe_info(struct snd_sof_dev *sdev, unsigned int cmd,
+                             void **params, size_t *num_params)
+{
+       struct sof_ipc_probe_info_params msg = {{{0}}};
+       struct sof_ipc_probe_info_params *reply;
+       size_t bytes;
+       int ret;
+
+       *params = NULL;
+       *num_params = 0;
+
+       reply = kzalloc(SOF_IPC_MSG_MAX_SIZE, GFP_KERNEL);
+       if (!reply)
+               return -ENOMEM;
+       msg.rhdr.hdr.size = sizeof(msg);
+       msg.rhdr.hdr.cmd = SOF_IPC_GLB_PROBE | cmd;
+
+       ret = sof_ipc_tx_message(sdev->ipc, msg.rhdr.hdr.cmd, &msg,
+                       msg.rhdr.hdr.size, reply, SOF_IPC_MSG_MAX_SIZE);
+       if (ret < 0 || reply->rhdr.error < 0)
+               goto exit;
+
+       if (!reply->num_elems)
+               goto exit;
+
+       if (cmd == SOF_IPC_PROBE_DMA_INFO)
+               bytes = sizeof(reply->dma[0]);
+       else
+               bytes = sizeof(reply->desc[0]);
+       bytes *= reply->num_elems;
+       *params = kmemdup(&reply->dma[0], bytes, GFP_KERNEL);
+       if (!*params) {
+               ret = -ENOMEM;
+               goto exit;
+       }
+       *num_params = reply->num_elems;
+
+exit:
+       kfree(reply);
+       return ret;
+}
+
+/**
+ * sof_ipc_probe_points_info - retrieve list of active probe points
+ * @sdev:      SOF sound device
+ * @desc:      Returned list of active probes
+ * @num_desc:  Returned count of active probes
+ *
+ * Host sends PROBE_POINT_INFO request to obtain list of active probe
+ * points, valid for disconnection when given probe is no longer
+ * required.
+ */
+int sof_ipc_probe_points_info(struct snd_sof_dev *sdev,
+                             struct sof_probe_point_desc **desc,
+                             size_t *num_desc)
+{
+       return sof_ipc_probe_info(sdev, SOF_IPC_PROBE_POINT_INFO,
+                                (void **)desc, num_desc);
+}
+EXPORT_SYMBOL(sof_ipc_probe_points_info);
+
+/**
+ * sof_ipc_probe_points_add - connect specified probes
+ * @sdev:      SOF sound device
+ * @desc:      List of probe points to connect
+ * @num_desc:  Number of elements in @desc
+ *
+ * Dynamically connects to provided set of endpoints. Immediately
+ * after connection is established, host must be prepared to
+ * transfer data from or to target stream given the probing purpose.
+ *
+ * Each probe point should be removed using PROBE_POINT_REMOVE
+ * request when no longer needed.
+ */
+int sof_ipc_probe_points_add(struct snd_sof_dev *sdev,
+                            struct sof_probe_point_desc *desc, size_t num_desc)
+{
+       struct sof_ipc_probe_point_add_params *msg;
+       struct sof_ipc_reply reply;
+       size_t size = struct_size(msg, desc, num_desc);
+       int ret;
+
+       msg = kmalloc(size, GFP_KERNEL);
+       if (!msg)
+               return -ENOMEM;
+       msg->hdr.size = size;
+       msg->num_elems = num_desc;
+       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_POINT_ADD;
+       memcpy(&msg->desc[0], desc, size - sizeof(*msg));
+
+       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
+                       &reply, sizeof(reply));
+       kfree(msg);
+       return ret;
+}
+EXPORT_SYMBOL(sof_ipc_probe_points_add);
+
+/**
+ * sof_ipc_probe_points_remove - disconnect specified probes
+ * @sdev:              SOF sound device
+ * @buffer_id:         List of probe points to disconnect
+ * @num_buffer_id:     Number of elements in @desc
+ *
+ * Removes previously connected probes from list of active probe
+ * points and frees all resources on DSP side.
+ */
+int sof_ipc_probe_points_remove(struct snd_sof_dev *sdev,
+                               unsigned int *buffer_id, size_t num_buffer_id)
+{
+       struct sof_ipc_probe_point_remove_params *msg;
+       struct sof_ipc_reply reply;
+       size_t size = struct_size(msg, buffer_id, num_buffer_id);
+       int ret;
+
+       msg = kmalloc(size, GFP_KERNEL);
+       if (!msg)
+               return -ENOMEM;
+       msg->hdr.size = size;
+       msg->num_elems = num_buffer_id;
+       msg->hdr.cmd = SOF_IPC_GLB_PROBE | SOF_IPC_PROBE_POINT_REMOVE;
+       memcpy(&msg->buffer_id[0], buffer_id, size - sizeof(*msg));
+
+       ret = sof_ipc_tx_message(sdev->ipc, msg->hdr.cmd, msg, msg->hdr.size,
+                       &reply, sizeof(reply));
+       kfree(msg);
+       return ret;
+}
+EXPORT_SYMBOL(sof_ipc_probe_points_remove);
+
+static int sof_probe_compr_startup(struct snd_compr_stream *cstream,
+                                  struct snd_soc_dai *dai)
+{
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+       int ret;
+
+       ret = snd_sof_probe_compr_assign(sdev, cstream, dai);
+       if (ret < 0) {
+               dev_err(dai->dev, "Failed to assign probe stream: %d\n", ret);
+               return ret;
+       }
+
+       sdev->extractor_stream_tag = ret;
+       return 0;
+}
+
+static int sof_probe_compr_shutdown(struct snd_compr_stream *cstream,
+                                   struct snd_soc_dai *dai)
+{
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+       struct sof_probe_point_desc *desc;
+       size_t num_desc;
+       int i, ret;
+
+       /* disconnect all probe points */
+       ret = sof_ipc_probe_points_info(sdev, &desc, &num_desc);
+       if (ret < 0) {
+               dev_err(dai->dev, "Failed to get probe points: %d\n", ret);
+               goto exit;
+       }
+
+       for (i = 0; i < num_desc; i++)
+               sof_ipc_probe_points_remove(sdev, &desc[i].buffer_id, 1);
+       kfree(desc);
+
+exit:
+       ret = sof_ipc_probe_deinit(sdev);
+       if (ret < 0)
+               dev_err(dai->dev, "Failed to deinit probe: %d\n", ret);
+
+       sdev->extractor_stream_tag = SOF_PROBE_INVALID_NODE_ID;
+       snd_compr_free_pages(cstream);
+
+       return snd_sof_probe_compr_free(sdev, cstream, dai);
+}
+
+static int sof_probe_compr_set_params(struct snd_compr_stream *cstream,
+                                     struct snd_compr_params *params,
+                                     struct snd_soc_dai *dai)
+{
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+       struct snd_compr_runtime *rtd = cstream->runtime;
+       int ret;
+
+       cstream->dma_buffer.dev.type = SNDRV_DMA_TYPE_DEV_SG;
+       cstream->dma_buffer.dev.dev = sdev->dev;
+       ret = snd_compr_malloc_pages(cstream, rtd->buffer_size);
+       if (ret < 0)
+               return ret;
+
+       ret = snd_sof_probe_compr_set_params(sdev, cstream, params, dai);
+       if (ret < 0)
+               return ret;
+
+       ret = sof_ipc_probe_init(sdev, sdev->extractor_stream_tag,
+                                rtd->dma_bytes);
+       if (ret < 0) {
+               dev_err(dai->dev, "Failed to init probe: %d\n", ret);
+               return ret;
+       }
+
+       return 0;
+}
+
+static int sof_probe_compr_trigger(struct snd_compr_stream *cstream, int cmd,
+                                  struct snd_soc_dai *dai)
+{
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+
+       return snd_sof_probe_compr_trigger(sdev, cstream, cmd, dai);
+}
+
+static int sof_probe_compr_pointer(struct snd_compr_stream *cstream,
+                                  struct snd_compr_tstamp *tstamp,
+                                  struct snd_soc_dai *dai)
+{
+       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(dai->component);
+
+       return snd_sof_probe_compr_pointer(sdev, cstream, tstamp, dai);
+}
+
+struct snd_soc_cdai_ops sof_probe_compr_ops = {
+       .startup        = sof_probe_compr_startup,
+       .shutdown       = sof_probe_compr_shutdown,
+       .set_params     = sof_probe_compr_set_params,
+       .trigger        = sof_probe_compr_trigger,
+       .pointer        = sof_probe_compr_pointer,
+};
+EXPORT_SYMBOL(sof_probe_compr_ops);
+
+static int sof_probe_compr_copy(struct snd_soc_component *component,
+                               struct snd_compr_stream *cstream,
+                               char __user *buf, size_t count)
+{
+       struct snd_compr_runtime *rtd = cstream->runtime;
+       unsigned int offset, n;
+       void *ptr;
+       int ret;
+
+       if (count > rtd->buffer_size)
+               count = rtd->buffer_size;
+
+       div_u64_rem(rtd->total_bytes_transferred, rtd->buffer_size, &offset);
+       ptr = rtd->dma_area + offset;
+       n = rtd->buffer_size - offset;
+
+       if (count < n) {
+               ret = copy_to_user(buf, ptr, count);
+       } else {
+               ret = copy_to_user(buf, ptr, n);
+               ret += copy_to_user(buf + n, rtd->dma_area, count - n);
+       }
+
+       if (ret)
+               return count - ret;
+       return count;
+}
+
+const struct snd_compress_ops sof_probe_compressed_ops = {
+       .copy           = sof_probe_compr_copy,
+};
+EXPORT_SYMBOL(sof_probe_compressed_ops);
diff --git a/sound/soc/sof/sof-probes.h b/sound/soc/sof/sof-probes.h
new file mode 100644 (file)
index 0000000..35e1dd8
--- /dev/null
@@ -0,0 +1,38 @@
+/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause) */
+/*
+ * This file is provided under a dual BSD/GPLv2 license.  When using or
+ * redistributing this file, you may do so under either license.
+ *
+ * Copyright(c) 2019-2021 Intel Corporation. All rights reserved.
+ * Author: Cezary Rojewski <cezary.rojewski@intel.com>
+ */
+
+#ifndef __SOF_PROBES_H
+#define __SOF_PROBES_H
+
+#include <sound/compress_driver.h>
+#include <sound/sof/header.h>
+
+struct snd_sof_dev;
+
+#define SOF_PROBE_INVALID_NODE_ID UINT_MAX
+
+struct sof_probe_point_desc {
+       unsigned int buffer_id;
+       unsigned int purpose;
+       unsigned int stream_tag;
+} __packed;
+
+int sof_ipc_probe_points_info(struct snd_sof_dev *sdev,
+                             struct sof_probe_point_desc **desc,
+                             size_t *num_desc);
+int sof_ipc_probe_points_add(struct snd_sof_dev *sdev,
+                            struct sof_probe_point_desc *desc,
+                            size_t num_desc);
+int sof_ipc_probe_points_remove(struct snd_sof_dev *sdev,
+                               unsigned int *buffer_id, size_t num_buffer_id);
+
+extern struct snd_soc_cdai_ops sof_probe_compr_ops;
+extern const struct snd_compress_ops sof_probe_compressed_ops;
+
+#endif
diff --git a/sound/soc/sof/stream-ipc.c b/sound/soc/sof/stream-ipc.c
new file mode 100644 (file)
index 0000000..15a5585
--- /dev/null
@@ -0,0 +1,103 @@
+// SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
+//
+// This file is provided under a dual BSD/GPLv2 license.  When using or
+// redistributing this file, you may do so under either license.
+//
+// Copyright(c) 2019 Intel Corporation. All rights reserved.
+//
+// Authors: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
+
+/* Generic SOF IPC code */
+
+#include <linux/device.h>
+#include <linux/export.h>
+#include <linux/module.h>
+#include <linux/types.h>
+
+#include <sound/pcm.h>
+#include <sound/sof/stream.h>
+
+#include "ops.h"
+#include "sof-priv.h"
+
+struct sof_stream {
+       size_t posn_offset;
+};
+
+/* Mailbox-based Generic IPC implementation */
+int sof_ipc_msg_data(struct snd_sof_dev *sdev,
+                    struct snd_pcm_substream *substream,
+                    void *p, size_t sz)
+{
+       if (!substream || !sdev->stream_box.size) {
+               snd_sof_dsp_mailbox_read(sdev, sdev->dsp_box.offset, p, sz);
+       } else {
+               struct sof_stream *stream = substream->runtime->private_data;
+
+               /* The stream might already be closed */
+               if (!stream)
+                       return -ESTRPIPE;
+
+               snd_sof_dsp_mailbox_read(sdev, stream->posn_offset, p, sz);
+       }
+
+       return 0;
+}
+EXPORT_SYMBOL(sof_ipc_msg_data);
+
+int sof_ipc_pcm_params(struct snd_sof_dev *sdev,
+                      struct snd_pcm_substream *substream,
+                      const struct sof_ipc_pcm_params_reply *reply)
+{
+       struct sof_stream *stream = substream->runtime->private_data;
+       size_t posn_offset = reply->posn_offset;
+
+       /* check if offset is overflow or it is not aligned */
+       if (posn_offset > sdev->stream_box.size ||
+           posn_offset % sizeof(struct sof_ipc_stream_posn) != 0)
+               return -EINVAL;
+
+       stream->posn_offset = sdev->stream_box.offset + posn_offset;
+
+       dev_dbg(sdev->dev, "pcm: stream dir %d, posn mailbox offset is %zu",
+               substream->stream, stream->posn_offset);
+
+       return 0;
+}
+EXPORT_SYMBOL(sof_ipc_pcm_params);
+
+int sof_stream_pcm_open(struct snd_sof_dev *sdev,
+                       struct snd_pcm_substream *substream)
+{
+       struct sof_stream *stream = kmalloc(sizeof(*stream), GFP_KERNEL);
+
+       if (!stream)
+               return -ENOMEM;
+
+       /* binding pcm substream to hda stream */
+       substream->runtime->private_data = stream;
+
+       /* align to DMA minimum transfer size */
+       snd_pcm_hw_constraint_step(substream->runtime, 0, SNDRV_PCM_HW_PARAM_PERIOD_BYTES, 4);
+
+       /* avoid circular buffer wrap in middle of period */
+       snd_pcm_hw_constraint_integer(substream->runtime,
+                                     SNDRV_PCM_HW_PARAM_PERIODS);
+
+       return 0;
+}
+EXPORT_SYMBOL(sof_stream_pcm_open);
+
+int sof_stream_pcm_close(struct snd_sof_dev *sdev,
+                        struct snd_pcm_substream *substream)
+{
+       struct sof_stream *stream = substream->runtime->private_data;
+
+       substream->runtime->private_data = NULL;
+       kfree(stream);
+
+       return 0;
+}
+EXPORT_SYMBOL(sof_stream_pcm_close);
+
+MODULE_LICENSE("Dual BSD/GPL");
index cc9585b..bb9e62b 100644 (file)
@@ -572,6 +572,12 @@ static const struct sof_topology_token sched_tokens[] = {
                offsetof(struct sof_ipc_pipe_new, time_domain), 0},
 };
 
+static const struct sof_topology_token pipeline_tokens[] = {
+       {SOF_TKN_SCHED_DYNAMIC_PIPELINE, SND_SOC_TPLG_TUPLE_TYPE_BOOL, get_token_u16,
+               offsetof(struct snd_sof_widget, dynamic_pipeline_widget), 0},
+
+};
+
 /* volume */
 static const struct sof_topology_token volume_tokens[] = {
        {SOF_TKN_VOLUME_RAMP_STEP_TYPE, SND_SOC_TPLG_TUPLE_TYPE_WORD,
@@ -1250,6 +1256,7 @@ static int sof_control_load(struct snd_soc_component *scomp, int index,
                return -ENOMEM;
 
        scontrol->scomp = scomp;
+       scontrol->access = kc->access;
 
        switch (le32_to_cpu(hdr->ops.info)) {
        case SND_SOC_TPLG_CTL_VOLSW:
@@ -1512,10 +1519,8 @@ static struct sof_ipc_comp *sof_comp_alloc(struct snd_sof_widget *swidget,
 static int sof_widget_load_dai(struct snd_soc_component *scomp, int index,
                               struct snd_sof_widget *swidget,
                               struct snd_soc_tplg_dapm_widget *tw,
-                              struct sof_ipc_comp_reply *r,
                               struct snd_sof_dai *dai)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_dai *comp_dai;
        size_t ipc_size = sizeof(*comp_dai);
@@ -1552,10 +1557,7 @@ static int sof_widget_load_dai(struct snd_soc_component *scomp, int index,
                swidget->widget->name, comp_dai->type, comp_dai->dai_index);
        sof_dbg_comp_config(scomp, &comp_dai->config);
 
-       ret = sof_ipc_tx_message(sdev->ipc, comp_dai->comp.hdr.cmd,
-                                comp_dai, ipc_size, r, sizeof(*r));
-
-       if (ret == 0 && dai) {
+       if (dai) {
                dai->scomp = scomp;
 
                /*
@@ -1577,10 +1579,8 @@ finish:
 
 static int sof_widget_load_buffer(struct snd_soc_component *scomp, int index,
                                  struct snd_sof_widget *swidget,
-                                 struct snd_soc_tplg_dapm_widget *tw,
-                                 struct sof_ipc_comp_reply *r)
+                                 struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_buffer *buffer;
        int ret;
@@ -1612,15 +1612,7 @@ static int sof_widget_load_buffer(struct snd_soc_component *scomp, int index,
 
        swidget->private = buffer;
 
-       ret = sof_ipc_tx_message(sdev->ipc, buffer->comp.hdr.cmd, buffer,
-                                sizeof(*buffer), r, sizeof(*r));
-       if (ret < 0) {
-               dev_err(scomp->dev, "error: buffer %s load failed\n",
-                       swidget->widget->name);
-               kfree(buffer);
-       }
-
-       return ret;
+       return 0;
 }
 
 /* bind PCM ID to host component ID */
@@ -1649,10 +1641,8 @@ static int spcm_bind(struct snd_soc_component *scomp, struct snd_sof_pcm *spcm,
 static int sof_widget_load_pcm(struct snd_soc_component *scomp, int index,
                               struct snd_sof_widget *swidget,
                               enum sof_ipc_stream_direction dir,
-                              struct snd_soc_tplg_dapm_widget *tw,
-                              struct sof_ipc_comp_reply *r)
+                              struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_host *host;
        size_t ipc_size = sizeof(*host);
@@ -1691,10 +1681,7 @@ static int sof_widget_load_pcm(struct snd_soc_component *scomp, int index,
 
        swidget->private = host;
 
-       ret = sof_ipc_tx_message(sdev->ipc, host->comp.hdr.cmd, host,
-                                ipc_size, r, sizeof(*r));
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(host);
        return ret;
@@ -1703,11 +1690,10 @@ err:
 /*
  * Pipeline Topology
  */
-int sof_load_pipeline_ipc(struct device *dev,
+int sof_load_pipeline_ipc(struct snd_sof_dev *sdev,
                          struct sof_ipc_pipe_new *pipeline,
                          struct sof_ipc_comp_reply *r)
 {
-       struct snd_sof_dev *sdev = dev_get_drvdata(dev);
        int ret = sof_core_enable(sdev, pipeline->core);
 
        if (ret < 0)
@@ -1716,15 +1702,14 @@ int sof_load_pipeline_ipc(struct device *dev,
        ret = sof_ipc_tx_message(sdev->ipc, pipeline->hdr.cmd, pipeline,
                                 sizeof(*pipeline), r, sizeof(*r));
        if (ret < 0)
-               dev_err(dev, "error: load pipeline ipc failure\n");
+               dev_err(sdev->dev, "error: load pipeline ipc failure\n");
 
        return ret;
 }
 
 static int sof_widget_load_pipeline(struct snd_soc_component *scomp, int index,
                                    struct snd_sof_widget *swidget,
-                                   struct snd_soc_tplg_dapm_widget *tw,
-                                   struct sof_ipc_comp_reply *r)
+                                   struct snd_soc_tplg_dapm_widget *tw)
 {
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_pipe_new *pipeline;
@@ -1764,16 +1749,30 @@ static int sof_widget_load_pipeline(struct snd_soc_component *scomp, int index,
                goto err;
        }
 
-       dev_dbg(scomp->dev, "pipeline %s: period %d pri %d mips %d core %d frames %d\n",
+       ret = sof_parse_tokens(scomp, swidget, pipeline_tokens,
+                              ARRAY_SIZE(pipeline_tokens), private->array,
+                              le32_to_cpu(private->size));
+       if (ret != 0) {
+               dev_err(scomp->dev, "error: parse dynamic pipeline token failed %d\n",
+                       private->size);
+               goto err;
+       }
+
+       if (sof_core_debug & SOF_DBG_DISABLE_MULTICORE)
+               pipeline->core = SOF_DSP_PRIMARY_CORE;
+
+       if (sof_core_debug & SOF_DBG_DYNAMIC_PIPELINES_OVERRIDE)
+               swidget->dynamic_pipeline_widget = sof_core_debug &
+                       SOF_DBG_DYNAMIC_PIPELINES_ENABLE;
+
+       dev_dbg(scomp->dev, "pipeline %s: period %d pri %d mips %d core %d frames %d dynamic %d\n",
                swidget->widget->name, pipeline->period, pipeline->priority,
-               pipeline->period_mips, pipeline->core, pipeline->frames_per_sched);
+               pipeline->period_mips, pipeline->core, pipeline->frames_per_sched,
+               swidget->dynamic_pipeline_widget);
 
        swidget->private = pipeline;
 
-       /* send ipc's to create pipeline comp and power up schedule core */
-       ret = sof_load_pipeline_ipc(scomp->dev, pipeline, r);
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(pipeline);
        return ret;
@@ -1785,10 +1784,8 @@ err:
 
 static int sof_widget_load_mixer(struct snd_soc_component *scomp, int index,
                                 struct snd_sof_widget *swidget,
-                                struct snd_soc_tplg_dapm_widget *tw,
-                                struct sof_ipc_comp_reply *r)
+                                struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_mixer *mixer;
        size_t ipc_size = sizeof(*mixer);
@@ -1817,12 +1814,7 @@ static int sof_widget_load_mixer(struct snd_soc_component *scomp, int index,
 
        swidget->private = mixer;
 
-       ret = sof_ipc_tx_message(sdev->ipc, mixer->comp.hdr.cmd, mixer,
-                                ipc_size, r, sizeof(*r));
-       if (ret < 0)
-               kfree(mixer);
-
-       return ret;
+       return 0;
 }
 
 /*
@@ -1830,10 +1822,8 @@ static int sof_widget_load_mixer(struct snd_soc_component *scomp, int index,
  */
 static int sof_widget_load_mux(struct snd_soc_component *scomp, int index,
                               struct snd_sof_widget *swidget,
-                              struct snd_soc_tplg_dapm_widget *tw,
-                              struct sof_ipc_comp_reply *r)
+                              struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_mux *mux;
        size_t ipc_size = sizeof(*mux);
@@ -1862,12 +1852,7 @@ static int sof_widget_load_mux(struct snd_soc_component *scomp, int index,
 
        swidget->private = mux;
 
-       ret = sof_ipc_tx_message(sdev->ipc, mux->comp.hdr.cmd, mux,
-                                ipc_size, r, sizeof(*r));
-       if (ret < 0)
-               kfree(mux);
-
-       return ret;
+       return 0;
 }
 
 /*
@@ -1876,8 +1861,7 @@ static int sof_widget_load_mux(struct snd_soc_component *scomp, int index,
 
 static int sof_widget_load_pga(struct snd_soc_component *scomp, int index,
                               struct snd_sof_widget *swidget,
-                              struct snd_soc_tplg_dapm_widget *tw,
-                              struct sof_ipc_comp_reply *r)
+                              struct snd_soc_tplg_dapm_widget *tw)
 {
        struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
@@ -1937,10 +1921,7 @@ static int sof_widget_load_pga(struct snd_soc_component *scomp, int index,
                }
        }
 
-       ret = sof_ipc_tx_message(sdev->ipc, volume->comp.hdr.cmd, volume,
-                                ipc_size, r, sizeof(*r));
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(volume);
        return ret;
@@ -1952,10 +1933,8 @@ err:
 
 static int sof_widget_load_src(struct snd_soc_component *scomp, int index,
                               struct snd_sof_widget *swidget,
-                              struct snd_soc_tplg_dapm_widget *tw,
-                              struct sof_ipc_comp_reply *r)
+                              struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_src *src;
        size_t ipc_size = sizeof(*src);
@@ -1994,10 +1973,7 @@ static int sof_widget_load_src(struct snd_soc_component *scomp, int index,
 
        swidget->private = src;
 
-       ret = sof_ipc_tx_message(sdev->ipc, src->comp.hdr.cmd, src,
-                                ipc_size, r, sizeof(*r));
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(src);
        return ret;
@@ -2009,10 +1985,8 @@ err:
 
 static int sof_widget_load_asrc(struct snd_soc_component *scomp, int index,
                                struct snd_sof_widget *swidget,
-                               struct snd_soc_tplg_dapm_widget *tw,
-                               struct sof_ipc_comp_reply *r)
+                               struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_asrc *asrc;
        size_t ipc_size = sizeof(*asrc);
@@ -2053,10 +2027,7 @@ static int sof_widget_load_asrc(struct snd_soc_component *scomp, int index,
 
        swidget->private = asrc;
 
-       ret = sof_ipc_tx_message(sdev->ipc, asrc->comp.hdr.cmd, asrc,
-                                ipc_size, r, sizeof(*r));
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(asrc);
        return ret;
@@ -2068,10 +2039,8 @@ err:
 
 static int sof_widget_load_siggen(struct snd_soc_component *scomp, int index,
                                  struct snd_sof_widget *swidget,
-                                 struct snd_soc_tplg_dapm_widget *tw,
-                                 struct sof_ipc_comp_reply *r)
+                                 struct snd_soc_tplg_dapm_widget *tw)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_tone *tone;
        size_t ipc_size = sizeof(*tone);
@@ -2110,10 +2079,7 @@ static int sof_widget_load_siggen(struct snd_soc_component *scomp, int index,
 
        swidget->private = tone;
 
-       ret = sof_ipc_tx_message(sdev->ipc, tone->comp.hdr.cmd, tone,
-                                ipc_size, r, sizeof(*r));
-       if (ret >= 0)
-               return ret;
+       return 0;
 err:
        kfree(tone);
        return ret;
@@ -2195,10 +2161,8 @@ static int sof_get_control_data(struct snd_soc_component *scomp,
 static int sof_process_load(struct snd_soc_component *scomp, int index,
                            struct snd_sof_widget *swidget,
                            struct snd_soc_tplg_dapm_widget *tw,
-                           struct sof_ipc_comp_reply *r,
                            int type)
 {
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_soc_dapm_widget *widget = swidget->widget;
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_process *process;
@@ -2272,33 +2236,6 @@ static int sof_process_load(struct snd_soc_component *scomp, int index,
 
        process->size = ipc_data_size;
        swidget->private = process;
-
-       ret = sof_ipc_tx_message(sdev->ipc, process->comp.hdr.cmd, process,
-                                ipc_size, r, sizeof(*r));
-
-       if (ret < 0) {
-               dev_err(scomp->dev, "error: create process failed\n");
-               goto err;
-       }
-
-       /* we sent the data in single message so return */
-       if (ipc_data_size)
-               goto out;
-
-       /* send control data with large message supported method */
-       for (i = 0; i < widget->num_kcontrols; i++) {
-               wdata[i].control->readback_offset = 0;
-               ret = snd_sof_ipc_set_get_comp_data(wdata[i].control,
-                                                   wdata[i].ipc_cmd,
-                                                   wdata[i].ctrl_type,
-                                                   wdata[i].control->cmd,
-                                                   true);
-               if (ret != 0) {
-                       dev_err(scomp->dev, "error: send control failed\n");
-                       break;
-               }
-       }
-
 err:
        if (ret < 0)
                kfree(process);
@@ -2314,8 +2251,7 @@ out:
 
 static int sof_widget_load_process(struct snd_soc_component *scomp, int index,
                                   struct snd_sof_widget *swidget,
-                                  struct snd_soc_tplg_dapm_widget *tw,
-                                  struct sof_ipc_comp_reply *r)
+                                  struct snd_soc_tplg_dapm_widget *tw)
 {
        struct snd_soc_tplg_private *private = &tw->priv;
        struct sof_ipc_comp_process config;
@@ -2341,8 +2277,7 @@ static int sof_widget_load_process(struct snd_soc_component *scomp, int index,
        }
 
        /* now load process specific data and send IPC */
-       ret = sof_process_load(scomp, index, swidget, tw, r,
-                              find_process_comp_type(config.type));
+       ret = sof_process_load(scomp, index, swidget, tw, find_process_comp_type(config.type));
        if (ret < 0) {
                dev_err(scomp->dev, "error: process loading failed\n");
                return ret;
@@ -2391,8 +2326,6 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
        struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
        struct snd_sof_widget *swidget;
        struct snd_sof_dai *dai;
-       struct sof_ipc_comp_reply reply;
-       struct snd_sof_control *scontrol;
        struct sof_ipc_comp comp = {
                .core = SOF_DSP_PRIMARY_CORE,
        };
@@ -2409,7 +2342,6 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
        swidget->id = w->id;
        swidget->pipeline_id = index;
        swidget->private = NULL;
-       memset(&reply, 0, sizeof(reply));
 
        dev_dbg(scomp->dev, "tplg: ready widget id %d pipe %d type %d name : %s stream %s\n",
                swidget->comp_id, index, swidget->id, tw->name,
@@ -2426,15 +2358,10 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
                return ret;
        }
 
-       swidget->core = comp.core;
+       if (sof_core_debug & SOF_DBG_DISABLE_MULTICORE)
+               comp.core = SOF_DSP_PRIMARY_CORE;
 
-       /* default is primary core, safe to call for already enabled cores */
-       ret = sof_core_enable(sdev, comp.core);
-       if (ret < 0) {
-               dev_err(scomp->dev, "error: enable core: %d\n", ret);
-               kfree(swidget);
-               return ret;
-       }
+       swidget->core = comp.core;
 
        ret = sof_parse_tokens(scomp, &swidget->comp_ext, comp_ext_tokens,
                               ARRAY_SIZE(comp_ext_tokens), tw->priv.array,
@@ -2456,57 +2383,51 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
                        return -ENOMEM;
                }
 
-               ret = sof_widget_load_dai(scomp, index, swidget, tw, &reply, dai);
-               if (ret == 0) {
-                       sof_connect_dai_widget(scomp, w, tw, dai);
-                       list_add(&dai->list, &sdev->dai_list);
-                       swidget->private = dai;
-               } else {
+               ret = sof_widget_load_dai(scomp, index, swidget, tw, dai);
+               if (!ret)
+                       ret = sof_connect_dai_widget(scomp, w, tw, dai);
+               if (ret < 0) {
                        kfree(dai);
+                       break;
                }
+               list_add(&dai->list, &sdev->dai_list);
+               swidget->private = dai;
                break;
        case snd_soc_dapm_mixer:
-               ret = sof_widget_load_mixer(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_mixer(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_pga:
-               ret = sof_widget_load_pga(scomp, index, swidget, tw, &reply);
-               /* Find scontrol for this pga and set readback offset*/
-               list_for_each_entry(scontrol, &sdev->kcontrol_list, list) {
-                       if (scontrol->comp_id == swidget->comp_id) {
-                               scontrol->readback_offset = reply.offset;
-                               break;
-                       }
-               }
+               ret = sof_widget_load_pga(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_buffer:
-               ret = sof_widget_load_buffer(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_buffer(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_scheduler:
-               ret = sof_widget_load_pipeline(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_pipeline(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_aif_out:
                ret = sof_widget_load_pcm(scomp, index, swidget,
-                                         SOF_IPC_STREAM_CAPTURE, tw, &reply);
+                                         SOF_IPC_STREAM_CAPTURE, tw);
                break;
        case snd_soc_dapm_aif_in:
                ret = sof_widget_load_pcm(scomp, index, swidget,
-                                         SOF_IPC_STREAM_PLAYBACK, tw, &reply);
+                                         SOF_IPC_STREAM_PLAYBACK, tw);
                break;
        case snd_soc_dapm_src:
-               ret = sof_widget_load_src(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_src(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_asrc:
-               ret = sof_widget_load_asrc(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_asrc(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_siggen:
-               ret = sof_widget_load_siggen(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_siggen(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_effect:
-               ret = sof_widget_load_process(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_process(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_mux:
        case snd_soc_dapm_demux:
-               ret = sof_widget_load_mux(scomp, index, swidget, tw, &reply);
+               ret = sof_widget_load_mux(scomp, index, swidget, tw);
                break;
        case snd_soc_dapm_switch:
        case snd_soc_dapm_dai_link:
@@ -2517,12 +2438,12 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
        }
 
        /* check IPC reply */
-       if (ret < 0 || reply.rhdr.error < 0) {
+       if (ret < 0) {
                dev_err(scomp->dev,
-                       "error: DSP failed to add widget id %d type %d name : %s stream %s reply %d\n",
+                       "error: failed to add widget id %d type %d name : %s stream %s\n",
                        tw->shift, swidget->id, tw->name,
                        strnlen(tw->sname, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) > 0
-                               ? tw->sname : "none", reply.rhdr.error);
+                               ? tw->sname : "none");
                kfree(swidget);
                return ret;
        }
@@ -2598,6 +2519,15 @@ static int sof_widget_unload(struct snd_soc_component *scomp,
 
                /* power down the pipeline schedule core */
                pipeline = swidget->private;
+
+               /*
+                * Runtime PM should still function normally if topology loading fails and
+                * it's components are unloaded. Do not power down the primary core so that the
+                * CTX_SAVE IPC can succeed during runtime suspend.
+                */
+               if (pipeline->core == SOF_DSP_PRIMARY_CORE)
+                       break;
+
                ret = snd_sof_dsp_core_power_down(sdev, 1 << pipeline->core);
                if (ret < 0)
                        dev_err(scomp->dev, "error: powering down pipeline schedule core %d\n",
@@ -2671,8 +2601,10 @@ static int sof_dai_load(struct snd_soc_component *scomp, int index,
 
        for_each_pcm_streams(stream) {
                spcm->stream[stream].comp_id = COMP_ID_UNASSIGNED;
-               INIT_WORK(&spcm->stream[stream].period_elapsed_work,
-                         snd_sof_pcm_period_elapsed_work);
+               if (pcm->compress)
+                       snd_sof_compr_init_elapsed_work(&spcm->stream[stream].period_elapsed_work);
+               else
+                       snd_sof_pcm_init_elapsed_work(&spcm->stream[stream].period_elapsed_work);
        }
 
        spcm->pcm = *pcm;
@@ -2828,9 +2760,6 @@ static int sof_set_dai_config_multi(struct snd_sof_dev *sdev, u32 size,
                        continue;
 
                if (strcmp(link->name, dai->name) == 0) {
-                       struct sof_ipc_reply reply;
-                       int ret;
-
                        /*
                         * the same dai config will be applied to all DAIs in
                         * the same dai link. We have to ensure that the ipc
@@ -2842,18 +2771,6 @@ static int sof_set_dai_config_multi(struct snd_sof_dev *sdev, u32 size,
 
                        dev_dbg(sdev->dev, "set DAI config for %s index %d\n",
                                dai->name, config[curr_conf].dai_index);
-                       /* send message to DSP */
-                       ret = sof_ipc_tx_message(sdev->ipc,
-                                                config[curr_conf].hdr.cmd,
-                                                &config[curr_conf], size,
-                                                &reply, sizeof(reply));
-
-                       if (ret < 0) {
-                               dev_err(sdev->dev,
-                                       "error: failed to set DAI config for %s index %d\n",
-                                       dai->name, config[curr_conf].dai_index);
-                               return ret;
-                       }
 
                        dai->number_configs = num_conf;
                        dai->current_config = curr_conf;
@@ -2861,9 +2778,6 @@ static int sof_set_dai_config_multi(struct snd_sof_dev *sdev, u32 size,
                        if (!dai->dai_config)
                                return -ENOMEM;
 
-                       /* set cpu_dai_name */
-                       dai->cpu_dai_name = link->cpus->dai_name;
-
                        found = 1;
                }
        }
@@ -2933,12 +2847,12 @@ static int sof_link_ssp_load(struct snd_soc_component *scomp, int index,
                config[i].ssp.rx_slots = le32_to_cpu(hw_config[i].rx_slots);
                config[i].ssp.tx_slots = le32_to_cpu(hw_config[i].tx_slots);
 
-               dev_dbg(scomp->dev, "tplg: config SSP%d fmt 0x%x mclk %d bclk %d fclk %d width (%d)%d slots %d mclk id %d quirks %d\n",
+               dev_dbg(scomp->dev, "tplg: config SSP%d fmt %#x mclk %d bclk %d fclk %d width (%d)%d slots %d mclk id %d quirks %d clks_control %#x\n",
                        config[i].dai_index, config[i].format,
                        config[i].ssp.mclk_rate, config[i].ssp.bclk_rate,
                        config[i].ssp.fsync_rate, config[i].ssp.sample_valid_bits,
                        config[i].ssp.tdm_slot_width, config[i].ssp.tdm_slots,
-                       config[i].ssp.mclk_id, config[i].ssp.quirks);
+                       config[i].ssp.mclk_id, config[i].ssp.quirks, config[i].ssp.clks_control);
 
                /* validate SSP fsync rate and channel count */
                if (config[i].ssp.fsync_rate < 8000 || config[i].ssp.fsync_rate > 192000) {
@@ -3383,7 +3297,6 @@ static int sof_route_load(struct snd_soc_component *scomp, int index,
        struct snd_sof_widget *source_swidget, *sink_swidget;
        struct snd_soc_dobj *dobj = &route->dobj;
        struct snd_sof_route *sroute;
-       struct sof_ipc_reply reply;
        int ret = 0;
 
        /* allocate memory for sroute and connect */
@@ -3458,33 +3371,11 @@ static int sof_route_load(struct snd_soc_component *scomp, int index,
                        route->source, route->sink);
                goto err;
        } else {
-               ret = sof_ipc_tx_message(sdev->ipc,
-                                        connect->hdr.cmd,
-                                        connect, sizeof(*connect),
-                                        &reply, sizeof(reply));
-
-               /* check IPC return value */
-               if (ret < 0) {
-                       dev_err(scomp->dev, "error: failed to add route sink %s control %s source %s\n",
-                               route->sink,
-                               route->control ? route->control : "none",
-                               route->source);
-                       goto err;
-               }
-
-               /* check IPC reply */
-               if (reply.error < 0) {
-                       dev_err(scomp->dev, "error: DSP failed to add route sink %s control %s source %s result %d\n",
-                               route->sink,
-                               route->control ? route->control : "none",
-                               route->source, reply.error);
-                       ret = reply.error;
-                       goto err;
-               }
-
                sroute->route = route;
                dobj->private = sroute;
                sroute->private = connect;
+               sroute->src_widget = source_swidget;
+               sroute->sink_widget = sink_swidget;
 
                /* add route to route list */
                list_add(&sroute->list, &sdev->route_list);
@@ -3498,59 +3389,14 @@ err:
        return ret;
 }
 
-/* Function to set the initial value of SOF kcontrols.
- * The value will be stored in scontrol->control_data
- */
-static int snd_sof_cache_kcontrol_val(struct snd_soc_component *scomp)
-{
-       struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
-       struct snd_sof_control *scontrol = NULL;
-       int ipc_cmd, ctrl_type;
-       int ret = 0;
-
-       list_for_each_entry(scontrol, &sdev->kcontrol_list, list) {
-
-               /* notify DSP of kcontrol values */
-               switch (scontrol->cmd) {
-               case SOF_CTRL_CMD_VOLUME:
-               case SOF_CTRL_CMD_ENUM:
-               case SOF_CTRL_CMD_SWITCH:
-                       ipc_cmd = SOF_IPC_COMP_GET_VALUE;
-                       ctrl_type = SOF_CTRL_TYPE_VALUE_CHAN_GET;
-                       break;
-               case SOF_CTRL_CMD_BINARY:
-                       ipc_cmd = SOF_IPC_COMP_GET_DATA;
-                       ctrl_type = SOF_CTRL_TYPE_DATA_GET;
-                       break;
-               default:
-                       dev_err(scomp->dev,
-                               "error: Invalid scontrol->cmd: %d\n",
-                               scontrol->cmd);
-                       return -EINVAL;
-               }
-               ret = snd_sof_ipc_set_get_comp_data(scontrol,
-                                                   ipc_cmd, ctrl_type,
-                                                   scontrol->cmd,
-                                                   false);
-               if (ret < 0) {
-                       dev_warn(scomp->dev,
-                                "error: kcontrol value get for widget: %d\n",
-                                scontrol->comp_id);
-               }
-       }
-
-       return ret;
-}
-
-int snd_sof_complete_pipeline(struct device *dev,
+int snd_sof_complete_pipeline(struct snd_sof_dev *sdev,
                              struct snd_sof_widget *swidget)
 {
-       struct snd_sof_dev *sdev = dev_get_drvdata(dev);
        struct sof_ipc_pipe_ready ready;
        struct sof_ipc_reply reply;
        int ret;
 
-       dev_dbg(dev, "tplg: complete pipeline %s id %d\n",
+       dev_dbg(sdev->dev, "tplg: complete pipeline %s id %d\n",
                swidget->widget->name, swidget->comp_id);
 
        memset(&ready, 0, sizeof(ready));
@@ -3566,31 +3412,84 @@ int snd_sof_complete_pipeline(struct device *dev,
        return 1;
 }
 
+/**
+ * sof_set_pipe_widget - Set pipe_widget for a component
+ * @sdev: pointer to struct snd_sof_dev
+ * @pipe_widget: pointer to struct snd_sof_widget of type snd_soc_dapm_scheduler
+ * @swidget: pointer to struct snd_sof_widget that has the same pipeline ID as @pipe_widget
+ *
+ * Return: 0 if successful, -EINVAL on error.
+ * The function checks if @swidget is associated with any volatile controls. If so, setting
+ * the dynamic_pipeline_widget is disallowed.
+ */
+static int sof_set_pipe_widget(struct snd_sof_dev *sdev, struct snd_sof_widget *pipe_widget,
+                              struct snd_sof_widget *swidget)
+{
+       struct snd_sof_control *scontrol;
+
+       if (pipe_widget->dynamic_pipeline_widget) {
+               /* dynamic widgets cannot have volatile kcontrols */
+               list_for_each_entry(scontrol, &sdev->kcontrol_list, list)
+                       if (scontrol->comp_id == swidget->comp_id &&
+                           (scontrol->access & SNDRV_CTL_ELEM_ACCESS_VOLATILE)) {
+                               dev_err(sdev->dev,
+                                       "error: volatile control found for dynamic widget %s\n",
+                                       swidget->widget->name);
+                               return -EINVAL;
+                       }
+       }
+
+       /* set the pipe_widget and apply the dynamic_pipeline_widget_flag */
+       swidget->pipe_widget = pipe_widget;
+       swidget->dynamic_pipeline_widget = pipe_widget->dynamic_pipeline_widget;
+
+       return 0;
+}
+
 /* completion - called at completion of firmware loading */
-static void sof_complete(struct snd_soc_component *scomp)
+static int sof_complete(struct snd_soc_component *scomp)
 {
        struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp);
-       struct snd_sof_widget *swidget;
+       struct snd_sof_widget *swidget, *comp_swidget;
+       int ret;
 
-       /* some widget types require completion notificattion */
+       /* set the pipe_widget and apply the dynamic_pipeline_widget_flag */
        list_for_each_entry(swidget, &sdev->widget_list, list) {
-               if (swidget->complete)
-                       continue;
-
                switch (swidget->id) {
                case snd_soc_dapm_scheduler:
-                       swidget->complete =
-                               snd_sof_complete_pipeline(scomp->dev, swidget);
+                       /*
+                        * Apply the dynamic_pipeline_widget flag and set the pipe_widget field
+                        * for all widgets that have the same pipeline ID as the scheduler widget
+                        */
+                       list_for_each_entry_reverse(comp_swidget, &sdev->widget_list, list)
+                               if (comp_swidget->pipeline_id == swidget->pipeline_id) {
+                                       ret = sof_set_pipe_widget(sdev, swidget, comp_swidget);
+                                       if (ret < 0)
+                                               return ret;
+                               }
                        break;
                default:
                        break;
                }
        }
-       /*
-        * cache initial values of SOF kcontrols by reading DSP value over
-        * IPC. It may be overwritten by alsa-mixer after booting up
-        */
-       snd_sof_cache_kcontrol_val(scomp);
+
+       /* verify topology components loading including dynamic pipelines */
+       if (sof_core_debug & SOF_DBG_VERIFY_TPLG) {
+               ret = sof_set_up_pipelines(sdev, true);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: topology verification failed %d\n", ret);
+                       return ret;
+               }
+
+               ret = sof_tear_down_pipelines(sdev, true);
+               if (ret < 0) {
+                       dev_err(sdev->dev, "error: topology tear down pipelines failed %d\n", ret);
+                       return ret;
+               }
+       }
+
+       /* set up static pipelines */
+       return sof_set_up_pipelines(sdev, false);
 }
 
 /* manifest - optional to inform component of manifest */
index 58f6ca5..e3afc3d 100644 (file)
@@ -417,7 +417,7 @@ int snd_sof_init_trace_ipc(struct snd_sof_dev *sdev)
                        "error: fail in snd_sof_dma_trace_init %d\n", ret);
                return ret;
        }
-       dev_dbg(sdev->dev, "stream_tag: %d\n", params.stream_tag);
+       dev_dbg(sdev->dev, "%s: stream_tag: %d\n", __func__, params.stream_tag);
 
        /* send IPC to the DSP */
        ret = sof_ipc_tx_message(sdev->ipc,
@@ -480,7 +480,8 @@ int snd_sof_init_trace(struct snd_sof_dev *sdev)
                goto table_err;
 
        sdev->dma_trace_pages = ret;
-       dev_dbg(sdev->dev, "dma_trace_pages: %d\n", sdev->dma_trace_pages);
+       dev_dbg(sdev->dev, "%s: dma_trace_pages: %d\n",
+               __func__, sdev->dma_trace_pages);
 
        if (sdev->first_boot) {
                ret = trace_debugfs_create(sdev);
index 5539d3a..66fa660 100644 (file)
@@ -14,6 +14,7 @@
 #include <sound/soc.h>
 #include <sound/sof.h>
 #include "sof-priv.h"
+#include "ops.h"
 
 /*
  * Register IO
@@ -72,15 +73,21 @@ EXPORT_SYMBOL(sof_mailbox_read);
  * Memory copy.
  */
 
-void sof_block_write(struct snd_sof_dev *sdev, u32 bar, u32 offset, void *src,
-                    size_t size)
+int sof_block_write(struct snd_sof_dev *sdev, enum snd_sof_fw_blk_type blk_type,
+                   u32 offset, void *src, size_t size)
 {
-       void __iomem *dest = sdev->bar[bar] + offset;
+       int bar = snd_sof_dsp_get_bar_index(sdev, blk_type);
        const u8 *src_byte = src;
+       void __iomem *dest;
        u32 affected_mask;
        u32 tmp;
        int m, n;
 
+       if (bar < 0)
+               return bar;
+
+       dest = sdev->bar[bar] + offset;
+
        m = size / 4;
        n = size % 4;
 
@@ -100,15 +107,22 @@ void sof_block_write(struct snd_sof_dev *sdev, u32 bar, u32 offset, void *src,
                tmp |= *(u32 *)(src_byte + m * 4) & affected_mask;
                iowrite32(tmp, dest + m * 4);
        }
+
+       return 0;
 }
 EXPORT_SYMBOL(sof_block_write);
 
-void sof_block_read(struct snd_sof_dev *sdev, u32 bar, u32 offset, void *dest,
-                   size_t size)
+int sof_block_read(struct snd_sof_dev *sdev, enum snd_sof_fw_blk_type blk_type,
+                  u32 offset, void *dest, size_t size)
 {
-       void __iomem *src = sdev->bar[bar] + offset;
+       int bar = snd_sof_dsp_get_bar_index(sdev, blk_type);
+
+       if (bar < 0)
+               return bar;
+
+       memcpy_fromio(dest, sdev->bar[bar] + offset, size);
 
-       memcpy_fromio(dest, src, size);
+       return 0;
 }
 EXPORT_SYMBOL(sof_block_read);
 
index f6e3411..bd09c38 100644 (file)
@@ -128,7 +128,7 @@ static void xtensa_stack(struct snd_sof_dev *sdev, void *oops, u32 *stack,
        }
 }
 
-const struct sof_arch_ops sof_xtensa_arch_ops = {
+const struct dsp_arch_ops sof_xtensa_arch_ops = {
        .dsp_oops = xtensa_dsp_oops,
        .dsp_stack = xtensa_stack,
 };
index 83c87f3..cd45487 100644 (file)
@@ -108,6 +108,54 @@ config SND_SOC_TEGRA210_ADMAIF
          channel. Buffer size is configurable for each ADMAIIF channel.
          Say Y or M if you want to add support for Tegra210 ADMAIF module.
 
+config SND_SOC_TEGRA210_MVC
+       tristate "Tegra210 MVC module"
+       help
+         Config to enable the digital Master Volume Controller (MVC) which
+         provides gain or attenuation to a digital signal path. It can be
+         used in input or output signal path. It can be used either for
+         per-stream volume control or for master volume control.
+         Say Y or M if you want to add support for Tegra210 MVC module.
+
+config SND_SOC_TEGRA210_SFC
+       tristate "Tegra210 SFC module"
+       help
+         Config to enable the Sampling Frequency Converter (SFC) which
+         converts the sampling frequency of input signal to another
+         frequency. It supports sampling frequency conversion of streams
+         upto 2 channels (stereo).
+         Say Y or M if you want to add support for Tegra210 SFC module.
+
+config SND_SOC_TEGRA210_AMX
+       tristate "Tegra210 AMX module"
+       help
+         Config to enable the Audio Multiplexer (AMX) which can multiplex
+         four input streams (each of up to 16 channels) and generate
+         output stream (of up to 16 channels). A byte RAM helps to form an
+         output frame by any combination of bytes from the input frames.
+         Say Y or M if you want to add support for Tegra210 AMX module.
+
+config SND_SOC_TEGRA210_ADX
+       tristate "Tegra210 ADX module"
+       help
+         Config to enable the Audio Demultiplexer (ADX) which takes an
+         input stream (up to 16 channels) and demultiplexes it into four
+         output streams (each of up to 16 channels). A byte RAM helps to
+         form output frames by any combination of bytes from the input
+         frame. Its design is identical to that of byte RAM in the AMX
+         except that the data flow direction is reversed.
+         Say Y or M if you want to add support for Tegra210 ADX module.
+
+config SND_SOC_TEGRA210_MIXER
+       tristate "Tegra210 Mixer module"
+       help
+         Config to enable the Mixer module which can help to mix multiple
+         audio streams. It supports mixing of upto 10 input streams,
+         where each stream can contain maximum of 8 channels. It supports
+         5 output each of which can be a mix of any combination of 10
+         input streams.
+         Say Y or M if you want to add support for Tegra210 Mixer module.
+
 config SND_SOC_TEGRA_AUDIO_GRAPH_CARD
        tristate "Audio Graph Card based Tegra driver"
        depends on SND_AUDIO_GRAPH_CARD
index e2cec9a..f19d566 100644 (file)
@@ -13,6 +13,11 @@ snd-soc-tegra210-dmic-objs := tegra210_dmic.o
 snd-soc-tegra210-i2s-objs := tegra210_i2s.o
 snd-soc-tegra186-dspk-objs := tegra186_dspk.o
 snd-soc-tegra210-admaif-objs := tegra210_admaif.o
+snd-soc-tegra210-mvc-objs := tegra210_mvc.o
+snd-soc-tegra210-sfc-objs := tegra210_sfc.o
+snd-soc-tegra210-amx-objs := tegra210_amx.o
+snd-soc-tegra210-adx-objs := tegra210_adx.o
+snd-soc-tegra210-mixer-objs := tegra210_mixer.o
 
 obj-$(CONFIG_SND_SOC_TEGRA) += snd-soc-tegra-pcm.o
 obj-$(CONFIG_SND_SOC_TEGRA20_AC97) += snd-soc-tegra20-ac97.o
@@ -26,6 +31,11 @@ obj-$(CONFIG_SND_SOC_TEGRA210_AHUB) += snd-soc-tegra210-ahub.o
 obj-$(CONFIG_SND_SOC_TEGRA210_I2S) += snd-soc-tegra210-i2s.o
 obj-$(CONFIG_SND_SOC_TEGRA186_DSPK) += snd-soc-tegra186-dspk.o
 obj-$(CONFIG_SND_SOC_TEGRA210_ADMAIF) += snd-soc-tegra210-admaif.o
+obj-$(CONFIG_SND_SOC_TEGRA210_MVC) += snd-soc-tegra210-mvc.o
+obj-$(CONFIG_SND_SOC_TEGRA210_SFC) += snd-soc-tegra210-sfc.o
+obj-$(CONFIG_SND_SOC_TEGRA210_AMX) += snd-soc-tegra210-amx.o
+obj-$(CONFIG_SND_SOC_TEGRA210_ADX) += snd-soc-tegra210-adx.o
+obj-$(CONFIG_SND_SOC_TEGRA210_MIXER) += snd-soc-tegra210-mixer.o
 
 # Tegra machine Support
 snd-soc-tegra-wm8903-objs := tegra_wm8903.o
diff --git a/sound/soc/tegra/tegra210_adx.c b/sound/soc/tegra/tegra210_adx.c
new file mode 100644 (file)
index 0000000..d7c7849
--- /dev/null
@@ -0,0 +1,531 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// tegra210_adx.c - Tegra210 ADX driver
+//
+// Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include "tegra210_adx.h"
+#include "tegra_cif.h"
+
+static const struct reg_default tegra210_adx_reg_defaults[] = {
+       { TEGRA210_ADX_RX_INT_MASK, 0x00000001},
+       { TEGRA210_ADX_RX_CIF_CTRL, 0x00007000},
+       { TEGRA210_ADX_TX_INT_MASK, 0x0000000f },
+       { TEGRA210_ADX_TX1_CIF_CTRL, 0x00007000},
+       { TEGRA210_ADX_TX2_CIF_CTRL, 0x00007000},
+       { TEGRA210_ADX_TX3_CIF_CTRL, 0x00007000},
+       { TEGRA210_ADX_TX4_CIF_CTRL, 0x00007000},
+       { TEGRA210_ADX_CG, 0x1},
+       { TEGRA210_ADX_CFG_RAM_CTRL, 0x00004000},
+};
+
+static void tegra210_adx_write_map_ram(struct tegra210_adx *adx)
+{
+       int i;
+
+       regmap_write(adx->regmap, TEGRA210_ADX_CFG_RAM_CTRL,
+                    TEGRA210_ADX_CFG_RAM_CTRL_SEQ_ACCESS_EN |
+                    TEGRA210_ADX_CFG_RAM_CTRL_ADDR_INIT_EN |
+                    TEGRA210_ADX_CFG_RAM_CTRL_RW_WRITE);
+
+       for (i = 0; i < TEGRA210_ADX_RAM_DEPTH; i++)
+               regmap_write(adx->regmap, TEGRA210_ADX_CFG_RAM_DATA,
+                            adx->map[i]);
+
+       regmap_write(adx->regmap, TEGRA210_ADX_IN_BYTE_EN0, adx->byte_mask[0]);
+       regmap_write(adx->regmap, TEGRA210_ADX_IN_BYTE_EN1, adx->byte_mask[1]);
+}
+
+static int tegra210_adx_startup(struct snd_pcm_substream *substream,
+                               struct snd_soc_dai *dai)
+{
+       struct tegra210_adx *adx = snd_soc_dai_get_drvdata(dai);
+       unsigned int val;
+       int err;
+
+       /* Ensure if ADX status is disabled */
+       err = regmap_read_poll_timeout_atomic(adx->regmap, TEGRA210_ADX_STATUS,
+                                             val, !(val & 0x1), 10, 10000);
+       if (err < 0) {
+               dev_err(dai->dev, "failed to stop ADX, err = %d\n", err);
+               return err;
+       }
+
+       /*
+        * Soft Reset: Below performs module soft reset which clears
+        * all FSM logic, flushes flow control of FIFO and resets the
+        * state register. It also brings module back to disabled
+        * state (without flushing the data in the pipe).
+        */
+       regmap_update_bits(adx->regmap, TEGRA210_ADX_SOFT_RESET,
+                          TEGRA210_ADX_SOFT_RESET_SOFT_RESET_MASK,
+                          TEGRA210_ADX_SOFT_RESET_SOFT_EN);
+
+       err = regmap_read_poll_timeout(adx->regmap, TEGRA210_ADX_SOFT_RESET,
+                                      val, !(val & 0x1), 10, 10000);
+       if (err < 0) {
+               dev_err(dai->dev, "failed to reset ADX, err = %d\n", err);
+               return err;
+       }
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_adx_runtime_suspend(struct device *dev)
+{
+       struct tegra210_adx *adx = dev_get_drvdata(dev);
+
+       regcache_cache_only(adx->regmap, true);
+       regcache_mark_dirty(adx->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_adx_runtime_resume(struct device *dev)
+{
+       struct tegra210_adx *adx = dev_get_drvdata(dev);
+
+       regcache_cache_only(adx->regmap, false);
+       regcache_sync(adx->regmap);
+
+       tegra210_adx_write_map_ram(adx);
+
+       return 0;
+}
+
+static int tegra210_adx_set_audio_cif(struct snd_soc_dai *dai,
+                                     unsigned int channels,
+                                     unsigned int format,
+                                     unsigned int reg)
+{
+       struct tegra210_adx *adx = snd_soc_dai_get_drvdata(dai);
+       struct tegra_cif_conf cif_conf;
+       int audio_bits;
+
+       memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
+
+       if (channels < 1 || channels > 16)
+               return -EINVAL;
+
+       switch (format) {
+       case SNDRV_PCM_FORMAT_S8:
+               audio_bits = TEGRA_ACIF_BITS_8;
+               break;
+       case SNDRV_PCM_FORMAT_S16_LE:
+               audio_bits = TEGRA_ACIF_BITS_16;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               audio_bits = TEGRA_ACIF_BITS_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       cif_conf.audio_ch = channels;
+       cif_conf.client_ch = channels;
+       cif_conf.audio_bits = audio_bits;
+       cif_conf.client_bits = audio_bits;
+
+       tegra_set_cif(adx->regmap, reg, &cif_conf);
+
+       return 0;
+}
+
+static int tegra210_adx_out_hw_params(struct snd_pcm_substream *substream,
+                                     struct snd_pcm_hw_params *params,
+                                     struct snd_soc_dai *dai)
+{
+       return tegra210_adx_set_audio_cif(dai, params_channels(params),
+                       params_format(params),
+                       TEGRA210_ADX_TX1_CIF_CTRL + ((dai->id - 1) * TEGRA210_ADX_AUDIOCIF_CH_STRIDE));
+}
+
+static int tegra210_adx_in_hw_params(struct snd_pcm_substream *substream,
+                                    struct snd_pcm_hw_params *params,
+                                    struct snd_soc_dai *dai)
+{
+       return tegra210_adx_set_audio_cif(dai, params_channels(params),
+                                         params_format(params),
+                                         TEGRA210_ADX_RX_CIF_CTRL);
+}
+
+static int tegra210_adx_get_byte_map(struct snd_kcontrol *kcontrol,
+                                    struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_adx *adx = snd_soc_component_get_drvdata(cmpnt);
+       struct soc_mixer_control *mc;
+       unsigned char *bytes_map = (unsigned char *)&adx->map;
+       int enabled;
+
+       mc = (struct soc_mixer_control *)kcontrol->private_value;
+       enabled = adx->byte_mask[mc->reg / 32] & (1 << (mc->reg % 32));
+
+       if (enabled)
+               ucontrol->value.integer.value[0] = bytes_map[mc->reg];
+       else
+               ucontrol->value.integer.value[0] = 0;
+
+       return 0;
+}
+
+static int tegra210_adx_put_byte_map(struct snd_kcontrol *kcontrol,
+                                    struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_adx *adx = snd_soc_component_get_drvdata(cmpnt);
+       unsigned char *bytes_map = (unsigned char *)&adx->map;
+       int value = ucontrol->value.integer.value[0];
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;;
+
+       if (value >= 0 && value <= 255) {
+               /* update byte map and enable slot */
+               bytes_map[mc->reg] = value;
+               adx->byte_mask[mc->reg / 32] |= (1 << (mc->reg % 32));
+       } else {
+               /* reset byte map and disable slot */
+               bytes_map[mc->reg] = 0;
+               adx->byte_mask[mc->reg / 32] &= ~(1 << (mc->reg % 32));
+       }
+
+       return 1;
+}
+
+static const struct snd_soc_dai_ops tegra210_adx_in_dai_ops = {
+       .hw_params      = tegra210_adx_in_hw_params,
+       .startup        = tegra210_adx_startup,
+};
+
+static const struct snd_soc_dai_ops tegra210_adx_out_dai_ops = {
+       .hw_params      = tegra210_adx_out_hw_params,
+};
+
+#define IN_DAI                                                 \
+       {                                                       \
+               .name = "ADX-RX-CIF",                           \
+               .playback = {                                   \
+                       .stream_name = "RX-CIF-Playback",       \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "RX-CIF-Capture",        \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .ops = &tegra210_adx_in_dai_ops,                \
+       }
+
+#define OUT_DAI(id)                                            \
+       {                                                       \
+               .name = "ADX-TX" #id "-CIF",                    \
+               .playback = {                                   \
+                       .stream_name = "TX" #id "-CIF-Playback",\
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "TX" #id "-CIF-Capture", \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .ops = &tegra210_adx_out_dai_ops,               \
+       }
+
+static struct snd_soc_dai_driver tegra210_adx_dais[] = {
+       IN_DAI,
+       OUT_DAI(1),
+       OUT_DAI(2),
+       OUT_DAI(3),
+       OUT_DAI(4),
+};
+
+static const struct snd_soc_dapm_widget tegra210_adx_widgets[] = {
+       SND_SOC_DAPM_AIF_IN("RX", NULL, 0, TEGRA210_ADX_ENABLE,
+                           TEGRA210_ADX_ENABLE_SHIFT, 0),
+       SND_SOC_DAPM_AIF_OUT("TX1", NULL, 0, TEGRA210_ADX_CTRL, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX2", NULL, 0, TEGRA210_ADX_CTRL, 1, 0),
+       SND_SOC_DAPM_AIF_OUT("TX3", NULL, 0, TEGRA210_ADX_CTRL, 2, 0),
+       SND_SOC_DAPM_AIF_OUT("TX4", NULL, 0, TEGRA210_ADX_CTRL, 3, 0),
+};
+
+#define STREAM_ROUTES(id, sname)                                         \
+       { "XBAR-" sname,                NULL,   "XBAR-TX" },              \
+       { "RX-CIF-" sname,              NULL,   "XBAR-" sname },          \
+       { "RX",                         NULL,   "RX-CIF-" sname },        \
+       { "TX" #id,                     NULL,   "RX" },                   \
+       { "TX" #id "-CIF-" sname,       NULL,   "TX" #id },               \
+       { "TX" #id " XBAR-" sname,      NULL,   "TX" #id "-CIF-" sname }, \
+       { "TX" #id " XBAR-RX",          NULL,   "TX" #id " XBAR-" sname }
+
+#define ADX_ROUTES(id)                 \
+       STREAM_ROUTES(id, "Playback"),  \
+       STREAM_ROUTES(id, "Capture")
+
+#define STREAM_ROUTES(id, sname)                                         \
+       { "XBAR-" sname,                NULL,   "XBAR-TX" },              \
+       { "RX-CIF-" sname,              NULL,   "XBAR-" sname },          \
+       { "RX",                         NULL,   "RX-CIF-" sname },        \
+       { "TX" #id,                     NULL,   "RX" },                   \
+       { "TX" #id "-CIF-" sname,       NULL,   "TX" #id },               \
+       { "TX" #id " XBAR-" sname,      NULL,   "TX" #id "-CIF-" sname }, \
+       { "TX" #id " XBAR-RX",          NULL,   "TX" #id " XBAR-" sname }
+
+#define ADX_ROUTES(id)                 \
+       STREAM_ROUTES(id, "Playback"),  \
+       STREAM_ROUTES(id, "Capture")
+
+static const struct snd_soc_dapm_route tegra210_adx_routes[] = {
+       ADX_ROUTES(1),
+       ADX_ROUTES(2),
+       ADX_ROUTES(3),
+       ADX_ROUTES(4),
+};
+
+#define TEGRA210_ADX_BYTE_MAP_CTRL(reg)                         \
+       SOC_SINGLE_EXT("Byte Map " #reg, reg, 0, 256, 0, \
+                      tegra210_adx_get_byte_map,        \
+                      tegra210_adx_put_byte_map)
+
+static struct snd_kcontrol_new tegra210_adx_controls[] = {
+       TEGRA210_ADX_BYTE_MAP_CTRL(0),
+       TEGRA210_ADX_BYTE_MAP_CTRL(1),
+       TEGRA210_ADX_BYTE_MAP_CTRL(2),
+       TEGRA210_ADX_BYTE_MAP_CTRL(3),
+       TEGRA210_ADX_BYTE_MAP_CTRL(4),
+       TEGRA210_ADX_BYTE_MAP_CTRL(5),
+       TEGRA210_ADX_BYTE_MAP_CTRL(6),
+       TEGRA210_ADX_BYTE_MAP_CTRL(7),
+       TEGRA210_ADX_BYTE_MAP_CTRL(8),
+       TEGRA210_ADX_BYTE_MAP_CTRL(9),
+       TEGRA210_ADX_BYTE_MAP_CTRL(10),
+       TEGRA210_ADX_BYTE_MAP_CTRL(11),
+       TEGRA210_ADX_BYTE_MAP_CTRL(12),
+       TEGRA210_ADX_BYTE_MAP_CTRL(13),
+       TEGRA210_ADX_BYTE_MAP_CTRL(14),
+       TEGRA210_ADX_BYTE_MAP_CTRL(15),
+       TEGRA210_ADX_BYTE_MAP_CTRL(16),
+       TEGRA210_ADX_BYTE_MAP_CTRL(17),
+       TEGRA210_ADX_BYTE_MAP_CTRL(18),
+       TEGRA210_ADX_BYTE_MAP_CTRL(19),
+       TEGRA210_ADX_BYTE_MAP_CTRL(20),
+       TEGRA210_ADX_BYTE_MAP_CTRL(21),
+       TEGRA210_ADX_BYTE_MAP_CTRL(22),
+       TEGRA210_ADX_BYTE_MAP_CTRL(23),
+       TEGRA210_ADX_BYTE_MAP_CTRL(24),
+       TEGRA210_ADX_BYTE_MAP_CTRL(25),
+       TEGRA210_ADX_BYTE_MAP_CTRL(26),
+       TEGRA210_ADX_BYTE_MAP_CTRL(27),
+       TEGRA210_ADX_BYTE_MAP_CTRL(28),
+       TEGRA210_ADX_BYTE_MAP_CTRL(29),
+       TEGRA210_ADX_BYTE_MAP_CTRL(30),
+       TEGRA210_ADX_BYTE_MAP_CTRL(31),
+       TEGRA210_ADX_BYTE_MAP_CTRL(32),
+       TEGRA210_ADX_BYTE_MAP_CTRL(33),
+       TEGRA210_ADX_BYTE_MAP_CTRL(34),
+       TEGRA210_ADX_BYTE_MAP_CTRL(35),
+       TEGRA210_ADX_BYTE_MAP_CTRL(36),
+       TEGRA210_ADX_BYTE_MAP_CTRL(37),
+       TEGRA210_ADX_BYTE_MAP_CTRL(38),
+       TEGRA210_ADX_BYTE_MAP_CTRL(39),
+       TEGRA210_ADX_BYTE_MAP_CTRL(40),
+       TEGRA210_ADX_BYTE_MAP_CTRL(41),
+       TEGRA210_ADX_BYTE_MAP_CTRL(42),
+       TEGRA210_ADX_BYTE_MAP_CTRL(43),
+       TEGRA210_ADX_BYTE_MAP_CTRL(44),
+       TEGRA210_ADX_BYTE_MAP_CTRL(45),
+       TEGRA210_ADX_BYTE_MAP_CTRL(46),
+       TEGRA210_ADX_BYTE_MAP_CTRL(47),
+       TEGRA210_ADX_BYTE_MAP_CTRL(48),
+       TEGRA210_ADX_BYTE_MAP_CTRL(49),
+       TEGRA210_ADX_BYTE_MAP_CTRL(50),
+       TEGRA210_ADX_BYTE_MAP_CTRL(51),
+       TEGRA210_ADX_BYTE_MAP_CTRL(52),
+       TEGRA210_ADX_BYTE_MAP_CTRL(53),
+       TEGRA210_ADX_BYTE_MAP_CTRL(54),
+       TEGRA210_ADX_BYTE_MAP_CTRL(55),
+       TEGRA210_ADX_BYTE_MAP_CTRL(56),
+       TEGRA210_ADX_BYTE_MAP_CTRL(57),
+       TEGRA210_ADX_BYTE_MAP_CTRL(58),
+       TEGRA210_ADX_BYTE_MAP_CTRL(59),
+       TEGRA210_ADX_BYTE_MAP_CTRL(60),
+       TEGRA210_ADX_BYTE_MAP_CTRL(61),
+       TEGRA210_ADX_BYTE_MAP_CTRL(62),
+       TEGRA210_ADX_BYTE_MAP_CTRL(63),
+};
+
+static const struct snd_soc_component_driver tegra210_adx_cmpnt = {
+       .dapm_widgets           = tegra210_adx_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(tegra210_adx_widgets),
+       .dapm_routes            = tegra210_adx_routes,
+       .num_dapm_routes        = ARRAY_SIZE(tegra210_adx_routes),
+       .controls               = tegra210_adx_controls,
+       .num_controls           = ARRAY_SIZE(tegra210_adx_controls),
+};
+
+static bool tegra210_adx_wr_reg(struct device *dev,
+                               unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_ADX_TX_INT_MASK ... TEGRA210_ADX_TX4_CIF_CTRL:
+       case TEGRA210_ADX_RX_INT_MASK ... TEGRA210_ADX_RX_CIF_CTRL:
+       case TEGRA210_ADX_ENABLE ... TEGRA210_ADX_CG:
+       case TEGRA210_ADX_CTRL ... TEGRA210_ADX_IN_BYTE_EN1:
+       case TEGRA210_ADX_CFG_RAM_CTRL ... TEGRA210_ADX_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_adx_rd_reg(struct device *dev,
+                               unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_ADX_RX_STATUS ... TEGRA210_ADX_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_adx_volatile_reg(struct device *dev,
+                               unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_ADX_RX_STATUS:
+       case TEGRA210_ADX_RX_INT_STATUS:
+       case TEGRA210_ADX_RX_INT_SET:
+       case TEGRA210_ADX_TX_STATUS:
+       case TEGRA210_ADX_TX_INT_STATUS:
+       case TEGRA210_ADX_TX_INT_SET:
+       case TEGRA210_ADX_SOFT_RESET:
+       case TEGRA210_ADX_STATUS:
+       case TEGRA210_ADX_INT_STATUS:
+       case TEGRA210_ADX_CFG_RAM_CTRL:
+       case TEGRA210_ADX_CFG_RAM_DATA:
+               return true;
+       default:
+               break;
+       }
+
+       return false;
+}
+
+static const struct regmap_config tegra210_adx_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA210_ADX_CFG_RAM_DATA,
+       .writeable_reg          = tegra210_adx_wr_reg,
+       .readable_reg           = tegra210_adx_rd_reg,
+       .volatile_reg           = tegra210_adx_volatile_reg,
+       .reg_defaults           = tegra210_adx_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_adx_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct of_device_id tegra210_adx_of_match[] = {
+       { .compatible = "nvidia,tegra210-adx" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tegra210_adx_of_match);
+
+static int tegra210_adx_platform_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tegra210_adx *adx;
+       void __iomem *regs;
+       int err;
+
+       adx = devm_kzalloc(dev, sizeof(*adx), GFP_KERNEL);
+       if (!adx)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, adx);
+
+       regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(regs))
+               return PTR_ERR(regs);
+
+       adx->regmap = devm_regmap_init_mmio(dev, regs,
+                                           &tegra210_adx_regmap_config);
+       if (IS_ERR(adx->regmap)) {
+               dev_err(dev, "regmap init failed\n");
+               return PTR_ERR(adx->regmap);
+       }
+
+       regcache_cache_only(adx->regmap, true);
+
+       err = devm_snd_soc_register_component(dev, &tegra210_adx_cmpnt,
+                                             tegra210_adx_dais,
+                                             ARRAY_SIZE(tegra210_adx_dais));
+       if (err) {
+               dev_err(dev, "can't register ADX component, err: %d\n", err);
+               return err;
+       }
+
+       pm_runtime_enable(dev);
+
+       return 0;
+}
+
+static int tegra210_adx_platform_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static const struct dev_pm_ops tegra210_adx_pm_ops = {
+       SET_RUNTIME_PM_OPS(tegra210_adx_runtime_suspend,
+                          tegra210_adx_runtime_resume, NULL)
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                    pm_runtime_force_resume)
+};
+
+static struct platform_driver tegra210_adx_driver = {
+       .driver = {
+               .name = "tegra210-adx",
+               .of_match_table = tegra210_adx_of_match,
+               .pm = &tegra210_adx_pm_ops,
+       },
+       .probe = tegra210_adx_platform_probe,
+       .remove = tegra210_adx_platform_remove,
+};
+module_platform_driver(tegra210_adx_driver);
+
+MODULE_AUTHOR("Arun Shamanna Lakshmi <aruns@nvidia.com>");
+MODULE_DESCRIPTION("Tegra210 ADX ASoC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/tegra/tegra210_adx.h b/sound/soc/tegra/tegra210_adx.h
new file mode 100644 (file)
index 0000000..d7dcb64
--- /dev/null
@@ -0,0 +1,72 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * tegra210_adx.h - Definitions for Tegra210 ADX driver
+ *
+ * Copyright (c) 2021, NVIDIA CORPORATION.  All rights reserved.
+ *
+ */
+
+#ifndef __TEGRA210_ADX_H__
+#define __TEGRA210_ADX_H__
+
+/* Register offsets from TEGRA210_ADX*_BASE */
+#define TEGRA210_ADX_RX_STATUS         0x0c
+#define TEGRA210_ADX_RX_INT_STATUS     0x10
+#define TEGRA210_ADX_RX_INT_MASK       0x14
+#define TEGRA210_ADX_RX_INT_SET                0x18
+#define TEGRA210_ADX_RX_INT_CLEAR      0x1c
+#define TEGRA210_ADX_RX_CIF_CTRL       0x20
+#define TEGRA210_ADX_TX_STATUS         0x4c
+#define TEGRA210_ADX_TX_INT_STATUS     0x50
+#define TEGRA210_ADX_TX_INT_MASK       0x54
+#define TEGRA210_ADX_TX_INT_SET                0x58
+#define TEGRA210_ADX_TX_INT_CLEAR      0x5c
+#define TEGRA210_ADX_TX1_CIF_CTRL      0x60
+#define TEGRA210_ADX_TX2_CIF_CTRL      0x64
+#define TEGRA210_ADX_TX3_CIF_CTRL      0x68
+#define TEGRA210_ADX_TX4_CIF_CTRL      0x6c
+#define TEGRA210_ADX_ENABLE            0x80
+#define TEGRA210_ADX_SOFT_RESET                0x84
+#define TEGRA210_ADX_CG                        0x88
+#define TEGRA210_ADX_STATUS            0x8c
+#define TEGRA210_ADX_INT_STATUS                0x90
+#define TEGRA210_ADX_CTRL              0xa4
+#define TEGRA210_ADX_IN_BYTE_EN0       0xa8
+#define TEGRA210_ADX_IN_BYTE_EN1       0xac
+#define TEGRA210_ADX_CFG_RAM_CTRL      0xb8
+#define TEGRA210_ADX_CFG_RAM_DATA      0xbc
+
+/* Fields in TEGRA210_ADX_ENABLE */
+#define TEGRA210_ADX_ENABLE_SHIFT                      0
+
+/* Fields in TEGRA210_ADX_CFG_RAM_CTRL */
+#define TEGRA210_ADX_CFG_RAM_CTRL_RAM_ADDR_SHIFT       0
+
+#define TEGRA210_ADX_CFG_RAM_CTRL_RW_SHIFT             14
+#define TEGRA210_ADX_CFG_RAM_CTRL_RW_WRITE             (1 << TEGRA210_ADX_CFG_RAM_CTRL_RW_SHIFT)
+
+#define TEGRA210_ADX_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT   13
+#define TEGRA210_ADX_CFG_RAM_CTRL_ADDR_INIT_EN         (1 << TEGRA210_ADX_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT)
+
+#define TEGRA210_ADX_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT  12
+#define TEGRA210_ADX_CFG_RAM_CTRL_SEQ_ACCESS_EN                (1 << TEGRA210_ADX_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT)
+
+/* Fields in TEGRA210_ADX_SOFT_RESET */
+#define TEGRA210_ADX_SOFT_RESET_SOFT_RESET_SHIFT       0
+#define TEGRA210_ADX_SOFT_RESET_SOFT_RESET_MASK                (1 << TEGRA210_ADX_SOFT_RESET_SOFT_RESET_SHIFT)
+#define TEGRA210_ADX_SOFT_RESET_SOFT_EN                        (1 << TEGRA210_ADX_SOFT_RESET_SOFT_RESET_SHIFT)
+#define TEGRA210_ADX_SOFT_RESET_SOFT_DEFAULT           (0 << TEGRA210_ADX_SOFT_RESET_SOFT_RESET_SHIFT)
+
+#define TEGRA210_ADX_AUDIOCIF_CH_STRIDE                4
+#define TEGRA210_ADX_RAM_DEPTH                 16
+#define TEGRA210_ADX_MAP_STREAM_NUMBER_SHIFT   6
+#define TEGRA210_ADX_MAP_WORD_NUMBER_SHIFT     2
+#define TEGRA210_ADX_MAP_BYTE_NUMBER_SHIFT     0
+
+struct tegra210_adx {
+       struct regmap *regmap;
+       unsigned int map[TEGRA210_ADX_RAM_DEPTH];
+       unsigned int byte_mask[2];
+};
+
+#endif
index 66287a7..a1989ea 100644 (file)
@@ -105,14 +105,68 @@ static struct snd_soc_dai_driver tegra210_ahub_dais[] = {
        DAI(ADMAIF8),
        DAI(ADMAIF9),
        DAI(ADMAIF10),
+       /* XBAR <-> I2S <-> Codec */
        DAI(I2S1),
        DAI(I2S2),
        DAI(I2S3),
        DAI(I2S4),
        DAI(I2S5),
+       /* XBAR <- DMIC <- Codec */
        DAI(DMIC1),
        DAI(DMIC2),
        DAI(DMIC3),
+       /* XBAR -> SFC -> XBAR */
+       DAI(SFC1 RX),
+       DAI(SFC1 TX),
+       DAI(SFC2 RX),
+       DAI(SFC2 TX),
+       DAI(SFC3 RX),
+       DAI(SFC3 TX),
+       DAI(SFC4 RX),
+       DAI(SFC4 TX),
+       /* XBAR -> MVC -> XBAR */
+       DAI(MVC1 RX),
+       DAI(MVC1 TX),
+       DAI(MVC2 RX),
+       DAI(MVC2 TX),
+       /* XBAR -> AMX(4:1) -> XBAR */
+       DAI(AMX1 RX1),
+       DAI(AMX1 RX2),
+       DAI(AMX1 RX3),
+       DAI(AMX1 RX4),
+       DAI(AMX1),
+       DAI(AMX2 RX1),
+       DAI(AMX2 RX2),
+       DAI(AMX2 RX3),
+       DAI(AMX2 RX4),
+       DAI(AMX2),
+       /* XBAR -> ADX(1:4) -> XBAR */
+       DAI(ADX1),
+       DAI(ADX1 TX1),
+       DAI(ADX1 TX2),
+       DAI(ADX1 TX3),
+       DAI(ADX1 TX4),
+       DAI(ADX2),
+       DAI(ADX2 TX1),
+       DAI(ADX2 TX2),
+       DAI(ADX2 TX3),
+       DAI(ADX2 TX4),
+       /* XBAR -> MIXER(10:5) -> XBAR */
+       DAI(MIXER1 RX1),
+       DAI(MIXER1 RX2),
+       DAI(MIXER1 RX3),
+       DAI(MIXER1 RX4),
+       DAI(MIXER1 RX5),
+       DAI(MIXER1 RX6),
+       DAI(MIXER1 RX7),
+       DAI(MIXER1 RX8),
+       DAI(MIXER1 RX9),
+       DAI(MIXER1 RX10),
+       DAI(MIXER1 TX1),
+       DAI(MIXER1 TX2),
+       DAI(MIXER1 TX3),
+       DAI(MIXER1 TX4),
+       DAI(MIXER1 TX5),
 };
 
 static struct snd_soc_dai_driver tegra186_ahub_dais[] = {
@@ -136,18 +190,93 @@ static struct snd_soc_dai_driver tegra186_ahub_dais[] = {
        DAI(ADMAIF18),
        DAI(ADMAIF19),
        DAI(ADMAIF20),
+       /* XBAR <-> I2S <-> Codec */
        DAI(I2S1),
        DAI(I2S2),
        DAI(I2S3),
        DAI(I2S4),
        DAI(I2S5),
        DAI(I2S6),
+       /* XBAR <- DMIC <- Codec */
        DAI(DMIC1),
        DAI(DMIC2),
        DAI(DMIC3),
        DAI(DMIC4),
+       /* XBAR -> DSPK -> Codec */
        DAI(DSPK1),
        DAI(DSPK2),
+       /* XBAR -> SFC -> XBAR */
+       DAI(SFC1 RX),
+       DAI(SFC1 TX),
+       DAI(SFC2 RX),
+       DAI(SFC2 TX),
+       DAI(SFC3 RX),
+       DAI(SFC3 TX),
+       DAI(SFC4 RX),
+       DAI(SFC4 TX),
+       /* XBAR -> MVC -> XBAR */
+       DAI(MVC1 RX),
+       DAI(MVC1 TX),
+       DAI(MVC2 RX),
+       DAI(MVC2 TX),
+       /* XBAR -> AMX(4:1) -> XBAR */
+       DAI(AMX1 RX1),
+       DAI(AMX1 RX2),
+       DAI(AMX1 RX3),
+       DAI(AMX1 RX4),
+       DAI(AMX1),
+       DAI(AMX2 RX1),
+       DAI(AMX2 RX2),
+       DAI(AMX2 RX3),
+       DAI(AMX2 RX4),
+       DAI(AMX2),
+       DAI(AMX3 RX1),
+       DAI(AMX3 RX2),
+       DAI(AMX3 RX3),
+       DAI(AMX3 RX4),
+       DAI(AMX3),
+       DAI(AMX4 RX1),
+       DAI(AMX4 RX2),
+       DAI(AMX4 RX3),
+       DAI(AMX4 RX4),
+       DAI(AMX4),
+       /* XBAR -> ADX(1:4) -> XBAR */
+       DAI(ADX1),
+       DAI(ADX1 TX1),
+       DAI(ADX1 TX2),
+       DAI(ADX1 TX3),
+       DAI(ADX1 TX4),
+       DAI(ADX2),
+       DAI(ADX2 TX1),
+       DAI(ADX2 TX2),
+       DAI(ADX2 TX3),
+       DAI(ADX2 TX4),
+       DAI(ADX3),
+       DAI(ADX3 TX1),
+       DAI(ADX3 TX2),
+       DAI(ADX3 TX3),
+       DAI(ADX3 TX4),
+       DAI(ADX4),
+       DAI(ADX4 TX1),
+       DAI(ADX4 TX2),
+       DAI(ADX4 TX3),
+       DAI(ADX4 TX4),
+       /* XBAR -> MIXER1(10:5) -> XBAR */
+       DAI(MIXER1 RX1),
+       DAI(MIXER1 RX2),
+       DAI(MIXER1 RX3),
+       DAI(MIXER1 RX4),
+       DAI(MIXER1 RX5),
+       DAI(MIXER1 RX6),
+       DAI(MIXER1 RX7),
+       DAI(MIXER1 RX8),
+       DAI(MIXER1 RX9),
+       DAI(MIXER1 RX10),
+       DAI(MIXER1 TX1),
+       DAI(MIXER1 TX2),
+       DAI(MIXER1 TX3),
+       DAI(MIXER1 TX4),
+       DAI(MIXER1 TX5),
 };
 
 static const char * const tegra210_ahub_mux_texts[] = {
@@ -170,6 +299,27 @@ static const char * const tegra210_ahub_mux_texts[] = {
        "DMIC1",
        "DMIC2",
        "DMIC3",
+       "SFC1",
+       "SFC2",
+       "SFC3",
+       "SFC4",
+       "MVC1",
+       "MVC2",
+       "AMX1",
+       "AMX2",
+       "ADX1 TX1",
+       "ADX1 TX2",
+       "ADX1 TX3",
+       "ADX1 TX4",
+       "ADX2 TX1",
+       "ADX2 TX2",
+       "ADX2 TX3",
+       "ADX2 TX4",
+       "MIXER1 TX1",
+       "MIXER1 TX2",
+       "MIXER1 TX3",
+       "MIXER1 TX4",
+       "MIXER1 TX5",
 };
 
 static const char * const tegra186_ahub_mux_texts[] = {
@@ -204,10 +354,42 @@ static const char * const tegra186_ahub_mux_texts[] = {
        "DMIC2",
        "DMIC3",
        "DMIC4",
+       "SFC1",
+       "SFC2",
+       "SFC3",
+       "SFC4",
+       "MVC1",
+       "MVC2",
+       "AMX1",
+       "AMX2",
+       "AMX3",
+       "AMX4",
+       "ADX1 TX1",
+       "ADX1 TX2",
+       "ADX1 TX3",
+       "ADX1 TX4",
+       "ADX2 TX1",
+       "ADX2 TX2",
+       "ADX2 TX3",
+       "ADX2 TX4",
+       "ADX3 TX1",
+       "ADX3 TX2",
+       "ADX3 TX3",
+       "ADX3 TX4",
+       "ADX4 TX1",
+       "ADX4 TX2",
+       "ADX4 TX3",
+       "ADX4 TX4",
+       "MIXER1 TX1",
+       "MIXER1 TX2",
+       "MIXER1 TX3",
+       "MIXER1 TX4",
+       "MIXER1 TX5",
 };
 
 static const unsigned int tegra210_ahub_mux_values[] = {
        0,
+       /* ADMAIF */
        MUX_VALUE(0, 0),
        MUX_VALUE(0, 1),
        MUX_VALUE(0, 2),
@@ -218,18 +400,47 @@ static const unsigned int tegra210_ahub_mux_values[] = {
        MUX_VALUE(0, 7),
        MUX_VALUE(0, 8),
        MUX_VALUE(0, 9),
+       /* I2S */
        MUX_VALUE(0, 16),
        MUX_VALUE(0, 17),
        MUX_VALUE(0, 18),
        MUX_VALUE(0, 19),
        MUX_VALUE(0, 20),
+       /* DMIC */
        MUX_VALUE(2, 18),
        MUX_VALUE(2, 19),
        MUX_VALUE(2, 20),
+       /* SFC */
+       MUX_VALUE(0, 24),
+       MUX_VALUE(0, 25),
+       MUX_VALUE(0, 26),
+       MUX_VALUE(0, 27),
+       /* MVC */
+       MUX_VALUE(2, 8),
+       MUX_VALUE(2, 9),
+       /* AMX */
+       MUX_VALUE(1, 8),
+       MUX_VALUE(1, 9),
+       /* ADX */
+       MUX_VALUE(2, 24),
+       MUX_VALUE(2, 25),
+       MUX_VALUE(2, 26),
+       MUX_VALUE(2, 27),
+       MUX_VALUE(2, 28),
+       MUX_VALUE(2, 29),
+       MUX_VALUE(2, 30),
+       MUX_VALUE(2, 31),
+       /* MIXER */
+       MUX_VALUE(1, 0),
+       MUX_VALUE(1, 1),
+       MUX_VALUE(1, 2),
+       MUX_VALUE(1, 3),
+       MUX_VALUE(1, 4),
 };
 
 static const unsigned int tegra186_ahub_mux_values[] = {
        0,
+       /* ADMAIF */
        MUX_VALUE(0, 0),
        MUX_VALUE(0, 1),
        MUX_VALUE(0, 2),
@@ -246,20 +457,59 @@ static const unsigned int tegra186_ahub_mux_values[] = {
        MUX_VALUE(0, 13),
        MUX_VALUE(0, 14),
        MUX_VALUE(0, 15),
+       /* I2S */
        MUX_VALUE(0, 16),
        MUX_VALUE(0, 17),
        MUX_VALUE(0, 18),
        MUX_VALUE(0, 19),
        MUX_VALUE(0, 20),
        MUX_VALUE(0, 21),
+       /* ADMAIF */
        MUX_VALUE(3, 16),
        MUX_VALUE(3, 17),
        MUX_VALUE(3, 18),
        MUX_VALUE(3, 19),
+       /* DMIC */
        MUX_VALUE(2, 18),
        MUX_VALUE(2, 19),
        MUX_VALUE(2, 20),
        MUX_VALUE(2, 21),
+       /* SFC */
+       MUX_VALUE(0, 24),
+       MUX_VALUE(0, 25),
+       MUX_VALUE(0, 26),
+       MUX_VALUE(0, 27),
+       /* MVC */
+       MUX_VALUE(2, 8),
+       MUX_VALUE(2, 9),
+       /* AMX */
+       MUX_VALUE(1, 8),
+       MUX_VALUE(1, 9),
+       MUX_VALUE(1, 10),
+       MUX_VALUE(1, 11),
+       /* ADX */
+       MUX_VALUE(2, 24),
+       MUX_VALUE(2, 25),
+       MUX_VALUE(2, 26),
+       MUX_VALUE(2, 27),
+       MUX_VALUE(2, 28),
+       MUX_VALUE(2, 29),
+       MUX_VALUE(2, 30),
+       MUX_VALUE(2, 31),
+       MUX_VALUE(3, 0),
+       MUX_VALUE(3, 1),
+       MUX_VALUE(3, 2),
+       MUX_VALUE(3, 3),
+       MUX_VALUE(3, 4),
+       MUX_VALUE(3, 5),
+       MUX_VALUE(3, 6),
+       MUX_VALUE(3, 7),
+       /* MIXER */
+       MUX_VALUE(1, 0),
+       MUX_VALUE(1, 1),
+       MUX_VALUE(1, 2),
+       MUX_VALUE(1, 3),
+       MUX_VALUE(1, 4),
 };
 
 /* Controls for t210 */
@@ -278,6 +528,32 @@ MUX_ENUM_CTRL_DECL(t210_i2s2_tx, 0x11);
 MUX_ENUM_CTRL_DECL(t210_i2s3_tx, 0x12);
 MUX_ENUM_CTRL_DECL(t210_i2s4_tx, 0x13);
 MUX_ENUM_CTRL_DECL(t210_i2s5_tx, 0x14);
+MUX_ENUM_CTRL_DECL(t210_sfc1_tx, 0x18);
+MUX_ENUM_CTRL_DECL(t210_sfc2_tx, 0x19);
+MUX_ENUM_CTRL_DECL(t210_sfc3_tx, 0x1a);
+MUX_ENUM_CTRL_DECL(t210_sfc4_tx, 0x1b);
+MUX_ENUM_CTRL_DECL(t210_mvc1_tx, 0x48);
+MUX_ENUM_CTRL_DECL(t210_mvc2_tx, 0x49);
+MUX_ENUM_CTRL_DECL(t210_amx11_tx, 0x50);
+MUX_ENUM_CTRL_DECL(t210_amx12_tx, 0x51);
+MUX_ENUM_CTRL_DECL(t210_amx13_tx, 0x52);
+MUX_ENUM_CTRL_DECL(t210_amx14_tx, 0x53);
+MUX_ENUM_CTRL_DECL(t210_amx21_tx, 0x54);
+MUX_ENUM_CTRL_DECL(t210_amx22_tx, 0x55);
+MUX_ENUM_CTRL_DECL(t210_amx23_tx, 0x56);
+MUX_ENUM_CTRL_DECL(t210_amx24_tx, 0x57);
+MUX_ENUM_CTRL_DECL(t210_adx1_tx, 0x58);
+MUX_ENUM_CTRL_DECL(t210_adx2_tx, 0x59);
+MUX_ENUM_CTRL_DECL(t210_mixer11_tx, 0x20);
+MUX_ENUM_CTRL_DECL(t210_mixer12_tx, 0x21);
+MUX_ENUM_CTRL_DECL(t210_mixer13_tx, 0x22);
+MUX_ENUM_CTRL_DECL(t210_mixer14_tx, 0x23);
+MUX_ENUM_CTRL_DECL(t210_mixer15_tx, 0x24);
+MUX_ENUM_CTRL_DECL(t210_mixer16_tx, 0x25);
+MUX_ENUM_CTRL_DECL(t210_mixer17_tx, 0x26);
+MUX_ENUM_CTRL_DECL(t210_mixer18_tx, 0x27);
+MUX_ENUM_CTRL_DECL(t210_mixer19_tx, 0x28);
+MUX_ENUM_CTRL_DECL(t210_mixer110_tx, 0x29);
 
 /* Controls for t186 */
 MUX_ENUM_CTRL_DECL_186(t186_admaif1_tx, 0x00);
@@ -308,6 +584,42 @@ MUX_ENUM_CTRL_DECL_186(t186_admaif17_tx, 0x68);
 MUX_ENUM_CTRL_DECL_186(t186_admaif18_tx, 0x69);
 MUX_ENUM_CTRL_DECL_186(t186_admaif19_tx, 0x6a);
 MUX_ENUM_CTRL_DECL_186(t186_admaif20_tx, 0x6b);
+MUX_ENUM_CTRL_DECL_186(t186_sfc1_tx, 0x18);
+MUX_ENUM_CTRL_DECL_186(t186_sfc2_tx, 0x19);
+MUX_ENUM_CTRL_DECL_186(t186_sfc3_tx, 0x1a);
+MUX_ENUM_CTRL_DECL_186(t186_sfc4_tx, 0x1b);
+MUX_ENUM_CTRL_DECL_186(t186_mvc1_tx, 0x48);
+MUX_ENUM_CTRL_DECL_186(t186_mvc2_tx, 0x49);
+MUX_ENUM_CTRL_DECL_186(t186_amx11_tx, 0x50);
+MUX_ENUM_CTRL_DECL_186(t186_amx12_tx, 0x51);
+MUX_ENUM_CTRL_DECL_186(t186_amx13_tx, 0x52);
+MUX_ENUM_CTRL_DECL_186(t186_amx14_tx, 0x53);
+MUX_ENUM_CTRL_DECL_186(t186_amx21_tx, 0x54);
+MUX_ENUM_CTRL_DECL_186(t186_amx22_tx, 0x55);
+MUX_ENUM_CTRL_DECL_186(t186_amx23_tx, 0x56);
+MUX_ENUM_CTRL_DECL_186(t186_amx24_tx, 0x57);
+MUX_ENUM_CTRL_DECL_186(t186_amx31_tx, 0x58);
+MUX_ENUM_CTRL_DECL_186(t186_amx32_tx, 0x59);
+MUX_ENUM_CTRL_DECL_186(t186_amx33_tx, 0x5a);
+MUX_ENUM_CTRL_DECL_186(t186_amx34_tx, 0x5b);
+MUX_ENUM_CTRL_DECL_186(t186_amx41_tx, 0x64);
+MUX_ENUM_CTRL_DECL_186(t186_amx42_tx, 0x65);
+MUX_ENUM_CTRL_DECL_186(t186_amx43_tx, 0x66);
+MUX_ENUM_CTRL_DECL_186(t186_amx44_tx, 0x67);
+MUX_ENUM_CTRL_DECL_186(t186_adx1_tx, 0x60);
+MUX_ENUM_CTRL_DECL_186(t186_adx2_tx, 0x61);
+MUX_ENUM_CTRL_DECL_186(t186_adx3_tx, 0x62);
+MUX_ENUM_CTRL_DECL_186(t186_adx4_tx, 0x63);
+MUX_ENUM_CTRL_DECL_186(t186_mixer11_tx, 0x20);
+MUX_ENUM_CTRL_DECL_186(t186_mixer12_tx, 0x21);
+MUX_ENUM_CTRL_DECL_186(t186_mixer13_tx, 0x22);
+MUX_ENUM_CTRL_DECL_186(t186_mixer14_tx, 0x23);
+MUX_ENUM_CTRL_DECL_186(t186_mixer15_tx, 0x24);
+MUX_ENUM_CTRL_DECL_186(t186_mixer16_tx, 0x25);
+MUX_ENUM_CTRL_DECL_186(t186_mixer17_tx, 0x26);
+MUX_ENUM_CTRL_DECL_186(t186_mixer18_tx, 0x27);
+MUX_ENUM_CTRL_DECL_186(t186_mixer19_tx, 0x28);
+MUX_ENUM_CTRL_DECL_186(t186_mixer110_tx, 0x29);
 
 /*
  * The number of entries in, and order of, this array is closely tied to the
@@ -333,6 +645,47 @@ static const struct snd_soc_dapm_widget tegra210_ahub_widgets[] = {
        TX_WIDGETS("DMIC1"),
        TX_WIDGETS("DMIC2"),
        TX_WIDGETS("DMIC3"),
+       WIDGETS("SFC1", t210_sfc1_tx),
+       WIDGETS("SFC2", t210_sfc2_tx),
+       WIDGETS("SFC3", t210_sfc3_tx),
+       WIDGETS("SFC4", t210_sfc4_tx),
+       WIDGETS("MVC1", t210_mvc1_tx),
+       WIDGETS("MVC2", t210_mvc2_tx),
+       WIDGETS("AMX1 RX1", t210_amx11_tx),
+       WIDGETS("AMX1 RX2", t210_amx12_tx),
+       WIDGETS("AMX1 RX3", t210_amx13_tx),
+       WIDGETS("AMX1 RX4", t210_amx14_tx),
+       WIDGETS("AMX2 RX1", t210_amx21_tx),
+       WIDGETS("AMX2 RX2", t210_amx22_tx),
+       WIDGETS("AMX2 RX3", t210_amx23_tx),
+       WIDGETS("AMX2 RX4", t210_amx24_tx),
+       TX_WIDGETS("AMX1"),
+       TX_WIDGETS("AMX2"),
+       WIDGETS("ADX1", t210_adx1_tx),
+       WIDGETS("ADX2", t210_adx2_tx),
+       TX_WIDGETS("ADX1 TX1"),
+       TX_WIDGETS("ADX1 TX2"),
+       TX_WIDGETS("ADX1 TX3"),
+       TX_WIDGETS("ADX1 TX4"),
+       TX_WIDGETS("ADX2 TX1"),
+       TX_WIDGETS("ADX2 TX2"),
+       TX_WIDGETS("ADX2 TX3"),
+       TX_WIDGETS("ADX2 TX4"),
+       WIDGETS("MIXER1 RX1", t210_mixer11_tx),
+       WIDGETS("MIXER1 RX2", t210_mixer12_tx),
+       WIDGETS("MIXER1 RX3", t210_mixer13_tx),
+       WIDGETS("MIXER1 RX4", t210_mixer14_tx),
+       WIDGETS("MIXER1 RX5", t210_mixer15_tx),
+       WIDGETS("MIXER1 RX6", t210_mixer16_tx),
+       WIDGETS("MIXER1 RX7", t210_mixer17_tx),
+       WIDGETS("MIXER1 RX8", t210_mixer18_tx),
+       WIDGETS("MIXER1 RX9", t210_mixer19_tx),
+       WIDGETS("MIXER1 RX10", t210_mixer110_tx),
+       TX_WIDGETS("MIXER1 TX1"),
+       TX_WIDGETS("MIXER1 TX2"),
+       TX_WIDGETS("MIXER1 TX3"),
+       TX_WIDGETS("MIXER1 TX4"),
+       TX_WIDGETS("MIXER1 TX5"),
 };
 
 static const struct snd_soc_dapm_widget tegra186_ahub_widgets[] = {
@@ -368,6 +721,67 @@ static const struct snd_soc_dapm_widget tegra186_ahub_widgets[] = {
        TX_WIDGETS("DMIC4"),
        WIDGETS("DSPK1", t186_dspk1_tx),
        WIDGETS("DSPK2", t186_dspk2_tx),
+       WIDGETS("SFC1", t186_sfc1_tx),
+       WIDGETS("SFC2", t186_sfc2_tx),
+       WIDGETS("SFC3", t186_sfc3_tx),
+       WIDGETS("SFC4", t186_sfc4_tx),
+       WIDGETS("MVC1", t186_mvc1_tx),
+       WIDGETS("MVC2", t186_mvc2_tx),
+       WIDGETS("AMX1 RX1", t186_amx11_tx),
+       WIDGETS("AMX1 RX2", t186_amx12_tx),
+       WIDGETS("AMX1 RX3", t186_amx13_tx),
+       WIDGETS("AMX1 RX4", t186_amx14_tx),
+       WIDGETS("AMX2 RX1", t186_amx21_tx),
+       WIDGETS("AMX2 RX2", t186_amx22_tx),
+       WIDGETS("AMX2 RX3", t186_amx23_tx),
+       WIDGETS("AMX2 RX4", t186_amx24_tx),
+       WIDGETS("AMX3 RX1", t186_amx31_tx),
+       WIDGETS("AMX3 RX2", t186_amx32_tx),
+       WIDGETS("AMX3 RX3", t186_amx33_tx),
+       WIDGETS("AMX3 RX4", t186_amx34_tx),
+       WIDGETS("AMX4 RX1", t186_amx41_tx),
+       WIDGETS("AMX4 RX2", t186_amx42_tx),
+       WIDGETS("AMX4 RX3", t186_amx43_tx),
+       WIDGETS("AMX4 RX4", t186_amx44_tx),
+       TX_WIDGETS("AMX1"),
+       TX_WIDGETS("AMX2"),
+       TX_WIDGETS("AMX3"),
+       TX_WIDGETS("AMX4"),
+       WIDGETS("ADX1", t186_adx1_tx),
+       WIDGETS("ADX2", t186_adx2_tx),
+       WIDGETS("ADX3", t186_adx3_tx),
+       WIDGETS("ADX4", t186_adx4_tx),
+       TX_WIDGETS("ADX1 TX1"),
+       TX_WIDGETS("ADX1 TX2"),
+       TX_WIDGETS("ADX1 TX3"),
+       TX_WIDGETS("ADX1 TX4"),
+       TX_WIDGETS("ADX2 TX1"),
+       TX_WIDGETS("ADX2 TX2"),
+       TX_WIDGETS("ADX2 TX3"),
+       TX_WIDGETS("ADX2 TX4"),
+       TX_WIDGETS("ADX3 TX1"),
+       TX_WIDGETS("ADX3 TX2"),
+       TX_WIDGETS("ADX3 TX3"),
+       TX_WIDGETS("ADX3 TX4"),
+       TX_WIDGETS("ADX4 TX1"),
+       TX_WIDGETS("ADX4 TX2"),
+       TX_WIDGETS("ADX4 TX3"),
+       TX_WIDGETS("ADX4 TX4"),
+       WIDGETS("MIXER1 RX1", t186_mixer11_tx),
+       WIDGETS("MIXER1 RX2", t186_mixer12_tx),
+       WIDGETS("MIXER1 RX3", t186_mixer13_tx),
+       WIDGETS("MIXER1 RX4", t186_mixer14_tx),
+       WIDGETS("MIXER1 RX5", t186_mixer15_tx),
+       WIDGETS("MIXER1 RX6", t186_mixer16_tx),
+       WIDGETS("MIXER1 RX7", t186_mixer17_tx),
+       WIDGETS("MIXER1 RX8", t186_mixer18_tx),
+       WIDGETS("MIXER1 RX9", t186_mixer19_tx),
+       WIDGETS("MIXER1 RX10", t186_mixer110_tx),
+       TX_WIDGETS("MIXER1 TX1"),
+       TX_WIDGETS("MIXER1 TX2"),
+       TX_WIDGETS("MIXER1 TX3"),
+       TX_WIDGETS("MIXER1 TX4"),
+       TX_WIDGETS("MIXER1 TX5"),
 };
 
 #define TEGRA_COMMON_MUX_ROUTES(name)                                  \
@@ -389,7 +803,28 @@ static const struct snd_soc_dapm_widget tegra186_ahub_widgets[] = {
        { name " Mux",          "I2S5",         "I2S5 XBAR-RX" },       \
        { name " Mux",          "DMIC1",        "DMIC1 XBAR-RX" },      \
        { name " Mux",          "DMIC2",        "DMIC2 XBAR-RX" },      \
-       { name " Mux",          "DMIC3",        "DMIC3 XBAR-RX" },
+       { name " Mux",          "DMIC3",        "DMIC3 XBAR-RX" },      \
+       { name " Mux",          "SFC1",         "SFC1 XBAR-RX" },       \
+       { name " Mux",          "SFC2",         "SFC2 XBAR-RX" },       \
+       { name " Mux",          "SFC3",         "SFC3 XBAR-RX" },       \
+       { name " Mux",          "SFC4",         "SFC4 XBAR-RX" },       \
+       { name " Mux",          "MVC1",         "MVC1 XBAR-RX" },       \
+       { name " Mux",          "MVC2",         "MVC2 XBAR-RX" },       \
+       { name " Mux",          "AMX1",         "AMX1 XBAR-RX" },       \
+       { name " Mux",          "AMX2",         "AMX2 XBAR-RX" },       \
+       { name " Mux",          "ADX1 TX1",     "ADX1 TX1 XBAR-RX" },   \
+       { name " Mux",          "ADX1 TX2",     "ADX1 TX2 XBAR-RX" },   \
+       { name " Mux",          "ADX1 TX3",     "ADX1 TX3 XBAR-RX" },   \
+       { name " Mux",          "ADX1 TX4",     "ADX1 TX4 XBAR-RX" },   \
+       { name " Mux",          "ADX2 TX1",     "ADX2 TX1 XBAR-RX" },   \
+       { name " Mux",          "ADX2 TX2",     "ADX2 TX2 XBAR-RX" },   \
+       { name " Mux",          "ADX2 TX3",     "ADX2 TX3 XBAR-RX" },   \
+       { name " Mux",          "ADX2 TX4",     "ADX2 TX4 XBAR-RX" },   \
+       { name " Mux",          "MIXER1 TX1",   "MIXER1 TX1 XBAR-RX" }, \
+       { name " Mux",          "MIXER1 TX2",   "MIXER1 TX2 XBAR-RX" }, \
+       { name " Mux",          "MIXER1 TX3",   "MIXER1 TX3 XBAR-RX" }, \
+       { name " Mux",          "MIXER1 TX4",   "MIXER1 TX4 XBAR-RX" }, \
+       { name " Mux",          "MIXER1 TX5",   "MIXER1 TX5 XBAR-RX" },
 
 #define TEGRA186_ONLY_MUX_ROUTES(name)                                 \
        { name " Mux",          "ADMAIF11",     "ADMAIF11 XBAR-RX" },   \
@@ -403,7 +838,17 @@ static const struct snd_soc_dapm_widget tegra186_ahub_widgets[] = {
        { name " Mux",          "ADMAIF19",     "ADMAIF19 XBAR-RX" },   \
        { name " Mux",          "ADMAIF20",     "ADMAIF20 XBAR-RX" },   \
        { name " Mux",          "I2S6",         "I2S6 XBAR-RX" },       \
-       { name " Mux",          "DMIC4",        "DMIC4 XBAR-RX" },
+       { name " Mux",          "DMIC4",        "DMIC4 XBAR-RX" },      \
+       { name " Mux",          "AMX3",         "AMX3 XBAR-RX" },       \
+       { name " Mux",          "AMX4",         "AMX4 XBAR-RX" },       \
+       { name " Mux",          "ADX3 TX1",     "ADX3 TX1 XBAR-RX" },   \
+       { name " Mux",          "ADX3 TX2",     "ADX3 TX2 XBAR-RX" },   \
+       { name " Mux",          "ADX3 TX3",     "ADX3 TX3 XBAR-RX" },   \
+       { name " Mux",          "ADX3 TX4",     "ADX3 TX4 XBAR-RX" },   \
+       { name " Mux",          "ADX4 TX1",     "ADX4 TX1 XBAR-RX" },   \
+       { name " Mux",          "ADX4 TX2",     "ADX4 TX2 XBAR-RX" },   \
+       { name " Mux",          "ADX4 TX3",     "ADX4 TX3 XBAR-RX" },   \
+       { name " Mux",          "ADX4 TX4",     "ADX4 TX4 XBAR-RX" },
 
 #define TEGRA210_MUX_ROUTES(name)                                              \
        TEGRA_COMMON_MUX_ROUTES(name)
@@ -450,6 +895,32 @@ static const struct snd_soc_dapm_route tegra210_ahub_routes[] = {
        TEGRA210_MUX_ROUTES("I2S3")
        TEGRA210_MUX_ROUTES("I2S4")
        TEGRA210_MUX_ROUTES("I2S5")
+       TEGRA210_MUX_ROUTES("SFC1")
+       TEGRA210_MUX_ROUTES("SFC2")
+       TEGRA210_MUX_ROUTES("SFC3")
+       TEGRA210_MUX_ROUTES("SFC4")
+       TEGRA210_MUX_ROUTES("MVC1")
+       TEGRA210_MUX_ROUTES("MVC2")
+       TEGRA210_MUX_ROUTES("AMX1 RX1")
+       TEGRA210_MUX_ROUTES("AMX1 RX2")
+       TEGRA210_MUX_ROUTES("AMX1 RX3")
+       TEGRA210_MUX_ROUTES("AMX1 RX4")
+       TEGRA210_MUX_ROUTES("AMX2 RX1")
+       TEGRA210_MUX_ROUTES("AMX2 RX2")
+       TEGRA210_MUX_ROUTES("AMX2 RX3")
+       TEGRA210_MUX_ROUTES("AMX2 RX4")
+       TEGRA210_MUX_ROUTES("ADX1")
+       TEGRA210_MUX_ROUTES("ADX2")
+       TEGRA210_MUX_ROUTES("MIXER1 RX1")
+       TEGRA210_MUX_ROUTES("MIXER1 RX2")
+       TEGRA210_MUX_ROUTES("MIXER1 RX3")
+       TEGRA210_MUX_ROUTES("MIXER1 RX4")
+       TEGRA210_MUX_ROUTES("MIXER1 RX5")
+       TEGRA210_MUX_ROUTES("MIXER1 RX6")
+       TEGRA210_MUX_ROUTES("MIXER1 RX7")
+       TEGRA210_MUX_ROUTES("MIXER1 RX8")
+       TEGRA210_MUX_ROUTES("MIXER1 RX9")
+       TEGRA210_MUX_ROUTES("MIXER1 RX10")
 };
 
 static const struct snd_soc_dapm_route tegra186_ahub_routes[] = {
@@ -501,6 +972,42 @@ static const struct snd_soc_dapm_route tegra186_ahub_routes[] = {
        TEGRA186_MUX_ROUTES("I2S6")
        TEGRA186_MUX_ROUTES("DSPK1")
        TEGRA186_MUX_ROUTES("DSPK2")
+       TEGRA186_MUX_ROUTES("SFC1")
+       TEGRA186_MUX_ROUTES("SFC2")
+       TEGRA186_MUX_ROUTES("SFC3")
+       TEGRA186_MUX_ROUTES("SFC4")
+       TEGRA186_MUX_ROUTES("MVC1")
+       TEGRA186_MUX_ROUTES("MVC2")
+       TEGRA186_MUX_ROUTES("AMX1 RX1")
+       TEGRA186_MUX_ROUTES("AMX1 RX2")
+       TEGRA186_MUX_ROUTES("AMX1 RX3")
+       TEGRA186_MUX_ROUTES("AMX1 RX4")
+       TEGRA186_MUX_ROUTES("AMX2 RX1")
+       TEGRA186_MUX_ROUTES("AMX2 RX2")
+       TEGRA186_MUX_ROUTES("AMX2 RX3")
+       TEGRA186_MUX_ROUTES("AMX2 RX4")
+       TEGRA186_MUX_ROUTES("AMX3 RX1")
+       TEGRA186_MUX_ROUTES("AMX3 RX2")
+       TEGRA186_MUX_ROUTES("AMX3 RX3")
+       TEGRA186_MUX_ROUTES("AMX3 RX4")
+       TEGRA186_MUX_ROUTES("AMX4 RX1")
+       TEGRA186_MUX_ROUTES("AMX4 RX2")
+       TEGRA186_MUX_ROUTES("AMX4 RX3")
+       TEGRA186_MUX_ROUTES("AMX4 RX4")
+       TEGRA186_MUX_ROUTES("ADX1")
+       TEGRA186_MUX_ROUTES("ADX2")
+       TEGRA186_MUX_ROUTES("ADX3")
+       TEGRA186_MUX_ROUTES("ADX4")
+       TEGRA186_MUX_ROUTES("MIXER1 RX1")
+       TEGRA186_MUX_ROUTES("MIXER1 RX2")
+       TEGRA186_MUX_ROUTES("MIXER1 RX3")
+       TEGRA186_MUX_ROUTES("MIXER1 RX4")
+       TEGRA186_MUX_ROUTES("MIXER1 RX5")
+       TEGRA186_MUX_ROUTES("MIXER1 RX6")
+       TEGRA186_MUX_ROUTES("MIXER1 RX7")
+       TEGRA186_MUX_ROUTES("MIXER1 RX8")
+       TEGRA186_MUX_ROUTES("MIXER1 RX9")
+       TEGRA186_MUX_ROUTES("MIXER1 RX10")
 };
 
 static const struct snd_soc_component_driver tegra210_ahub_component = {
diff --git a/sound/soc/tegra/tegra210_amx.c b/sound/soc/tegra/tegra210_amx.c
new file mode 100644 (file)
index 0000000..af9bddf
--- /dev/null
@@ -0,0 +1,600 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// tegra210_amx.c - Tegra210 AMX driver
+//
+// Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include "tegra210_amx.h"
+#include "tegra_cif.h"
+
+/*
+ * The counter is in terms of AHUB clock cycles. If a frame is not
+ * received within these clock cycles, the AMX input channel gets
+ * automatically disabled. For now the counter is calculated as a
+ * function of sample rate (8 kHz) and AHUB clock (49.152 MHz).
+ * If later an accurate number is needed, the counter needs to be
+ * calculated at runtime.
+ *
+ *     count = ahub_clk / sample_rate
+ */
+#define TEGRA194_MAX_FRAME_IDLE_COUNT  0x1800
+
+#define AMX_CH_REG(id, reg) ((reg) + ((id) * TEGRA210_AMX_AUDIOCIF_CH_STRIDE))
+
+static const struct reg_default tegra210_amx_reg_defaults[] = {
+       { TEGRA210_AMX_RX_INT_MASK, 0x0000000f},
+       { TEGRA210_AMX_RX1_CIF_CTRL, 0x00007000},
+       { TEGRA210_AMX_RX2_CIF_CTRL, 0x00007000},
+       { TEGRA210_AMX_RX3_CIF_CTRL, 0x00007000},
+       { TEGRA210_AMX_RX4_CIF_CTRL, 0x00007000},
+       { TEGRA210_AMX_TX_INT_MASK, 0x00000001},
+       { TEGRA210_AMX_TX_CIF_CTRL, 0x00007000},
+       { TEGRA210_AMX_CG, 0x1},
+       { TEGRA210_AMX_CFG_RAM_CTRL, 0x00004000},
+};
+
+static void tegra210_amx_write_map_ram(struct tegra210_amx *amx)
+{
+       int i;
+
+       regmap_write(amx->regmap, TEGRA210_AMX_CFG_RAM_CTRL,
+                    TEGRA210_AMX_CFG_RAM_CTRL_SEQ_ACCESS_EN |
+                    TEGRA210_AMX_CFG_RAM_CTRL_ADDR_INIT_EN |
+                    TEGRA210_AMX_CFG_RAM_CTRL_RW_WRITE);
+
+       for (i = 0; i < TEGRA210_AMX_RAM_DEPTH; i++)
+               regmap_write(amx->regmap, TEGRA210_AMX_CFG_RAM_DATA,
+                            amx->map[i]);
+
+       regmap_write(amx->regmap, TEGRA210_AMX_OUT_BYTE_EN0, amx->byte_mask[0]);
+       regmap_write(amx->regmap, TEGRA210_AMX_OUT_BYTE_EN1, amx->byte_mask[1]);
+}
+
+static int tegra210_amx_startup(struct snd_pcm_substream *substream,
+                               struct snd_soc_dai *dai)
+{
+       struct tegra210_amx *amx = snd_soc_dai_get_drvdata(dai);
+       unsigned int val;
+       int err;
+
+       /* Ensure if AMX is disabled */
+       err = regmap_read_poll_timeout(amx->regmap, TEGRA210_AMX_STATUS, val,
+                                      !(val & 0x1), 10, 10000);
+       if (err < 0) {
+               dev_err(dai->dev, "failed to stop AMX, err = %d\n", err);
+               return err;
+       }
+
+       /*
+        * Soft Reset: Below performs module soft reset which clears
+        * all FSM logic, flushes flow control of FIFO and resets the
+        * state register. It also brings module back to disabled
+        * state (without flushing the data in the pipe).
+        */
+       regmap_update_bits(amx->regmap, TEGRA210_AMX_SOFT_RESET,
+                          TEGRA210_AMX_SOFT_RESET_SOFT_RESET_MASK,
+                          TEGRA210_AMX_SOFT_RESET_SOFT_EN);
+
+       err = regmap_read_poll_timeout(amx->regmap, TEGRA210_AMX_SOFT_RESET,
+                                      val, !(val & 0x1), 10, 10000);
+       if (err < 0) {
+               dev_err(dai->dev, "failed to reset AMX, err = %d\n", err);
+               return err;
+       }
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_amx_runtime_suspend(struct device *dev)
+{
+       struct tegra210_amx *amx = dev_get_drvdata(dev);
+
+       regcache_cache_only(amx->regmap, true);
+       regcache_mark_dirty(amx->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_amx_runtime_resume(struct device *dev)
+{
+       struct tegra210_amx *amx = dev_get_drvdata(dev);
+
+       regcache_cache_only(amx->regmap, false);
+       regcache_sync(amx->regmap);
+
+       regmap_update_bits(amx->regmap,
+               TEGRA210_AMX_CTRL,
+               TEGRA210_AMX_CTRL_RX_DEP_MASK,
+               TEGRA210_AMX_WAIT_ON_ANY << TEGRA210_AMX_CTRL_RX_DEP_SHIFT);
+
+       tegra210_amx_write_map_ram(amx);
+
+       return 0;
+}
+
+static int tegra210_amx_set_audio_cif(struct snd_soc_dai *dai,
+                                     struct snd_pcm_hw_params *params,
+                                     unsigned int reg)
+{
+       struct tegra210_amx *amx = snd_soc_dai_get_drvdata(dai);
+       int channels, audio_bits;
+       struct tegra_cif_conf cif_conf;
+
+       memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
+
+       channels = params_channels(params);
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S8:
+               audio_bits = TEGRA_ACIF_BITS_8;
+               break;
+       case SNDRV_PCM_FORMAT_S16_LE:
+               audio_bits = TEGRA_ACIF_BITS_16;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               audio_bits = TEGRA_ACIF_BITS_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       cif_conf.audio_ch = channels;
+       cif_conf.client_ch = channels;
+       cif_conf.audio_bits = audio_bits;
+       cif_conf.client_bits = audio_bits;
+
+       tegra_set_cif(amx->regmap, reg, &cif_conf);
+
+       return 0;
+}
+
+static int tegra210_amx_in_hw_params(struct snd_pcm_substream *substream,
+                                    struct snd_pcm_hw_params *params,
+                                    struct snd_soc_dai *dai)
+{
+       struct tegra210_amx *amx = snd_soc_dai_get_drvdata(dai);
+
+       if (amx->soc_data->auto_disable) {
+               regmap_write(amx->regmap,
+                            AMX_CH_REG(dai->id, TEGRA194_AMX_RX1_FRAME_PERIOD),
+                            TEGRA194_MAX_FRAME_IDLE_COUNT);
+               regmap_write(amx->regmap, TEGRA210_AMX_CYA, 1);
+       }
+
+       return tegra210_amx_set_audio_cif(dai, params,
+                       AMX_CH_REG(dai->id, TEGRA210_AMX_RX1_CIF_CTRL));
+}
+
+static int tegra210_amx_out_hw_params(struct snd_pcm_substream *substream,
+                                     struct snd_pcm_hw_params *params,
+                                     struct snd_soc_dai *dai)
+{
+       return tegra210_amx_set_audio_cif(dai, params,
+                                         TEGRA210_AMX_TX_CIF_CTRL);
+}
+
+static int tegra210_amx_get_byte_map(struct snd_kcontrol *kcontrol,
+                                    struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct tegra210_amx *amx = snd_soc_component_get_drvdata(cmpnt);
+       unsigned char *bytes_map = (unsigned char *)&amx->map;
+       int reg = mc->reg;
+       int enabled;
+
+       if (reg > 31)
+               enabled = amx->byte_mask[1] & (1 << (reg - 32));
+       else
+               enabled = amx->byte_mask[0] & (1 << reg);
+
+       if (enabled)
+               ucontrol->value.integer.value[0] = bytes_map[reg];
+       else
+               ucontrol->value.integer.value[0] = 0;
+
+       return 0;
+}
+
+static int tegra210_amx_put_byte_map(struct snd_kcontrol *kcontrol,
+                                    struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_amx *amx = snd_soc_component_get_drvdata(cmpnt);
+       unsigned char *bytes_map = (unsigned char *)&amx->map;
+       int reg = mc->reg;
+       int value = ucontrol->value.integer.value[0];
+
+       if (value >= 0 && value <= 255) {
+               /* Update byte map and enable slot */
+               bytes_map[reg] = value;
+               if (reg > 31)
+                       amx->byte_mask[1] |= (1 << (reg - 32));
+               else
+                       amx->byte_mask[0] |= (1 << reg);
+       } else {
+               /* Reset byte map and disable slot */
+               bytes_map[reg] = 0;
+               if (reg > 31)
+                       amx->byte_mask[1] &= ~(1 << (reg - 32));
+               else
+                       amx->byte_mask[0] &= ~(1 << reg);
+       }
+
+       return 1;
+}
+
+static const struct snd_soc_dai_ops tegra210_amx_out_dai_ops = {
+       .hw_params      = tegra210_amx_out_hw_params,
+       .startup        = tegra210_amx_startup,
+};
+
+static const struct snd_soc_dai_ops tegra210_amx_in_dai_ops = {
+       .hw_params      = tegra210_amx_in_hw_params,
+};
+
+#define IN_DAI(id)                                             \
+       {                                                       \
+               .name = "AMX-RX-CIF" #id,                       \
+               .playback = {                                   \
+                       .stream_name = "RX" #id "-CIF-Playback",\
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "RX" #id "-CIF-Capture", \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .ops = &tegra210_amx_in_dai_ops,                \
+       }
+
+#define OUT_DAI                                                        \
+       {                                                       \
+               .name = "AMX-TX-CIF",                           \
+               .playback = {                                   \
+                       .stream_name = "TX-CIF-Playback",       \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "TX-CIF-Capture",        \
+                       .channels_min = 1,                      \
+                       .channels_max = 16,                     \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                                  SNDRV_PCM_FMTBIT_S16_LE |    \
+                                  SNDRV_PCM_FMTBIT_S32_LE,     \
+               },                                              \
+               .ops = &tegra210_amx_out_dai_ops,               \
+       }
+
+static struct snd_soc_dai_driver tegra210_amx_dais[] = {
+       IN_DAI(1),
+       IN_DAI(2),
+       IN_DAI(3),
+       IN_DAI(4),
+       OUT_DAI,
+};
+
+static const struct snd_soc_dapm_widget tegra210_amx_widgets[] = {
+       SND_SOC_DAPM_AIF_IN("RX1", NULL, 0, TEGRA210_AMX_CTRL, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX2", NULL, 0, TEGRA210_AMX_CTRL, 1, 0),
+       SND_SOC_DAPM_AIF_IN("RX3", NULL, 0, TEGRA210_AMX_CTRL, 2, 0),
+       SND_SOC_DAPM_AIF_IN("RX4", NULL, 0, TEGRA210_AMX_CTRL, 3, 0),
+       SND_SOC_DAPM_AIF_OUT("TX", NULL, 0, TEGRA210_AMX_ENABLE,
+                            TEGRA210_AMX_ENABLE_SHIFT, 0),
+};
+
+#define STREAM_ROUTES(id, sname)                                         \
+       { "RX" #id " XBAR-" sname,      NULL,   "RX" #id " XBAR-TX" },    \
+       { "RX" #id "-CIF-" sname,       NULL,   "RX" #id " XBAR-" sname },\
+       { "RX" #id,                     NULL,   "RX" #id "-CIF-" sname }, \
+       { "TX",                         NULL,   "RX" #id },               \
+       { "TX-CIF-" sname,              NULL,   "TX" },                   \
+       { "XBAR-" sname,                NULL,   "TX-CIF-" sname },        \
+       { "XBAR-RX",                    NULL,   "XBAR-" sname }
+
+#define AMX_ROUTES(id)                 \
+       STREAM_ROUTES(id, "Playback"),  \
+       STREAM_ROUTES(id, "Capture")
+
+static const struct snd_soc_dapm_route tegra210_amx_routes[] = {
+       AMX_ROUTES(1),
+       AMX_ROUTES(2),
+       AMX_ROUTES(3),
+       AMX_ROUTES(4),
+};
+
+#define TEGRA210_AMX_BYTE_MAP_CTRL(reg)                                        \
+       SOC_SINGLE_EXT("Byte Map " #reg, reg, 0, 256, 0,                \
+                      tegra210_amx_get_byte_map,                       \
+                      tegra210_amx_put_byte_map)
+
+static struct snd_kcontrol_new tegra210_amx_controls[] = {
+       TEGRA210_AMX_BYTE_MAP_CTRL(0),
+       TEGRA210_AMX_BYTE_MAP_CTRL(1),
+       TEGRA210_AMX_BYTE_MAP_CTRL(2),
+       TEGRA210_AMX_BYTE_MAP_CTRL(3),
+       TEGRA210_AMX_BYTE_MAP_CTRL(4),
+       TEGRA210_AMX_BYTE_MAP_CTRL(5),
+       TEGRA210_AMX_BYTE_MAP_CTRL(6),
+       TEGRA210_AMX_BYTE_MAP_CTRL(7),
+       TEGRA210_AMX_BYTE_MAP_CTRL(8),
+       TEGRA210_AMX_BYTE_MAP_CTRL(9),
+       TEGRA210_AMX_BYTE_MAP_CTRL(10),
+       TEGRA210_AMX_BYTE_MAP_CTRL(11),
+       TEGRA210_AMX_BYTE_MAP_CTRL(12),
+       TEGRA210_AMX_BYTE_MAP_CTRL(13),
+       TEGRA210_AMX_BYTE_MAP_CTRL(14),
+       TEGRA210_AMX_BYTE_MAP_CTRL(15),
+       TEGRA210_AMX_BYTE_MAP_CTRL(16),
+       TEGRA210_AMX_BYTE_MAP_CTRL(17),
+       TEGRA210_AMX_BYTE_MAP_CTRL(18),
+       TEGRA210_AMX_BYTE_MAP_CTRL(19),
+       TEGRA210_AMX_BYTE_MAP_CTRL(20),
+       TEGRA210_AMX_BYTE_MAP_CTRL(21),
+       TEGRA210_AMX_BYTE_MAP_CTRL(22),
+       TEGRA210_AMX_BYTE_MAP_CTRL(23),
+       TEGRA210_AMX_BYTE_MAP_CTRL(24),
+       TEGRA210_AMX_BYTE_MAP_CTRL(25),
+       TEGRA210_AMX_BYTE_MAP_CTRL(26),
+       TEGRA210_AMX_BYTE_MAP_CTRL(27),
+       TEGRA210_AMX_BYTE_MAP_CTRL(28),
+       TEGRA210_AMX_BYTE_MAP_CTRL(29),
+       TEGRA210_AMX_BYTE_MAP_CTRL(30),
+       TEGRA210_AMX_BYTE_MAP_CTRL(31),
+       TEGRA210_AMX_BYTE_MAP_CTRL(32),
+       TEGRA210_AMX_BYTE_MAP_CTRL(33),
+       TEGRA210_AMX_BYTE_MAP_CTRL(34),
+       TEGRA210_AMX_BYTE_MAP_CTRL(35),
+       TEGRA210_AMX_BYTE_MAP_CTRL(36),
+       TEGRA210_AMX_BYTE_MAP_CTRL(37),
+       TEGRA210_AMX_BYTE_MAP_CTRL(38),
+       TEGRA210_AMX_BYTE_MAP_CTRL(39),
+       TEGRA210_AMX_BYTE_MAP_CTRL(40),
+       TEGRA210_AMX_BYTE_MAP_CTRL(41),
+       TEGRA210_AMX_BYTE_MAP_CTRL(42),
+       TEGRA210_AMX_BYTE_MAP_CTRL(43),
+       TEGRA210_AMX_BYTE_MAP_CTRL(44),
+       TEGRA210_AMX_BYTE_MAP_CTRL(45),
+       TEGRA210_AMX_BYTE_MAP_CTRL(46),
+       TEGRA210_AMX_BYTE_MAP_CTRL(47),
+       TEGRA210_AMX_BYTE_MAP_CTRL(48),
+       TEGRA210_AMX_BYTE_MAP_CTRL(49),
+       TEGRA210_AMX_BYTE_MAP_CTRL(50),
+       TEGRA210_AMX_BYTE_MAP_CTRL(51),
+       TEGRA210_AMX_BYTE_MAP_CTRL(52),
+       TEGRA210_AMX_BYTE_MAP_CTRL(53),
+       TEGRA210_AMX_BYTE_MAP_CTRL(54),
+       TEGRA210_AMX_BYTE_MAP_CTRL(55),
+       TEGRA210_AMX_BYTE_MAP_CTRL(56),
+       TEGRA210_AMX_BYTE_MAP_CTRL(57),
+       TEGRA210_AMX_BYTE_MAP_CTRL(58),
+       TEGRA210_AMX_BYTE_MAP_CTRL(59),
+       TEGRA210_AMX_BYTE_MAP_CTRL(60),
+       TEGRA210_AMX_BYTE_MAP_CTRL(61),
+       TEGRA210_AMX_BYTE_MAP_CTRL(62),
+       TEGRA210_AMX_BYTE_MAP_CTRL(63),
+};
+
+static const struct snd_soc_component_driver tegra210_amx_cmpnt = {
+       .dapm_widgets           = tegra210_amx_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(tegra210_amx_widgets),
+       .dapm_routes            = tegra210_amx_routes,
+       .num_dapm_routes        = ARRAY_SIZE(tegra210_amx_routes),
+       .controls               = tegra210_amx_controls,
+       .num_controls           = ARRAY_SIZE(tegra210_amx_controls),
+};
+
+static bool tegra210_amx_wr_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_AMX_RX_INT_MASK ... TEGRA210_AMX_RX4_CIF_CTRL:
+       case TEGRA210_AMX_TX_INT_MASK ... TEGRA210_AMX_CG:
+       case TEGRA210_AMX_CTRL ... TEGRA210_AMX_CYA:
+       case TEGRA210_AMX_CFG_RAM_CTRL ... TEGRA210_AMX_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra194_amx_wr_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA194_AMX_RX1_FRAME_PERIOD ... TEGRA194_AMX_RX4_FRAME_PERIOD:
+               return true;
+       default:
+               return tegra210_amx_wr_reg(dev, reg);
+       }
+}
+
+static bool tegra210_amx_rd_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_AMX_RX_STATUS ... TEGRA210_AMX_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra194_amx_rd_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA194_AMX_RX1_FRAME_PERIOD ... TEGRA194_AMX_RX4_FRAME_PERIOD:
+               return true;
+       default:
+               return tegra210_amx_rd_reg(dev, reg);
+       }
+}
+
+static bool tegra210_amx_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_AMX_RX_STATUS:
+       case TEGRA210_AMX_RX_INT_STATUS:
+       case TEGRA210_AMX_RX_INT_SET:
+       case TEGRA210_AMX_TX_STATUS:
+       case TEGRA210_AMX_TX_INT_STATUS:
+       case TEGRA210_AMX_TX_INT_SET:
+       case TEGRA210_AMX_SOFT_RESET:
+       case TEGRA210_AMX_STATUS:
+       case TEGRA210_AMX_INT_STATUS:
+       case TEGRA210_AMX_CFG_RAM_CTRL:
+       case TEGRA210_AMX_CFG_RAM_DATA:
+               return true;
+       default:
+               break;
+       }
+
+       return false;
+}
+
+static const struct regmap_config tegra210_amx_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA210_AMX_CFG_RAM_DATA,
+       .writeable_reg          = tegra210_amx_wr_reg,
+       .readable_reg           = tegra210_amx_rd_reg,
+       .volatile_reg           = tegra210_amx_volatile_reg,
+       .reg_defaults           = tegra210_amx_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_amx_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct regmap_config tegra194_amx_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA194_AMX_RX4_LAST_FRAME_PERIOD,
+       .writeable_reg          = tegra194_amx_wr_reg,
+       .readable_reg           = tegra194_amx_rd_reg,
+       .volatile_reg           = tegra210_amx_volatile_reg,
+       .reg_defaults           = tegra210_amx_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_amx_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct tegra210_amx_soc_data soc_data_tegra210 = {
+       .regmap_conf    = &tegra210_amx_regmap_config,
+};
+
+static const struct tegra210_amx_soc_data soc_data_tegra194 = {
+       .regmap_conf    = &tegra194_amx_regmap_config,
+       .auto_disable   = true,
+};
+
+static const struct of_device_id tegra210_amx_of_match[] = {
+       { .compatible = "nvidia,tegra210-amx", .data = &soc_data_tegra210 },
+       { .compatible = "nvidia,tegra194-amx", .data = &soc_data_tegra194 },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tegra210_amx_of_match);
+
+static int tegra210_amx_platform_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tegra210_amx *amx;
+       void __iomem *regs;
+       int err;
+       const struct of_device_id *match;
+       struct tegra210_amx_soc_data *soc_data;
+
+       match = of_match_device(tegra210_amx_of_match, dev);
+
+       soc_data = (struct tegra210_amx_soc_data *)match->data;
+
+       amx = devm_kzalloc(dev, sizeof(*amx), GFP_KERNEL);
+       if (!amx)
+               return -ENOMEM;
+
+       amx->soc_data = soc_data;
+
+       dev_set_drvdata(dev, amx);
+
+       regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(regs))
+               return PTR_ERR(regs);
+
+       amx->regmap = devm_regmap_init_mmio(dev, regs,
+                                           soc_data->regmap_conf);
+       if (IS_ERR(amx->regmap)) {
+               dev_err(dev, "regmap init failed\n");
+               return PTR_ERR(amx->regmap);
+       }
+
+       regcache_cache_only(amx->regmap, true);
+
+       err = devm_snd_soc_register_component(dev, &tegra210_amx_cmpnt,
+                                             tegra210_amx_dais,
+                                             ARRAY_SIZE(tegra210_amx_dais));
+       if (err) {
+               dev_err(dev, "can't register AMX component, err: %d\n", err);
+               return err;
+       }
+
+       pm_runtime_enable(dev);
+
+       return 0;
+}
+
+static int tegra210_amx_platform_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static const struct dev_pm_ops tegra210_amx_pm_ops = {
+       SET_RUNTIME_PM_OPS(tegra210_amx_runtime_suspend,
+                          tegra210_amx_runtime_resume, NULL)
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                    pm_runtime_force_resume)
+};
+
+static struct platform_driver tegra210_amx_driver = {
+       .driver = {
+               .name = "tegra210-amx",
+               .of_match_table = tegra210_amx_of_match,
+               .pm = &tegra210_amx_pm_ops,
+       },
+       .probe = tegra210_amx_platform_probe,
+       .remove = tegra210_amx_platform_remove,
+};
+module_platform_driver(tegra210_amx_driver);
+
+MODULE_AUTHOR("Songhee Baek <sbaek@nvidia.com>");
+MODULE_DESCRIPTION("Tegra210 AMX ASoC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/tegra/tegra210_amx.h b/sound/soc/tegra/tegra210_amx.h
new file mode 100644 (file)
index 0000000..e277741
--- /dev/null
@@ -0,0 +1,93 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * tegra210_amx.h - Definitions for Tegra210 AMX driver
+ *
+ * Copyright (c) 2021, NVIDIA CORPORATION.  All rights reserved.
+ *
+ */
+
+#ifndef __TEGRA210_AMX_H__
+#define __TEGRA210_AMX_H__
+
+/* Register offsets from TEGRA210_AMX*_BASE */
+#define TEGRA210_AMX_RX_STATUS                 0x0c
+#define TEGRA210_AMX_RX_INT_STATUS             0x10
+#define TEGRA210_AMX_RX_INT_MASK               0x14
+#define TEGRA210_AMX_RX_INT_SET                        0x18
+#define TEGRA210_AMX_RX_INT_CLEAR              0x1c
+#define TEGRA210_AMX_RX1_CIF_CTRL              0x20
+#define TEGRA210_AMX_RX2_CIF_CTRL              0x24
+#define TEGRA210_AMX_RX3_CIF_CTRL              0x28
+#define TEGRA210_AMX_RX4_CIF_CTRL              0x2c
+#define TEGRA210_AMX_TX_STATUS                 0x4c
+#define TEGRA210_AMX_TX_INT_STATUS             0x50
+#define TEGRA210_AMX_TX_INT_MASK               0x54
+#define TEGRA210_AMX_TX_INT_SET                        0x58
+#define TEGRA210_AMX_TX_INT_CLEAR              0x5c
+#define TEGRA210_AMX_TX_CIF_CTRL               0x60
+#define TEGRA210_AMX_ENABLE                    0x80
+#define TEGRA210_AMX_SOFT_RESET                        0x84
+#define TEGRA210_AMX_CG                                0x88
+#define TEGRA210_AMX_STATUS                    0x8c
+#define TEGRA210_AMX_INT_STATUS                        0x90
+#define TEGRA210_AMX_CTRL                      0xa4
+#define TEGRA210_AMX_OUT_BYTE_EN0              0xa8
+#define TEGRA210_AMX_OUT_BYTE_EN1              0xac
+#define TEGRA210_AMX_CYA                       0xb0
+#define TEGRA210_AMX_CFG_RAM_CTRL              0xb8
+#define TEGRA210_AMX_CFG_RAM_DATA              0xbc
+
+#define TEGRA194_AMX_RX1_FRAME_PERIOD          0xc0
+#define TEGRA194_AMX_RX4_FRAME_PERIOD          0xcc
+#define TEGRA194_AMX_RX4_LAST_FRAME_PERIOD     0xdc
+
+/* Fields in TEGRA210_AMX_ENABLE */
+#define TEGRA210_AMX_ENABLE_SHIFT                      0
+
+/* Fields in TEGRA210_AMX_CTRL */
+#define TEGRA210_AMX_CTRL_MSTR_RX_NUM_SHIFT            14
+#define TEGRA210_AMX_CTRL_MSTR_RX_NUM_MASK             (3 << TEGRA210_AMX_CTRL_MSTR_RX_NUM_SHIFT)
+
+#define TEGRA210_AMX_CTRL_RX_DEP_SHIFT                 12
+#define TEGRA210_AMX_CTRL_RX_DEP_MASK                  (3 << TEGRA210_AMX_CTRL_RX_DEP_SHIFT)
+
+/* Fields in TEGRA210_AMX_CFG_RAM_CTRL */
+#define TEGRA210_AMX_CFG_RAM_CTRL_RW_SHIFT             14
+#define TEGRA210_AMX_CFG_RAM_CTRL_RW_WRITE             (1 << TEGRA210_AMX_CFG_RAM_CTRL_RW_SHIFT)
+
+#define TEGRA210_AMX_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT   13
+#define TEGRA210_AMX_CFG_RAM_CTRL_ADDR_INIT_EN         (1 << TEGRA210_AMX_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT)
+
+#define TEGRA210_AMX_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT  12
+#define TEGRA210_AMX_CFG_RAM_CTRL_SEQ_ACCESS_EN                (1 << TEGRA210_AMX_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT)
+
+#define TEGRA210_AMX_CFG_CTRL_RAM_ADDR_SHIFT           0
+
+/* Fields in TEGRA210_AMX_SOFT_RESET */
+#define TEGRA210_AMX_SOFT_RESET_SOFT_EN                        1
+#define TEGRA210_AMX_SOFT_RESET_SOFT_RESET_MASK                TEGRA210_AMX_SOFT_RESET_SOFT_EN
+
+#define TEGRA210_AMX_AUDIOCIF_CH_STRIDE                4
+#define TEGRA210_AMX_RAM_DEPTH                 16
+#define TEGRA210_AMX_MAP_STREAM_NUM_SHIFT      6
+#define TEGRA210_AMX_MAP_WORD_NUM_SHIFT                2
+#define TEGRA210_AMX_MAP_BYTE_NUM_SHIFT                0
+
+enum {
+       TEGRA210_AMX_WAIT_ON_ALL,
+       TEGRA210_AMX_WAIT_ON_ANY,
+};
+
+struct tegra210_amx_soc_data {
+       const struct regmap_config *regmap_conf;
+       bool auto_disable;
+};
+
+struct tegra210_amx {
+       const struct tegra210_amx_soc_data *soc_data;
+       unsigned int map[TEGRA210_AMX_RAM_DEPTH];
+       struct regmap *regmap;
+       unsigned int byte_mask[2];
+};
+
+#endif
diff --git a/sound/soc/tegra/tegra210_mixer.c b/sound/soc/tegra/tegra210_mixer.c
new file mode 100644 (file)
index 0000000..55e6177
--- /dev/null
@@ -0,0 +1,674 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// tegra210_mixer.c - Tegra210 MIXER driver
+//
+// Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include "tegra210_mixer.h"
+#include "tegra_cif.h"
+
+#define MIXER_REG(reg, id)     ((reg) + ((id) * TEGRA210_MIXER_REG_STRIDE))
+#define MIXER_REG_BASE(reg)    ((reg) % TEGRA210_MIXER_REG_STRIDE)
+
+#define MIXER_GAIN_CFG_RAM_ADDR(id)                                    \
+       (TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_0 +                           \
+        ((id) * TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_STRIDE))
+
+#define MIXER_RX_REG_DEFAULTS(id)                                      \
+       { MIXER_REG(TEGRA210_MIXER_RX1_CIF_CTRL, id), 0x00007700},      \
+       { MIXER_REG(TEGRA210_MIXER_RX1_CTRL, id), 0x00010823},  \
+       { MIXER_REG(TEGRA210_MIXER_RX1_PEAK_CTRL, id), 0x000012c0}
+
+#define MIXER_TX_REG_DEFAULTS(id)                                      \
+       { MIXER_REG(TEGRA210_MIXER_TX1_INT_MASK, (id)), 0x00000001},    \
+       { MIXER_REG(TEGRA210_MIXER_TX1_CIF_CTRL, (id)), 0x00007700}
+
+#define REG_DURATION_PARAM(reg, i) ((reg) + NUM_GAIN_POLY_COEFFS + 1 + (i))
+
+static const struct reg_default tegra210_mixer_reg_defaults[] = {
+       /* Inputs */
+       MIXER_RX_REG_DEFAULTS(0),
+       MIXER_RX_REG_DEFAULTS(1),
+       MIXER_RX_REG_DEFAULTS(2),
+       MIXER_RX_REG_DEFAULTS(3),
+       MIXER_RX_REG_DEFAULTS(4),
+       MIXER_RX_REG_DEFAULTS(5),
+       MIXER_RX_REG_DEFAULTS(6),
+       MIXER_RX_REG_DEFAULTS(7),
+       MIXER_RX_REG_DEFAULTS(8),
+       MIXER_RX_REG_DEFAULTS(9),
+       /* Outputs */
+       MIXER_TX_REG_DEFAULTS(0),
+       MIXER_TX_REG_DEFAULTS(1),
+       MIXER_TX_REG_DEFAULTS(2),
+       MIXER_TX_REG_DEFAULTS(3),
+       MIXER_TX_REG_DEFAULTS(4),
+
+       { TEGRA210_MIXER_CG, 0x00000001},
+       { TEGRA210_MIXER_GAIN_CFG_RAM_CTRL, 0x00004000},
+       { TEGRA210_MIXER_PEAKM_RAM_CTRL, 0x00004000},
+       { TEGRA210_MIXER_ENABLE, 0x1 },
+};
+
+/* Default gain parameters */
+static const struct tegra210_mixer_gain_params gain_params = {
+       /* Polynomial coefficients */
+       { 0, 0, 0, 0, 0, 0, 0, 0x1000000, 0 },
+       /* Gain value */
+       0x10000,
+       /* Duration Parameters */
+       { 0, 0, 0x400, 0x8000000 },
+};
+
+static int __maybe_unused tegra210_mixer_runtime_suspend(struct device *dev)
+{
+       struct tegra210_mixer *mixer = dev_get_drvdata(dev);
+
+       regcache_cache_only(mixer->regmap, true);
+       regcache_mark_dirty(mixer->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_mixer_runtime_resume(struct device *dev)
+{
+       struct tegra210_mixer *mixer = dev_get_drvdata(dev);
+
+       regcache_cache_only(mixer->regmap, false);
+       regcache_sync(mixer->regmap);
+
+       return 0;
+}
+
+static int tegra210_mixer_write_ram(struct tegra210_mixer *mixer,
+                                   unsigned int addr,
+                                   unsigned int coef)
+{
+       unsigned int reg, val;
+       int err;
+
+       /* Check if busy */
+       err = regmap_read_poll_timeout(mixer->regmap,
+                                      TEGRA210_MIXER_GAIN_CFG_RAM_CTRL,
+                                      val, !(val & 0x80000000), 10, 10000);
+       if (err < 0)
+               return err;
+
+       reg = (addr << TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_SHIFT) &
+             TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_MASK;
+       reg |= TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN;
+       reg |= TEGRA210_MIXER_GAIN_CFG_RAM_RW_WRITE;
+       reg |= TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN;
+
+       regmap_write(mixer->regmap,
+                    TEGRA210_MIXER_GAIN_CFG_RAM_CTRL,
+                    reg);
+       regmap_write(mixer->regmap,
+                    TEGRA210_MIXER_GAIN_CFG_RAM_DATA,
+                    coef);
+
+       return 0;
+}
+
+static int tegra210_mixer_configure_gain(struct snd_soc_component *cmpnt,
+                                        unsigned int id, bool instant_gain)
+{
+       struct tegra210_mixer *mixer = snd_soc_component_get_drvdata(cmpnt);
+       unsigned int reg = MIXER_GAIN_CFG_RAM_ADDR(id);
+       int err, i;
+
+       pm_runtime_get_sync(cmpnt->dev);
+
+       /* Write default gain poly coefficients */
+       for (i = 0; i < NUM_GAIN_POLY_COEFFS; i++) {
+               err = tegra210_mixer_write_ram(mixer, reg + i,
+                                              gain_params.poly_coeff[i]);
+
+               if (err < 0)
+                       goto rpm_put;
+       }
+
+       /* Write stored gain value */
+       err = tegra210_mixer_write_ram(mixer, reg + NUM_GAIN_POLY_COEFFS,
+                                      mixer->gain_value[id]);
+       if (err < 0)
+               goto rpm_put;
+
+       /* Write duration parameters */
+       for (i = 0; i < NUM_DURATION_PARMS; i++) {
+               int val;
+
+               if (instant_gain)
+                       val = 1;
+               else
+                       val = gain_params.duration[i];
+
+               err = tegra210_mixer_write_ram(mixer,
+                                              REG_DURATION_PARAM(reg, i),
+                                              val);
+               if (err < 0)
+                       goto rpm_put;
+       }
+
+       /* Trigger to apply gain configurations */
+       err = tegra210_mixer_write_ram(mixer, reg + REG_CFG_DONE_TRIGGER,
+                                      VAL_CFG_DONE_TRIGGER);
+
+rpm_put:
+       pm_runtime_put(cmpnt->dev);
+
+       return err;
+}
+
+static int tegra210_mixer_get_gain(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mixer *mixer = snd_soc_component_get_drvdata(cmpnt);
+       unsigned int reg = mc->reg;
+       unsigned int i;
+
+       i = (reg - TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_0) /
+           TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_STRIDE;
+
+       ucontrol->value.integer.value[0] = mixer->gain_value[i];
+
+       return 0;
+}
+
+static int tegra210_mixer_put_gain(struct snd_kcontrol *kcontrol,
+                                  struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mixer *mixer = snd_soc_component_get_drvdata(cmpnt);
+       unsigned int reg = mc->reg, id;
+       bool instant_gain = false;
+       int err;
+
+       if (strstr(kcontrol->id.name, "Instant Gain Volume"))
+               instant_gain = true;
+
+       /* Save gain value for specific MIXER input */
+       id = (reg - TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_0) /
+            TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_STRIDE;
+
+       mixer->gain_value[id] = ucontrol->value.integer.value[0];
+
+       err = tegra210_mixer_configure_gain(cmpnt, id, instant_gain);
+       if (err) {
+               dev_err(cmpnt->dev, "Failed to apply gain\n");
+               return err;
+       }
+
+       return 1;
+}
+
+static int tegra210_mixer_set_audio_cif(struct tegra210_mixer *mixer,
+                                       struct snd_pcm_hw_params *params,
+                                       unsigned int reg,
+                                       unsigned int id)
+{
+       unsigned int channels, audio_bits;
+       struct tegra_cif_conf cif_conf;
+
+       memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
+
+       channels = params_channels(params);
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               audio_bits = TEGRA_ACIF_BITS_16;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               audio_bits = TEGRA_ACIF_BITS_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       cif_conf.audio_ch = channels;
+       cif_conf.client_ch = channels;
+       cif_conf.audio_bits = audio_bits;
+       cif_conf.client_bits = audio_bits;
+
+       tegra_set_cif(mixer->regmap,
+                     reg + (id * TEGRA210_MIXER_REG_STRIDE),
+                     &cif_conf);
+
+       return 0;
+}
+
+static int tegra210_mixer_in_hw_params(struct snd_pcm_substream *substream,
+                                      struct snd_pcm_hw_params *params,
+                                      struct snd_soc_dai *dai)
+{
+       struct tegra210_mixer *mixer = snd_soc_dai_get_drvdata(dai);
+       int err;
+
+       err = tegra210_mixer_set_audio_cif(mixer, params,
+                                          TEGRA210_MIXER_RX1_CIF_CTRL,
+                                          dai->id);
+       if (err < 0)
+               return err;
+
+       return tegra210_mixer_configure_gain(dai->component, dai->id, false);
+}
+
+static int tegra210_mixer_out_hw_params(struct snd_pcm_substream *substream,
+                                       struct snd_pcm_hw_params *params,
+                                       struct snd_soc_dai *dai)
+{
+       struct tegra210_mixer *mixer = snd_soc_dai_get_drvdata(dai);
+
+       return tegra210_mixer_set_audio_cif(mixer, params,
+                                           TEGRA210_MIXER_TX1_CIF_CTRL,
+                                           dai->id - TEGRA210_MIXER_RX_MAX);
+}
+
+static const struct snd_soc_dai_ops tegra210_mixer_out_dai_ops = {
+       .hw_params      = tegra210_mixer_out_hw_params,
+};
+
+static const struct snd_soc_dai_ops tegra210_mixer_in_dai_ops = {
+       .hw_params      = tegra210_mixer_in_hw_params,
+};
+
+#define IN_DAI(id)                                             \
+       {                                                       \
+               .name = "MIXER-RX-CIF"#id,                      \
+               .playback = {                                   \
+                       .stream_name = "RX" #id "-CIF-Playback",\
+                       .channels_min = 1,                      \
+                       .channels_max = 8,                      \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                               SNDRV_PCM_FMTBIT_S16_LE |       \
+                               SNDRV_PCM_FMTBIT_S32_LE,        \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "RX" #id "-CIF-Capture", \
+                       .channels_min = 1,                      \
+                       .channels_max = 8,                      \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                               SNDRV_PCM_FMTBIT_S16_LE |       \
+                               SNDRV_PCM_FMTBIT_S32_LE,        \
+               },                                              \
+               .ops = &tegra210_mixer_in_dai_ops,              \
+       }
+
+#define OUT_DAI(id)                                            \
+       {                                                       \
+               .name = "MIXER-TX-CIF" #id,                     \
+               .playback = {                                   \
+                       .stream_name = "TX" #id "-CIF-Playback",\
+                       .channels_min = 1,                      \
+                       .channels_max = 8,                      \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                               SNDRV_PCM_FMTBIT_S16_LE |       \
+                               SNDRV_PCM_FMTBIT_S32_LE,        \
+               },                                              \
+               .capture = {                                    \
+                       .stream_name = "TX" #id "-CIF-Capture", \
+                       .channels_min = 1,                      \
+                       .channels_max = 8,                      \
+                       .rates = SNDRV_PCM_RATE_8000_192000,    \
+                       .formats = SNDRV_PCM_FMTBIT_S8 |        \
+                               SNDRV_PCM_FMTBIT_S16_LE |       \
+                               SNDRV_PCM_FMTBIT_S32_LE,        \
+               },                                              \
+               .ops = &tegra210_mixer_out_dai_ops,             \
+       }
+
+static struct snd_soc_dai_driver tegra210_mixer_dais[] = {
+       /* Mixer Input */
+       IN_DAI(1),
+       IN_DAI(2),
+       IN_DAI(3),
+       IN_DAI(4),
+       IN_DAI(5),
+       IN_DAI(6),
+       IN_DAI(7),
+       IN_DAI(8),
+       IN_DAI(9),
+       IN_DAI(10),
+
+       /* Mixer Output */
+       OUT_DAI(1),
+       OUT_DAI(2),
+       OUT_DAI(3),
+       OUT_DAI(4),
+       OUT_DAI(5),
+};
+
+#define ADDER_CTRL_DECL(name, reg)                     \
+       static const struct snd_kcontrol_new name[] = { \
+               SOC_DAPM_SINGLE("RX1", reg, 0, 1, 0),   \
+               SOC_DAPM_SINGLE("RX2", reg, 1, 1, 0),   \
+               SOC_DAPM_SINGLE("RX3", reg, 2, 1, 0),   \
+               SOC_DAPM_SINGLE("RX4", reg, 3, 1, 0),   \
+               SOC_DAPM_SINGLE("RX5", reg, 4, 1, 0),   \
+               SOC_DAPM_SINGLE("RX6", reg, 5, 1, 0),   \
+               SOC_DAPM_SINGLE("RX7", reg, 6, 1, 0),   \
+               SOC_DAPM_SINGLE("RX8", reg, 7, 1, 0),   \
+               SOC_DAPM_SINGLE("RX9", reg, 8, 1, 0),   \
+               SOC_DAPM_SINGLE("RX10", reg, 9, 1, 0),  \
+       }
+
+ADDER_CTRL_DECL(adder1, TEGRA210_MIXER_TX1_ADDER_CONFIG);
+ADDER_CTRL_DECL(adder2, TEGRA210_MIXER_TX2_ADDER_CONFIG);
+ADDER_CTRL_DECL(adder3, TEGRA210_MIXER_TX3_ADDER_CONFIG);
+ADDER_CTRL_DECL(adder4, TEGRA210_MIXER_TX4_ADDER_CONFIG);
+ADDER_CTRL_DECL(adder5, TEGRA210_MIXER_TX5_ADDER_CONFIG);
+
+#define GAIN_CTRL(id)  \
+       SOC_SINGLE_EXT("RX" #id " Gain Volume",                 \
+                      MIXER_GAIN_CFG_RAM_ADDR((id) - 1), 0,    \
+                      0x20000, 0, tegra210_mixer_get_gain,     \
+                      tegra210_mixer_put_gain),                \
+       SOC_SINGLE_EXT("RX" #id " Instant Gain Volume",         \
+                      MIXER_GAIN_CFG_RAM_ADDR((id) - 1), 0,    \
+                      0x20000, 0, tegra210_mixer_get_gain,     \
+                      tegra210_mixer_put_gain),
+
+/* Volume controls for all MIXER inputs */
+static const struct snd_kcontrol_new tegra210_mixer_gain_ctls[] = {
+       GAIN_CTRL(1)
+       GAIN_CTRL(2)
+       GAIN_CTRL(3)
+       GAIN_CTRL(4)
+       GAIN_CTRL(5)
+       GAIN_CTRL(6)
+       GAIN_CTRL(7)
+       GAIN_CTRL(8)
+       GAIN_CTRL(9)
+       GAIN_CTRL(10)
+};
+
+static const struct snd_soc_dapm_widget tegra210_mixer_widgets[] = {
+       SND_SOC_DAPM_AIF_IN("RX1", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX2", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX3", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX4", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX5", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX6", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX7", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX8", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX9", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_IN("RX10", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX1", NULL, 0, TEGRA210_MIXER_TX1_ENABLE, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX2", NULL, 0, TEGRA210_MIXER_TX2_ENABLE, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX3", NULL, 0, TEGRA210_MIXER_TX3_ENABLE, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX4", NULL, 0, TEGRA210_MIXER_TX4_ENABLE, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX5", NULL, 0, TEGRA210_MIXER_TX5_ENABLE, 0, 0),
+       SND_SOC_DAPM_MIXER("Adder1", SND_SOC_NOPM, 1, 0, adder1,
+                          ARRAY_SIZE(adder1)),
+       SND_SOC_DAPM_MIXER("Adder2", SND_SOC_NOPM, 1, 0, adder2,
+                          ARRAY_SIZE(adder2)),
+       SND_SOC_DAPM_MIXER("Adder3", SND_SOC_NOPM, 1, 0, adder3,
+                          ARRAY_SIZE(adder3)),
+       SND_SOC_DAPM_MIXER("Adder4", SND_SOC_NOPM, 1, 0, adder4,
+                          ARRAY_SIZE(adder4)),
+       SND_SOC_DAPM_MIXER("Adder5", SND_SOC_NOPM, 1, 0, adder5,
+                          ARRAY_SIZE(adder5)),
+};
+
+#define RX_ROUTES(id, sname)                                              \
+       { "RX" #id " XBAR-" sname,      NULL,   "RX" #id " XBAR-TX" },     \
+       { "RX" #id "-CIF-" sname,       NULL,   "RX" #id " XBAR-" sname }, \
+       { "RX" #id,                     NULL,   "RX" #id "-CIF-" sname }
+
+#define MIXER_RX_ROUTES(id)            \
+       RX_ROUTES(id, "Playback"),      \
+       RX_ROUTES(id, "Capture")
+
+#define ADDER_ROUTES(id, sname)                                                  \
+       { "Adder" #id,                  "RX1",  "RX1" },                  \
+       { "Adder" #id,                  "RX2",  "RX2" },                  \
+       { "Adder" #id,                  "RX3",  "RX3" },                  \
+       { "Adder" #id,                  "RX4",  "RX4" },                  \
+       { "Adder" #id,                  "RX5",  "RX5" },                  \
+       { "Adder" #id,                  "RX6",  "RX6" },                  \
+       { "Adder" #id,                  "RX7",  "RX7" },                  \
+       { "Adder" #id,                  "RX8",  "RX8" },                  \
+       { "Adder" #id,                  "RX9",  "RX9" },                  \
+       { "Adder" #id,                  "RX10", "RX10" },                 \
+       { "TX" #id,                     NULL,   "Adder" #id },            \
+       { "TX" #id "-CIF-" sname,       NULL,   "TX" #id },               \
+       { "TX" #id " XBAR-" sname,      NULL,   "TX" #id "-CIF-" sname }, \
+       { "TX" #id " XBAR-RX",          NULL,   "TX" #id " XBAR-" sname } \
+
+#define TX_ROUTES(id, sname)           \
+       ADDER_ROUTES(1, sname),         \
+       ADDER_ROUTES(2, sname),         \
+       ADDER_ROUTES(3, sname),         \
+       ADDER_ROUTES(4, sname),         \
+       ADDER_ROUTES(5, sname)
+
+#define MIXER_TX_ROUTES(id)            \
+       TX_ROUTES(id, "Playback"),      \
+       TX_ROUTES(id, "Capture")
+
+static const struct snd_soc_dapm_route tegra210_mixer_routes[] = {
+       /* Input */
+       MIXER_RX_ROUTES(1),
+       MIXER_RX_ROUTES(2),
+       MIXER_RX_ROUTES(3),
+       MIXER_RX_ROUTES(4),
+       MIXER_RX_ROUTES(5),
+       MIXER_RX_ROUTES(6),
+       MIXER_RX_ROUTES(7),
+       MIXER_RX_ROUTES(8),
+       MIXER_RX_ROUTES(9),
+       MIXER_RX_ROUTES(10),
+       /* Output */
+       MIXER_TX_ROUTES(1),
+       MIXER_TX_ROUTES(2),
+       MIXER_TX_ROUTES(3),
+       MIXER_TX_ROUTES(4),
+       MIXER_TX_ROUTES(5),
+};
+
+static const struct snd_soc_component_driver tegra210_mixer_cmpnt = {
+       .dapm_widgets           = tegra210_mixer_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(tegra210_mixer_widgets),
+       .dapm_routes            = tegra210_mixer_routes,
+       .num_dapm_routes        = ARRAY_SIZE(tegra210_mixer_routes),
+       .controls               = tegra210_mixer_gain_ctls,
+       .num_controls           = ARRAY_SIZE(tegra210_mixer_gain_ctls),
+};
+
+static bool tegra210_mixer_wr_reg(struct device *dev,
+                               unsigned int reg)
+{
+       if (reg < TEGRA210_MIXER_RX_LIMIT)
+               reg = MIXER_REG_BASE(reg);
+       else if (reg < TEGRA210_MIXER_TX_LIMIT)
+               reg = MIXER_REG_BASE(reg) + TEGRA210_MIXER_TX1_ENABLE;
+
+       switch (reg) {
+       case TEGRA210_MIXER_RX1_SOFT_RESET:
+       case TEGRA210_MIXER_RX1_CIF_CTRL ... TEGRA210_MIXER_RX1_PEAK_CTRL:
+
+       case TEGRA210_MIXER_TX1_ENABLE:
+       case TEGRA210_MIXER_TX1_SOFT_RESET:
+       case TEGRA210_MIXER_TX1_INT_MASK ... TEGRA210_MIXER_TX1_ADDER_CONFIG:
+
+       case TEGRA210_MIXER_ENABLE ... TEGRA210_MIXER_CG:
+       case TEGRA210_MIXER_GAIN_CFG_RAM_CTRL ... TEGRA210_MIXER_CTRL:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_mixer_rd_reg(struct device *dev,
+                               unsigned int reg)
+{
+       if (reg < TEGRA210_MIXER_RX_LIMIT)
+               reg = MIXER_REG_BASE(reg);
+       else if (reg < TEGRA210_MIXER_TX_LIMIT)
+               reg = MIXER_REG_BASE(reg) + TEGRA210_MIXER_TX1_ENABLE;
+
+       switch (reg) {
+       case TEGRA210_MIXER_RX1_SOFT_RESET ... TEGRA210_MIXER_RX1_SAMPLE_COUNT:
+       case TEGRA210_MIXER_TX1_ENABLE ... TEGRA210_MIXER_TX1_ADDER_CONFIG:
+       case TEGRA210_MIXER_ENABLE ... TEGRA210_MIXER_CTRL:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_mixer_volatile_reg(struct device *dev,
+                               unsigned int reg)
+{
+       if (reg < TEGRA210_MIXER_RX_LIMIT)
+               reg = MIXER_REG_BASE(reg);
+       else if (reg < TEGRA210_MIXER_TX_LIMIT)
+               reg = MIXER_REG_BASE(reg) + TEGRA210_MIXER_TX1_ENABLE;
+
+       switch (reg) {
+       case TEGRA210_MIXER_RX1_SOFT_RESET:
+       case TEGRA210_MIXER_RX1_STATUS:
+
+       case TEGRA210_MIXER_TX1_SOFT_RESET:
+       case TEGRA210_MIXER_TX1_STATUS:
+       case TEGRA210_MIXER_TX1_INT_STATUS:
+       case TEGRA210_MIXER_TX1_INT_SET:
+
+       case TEGRA210_MIXER_SOFT_RESET:
+       case TEGRA210_MIXER_STATUS:
+       case TEGRA210_MIXER_INT_STATUS:
+       case TEGRA210_MIXER_GAIN_CFG_RAM_CTRL:
+       case TEGRA210_MIXER_GAIN_CFG_RAM_DATA:
+       case TEGRA210_MIXER_PEAKM_RAM_CTRL:
+       case TEGRA210_MIXER_PEAKM_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_mixer_precious_reg(struct device *dev,
+                               unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_MIXER_GAIN_CFG_RAM_DATA:
+       case TEGRA210_MIXER_PEAKM_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static const struct regmap_config tegra210_mixer_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA210_MIXER_CTRL,
+       .writeable_reg          = tegra210_mixer_wr_reg,
+       .readable_reg           = tegra210_mixer_rd_reg,
+       .volatile_reg           = tegra210_mixer_volatile_reg,
+       .precious_reg           = tegra210_mixer_precious_reg,
+       .reg_defaults           = tegra210_mixer_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_mixer_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct of_device_id tegra210_mixer_of_match[] = {
+       { .compatible = "nvidia,tegra210-amixer" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tegra210_mixer_of_match);
+
+static int tegra210_mixer_platform_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tegra210_mixer *mixer;
+       void __iomem *regs;
+       int err, i;
+
+       mixer = devm_kzalloc(dev, sizeof(*mixer), GFP_KERNEL);
+       if (!mixer)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, mixer);
+
+       /* Use default gain value for all MIXER inputs */
+       for (i = 0; i < TEGRA210_MIXER_RX_MAX; i++)
+               mixer->gain_value[i] = gain_params.gain_value;
+
+       regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(regs))
+               return PTR_ERR(regs);
+
+       mixer->regmap = devm_regmap_init_mmio(dev, regs,
+                                             &tegra210_mixer_regmap_config);
+       if (IS_ERR(mixer->regmap)) {
+               dev_err(dev, "regmap init failed\n");
+               return PTR_ERR(mixer->regmap);
+       }
+
+       regcache_cache_only(mixer->regmap, true);
+
+       err = devm_snd_soc_register_component(dev, &tegra210_mixer_cmpnt,
+                                             tegra210_mixer_dais,
+                                             ARRAY_SIZE(tegra210_mixer_dais));
+       if (err) {
+               dev_err(dev, "can't register MIXER component, err: %d\n", err);
+               return err;
+       }
+
+       pm_runtime_enable(dev);
+
+       return 0;
+}
+
+static int tegra210_mixer_platform_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static const struct dev_pm_ops tegra210_mixer_pm_ops = {
+       SET_RUNTIME_PM_OPS(tegra210_mixer_runtime_suspend,
+                          tegra210_mixer_runtime_resume, NULL)
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                    pm_runtime_force_resume)
+};
+
+static struct platform_driver tegra210_mixer_driver = {
+       .driver = {
+               .name = "tegra210_mixer",
+               .of_match_table = tegra210_mixer_of_match,
+               .pm = &tegra210_mixer_pm_ops,
+       },
+       .probe = tegra210_mixer_platform_probe,
+       .remove = tegra210_mixer_platform_remove,
+};
+module_platform_driver(tegra210_mixer_driver);
+
+MODULE_AUTHOR("Arun Shamanna Lakshmi <aruns@nvidia.com>");
+MODULE_DESCRIPTION("Tegra210 MIXER ASoC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/tegra/tegra210_mixer.h b/sound/soc/tegra/tegra210_mixer.h
new file mode 100644 (file)
index 0000000..a330530
--- /dev/null
@@ -0,0 +1,100 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * tegra210_mixer.h - Definitions for Tegra210 MIXER driver
+ *
+ * Copyright (c) 2021, NVIDIA CORPORATION.  All rights reserved.
+ *
+ */
+
+#ifndef __TEGRA210_MIXER_H__
+#define __TEGRA210_MIXER_H__
+
+/* XBAR_RX related MIXER offsets */
+#define TEGRA210_MIXER_RX1_SOFT_RESET  0x04
+#define TEGRA210_MIXER_RX1_STATUS      0x10
+#define TEGRA210_MIXER_RX1_CIF_CTRL    0x24
+#define TEGRA210_MIXER_RX1_CTRL                0x28
+#define TEGRA210_MIXER_RX1_PEAK_CTRL   0x2c
+#define TEGRA210_MIXER_RX1_SAMPLE_COUNT        0x30
+
+/* XBAR_TX related MIXER offsets */
+#define TEGRA210_MIXER_TX1_ENABLE      0x280
+#define TEGRA210_MIXER_TX1_SOFT_RESET  0x284
+#define TEGRA210_MIXER_TX1_STATUS      0x290
+#define TEGRA210_MIXER_TX1_INT_STATUS  0x294
+#define TEGRA210_MIXER_TX1_INT_MASK    0x298
+#define TEGRA210_MIXER_TX1_INT_SET     0x29c
+#define TEGRA210_MIXER_TX1_INT_CLEAR   0x2a0
+#define TEGRA210_MIXER_TX1_CIF_CTRL    0x2a4
+#define TEGRA210_MIXER_TX1_ADDER_CONFIG        0x2a8
+
+/* MIXER related offsets */
+#define TEGRA210_MIXER_ENABLE                  0x400
+#define TEGRA210_MIXER_SOFT_RESET              0x404
+#define TEGRA210_MIXER_CG                      0x408
+#define TEGRA210_MIXER_STATUS                  0x410
+#define TEGRA210_MIXER_INT_STATUS              0x414
+#define TEGRA210_MIXER_GAIN_CFG_RAM_CTRL       0x42c
+#define TEGRA210_MIXER_GAIN_CFG_RAM_DATA       0x430
+#define TEGRA210_MIXER_PEAKM_RAM_CTRL          0x434
+#define TEGRA210_MIXER_PEAKM_RAM_DATA          0x438
+#define TEGRA210_MIXER_CTRL                    0x43c
+
+#define TEGRA210_MIXER_TX2_ADDER_CONFIG        (TEGRA210_MIXER_TX1_ADDER_CONFIG + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX3_ADDER_CONFIG        (TEGRA210_MIXER_TX2_ADDER_CONFIG + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX4_ADDER_CONFIG        (TEGRA210_MIXER_TX3_ADDER_CONFIG + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX5_ADDER_CONFIG        (TEGRA210_MIXER_TX4_ADDER_CONFIG + TEGRA210_MIXER_REG_STRIDE)
+
+#define TEGRA210_MIXER_TX2_ENABLE      (TEGRA210_MIXER_TX1_ENABLE + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX3_ENABLE      (TEGRA210_MIXER_TX2_ENABLE + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX4_ENABLE      (TEGRA210_MIXER_TX3_ENABLE + TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX5_ENABLE      (TEGRA210_MIXER_TX4_ENABLE + TEGRA210_MIXER_REG_STRIDE)
+
+/* Fields in TEGRA210_MIXER_ENABLE */
+#define TEGRA210_MIXER_ENABLE_SHIFT    0
+#define TEGRA210_MIXER_ENABLE_MASK     (1 << TEGRA210_MIXER_ENABLE_SHIFT)
+#define TEGRA210_MIXER_EN              (1 << TEGRA210_MIXER_ENABLE_SHIFT)
+
+/* Fields in TEGRA210_MIXER_GAIN_CFG_RAM_CTRL */
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_0             0x0
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_STRIDE                0x10
+
+#define TEGRA210_MIXER_GAIN_CFG_RAM_RW_SHIFT           14
+#define TEGRA210_MIXER_GAIN_CFG_RAM_RW_MASK            (1 << TEGRA210_MIXER_GAIN_CFG_RAM_RW_SHIFT)
+#define TEGRA210_MIXER_GAIN_CFG_RAM_RW_WRITE           (1 << TEGRA210_MIXER_GAIN_CFG_RAM_RW_SHIFT)
+
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN_SHIFT 13
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN_MASK  (1 << TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN_SHIFT)
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN       (1 << TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_INIT_EN_SHIFT)
+
+#define TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN_SHIFT        12
+#define TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN_MASK (1 << TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN_SHIFT)
+#define TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN      (1 << TEGRA210_MIXER_GAIN_CFG_RAM_SEQ_ACCESS_EN_SHIFT)
+
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_SHIFT         0
+#define TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_MASK          (0x1ff << TEGRA210_MIXER_GAIN_CFG_RAM_ADDR_SHIFT)
+
+#define TEGRA210_MIXER_REG_STRIDE      0x40
+#define TEGRA210_MIXER_RX_MAX          10
+#define TEGRA210_MIXER_RX_LIMIT                (TEGRA210_MIXER_RX_MAX * TEGRA210_MIXER_REG_STRIDE)
+#define TEGRA210_MIXER_TX_MAX          5
+#define TEGRA210_MIXER_TX_LIMIT                (TEGRA210_MIXER_RX_LIMIT + (TEGRA210_MIXER_TX_MAX * TEGRA210_MIXER_REG_STRIDE))
+
+#define REG_CFG_DONE_TRIGGER   0xf
+#define VAL_CFG_DONE_TRIGGER   0x1
+
+#define NUM_GAIN_POLY_COEFFS 9
+#define NUM_DURATION_PARMS 4
+
+struct tegra210_mixer_gain_params {
+       int poly_coeff[NUM_GAIN_POLY_COEFFS];
+       int gain_value;
+       int duration[NUM_DURATION_PARMS];
+};
+
+struct tegra210_mixer {
+       int gain_value[TEGRA210_MIXER_RX_MAX];
+       struct regmap *regmap;
+};
+
+#endif
diff --git a/sound/soc/tegra/tegra210_mvc.c b/sound/soc/tegra/tegra210_mvc.c
new file mode 100644 (file)
index 0000000..7b9c700
--- /dev/null
@@ -0,0 +1,645 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// tegra210_mvc.c - Tegra210 MVC driver
+//
+// Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include "tegra210_mvc.h"
+#include "tegra_cif.h"
+
+static const struct reg_default tegra210_mvc_reg_defaults[] = {
+       { TEGRA210_MVC_RX_INT_MASK, 0x00000001},
+       { TEGRA210_MVC_RX_CIF_CTRL, 0x00007700},
+       { TEGRA210_MVC_TX_INT_MASK, 0x00000001},
+       { TEGRA210_MVC_TX_CIF_CTRL, 0x00007700},
+       { TEGRA210_MVC_CG, 0x1},
+       { TEGRA210_MVC_CTRL, TEGRA210_MVC_CTRL_DEFAULT},
+       { TEGRA210_MVC_INIT_VOL, 0x00800000},
+       { TEGRA210_MVC_TARGET_VOL, 0x00800000},
+       { TEGRA210_MVC_DURATION, 0x000012c0},
+       { TEGRA210_MVC_DURATION_INV, 0x0006d3a0},
+       { TEGRA210_MVC_POLY_N1, 0x0000007d},
+       { TEGRA210_MVC_POLY_N2, 0x00000271},
+       { TEGRA210_MVC_PEAK_CTRL, 0x000012c0},
+       { TEGRA210_MVC_CFG_RAM_CTRL, 0x00004000},
+};
+
+static const struct tegra210_mvc_gain_params gain_params = {
+       .poly_coeff = { 23738319, 659403, -3680,
+                       15546680, 2530732, -120985,
+                       12048422, 5527252, -785042 },
+       .poly_n1 = 16,
+       .poly_n2 = 63,
+       .duration = 150,
+       .duration_inv = 14316558,
+};
+
+static int __maybe_unused tegra210_mvc_runtime_suspend(struct device *dev)
+{
+       struct tegra210_mvc *mvc = dev_get_drvdata(dev);
+
+       regmap_read(mvc->regmap, TEGRA210_MVC_CTRL, &(mvc->ctrl_value));
+
+       regcache_cache_only(mvc->regmap, true);
+       regcache_mark_dirty(mvc->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_mvc_runtime_resume(struct device *dev)
+{
+       struct tegra210_mvc *mvc = dev_get_drvdata(dev);
+
+       regcache_cache_only(mvc->regmap, false);
+       regcache_sync(mvc->regmap);
+
+       regmap_write(mvc->regmap, TEGRA210_MVC_CTRL, mvc->ctrl_value);
+       regmap_update_bits(mvc->regmap,
+                          TEGRA210_MVC_SWITCH,
+                          TEGRA210_MVC_VOLUME_SWITCH_MASK,
+                          TEGRA210_MVC_VOLUME_SWITCH_TRIGGER);
+
+       return 0;
+}
+
+static void tegra210_mvc_write_ram(struct regmap *regmap)
+{
+       int i;
+
+       regmap_write(regmap, TEGRA210_MVC_CFG_RAM_CTRL,
+                    TEGRA210_MVC_CFG_RAM_CTRL_SEQ_ACCESS_EN |
+                    TEGRA210_MVC_CFG_RAM_CTRL_ADDR_INIT_EN |
+                    TEGRA210_MVC_CFG_RAM_CTRL_RW_WRITE);
+
+       for (i = 0; i < NUM_GAIN_POLY_COEFFS; i++)
+               regmap_write(regmap, TEGRA210_MVC_CFG_RAM_DATA,
+                            gain_params.poly_coeff[i]);
+}
+
+static void tegra210_mvc_conv_vol(struct tegra210_mvc *mvc, u8 chan, s32 val)
+{
+       /*
+        * Volume control read from mixer control is with
+        * 100x scaling; for CURVE_POLY the reg range
+        * is 0-100 (linear, Q24) and for CURVE_LINEAR
+        * it is -120dB to +40dB (Q8)
+        */
+       if (mvc->curve_type == CURVE_POLY) {
+               if (val > 10000)
+                       val = 10000;
+               mvc->volume[chan] = ((val * (1<<8)) / 100) << 16;
+       } else {
+               val -= 12000;
+               mvc->volume[chan] = (val * (1<<8)) / 100;
+       }
+}
+
+static int tegra210_mvc_get_mute(struct snd_kcontrol *kcontrol,
+                                struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+       u8 mute_mask;
+       u32 val;
+
+       pm_runtime_get_sync(cmpnt->dev);
+       regmap_read(mvc->regmap, TEGRA210_MVC_CTRL, &val);
+       pm_runtime_put(cmpnt->dev);
+
+       mute_mask = (val >>  TEGRA210_MVC_MUTE_SHIFT) &
+               TEGRA210_MUTE_MASK_EN;
+
+       ucontrol->value.integer.value[0] = mute_mask;
+
+       return 0;
+}
+
+static int tegra210_mvc_put_mute(struct snd_kcontrol *kcontrol,
+                                struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+       unsigned int value;
+       u8 mute_mask;
+       int err;
+
+       pm_runtime_get_sync(cmpnt->dev);
+
+       /* Check if VOLUME_SWITCH is triggered */
+       err = regmap_read_poll_timeout(mvc->regmap, TEGRA210_MVC_SWITCH,
+                       value, !(value & TEGRA210_MVC_VOLUME_SWITCH_MASK),
+                       10, 10000);
+       if (err < 0)
+               goto end;
+
+       mute_mask = ucontrol->value.integer.value[0];
+
+       err = regmap_update_bits(mvc->regmap, mc->reg,
+                                TEGRA210_MVC_MUTE_MASK,
+                                mute_mask << TEGRA210_MVC_MUTE_SHIFT);
+       if (err < 0)
+               goto end;
+
+       return 1;
+
+end:
+       pm_runtime_put(cmpnt->dev);
+       return err;
+}
+
+static int tegra210_mvc_get_vol(struct snd_kcontrol *kcontrol,
+                               struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+       u8 chan = (mc->reg - TEGRA210_MVC_TARGET_VOL) / REG_SIZE;
+       s32 val = mvc->volume[chan];
+
+       if (mvc->curve_type == CURVE_POLY) {
+               val = ((val >> 16) * 100) >> 8;
+       } else {
+               val = (val * 100) >> 8;
+               val += 12000;
+       }
+
+       ucontrol->value.integer.value[0] = val;
+
+       return 0;
+}
+
+static int tegra210_mvc_put_vol(struct snd_kcontrol *kcontrol,
+                               struct snd_ctl_elem_value *ucontrol)
+{
+       struct soc_mixer_control *mc =
+               (struct soc_mixer_control *)kcontrol->private_value;
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+       unsigned int reg = mc->reg;
+       unsigned int value;
+       u8 chan;
+       int err;
+
+       pm_runtime_get_sync(cmpnt->dev);
+
+       /* Check if VOLUME_SWITCH is triggered */
+       err = regmap_read_poll_timeout(mvc->regmap, TEGRA210_MVC_SWITCH,
+                       value, !(value & TEGRA210_MVC_VOLUME_SWITCH_MASK),
+                       10, 10000);
+       if (err < 0)
+               goto end;
+
+       chan = (reg - TEGRA210_MVC_TARGET_VOL) / REG_SIZE;
+
+       tegra210_mvc_conv_vol(mvc, chan,
+                             ucontrol->value.integer.value[0]);
+
+       /* Configure init volume same as target volume */
+       regmap_write(mvc->regmap,
+               TEGRA210_MVC_REG_OFFSET(TEGRA210_MVC_INIT_VOL, chan),
+               mvc->volume[chan]);
+
+       regmap_write(mvc->regmap, reg, mvc->volume[chan]);
+
+       regmap_update_bits(mvc->regmap, TEGRA210_MVC_SWITCH,
+                          TEGRA210_MVC_VOLUME_SWITCH_MASK,
+                          TEGRA210_MVC_VOLUME_SWITCH_TRIGGER);
+
+       return 1;
+
+end:
+       pm_runtime_put(cmpnt->dev);
+       return err;
+}
+
+static void tegra210_mvc_reset_vol_settings(struct tegra210_mvc *mvc,
+                                           struct device *dev)
+{
+       int i;
+
+       /* Change volume to default init for new curve type */
+       if (mvc->curve_type == CURVE_POLY) {
+               for (i = 0; i < TEGRA210_MVC_MAX_CHAN_COUNT; i++)
+                       mvc->volume[i] = TEGRA210_MVC_INIT_VOL_DEFAULT_POLY;
+       } else {
+               for (i = 0; i < TEGRA210_MVC_MAX_CHAN_COUNT; i++)
+                       mvc->volume[i] = TEGRA210_MVC_INIT_VOL_DEFAULT_LINEAR;
+       }
+
+       pm_runtime_get_sync(dev);
+
+       /* Program curve type */
+       regmap_update_bits(mvc->regmap, TEGRA210_MVC_CTRL,
+                          TEGRA210_MVC_CURVE_TYPE_MASK,
+                          mvc->curve_type <<
+                          TEGRA210_MVC_CURVE_TYPE_SHIFT);
+
+       /* Init volume for all channels */
+       for (i = 0; i < TEGRA210_MVC_MAX_CHAN_COUNT; i++) {
+               regmap_write(mvc->regmap,
+                       TEGRA210_MVC_REG_OFFSET(TEGRA210_MVC_INIT_VOL, i),
+                       mvc->volume[i]);
+               regmap_write(mvc->regmap,
+                       TEGRA210_MVC_REG_OFFSET(TEGRA210_MVC_TARGET_VOL, i),
+                       mvc->volume[i]);
+       }
+
+       /* Trigger volume switch */
+       regmap_update_bits(mvc->regmap, TEGRA210_MVC_SWITCH,
+                          TEGRA210_MVC_VOLUME_SWITCH_MASK,
+                          TEGRA210_MVC_VOLUME_SWITCH_TRIGGER);
+
+       pm_runtime_put(dev);
+}
+
+static int tegra210_mvc_get_curve_type(struct snd_kcontrol *kcontrol,
+                                      struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+
+       ucontrol->value.integer.value[0] = mvc->curve_type;
+
+       return 0;
+}
+
+static int tegra210_mvc_put_curve_type(struct snd_kcontrol *kcontrol,
+                                      struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_mvc *mvc = snd_soc_component_get_drvdata(cmpnt);
+       int value;
+
+       regmap_read(mvc->regmap, TEGRA210_MVC_ENABLE, &value);
+       if (value & TEGRA210_MVC_EN) {
+               dev_err(cmpnt->dev,
+                       "Curve type can't be set when MVC is running\n");
+               return -EINVAL;
+       }
+
+       if (mvc->curve_type == ucontrol->value.integer.value[0])
+               return 0;
+
+       mvc->curve_type = ucontrol->value.integer.value[0];
+
+       tegra210_mvc_reset_vol_settings(mvc, cmpnt->dev);
+
+       return 1;
+}
+
+static int tegra210_mvc_set_audio_cif(struct tegra210_mvc *mvc,
+                                     struct snd_pcm_hw_params *params,
+                                     unsigned int reg)
+{
+       unsigned int channels, audio_bits;
+       struct tegra_cif_conf cif_conf;
+
+       memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
+
+       channels = params_channels(params);
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               audio_bits = TEGRA_ACIF_BITS_16;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               audio_bits = TEGRA_ACIF_BITS_32;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       cif_conf.audio_ch = channels;
+       cif_conf.client_ch = channels;
+       cif_conf.audio_bits = audio_bits;
+       cif_conf.client_bits = audio_bits;
+
+       tegra_set_cif(mvc->regmap, reg, &cif_conf);
+
+       return 0;
+}
+
+static int tegra210_mvc_hw_params(struct snd_pcm_substream *substream,
+                                 struct snd_pcm_hw_params *params,
+                                 struct snd_soc_dai *dai)
+{
+       struct device *dev = dai->dev;
+       struct tegra210_mvc *mvc = snd_soc_dai_get_drvdata(dai);
+       int err, val;
+
+       /*
+        * Soft Reset: Below performs module soft reset which clears
+        * all FSM logic, flushes flow control of FIFO and resets the
+        * state register. It also brings module back to disabled
+        * state (without flushing the data in the pipe).
+        */
+       regmap_write(mvc->regmap, TEGRA210_MVC_SOFT_RESET, 1);
+
+       err = regmap_read_poll_timeout(mvc->regmap, TEGRA210_MVC_SOFT_RESET,
+                                      val, !val, 10, 10000);
+       if (err < 0) {
+               dev_err(dev, "SW reset failed, err = %d\n", err);
+               return err;
+       }
+
+       /* Set RX CIF */
+       err = tegra210_mvc_set_audio_cif(mvc, params, TEGRA210_MVC_RX_CIF_CTRL);
+       if (err) {
+               dev_err(dev, "Can't set MVC RX CIF: %d\n", err);
+               return err;
+       }
+
+       /* Set TX CIF */
+       err = tegra210_mvc_set_audio_cif(mvc, params, TEGRA210_MVC_TX_CIF_CTRL);
+       if (err) {
+               dev_err(dev, "Can't set MVC TX CIF: %d\n", err);
+               return err;
+       }
+
+       tegra210_mvc_write_ram(mvc->regmap);
+
+       /* Program poly_n1, poly_n2, duration */
+       regmap_write(mvc->regmap, TEGRA210_MVC_POLY_N1, gain_params.poly_n1);
+       regmap_write(mvc->regmap, TEGRA210_MVC_POLY_N2, gain_params.poly_n2);
+       regmap_write(mvc->regmap, TEGRA210_MVC_DURATION, gain_params.duration);
+
+       /* Program duration_inv */
+       regmap_write(mvc->regmap, TEGRA210_MVC_DURATION_INV,
+                    gain_params.duration_inv);
+
+       return 0;
+}
+
+static const struct snd_soc_dai_ops tegra210_mvc_dai_ops = {
+       .hw_params      = tegra210_mvc_hw_params,
+};
+
+static const char * const tegra210_mvc_curve_type_text[] = {
+       "Poly",
+       "Linear",
+};
+
+static const struct soc_enum tegra210_mvc_curve_type_ctrl =
+       SOC_ENUM_SINGLE_EXT(2, tegra210_mvc_curve_type_text);
+
+#define TEGRA210_MVC_VOL_CTRL(chan)                                    \
+       SOC_SINGLE_EXT("Channel" #chan " Volume",                       \
+                      TEGRA210_MVC_REG_OFFSET(TEGRA210_MVC_TARGET_VOL, \
+                                              (chan - 1)),             \
+                      0, 16000, 0, tegra210_mvc_get_vol,               \
+                      tegra210_mvc_put_vol)
+
+static const struct snd_kcontrol_new tegra210_mvc_vol_ctrl[] = {
+       /* Per channel volume control */
+       TEGRA210_MVC_VOL_CTRL(1),
+       TEGRA210_MVC_VOL_CTRL(2),
+       TEGRA210_MVC_VOL_CTRL(3),
+       TEGRA210_MVC_VOL_CTRL(4),
+       TEGRA210_MVC_VOL_CTRL(5),
+       TEGRA210_MVC_VOL_CTRL(6),
+       TEGRA210_MVC_VOL_CTRL(7),
+       TEGRA210_MVC_VOL_CTRL(8),
+
+       /* Per channel mute */
+       SOC_SINGLE_EXT("Per Chan Mute Mask",
+                      TEGRA210_MVC_CTRL, 0, TEGRA210_MUTE_MASK_EN, 0,
+                      tegra210_mvc_get_mute, tegra210_mvc_put_mute),
+
+       SOC_ENUM_EXT("Curve Type", tegra210_mvc_curve_type_ctrl,
+                    tegra210_mvc_get_curve_type, tegra210_mvc_put_curve_type),
+};
+
+static struct snd_soc_dai_driver tegra210_mvc_dais[] = {
+       /* Input */
+       {
+               .name = "MVC-RX-CIF",
+               .playback = {
+                       .stream_name = "RX-CIF-Playback",
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .capture = {
+                       .stream_name = "RX-CIF-Capture",
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+       },
+
+       /* Output */
+       {
+               .name = "MVC-TX-CIF",
+               .playback = {
+                       .stream_name = "TX-CIF-Playback",
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .capture = {
+                       .stream_name = "TX-CIF-Capture",
+                       .channels_min = 1,
+                       .channels_max = 8,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .ops = &tegra210_mvc_dai_ops,
+       }
+};
+
+static const struct snd_soc_dapm_widget tegra210_mvc_widgets[] = {
+       SND_SOC_DAPM_AIF_IN("RX", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_OUT("TX", NULL, 0, TEGRA210_MVC_ENABLE,
+                            TEGRA210_MVC_EN_SHIFT, 0),
+};
+
+#define MVC_ROUTES(sname)                                      \
+       { "RX XBAR-" sname,     NULL,   "XBAR-TX" },            \
+       { "RX-CIF-" sname,      NULL,   "RX XBAR-" sname },     \
+       { "RX",                 NULL,   "RX-CIF-" sname },      \
+       { "TX-CIF-" sname,      NULL,   "TX" },                 \
+       { "TX XBAR-" sname,     NULL,   "TX-CIF-" sname },      \
+       { "XBAR-RX",            NULL,   "TX XBAR-" sname }
+
+static const struct snd_soc_dapm_route tegra210_mvc_routes[] = {
+       { "TX", NULL, "RX" },
+       MVC_ROUTES("Playback"),
+       MVC_ROUTES("Capture"),
+};
+
+static const struct snd_soc_component_driver tegra210_mvc_cmpnt = {
+       .dapm_widgets           = tegra210_mvc_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(tegra210_mvc_widgets),
+       .dapm_routes            = tegra210_mvc_routes,
+       .num_dapm_routes        = ARRAY_SIZE(tegra210_mvc_routes),
+       .controls               = tegra210_mvc_vol_ctrl,
+       .num_controls           = ARRAY_SIZE(tegra210_mvc_vol_ctrl),
+};
+
+static bool tegra210_mvc_rd_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_MVC_RX_STATUS ... TEGRA210_MVC_CONFIG_ERR_TYPE:
+               return true;
+       default:
+               return false;
+       };
+}
+
+static bool tegra210_mvc_wr_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_MVC_RX_INT_MASK ... TEGRA210_MVC_RX_CIF_CTRL:
+       case TEGRA210_MVC_TX_INT_MASK ... TEGRA210_MVC_TX_CIF_CTRL:
+       case TEGRA210_MVC_ENABLE ... TEGRA210_MVC_CG:
+       case TEGRA210_MVC_CTRL ... TEGRA210_MVC_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_mvc_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_MVC_RX_STATUS:
+       case TEGRA210_MVC_RX_INT_STATUS:
+       case TEGRA210_MVC_RX_INT_SET:
+
+       case TEGRA210_MVC_TX_STATUS:
+       case TEGRA210_MVC_TX_INT_STATUS:
+       case TEGRA210_MVC_TX_INT_SET:
+
+       case TEGRA210_MVC_SOFT_RESET:
+       case TEGRA210_MVC_STATUS:
+       case TEGRA210_MVC_INT_STATUS:
+       case TEGRA210_MVC_SWITCH:
+       case TEGRA210_MVC_CFG_RAM_CTRL:
+       case TEGRA210_MVC_CFG_RAM_DATA:
+       case TEGRA210_MVC_PEAK_VALUE:
+       case TEGRA210_MVC_CTRL:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static const struct regmap_config tegra210_mvc_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA210_MVC_CONFIG_ERR_TYPE,
+       .writeable_reg          = tegra210_mvc_wr_reg,
+       .readable_reg           = tegra210_mvc_rd_reg,
+       .volatile_reg           = tegra210_mvc_volatile_reg,
+       .reg_defaults           = tegra210_mvc_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_mvc_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct of_device_id tegra210_mvc_of_match[] = {
+       { .compatible = "nvidia,tegra210-mvc" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tegra210_mvc_of_match);
+
+static int tegra210_mvc_platform_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tegra210_mvc *mvc;
+       void __iomem *regs;
+       int err;
+
+       mvc = devm_kzalloc(dev, sizeof(*mvc), GFP_KERNEL);
+       if (!mvc)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, mvc);
+
+       mvc->curve_type = CURVE_LINEAR;
+       mvc->ctrl_value = TEGRA210_MVC_CTRL_DEFAULT;
+
+       regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(regs))
+               return PTR_ERR(regs);
+
+       mvc->regmap = devm_regmap_init_mmio(dev, regs,
+                                           &tegra210_mvc_regmap_config);
+       if (IS_ERR(mvc->regmap)) {
+               dev_err(dev, "regmap init failed\n");
+               return PTR_ERR(mvc->regmap);
+       }
+
+       regcache_cache_only(mvc->regmap, true);
+
+       err = devm_snd_soc_register_component(dev, &tegra210_mvc_cmpnt,
+                                             tegra210_mvc_dais,
+                                             ARRAY_SIZE(tegra210_mvc_dais));
+       if (err) {
+               dev_err(dev, "can't register MVC component, err: %d\n", err);
+               return err;
+       }
+
+       pm_runtime_enable(dev);
+
+       tegra210_mvc_reset_vol_settings(mvc, &pdev->dev);
+
+       return 0;
+}
+
+static int tegra210_mvc_platform_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static const struct dev_pm_ops tegra210_mvc_pm_ops = {
+       SET_RUNTIME_PM_OPS(tegra210_mvc_runtime_suspend,
+                          tegra210_mvc_runtime_resume, NULL)
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                    pm_runtime_force_resume)
+};
+
+static struct platform_driver tegra210_mvc_driver = {
+       .driver = {
+               .name = "tegra210-mvc",
+               .of_match_table = tegra210_mvc_of_match,
+               .pm = &tegra210_mvc_pm_ops,
+       },
+       .probe = tegra210_mvc_platform_probe,
+       .remove = tegra210_mvc_platform_remove,
+};
+module_platform_driver(tegra210_mvc_driver)
+
+MODULE_AUTHOR("Arun Shamanna Lakshmi <aruns@nvidia.com>");
+MODULE_DESCRIPTION("Tegra210 MVC ASoC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/tegra/tegra210_mvc.h b/sound/soc/tegra/tegra210_mvc.h
new file mode 100644 (file)
index 0000000..def29c4
--- /dev/null
@@ -0,0 +1,117 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * tegra210_mvc.h - Definitions for Tegra210 MVC driver
+ *
+ * Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+ *
+ */
+
+#ifndef __TEGRA210_MVC_H__
+#define __TEGRA210_MVC_H__
+
+/*
+ * MVC_RX registers are with respect to XBAR.
+ * The data comes from XBAR to MVC.
+ */
+#define TEGRA210_MVC_RX_STATUS                 0x0c
+#define TEGRA210_MVC_RX_INT_STATUS             0x10
+#define TEGRA210_MVC_RX_INT_MASK               0x14
+#define TEGRA210_MVC_RX_INT_SET                        0x18
+#define TEGRA210_MVC_RX_INT_CLEAR              0x1c
+#define TEGRA210_MVC_RX_CIF_CTRL               0x20
+
+/*
+ * MVC_TX registers are with respect to XBAR.
+ * The data goes out of MVC.
+ */
+#define TEGRA210_MVC_TX_STATUS                 0x4c
+#define TEGRA210_MVC_TX_INT_STATUS             0x50
+#define TEGRA210_MVC_TX_INT_MASK               0x54
+#define TEGRA210_MVC_TX_INT_SET                        0x58
+#define TEGRA210_MVC_TX_INT_CLEAR              0x5c
+#define TEGRA210_MVC_TX_CIF_CTRL               0x60
+
+/* Register offsets from TEGRA210_MVC*_BASE */
+#define TEGRA210_MVC_ENABLE                    0x80
+#define TEGRA210_MVC_SOFT_RESET                        0x84
+#define TEGRA210_MVC_CG                                0x88
+#define TEGRA210_MVC_STATUS                    0x90
+#define TEGRA210_MVC_INT_STATUS                        0x94
+#define TEGRA210_MVC_CTRL                      0xa8
+#define TEGRA210_MVC_SWITCH                    0xac
+#define TEGRA210_MVC_INIT_VOL                  0xb0
+#define TEGRA210_MVC_TARGET_VOL                        0xd0
+#define TEGRA210_MVC_DURATION                  0xf0
+#define TEGRA210_MVC_DURATION_INV              0xf4
+#define TEGRA210_MVC_POLY_N1                   0xf8
+#define TEGRA210_MVC_POLY_N2                   0xfc
+#define TEGRA210_MVC_PEAK_CTRL                 0x100
+#define TEGRA210_MVC_CFG_RAM_CTRL              0x104
+#define TEGRA210_MVC_CFG_RAM_DATA              0x108
+#define TEGRA210_MVC_PEAK_VALUE                        0x10c
+#define TEGRA210_MVC_CONFIG_ERR_TYPE           0x12c
+
+/* Fields in TEGRA210_MVC_ENABLE */
+#define TEGRA210_MVC_EN_SHIFT                  0
+#define TEGRA210_MVC_EN                                (1 << TEGRA210_MVC_EN_SHIFT)
+
+#define TEGRA210_MVC_MUTE_SHIFT                        8
+#define TEGRA210_MUTE_MASK_EN                  0xff
+#define TEGRA210_MVC_MUTE_MASK                 (TEGRA210_MUTE_MASK_EN << TEGRA210_MVC_MUTE_SHIFT)
+#define TEGRA210_MVC_MUTE_EN                   (TEGRA210_MUTE_MASK_EN << TEGRA210_MVC_MUTE_SHIFT)
+
+#define TEGRA210_MVC_PER_CHAN_CTRL_EN_SHIFT    30
+#define TEGRA210_MVC_PER_CHAN_CTRL_EN_MASK     (1 << TEGRA210_MVC_PER_CHAN_CTRL_EN_SHIFT)
+#define TEGRA210_MVC_PER_CHAN_CTRL_EN          (1 << TEGRA210_MVC_PER_CHAN_CTRL_EN_SHIFT)
+
+#define TEGRA210_MVC_CURVE_TYPE_SHIFT          1
+#define TEGRA210_MVC_CURVE_TYPE_MASK           (1 << TEGRA210_MVC_CURVE_TYPE_SHIFT)
+
+#define TEGRA210_MVC_VOLUME_SWITCH_SHIFT       2
+#define TEGRA210_MVC_VOLUME_SWITCH_MASK                (1 << TEGRA210_MVC_VOLUME_SWITCH_SHIFT)
+#define TEGRA210_MVC_VOLUME_SWITCH_TRIGGER     (1 << TEGRA210_MVC_VOLUME_SWITCH_SHIFT)
+#define TEGRA210_MVC_CTRL_DEFAULT      0x40000003
+
+#define TEGRA210_MVC_INIT_VOL_DEFAULT_POLY     0x01000000
+#define TEGRA210_MVC_INIT_VOL_DEFAULT_LINEAR   0x00000000
+
+/* Fields in TEGRA210_MVC ram ctrl */
+#define TEGRA210_MVC_CFG_RAM_CTRL_RW_SHIFT             14
+#define TEGRA210_MVC_CFG_RAM_CTRL_RW_WRITE             (1 << TEGRA210_MVC_CFG_RAM_CTRL_RW_SHIFT)
+
+#define TEGRA210_MVC_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT   13
+#define TEGRA210_MVC_CFG_RAM_CTRL_ADDR_INIT_EN         (1 << TEGRA210_MVC_CFG_RAM_CTRL_ADDR_INIT_EN_SHIFT)
+
+#define TEGRA210_MVC_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT  12
+#define TEGRA210_MVC_CFG_RAM_CTRL_SEQ_ACCESS_EN                (1 << TEGRA210_MVC_CFG_RAM_CTRL_SEQ_ACCESS_EN_SHIFT)
+
+#define TEGRA210_MVC_CFG_RAM_CTRL_ADDR_SHIFT           0
+#define TEGRA210_MVC_CFG_RAM_CTRL_ADDR_MASK            (0x1ff << TEGRA210_MVC_CFG_RAM_CTRL_ADDR_SHIFT)
+
+#define REG_SIZE 4
+#define TEGRA210_MVC_MAX_CHAN_COUNT 8
+#define TEGRA210_MVC_REG_OFFSET(reg, i) (reg + (REG_SIZE * i))
+
+#define NUM_GAIN_POLY_COEFFS 9
+
+enum {
+       CURVE_POLY,
+       CURVE_LINEAR,
+};
+
+struct tegra210_mvc_gain_params {
+       int poly_coeff[NUM_GAIN_POLY_COEFFS];
+       int poly_n1;
+       int poly_n2;
+       int duration;
+       int duration_inv;
+};
+
+struct tegra210_mvc {
+       int volume[TEGRA210_MVC_MAX_CHAN_COUNT];
+       unsigned int curve_type;
+       unsigned int ctrl_value;
+       struct regmap *regmap;
+};
+
+#endif
diff --git a/sound/soc/tegra/tegra210_sfc.c b/sound/soc/tegra/tegra210_sfc.c
new file mode 100644 (file)
index 0000000..dc477ee
--- /dev/null
@@ -0,0 +1,3549 @@
+// SPDX-License-Identifier: GPL-2.0-only
+//
+// tegra210_sfc.c - Tegra210 SFC driver
+//
+// Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+
+#include <linux/clk.h>
+#include <linux/device.h>
+#include <linux/io.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
+#include <linux/regmap.h>
+#include <sound/core.h>
+#include <sound/pcm.h>
+#include <sound/pcm_params.h>
+#include <sound/soc.h>
+
+#include "tegra210_sfc.h"
+#include "tegra_cif.h"
+
+#define UNSUPP_CONV ((void *)(-EOPNOTSUPP))
+#define BYPASS_CONV NULL
+
+static const struct reg_default tegra210_sfc_reg_defaults[] = {
+       { TEGRA210_SFC_RX_INT_MASK, 0x00000001},
+       { TEGRA210_SFC_RX_CIF_CTRL, 0x00007700},
+       { TEGRA210_SFC_TX_INT_MASK, 0x00000001},
+       { TEGRA210_SFC_TX_CIF_CTRL, 0x00007700},
+       { TEGRA210_SFC_CG, 0x1},
+       { TEGRA210_SFC_CFG_RAM_CTRL, 0x00004000},
+};
+
+static const int tegra210_sfc_rates[TEGRA210_SFC_NUM_RATES] = {
+       8000,
+       11025,
+       16000,
+       22050,
+       24000,
+       32000,
+       44100,
+       48000,
+       88200,
+       96000,
+       176400,
+       192000,
+};
+
+/* coeff RAM tables required for SFC */
+static u32 coef_8to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00235204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000001//output gain
+};
+
+static u32 coef_8to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_8to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00230204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000001//output gain
+};
+
+static u32 coef_8to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0000a105,//header
+       0x000005e1,//input gain
+       0x00dca92f, 0xff45647a, 0x0046b59c,
+       0x00429d1e, 0xff4fec62, 0x00516d30,
+       0xffdea779, 0xff5e08ba, 0x0060185e,
+       0xffafbab2, 0xff698d5a, 0x006ce3ae,
+       0xff9a82d2, 0xff704674, 0x007633c5,
+       0xff923433, 0xff721128, 0x007cff42,
+       0x00000003//output gain
+};
+
+static u32 coef_8to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_8to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0156105,//interpolation + IIR filter
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000002,//ouptut gain
+       0x0021a102,//interpolation + IIR filter
+       0x00000e00,//input gain
+       0x00e2e000, 0xff6e1a00, 0x002aaa00,
+       0x00610a00, 0xff5dda00, 0x003ccc00,
+       0x00163a00, 0xff3c0400, 0x00633200,
+       0x00000003,//Output gain
+       0x00000204,//Farrow filter
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_8to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00156105,//interpolation + IIR Filter
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000002,//ouptut gain
+       0x0000a102,//interpolation + IIR filter
+       0x00000e00,//input gain
+       0x00e2e000, 0xff6e1a00, 0x002aaa00,
+       0x00610a00, 0xff5dda00, 0x003ccc00,
+       0x00163a00, 0xff3c0400, 0x00633200,
+       0x00000003//output gain
+};
+
+static u32 coef_8to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x0024a102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000003,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_8to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x0000a102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000003//output gain
+};
+
+static u32 coef_11to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000002,//output gain
+       0x00239204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_11to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00009204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_11to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_11to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_11to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00009204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_11to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_11to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_11to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002//output gain
+};
+
+static u32 coef_11to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_16to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_16to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000fa103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000003,//output gain
+       0x001a5204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_16to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00235204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000001//output gain
+};
+
+static u32 coef_16to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0015a105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000003,//output gain
+       0x00005105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000001//output gain
+};
+
+static u32 coef_16to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_16to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00156105,//interpolation + IIR filter
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000002,//output gain
+       0x0021a102,//interpolation + IIR filter
+       0x00000e00,//input gain
+       0x00e2e000, 0xff6e1a00, 0x002aaa00,
+       0x00610a00, 0xff5dda00, 0x003ccc00,
+       0x00163a00, 0xff3c0400, 0x00633200,
+       0x00000003,//output gain
+       0x002c0204,//Farrow Filter
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005101,//IIR Filter + Decimator
+       0x0000203c,//input gain
+       0x00f52d35, 0xff2e2162, 0x005a21e0,
+       0x00c6f0f0, 0xff2ecd69, 0x006fa78d,
+       0x00000001//output gain
+};
+
+static u32 coef_16to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0000a105,//interpolation + IIR Filter
+       0x00000784,//input gain
+       0x00cc516e, 0xff2c9639, 0x005ad5b3,
+       0x0013ad0d, 0xff3d4799, 0x0063ce75,
+       0xffb6f398, 0xff5138d1, 0x006e9e1f,
+       0xff9186e5, 0xff5f96a4, 0x0076a86e,
+       0xff82089c, 0xff676b81, 0x007b9f8a,
+       0xff7c48a5, 0xff6a31e7, 0x007ebb7b,
+       0x00000003//output gain
+};
+
+static u32 coef_16to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_16to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0000a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003//output gain
+};
+
+static u32 coef_16to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x0024a102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000003,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_16to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x0000a102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000003//output gain
+};
+
+static u32 coef_22to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000002,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_22to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_22to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000002,//output gain
+       0x00239204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_22to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00235204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d029,//input gain
+       0x00f2a98b, 0xff92aa71, 0x001fcd16,
+       0x00ae9004, 0xffb85140, 0x0041813a,
+       0x007f8ed1, 0xffd585fc, 0x006a69e6,
+       0x00000001//output gain
+};
+
+static u32 coef_22to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00009204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_22to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_22to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_22to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_22to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_22to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002//output gain
+};
+
+static u32 coef_22to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_24to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00009105,//header
+       0x000005e1,//input gain
+       0x00dca92f, 0xff45647a, 0x0046b59c,
+       0x00429d1e, 0xff4fec62, 0x00516d30,
+       0xffdea779, 0xff5e08ba, 0x0060185e,
+       0xffafbab2, 0xff698d5a, 0x006ce3ae,
+       0xff9a82d2, 0xff704674, 0x007633c5,
+       0xff923433, 0xff721128, 0x007cff42,
+       0x00000001//output gain
+};
+
+static u32 coef_24to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000f6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x001a5204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_24to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00156105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000002,//output gain
+       0x00009105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000001//output gain
+};
+
+static u32 coef_24to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d029,//input gain
+       0x00f2a98b, 0xff92aa71, 0x001fcd16,
+       0x00ae9004, 0xffb85140, 0x0041813a,
+       0x007f8ed1, 0xffd585fc, 0x006a69e6,
+       0x00000002,//output gain
+       0x001b6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x00265204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_24to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00009102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_24to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00230204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000001//output gain
+};
+
+static u32 coef_24to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_24to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x002f0204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x00000138,//input gain
+       0x00d5d232, 0xff2a3bf8, 0x005a785c,
+       0x0034001b, 0xff283109, 0x006462a6,
+       0xffe6746a, 0xff1fb09c, 0x00758a91,
+       0x00000001//output gain
+};
+
+static u32 coef_24to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_24to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_24to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002//output gain
+};
+
+static u32 coef_32to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_32to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000ca102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000003,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x0000d102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_32to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_32to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000fa103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000003,//output gain
+       0x001a5204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_32to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000ca102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000003,//output gain
+       0x0000d102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_32to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00235204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000001//output gain
+};
+
+static u32 coef_32to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0015a105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000003,//output gain
+       0x00005105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000001//output gain
+};
+
+static u32 coef_32to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00230204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000001//output gain
+};
+
+static u32 coef_32to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x0000a105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000003//output gain
+};
+
+static u32 coef_32to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0018a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003,//output gain
+       0x00000204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_32to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x0000a102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000003//output gain
+};
+
+static u32 coef_44to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00120104,//IIR Filter
+       0x00000af2,//input gain
+       0x0057eebe, 0xff1e9863, 0x00652604,
+       0xff7206ea, 0xff22ad7e, 0x006d47e1,
+       0xff42a4d7, 0xff26e722, 0x0075fd83,
+       0xff352f66, 0xff29312b, 0x007b986b,
+       0xff310a07, 0xff296f51, 0x007eca7c,
+       0x00000001,//output gain
+       0x001d9204,//Farrow Filter + decimation
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005105,//IIR Filter + Decimator
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000001//output gain
+};
+
+static u32 coef_44to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_44to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00126104,//IIR Filter + interpolation
+       0x00000af2,//input gain
+       0x0057eebe, 0xff1e9863, 0x00652604,
+       0xff7206ea, 0xff22ad7e, 0x006d47e1,
+       0xff42a4d7, 0xff26e722, 0x0075fd83,
+       0xff352f66, 0xff29312b, 0x007b986b,
+       0xff310a07, 0xff296f51, 0x007eca7c,
+       0x00000002,//output gain
+       0x001d9204,//Farrow Filter + decimation
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005105,//IIR Filter + Decimator
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000001//output gain
+};
+
+static u32 coef_44to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_44to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_44to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0000015f,//input gain
+       0x00a7909c, 0xff241c71, 0x005f5e00,
+       0xffca77f4, 0xff20dd50, 0x006855eb,
+       0xff86c552, 0xff18137a, 0x00773648,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000002,//output gain
+       0x00239204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_44to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00235204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d029,//input gain
+       0x00f2a98b, 0xff92aa71, 0x001fcd16,
+       0x00ae9004, 0xffb85140, 0x0041813a,
+       0x007f8ed1, 0xffd585fc, 0x006a69e6,
+       0x00000001//output gain
+};
+
+static u32 coef_44to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_44to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_44to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_44to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_48to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c9102,//IIR Filter + Decimator
+       0x00000e00,//input gain
+       0x00e2e000, 0xff6e1a00, 0x002aaa00,
+       0x00610a00, 0xff5dda00, 0x003ccc00,
+       0x00163a00, 0xff3c0400, 0x00633200,
+       0x00000001,//output gain
+       0x00005105,//IIR Filter + Decimator
+       0x0000d649,//input gain
+       0x00e87afb, 0xff5f69d0, 0x003df3cf,
+       0x007ce488, 0xff99a5c8, 0x0056a6a0,
+       0x00344928, 0xffcba3e5, 0x006be470,
+       0x00137aa7, 0xffe60276, 0x00773410,
+       0x0005fa2a, 0xfff1ac11, 0x007c795b,
+       0x00012d36, 0xfff5eca2, 0x007f10ef,
+       0x00000001//output gain
+};
+
+static u32 coef_48to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_48to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00009105,//IIR Filter + Decimator
+       0x00000784,//input gain
+       0x00cc516e, 0xff2c9639, 0x005ad5b3,
+       0x0013ad0d, 0xff3d4799, 0x0063ce75,
+       0xffb6f398, 0xff5138d1, 0x006e9e1f,
+       0xff9186e5, 0xff5f96a4, 0x0076a86e,
+       0xff82089c, 0xff676b81, 0x007b9f8a,
+       0xff7c48a5, 0xff6a31e7, 0x007ebb7b,
+       0x00000001//output gain
+};
+
+static u32 coef_48to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000f6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x001a5204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_48to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_48to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00156105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000002,//output gain
+       0x00009105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000001//output gain
+};
+
+static u32 coef_48to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d029,//input gain
+       0x00f2a98b, 0xff92aa71, 0x001fcd16,
+       0x00ae9004, 0xffb85140, 0x0041813a,
+       0x007f8ed1, 0xffd585fc, 0x006a69e6,
+       0x00000002,//output gain
+       0x001b6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x00265204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_48to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00230204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000001//output gain
+};
+
+static u32 coef_48to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002//output gain
+};
+
+static u32 coef_48to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00246102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x002f0204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x00000138,//input gain
+       0x00d5d232, 0xff2a3bf8, 0x005a785c,
+       0x0034001b, 0xff283109, 0x006462a6,
+       0xffe6746a, 0xff1fb09c, 0x00758a91,
+       0x00000001//output gain
+};
+
+static u32 coef_48to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000002,//output gain
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_88to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x00000057,//input gain
+       0x00a8e717, 0xff1c748d, 0x0065b976,
+       0xffcbccab, 0xff190aff, 0x006cc1cf,
+       0xff871ce1, 0xff10d878, 0x0078cfc5,
+       0x00000001,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000001,//output gain
+       0x00185102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000001,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000001,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000002,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_88to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_88to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002//output gain
+};
+
+static u32 coef_88to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000002,//output gain
+       0x00186102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_96to8[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c9102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000001,//output gain
+       0x00185102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to11[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000001,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c9102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00009105,//header
+       0x00000292,//input gain
+       0x00e4320a, 0xff41d2d9, 0x004911ac,
+       0x005dd9e3, 0xff4c7d80, 0x0052103e,
+       0xfff8ebef, 0xff5b6fab, 0x005f0a0d,
+       0xffc4b414, 0xff68582c, 0x006b38e5,
+       0xffabb861, 0xff704bec, 0x0074de52,
+       0xffa19f4c, 0xff729059, 0x007c7e90,
+       0x00000001//output gain
+};
+
+static u32 coef_96to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000f6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x001a5204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_96to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000f6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x001a0204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_96to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000f6103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002,//output gain
+       0x001b6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00260204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000001//output gain
+};
+
+static u32 coef_96to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00006103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000002//output gain
+};
+
+static u32 coef_176to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x00000057,//input gain
+       0x00a8e717, 0xff1c748d, 0x0065b976,
+       0xffcbccab, 0xff190aff, 0x006cc1cf,
+       0xff871ce1, 0xff10d878, 0x0078cfc5,
+       0x00000001,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000001,//output gain
+       0x00185102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x00000138,//input gain
+       0x00d5d232, 0xff2a3bf8, 0x005a785c,
+       0x0034001b, 0xff283109, 0x006462a6,
+       0xffe6746a, 0xff1fb09c, 0x00758a91,
+       0x00000001,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x000005f3,//input gain
+       0x00d816d6, 0xff385383, 0x004fe566,
+       0x003c548d, 0xff38c23d, 0x005d0b1c,
+       0xfff02f7d, 0xff31e983, 0x0072d65d,
+       0x00000001,//output gain
+       0x00179204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x00001685,//input gain
+       0x00f53ae9, 0xff52f196, 0x003e3e08,
+       0x00b9f857, 0xff5d8985, 0x0050070a,
+       0x008c3e86, 0xff6053f0, 0x006d98ef,
+       0x00000001,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_176to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_176to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000001//output gain
+};
+
+static u32 coef_176to192[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000002,//output gain
+       0x00005204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000
+};
+
+static u32 coef_192to16[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c9102,//header
+       0x0000007d,//input gain
+       0x007d1f20, 0xff1a540e, 0x00678bf9,
+       0xff916625, 0xff16b0ff, 0x006e433a,
+       0xff5af660, 0xff0eb91f, 0x00797356,
+       0x00000001,//output gain
+       0x00185102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to22[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c0102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000001,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to24[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000001,//output gain
+       0x00185102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to32[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c9102,//header
+       0x000005d6,//input gain
+       0x00c6543e, 0xff342935, 0x0052f116,
+       0x000a1d78, 0xff3330c0, 0x005f88a3,
+       0xffbee7c0, 0xff2b5ba5, 0x0073eb26,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to44[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00235102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to48[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c5102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001,//output gain
+       0x00005102,//header
+       0x0001d727,//input gain
+       0x00fc2fc7, 0xff9bb27b, 0x001c564c,
+       0x00e55557, 0xffcadd5b, 0x003d80ba,
+       0x00d13397, 0xfff232f8, 0x00683337,
+       0x00000001//output gain
+};
+
+static u32 coef_192to88[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00175204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x000013d9,//input gain
+       0x00ebd477, 0xff4ce383, 0x0042049d,
+       0x0089c278, 0xff54414d, 0x00531ded,
+       0x004a5e07, 0xff53cf41, 0x006efbdc,
+       0x00000001//output gain
+};
+
+static u32 coef_192to96[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x00005103,//header
+       0x000001e0,//input gain
+       0x00de44c0, 0xff380b7f, 0x004ffc73,
+       0x00494b44, 0xff3d493a, 0x005908bf,
+       0xffe9a3c8, 0xff425647, 0x006745f7,
+       0xffc42d61, 0xff40a6c7, 0x00776709,
+       0x00000001//output gain
+};
+
+static u32 coef_192to176[TEGRA210_SFC_COEF_RAM_DEPTH] = {
+       0x000c6102,//header
+       0x000000af,//input gain
+       0x00c65663, 0xff23d2ce, 0x005f97d6,
+       0x00086ad6, 0xff20ec4f, 0x00683201,
+       0xffbbbef6, 0xff184447, 0x00770963,
+       0x00000002,//output gain
+       0x00170204,//farrow
+       0x000aaaab,
+       0xffaaaaab,
+       0xfffaaaab,
+       0x00555555,
+       0xff600000,
+       0xfff55555,
+       0x00155555,
+       0x00055555,
+       0xffeaaaab,
+       0x00200000,
+       0x00005102,//header
+       0x0000010a,//input gain
+       0x00c93dc4, 0xff26f5f6, 0x005d1041,
+       0x001002c4, 0xff245b76, 0x00666002,
+       0xffc30a45, 0xff1baecd, 0x00765921,
+       0x00000001//output gain
+};
+
+/*
+ * Coefficient table for various sample rate conversions. The sample
+ * rates available are as per tegra210_sfc_rates[].
+ */
+static s32 *coef_addr_table[TEGRA210_SFC_NUM_RATES][TEGRA210_SFC_NUM_RATES] = {
+       /* Convertions from 8 kHz */
+       {
+               BYPASS_CONV,
+               coef_8to11,
+               coef_8to16,
+               coef_8to22,
+               coef_8to24,
+               coef_8to32,
+               coef_8to44,
+               coef_8to48,
+               coef_8to88,
+               coef_8to96,
+               UNSUPP_CONV,
+               UNSUPP_CONV,
+       },
+       /* Convertions from 11.025 kHz */
+       {
+               coef_11to8,
+               BYPASS_CONV,
+               coef_11to16,
+               coef_11to22,
+               coef_11to24,
+               coef_11to32,
+               coef_11to44,
+               coef_11to48,
+               coef_11to88,
+               coef_11to96,
+               UNSUPP_CONV,
+               UNSUPP_CONV,
+       },
+       /* Convertions from 16 kHz */
+       {
+               coef_16to8,
+               coef_16to11,
+               BYPASS_CONV,
+               coef_16to22,
+               coef_16to24,
+               coef_16to32,
+               coef_16to44,
+               coef_16to48,
+               coef_16to88,
+               coef_16to96,
+               coef_16to176,
+               coef_16to192,
+       },
+       /* Convertions from 22.05 kHz */
+       {
+               coef_22to8,
+               coef_22to11,
+               coef_22to16,
+               BYPASS_CONV,
+               coef_22to24,
+               coef_22to32,
+               coef_22to44,
+               coef_22to48,
+               coef_22to88,
+               coef_22to96,
+               coef_22to176,
+               coef_22to192,
+       },
+       /* Convertions from 24 kHz */
+       {
+               coef_24to8,
+               coef_24to11,
+               coef_24to16,
+               coef_24to22,
+               BYPASS_CONV,
+               coef_24to32,
+               coef_24to44,
+               coef_24to48,
+               coef_24to88,
+               coef_24to96,
+               coef_24to176,
+               coef_24to192,
+       },
+       /* Convertions from 32 kHz */
+       {
+               coef_32to8,
+               coef_32to11,
+               coef_32to16,
+               coef_32to22,
+               coef_32to24,
+               BYPASS_CONV,
+               coef_32to44,
+               coef_32to48,
+               coef_32to88,
+               coef_32to96,
+               coef_32to176,
+               coef_32to192,
+       },
+       /* Convertions from 44.1 kHz */
+       {
+               coef_44to8,
+               coef_44to11,
+               coef_44to16,
+               coef_44to22,
+               coef_44to24,
+               coef_44to32,
+               BYPASS_CONV,
+               coef_44to48,
+               coef_44to88,
+               coef_44to96,
+               coef_44to176,
+               coef_44to192,
+       },
+       /* Convertions from 48 kHz */
+       {
+               coef_48to8,
+               coef_48to11,
+               coef_48to16,
+               coef_48to22,
+               coef_48to24,
+               coef_48to32,
+               coef_48to44,
+               BYPASS_CONV,
+               coef_48to88,
+               coef_48to96,
+               coef_48to176,
+               coef_48to192,
+       },
+       /* Convertions from 88.2 kHz */
+       {
+               coef_88to8,
+               coef_88to11,
+               coef_88to16,
+               coef_88to22,
+               coef_88to24,
+               coef_88to32,
+               coef_88to44,
+               coef_88to48,
+               BYPASS_CONV,
+               coef_88to96,
+               coef_88to176,
+               coef_88to192,
+       },
+       /* Convertions from 96 kHz */
+       {       coef_96to8,
+               coef_96to11,
+               coef_96to16,
+               coef_96to22,
+               coef_96to24,
+               coef_96to32,
+               coef_96to44,
+               coef_96to48,
+               coef_96to88,
+               BYPASS_CONV,
+               coef_96to176,
+               coef_96to192,
+       },
+       /* Convertions from 176.4 kHz */
+       {
+               UNSUPP_CONV,
+               UNSUPP_CONV,
+               coef_176to16,
+               coef_176to22,
+               coef_176to24,
+               coef_176to32,
+               coef_176to44,
+               coef_176to48,
+               coef_176to88,
+               coef_176to96,
+               BYPASS_CONV,
+               coef_176to192,
+       },
+       /* Convertions from 192 kHz */
+       {
+               UNSUPP_CONV,
+               UNSUPP_CONV,
+               coef_192to16,
+               coef_192to22,
+               coef_192to24,
+               coef_192to32,
+               coef_192to44,
+               coef_192to48,
+               coef_192to88,
+               coef_192to96,
+               coef_192to176,
+               BYPASS_CONV,
+       },
+};
+
+static int __maybe_unused tegra210_sfc_runtime_suspend(struct device *dev)
+{
+       struct tegra210_sfc *sfc = dev_get_drvdata(dev);
+
+       regcache_cache_only(sfc->regmap, true);
+       regcache_mark_dirty(sfc->regmap);
+
+       return 0;
+}
+
+static int __maybe_unused tegra210_sfc_runtime_resume(struct device *dev)
+{
+       struct tegra210_sfc *sfc = dev_get_drvdata(dev);
+
+       regcache_cache_only(sfc->regmap, false);
+       regcache_sync(sfc->regmap);
+
+       return 0;
+}
+
+static inline void tegra210_sfc_write_ram(struct regmap *regmap,
+                                         s32 *data)
+{
+       int i;
+
+       regmap_write(regmap, TEGRA210_SFC_CFG_RAM_CTRL,
+                    TEGRA210_SFC_RAM_CTRL_SEQ_ACCESS_EN |
+                    TEGRA210_SFC_RAM_CTRL_ADDR_INIT_EN |
+                    TEGRA210_SFC_RAM_CTRL_RW_WRITE);
+
+       for (i = 0; i < TEGRA210_SFC_COEF_RAM_DEPTH; i++)
+               regmap_write(regmap, TEGRA210_SFC_CFG_RAM_DATA, data[i]);
+}
+
+static int tegra210_sfc_write_coeff_ram(struct snd_soc_component *cmpnt)
+{
+       struct tegra210_sfc *sfc = dev_get_drvdata(cmpnt->dev);
+       s32 *coeff_ram;
+
+       /* Bypass */
+       if (sfc->srate_in == sfc->srate_out)
+               return 0;
+
+       coeff_ram = coef_addr_table[sfc->srate_in][sfc->srate_out];
+       if (IS_ERR_OR_NULL(coeff_ram)) {
+               dev_err(cmpnt->dev,
+                       "Conversion from %d to %d Hz is not supported\n",
+                       sfc->srate_in, sfc->srate_out);
+
+               return PTR_ERR_OR_ZERO(coeff_ram);
+       }
+
+       tegra210_sfc_write_ram(sfc->regmap, coeff_ram);
+
+       regmap_update_bits(sfc->regmap,
+                          TEGRA210_SFC_COEF_RAM,
+                          TEGRA210_SFC_COEF_RAM_EN,
+                          TEGRA210_SFC_COEF_RAM_EN);
+
+       return 0;
+}
+
+static int tegra210_sfc_set_audio_cif(struct tegra210_sfc *sfc,
+                                     struct snd_pcm_hw_params *params,
+                                     unsigned int reg)
+{
+       unsigned int channels, audio_bits, path;
+       struct tegra_cif_conf cif_conf;
+
+       memset(&cif_conf, 0, sizeof(struct tegra_cif_conf));
+
+       channels = params_channels(params);
+
+       switch (params_format(params)) {
+       case SNDRV_PCM_FORMAT_S16_LE:
+               audio_bits = TEGRA_ACIF_BITS_16;
+               break;
+       case SNDRV_PCM_FORMAT_S32_LE:
+               audio_bits = TEGRA_ACIF_BITS_32;
+               break;
+       default:
+               return -EOPNOTSUPP;
+       }
+
+       cif_conf.audio_ch = channels;
+       cif_conf.client_ch = channels;
+       cif_conf.audio_bits = audio_bits;
+       cif_conf.client_bits = TEGRA_ACIF_BITS_32;
+
+       if (reg == TEGRA210_SFC_RX_CIF_CTRL)
+               path = SFC_RX_PATH;
+       else
+               path = SFC_TX_PATH;
+
+       cif_conf.stereo_conv = sfc->stereo_to_mono[path];
+       cif_conf.mono_conv = sfc->mono_to_stereo[path];
+
+       tegra_set_cif(sfc->regmap, reg, &cif_conf);
+
+       return 0;
+}
+
+static int tegra210_sfc_soft_reset(struct tegra210_sfc *sfc)
+{
+       u32 val;
+
+       /*
+        * Soft Reset: Below performs module soft reset which clears
+        * all FSM logic, flushes flow control of FIFO and resets the
+        * state register. It also brings module back to disabled
+        * state (without flushing the data in the pipe).
+        */
+       regmap_update_bits(sfc->regmap, TEGRA210_SFC_SOFT_RESET,
+                          TEGRA210_SFC_SOFT_RESET_EN, 1);
+
+       return regmap_read_poll_timeout(sfc->regmap,
+                                       TEGRA210_SFC_SOFT_RESET,
+                                       val,
+                                       !(val & TEGRA210_SFC_SOFT_RESET_EN),
+                                       10, 10000);
+}
+
+static int tegra210_sfc_rate_to_idx(struct device *dev, int rate,
+                                   int *rate_idx)
+{
+       int i;
+
+       for (i = 0; i < ARRAY_SIZE(tegra210_sfc_rates); i++) {
+               if (rate == tegra210_sfc_rates[i]) {
+                       *rate_idx = i;
+
+                       return 0;
+               }
+       }
+
+       dev_err(dev, "Sample rate %d Hz is not supported\n", rate);
+
+       return -EOPNOTSUPP;
+}
+
+static int tegra210_sfc_startup(struct snd_pcm_substream *substream,
+                               struct snd_soc_dai *dai)
+{
+       struct tegra210_sfc *sfc = snd_soc_dai_get_drvdata(dai);
+       int err;
+
+       regmap_update_bits(sfc->regmap, TEGRA210_SFC_COEF_RAM,
+                          TEGRA210_SFC_COEF_RAM_EN, 0);
+
+       err = tegra210_sfc_soft_reset(sfc);
+       if (err < 0) {
+               dev_err(dai->dev, "Failed to reset SFC in %s, err = %d\n",
+                       __func__, err);
+
+               return err;
+       }
+
+       return 0;
+}
+
+static int tegra210_sfc_in_hw_params(struct snd_pcm_substream *substream,
+                                    struct snd_pcm_hw_params *params,
+                                    struct snd_soc_dai *dai)
+{
+       struct tegra210_sfc *sfc = snd_soc_dai_get_drvdata(dai);
+       struct device *dev = dai->dev;
+       int err;
+
+       err = tegra210_sfc_rate_to_idx(dev, params_rate(params),
+                                      &sfc->srate_in);
+       if (err < 0)
+               return err;
+
+       err = tegra210_sfc_set_audio_cif(sfc, params, TEGRA210_SFC_RX_CIF_CTRL);
+       if (err < 0) {
+               dev_err(dev, "Can't set SFC RX CIF: %d\n", err);
+               return err;
+       }
+
+       regmap_write(sfc->regmap, TEGRA210_SFC_RX_FREQ, sfc->srate_in);
+
+       return err;
+}
+
+static int tegra210_sfc_out_hw_params(struct snd_pcm_substream *substream,
+                                     struct snd_pcm_hw_params *params,
+                                     struct snd_soc_dai *dai)
+{
+       struct tegra210_sfc *sfc = snd_soc_dai_get_drvdata(dai);
+       struct device *dev = dai->dev;
+       int err;
+
+       err = tegra210_sfc_rate_to_idx(dev, params_rate(params),
+                                      &sfc->srate_out);
+       if (err < 0)
+               return err;
+
+       err = tegra210_sfc_set_audio_cif(sfc, params, TEGRA210_SFC_TX_CIF_CTRL);
+       if (err < 0) {
+               dev_err(dev, "Can't set SFC TX CIF: %d\n", err);
+               return err;
+       }
+
+       regmap_write(sfc->regmap, TEGRA210_SFC_TX_FREQ, sfc->srate_out);
+
+       return 0;
+}
+
+static int tegra210_sfc_init(struct snd_soc_dapm_widget *w,
+                            struct snd_kcontrol *kcontrol, int event)
+{
+       struct snd_soc_component *cmpnt = snd_soc_dapm_to_component(w->dapm);
+
+       return tegra210_sfc_write_coeff_ram(cmpnt);
+}
+
+static int tegra210_sfc_get_control(struct snd_kcontrol *kcontrol,
+                                   struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_sfc *sfc = snd_soc_component_get_drvdata(cmpnt);
+
+       if (strstr(kcontrol->id.name, "Input Stereo To Mono"))
+               ucontrol->value.integer.value[0] =
+                       sfc->stereo_to_mono[SFC_RX_PATH];
+       else if (strstr(kcontrol->id.name, "Input Mono To Stereo"))
+               ucontrol->value.integer.value[0] =
+                       sfc->mono_to_stereo[SFC_RX_PATH];
+       else if (strstr(kcontrol->id.name, "Output Stereo To Mono"))
+               ucontrol->value.integer.value[0] =
+                       sfc->stereo_to_mono[SFC_TX_PATH];
+       else if (strstr(kcontrol->id.name, "Output Mono To Stereo"))
+               ucontrol->value.integer.value[0] =
+                       sfc->mono_to_stereo[SFC_TX_PATH];
+
+       return 0;
+}
+
+static int tegra210_sfc_put_control(struct snd_kcontrol *kcontrol,
+                                   struct snd_ctl_elem_value *ucontrol)
+{
+       struct snd_soc_component *cmpnt = snd_soc_kcontrol_component(kcontrol);
+       struct tegra210_sfc *sfc = snd_soc_component_get_drvdata(cmpnt);
+       int value = ucontrol->value.integer.value[0];
+
+       if (strstr(kcontrol->id.name, "Input Stereo To Mono"))
+               sfc->stereo_to_mono[SFC_RX_PATH] = value;
+       else if (strstr(kcontrol->id.name, "Input Mono To Stereo"))
+               sfc->mono_to_stereo[SFC_RX_PATH] = value;
+       else if (strstr(kcontrol->id.name, "Output Stereo To Mono"))
+               sfc->stereo_to_mono[SFC_TX_PATH] = value;
+       else if (strstr(kcontrol->id.name, "Output Mono To Stereo"))
+               sfc->mono_to_stereo[SFC_TX_PATH] = value;
+       else
+               return 0;
+
+       return 1;
+}
+
+static const struct snd_soc_dai_ops tegra210_sfc_in_dai_ops = {
+       .hw_params      = tegra210_sfc_in_hw_params,
+       .startup        = tegra210_sfc_startup,
+};
+
+static const struct snd_soc_dai_ops tegra210_sfc_out_dai_ops = {
+       .hw_params      = tegra210_sfc_out_hw_params,
+};
+
+static struct snd_soc_dai_driver tegra210_sfc_dais[] = {
+       {
+               .name = "SFC-RX-CIF",
+               .playback = {
+                       .stream_name = "RX-CIF-Playback",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .capture = {
+                       .stream_name = "RX-CIF-Capture",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .ops = &tegra210_sfc_in_dai_ops,
+       },
+       {
+               .name = "SFC-TX-CIF",
+               .playback = {
+                       .stream_name = "TX-CIF-Playback",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .capture = {
+                       .stream_name = "TX-CIF-Capture",
+                       .channels_min = 1,
+                       .channels_max = 2,
+                       .rates = SNDRV_PCM_RATE_8000_192000,
+                       .formats = SNDRV_PCM_FMTBIT_S8 |
+                               SNDRV_PCM_FMTBIT_S16_LE |
+                               SNDRV_PCM_FMTBIT_S32_LE,
+               },
+               .ops = &tegra210_sfc_out_dai_ops,
+       },
+};
+
+static const struct snd_soc_dapm_widget tegra210_sfc_widgets[] = {
+       SND_SOC_DAPM_AIF_IN("RX", NULL, 0, SND_SOC_NOPM, 0, 0),
+       SND_SOC_DAPM_AIF_OUT_E("TX", NULL, 0, TEGRA210_SFC_ENABLE,
+                              TEGRA210_SFC_EN_SHIFT, 0,
+                              tegra210_sfc_init, SND_SOC_DAPM_PRE_PMU),
+};
+
+#define RESAMPLE_ROUTE(sname)                                  \
+       { "RX XBAR-" sname,     NULL,   "XBAR-TX" },            \
+       { "RX-CIF-" sname,      NULL,   "RX XBAR-" sname },     \
+       { "RX",                 NULL,   "RX-CIF-" sname },      \
+       { "TX-CIF-" sname,      NULL,   "TX" },                 \
+       { "TX XBAR-" sname,     NULL,   "TX-CIF-" sname },      \
+       { "XBAR-RX",            NULL,   "TX XBAR-" sname }
+
+static const struct snd_soc_dapm_route tegra210_sfc_routes[] = {
+       { "TX", NULL, "RX" },
+       RESAMPLE_ROUTE("Playback"),
+       RESAMPLE_ROUTE("Capture"),
+};
+
+static const char * const tegra210_sfc_stereo_conv_text[] = {
+       "CH0", "CH1", "AVG",
+};
+
+static const char * const tegra210_sfc_mono_conv_text[] = {
+       "Zero", "Copy",
+};
+
+static const struct soc_enum tegra210_sfc_stereo_conv_enum =
+       SOC_ENUM_SINGLE(SND_SOC_NOPM, 0,
+                       ARRAY_SIZE(tegra210_sfc_stereo_conv_text),
+                       tegra210_sfc_stereo_conv_text);
+
+static const struct soc_enum tegra210_sfc_mono_conv_enum =
+       SOC_ENUM_SINGLE(SND_SOC_NOPM, 0,
+                       ARRAY_SIZE(tegra210_sfc_mono_conv_text),
+                       tegra210_sfc_mono_conv_text);
+
+static const struct snd_kcontrol_new tegra210_sfc_controls[] = {
+       SOC_ENUM_EXT("Input Stereo To Mono", tegra210_sfc_stereo_conv_enum,
+               tegra210_sfc_get_control, tegra210_sfc_put_control),
+       SOC_ENUM_EXT("Input Mono To Stereo", tegra210_sfc_mono_conv_enum,
+               tegra210_sfc_get_control, tegra210_sfc_put_control),
+       SOC_ENUM_EXT("Output Stereo To Mono", tegra210_sfc_stereo_conv_enum,
+               tegra210_sfc_get_control, tegra210_sfc_put_control),
+       SOC_ENUM_EXT("Output Mono To Stereo", tegra210_sfc_mono_conv_enum,
+               tegra210_sfc_get_control, tegra210_sfc_put_control),
+};
+
+static const struct snd_soc_component_driver tegra210_sfc_cmpnt = {
+       .dapm_widgets           = tegra210_sfc_widgets,
+       .num_dapm_widgets       = ARRAY_SIZE(tegra210_sfc_widgets),
+       .dapm_routes            = tegra210_sfc_routes,
+       .num_dapm_routes        = ARRAY_SIZE(tegra210_sfc_routes),
+       .controls               = tegra210_sfc_controls,
+       .num_controls           = ARRAY_SIZE(tegra210_sfc_controls),
+};
+
+static bool tegra210_sfc_wr_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_SFC_RX_INT_MASK ... TEGRA210_SFC_RX_FREQ:
+       case TEGRA210_SFC_TX_INT_MASK ... TEGRA210_SFC_TX_FREQ:
+       case TEGRA210_SFC_ENABLE ... TEGRA210_SFC_CG:
+       case TEGRA210_SFC_COEF_RAM ... TEGRA210_SFC_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_sfc_rd_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_SFC_RX_STATUS ... TEGRA210_SFC_RX_FREQ:
+       case TEGRA210_SFC_TX_STATUS ... TEGRA210_SFC_TX_FREQ:
+       case TEGRA210_SFC_ENABLE ... TEGRA210_SFC_INT_STATUS:
+       case TEGRA210_SFC_COEF_RAM ... TEGRA210_SFC_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_sfc_volatile_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_SFC_RX_STATUS:
+       case TEGRA210_SFC_RX_INT_STATUS:
+       case TEGRA210_SFC_RX_INT_SET:
+
+       case TEGRA210_SFC_TX_STATUS:
+       case TEGRA210_SFC_TX_INT_STATUS:
+       case TEGRA210_SFC_TX_INT_SET:
+
+       case TEGRA210_SFC_SOFT_RESET:
+       case TEGRA210_SFC_STATUS:
+       case TEGRA210_SFC_INT_STATUS:
+       case TEGRA210_SFC_CFG_RAM_CTRL:
+       case TEGRA210_SFC_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static bool tegra210_sfc_precious_reg(struct device *dev, unsigned int reg)
+{
+       switch (reg) {
+       case TEGRA210_SFC_CFG_RAM_DATA:
+               return true;
+       default:
+               return false;
+       }
+}
+
+static const struct regmap_config tegra210_sfc_regmap_config = {
+       .reg_bits               = 32,
+       .reg_stride             = 4,
+       .val_bits               = 32,
+       .max_register           = TEGRA210_SFC_CFG_RAM_DATA,
+       .writeable_reg          = tegra210_sfc_wr_reg,
+       .readable_reg           = tegra210_sfc_rd_reg,
+       .volatile_reg           = tegra210_sfc_volatile_reg,
+       .precious_reg           = tegra210_sfc_precious_reg,
+       .reg_defaults           = tegra210_sfc_reg_defaults,
+       .num_reg_defaults       = ARRAY_SIZE(tegra210_sfc_reg_defaults),
+       .cache_type             = REGCACHE_FLAT,
+};
+
+static const struct of_device_id tegra210_sfc_of_match[] = {
+       { .compatible = "nvidia,tegra210-sfc" },
+       {},
+};
+MODULE_DEVICE_TABLE(of, tegra210_sfc_of_match);
+
+static int tegra210_sfc_platform_probe(struct platform_device *pdev)
+{
+       struct device *dev = &pdev->dev;
+       struct tegra210_sfc *sfc;
+       void __iomem *regs;
+       int err;
+
+       sfc = devm_kzalloc(dev, sizeof(*sfc), GFP_KERNEL);
+       if (!sfc)
+               return -ENOMEM;
+
+       dev_set_drvdata(dev, sfc);
+
+       regs = devm_platform_ioremap_resource(pdev, 0);
+       if (IS_ERR(regs))
+               return PTR_ERR(regs);
+
+       sfc->regmap = devm_regmap_init_mmio(dev, regs,
+                                           &tegra210_sfc_regmap_config);
+       if (IS_ERR(sfc->regmap)) {
+               dev_err(dev, "regmap init failed\n");
+               return PTR_ERR(sfc->regmap);
+       }
+
+       regcache_cache_only(sfc->regmap, true);
+
+       err = devm_snd_soc_register_component(dev, &tegra210_sfc_cmpnt,
+                                             tegra210_sfc_dais,
+                                             ARRAY_SIZE(tegra210_sfc_dais));
+       if (err) {
+               dev_err(dev, "can't register SFC component, err: %d\n", err);
+               return err;
+       }
+
+       pm_runtime_enable(&pdev->dev);
+
+       return 0;
+}
+
+static int tegra210_sfc_platform_remove(struct platform_device *pdev)
+{
+       pm_runtime_disable(&pdev->dev);
+
+       return 0;
+}
+
+static const struct dev_pm_ops tegra210_sfc_pm_ops = {
+       SET_RUNTIME_PM_OPS(tegra210_sfc_runtime_suspend,
+                          tegra210_sfc_runtime_resume, NULL)
+       SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+                                    pm_runtime_force_resume)
+};
+
+static struct platform_driver tegra210_sfc_driver = {
+       .driver = {
+               .name = "tegra210-sfc",
+               .of_match_table = tegra210_sfc_of_match,
+               .pm = &tegra210_sfc_pm_ops,
+       },
+       .probe = tegra210_sfc_platform_probe,
+       .remove = tegra210_sfc_platform_remove,
+};
+module_platform_driver(tegra210_sfc_driver)
+
+MODULE_AUTHOR("Arun Shamanna Lakshmi <aruns@nvidia.com>");
+MODULE_DESCRIPTION("Tegra210 SFC ASoC driver");
+MODULE_LICENSE("GPL v2");
diff --git a/sound/soc/tegra/tegra210_sfc.h b/sound/soc/tegra/tegra210_sfc.h
new file mode 100644 (file)
index 0000000..5a6b66e
--- /dev/null
@@ -0,0 +1,78 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * tegra210_sfc.h - Definitions for Tegra210 SFC driver
+ *
+ * Copyright (c) 2021 NVIDIA CORPORATION.  All rights reserved.
+ *
+ */
+
+#ifndef __TEGRA210_SFC_H__
+#define __TEGRA210_SFC_H__
+
+/*
+ * SFC_RX registers are with respect to XBAR.
+ * The data comes from XBAR to SFC.
+ */
+#define TEGRA210_SFC_RX_STATUS                 0x0c
+#define TEGRA210_SFC_RX_INT_STATUS             0x10
+#define TEGRA210_SFC_RX_INT_MASK               0x14
+#define TEGRA210_SFC_RX_INT_SET                        0x18
+#define TEGRA210_SFC_RX_INT_CLEAR              0x1c
+#define TEGRA210_SFC_RX_CIF_CTRL               0x20
+#define TEGRA210_SFC_RX_FREQ                   0x24
+
+/*
+ * SFC_TX registers are with respect to XBAR.
+ * The data goes out of SFC.
+ */
+#define TEGRA210_SFC_TX_STATUS                 0x4c
+#define TEGRA210_SFC_TX_INT_STATUS             0x50
+#define TEGRA210_SFC_TX_INT_MASK               0x54
+#define TEGRA210_SFC_TX_INT_SET                        0x58
+#define TEGRA210_SFC_TX_INT_CLEAR              0x5c
+#define TEGRA210_SFC_TX_CIF_CTRL               0x60
+#define TEGRA210_SFC_TX_FREQ                   0x64
+
+/* Register offsets from TEGRA210_SFC*_BASE */
+#define TEGRA210_SFC_ENABLE                    0x80
+#define TEGRA210_SFC_SOFT_RESET                        0x84
+#define TEGRA210_SFC_CG                                0x88
+#define TEGRA210_SFC_STATUS                    0x8c
+#define TEGRA210_SFC_INT_STATUS                        0x90
+#define TEGRA210_SFC_COEF_RAM                  0xbc
+#define TEGRA210_SFC_CFG_RAM_CTRL              0xc0
+#define TEGRA210_SFC_CFG_RAM_DATA              0xc4
+
+/* Fields in TEGRA210_SFC_ENABLE */
+#define TEGRA210_SFC_EN_SHIFT                  0
+#define TEGRA210_SFC_EN                                (1 << TEGRA210_SFC_EN_SHIFT)
+
+#define TEGRA210_SFC_NUM_RATES 12
+
+/* Fields in TEGRA210_SFC_COEF_RAM */
+#define TEGRA210_SFC_COEF_RAM_EN               BIT(0)
+
+#define TEGRA210_SFC_SOFT_RESET_EN              BIT(0)
+
+/* Coefficients */
+#define TEGRA210_SFC_COEF_RAM_DEPTH            64
+#define TEGRA210_SFC_RAM_CTRL_RW_WRITE         (1 << 14)
+#define TEGRA210_SFC_RAM_CTRL_ADDR_INIT_EN     (1 << 13)
+#define TEGRA210_SFC_RAM_CTRL_SEQ_ACCESS_EN    (1 << 12)
+
+
+enum tegra210_sfc_path {
+       SFC_RX_PATH,
+       SFC_TX_PATH,
+       SFC_PATHS,
+};
+
+struct tegra210_sfc {
+       unsigned int mono_to_stereo[SFC_PATHS];
+       unsigned int stereo_to_mono[SFC_PATHS];
+       unsigned int srate_out;
+       unsigned int srate_in;
+       struct regmap *regmap;
+};
+
+#endif
index 7359093..b95438c 100644 (file)
@@ -313,7 +313,7 @@ static int tegra_machine_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops tegra_machine_snd_ops = {
+static const struct snd_soc_ops tegra_machine_snd_ops = {
        .hw_params = tegra_machine_hw_params,
 };
 
@@ -341,9 +341,34 @@ tegra_machine_parse_phandle(struct device *dev, const char *name)
        return np;
 }
 
+static void tegra_machine_unregister_codec(void *pdev)
+{
+       platform_device_unregister(pdev);
+}
+
+static int tegra_machine_register_codec(struct device *dev, const char *name)
+{
+       struct platform_device *pdev;
+       int err;
+
+       if (!name)
+               return 0;
+
+       pdev = platform_device_register_simple(name, -1, NULL, 0);
+       if (IS_ERR(pdev))
+               return PTR_ERR(pdev);
+
+       err = devm_add_action_or_reset(dev, tegra_machine_unregister_codec,
+                                      pdev);
+       if (err)
+               return err;
+
+       return 0;
+}
+
 int tegra_asoc_machine_probe(struct platform_device *pdev)
 {
-       struct device_node *np_codec, *np_i2s;
+       struct device_node *np_codec, *np_i2s, *np_ac97;
        const struct tegra_asoc_data *asoc;
        struct device *dev = &pdev->dev;
        struct tegra_machine *machine;
@@ -404,17 +429,30 @@ int tegra_asoc_machine_probe(struct platform_device *pdev)
                        return err;
        }
 
-       np_codec = tegra_machine_parse_phandle(dev, "nvidia,audio-codec");
-       if (IS_ERR(np_codec))
-               return PTR_ERR(np_codec);
+       if (asoc->set_ac97) {
+               err = tegra_machine_register_codec(dev, asoc->codec_dev_name);
+               if (err)
+                       return err;
+
+               np_ac97 = tegra_machine_parse_phandle(dev, "nvidia,ac97-controller");
+               if (IS_ERR(np_ac97))
+                       return PTR_ERR(np_ac97);
 
-       np_i2s = tegra_machine_parse_phandle(dev, "nvidia,i2s-controller");
-       if (IS_ERR(np_i2s))
-               return PTR_ERR(np_i2s);
+               card->dai_link->cpus->of_node = np_ac97;
+               card->dai_link->platforms->of_node = np_ac97;
+       } else {
+               np_codec = tegra_machine_parse_phandle(dev, "nvidia,audio-codec");
+               if (IS_ERR(np_codec))
+                       return PTR_ERR(np_codec);
 
-       card->dai_link->cpus->of_node = np_i2s;
-       card->dai_link->codecs->of_node = np_codec;
-       card->dai_link->platforms->of_node = np_i2s;
+               np_i2s = tegra_machine_parse_phandle(dev, "nvidia,i2s-controller");
+               if (IS_ERR(np_i2s))
+                       return PTR_ERR(np_i2s);
+
+               card->dai_link->cpus->of_node = np_i2s;
+               card->dai_link->codecs->of_node = np_codec;
+               card->dai_link->platforms->of_node = np_i2s;
+       }
 
        if (asoc->add_common_controls) {
                card->controls = tegra_machine_controls;
@@ -589,6 +627,7 @@ static struct snd_soc_card snd_soc_tegra_wm9712 = {
 static const struct tegra_asoc_data tegra_wm9712_data = {
        .card = &snd_soc_tegra_wm9712,
        .add_common_dapm_widgets = true,
+       .codec_dev_name = "wm9712-codec",
        .set_ac97 = true,
 };
 
@@ -686,6 +725,7 @@ static struct snd_soc_dai_link tegra_tlv320aic23_dai = {
 };
 
 static struct snd_soc_card snd_soc_tegra_trimslice = {
+       .name = "tegra-trimslice",
        .components = "codec:tlv320aic23",
        .dai_link = &tegra_tlv320aic23_dai,
        .num_links = 1,
index 8ee0ec8..d6a8d13 100644 (file)
@@ -13,6 +13,7 @@ struct snd_soc_pcm_runtime;
 
 struct tegra_asoc_data {
        unsigned int (*mclk_rate)(unsigned int srate);
+       const char *codec_dev_name;
        struct snd_soc_card *card;
        unsigned int mclk_id;
        bool hp_jack_gpio_active_low;
index 1d9fe3f..40110e9 100644 (file)
@@ -212,7 +212,7 @@ config SND_SOC_DM365_VOICE_CODEC
          Say Y if you want to add support for SoC On-chip voice codec
 endchoice
 
-config SND_SOC_DM365_VOICE_CODEC_MODULE
+config SND_SOC_DM365_SELECT_VOICE_CODECS
        def_tristate y
        depends on SND_SOC_DM365_VOICE_CODEC && SND_SOC
        select MFD_DAVINCI_VOICECODEC
index b043a00..68d69e3 100644 (file)
@@ -73,7 +73,7 @@ static int evm_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops evm_ops = {
+static const struct snd_soc_ops evm_ops = {
        .startup = evm_startup,
        .shutdown = evm_shutdown,
        .hw_params = evm_hw_params,
index 2e3d1ee..da809c7 100644 (file)
@@ -96,7 +96,7 @@ static int omap_abe_dmic_hw_params(struct snd_pcm_substream *substream,
        return 0;
 }
 
-static struct snd_soc_ops omap_abe_dmic_ops = {
+static const struct snd_soc_ops omap_abe_dmic_ops = {
        .hw_params = omap_abe_dmic_hw_params,
 };
 
index 2c39c7a..3e654e7 100644 (file)
@@ -348,7 +348,7 @@ static int mop500_ab8500_hw_free(struct snd_pcm_substream *substream)
        return 0;
 }
 
-struct snd_soc_ops mop500_ab8500_ops[] = {
+const struct snd_soc_ops mop500_ab8500_ops[] = {
        {
                .hw_params = mop500_ab8500_hw_params,
                .hw_free = mop500_ab8500_hw_free,
index 8138a4e..087ef24 100644 (file)
@@ -11,7 +11,7 @@
 #ifndef MOP500_AB8500_H
 #define MOP500_AB8500_H
 
-extern struct snd_soc_ops mop500_ab8500_ops[];
+extern const struct snd_soc_ops mop500_ab8500_ops[];
 
 int mop500_ab8500_machine_init(struct snd_soc_pcm_runtime *rtd);
 void mop500_ab8500_remove(struct snd_soc_card *card);
diff --git a/tools/arch/x86/include/asm/unistd_32.h b/tools/arch/x86/include/asm/unistd_32.h
deleted file mode 100644 (file)
index 60a89db..0000000
+++ /dev/null
@@ -1,16 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __NR_perf_event_open
-# define __NR_perf_event_open 336
-#endif
-#ifndef __NR_futex
-# define __NR_futex 240
-#endif
-#ifndef __NR_gettid
-# define __NR_gettid 224
-#endif
-#ifndef __NR_getcpu
-# define __NR_getcpu 318
-#endif
-#ifndef __NR_setns
-# define __NR_setns 346
-#endif
diff --git a/tools/arch/x86/include/asm/unistd_64.h b/tools/arch/x86/include/asm/unistd_64.h
deleted file mode 100644 (file)
index 4205ed4..0000000
+++ /dev/null
@@ -1,19 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __NR_userfaultfd
-#define __NR_userfaultfd 282
-#endif
-#ifndef __NR_perf_event_open
-# define __NR_perf_event_open 298
-#endif
-#ifndef __NR_futex
-# define __NR_futex 202
-#endif
-#ifndef __NR_gettid
-# define __NR_gettid 186
-#endif
-#ifndef __NR_getcpu
-# define __NR_getcpu 309
-#endif
-#ifndef __NR_setns
-#define __NR_setns 308
-#endif
diff --git a/tools/arch/x86/include/uapi/asm/unistd_32.h b/tools/arch/x86/include/uapi/asm/unistd_32.h
new file mode 100644 (file)
index 0000000..60a89db
--- /dev/null
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __NR_perf_event_open
+# define __NR_perf_event_open 336
+#endif
+#ifndef __NR_futex
+# define __NR_futex 240
+#endif
+#ifndef __NR_gettid
+# define __NR_gettid 224
+#endif
+#ifndef __NR_getcpu
+# define __NR_getcpu 318
+#endif
+#ifndef __NR_setns
+# define __NR_setns 346
+#endif
diff --git a/tools/arch/x86/include/uapi/asm/unistd_64.h b/tools/arch/x86/include/uapi/asm/unistd_64.h
new file mode 100644 (file)
index 0000000..cb52a3a
--- /dev/null
@@ -0,0 +1,16 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+#ifndef __NR_perf_event_open
+# define __NR_perf_event_open 298
+#endif
+#ifndef __NR_futex
+# define __NR_futex 202
+#endif
+#ifndef __NR_gettid
+# define __NR_gettid 186
+#endif
+#ifndef __NR_getcpu
+# define __NR_getcpu 309
+#endif
+#ifndef __NR_setns
+#define __NR_setns 308
+#endif
index c41f958..7976994 100644 (file)
        ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr)
 
 #define __get_next(t, insn)    \
-       ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); leXX_to_cpu(t, r); })
+       ({ t r; memcpy(&r, insn->next_byte, sizeof(t)); insn->next_byte += sizeof(t); leXX_to_cpu(t, r); })
 
 #define __peek_nbyte_next(t, insn, n)  \
-       ({ t r = *(t*)((insn)->next_byte + n); leXX_to_cpu(t, r); })
+       ({ t r; memcpy(&r, (insn)->next_byte + n, sizeof(t)); leXX_to_cpu(t, r); })
 
 #define get_next(t, insn)      \
        ({ if (unlikely(!validate_next(t, insn, 0))) goto err_out; __get_next(t, insn); })
index 7862f21..f2e506f 100644 (file)
@@ -4,9 +4,8 @@
 
 #include <stdlib.h>
 
-#define __pa(addr)     (addr)
 #define SMP_CACHE_BYTES        0
 #define memblock_alloc(size, align)    malloc(size)
-#define memblock_free(paddr, size)     free(paddr)
+#define memblock_free_ptr(paddr, size) free(paddr)
 
 #endif
index 95c072b..8816f06 100644 (file)
@@ -16,9 +16,9 @@
 # define __fallthrough __attribute__ ((fallthrough))
 #endif
 
-#if GCC_VERSION >= 40300
+#if __has_attribute(__error__)
 # define __compiletime_error(message) __attribute__((error(message)))
-#endif /* GCC_VERSION >= 40300 */
+#endif
 
 /* &a[0] degrades to a pointer: a different type from an array */
 #define __must_be_array(a)     BUILD_BUG_ON_ZERO(__same_type((a), &(a)[0]))
@@ -38,7 +38,3 @@
 #endif
 #define __printf(a, b) __attribute__((format(printf, a, b)))
 #define __scanf(a, b)  __attribute__((format(scanf, a, b)))
-
-#if GCC_VERSION >= 50100
-#define COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW 1
-#endif
index 8712ff7..dcb0c1b 100644 (file)
@@ -5,12 +5,9 @@
 #include <linux/compiler.h>
 
 /*
- * In the fallback code below, we need to compute the minimum and
- * maximum values representable in a given type. These macros may also
- * be useful elsewhere, so we provide them outside the
- * COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW block.
- *
- * It would seem more obvious to do something like
+ * We need to compute the minimum and maximum values representable in a given
+ * type. These macros may also be useful elsewhere. It would seem more obvious
+ * to do something like:
  *
  * #define type_min(T) (T)(is_signed_type(T) ? (T)1 << (8*sizeof(T)-1) : 0)
  * #define type_max(T) (T)(is_signed_type(T) ? ((T)1 << (8*sizeof(T)-1)) - 1 : ~(T)0)
@@ -36,8 +33,6 @@
 #define type_max(T) ((T)((__type_half_max(T) - 1) + __type_half_max(T)))
 #define type_min(T) ((T)((T)-type_max(T)-(T)1))
 
-
-#ifdef COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW
 /*
  * For simplicity and code hygiene, the fallback code below insists on
  * a, b and *d having the same type (similar to the min() and max()
        __builtin_mul_overflow(__a, __b, __d);  \
 })
 
-#else
-
-
-/* Checking for unsigned overflow is relatively easy without causing UB. */
-#define __unsigned_add_overflow(a, b, d) ({    \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = __a + __b;                       \
-       *__d < __a;                             \
-})
-#define __unsigned_sub_overflow(a, b, d) ({    \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = __a - __b;                       \
-       __a < __b;                              \
-})
-/*
- * If one of a or b is a compile-time constant, this avoids a division.
- */
-#define __unsigned_mul_overflow(a, b, d) ({            \
-       typeof(a) __a = (a);                            \
-       typeof(b) __b = (b);                            \
-       typeof(d) __d = (d);                            \
-       (void) (&__a == &__b);                          \
-       (void) (&__a == __d);                           \
-       *__d = __a * __b;                               \
-       __builtin_constant_p(__b) ?                     \
-         __b > 0 && __a > type_max(typeof(__a)) / __b : \
-         __a > 0 && __b > type_max(typeof(__b)) / __a;  \
-})
-
-/*
- * For signed types, detecting overflow is much harder, especially if
- * we want to avoid UB. But the interface of these macros is such that
- * we must provide a result in *d, and in fact we must produce the
- * result promised by gcc's builtins, which is simply the possibly
- * wrapped-around value. Fortunately, we can just formally do the
- * operations in the widest relevant unsigned type (u64) and then
- * truncate the result - gcc is smart enough to generate the same code
- * with and without the (u64) casts.
- */
-
-/*
- * Adding two signed integers can overflow only if they have the same
- * sign, and overflow has happened iff the result has the opposite
- * sign.
- */
-#define __signed_add_overflow(a, b, d) ({      \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = (u64)__a + (u64)__b;             \
-       (((~(__a ^ __b)) & (*__d ^ __a))        \
-               & type_min(typeof(__a))) != 0;  \
-})
-
-/*
- * Subtraction is similar, except that overflow can now happen only
- * when the signs are opposite. In this case, overflow has happened if
- * the result has the opposite sign of a.
- */
-#define __signed_sub_overflow(a, b, d) ({      \
-       typeof(a) __a = (a);                    \
-       typeof(b) __b = (b);                    \
-       typeof(d) __d = (d);                    \
-       (void) (&__a == &__b);                  \
-       (void) (&__a == __d);                   \
-       *__d = (u64)__a - (u64)__b;             \
-       ((((__a ^ __b)) & (*__d ^ __a))         \
-               & type_min(typeof(__a))) != 0;  \
-})
-
-/*
- * Signed multiplication is rather hard. gcc always follows C99, so
- * division is truncated towards 0. This means that we can write the
- * overflow check like this:
- *
- * (a > 0 && (b > MAX/a || b < MIN/a)) ||
- * (a < -1 && (b > MIN/a || b < MAX/a) ||
- * (a == -1 && b == MIN)
- *
- * The redundant casts of -1 are to silence an annoying -Wtype-limits
- * (included in -Wextra) warning: When the type is u8 or u16, the
- * __b_c_e in check_mul_overflow obviously selects
- * __unsigned_mul_overflow, but unfortunately gcc still parses this
- * code and warns about the limited range of __b.
- */
-
-#define __signed_mul_overflow(a, b, d) ({                              \
-       typeof(a) __a = (a);                                            \
-       typeof(b) __b = (b);                                            \
-       typeof(d) __d = (d);                                            \
-       typeof(a) __tmax = type_max(typeof(a));                         \
-       typeof(a) __tmin = type_min(typeof(a));                         \
-       (void) (&__a == &__b);                                          \
-       (void) (&__a == __d);                                           \
-       *__d = (u64)__a * (u64)__b;                                     \
-       (__b > 0   && (__a > __tmax/__b || __a < __tmin/__b)) ||        \
-       (__b < (typeof(__b))-1  && (__a > __tmin/__b || __a < __tmax/__b)) || \
-       (__b == (typeof(__b))-1 && __a == __tmin);                      \
-})
-
-
-#define check_add_overflow(a, b, d)                                    \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_add_overflow(a, b, d),                 \
-                       __unsigned_add_overflow(a, b, d))
-
-#define check_sub_overflow(a, b, d)                                    \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_sub_overflow(a, b, d),                 \
-                       __unsigned_sub_overflow(a, b, d))
-
-#define check_mul_overflow(a, b, d)                                    \
-       __builtin_choose_expr(is_signed_type(typeof(a)),                \
-                       __signed_mul_overflow(a, b, d),                 \
-                       __unsigned_mul_overflow(a, b, d))
-
-
-#endif /* COMPILER_HAS_GENERIC_BUILTIN_OVERFLOW */
-
 /**
  * array_size() - Calculate size of 2-dimensional array.
  *
index 1d84ec9..5859ca0 100644 (file)
@@ -784,6 +784,7 @@ struct snd_rawmidi_status {
 
 #define SNDRV_RAWMIDI_IOCTL_PVERSION   _IOR('W', 0x00, int)
 #define SNDRV_RAWMIDI_IOCTL_INFO       _IOR('W', 0x01, struct snd_rawmidi_info)
+#define SNDRV_RAWMIDI_IOCTL_USER_PVERSION _IOW('W', 0x02, int)
 #define SNDRV_RAWMIDI_IOCTL_PARAMS     _IOWR('W', 0x10, struct snd_rawmidi_params)
 #define SNDRV_RAWMIDI_IOCTL_STATUS     _IOWR('W', 0x20, struct snd_rawmidi_status)
 #define SNDRV_RAWMIDI_IOCTL_DROP       _IOW('W', 0x30, int)
index 88d8825..e4f83c3 100644 (file)
@@ -6894,7 +6894,8 @@ int bpf_object__load_xattr(struct bpf_object_load_attr *attr)
 
        if (obj->gen_loader) {
                /* reset FDs */
-               btf__set_fd(obj->btf, -1);
+               if (obj->btf)
+                       btf__set_fd(obj->btf, -1);
                for (i = 0; i < obj->nr_maps; i++)
                        obj->maps[i].fd = -1;
                if (!err)
index 10911a8..2df880c 100644 (file)
@@ -1649,11 +1649,17 @@ static bool btf_is_non_static(const struct btf_type *t)
 static int find_glob_sym_btf(struct src_obj *obj, Elf64_Sym *sym, const char *sym_name,
                             int *out_btf_sec_id, int *out_btf_id)
 {
-       int i, j, n = btf__get_nr_types(obj->btf), m, btf_id = 0;
+       int i, j, n, m, btf_id = 0;
        const struct btf_type *t;
        const struct btf_var_secinfo *vi;
        const char *name;
 
+       if (!obj->btf) {
+               pr_warn("failed to find BTF info for object '%s'\n", obj->filename);
+               return -EINVAL;
+       }
+
+       n = btf__get_nr_types(obj->btf);
        for (i = 1; i <= n; i++) {
                t = btf__type_by_id(obj->btf, i);
 
index 1fb8b49..ea65531 100644 (file)
@@ -88,6 +88,7 @@ void strset__free(struct strset *set)
 
        hashmap__free(set->strs_hash);
        free(set->strs_data);
+       free(set);
 }
 
 size_t strset__data_size(const struct strset *set)
index d888672..8441e3e 100644 (file)
@@ -43,7 +43,7 @@ void perf_evsel__delete(struct perf_evsel *evsel)
        free(evsel);
 }
 
-#define FD(e, x, y) (*(int *) xyarray__entry(e->fd, x, y))
+#define FD(e, x, y) ((int *) xyarray__entry(e->fd, x, y))
 #define MMAP(e, x, y) (e->mmap ? ((struct perf_mmap *) xyarray__entry(e->mmap, x, y)) : NULL)
 
 int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads)
@@ -54,7 +54,10 @@ int perf_evsel__alloc_fd(struct perf_evsel *evsel, int ncpus, int nthreads)
                int cpu, thread;
                for (cpu = 0; cpu < ncpus; cpu++) {
                        for (thread = 0; thread < nthreads; thread++) {
-                               FD(evsel, cpu, thread) = -1;
+                               int *fd = FD(evsel, cpu, thread);
+
+                               if (fd)
+                                       *fd = -1;
                        }
                }
        }
@@ -80,7 +83,7 @@ sys_perf_event_open(struct perf_event_attr *attr,
 static int get_group_fd(struct perf_evsel *evsel, int cpu, int thread, int *group_fd)
 {
        struct perf_evsel *leader = evsel->leader;
-       int fd;
+       int *fd;
 
        if (evsel == leader) {
                *group_fd = -1;
@@ -95,10 +98,10 @@ static int get_group_fd(struct perf_evsel *evsel, int cpu, int thread, int *grou
                return -ENOTCONN;
 
        fd = FD(leader, cpu, thread);
-       if (fd == -1)
+       if (fd == NULL || *fd == -1)
                return -EBADF;
 
-       *group_fd = fd;
+       *group_fd = *fd;
 
        return 0;
 }
@@ -138,7 +141,11 @@ int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus,
 
        for (cpu = 0; cpu < cpus->nr; cpu++) {
                for (thread = 0; thread < threads->nr; thread++) {
-                       int fd, group_fd;
+                       int fd, group_fd, *evsel_fd;
+
+                       evsel_fd = FD(evsel, cpu, thread);
+                       if (evsel_fd == NULL)
+                               return -EINVAL;
 
                        err = get_group_fd(evsel, cpu, thread, &group_fd);
                        if (err < 0)
@@ -151,7 +158,7 @@ int perf_evsel__open(struct perf_evsel *evsel, struct perf_cpu_map *cpus,
                        if (fd < 0)
                                return -errno;
 
-                       FD(evsel, cpu, thread) = fd;
+                       *evsel_fd = fd;
                }
        }
 
@@ -163,9 +170,12 @@ static void perf_evsel__close_fd_cpu(struct perf_evsel *evsel, int cpu)
        int thread;
 
        for (thread = 0; thread < xyarray__max_y(evsel->fd); ++thread) {
-               if (FD(evsel, cpu, thread) >= 0)
-                       close(FD(evsel, cpu, thread));
-               FD(evsel, cpu, thread) = -1;
+               int *fd = FD(evsel, cpu, thread);
+
+               if (fd && *fd >= 0) {
+                       close(*fd);
+                       *fd = -1;
+               }
        }
 }
 
@@ -209,13 +219,12 @@ void perf_evsel__munmap(struct perf_evsel *evsel)
 
        for (cpu = 0; cpu < xyarray__max_x(evsel->fd); cpu++) {
                for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
-                       int fd = FD(evsel, cpu, thread);
-                       struct perf_mmap *map = MMAP(evsel, cpu, thread);
+                       int *fd = FD(evsel, cpu, thread);
 
-                       if (fd < 0)
+                       if (fd == NULL || *fd < 0)
                                continue;
 
-                       perf_mmap__munmap(map);
+                       perf_mmap__munmap(MMAP(evsel, cpu, thread));
                }
        }
 
@@ -239,15 +248,16 @@ int perf_evsel__mmap(struct perf_evsel *evsel, int pages)
 
        for (cpu = 0; cpu < xyarray__max_x(evsel->fd); cpu++) {
                for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
-                       int fd = FD(evsel, cpu, thread);
-                       struct perf_mmap *map = MMAP(evsel, cpu, thread);
+                       int *fd = FD(evsel, cpu, thread);
+                       struct perf_mmap *map;
 
-                       if (fd < 0)
+                       if (fd == NULL || *fd < 0)
                                continue;
 
+                       map = MMAP(evsel, cpu, thread);
                        perf_mmap__init(map, NULL, false, NULL);
 
-                       ret = perf_mmap__mmap(map, &mp, fd, cpu);
+                       ret = perf_mmap__mmap(map, &mp, *fd, cpu);
                        if (ret) {
                                perf_evsel__munmap(evsel);
                                return ret;
@@ -260,7 +270,9 @@ int perf_evsel__mmap(struct perf_evsel *evsel, int pages)
 
 void *perf_evsel__mmap_base(struct perf_evsel *evsel, int cpu, int thread)
 {
-       if (FD(evsel, cpu, thread) < 0 || MMAP(evsel, cpu, thread) == NULL)
+       int *fd = FD(evsel, cpu, thread);
+
+       if (fd == NULL || *fd < 0 || MMAP(evsel, cpu, thread) == NULL)
                return NULL;
 
        return MMAP(evsel, cpu, thread)->base;
@@ -295,17 +307,18 @@ int perf_evsel__read(struct perf_evsel *evsel, int cpu, int thread,
                     struct perf_counts_values *count)
 {
        size_t size = perf_evsel__read_size(evsel);
+       int *fd = FD(evsel, cpu, thread);
 
        memset(count, 0, sizeof(*count));
 
-       if (FD(evsel, cpu, thread) < 0)
+       if (fd == NULL || *fd < 0)
                return -EINVAL;
 
        if (MMAP(evsel, cpu, thread) &&
            !perf_mmap__read_self(MMAP(evsel, cpu, thread), count))
                return 0;
 
-       if (readn(FD(evsel, cpu, thread), count->values, size) <= 0)
+       if (readn(*fd, count->values, size) <= 0)
                return -errno;
 
        return 0;
@@ -318,8 +331,13 @@ static int perf_evsel__run_ioctl(struct perf_evsel *evsel,
        int thread;
 
        for (thread = 0; thread < xyarray__max_y(evsel->fd); thread++) {
-               int fd = FD(evsel, cpu, thread),
-                   err = ioctl(fd, ioc, arg);
+               int err;
+               int *fd = FD(evsel, cpu, thread);
+
+               if (fd == NULL || *fd < 0)
+                       return -1;
+
+               err = ioctl(*fd, ioc, arg);
 
                if (err)
                        return err;
index c67c833..ce91a58 100644 (file)
@@ -40,7 +40,7 @@ static int test_stat_cpu(void)
                .type   = PERF_TYPE_SOFTWARE,
                .config = PERF_COUNT_SW_TASK_CLOCK,
        };
-       int err, cpu, tmp;
+       int err, idx;
 
        cpus = perf_cpu_map__new(NULL);
        __T("failed to create cpus", cpus);
@@ -70,10 +70,10 @@ static int test_stat_cpu(void)
        perf_evlist__for_each_evsel(evlist, evsel) {
                cpus = perf_evsel__cpus(evsel);
 
-               perf_cpu_map__for_each_cpu(cpu, tmp, cpus) {
+               for (idx = 0; idx < perf_cpu_map__nr(cpus); idx++) {
                        struct perf_counts_values counts = { .val = 0 };
 
-                       perf_evsel__read(evsel, cpu, 0, &counts);
+                       perf_evsel__read(evsel, idx, 0, &counts);
                        __T("failed to read value for evsel", counts.val != 0);
                }
        }
index a184e48..33ae933 100644 (file)
@@ -22,7 +22,7 @@ static int test_stat_cpu(void)
                .type   = PERF_TYPE_SOFTWARE,
                .config = PERF_COUNT_SW_CPU_CLOCK,
        };
-       int err, cpu, tmp;
+       int err, idx;
 
        cpus = perf_cpu_map__new(NULL);
        __T("failed to create cpus", cpus);
@@ -33,10 +33,10 @@ static int test_stat_cpu(void)
        err = perf_evsel__open(evsel, cpus, NULL);
        __T("failed to open evsel", err == 0);
 
-       perf_cpu_map__for_each_cpu(cpu, tmp, cpus) {
+       for (idx = 0; idx < perf_cpu_map__nr(cpus); idx++) {
                struct perf_counts_values counts = { .val = 0 };
 
-               perf_evsel__read(evsel, cpu, 0, &counts);
+               perf_evsel__read(evsel, idx, 0, &counts);
                __T("failed to read value for evsel", counts.val != 0);
        }
 
@@ -148,6 +148,7 @@ static int test_stat_user_read(int event)
        __T("failed to mmap evsel", err == 0);
 
        pc = perf_evsel__mmap_base(evsel, 0, 0);
+       __T("failed to get mmapped address", pc);
 
 #if defined(__i386__) || defined(__x86_64__)
        __T("userspace counter access not supported", pc->cap_user_rdpmc);
index bc82105..0893436 100644 (file)
@@ -684,7 +684,7 @@ static int elf_add_alternative(struct elf *elf,
        sec = find_section_by_name(elf, ".altinstructions");
        if (!sec) {
                sec = elf_create_section(elf, ".altinstructions",
-                                        SHF_ALLOC, size, 0);
+                                        SHF_ALLOC, 0, 0);
 
                if (!sec) {
                        WARN_ELF("elf_create_section");
index e5947fb..06b5c16 100644 (file)
@@ -292,7 +292,7 @@ static int decode_instructions(struct objtool_file *file)
                    !strcmp(sec->name, ".entry.text"))
                        sec->noinstr = true;
 
-               for (offset = 0; offset < sec->len; offset += insn->len) {
+               for (offset = 0; offset < sec->sh.sh_size; offset += insn->len) {
                        insn = malloc(sizeof(*insn));
                        if (!insn) {
                                WARN("malloc failed");
@@ -307,7 +307,7 @@ static int decode_instructions(struct objtool_file *file)
                        insn->offset = offset;
 
                        ret = arch_decode_instruction(file->elf, sec, offset,
-                                                     sec->len - offset,
+                                                     sec->sh.sh_size - offset,
                                                      &insn->len, &insn->type,
                                                      &insn->immediate,
                                                      &insn->stack_ops);
@@ -349,9 +349,9 @@ static struct instruction *find_last_insn(struct objtool_file *file,
 {
        struct instruction *insn = NULL;
        unsigned int offset;
-       unsigned int end = (sec->len > 10) ? sec->len - 10 : 0;
+       unsigned int end = (sec->sh.sh_size > 10) ? sec->sh.sh_size - 10 : 0;
 
-       for (offset = sec->len - 1; offset >= end && !insn; offset--)
+       for (offset = sec->sh.sh_size - 1; offset >= end && !insn; offset--)
                insn = find_insn(file, sec, offset);
 
        return insn;
@@ -389,7 +389,7 @@ static int add_dead_ends(struct objtool_file *file)
                insn = find_insn(file, reloc->sym->sec, reloc->addend);
                if (insn)
                        insn = list_prev_entry(insn, list);
-               else if (reloc->addend == reloc->sym->sec->len) {
+               else if (reloc->addend == reloc->sym->sec->sh.sh_size) {
                        insn = find_last_insn(file, reloc->sym->sec);
                        if (!insn) {
                                WARN("can't find unreachable insn at %s+0x%x",
@@ -424,7 +424,7 @@ reachable:
                insn = find_insn(file, reloc->sym->sec, reloc->addend);
                if (insn)
                        insn = list_prev_entry(insn, list);
-               else if (reloc->addend == reloc->sym->sec->len) {
+               else if (reloc->addend == reloc->sym->sec->sh.sh_size) {
                        insn = find_last_insn(file, reloc->sym->sec);
                        if (!insn) {
                                WARN("can't find reachable insn at %s+0x%x",
@@ -1561,14 +1561,14 @@ static int read_unwind_hints(struct objtool_file *file)
                return -1;
        }
 
-       if (sec->len % sizeof(struct unwind_hint)) {
+       if (sec->sh.sh_size % sizeof(struct unwind_hint)) {
                WARN("struct unwind_hint size mismatch");
                return -1;
        }
 
        file->hints = true;
 
-       for (i = 0; i < sec->len / sizeof(struct unwind_hint); i++) {
+       for (i = 0; i < sec->sh.sh_size / sizeof(struct unwind_hint); i++) {
                hint = (struct unwind_hint *)sec->data->d_buf + i;
 
                reloc = find_reloc_by_dest(file->elf, sec, i * sizeof(*hint));
index 8676c75..fee03b7 100644 (file)
@@ -286,10 +286,9 @@ static int read_sections(struct elf *elf)
                                return -1;
                        }
                }
-               sec->len = sec->sh.sh_size;
 
                if (sec->sh.sh_flags & SHF_EXECINSTR)
-                       elf->text_size += sec->len;
+                       elf->text_size += sec->sh.sh_size;
 
                list_add_tail(&sec->list, &elf->sections);
                elf_hash_add(section, &sec->hash, sec->idx);
@@ -509,6 +508,7 @@ int elf_add_reloc(struct elf *elf, struct section *sec, unsigned long offset,
        list_add_tail(&reloc->list, &sec->reloc->reloc_list);
        elf_hash_add(reloc, &reloc->hash, reloc_hash(reloc));
 
+       sec->reloc->sh.sh_size += sec->reloc->sh.sh_entsize;
        sec->reloc->changed = true;
 
        return 0;
@@ -734,8 +734,8 @@ static int elf_add_string(struct elf *elf, struct section *strtab, char *str)
        data->d_size = strlen(str) + 1;
        data->d_align = 1;
 
-       len = strtab->len;
-       strtab->len += data->d_size;
+       len = strtab->sh.sh_size;
+       strtab->sh.sh_size += data->d_size;
        strtab->changed = true;
 
        return len;
@@ -790,9 +790,9 @@ struct symbol *elf_create_undef_symbol(struct elf *elf, const char *name)
        data->d_align = 1;
        data->d_type = ELF_T_SYM;
 
-       sym->idx = symtab->len / sizeof(sym->sym);
+       sym->idx = symtab->sh.sh_size / sizeof(sym->sym);
 
-       symtab->len += data->d_size;
+       symtab->sh.sh_size += data->d_size;
        symtab->changed = true;
 
        symtab_shndx = find_section_by_name(elf, ".symtab_shndx");
@@ -814,7 +814,7 @@ struct symbol *elf_create_undef_symbol(struct elf *elf, const char *name)
                data->d_align = 4;
                data->d_type = ELF_T_WORD;
 
-               symtab_shndx->len += 4;
+               symtab_shndx->sh.sh_size += 4;
                symtab_shndx->changed = true;
        }
 
@@ -855,7 +855,6 @@ struct section *elf_create_section(struct elf *elf, const char *name,
        }
 
        sec->idx = elf_ndxscn(s);
-       sec->len = size;
        sec->changed = true;
 
        sec->data = elf_newdata(s);
@@ -979,63 +978,63 @@ static struct section *elf_create_reloc_section(struct elf *elf,
        }
 }
 
-static int elf_rebuild_rel_reloc_section(struct section *sec, int nr)
+static int elf_rebuild_rel_reloc_section(struct section *sec)
 {
        struct reloc *reloc;
-       int idx = 0, size;
+       int idx = 0;
        void *buf;
 
        /* Allocate a buffer for relocations */
-       size = nr * sizeof(GElf_Rel);
-       buf = malloc(size);
+       buf = malloc(sec->sh.sh_size);
        if (!buf) {
                perror("malloc");
                return -1;
        }
 
        sec->data->d_buf = buf;
-       sec->data->d_size = size;
+       sec->data->d_size = sec->sh.sh_size;
        sec->data->d_type = ELF_T_REL;
 
-       sec->sh.sh_size = size;
-
        idx = 0;
        list_for_each_entry(reloc, &sec->reloc_list, list) {
                reloc->rel.r_offset = reloc->offset;
                reloc->rel.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type);
-               gelf_update_rel(sec->data, idx, &reloc->rel);
+               if (!gelf_update_rel(sec->data, idx, &reloc->rel)) {
+                       WARN_ELF("gelf_update_rel");
+                       return -1;
+               }
                idx++;
        }
 
        return 0;
 }
 
-static int elf_rebuild_rela_reloc_section(struct section *sec, int nr)
+static int elf_rebuild_rela_reloc_section(struct section *sec)
 {
        struct reloc *reloc;
-       int idx = 0, size;
+       int idx = 0;
        void *buf;
 
        /* Allocate a buffer for relocations with addends */
-       size = nr * sizeof(GElf_Rela);
-       buf = malloc(size);
+       buf = malloc(sec->sh.sh_size);
        if (!buf) {
                perror("malloc");
                return -1;
        }
 
        sec->data->d_buf = buf;
-       sec->data->d_size = size;
+       sec->data->d_size = sec->sh.sh_size;
        sec->data->d_type = ELF_T_RELA;
 
-       sec->sh.sh_size = size;
-
        idx = 0;
        list_for_each_entry(reloc, &sec->reloc_list, list) {
                reloc->rela.r_offset = reloc->offset;
                reloc->rela.r_addend = reloc->addend;
                reloc->rela.r_info = GELF_R_INFO(reloc->sym->idx, reloc->type);
-               gelf_update_rela(sec->data, idx, &reloc->rela);
+               if (!gelf_update_rela(sec->data, idx, &reloc->rela)) {
+                       WARN_ELF("gelf_update_rela");
+                       return -1;
+               }
                idx++;
        }
 
@@ -1044,16 +1043,9 @@ static int elf_rebuild_rela_reloc_section(struct section *sec, int nr)
 
 static int elf_rebuild_reloc_section(struct elf *elf, struct section *sec)
 {
-       struct reloc *reloc;
-       int nr;
-
-       nr = 0;
-       list_for_each_entry(reloc, &sec->reloc_list, list)
-               nr++;
-
        switch (sec->sh.sh_type) {
-       case SHT_REL:  return elf_rebuild_rel_reloc_section(sec, nr);
-       case SHT_RELA: return elf_rebuild_rela_reloc_section(sec, nr);
+       case SHT_REL:  return elf_rebuild_rel_reloc_section(sec);
+       case SHT_RELA: return elf_rebuild_rela_reloc_section(sec);
        default:       return -1;
        }
 }
@@ -1113,12 +1105,6 @@ int elf_write(struct elf *elf)
        /* Update changed relocation sections and section headers: */
        list_for_each_entry(sec, &elf->sections, list) {
                if (sec->changed) {
-                       if (sec->base &&
-                           elf_rebuild_reloc_section(elf, sec)) {
-                               WARN("elf_rebuild_reloc_section");
-                               return -1;
-                       }
-
                        s = elf_getscn(elf->elf, sec->idx);
                        if (!s) {
                                WARN_ELF("elf_getscn");
@@ -1129,6 +1115,12 @@ int elf_write(struct elf *elf)
                                return -1;
                        }
 
+                       if (sec->base &&
+                           elf_rebuild_reloc_section(elf, sec)) {
+                               WARN("elf_rebuild_reloc_section");
+                               return -1;
+                       }
+
                        sec->changed = false;
                        elf->changed = true;
                }
index e343950..075d829 100644 (file)
@@ -38,7 +38,6 @@ struct section {
        Elf_Data *data;
        char *name;
        int idx;
-       unsigned int len;
        bool changed, text, rodata, noinstr;
 };
 
index dc9b7dd..b5865e2 100644 (file)
@@ -204,7 +204,7 @@ int orc_create(struct objtool_file *file)
 
                /* Add a section terminator */
                if (!empty) {
-                       orc_list_add(&orc_list, &null, sec, sec->len);
+                       orc_list_add(&orc_list, &null, sec, sec->sh.sh_size);
                        nr++;
                }
        }
index bc925cf..06c3eac 100644 (file)
@@ -58,6 +58,13 @@ void __weak arch_handle_alternative(unsigned short feature, struct special_alt *
 {
 }
 
+static void reloc_to_sec_off(struct reloc *reloc, struct section **sec,
+                            unsigned long *off)
+{
+       *sec = reloc->sym->sec;
+       *off = reloc->sym->offset + reloc->addend;
+}
+
 static int get_alt_entry(struct elf *elf, struct special_entry *entry,
                         struct section *sec, int idx,
                         struct special_alt *alt)
@@ -91,14 +98,8 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
                WARN_FUNC("can't find orig reloc", sec, offset + entry->orig);
                return -1;
        }
-       if (orig_reloc->sym->type != STT_SECTION) {
-               WARN_FUNC("don't know how to handle non-section reloc symbol %s",
-                          sec, offset + entry->orig, orig_reloc->sym->name);
-               return -1;
-       }
 
-       alt->orig_sec = orig_reloc->sym->sec;
-       alt->orig_off = orig_reloc->addend;
+       reloc_to_sec_off(orig_reloc, &alt->orig_sec, &alt->orig_off);
 
        if (!entry->group || alt->new_len) {
                new_reloc = find_reloc_by_dest(elf, sec, offset + entry->new);
@@ -116,8 +117,7 @@ static int get_alt_entry(struct elf *elf, struct special_entry *entry,
                if (arch_is_retpoline(new_reloc->sym))
                        return 1;
 
-               alt->new_sec = new_reloc->sym->sec;
-               alt->new_off = (unsigned int)new_reloc->addend;
+               reloc_to_sec_off(new_reloc, &alt->new_sec, &alt->new_off);
 
                /* _ASM_EXTABLE_EX hack */
                if (alt->new_off >= 0x7ffffff0)
@@ -159,13 +159,13 @@ int special_get_alts(struct elf *elf, struct list_head *alts)
                if (!sec)
                        continue;
 
-               if (sec->len % entry->size != 0) {
+               if (sec->sh.sh_size % entry->size != 0) {
                        WARN("%s size not a multiple of %d",
                             sec->name, entry->size);
                        return -1;
                }
 
-               nr_entries = sec->len / entry->size;
+               nr_entries = sec->sh.sh_size / entry->size;
 
                for (idx = 0; idx < nr_entries; idx++) {
                        alt = malloc(sizeof(*alt));
index 52152d1..7993635 100644 (file)
@@ -164,7 +164,7 @@ const char unwinding_data[n]: an array of unwinding data, consisting of the EH F
 The EH Frame header follows the Linux Standard Base (LSB) specification as described in the document at https://refspecs.linuxfoundation.org/LSB_1.3.0/gLSB/gLSB/ehframehdr.html
 
 
-The EH Frame follows the LSB specicfication as described in the document at https://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/ehframechpt.html
+The EH Frame follows the LSB specification as described in the document at https://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/ehframechpt.html
 
 
 NOTE: The mapped_size is generally either the same as unwind_data_size (if the unwinding data was mapped in memory by the running process) or zero (if the unwinding data is not mapped by the process). If the unwinding data was not mapped, then only the EH Frame Header will be read, which can be used to specify FP based unwinding for a function which does not have unwinding information.
index de6beed..3b6a2c8 100644 (file)
@@ -261,7 +261,7 @@ COALESCE
 User can specify how to sort offsets for cacheline.
 
 Following fields are available and governs the final
-output fields set for caheline offsets output:
+output fields set for cacheline offsets output:
 
   tid   - coalesced by process TIDs
   pid   - coalesced by process PIDs
index 184ba62..db465fa 100644 (file)
@@ -883,7 +883,7 @@ and "r" can be combined to get calls and returns.
 
 "Transactions" events correspond to the start or end of transactions. The
 'flags' field can be used in perf script to determine whether the event is a
-tranasaction start, commit or abort.
+transaction start, commit or abort.
 
 Note that "instructions", "branches" and "transactions" events depend on code
 flow packets which can be disabled by using the config term "branch=0".  Refer
index 74d7745..1b4d452 100644 (file)
@@ -44,7 +44,7 @@ COMMON OPTIONS
 
 -f::
 --force::
-       Don't complan, do it.
+       Don't complain, do it.
 
 REPORT OPTIONS
 --------------
index 5a1f681..fa4f39d 100644 (file)
@@ -54,7 +54,7 @@ all sched_wakeup events in the system:
 Traces meant to be processed using a script should be recorded with
 the above option: -a to enable system-wide collection.
 
-The format file for the sched_wakep event defines the following fields
+The format file for the sched_wakeup event defines the following fields
 (see /sys/kernel/debug/tracing/events/sched/sched_wakeup/format):
 
 ----
index 0250dc6..cf4b7f4 100644 (file)
@@ -448,7 +448,7 @@ all sched_wakeup events in the system:
 Traces meant to be processed using a script should be recorded with
 the above option: -a to enable system-wide collection.
 
-The format file for the sched_wakep event defines the following fields
+The format file for the sched_wakeup event defines the following fields
 (see /sys/kernel/debug/tracing/events/sched/sched_wakeup/format):
 
 ----
index 4c9310b..7e6fb7c 100644 (file)
@@ -385,7 +385,7 @@ Aggregate counts per physical processor for system-wide mode measurements.
 Print metrics or metricgroups specified in a comma separated list.
 For a group all metrics from the group are added.
 The events from the metrics are automatically measured.
-See perf list output for the possble metrics and metricgroups.
+See perf list output for the possible metrics and metricgroups.
 
 -A::
 --no-aggr::
index c6302df..a15b93f 100644 (file)
@@ -2,7 +2,7 @@ Using TopDown metrics in user space
 -----------------------------------
 
 Intel CPUs (since Sandy Bridge and Silvermont) support a TopDown
-methology to break down CPU pipeline execution into 4 bottlenecks:
+methodology to break down CPU pipeline execution into 4 bottlenecks:
 frontend bound, backend bound, bad speculation, retiring.
 
 For more details on Topdown see [1][5]
index 4461804..14e3e8d 100644 (file)
@@ -143,7 +143,7 @@ FEATURE_CHECK_LDFLAGS-libcrypto = -lcrypto
 ifdef CSINCLUDES
   LIBOPENCSD_CFLAGS := -I$(CSINCLUDES)
 endif
-OPENCSDLIBS := -lopencsd_c_api -lopencsd
+OPENCSDLIBS := -lopencsd_c_api -lopencsd -lstdc++
 ifdef CSLIBS
   LIBOPENCSD_LDFLAGS := -L$(CSLIBS)
 endif
index e04313c..5cd7020 100644 (file)
@@ -802,7 +802,7 @@ endif
 
 $(patsubst perf-%,%.o,$(PROGRAMS)): $(wildcard */*.h)
 
-LIBTRACEEVENT_FLAGS += plugin_dir=$(plugindir_SQ) 'EXTRA_CFLAGS=$(EXTRA_CFLAGS)' 'LDFLAGS=$(LDFLAGS)'
+LIBTRACEEVENT_FLAGS += plugin_dir=$(plugindir_SQ) 'EXTRA_CFLAGS=$(EXTRA_CFLAGS)' 'LDFLAGS=$(filter-out -static,$(LDFLAGS))'
 
 $(LIBTRACEEVENT): FORCE
        $(Q)$(MAKE) -C $(TRACE_EVENT_DIR) $(LIBTRACEEVENT_FLAGS) O=$(OUTPUT) $(OUTPUT)libtraceevent.a
index c7c7ec0..5fc6a2a 100644 (file)
@@ -8,10 +8,10 @@
 #include <linux/coresight-pmu.h>
 #include <linux/zalloc.h>
 
-#include "../../util/auxtrace.h"
-#include "../../util/debug.h"
-#include "../../util/evlist.h"
-#include "../../util/pmu.h"
+#include "../../../util/auxtrace.h"
+#include "../../../util/debug.h"
+#include "../../../util/evlist.h"
+#include "../../../util/pmu.h"
 #include "cs-etm.h"
 #include "arm-spe.h"
 
index 515aae4..293a23b 100644 (file)
 #include <linux/zalloc.h>
 
 #include "cs-etm.h"
-#include "../../util/debug.h"
-#include "../../util/record.h"
-#include "../../util/auxtrace.h"
-#include "../../util/cpumap.h"
-#include "../../util/event.h"
-#include "../../util/evlist.h"
-#include "../../util/evsel.h"
-#include "../../util/perf_api_probe.h"
-#include "../../util/evsel_config.h"
-#include "../../util/pmu.h"
-#include "../../util/cs-etm.h"
+#include "../../../util/debug.h"
+#include "../../../util/record.h"
+#include "../../../util/auxtrace.h"
+#include "../../../util/cpumap.h"
+#include "../../../util/event.h"
+#include "../../../util/evlist.h"
+#include "../../../util/evsel.h"
+#include "../../../util/perf_api_probe.h"
+#include "../../../util/evsel_config.h"
+#include "../../../util/pmu.h"
+#include "../../../util/cs-etm.h"
 #include <internal/lib.h> // page_size
-#include "../../util/session.h"
+#include "../../../util/session.h"
 
 #include <errno.h>
 #include <stdlib.h>
index 2864e2e..2833e10 100644 (file)
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-#include "../../util/perf_regs.h"
+#include "../../../util/perf_regs.h"
 
 const struct sample_reg sample_reg_masks[] = {
        SMPL_REG_END
index bbc297a..b8b23b9 100644 (file)
@@ -10,7 +10,7 @@
 #include <linux/string.h>
 
 #include "arm-spe.h"
-#include "../../util/pmu.h"
+#include "../../../util/pmu.h"
 
 struct perf_event_attr
 *perf_pmu__get_default_config(struct perf_pmu *pmu __maybe_unused)
index 36ba4c6..b7692cb 100644 (file)
@@ -1,8 +1,8 @@
 // SPDX-License-Identifier: GPL-2.0
 #include <elfutils/libdwfl.h>
-#include "../../util/unwind-libdw.h"
-#include "../../util/perf_regs.h"
-#include "../../util/event.h"
+#include "../../../util/unwind-libdw.h"
+#include "../../../util/perf_regs.h"
+#include "../../../util/event.h"
 
 bool libdw__arch_set_initial_registers(Dwfl_Thread *thread, void *arg)
 {
index 3a55022..438906b 100644 (file)
@@ -3,8 +3,8 @@
 #include <errno.h>
 #include <libunwind.h>
 #include "perf_regs.h"
-#include "../../util/unwind.h"
-#include "../../util/debug.h"
+#include "../../../util/unwind.h"
+#include "../../../util/debug.h"
 
 int libunwind__arch_reg_id(int regnum)
 {
index eeafe97..792cd75 100644 (file)
@@ -432,7 +432,7 @@ void iostat_print_metric(struct perf_stat_config *config, struct evsel *evsel,
        u8 die = ((struct iio_root_port *)evsel->priv)->die;
        struct perf_counts_values *count = perf_counts(evsel->counts, die, 0);
 
-       if (count->run && count->ena) {
+       if (count && count->run && count->ena) {
                if (evsel->prev_raw_counts && !out->force_header) {
                        struct perf_counts_values *prev_count =
                                perf_counts(evsel->prev_raw_counts, die, 0);
index 0e824f7..6211d0b 100644 (file)
@@ -368,16 +368,6 @@ static inline int output_type(unsigned int type)
        return OUTPUT_TYPE_OTHER;
 }
 
-static inline unsigned int attr_type(unsigned int type)
-{
-       switch (type) {
-       case OUTPUT_TYPE_SYNTH:
-               return PERF_TYPE_SYNTH;
-       default:
-               return type;
-       }
-}
-
 static bool output_set_by_user(void)
 {
        int j;
@@ -556,6 +546,18 @@ static void set_print_ip_opts(struct perf_event_attr *attr)
                output[type].print_ip_opts |= EVSEL__PRINT_SRCLINE;
 }
 
+static struct evsel *find_first_output_type(struct evlist *evlist,
+                                           unsigned int type)
+{
+       struct evsel *evsel;
+
+       evlist__for_each_entry(evlist, evsel) {
+               if (output_type(evsel->core.attr.type) == (int)type)
+                       return evsel;
+       }
+       return NULL;
+}
+
 /*
  * verify all user requested events exist and the samples
  * have the expected data
@@ -567,7 +569,7 @@ static int perf_session__check_output_opt(struct perf_session *session)
        struct evsel *evsel;
 
        for (j = 0; j < OUTPUT_TYPE_MAX; ++j) {
-               evsel = perf_session__find_first_evtype(session, attr_type(j));
+               evsel = find_first_output_type(session->evlist, j);
 
                /*
                 * even if fields is set to 0 (ie., show nothing) event must
index f6e87b7..f0ecfda 100644 (file)
@@ -2408,6 +2408,8 @@ int cmd_stat(int argc, const char **argv)
                        goto out;
                } else if (verbose)
                        iostat_list(evsel_list, &stat_config);
+               if (iostat_mode == IOSTAT_RUN && !target__has_cpu(&target))
+                       target.system_wide = true;
        }
 
        if (add_default_attributes())
index 84a0ced..f1f2965 100644 (file)
   {
     "EventCode": "0x4e010",
     "EventName": "PM_GCT_NOSLOT_IC_L3MISS",
-    "BriefDescription": "Gct empty for this thread due to icach l3 miss",
+    "BriefDescription": "Gct empty for this thread due to icache l3 miss",
     "PublicDescription": ""
   },
   {
index 6731b3c..7c887d3 100644 (file)
@@ -1285,6 +1285,7 @@ int main(int argc, char *argv[])
        }
 
        free_arch_std_events();
+       free_sys_event_tables();
        free(mapfile);
        return 0;
 
@@ -1306,6 +1307,7 @@ err_close_eventsfp:
                create_empty_mapping(output_file);
 err_out:
        free_arch_std_events();
+       free_sys_event_tables();
        free(mapfile);
        return ret;
 }
index d9e99b3..d8ea6a8 100644 (file)
@@ -68,3 +68,100 @@ fd=10
 type=0
 config=5
 optional=1
+
+# PERF_TYPE_RAW / slots (0x400)
+[event11:base-stat]
+fd=11
+group_fd=-1
+type=4
+config=1024
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-retiring (0x8000)
+[event12:base-stat]
+fd=12
+group_fd=11
+type=4
+config=32768
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-bad-spec (0x8100)
+[event13:base-stat]
+fd=13
+group_fd=11
+type=4
+config=33024
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fe-bound (0x8200)
+[event14:base-stat]
+fd=14
+group_fd=11
+type=4
+config=33280
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-be-bound (0x8300)
+[event15:base-stat]
+fd=15
+group_fd=11
+type=4
+config=33536
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-heavy-ops (0x8400)
+[event16:base-stat]
+fd=16
+group_fd=11
+type=4
+config=33792
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-br-mispredict (0x8500)
+[event17:base-stat]
+fd=17
+group_fd=11
+type=4
+config=34048
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fetch-lat (0x8600)
+[event18:base-stat]
+fd=18
+group_fd=11
+type=4
+config=34304
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-mem-bound (0x8700)
+[event19:base-stat]
+fd=19
+group_fd=11
+type=4
+config=34560
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
index 8b04a05..b656ab9 100644 (file)
@@ -70,12 +70,109 @@ type=0
 config=5
 optional=1
 
+# PERF_TYPE_RAW / slots (0x400)
+[event11:base-stat]
+fd=11
+group_fd=-1
+type=4
+config=1024
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-retiring (0x8000)
+[event12:base-stat]
+fd=12
+group_fd=11
+type=4
+config=32768
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-bad-spec (0x8100)
+[event13:base-stat]
+fd=13
+group_fd=11
+type=4
+config=33024
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fe-bound (0x8200)
+[event14:base-stat]
+fd=14
+group_fd=11
+type=4
+config=33280
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-be-bound (0x8300)
+[event15:base-stat]
+fd=15
+group_fd=11
+type=4
+config=33536
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-heavy-ops (0x8400)
+[event16:base-stat]
+fd=16
+group_fd=11
+type=4
+config=33792
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-br-mispredict (0x8500)
+[event17:base-stat]
+fd=17
+group_fd=11
+type=4
+config=34048
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fetch-lat (0x8600)
+[event18:base-stat]
+fd=18
+group_fd=11
+type=4
+config=34304
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-mem-bound (0x8700)
+[event19:base-stat]
+fd=19
+group_fd=11
+type=4
+config=34560
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
 # PERF_TYPE_HW_CACHE /
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event11:base-stat]
-fd=11
+[event20:base-stat]
+fd=20
 type=3
 config=0
 optional=1
@@ -84,8 +181,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event12:base-stat]
-fd=12
+[event21:base-stat]
+fd=21
 type=3
 config=65536
 optional=1
@@ -94,8 +191,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event13:base-stat]
-fd=13
+[event22:base-stat]
+fd=22
 type=3
 config=2
 optional=1
@@ -104,8 +201,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event14:base-stat]
-fd=14
+[event23:base-stat]
+fd=23
 type=3
 config=65538
 optional=1
index 4fca9f1..9762509 100644 (file)
@@ -70,12 +70,109 @@ type=0
 config=5
 optional=1
 
+# PERF_TYPE_RAW / slots (0x400)
+[event11:base-stat]
+fd=11
+group_fd=-1
+type=4
+config=1024
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-retiring (0x8000)
+[event12:base-stat]
+fd=12
+group_fd=11
+type=4
+config=32768
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-bad-spec (0x8100)
+[event13:base-stat]
+fd=13
+group_fd=11
+type=4
+config=33024
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fe-bound (0x8200)
+[event14:base-stat]
+fd=14
+group_fd=11
+type=4
+config=33280
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-be-bound (0x8300)
+[event15:base-stat]
+fd=15
+group_fd=11
+type=4
+config=33536
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-heavy-ops (0x8400)
+[event16:base-stat]
+fd=16
+group_fd=11
+type=4
+config=33792
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-br-mispredict (0x8500)
+[event17:base-stat]
+fd=17
+group_fd=11
+type=4
+config=34048
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fetch-lat (0x8600)
+[event18:base-stat]
+fd=18
+group_fd=11
+type=4
+config=34304
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-mem-bound (0x8700)
+[event19:base-stat]
+fd=19
+group_fd=11
+type=4
+config=34560
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
 # PERF_TYPE_HW_CACHE /
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event11:base-stat]
-fd=11
+[event20:base-stat]
+fd=20
 type=3
 config=0
 optional=1
@@ -84,8 +181,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event12:base-stat]
-fd=12
+[event21:base-stat]
+fd=21
 type=3
 config=65536
 optional=1
@@ -94,8 +191,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event13:base-stat]
-fd=13
+[event22:base-stat]
+fd=22
 type=3
 config=2
 optional=1
@@ -104,8 +201,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event14:base-stat]
-fd=14
+[event23:base-stat]
+fd=23
 type=3
 config=65538
 optional=1
@@ -114,8 +211,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1I                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event15:base-stat]
-fd=15
+[event24:base-stat]
+fd=24
 type=3
 config=1
 optional=1
@@ -124,8 +221,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1I                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event16:base-stat]
-fd=16
+[event25:base-stat]
+fd=25
 type=3
 config=65537
 optional=1
@@ -134,8 +231,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_DTLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event17:base-stat]
-fd=17
+[event26:base-stat]
+fd=26
 type=3
 config=3
 optional=1
@@ -144,8 +241,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_DTLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event18:base-stat]
-fd=18
+[event27:base-stat]
+fd=27
 type=3
 config=65539
 optional=1
@@ -154,8 +251,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_ITLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event19:base-stat]
-fd=19
+[event28:base-stat]
+fd=28
 type=3
 config=4
 optional=1
@@ -164,8 +261,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_ITLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event20:base-stat]
-fd=20
+[event29:base-stat]
+fd=29
 type=3
 config=65540
 optional=1
index 4bb58e1..d555042 100644 (file)
@@ -70,12 +70,109 @@ type=0
 config=5
 optional=1
 
+# PERF_TYPE_RAW / slots (0x400)
+[event11:base-stat]
+fd=11
+group_fd=-1
+type=4
+config=1024
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-retiring (0x8000)
+[event12:base-stat]
+fd=12
+group_fd=11
+type=4
+config=32768
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-bad-spec (0x8100)
+[event13:base-stat]
+fd=13
+group_fd=11
+type=4
+config=33024
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fe-bound (0x8200)
+[event14:base-stat]
+fd=14
+group_fd=11
+type=4
+config=33280
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-be-bound (0x8300)
+[event15:base-stat]
+fd=15
+group_fd=11
+type=4
+config=33536
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-heavy-ops (0x8400)
+[event16:base-stat]
+fd=16
+group_fd=11
+type=4
+config=33792
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-br-mispredict (0x8500)
+[event17:base-stat]
+fd=17
+group_fd=11
+type=4
+config=34048
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-fetch-lat (0x8600)
+[event18:base-stat]
+fd=18
+group_fd=11
+type=4
+config=34304
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
+# PERF_TYPE_RAW / topdown-mem-bound (0x8700)
+[event19:base-stat]
+fd=19
+group_fd=11
+type=4
+config=34560
+disabled=0
+enable_on_exec=0
+read_format=15
+optional=1
+
 # PERF_TYPE_HW_CACHE /
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event11:base-stat]
-fd=11
+[event20:base-stat]
+fd=20
 type=3
 config=0
 optional=1
@@ -84,8 +181,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event12:base-stat]
-fd=12
+[event21:base-stat]
+fd=21
 type=3
 config=65536
 optional=1
@@ -94,8 +191,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event13:base-stat]
-fd=13
+[event22:base-stat]
+fd=22
 type=3
 config=2
 optional=1
@@ -104,8 +201,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_LL                 <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event14:base-stat]
-fd=14
+[event23:base-stat]
+fd=23
 type=3
 config=65538
 optional=1
@@ -114,8 +211,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1I                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event15:base-stat]
-fd=15
+[event24:base-stat]
+fd=24
 type=3
 config=1
 optional=1
@@ -124,8 +221,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1I                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event16:base-stat]
-fd=16
+[event25:base-stat]
+fd=25
 type=3
 config=65537
 optional=1
@@ -134,8 +231,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_DTLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event17:base-stat]
-fd=17
+[event26:base-stat]
+fd=26
 type=3
 config=3
 optional=1
@@ -144,8 +241,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_DTLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event18:base-stat]
-fd=18
+[event27:base-stat]
+fd=27
 type=3
 config=65539
 optional=1
@@ -154,8 +251,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_ITLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event19:base-stat]
-fd=19
+[event28:base-stat]
+fd=28
 type=3
 config=4
 optional=1
@@ -164,8 +261,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_ITLB               <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_READ            <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event20:base-stat]
-fd=20
+[event29:base-stat]
+fd=29
 type=3
 config=65540
 optional=1
@@ -174,8 +271,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_PREFETCH        <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_ACCESS      << 16)
-[event21:base-stat]
-fd=21
+[event30:base-stat]
+fd=30
 type=3
 config=512
 optional=1
@@ -184,8 +281,8 @@ optional=1
 #  PERF_COUNT_HW_CACHE_L1D                <<  0  |
 # (PERF_COUNT_HW_CACHE_OP_PREFETCH        <<  8) |
 # (PERF_COUNT_HW_CACHE_RESULT_MISS        << 16)
-[event22:base-stat]
-fd=22
+[event31:base-stat]
+fd=31
 type=3
 config=66048
 optional=1
index 9866cdd..9b4a765 100644 (file)
@@ -229,8 +229,8 @@ static int read_object_code(u64 addr, size_t len, u8 cpumode,
                            struct thread *thread, struct state *state)
 {
        struct addr_location al;
-       unsigned char buf1[BUFSZ];
-       unsigned char buf2[BUFSZ];
+       unsigned char buf1[BUFSZ] = {0};
+       unsigned char buf2[BUFSZ] = {0};
        size_t ret_len;
        u64 objdump_addr;
        const char *objdump_name;
index a288035..c756284 100644 (file)
 /* For bsearch. We try to unwind functions in shared object. */
 #include <stdlib.h>
 
+/*
+ * The test will assert frames are on the stack but tail call optimizations lose
+ * the frame of the caller. Clang can disable this optimization on a called
+ * function but GCC currently (11/2020) lacks this attribute. The barrier is
+ * used to inhibit tail calls in these cases.
+ */
+#ifdef __has_attribute
+#if __has_attribute(disable_tail_calls)
+#define NO_TAIL_CALL_ATTRIBUTE __attribute__((disable_tail_calls))
+#define NO_TAIL_CALL_BARRIER
+#endif
+#endif
+#ifndef NO_TAIL_CALL_ATTRIBUTE
+#define NO_TAIL_CALL_ATTRIBUTE
+#define NO_TAIL_CALL_BARRIER __asm__ __volatile__("" : : : "memory");
+#endif
+
 static int mmap_handler(struct perf_tool *tool __maybe_unused,
                        union perf_event *event,
                        struct perf_sample *sample,
@@ -91,7 +108,7 @@ static int unwind_entry(struct unwind_entry *entry, void *arg)
        return strcmp((const char *) symbol, funcs[idx]);
 }
 
-noinline int test_dwarf_unwind__thread(struct thread *thread)
+NO_TAIL_CALL_ATTRIBUTE noinline int test_dwarf_unwind__thread(struct thread *thread)
 {
        struct perf_sample sample;
        unsigned long cnt = 0;
@@ -122,7 +139,7 @@ noinline int test_dwarf_unwind__thread(struct thread *thread)
 
 static int global_unwind_retval = -INT_MAX;
 
-noinline int test_dwarf_unwind__compare(void *p1, void *p2)
+NO_TAIL_CALL_ATTRIBUTE noinline int test_dwarf_unwind__compare(void *p1, void *p2)
 {
        /* Any possible value should be 'thread' */
        struct thread *thread = *(struct thread **)p1;
@@ -141,7 +158,7 @@ noinline int test_dwarf_unwind__compare(void *p1, void *p2)
        return p1 - p2;
 }
 
-noinline int test_dwarf_unwind__krava_3(struct thread *thread)
+NO_TAIL_CALL_ATTRIBUTE noinline int test_dwarf_unwind__krava_3(struct thread *thread)
 {
        struct thread *array[2] = {thread, thread};
        void *fp = &bsearch;
@@ -160,14 +177,22 @@ noinline int test_dwarf_unwind__krava_3(struct thread *thread)
        return global_unwind_retval;
 }
 
-noinline int test_dwarf_unwind__krava_2(struct thread *thread)
+NO_TAIL_CALL_ATTRIBUTE noinline int test_dwarf_unwind__krava_2(struct thread *thread)
 {
-       return test_dwarf_unwind__krava_3(thread);
+       int ret;
+
+       ret =  test_dwarf_unwind__krava_3(thread);
+       NO_TAIL_CALL_BARRIER;
+       return ret;
 }
 
-noinline int test_dwarf_unwind__krava_1(struct thread *thread)
+NO_TAIL_CALL_ATTRIBUTE noinline int test_dwarf_unwind__krava_1(struct thread *thread)
 {
-       return test_dwarf_unwind__krava_2(thread);
+       int ret;
+
+       ret =  test_dwarf_unwind__krava_2(thread);
+       NO_TAIL_CALL_BARRIER;
+       return ret;
 }
 
 int test__dwarf_unwind(struct test *test __maybe_unused, int subtest __maybe_unused)
index 781afe4..fa5bd5c 100644 (file)
@@ -757,25 +757,40 @@ void __ui_browser__line_arrow(struct ui_browser *browser, unsigned int column,
 }
 
 void ui_browser__mark_fused(struct ui_browser *browser, unsigned int column,
-                           unsigned int row, bool arrow_down)
+                           unsigned int row, int diff, bool arrow_down)
 {
-       unsigned int end_row;
+       int end_row;
 
-       if (row >= browser->top_idx)
-               end_row = row - browser->top_idx;
-       else
+       if (diff <= 0)
                return;
 
        SLsmg_set_char_set(1);
 
        if (arrow_down) {
+               if (row + diff <= browser->top_idx)
+                       return;
+
+               end_row = row + diff - browser->top_idx;
                ui_browser__gotorc(browser, end_row, column - 1);
-               SLsmg_write_char(SLSMG_ULCORN_CHAR);
-               ui_browser__gotorc(browser, end_row, column);
-               SLsmg_draw_hline(2);
-               ui_browser__gotorc(browser, end_row + 1, column - 1);
                SLsmg_write_char(SLSMG_LTEE_CHAR);
+
+               while (--end_row >= 0 && end_row > (int)(row - browser->top_idx)) {
+                       ui_browser__gotorc(browser, end_row, column - 1);
+                       SLsmg_draw_vline(1);
+               }
+
+               end_row = (int)(row - browser->top_idx);
+               if (end_row >= 0) {
+                       ui_browser__gotorc(browser, end_row, column - 1);
+                       SLsmg_write_char(SLSMG_ULCORN_CHAR);
+                       ui_browser__gotorc(browser, end_row, column);
+                       SLsmg_draw_hline(2);
+               }
        } else {
+               if (row < browser->top_idx)
+                       return;
+
+               end_row = row - browser->top_idx;
                ui_browser__gotorc(browser, end_row, column - 1);
                SLsmg_write_char(SLSMG_LTEE_CHAR);
                ui_browser__gotorc(browser, end_row, column);
index 3678eb8..510ce45 100644 (file)
@@ -51,7 +51,7 @@ void ui_browser__write_graph(struct ui_browser *browser, int graph);
 void __ui_browser__line_arrow(struct ui_browser *browser, unsigned int column,
                              u64 start, u64 end);
 void ui_browser__mark_fused(struct ui_browser *browser, unsigned int column,
-                           unsigned int row, bool arrow_down);
+                           unsigned int row, int diff, bool arrow_down);
 void __ui_browser__show_title(struct ui_browser *browser, const char *title);
 void ui_browser__show_title(struct ui_browser *browser, const char *title);
 int ui_browser__show(struct ui_browser *browser, const char *title,
index ef4da42..e81c249 100644 (file)
@@ -125,13 +125,20 @@ static void annotate_browser__write(struct ui_browser *browser, void *entry, int
                ab->selection = al;
 }
 
-static bool is_fused(struct annotate_browser *ab, struct disasm_line *cursor)
+static int is_fused(struct annotate_browser *ab, struct disasm_line *cursor)
 {
        struct disasm_line *pos = list_prev_entry(cursor, al.node);
        const char *name;
+       int diff = 1;
+
+       while (pos && pos->al.offset == -1) {
+               pos = list_prev_entry(pos, al.node);
+               if (!ab->opts->hide_src_code)
+                       diff++;
+       }
 
        if (!pos)
-               return false;
+               return 0;
 
        if (ins__is_lock(&pos->ins))
                name = pos->ops.locked.ins.name;
@@ -139,9 +146,11 @@ static bool is_fused(struct annotate_browser *ab, struct disasm_line *cursor)
                name = pos->ins.name;
 
        if (!name || !cursor->ins.name)
-               return false;
+               return 0;
 
-       return ins__is_fused(ab->arch, name, cursor->ins.name);
+       if (ins__is_fused(ab->arch, name, cursor->ins.name))
+               return diff;
+       return 0;
 }
 
 static void annotate_browser__draw_current_jump(struct ui_browser *browser)
@@ -155,6 +164,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
        struct annotation *notes = symbol__annotation(sym);
        u8 pcnt_width = annotation__pcnt_width(notes);
        int width;
+       int diff = 0;
 
        /* PLT symbols contain external offsets */
        if (strstr(sym->name, "@plt"))
@@ -205,11 +215,11 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
                                 pcnt_width + 2 + notes->widths.addr + width,
                                 from, to);
 
-       if (is_fused(ab, cursor)) {
+       diff = is_fused(ab, cursor);
+       if (diff > 0) {
                ui_browser__mark_fused(browser,
                                       pcnt_width + 3 + notes->widths.addr + width,
-                                      from - 1,
-                                      to > from);
+                                      from - diff, diff, to > from);
        }
 }
 
index 683f6d6..1a7112a 100644 (file)
 struct btf * __weak btf__load_from_kernel_by_id(__u32 id)
 {
        struct btf *btf;
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
        int err = btf__get_from_id(id, &btf);
+#pragma GCC diagnostic pop
 
        return err ? ERR_PTR(err) : btf;
 }
index 4fb5e90..60ce590 100644 (file)
@@ -801,7 +801,7 @@ int perf_config_set(struct perf_config_set *set,
                                  section->name, item->name);
                        ret = fn(key, value, data);
                        if (ret < 0) {
-                               pr_err("Error: wrong config key-value pair %s=%s\n",
+                               pr_err("Error in the given config file: wrong config key-value pair %s=%s\n",
                                       key, value);
                                /*
                                 * Can't be just a 'break', as perf_config_set__for_each_entry()
index da19be7..44e40ba 100644 (file)
@@ -2149,6 +2149,7 @@ static int add_callchain_ip(struct thread *thread,
 
        al.filtered = 0;
        al.sym = NULL;
+       al.srcline = NULL;
        if (!cpumode) {
                thread__find_cpumode_addr_location(thread, ip, &al);
        } else {
index 069c2cf..352f160 100644 (file)
@@ -2116,7 +2116,7 @@ fetch_decomp_event(u64 head, size_t mmap_size, char *buf, bool needs_swap)
 static int __perf_session__process_decomp_events(struct perf_session *session)
 {
        s64 skip;
-       u64 size, file_pos = 0;
+       u64 size;
        struct decomp *decomp = session->decomp_last;
 
        if (!decomp)
@@ -2132,7 +2132,7 @@ static int __perf_session__process_decomp_events(struct perf_session *session)
                size = event->header.size;
 
                if (size < sizeof(struct perf_event_header) ||
-                   (skip = perf_session__process_event(session, event, file_pos)) < 0) {
+                   (skip = perf_session__process_event(session, event, decomp->file_pos)) < 0) {
                        pr_err("%#" PRIx64 " [%#x]: failed to process type: %d\n",
                                decomp->file_pos + decomp->head, event->header.size, event->header.type);
                        return -EINVAL;
index 5a93145..ac35c61 100755 (executable)
@@ -16,7 +16,7 @@ assert sys.version_info >= (3, 7), "Python version is too old"
 
 from collections import namedtuple
 from enum import Enum, auto
-from typing import Iterable
+from typing import Iterable, Sequence
 
 import kunit_config
 import kunit_json
@@ -186,6 +186,26 @@ def run_tests(linux: kunit_kernel.LinuxSourceTree,
                                exec_result.elapsed_time))
        return parse_result
 
+# Problem:
+# $ kunit.py run --json
+# works as one would expect and prints the parsed test results as JSON.
+# $ kunit.py run --json suite_name
+# would *not* pass suite_name as the filter_glob and print as json.
+# argparse will consider it to be another way of writing
+# $ kunit.py run --json=suite_name
+# i.e. it would run all tests, and dump the json to a `suite_name` file.
+# So we hackily automatically rewrite --json => --json=stdout
+pseudo_bool_flag_defaults = {
+               '--json': 'stdout',
+               '--raw_output': 'kunit',
+}
+def massage_argv(argv: Sequence[str]) -> Sequence[str]:
+       def massage_arg(arg: str) -> str:
+               if arg not in pseudo_bool_flag_defaults:
+                       return arg
+               return  f'{arg}={pseudo_bool_flag_defaults[arg]}'
+       return list(map(massage_arg, argv))
+
 def add_common_opts(parser) -> None:
        parser.add_argument('--build_dir',
                            help='As in the make command, it specifies the build '
@@ -303,7 +323,7 @@ def main(argv, linux=None):
                                  help='Specifies the file to read results from.',
                                  type=str, nargs='?', metavar='input_file')
 
-       cli_args = parser.parse_args(argv)
+       cli_args = parser.parse_args(massage_argv(argv))
 
        if get_kernel_root_path():
                os.chdir(get_kernel_root_path())
index 619c455..1edcc83 100755 (executable)
@@ -408,6 +408,14 @@ class KUnitMainTest(unittest.TestCase):
                        self.assertNotEqual(call, mock.call(StrContains('Testing complete.')))
                        self.assertNotEqual(call, mock.call(StrContains(' 0 tests run')))
 
+       def test_run_raw_output_does_not_take_positional_args(self):
+               # --raw_output is a string flag, but we don't want it to consume
+               # any positional arguments, only ones after an '='
+               self.linux_source_mock.run_kernel = mock.Mock(return_value=[])
+               kunit.main(['run', '--raw_output', 'filter_glob'], self.linux_source_mock)
+               self.linux_source_mock.run_kernel.assert_called_once_with(
+                       args=None, build_dir='.kunit', filter_glob='filter_glob', timeout=300)
+
        def test_exec_timeout(self):
                timeout = 3453
                kunit.main(['exec', '--timeout', str(timeout)], self.linux_source_mock)
index 6836510..22722ab 100644 (file)
@@ -266,16 +266,19 @@ int test_init(struct tdescr *td)
                        td->feats_supported |= FEAT_SSBS;
                if (getauxval(AT_HWCAP) & HWCAP_SVE)
                        td->feats_supported |= FEAT_SVE;
-               if (feats_ok(td))
+               if (feats_ok(td)) {
                        fprintf(stderr,
                                "Required Features: [%s] supported\n",
                                feats_to_string(td->feats_required &
                                                td->feats_supported));
-               else
+               } else {
                        fprintf(stderr,
                                "Required Features: [%s] NOT supported\n",
                                feats_to_string(td->feats_required &
                                                ~td->feats_supported));
+                       td->result = KSFT_SKIP;
+                       return 0;
+               }
        }
 
        /* Perform test specific additional initialization */
index 866531c..799b881 100644 (file)
@@ -375,7 +375,8 @@ $(TRUNNER_BPF_OBJS): $(TRUNNER_OUTPUT)/%.o:                         \
                     $(TRUNNER_BPF_PROGS_DIR)/%.c                       \
                     $(TRUNNER_BPF_PROGS_DIR)/*.h                       \
                     $$(INCLUDE_DIR)/vmlinux.h                          \
-                    $(wildcard $(BPFDIR)/bpf_*.h) | $(TRUNNER_OUTPUT)
+                    $(wildcard $(BPFDIR)/bpf_*.h)                      \
+                    | $(TRUNNER_OUTPUT) $$(BPFOBJ)
        $$(call $(TRUNNER_BPF_BUILD_RULE),$$<,$$@,                      \
                                          $(TRUNNER_BPF_CFLAGS))
 
index 0330517..f3daa44 100644 (file)
 #include <unistd.h>
 #include <ftw.h>
 
-
 #include "cgroup_helpers.h"
 
 /*
  * To avoid relying on the system setup, when setup_cgroup_env is called
- * we create a new mount namespace, and cgroup namespace. The cgroup2
- * root is mounted at CGROUP_MOUNT_PATH
- *
- * Unfortunately, most people don't have cgroupv2 enabled at this point in time.
- * It's easier to create our own mount namespace and manage it ourselves.
+ * we create a new mount namespace, and cgroup namespace. The cgroupv2
+ * root is mounted at CGROUP_MOUNT_PATH. Unfortunately, most people don't
+ * have cgroupv2 enabled at this point in time. It's easier to create our
+ * own mount namespace and manage it ourselves. We assume /mnt exists.
  *
- * We assume /mnt exists.
+ * Related cgroupv1 helpers are named *classid*(), since we only use the
+ * net_cls controller for tagging net_cls.classid. We assume the default
+ * mount under /sys/fs/cgroup/net_cls, which should be the case for the
+ * vast majority of users.
  */
 
 #define WALK_FD_LIMIT                  16
+
 #define CGROUP_MOUNT_PATH              "/mnt"
+#define CGROUP_MOUNT_DFLT              "/sys/fs/cgroup"
+#define NETCLS_MOUNT_PATH              CGROUP_MOUNT_DFLT "/net_cls"
 #define CGROUP_WORK_DIR                        "/cgroup-test-work-dir"
+
 #define format_cgroup_path(buf, path) \
        snprintf(buf, sizeof(buf), "%s%s%s", CGROUP_MOUNT_PATH, \
                 CGROUP_WORK_DIR, path)
 
+#define format_classid_path(buf)                               \
+       snprintf(buf, sizeof(buf), "%s%s", NETCLS_MOUNT_PATH,   \
+                CGROUP_WORK_DIR)
+
 /**
  * enable_all_controllers() - Enable all available cgroup v2 controllers
  *
@@ -139,8 +148,7 @@ static int nftwfunc(const char *filename, const struct stat *statptr,
        return 0;
 }
 
-
-static int join_cgroup_from_top(char *cgroup_path)
+static int join_cgroup_from_top(const char *cgroup_path)
 {
        char cgroup_procs_path[PATH_MAX + 1];
        pid_t pid = getpid();
@@ -313,3 +321,114 @@ int cgroup_setup_and_join(const char *path) {
        }
        return cg_fd;
 }
+
+/**
+ * setup_classid_environment() - Setup the cgroupv1 net_cls environment
+ *
+ * After calling this function, cleanup_classid_environment should be called
+ * once testing is complete.
+ *
+ * This function will print an error to stderr and return 1 if it is unable
+ * to setup the cgroup environment. If setup is successful, 0 is returned.
+ */
+int setup_classid_environment(void)
+{
+       char cgroup_workdir[PATH_MAX + 1];
+
+       format_classid_path(cgroup_workdir);
+
+       if (mount("tmpfs", CGROUP_MOUNT_DFLT, "tmpfs", 0, NULL) &&
+           errno != EBUSY) {
+               log_err("mount cgroup base");
+               return 1;
+       }
+
+       if (mkdir(NETCLS_MOUNT_PATH, 0777) && errno != EEXIST) {
+               log_err("mkdir cgroup net_cls");
+               return 1;
+       }
+
+       if (mount("net_cls", NETCLS_MOUNT_PATH, "cgroup", 0, "net_cls") &&
+           errno != EBUSY) {
+               log_err("mount cgroup net_cls");
+               return 1;
+       }
+
+       cleanup_classid_environment();
+
+       if (mkdir(cgroup_workdir, 0777) && errno != EEXIST) {
+               log_err("mkdir cgroup work dir");
+               return 1;
+       }
+
+       return 0;
+}
+
+/**
+ * set_classid() - Set a cgroupv1 net_cls classid
+ * @id: the numeric classid
+ *
+ * Writes the passed classid into the cgroup work dir's net_cls.classid
+ * file in order to later on trigger socket tagging.
+ *
+ * On success, it returns 0, otherwise on failure it returns 1. If there
+ * is a failure, it prints the error to stderr.
+ */
+int set_classid(unsigned int id)
+{
+       char cgroup_workdir[PATH_MAX - 42];
+       char cgroup_classid_path[PATH_MAX + 1];
+       int fd, rc = 0;
+
+       format_classid_path(cgroup_workdir);
+       snprintf(cgroup_classid_path, sizeof(cgroup_classid_path),
+                "%s/net_cls.classid", cgroup_workdir);
+
+       fd = open(cgroup_classid_path, O_WRONLY);
+       if (fd < 0) {
+               log_err("Opening cgroup classid: %s", cgroup_classid_path);
+               return 1;
+       }
+
+       if (dprintf(fd, "%u\n", id) < 0) {
+               log_err("Setting cgroup classid");
+               rc = 1;
+       }
+
+       close(fd);
+       return rc;
+}
+
+/**
+ * join_classid() - Join a cgroupv1 net_cls classid
+ *
+ * This function expects the cgroup work dir to be already created, as we
+ * join it here. This causes the process sockets to be tagged with the given
+ * net_cls classid.
+ *
+ * On success, it returns 0, otherwise on failure it returns 1.
+ */
+int join_classid(void)
+{
+       char cgroup_workdir[PATH_MAX + 1];
+
+       format_classid_path(cgroup_workdir);
+       return join_cgroup_from_top(cgroup_workdir);
+}
+
+/**
+ * cleanup_classid_environment() - Cleanup the cgroupv1 net_cls environment
+ *
+ * At call time, it moves the calling process to the root cgroup, and then
+ * runs the deletion process.
+ *
+ * On failure, it will print an error to stderr, and try to continue.
+ */
+void cleanup_classid_environment(void)
+{
+       char cgroup_workdir[PATH_MAX + 1];
+
+       format_classid_path(cgroup_workdir);
+       join_cgroup_from_top(NETCLS_MOUNT_PATH);
+       nftw(cgroup_workdir, nftwfunc, WALK_FD_LIMIT, FTW_DEPTH | FTW_MOUNT);
+}
index 5fe3d88..629da38 100644 (file)
@@ -1,6 +1,7 @@
 /* SPDX-License-Identifier: GPL-2.0 */
 #ifndef __CGROUP_HELPERS_H
 #define __CGROUP_HELPERS_H
+
 #include <errno.h>
 #include <string.h>
 
@@ -8,12 +9,21 @@
 #define log_err(MSG, ...) fprintf(stderr, "(%s:%d: errno: %s) " MSG "\n", \
        __FILE__, __LINE__, clean_errno(), ##__VA_ARGS__)
 
-
+/* cgroupv2 related */
 int cgroup_setup_and_join(const char *path);
 int create_and_get_cgroup(const char *path);
+unsigned long long get_cgroup_id(const char *path);
+
 int join_cgroup(const char *path);
+
 int setup_cgroup_environment(void);
 void cleanup_cgroup_environment(void);
-unsigned long long get_cgroup_id(const char *path);
 
-#endif
+/* cgroupv1 related */
+int set_classid(unsigned int id);
+int join_classid(void);
+
+int setup_classid_environment(void);
+void cleanup_classid_environment(void);
+
+#endif /* __CGROUP_HELPERS_H */
index 7e9f637..6db1af8 100644 (file)
@@ -208,11 +208,26 @@ error_close:
 
 static int connect_fd_to_addr(int fd,
                              const struct sockaddr_storage *addr,
-                             socklen_t addrlen)
+                             socklen_t addrlen, const bool must_fail)
 {
-       if (connect(fd, (const struct sockaddr *)addr, addrlen)) {
-               log_err("Failed to connect to server");
-               return -1;
+       int ret;
+
+       errno = 0;
+       ret = connect(fd, (const struct sockaddr *)addr, addrlen);
+       if (must_fail) {
+               if (!ret) {
+                       log_err("Unexpected success to connect to server");
+                       return -1;
+               }
+               if (errno != EPERM) {
+                       log_err("Unexpected error from connect to server");
+                       return -1;
+               }
+       } else {
+               if (ret) {
+                       log_err("Failed to connect to server");
+                       return -1;
+               }
        }
 
        return 0;
@@ -257,7 +272,7 @@ int connect_to_fd_opts(int server_fd, const struct network_helper_opts *opts)
                       strlen(opts->cc) + 1))
                goto error_close;
 
-       if (connect_fd_to_addr(fd, &addr, addrlen))
+       if (connect_fd_to_addr(fd, &addr, addrlen, opts->must_fail))
                goto error_close;
 
        return fd;
@@ -289,7 +304,7 @@ int connect_fd_to_fd(int client_fd, int server_fd, int timeout_ms)
                return -1;
        }
 
-       if (connect_fd_to_addr(client_fd, &addr, len))
+       if (connect_fd_to_addr(client_fd, &addr, len, false))
                return -1;
 
        return 0;
index da7e132..d198181 100644 (file)
@@ -20,6 +20,7 @@ typedef __u16 __sum16;
 struct network_helper_opts {
        const char *cc;
        int timeout_ms;
+       bool must_fail;
 };
 
 /* ipv4 test vector */
diff --git a/tools/testing/selftests/bpf/prog_tests/cgroup_v1v2.c b/tools/testing/selftests/bpf/prog_tests/cgroup_v1v2.c
new file mode 100644 (file)
index 0000000..ab3b9bc
--- /dev/null
@@ -0,0 +1,79 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <test_progs.h>
+
+#include "connect4_dropper.skel.h"
+
+#include "cgroup_helpers.h"
+#include "network_helpers.h"
+
+static int run_test(int cgroup_fd, int server_fd, bool classid)
+{
+       struct network_helper_opts opts = {
+               .must_fail = true,
+       };
+       struct connect4_dropper *skel;
+       int fd, err = 0;
+
+       skel = connect4_dropper__open_and_load();
+       if (!ASSERT_OK_PTR(skel, "skel_open"))
+               return -1;
+
+       skel->links.connect_v4_dropper =
+               bpf_program__attach_cgroup(skel->progs.connect_v4_dropper,
+                                          cgroup_fd);
+       if (!ASSERT_OK_PTR(skel->links.connect_v4_dropper, "prog_attach")) {
+               err = -1;
+               goto out;
+       }
+
+       if (classid && !ASSERT_OK(join_classid(), "join_classid")) {
+               err = -1;
+               goto out;
+       }
+
+       fd = connect_to_fd_opts(server_fd, &opts);
+       if (fd < 0)
+               err = -1;
+       else
+               close(fd);
+out:
+       connect4_dropper__destroy(skel);
+       return err;
+}
+
+void test_cgroup_v1v2(void)
+{
+       struct network_helper_opts opts = {};
+       int server_fd, client_fd, cgroup_fd;
+       static const int port = 60123;
+
+       /* Step 1: Check base connectivity works without any BPF. */
+       server_fd = start_server(AF_INET, SOCK_STREAM, NULL, port, 0);
+       if (!ASSERT_GE(server_fd, 0, "server_fd"))
+               return;
+       client_fd = connect_to_fd_opts(server_fd, &opts);
+       if (!ASSERT_GE(client_fd, 0, "client_fd")) {
+               close(server_fd);
+               return;
+       }
+       close(client_fd);
+       close(server_fd);
+
+       /* Step 2: Check BPF policy prog attached to cgroups drops connectivity. */
+       cgroup_fd = test__join_cgroup("/connect_dropper");
+       if (!ASSERT_GE(cgroup_fd, 0, "cgroup_fd"))
+               return;
+       server_fd = start_server(AF_INET, SOCK_STREAM, NULL, port, 0);
+       if (!ASSERT_GE(server_fd, 0, "server_fd")) {
+               close(cgroup_fd);
+               return;
+       }
+       ASSERT_OK(run_test(cgroup_fd, server_fd, false), "cgroup-v2-only");
+       setup_classid_environment();
+       set_classid(42);
+       ASSERT_OK(run_test(cgroup_fd, server_fd, true), "cgroup-v1v2");
+       cleanup_classid_environment();
+       close(server_fd);
+       close(cgroup_fd);
+}
index 53f0e0f..37c20b5 100644 (file)
@@ -1,7 +1,6 @@
 // SPDX-License-Identifier: GPL-2.0
 #define _GNU_SOURCE
 #include <test_progs.h>
-#include <linux/ptrace.h>
 #include "test_task_pt_regs.skel.h"
 
 void test_task_pt_regs(void)
diff --git a/tools/testing/selftests/bpf/progs/connect4_dropper.c b/tools/testing/selftests/bpf/progs/connect4_dropper.c
new file mode 100644 (file)
index 0000000..b565d99
--- /dev/null
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: GPL-2.0
+
+#include <string.h>
+
+#include <linux/stddef.h>
+#include <linux/bpf.h>
+
+#include <sys/socket.h>
+
+#include <bpf/bpf_helpers.h>
+#include <bpf/bpf_endian.h>
+
+#define VERDICT_REJECT 0
+#define VERDICT_PROCEED        1
+
+SEC("cgroup/connect4")
+int connect_v4_dropper(struct bpf_sock_addr *ctx)
+{
+       if (ctx->type != SOCK_STREAM)
+               return VERDICT_PROCEED;
+       if (ctx->user_port == bpf_htons(60123))
+               return VERDICT_REJECT;
+       return VERDICT_PROCEED;
+}
+
+char _license[] SEC("license") = "GPL";
index 6c059f1..e6cb092 100644 (file)
@@ -1,12 +1,17 @@
 // SPDX-License-Identifier: GPL-2.0
 
-#include <linux/ptrace.h>
-#include <linux/bpf.h>
+#include "vmlinux.h"
 #include <bpf/bpf_helpers.h>
 #include <bpf/bpf_tracing.h>
 
-struct pt_regs current_regs = {};
-struct pt_regs ctx_regs = {};
+#define PT_REGS_SIZE sizeof(struct pt_regs)
+
+/*
+ * The kernel struct pt_regs isn't exported in its entirety to userspace.
+ * Pass it as an array to task_pt_regs.c
+ */
+char current_regs[PT_REGS_SIZE] = {};
+char ctx_regs[PT_REGS_SIZE] = {};
 int uprobe_res = 0;
 
 SEC("uprobe/trigger_func")
@@ -17,8 +22,10 @@ int handle_uprobe(struct pt_regs *ctx)
 
        current = bpf_get_current_task_btf();
        regs = (struct pt_regs *) bpf_task_pt_regs(current);
-       __builtin_memcpy(&current_regs, regs, sizeof(*regs));
-       __builtin_memcpy(&ctx_regs, ctx, sizeof(*ctx));
+       if (bpf_probe_read_kernel(current_regs, PT_REGS_SIZE, regs))
+               return 0;
+       if (bpf_probe_read_kernel(ctx_regs, PT_REGS_SIZE, ctx))
+               return 0;
 
        /* Prove that uprobe was run */
        uprobe_res = 1;
index 59ea569..b497bb8 100755 (executable)
@@ -112,6 +112,14 @@ setup()
        ip netns add "${NS2}"
        ip netns add "${NS3}"
 
+       # rp_filter gets confused by what these tests are doing, so disable it
+       ip netns exec ${NS1} sysctl -wq net.ipv4.conf.all.rp_filter=0
+       ip netns exec ${NS2} sysctl -wq net.ipv4.conf.all.rp_filter=0
+       ip netns exec ${NS3} sysctl -wq net.ipv4.conf.all.rp_filter=0
+       ip netns exec ${NS1} sysctl -wq net.ipv4.conf.default.rp_filter=0
+       ip netns exec ${NS2} sysctl -wq net.ipv4.conf.default.rp_filter=0
+       ip netns exec ${NS3} sysctl -wq net.ipv4.conf.default.rp_filter=0
+
        ip link add veth1 type veth peer name veth2
        ip link add veth3 type veth peer name veth4
        ip link add veth5 type veth peer name veth6
@@ -236,11 +244,6 @@ setup()
        ip -netns ${NS1} -6 route add ${IPv6_GRE}/128 dev veth5 via ${IPv6_6} ${VRF}
        ip -netns ${NS2} -6 route add ${IPv6_GRE}/128 dev veth7 via ${IPv6_8} ${VRF}
 
-       # rp_filter gets confused by what these tests are doing, so disable it
-       ip netns exec ${NS1} sysctl -wq net.ipv4.conf.all.rp_filter=0
-       ip netns exec ${NS2} sysctl -wq net.ipv4.conf.all.rp_filter=0
-       ip netns exec ${NS3} sysctl -wq net.ipv4.conf.all.rp_filter=0
-
        TMPFILE=$(mktemp /tmp/test_lwt_ip_encap.XXXXXX)
 
        sleep 1  # reduce flakiness
index 4de902e..de1c4e6 100644 (file)
@@ -1,10 +1,13 @@
 // SPDX-License-Identifier: GPL-2.0
+#define _GNU_SOURCE
+#define __EXPORTED_HEADERS__
+
 #include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #include <string.h>
 #include <errno.h>
-#include <linux/fcntl.h>
+#include <fcntl.h>
 #include <malloc.h>
 
 #include <sys/ioctl.h>
index beee0d5..f7d8454 100755 (executable)
@@ -1,6 +1,6 @@
 #!/bin/bash
 # SPDX-License-Identifier: GPL-2.0
-# Copyright 2020 NXP Semiconductors
+# Copyright 2020 NXP
 
 WAIT_TIME=1
 NUM_NETIFS=4
index 5f5b2ba..60c02b4 100644 (file)
@@ -11,8 +11,8 @@ SYSTEM="syscalls"
 EVENT="sys_enter_openat"
 FIELD="filename"
 EPROBE="eprobe_open"
-
-echo "e:$EPROBE $SYSTEM/$EVENT file=+0(\$filename):ustring" >> dynamic_events
+OPTIONS="file=+0(\$filename):ustring"
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
 
 grep -q "$EPROBE" dynamic_events
 test -d events/eprobes/$EPROBE
@@ -37,4 +37,54 @@ echo "-:$EPROBE" >> dynamic_events
 ! grep -q "$EPROBE" dynamic_events
 ! test -d events/eprobes/$EPROBE
 
+# test various ways to remove the probe (already tested with just event name)
+
+# With group name
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+grep -q "$EPROBE" dynamic_events
+test -d events/eprobes/$EPROBE
+echo "-:eprobes/$EPROBE" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
+# With group name and system/event
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+grep -q "$EPROBE" dynamic_events
+test -d events/eprobes/$EPROBE
+echo "-:eprobes/$EPROBE $SYSTEM/$EVENT" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
+# With just event name and system/event
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+grep -q "$EPROBE" dynamic_events
+test -d events/eprobes/$EPROBE
+echo "-:$EPROBE $SYSTEM/$EVENT" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
+# With just event name and system/event and options
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+grep -q "$EPROBE" dynamic_events
+test -d events/eprobes/$EPROBE
+echo "-:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
+# With group name and system/event and options
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+grep -q "$EPROBE" dynamic_events
+test -d events/eprobes/$EPROBE
+echo "-:eprobes/$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
+# Finally make sure what is in the dynamic_events file clears it too
+echo "e:$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+LINE=`sed -e '/$EPROBE/s/^e/-/' < dynamic_events`
+test -d events/eprobes/$EPROBE
+echo "-:eprobes/$EPROBE $SYSTEM/$EVENT $OPTIONS" >> dynamic_events
+! grep -q "$EPROBE" dynamic_events
+! test -d events/eprobes/$EPROBE
+
 clear_trace
index 98053d3..b8dbabe 100644 (file)
@@ -24,6 +24,7 @@
 /x86_64/smm_test
 /x86_64/state_test
 /x86_64/svm_vmcall_test
+/x86_64/svm_int_ctl_test
 /x86_64/sync_regs_test
 /x86_64/tsc_msrs_test
 /x86_64/userspace_msr_exit_test
@@ -48,6 +49,7 @@
 /kvm_page_table_test
 /memslot_modification_stress_test
 /memslot_perf_test
+/rseq_test
 /set_memory_region_test
 /steal_time
 /kvm_binary_stats_test
index 5d05801..d1774f4 100644 (file)
@@ -56,6 +56,7 @@ TEST_GEN_PROGS_x86_64 += x86_64/smm_test
 TEST_GEN_PROGS_x86_64 += x86_64/state_test
 TEST_GEN_PROGS_x86_64 += x86_64/vmx_preemption_timer_test
 TEST_GEN_PROGS_x86_64 += x86_64/svm_vmcall_test
+TEST_GEN_PROGS_x86_64 += x86_64/svm_int_ctl_test
 TEST_GEN_PROGS_x86_64 += x86_64/sync_regs_test
 TEST_GEN_PROGS_x86_64 += x86_64/userspace_msr_exit_test
 TEST_GEN_PROGS_x86_64 += x86_64/vmx_apic_access_test
@@ -80,6 +81,7 @@ TEST_GEN_PROGS_x86_64 += kvm_create_max_vcpus
 TEST_GEN_PROGS_x86_64 += kvm_page_table_test
 TEST_GEN_PROGS_x86_64 += memslot_modification_stress_test
 TEST_GEN_PROGS_x86_64 += memslot_perf_test
+TEST_GEN_PROGS_x86_64 += rseq_test
 TEST_GEN_PROGS_x86_64 += set_memory_region_test
 TEST_GEN_PROGS_x86_64 += steal_time
 TEST_GEN_PROGS_x86_64 += kvm_binary_stats_test
@@ -93,6 +95,7 @@ TEST_GEN_PROGS_aarch64 += dirty_log_test
 TEST_GEN_PROGS_aarch64 += dirty_log_perf_test
 TEST_GEN_PROGS_aarch64 += kvm_create_max_vcpus
 TEST_GEN_PROGS_aarch64 += kvm_page_table_test
+TEST_GEN_PROGS_aarch64 += rseq_test
 TEST_GEN_PROGS_aarch64 += set_memory_region_test
 TEST_GEN_PROGS_aarch64 += steal_time
 TEST_GEN_PROGS_aarch64 += kvm_binary_stats_test
@@ -104,6 +107,7 @@ TEST_GEN_PROGS_s390x += demand_paging_test
 TEST_GEN_PROGS_s390x += dirty_log_test
 TEST_GEN_PROGS_s390x += kvm_create_max_vcpus
 TEST_GEN_PROGS_s390x += kvm_page_table_test
+TEST_GEN_PROGS_s390x += rseq_test
 TEST_GEN_PROGS_s390x += set_memory_region_test
 TEST_GEN_PROGS_s390x += kvm_binary_stats_test
 
index 71e277c..5d95113 100644 (file)
@@ -371,9 +371,7 @@ static void help(char *name)
        printf(" -v: specify the number of vCPUs to run.\n");
        printf(" -o: Overlap guest memory accesses instead of partitioning\n"
               "     them into a separate region of memory for each vCPU.\n");
-       printf(" -s: specify the type of memory that should be used to\n"
-              "     back the guest data region.\n\n");
-       backing_src_help();
+       backing_src_help("-s");
        puts("");
        exit(0);
 }
@@ -381,7 +379,7 @@ static void help(char *name)
 int main(int argc, char *argv[])
 {
        struct test_params params = {
-               .backing_src = VM_MEM_SRC_ANONYMOUS,
+               .backing_src = DEFAULT_VM_MEM_SRC,
                .vcpu_memory_bytes = DEFAULT_PER_VCPU_MEM_SIZE,
                .vcpus = 1,
        };
index e79c1b6..1510b21 100644 (file)
@@ -179,7 +179,7 @@ static void *uffd_handler_thread_fn(void *arg)
                        return NULL;
                }
 
-               if (!pollfd[0].revents & POLLIN)
+               if (!(pollfd[0].revents & POLLIN))
                        continue;
 
                r = read(uffd, &msg, sizeof(msg));
@@ -416,7 +416,7 @@ static void help(char *name)
 {
        puts("");
        printf("usage: %s [-h] [-m vm_mode] [-u uffd_mode] [-d uffd_delay_usec]\n"
-              "          [-b memory] [-t type] [-v vcpus] [-o]\n", name);
+              "          [-b memory] [-s type] [-v vcpus] [-o]\n", name);
        guest_modes_help();
        printf(" -u: use userfaultfd to handle vCPU page faults. Mode is a\n"
               "     UFFD registration mode: 'MISSING' or 'MINOR'.\n");
@@ -426,8 +426,7 @@ static void help(char *name)
        printf(" -b: specify the size of the memory region which should be\n"
               "     demand paged by each vCPU. e.g. 10M or 3G.\n"
               "     Default: 1G\n");
-       printf(" -t: The type of backing memory to use. Default: anonymous\n");
-       backing_src_help();
+       backing_src_help("-s");
        printf(" -v: specify the number of vCPUs to run.\n");
        printf(" -o: Overlap guest memory accesses instead of partitioning\n"
               "     them into a separate region of memory for each vCPU.\n");
@@ -439,14 +438,14 @@ int main(int argc, char *argv[])
 {
        int max_vcpus = kvm_check_cap(KVM_CAP_MAX_VCPUS);
        struct test_params p = {
-               .src_type = VM_MEM_SRC_ANONYMOUS,
+               .src_type = DEFAULT_VM_MEM_SRC,
                .partition_vcpu_memory_access = true,
        };
        int opt;
 
        guest_modes_append_default();
 
-       while ((opt = getopt(argc, argv, "hm:u:d:b:t:v:o")) != -1) {
+       while ((opt = getopt(argc, argv, "hm:u:d:b:s:v:o")) != -1) {
                switch (opt) {
                case 'm':
                        guest_modes_cmdline(optarg);
@@ -465,7 +464,7 @@ int main(int argc, char *argv[])
                case 'b':
                        guest_percpu_mem_size = parse_size(optarg);
                        break;
-               case 't':
+               case 's':
                        p.src_type = parse_backing_src_type(optarg);
                        break;
                case 'v':
@@ -485,7 +484,7 @@ int main(int argc, char *argv[])
 
        if (p.uffd_mode == UFFDIO_REGISTER_MODE_MINOR &&
            !backing_src_is_shared(p.src_type)) {
-               TEST_FAIL("userfaultfd MINOR mode requires shared memory; pick a different -t");
+               TEST_FAIL("userfaultfd MINOR mode requires shared memory; pick a different -s");
        }
 
        for_each_guest_mode(run_test, &p);
index 4798685..7ffab5b 100644 (file)
@@ -118,42 +118,64 @@ static inline void disable_dirty_logging(struct kvm_vm *vm, int slots)
        toggle_dirty_logging(vm, slots, false);
 }
 
-static void get_dirty_log(struct kvm_vm *vm, int slots, unsigned long *bitmap,
-                         uint64_t nr_pages)
+static void get_dirty_log(struct kvm_vm *vm, unsigned long *bitmaps[], int slots)
 {
-       uint64_t slot_pages = nr_pages / slots;
        int i;
 
        for (i = 0; i < slots; i++) {
                int slot = PERF_TEST_MEM_SLOT_INDEX + i;
-               unsigned long *slot_bitmap = bitmap + i * slot_pages;
 
-               kvm_vm_get_dirty_log(vm, slot, slot_bitmap);
+               kvm_vm_get_dirty_log(vm, slot, bitmaps[i]);
        }
 }
 
-static void clear_dirty_log(struct kvm_vm *vm, int slots, unsigned long *bitmap,
-                           uint64_t nr_pages)
+static void clear_dirty_log(struct kvm_vm *vm, unsigned long *bitmaps[],
+                           int slots, uint64_t pages_per_slot)
 {
-       uint64_t slot_pages = nr_pages / slots;
        int i;
 
        for (i = 0; i < slots; i++) {
                int slot = PERF_TEST_MEM_SLOT_INDEX + i;
-               unsigned long *slot_bitmap = bitmap + i * slot_pages;
 
-               kvm_vm_clear_dirty_log(vm, slot, slot_bitmap, 0, slot_pages);
+               kvm_vm_clear_dirty_log(vm, slot, bitmaps[i], 0, pages_per_slot);
        }
 }
 
+static unsigned long **alloc_bitmaps(int slots, uint64_t pages_per_slot)
+{
+       unsigned long **bitmaps;
+       int i;
+
+       bitmaps = malloc(slots * sizeof(bitmaps[0]));
+       TEST_ASSERT(bitmaps, "Failed to allocate bitmaps array.");
+
+       for (i = 0; i < slots; i++) {
+               bitmaps[i] = bitmap_zalloc(pages_per_slot);
+               TEST_ASSERT(bitmaps[i], "Failed to allocate slot bitmap.");
+       }
+
+       return bitmaps;
+}
+
+static void free_bitmaps(unsigned long *bitmaps[], int slots)
+{
+       int i;
+
+       for (i = 0; i < slots; i++)
+               free(bitmaps[i]);
+
+       free(bitmaps);
+}
+
 static void run_test(enum vm_guest_mode mode, void *arg)
 {
        struct test_params *p = arg;
        pthread_t *vcpu_threads;
        struct kvm_vm *vm;
-       unsigned long *bmap;
+       unsigned long **bitmaps;
        uint64_t guest_num_pages;
        uint64_t host_num_pages;
+       uint64_t pages_per_slot;
        int vcpu_id;
        struct timespec start;
        struct timespec ts_diff;
@@ -171,7 +193,9 @@ static void run_test(enum vm_guest_mode mode, void *arg)
        guest_num_pages = (nr_vcpus * guest_percpu_mem_size) >> vm_get_page_shift(vm);
        guest_num_pages = vm_adjust_num_guest_pages(mode, guest_num_pages);
        host_num_pages = vm_num_host_pages(mode, guest_num_pages);
-       bmap = bitmap_zalloc(host_num_pages);
+       pages_per_slot = host_num_pages / p->slots;
+
+       bitmaps = alloc_bitmaps(p->slots, pages_per_slot);
 
        if (dirty_log_manual_caps) {
                cap.cap = KVM_CAP_MANUAL_DIRTY_LOG_PROTECT2;
@@ -239,7 +263,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
                        iteration, ts_diff.tv_sec, ts_diff.tv_nsec);
 
                clock_gettime(CLOCK_MONOTONIC, &start);
-               get_dirty_log(vm, p->slots, bmap, host_num_pages);
+               get_dirty_log(vm, bitmaps, p->slots);
                ts_diff = timespec_elapsed(start);
                get_dirty_log_total = timespec_add(get_dirty_log_total,
                                                   ts_diff);
@@ -248,7 +272,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
 
                if (dirty_log_manual_caps) {
                        clock_gettime(CLOCK_MONOTONIC, &start);
-                       clear_dirty_log(vm, p->slots, bmap, host_num_pages);
+                       clear_dirty_log(vm, bitmaps, p->slots, pages_per_slot);
                        ts_diff = timespec_elapsed(start);
                        clear_dirty_log_total = timespec_add(clear_dirty_log_total,
                                                             ts_diff);
@@ -281,7 +305,7 @@ static void run_test(enum vm_guest_mode mode, void *arg)
                        clear_dirty_log_total.tv_nsec, avg.tv_sec, avg.tv_nsec);
        }
 
-       free(bmap);
+       free_bitmaps(bitmaps, p->slots);
        free(vcpu_threads);
        perf_test_destroy_vm(vm);
 }
@@ -308,11 +332,9 @@ static void help(char *name)
        printf(" -v: specify the number of vCPUs to run.\n");
        printf(" -o: Overlap guest memory accesses instead of partitioning\n"
               "     them into a separate region of memory for each vCPU.\n");
-       printf(" -s: specify the type of memory that should be used to\n"
-              "     back the guest data region.\n\n");
+       backing_src_help("-s");
        printf(" -x: Split the memory region into this number of memslots.\n"
-              "     (default: 1)");
-       backing_src_help();
+              "     (default: 1)\n");
        puts("");
        exit(0);
 }
@@ -324,7 +346,7 @@ int main(int argc, char *argv[])
                .iterations = TEST_HOST_LOOP_N,
                .wr_fract = 1,
                .partition_vcpu_memory_access = true,
-               .backing_src = VM_MEM_SRC_ANONYMOUS,
+               .backing_src = DEFAULT_VM_MEM_SRC,
                .slots = 1,
        };
        int opt;
index d79be15..f8fddc8 100644 (file)
@@ -90,18 +90,23 @@ enum vm_mem_backing_src_type {
        NUM_SRC_TYPES,
 };
 
+#define DEFAULT_VM_MEM_SRC VM_MEM_SRC_ANONYMOUS
+
 struct vm_mem_backing_src_alias {
        const char *name;
        uint32_t flag;
 };
 
+#define MIN_RUN_DELAY_NS       200000UL
+
 bool thp_configured(void);
 size_t get_trans_hugepagesz(void);
 size_t get_def_hugetlb_pagesz(void);
 const struct vm_mem_backing_src_alias *vm_mem_backing_src_alias(uint32_t i);
 size_t get_backing_src_pagesz(uint32_t i);
-void backing_src_help(void);
+void backing_src_help(const char *flag);
 enum vm_mem_backing_src_type parse_backing_src_type(const char *type_name);
+long get_run_delay(void);
 
 /*
  * Whether or not the given source type is shared memory (as opposed to
index 242ae8e..05e65ca 100644 (file)
@@ -312,37 +312,37 @@ static inline void set_xmm(int n, unsigned long val)
        }
 }
 
-typedef unsigned long v1di __attribute__ ((vector_size (8)));
+#define GET_XMM(__xmm)                                                 \
+({                                                                     \
+       unsigned long __val;                                            \
+       asm volatile("movq %%"#__xmm", %0" : "=r"(__val));              \
+       __val;                                                          \
+})
+
 static inline unsigned long get_xmm(int n)
 {
        assert(n >= 0 && n <= 7);
 
-       register v1di xmm0 __asm__("%xmm0");
-       register v1di xmm1 __asm__("%xmm1");
-       register v1di xmm2 __asm__("%xmm2");
-       register v1di xmm3 __asm__("%xmm3");
-       register v1di xmm4 __asm__("%xmm4");
-       register v1di xmm5 __asm__("%xmm5");
-       register v1di xmm6 __asm__("%xmm6");
-       register v1di xmm7 __asm__("%xmm7");
        switch (n) {
        case 0:
-               return (unsigned long)xmm0;
+               return GET_XMM(xmm0);
        case 1:
-               return (unsigned long)xmm1;
+               return GET_XMM(xmm1);
        case 2:
-               return (unsigned long)xmm2;
+               return GET_XMM(xmm2);
        case 3:
-               return (unsigned long)xmm3;
+               return GET_XMM(xmm3);
        case 4:
-               return (unsigned long)xmm4;
+               return GET_XMM(xmm4);
        case 5:
-               return (unsigned long)xmm5;
+               return GET_XMM(xmm5);
        case 6:
-               return (unsigned long)xmm6;
+               return GET_XMM(xmm6);
        case 7:
-               return (unsigned long)xmm7;
+               return GET_XMM(xmm7);
        }
+
+       /* never reached */
        return 0;
 }
 
index 0d04a7d..36407cb 100644 (file)
@@ -456,10 +456,7 @@ static void help(char *name)
               "     (default: 1G)\n");
        printf(" -v: specify the number of vCPUs to run\n"
               "     (default: 1)\n");
-       printf(" -s: specify the type of memory that should be used to\n"
-              "     back the guest data region.\n"
-              "     (default: anonymous)\n\n");
-       backing_src_help();
+       backing_src_help("-s");
        puts("");
 }
 
@@ -468,7 +465,7 @@ int main(int argc, char *argv[])
        int max_vcpus = kvm_check_cap(KVM_CAP_MAX_VCPUS);
        struct test_params p = {
                .test_mem_size = DEFAULT_TEST_MEM_SIZE,
-               .src_type = VM_MEM_SRC_ANONYMOUS,
+               .src_type = DEFAULT_VM_MEM_SRC,
        };
        int opt;
 
index af1031f..b724291 100644 (file)
@@ -11,6 +11,7 @@
 #include <stdlib.h>
 #include <time.h>
 #include <sys/stat.h>
+#include <sys/syscall.h>
 #include <linux/mman.h>
 #include "linux/kernel.h"
 
@@ -129,13 +130,16 @@ size_t get_trans_hugepagesz(void)
 {
        size_t size;
        FILE *f;
+       int ret;
 
        TEST_ASSERT(thp_configured(), "THP is not configured in host kernel");
 
        f = fopen("/sys/kernel/mm/transparent_hugepage/hpage_pmd_size", "r");
        TEST_ASSERT(f != NULL, "Error in opening transparent_hugepage/hpage_pmd_size");
 
-       fscanf(f, "%ld", &size);
+       ret = fscanf(f, "%ld", &size);
+       ret = fscanf(f, "%ld", &size);
+       TEST_ASSERT(ret < 1, "Error reading transparent_hugepage/hpage_pmd_size");
        fclose(f);
 
        return size;
@@ -279,13 +283,22 @@ size_t get_backing_src_pagesz(uint32_t i)
        }
 }
 
-void backing_src_help(void)
+static void print_available_backing_src_types(const char *prefix)
 {
        int i;
 
-       printf("Available backing src types:\n");
+       printf("%sAvailable backing src types:\n", prefix);
+
        for (i = 0; i < NUM_SRC_TYPES; i++)
-               printf("\t%s\n", vm_mem_backing_src_alias(i)->name);
+               printf("%s    %s\n", prefix, vm_mem_backing_src_alias(i)->name);
+}
+
+void backing_src_help(const char *flag)
+{
+       printf(" %s: specify the type of memory that should be used to\n"
+              "     back the guest data region. (default: %s)\n",
+              flag, vm_mem_backing_src_alias(DEFAULT_VM_MEM_SRC)->name);
+       print_available_backing_src_types("     ");
 }
 
 enum vm_mem_backing_src_type parse_backing_src_type(const char *type_name)
@@ -296,7 +309,23 @@ enum vm_mem_backing_src_type parse_backing_src_type(const char *type_name)
                if (!strcmp(type_name, vm_mem_backing_src_alias(i)->name))
                        return i;
 
-       backing_src_help();
+       print_available_backing_src_types("");
        TEST_FAIL("Unknown backing src type: %s", type_name);
        return -1;
 }
+
+long get_run_delay(void)
+{
+       char path[64];
+       long val[2];
+       FILE *fp;
+
+       sprintf(path, "/proc/%ld/schedstat", syscall(SYS_gettid));
+       fp = fopen(path, "r");
+       /* Return MIN_RUN_DELAY_NS upon failure just to be safe */
+       if (fscanf(fp, "%ld %ld ", &val[0], &val[1]) < 2)
+               val[1] = MIN_RUN_DELAY_NS;
+       fclose(fp);
+
+       return val[1];
+}
diff --git a/tools/testing/selftests/kvm/rseq_test.c b/tools/testing/selftests/kvm/rseq_test.c
new file mode 100644 (file)
index 0000000..4158da0
--- /dev/null
@@ -0,0 +1,286 @@
+// SPDX-License-Identifier: GPL-2.0-only
+#define _GNU_SOURCE /* for program_invocation_short_name */
+#include <errno.h>
+#include <fcntl.h>
+#include <pthread.h>
+#include <sched.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <signal.h>
+#include <syscall.h>
+#include <sys/ioctl.h>
+#include <sys/sysinfo.h>
+#include <asm/barrier.h>
+#include <linux/atomic.h>
+#include <linux/rseq.h>
+#include <linux/unistd.h>
+
+#include "kvm_util.h"
+#include "processor.h"
+#include "test_util.h"
+
+#define VCPU_ID 0
+
+static __thread volatile struct rseq __rseq = {
+       .cpu_id = RSEQ_CPU_ID_UNINITIALIZED,
+};
+
+/*
+ * Use an arbitrary, bogus signature for configuring rseq, this test does not
+ * actually enter an rseq critical section.
+ */
+#define RSEQ_SIG 0xdeadbeef
+
+/*
+ * Any bug related to task migration is likely to be timing-dependent; perform
+ * a large number of migrations to reduce the odds of a false negative.
+ */
+#define NR_TASK_MIGRATIONS 100000
+
+static pthread_t migration_thread;
+static cpu_set_t possible_mask;
+static int min_cpu, max_cpu;
+static bool done;
+
+static atomic_t seq_cnt;
+
+static void guest_code(void)
+{
+       for (;;)
+               GUEST_SYNC(0);
+}
+
+static void sys_rseq(int flags)
+{
+       int r;
+
+       r = syscall(__NR_rseq, &__rseq, sizeof(__rseq), flags, RSEQ_SIG);
+       TEST_ASSERT(!r, "rseq failed, errno = %d (%s)", errno, strerror(errno));
+}
+
+static int next_cpu(int cpu)
+{
+       /*
+        * Advance to the next CPU, skipping those that weren't in the original
+        * affinity set.  Sadly, there is no CPU_SET_FOR_EACH, and cpu_set_t's
+        * data storage is considered as opaque.  Note, if this task is pinned
+        * to a small set of discontigous CPUs, e.g. 2 and 1023, this loop will
+        * burn a lot cycles and the test will take longer than normal to
+        * complete.
+        */
+       do {
+               cpu++;
+               if (cpu > max_cpu) {
+                       cpu = min_cpu;
+                       TEST_ASSERT(CPU_ISSET(cpu, &possible_mask),
+                                   "Min CPU = %d must always be usable", cpu);
+                       break;
+               }
+       } while (!CPU_ISSET(cpu, &possible_mask));
+
+       return cpu;
+}
+
+static void *migration_worker(void *ign)
+{
+       cpu_set_t allowed_mask;
+       int r, i, cpu;
+
+       CPU_ZERO(&allowed_mask);
+
+       for (i = 0, cpu = min_cpu; i < NR_TASK_MIGRATIONS; i++, cpu = next_cpu(cpu)) {
+               CPU_SET(cpu, &allowed_mask);
+
+               /*
+                * Bump the sequence count twice to allow the reader to detect
+                * that a migration may have occurred in between rseq and sched
+                * CPU ID reads.  An odd sequence count indicates a migration
+                * is in-progress, while a completely different count indicates
+                * a migration occurred since the count was last read.
+                */
+               atomic_inc(&seq_cnt);
+
+               /*
+                * Ensure the odd count is visible while sched_getcpu() isn't
+                * stable, i.e. while changing affinity is in-progress.
+                */
+               smp_wmb();
+               r = sched_setaffinity(0, sizeof(allowed_mask), &allowed_mask);
+               TEST_ASSERT(!r, "sched_setaffinity failed, errno = %d (%s)",
+                           errno, strerror(errno));
+               smp_wmb();
+               atomic_inc(&seq_cnt);
+
+               CPU_CLR(cpu, &allowed_mask);
+
+               /*
+                * Wait 1-10us before proceeding to the next iteration and more
+                * specifically, before bumping seq_cnt again.  A delay is
+                * needed on three fronts:
+                *
+                *  1. To allow sched_setaffinity() to prompt migration before
+                *     ioctl(KVM_RUN) enters the guest so that TIF_NOTIFY_RESUME
+                *     (or TIF_NEED_RESCHED, which indirectly leads to handling
+                *     NOTIFY_RESUME) is handled in KVM context.
+                *
+                *     If NOTIFY_RESUME/NEED_RESCHED is set after KVM enters
+                *     the guest, the guest will trigger a IO/MMIO exit all the
+                *     way to userspace and the TIF flags will be handled by
+                *     the generic "exit to userspace" logic, not by KVM.  The
+                *     exit to userspace is necessary to give the test a chance
+                *     to check the rseq CPU ID (see #2).
+                *
+                *     Alternatively, guest_code() could include an instruction
+                *     to trigger an exit that is handled by KVM, but any such
+                *     exit requires architecture specific code.
+                *
+                *  2. To let ioctl(KVM_RUN) make its way back to the test
+                *     before the next round of migration.  The test's check on
+                *     the rseq CPU ID must wait for migration to complete in
+                *     order to avoid false positive, thus any kernel rseq bug
+                *     will be missed if the next migration starts before the
+                *     check completes.
+                *
+                *  3. To ensure the read-side makes efficient forward progress,
+                *     e.g. if sched_getcpu() involves a syscall.  Stalling the
+                *     read-side means the test will spend more time waiting for
+                *     sched_getcpu() to stabilize and less time trying to hit
+                *     the timing-dependent bug.
+                *
+                * Because any bug in this area is likely to be timing-dependent,
+                * run with a range of delays at 1us intervals from 1us to 10us
+                * as a best effort to avoid tuning the test to the point where
+                * it can hit _only_ the original bug and not detect future
+                * regressions.
+                *
+                * The original bug can reproduce with a delay up to ~500us on
+                * x86-64, but starts to require more iterations to reproduce
+                * as the delay creeps above ~10us, and the average runtime of
+                * each iteration obviously increases as well.  Cap the delay
+                * at 10us to keep test runtime reasonable while minimizing
+                * potential coverage loss.
+                *
+                * The lower bound for reproducing the bug is likely below 1us,
+                * e.g. failures occur on x86-64 with nanosleep(0), but at that
+                * point the overhead of the syscall likely dominates the delay.
+                * Use usleep() for simplicity and to avoid unnecessary kernel
+                * dependencies.
+                */
+               usleep((i % 10) + 1);
+       }
+       done = true;
+       return NULL;
+}
+
+static int calc_min_max_cpu(void)
+{
+       int i, cnt, nproc;
+
+       if (CPU_COUNT(&possible_mask) < 2)
+               return -EINVAL;
+
+       /*
+        * CPU_SET doesn't provide a FOR_EACH helper, get the min/max CPU that
+        * this task is affined to in order to reduce the time spent querying
+        * unusable CPUs, e.g. if this task is pinned to a small percentage of
+        * total CPUs.
+        */
+       nproc = get_nprocs_conf();
+       min_cpu = -1;
+       max_cpu = -1;
+       cnt = 0;
+
+       for (i = 0; i < nproc; i++) {
+               if (!CPU_ISSET(i, &possible_mask))
+                       continue;
+               if (min_cpu == -1)
+                       min_cpu = i;
+               max_cpu = i;
+               cnt++;
+       }
+
+       return (cnt < 2) ? -EINVAL : 0;
+}
+
+int main(int argc, char *argv[])
+{
+       int r, i, snapshot;
+       struct kvm_vm *vm;
+       u32 cpu, rseq_cpu;
+
+       /* Tell stdout not to buffer its content */
+       setbuf(stdout, NULL);
+
+       r = sched_getaffinity(0, sizeof(possible_mask), &possible_mask);
+       TEST_ASSERT(!r, "sched_getaffinity failed, errno = %d (%s)", errno,
+                   strerror(errno));
+
+       if (calc_min_max_cpu()) {
+               print_skip("Only one usable CPU, task migration not possible");
+               exit(KSFT_SKIP);
+       }
+
+       sys_rseq(0);
+
+       /*
+        * Create and run a dummy VM that immediately exits to userspace via
+        * GUEST_SYNC, while concurrently migrating the process by setting its
+        * CPU affinity.
+        */
+       vm = vm_create_default(VCPU_ID, 0, guest_code);
+       ucall_init(vm, NULL);
+
+       pthread_create(&migration_thread, NULL, migration_worker, 0);
+
+       for (i = 0; !done; i++) {
+               vcpu_run(vm, VCPU_ID);
+               TEST_ASSERT(get_ucall(vm, VCPU_ID, NULL) == UCALL_SYNC,
+                           "Guest failed?");
+
+               /*
+                * Verify rseq's CPU matches sched's CPU.  Ensure migration
+                * doesn't occur between sched_getcpu() and reading the rseq
+                * cpu_id by rereading both if the sequence count changes, or
+                * if the count is odd (migration in-progress).
+                */
+               do {
+                       /*
+                        * Drop bit 0 to force a mismatch if the count is odd,
+                        * i.e. if a migration is in-progress.
+                        */
+                       snapshot = atomic_read(&seq_cnt) & ~1;
+
+                       /*
+                        * Ensure reading sched_getcpu() and rseq.cpu_id
+                        * complete in a single "no migration" window, i.e. are
+                        * not reordered across the seq_cnt reads.
+                        */
+                       smp_rmb();
+                       cpu = sched_getcpu();
+                       rseq_cpu = READ_ONCE(__rseq.cpu_id);
+                       smp_rmb();
+               } while (snapshot != atomic_read(&seq_cnt));
+
+               TEST_ASSERT(rseq_cpu == cpu,
+                           "rseq CPU = %d, sched CPU = %d\n", rseq_cpu, cpu);
+       }
+
+       /*
+        * Sanity check that the test was able to enter the guest a reasonable
+        * number of times, e.g. didn't get stalled too often/long waiting for
+        * sched_getcpu() to stabilize.  A 2:1 migration:KVM_RUN ratio is a
+        * fairly conservative ratio on x86-64, which can do _more_ KVM_RUNs
+        * than migrations given the 1us+ delay in the migration task.
+        */
+       TEST_ASSERT(i > (NR_TASK_MIGRATIONS / 2),
+                   "Only performed %d KVM_RUNs, task stalled too much?\n", i);
+
+       pthread_join(migration_thread, NULL);
+
+       kvm_vm_free(vm);
+
+       sys_rseq(RSEQ_FLAG_UNREGISTER);
+
+       return 0;
+}
index ecec308..62f2eb9 100644 (file)
@@ -10,7 +10,6 @@
 #include <sched.h>
 #include <pthread.h>
 #include <linux/kernel.h>
-#include <sys/syscall.h>
 #include <asm/kvm.h>
 #include <asm/kvm_para.h>
 
@@ -20,7 +19,6 @@
 
 #define NR_VCPUS               4
 #define ST_GPA_BASE            (1 << 30)
-#define MIN_RUN_DELAY_NS       200000UL
 
 static void *st_gva[NR_VCPUS];
 static uint64_t guest_stolen_time[NR_VCPUS];
@@ -118,12 +116,12 @@ struct st_time {
        uint64_t st_time;
 };
 
-static int64_t smccc(uint32_t func, uint32_t arg)
+static int64_t smccc(uint32_t func, uint64_t arg)
 {
        unsigned long ret;
 
        asm volatile(
-               "mov    x0, %1\n"
+               "mov    w0, %w1\n"
                "mov    x1, %2\n"
                "hvc    #0\n"
                "mov    %0, x0\n"
@@ -217,20 +215,6 @@ static void steal_time_dump(struct kvm_vm *vm, uint32_t vcpuid)
 
 #endif
 
-static long get_run_delay(void)
-{
-       char path[64];
-       long val[2];
-       FILE *fp;
-
-       sprintf(path, "/proc/%ld/schedstat", syscall(SYS_gettid));
-       fp = fopen(path, "r");
-       fscanf(fp, "%ld %ld ", &val[0], &val[1]);
-       fclose(fp);
-
-       return val[1];
-}
-
 static void *do_steal_time(void *arg)
 {
        struct timespec ts, stop;
index e6480fd..8039e1e 100644 (file)
@@ -82,7 +82,8 @@ int get_warnings_count(void)
        FILE *f;
 
        f = popen("dmesg | grep \"WARNING:\" | wc -l", "r");
-       fscanf(f, "%d", &warnings);
+       if (fscanf(f, "%d", &warnings) < 1)
+               warnings = 0;
        fclose(f);
 
        return warnings;
diff --git a/tools/testing/selftests/kvm/x86_64/svm_int_ctl_test.c b/tools/testing/selftests/kvm/x86_64/svm_int_ctl_test.c
new file mode 100644 (file)
index 0000000..df04f56
--- /dev/null
@@ -0,0 +1,128 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * svm_int_ctl_test
+ *
+ * Copyright (C) 2021, Red Hat, Inc.
+ *
+ * Nested SVM testing: test simultaneous use of V_IRQ from L1 and L0.
+ */
+
+#include "test_util.h"
+#include "kvm_util.h"
+#include "processor.h"
+#include "svm_util.h"
+#include "apic.h"
+
+#define VCPU_ID                0
+
+static struct kvm_vm *vm;
+
+bool vintr_irq_called;
+bool intr_irq_called;
+
+#define VINTR_IRQ_NUMBER 0x20
+#define INTR_IRQ_NUMBER 0x30
+
+static void vintr_irq_handler(struct ex_regs *regs)
+{
+       vintr_irq_called = true;
+}
+
+static void intr_irq_handler(struct ex_regs *regs)
+{
+       x2apic_write_reg(APIC_EOI, 0x00);
+       intr_irq_called = true;
+}
+
+static void l2_guest_code(struct svm_test_data *svm)
+{
+       /* This code raises interrupt INTR_IRQ_NUMBER in the L1's LAPIC,
+        * and since L1 didn't enable virtual interrupt masking,
+        * L2 should receive it and not L1.
+        *
+        * L2 also has virtual interrupt 'VINTR_IRQ_NUMBER' pending in V_IRQ
+        * so it should also receive it after the following 'sti'.
+        */
+       x2apic_write_reg(APIC_ICR,
+               APIC_DEST_SELF | APIC_INT_ASSERT | INTR_IRQ_NUMBER);
+
+       __asm__ __volatile__(
+               "sti\n"
+               "nop\n"
+       );
+
+       GUEST_ASSERT(vintr_irq_called);
+       GUEST_ASSERT(intr_irq_called);
+
+       __asm__ __volatile__(
+               "vmcall\n"
+       );
+}
+
+static void l1_guest_code(struct svm_test_data *svm)
+{
+       #define L2_GUEST_STACK_SIZE 64
+       unsigned long l2_guest_stack[L2_GUEST_STACK_SIZE];
+       struct vmcb *vmcb = svm->vmcb;
+
+       x2apic_enable();
+
+       /* Prepare for L2 execution. */
+       generic_svm_setup(svm, l2_guest_code,
+                         &l2_guest_stack[L2_GUEST_STACK_SIZE]);
+
+       /* No virtual interrupt masking */
+       vmcb->control.int_ctl &= ~V_INTR_MASKING_MASK;
+
+       /* No intercepts for real and virtual interrupts */
+       vmcb->control.intercept &= ~(1ULL << INTERCEPT_INTR | INTERCEPT_VINTR);
+
+       /* Make a virtual interrupt VINTR_IRQ_NUMBER pending */
+       vmcb->control.int_ctl |= V_IRQ_MASK | (0x1 << V_INTR_PRIO_SHIFT);
+       vmcb->control.int_vector = VINTR_IRQ_NUMBER;
+
+       run_guest(vmcb, svm->vmcb_gpa);
+       GUEST_ASSERT(vmcb->control.exit_code == SVM_EXIT_VMMCALL);
+       GUEST_DONE();
+}
+
+int main(int argc, char *argv[])
+{
+       vm_vaddr_t svm_gva;
+
+       nested_svm_check_supported();
+
+       vm = vm_create_default(VCPU_ID, 0, (void *) l1_guest_code);
+
+       vm_init_descriptor_tables(vm);
+       vcpu_init_descriptor_tables(vm, VCPU_ID);
+
+       vm_install_exception_handler(vm, VINTR_IRQ_NUMBER, vintr_irq_handler);
+       vm_install_exception_handler(vm, INTR_IRQ_NUMBER, intr_irq_handler);
+
+       vcpu_alloc_svm(vm, &svm_gva);
+       vcpu_args_set(vm, VCPU_ID, 1, svm_gva);
+
+       struct kvm_run *run = vcpu_state(vm, VCPU_ID);
+       struct ucall uc;
+
+       vcpu_run(vm, VCPU_ID);
+       TEST_ASSERT(run->exit_reason == KVM_EXIT_IO,
+                   "Got exit_reason other than KVM_EXIT_IO: %u (%s)\n",
+                   run->exit_reason,
+                   exit_reason_str(run->exit_reason));
+
+       switch (get_ucall(vm, VCPU_ID, &uc)) {
+       case UCALL_ABORT:
+               TEST_FAIL("%s", (const char *)uc.args[0]);
+               break;
+               /* NOT REACHED */
+       case UCALL_DONE:
+               goto done;
+       default:
+               TEST_FAIL("Unknown ucall 0x%lx.", uc.cmd);
+       }
+done:
+       kvm_vm_free(vm);
+       return 0;
+}
index 117bf49..eda0d2a 100644 (file)
@@ -14,7 +14,6 @@
 #include <stdint.h>
 #include <time.h>
 #include <sched.h>
-#include <sys/syscall.h>
 
 #define VCPU_ID                5
 
@@ -98,20 +97,6 @@ static void guest_code(void)
        GUEST_DONE();
 }
 
-static long get_run_delay(void)
-{
-        char path[64];
-        long val[2];
-        FILE *fp;
-
-        sprintf(path, "/proc/%ld/schedstat", syscall(SYS_gettid));
-        fp = fopen(path, "r");
-        fscanf(fp, "%ld %ld ", &val[0], &val[1]);
-        fclose(fp);
-
-        return val[1];
-}
-
 static int cmp_timespec(struct timespec *a, struct timespec *b)
 {
        if (a->tv_sec > b->tv_sec)
index fa2ac0e..fe7ee2b 100644 (file)
@@ -48,6 +48,7 @@ ARCH          ?= $(SUBARCH)
 # When local build is done, headers are installed in the default
 # INSTALL_HDR_PATH usr/include.
 .PHONY: khdr
+.NOTPARALLEL:
 khdr:
 ifndef KSFT_KHDR_INSTALL_DONE
 ifeq (1,$(DEFAULT_INSTALL_HDR_PATH))
index e1bf55d..162c41e 100644 (file)
@@ -746,7 +746,7 @@ int read_write_nci_cmd(int nfc_sock, int virtual_fd, const __u8 *cmd, __u32 cmd_
                       const __u8 *rsp, __u32 rsp_len)
 {
        char buf[256];
-       unsigned int len;
+       int len;
 
        send(nfc_sock, &cmd[3], cmd_len - 3, 0);
        len = read(virtual_fd, buf, cmd_len);
index cfc7f4f..df34164 100644 (file)
@@ -1,5 +1,2 @@
-##TEST_GEN_FILES := test_unix_oob
-TEST_PROGS := test_unix_oob
+TEST_GEN_PROGS := test_unix_oob
 include ../../lib.mk
-
-all: $(TEST_PROGS)
index 0f3e376..3dece8b 100644 (file)
@@ -271,8 +271,9 @@ main(int argc, char **argv)
        read_oob(pfd, &oob);
 
        if (!signal_recvd || len != 127 || oob != '%' || atmark != 1) {
-               fprintf(stderr, "Test 3 failed, sigurg %d len %d OOB %c ",
-               "atmark %d\n", signal_recvd, len, oob, atmark);
+               fprintf(stderr,
+                       "Test 3 failed, sigurg %d len %d OOB %c atmark %d\n",
+                       signal_recvd, len, oob, atmark);
                die(1);
        }
 
index 4254ddc..1ef9e41 100755 (executable)
@@ -45,7 +45,7 @@ altnames_test()
        check_err $? "Got unexpected long alternative name from link show JSON"
 
        ip link property del $DUMMY_DEV altname $SHORT_NAME
-       check_err $? "Failed to add short alternative name"
+       check_err $? "Failed to delete short alternative name"
 
        ip -j -p link show $SHORT_NAME &>/dev/null
        check_fail $? "Unexpected success while trying to do link show with deleted short alternative name"
index 3caf72b..a2489ec 100755 (executable)
@@ -468,10 +468,26 @@ out_bits()
   for i in {0..22}
   do
     ip -netns ioam-node-alpha route change db01::/64 encap ioam6 trace \
-           prealloc type ${bit2type[$i]} ns 123 size ${bit2size[$i]} dev veth0
-
-    run_test "out_bit$i" "${desc/<n>/$i}" ioam-node-alpha ioam-node-beta \
-           db01::2 db01::1 veth0 ${bit2type[$i]} 123
+           prealloc type ${bit2type[$i]} ns 123 size ${bit2size[$i]} \
+           dev veth0 &>/dev/null
+
+    local cmd_res=$?
+    local descr="${desc/<n>/$i}"
+
+    if [[ $i -ge 12 && $i -le 21 ]]
+    then
+      if [ $cmd_res != 0 ]
+      then
+        npassed=$((npassed+1))
+        log_test_passed "$descr"
+      else
+        nfailed=$((nfailed+1))
+        log_test_failed "$descr"
+      fi
+    else
+      run_test "out_bit$i" "$descr" ioam-node-alpha ioam-node-beta \
+             db01::2 db01::1 veth0 ${bit2type[$i]} 123
+    fi
   done
 
   bit2size[22]=$tmp
@@ -544,7 +560,7 @@ in_bits()
   local tmp=${bit2size[22]}
   bit2size[22]=$(( $tmp + ${#BETA[9]} + ((4 - (${#BETA[9]} % 4)) % 4) ))
 
-  for i in {0..22}
+  for i in {0..11} {22..22}
   do
     ip -netns ioam-node-alpha route change db01::/64 encap ioam6 trace \
            prealloc type ${bit2type[$i]} ns 123 size ${bit2size[$i]} dev veth0
index d376cb2..8f6997d 100644 (file)
@@ -94,16 +94,6 @@ enum {
        TEST_OUT_BIT9,
        TEST_OUT_BIT10,
        TEST_OUT_BIT11,
-       TEST_OUT_BIT12,
-       TEST_OUT_BIT13,
-       TEST_OUT_BIT14,
-       TEST_OUT_BIT15,
-       TEST_OUT_BIT16,
-       TEST_OUT_BIT17,
-       TEST_OUT_BIT18,
-       TEST_OUT_BIT19,
-       TEST_OUT_BIT20,
-       TEST_OUT_BIT21,
        TEST_OUT_BIT22,
        TEST_OUT_FULL_SUPP_TRACE,
 
@@ -125,16 +115,6 @@ enum {
        TEST_IN_BIT9,
        TEST_IN_BIT10,
        TEST_IN_BIT11,
-       TEST_IN_BIT12,
-       TEST_IN_BIT13,
-       TEST_IN_BIT14,
-       TEST_IN_BIT15,
-       TEST_IN_BIT16,
-       TEST_IN_BIT17,
-       TEST_IN_BIT18,
-       TEST_IN_BIT19,
-       TEST_IN_BIT20,
-       TEST_IN_BIT21,
        TEST_IN_BIT22,
        TEST_IN_FULL_SUPP_TRACE,
 
@@ -199,30 +179,6 @@ static int check_ioam_header(int tid, struct ioam6_trace_hdr *ioam6h,
                       ioam6h->nodelen != 2 ||
                       ioam6h->remlen;
 
-       case TEST_OUT_BIT12:
-       case TEST_IN_BIT12:
-       case TEST_OUT_BIT13:
-       case TEST_IN_BIT13:
-       case TEST_OUT_BIT14:
-       case TEST_IN_BIT14:
-       case TEST_OUT_BIT15:
-       case TEST_IN_BIT15:
-       case TEST_OUT_BIT16:
-       case TEST_IN_BIT16:
-       case TEST_OUT_BIT17:
-       case TEST_IN_BIT17:
-       case TEST_OUT_BIT18:
-       case TEST_IN_BIT18:
-       case TEST_OUT_BIT19:
-       case TEST_IN_BIT19:
-       case TEST_OUT_BIT20:
-       case TEST_IN_BIT20:
-       case TEST_OUT_BIT21:
-       case TEST_IN_BIT21:
-               return ioam6h->overflow ||
-                      ioam6h->nodelen ||
-                      ioam6h->remlen != 1;
-
        case TEST_OUT_BIT22:
        case TEST_IN_BIT22:
                return ioam6h->overflow ||
@@ -326,6 +282,66 @@ static int check_ioam6_data(__u8 **p, struct ioam6_trace_hdr *ioam6h,
                *p += sizeof(__u32);
        }
 
+       if (ioam6h->type.bit12) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit13) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit14) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit15) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit16) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit17) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit18) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit19) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit20) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
+       if (ioam6h->type.bit21) {
+               if (__be32_to_cpu(*((__u32 *)*p)) != 0xffffffff)
+                       return 1;
+               *p += sizeof(__u32);
+       }
+
        if (ioam6h->type.bit22) {
                len = cnf.sc_data ? strlen(cnf.sc_data) : 0;
                aligned = cnf.sc_data ? __ALIGN_KERNEL(len, 4) : 0;
@@ -455,26 +471,6 @@ static int str2id(const char *tname)
                return TEST_OUT_BIT10;
        if (!strcmp("out_bit11", tname))
                return TEST_OUT_BIT11;
-       if (!strcmp("out_bit12", tname))
-               return TEST_OUT_BIT12;
-       if (!strcmp("out_bit13", tname))
-               return TEST_OUT_BIT13;
-       if (!strcmp("out_bit14", tname))
-               return TEST_OUT_BIT14;
-       if (!strcmp("out_bit15", tname))
-               return TEST_OUT_BIT15;
-       if (!strcmp("out_bit16", tname))
-               return TEST_OUT_BIT16;
-       if (!strcmp("out_bit17", tname))
-               return TEST_OUT_BIT17;
-       if (!strcmp("out_bit18", tname))
-               return TEST_OUT_BIT18;
-       if (!strcmp("out_bit19", tname))
-               return TEST_OUT_BIT19;
-       if (!strcmp("out_bit20", tname))
-               return TEST_OUT_BIT20;
-       if (!strcmp("out_bit21", tname))
-               return TEST_OUT_BIT21;
        if (!strcmp("out_bit22", tname))
                return TEST_OUT_BIT22;
        if (!strcmp("out_full_supp_trace", tname))
@@ -509,26 +505,6 @@ static int str2id(const char *tname)
                return TEST_IN_BIT10;
        if (!strcmp("in_bit11", tname))
                return TEST_IN_BIT11;
-       if (!strcmp("in_bit12", tname))
-               return TEST_IN_BIT12;
-       if (!strcmp("in_bit13", tname))
-               return TEST_IN_BIT13;
-       if (!strcmp("in_bit14", tname))
-               return TEST_IN_BIT14;
-       if (!strcmp("in_bit15", tname))
-               return TEST_IN_BIT15;
-       if (!strcmp("in_bit16", tname))
-               return TEST_IN_BIT16;
-       if (!strcmp("in_bit17", tname))
-               return TEST_IN_BIT17;
-       if (!strcmp("in_bit18", tname))
-               return TEST_IN_BIT18;
-       if (!strcmp("in_bit19", tname))
-               return TEST_IN_BIT19;
-       if (!strcmp("in_bit20", tname))
-               return TEST_IN_BIT20;
-       if (!strcmp("in_bit21", tname))
-               return TEST_IN_BIT21;
        if (!strcmp("in_bit22", tname))
                return TEST_IN_BIT22;
        if (!strcmp("in_full_supp_trace", tname))
@@ -606,16 +582,6 @@ static int (*func[__TEST_MAX])(int, struct ioam6_trace_hdr *, __u32, __u16) = {
        [TEST_OUT_BIT9]         = check_ioam_header_and_data,
        [TEST_OUT_BIT10]                = check_ioam_header_and_data,
        [TEST_OUT_BIT11]                = check_ioam_header_and_data,
-       [TEST_OUT_BIT12]                = check_ioam_header,
-       [TEST_OUT_BIT13]                = check_ioam_header,
-       [TEST_OUT_BIT14]                = check_ioam_header,
-       [TEST_OUT_BIT15]                = check_ioam_header,
-       [TEST_OUT_BIT16]                = check_ioam_header,
-       [TEST_OUT_BIT17]                = check_ioam_header,
-       [TEST_OUT_BIT18]                = check_ioam_header,
-       [TEST_OUT_BIT19]                = check_ioam_header,
-       [TEST_OUT_BIT20]                = check_ioam_header,
-       [TEST_OUT_BIT21]                = check_ioam_header,
        [TEST_OUT_BIT22]                = check_ioam_header_and_data,
        [TEST_OUT_FULL_SUPP_TRACE]      = check_ioam_header_and_data,
        [TEST_IN_UNDEF_NS]              = check_ioam_header,
@@ -633,16 +599,6 @@ static int (*func[__TEST_MAX])(int, struct ioam6_trace_hdr *, __u32, __u16) = {
        [TEST_IN_BIT9]                  = check_ioam_header_and_data,
        [TEST_IN_BIT10]         = check_ioam_header_and_data,
        [TEST_IN_BIT11]         = check_ioam_header_and_data,
-       [TEST_IN_BIT12]         = check_ioam_header,
-       [TEST_IN_BIT13]         = check_ioam_header,
-       [TEST_IN_BIT14]         = check_ioam_header,
-       [TEST_IN_BIT15]         = check_ioam_header,
-       [TEST_IN_BIT16]         = check_ioam_header,
-       [TEST_IN_BIT17]         = check_ioam_header,
-       [TEST_IN_BIT18]         = check_ioam_header,
-       [TEST_IN_BIT19]         = check_ioam_header,
-       [TEST_IN_BIT20]         = check_ioam_header,
-       [TEST_IN_BIT21]         = check_ioam_header,
        [TEST_IN_BIT22]         = check_ioam_header_and_data,
        [TEST_IN_FULL_SUPP_TRACE]       = check_ioam_header_and_data,
        [TEST_FWD_FULL_SUPP_TRACE]      = check_ioam_header_and_data,
diff --git a/tools/testing/selftests/netfilter/nft_nat_zones.sh b/tools/testing/selftests/netfilter/nft_nat_zones.sh
new file mode 100755 (executable)
index 0000000..b9ab373
--- /dev/null
@@ -0,0 +1,309 @@
+#!/bin/bash
+#
+# Test connection tracking zone and NAT source port reallocation support.
+#
+
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+# Don't increase too much, 2000 clients should work
+# just fine but script can then take several minutes with
+# KASAN/debug builds.
+maxclients=100
+
+have_iperf=1
+ret=0
+
+# client1---.
+#            veth1-.
+#                  |
+#               NAT Gateway --veth0--> Server
+#                  | |
+#            veth2-' |
+# client2---'        |
+#  ....              |
+# clientX----vethX---'
+
+# All clients share identical IP address.
+# NAT Gateway uses policy routing and conntrack zones to isolate client
+# namespaces.  Each client connects to Server, each with colliding tuples:
+#   clientsaddr:10000 -> serveraddr:dport
+#   NAT Gateway is supposed to do port reallocation for each of the
+#   connections.
+
+sfx=$(mktemp -u "XXXXXXXX")
+gw="ns-gw-$sfx"
+cl1="ns-cl1-$sfx"
+cl2="ns-cl2-$sfx"
+srv="ns-srv-$sfx"
+
+v4gc1=$(sysctl -n net.ipv4.neigh.default.gc_thresh1 2>/dev/null)
+v4gc2=$(sysctl -n net.ipv4.neigh.default.gc_thresh2 2>/dev/null)
+v4gc3=$(sysctl -n net.ipv4.neigh.default.gc_thresh3 2>/dev/null)
+v6gc1=$(sysctl -n net.ipv6.neigh.default.gc_thresh1 2>/dev/null)
+v6gc2=$(sysctl -n net.ipv6.neigh.default.gc_thresh2 2>/dev/null)
+v6gc3=$(sysctl -n net.ipv6.neigh.default.gc_thresh3 2>/dev/null)
+
+cleanup()
+{
+       ip netns del $gw
+       ip netns del $srv
+       for i in $(seq 1 $maxclients); do
+               ip netns del ns-cl$i-$sfx 2>/dev/null
+       done
+
+       sysctl -q net.ipv4.neigh.default.gc_thresh1=$v4gc1 2>/dev/null
+       sysctl -q net.ipv4.neigh.default.gc_thresh2=$v4gc2 2>/dev/null
+       sysctl -q net.ipv4.neigh.default.gc_thresh3=$v4gc3 2>/dev/null
+       sysctl -q net.ipv6.neigh.default.gc_thresh1=$v6gc1 2>/dev/null
+       sysctl -q net.ipv6.neigh.default.gc_thresh2=$v6gc2 2>/dev/null
+       sysctl -q net.ipv6.neigh.default.gc_thresh3=$v6gc3 2>/dev/null
+}
+
+nft --version > /dev/null 2>&1
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not run test without nft tool"
+       exit $ksft_skip
+fi
+
+ip -Version > /dev/null 2>&1
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not run test without ip tool"
+       exit $ksft_skip
+fi
+
+conntrack -V > /dev/null 2>&1
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not run test without conntrack tool"
+       exit $ksft_skip
+fi
+
+iperf3 -v >/dev/null 2>&1
+if [ $? -ne 0 ];then
+       have_iperf=0
+fi
+
+ip netns add "$gw"
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not create net namespace $gw"
+       exit $ksft_skip
+fi
+ip -net "$gw" link set lo up
+
+trap cleanup EXIT
+
+ip netns add "$srv"
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not create server netns $srv"
+       exit $ksft_skip
+fi
+
+ip link add veth0 netns "$gw" type veth peer name eth0 netns "$srv"
+ip -net "$gw" link set veth0 up
+ip -net "$srv" link set lo up
+ip -net "$srv" link set eth0 up
+
+sysctl -q net.ipv6.neigh.default.gc_thresh1=512  2>/dev/null
+sysctl -q net.ipv6.neigh.default.gc_thresh2=1024 2>/dev/null
+sysctl -q net.ipv6.neigh.default.gc_thresh3=4096 2>/dev/null
+sysctl -q net.ipv4.neigh.default.gc_thresh1=512  2>/dev/null
+sysctl -q net.ipv4.neigh.default.gc_thresh2=1024 2>/dev/null
+sysctl -q net.ipv4.neigh.default.gc_thresh3=4096 2>/dev/null
+
+for i in $(seq 1 $maxclients);do
+  cl="ns-cl$i-$sfx"
+
+  ip netns add "$cl"
+  if [ $? -ne 0 ];then
+     echo "SKIP: Could not create client netns $cl"
+     exit $ksft_skip
+  fi
+  ip link add veth$i netns "$gw" type veth peer name eth0 netns "$cl" > /dev/null 2>&1
+  if [ $? -ne 0 ];then
+    echo "SKIP: No virtual ethernet pair device support in kernel"
+    exit $ksft_skip
+  fi
+done
+
+for i in $(seq 1 $maxclients);do
+  cl="ns-cl$i-$sfx"
+  echo netns exec "$cl" ip link set lo up
+  echo netns exec "$cl" ip link set eth0 up
+  echo netns exec "$cl" sysctl -q net.ipv4.tcp_syn_retries=2
+  echo netns exec "$gw" ip link set veth$i up
+  echo netns exec "$gw" sysctl -q net.ipv4.conf.veth$i.arp_ignore=2
+  echo netns exec "$gw" sysctl -q net.ipv4.conf.veth$i.rp_filter=0
+
+  # clients have same IP addresses.
+  echo netns exec "$cl" ip addr add 10.1.0.3/24 dev eth0
+  echo netns exec "$cl" ip addr add dead:1::3/64 dev eth0
+  echo netns exec "$cl" ip route add default via 10.1.0.2 dev eth0
+  echo netns exec "$cl" ip route add default via dead:1::2 dev eth0
+
+  # NB: same addresses on client-facing interfaces.
+  echo netns exec "$gw" ip addr add 10.1.0.2/24 dev veth$i
+  echo netns exec "$gw" ip addr add dead:1::2/64 dev veth$i
+
+  # gw: policy routing
+  echo netns exec "$gw" ip route add 10.1.0.0/24 dev veth$i table $((1000+i))
+  echo netns exec "$gw" ip route add dead:1::0/64 dev veth$i table $((1000+i))
+  echo netns exec "$gw" ip route add 10.3.0.0/24 dev veth0 table $((1000+i))
+  echo netns exec "$gw" ip route add dead:3::0/64 dev veth0 table $((1000+i))
+  echo netns exec "$gw" ip rule add fwmark $i lookup $((1000+i))
+done | ip -batch /dev/stdin
+
+ip -net "$gw" addr add 10.3.0.1/24 dev veth0
+ip -net "$gw" addr add dead:3::1/64 dev veth0
+
+ip -net "$srv" addr add 10.3.0.99/24 dev eth0
+ip -net "$srv" addr add dead:3::99/64 dev eth0
+
+ip netns exec $gw nft -f /dev/stdin<<EOF
+table inet raw {
+       map iiftomark {
+               type ifname : mark
+       }
+
+       map iiftozone {
+               typeof iifname : ct zone
+       }
+
+       set inicmp {
+               flags dynamic
+               type ipv4_addr . ifname . ipv4_addr
+       }
+       set inflows {
+               flags dynamic
+               type ipv4_addr . inet_service . ifname . ipv4_addr . inet_service
+       }
+
+       set inflows6 {
+               flags dynamic
+               type ipv6_addr . inet_service . ifname . ipv6_addr . inet_service
+       }
+
+       chain prerouting {
+               type filter hook prerouting priority -64000; policy accept;
+               ct original zone set meta iifname map @iiftozone
+               meta mark set meta iifname map @iiftomark
+
+               tcp flags & (syn|ack) == ack add @inflows { ip saddr . tcp sport . meta iifname . ip daddr . tcp dport counter }
+               add @inflows6 { ip6 saddr . tcp sport . meta iifname . ip6 daddr . tcp dport counter }
+               ip protocol icmp add @inicmp { ip saddr . meta iifname . ip daddr counter }
+       }
+
+       chain nat_postrouting {
+               type nat hook postrouting priority 0; policy accept;
+                ct mark set meta mark meta oifname veth0 masquerade
+       }
+
+       chain mangle_prerouting {
+               type filter hook prerouting priority -100; policy accept;
+               ct direction reply meta mark set ct mark
+       }
+}
+EOF
+
+( echo add element inet raw iiftomark \{
+       for i in $(seq 1 $((maxclients-1))); do
+               echo \"veth$i\" : $i,
+       done
+       echo \"veth$maxclients\" : $maxclients \}
+       echo add element inet raw iiftozone \{
+       for i in $(seq 1 $((maxclients-1))); do
+               echo \"veth$i\" : $i,
+       done
+       echo \"veth$maxclients\" : $maxclients \}
+) | ip netns exec $gw nft -f /dev/stdin
+
+ip netns exec "$gw" sysctl -q net.ipv4.conf.all.forwarding=1 > /dev/null
+ip netns exec "$gw" sysctl -q net.ipv6.conf.all.forwarding=1 > /dev/null
+ip netns exec "$gw" sysctl -q net.ipv4.conf.all.rp_filter=0 >/dev/null
+
+# useful for debugging: allows to use 'ping' from clients to gateway.
+ip netns exec "$gw" sysctl -q net.ipv4.fwmark_reflect=1 > /dev/null
+ip netns exec "$gw" sysctl -q net.ipv6.fwmark_reflect=1 > /dev/null
+
+for i in $(seq 1 $maxclients); do
+  cl="ns-cl$i-$sfx"
+  ip netns exec $cl ping -i 0.5 -q -c 3 10.3.0.99 > /dev/null 2>&1 &
+  if [ $? -ne 0 ]; then
+     echo FAIL: Ping failure from $cl 1>&2
+     ret=1
+     break
+  fi
+done
+
+wait
+
+for i in $(seq 1 $maxclients); do
+   ip netns exec $gw nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" | grep -q "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 counter packets 3 bytes 252 }"
+   if [ $? -ne 0 ];then
+      ret=1
+      echo "FAIL: counter icmp mismatch for veth$i" 1>&2
+      ip netns exec $gw nft get element inet raw inicmp "{ 10.1.0.3 . \"veth$i\" . 10.3.0.99 }" 1>&2
+      break
+   fi
+done
+
+ip netns exec $gw nft get element inet raw inicmp "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 }" | grep -q "{ 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * $maxclients)) bytes $((252 * $maxclients)) }"
+if [ $? -ne 0 ];then
+    ret=1
+    echo "FAIL: counter icmp mismatch for veth0: { 10.3.0.99 . \"veth0\" . 10.3.0.1 counter packets $((3 * $maxclients)) bytes $((252 * $maxclients)) }"
+    ip netns exec $gw nft get element inet raw inicmp "{ 10.3.99 . \"veth0\" . 10.3.0.1 }" 1>&2
+fi
+
+if  [ $ret -eq 0 ]; then
+       echo "PASS: ping test from all $maxclients namespaces"
+fi
+
+if [ $have_iperf -eq 0 ];then
+       echo "SKIP: iperf3 not installed"
+       if [ $ret -ne 0 ];then
+           exit $ret
+       fi
+       exit $ksft_skip
+fi
+
+ip netns exec $srv iperf3 -s > /dev/null 2>&1 &
+iperfpid=$!
+sleep 1
+
+for i in $(seq 1 $maxclients); do
+  if [ $ret -ne 0 ]; then
+     break
+  fi
+  cl="ns-cl$i-$sfx"
+  ip netns exec $cl iperf3 -c 10.3.0.99 --cport 10000 -n 1 > /dev/null
+  if [ $? -ne 0 ]; then
+     echo FAIL: Failure to connect for $cl 1>&2
+     ip netns exec $gw conntrack -S 1>&2
+     ret=1
+  fi
+done
+if [ $ret -eq 0 ];then
+       echo "PASS: iperf3 connections for all $maxclients net namespaces"
+fi
+
+kill $iperfpid
+wait
+
+for i in $(seq 1 $maxclients); do
+   ip netns exec $gw nft get element inet raw inflows "{ 10.1.0.3 . 10000 . \"veth$i\" . 10.3.0.99 . 5201 }" > /dev/null
+   if [ $? -ne 0 ];then
+      ret=1
+      echo "FAIL: can't find expected tcp entry for veth$i" 1>&2
+      break
+   fi
+done
+if [ $ret -eq 0 ];then
+       echo "PASS: Found client connection for all $maxclients net namespaces"
+fi
+
+ip netns exec $gw nft get element inet raw inflows "{ 10.3.0.99 . 5201 . \"veth0\" . 10.3.0.1 . 10000 }" > /dev/null
+if [ $? -ne 0 ];then
+    ret=1
+    echo "FAIL: cannot find return entry on veth0" 1>&2
+fi
+
+exit $ret
diff --git a/tools/testing/selftests/netfilter/nft_zones_many.sh b/tools/testing/selftests/netfilter/nft_zones_many.sh
new file mode 100755 (executable)
index 0000000..ac64637
--- /dev/null
@@ -0,0 +1,156 @@
+#!/bin/bash
+
+# Test insertion speed for packets with identical addresses/ports
+# that are all placed in distinct conntrack zones.
+
+sfx=$(mktemp -u "XXXXXXXX")
+ns="ns-$sfx"
+
+# Kselftest framework requirement - SKIP code is 4.
+ksft_skip=4
+
+zones=20000
+have_ct_tool=0
+ret=0
+
+cleanup()
+{
+       ip netns del $ns
+}
+
+ip netns add $ns
+if [ $? -ne 0 ];then
+       echo "SKIP: Could not create net namespace $gw"
+       exit $ksft_skip
+fi
+
+trap cleanup EXIT
+
+conntrack -V > /dev/null 2>&1
+if [ $? -eq 0 ];then
+       have_ct_tool=1
+fi
+
+ip -net "$ns" link set lo up
+
+test_zones() {
+       local max_zones=$1
+
+ip netns exec $ns sysctl -q net.netfilter.nf_conntrack_udp_timeout=3600
+ip netns exec $ns nft -f /dev/stdin<<EOF
+flush ruleset
+table inet raw {
+       map rndzone {
+               typeof numgen inc mod $max_zones : ct zone
+       }
+
+       chain output {
+               type filter hook output priority -64000; policy accept;
+               udp dport 12345  ct zone set numgen inc mod 65536 map @rndzone
+       }
+}
+EOF
+       (
+               echo "add element inet raw rndzone {"
+       for i in $(seq 1 $max_zones);do
+               echo -n "$i : $i"
+               if [ $i -lt $max_zones ]; then
+                       echo ","
+               else
+                       echo "}"
+               fi
+       done
+       ) | ip netns exec $ns nft -f /dev/stdin
+
+       local i=0
+       local j=0
+       local outerstart=$(date +%s%3N)
+       local stop=$outerstart
+
+       while [ $i -lt $max_zones ]; do
+               local start=$(date +%s%3N)
+               i=$((i + 10000))
+               j=$((j + 1))
+               dd if=/dev/zero of=/dev/stdout bs=8k count=10000 2>/dev/null | ip netns exec "$ns" nc -w 1 -q 1 -u -p 12345 127.0.0.1 12345 > /dev/null
+               if [ $? -ne 0 ] ;then
+                       ret=1
+                       break
+               fi
+
+               stop=$(date +%s%3N)
+               local duration=$((stop-start))
+               echo "PASS: added 10000 entries in $duration ms (now $i total, loop $j)"
+       done
+
+       if [ $have_ct_tool -eq 1 ]; then
+               local count=$(ip netns exec "$ns" conntrack -C)
+               local duration=$((stop-outerstart))
+
+               if [ $count -eq $max_zones ]; then
+                       echo "PASS: inserted $count entries from packet path in $duration ms total"
+               else
+                       ip netns exec $ns conntrack -S 1>&2
+                       echo "FAIL: inserted $count entries from packet path in $duration ms total, expected $max_zones entries"
+                       ret=1
+               fi
+       fi
+
+       if [ $ret -ne 0 ];then
+               echo "FAIL: insert $max_zones entries from packet path" 1>&2
+       fi
+}
+
+test_conntrack_tool() {
+       local max_zones=$1
+
+       ip netns exec $ns conntrack -F >/dev/null 2>/dev/null
+
+       local outerstart=$(date +%s%3N)
+       local start=$(date +%s%3N)
+       local stop=$start
+       local i=0
+       while [ $i -lt $max_zones ]; do
+               i=$((i + 1))
+               ip netns exec "$ns" conntrack -I -s 1.1.1.1 -d 2.2.2.2 --protonum 6 \
+                        --timeout 3600 --state ESTABLISHED --sport 12345 --dport 1000 --zone $i >/dev/null 2>&1
+               if [ $? -ne 0 ];then
+                       ip netns exec "$ns" conntrack -I -s 1.1.1.1 -d 2.2.2.2 --protonum 6 \
+                        --timeout 3600 --state ESTABLISHED --sport 12345 --dport 1000 --zone $i > /dev/null
+                       echo "FAIL: conntrack -I returned an error"
+                       ret=1
+                       break
+               fi
+
+               if [ $((i%10000)) -eq 0 ];then
+                       stop=$(date +%s%3N)
+
+                       local duration=$((stop-start))
+                       echo "PASS: added 10000 entries in $duration ms (now $i total)"
+                       start=$stop
+               fi
+       done
+
+       local count=$(ip netns exec "$ns" conntrack -C)
+       local duration=$((stop-outerstart))
+
+       if [ $count -eq $max_zones ]; then
+               echo "PASS: inserted $count entries via ctnetlink in $duration ms"
+       else
+               ip netns exec $ns conntrack -S 1>&2
+               echo "FAIL: inserted $count entries via ctnetlink in $duration ms, expected $max_zones entries ($duration ms)"
+               ret=1
+       fi
+}
+
+test_zones $zones
+
+if [ $have_ct_tool -eq 1 ];then
+       test_conntrack_tool $zones
+else
+       echo "SKIP: Could not run ctnetlink insertion test without conntrack tool"
+       if [ $ret -eq 0 ];then
+               exit $ksft_skip
+       fi
+fi
+
+exit $ret
index bd1ca25..aed632d 100644 (file)
@@ -1,5 +1,5 @@
 /* SPDX-License-Identifier: GPL-2.0 */
-#include <ppc-asm.h>
+#include <basic_asm.h>
 #include <asm/unistd.h>
 
        .text
@@ -26,3 +26,38 @@ FUNC_START(getppid_tm_suspended)
 1:
        li      r3, -1
        blr
+
+
+.macro scv level
+       .long (0x44000001 | (\level) << 5)
+.endm
+
+FUNC_START(getppid_scv_tm_active)
+       PUSH_BASIC_STACK(0)
+       tbegin.
+       beq 1f
+       li      r0, __NR_getppid
+       scv     0
+       tend.
+       POP_BASIC_STACK(0)
+       blr
+1:
+       li      r3, -1
+       POP_BASIC_STACK(0)
+       blr
+
+FUNC_START(getppid_scv_tm_suspended)
+       PUSH_BASIC_STACK(0)
+       tbegin.
+       beq 1f
+       li      r0, __NR_getppid
+       tsuspend.
+       scv     0
+       tresume.
+       tend.
+       POP_BASIC_STACK(0)
+       blr
+1:
+       li      r3, -1
+       POP_BASIC_STACK(0)
+       blr
index 467a6b3..b763354 100644 (file)
 #include "utils.h"
 #include "tm.h"
 
+#ifndef PPC_FEATURE2_SCV
+#define PPC_FEATURE2_SCV               0x00100000 /* scv syscall */
+#endif
+
 extern int getppid_tm_active(void);
 extern int getppid_tm_suspended(void);
+extern int getppid_scv_tm_active(void);
+extern int getppid_scv_tm_suspended(void);
 
 unsigned retries = 0;
 
 #define TEST_DURATION 10 /* seconds */
 
-pid_t getppid_tm(bool suspend)
+pid_t getppid_tm(bool scv, bool suspend)
 {
        int i;
        pid_t pid;
 
        for (i = 0; i < TM_RETRIES; i++) {
-               if (suspend)
-                       pid = getppid_tm_suspended();
-               else
-                       pid = getppid_tm_active();
+               if (suspend) {
+                       if (scv)
+                               pid = getppid_scv_tm_suspended();
+                       else
+                               pid = getppid_tm_suspended();
+               } else {
+                       if (scv)
+                               pid = getppid_scv_tm_active();
+                       else
+                               pid = getppid_tm_active();
+               }
 
                if (pid >= 0)
                        return pid;
@@ -82,15 +95,24 @@ int tm_syscall(void)
                 * Test a syscall within a suspended transaction and verify
                 * that it succeeds.
                 */
-               FAIL_IF(getppid_tm(true) == -1); /* Should succeed. */
+               FAIL_IF(getppid_tm(false, true) == -1); /* Should succeed. */
 
                /*
                 * Test a syscall within an active transaction and verify that
                 * it fails with the correct failure code.
                 */
-               FAIL_IF(getppid_tm(false) != -1);  /* Should fail... */
+               FAIL_IF(getppid_tm(false, false) != -1);  /* Should fail... */
                FAIL_IF(!failure_is_persistent()); /* ...persistently... */
                FAIL_IF(!failure_is_syscall());    /* ...with code syscall. */
+
+               /* Now do it all again with scv if it is available. */
+               if (have_hwcap2(PPC_FEATURE2_SCV)) {
+                       FAIL_IF(getppid_tm(true, true) == -1); /* Should succeed. */
+                       FAIL_IF(getppid_tm(true, false) != -1);  /* Should fail... */
+                       FAIL_IF(!failure_is_persistent()); /* ...persistently... */
+                       FAIL_IF(!failure_is_syscall());    /* ...with code syscall. */
+               }
+
                gettimeofday(&now, 0);
        }
 
index ee8208b..69c3ead 100644 (file)
@@ -265,12 +265,6 @@ nomem:
        }
 
        entry->ifnum = ifnum;
-
-       /* FIXME update USBDEVFS_CONNECTINFO so it tells about high speed etc */
-
-       fprintf(stderr, "%s speed\t%s\t%u\n",
-               speed(entry->speed), entry->name, entry->ifnum);
-
        entry->next = testdevs;
        testdevs = entry;
        return 0;
@@ -299,6 +293,14 @@ static void *handle_testdev (void *arg)
                return 0;
        }
 
+       status  =  ioctl(fd, USBDEVFS_GET_SPEED, NULL);
+       if (status < 0)
+               fprintf(stderr, "USBDEVFS_GET_SPEED failed %d\n", status);
+       else
+               dev->speed = status;
+       fprintf(stderr, "%s speed\t%s\t%u\n",
+                       speed(dev->speed), dev->name, dev->ifnum);
+
 restart:
        for (i = 0; i < TEST_CASES; i++) {
                if (dev->test != -1 && dev->test != i)
index 0517c74..f62f10c 100644 (file)
@@ -1331,7 +1331,7 @@ int main(int argc, char *argv[])
        if (opt_list && opt_list_mapcnt)
                kpagecount_fd = checked_open(PROC_KPAGECOUNT, O_RDONLY);
 
-       if (opt_mark_idle && opt_file)
+       if (opt_mark_idle)
                page_idle_fd = checked_open(SYS_KERNEL_MM_PAGE_IDLE, O_RDWR);
 
        if (opt_list && opt_pid)
index 439d3b4..7851f3a 100644 (file)
@@ -235,9 +235,13 @@ static void ack_flush(void *_completed)
 {
 }
 
-static inline bool kvm_kick_many_cpus(const struct cpumask *cpus, bool wait)
+static inline bool kvm_kick_many_cpus(cpumask_var_t tmp, bool wait)
 {
-       if (unlikely(!cpus))
+       const struct cpumask *cpus;
+
+       if (likely(cpumask_available(tmp)))
+               cpus = tmp;
+       else
                cpus = cpu_online_mask;
 
        if (cpumask_empty(cpus))
@@ -263,14 +267,34 @@ bool kvm_make_vcpus_request_mask(struct kvm *kvm, unsigned int req,
                        continue;
 
                kvm_make_request(req, vcpu);
-               cpu = vcpu->cpu;
 
                if (!(req & KVM_REQUEST_NO_WAKEUP) && kvm_vcpu_wake_up(vcpu))
                        continue;
 
-               if (tmp != NULL && cpu != -1 && cpu != me &&
-                   kvm_request_needs_ipi(vcpu, req))
-                       __cpumask_set_cpu(cpu, tmp);
+               /*
+                * tmp can be "unavailable" if cpumasks are allocated off stack
+                * as allocation of the mask is deliberately not fatal and is
+                * handled by falling back to kicking all online CPUs.
+                */
+               if (!cpumask_available(tmp))
+                       continue;
+
+               /*
+                * Note, the vCPU could get migrated to a different pCPU at any
+                * point after kvm_request_needs_ipi(), which could result in
+                * sending an IPI to the previous pCPU.  But, that's ok because
+                * the purpose of the IPI is to ensure the vCPU returns to
+                * OUTSIDE_GUEST_MODE, which is satisfied if the vCPU migrates.
+                * Entering READING_SHADOW_PAGE_TABLES after this point is also
+                * ok, as the requirement is only that KVM wait for vCPUs that
+                * were reading SPTEs _before_ any changes were finalized.  See
+                * kvm_vcpu_kick() for more details on handling requests.
+                */
+               if (kvm_request_needs_ipi(vcpu, req)) {
+                       cpu = READ_ONCE(vcpu->cpu);
+                       if (cpu != -1 && cpu != me)
+                               __cpumask_set_cpu(cpu, tmp);
+               }
        }
 
        called = kvm_kick_many_cpus(tmp, !!(req & KVM_REQUEST_WAIT));
@@ -302,13 +326,8 @@ EXPORT_SYMBOL_GPL(kvm_make_all_cpus_request);
 #ifndef CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL
 void kvm_flush_remote_tlbs(struct kvm *kvm)
 {
-       /*
-        * Read tlbs_dirty before setting KVM_REQ_TLB_FLUSH in
-        * kvm_make_all_cpus_request.
-        */
-       long dirty_count = smp_load_acquire(&kvm->tlbs_dirty);
-
        ++kvm->stat.generic.remote_tlb_flush_requests;
+
        /*
         * We want to publish modifications to the page tables before reading
         * mode. Pairs with a memory barrier in arch-specific code.
@@ -323,7 +342,6 @@ void kvm_flush_remote_tlbs(struct kvm *kvm)
        if (!kvm_arch_flush_remote_tlb(kvm)
            || kvm_make_all_cpus_request(kvm, KVM_REQ_TLB_FLUSH))
                ++kvm->stat.generic.remote_tlb_flush;
-       cmpxchg(&kvm->tlbs_dirty, dirty_count, 0);
 }
 EXPORT_SYMBOL_GPL(kvm_flush_remote_tlbs);
 #endif
@@ -528,7 +546,7 @@ static __always_inline int __kvm_handle_hva_range(struct kvm *kvm,
                }
        }
 
-       if (range->flush_on_ret && (ret || kvm->tlbs_dirty))
+       if (range->flush_on_ret && ret)
                kvm_flush_remote_tlbs(kvm);
 
        if (locked)
@@ -3134,15 +3152,19 @@ out:
 
 static void shrink_halt_poll_ns(struct kvm_vcpu *vcpu)
 {
-       unsigned int old, val, shrink;
+       unsigned int old, val, shrink, grow_start;
 
        old = val = vcpu->halt_poll_ns;
        shrink = READ_ONCE(halt_poll_ns_shrink);
+       grow_start = READ_ONCE(halt_poll_ns_grow_start);
        if (shrink == 0)
                val = 0;
        else
                val /= shrink;
 
+       if (val < grow_start)
+               val = 0;
+
        vcpu->halt_poll_ns = val;
        trace_kvm_halt_poll_ns_shrink(vcpu->vcpu_id, val, old);
 }
@@ -3290,16 +3312,24 @@ EXPORT_SYMBOL_GPL(kvm_vcpu_wake_up);
  */
 void kvm_vcpu_kick(struct kvm_vcpu *vcpu)
 {
-       int me;
-       int cpu = vcpu->cpu;
+       int me, cpu;
 
        if (kvm_vcpu_wake_up(vcpu))
                return;
 
+       /*
+        * Note, the vCPU could get migrated to a different pCPU at any point
+        * after kvm_arch_vcpu_should_kick(), which could result in sending an
+        * IPI to the previous pCPU.  But, that's ok because the purpose of the
+        * IPI is to force the vCPU to leave IN_GUEST_MODE, and migrating the
+        * vCPU also requires it to leave IN_GUEST_MODE.
+        */
        me = get_cpu();
-       if (cpu != me && (unsigned)cpu < nr_cpu_ids && cpu_online(cpu))
-               if (kvm_arch_vcpu_should_kick(vcpu))
+       if (kvm_arch_vcpu_should_kick(vcpu)) {
+               cpu = READ_ONCE(vcpu->cpu);
+               if (cpu != me && (unsigned)cpu < nr_cpu_ids && cpu_online(cpu))
                        smp_send_reschedule(cpu);
+       }
        put_cpu();
 }
 EXPORT_SYMBOL_GPL(kvm_vcpu_kick);