mISDN: hfcsusb: Use struct_size() helper
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 17 Jun 2020 23:15:57 +0000 (18:15 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Jun 2020 03:41:02 +0000 (20:41 -0700)
Make use of the struct_size() helper instead of an open-coded version
in order to avoid any potential type mistakes.

This code was detected with the help of Coccinelle and, audited and
fixed manually.

Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/hardware/mISDN/hfcsusb.c

index 621364b..4274906 100644 (file)
@@ -261,8 +261,7 @@ hfcsusb_ph_info(struct hfcsusb *hw)
                phi->bch[i].Flags = hw->bch[i].Flags;
        }
        _queue_data(&dch->dev.D, MPH_INFORMATION_IND, MISDN_ID_ANY,
-                   sizeof(struct ph_info_dch) + dch->dev.nrbchan *
-                   sizeof(struct ph_info_ch), phi, GFP_ATOMIC);
+                   struct_size(phi, bch, dch->dev.nrbchan), phi, GFP_ATOMIC);
        kfree(phi);
 }