smb: client: get rid of bounds check in SMB2_ioctl_init()
authorPaulo Alcantara <pc@manguebit.com>
Mon, 18 Nov 2024 15:35:15 +0000 (12:35 -0300)
committerSteve French <stfrench@microsoft.com>
Thu, 21 Nov 2024 16:45:50 +0000 (10:45 -0600)
smb2_set_next_command() no longer squashes request iovs into a single
iov, so the bounds check can be dropped.

Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Paulo Alcantara (Red Hat) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2pdu.c

index ab3a2ca..0552368 100644 (file)
@@ -3313,15 +3313,6 @@ SMB2_ioctl_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server,
                return rc;
 
        if (indatalen) {
-               unsigned int len;
-
-               if (WARN_ON_ONCE(smb3_encryption_required(tcon) &&
-                                (check_add_overflow(total_len - 1,
-                                                    ALIGN(indatalen, 8), &len) ||
-                                 len > MAX_CIFS_SMALL_BUFFER_SIZE))) {
-                       cifs_small_buf_release(req);
-                       return -EIO;
-               }
                /*
                 * indatalen is usually small at a couple of bytes max, so
                 * just allocate through generic pool