eth: bnxt: fix warning for define in struct_group
authorJakub Kicinski <kuba@kernel.org>
Thu, 27 Jul 2023 19:07:26 +0000 (12:07 -0700)
committerJakub Kicinski <kuba@kernel.org>
Fri, 28 Jul 2023 20:47:34 +0000 (13:47 -0700)
Fix C=1 warning with sparse 0.6.4:

drivers/net/ethernet/broadcom/bnxt/bnxt.c: note: in included file:
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h:30:1: warning: directive in macro's argument list

Don't put defines in a struct_group().

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Link: https://lore.kernel.org/r/20230727190726.1859515-3-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.h

index 7167425..5b2a6f6 100644 (file)
@@ -27,11 +27,12 @@ struct bnxt_cos2bw_cfg {
                u8              queue_id;
                __le32          min_bw;
                __le32          max_bw;
-#define BW_VALUE_UNIT_PERCENT1_100             (0x1UL << 29)
                u8              tsa;
                u8              pri_lvl;
                u8              bw_weight;
        );
+/* for min_bw / max_bw */
+#define BW_VALUE_UNIT_PERCENT1_100             (0x1UL << 29)
        u8                      unused;
 };