ASoC: rt1305: clarify expression
authorPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Tue, 2 Mar 2021 21:25:09 +0000 (15:25 -0600)
committerMark Brown <broonie@kernel.org>
Wed, 10 Mar 2021 13:09:58 +0000 (13:09 +0000)
cppcheck warning:

sound/soc/codecs/rt1305.c:853:63: style: Boolean result is used in
bitwise operation. Clarify expression with
parentheses. [clarifyCondition]
  (pll_code.m_bp ? 0 : pll_code.m_code) << RT1305_PLL_1_M_SFT |
                                                              ^

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20210302212527.55158-7-pierre-louis.bossart@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/rt1305.c

index 16aa405..7a00945 100644 (file)
@@ -850,8 +850,8 @@ static int rt1305_set_component_pll(struct snd_soc_component *component,
                pll_code.n_code, pll_code.k_code);
 
        snd_soc_component_write(component, RT1305_PLL1_1,
-               (pll_code.m_bp ? 0 : pll_code.m_code) << RT1305_PLL_1_M_SFT |
-               pll_code.m_bp << RT1305_PLL_1_M_BYPASS_SFT |
+               ((pll_code.m_bp ? 0 : pll_code.m_code) << RT1305_PLL_1_M_SFT) |
+               (pll_code.m_bp << RT1305_PLL_1_M_BYPASS_SFT) |
                pll_code.n_code);
        snd_soc_component_write(component, RT1305_PLL1_2,
                pll_code.k_code);