drm/xe/uapi: Remove useless max_page_size
authorRodrigo Vivi <rodrigo.vivi@intel.com>
Wed, 30 Aug 2023 21:47:15 +0000 (17:47 -0400)
committerRodrigo Vivi <rodrigo.vivi@intel.com>
Thu, 21 Dec 2023 16:41:06 +0000 (11:41 -0500)
The min_page_size is useful information to ensure alignment and it is
an API actually in use. However max_page_size doesn't bring any useful
information to the userspace hence being not used at all.

So, let's remove and only bring it back if that ever gets used.

Suggested-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Reviewed-by: Francois Dugast <francois.dugast@intel.com>
drivers/gpu/drm/xe/xe_query.c
include/uapi/drm/xe_drm.h

index c3d3969..a951205 100644 (file)
@@ -127,7 +127,6 @@ static int query_memory_usage(struct xe_device *xe,
        usage->regions[0].mem_class = XE_MEM_REGION_CLASS_SYSMEM;
        usage->regions[0].instance = 0;
        usage->regions[0].min_page_size = PAGE_SIZE;
-       usage->regions[0].max_page_size = PAGE_SIZE;
        usage->regions[0].total_size = man->size << PAGE_SHIFT;
        if (perfmon_capable())
                usage->regions[0].used = ttm_resource_manager_usage(man);
@@ -143,8 +142,6 @@ static int query_memory_usage(struct xe_device *xe,
                        usage->regions[usage->num_regions].min_page_size =
                                xe->info.vram_flags & XE_VRAM_FLAGS_NEED64K ?
                                SZ_64K : PAGE_SIZE;
-                       usage->regions[usage->num_regions].max_page_size =
-                               SZ_1G;
                        usage->regions[usage->num_regions].total_size =
                                man->size;
 
index 902b5c4..00d5cb4 100644 (file)
@@ -174,10 +174,6 @@ struct drm_xe_query_mem_region {
         * kernel.
         */
        __u32 min_page_size;
-       /**
-        * @max_page_size: Max page-size in bytes for this region.
-        */
-       __u32 max_page_size;
        /**
         * @total_size: The usable size in bytes for this region.
         */