pwm: dwc: simplify error handling
authorRaag Jadav <raag.jadav@intel.com>
Mon, 19 Feb 2024 03:38:35 +0000 (09:08 +0530)
committerUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Mon, 26 Feb 2024 10:14:46 +0000 (11:14 +0100)
Simplify error handling in ->probe() function using dev_err_probe() helper
and while at it, drop error codes from the message to prevent duplication.

Signed-off-by: Raag Jadav <raag.jadav@intel.com>
Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20240219033835.11369-5-raag.jadav@intel.com
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
drivers/pwm/pwm-dwc.c

index de95352..676eaf8 100644 (file)
@@ -53,18 +53,14 @@ static int dwc_pwm_probe(struct pci_dev *pci, const struct pci_device_id *id)
        int i, ret;
 
        ret = pcim_enable_device(pci);
-       if (ret) {
-               dev_err(dev, "Failed to enable device (%pe)\n", ERR_PTR(ret));
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to enable device\n");
 
        pci_set_master(pci);
 
        ret = pcim_iomap_regions(pci, BIT(0), pci_name(pci));
-       if (ret) {
-               dev_err(dev, "Failed to iomap PCI BAR (%pe)\n", ERR_PTR(ret));
-               return ret;
-       }
+       if (ret)
+               return dev_err_probe(dev, ret, "Failed to iomap PCI BAR\n");
 
        info = (const struct dwc_pwm_info *)id->driver_data;