drm/i915: Fix framestart_delay commens in VRR code
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 17 Nov 2021 18:31:03 +0000 (20:31 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 18 Nov 2021 20:31:15 +0000 (22:31 +0200)
Since I originally wrote these comments we decided to change our
definition of framestart_delay from 0-3 to 1-4. Adjust the comments
to match that new convention. The actual code was adjusted already.

Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211117183103.27418-3-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/display/intel_vrr.c

index db1c390..139e893 100644 (file)
@@ -60,7 +60,7 @@ intel_vrr_check_modeset(struct intel_atomic_state *state)
  * Between those two points the vblank exit starts (and hence registers get
  * latched) ASAP after a push is sent.
  *
- * framestart_delay is programmable 0-3.
+ * framestart_delay is programmable 1-4.
  */
 static int intel_vrr_vblank_exit_length(const struct intel_crtc_state *crtc_state)
 {
@@ -138,13 +138,13 @@ intel_vrr_compute_config(struct intel_crtc_state *crtc_state,
                        i915->window2_delay;
        else
                /*
-                * FIXME: s/4/framestart_delay+1/ to get consistent
+                * FIXME: s/4/framestart_delay/ to get consistent
                 * earliest/latest points for register latching regardless
                 * of the framestart_delay used?
                 *
                 * FIXME: this really needs the extra scanline to provide consistent
                 * behaviour for all framestart_delay values. Otherwise with
-                * framestart_delay==3 we will end up extending the min vblank by
+                * framestart_delay==4 we will end up extending the min vblank by
                 * one extra line.
                 */
                crtc_state->vrr.pipeline_full =