fbdev/simplefb: Suppress error on missing power domains
authorRichard Acayan <mailingradian@gmail.com>
Wed, 22 Nov 2023 00:54:59 +0000 (19:54 -0500)
committerHans de Goede <hdegoede@redhat.com>
Wed, 22 Nov 2023 08:51:16 +0000 (09:51 +0100)
When the power domains are missing, the call to of_count_phandle_with_args
fails with -ENOENT. The power domains are not required and there are
some device trees that do not specify them. Suppress this error to fix
devices without power domains attached to simplefb.

Fixes: 92a511a568e4 ("fbdev/simplefb: Add support for generic power-domains")
Closes: https://lore.kernel.org/linux-fbdev/ZVwFNfkqjrvhFHM0@radian
Signed-off-by: Richard Acayan <mailingradian@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231122005457.330066-3-mailingradian@gmail.com
drivers/video/fbdev/simplefb.c

index fe682af..6f58ee2 100644 (file)
@@ -466,6 +466,10 @@ static int simplefb_attach_genpds(struct simplefb_par *par,
        err = of_count_phandle_with_args(dev->of_node, "power-domains",
                                         "#power-domain-cells");
        if (err < 0) {
+               /* Nothing wrong if optional PDs are missing */
+               if (err == -ENOENT)
+                       return 0;
+
                dev_info(dev, "failed to parse power-domains: %d\n", err);
                return err;
        }