ASoC: codecs: fix error code in ntp8835_i2c_probe()
authorHarshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Wed, 23 Oct 2024 14:44:11 +0000 (07:44 -0700)
committerMark Brown <broonie@kernel.org>
Wed, 23 Oct 2024 15:30:54 +0000 (16:30 +0100)
When reset_control_deassert() fails it returns valid error codes stored
in return, pass that to dev_err_probe() instead of
PTR_ERR(ntp8835->reset).

Fixes: dc9004ea273a ("ASoC: codecs: Add NeoFidelity NTP8835 codec")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202409281054.DUTb5KxU-lkp@intel.com/
Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com>
Link: https://patch.msgid.link/20241023144421.1720234-1-harshit.m.mogalapalli@oracle.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/ntp8835.c

index 800bda6..796e141 100644 (file)
@@ -428,7 +428,7 @@ static int ntp8835_i2c_probe(struct i2c_client *i2c)
 
        ret = reset_control_deassert(ntp8835->reset);
        if (ret)
-               return dev_err_probe(&i2c->dev, PTR_ERR(ntp8835->reset),
+               return dev_err_probe(&i2c->dev, ret,
                                     "Failed to deassert reset\n");
 
        dev_set_drvdata(&i2c->dev, ntp8835);