octeontx2-pf: Add error log forcn10k_map_unmap_rq_policer()
authorWentao Liang <vulab@iscas.ac.cn>
Tue, 8 Apr 2025 03:26:02 +0000 (11:26 +0800)
committerJakub Kicinski <kuba@kernel.org>
Thu, 10 Apr 2025 00:59:21 +0000 (17:59 -0700)
The cn10k_free_matchall_ipolicer() calls the cn10k_map_unmap_rq_policer()
for each queue in a for loop without checking for any errors.

Check the return value of the cn10k_map_unmap_rq_policer() function during
each loop, and report a warning if the function fails.

Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250408032602.2909-1-vulab@iscas.ac.cn
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/nic/cn10k.c

index c3b6e0f..7f6a435 100644 (file)
@@ -357,9 +357,12 @@ int cn10k_free_matchall_ipolicer(struct otx2_nic *pfvf)
        mutex_lock(&pfvf->mbox.lock);
 
        /* Remove RQ's policer mapping */
-       for (qidx = 0; qidx < hw->rx_queues; qidx++)
-               cn10k_map_unmap_rq_policer(pfvf, qidx,
-                                          hw->matchall_ipolicer, false);
+       for (qidx = 0; qidx < hw->rx_queues; qidx++) {
+               rc = cn10k_map_unmap_rq_policer(pfvf, qidx, hw->matchall_ipolicer, false);
+               if (rc)
+                       dev_warn(pfvf->dev, "Failed to unmap RQ %d's policer (error %d).",
+                                qidx, rc);
+       }
 
        rc = cn10k_free_leaf_profile(pfvf, hw->matchall_ipolicer);