arm64/cpu: Mark cpu_die() __noreturn
authorJosh Poimboeuf <jpoimboe@kernel.org>
Thu, 16 Feb 2023 18:42:01 +0000 (10:42 -0800)
committerJosh Poimboeuf <jpoimboe@kernel.org>
Mon, 6 Mar 2023 23:34:04 +0000 (15:34 -0800)
cpu_die() doesn't return.  Annotate it as such.  By extension this also
makes arch_cpu_idle_dead() noreturn.

Acked-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Link: https://lkml.kernel.org/r/20230216184157.4hup6y6mmspr2kll@treble
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
arch/arm64/include/asm/smp.h
arch/arm64/kernel/smp.c

index fc55f5a..5733a31 100644 (file)
@@ -100,7 +100,7 @@ static inline void arch_send_wakeup_ipi_mask(const struct cpumask *mask)
 extern int __cpu_disable(void);
 
 extern void __cpu_die(unsigned int cpu);
-extern void cpu_die(void);
+extern void __noreturn cpu_die(void);
 extern void cpu_die_early(void);
 
 static inline void cpu_park_loop(void)
index 4e83272..d5d09a1 100644 (file)
@@ -361,7 +361,7 @@ void __cpu_die(unsigned int cpu)
  * Called from the idle thread for the CPU which has been shutdown.
  *
  */
-void cpu_die(void)
+void __noreturn cpu_die(void)
 {
        unsigned int cpu = smp_processor_id();
        const struct cpu_operations *ops = get_cpu_ops(cpu);