mmc: mediatek: Replace spin_lock_irqsave by spin_lock in hard IRQ
authorTian Tao <tiantao6@hisilicon.com>
Mon, 19 Oct 2020 00:43:13 +0000 (08:43 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 16 Nov 2020 10:59:28 +0000 (11:59 +0100)
The code has been in a irq-disabled context since it is hard IRQ. Therefore
there no need to do it again.

Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Link: https://lore.kernel.org/r/1603068193-44688-1-git-send-email-tiantao6@hisilicon.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/mtk-sd.c

index c7df751..f7f6862 100644 (file)
@@ -1548,13 +1548,12 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
        struct mmc_host *mmc = mmc_from_priv(host);
 
        while (true) {
-               unsigned long flags;
                struct mmc_request *mrq;
                struct mmc_command *cmd;
                struct mmc_data *data;
                u32 events, event_mask;
 
-               spin_lock_irqsave(&host->lock, flags);
+               spin_lock(&host->lock);
                events = readl(host->base + MSDC_INT);
                event_mask = readl(host->base + MSDC_INTEN);
                if ((events & event_mask) & MSDC_INT_SDIOIRQ)
@@ -1565,7 +1564,7 @@ static irqreturn_t msdc_irq(int irq, void *dev_id)
                mrq = host->mrq;
                cmd = host->cmd;
                data = host->data;
-               spin_unlock_irqrestore(&host->lock, flags);
+               spin_unlock(&host->lock);
 
                if ((events & event_mask) & MSDC_INT_SDIOIRQ)
                        sdio_signal_irq(mmc);