net: hns3: delete redundant PCI revision judgement
authorGuangbin Huang <huangguangbin2@huawei.com>
Sun, 27 Sep 2020 07:12:40 +0000 (15:12 +0800)
committerDavid S. Miller <davem@davemloft.net>
Sun, 27 Sep 2020 20:25:22 +0000 (13:25 -0700)
Fibre device of PCI revision 0x20 don't support autoneg, and the ops
get_autoneg() return AUTONEG_DISABLE so function hns3_nway_reset()
will return earlier than judging PCI revision.

Function hclge_handle_rocee_ras_error() don't need to judge PCI
revision again because its caller hclge_handle_hw_ras_error() has
judged once.

Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3_ethtool.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_err.c

index df28811..96b4d97 100644 (file)
@@ -1076,9 +1076,6 @@ static int hns3_nway_reset(struct net_device *netdev)
        if (phy)
                return genphy_restart_aneg(phy);
 
-       if (handle->pdev->revision == 0x20)
-               return -EOPNOTSUPP;
-
        return ops->restart_autoneg(handle);
 }
 
index 5d80efd..9ee55ee 100644 (file)
@@ -1577,8 +1577,7 @@ static void hclge_handle_rocee_ras_error(struct hnae3_ae_dev *ae_dev)
        struct hclge_dev *hdev = ae_dev->priv;
        enum hnae3_reset_type reset_type;
 
-       if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state) ||
-           hdev->pdev->revision < 0x21)
+       if (test_bit(HCLGE_STATE_RST_HANDLING, &hdev->state))
                return;
 
        reset_type = hclge_log_and_clear_rocee_ras_error(hdev);