crypto: arm64/aes-neonbs - add return value of skcipher_walk_done() in __xts_crypt()
authorYunfeng Ye <yeyunfeng@huawei.com>
Tue, 22 Oct 2019 08:11:18 +0000 (16:11 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 1 Nov 2019 05:33:42 +0000 (13:33 +0800)
A warning is found by the static code analysis tool:
  "Identical condition 'err', second condition is always false"

Fix this by adding return value of skcipher_walk_done().

Fixes: 67cfa5d3b721 ("crypto: arm64/aes-neonbs - implement ciphertext stealing for XTS")
Signed-off-by: Yunfeng Ye <yeyunfeng@huawei.com>
Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm64/crypto/aes-neonbs-glue.c

index ea873b8..e3e2734 100644 (file)
@@ -384,7 +384,7 @@ static int __xts_crypt(struct skcipher_request *req, bool encrypt,
                        goto xts_tail;
 
                kernel_neon_end();
-               skcipher_walk_done(&walk, nbytes);
+               err = skcipher_walk_done(&walk, nbytes);
        }
 
        if (err || likely(!tail))