spi: hisi-kunpeng: Fix Woverflow warning on conversion
authorJay Fang <f.fangjian@huawei.com>
Wed, 7 Apr 2021 02:31:00 +0000 (10:31 +0800)
committerMark Brown <broonie@kernel.org>
Wed, 7 Apr 2021 15:58:34 +0000 (16:58 +0100)
Fix warning Woverflow on type conversion reported on x86_64:

  drivers/spi/spi-hisi-kunpeng.c:361:9: warning: conversion from 'long unsigned int' to 'u32'
  {aka 'unsigned int'} changes value from '18446744073709551600' to '4294967280' [-Woverflow]

The registers are 32 bit, so fix by casting to u32.

Fixes: c770d8631e18 ("spi: Add HiSilicon SPI Controller Driver for Kunpeng SoCs")
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Jay Fang <f.fangjian@huawei.com>
Link: https://lore.kernel.org/r/1617762660-54681-1-git-send-email-f.fangjian@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-hisi-kunpeng.c

index abc0cd5..3f986ba 100644 (file)
@@ -358,7 +358,7 @@ static int hisi_spi_transfer_one(struct spi_controller *master,
        smp_mb();
 
        /* Enable all interrupts and the controller */
-       writel(~IMR_MASK, hs->regs + HISI_SPI_IMR);
+       writel(~(u32)IMR_MASK, hs->regs + HISI_SPI_IMR);
        writel(1, hs->regs + HISI_SPI_ENR);
 
        return 1;