mmc: core: Drop check for mmc_card_is_removable() in mmc_rescan()
authorUlf Hansson <ulf.hansson@linaro.org>
Thu, 10 Oct 2019 13:54:37 +0000 (15:54 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 14 Nov 2019 15:28:56 +0000 (16:28 +0100)
Upfront in mmc_rescan() we use the host->rescan_entered flag, to allow
scanning only once for non-removable cards. Therefore, it's also not
possible that we can have a corresponding card bus attached (host->bus_ops
is NULL), when we are scanning non-removable cards.

For this reason, let' drop the check for mmc_card_is_removable() as it's
redundant.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Tested-by: Douglas Anderson <dianders@chromium.org>
Cc: stable@vger.kernel.org # v5.4+
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/core.c

index 2211273..6f83427 100644 (file)
@@ -2297,11 +2297,8 @@ void mmc_rescan(struct work_struct *work)
 
        mmc_bus_get(host);
 
-       /*
-        * if there is a _removable_ card registered, check whether it is
-        * still present
-        */
-       if (host->bus_ops && !host->bus_dead && mmc_card_is_removable(host))
+       /* Verify a registered card to be functional, else remove it. */
+       if (host->bus_ops && !host->bus_dead)
                host->bus_ops->detect(host);
 
        host->detect_change = 0;