powerpc/sstep: Use bitwise instead of arithmetic operator for flags
authorYang Li <yang.lee@linux.alibaba.com>
Sat, 20 Feb 2021 08:57:35 +0000 (16:57 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 2 May 2022 13:02:15 +0000 (23:02 +1000)
Fix the following coccinelle warnings:
./arch/powerpc/lib/sstep.c:1090:20-21: WARNING: sum of probable
bitmasks, consider |
./arch/powerpc/lib/sstep.c:1115:20-21: WARNING: sum of probable
bitmasks, consider |
./arch/powerpc/lib/sstep.c:1134:20-21: WARNING: sum of probable
bitmasks, consider |

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/1613811455-2457-1-git-send-email-yang.lee@linux.alibaba.com
arch/powerpc/lib/sstep.c

index 6f79bde..72d4ce2 100644 (file)
@@ -1166,7 +1166,7 @@ static nokprobe_inline void add_with_carry(const struct pt_regs *regs,
 
        if (carry_in)
                ++val;
-       op->type = COMPUTE + SETREG + SETXER;
+       op->type = COMPUTE | SETREG | SETXER;
        op->reg = rd;
        op->val = val;
        val = truncate_if_32bit(regs->msr, val);
@@ -1187,7 +1187,7 @@ static nokprobe_inline void do_cmp_signed(const struct pt_regs *regs,
 {
        unsigned int crval, shift;
 
-       op->type = COMPUTE + SETCC;
+       op->type = COMPUTE | SETCC;
        crval = (regs->xer >> 31) & 1;          /* get SO bit */
        if (v1 < v2)
                crval |= 8;
@@ -1206,7 +1206,7 @@ static nokprobe_inline void do_cmp_unsigned(const struct pt_regs *regs,
 {
        unsigned int crval, shift;
 
-       op->type = COMPUTE + SETCC;
+       op->type = COMPUTE | SETCC;
        crval = (regs->xer >> 31) & 1;          /* get SO bit */
        if (v1 < v2)
                crval |= 8;