firmware: bcm47xx_nvram: look for NVRAM with for instead of while
authorRafał Miłecki <rafal@milecki.pl>
Mon, 8 Mar 2021 09:03:19 +0000 (10:03 +0100)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Fri, 12 Mar 2021 14:53:07 +0000 (15:53 +0100)
This loop requires variable initialization, stop condition and post
iteration increment. It's pretty much a for loop definition.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
drivers/firmware/broadcom/bcm47xx_nvram.c

index 09f51b9..1d2271b 100644 (file)
@@ -93,15 +93,13 @@ static int bcm47xx_nvram_find_and_copy(void __iomem *flash_start, size_t res_siz
        }
 
        /* TODO: when nvram is on nand flash check for bad blocks first. */
-       flash_size = FLASH_MIN;
-       while (flash_size <= res_size) {
+       for (flash_size = FLASH_MIN; flash_size <= res_size; flash_size <<= 1) {
                /* Windowed flash access */
                size = find_nvram_size(flash_start + flash_size);
                if (size) {
                        offset = flash_size - size;
                        goto found;
                }
-               flash_size <<= 1;
        }
 
        /* Try embedded NVRAM at 4 KB and 1 KB as last resorts */