net: dev: use kfree_skb_reason() for sch_handle_egress()
authorMenglong Dong <imagedong@tencent.com>
Fri, 4 Mar 2022 06:00:40 +0000 (14:00 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 4 Mar 2022 12:17:11 +0000 (12:17 +0000)
Replace kfree_skb() used in sch_handle_egress() with kfree_skb_reason().
The drop reason SKB_DROP_REASON_TC_EGRESS is introduced. Considering
the code path of tc egerss, we make it distinct with the drop reason
of SKB_DROP_REASON_QDISC_DROP in the next commit.

Signed-off-by: Menglong Dong <imagedong@tencent.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/skbuff.h
include/trace/events/skb.h
net/core/dev.c

index 5445860..1ffe646 100644 (file)
@@ -394,6 +394,7 @@ enum skb_drop_reason {
                                                 * entry is full
                                                 */
        SKB_DROP_REASON_NEIGH_DEAD,     /* neigh entry is dead */
+       SKB_DROP_REASON_TC_EGRESS,      /* dropped in TC egress HOOK */
        SKB_DROP_REASON_MAX,
 };
 
index 1977f30..53755e8 100644 (file)
@@ -45,6 +45,7 @@
        EM(SKB_DROP_REASON_NEIGH_FAILED, NEIGH_FAILED)          \
        EM(SKB_DROP_REASON_NEIGH_QUEUEFULL, NEIGH_QUEUEFULL)    \
        EM(SKB_DROP_REASON_NEIGH_DEAD, NEIGH_DEAD)              \
+       EM(SKB_DROP_REASON_TC_EGRESS, TC_EGRESS)                \
        EMe(SKB_DROP_REASON_MAX, MAX)
 
 #undef EM
index 96bcc00..ef0b199 100644 (file)
@@ -3889,7 +3889,7 @@ sch_handle_egress(struct sk_buff *skb, int *ret, struct net_device *dev)
        case TC_ACT_SHOT:
                mini_qdisc_qstats_cpu_drop(miniq);
                *ret = NET_XMIT_DROP;
-               kfree_skb(skb);
+               kfree_skb_reason(skb, SKB_DROP_REASON_TC_EGRESS);
                return NULL;
        case TC_ACT_STOLEN:
        case TC_ACT_QUEUED: