ide: remove set but not used variable 'hwif'
authorWang Hai <wanghai38@huawei.com>
Sat, 26 Oct 2019 01:57:38 +0000 (09:57 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 20 Jan 2020 12:38:26 +0000 (13:38 +0100)
Fix the following gcc warning:

drivers/ide/pmac.c: In function pmac_ide_setup_device:
drivers/ide/pmac.c:1027:14: warning: variable hwif set but not used
[-Wunused-but-set-variable]

Fixes: d58b0c39e32f ("powerpc/macio: Rework hotplug media bay support")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/pmac.c

index b5647e3..ea0b064 100644 (file)
@@ -1019,7 +1019,6 @@ static int pmac_ide_setup_device(pmac_ide_hwif_t *pmif, struct ide_hw *hw)
        struct device_node *np = pmif->node;
        const int *bidp;
        struct ide_host *host;
-       ide_hwif_t *hwif;
        struct ide_hw *hws[] = { hw };
        struct ide_port_info d = pmac_port_info;
        int rc;
@@ -1075,7 +1074,7 @@ static int pmac_ide_setup_device(pmac_ide_hwif_t *pmif, struct ide_hw *hw)
                rc = -ENOMEM;
                goto bail;
        }
-       hwif = pmif->hwif = host->ports[0];
+       pmif->hwif = host->ports[0];
 
        if (on_media_bay(pmif)) {
                /* Fixup bus ID for media bay */