IB/cma: use strlcpy() instead of strncpy()
authorXiongfeng Wang <xiongfeng.wang@linaro.org>
Fri, 12 Jan 2018 07:56:05 +0000 (15:56 +0800)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 15 Jan 2018 22:33:21 +0000 (15:33 -0700)
gcc-8 reports

drivers/infiniband/core/cma_configfs.c: In function 'make_cma_dev':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 64 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the string is nul-terminated.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/cma_configfs.c

index 31dfee0..eee38b4 100644 (file)
@@ -295,7 +295,7 @@ static struct config_group *make_cma_dev(struct config_group *group,
                goto fail;
        }
 
-       strncpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));
+       strlcpy(cma_dev_group->name, name, sizeof(cma_dev_group->name));
 
        config_group_init_type_name(&cma_dev_group->ports_group, "ports",
                                    &cma_ports_group_type);