IB/hfi1: Validate page aligned for a given virtual address
authorKamenee Arumugam <kamenee.arumugam@intel.com>
Fri, 24 May 2019 15:45:04 +0000 (11:45 -0400)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 29 May 2019 15:56:05 +0000 (12:56 -0300)
User applications can register memory regions for TID buffers that are not
aligned on page boundaries. Hfi1 is expected to pin those pages in memory
and cache the pages with mmu_rb. The rb tree will fail to insert pages
that are not aligned correctly.

Validate whether a given virtual address is page aligned before pinning.

Fixes: 7e7a436ecb6e ("staging/hfi1: Add TID entry program function body")
Reviewed-by: Michael J. Ruhl <michael.j.ruhl@intel.com>
Signed-off-by: Kamenee Arumugam <kamenee.arumugam@intel.com>
Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/hfi1/user_exp_rcv.c

index 0cd71ce..3592a9e 100644 (file)
@@ -324,6 +324,9 @@ int hfi1_user_exp_rcv_setup(struct hfi1_filedata *fd,
        u32 *tidlist = NULL;
        struct tid_user_buf *tidbuf;
 
+       if (!PAGE_ALIGNED(tinfo->vaddr))
+               return -EINVAL;
+
        tidbuf = kzalloc(sizeof(*tidbuf), GFP_KERNEL);
        if (!tidbuf)
                return -ENOMEM;