Bluetooth: Use sizeof(*pointer) instead of sizeof(type)
authorErick Archer <erick.archer@outlook.com>
Fri, 24 May 2024 17:11:51 +0000 (19:11 +0200)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Mon, 15 Jul 2024 01:34:28 +0000 (21:34 -0400)
It is preferred to use sizeof(*pointer) instead of sizeof(type)
due to the type of the variable can change and one needs not
change the former (unlike the latter). This patch has no effect
on runtime behavior.

Signed-off-by: Erick Archer <erick.archer@outlook.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btrtl.c
drivers/bluetooth/hci_ldisc.c
drivers/bluetooth/hci_qca.c
drivers/bluetooth/hci_vhci.c

index 4f1e37b..f2f3714 100644 (file)
@@ -811,7 +811,7 @@ static int rtl_download_firmware(struct hci_dev *hdev,
        struct sk_buff *skb;
        struct hci_rp_read_local_version *rp;
 
-       dl_cmd = kmalloc(sizeof(struct rtl_download_cmd), GFP_KERNEL);
+       dl_cmd = kmalloc(sizeof(*dl_cmd), GFP_KERNEL);
        if (!dl_cmd)
                return -ENOMEM;
 
index 17a2f15..30192bb 100644 (file)
@@ -488,7 +488,7 @@ static int hci_uart_tty_open(struct tty_struct *tty)
        if (tty->ops->write == NULL)
                return -EOPNOTSUPP;
 
-       hu = kzalloc(sizeof(struct hci_uart), GFP_KERNEL);
+       hu = kzalloc(sizeof(*hu), GFP_KERNEL);
        if (!hu) {
                BT_ERR("Can't allocate control structure");
                return -ENFILE;
index 9a0bc86..2f47267 100644 (file)
@@ -569,7 +569,7 @@ static int qca_open(struct hci_uart *hu)
        if (!hci_uart_has_flow_control(hu))
                return -EOPNOTSUPP;
 
-       qca = kzalloc(sizeof(struct qca_data), GFP_KERNEL);
+       qca = kzalloc(sizeof(*qca), GFP_KERNEL);
        if (!qca)
                return -ENOMEM;
 
@@ -1040,8 +1040,7 @@ static void qca_controller_memdump(struct work_struct *work)
                }
 
                if (!qca_memdump) {
-                       qca_memdump = kzalloc(sizeof(struct qca_memdump_info),
-                                             GFP_ATOMIC);
+                       qca_memdump = kzalloc(sizeof(*qca_memdump), GFP_ATOMIC);
                        if (!qca_memdump) {
                                mutex_unlock(&qca->hci_memdump_lock);
                                return;
index 28750a4..c4046f8 100644 (file)
@@ -633,7 +633,7 @@ static int vhci_open(struct inode *inode, struct file *file)
 {
        struct vhci_data *data;
 
-       data = kzalloc(sizeof(struct vhci_data), GFP_KERNEL);
+       data = kzalloc(sizeof(*data), GFP_KERNEL);
        if (!data)
                return -ENOMEM;