usb: typec: altmodes/displayport: Fix pin assignment calculation
authorPrashant Malani <pmalani@chromium.org>
Wed, 11 Jan 2023 02:05:42 +0000 (02:05 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 17 Jan 2023 16:07:25 +0000 (17:07 +0100)
Commit c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin
assignment for UFP receptacles") fixed the pin assignment calculation
to take into account whether the peripheral was a plug or a receptacle.

But the "pin_assignments" sysfs logic was not updated. Address this by
using the macros introduced in the aforementioned commit in the sysfs
logic too.

Fixes: c1e5c2f0cb8a ("usb: typec: altmodes/displayport: correct pin assignment for UFP receptacles")
Cc: stable@vger.kernel.org
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Prashant Malani <pmalani@chromium.org>
Reviewed-by: Benson Leung <bleung@chromium.org>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20230111020546.3384569-2-pmalani@chromium.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/typec/altmodes/displayport.c

index 5bc7a58..80d8c6c 100644 (file)
@@ -426,9 +426,9 @@ static const char * const pin_assignments[] = {
 static u8 get_current_pin_assignments(struct dp_altmode *dp)
 {
        if (DP_CONF_CURRENTLY(dp->data.conf) == DP_CONF_DFP_D)
-               return DP_CAP_UFP_D_PIN_ASSIGN(dp->alt->vdo);
+               return DP_CAP_PIN_ASSIGN_DFP_D(dp->alt->vdo);
        else
-               return DP_CAP_DFP_D_PIN_ASSIGN(dp->alt->vdo);
+               return DP_CAP_PIN_ASSIGN_UFP_D(dp->alt->vdo);
 }
 
 static ssize_t