f2fs: should put a page beyond EOF when preparing a write
authorJaegeuk Kim <jaegeuk@kernel.org>
Mon, 30 Aug 2021 20:30:45 +0000 (13:30 -0700)
committerJaegeuk Kim <jaegeuk@kernel.org>
Tue, 31 Aug 2021 21:39:39 +0000 (14:39 -0700)
The prepare_compress_overwrite() gets/locks a page to prepare a read, and calls
f2fs_read_multi_pages() which checks EOF first. If there's any page beyond EOF,
we unlock the page and set cc->rpages[i] = NULL, which we can't put the page
anymore. This makes page leak, so let's fix by putting that page.

Fixes: a949dc5f2c5c ("f2fs: compress: fix race condition of overwrite vs truncate")
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/data.c

index 8e88246..41d2938 100644 (file)
@@ -2183,6 +2183,8 @@ int f2fs_read_multi_pages(struct compress_ctx *cc, struct bio **bio_ret,
                        continue;
                }
                unlock_page(page);
+               if (for_write)
+                       put_page(page);
                cc->rpages[i] = NULL;
                cc->nr_rpages--;
        }