ubifs: Convert to use ERR_CAST()
authorShen Lichuan <shenlichuan@vivo.com>
Wed, 28 Aug 2024 08:59:08 +0000 (16:59 +0800)
committerRichard Weinberger <richard@nod.at>
Thu, 14 Nov 2024 16:58:45 +0000 (17:58 +0100)
As opposed to open-code, using the ERR_CAST macro clearly indicates that
this is a pointer to an error value and a type conversion was performed.

Signed-off-by: Shen Lichuan <shenlichuan@vivo.com>
Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
fs/ubifs/lpt_commit.c

index 07351fd..aa8837e 100644 (file)
@@ -577,7 +577,7 @@ static struct ubifs_pnode *next_pnode_to_dirty(struct ubifs_info *c,
        /* Go right */
        nnode = ubifs_get_nnode(c, nnode, iip);
        if (IS_ERR(nnode))
-               return (void *)nnode;
+               return ERR_CAST(nnode);
 
        /* Go down to level 1 */
        while (nnode->level > 1) {
@@ -594,7 +594,7 @@ static struct ubifs_pnode *next_pnode_to_dirty(struct ubifs_info *c,
                }
                nnode = ubifs_get_nnode(c, nnode, iip);
                if (IS_ERR(nnode))
-                       return (void *)nnode;
+                       return ERR_CAST(nnode);
        }
 
        for (iip = 0; iip < UBIFS_LPT_FANOUT; iip++)