mtd: rawnand: Add an indirection on onfi_fill_interface_config()
authorMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 5 May 2021 21:37:38 +0000 (23:37 +0200)
committerMiquel Raynal <miquel.raynal@bootlin.com>
Wed, 26 May 2021 08:43:48 +0000 (10:43 +0200)
This helper actually fills the interface configuration with SDR data.
As part of the work to bring NV-DDR support, let's rename this helper
onfi_fill_sdr_interface_config() and add a generic indirection to it.

There are no functional changes here, but this will simplify a next
change which adds onfi_fill_nvddr_interface_config() support.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20210505213750.257417-11-miquel.raynal@bootlin.com
drivers/mtd/nand/raw/nand_timings.c

index 481b56d..fb483e6 100644 (file)
@@ -601,23 +601,18 @@ onfi_find_closest_sdr_mode(const struct nand_sdr_timings *spec_timings)
 }
 
 /**
- * onfi_fill_interface_config - Initialize an interface config from a given
- *                              ONFI mode
+ * onfi_fill_sdr_interface_config - Initialize a SDR interface config from a
+ *                                  given ONFI mode
  * @chip: The NAND chip
  * @iface: The interface configuration to fill
- * @type: The interface type
  * @timing_mode: The ONFI timing mode
  */
-void onfi_fill_interface_config(struct nand_chip *chip,
-                               struct nand_interface_config *iface,
-                               enum nand_interface_type type,
-                               unsigned int timing_mode)
+static void onfi_fill_sdr_interface_config(struct nand_chip *chip,
+                                          struct nand_interface_config *iface,
+                                          unsigned int timing_mode)
 {
        struct onfi_params *onfi = chip->parameters.onfi;
 
-       if (WARN_ON(type != NAND_SDR_IFACE))
-               return;
-
        if (WARN_ON(timing_mode >= ARRAY_SIZE(onfi_sdr_timings)))
                return;
 
@@ -640,3 +635,20 @@ void onfi_fill_interface_config(struct nand_chip *chip,
                timings->tCCS_min = 1000UL * onfi->tCCS;
        }
 }
+
+/**
+ * onfi_fill_interface_config - Initialize an interface config from a given
+ *                              ONFI mode
+ * @chip: The NAND chip
+ * @iface: The interface configuration to fill
+ * @type: The interface type
+ * @timing_mode: The ONFI timing mode
+ */
+void onfi_fill_interface_config(struct nand_chip *chip,
+                               struct nand_interface_config *iface,
+                               enum nand_interface_type type,
+                               unsigned int timing_mode)
+{
+       if (type == NAND_SDR_IFACE)
+               return onfi_fill_sdr_interface_config(chip, iface, timing_mode);
+}