dmaengine: qcom: gpi: set chain and link flag for duplex
authorVinod Koul <vkoul@kernel.org>
Wed, 6 Apr 2022 13:25:06 +0000 (18:55 +0530)
committerVinod Koul <vkoul@kernel.org>
Wed, 13 Apr 2022 12:24:39 +0000 (17:54 +0530)
Newer platforms seem to have strict requirement for TRE flags which
causes transaction to timeout. This was resolved to missing chain and
link flag for duplex spi transaction.

So add these two flags.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Link: https://lore.kernel.org/r/20220406132508.1029348-1-vkoul@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/gpi.c

index 94f3648..3429cec 100644 (file)
@@ -1754,10 +1754,14 @@ static int gpi_create_spi_tre(struct gchan *chan, struct gpi_desc *desc,
                tre->dword[2] = u32_encode_bits(spi->rx_len, TRE_RX_LEN);
 
                tre->dword[3] = u32_encode_bits(TRE_TYPE_GO, TRE_FLAGS_TYPE);
-               if (spi->cmd == SPI_RX)
+               if (spi->cmd == SPI_RX) {
                        tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_IEOB);
-               else
+               } else if (spi->cmd == SPI_TX) {
+                       tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_CHAIN);
+               } else { /* SPI_DUPLEX */
                        tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_CHAIN);
+                       tre->dword[3] |= u32_encode_bits(1, TRE_FLAGS_LINK);
+               }
        }
 
        /* create the dma tre */