ext4: standardize error message in ext4_protect_reserved_inode()
authorJan Kara <jack@suse.cz>
Fri, 27 Nov 2020 11:33:56 +0000 (12:33 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 17 Dec 2020 18:30:55 +0000 (13:30 -0500)
We use __ext4_error() when ext4_protect_reserved_inode() finds
filesystem corruption. However EXT4_ERROR_INODE_ERR() is perfectly
capable of reporting all the needed information. So just use that.

Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201127113405.26867-4-jack@suse.cz
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/block_validity.c

index c13422a..4666b55 100644 (file)
@@ -176,12 +176,10 @@ static int ext4_protect_reserved_inode(struct super_block *sb,
                        err = add_system_zone(system_blks, map.m_pblk, n, ino);
                        if (err < 0) {
                                if (err == -EFSCORRUPTED) {
-                                       __ext4_error(sb, __func__, __LINE__,
-                                                    -err, map.m_pblk,
-                                                    "blocks %llu-%llu from inode %u overlap system zone",
-                                                    map.m_pblk,
-                                                    map.m_pblk + map.m_len - 1,
-                                                    ino);
+                                       EXT4_ERROR_INODE_ERR(inode, -err,
+                                               "blocks %llu-%llu from inode overlap system zone",
+                                               map.m_pblk,
+                                               map.m_pblk + map.m_len - 1);
                                }
                                break;
                        }