net: enetc: Annotate struct enetc_psfp_gate with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:28:53 +0000 (10:28 -0700)
committerJakub Kicinski <kuba@kernel.org>
Mon, 2 Oct 2023 18:24:55 +0000 (11:24 -0700)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct enetc_psfp_gate.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20230922172858.3822653-11-keescook@chromium.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/enetc/enetc_qos.c

index 2513b44..b65da49 100644 (file)
@@ -443,7 +443,7 @@ struct enetc_psfp_gate {
        u32 num_entries;
        refcount_t refcount;
        struct hlist_node node;
-       struct action_gate_entry entries[];
+       struct action_gate_entry entries[] __counted_by(num_entries);
 };
 
 /* Only enable the green color frame now