r8169: enable PLL power-down for chip versions 34, 35, 36, 42
authorHeiner Kallweit <hkallweit1@gmail.com>
Sun, 10 Jan 2021 19:48:40 +0000 (20:48 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Jan 2021 01:01:17 +0000 (17:01 -0800)
There's no known reason why PLL powerdown on D3 shouldn't be enabled
on chip versions 34, 35, 36, and 42. At least the vendor driver doesn't
exclude any of these chip versions.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index dbf0c29..9c87fb9 100644 (file)
@@ -2226,10 +2226,8 @@ static void rtl_pll_power_down(struct rtl8169_private *tp)
 
        switch (tp->mac_version) {
        case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26:
-       case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33:
-       case RTL_GIGA_MAC_VER_37:
-       case RTL_GIGA_MAC_VER_39 ... RTL_GIGA_MAC_VER_41:
-       case RTL_GIGA_MAC_VER_43 ... RTL_GIGA_MAC_VER_63:
+       case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_37:
+       case RTL_GIGA_MAC_VER_39 ... RTL_GIGA_MAC_VER_63:
                RTL_W8(tp, PMCH, RTL_R8(tp, PMCH) & ~0x80);
                break;
        default:
@@ -2241,13 +2239,12 @@ static void rtl_pll_power_up(struct rtl8169_private *tp)
 {
        switch (tp->mac_version) {
        case RTL_GIGA_MAC_VER_25 ... RTL_GIGA_MAC_VER_26:
-       case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_33:
-       case RTL_GIGA_MAC_VER_37:
+       case RTL_GIGA_MAC_VER_32 ... RTL_GIGA_MAC_VER_37:
        case RTL_GIGA_MAC_VER_39:
        case RTL_GIGA_MAC_VER_43:
                RTL_W8(tp, PMCH, RTL_R8(tp, PMCH) | 0x80);
                break;
-       case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_41:
+       case RTL_GIGA_MAC_VER_40 ... RTL_GIGA_MAC_VER_42:
        case RTL_GIGA_MAC_VER_44 ... RTL_GIGA_MAC_VER_63:
                RTL_W8(tp, PMCH, RTL_R8(tp, PMCH) | 0xc0);
                break;