net: davicom: Remove redundant assignment to ret
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Sun, 25 Apr 2021 10:42:56 +0000 (18:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 26 Apr 2021 19:48:30 +0000 (12:48 -0700)
Variable ret is set to zero but this value is never read as it is
overwritten with a new value later on, hence it is a redundant
assignment and can be removed.

Cleans up the following clang-analyzer warning:

drivers/net/ethernet/davicom/dm9000.c:1527:5: warning: Value stored to
'ret' is never read [clang-analyzer-deadcode.DeadStores].

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/davicom/dm9000.c

index e7f7121..2a8bf53 100644 (file)
@@ -1522,7 +1522,6 @@ dm9000_probe(struct platform_device *pdev)
                        if (ret) {
                                dev_err(db->dev, "irq %d cannot set wakeup (%d)\n",
                                        db->irq_wake, ret);
-                               ret = 0;
                        } else {
                                irq_set_irq_wake(db->irq_wake, 0);
                                db->wake_supported = 1;