clocksource/drivers/timer-tegra186: Avoid 64-bit divide operation
authorGuenter Roeck <linux@roeck-us.net>
Sat, 14 Jun 2025 17:55:55 +0000 (10:55 -0700)
committerDaniel Lezcano <daniel.lezcano@linaro.org>
Tue, 23 Sep 2025 08:54:29 +0000 (10:54 +0200)
Building the driver on xtensa fails with

tensa-linux-ld: drivers/clocksource/timer-tegra186.o:
in function `tegra186_timer_remove':
timer-tegra186.c:(.text+0x350):
undefined reference to `__udivdi3'

Avoid the problem by rearranging the offending code to avoid the 64-bit
divide operation.

Fixes: 28c842c8b0f5 ("clocksource/drivers/timer-tegra186: Add WDIOC_GETTIMELEFT support")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Jon Hunter <jonathanh@nvidia.com>
Cc: Pohsun Su <pohsuns@nvidia.com>
Cc: Robert Lin <robelin@nvidia.com>
Link: https://lore.kernel.org/r/20250614175556.922159-1-linux@roeck-us.net
drivers/clocksource/timer-tegra186.c

index 56a5342..76a5481 100644 (file)
@@ -267,7 +267,7 @@ static unsigned int tegra186_wdt_get_timeleft(struct watchdog_device *wdd)
         * counter value to the time of the counter expirations that
         * remain.
         */
-       timeleft += (((u64)wdt->base.timeout * USEC_PER_SEC) / 5) * (4 - expiration);
+       timeleft += ((u64)wdt->base.timeout * (USEC_PER_SEC / 5)) * (4 - expiration);
 
        /*
         * Convert the current counter value to seconds,